blob: 8023ef6e753dac992072d1029719c34fb2f4cb8b [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
Clint Byrum03454a52017-05-26 17:14:02 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Monty Taylorbc758832013-06-17 17:22:42 -040028import testtools
Monty Taylorb934c1a2017-06-16 19:31:47 -050029import urllib
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
Clint Byrumb9de8be2017-05-27 13:49:19 -070032from zuul.driver.gerrit import gerritreporter
James E. Blairb0fcae42012-07-17 11:12:10 -070033import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080034import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040035import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070036
Maru Newby3fe5f852015-01-13 04:22:14 +000037from tests.base import (
Paul Belanger0a21f0a2017-06-13 13:14:42 -040038 SSLZuulTestCase,
Maru Newby3fe5f852015-01-13 04:22:14 +000039 ZuulTestCase,
40 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070041 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000042)
James E. Blairb0fcae42012-07-17 11:12:10 -070043
James E. Blairb0fcae42012-07-17 11:12:10 -070044
Paul Belanger0a21f0a2017-06-13 13:14:42 -040045class TestSchedulerSSL(SSLZuulTestCase):
46 tenant_config_file = 'config/single-tenant/main.yaml'
47
48 def test_jobs_executed(self):
49 "Test that jobs are executed and a change is merged"
Paul Belanger0a21f0a2017-06-13 13:14:42 -040050 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +020051 A.addApproval('Code-Review', 2)
52 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Paul Belanger0a21f0a2017-06-13 13:14:42 -040053 self.waitUntilSettled()
54 self.assertEqual(self.getJobFromHistory('project-merge').result,
55 'SUCCESS')
56 self.assertEqual(self.getJobFromHistory('project-test1').result,
57 'SUCCESS')
58 self.assertEqual(self.getJobFromHistory('project-test2').result,
59 'SUCCESS')
60 self.assertEqual(A.data['status'], 'MERGED')
61 self.assertEqual(A.reported, 2)
62 self.assertEqual(self.getJobFromHistory('project-test1').node,
63 'label1')
James E. Blairfcbf95d2017-07-25 16:38:09 -070064 self.assertEqual(self.getJobFromHistory('project-test2').node,
65 'label1')
Paul Belanger0a21f0a2017-06-13 13:14:42 -040066
67
Clark Boylanb640e052014-04-03 16:41:46 -070068class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070069 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010070
Paul Belanger174a8272017-03-14 13:20:10 -040071 def test_jobs_executed(self):
72 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070073
James E. Blairb0fcae42012-07-17 11:12:10 -070074 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +020075 A.addApproval('Code-Review', 2)
76 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070077 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040078 self.assertEqual(self.getJobFromHistory('project-merge').result,
79 'SUCCESS')
80 self.assertEqual(self.getJobFromHistory('project-test1').result,
81 'SUCCESS')
82 self.assertEqual(self.getJobFromHistory('project-test2').result,
83 'SUCCESS')
84 self.assertEqual(A.data['status'], 'MERGED')
85 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070086 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -070087 'label1')
James E. Blairfcbf95d2017-07-25 16:38:09 -070088 self.assertEqual(self.getJobFromHistory('project-test2').node,
89 'label1')
James E. Blairb0fcae42012-07-17 11:12:10 -070090
James E. Blair80ac1582017-10-09 07:02:40 -070091 for stat in self.statsd.stats:
92 k, v = stat.decode('utf-8').split(':')
93 self.log.debug('stat %s:%s', k, v)
James E. Blair552b54f2016-07-22 13:55:32 -070094 # TODOv3(jeblair): we may want to report stats by tenant (also?).
Monty Taylorf1385042017-05-27 12:25:05 -050095 # Per-driver
96 self.assertReportedStat('zuul.event.gerrit.comment-added', value='1|c')
97 # Per-driver per-connection
98 self.assertReportedStat('zuul.event.gerrit.gerrit.comment-added',
99 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -0700100 self.assertReportedStat(
James E. Blair80ac1582017-10-09 07:02:40 -0700101 'zuul.tenant.tenant-one.pipeline.gate.current_changes',
102 value='1|g')
James E. Blair412e5582013-04-22 15:50:12 -0700103 self.assertReportedStat(
James E. Blair80ac1582017-10-09 07:02:40 -0700104 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
105 'org_project.master.job.project-merge.SUCCESS', kind='ms')
106 self.assertReportedStat(
107 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
108 'org_project.master.job.project-merge.SUCCESS', value='1|c')
109 self.assertReportedStat(
110 'zuul.tenant.tenant-one.pipeline.gate.resident_time', kind='ms')
111 self.assertReportedStat(
112 'zuul.tenant.tenant-one.pipeline.gate.total_changes', value='1|c')
113 self.assertReportedStat(
114 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
115 'org_project.master.resident_time', kind='ms')
116 self.assertReportedStat(
117 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
118 'org_project.master.total_changes', value='1|c')
James E. Blairfaf81982017-10-10 15:42:26 -0700119 exec_key = 'zuul.executor.%s' % self.executor_server.hostname
120 self.assertReportedStat(exec_key + '.builds', value='1|c')
James E. Blair4f1731b2017-10-10 18:11:42 -0700121 self.assertReportedStat('zuul.nodepool.requested', value='1|c')
122 self.assertReportedStat('zuul.nodepool.requested.label.label1',
123 value='1|c')
124 self.assertReportedStat('zuul.nodepool.fulfilled.label.label1',
125 value='1|c')
126 self.assertReportedStat('zuul.nodepool.requested.size.1', value='1|c')
127 self.assertReportedStat('zuul.nodepool.fulfilled.size.1', value='1|c')
128 self.assertReportedStat('zuul.nodepool.current_requests', value='1|g')
James E. Blairbdd50e62017-10-21 08:18:55 -0700129 self.assertReportedStat('zuul.executors.online', value='1|g')
130 self.assertReportedStat('zuul.executors.accepting', value='1|g')
131 self.assertReportedStat('zuul.mergers.online', value='1|g')
James E. Blair412e5582013-04-22 15:50:12 -0700132
James E. Blair2ef29e92017-07-21 15:25:05 -0700133 for build in self.history:
134 self.assertTrue(build.parameters['zuul']['voting'])
James E. Blair5821bd92015-09-16 08:48:15 -0700135
James E. Blair3cb10702013-08-24 08:56:03 -0700136 def test_initial_pipeline_gauges(self):
137 "Test that each pipeline reported its length on start"
James E. Blair57bf14d2017-10-21 09:09:48 -0700138 self.assertReportedStat('zuul.tenant.tenant-one.pipeline.gate.'
139 'current_changes',
James E. Blair7da51b72016-07-25 15:29:43 -0700140 value='0|g')
James E. Blair57bf14d2017-10-21 09:09:48 -0700141 self.assertReportedStat('zuul.tenant.tenant-one.pipeline.check.'
142 'current_changes',
James E. Blair7da51b72016-07-25 15:29:43 -0700143 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -0700144
James E. Blair34776ee2016-08-25 13:53:54 -0700145 def test_job_branch(self):
146 "Test the correct variant of a job runs on a branch"
147 self.create_branch('org/project', 'stable')
148 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200149 A.addApproval('Code-Review', 2)
150 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair34776ee2016-08-25 13:53:54 -0700151 self.waitUntilSettled()
152 self.assertEqual(self.getJobFromHistory('project-test1').result,
153 'SUCCESS')
154 self.assertEqual(self.getJobFromHistory('project-test2').result,
155 'SUCCESS')
156 self.assertEqual(A.data['status'], 'MERGED')
157 self.assertEqual(A.reported, 2,
158 "A should report start and success")
159 self.assertIn('gate', A.messages[1],
160 "A should transit gate")
161 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -0700162 'label2')
James E. Blair34776ee2016-08-25 13:53:54 -0700163
James E. Blairb0fcae42012-07-17 11:12:10 -0700164 def test_parallel_changes(self):
165 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700166
Paul Belanger174a8272017-03-14 13:20:10 -0400167 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700168 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
169 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
170 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200171 A.addApproval('Code-Review', 2)
172 B.addApproval('Code-Review', 2)
173 C.addApproval('Code-Review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700174
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200175 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
176 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
177 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700178
179 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400180 self.assertEqual(len(self.builds), 1)
181 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700182 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700183
Paul Belanger174a8272017-03-14 13:20:10 -0400184 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700185 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400186 self.assertEqual(len(self.builds), 3)
187 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700188 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400189 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700190 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400191 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700192 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700193
Paul Belanger174a8272017-03-14 13:20:10 -0400194 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700195 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400196 self.assertEqual(len(self.builds), 5)
197 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700198 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400199 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700200 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700201
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400202 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700203 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400204 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700205 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700206
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400207 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700208 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700209
Paul Belanger174a8272017-03-14 13:20:10 -0400210 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700211 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400212 self.assertEqual(len(self.builds), 6)
213 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700214 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400215 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700216 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700217
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400218 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700219 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400220 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700221 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700222
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400223 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700224 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400225 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700226 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700227
Paul Belanger174a8272017-03-14 13:20:10 -0400228 self.executor_server.hold_jobs_in_build = False
229 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700230 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400231 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700232
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400233 self.assertEqual(len(self.history), 9)
234 self.assertEqual(A.data['status'], 'MERGED')
235 self.assertEqual(B.data['status'], 'MERGED')
236 self.assertEqual(C.data['status'], 'MERGED')
237 self.assertEqual(A.reported, 2)
238 self.assertEqual(B.reported, 2)
239 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700240
241 def test_failed_changes(self):
242 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400243 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700244
James E. Blairb02a3bb2012-07-30 17:49:55 -0700245 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
246 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200247 A.addApproval('Code-Review', 2)
248 B.addApproval('Code-Review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700249
Paul Belanger174a8272017-03-14 13:20:10 -0400250 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700251
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200252 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
253 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700254 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700255 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400256
Paul Belanger174a8272017-03-14 13:20:10 -0400257 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400258 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700259 # A/project-merge is complete
260 self.assertBuilds([
261 dict(name='project-test1', changes='1,1'),
262 dict(name='project-test2', changes='1,1'),
263 dict(name='project-merge', changes='1,1 2,1'),
264 ])
James E. Blaire2819012013-06-28 17:17:26 -0400265
Paul Belanger174a8272017-03-14 13:20:10 -0400266 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400267 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700268 # A/project-merge is complete
269 # B/project-merge is complete
270 self.assertBuilds([
271 dict(name='project-test1', changes='1,1'),
272 dict(name='project-test2', changes='1,1'),
273 dict(name='project-test1', changes='1,1 2,1'),
274 dict(name='project-test2', changes='1,1 2,1'),
275 ])
276
277 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400278 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700279 self.builds[0].release()
280 self.waitUntilSettled()
281
282 self.orderedRelease()
283 self.assertHistory([
284 dict(name='project-merge', result='SUCCESS', changes='1,1'),
285 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
286 dict(name='project-test1', result='FAILURE', changes='1,1'),
287 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
288 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
289 dict(name='project-test2', result='SUCCESS', changes='1,1'),
290 dict(name='project-merge', result='SUCCESS', changes='2,1'),
291 dict(name='project-test1', result='SUCCESS', changes='2,1'),
292 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700293 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700294
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400295 self.assertEqual(A.data['status'], 'NEW')
296 self.assertEqual(B.data['status'], 'MERGED')
297 self.assertEqual(A.reported, 2)
298 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700299
300 def test_independent_queues(self):
301 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700302
Paul Belanger174a8272017-03-14 13:20:10 -0400303 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900304 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700305 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
306 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200307 A.addApproval('Code-Review', 2)
308 B.addApproval('Code-Review', 2)
309 C.addApproval('Code-Review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700310
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200311 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800312 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700313
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200314 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800315 self.waitUntilSettled()
316
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200317 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700318 self.waitUntilSettled()
319
320 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700321 self.assertBuilds([
322 dict(name='project-merge', changes='1,1'),
323 dict(name='project-merge', changes='2,1'),
324 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700325
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700326 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700327 self.builds[0].release()
328 self.waitUntilSettled()
329 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700330 self.waitUntilSettled()
331 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400332 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700333 self.waitUntilSettled()
334
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700335 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700336 self.assertBuilds([
337 dict(name='project-test1', changes='1,1'),
338 dict(name='project-test2', changes='1,1'),
339 dict(name='project-test1', changes='2,1'),
340 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500341 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700342 dict(name='project-test1', changes='2,1 3,1'),
343 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800344 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700345 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700346
James E. Blair5f0d49e2016-08-19 09:36:50 -0700347 self.orderedRelease()
348 self.assertHistory([
349 dict(name='project-merge', result='SUCCESS', changes='1,1'),
350 dict(name='project-merge', result='SUCCESS', changes='2,1'),
351 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
352 dict(name='project-test1', result='SUCCESS', changes='1,1'),
353 dict(name='project-test2', result='SUCCESS', changes='1,1'),
354 dict(name='project-test1', result='SUCCESS', changes='2,1'),
355 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500356 dict(
357 name='project1-project2-integration',
358 result='SUCCESS',
359 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700360 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
361 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800362 dict(name='project1-project2-integration',
363 result='SUCCESS',
364 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700365 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700366
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400367 self.assertEqual(A.data['status'], 'MERGED')
368 self.assertEqual(B.data['status'], 'MERGED')
369 self.assertEqual(C.data['status'], 'MERGED')
370 self.assertEqual(A.reported, 2)
371 self.assertEqual(B.reported, 2)
372 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700373
374 def test_failed_change_at_head(self):
375 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700376
Paul Belanger174a8272017-03-14 13:20:10 -0400377 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700378 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
379 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
380 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200381 A.addApproval('Code-Review', 2)
382 B.addApproval('Code-Review', 2)
383 C.addApproval('Code-Review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700384
Paul Belanger174a8272017-03-14 13:20:10 -0400385 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700386
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200387 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
388 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
389 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700390
391 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700392
James E. Blairb536ecc2016-08-31 10:11:42 -0700393 self.assertBuilds([
394 dict(name='project-merge', changes='1,1'),
395 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700396
Paul Belanger174a8272017-03-14 13:20:10 -0400397 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700398 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400399 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700400 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400401 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700402 self.waitUntilSettled()
403
James E. Blairb536ecc2016-08-31 10:11:42 -0700404 self.assertBuilds([
405 dict(name='project-test1', changes='1,1'),
406 dict(name='project-test2', changes='1,1'),
407 dict(name='project-test1', changes='1,1 2,1'),
408 dict(name='project-test2', changes='1,1 2,1'),
409 dict(name='project-test1', changes='1,1 2,1 3,1'),
410 dict(name='project-test2', changes='1,1 2,1 3,1'),
411 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700412
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400413 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700414 self.waitUntilSettled()
415
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400416 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700417 self.assertBuilds([
418 dict(name='project-test2', changes='1,1'),
419 dict(name='project-merge', changes='2,1'),
420 ])
421 # Unordered history comparison because the aborts can finish
422 # in any order.
423 self.assertHistory([
424 dict(name='project-merge', result='SUCCESS',
425 changes='1,1'),
426 dict(name='project-merge', result='SUCCESS',
427 changes='1,1 2,1'),
428 dict(name='project-merge', result='SUCCESS',
429 changes='1,1 2,1 3,1'),
430 dict(name='project-test1', result='FAILURE',
431 changes='1,1'),
432 dict(name='project-test1', result='ABORTED',
433 changes='1,1 2,1'),
434 dict(name='project-test2', result='ABORTED',
435 changes='1,1 2,1'),
436 dict(name='project-test1', result='ABORTED',
437 changes='1,1 2,1 3,1'),
438 dict(name='project-test2', result='ABORTED',
439 changes='1,1 2,1 3,1'),
440 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700441
Paul Belanger174a8272017-03-14 13:20:10 -0400442 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700443 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400444 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700445 self.waitUntilSettled()
446 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700447
James E. Blairb536ecc2016-08-31 10:11:42 -0700448 self.assertBuilds([])
449 self.assertHistory([
450 dict(name='project-merge', result='SUCCESS',
451 changes='1,1'),
452 dict(name='project-merge', result='SUCCESS',
453 changes='1,1 2,1'),
454 dict(name='project-merge', result='SUCCESS',
455 changes='1,1 2,1 3,1'),
456 dict(name='project-test1', result='FAILURE',
457 changes='1,1'),
458 dict(name='project-test1', result='ABORTED',
459 changes='1,1 2,1'),
460 dict(name='project-test2', result='ABORTED',
461 changes='1,1 2,1'),
462 dict(name='project-test1', result='ABORTED',
463 changes='1,1 2,1 3,1'),
464 dict(name='project-test2', result='ABORTED',
465 changes='1,1 2,1 3,1'),
466 dict(name='project-merge', result='SUCCESS',
467 changes='2,1'),
468 dict(name='project-merge', result='SUCCESS',
469 changes='2,1 3,1'),
470 dict(name='project-test2', result='SUCCESS',
471 changes='1,1'),
472 dict(name='project-test1', result='SUCCESS',
473 changes='2,1'),
474 dict(name='project-test2', result='SUCCESS',
475 changes='2,1'),
476 dict(name='project-test1', result='SUCCESS',
477 changes='2,1 3,1'),
478 dict(name='project-test2', result='SUCCESS',
479 changes='2,1 3,1'),
480 ], ordered=False)
481
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400482 self.assertEqual(A.data['status'], 'NEW')
483 self.assertEqual(B.data['status'], 'MERGED')
484 self.assertEqual(C.data['status'], 'MERGED')
485 self.assertEqual(A.reported, 2)
486 self.assertEqual(B.reported, 2)
487 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700488
James E. Blair0aac4872013-08-23 14:02:38 -0700489 def test_failed_change_in_middle(self):
490 "Test a failed change in the middle of the queue"
491
Paul Belanger174a8272017-03-14 13:20:10 -0400492 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700493 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
494 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
495 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200496 A.addApproval('Code-Review', 2)
497 B.addApproval('Code-Review', 2)
498 C.addApproval('Code-Review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700499
Paul Belanger174a8272017-03-14 13:20:10 -0400500 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700501
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200502 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
503 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
504 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700505
506 self.waitUntilSettled()
507
Paul Belanger174a8272017-03-14 13:20:10 -0400508 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700509 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400510 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700511 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400512 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700513 self.waitUntilSettled()
514
515 self.assertEqual(len(self.builds), 6)
516 self.assertEqual(self.builds[0].name, 'project-test1')
517 self.assertEqual(self.builds[1].name, 'project-test2')
518 self.assertEqual(self.builds[2].name, 'project-test1')
519 self.assertEqual(self.builds[3].name, 'project-test2')
520 self.assertEqual(self.builds[4].name, 'project-test1')
521 self.assertEqual(self.builds[5].name, 'project-test2')
522
523 self.release(self.builds[2])
524 self.waitUntilSettled()
525
James E. Blair972e3c72013-08-29 12:04:55 -0700526 # project-test1 and project-test2 for A
527 # project-test2 for B
528 # project-merge for C (without B)
529 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700530 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
531
Paul Belanger174a8272017-03-14 13:20:10 -0400532 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700533 self.waitUntilSettled()
534
535 # project-test1 and project-test2 for A
536 # project-test2 for B
537 # project-test1 and project-test2 for C
538 self.assertEqual(len(self.builds), 5)
539
Paul Belanger2e2a0492016-10-30 18:33:37 -0400540 tenant = self.sched.abide.tenants.get('tenant-one')
541 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700542 builds = items[0].current_build_set.getBuilds()
543 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
544 self.assertEqual(self.countJobResults(builds, None), 2)
545 builds = items[1].current_build_set.getBuilds()
546 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
547 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
548 self.assertEqual(self.countJobResults(builds, None), 1)
549 builds = items[2].current_build_set.getBuilds()
550 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700551 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700552
Paul Belanger174a8272017-03-14 13:20:10 -0400553 self.executor_server.hold_jobs_in_build = False
554 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700555 self.waitUntilSettled()
556
557 self.assertEqual(len(self.builds), 0)
558 self.assertEqual(len(self.history), 12)
559 self.assertEqual(A.data['status'], 'MERGED')
560 self.assertEqual(B.data['status'], 'NEW')
561 self.assertEqual(C.data['status'], 'MERGED')
562 self.assertEqual(A.reported, 2)
563 self.assertEqual(B.reported, 2)
564 self.assertEqual(C.reported, 2)
565
James E. Blaird466dc42012-07-31 10:42:56 -0700566 def test_failed_change_at_head_with_queue(self):
567 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700568
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700569 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700570 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
571 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
572 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200573 A.addApproval('Code-Review', 2)
574 B.addApproval('Code-Review', 2)
575 C.addApproval('Code-Review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700576
Paul Belanger174a8272017-03-14 13:20:10 -0400577 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700578
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200579 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
580 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
581 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700582
583 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700584 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400585 self.assertEqual(len(self.builds), 0)
586 self.assertEqual(len(queue), 1)
Clint Byrumf322fe22017-05-10 20:53:12 -0700587 self.assertEqual(queue[0].name, b'executor:execute')
588 job_args = json.loads(queue[0].arguments.decode('utf8'))
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800589 self.assertEqual(job_args['job'], 'project-merge')
590 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700591
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700592 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700593 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700594 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700595 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700596 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700597 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700598 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700599
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400600 self.assertEqual(len(self.builds), 0)
601 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800602
603 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700604 json.loads(queue[0].arguments.decode('utf8'))['job'],
605 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800606 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700607 json.loads(queue[1].arguments.decode('utf8'))['job'],
608 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800609 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700610 json.loads(queue[2].arguments.decode('utf8'))['job'],
611 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800612 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700613 json.loads(queue[3].arguments.decode('utf8'))['job'],
614 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800615 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700616 json.loads(queue[4].arguments.decode('utf8'))['job'],
617 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800618 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700619 json.loads(queue[5].arguments.decode('utf8'))['job'],
620 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700621
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700622 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700623 self.waitUntilSettled()
624
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400625 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700626 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400627 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
628 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700629
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700630 self.gearman_server.hold_jobs_in_queue = False
631 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700632 self.waitUntilSettled()
633
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400634 self.assertEqual(len(self.builds), 0)
635 self.assertEqual(len(self.history), 11)
636 self.assertEqual(A.data['status'], 'NEW')
637 self.assertEqual(B.data['status'], 'MERGED')
638 self.assertEqual(C.data['status'], 'MERGED')
639 self.assertEqual(A.reported, 2)
640 self.assertEqual(B.reported, 2)
641 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700642
James E. Blairce8a2132016-05-19 15:21:52 -0700643 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400644 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700645 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200646 A.addApproval('Code-Review', 2)
647 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700648 self.waitUntilSettled()
649 time.sleep(2)
650
James E. Blairae0f23c2017-09-13 10:55:15 -0600651 data = json.loads(self.sched.formatStatusJSON('tenant-one'))
James E. Blairce8a2132016-05-19 15:21:52 -0700652 found_job = None
653 for pipeline in data['pipelines']:
654 if pipeline['name'] != 'gate':
655 continue
656 for queue in pipeline['change_queues']:
657 for head in queue['heads']:
658 for item in head:
659 for job in item['jobs']:
660 if job['name'] == 'project-merge':
661 found_job = job
662 break
663
664 self.assertIsNotNone(found_job)
665 if iteration == 1:
666 self.assertIsNotNone(found_job['estimated_time'])
667 self.assertIsNone(found_job['remaining_time'])
668 else:
669 self.assertIsNotNone(found_job['estimated_time'])
670 self.assertTrue(found_job['estimated_time'] >= 2)
671 self.assertIsNotNone(found_job['remaining_time'])
672
Paul Belanger174a8272017-03-14 13:20:10 -0400673 self.executor_server.hold_jobs_in_build = False
674 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700675 self.waitUntilSettled()
676
677 def test_time_database(self):
678 "Test the time database"
679
680 self._test_time_database(1)
681 self._test_time_database(2)
682
James E. Blairfef71632013-09-23 11:15:47 -0700683 def test_two_failed_changes_at_head(self):
684 "Test that changes are reparented correctly if 2 fail at head"
685
Paul Belanger174a8272017-03-14 13:20:10 -0400686 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700687 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
688 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
689 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200690 A.addApproval('Code-Review', 2)
691 B.addApproval('Code-Review', 2)
692 C.addApproval('Code-Review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700693
Paul Belanger174a8272017-03-14 13:20:10 -0400694 self.executor_server.failJob('project-test1', A)
695 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700696
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200697 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
698 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
699 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700700 self.waitUntilSettled()
701
Paul Belanger174a8272017-03-14 13:20:10 -0400702 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700703 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400704 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700705 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400706 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700707 self.waitUntilSettled()
708
709 self.assertEqual(len(self.builds), 6)
710 self.assertEqual(self.builds[0].name, 'project-test1')
711 self.assertEqual(self.builds[1].name, 'project-test2')
712 self.assertEqual(self.builds[2].name, 'project-test1')
713 self.assertEqual(self.builds[3].name, 'project-test2')
714 self.assertEqual(self.builds[4].name, 'project-test1')
715 self.assertEqual(self.builds[5].name, 'project-test2')
716
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400717 self.assertTrue(self.builds[0].hasChanges(A))
718 self.assertTrue(self.builds[2].hasChanges(A))
719 self.assertTrue(self.builds[2].hasChanges(B))
720 self.assertTrue(self.builds[4].hasChanges(A))
721 self.assertTrue(self.builds[4].hasChanges(B))
722 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700723
724 # Fail change B first
725 self.release(self.builds[2])
726 self.waitUntilSettled()
727
728 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400729 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700730 self.waitUntilSettled()
731
732 self.assertEqual(len(self.builds), 5)
733 self.assertEqual(self.builds[0].name, 'project-test1')
734 self.assertEqual(self.builds[1].name, 'project-test2')
735 self.assertEqual(self.builds[2].name, 'project-test2')
736 self.assertEqual(self.builds[3].name, 'project-test1')
737 self.assertEqual(self.builds[4].name, 'project-test2')
738
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400739 self.assertTrue(self.builds[1].hasChanges(A))
740 self.assertTrue(self.builds[2].hasChanges(A))
741 self.assertTrue(self.builds[2].hasChanges(B))
742 self.assertTrue(self.builds[4].hasChanges(A))
743 self.assertFalse(self.builds[4].hasChanges(B))
744 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700745
746 # Finish running all passing jobs for change A
747 self.release(self.builds[1])
748 self.waitUntilSettled()
749 # Fail and report change A
750 self.release(self.builds[0])
751 self.waitUntilSettled()
752
753 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400754 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700755 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400756 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700757 self.waitUntilSettled()
758
759 self.assertEqual(len(self.builds), 4)
760 self.assertEqual(self.builds[0].name, 'project-test1') # B
761 self.assertEqual(self.builds[1].name, 'project-test2') # B
762 self.assertEqual(self.builds[2].name, 'project-test1') # C
763 self.assertEqual(self.builds[3].name, 'project-test2') # C
764
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400765 self.assertFalse(self.builds[1].hasChanges(A))
766 self.assertTrue(self.builds[1].hasChanges(B))
767 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700768
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400769 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700770 # After A failed and B and C restarted, B should be back in
771 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400772 self.assertTrue(self.builds[2].hasChanges(B))
773 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700774
Paul Belanger174a8272017-03-14 13:20:10 -0400775 self.executor_server.hold_jobs_in_build = False
776 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700777 self.waitUntilSettled()
778
779 self.assertEqual(len(self.builds), 0)
780 self.assertEqual(len(self.history), 21)
781 self.assertEqual(A.data['status'], 'NEW')
782 self.assertEqual(B.data['status'], 'NEW')
783 self.assertEqual(C.data['status'], 'MERGED')
784 self.assertEqual(A.reported, 2)
785 self.assertEqual(B.reported, 2)
786 self.assertEqual(C.reported, 2)
787
James E. Blair8c803f82012-07-31 16:25:42 -0700788 def test_patch_order(self):
789 "Test that dependent patches are tested in the right order"
790 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
791 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
792 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200793 A.addApproval('Code-Review', 2)
794 B.addApproval('Code-Review', 2)
795 C.addApproval('Code-Review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700796
797 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
798 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
799 M2.setMerged()
800 M1.setMerged()
801
802 # C -> B -> A -> M1 -> M2
803 # M2 is here to make sure it is never queried. If it is, it
804 # means zuul is walking down the entire history of merged
805 # changes.
806
807 C.setDependsOn(B, 1)
808 B.setDependsOn(A, 1)
809 A.setDependsOn(M1, 1)
810 M1.setDependsOn(M2, 1)
811
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200812 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700813
814 self.waitUntilSettled()
815
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400816 self.assertEqual(A.data['status'], 'NEW')
817 self.assertEqual(B.data['status'], 'NEW')
818 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700819
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200820 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
821 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700822
823 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400824 self.assertEqual(M2.queried, 0)
825 self.assertEqual(A.data['status'], 'MERGED')
826 self.assertEqual(B.data['status'], 'MERGED')
827 self.assertEqual(C.data['status'], 'MERGED')
828 self.assertEqual(A.reported, 2)
829 self.assertEqual(B.reported, 2)
830 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700831
James E. Blair063672f2015-01-29 13:09:12 -0800832 def test_needed_changes_enqueue(self):
833 "Test that a needed change is enqueued ahead"
834 # A Given a git tree like this, if we enqueue
835 # / \ change C, we should walk up and down the tree
836 # B G and enqueue changes in the order ABCDEFG.
837 # /|\ This is also the order that you would get if
838 # *C E F you enqueued changes in the order ABCDEFG, so
839 # / the ordering is stable across re-enqueue events.
840 # D
841
842 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
843 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
844 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
845 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
846 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
847 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
848 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
849 B.setDependsOn(A, 1)
850 C.setDependsOn(B, 1)
851 D.setDependsOn(C, 1)
852 E.setDependsOn(B, 1)
853 F.setDependsOn(B, 1)
854 G.setDependsOn(A, 1)
855
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200856 A.addApproval('Code-Review', 2)
857 B.addApproval('Code-Review', 2)
858 C.addApproval('Code-Review', 2)
859 D.addApproval('Code-Review', 2)
860 E.addApproval('Code-Review', 2)
861 F.addApproval('Code-Review', 2)
862 G.addApproval('Code-Review', 2)
863 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800864
865 self.waitUntilSettled()
866
867 self.assertEqual(A.data['status'], 'NEW')
868 self.assertEqual(B.data['status'], 'NEW')
869 self.assertEqual(C.data['status'], 'NEW')
870 self.assertEqual(D.data['status'], 'NEW')
871 self.assertEqual(E.data['status'], 'NEW')
872 self.assertEqual(F.data['status'], 'NEW')
873 self.assertEqual(G.data['status'], 'NEW')
874
875 # We're about to add approvals to changes without adding the
876 # triggering events to Zuul, so that we can be sure that it is
877 # enqueing the changes based on dependencies, not because of
878 # triggering events. Since it will have the changes cached
879 # already (without approvals), we need to clear the cache
880 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400881 for connection in self.connections.connections.values():
James E. Blairb0a95ab2017-10-18 09:39:18 -0700882 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800883
Paul Belanger174a8272017-03-14 13:20:10 -0400884 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200885 A.addApproval('Approved', 1)
886 B.addApproval('Approved', 1)
887 D.addApproval('Approved', 1)
888 E.addApproval('Approved', 1)
889 F.addApproval('Approved', 1)
890 G.addApproval('Approved', 1)
891 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800892
893 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400894 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800895 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400896 self.executor_server.hold_jobs_in_build = False
897 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800898 self.waitUntilSettled()
899
900 self.assertEqual(A.data['status'], 'MERGED')
901 self.assertEqual(B.data['status'], 'MERGED')
902 self.assertEqual(C.data['status'], 'MERGED')
903 self.assertEqual(D.data['status'], 'MERGED')
904 self.assertEqual(E.data['status'], 'MERGED')
905 self.assertEqual(F.data['status'], 'MERGED')
906 self.assertEqual(G.data['status'], 'MERGED')
907 self.assertEqual(A.reported, 2)
908 self.assertEqual(B.reported, 2)
909 self.assertEqual(C.reported, 2)
910 self.assertEqual(D.reported, 2)
911 self.assertEqual(E.reported, 2)
912 self.assertEqual(F.reported, 2)
913 self.assertEqual(G.reported, 2)
914 self.assertEqual(self.history[6].changes,
915 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
916
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100917 def test_source_cache(self):
918 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400919 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700920
921 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
922 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
923 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200924 A.addApproval('Code-Review', 2)
925 B.addApproval('Code-Review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700926
927 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
928 M1.setMerged()
929
930 B.setDependsOn(A, 1)
931 A.setDependsOn(M1, 1)
932
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200933 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700934 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
935
936 self.waitUntilSettled()
937
938 for build in self.builds:
James E. Blaire675d682017-07-21 15:29:35 -0700939 if build.pipeline == 'check':
James E. Blair0e933c52013-07-11 10:18:52 -0700940 build.release()
941 self.waitUntilSettled()
942 for build in self.builds:
James E. Blaire675d682017-07-21 15:29:35 -0700943 if build.pipeline == 'check':
James E. Blair0e933c52013-07-11 10:18:52 -0700944 build.release()
945 self.waitUntilSettled()
946
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200947 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700948 self.waitUntilSettled()
949
Joshua Hesketh352264b2015-08-11 23:42:08 +1000950 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700951 # there should still be changes in the cache
James E. Blairb0a95ab2017-10-18 09:39:18 -0700952 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700953
Paul Belanger174a8272017-03-14 13:20:10 -0400954 self.executor_server.hold_jobs_in_build = False
955 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700956 self.waitUntilSettled()
957
958 self.assertEqual(A.data['status'], 'MERGED')
959 self.assertEqual(B.data['status'], 'MERGED')
960 self.assertEqual(A.queried, 2) # Initial and isMerged
961 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
962
James E. Blair8c803f82012-07-31 16:25:42 -0700963 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700964 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700965 # TODO: move to test_gerrit (this is a unit test!)
966 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400967 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700968 (trusted, project) = tenant.getProject('org/project')
969 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400970
971 # TODO(pabelanger): As we add more source / trigger APIs we should make
972 # it easier for users to create events for testing.
973 event = zuul.model.TriggerEvent()
974 event.trigger_name = 'gerrit'
975 event.change_number = '1'
976 event.patch_number = '2'
977
978 a = source.getChange(event)
979 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700980 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700981
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200982 A.addApproval('Code-Review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400983 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700984 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700985
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200986 A.addApproval('Approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400987 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700988 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700989
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700990 def test_project_merge_conflict(self):
991 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700992
993 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700994 A = self.fake_gerrit.addFakeChange('org/project',
995 'master', 'A',
996 files={'conflict': 'foo'})
997 B = self.fake_gerrit.addFakeChange('org/project',
998 'master', 'B',
999 files={'conflict': 'bar'})
1000 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -07001001 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001002 A.addApproval('Code-Review', 2)
1003 B.addApproval('Code-Review', 2)
1004 C.addApproval('Code-Review', 2)
1005 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1006 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1007 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -07001008 self.waitUntilSettled()
1009
James E. Blair6736beb2013-07-11 15:18:15 -07001010 self.assertEqual(A.reported, 1)
James E. Blair6736beb2013-07-11 15:18:15 -07001011 self.assertEqual(C.reported, 1)
1012
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001013 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -07001014 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001015 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -07001016 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001017 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -07001018 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -07001019
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001020 self.gearman_server.hold_jobs_in_queue = False
1021 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -07001022 self.waitUntilSettled()
1023
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001024 self.assertEqual(A.data['status'], 'MERGED')
1025 self.assertEqual(B.data['status'], 'NEW')
1026 self.assertEqual(C.data['status'], 'MERGED')
1027 self.assertEqual(A.reported, 2)
Tobias Henkel9842bd72017-05-16 13:40:03 +02001028 self.assertIn('Merge Failed', B.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001029 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001030
1031 self.assertHistory([
1032 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1033 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1034 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1035 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
1036 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
1037 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
1038 ], ordered=False)
1039
1040 def test_delayed_merge_conflict(self):
1041 "Test that delayed check merge conflicts are handled properly"
1042
1043 # Hold jobs in the gearman queue so that we can test whether
James E. Blair1960d682017-04-28 15:44:14 -07001044 # the executor sucesfully merges a change based on an old
1045 # repo state (frozen by the scheduler) which would otherwise
1046 # conflict.
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001047 self.gearman_server.hold_jobs_in_queue = True
1048 A = self.fake_gerrit.addFakeChange('org/project',
1049 'master', 'A',
1050 files={'conflict': 'foo'})
1051 B = self.fake_gerrit.addFakeChange('org/project',
1052 'master', 'B',
1053 files={'conflict': 'bar'})
1054 C = self.fake_gerrit.addFakeChange('org/project',
1055 'master', 'C')
1056 C.setDependsOn(B, 1)
1057
1058 # A enters the gate queue; B and C enter the check queue
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001059 A.addApproval('Code-Review', 2)
1060 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001061 self.waitUntilSettled()
1062 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
James E. Blair8d144dc2017-05-05 10:13:45 -07001063 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001064 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1065 self.waitUntilSettled()
1066
1067 self.assertEqual(A.reported, 1)
1068 self.assertEqual(B.reported, 0) # Check does not report start
1069 self.assertEqual(C.reported, 0) # Check does not report start
1070
1071 # A merges while B and C are queued in check
1072 # Release A project-merge
1073 queue = self.gearman_server.getQueue()
1074 self.release(queue[0])
1075 self.waitUntilSettled()
1076
1077 # Release A project-test*
1078 # gate has higher precedence, so A's test jobs are added in
1079 # front of the merge jobs for B and C
1080 queue = self.gearman_server.getQueue()
1081 self.release(queue[0])
1082 self.release(queue[1])
1083 self.waitUntilSettled()
1084
1085 self.assertEqual(A.data['status'], 'MERGED')
1086 self.assertEqual(B.data['status'], 'NEW')
1087 self.assertEqual(C.data['status'], 'NEW')
1088 self.assertEqual(A.reported, 2)
1089 self.assertEqual(B.reported, 0)
1090 self.assertEqual(C.reported, 0)
1091 self.assertHistory([
1092 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1093 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1094 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1095 ], ordered=False)
1096
1097 # B and C report merge conflicts
1098 # Release B project-merge
1099 queue = self.gearman_server.getQueue()
1100 self.release(queue[0])
1101 self.waitUntilSettled()
1102
1103 # Release C
1104 self.gearman_server.hold_jobs_in_queue = False
1105 self.gearman_server.release()
1106 self.waitUntilSettled()
1107
1108 self.assertEqual(A.data['status'], 'MERGED')
1109 self.assertEqual(B.data['status'], 'NEW')
1110 self.assertEqual(C.data['status'], 'NEW')
1111 self.assertEqual(A.reported, 2)
1112 self.assertEqual(B.reported, 1)
1113 self.assertEqual(C.reported, 1)
1114
1115 self.assertHistory([
1116 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1117 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1118 dict(name='project-test2', result='SUCCESS', changes='1,1'),
James E. Blair1960d682017-04-28 15:44:14 -07001119 dict(name='project-merge', result='SUCCESS', changes='2,1'),
1120 dict(name='project-test1', result='SUCCESS', changes='2,1'),
1121 dict(name='project-test2', result='SUCCESS', changes='2,1'),
1122 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
1123 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
1124 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001125 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001126
James E. Blairdaabed22012-08-15 15:38:57 -07001127 def test_post(self):
1128 "Test that post jobs run"
James E. Blair289f5932017-07-27 15:02:29 -07001129 p = "review.example.com/org/project"
1130 upstream = self.getUpstreamRepos([p])
1131 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1132 A.setMerged()
1133 A_commit = str(upstream[p].commit('master'))
1134 self.log.debug("A commit: %s" % A_commit)
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001135
Zhongyue Luo5d556072012-09-21 02:00:47 +09001136 e = {
1137 "type": "ref-updated",
1138 "submitter": {
1139 "name": "User Name",
1140 },
1141 "refUpdate": {
1142 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
James E. Blair289f5932017-07-27 15:02:29 -07001143 "newRev": A_commit,
Zhongyue Luo5d556072012-09-21 02:00:47 +09001144 "refName": "master",
1145 "project": "org/project",
1146 }
1147 }
James E. Blairdaabed22012-08-15 15:38:57 -07001148 self.fake_gerrit.addEvent(e)
1149 self.waitUntilSettled()
1150
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001151 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001152 self.assertEqual(len(self.history), 1)
1153 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001154
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001155 def test_post_ignore_deletes(self):
1156 "Test that deleting refs does not trigger post jobs"
1157
1158 e = {
1159 "type": "ref-updated",
1160 "submitter": {
1161 "name": "User Name",
1162 },
1163 "refUpdate": {
1164 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1165 "newRev": "0000000000000000000000000000000000000000",
1166 "refName": "master",
1167 "project": "org/project",
1168 }
1169 }
1170 self.fake_gerrit.addEvent(e)
1171 self.waitUntilSettled()
1172
1173 job_names = [x.name for x in self.history]
1174 self.assertEqual(len(self.history), 0)
1175 self.assertNotIn('project-post', job_names)
1176
James E. Blaircc324192017-04-19 14:36:08 -07001177 @simple_layout('layouts/dont-ignore-ref-deletes.yaml')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001178 def test_post_ignore_deletes_negative(self):
1179 "Test that deleting refs does trigger post jobs"
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001180 e = {
1181 "type": "ref-updated",
1182 "submitter": {
1183 "name": "User Name",
1184 },
1185 "refUpdate": {
1186 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1187 "newRev": "0000000000000000000000000000000000000000",
James E. Blair289f5932017-07-27 15:02:29 -07001188 "refName": "testbranch",
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001189 "project": "org/project",
1190 }
1191 }
1192 self.fake_gerrit.addEvent(e)
1193 self.waitUntilSettled()
1194
1195 job_names = [x.name for x in self.history]
1196 self.assertEqual(len(self.history), 1)
1197 self.assertIn('project-post', job_names)
1198
James E. Blairec056492016-07-22 09:45:56 -07001199 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001200 def test_build_configuration_branch_interaction(self):
1201 "Test that switching between branches works"
1202 self.test_build_configuration()
1203 self.test_build_configuration_branch()
1204 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001205 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001206 repo = git.Repo(path)
1207 repo.heads.master.commit = repo.commit('init')
1208 self.test_build_configuration()
1209
James E. Blairdb93b302017-07-19 15:33:11 -07001210 def test_dependent_changes_rebase(self):
1211 # Test that no errors occur when we walk a dependency tree
1212 # with an unused leaf node due to a rebase.
1213 # Start by constructing: C -> B -> A
1214 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1215 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1216 B.setDependsOn(A, 1)
1217
1218 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1219 C.setDependsOn(B, 1)
1220
1221 # Then rebase to form: D -> C -> A
1222 C.addPatchset() # C,2
1223 C.setDependsOn(A, 1)
1224
1225 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1226 D.setDependsOn(C, 2)
1227
1228 # Walk the entire tree
1229 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1230 self.waitUntilSettled()
1231 self.assertEqual(len(self.history), 3)
1232
1233 # Verify that walking just part of the tree still works
1234 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
1235 self.waitUntilSettled()
1236 self.assertEqual(len(self.history), 6)
1237
James E. Blaircaec0c52012-08-22 14:52:22 -07001238 def test_dependent_changes_dequeue(self):
1239 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001240
James E. Blaircaec0c52012-08-22 14:52:22 -07001241 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1242 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1243 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001244 A.addApproval('Code-Review', 2)
1245 B.addApproval('Code-Review', 2)
1246 C.addApproval('Code-Review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001247
1248 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1249 M1.setMerged()
1250
1251 # C -> B -> A -> M1
1252
1253 C.setDependsOn(B, 1)
1254 B.setDependsOn(A, 1)
1255 A.setDependsOn(M1, 1)
1256
Paul Belanger174a8272017-03-14 13:20:10 -04001257 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001258
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001259 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1260 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1261 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001262
1263 self.waitUntilSettled()
1264
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001265 self.assertEqual(A.data['status'], 'NEW')
1266 self.assertEqual(A.reported, 2)
1267 self.assertEqual(B.data['status'], 'NEW')
1268 self.assertEqual(B.reported, 2)
1269 self.assertEqual(C.data['status'], 'NEW')
James E. Blair0d3e83b2017-06-05 13:51:57 -07001270 self.assertIn('This change depends on a change that failed to merge.',
1271 C.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001272 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001273
James E. Blair972e3c72013-08-29 12:04:55 -07001274 def test_failing_dependent_changes(self):
1275 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001276 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001277 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1278 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1279 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1280 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1281 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001282 A.addApproval('Code-Review', 2)
1283 B.addApproval('Code-Review', 2)
1284 C.addApproval('Code-Review', 2)
1285 D.addApproval('Code-Review', 2)
1286 E.addApproval('Code-Review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001287
1288 # E, D -> C -> B, A
1289
1290 D.setDependsOn(C, 1)
1291 C.setDependsOn(B, 1)
1292
Paul Belanger174a8272017-03-14 13:20:10 -04001293 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001294
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001295 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1296 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
1297 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1298 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1299 self.fake_gerrit.addEvent(E.addApproval('Approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001300
1301 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001302 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001303 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001304 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001305 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001306 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001307 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001308 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001309 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001310 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001311 self.waitUntilSettled()
1312
Paul Belanger174a8272017-03-14 13:20:10 -04001313 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001314 for build in self.builds:
James E. Blaire3db2952017-07-21 15:03:36 -07001315 if build.parameters['zuul']['change'] != '1':
James E. Blair972e3c72013-08-29 12:04:55 -07001316 build.release()
1317 self.waitUntilSettled()
1318
Paul Belanger174a8272017-03-14 13:20:10 -04001319 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001320 self.waitUntilSettled()
1321
1322 self.assertEqual(A.data['status'], 'MERGED')
1323 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001324 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001325 self.assertEqual(B.data['status'], 'NEW')
1326 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001327 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001328 self.assertEqual(C.data['status'], 'NEW')
1329 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001330 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001331 self.assertEqual(D.data['status'], 'NEW')
1332 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001333 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001334 self.assertEqual(E.data['status'], 'MERGED')
1335 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001336 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001337 self.assertEqual(len(self.history), 18)
1338
James E. Blairec590122012-08-22 15:19:31 -07001339 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001340 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001341 # If it's dequeued more than once, we should see extra
1342 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001343
Paul Belanger174a8272017-03-14 13:20:10 -04001344 self.executor_server.hold_jobs_in_build = True
James E. Blair6df67132017-04-19 13:53:20 -07001345 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1346 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1347 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001348 A.addApproval('Code-Review', 2)
1349 B.addApproval('Code-Review', 2)
1350 C.addApproval('Code-Review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001351
Paul Belanger174a8272017-03-14 13:20:10 -04001352 self.executor_server.failJob('project-test1', A)
1353 self.executor_server.failJob('project-test2', A)
James E. Blairec590122012-08-22 15:19:31 -07001354
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001355 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1356 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1357 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001358
1359 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001360
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001361 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001362 self.assertEqual(self.builds[0].name, 'project-merge')
1363 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001364
Paul Belanger174a8272017-03-14 13:20:10 -04001365 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001366 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001367 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001368 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001369 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001370 self.waitUntilSettled()
1371
James E. Blair6df67132017-04-19 13:53:20 -07001372 self.assertEqual(len(self.builds), 6)
Paul Belanger58bf6912016-11-11 19:36:01 -05001373 self.assertEqual(self.builds[0].name, 'project-test1')
1374 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair6df67132017-04-19 13:53:20 -07001375 self.assertEqual(self.builds[2].name, 'project-test1')
1376 self.assertEqual(self.builds[3].name, 'project-test2')
1377 self.assertEqual(self.builds[4].name, 'project-test1')
1378 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blairec590122012-08-22 15:19:31 -07001379
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001380 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001381 self.waitUntilSettled()
1382
James E. Blair6df67132017-04-19 13:53:20 -07001383 self.assertEqual(len(self.builds), 2) # test2, merge for B
1384 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
James E. Blairec590122012-08-22 15:19:31 -07001385
Paul Belanger174a8272017-03-14 13:20:10 -04001386 self.executor_server.hold_jobs_in_build = False
1387 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001388 self.waitUntilSettled()
1389
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001390 self.assertEqual(len(self.builds), 0)
James E. Blair6df67132017-04-19 13:53:20 -07001391 self.assertEqual(len(self.history), 15)
James E. Blaircaec0c52012-08-22 14:52:22 -07001392
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001393 self.assertEqual(A.data['status'], 'NEW')
1394 self.assertEqual(B.data['status'], 'MERGED')
1395 self.assertEqual(C.data['status'], 'MERGED')
1396 self.assertEqual(A.reported, 2)
1397 self.assertEqual(B.reported, 2)
1398 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001399
James E. Blaircc020532017-04-19 13:04:44 -07001400 @simple_layout('layouts/nonvoting-job.yaml')
James E. Blair4ec821f2012-08-23 15:28:28 -07001401 def test_nonvoting_job(self):
1402 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001403
James E. Blair4ec821f2012-08-23 15:28:28 -07001404 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1405 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001406 A.addApproval('Code-Review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001407 self.executor_server.failJob('nonvoting-project-test2', A)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001408 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001409
1410 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001411
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001412 self.assertEqual(A.data['status'], 'MERGED')
1413 self.assertEqual(A.reported, 2)
1414 self.assertEqual(
1415 self.getJobFromHistory('nonvoting-project-merge').result,
1416 'SUCCESS')
1417 self.assertEqual(
1418 self.getJobFromHistory('nonvoting-project-test1').result,
1419 'SUCCESS')
1420 self.assertEqual(
1421 self.getJobFromHistory('nonvoting-project-test2').result,
1422 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001423
James E. Blair2ef29e92017-07-21 15:25:05 -07001424 self.assertTrue(self.getJobFromHistory('nonvoting-project-merge').
1425 parameters['zuul']['voting'])
1426 self.assertTrue(self.getJobFromHistory('nonvoting-project-test1').
1427 parameters['zuul']['voting'])
1428 self.assertFalse(self.getJobFromHistory('nonvoting-project-test2').
1429 parameters['zuul']['voting'])
James E. Blair5821bd92015-09-16 08:48:15 -07001430
James E. Blaire0487072012-08-29 17:38:31 -07001431 def test_check_queue_success(self):
1432 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001433
James E. Blaire0487072012-08-29 17:38:31 -07001434 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1435 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1436
1437 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001438
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001439 self.assertEqual(A.data['status'], 'NEW')
1440 self.assertEqual(A.reported, 1)
1441 self.assertEqual(self.getJobFromHistory('project-merge').result,
1442 'SUCCESS')
1443 self.assertEqual(self.getJobFromHistory('project-test1').result,
1444 'SUCCESS')
1445 self.assertEqual(self.getJobFromHistory('project-test2').result,
1446 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001447
1448 def test_check_queue_failure(self):
1449 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001450
James E. Blaire0487072012-08-29 17:38:31 -07001451 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001452 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001453 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1454
1455 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001456
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001457 self.assertEqual(A.data['status'], 'NEW')
1458 self.assertEqual(A.reported, 1)
1459 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001460 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001461 self.assertEqual(self.getJobFromHistory('project-test1').result,
1462 'SUCCESS')
1463 self.assertEqual(self.getJobFromHistory('project-test2').result,
1464 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001465
David Shrewsburyffab07a2017-07-24 12:45:07 -04001466 @simple_layout('layouts/autohold.yaml')
1467 def test_autohold(self):
1468 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1469
1470 client = zuul.rpcclient.RPCClient('127.0.0.1',
1471 self.gearman_server.port)
1472 self.addCleanup(client.shutdown)
David Shrewsbury36b2adf2017-07-31 15:40:13 -04001473 r = client.autohold('tenant-one', 'org/project', 'project-test2',
1474 "reason text", 1)
David Shrewsburyffab07a2017-07-24 12:45:07 -04001475 self.assertTrue(r)
1476
1477 self.executor_server.failJob('project-test2', A)
1478 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1479
1480 self.waitUntilSettled()
1481
1482 self.assertEqual(A.data['status'], 'NEW')
1483 self.assertEqual(A.reported, 1)
1484 self.assertEqual(self.getJobFromHistory('project-test2').result,
1485 'FAILURE')
1486
1487 # Check nodepool for a held node
1488 held_node = None
1489 for node in self.fake_nodepool.getNodes():
1490 if node['state'] == zuul.model.STATE_HOLD:
1491 held_node = node
1492 break
1493 self.assertIsNotNone(held_node)
1494
1495 # Validate node has recorded the failed job
1496 self.assertEqual(
1497 held_node['hold_job'],
1498 " ".join(['tenant-one',
1499 'review.example.com/org/project',
1500 'project-test2'])
1501 )
David Shrewsburyf9af9df2017-08-01 15:19:26 -04001502 self.assertEqual(held_node['comment'], "reason text")
David Shrewsburyffab07a2017-07-24 12:45:07 -04001503
1504 # Another failed change should not hold any more nodes
1505 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1506 self.executor_server.failJob('project-test2', B)
1507 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1508 self.waitUntilSettled()
1509 self.assertEqual(B.data['status'], 'NEW')
1510 self.assertEqual(B.reported, 1)
1511 self.assertEqual(self.getJobFromHistory('project-test2').result,
1512 'FAILURE')
1513
1514 held_nodes = 0
1515 for node in self.fake_nodepool.getNodes():
1516 if node['state'] == zuul.model.STATE_HOLD:
1517 held_nodes += 1
1518 self.assertEqual(held_nodes, 1)
1519
David Shrewsburyc4676132017-10-16 12:41:57 -04001520 @simple_layout('layouts/autohold.yaml')
1521 def test_autohold_list(self):
1522 client = zuul.rpcclient.RPCClient('127.0.0.1',
1523 self.gearman_server.port)
1524 self.addCleanup(client.shutdown)
1525
1526 r = client.autohold('tenant-one', 'org/project', 'project-test2',
1527 "reason text", 1)
1528 self.assertTrue(r)
1529
1530 autohold_requests = client.autohold_list()
1531 self.assertNotEqual({}, autohold_requests)
1532 self.assertEqual(1, len(autohold_requests.keys()))
1533
1534 # The single dict key should be a CSV string value
1535 key = list(autohold_requests.keys())[0]
1536 tenant, project, job = key.split(',')
1537
1538 self.assertEqual('tenant-one', tenant)
1539 self.assertIn('org/project', project)
1540 self.assertEqual('project-test2', job)
1541
1542 # Note: the value is converted from set to list by json.
1543 self.assertEqual([1, "reason text"], autohold_requests[key])
1544
James E. Blair7cb84542017-04-19 13:35:05 -07001545 @simple_layout('layouts/three-projects.yaml')
James E. Blair127bc182012-08-28 15:55:15 -07001546 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001547 # This particular test does a large amount of merges and needs a little
1548 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001549 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001550 "test that dependent changes behind dequeued changes work"
1551 # This complicated test is a reproduction of a real life bug
1552 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001553
Paul Belanger174a8272017-03-14 13:20:10 -04001554 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001555 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1556 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1557 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1558 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1559 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1560 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1561 D.setDependsOn(C, 1)
1562 E.setDependsOn(D, 1)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001563 A.addApproval('Code-Review', 2)
1564 B.addApproval('Code-Review', 2)
1565 C.addApproval('Code-Review', 2)
1566 D.addApproval('Code-Review', 2)
1567 E.addApproval('Code-Review', 2)
1568 F.addApproval('Code-Review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001569
1570 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001571
1572 # Change object re-use in the gerrit trigger is hidden if
1573 # changes are added in quick succession; waiting makes it more
1574 # like real life.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001575 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001576 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001577 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001578 self.waitUntilSettled()
1579
Paul Belanger174a8272017-03-14 13:20:10 -04001580 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001581 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001582 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001583 self.waitUntilSettled()
1584
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001585 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001586 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001587 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001588 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001589 self.fake_gerrit.addEvent(E.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001590 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001591 self.fake_gerrit.addEvent(F.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001592 self.waitUntilSettled()
1593
Paul Belanger174a8272017-03-14 13:20:10 -04001594 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001595 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001596 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001597 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001598 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001599 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001600 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001601 self.waitUntilSettled()
1602
1603 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001604
1605 # Grab pointers to the jobs we want to release before
1606 # releasing any, because list indexes may change as
1607 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001608 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001609 a.release()
1610 b.release()
1611 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001612 self.waitUntilSettled()
1613
Paul Belanger174a8272017-03-14 13:20:10 -04001614 self.executor_server.hold_jobs_in_build = False
1615 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001616 self.waitUntilSettled()
1617
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001618 self.assertEqual(A.data['status'], 'NEW')
1619 self.assertEqual(B.data['status'], 'MERGED')
1620 self.assertEqual(C.data['status'], 'MERGED')
1621 self.assertEqual(D.data['status'], 'MERGED')
1622 self.assertEqual(E.data['status'], 'MERGED')
1623 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001624
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001625 self.assertEqual(A.reported, 2)
1626 self.assertEqual(B.reported, 2)
1627 self.assertEqual(C.reported, 2)
1628 self.assertEqual(D.reported, 2)
1629 self.assertEqual(E.reported, 2)
1630 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001631
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001632 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1633 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001634
1635 def test_merger_repack(self):
1636 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001637
James E. Blair05fed602012-09-07 12:45:24 -07001638 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001639 A.addApproval('Code-Review', 2)
1640 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001641 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001642 self.assertEqual(self.getJobFromHistory('project-merge').result,
1643 'SUCCESS')
1644 self.assertEqual(self.getJobFromHistory('project-test1').result,
1645 'SUCCESS')
1646 self.assertEqual(self.getJobFromHistory('project-test2').result,
1647 'SUCCESS')
1648 self.assertEqual(A.data['status'], 'MERGED')
1649 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001650 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001651 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001652
James E. Blair2a535672017-04-27 12:03:15 -07001653 path = os.path.join(self.merger_src_root, "review.example.com",
1654 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001655 if os.path.exists(path):
1656 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001657 path = os.path.join(self.executor_src_root, "review.example.com",
1658 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001659 if os.path.exists(path):
1660 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001661
1662 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001663 A.addApproval('Code-Review', 2)
1664 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001665 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001666 self.assertEqual(self.getJobFromHistory('project-merge').result,
1667 'SUCCESS')
1668 self.assertEqual(self.getJobFromHistory('project-test1').result,
1669 'SUCCESS')
1670 self.assertEqual(self.getJobFromHistory('project-test2').result,
1671 'SUCCESS')
1672 self.assertEqual(A.data['status'], 'MERGED')
1673 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001674
James E. Blair4886f282012-11-15 09:27:33 -08001675 def test_merger_repack_large_change(self):
1676 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001677 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001678 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001679 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6df67132017-04-19 13:53:20 -07001680 trusted, project = tenant.getProject('org/project')
James E. Blair0ffa0102017-03-30 13:11:33 -07001681 url = self.fake_gerrit.getGitUrl(project)
James E. Blair8d144dc2017-05-05 10:13:45 -07001682 self.executor_server.merger._addProject('review.example.com',
James E. Blair197e8202017-06-09 12:54:28 -07001683 'org/project', url, None)
James E. Blair6df67132017-04-19 13:53:20 -07001684 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair4886f282012-11-15 09:27:33 -08001685 A.addPatchset(large=True)
James E. Blair2a535672017-04-27 12:03:15 -07001686 # TODOv3(jeblair): add hostname to upstream root
1687 path = os.path.join(self.upstream_root, 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001688 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001689 path = os.path.join(self.merger_src_root, 'review.example.com',
1690 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001691 if os.path.exists(path):
1692 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001693 path = os.path.join(self.executor_src_root, 'review.example.com',
1694 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001695 if os.path.exists(path):
1696 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001697
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001698 A.addApproval('Code-Review', 2)
1699 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001700 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001701 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001702 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001703 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001704 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001705 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001706 'SUCCESS')
1707 self.assertEqual(A.data['status'], 'MERGED')
1708 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001709
James E. Blair2fa50962013-01-30 21:50:41 -08001710 def test_new_patchset_dequeues_old(self):
1711 "Test that a new patchset causes the old to be dequeued"
1712 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001713 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001714 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1715 M.setMerged()
1716
1717 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1718 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1719 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1720 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001721 A.addApproval('Code-Review', 2)
1722 B.addApproval('Code-Review', 2)
1723 C.addApproval('Code-Review', 2)
1724 D.addApproval('Code-Review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001725
1726 C.setDependsOn(B, 1)
1727 B.setDependsOn(A, 1)
1728 A.setDependsOn(M, 1)
1729
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001730 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1731 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1732 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1733 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001734 self.waitUntilSettled()
1735
1736 B.addPatchset()
1737 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1738 self.waitUntilSettled()
1739
Paul Belanger174a8272017-03-14 13:20:10 -04001740 self.executor_server.hold_jobs_in_build = False
1741 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001742 self.waitUntilSettled()
1743
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001744 self.assertEqual(A.data['status'], 'MERGED')
1745 self.assertEqual(A.reported, 2)
1746 self.assertEqual(B.data['status'], 'NEW')
1747 self.assertEqual(B.reported, 2)
1748 self.assertEqual(C.data['status'], 'NEW')
1749 self.assertEqual(C.reported, 2)
1750 self.assertEqual(D.data['status'], 'MERGED')
1751 self.assertEqual(D.reported, 2)
1752 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001753
James E. Blairba437362015-02-07 11:41:52 -08001754 def test_new_patchset_check(self):
1755 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001756
Paul Belanger174a8272017-03-14 13:20:10 -04001757 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001758
1759 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001760 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001761 tenant = self.sched.abide.tenants.get('tenant-one')
1762 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001763
1764 # Add two git-dependent changes
1765 B.setDependsOn(A, 1)
1766 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1767 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001768 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1769 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001770
1771 # A live item, and a non-live/live pair
1772 items = check_pipeline.getAllItems()
1773 self.assertEqual(len(items), 3)
1774
1775 self.assertEqual(items[0].change.number, '1')
1776 self.assertEqual(items[0].change.patchset, '1')
1777 self.assertFalse(items[0].live)
1778
1779 self.assertEqual(items[1].change.number, '2')
1780 self.assertEqual(items[1].change.patchset, '1')
1781 self.assertTrue(items[1].live)
1782
1783 self.assertEqual(items[2].change.number, '1')
1784 self.assertEqual(items[2].change.patchset, '1')
1785 self.assertTrue(items[2].live)
1786
1787 # Add a new patchset to A
1788 A.addPatchset()
1789 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1790 self.waitUntilSettled()
1791
1792 # The live copy of A,1 should be gone, but the non-live and B
1793 # should continue, and we should have a new A,2
1794 items = check_pipeline.getAllItems()
1795 self.assertEqual(len(items), 3)
1796
1797 self.assertEqual(items[0].change.number, '1')
1798 self.assertEqual(items[0].change.patchset, '1')
1799 self.assertFalse(items[0].live)
1800
1801 self.assertEqual(items[1].change.number, '2')
1802 self.assertEqual(items[1].change.patchset, '1')
1803 self.assertTrue(items[1].live)
1804
1805 self.assertEqual(items[2].change.number, '1')
1806 self.assertEqual(items[2].change.patchset, '2')
1807 self.assertTrue(items[2].live)
1808
1809 # Add a new patchset to B
1810 B.addPatchset()
1811 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1812 self.waitUntilSettled()
1813
1814 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1815 # but we should have a new B,2 (still based on A,1)
1816 items = check_pipeline.getAllItems()
1817 self.assertEqual(len(items), 3)
1818
1819 self.assertEqual(items[0].change.number, '1')
1820 self.assertEqual(items[0].change.patchset, '2')
1821 self.assertTrue(items[0].live)
1822
1823 self.assertEqual(items[1].change.number, '1')
1824 self.assertEqual(items[1].change.patchset, '1')
1825 self.assertFalse(items[1].live)
1826
1827 self.assertEqual(items[2].change.number, '2')
1828 self.assertEqual(items[2].change.patchset, '2')
1829 self.assertTrue(items[2].live)
1830
1831 self.builds[0].release()
1832 self.waitUntilSettled()
1833 self.builds[0].release()
1834 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001835 self.executor_server.hold_jobs_in_build = False
1836 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001837 self.waitUntilSettled()
1838
1839 self.assertEqual(A.reported, 1)
1840 self.assertEqual(B.reported, 1)
1841 self.assertEqual(self.history[0].result, 'ABORTED')
1842 self.assertEqual(self.history[0].changes, '1,1')
1843 self.assertEqual(self.history[1].result, 'ABORTED')
1844 self.assertEqual(self.history[1].changes, '1,1 2,1')
1845 self.assertEqual(self.history[2].result, 'SUCCESS')
1846 self.assertEqual(self.history[2].changes, '1,2')
1847 self.assertEqual(self.history[3].result, 'SUCCESS')
1848 self.assertEqual(self.history[3].changes, '1,1 2,2')
1849
1850 def test_abandoned_gate(self):
1851 "Test that an abandoned change is dequeued from gate"
1852
Paul Belanger174a8272017-03-14 13:20:10 -04001853 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001854
1855 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001856 A.addApproval('Code-Review', 2)
1857 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001858 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001859 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1860 self.assertEqual(self.builds[0].name, 'project-merge')
1861
1862 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1863 self.waitUntilSettled()
1864
Paul Belanger174a8272017-03-14 13:20:10 -04001865 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001866 self.waitUntilSettled()
1867
Arie5b4048c2016-10-05 16:12:06 +03001868 self.assertBuilds([])
1869 self.assertHistory([
1870 dict(name='project-merge', result='ABORTED', changes='1,1')],
1871 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001872 self.assertEqual(A.reported, 1,
1873 "Abandoned gate change should report only start")
1874
1875 def test_abandoned_check(self):
1876 "Test that an abandoned change is dequeued from check"
1877
Paul Belanger174a8272017-03-14 13:20:10 -04001878 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001879
1880 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1881 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001882 tenant = self.sched.abide.tenants.get('tenant-one')
1883 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001884
1885 # Add two git-dependent changes
1886 B.setDependsOn(A, 1)
1887 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1888 self.waitUntilSettled()
1889 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1890 self.waitUntilSettled()
1891 # A live item, and a non-live/live pair
1892 items = check_pipeline.getAllItems()
1893 self.assertEqual(len(items), 3)
1894
1895 self.assertEqual(items[0].change.number, '1')
1896 self.assertFalse(items[0].live)
1897
1898 self.assertEqual(items[1].change.number, '2')
1899 self.assertTrue(items[1].live)
1900
1901 self.assertEqual(items[2].change.number, '1')
1902 self.assertTrue(items[2].live)
1903
1904 # Abandon A
1905 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1906 self.waitUntilSettled()
1907
1908 # The live copy of A should be gone, but the non-live and B
1909 # should continue
1910 items = check_pipeline.getAllItems()
1911 self.assertEqual(len(items), 2)
1912
1913 self.assertEqual(items[0].change.number, '1')
1914 self.assertFalse(items[0].live)
1915
1916 self.assertEqual(items[1].change.number, '2')
1917 self.assertTrue(items[1].live)
1918
Paul Belanger174a8272017-03-14 13:20:10 -04001919 self.executor_server.hold_jobs_in_build = False
1920 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001921 self.waitUntilSettled()
1922
1923 self.assertEqual(len(self.history), 4)
1924 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001925 'Build should have been aborted')
1926 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001927 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001928
Steve Varnau7b78b312015-04-03 14:49:46 -07001929 def test_abandoned_not_timer(self):
1930 "Test that an abandoned change does not cancel timer jobs"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001931 # This test can not use simple_layout because it must start
1932 # with a configuration which does not include a
1933 # timer-triggered job so that we have an opportunity to set
1934 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04001935 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001936 # Start timer trigger - also org/project
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001937 self.commitConfigUpdate('common-config', 'layouts/idle.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001938 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001939 # The pipeline triggers every second, so we should have seen
1940 # several by now.
1941 time.sleep(5)
1942 self.waitUntilSettled()
1943 # Stop queuing timer triggered jobs so that the assertions
1944 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001945 # Must be in same repo, so overwrite config with another one
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001946 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001947 self.sched.reconfigure(self.config)
James E. Blair0b137b42017-07-27 08:51:25 -07001948 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07001949 # If APScheduler is in mid-event when we remove the job, we
1950 # can end up with one more event firing, so give it an extra
1951 # second to settle.
1952 time.sleep(1)
1953 self.waitUntilSettled()
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001954
James E. Blair21037782017-07-19 11:56:55 -07001955 self.assertEqual(len(self.builds), 1, "One timer job")
Steve Varnau7b78b312015-04-03 14:49:46 -07001956
1957 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1958 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1959 self.waitUntilSettled()
James E. Blair21037782017-07-19 11:56:55 -07001960 self.assertEqual(len(self.builds), 2, "One change plus one timer job")
Steve Varnau7b78b312015-04-03 14:49:46 -07001961
1962 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1963 self.waitUntilSettled()
1964
James E. Blair21037782017-07-19 11:56:55 -07001965 self.assertEqual(len(self.builds), 1, "One timer job remains")
Steve Varnau7b78b312015-04-03 14:49:46 -07001966
Paul Belanger174a8272017-03-14 13:20:10 -04001967 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001968 self.waitUntilSettled()
1969
James E. Blair2fa50962013-01-30 21:50:41 -08001970 def test_new_patchset_dequeues_old_on_head(self):
1971 "Test that a new patchset causes the old to be dequeued (at head)"
1972 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001973 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001974 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1975 M.setMerged()
1976 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1977 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1978 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1979 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001980 A.addApproval('Code-Review', 2)
1981 B.addApproval('Code-Review', 2)
1982 C.addApproval('Code-Review', 2)
1983 D.addApproval('Code-Review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001984
1985 C.setDependsOn(B, 1)
1986 B.setDependsOn(A, 1)
1987 A.setDependsOn(M, 1)
1988
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001989 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1990 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1991 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1992 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001993 self.waitUntilSettled()
1994
1995 A.addPatchset()
1996 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1997 self.waitUntilSettled()
1998
Paul Belanger174a8272017-03-14 13:20:10 -04001999 self.executor_server.hold_jobs_in_build = False
2000 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08002001 self.waitUntilSettled()
2002
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002003 self.assertEqual(A.data['status'], 'NEW')
2004 self.assertEqual(A.reported, 2)
2005 self.assertEqual(B.data['status'], 'NEW')
2006 self.assertEqual(B.reported, 2)
2007 self.assertEqual(C.data['status'], 'NEW')
2008 self.assertEqual(C.reported, 2)
2009 self.assertEqual(D.data['status'], 'MERGED')
2010 self.assertEqual(D.reported, 2)
2011 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08002012
2013 def test_new_patchset_dequeues_old_without_dependents(self):
2014 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04002015 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08002016 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2017 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2018 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002019 A.addApproval('Code-Review', 2)
2020 B.addApproval('Code-Review', 2)
2021 C.addApproval('Code-Review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08002022
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002023 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
2024 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
2025 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08002026 self.waitUntilSettled()
2027
2028 B.addPatchset()
2029 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
2030 self.waitUntilSettled()
2031
Paul Belanger174a8272017-03-14 13:20:10 -04002032 self.executor_server.hold_jobs_in_build = False
2033 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08002034 self.waitUntilSettled()
2035
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002036 self.assertEqual(A.data['status'], 'MERGED')
2037 self.assertEqual(A.reported, 2)
2038 self.assertEqual(B.data['status'], 'NEW')
2039 self.assertEqual(B.reported, 2)
2040 self.assertEqual(C.data['status'], 'MERGED')
2041 self.assertEqual(C.reported, 2)
2042 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08002043
2044 def test_new_patchset_dequeues_old_independent_queue(self):
2045 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04002046 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08002047 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2048 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2049 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
2050 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2051 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2052 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2053 self.waitUntilSettled()
2054
2055 B.addPatchset()
2056 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
2057 self.waitUntilSettled()
2058
Paul Belanger174a8272017-03-14 13:20:10 -04002059 self.executor_server.hold_jobs_in_build = False
2060 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08002061 self.waitUntilSettled()
2062
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002063 self.assertEqual(A.data['status'], 'NEW')
2064 self.assertEqual(A.reported, 1)
2065 self.assertEqual(B.data['status'], 'NEW')
2066 self.assertEqual(B.reported, 1)
2067 self.assertEqual(C.data['status'], 'NEW')
2068 self.assertEqual(C.reported, 1)
2069 self.assertEqual(len(self.history), 10)
2070 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08002071
James E. Blaircc020532017-04-19 13:04:44 -07002072 @simple_layout('layouts/noop-job.yaml')
James E. Blair18c64442014-03-18 10:14:45 -07002073 def test_noop_job(self):
2074 "Test that the internal noop job works"
2075 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002076 A.addApproval('Code-Review', 2)
2077 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07002078 self.waitUntilSettled()
2079
2080 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2081 self.assertTrue(self.sched._areAllBuildsComplete())
2082 self.assertEqual(len(self.history), 0)
2083 self.assertEqual(A.data['status'], 'MERGED')
2084 self.assertEqual(A.reported, 2)
2085
James E. Blair06cc3922017-04-19 10:08:10 -07002086 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00002087 def test_no_job_project(self):
2088 "Test that reports with no jobs don't get sent"
2089 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
2090 'master', 'A')
2091 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2092 self.waitUntilSettled()
2093
2094 # Change wasn't reported to
2095 self.assertEqual(A.reported, False)
2096
2097 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08002098 tenant = self.sched.abide.tenants.get('tenant-one')
2099 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00002100 items = check_pipeline.getAllItems()
2101 self.assertEqual(len(items), 0)
2102
2103 self.assertEqual(len(self.history), 0)
2104
James E. Blair7d0dedc2013-02-21 17:26:09 -08002105 def test_zuul_refs(self):
2106 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04002107 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08002108 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
2109 M1.setMerged()
2110 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
2111 M2.setMerged()
2112
2113 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2114 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2115 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
2116 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002117 A.addApproval('Code-Review', 2)
2118 B.addApproval('Code-Review', 2)
2119 C.addApproval('Code-Review', 2)
2120 D.addApproval('Code-Review', 2)
2121 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2122 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
2123 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
2124 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002125
2126 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002127 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002128 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002129 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002130 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002131 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002132 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002133 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002134 self.waitUntilSettled()
2135
Clint Byrum3343e3e2016-11-15 16:05:03 -08002136 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002137 for x in self.builds:
James E. Blaire3db2952017-07-21 15:03:36 -07002138 if x.parameters['zuul']['change'] == '3':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002139 a_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002140 elif x.parameters['zuul']['change'] == '4':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002141 b_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002142 elif x.parameters['zuul']['change'] == '5':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002143 c_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002144 elif x.parameters['zuul']['change'] == '6':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002145 d_build = x
2146 if a_build and b_build and c_build and d_build:
2147 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08002148
Clint Byrum3343e3e2016-11-15 16:05:03 -08002149 # should have a, not b, and should not be in project2
2150 self.assertTrue(a_build.hasChanges(A))
2151 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002152
Clint Byrum3343e3e2016-11-15 16:05:03 -08002153 # should have a and b, and should not be in project2
2154 self.assertTrue(b_build.hasChanges(A, B))
2155 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002156
Clint Byrum3343e3e2016-11-15 16:05:03 -08002157 # should have a and b in 1, c in 2
2158 self.assertTrue(c_build.hasChanges(A, B, C))
2159 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002160
Clint Byrum3343e3e2016-11-15 16:05:03 -08002161 # should have a and b in 1, c and d in 2
2162 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002163
Paul Belanger174a8272017-03-14 13:20:10 -04002164 self.executor_server.hold_jobs_in_build = False
2165 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002166 self.waitUntilSettled()
2167
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002168 self.assertEqual(A.data['status'], 'MERGED')
2169 self.assertEqual(A.reported, 2)
2170 self.assertEqual(B.data['status'], 'MERGED')
2171 self.assertEqual(B.reported, 2)
2172 self.assertEqual(C.data['status'], 'MERGED')
2173 self.assertEqual(C.reported, 2)
2174 self.assertEqual(D.data['status'], 'MERGED')
2175 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002176
James E. Blair4a28a882013-08-23 15:17:33 -07002177 def test_rerun_on_error(self):
2178 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002179 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002180 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002181 A.addApproval('Code-Review', 2)
2182 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002183 self.waitUntilSettled()
2184
James E. Blair412fba82017-01-26 15:00:50 -08002185 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002186 self.executor_server.hold_jobs_in_build = False
2187 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002188 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002189 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002190 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2191
James E. Blair412e5582013-04-22 15:50:12 -07002192 def test_statsd(self):
2193 "Test each of the statsd methods used in the scheduler"
James E. Blairded241e2017-10-10 13:22:40 -07002194 statsd = self.sched.statsd
James E. Blair412e5582013-04-22 15:50:12 -07002195 statsd.incr('test-incr')
2196 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002197 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002198 self.assertReportedStat('test-incr', '1|c')
2199 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002200 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002201
James E. Blairdad52252014-02-07 16:59:17 -08002202 def test_stuck_job_cleanup(self):
2203 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002204
2205 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002206 self.gearman_server.hold_jobs_in_queue = True
2207 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002208 A.addApproval('Code-Review', 2)
2209 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002210 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002211 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002212 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2213
James E. Blair31cb3e82017-04-20 13:08:56 -07002214 self.commitConfigUpdate('common-config', 'layouts/no-jobs.yaml')
James E. Blairdad52252014-02-07 16:59:17 -08002215 self.sched.reconfigure(self.config)
2216 self.waitUntilSettled()
2217
James E. Blair18c64442014-03-18 10:14:45 -07002218 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002219 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002220 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002221 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2222 self.assertTrue(self.sched._areAllBuildsComplete())
2223
2224 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002225 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002226 self.assertEqual(self.history[0].result, 'SUCCESS')
2227
James E. Blair879dafb2015-07-17 14:04:49 -07002228 def test_file_head(self):
2229 # This is a regression test for an observed bug. A change
2230 # with a file named "HEAD" in the root directory of the repo
2231 # was processed by a merger. It then was unable to reset the
2232 # repo because of:
2233 # GitCommandError: 'git reset --hard HEAD' returned
2234 # with exit code 128
2235 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2236 # and filename
2237 # Use '--' to separate filenames from revisions'
2238
2239 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002240 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002241 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2242
2243 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2244 self.waitUntilSettled()
2245
2246 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2247 self.waitUntilSettled()
2248
2249 self.assertIn('Build succeeded', A.messages[0])
2250 self.assertIn('Build succeeded', B.messages[0])
2251
James E. Blair70c71582013-03-06 08:50:50 -08002252 def test_file_jobs(self):
2253 "Test that file jobs run only when appropriate"
2254 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002255 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002256 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002257 A.addApproval('Code-Review', 2)
2258 B.addApproval('Code-Review', 2)
2259 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2260 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002261 self.waitUntilSettled()
2262
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002263 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002264 if x.name == 'project-testfile']
2265
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002266 self.assertEqual(len(testfile_jobs), 1)
2267 self.assertEqual(testfile_jobs[0].changes, '1,2')
2268 self.assertEqual(A.data['status'], 'MERGED')
2269 self.assertEqual(A.reported, 2)
2270 self.assertEqual(B.data['status'], 'MERGED')
2271 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002272
Clint Byrum3ee39f32016-11-17 23:45:07 -08002273 def _test_irrelevant_files_jobs(self, should_skip):
2274 "Test that jobs with irrelevant-files filter run only when appropriate"
Clint Byrum3ee39f32016-11-17 23:45:07 -08002275 if should_skip:
2276 files = {'ignoreme': 'ignored\n'}
2277 else:
2278 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002279
2280 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002281 'master',
2282 'test irrelevant-files',
2283 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002284 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2285 self.waitUntilSettled()
2286
2287 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002288 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002289
2290 if should_skip:
2291 self.assertEqual([], tested_change_ids)
2292 else:
2293 self.assertIn(change.data['number'], tested_change_ids)
2294
James E. Blaircc324192017-04-19 14:36:08 -07002295 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002296 def test_irrelevant_files_match_skips_job(self):
2297 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002298
James E. Blaircc324192017-04-19 14:36:08 -07002299 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002300 def test_irrelevant_files_no_match_runs_job(self):
2301 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002302
James E. Blaircc324192017-04-19 14:36:08 -07002303 @simple_layout('layouts/inheritance.yaml')
Clint Byrum85493602016-11-18 11:59:47 -08002304 def test_inherited_jobs_keep_matchers(self):
Clint Byrum85493602016-11-18 11:59:47 -08002305 files = {'ignoreme': 'ignored\n'}
2306
2307 change = self.fake_gerrit.addFakeChange('org/project',
2308 'master',
2309 'test irrelevant-files',
2310 files=files)
2311 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2312 self.waitUntilSettled()
2313
2314 run_jobs = set([build.name for build in self.history])
2315
2316 self.assertEqual(set(['project-test-nomatch-starts-empty',
2317 'project-test-nomatch-starts-full']), run_jobs)
2318
James E. Blairaf8b2082017-10-03 15:38:27 -07002319 @simple_layout('layouts/job-vars.yaml')
2320 def test_inherited_job_variables(self):
2321 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2322 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2323 self.waitUntilSettled()
2324 self.assertHistory([
2325 dict(name='parentjob', result='SUCCESS'),
2326 dict(name='child1', result='SUCCESS'),
2327 dict(name='child2', result='SUCCESS'),
2328 dict(name='child3', result='SUCCESS'),
2329 ], ordered=False)
2330 j = self.getJobFromHistory('parentjob')
2331 rp = set([p['name'] for p in j.parameters['projects']])
2332 self.assertEqual(j.parameters['vars']['override'], 0)
2333 self.assertEqual(j.parameters['vars']['child1override'], 0)
2334 self.assertEqual(j.parameters['vars']['parent'], 0)
2335 self.assertFalse('child1' in j.parameters['vars'])
2336 self.assertFalse('child2' in j.parameters['vars'])
2337 self.assertFalse('child3' in j.parameters['vars'])
2338 self.assertEqual(rp, set(['org/project', 'org/project0',
2339 'org/project0']))
2340 j = self.getJobFromHistory('child1')
2341 rp = set([p['name'] for p in j.parameters['projects']])
2342 self.assertEqual(j.parameters['vars']['override'], 1)
2343 self.assertEqual(j.parameters['vars']['child1override'], 1)
2344 self.assertEqual(j.parameters['vars']['parent'], 0)
2345 self.assertEqual(j.parameters['vars']['child1'], 1)
2346 self.assertFalse('child2' in j.parameters['vars'])
2347 self.assertFalse('child3' in j.parameters['vars'])
2348 self.assertEqual(rp, set(['org/project', 'org/project0',
2349 'org/project1']))
2350 j = self.getJobFromHistory('child2')
2351 rp = set([p['name'] for p in j.parameters['projects']])
2352 self.assertEqual(j.parameters['vars']['override'], 2)
2353 self.assertEqual(j.parameters['vars']['child1override'], 0)
2354 self.assertEqual(j.parameters['vars']['parent'], 0)
2355 self.assertFalse('child1' in j.parameters['vars'])
2356 self.assertEqual(j.parameters['vars']['child2'], 2)
2357 self.assertFalse('child3' in j.parameters['vars'])
2358 self.assertEqual(rp, set(['org/project', 'org/project0',
2359 'org/project2']))
2360 j = self.getJobFromHistory('child3')
2361 rp = set([p['name'] for p in j.parameters['projects']])
2362 self.assertEqual(j.parameters['vars']['override'], 3)
2363 self.assertEqual(j.parameters['vars']['child1override'], 0)
2364 self.assertEqual(j.parameters['vars']['parent'], 0)
2365 self.assertFalse('child1' in j.parameters['vars'])
2366 self.assertFalse('child2' in j.parameters['vars'])
2367 self.assertEqual(j.parameters['vars']['child3'], 3)
2368 self.assertEqual(rp, set(['org/project', 'org/project0',
2369 'org/project3']))
2370
James E. Blairc8a1e052014-02-25 09:29:26 -08002371 def test_queue_names(self):
2372 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002373 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002374 (trusted, project1) = tenant.getProject('org/project1')
2375 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002376 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2377 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2378 self.assertEqual(q1.name, 'integrated')
2379 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002380
James E. Blair64ed6f22013-07-10 14:07:23 -07002381 def test_queue_precedence(self):
2382 "Test that queue precedence works"
2383
2384 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002385 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002386 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2387 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002388 A.addApproval('Code-Review', 2)
2389 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002390
2391 self.waitUntilSettled()
2392 self.gearman_server.hold_jobs_in_queue = False
2393 self.gearman_server.release()
2394 self.waitUntilSettled()
2395
James E. Blair8de58bd2013-07-18 16:23:33 -07002396 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002397 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002398 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002399 self.waitUntilSettled()
2400
James E. Blair64ed6f22013-07-10 14:07:23 -07002401 self.log.debug(self.history)
2402 self.assertEqual(self.history[0].pipeline, 'gate')
2403 self.assertEqual(self.history[1].pipeline, 'check')
2404 self.assertEqual(self.history[2].pipeline, 'gate')
2405 self.assertEqual(self.history[3].pipeline, 'gate')
2406 self.assertEqual(self.history[4].pipeline, 'check')
2407 self.assertEqual(self.history[5].pipeline, 'check')
2408
Clark Boylana5edbe42014-06-03 16:39:10 -07002409 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002410 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002411 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002412 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002413 A.addApproval('Code-Review', 2)
2414 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002415 self.waitUntilSettled()
2416
Paul Belanger174a8272017-03-14 13:20:10 -04002417 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002418 self.waitUntilSettled()
2419
James E. Blair1843a552013-07-03 14:19:52 -07002420 port = self.webapp.server.socket.getsockname()[1]
2421
Adam Gandelman77a12c72017-02-03 17:43:43 -08002422 req = urllib.request.Request(
2423 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002424 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002425 headers = f.info()
2426 self.assertIn('Content-Length', headers)
2427 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002428 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2429 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002430 self.assertIn('Access-Control-Allow-Origin', headers)
2431 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002432 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002433 self.assertIn('Expires', headers)
Clint Byrumf322fe22017-05-10 20:53:12 -07002434 data = f.read().decode('utf8')
James E. Blair1843a552013-07-03 14:19:52 -07002435
Paul Belanger174a8272017-03-14 13:20:10 -04002436 self.executor_server.hold_jobs_in_build = False
2437 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002438 self.waitUntilSettled()
2439
2440 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002441 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002442 for p in data['pipelines']:
2443 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002444 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002445 self.assertEqual(q['window'], 20)
2446 else:
2447 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002448 for head in q['heads']:
2449 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002450 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002451 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002452 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002453 status_jobs.append(job)
2454 self.assertEqual('project-merge', status_jobs[0]['name'])
Monty Taylorde8242c2017-02-23 20:29:53 -06002455 # TODO(mordred) pull uuids from self.builds
Monty Taylor51139a02016-05-24 11:28:10 -05002456 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002457 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2458 uuid=status_jobs[0]['uuid']),
2459 status_jobs[0]['url'])
2460 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002461 'finger://{hostname}/{uuid}'.format(
2462 hostname=self.executor_server.hostname,
2463 uuid=status_jobs[0]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002464 status_jobs[0]['finger_url'])
Monty Taylorde8242c2017-02-23 20:29:53 -06002465 # TOOD(mordred) configure a success-url on the base job
Monty Taylor51139a02016-05-24 11:28:10 -05002466 self.assertEqual(
2467 'finger://{hostname}/{uuid}'.format(
2468 hostname=self.executor_server.hostname,
2469 uuid=status_jobs[0]['uuid']),
2470 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002471 self.assertEqual('project-test1', status_jobs[1]['name'])
Monty Taylor51139a02016-05-24 11:28:10 -05002472 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002473 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2474 uuid=status_jobs[1]['uuid']),
2475 status_jobs[1]['url'])
2476 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002477 'finger://{hostname}/{uuid}'.format(
2478 hostname=self.executor_server.hostname,
2479 uuid=status_jobs[1]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002480 status_jobs[1]['finger_url'])
Monty Taylor51139a02016-05-24 11:28:10 -05002481 self.assertEqual(
2482 'finger://{hostname}/{uuid}'.format(
2483 hostname=self.executor_server.hostname,
2484 uuid=status_jobs[1]['uuid']),
2485 status_jobs[1]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002486
2487 self.assertEqual('project-test2', status_jobs[2]['name'])
Monty Taylor51139a02016-05-24 11:28:10 -05002488 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002489 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2490 uuid=status_jobs[2]['uuid']),
2491 status_jobs[2]['url'])
2492 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002493 'finger://{hostname}/{uuid}'.format(
2494 hostname=self.executor_server.hostname,
2495 uuid=status_jobs[2]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002496 status_jobs[2]['finger_url'])
Monty Taylor51139a02016-05-24 11:28:10 -05002497 self.assertEqual(
2498 'finger://{hostname}/{uuid}'.format(
2499 hostname=self.executor_server.hostname,
2500 uuid=status_jobs[2]['uuid']),
2501 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002502
Tobias Henkel65639f82017-07-10 10:25:42 +02002503 # check job dependencies
2504 self.assertIsNotNone(status_jobs[0]['dependencies'])
2505 self.assertIsNotNone(status_jobs[1]['dependencies'])
2506 self.assertIsNotNone(status_jobs[2]['dependencies'])
2507 self.assertEqual(len(status_jobs[0]['dependencies']), 0)
2508 self.assertEqual(len(status_jobs[1]['dependencies']), 1)
2509 self.assertEqual(len(status_jobs[2]['dependencies']), 1)
2510 self.assertIn('project-merge', status_jobs[1]['dependencies'])
2511 self.assertIn('project-merge', status_jobs[2]['dependencies'])
2512
James E. Blair419a8672017-10-18 14:48:25 -07002513 def test_reconfigure_merge(self):
2514 """Test that two reconfigure events are merged"""
2515
2516 tenant = self.sched.abide.tenants['tenant-one']
2517 (trusted, project) = tenant.getProject('org/project')
2518
2519 self.sched.run_handler_lock.acquire()
2520 self.assertEqual(self.sched.management_event_queue.qsize(), 0)
2521
2522 self.sched.reconfigureTenant(tenant, project)
2523 self.assertEqual(self.sched.management_event_queue.qsize(), 1)
2524
2525 self.sched.reconfigureTenant(tenant, project)
2526 # The second event should have been combined with the first
2527 # so we should still only have one entry.
2528 self.assertEqual(self.sched.management_event_queue.qsize(), 1)
2529
2530 self.sched.run_handler_lock.release()
2531 self.waitUntilSettled()
2532
2533 self.assertEqual(self.sched.management_event_queue.qsize(), 0)
2534
James E. Blaircdccd972013-07-01 12:10:22 -07002535 def test_live_reconfiguration(self):
2536 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002537 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002538 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002539 A.addApproval('Code-Review', 2)
2540 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002541 self.waitUntilSettled()
2542
2543 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002544 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002545
Paul Belanger174a8272017-03-14 13:20:10 -04002546 self.executor_server.hold_jobs_in_build = False
2547 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002548 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002549 self.assertEqual(self.getJobFromHistory('project-merge').result,
2550 'SUCCESS')
2551 self.assertEqual(self.getJobFromHistory('project-test1').result,
2552 'SUCCESS')
2553 self.assertEqual(self.getJobFromHistory('project-test2').result,
2554 'SUCCESS')
2555 self.assertEqual(A.data['status'], 'MERGED')
2556 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002557
James E. Blair027ba992017-09-20 13:48:32 -07002558 def test_live_reconfiguration_abort(self):
2559 # Raise an exception during reconfiguration and verify we
2560 # still function.
2561 self.executor_server.hold_jobs_in_build = True
2562 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2563 A.addApproval('Code-Review', 2)
2564 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2565 self.waitUntilSettled()
2566
2567 tenant = self.sched.abide.tenants.get('tenant-one')
2568 pipeline = tenant.layout.pipelines['gate']
2569 change = pipeline.getAllItems()[0].change
2570 # Set this to an invalid value to cause an exception during
2571 # reconfiguration.
2572 change.branch = None
2573
2574 self.sched.reconfigure(self.config)
2575 self.waitUntilSettled()
2576
2577 self.executor_server.hold_jobs_in_build = False
2578 self.executor_server.release()
2579
2580 self.waitUntilSettled()
2581 self.assertEqual(self.getJobFromHistory('project-merge').result,
2582 'ABORTED')
2583 self.assertEqual(A.data['status'], 'NEW')
2584 # The final report fails because of the invalid value set above.
2585 self.assertEqual(A.reported, 1)
2586
James E. Blair6bc782d2015-07-17 16:20:21 -07002587 def test_live_reconfiguration_merge_conflict(self):
2588 # A real-world bug: a change in a gate queue has a merge
2589 # conflict and a job is added to its project while it's
2590 # sitting in the queue. The job gets added to the change and
2591 # enqueued and the change gets stuck.
Paul Belanger174a8272017-03-14 13:20:10 -04002592 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002593
2594 # This change is fine. It's here to stop the queue long
2595 # enough for the next change to be subject to the
2596 # reconfiguration, as well as to provide a conflict for the
2597 # next change. This change will succeed and merge.
2598 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum073c00b2017-05-01 13:41:23 -07002599 A.addPatchset({'conflict': 'A'})
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002600 A.addApproval('Code-Review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002601
2602 # This change will be in merge conflict. During the
2603 # reconfiguration, we will add a job. We want to make sure
2604 # that doesn't cause it to get stuck.
2605 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Clint Byrum073c00b2017-05-01 13:41:23 -07002606 B.addPatchset({'conflict': 'B'})
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002607 B.addApproval('Code-Review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002608
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002609 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2610 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002611
2612 self.waitUntilSettled()
2613
2614 # No jobs have run yet
2615 self.assertEqual(A.data['status'], 'NEW')
2616 self.assertEqual(A.reported, 1)
2617 self.assertEqual(B.data['status'], 'NEW')
James E. Blair6bc782d2015-07-17 16:20:21 -07002618 self.assertEqual(len(self.history), 0)
2619
2620 # Add the "project-test3" job.
Clint Byrum073c00b2017-05-01 13:41:23 -07002621 self.commitConfigUpdate('common-config',
2622 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002623 self.sched.reconfigure(self.config)
2624 self.waitUntilSettled()
2625
Paul Belanger174a8272017-03-14 13:20:10 -04002626 self.executor_server.hold_jobs_in_build = False
2627 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002628 self.waitUntilSettled()
2629
2630 self.assertEqual(A.data['status'], 'MERGED')
2631 self.assertEqual(A.reported, 2)
2632 self.assertEqual(B.data['status'], 'NEW')
Tobias Henkel9842bd72017-05-16 13:40:03 +02002633 self.assertIn('Merge Failed', B.messages[-1])
James E. Blair6bc782d2015-07-17 16:20:21 -07002634 self.assertEqual(self.getJobFromHistory('project-merge').result,
2635 'SUCCESS')
2636 self.assertEqual(self.getJobFromHistory('project-test1').result,
2637 'SUCCESS')
2638 self.assertEqual(self.getJobFromHistory('project-test2').result,
2639 'SUCCESS')
2640 self.assertEqual(self.getJobFromHistory('project-test3').result,
2641 'SUCCESS')
2642 self.assertEqual(len(self.history), 4)
2643
James E. Blair400e8fd2015-07-30 17:44:45 -07002644 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002645 # An extrapolation of test_live_reconfiguration_merge_conflict
2646 # that tests a job added to a job tree with a failed root does
2647 # not run.
Paul Belanger174a8272017-03-14 13:20:10 -04002648 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002649
2650 # This change is fine. It's here to stop the queue long
2651 # enough for the next change to be subject to the
2652 # reconfiguration. This change will succeed and merge.
2653 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum3147d652017-05-01 14:01:42 -07002654 A.addPatchset({'conflict': 'A'})
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002655 A.addApproval('Code-Review', 2)
2656 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002657 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002658 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002659 self.waitUntilSettled()
2660
2661 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002662 self.executor_server.failJob('project-merge', B)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002663 B.addApproval('Code-Review', 2)
2664 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002665 self.waitUntilSettled()
2666
Paul Belanger174a8272017-03-14 13:20:10 -04002667 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002668 self.waitUntilSettled()
2669
2670 # Both -merge jobs have run, but no others.
2671 self.assertEqual(A.data['status'], 'NEW')
2672 self.assertEqual(A.reported, 1)
2673 self.assertEqual(B.data['status'], 'NEW')
2674 self.assertEqual(B.reported, 1)
2675 self.assertEqual(self.history[0].result, 'SUCCESS')
2676 self.assertEqual(self.history[0].name, 'project-merge')
2677 self.assertEqual(self.history[1].result, 'FAILURE')
2678 self.assertEqual(self.history[1].name, 'project-merge')
2679 self.assertEqual(len(self.history), 2)
2680
2681 # Add the "project-test3" job.
Clint Byrum3147d652017-05-01 14:01:42 -07002682 self.commitConfigUpdate('common-config',
2683 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002684 self.sched.reconfigure(self.config)
2685 self.waitUntilSettled()
2686
Paul Belanger174a8272017-03-14 13:20:10 -04002687 self.executor_server.hold_jobs_in_build = False
2688 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002689 self.waitUntilSettled()
2690
2691 self.assertEqual(A.data['status'], 'MERGED')
2692 self.assertEqual(A.reported, 2)
2693 self.assertEqual(B.data['status'], 'NEW')
2694 self.assertEqual(B.reported, 2)
2695 self.assertEqual(self.history[0].result, 'SUCCESS')
2696 self.assertEqual(self.history[0].name, 'project-merge')
2697 self.assertEqual(self.history[1].result, 'FAILURE')
2698 self.assertEqual(self.history[1].name, 'project-merge')
2699 self.assertEqual(self.history[2].result, 'SUCCESS')
2700 self.assertEqual(self.history[3].result, 'SUCCESS')
2701 self.assertEqual(self.history[4].result, 'SUCCESS')
2702 self.assertEqual(len(self.history), 5)
2703
James E. Blair400e8fd2015-07-30 17:44:45 -07002704 def test_live_reconfiguration_failed_job(self):
2705 # Test that a change with a removed failing job does not
2706 # disrupt reconfiguration. If a change has a failed job and
2707 # that job is removed during a reconfiguration, we observed a
2708 # bug where the code to re-set build statuses would run on
2709 # that build and raise an exception because the job no longer
2710 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002711 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002712
2713 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2714
2715 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002716 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002717
2718 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2719 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002720 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002721 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002722 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002723 self.waitUntilSettled()
2724
2725 self.assertEqual(A.data['status'], 'NEW')
2726 self.assertEqual(A.reported, 0)
2727
2728 self.assertEqual(self.getJobFromHistory('project-merge').result,
2729 'SUCCESS')
2730 self.assertEqual(self.getJobFromHistory('project-test1').result,
2731 'FAILURE')
2732 self.assertEqual(len(self.history), 2)
2733
2734 # Remove the test1 job.
Clint Byrum841a58c2017-05-01 14:17:21 -07002735 self.commitConfigUpdate('common-config',
2736 'layouts/live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002737 self.sched.reconfigure(self.config)
2738 self.waitUntilSettled()
2739
Paul Belanger174a8272017-03-14 13:20:10 -04002740 self.executor_server.hold_jobs_in_build = False
2741 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002742 self.waitUntilSettled()
2743
2744 self.assertEqual(self.getJobFromHistory('project-test2').result,
2745 'SUCCESS')
2746 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2747 'SUCCESS')
2748 self.assertEqual(len(self.history), 4)
2749
2750 self.assertEqual(A.data['status'], 'NEW')
2751 self.assertEqual(A.reported, 1)
2752 self.assertIn('Build succeeded', A.messages[0])
2753 # Ensure the removed job was not included in the report.
2754 self.assertNotIn('project-test1', A.messages[0])
2755
James E. Blairfe707d12015-08-05 15:18:15 -07002756 def test_live_reconfiguration_shared_queue(self):
2757 # Test that a change with a failing job which was removed from
2758 # this project but otherwise still exists in the system does
2759 # not disrupt reconfiguration.
2760
Paul Belanger174a8272017-03-14 13:20:10 -04002761 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002762
2763 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2764
Paul Belanger174a8272017-03-14 13:20:10 -04002765 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002766
2767 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2768 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002769 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002770 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002771 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002772 self.waitUntilSettled()
2773
2774 self.assertEqual(A.data['status'], 'NEW')
2775 self.assertEqual(A.reported, 0)
2776
Clint Byrum69663d42017-05-01 14:51:04 -07002777 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002778 'SUCCESS')
2779 self.assertEqual(self.getJobFromHistory(
2780 'project1-project2-integration').result, 'FAILURE')
2781 self.assertEqual(len(self.history), 2)
2782
2783 # Remove the integration job.
Clint Byrum69663d42017-05-01 14:51:04 -07002784 self.commitConfigUpdate(
2785 'common-config',
2786 'layouts/live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002787 self.sched.reconfigure(self.config)
2788 self.waitUntilSettled()
2789
Paul Belanger174a8272017-03-14 13:20:10 -04002790 self.executor_server.hold_jobs_in_build = False
2791 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002792 self.waitUntilSettled()
2793
Clint Byrum69663d42017-05-01 14:51:04 -07002794 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002795 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002796 self.assertEqual(self.getJobFromHistory('project-test1').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002797 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002798 self.assertEqual(self.getJobFromHistory('project-test2').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002799 'SUCCESS')
2800 self.assertEqual(self.getJobFromHistory(
2801 'project1-project2-integration').result, 'FAILURE')
2802 self.assertEqual(len(self.history), 4)
2803
2804 self.assertEqual(A.data['status'], 'NEW')
2805 self.assertEqual(A.reported, 1)
2806 self.assertIn('Build succeeded', A.messages[0])
2807 # Ensure the removed job was not included in the report.
2808 self.assertNotIn('project1-project2-integration', A.messages[0])
2809
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002810 def test_double_live_reconfiguration_shared_queue(self):
2811 # This was a real-world regression. A change is added to
2812 # gate; a reconfigure happens, a second change which depends
2813 # on the first is added, and a second reconfiguration happens.
2814 # Ensure that both changes merge.
2815
2816 # A failure may indicate incorrect caching or cleaning up of
2817 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002818 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002819
2820 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2821 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2822 B.setDependsOn(A, 1)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002823 A.addApproval('Code-Review', 2)
2824 B.addApproval('Code-Review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002825
2826 # Add the parent change.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002827 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002828 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002829 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002830 self.waitUntilSettled()
2831
2832 # Reconfigure (with only one change in the pipeline).
2833 self.sched.reconfigure(self.config)
2834 self.waitUntilSettled()
2835
2836 # Add the child change.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002837 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002838 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002839 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002840 self.waitUntilSettled()
2841
2842 # Reconfigure (with both in the pipeline).
2843 self.sched.reconfigure(self.config)
2844 self.waitUntilSettled()
2845
Paul Belanger174a8272017-03-14 13:20:10 -04002846 self.executor_server.hold_jobs_in_build = False
2847 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002848 self.waitUntilSettled()
2849
2850 self.assertEqual(len(self.history), 8)
2851
2852 self.assertEqual(A.data['status'], 'MERGED')
2853 self.assertEqual(A.reported, 2)
2854 self.assertEqual(B.data['status'], 'MERGED')
2855 self.assertEqual(B.reported, 2)
2856
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002857 def test_live_reconfiguration_del_project(self):
2858 # Test project deletion from layout
2859 # while changes are enqueued
2860
Paul Belanger174a8272017-03-14 13:20:10 -04002861 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002862 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2863 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2864 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2865
2866 # A Depends-On: B
2867 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2868 A.subject, B.data['id'])
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002869 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002870
2871 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2872 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2873 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002874 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002875 self.waitUntilSettled()
2876 self.assertEqual(len(self.builds), 5)
2877
2878 # This layout defines only org/project, not org/project1
James E. Blair31cb3e82017-04-20 13:08:56 -07002879 self.commitConfigUpdate(
2880 'common-config',
2881 'layouts/live-reconfiguration-del-project.yaml')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002882 self.sched.reconfigure(self.config)
2883 self.waitUntilSettled()
2884
2885 # Builds for C aborted, builds for A succeed,
2886 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002887 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002888 self.assertEqual(job_c.changes, '3,1')
2889 self.assertEqual(job_c.result, 'ABORTED')
2890
Paul Belanger174a8272017-03-14 13:20:10 -04002891 self.executor_server.hold_jobs_in_build = False
2892 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002893 self.waitUntilSettled()
2894
Clint Byrum0149ada2017-04-04 12:22:01 -07002895 self.assertEqual(
2896 self.getJobFromHistory('project-test1', 'org/project').changes,
2897 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002898
2899 self.assertEqual(A.data['status'], 'NEW')
2900 self.assertEqual(B.data['status'], 'NEW')
2901 self.assertEqual(C.data['status'], 'NEW')
2902 self.assertEqual(A.reported, 1)
2903 self.assertEqual(B.reported, 0)
2904 self.assertEqual(C.reported, 0)
2905
Clint Byrum0149ada2017-04-04 12:22:01 -07002906 tenant = self.sched.abide.tenants.get('tenant-one')
2907 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002908 self.assertIn('Build succeeded', A.messages[0])
2909
James E. Blair287c06d2013-07-24 10:39:30 -07002910 def test_delayed_repo_init(self):
James E. Blair287c06d2013-07-24 10:39:30 -07002911 self.init_repo("org/new-project")
Clint Byrum627ba362017-08-14 13:20:40 -07002912 files = {'README': ''}
2913 self.addCommitToRepo("org/new-project", 'Initial commit',
2914 files=files, tag='init')
2915 self.newTenantConfig('tenants/delayed-repo-init.yaml')
2916 self.commitConfigUpdate(
2917 'common-config',
2918 'layouts/delayed-repo-init.yaml')
2919 self.sched.reconfigure(self.config)
2920 self.waitUntilSettled()
2921
James E. Blair287c06d2013-07-24 10:39:30 -07002922 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2923
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002924 A.addApproval('Code-Review', 2)
2925 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002926 self.waitUntilSettled()
2927 self.assertEqual(self.getJobFromHistory('project-merge').result,
2928 'SUCCESS')
2929 self.assertEqual(self.getJobFromHistory('project-test1').result,
2930 'SUCCESS')
2931 self.assertEqual(self.getJobFromHistory('project-test2').result,
2932 'SUCCESS')
2933 self.assertEqual(A.data['status'], 'MERGED')
2934 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002935
James E. Blair9ea70072017-04-19 16:05:30 -07002936 @simple_layout('layouts/repo-deleted.yaml')
Clark Boylan6dbbc482013-10-18 10:57:31 -07002937 def test_repo_deleted(self):
Clark Boylan6dbbc482013-10-18 10:57:31 -07002938 self.init_repo("org/delete-project")
2939 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2940
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002941 A.addApproval('Code-Review', 2)
2942 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002943 self.waitUntilSettled()
2944 self.assertEqual(self.getJobFromHistory('project-merge').result,
2945 'SUCCESS')
2946 self.assertEqual(self.getJobFromHistory('project-test1').result,
2947 'SUCCESS')
2948 self.assertEqual(self.getJobFromHistory('project-test2').result,
2949 'SUCCESS')
2950 self.assertEqual(A.data['status'], 'MERGED')
2951 self.assertEqual(A.reported, 2)
2952
2953 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002954 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002955 if os.path.exists(os.path.join(self.merger_src_root, p)):
2956 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002957 if os.path.exists(os.path.join(self.executor_src_root, p)):
2958 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002959
2960 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2961
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002962 B.addApproval('Code-Review', 2)
2963 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002964 self.waitUntilSettled()
2965 self.assertEqual(self.getJobFromHistory('project-merge').result,
2966 'SUCCESS')
2967 self.assertEqual(self.getJobFromHistory('project-test1').result,
2968 'SUCCESS')
2969 self.assertEqual(self.getJobFromHistory('project-test2').result,
2970 'SUCCESS')
2971 self.assertEqual(B.data['status'], 'MERGED')
2972 self.assertEqual(B.reported, 2)
2973
James E. Blair892cca62017-08-09 11:36:58 -07002974 @simple_layout('layouts/untrusted-secrets.yaml')
2975 def test_untrusted_secrets(self):
2976 "Test untrusted secrets"
2977 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2978 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2979 self.waitUntilSettled()
2980
2981 self.assertHistory([])
2982 self.assertEqual(A.patchsets[0]['approvals'][0]['value'], "-1")
James E. Blair8eb564a2017-08-10 09:21:41 -07002983 self.assertIn('does not allow post-review job',
James E. Blair892cca62017-08-09 11:36:58 -07002984 A.messages[0])
2985
James E. Blaire68d43f2017-04-19 14:03:30 -07002986 @simple_layout('layouts/tags.yaml')
James E. Blair456f2fb2016-02-09 09:29:33 -08002987 def test_tags(self):
2988 "Test job tags"
James E. Blair456f2fb2016-02-09 09:29:33 -08002989 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2990 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2991 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2992 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2993 self.waitUntilSettled()
2994
James E. Blaire68d43f2017-04-19 14:03:30 -07002995 self.assertEqual(len(self.history), 2)
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002996
2997 results = {self.getJobFromHistory('merge',
James E. Blair9d46f092017-07-20 16:06:20 -07002998 project='org/project1').uuid: ['extratag', 'merge'],
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002999 self.getJobFromHistory('merge',
James E. Blair9d46f092017-07-20 16:06:20 -07003000 project='org/project2').uuid: ['merge']}
James E. Blair456f2fb2016-02-09 09:29:33 -08003001
3002 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06003003 self.assertEqual(results.get(build.uuid, ''),
James E. Blair9d46f092017-07-20 16:06:20 -07003004 build.parameters['zuul'].get('jobtags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08003005
James E. Blair63bb0ef2013-07-29 17:14:51 -07003006 def test_timer(self):
3007 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003008 # This test can not use simple_layout because it must start
3009 # with a configuration which does not include a
3010 # timer-triggered job so that we have an opportunity to set
3011 # the hold flag before the first job.
James E. Blair21037782017-07-19 11:56:55 -07003012 self.create_branch('org/project', 'stable')
Paul Belanger174a8272017-03-14 13:20:10 -04003013 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003014 self.commitConfigUpdate('common-config', 'layouts/timer.yaml')
James E. Blair63bb0ef2013-07-29 17:14:51 -07003015 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07003016
Clark Boylan3ee090a2014-04-03 20:55:09 -07003017 # The pipeline triggers every second, so we should have seen
3018 # several by now.
3019 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07003020 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07003021
3022 self.assertEqual(len(self.builds), 2)
3023
James E. Blair63bb0ef2013-07-29 17:14:51 -07003024 port = self.webapp.server.socket.getsockname()[1]
3025
Clint Byrum5e729e92017-02-08 06:34:57 -08003026 req = urllib.request.Request(
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003027 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07003028 f = urllib.request.urlopen(req)
Clint Byrumf322fe22017-05-10 20:53:12 -07003029 data = f.read().decode('utf8')
James E. Blair63bb0ef2013-07-29 17:14:51 -07003030
Paul Belanger174a8272017-03-14 13:20:10 -04003031 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07003032 # Stop queuing timer triggered jobs so that the assertions
3033 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003034 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003035 self.sched.reconfigure(self.config)
James E. Blair78ae4782017-08-02 14:19:10 -07003036 self.waitUntilSettled()
3037 # If APScheduler is in mid-event when we remove the job, we
3038 # can end up with one more event firing, so give it an extra
3039 # second to settle.
3040 time.sleep(1)
3041 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003042 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07003043 self.waitUntilSettled()
3044
James E. Blair21037782017-07-19 11:56:55 -07003045 self.assertHistory([
3046 dict(name='project-bitrot', result='SUCCESS',
3047 ref='refs/heads/master'),
3048 dict(name='project-bitrot', result='SUCCESS',
3049 ref='refs/heads/stable'),
3050 ], ordered=False)
James E. Blair63bb0ef2013-07-29 17:14:51 -07003051
3052 data = json.loads(data)
3053 status_jobs = set()
3054 for p in data['pipelines']:
3055 for q in p['change_queues']:
3056 for head in q['heads']:
3057 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07003058 for job in change['jobs']:
3059 status_jobs.add(job['name'])
James E. Blair21037782017-07-19 11:56:55 -07003060 self.assertIn('project-bitrot', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003061
James E. Blair4f6033c2014-03-27 15:49:09 -07003062 def test_idle(self):
3063 "Test that frequent periodic jobs work"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003064 # This test can not use simple_layout because it must start
3065 # with a configuration which does not include a
3066 # timer-triggered job so that we have an opportunity to set
3067 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04003068 self.executor_server.hold_jobs_in_build = True
James E. Blair4f6033c2014-03-27 15:49:09 -07003069
Clark Boylan3ee090a2014-04-03 20:55:09 -07003070 for x in range(1, 3):
3071 # Test that timer triggers periodic jobs even across
3072 # layout config reloads.
3073 # Start timer trigger
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003074 self.commitConfigUpdate('common-config',
3075 'layouts/idle.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003076 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08003077 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07003078
Clark Boylan3ee090a2014-04-03 20:55:09 -07003079 # The pipeline triggers every second, so we should have seen
3080 # several by now.
3081 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07003082
3083 # Stop queuing timer triggered jobs so that the assertions
3084 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003085 self.commitConfigUpdate('common-config',
3086 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003087 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08003088 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07003089 # If APScheduler is in mid-event when we remove the job,
3090 # we can end up with one more event firing, so give it an
3091 # extra second to settle.
3092 time.sleep(1)
3093 self.waitUntilSettled()
James E. Blair21037782017-07-19 11:56:55 -07003094 self.assertEqual(len(self.builds), 1,
Clint Byrum58264dc2017-02-07 21:21:22 -08003095 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04003096 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003097 self.waitUntilSettled()
3098 self.assertEqual(len(self.builds), 0)
James E. Blair21037782017-07-19 11:56:55 -07003099 self.assertEqual(len(self.history), x)
James E. Blair4f6033c2014-03-27 15:49:09 -07003100
James E. Blaircc324192017-04-19 14:36:08 -07003101 @simple_layout('layouts/smtp.yaml')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003102 def test_check_smtp_pool(self):
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003103 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3104 self.waitUntilSettled()
3105
3106 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3107 self.waitUntilSettled()
3108
James E. Blairff80a2f2013-12-27 13:24:06 -08003109 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003110
3111 # A.messages only holds what FakeGerrit places in it. Thus we
3112 # work on the knowledge of what the first message should be as
3113 # it is only configured to go to SMTP.
3114
3115 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003116 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003117 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003118 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003119 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08003120 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003121
3122 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003123 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003124 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003125 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003126 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08003127 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08003128
James E. Blaire5910202013-12-27 09:50:31 -08003129 def test_timer_smtp(self):
3130 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003131 # This test can not use simple_layout because it must start
3132 # with a configuration which does not include a
3133 # timer-triggered job so that we have an opportunity to set
3134 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04003135 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003136 self.commitConfigUpdate('common-config', 'layouts/timer-smtp.yaml')
James E. Blaire5910202013-12-27 09:50:31 -08003137 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08003138
Clark Boylan3ee090a2014-04-03 20:55:09 -07003139 # The pipeline triggers every second, so we should have seen
3140 # several by now.
3141 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08003142 self.waitUntilSettled()
3143
Clark Boylan3ee090a2014-04-03 20:55:09 -07003144 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003145 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003146 self.waitUntilSettled()
3147 self.assertEqual(len(self.history), 2)
3148
James E. Blaire5910202013-12-27 09:50:31 -08003149 self.assertEqual(self.getJobFromHistory(
3150 'project-bitrot-stable-old').result, 'SUCCESS')
3151 self.assertEqual(self.getJobFromHistory(
3152 'project-bitrot-stable-older').result, 'SUCCESS')
3153
James E. Blairff80a2f2013-12-27 13:24:06 -08003154 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08003155
3156 # A.messages only holds what FakeGerrit places in it. Thus we
3157 # work on the knowledge of what the first message should be as
3158 # it is only configured to go to SMTP.
3159
3160 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003161 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08003162 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003163 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08003164 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08003165 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08003166
Clark Boylan3ee090a2014-04-03 20:55:09 -07003167 # Stop queuing timer triggered jobs and let any that may have
3168 # queued through so that end of test assertions pass.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003169 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003170 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07003171 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07003172 # If APScheduler is in mid-event when we remove the job, we
3173 # can end up with one more event firing, so give it an extra
3174 # second to settle.
3175 time.sleep(1)
3176 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003177 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003178 self.waitUntilSettled()
3179
Joshua Hesketh25695cb2017-03-06 12:50:04 +11003180 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00003181 def test_timer_sshkey(self):
3182 "Test that a periodic job can setup SSH key authentication"
3183 self.worker.hold_jobs_in_build = True
3184 self.config.set('zuul', 'layout_config',
3185 'tests/fixtures/layout-timer.yaml')
3186 self.sched.reconfigure(self.config)
3187 self.registerJobs()
3188
3189 # The pipeline triggers every second, so we should have seen
3190 # several by now.
3191 time.sleep(5)
3192 self.waitUntilSettled()
3193
3194 self.assertEqual(len(self.builds), 2)
3195
3196 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
3197 self.assertTrue(os.path.isfile(ssh_wrapper))
3198 with open(ssh_wrapper) as f:
3199 ssh_wrapper_content = f.read()
3200 self.assertIn("fake_id_rsa", ssh_wrapper_content)
3201 # In the unit tests Merger runs in the same process,
3202 # so we see its' environment variables
3203 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
3204
3205 self.worker.release('.*')
3206 self.waitUntilSettled()
3207 self.assertEqual(len(self.history), 2)
3208
3209 self.assertEqual(self.getJobFromHistory(
3210 'project-bitrot-stable-old').result, 'SUCCESS')
3211 self.assertEqual(self.getJobFromHistory(
3212 'project-bitrot-stable-older').result, 'SUCCESS')
3213
3214 # Stop queuing timer triggered jobs and let any that may have
3215 # queued through so that end of test assertions pass.
3216 self.config.set('zuul', 'layout_config',
3217 'tests/fixtures/layout-no-timer.yaml')
3218 self.sched.reconfigure(self.config)
3219 self.registerJobs()
3220 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07003221 # If APScheduler is in mid-event when we remove the job, we
3222 # can end up with one more event firing, so give it an extra
3223 # second to settle.
3224 time.sleep(1)
3225 self.waitUntilSettled()
Evgeny Antyshevda90a502017-02-08 08:42:59 +00003226 self.worker.release('.*')
3227 self.waitUntilSettled()
3228
James E. Blair91e34592015-07-31 16:45:59 -07003229 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08003230 "Test that the RPC client can enqueue a change"
3231 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003232 A.addApproval('Code-Review', 2)
3233 A.addApproval('Approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08003234
3235 client = zuul.rpcclient.RPCClient('127.0.0.1',
3236 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003237 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003238 r = client.enqueue(tenant='tenant-one',
3239 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003240 project='org/project',
3241 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003242 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003243 self.waitUntilSettled()
3244 self.assertEqual(self.getJobFromHistory('project-merge').result,
3245 'SUCCESS')
3246 self.assertEqual(self.getJobFromHistory('project-test1').result,
3247 'SUCCESS')
3248 self.assertEqual(self.getJobFromHistory('project-test2').result,
3249 'SUCCESS')
3250 self.assertEqual(A.data['status'], 'MERGED')
3251 self.assertEqual(A.reported, 2)
3252 self.assertEqual(r, True)
3253
James E. Blair91e34592015-07-31 16:45:59 -07003254 def test_client_enqueue_ref(self):
3255 "Test that the RPC client can enqueue a ref"
James E. Blair289f5932017-07-27 15:02:29 -07003256 p = "review.example.com/org/project"
3257 upstream = self.getUpstreamRepos([p])
3258 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3259 A.setMerged()
3260 A_commit = str(upstream[p].commit('master'))
3261 self.log.debug("A commit: %s" % A_commit)
James E. Blair91e34592015-07-31 16:45:59 -07003262
3263 client = zuul.rpcclient.RPCClient('127.0.0.1',
3264 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003265 self.addCleanup(client.shutdown)
James E. Blair91e34592015-07-31 16:45:59 -07003266 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04003267 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07003268 pipeline='post',
3269 project='org/project',
3270 trigger='gerrit',
3271 ref='master',
3272 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
James E. Blair289f5932017-07-27 15:02:29 -07003273 newrev=A_commit)
James E. Blair91e34592015-07-31 16:45:59 -07003274 self.waitUntilSettled()
3275 job_names = [x.name for x in self.history]
3276 self.assertEqual(len(self.history), 1)
3277 self.assertIn('project-post', job_names)
3278 self.assertEqual(r, True)
3279
James E. Blairad28e912013-11-27 10:43:22 -08003280 def test_client_enqueue_negative(self):
3281 "Test that the RPC client returns errors"
3282 client = zuul.rpcclient.RPCClient('127.0.0.1',
3283 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003284 self.addCleanup(client.shutdown)
James E. Blairad28e912013-11-27 10:43:22 -08003285 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04003286 "Invalid tenant"):
3287 r = client.enqueue(tenant='tenant-foo',
3288 pipeline='gate',
3289 project='org/project',
3290 trigger='gerrit',
3291 change='1,1')
Paul Belangerbaca3132016-11-04 12:49:54 -04003292 self.assertEqual(r, False)
3293
3294 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08003295 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003296 r = client.enqueue(tenant='tenant-one',
3297 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003298 project='project-does-not-exist',
3299 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003300 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003301 self.assertEqual(r, False)
3302
3303 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3304 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003305 r = client.enqueue(tenant='tenant-one',
3306 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08003307 project='org/project',
3308 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003309 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003310 self.assertEqual(r, False)
3311
3312 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3313 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003314 r = client.enqueue(tenant='tenant-one',
3315 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003316 project='org/project',
3317 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08003318 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003319 self.assertEqual(r, False)
3320
3321 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3322 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003323 r = client.enqueue(tenant='tenant-one',
3324 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003325 project='org/project',
3326 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003327 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003328 self.assertEqual(r, False)
3329
3330 self.waitUntilSettled()
3331 self.assertEqual(len(self.history), 0)
3332 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08003333
3334 def test_client_promote(self):
3335 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04003336 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003337 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3338 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3339 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003340 A.addApproval('Code-Review', 2)
3341 B.addApproval('Code-Review', 2)
3342 C.addApproval('Code-Review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003343
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003344 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3345 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3346 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003347
3348 self.waitUntilSettled()
3349
Paul Belangerbaca3132016-11-04 12:49:54 -04003350 tenant = self.sched.abide.tenants.get('tenant-one')
3351 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003352 enqueue_times = {}
3353 for item in items:
3354 enqueue_times[str(item.change)] = item.enqueue_time
3355
James E. Blair36658cf2013-12-06 17:53:48 -08003356 client = zuul.rpcclient.RPCClient('127.0.0.1',
3357 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003358 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003359 r = client.promote(tenant='tenant-one',
3360 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003361 change_ids=['2,1', '3,1'])
3362
Sean Daguef39b9ca2014-01-10 21:34:35 -05003363 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003364 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003365 for item in items:
3366 self.assertEqual(
3367 enqueue_times[str(item.change)], item.enqueue_time)
3368
James E. Blair78acec92014-02-06 07:11:32 -08003369 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003370 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003371 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003372 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003373 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003374 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003375 self.waitUntilSettled()
3376
3377 self.assertEqual(len(self.builds), 6)
3378 self.assertEqual(self.builds[0].name, 'project-test1')
3379 self.assertEqual(self.builds[1].name, 'project-test2')
3380 self.assertEqual(self.builds[2].name, 'project-test1')
3381 self.assertEqual(self.builds[3].name, 'project-test2')
3382 self.assertEqual(self.builds[4].name, 'project-test1')
3383 self.assertEqual(self.builds[5].name, 'project-test2')
3384
Paul Belangerbaca3132016-11-04 12:49:54 -04003385 self.assertTrue(self.builds[0].hasChanges(B))
3386 self.assertFalse(self.builds[0].hasChanges(A))
3387 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003388
Paul Belangerbaca3132016-11-04 12:49:54 -04003389 self.assertTrue(self.builds[2].hasChanges(B))
3390 self.assertTrue(self.builds[2].hasChanges(C))
3391 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003392
Paul Belangerbaca3132016-11-04 12:49:54 -04003393 self.assertTrue(self.builds[4].hasChanges(B))
3394 self.assertTrue(self.builds[4].hasChanges(C))
3395 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003396
Paul Belanger174a8272017-03-14 13:20:10 -04003397 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003398 self.waitUntilSettled()
3399
3400 self.assertEqual(A.data['status'], 'MERGED')
3401 self.assertEqual(A.reported, 2)
3402 self.assertEqual(B.data['status'], 'MERGED')
3403 self.assertEqual(B.reported, 2)
3404 self.assertEqual(C.data['status'], 'MERGED')
3405 self.assertEqual(C.reported, 2)
3406
James E. Blair36658cf2013-12-06 17:53:48 -08003407 self.assertEqual(r, True)
3408
3409 def test_client_promote_dependent(self):
3410 "Test that the RPC client can promote a dependent change"
3411 # C (depends on B) -> B -> A ; then promote C to get:
3412 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003413 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003414 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3415 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3416 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3417
3418 C.setDependsOn(B, 1)
3419
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003420 A.addApproval('Code-Review', 2)
3421 B.addApproval('Code-Review', 2)
3422 C.addApproval('Code-Review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003423
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003424 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3425 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3426 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003427
3428 self.waitUntilSettled()
3429
3430 client = zuul.rpcclient.RPCClient('127.0.0.1',
3431 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003432 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003433 r = client.promote(tenant='tenant-one',
3434 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003435 change_ids=['3,1'])
3436
James E. Blair78acec92014-02-06 07:11:32 -08003437 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003438 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003439 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003440 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003441 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003442 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003443 self.waitUntilSettled()
3444
3445 self.assertEqual(len(self.builds), 6)
3446 self.assertEqual(self.builds[0].name, 'project-test1')
3447 self.assertEqual(self.builds[1].name, 'project-test2')
3448 self.assertEqual(self.builds[2].name, 'project-test1')
3449 self.assertEqual(self.builds[3].name, 'project-test2')
3450 self.assertEqual(self.builds[4].name, 'project-test1')
3451 self.assertEqual(self.builds[5].name, 'project-test2')
3452
Paul Belangerbaca3132016-11-04 12:49:54 -04003453 self.assertTrue(self.builds[0].hasChanges(B))
3454 self.assertFalse(self.builds[0].hasChanges(A))
3455 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003456
Paul Belangerbaca3132016-11-04 12:49:54 -04003457 self.assertTrue(self.builds[2].hasChanges(B))
3458 self.assertTrue(self.builds[2].hasChanges(C))
3459 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003460
Paul Belangerbaca3132016-11-04 12:49:54 -04003461 self.assertTrue(self.builds[4].hasChanges(B))
3462 self.assertTrue(self.builds[4].hasChanges(C))
3463 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003464
Paul Belanger174a8272017-03-14 13:20:10 -04003465 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003466 self.waitUntilSettled()
3467
3468 self.assertEqual(A.data['status'], 'MERGED')
3469 self.assertEqual(A.reported, 2)
3470 self.assertEqual(B.data['status'], 'MERGED')
3471 self.assertEqual(B.reported, 2)
3472 self.assertEqual(C.data['status'], 'MERGED')
3473 self.assertEqual(C.reported, 2)
3474
James E. Blair36658cf2013-12-06 17:53:48 -08003475 self.assertEqual(r, True)
3476
3477 def test_client_promote_negative(self):
3478 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003479 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003480 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003481 A.addApproval('Code-Review', 2)
3482 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003483 self.waitUntilSettled()
3484
3485 client = zuul.rpcclient.RPCClient('127.0.0.1',
3486 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003487 self.addCleanup(client.shutdown)
James E. Blair36658cf2013-12-06 17:53:48 -08003488
3489 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003490 r = client.promote(tenant='tenant-one',
3491 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003492 change_ids=['2,1', '3,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003493 self.assertEqual(r, False)
3494
3495 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003496 r = client.promote(tenant='tenant-one',
3497 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003498 change_ids=['4,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003499 self.assertEqual(r, False)
3500
Paul Belanger174a8272017-03-14 13:20:10 -04003501 self.executor_server.hold_jobs_in_build = False
3502 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003503 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003504
James E. Blaircc324192017-04-19 14:36:08 -07003505 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003506 def test_queue_rate_limiting(self):
3507 "Test that DependentPipelines are rate limited with dep across window"
Paul Belanger174a8272017-03-14 13:20:10 -04003508 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003509 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3510 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3511 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3512
3513 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003514 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003515
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003516 A.addApproval('Code-Review', 2)
3517 B.addApproval('Code-Review', 2)
3518 C.addApproval('Code-Review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003519
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003520 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3521 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3522 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003523 self.waitUntilSettled()
3524
3525 # Only A and B will have their merge jobs queued because
3526 # window is 2.
3527 self.assertEqual(len(self.builds), 2)
3528 self.assertEqual(self.builds[0].name, 'project-merge')
3529 self.assertEqual(self.builds[1].name, 'project-merge')
3530
James E. Blair732ee862017-04-21 07:49:26 -07003531 # Release the merge jobs one at a time.
3532 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003533 self.waitUntilSettled()
James E. Blair732ee862017-04-21 07:49:26 -07003534 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003535 self.waitUntilSettled()
3536
3537 # Only A and B will have their test jobs queued because
3538 # window is 2.
3539 self.assertEqual(len(self.builds), 4)
3540 self.assertEqual(self.builds[0].name, 'project-test1')
3541 self.assertEqual(self.builds[1].name, 'project-test2')
3542 self.assertEqual(self.builds[2].name, 'project-test1')
3543 self.assertEqual(self.builds[3].name, 'project-test2')
3544
Paul Belanger174a8272017-03-14 13:20:10 -04003545 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003546 self.waitUntilSettled()
3547
James E. Blaircc324192017-04-19 14:36:08 -07003548 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003549 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003550 # A failed so window is reduced by 1 to 1.
3551 self.assertEqual(queue.window, 1)
3552 self.assertEqual(queue.window_floor, 1)
3553 self.assertEqual(A.data['status'], 'NEW')
3554
3555 # Gate is reset and only B's merge job is queued because
3556 # window shrunk to 1.
3557 self.assertEqual(len(self.builds), 1)
3558 self.assertEqual(self.builds[0].name, 'project-merge')
3559
Paul Belanger174a8272017-03-14 13:20:10 -04003560 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003561 self.waitUntilSettled()
3562
3563 # Only B's test jobs are queued because window is still 1.
3564 self.assertEqual(len(self.builds), 2)
3565 self.assertEqual(self.builds[0].name, 'project-test1')
3566 self.assertEqual(self.builds[1].name, 'project-test2')
3567
Paul Belanger174a8272017-03-14 13:20:10 -04003568 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003569 self.waitUntilSettled()
3570
3571 # B was successfully merged so window is increased to 2.
3572 self.assertEqual(queue.window, 2)
3573 self.assertEqual(queue.window_floor, 1)
3574 self.assertEqual(B.data['status'], 'MERGED')
3575
3576 # Only C is left and its merge job is queued.
3577 self.assertEqual(len(self.builds), 1)
3578 self.assertEqual(self.builds[0].name, 'project-merge')
3579
Paul Belanger174a8272017-03-14 13:20:10 -04003580 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003581 self.waitUntilSettled()
3582
3583 # After successful merge job the test jobs for C are queued.
3584 self.assertEqual(len(self.builds), 2)
3585 self.assertEqual(self.builds[0].name, 'project-test1')
3586 self.assertEqual(self.builds[1].name, 'project-test2')
3587
Paul Belanger174a8272017-03-14 13:20:10 -04003588 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003589 self.waitUntilSettled()
3590
3591 # C successfully merged so window is bumped to 3.
3592 self.assertEqual(queue.window, 3)
3593 self.assertEqual(queue.window_floor, 1)
3594 self.assertEqual(C.data['status'], 'MERGED')
3595
James E. Blaircc324192017-04-19 14:36:08 -07003596 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003597 def test_queue_rate_limiting_dependent(self):
3598 "Test that DependentPipelines are rate limited with dep in window"
Paul Belanger174a8272017-03-14 13:20:10 -04003599 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003600 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3601 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3602 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3603
3604 B.setDependsOn(A, 1)
3605
Paul Belanger174a8272017-03-14 13:20:10 -04003606 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003607
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003608 A.addApproval('Code-Review', 2)
3609 B.addApproval('Code-Review', 2)
3610 C.addApproval('Code-Review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003611
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003612 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3613 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3614 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003615 self.waitUntilSettled()
3616
3617 # Only A and B will have their merge jobs queued because
3618 # window is 2.
3619 self.assertEqual(len(self.builds), 2)
3620 self.assertEqual(self.builds[0].name, 'project-merge')
3621 self.assertEqual(self.builds[1].name, 'project-merge')
3622
James E. Blairf4a5f022017-04-18 14:01:10 -07003623 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003624
3625 # Only A and B will have their test jobs queued because
3626 # window is 2.
3627 self.assertEqual(len(self.builds), 4)
3628 self.assertEqual(self.builds[0].name, 'project-test1')
3629 self.assertEqual(self.builds[1].name, 'project-test2')
3630 self.assertEqual(self.builds[2].name, 'project-test1')
3631 self.assertEqual(self.builds[3].name, 'project-test2')
3632
Paul Belanger174a8272017-03-14 13:20:10 -04003633 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003634 self.waitUntilSettled()
3635
James E. Blaircc324192017-04-19 14:36:08 -07003636 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003637 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003638 # A failed so window is reduced by 1 to 1.
3639 self.assertEqual(queue.window, 1)
3640 self.assertEqual(queue.window_floor, 1)
3641 self.assertEqual(A.data['status'], 'NEW')
3642 self.assertEqual(B.data['status'], 'NEW')
3643
3644 # Gate is reset and only C's merge job is queued because
3645 # window shrunk to 1 and A and B were dequeued.
3646 self.assertEqual(len(self.builds), 1)
3647 self.assertEqual(self.builds[0].name, 'project-merge')
3648
James E. Blairf4a5f022017-04-18 14:01:10 -07003649 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003650
3651 # Only C's test jobs are queued because window is still 1.
3652 self.assertEqual(len(self.builds), 2)
James E. Blairdf25ddc2017-07-08 07:57:09 -07003653 builds = self.getSortedBuilds()
3654 self.assertEqual(builds[0].name, 'project-test1')
3655 self.assertEqual(builds[1].name, 'project-test2')
Clark Boylan7603a372014-01-21 11:43:20 -08003656
Paul Belanger174a8272017-03-14 13:20:10 -04003657 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003658 self.waitUntilSettled()
3659
3660 # C was successfully merged so window is increased to 2.
3661 self.assertEqual(queue.window, 2)
3662 self.assertEqual(queue.window_floor, 1)
3663 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003664
3665 def test_worker_update_metadata(self):
3666 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003667 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003668
3669 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003670 A.addApproval('Code-Review', 2)
3671 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003672 self.waitUntilSettled()
3673
Clint Byrumd4de79a2017-05-27 11:39:13 -07003674 self.assertEqual(len(self.executor_client.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003675
3676 self.log.debug('Current builds:')
Clint Byrumd4de79a2017-05-27 11:39:13 -07003677 self.log.debug(self.executor_client.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003678
3679 start = time.time()
3680 while True:
3681 if time.time() - start > 10:
3682 raise Exception("Timeout waiting for gearman server to report "
3683 + "back to the client")
Clint Byrumd4de79a2017-05-27 11:39:13 -07003684 build = list(self.executor_client.builds.values())[0]
Monty Tayloreea6bb92017-06-14 11:56:54 -05003685 if build.worker.name == self.executor_server.hostname:
Joshua Heskethba8776a2014-01-12 14:35:40 +08003686 break
3687 else:
3688 time.sleep(0)
3689
3690 self.log.debug(build)
Monty Tayloreea6bb92017-06-14 11:56:54 -05003691 self.assertEqual(self.executor_server.hostname, build.worker.name)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003692
Paul Belanger174a8272017-03-14 13:20:10 -04003693 self.executor_server.hold_jobs_in_build = False
3694 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003695 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003696
James E. Blaircc324192017-04-19 14:36:08 -07003697 @simple_layout('layouts/footer-message.yaml')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003698 def test_footer_message(self):
3699 "Test a pipeline's footer message is correctly added to the report."
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003700 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003701 A.addApproval('Code-Review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003702 self.executor_server.failJob('project-test1', A)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003703 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003704 self.waitUntilSettled()
3705
3706 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003707 B.addApproval('Code-Review', 2)
3708 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003709 self.waitUntilSettled()
3710
3711 self.assertEqual(2, len(self.smtp_messages))
3712
Adam Gandelman82258fd2017-02-07 16:51:58 -08003713 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003714Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003715http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003716
Adam Gandelman82258fd2017-02-07 16:51:58 -08003717 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003718For CI problems and help debugging, contact ci@example.org"""
3719
Adam Gandelman82258fd2017-02-07 16:51:58 -08003720 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3721 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3722 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3723 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003724
Tobias Henkel9842bd72017-05-16 13:40:03 +02003725 @simple_layout('layouts/unmanaged-project.yaml')
3726 def test_unmanaged_project_start_message(self):
3727 "Test start reporting is not done for unmanaged projects."
3728 self.init_repo("org/project", tag='init')
3729 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3730 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3731 self.waitUntilSettled()
3732
3733 self.assertEqual(0, len(A.messages))
3734
Clint Byrumb9de8be2017-05-27 13:49:19 -07003735 @simple_layout('layouts/merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003736 def test_merge_failure_reporters(self):
3737 """Check that the config is set up correctly"""
3738
Clint Byrumb9de8be2017-05-27 13:49:19 -07003739 tenant = self.sched.abide.tenants.get('tenant-one')
Joshua Heskethb7179772014-01-30 23:30:46 +11003740 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003741 "Merge Failed.\n\nThis change or one of its cross-repo "
3742 "dependencies was unable to be automatically merged with the "
3743 "current state of its repository. Please rebase the change and "
3744 "upload a new patchset.",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003745 tenant.layout.pipelines['check'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003746 self.assertEqual(
3747 "The merge failed! For more information...",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003748 tenant.layout.pipelines['gate'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003749
3750 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003751 len(tenant.layout.pipelines['check'].merge_failure_actions), 1)
Joshua Heskethb7179772014-01-30 23:30:46 +11003752 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003753 len(tenant.layout.pipelines['gate'].merge_failure_actions), 2)
Joshua Heskethb7179772014-01-30 23:30:46 +11003754
3755 self.assertTrue(isinstance(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003756 tenant.layout.pipelines['check'].merge_failure_actions[0],
3757 gerritreporter.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003758
3759 self.assertTrue(
3760 (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003761 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003762 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003763 zuul.driver.smtp.smtpreporter.SMTPReporter) and
3764 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003765 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003766 gerritreporter.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003767 ) or (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003768 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003769 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003770 gerritreporter.GerritReporter) and
3771 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003772 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003773 zuul.driver.smtp.smtpreporter.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003774 )
3775 )
3776
James E. Blairec056492016-07-22 09:45:56 -07003777 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003778 def test_merge_failure_reports(self):
3779 """Check that when a change fails to merge the correct message is sent
3780 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003781 self.updateConfigLayout(
3782 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003783 self.sched.reconfigure(self.config)
3784 self.registerJobs()
3785
3786 # Check a test failure isn't reported to SMTP
3787 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003788 A.addApproval('Code-Review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003789 self.executor_server.failJob('project-test1', A)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003790 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003791 self.waitUntilSettled()
3792
3793 self.assertEqual(3, len(self.history)) # 3 jobs
3794 self.assertEqual(0, len(self.smtp_messages))
3795
3796 # Check a merge failure is reported to SMTP
3797 # B should be merged, but C will conflict with B
3798 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3799 B.addPatchset(['conflict'])
3800 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3801 C.addPatchset(['conflict'])
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003802 B.addApproval('Code-Review', 2)
3803 C.addApproval('Code-Review', 2)
3804 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3805 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003806 self.waitUntilSettled()
3807
3808 self.assertEqual(6, len(self.history)) # A and B jobs
3809 self.assertEqual(1, len(self.smtp_messages))
3810 self.assertEqual('The merge failed! For more information...',
3811 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003812
James E. Blairec056492016-07-22 09:45:56 -07003813 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003814 def test_default_merge_failure_reports(self):
3815 """Check that the default merge failure reports are correct."""
3816
3817 # A should report success, B should report merge failure.
3818 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3819 A.addPatchset(['conflict'])
3820 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3821 B.addPatchset(['conflict'])
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003822 A.addApproval('Code-Review', 2)
3823 B.addApproval('Code-Review', 2)
3824 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3825 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003826 self.waitUntilSettled()
3827
3828 self.assertEqual(3, len(self.history)) # A jobs
3829 self.assertEqual(A.reported, 2)
3830 self.assertEqual(B.reported, 2)
3831 self.assertEqual(A.data['status'], 'MERGED')
3832 self.assertEqual(B.data['status'], 'NEW')
3833 self.assertIn('Build succeeded', A.messages[1])
3834 self.assertIn('Merge Failed', B.messages[1])
3835 self.assertIn('automatically merged', B.messages[1])
3836 self.assertNotIn('logs.example.com', B.messages[1])
3837 self.assertNotIn('SKIPPED', B.messages[1])
3838
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003839 def test_client_get_running_jobs(self):
3840 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003841 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003842 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003843 A.addApproval('Code-Review', 2)
3844 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003845 self.waitUntilSettled()
3846
3847 client = zuul.rpcclient.RPCClient('127.0.0.1',
3848 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003849 self.addCleanup(client.shutdown)
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003850
3851 # Wait for gearman server to send the initial workData back to zuul
3852 start = time.time()
3853 while True:
3854 if time.time() - start > 10:
3855 raise Exception("Timeout waiting for gearman server to report "
3856 + "back to the client")
Clint Byrum1d0c7d12017-05-10 19:40:53 -07003857 build = list(self.executor_client.builds.values())[0]
Monty Tayloreea6bb92017-06-14 11:56:54 -05003858 if build.worker.name == self.executor_server.hostname:
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003859 break
3860 else:
3861 time.sleep(0)
3862
3863 running_items = client.get_running_jobs()
3864
3865 self.assertEqual(1, len(running_items))
3866 running_item = running_items[0]
3867 self.assertEqual([], running_item['failing_reasons'])
3868 self.assertEqual([], running_item['items_behind'])
3869 self.assertEqual('https://hostname/1', running_item['url'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003870 self.assertIsNone(running_item['item_ahead'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003871 self.assertEqual('org/project', running_item['project'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003872 self.assertIsNone(running_item['remaining_time'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003873 self.assertEqual(True, running_item['active'])
3874 self.assertEqual('1,1', running_item['id'])
3875
3876 self.assertEqual(3, len(running_item['jobs']))
3877 for job in running_item['jobs']:
3878 if job['name'] == 'project-merge':
3879 self.assertEqual('project-merge', job['name'])
3880 self.assertEqual('gate', job['pipeline'])
3881 self.assertEqual(False, job['retry'])
Monty Taylor51139a02016-05-24 11:28:10 -05003882 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02003883 'static/stream.html?uuid={uuid}&logfile=console.log'
3884 .format(uuid=job['uuid']), job['url'])
3885 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05003886 'finger://{hostname}/{uuid}'.format(
3887 hostname=self.executor_server.hostname,
3888 uuid=job['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02003889 job['finger_url'])
Clint Byrumd4de79a2017-05-27 11:39:13 -07003890 self.assertEqual(2, len(job['worker']))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003891 self.assertEqual(False, job['canceled'])
3892 self.assertEqual(True, job['voting'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003893 self.assertIsNone(job['result'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003894 self.assertEqual('gate', job['pipeline'])
3895 break
3896
Paul Belanger174a8272017-03-14 13:20:10 -04003897 self.executor_server.hold_jobs_in_build = False
3898 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003899 self.waitUntilSettled()
3900
3901 running_items = client.get_running_jobs()
3902 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003903
James E. Blairb70e55a2017-04-19 12:57:02 -07003904 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003905 def test_nonvoting_pipeline(self):
3906 "Test that a nonvoting pipeline (experimental) can still report"
3907
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003908 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3909 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003910 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3911 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003912
3913 self.assertEqual(self.getJobFromHistory('project-merge').result,
3914 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003915 self.assertEqual(
3916 self.getJobFromHistory('experimental-project-test').result,
3917 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003918 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003919
3920 def test_crd_gate(self):
3921 "Test cross-repo dependencies"
3922 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3923 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003924 A.addApproval('Code-Review', 2)
3925 B.addApproval('Code-Review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003926
3927 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3928 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3929 AM2.setMerged()
3930 AM1.setMerged()
3931
3932 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3933 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3934 BM2.setMerged()
3935 BM1.setMerged()
3936
3937 # A -> AM1 -> AM2
3938 # B -> BM1 -> BM2
3939 # A Depends-On: B
3940 # M2 is here to make sure it is never queried. If it is, it
3941 # means zuul is walking down the entire history of merged
3942 # changes.
3943
3944 B.setDependsOn(BM1, 1)
3945 BM1.setDependsOn(BM2, 1)
3946
3947 A.setDependsOn(AM1, 1)
3948 AM1.setDependsOn(AM2, 1)
3949
3950 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3951 A.subject, B.data['id'])
3952
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003953 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003954 self.waitUntilSettled()
3955
3956 self.assertEqual(A.data['status'], 'NEW')
3957 self.assertEqual(B.data['status'], 'NEW')
3958
Paul Belanger5dccbe72016-11-14 11:17:37 -05003959 for connection in self.connections.connections.values():
James E. Blairb0a95ab2017-10-18 09:39:18 -07003960 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003961
Paul Belanger174a8272017-03-14 13:20:10 -04003962 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003963 B.addApproval('Approved', 1)
3964 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003965 self.waitUntilSettled()
3966
Paul Belanger174a8272017-03-14 13:20:10 -04003967 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003968 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003969 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003970 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003971 self.executor_server.hold_jobs_in_build = False
3972 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003973 self.waitUntilSettled()
3974
3975 self.assertEqual(AM2.queried, 0)
3976 self.assertEqual(BM2.queried, 0)
3977 self.assertEqual(A.data['status'], 'MERGED')
3978 self.assertEqual(B.data['status'], 'MERGED')
3979 self.assertEqual(A.reported, 2)
3980 self.assertEqual(B.reported, 2)
3981
Paul Belanger5dccbe72016-11-14 11:17:37 -05003982 changes = self.getJobFromHistory(
3983 'project-merge', 'org/project1').changes
3984 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003985
3986 def test_crd_branch(self):
3987 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003988
3989 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003990 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3991 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04003992 C1 = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C1')
3993 C2 = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C2',
3994 status='ABANDONED')
3995 C1.data['id'] = B.data['id']
3996 C2.data['id'] = B.data['id']
3997
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003998 A.addApproval('Code-Review', 2)
3999 B.addApproval('Code-Review', 2)
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004000 C1.addApproval('Code-Review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08004001
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004002 # A Depends-On: B+C1
James E. Blair8f78d882015-02-05 08:51:37 -08004003 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4004 A.subject, B.data['id'])
4005
Paul Belanger174a8272017-03-14 13:20:10 -04004006 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004007 B.addApproval('Approved', 1)
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004008 C1.addApproval('Approved', 1)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004009 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08004010 self.waitUntilSettled()
4011
Paul Belanger174a8272017-03-14 13:20:10 -04004012 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004013 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004014 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004015 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004016 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004017 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004018 self.executor_server.hold_jobs_in_build = False
4019 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08004020 self.waitUntilSettled()
4021
4022 self.assertEqual(A.data['status'], 'MERGED')
4023 self.assertEqual(B.data['status'], 'MERGED')
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004024 self.assertEqual(C1.data['status'], 'MERGED')
James E. Blair8f78d882015-02-05 08:51:37 -08004025 self.assertEqual(A.reported, 2)
4026 self.assertEqual(B.reported, 2)
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004027 self.assertEqual(C1.reported, 2)
James E. Blair8f78d882015-02-05 08:51:37 -08004028
Paul Belanger6379db12016-11-14 13:57:54 -05004029 changes = self.getJobFromHistory(
4030 'project-merge', 'org/project1').changes
4031 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08004032
4033 def test_crd_multiline(self):
4034 "Test multiple depends-on lines in commit"
4035 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4036 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4037 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004038 A.addApproval('Code-Review', 2)
4039 B.addApproval('Code-Review', 2)
4040 C.addApproval('Code-Review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08004041
4042 # A Depends-On: B+C
4043 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
4044 A.subject, B.data['id'], C.data['id'])
4045
Paul Belanger174a8272017-03-14 13:20:10 -04004046 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004047 B.addApproval('Approved', 1)
4048 C.addApproval('Approved', 1)
4049 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08004050 self.waitUntilSettled()
4051
Paul Belanger174a8272017-03-14 13:20:10 -04004052 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004053 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004054 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004055 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004056 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004057 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004058 self.executor_server.hold_jobs_in_build = False
4059 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08004060 self.waitUntilSettled()
4061
4062 self.assertEqual(A.data['status'], 'MERGED')
4063 self.assertEqual(B.data['status'], 'MERGED')
4064 self.assertEqual(C.data['status'], 'MERGED')
4065 self.assertEqual(A.reported, 2)
4066 self.assertEqual(B.reported, 2)
4067 self.assertEqual(C.reported, 2)
4068
Paul Belanger5dccbe72016-11-14 11:17:37 -05004069 changes = self.getJobFromHistory(
4070 'project-merge', 'org/project1').changes
4071 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08004072
4073 def test_crd_unshared_gate(self):
4074 "Test cross-repo dependencies in unshared gate queues"
4075 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4076 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004077 A.addApproval('Code-Review', 2)
4078 B.addApproval('Code-Review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08004079
4080 # A Depends-On: B
4081 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4082 A.subject, B.data['id'])
4083
4084 # A and B do not share a queue, make sure that A is unable to
4085 # enqueue B (and therefore, A is unable to be enqueued).
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004086 B.addApproval('Approved', 1)
4087 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004088 self.waitUntilSettled()
4089
4090 self.assertEqual(A.data['status'], 'NEW')
4091 self.assertEqual(B.data['status'], 'NEW')
4092 self.assertEqual(A.reported, 0)
4093 self.assertEqual(B.reported, 0)
4094 self.assertEqual(len(self.history), 0)
4095
4096 # Enqueue and merge B alone.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004097 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004098 self.waitUntilSettled()
4099
4100 self.assertEqual(B.data['status'], 'MERGED')
4101 self.assertEqual(B.reported, 2)
4102
4103 # Now that B is merged, A should be able to be enqueued and
4104 # merged.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004105 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004106 self.waitUntilSettled()
4107
4108 self.assertEqual(A.data['status'], 'MERGED')
4109 self.assertEqual(A.reported, 2)
4110
James E. Blair96698e22015-04-02 07:48:21 -07004111 def test_crd_gate_reverse(self):
4112 "Test reverse cross-repo dependencies"
4113 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4114 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004115 A.addApproval('Code-Review', 2)
4116 B.addApproval('Code-Review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07004117
4118 # A Depends-On: B
4119
4120 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4121 A.subject, B.data['id'])
4122
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004123 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07004124 self.waitUntilSettled()
4125
4126 self.assertEqual(A.data['status'], 'NEW')
4127 self.assertEqual(B.data['status'], 'NEW')
4128
Paul Belanger174a8272017-03-14 13:20:10 -04004129 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004130 A.addApproval('Approved', 1)
4131 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07004132 self.waitUntilSettled()
4133
Paul Belanger174a8272017-03-14 13:20:10 -04004134 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07004135 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004136 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07004137 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004138 self.executor_server.hold_jobs_in_build = False
4139 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07004140 self.waitUntilSettled()
4141
4142 self.assertEqual(A.data['status'], 'MERGED')
4143 self.assertEqual(B.data['status'], 'MERGED')
4144 self.assertEqual(A.reported, 2)
4145 self.assertEqual(B.reported, 2)
4146
Paul Belanger5dccbe72016-11-14 11:17:37 -05004147 changes = self.getJobFromHistory(
4148 'project-merge', 'org/project1').changes
4149 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07004150
James E. Blair5ee24252014-12-30 10:12:29 -08004151 def test_crd_cycle(self):
4152 "Test cross-repo dependency cycles"
4153 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4154 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004155 A.addApproval('Code-Review', 2)
4156 B.addApproval('Code-Review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08004157
4158 # A -> B -> A (via commit-depends)
4159
4160 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4161 A.subject, B.data['id'])
4162 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4163 B.subject, A.data['id'])
4164
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004165 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004166 self.waitUntilSettled()
4167
4168 self.assertEqual(A.reported, 0)
4169 self.assertEqual(B.reported, 0)
4170 self.assertEqual(A.data['status'], 'NEW')
4171 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08004172
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004173 def test_crd_gate_unknown(self):
4174 "Test unknown projects in dependent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004175 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004176 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4177 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004178 A.addApproval('Code-Review', 2)
4179 B.addApproval('Code-Review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004180
4181 # A Depends-On: B
4182 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4183 A.subject, B.data['id'])
4184
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004185 B.addApproval('Approved', 1)
4186 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004187 self.waitUntilSettled()
4188
4189 # Unknown projects cannot share a queue with any other
4190 # since they don't have common jobs with any other (they have no jobs).
4191 # Changes which depend on unknown project changes
4192 # should not be processed in dependent pipeline
4193 self.assertEqual(A.data['status'], 'NEW')
4194 self.assertEqual(B.data['status'], 'NEW')
4195 self.assertEqual(A.reported, 0)
4196 self.assertEqual(B.reported, 0)
4197 self.assertEqual(len(self.history), 0)
4198
James E. Blair7720b402017-06-07 08:51:49 -07004199 # Simulate change B being gated outside this layout Set the
4200 # change merged before submitting the event so that when the
4201 # event triggers a gerrit query to update the change, we get
4202 # the information that it was merged.
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004203 B.setMerged()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004204 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004205 self.waitUntilSettled()
4206 self.assertEqual(len(self.history), 0)
4207
4208 # Now that B is merged, A should be able to be enqueued and
4209 # merged.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004210 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004211 self.waitUntilSettled()
4212
4213 self.assertEqual(A.data['status'], 'MERGED')
4214 self.assertEqual(A.reported, 2)
4215 self.assertEqual(B.data['status'], 'MERGED')
4216 self.assertEqual(B.reported, 0)
4217
James E. Blairbfb8e042014-12-30 17:01:44 -08004218 def test_crd_check(self):
4219 "Test cross-repo dependencies in independent pipelines"
4220
Paul Belanger174a8272017-03-14 13:20:10 -04004221 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08004222 self.gearman_server.hold_jobs_in_queue = True
4223 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4224 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4225
4226 # A Depends-On: B
4227 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4228 A.subject, B.data['id'])
4229
4230 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4231 self.waitUntilSettled()
4232
James E. Blairbfb8e042014-12-30 17:01:44 -08004233 self.gearman_server.hold_jobs_in_queue = False
4234 self.gearman_server.release()
4235 self.waitUntilSettled()
4236
Paul Belanger174a8272017-03-14 13:20:10 -04004237 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05004238 self.waitUntilSettled()
4239
James E. Blair2a535672017-04-27 12:03:15 -07004240 self.assertTrue(self.builds[0].hasChanges(A, B))
James E. Blairbfb8e042014-12-30 17:01:44 -08004241
Paul Belanger174a8272017-03-14 13:20:10 -04004242 self.executor_server.hold_jobs_in_build = False
4243 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05004244 self.waitUntilSettled()
4245
James E. Blairbfb8e042014-12-30 17:01:44 -08004246 self.assertEqual(A.data['status'], 'NEW')
4247 self.assertEqual(B.data['status'], 'NEW')
4248 self.assertEqual(A.reported, 1)
4249 self.assertEqual(B.reported, 0)
4250
4251 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05004252 tenant = self.sched.abide.tenants.get('tenant-one')
4253 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08004254
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004255 def test_crd_check_git_depends(self):
4256 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07004257 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004258 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4259 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4260
4261 # Add two git-dependent changes and make sure they both report
4262 # success.
4263 B.setDependsOn(A, 1)
4264 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4265 self.waitUntilSettled()
4266 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4267 self.waitUntilSettled()
4268
James E. Blairb8c16472015-05-05 14:55:26 -07004269 self.orderedRelease()
4270 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004271 self.waitUntilSettled()
4272
4273 self.assertEqual(A.data['status'], 'NEW')
4274 self.assertEqual(B.data['status'], 'NEW')
4275 self.assertEqual(A.reported, 1)
4276 self.assertEqual(B.reported, 1)
4277
4278 self.assertEqual(self.history[0].changes, '1,1')
4279 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04004280 tenant = self.sched.abide.tenants.get('tenant-one')
4281 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004282
4283 self.assertIn('Build succeeded', A.messages[0])
4284 self.assertIn('Build succeeded', B.messages[0])
4285
4286 def test_crd_check_duplicate(self):
4287 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04004288 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004289 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4290 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04004291 tenant = self.sched.abide.tenants.get('tenant-one')
4292 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004293
4294 # Add two git-dependent changes...
4295 B.setDependsOn(A, 1)
4296 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4297 self.waitUntilSettled()
4298 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4299
4300 # ...make sure the live one is not duplicated...
4301 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4302 self.waitUntilSettled()
4303 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4304
4305 # ...but the non-live one is able to be.
4306 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4307 self.waitUntilSettled()
4308 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4309
Clark Boylandd849822015-03-02 12:38:14 -08004310 # Release jobs in order to avoid races with change A jobs
4311 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07004312 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04004313 self.executor_server.hold_jobs_in_build = False
4314 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004315 self.waitUntilSettled()
4316
4317 self.assertEqual(A.data['status'], 'NEW')
4318 self.assertEqual(B.data['status'], 'NEW')
4319 self.assertEqual(A.reported, 1)
4320 self.assertEqual(B.reported, 1)
4321
4322 self.assertEqual(self.history[0].changes, '1,1 2,1')
4323 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04004324 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004325
4326 self.assertIn('Build succeeded', A.messages[0])
4327 self.assertIn('Build succeeded', B.messages[0])
4328
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004329 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08004330 "Test cross-repo dependencies re-enqueued in independent pipelines"
4331
4332 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004333 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
4334 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08004335
4336 # A Depends-On: B
4337 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4338 A.subject, B.data['id'])
4339
4340 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4341 self.waitUntilSettled()
4342
4343 self.sched.reconfigure(self.config)
4344
4345 # Make sure the items still share a change queue, and the
4346 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05004347 tenant = self.sched.abide.tenants.get('tenant-one')
4348 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
4349 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08004350 first_item = queue.queue[0]
4351 for item in queue.queue:
4352 self.assertEqual(item.queue, first_item.queue)
4353 self.assertFalse(first_item.live)
4354 self.assertTrue(queue.queue[1].live)
4355
4356 self.gearman_server.hold_jobs_in_queue = False
4357 self.gearman_server.release()
4358 self.waitUntilSettled()
4359
4360 self.assertEqual(A.data['status'], 'NEW')
4361 self.assertEqual(B.data['status'], 'NEW')
4362 self.assertEqual(A.reported, 1)
4363 self.assertEqual(B.reported, 0)
4364
4365 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004366 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004367
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004368 def test_crd_check_reconfiguration(self):
4369 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4370
4371 def test_crd_undefined_project(self):
4372 """Test that undefined projects in dependencies are handled for
4373 independent pipelines"""
4374 # It's a hack for fake gerrit,
4375 # as it implies repo creation upon the creation of any change
James E. Blairc4ba97a2017-04-19 16:26:24 -07004376 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004377 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4378
Jesse Keatingea68ab42017-04-19 15:03:30 -07004379 @simple_layout('layouts/ignore-dependencies.yaml')
James E. Blair17dd6772015-02-09 14:45:18 -08004380 def test_crd_check_ignore_dependencies(self):
4381 "Test cross-repo dependencies can be ignored"
James E. Blair17dd6772015-02-09 14:45:18 -08004382
4383 self.gearman_server.hold_jobs_in_queue = True
4384 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4385 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4386 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4387
4388 # A Depends-On: B
4389 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4390 A.subject, B.data['id'])
4391 # C git-depends on B
4392 C.setDependsOn(B, 1)
4393 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4394 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4395 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4396 self.waitUntilSettled()
4397
4398 # Make sure none of the items share a change queue, and all
4399 # are live.
Jesse Keatingea68ab42017-04-19 15:03:30 -07004400 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum12282ca2017-04-03 11:04:02 -07004401 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004402 self.assertEqual(len(check_pipeline.queues), 3)
4403 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4404 for item in check_pipeline.getAllItems():
4405 self.assertTrue(item.live)
4406
4407 self.gearman_server.hold_jobs_in_queue = False
4408 self.gearman_server.release()
4409 self.waitUntilSettled()
4410
4411 self.assertEqual(A.data['status'], 'NEW')
4412 self.assertEqual(B.data['status'], 'NEW')
4413 self.assertEqual(C.data['status'], 'NEW')
4414 self.assertEqual(A.reported, 1)
4415 self.assertEqual(B.reported, 1)
4416 self.assertEqual(C.reported, 1)
4417
4418 # Each job should have tested exactly one change
4419 for job in self.history:
4420 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004421
James E. Blair7cb84542017-04-19 13:35:05 -07004422 @simple_layout('layouts/three-projects.yaml')
James E. Blair96698e22015-04-02 07:48:21 -07004423 def test_crd_check_transitive(self):
4424 "Test transitive cross-repo dependencies"
4425 # Specifically, if A -> B -> C, and C gets a new patchset and
4426 # A gets a new patchset, ensure the test of A,2 includes B,1
4427 # and C,2 (not C,1 which would indicate stale data in the
4428 # cache for B).
4429 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4430 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4431 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4432
4433 # A Depends-On: B
4434 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4435 A.subject, B.data['id'])
4436
4437 # B Depends-On: C
4438 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4439 B.subject, C.data['id'])
4440
4441 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4442 self.waitUntilSettled()
4443 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4444
4445 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4446 self.waitUntilSettled()
4447 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4448
4449 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4450 self.waitUntilSettled()
4451 self.assertEqual(self.history[-1].changes, '3,1')
4452
4453 C.addPatchset()
4454 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4455 self.waitUntilSettled()
4456 self.assertEqual(self.history[-1].changes, '3,2')
4457
4458 A.addPatchset()
4459 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4460 self.waitUntilSettled()
4461 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004462
James E. Blaira8b90b32016-08-24 15:18:50 -07004463 def test_crd_check_unknown(self):
4464 "Test unknown projects in independent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004465 self.init_repo("org/unknown", tag='init')
James E. Blaira8b90b32016-08-24 15:18:50 -07004466 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4467 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4468 # A Depends-On: B
4469 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4470 A.subject, B.data['id'])
4471
4472 # Make sure zuul has seen an event on B.
4473 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4474 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4475 self.waitUntilSettled()
4476
4477 self.assertEqual(A.data['status'], 'NEW')
4478 self.assertEqual(A.reported, 1)
4479 self.assertEqual(B.data['status'], 'NEW')
4480 self.assertEqual(B.reported, 0)
4481
James E. Blair92464a22016-04-05 10:21:26 -07004482 def test_crd_cycle_join(self):
4483 "Test an updated change creates a cycle"
4484 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4485
4486 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4487 self.waitUntilSettled()
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004488 self.assertEqual(A.reported, 1)
James E. Blair92464a22016-04-05 10:21:26 -07004489
4490 # Create B->A
4491 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4492 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4493 B.subject, A.data['id'])
4494 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4495 self.waitUntilSettled()
4496
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004497 # Dep is there so zuul should have reported on B
4498 self.assertEqual(B.reported, 1)
4499
James E. Blair92464a22016-04-05 10:21:26 -07004500 # Update A to add A->B (a cycle).
4501 A.addPatchset()
4502 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4503 A.subject, B.data['id'])
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004504 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4505 self.waitUntilSettled()
James E. Blair92464a22016-04-05 10:21:26 -07004506
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004507 # Dependency cycle injected so zuul should not have reported again on A
4508 self.assertEqual(A.reported, 1)
James E. Blair92464a22016-04-05 10:21:26 -07004509
4510 # Now if we update B to remove the depends-on, everything
4511 # should be okay. B; A->B
4512
4513 B.addPatchset()
4514 B.data['commitMessage'] = '%s\n' % (B.subject,)
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004515 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4516 self.waitUntilSettled()
Paul Belanger0e155e22016-11-14 14:12:23 -05004517
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004518 # Cycle was removed so now zuul should have reported again on A
4519 self.assertEqual(A.reported, 2)
4520
4521 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
4522 self.waitUntilSettled()
4523 self.assertEqual(B.reported, 2)
James E. Blair92464a22016-04-05 10:21:26 -07004524
Jesse Keatingcc67b122017-04-19 14:54:57 -07004525 @simple_layout('layouts/disable_at.yaml')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004526 def test_disable_at(self):
4527 "Test a pipeline will only report to the disabled trigger when failing"
4528
Jesse Keatingcc67b122017-04-19 14:54:57 -07004529 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004530 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004531 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004532 0, tenant.layout.pipelines['check']._consecutive_failures)
4533 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004534
4535 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4536 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4537 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4538 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4539 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4540 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4541 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4542 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4543 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4544 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4545 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4546
Paul Belanger174a8272017-03-14 13:20:10 -04004547 self.executor_server.failJob('project-test1', A)
4548 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004549 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004550 self.executor_server.failJob('project-test1', D)
4551 self.executor_server.failJob('project-test1', E)
4552 self.executor_server.failJob('project-test1', F)
4553 self.executor_server.failJob('project-test1', G)
4554 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004555 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004556 self.executor_server.failJob('project-test1', J)
4557 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004558
4559 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4560 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4561 self.waitUntilSettled()
4562
4563 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004564 2, tenant.layout.pipelines['check']._consecutive_failures)
4565 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004566
4567 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4568 self.waitUntilSettled()
4569
4570 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004571 0, tenant.layout.pipelines['check']._consecutive_failures)
4572 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004573
4574 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4575 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4576 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4577 self.waitUntilSettled()
4578
4579 # We should be disabled now
4580 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004581 3, tenant.layout.pipelines['check']._consecutive_failures)
4582 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004583
4584 # We need to wait between each of these patches to make sure the
4585 # smtp messages come back in an expected order
4586 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4587 self.waitUntilSettled()
4588 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4589 self.waitUntilSettled()
4590 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4591 self.waitUntilSettled()
4592
4593 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4594 # leaving a message on each change
4595 self.assertEqual(1, len(A.messages))
4596 self.assertIn('Build failed.', A.messages[0])
4597 self.assertEqual(1, len(B.messages))
4598 self.assertIn('Build failed.', B.messages[0])
4599 self.assertEqual(1, len(C.messages))
4600 self.assertIn('Build succeeded.', C.messages[0])
4601 self.assertEqual(1, len(D.messages))
4602 self.assertIn('Build failed.', D.messages[0])
4603 self.assertEqual(1, len(E.messages))
4604 self.assertIn('Build failed.', E.messages[0])
4605 self.assertEqual(1, len(F.messages))
4606 self.assertIn('Build failed.', F.messages[0])
4607
4608 # The last 3 (GHI) would have only reported via smtp.
4609 self.assertEqual(3, len(self.smtp_messages))
4610 self.assertEqual(0, len(G.messages))
4611 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004612 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004613 'project-test1 finger://', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004614 self.assertEqual(0, len(H.messages))
4615 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004616 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004617 'project-test1 finger://', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004618 self.assertEqual(0, len(I.messages))
4619 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004620 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004621 'project-test1 finger://', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004622
4623 # Now reload the configuration (simulate a HUP) to check the pipeline
4624 # comes out of disabled
4625 self.sched.reconfigure(self.config)
4626
Jesse Keatingcc67b122017-04-19 14:54:57 -07004627 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004628
4629 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004630 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004631 0, tenant.layout.pipelines['check']._consecutive_failures)
4632 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004633
4634 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4635 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4636 self.waitUntilSettled()
4637
4638 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004639 2, tenant.layout.pipelines['check']._consecutive_failures)
4640 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004641
4642 # J and K went back to gerrit
4643 self.assertEqual(1, len(J.messages))
4644 self.assertIn('Build failed.', J.messages[0])
4645 self.assertEqual(1, len(K.messages))
4646 self.assertIn('Build failed.', K.messages[0])
4647 # No more messages reported via smtp
4648 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004649
James E. Blaircc020532017-04-19 13:04:44 -07004650 @simple_layout('layouts/one-job-project.yaml')
4651 def test_one_job_project(self):
4652 "Test that queueing works with one job"
4653 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4654 'master', 'A')
4655 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4656 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004657 A.addApproval('Code-Review', 2)
4658 B.addApproval('Code-Review', 2)
4659 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
4660 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blaircc020532017-04-19 13:04:44 -07004661 self.waitUntilSettled()
4662
4663 self.assertEqual(A.data['status'], 'MERGED')
4664 self.assertEqual(A.reported, 2)
4665 self.assertEqual(B.data['status'], 'MERGED')
4666 self.assertEqual(B.reported, 2)
4667
Paul Belanger32023542017-10-06 14:48:50 -04004668 def test_job_aborted(self):
4669 "Test that if a execute server aborts a job, it is run again"
4670 self.executor_server.hold_jobs_in_build = True
4671 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4672 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4673 self.waitUntilSettled()
4674
4675 self.executor_server.release('.*-merge')
4676 self.waitUntilSettled()
4677
4678 self.assertEqual(len(self.builds), 2)
Tobias Henkel26fa8a32017-10-07 07:08:36 +00004679
4680 # first abort
4681 self.builds[0].aborted = True
4682 self.executor_server.release('.*-test*')
4683 self.waitUntilSettled()
4684 self.assertEqual(len(self.builds), 1)
4685
4686 # second abort
4687 self.builds[0].aborted = True
4688 self.executor_server.release('.*-test*')
4689 self.waitUntilSettled()
4690 self.assertEqual(len(self.builds), 1)
4691
4692 # third abort
4693 self.builds[0].aborted = True
4694 self.executor_server.release('.*-test*')
4695 self.waitUntilSettled()
4696 self.assertEqual(len(self.builds), 1)
4697
4698 # fourth abort
Paul Belanger32023542017-10-06 14:48:50 -04004699 self.builds[0].aborted = True
4700 self.executor_server.release('.*-test*')
4701 self.waitUntilSettled()
4702 self.assertEqual(len(self.builds), 1)
4703
4704 self.executor_server.hold_jobs_in_build = False
4705 self.executor_server.release()
4706 self.waitUntilSettled()
4707
Tobias Henkel26fa8a32017-10-07 07:08:36 +00004708 self.assertEqual(len(self.history), 7)
4709 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
Paul Belanger32023542017-10-06 14:48:50 -04004710 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
4711
Paul Belanger71d98172016-11-08 10:56:31 -05004712 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004713 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004714
Paul Belanger174a8272017-03-14 13:20:10 -04004715 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004716 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4717 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4718 self.waitUntilSettled()
4719
Paul Belanger174a8272017-03-14 13:20:10 -04004720 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004721 self.waitUntilSettled()
4722
4723 self.assertEqual(len(self.builds), 2)
4724 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004725 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004726 self.waitUntilSettled()
4727
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004728 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004729 self.assertEqual(len(self.builds), 1,
4730 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004731 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004732 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004733 self.waitUntilSettled()
4734
Paul Belanger174a8272017-03-14 13:20:10 -04004735 self.executor_server.hold_jobs_in_build = False
4736 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004737 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004738 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004739 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4740 self.assertEqual(A.reported, 1)
4741 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004742
James E. Blair15be0e12017-01-03 13:45:20 -08004743 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004744 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004745
4746 self.fake_nodepool.paused = True
4747 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004748 A.addApproval('Code-Review', 2)
4749 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair15be0e12017-01-03 13:45:20 -08004750 self.waitUntilSettled()
4751
4752 self.zk.client.stop()
4753 self.zk.client.start()
4754 self.fake_nodepool.paused = False
4755 self.waitUntilSettled()
4756
4757 self.assertEqual(A.data['status'], 'MERGED')
4758 self.assertEqual(A.reported, 2)
4759
James E. Blair6ab79e02017-01-06 10:10:17 -08004760 def test_nodepool_failure(self):
4761 "Test that jobs are reported after a nodepool failure"
4762
4763 self.fake_nodepool.paused = True
4764 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004765 A.addApproval('Code-Review', 2)
4766 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair6ab79e02017-01-06 10:10:17 -08004767 self.waitUntilSettled()
4768
4769 req = self.fake_nodepool.getNodeRequests()[0]
4770 self.fake_nodepool.addFailRequest(req)
4771
4772 self.fake_nodepool.paused = False
4773 self.waitUntilSettled()
4774
4775 self.assertEqual(A.data['status'], 'NEW')
4776 self.assertEqual(A.reported, 2)
4777 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4778 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4779 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4780
Monty Taylor6dc5bc12017-09-29 15:47:31 -05004781 def test_nodepool_priority(self):
4782 "Test that nodes are requested at the correct priority"
4783
4784 self.fake_nodepool.paused = True
4785
4786 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4787 self.fake_gerrit.addEvent(A.getRefUpdatedEvent())
4788
4789 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4790 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4791
4792 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4793 C.addApproval('Code-Review', 2)
4794 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
4795
4796 self.waitUntilSettled()
4797
4798 reqs = self.fake_nodepool.getNodeRequests()
4799
4800 # The requests come back sorted by oid. Since we have three requests
4801 # for the three changes each with a different priority.
4802 # Also they get a serial number based on order they were received
4803 # so the number on the endof the oid should map to order submitted.
4804
4805 # * gate first - high priority - change C
4806 self.assertEqual(reqs[0]['_oid'], '100-0000000002')
4807 self.assertEqual(reqs[0]['node_types'], ['label1'])
4808 # * check second - normal priority - change B
4809 self.assertEqual(reqs[1]['_oid'], '200-0000000001')
4810 self.assertEqual(reqs[1]['node_types'], ['label1'])
4811 # * post third - low priority - change A
4812 # additionally, the post job defined uses an ubuntu-xenial node,
4813 # so we include that check just as an extra verification
4814 self.assertEqual(reqs[2]['_oid'], '300-0000000000')
4815 self.assertEqual(reqs[2]['node_types'], ['ubuntu-xenial'])
4816
4817 self.fake_nodepool.paused = False
4818 self.waitUntilSettled()
4819
James E. Blairfceaf412017-09-29 13:44:57 -07004820 @simple_layout('layouts/multiple-templates.yaml')
4821 def test_multiple_project_templates(self):
4822 # Test that applying multiple project templates to a project
4823 # doesn't alter them when used for a second project.
4824 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4825 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4826 self.waitUntilSettled()
4827
4828 build = self.getJobFromHistory('py27')
4829 self.assertEqual(build.parameters['zuul']['jobtags'], [])
4830
James E. Blair29c77002017-10-05 14:56:35 -07004831 def test_pending_merge_in_reconfig(self):
4832 # Test that if we are waiting for an outstanding merge on
4833 # reconfiguration that we continue to do so.
4834 self.gearman_server.hold_merge_jobs_in_queue = True
4835 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4836 A.setMerged()
4837 self.fake_gerrit.addEvent(A.getRefUpdatedEvent())
4838 self.waitUntilSettled()
4839 # Reconfigure while we still have an outstanding merge job
4840 self.sched.reconfigureTenant(self.sched.abide.tenants['tenant-one'],
4841 None)
4842 self.waitUntilSettled()
4843 # Verify the merge job is still running and that the item is
4844 # in the pipeline
4845 self.assertEqual(len(self.sched.merger.jobs), 1)
4846 tenant = self.sched.abide.tenants.get('tenant-one')
4847 pipeline = tenant.layout.pipelines['post']
4848 self.assertEqual(len(pipeline.getAllItems()), 1)
4849 self.gearman_server.hold_merge_jobs_in_queue = False
4850 self.gearman_server.release()
4851 self.waitUntilSettled()
4852
Arieb6f068c2016-10-09 13:11:06 +03004853
James E. Blaira002b032017-04-18 10:35:48 -07004854class TestExecutor(ZuulTestCase):
4855 tenant_config_file = 'config/single-tenant/main.yaml'
4856
4857 def assertFinalState(self):
4858 # In this test, we expect to shut down in a non-final state,
4859 # so skip these checks.
4860 pass
4861
4862 def assertCleanShutdown(self):
4863 self.log.debug("Assert clean shutdown")
4864
4865 # After shutdown, make sure no jobs are running
4866 self.assertEqual({}, self.executor_server.job_workers)
4867
4868 # Make sure that git.Repo objects have been garbage collected.
4869 repos = []
4870 gc.collect()
4871 for obj in gc.get_objects():
4872 if isinstance(obj, git.Repo):
4873 self.log.debug("Leaked git repo object: %s" % repr(obj))
4874 repos.append(obj)
4875 self.assertEqual(len(repos), 0)
4876
4877 def test_executor_shutdown(self):
4878 "Test that the executor can shut down with jobs running"
4879
4880 self.executor_server.hold_jobs_in_build = True
4881 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004882 A.addApproval('Code-Review', 2)
4883 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blaira002b032017-04-18 10:35:48 -07004884 self.waitUntilSettled()
4885
4886
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004887class TestDependencyGraph(ZuulTestCase):
4888 tenant_config_file = 'config/dependency-graph/main.yaml'
4889
4890 def test_dependeny_graph_dispatch_jobs_once(self):
4891 "Test a job in a dependency graph is queued only once"
4892 # Job dependencies, starting with A
4893 # A
4894 # / \
4895 # B C
4896 # / \ / \
4897 # D F E
4898 # |
4899 # G
4900
4901 self.executor_server.hold_jobs_in_build = True
4902 change = self.fake_gerrit.addFakeChange(
4903 'org/project', 'master', 'change')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004904 change.addApproval('Code-Review', 2)
4905 self.fake_gerrit.addEvent(change.addApproval('Approved', 1))
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004906
4907 self.waitUntilSettled()
4908 self.assertEqual([b.name for b in self.builds], ['A'])
4909
4910 self.executor_server.release('A')
4911 self.waitUntilSettled()
4912 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4913
4914 self.executor_server.release('B')
4915 self.waitUntilSettled()
4916 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4917
4918 self.executor_server.release('D')
4919 self.waitUntilSettled()
4920 self.assertEqual([b.name for b in self.builds], ['C'])
4921
4922 self.executor_server.release('C')
4923 self.waitUntilSettled()
4924 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4925
4926 self.executor_server.release('F')
4927 self.waitUntilSettled()
4928 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4929
4930 self.executor_server.release('G')
4931 self.waitUntilSettled()
4932 self.assertEqual([b.name for b in self.builds], ['E'])
4933
4934 self.executor_server.release('E')
4935 self.waitUntilSettled()
4936 self.assertEqual(len(self.builds), 0)
4937
4938 self.executor_server.hold_jobs_in_build = False
4939 self.executor_server.release()
4940 self.waitUntilSettled()
4941
4942 self.assertEqual(len(self.builds), 0)
4943 self.assertEqual(len(self.history), 7)
4944
4945 self.assertEqual(change.data['status'], 'MERGED')
4946 self.assertEqual(change.reported, 2)
4947
4948 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4949 "Test that a job waits till all dependencies are successful"
4950 # Job dependencies, starting with A
4951 # A
4952 # / \
4953 # B C*
4954 # / \ / \
4955 # D F E
4956 # |
4957 # G
4958
4959 self.executor_server.hold_jobs_in_build = True
4960 change = self.fake_gerrit.addFakeChange(
4961 'org/project', 'master', 'change')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004962 change.addApproval('Code-Review', 2)
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004963
4964 self.executor_server.failJob('C', change)
4965
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004966 self.fake_gerrit.addEvent(change.addApproval('Approved', 1))
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004967
4968 self.waitUntilSettled()
4969 self.assertEqual([b.name for b in self.builds], ['A'])
4970
4971 self.executor_server.release('A')
4972 self.waitUntilSettled()
4973 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4974
4975 self.executor_server.release('B')
4976 self.waitUntilSettled()
4977 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4978
4979 self.executor_server.release('D')
4980 self.waitUntilSettled()
4981 self.assertEqual([b.name for b in self.builds], ['C'])
4982
4983 self.executor_server.release('C')
4984 self.waitUntilSettled()
4985 self.assertEqual(len(self.builds), 0)
4986
4987 self.executor_server.hold_jobs_in_build = False
4988 self.executor_server.release()
4989 self.waitUntilSettled()
4990
4991 self.assertEqual(len(self.builds), 0)
4992 self.assertEqual(len(self.history), 4)
4993
4994 self.assertEqual(change.data['status'], 'NEW')
4995 self.assertEqual(change.reported, 2)
4996
4997
Arieb6f068c2016-10-09 13:11:06 +03004998class TestDuplicatePipeline(ZuulTestCase):
4999 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
5000
5001 def test_duplicate_pipelines(self):
5002 "Test that a change matching multiple pipelines works"
5003
5004 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5005 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
5006 self.waitUntilSettled()
5007
5008 self.assertHistory([
5009 dict(name='project-test1', result='SUCCESS', changes='1,1',
5010 pipeline='dup1'),
5011 dict(name='project-test1', result='SUCCESS', changes='1,1',
5012 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05005013 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03005014
5015 self.assertEqual(len(A.messages), 2)
5016
Paul Belangera46a3742016-11-09 14:23:03 -05005017 if 'dup1' in A.messages[0]:
5018 self.assertIn('dup1', A.messages[0])
5019 self.assertNotIn('dup2', A.messages[0])
5020 self.assertIn('project-test1', A.messages[0])
5021 self.assertIn('dup2', A.messages[1])
5022 self.assertNotIn('dup1', A.messages[1])
5023 self.assertIn('project-test1', A.messages[1])
5024 else:
5025 self.assertIn('dup1', A.messages[1])
5026 self.assertNotIn('dup2', A.messages[1])
5027 self.assertIn('project-test1', A.messages[1])
5028 self.assertIn('dup2', A.messages[0])
5029 self.assertNotIn('dup1', A.messages[0])
5030 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04005031
5032
Paul Belanger86085b32016-11-03 12:48:57 -04005033class TestSchedulerTemplatedProject(ZuulTestCase):
5034 tenant_config_file = 'config/templated-project/main.yaml'
5035
Paul Belanger174a8272017-03-14 13:20:10 -04005036 def test_job_from_templates_executed(self):
5037 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04005038
5039 A = self.fake_gerrit.addFakeChange(
5040 'org/templated-project', 'master', 'A')
5041 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5042 self.waitUntilSettled()
5043
5044 self.assertEqual(self.getJobFromHistory('project-test1').result,
5045 'SUCCESS')
5046 self.assertEqual(self.getJobFromHistory('project-test2').result,
5047 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04005048
5049 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04005050 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04005051
5052 A = self.fake_gerrit.addFakeChange(
5053 'org/layered-project', 'master', 'A')
5054 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5055 self.waitUntilSettled()
5056
5057 self.assertEqual(self.getJobFromHistory('project-test1').result,
5058 'SUCCESS')
5059 self.assertEqual(self.getJobFromHistory('project-test2').result,
5060 'SUCCESS')
5061 self.assertEqual(self.getJobFromHistory('layered-project-test3'
5062 ).result, 'SUCCESS')
5063 self.assertEqual(self.getJobFromHistory('layered-project-test4'
5064 ).result, 'SUCCESS')
5065 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
5066 ).result, 'SUCCESS')
5067 self.assertEqual(self.getJobFromHistory('project-test6').result,
5068 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08005069
James E. Blaire74f5712017-09-29 15:14:31 -07005070 def test_unimplied_branch_matchers(self):
5071 # This tests that there are no implied branch matchers added
5072 # by project templates.
5073 self.create_branch('org/layered-project', 'stable')
5074
5075 A = self.fake_gerrit.addFakeChange(
5076 'org/layered-project', 'stable', 'A')
5077
5078 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5079 self.waitUntilSettled()
5080
5081 self.assertEqual(self.getJobFromHistory('project-test1').result,
5082 'SUCCESS')
5083 print(self.getJobFromHistory('project-test1').
5084 parameters['zuul']['_inheritance_path'])
5085
5086 def test_implied_branch_matchers(self):
5087 # This tests that there is an implied branch matcher when a
5088 # template is used on an in-repo project pipeline definition.
5089 self.create_branch('untrusted-config', 'stable')
5090 self.fake_gerrit.addEvent(
5091 self.fake_gerrit.getFakeBranchCreatedEvent(
5092 'untrusted-config', 'stable'))
5093 self.waitUntilSettled()
5094
5095 A = self.fake_gerrit.addFakeChange(
5096 'untrusted-config', 'stable', 'A')
5097
5098 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5099 self.waitUntilSettled()
5100
5101 self.assertEqual(self.getJobFromHistory('project-test1').result,
5102 'SUCCESS')
5103 print(self.getJobFromHistory('project-test1').
5104 parameters['zuul']['_inheritance_path'])
5105
Adam Gandelman94a60062016-11-21 16:43:14 -08005106
5107class TestSchedulerSuccessURL(ZuulTestCase):
5108 tenant_config_file = 'config/success-url/main.yaml'
5109
5110 def test_success_url(self):
5111 "Ensure bad build params are ignored"
5112 self.sched.reconfigure(self.config)
5113 self.init_repo('org/docs')
5114
5115 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
5116 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5117 self.waitUntilSettled()
5118
5119 # Both builds ran: docs-draft-test + docs-draft-test2
5120 self.assertEqual(len(self.history), 2)
5121
5122 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08005123 for build in self.history:
5124 if build.name == 'docs-draft-test':
5125 uuid = build.uuid[:7]
Monty Taylorde8242c2017-02-23 20:29:53 -06005126 elif build.name == 'docs-draft-test2':
5127 uuid_test2 = build.uuid
Adam Gandelman94a60062016-11-21 16:43:14 -08005128
5129 # Two msgs: 'Starting...' + results
5130 self.assertEqual(len(self.smtp_messages), 2)
5131 body = self.smtp_messages[1]['body'].splitlines()
5132 self.assertEqual('Build succeeded.', body[0])
5133
5134 self.assertIn(
5135 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
5136 'docs-draft-test/%s/publish-docs/' % uuid,
5137 body[2])
5138
Paul Belanger174a8272017-03-14 13:20:10 -04005139 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08005140 self.assertIn(
Monty Taylor51139a02016-05-24 11:28:10 -05005141 '- docs-draft-test2 finger://{hostname}/{uuid}'.format(
5142 hostname=self.executor_server.hostname,
Monty Taylorde8242c2017-02-23 20:29:53 -06005143 uuid=uuid_test2),
Adam Gandelman94a60062016-11-21 16:43:14 -08005144 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08005145
5146
Adam Gandelman4da00f62016-12-09 15:47:33 -08005147class TestSchedulerMerges(ZuulTestCase):
5148 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08005149
5150 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04005151 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08005152 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04005153 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08005154 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
5155 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
5156 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005157 A.addApproval('Code-Review', 2)
5158 B.addApproval('Code-Review', 2)
5159 C.addApproval('Code-Review', 2)
5160 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5161 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5162 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Adam Gandelman8bd57102016-12-02 12:58:42 -08005163 self.waitUntilSettled()
5164
5165 build = self.builds[-1]
James E. Blair2a535672017-04-27 12:03:15 -07005166 path = os.path.join(build.jobdir.src_root, 'review.example.com',
5167 project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08005168 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07005169 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman8bd57102016-12-02 12:58:42 -08005170 repo_messages.reverse()
5171
Paul Belanger174a8272017-03-14 13:20:10 -04005172 self.executor_server.hold_jobs_in_build = False
5173 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08005174 self.waitUntilSettled()
5175
5176 return repo_messages
5177
5178 def _test_merge(self, mode):
5179 us_path = os.path.join(
5180 self.upstream_root, 'org/project-%s' % mode)
5181 expected_messages = [
5182 'initial commit',
5183 'add content from fixture',
5184 # the intermediate commits order is nondeterministic
5185 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
5186 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
5187 ]
5188 result = self._test_project_merge_mode(mode)
5189 self.assertEqual(result[:2], expected_messages[:2])
5190 self.assertEqual(result[-2:], expected_messages[-2:])
5191
5192 def test_project_merge_mode_merge(self):
5193 self._test_merge('merge')
5194
5195 def test_project_merge_mode_merge_resolve(self):
5196 self._test_merge('merge-resolve')
5197
5198 def test_project_merge_mode_cherrypick(self):
5199 expected_messages = [
5200 'initial commit',
5201 'add content from fixture',
5202 'A-1',
5203 'B-1',
5204 'C-1']
5205 result = self._test_project_merge_mode('cherry-pick')
5206 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08005207
5208 def test_merge_branch(self):
5209 "Test that the right commits are on alternate branches"
5210 self.create_branch('org/project-merge-branches', 'mp')
5211
Paul Belanger174a8272017-03-14 13:20:10 -04005212 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08005213 A = self.fake_gerrit.addFakeChange(
5214 'org/project-merge-branches', 'mp', 'A')
5215 B = self.fake_gerrit.addFakeChange(
5216 'org/project-merge-branches', 'mp', 'B')
5217 C = self.fake_gerrit.addFakeChange(
5218 'org/project-merge-branches', 'mp', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005219 A.addApproval('Code-Review', 2)
5220 B.addApproval('Code-Review', 2)
5221 C.addApproval('Code-Review', 2)
5222 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5223 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5224 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Adam Gandelman4da00f62016-12-09 15:47:33 -08005225 self.waitUntilSettled()
5226
Paul Belanger174a8272017-03-14 13:20:10 -04005227 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005228 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04005229 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005230 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04005231 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005232 self.waitUntilSettled()
5233
5234 build = self.builds[-1]
James E. Blair3b222492017-07-21 15:17:37 -07005235 self.assertEqual(build.parameters['zuul']['branch'], 'mp')
James E. Blair2a535672017-04-27 12:03:15 -07005236 path = os.path.join(build.jobdir.src_root, 'review.example.com',
5237 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005238 repo = git.Repo(path)
5239
James E. Blair247cab72017-07-20 16:52:36 -07005240 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005241 repo_messages.reverse()
5242 correct_messages = [
5243 'initial commit',
5244 'add content from fixture',
5245 'mp commit',
5246 'A-1', 'B-1', 'C-1']
5247 self.assertEqual(repo_messages, correct_messages)
5248
Paul Belanger174a8272017-03-14 13:20:10 -04005249 self.executor_server.hold_jobs_in_build = False
5250 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08005251 self.waitUntilSettled()
5252
5253 def test_merge_multi_branch(self):
5254 "Test that dependent changes on multiple branches are merged"
5255 self.create_branch('org/project-merge-branches', 'mp')
5256
Paul Belanger174a8272017-03-14 13:20:10 -04005257 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08005258 A = self.fake_gerrit.addFakeChange(
5259 'org/project-merge-branches', 'master', 'A')
5260 B = self.fake_gerrit.addFakeChange(
5261 'org/project-merge-branches', 'mp', 'B')
5262 C = self.fake_gerrit.addFakeChange(
5263 'org/project-merge-branches', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005264 A.addApproval('Code-Review', 2)
5265 B.addApproval('Code-Review', 2)
5266 C.addApproval('Code-Review', 2)
5267 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5268 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5269 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Adam Gandelman4da00f62016-12-09 15:47:33 -08005270 self.waitUntilSettled()
5271
5272 job_A = None
5273 for job in self.builds:
5274 if 'project-merge' in job.name:
5275 job_A = job
Adam Gandelman4da00f62016-12-09 15:47:33 -08005276
James E. Blair2a535672017-04-27 12:03:15 -07005277 path = os.path.join(job_A.jobdir.src_root, 'review.example.com',
5278 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005279 repo = git.Repo(path)
5280 repo_messages = [c.message.strip()
James E. Blair247cab72017-07-20 16:52:36 -07005281 for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005282 repo_messages.reverse()
5283 correct_messages = [
5284 'initial commit', 'add content from fixture', 'A-1']
5285 self.assertEqual(repo_messages, correct_messages)
5286
Paul Belanger174a8272017-03-14 13:20:10 -04005287 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005288 self.waitUntilSettled()
5289
5290 job_B = None
5291 for job in self.builds:
5292 if 'project-merge' in job.name:
5293 job_B = job
Adam Gandelman4da00f62016-12-09 15:47:33 -08005294
James E. Blair2a535672017-04-27 12:03:15 -07005295 path = os.path.join(job_B.jobdir.src_root, 'review.example.com',
5296 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005297 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07005298 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005299 repo_messages.reverse()
5300 correct_messages = [
5301 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
5302 self.assertEqual(repo_messages, correct_messages)
5303
Paul Belanger174a8272017-03-14 13:20:10 -04005304 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005305 self.waitUntilSettled()
5306
5307 job_C = None
5308 for job in self.builds:
5309 if 'project-merge' in job.name:
5310 job_C = job
James E. Blairb1345832017-07-21 14:51:35 -07005311
James E. Blair2a535672017-04-27 12:03:15 -07005312 path = os.path.join(job_C.jobdir.src_root, 'review.example.com',
5313 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005314 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07005315 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005316
5317 repo_messages.reverse()
5318 correct_messages = [
5319 'initial commit', 'add content from fixture',
5320 'A-1', 'C-1']
5321 # Ensure the right commits are in the history for this ref
5322 self.assertEqual(repo_messages, correct_messages)
5323
Paul Belanger174a8272017-03-14 13:20:10 -04005324 self.executor_server.hold_jobs_in_build = False
5325 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08005326 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005327
5328
James E. Blair9ea0d0b2017-04-20 09:27:15 -07005329class TestSemaphore(ZuulTestCase):
5330 tenant_config_file = 'config/semaphore/main.yaml'
5331
5332 def test_semaphore_one(self):
5333 "Test semaphores with max=1 (mutex)"
5334 tenant = self.sched.abide.tenants.get('tenant-one')
5335
5336 self.executor_server.hold_jobs_in_build = True
5337
5338 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5339 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5340 self.assertFalse('test-semaphore' in
5341 tenant.semaphore_handler.semaphores)
5342
5343 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5344 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5345 self.waitUntilSettled()
5346
5347 self.assertEqual(len(self.builds), 3)
5348 self.assertEqual(self.builds[0].name, 'project-test1')
5349 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
5350 self.assertEqual(self.builds[2].name, 'project-test1')
5351
5352 self.executor_server.release('semaphore-one-test1')
5353 self.waitUntilSettled()
5354
5355 self.assertEqual(len(self.builds), 3)
5356 self.assertEqual(self.builds[0].name, 'project-test1')
5357 self.assertEqual(self.builds[1].name, 'project-test1')
5358 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
5359 self.assertTrue('test-semaphore' in
5360 tenant.semaphore_handler.semaphores)
5361
5362 self.executor_server.release('semaphore-one-test2')
5363 self.waitUntilSettled()
5364
5365 self.assertEqual(len(self.builds), 3)
5366 self.assertEqual(self.builds[0].name, 'project-test1')
5367 self.assertEqual(self.builds[1].name, 'project-test1')
5368 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
5369 self.assertTrue('test-semaphore' in
5370 tenant.semaphore_handler.semaphores)
5371
5372 self.executor_server.release('semaphore-one-test1')
5373 self.waitUntilSettled()
5374
5375 self.assertEqual(len(self.builds), 3)
5376 self.assertEqual(self.builds[0].name, 'project-test1')
5377 self.assertEqual(self.builds[1].name, 'project-test1')
5378 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
5379 self.assertTrue('test-semaphore' in
5380 tenant.semaphore_handler.semaphores)
5381
5382 self.executor_server.release('semaphore-one-test2')
5383 self.waitUntilSettled()
5384
5385 self.assertEqual(len(self.builds), 2)
5386 self.assertEqual(self.builds[0].name, 'project-test1')
5387 self.assertEqual(self.builds[1].name, 'project-test1')
5388 self.assertFalse('test-semaphore' in
5389 tenant.semaphore_handler.semaphores)
5390
5391 self.executor_server.hold_jobs_in_build = False
5392 self.executor_server.release()
5393
5394 self.waitUntilSettled()
5395 self.assertEqual(len(self.builds), 0)
5396
5397 self.assertEqual(A.reported, 1)
5398 self.assertEqual(B.reported, 1)
5399 self.assertFalse('test-semaphore' in
5400 tenant.semaphore_handler.semaphores)
5401
5402 def test_semaphore_two(self):
5403 "Test semaphores with max>1"
5404 tenant = self.sched.abide.tenants.get('tenant-one')
5405
5406 self.executor_server.hold_jobs_in_build = True
5407 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5408 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5409 self.assertFalse('test-semaphore-two' in
5410 tenant.semaphore_handler.semaphores)
5411
5412 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5413 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5414 self.waitUntilSettled()
5415
5416 self.assertEqual(len(self.builds), 4)
5417 self.assertEqual(self.builds[0].name, 'project-test1')
5418 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
5419 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
5420 self.assertEqual(self.builds[3].name, 'project-test1')
5421 self.assertTrue('test-semaphore-two' in
5422 tenant.semaphore_handler.semaphores)
5423 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5424 'test-semaphore-two', [])), 2)
5425
5426 self.executor_server.release('semaphore-two-test1')
5427 self.waitUntilSettled()
5428
5429 self.assertEqual(len(self.builds), 4)
5430 self.assertEqual(self.builds[0].name, 'project-test1')
5431 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
5432 self.assertEqual(self.builds[2].name, 'project-test1')
5433 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
5434 self.assertTrue('test-semaphore-two' in
5435 tenant.semaphore_handler.semaphores)
5436 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5437 'test-semaphore-two', [])), 2)
5438
5439 self.executor_server.release('semaphore-two-test2')
5440 self.waitUntilSettled()
5441
5442 self.assertEqual(len(self.builds), 4)
5443 self.assertEqual(self.builds[0].name, 'project-test1')
5444 self.assertEqual(self.builds[1].name, 'project-test1')
5445 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
5446 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
5447 self.assertTrue('test-semaphore-two' in
5448 tenant.semaphore_handler.semaphores)
5449 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5450 'test-semaphore-two', [])), 2)
5451
5452 self.executor_server.release('semaphore-two-test1')
5453 self.waitUntilSettled()
5454
5455 self.assertEqual(len(self.builds), 3)
5456 self.assertEqual(self.builds[0].name, 'project-test1')
5457 self.assertEqual(self.builds[1].name, 'project-test1')
5458 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
5459 self.assertTrue('test-semaphore-two' in
5460 tenant.semaphore_handler.semaphores)
5461 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5462 'test-semaphore-two', [])), 1)
5463
5464 self.executor_server.release('semaphore-two-test2')
5465 self.waitUntilSettled()
5466
5467 self.assertEqual(len(self.builds), 2)
5468 self.assertEqual(self.builds[0].name, 'project-test1')
5469 self.assertEqual(self.builds[1].name, 'project-test1')
5470 self.assertFalse('test-semaphore-two' in
5471 tenant.semaphore_handler.semaphores)
5472
5473 self.executor_server.hold_jobs_in_build = False
5474 self.executor_server.release()
5475
5476 self.waitUntilSettled()
5477 self.assertEqual(len(self.builds), 0)
5478
5479 self.assertEqual(A.reported, 1)
5480 self.assertEqual(B.reported, 1)
5481
5482 def test_semaphore_abandon(self):
5483 "Test abandon with job semaphores"
5484 self.executor_server.hold_jobs_in_build = True
5485 tenant = self.sched.abide.tenants.get('tenant-one')
5486 check_pipeline = tenant.layout.pipelines['check']
5487
5488 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5489 self.assertFalse('test-semaphore' in
5490 tenant.semaphore_handler.semaphores)
5491
5492 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5493 self.waitUntilSettled()
5494
5495 self.assertTrue('test-semaphore' in
5496 tenant.semaphore_handler.semaphores)
5497
5498 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
5499 self.waitUntilSettled()
5500
5501 # The check pipeline should be empty
5502 items = check_pipeline.getAllItems()
5503 self.assertEqual(len(items), 0)
5504
5505 # The semaphore should be released
5506 self.assertFalse('test-semaphore' in
5507 tenant.semaphore_handler.semaphores)
5508
5509 self.executor_server.hold_jobs_in_build = False
5510 self.executor_server.release()
5511 self.waitUntilSettled()
5512
Tobias Henkel0f714002017-06-30 23:30:52 +02005513 def test_semaphore_new_patchset(self):
5514 "Test new patchset with job semaphores"
5515 self.executor_server.hold_jobs_in_build = True
5516 tenant = self.sched.abide.tenants.get('tenant-one')
5517 check_pipeline = tenant.layout.pipelines['check']
5518
5519 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5520 self.assertFalse('test-semaphore' in
5521 tenant.semaphore_handler.semaphores)
5522
5523 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5524 self.waitUntilSettled()
5525
5526 self.assertTrue('test-semaphore' in
5527 tenant.semaphore_handler.semaphores)
5528 semaphore = tenant.semaphore_handler.semaphores['test-semaphore']
5529 self.assertEqual(len(semaphore), 1)
5530
5531 A.addPatchset()
5532 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
5533 self.waitUntilSettled()
5534
5535 self.assertTrue('test-semaphore' in
5536 tenant.semaphore_handler.semaphores)
5537 semaphore = tenant.semaphore_handler.semaphores['test-semaphore']
5538 self.assertEqual(len(semaphore), 1)
5539
5540 items = check_pipeline.getAllItems()
5541 self.assertEqual(items[0].change.number, '1')
5542 self.assertEqual(items[0].change.patchset, '2')
5543 self.assertTrue(items[0].live)
5544
5545 self.executor_server.hold_jobs_in_build = False
5546 self.executor_server.release()
5547 self.waitUntilSettled()
5548
5549 # The semaphore should be released
5550 self.assertFalse('test-semaphore' in
5551 tenant.semaphore_handler.semaphores)
5552
James E. Blair9ea0d0b2017-04-20 09:27:15 -07005553 def test_semaphore_reconfigure(self):
5554 "Test reconfigure with job semaphores"
5555 self.executor_server.hold_jobs_in_build = True
5556 tenant = self.sched.abide.tenants.get('tenant-one')
5557 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5558 self.assertFalse('test-semaphore' in
5559 tenant.semaphore_handler.semaphores)
5560
5561 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5562 self.waitUntilSettled()
5563
5564 self.assertTrue('test-semaphore' in
5565 tenant.semaphore_handler.semaphores)
5566
5567 # reconfigure without layout change
5568 self.sched.reconfigure(self.config)
5569 self.waitUntilSettled()
5570 tenant = self.sched.abide.tenants.get('tenant-one')
5571
5572 # semaphore still must be held
5573 self.assertTrue('test-semaphore' in
5574 tenant.semaphore_handler.semaphores)
5575
5576 self.commitConfigUpdate(
5577 'common-config',
5578 'config/semaphore/zuul-reconfiguration.yaml')
5579 self.sched.reconfigure(self.config)
5580 self.waitUntilSettled()
5581 tenant = self.sched.abide.tenants.get('tenant-one')
5582
5583 self.executor_server.release('project-test1')
5584 self.waitUntilSettled()
5585
5586 # There should be no builds anymore
5587 self.assertEqual(len(self.builds), 0)
5588
5589 # The semaphore should be released
5590 self.assertFalse('test-semaphore' in
5591 tenant.semaphore_handler.semaphores)
5592
5593
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005594class TestSemaphoreMultiTenant(ZuulTestCase):
5595 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5596
5597 def test_semaphore_tenant_isolation(self):
5598 "Test semaphores in multiple tenants"
5599
5600 self.waitUntilSettled()
5601 tenant_one = self.sched.abide.tenants.get('tenant-one')
5602 tenant_two = self.sched.abide.tenants.get('tenant-two')
5603
5604 self.executor_server.hold_jobs_in_build = True
5605 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5606 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5607 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5608 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5609 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5610 self.assertFalse('test-semaphore' in
5611 tenant_one.semaphore_handler.semaphores)
5612 self.assertFalse('test-semaphore' in
5613 tenant_two.semaphore_handler.semaphores)
5614
5615 # add patches to project1 of tenant-one
5616 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5617 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5618 self.waitUntilSettled()
5619
5620 # one build of project1-test1 must run
5621 # semaphore of tenant-one must be acquired once
5622 # semaphore of tenant-two must not be acquired
5623 self.assertEqual(len(self.builds), 1)
5624 self.assertEqual(self.builds[0].name, 'project1-test1')
5625 self.assertTrue('test-semaphore' in
5626 tenant_one.semaphore_handler.semaphores)
5627 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5628 'test-semaphore', [])), 1)
5629 self.assertFalse('test-semaphore' in
5630 tenant_two.semaphore_handler.semaphores)
5631
5632 # add patches to project2 of tenant-two
5633 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5634 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5635 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5636 self.waitUntilSettled()
5637
5638 # one build of project1-test1 must run
5639 # two builds of project2-test1 must run
5640 # semaphore of tenant-one must be acquired once
5641 # semaphore of tenant-two must be acquired twice
5642 self.assertEqual(len(self.builds), 3)
5643 self.assertEqual(self.builds[0].name, 'project1-test1')
5644 self.assertEqual(self.builds[1].name, 'project2-test1')
5645 self.assertEqual(self.builds[2].name, 'project2-test1')
5646 self.assertTrue('test-semaphore' in
5647 tenant_one.semaphore_handler.semaphores)
5648 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5649 'test-semaphore', [])), 1)
5650 self.assertTrue('test-semaphore' in
5651 tenant_two.semaphore_handler.semaphores)
5652 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5653 'test-semaphore', [])), 2)
5654
5655 self.executor_server.release('project1-test1')
5656 self.waitUntilSettled()
5657
5658 # one build of project1-test1 must run
5659 # two builds of project2-test1 must run
5660 # semaphore of tenant-one must be acquired once
5661 # semaphore of tenant-two must be acquired twice
5662 self.assertEqual(len(self.builds), 3)
5663 self.assertEqual(self.builds[0].name, 'project2-test1')
5664 self.assertEqual(self.builds[1].name, 'project2-test1')
5665 self.assertEqual(self.builds[2].name, 'project1-test1')
5666 self.assertTrue('test-semaphore' in
5667 tenant_one.semaphore_handler.semaphores)
5668 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5669 'test-semaphore', [])), 1)
5670 self.assertTrue('test-semaphore' in
5671 tenant_two.semaphore_handler.semaphores)
5672 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5673 'test-semaphore', [])), 2)
5674
5675 self.executor_server.release('project2-test1')
5676 self.waitUntilSettled()
5677
5678 # one build of project1-test1 must run
5679 # one build of project2-test1 must run
5680 # semaphore of tenant-one must be acquired once
5681 # semaphore of tenant-two must be acquired once
5682 self.assertEqual(len(self.builds), 2)
5683 self.assertTrue('test-semaphore' in
5684 tenant_one.semaphore_handler.semaphores)
5685 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5686 'test-semaphore', [])), 1)
5687 self.assertTrue('test-semaphore' in
5688 tenant_two.semaphore_handler.semaphores)
5689 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5690 'test-semaphore', [])), 1)
5691
5692 self.executor_server.hold_jobs_in_build = False
5693 self.executor_server.release()
5694
5695 self.waitUntilSettled()
5696
5697 # no build must run
5698 # semaphore of tenant-one must not be acquired
5699 # semaphore of tenant-two must not be acquired
5700 self.assertEqual(len(self.builds), 0)
5701 self.assertFalse('test-semaphore' in
5702 tenant_one.semaphore_handler.semaphores)
5703 self.assertFalse('test-semaphore' in
5704 tenant_two.semaphore_handler.semaphores)
5705
5706 self.assertEqual(A.reported, 1)
5707 self.assertEqual(B.reported, 1)
5708
5709
5710class TestSemaphoreInRepo(ZuulTestCase):
Tobias Henkelabf973e2017-07-28 10:07:34 +02005711 config_file = 'zuul-connections-gerrit-and-github.conf'
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005712 tenant_config_file = 'config/in-repo/main.yaml'
5713
5714 def test_semaphore_in_repo(self):
5715 "Test semaphores in repo config"
5716
5717 # This tests dynamic semaphore handling in project repos. The semaphore
5718 # max value should not be evaluated dynamically but must be updated
5719 # after the change lands.
5720
5721 self.waitUntilSettled()
5722 tenant = self.sched.abide.tenants.get('tenant-one')
5723
5724 in_repo_conf = textwrap.dedent(
5725 """
5726 - job:
Tobias Henkelf02cf512017-07-21 22:55:34 +02005727 name: project-test1
5728
5729 - job:
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005730 name: project-test2
5731 semaphore: test-semaphore
5732
5733 - project:
5734 name: org/project
5735 tenant-one-gate:
5736 jobs:
5737 - project-test2
5738
5739 # the max value in dynamic layout must be ignored
5740 - semaphore:
5741 name: test-semaphore
5742 max: 2
5743 """)
5744
5745 in_repo_playbook = textwrap.dedent(
5746 """
5747 - hosts: all
5748 tasks: []
5749 """)
5750
5751 file_dict = {'.zuul.yaml': in_repo_conf,
5752 'playbooks/project-test2.yaml': in_repo_playbook}
5753 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5754 files=file_dict)
5755 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5756 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5757 B.setDependsOn(A, 1)
5758 C.setDependsOn(A, 1)
5759
5760 self.executor_server.hold_jobs_in_build = True
5761
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005762 A.addApproval('Code-Review', 2)
5763 B.addApproval('Code-Review', 2)
5764 C.addApproval('Code-Review', 2)
5765 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5766 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5767 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005768 self.waitUntilSettled()
5769
5770 # check that the layout in a queue item still has max value of 1
5771 # for test-semaphore
5772 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5773 queue = None
5774 for queue_candidate in pipeline.queues:
5775 if queue_candidate.name == 'org/project':
5776 queue = queue_candidate
5777 break
5778 queue_item = queue.queue[0]
James E. Blair29a24fd2017-10-02 15:04:56 -07005779 item_dynamic_layout = queue_item.layout
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005780 dynamic_test_semaphore = \
5781 item_dynamic_layout.semaphores.get('test-semaphore')
5782 self.assertEqual(dynamic_test_semaphore.max, 1)
5783
5784 # one build must be in queue, one semaphores acquired
5785 self.assertEqual(len(self.builds), 1)
5786 self.assertEqual(self.builds[0].name, 'project-test2')
5787 self.assertTrue('test-semaphore' in
5788 tenant.semaphore_handler.semaphores)
5789 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5790 'test-semaphore', [])), 1)
5791
5792 self.executor_server.release('project-test2')
5793 self.waitUntilSettled()
5794
5795 # change A must be merged
5796 self.assertEqual(A.data['status'], 'MERGED')
5797 self.assertEqual(A.reported, 2)
5798
5799 # send change-merged event as the gerrit mock doesn't send it
5800 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5801 self.waitUntilSettled()
5802
5803 # now that change A was merged, the new semaphore max must be effective
5804 tenant = self.sched.abide.tenants.get('tenant-one')
5805 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5806
5807 # two builds must be in queue, two semaphores acquired
5808 self.assertEqual(len(self.builds), 2)
5809 self.assertEqual(self.builds[0].name, 'project-test2')
5810 self.assertEqual(self.builds[1].name, 'project-test2')
5811 self.assertTrue('test-semaphore' in
5812 tenant.semaphore_handler.semaphores)
5813 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5814 'test-semaphore', [])), 2)
5815
5816 self.executor_server.release('project-test2')
5817 self.waitUntilSettled()
5818
5819 self.assertEqual(len(self.builds), 0)
5820 self.assertFalse('test-semaphore' in
5821 tenant.semaphore_handler.semaphores)
5822
5823 self.executor_server.hold_jobs_in_build = False
5824 self.executor_server.release()
5825
5826 self.waitUntilSettled()
5827 self.assertEqual(len(self.builds), 0)
5828
5829 self.assertEqual(A.reported, 2)
5830 self.assertEqual(B.reported, 2)
5831 self.assertEqual(C.reported, 2)
David Shrewsburyf6dc1762017-10-02 13:34:37 -04005832
5833
5834class TestSchedulerBranchMatcher(ZuulTestCase):
5835
5836 @simple_layout('layouts/matcher-test.yaml')
5837 def test_job_branch_ignored(self):
5838 '''
5839 Test that branch matching logic works.
5840
5841 The 'ignore-branch' job has a branch matcher that is supposed to
5842 match every branch except for the 'featureA' branch, so it should
5843 not be run on a change to that branch.
5844 '''
5845 self.create_branch('org/project', 'featureA')
5846 A = self.fake_gerrit.addFakeChange('org/project', 'featureA', 'A')
5847 A.addApproval('Code-Review', 2)
5848 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5849 self.waitUntilSettled()
5850 self.printHistory()
5851 self.assertEqual(self.getJobFromHistory('project-test1').result,
5852 'SUCCESS')
5853 self.assertJobNotInHistory('ignore-branch')
5854 self.assertEqual(A.data['status'], 'MERGED')
5855 self.assertEqual(A.reported, 2,
5856 "A should report start and success")
5857 self.assertIn('gate', A.messages[1],
5858 "A should transit gate")