blob: bc849890b00e561541c793f9fa28c994d99282e8 [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
James E. Blairec056492016-07-22 09:45:56 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Morgan Fainberg293f7f82016-05-30 14:01:22 -070028from six.moves import urllib
Monty Taylorbc758832013-06-17 17:22:42 -040029import testtools
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
James E. Blairb0fcae42012-07-17 11:12:10 -070032import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080033import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040034import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070035
Maru Newby3fe5f852015-01-13 04:22:14 +000036from tests.base import (
Maru Newby3fe5f852015-01-13 04:22:14 +000037 ZuulTestCase,
38 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070039 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000040)
James E. Blairb0fcae42012-07-17 11:12:10 -070041
James E. Blairb0fcae42012-07-17 11:12:10 -070042
Clark Boylanb640e052014-04-03 16:41:46 -070043class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070044 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010045
Paul Belanger174a8272017-03-14 13:20:10 -040046 def test_jobs_executed(self):
47 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070048
James E. Blairb0fcae42012-07-17 11:12:10 -070049 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -070050 A.addApproval('code-review', 2)
51 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070052 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040053 self.assertEqual(self.getJobFromHistory('project-merge').result,
54 'SUCCESS')
55 self.assertEqual(self.getJobFromHistory('project-test1').result,
56 'SUCCESS')
57 self.assertEqual(self.getJobFromHistory('project-test2').result,
58 'SUCCESS')
59 self.assertEqual(A.data['status'], 'MERGED')
60 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070061 self.assertEqual(self.getJobFromHistory('project-test1').node,
62 'image1')
Adam Gandelmaneace4692017-02-07 15:18:36 -080063 self.assertIsNone(self.getJobFromHistory('project-test2').node)
James E. Blairb0fcae42012-07-17 11:12:10 -070064
James E. Blair552b54f2016-07-22 13:55:32 -070065 # TODOv3(jeblair): we may want to report stats by tenant (also?).
James E. Blair66eeebf2013-07-27 17:44:32 -070066 self.assertReportedStat('gerrit.event.comment-added', value='1|c')
67 self.assertReportedStat('zuul.pipeline.gate.current_changes',
68 value='1|g')
69 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
70 kind='ms')
71 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
72 value='1|c')
73 self.assertReportedStat('zuul.pipeline.gate.resident_time', kind='ms')
74 self.assertReportedStat('zuul.pipeline.gate.total_changes',
75 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070076 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070077 'zuul.pipeline.gate.org.project.resident_time', kind='ms')
James E. Blair412e5582013-04-22 15:50:12 -070078 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070079 'zuul.pipeline.gate.org.project.total_changes', value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070080
James E. Blair5821bd92015-09-16 08:48:15 -070081 for build in self.builds:
82 self.assertEqual(build.parameters['ZUUL_VOTING'], '1')
83
James E. Blair3cb10702013-08-24 08:56:03 -070084 def test_initial_pipeline_gauges(self):
85 "Test that each pipeline reported its length on start"
James E. Blair7da51b72016-07-25 15:29:43 -070086 self.assertReportedStat('zuul.pipeline.gate.current_changes',
87 value='0|g')
88 self.assertReportedStat('zuul.pipeline.check.current_changes',
89 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -070090
James E. Blair34776ee2016-08-25 13:53:54 -070091 def test_job_branch(self):
92 "Test the correct variant of a job runs on a branch"
93 self.create_branch('org/project', 'stable')
94 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
95 A.addApproval('code-review', 2)
96 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
97 self.waitUntilSettled()
98 self.assertEqual(self.getJobFromHistory('project-test1').result,
99 'SUCCESS')
100 self.assertEqual(self.getJobFromHistory('project-test2').result,
101 'SUCCESS')
102 self.assertEqual(A.data['status'], 'MERGED')
103 self.assertEqual(A.reported, 2,
104 "A should report start and success")
105 self.assertIn('gate', A.messages[1],
106 "A should transit gate")
107 self.assertEqual(self.getJobFromHistory('project-test1').node,
108 'image2')
109
James E. Blairb0fcae42012-07-17 11:12:10 -0700110 def test_parallel_changes(self):
111 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700112
Paul Belanger174a8272017-03-14 13:20:10 -0400113 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700114 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
115 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
116 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700117 A.addApproval('code-review', 2)
118 B.addApproval('code-review', 2)
119 C.addApproval('code-review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700120
James E. Blair8b5408c2016-08-08 15:37:46 -0700121 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
122 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
123 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700124
125 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400126 self.assertEqual(len(self.builds), 1)
127 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700128 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700129
Paul Belanger174a8272017-03-14 13:20:10 -0400130 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700131 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400132 self.assertEqual(len(self.builds), 3)
133 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700134 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400135 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700136 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400137 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700138 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700139
Paul Belanger174a8272017-03-14 13:20:10 -0400140 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700141 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400142 self.assertEqual(len(self.builds), 5)
143 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700144 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400145 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700146 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700147
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400148 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700149 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400150 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700151 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700152
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400153 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700154 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700155
Paul Belanger174a8272017-03-14 13:20:10 -0400156 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700157 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400158 self.assertEqual(len(self.builds), 6)
159 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700160 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400161 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700162 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700163
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400164 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700165 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400166 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700167 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700168
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400169 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700170 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400171 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700172 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700173
Paul Belanger174a8272017-03-14 13:20:10 -0400174 self.executor_server.hold_jobs_in_build = False
175 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700176 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400177 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700178
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400179 self.assertEqual(len(self.history), 9)
180 self.assertEqual(A.data['status'], 'MERGED')
181 self.assertEqual(B.data['status'], 'MERGED')
182 self.assertEqual(C.data['status'], 'MERGED')
183 self.assertEqual(A.reported, 2)
184 self.assertEqual(B.reported, 2)
185 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700186
187 def test_failed_changes(self):
188 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400189 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700190
James E. Blairb02a3bb2012-07-30 17:49:55 -0700191 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
192 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -0700193 A.addApproval('code-review', 2)
194 B.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700195
Paul Belanger174a8272017-03-14 13:20:10 -0400196 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700197
James E. Blair8b5408c2016-08-08 15:37:46 -0700198 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
199 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700200 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700201 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400202
Paul Belanger174a8272017-03-14 13:20:10 -0400203 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400204 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700205 # A/project-merge is complete
206 self.assertBuilds([
207 dict(name='project-test1', changes='1,1'),
208 dict(name='project-test2', changes='1,1'),
209 dict(name='project-merge', changes='1,1 2,1'),
210 ])
James E. Blaire2819012013-06-28 17:17:26 -0400211
Paul Belanger174a8272017-03-14 13:20:10 -0400212 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400213 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700214 # A/project-merge is complete
215 # B/project-merge is complete
216 self.assertBuilds([
217 dict(name='project-test1', changes='1,1'),
218 dict(name='project-test2', changes='1,1'),
219 dict(name='project-test1', changes='1,1 2,1'),
220 dict(name='project-test2', changes='1,1 2,1'),
221 ])
222
223 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400224 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700225 self.builds[0].release()
226 self.waitUntilSettled()
227
228 self.orderedRelease()
229 self.assertHistory([
230 dict(name='project-merge', result='SUCCESS', changes='1,1'),
231 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
232 dict(name='project-test1', result='FAILURE', changes='1,1'),
233 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
234 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
235 dict(name='project-test2', result='SUCCESS', changes='1,1'),
236 dict(name='project-merge', result='SUCCESS', changes='2,1'),
237 dict(name='project-test1', result='SUCCESS', changes='2,1'),
238 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700239 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700240
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400241 self.assertEqual(A.data['status'], 'NEW')
242 self.assertEqual(B.data['status'], 'MERGED')
243 self.assertEqual(A.reported, 2)
244 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700245
246 def test_independent_queues(self):
247 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700248
Paul Belanger174a8272017-03-14 13:20:10 -0400249 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900250 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700251 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
252 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700253 A.addApproval('code-review', 2)
254 B.addApproval('code-review', 2)
255 C.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700256
James E. Blair8b5408c2016-08-08 15:37:46 -0700257 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800258 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700259
James E. Blairf59f3cf2017-02-19 14:50:26 -0800260 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
261 self.waitUntilSettled()
262
263 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700264 self.waitUntilSettled()
265
266 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700267 self.assertBuilds([
268 dict(name='project-merge', changes='1,1'),
269 dict(name='project-merge', changes='2,1'),
270 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700271
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700272 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700273 self.builds[0].release()
274 self.waitUntilSettled()
275 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700276 self.waitUntilSettled()
277 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400278 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700279 self.waitUntilSettled()
280
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700281 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700282 self.assertBuilds([
283 dict(name='project-test1', changes='1,1'),
284 dict(name='project-test2', changes='1,1'),
285 dict(name='project-test1', changes='2,1'),
286 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500287 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700288 dict(name='project-test1', changes='2,1 3,1'),
289 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800290 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700291 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700292
James E. Blair5f0d49e2016-08-19 09:36:50 -0700293 self.orderedRelease()
294 self.assertHistory([
295 dict(name='project-merge', result='SUCCESS', changes='1,1'),
296 dict(name='project-merge', result='SUCCESS', changes='2,1'),
297 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
298 dict(name='project-test1', result='SUCCESS', changes='1,1'),
299 dict(name='project-test2', result='SUCCESS', changes='1,1'),
300 dict(name='project-test1', result='SUCCESS', changes='2,1'),
301 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500302 dict(
303 name='project1-project2-integration',
304 result='SUCCESS',
305 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700306 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
307 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800308 dict(name='project1-project2-integration',
309 result='SUCCESS',
310 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700311 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700312
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400313 self.assertEqual(A.data['status'], 'MERGED')
314 self.assertEqual(B.data['status'], 'MERGED')
315 self.assertEqual(C.data['status'], 'MERGED')
316 self.assertEqual(A.reported, 2)
317 self.assertEqual(B.reported, 2)
318 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700319
320 def test_failed_change_at_head(self):
321 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700322
Paul Belanger174a8272017-03-14 13:20:10 -0400323 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700324 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
325 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
326 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700327 A.addApproval('code-review', 2)
328 B.addApproval('code-review', 2)
329 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700330
Paul Belanger174a8272017-03-14 13:20:10 -0400331 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700332
James E. Blair8b5408c2016-08-08 15:37:46 -0700333 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
334 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
335 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700336
337 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700338
James E. Blairb536ecc2016-08-31 10:11:42 -0700339 self.assertBuilds([
340 dict(name='project-merge', changes='1,1'),
341 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700342
Paul Belanger174a8272017-03-14 13:20:10 -0400343 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700344 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400345 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700346 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400347 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700348 self.waitUntilSettled()
349
James E. Blairb536ecc2016-08-31 10:11:42 -0700350 self.assertBuilds([
351 dict(name='project-test1', changes='1,1'),
352 dict(name='project-test2', changes='1,1'),
353 dict(name='project-test1', changes='1,1 2,1'),
354 dict(name='project-test2', changes='1,1 2,1'),
355 dict(name='project-test1', changes='1,1 2,1 3,1'),
356 dict(name='project-test2', changes='1,1 2,1 3,1'),
357 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700358
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400359 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700360 self.waitUntilSettled()
361
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400362 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700363 self.assertBuilds([
364 dict(name='project-test2', changes='1,1'),
365 dict(name='project-merge', changes='2,1'),
366 ])
367 # Unordered history comparison because the aborts can finish
368 # in any order.
369 self.assertHistory([
370 dict(name='project-merge', result='SUCCESS',
371 changes='1,1'),
372 dict(name='project-merge', result='SUCCESS',
373 changes='1,1 2,1'),
374 dict(name='project-merge', result='SUCCESS',
375 changes='1,1 2,1 3,1'),
376 dict(name='project-test1', result='FAILURE',
377 changes='1,1'),
378 dict(name='project-test1', result='ABORTED',
379 changes='1,1 2,1'),
380 dict(name='project-test2', result='ABORTED',
381 changes='1,1 2,1'),
382 dict(name='project-test1', result='ABORTED',
383 changes='1,1 2,1 3,1'),
384 dict(name='project-test2', result='ABORTED',
385 changes='1,1 2,1 3,1'),
386 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700387
Paul Belanger174a8272017-03-14 13:20:10 -0400388 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700389 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400390 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700391 self.waitUntilSettled()
392 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700393
James E. Blairb536ecc2016-08-31 10:11:42 -0700394 self.assertBuilds([])
395 self.assertHistory([
396 dict(name='project-merge', result='SUCCESS',
397 changes='1,1'),
398 dict(name='project-merge', result='SUCCESS',
399 changes='1,1 2,1'),
400 dict(name='project-merge', result='SUCCESS',
401 changes='1,1 2,1 3,1'),
402 dict(name='project-test1', result='FAILURE',
403 changes='1,1'),
404 dict(name='project-test1', result='ABORTED',
405 changes='1,1 2,1'),
406 dict(name='project-test2', result='ABORTED',
407 changes='1,1 2,1'),
408 dict(name='project-test1', result='ABORTED',
409 changes='1,1 2,1 3,1'),
410 dict(name='project-test2', result='ABORTED',
411 changes='1,1 2,1 3,1'),
412 dict(name='project-merge', result='SUCCESS',
413 changes='2,1'),
414 dict(name='project-merge', result='SUCCESS',
415 changes='2,1 3,1'),
416 dict(name='project-test2', result='SUCCESS',
417 changes='1,1'),
418 dict(name='project-test1', result='SUCCESS',
419 changes='2,1'),
420 dict(name='project-test2', result='SUCCESS',
421 changes='2,1'),
422 dict(name='project-test1', result='SUCCESS',
423 changes='2,1 3,1'),
424 dict(name='project-test2', result='SUCCESS',
425 changes='2,1 3,1'),
426 ], ordered=False)
427
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400428 self.assertEqual(A.data['status'], 'NEW')
429 self.assertEqual(B.data['status'], 'MERGED')
430 self.assertEqual(C.data['status'], 'MERGED')
431 self.assertEqual(A.reported, 2)
432 self.assertEqual(B.reported, 2)
433 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700434
James E. Blair0aac4872013-08-23 14:02:38 -0700435 def test_failed_change_in_middle(self):
436 "Test a failed change in the middle of the queue"
437
Paul Belanger174a8272017-03-14 13:20:10 -0400438 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700439 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
440 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
441 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700442 A.addApproval('code-review', 2)
443 B.addApproval('code-review', 2)
444 C.addApproval('code-review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700445
Paul Belanger174a8272017-03-14 13:20:10 -0400446 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700447
James E. Blair8b5408c2016-08-08 15:37:46 -0700448 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
449 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
450 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700451
452 self.waitUntilSettled()
453
Paul Belanger174a8272017-03-14 13:20:10 -0400454 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700455 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400456 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700457 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400458 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700459 self.waitUntilSettled()
460
461 self.assertEqual(len(self.builds), 6)
462 self.assertEqual(self.builds[0].name, 'project-test1')
463 self.assertEqual(self.builds[1].name, 'project-test2')
464 self.assertEqual(self.builds[2].name, 'project-test1')
465 self.assertEqual(self.builds[3].name, 'project-test2')
466 self.assertEqual(self.builds[4].name, 'project-test1')
467 self.assertEqual(self.builds[5].name, 'project-test2')
468
469 self.release(self.builds[2])
470 self.waitUntilSettled()
471
James E. Blair972e3c72013-08-29 12:04:55 -0700472 # project-test1 and project-test2 for A
473 # project-test2 for B
474 # project-merge for C (without B)
475 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700476 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
477
Paul Belanger174a8272017-03-14 13:20:10 -0400478 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700479 self.waitUntilSettled()
480
481 # project-test1 and project-test2 for A
482 # project-test2 for B
483 # project-test1 and project-test2 for C
484 self.assertEqual(len(self.builds), 5)
485
Paul Belanger2e2a0492016-10-30 18:33:37 -0400486 tenant = self.sched.abide.tenants.get('tenant-one')
487 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700488 builds = items[0].current_build_set.getBuilds()
489 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
490 self.assertEqual(self.countJobResults(builds, None), 2)
491 builds = items[1].current_build_set.getBuilds()
492 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
493 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
494 self.assertEqual(self.countJobResults(builds, None), 1)
495 builds = items[2].current_build_set.getBuilds()
496 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700497 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700498
Paul Belanger174a8272017-03-14 13:20:10 -0400499 self.executor_server.hold_jobs_in_build = False
500 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700501 self.waitUntilSettled()
502
503 self.assertEqual(len(self.builds), 0)
504 self.assertEqual(len(self.history), 12)
505 self.assertEqual(A.data['status'], 'MERGED')
506 self.assertEqual(B.data['status'], 'NEW')
507 self.assertEqual(C.data['status'], 'MERGED')
508 self.assertEqual(A.reported, 2)
509 self.assertEqual(B.reported, 2)
510 self.assertEqual(C.reported, 2)
511
James E. Blaird466dc42012-07-31 10:42:56 -0700512 def test_failed_change_at_head_with_queue(self):
513 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700514
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700515 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700516 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
517 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
518 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700519 A.addApproval('code-review', 2)
520 B.addApproval('code-review', 2)
521 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700522
Paul Belanger174a8272017-03-14 13:20:10 -0400523 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700524
James E. Blair8b5408c2016-08-08 15:37:46 -0700525 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
526 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
527 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700528
529 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700530 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400531 self.assertEqual(len(self.builds), 0)
532 self.assertEqual(len(queue), 1)
Paul Belanger174a8272017-03-14 13:20:10 -0400533 self.assertEqual(queue[0].name, 'executor:execute')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800534 job_args = json.loads(queue[0].arguments)
535 self.assertEqual(job_args['job'], 'project-merge')
536 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700537
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700538 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700539 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700540 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700541 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700542 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700543 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700544 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700545
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400546 self.assertEqual(len(self.builds), 0)
547 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800548
549 self.assertEqual(
550 json.loads(queue[0].arguments)['job'], 'project-test1')
551 self.assertEqual(
552 json.loads(queue[1].arguments)['job'], 'project-test2')
553 self.assertEqual(
554 json.loads(queue[2].arguments)['job'], 'project-test1')
555 self.assertEqual(
556 json.loads(queue[3].arguments)['job'], 'project-test2')
557 self.assertEqual(
558 json.loads(queue[4].arguments)['job'], 'project-test1')
559 self.assertEqual(
560 json.loads(queue[5].arguments)['job'], 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700561
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700562 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700563 self.waitUntilSettled()
564
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400565 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700566 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400567 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
568 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700569
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700570 self.gearman_server.hold_jobs_in_queue = False
571 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700572 self.waitUntilSettled()
573
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400574 self.assertEqual(len(self.builds), 0)
575 self.assertEqual(len(self.history), 11)
576 self.assertEqual(A.data['status'], 'NEW')
577 self.assertEqual(B.data['status'], 'MERGED')
578 self.assertEqual(C.data['status'], 'MERGED')
579 self.assertEqual(A.reported, 2)
580 self.assertEqual(B.reported, 2)
581 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700582
James E. Blairec056492016-07-22 09:45:56 -0700583 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700584 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400585 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700586 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -0700587 A.addApproval('code-review', 2)
588 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700589 self.waitUntilSettled()
590 time.sleep(2)
591
592 data = json.loads(self.sched.formatStatusJSON())
593 found_job = None
594 for pipeline in data['pipelines']:
595 if pipeline['name'] != 'gate':
596 continue
597 for queue in pipeline['change_queues']:
598 for head in queue['heads']:
599 for item in head:
600 for job in item['jobs']:
601 if job['name'] == 'project-merge':
602 found_job = job
603 break
604
605 self.assertIsNotNone(found_job)
606 if iteration == 1:
607 self.assertIsNotNone(found_job['estimated_time'])
608 self.assertIsNone(found_job['remaining_time'])
609 else:
610 self.assertIsNotNone(found_job['estimated_time'])
611 self.assertTrue(found_job['estimated_time'] >= 2)
612 self.assertIsNotNone(found_job['remaining_time'])
613
Paul Belanger174a8272017-03-14 13:20:10 -0400614 self.executor_server.hold_jobs_in_build = False
615 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700616 self.waitUntilSettled()
617
James E. Blairec056492016-07-22 09:45:56 -0700618 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700619 def test_time_database(self):
620 "Test the time database"
621
622 self._test_time_database(1)
623 self._test_time_database(2)
624
James E. Blairfef71632013-09-23 11:15:47 -0700625 def test_two_failed_changes_at_head(self):
626 "Test that changes are reparented correctly if 2 fail at head"
627
Paul Belanger174a8272017-03-14 13:20:10 -0400628 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700629 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
630 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
631 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700632 A.addApproval('code-review', 2)
633 B.addApproval('code-review', 2)
634 C.addApproval('code-review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700635
Paul Belanger174a8272017-03-14 13:20:10 -0400636 self.executor_server.failJob('project-test1', A)
637 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700638
James E. Blair8b5408c2016-08-08 15:37:46 -0700639 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
640 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
641 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700642 self.waitUntilSettled()
643
Paul Belanger174a8272017-03-14 13:20:10 -0400644 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700645 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400646 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700647 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400648 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700649 self.waitUntilSettled()
650
651 self.assertEqual(len(self.builds), 6)
652 self.assertEqual(self.builds[0].name, 'project-test1')
653 self.assertEqual(self.builds[1].name, 'project-test2')
654 self.assertEqual(self.builds[2].name, 'project-test1')
655 self.assertEqual(self.builds[3].name, 'project-test2')
656 self.assertEqual(self.builds[4].name, 'project-test1')
657 self.assertEqual(self.builds[5].name, 'project-test2')
658
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400659 self.assertTrue(self.builds[0].hasChanges(A))
660 self.assertTrue(self.builds[2].hasChanges(A))
661 self.assertTrue(self.builds[2].hasChanges(B))
662 self.assertTrue(self.builds[4].hasChanges(A))
663 self.assertTrue(self.builds[4].hasChanges(B))
664 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700665
666 # Fail change B first
667 self.release(self.builds[2])
668 self.waitUntilSettled()
669
670 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400671 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700672 self.waitUntilSettled()
673
674 self.assertEqual(len(self.builds), 5)
675 self.assertEqual(self.builds[0].name, 'project-test1')
676 self.assertEqual(self.builds[1].name, 'project-test2')
677 self.assertEqual(self.builds[2].name, 'project-test2')
678 self.assertEqual(self.builds[3].name, 'project-test1')
679 self.assertEqual(self.builds[4].name, 'project-test2')
680
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400681 self.assertTrue(self.builds[1].hasChanges(A))
682 self.assertTrue(self.builds[2].hasChanges(A))
683 self.assertTrue(self.builds[2].hasChanges(B))
684 self.assertTrue(self.builds[4].hasChanges(A))
685 self.assertFalse(self.builds[4].hasChanges(B))
686 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700687
688 # Finish running all passing jobs for change A
689 self.release(self.builds[1])
690 self.waitUntilSettled()
691 # Fail and report change A
692 self.release(self.builds[0])
693 self.waitUntilSettled()
694
695 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400696 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700697 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400698 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700699 self.waitUntilSettled()
700
701 self.assertEqual(len(self.builds), 4)
702 self.assertEqual(self.builds[0].name, 'project-test1') # B
703 self.assertEqual(self.builds[1].name, 'project-test2') # B
704 self.assertEqual(self.builds[2].name, 'project-test1') # C
705 self.assertEqual(self.builds[3].name, 'project-test2') # C
706
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400707 self.assertFalse(self.builds[1].hasChanges(A))
708 self.assertTrue(self.builds[1].hasChanges(B))
709 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700710
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400711 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700712 # After A failed and B and C restarted, B should be back in
713 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400714 self.assertTrue(self.builds[2].hasChanges(B))
715 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700716
Paul Belanger174a8272017-03-14 13:20:10 -0400717 self.executor_server.hold_jobs_in_build = False
718 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700719 self.waitUntilSettled()
720
721 self.assertEqual(len(self.builds), 0)
722 self.assertEqual(len(self.history), 21)
723 self.assertEqual(A.data['status'], 'NEW')
724 self.assertEqual(B.data['status'], 'NEW')
725 self.assertEqual(C.data['status'], 'MERGED')
726 self.assertEqual(A.reported, 2)
727 self.assertEqual(B.reported, 2)
728 self.assertEqual(C.reported, 2)
729
James E. Blair8c803f82012-07-31 16:25:42 -0700730 def test_patch_order(self):
731 "Test that dependent patches are tested in the right order"
732 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
733 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
734 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700735 A.addApproval('code-review', 2)
736 B.addApproval('code-review', 2)
737 C.addApproval('code-review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700738
739 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
740 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
741 M2.setMerged()
742 M1.setMerged()
743
744 # C -> B -> A -> M1 -> M2
745 # M2 is here to make sure it is never queried. If it is, it
746 # means zuul is walking down the entire history of merged
747 # changes.
748
749 C.setDependsOn(B, 1)
750 B.setDependsOn(A, 1)
751 A.setDependsOn(M1, 1)
752 M1.setDependsOn(M2, 1)
753
James E. Blair8b5408c2016-08-08 15:37:46 -0700754 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700755
756 self.waitUntilSettled()
757
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400758 self.assertEqual(A.data['status'], 'NEW')
759 self.assertEqual(B.data['status'], 'NEW')
760 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700761
James E. Blair8b5408c2016-08-08 15:37:46 -0700762 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
763 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700764
765 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400766 self.assertEqual(M2.queried, 0)
767 self.assertEqual(A.data['status'], 'MERGED')
768 self.assertEqual(B.data['status'], 'MERGED')
769 self.assertEqual(C.data['status'], 'MERGED')
770 self.assertEqual(A.reported, 2)
771 self.assertEqual(B.reported, 2)
772 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700773
James E. Blair063672f2015-01-29 13:09:12 -0800774 def test_needed_changes_enqueue(self):
775 "Test that a needed change is enqueued ahead"
776 # A Given a git tree like this, if we enqueue
777 # / \ change C, we should walk up and down the tree
778 # B G and enqueue changes in the order ABCDEFG.
779 # /|\ This is also the order that you would get if
780 # *C E F you enqueued changes in the order ABCDEFG, so
781 # / the ordering is stable across re-enqueue events.
782 # D
783
784 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
785 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
786 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
787 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
788 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
789 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
790 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
791 B.setDependsOn(A, 1)
792 C.setDependsOn(B, 1)
793 D.setDependsOn(C, 1)
794 E.setDependsOn(B, 1)
795 F.setDependsOn(B, 1)
796 G.setDependsOn(A, 1)
797
James E. Blair8b5408c2016-08-08 15:37:46 -0700798 A.addApproval('code-review', 2)
799 B.addApproval('code-review', 2)
800 C.addApproval('code-review', 2)
801 D.addApproval('code-review', 2)
802 E.addApproval('code-review', 2)
803 F.addApproval('code-review', 2)
804 G.addApproval('code-review', 2)
805 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800806
807 self.waitUntilSettled()
808
809 self.assertEqual(A.data['status'], 'NEW')
810 self.assertEqual(B.data['status'], 'NEW')
811 self.assertEqual(C.data['status'], 'NEW')
812 self.assertEqual(D.data['status'], 'NEW')
813 self.assertEqual(E.data['status'], 'NEW')
814 self.assertEqual(F.data['status'], 'NEW')
815 self.assertEqual(G.data['status'], 'NEW')
816
817 # We're about to add approvals to changes without adding the
818 # triggering events to Zuul, so that we can be sure that it is
819 # enqueing the changes based on dependencies, not because of
820 # triggering events. Since it will have the changes cached
821 # already (without approvals), we need to clear the cache
822 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400823 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +1100824 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800825
Paul Belanger174a8272017-03-14 13:20:10 -0400826 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -0700827 A.addApproval('approved', 1)
828 B.addApproval('approved', 1)
829 D.addApproval('approved', 1)
830 E.addApproval('approved', 1)
831 F.addApproval('approved', 1)
832 G.addApproval('approved', 1)
833 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800834
835 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400836 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800837 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400838 self.executor_server.hold_jobs_in_build = False
839 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800840 self.waitUntilSettled()
841
842 self.assertEqual(A.data['status'], 'MERGED')
843 self.assertEqual(B.data['status'], 'MERGED')
844 self.assertEqual(C.data['status'], 'MERGED')
845 self.assertEqual(D.data['status'], 'MERGED')
846 self.assertEqual(E.data['status'], 'MERGED')
847 self.assertEqual(F.data['status'], 'MERGED')
848 self.assertEqual(G.data['status'], 'MERGED')
849 self.assertEqual(A.reported, 2)
850 self.assertEqual(B.reported, 2)
851 self.assertEqual(C.reported, 2)
852 self.assertEqual(D.reported, 2)
853 self.assertEqual(E.reported, 2)
854 self.assertEqual(F.reported, 2)
855 self.assertEqual(G.reported, 2)
856 self.assertEqual(self.history[6].changes,
857 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
858
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100859 def test_source_cache(self):
860 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400861 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700862
863 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
864 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
865 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
James E. Blair8b5408c2016-08-08 15:37:46 -0700866 A.addApproval('code-review', 2)
867 B.addApproval('code-review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700868
869 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
870 M1.setMerged()
871
872 B.setDependsOn(A, 1)
873 A.setDependsOn(M1, 1)
874
James E. Blair8b5408c2016-08-08 15:37:46 -0700875 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700876 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
877
878 self.waitUntilSettled()
879
880 for build in self.builds:
881 if build.parameters['ZUUL_PIPELINE'] == 'check':
882 build.release()
883 self.waitUntilSettled()
884 for build in self.builds:
885 if build.parameters['ZUUL_PIPELINE'] == 'check':
886 build.release()
887 self.waitUntilSettled()
888
James E. Blair8b5408c2016-08-08 15:37:46 -0700889 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700890 self.waitUntilSettled()
891
Joshua Hesketh352264b2015-08-11 23:42:08 +1000892 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700893 # there should still be changes in the cache
Joshua Hesketh352264b2015-08-11 23:42:08 +1000894 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700895
Paul Belanger174a8272017-03-14 13:20:10 -0400896 self.executor_server.hold_jobs_in_build = False
897 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700898 self.waitUntilSettled()
899
900 self.assertEqual(A.data['status'], 'MERGED')
901 self.assertEqual(B.data['status'], 'MERGED')
902 self.assertEqual(A.queried, 2) # Initial and isMerged
903 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
904
James E. Blair8c803f82012-07-31 16:25:42 -0700905 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700906 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700907 # TODO: move to test_gerrit (this is a unit test!)
908 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400909 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700910 (trusted, project) = tenant.getProject('org/project')
911 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400912
913 # TODO(pabelanger): As we add more source / trigger APIs we should make
914 # it easier for users to create events for testing.
915 event = zuul.model.TriggerEvent()
916 event.trigger_name = 'gerrit'
917 event.change_number = '1'
918 event.patch_number = '2'
919
920 a = source.getChange(event)
921 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700922 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700923
James E. Blair8b5408c2016-08-08 15:37:46 -0700924 A.addApproval('code-review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400925 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700926 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700927
James E. Blair8b5408c2016-08-08 15:37:46 -0700928 A.addApproval('approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400929 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700930 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700931
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700932 def test_project_merge_conflict(self):
933 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700934
935 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700936 A = self.fake_gerrit.addFakeChange('org/project',
937 'master', 'A',
938 files={'conflict': 'foo'})
939 B = self.fake_gerrit.addFakeChange('org/project',
940 'master', 'B',
941 files={'conflict': 'bar'})
942 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -0700943 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700944 A.addApproval('code-review', 2)
945 B.addApproval('code-review', 2)
946 C.addApproval('code-review', 2)
947 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
948 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
949 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -0700950 self.waitUntilSettled()
951
James E. Blair6736beb2013-07-11 15:18:15 -0700952 self.assertEqual(A.reported, 1)
953 self.assertEqual(B.reported, 1)
954 self.assertEqual(C.reported, 1)
955
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700956 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700957 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700958 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700959 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700960 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700961 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -0700962
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700963 self.gearman_server.hold_jobs_in_queue = False
964 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -0700965 self.waitUntilSettled()
966
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400967 self.assertEqual(A.data['status'], 'MERGED')
968 self.assertEqual(B.data['status'], 'NEW')
969 self.assertEqual(C.data['status'], 'MERGED')
970 self.assertEqual(A.reported, 2)
971 self.assertEqual(B.reported, 2)
972 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700973
974 self.assertHistory([
975 dict(name='project-merge', result='SUCCESS', changes='1,1'),
976 dict(name='project-test1', result='SUCCESS', changes='1,1'),
977 dict(name='project-test2', result='SUCCESS', changes='1,1'),
978 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
979 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
980 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
981 ], ordered=False)
982
983 def test_delayed_merge_conflict(self):
984 "Test that delayed check merge conflicts are handled properly"
985
986 # Hold jobs in the gearman queue so that we can test whether
987 # the executor returns a merge failure after the scheduler has
988 # successfully merged.
989 self.gearman_server.hold_jobs_in_queue = True
990 A = self.fake_gerrit.addFakeChange('org/project',
991 'master', 'A',
992 files={'conflict': 'foo'})
993 B = self.fake_gerrit.addFakeChange('org/project',
994 'master', 'B',
995 files={'conflict': 'bar'})
996 C = self.fake_gerrit.addFakeChange('org/project',
997 'master', 'C')
998 C.setDependsOn(B, 1)
999
1000 # A enters the gate queue; B and C enter the check queue
1001 A.addApproval('code-review', 2)
1002 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1003 self.waitUntilSettled()
1004 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1005 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1006 self.waitUntilSettled()
1007
1008 self.assertEqual(A.reported, 1)
1009 self.assertEqual(B.reported, 0) # Check does not report start
1010 self.assertEqual(C.reported, 0) # Check does not report start
1011
1012 # A merges while B and C are queued in check
1013 # Release A project-merge
1014 queue = self.gearman_server.getQueue()
1015 self.release(queue[0])
1016 self.waitUntilSettled()
1017
1018 # Release A project-test*
1019 # gate has higher precedence, so A's test jobs are added in
1020 # front of the merge jobs for B and C
1021 queue = self.gearman_server.getQueue()
1022 self.release(queue[0])
1023 self.release(queue[1])
1024 self.waitUntilSettled()
1025
1026 self.assertEqual(A.data['status'], 'MERGED')
1027 self.assertEqual(B.data['status'], 'NEW')
1028 self.assertEqual(C.data['status'], 'NEW')
1029 self.assertEqual(A.reported, 2)
1030 self.assertEqual(B.reported, 0)
1031 self.assertEqual(C.reported, 0)
1032 self.assertHistory([
1033 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1034 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1035 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1036 ], ordered=False)
1037
1038 # B and C report merge conflicts
1039 # Release B project-merge
1040 queue = self.gearman_server.getQueue()
1041 self.release(queue[0])
1042 self.waitUntilSettled()
1043
1044 # Release C
1045 self.gearman_server.hold_jobs_in_queue = False
1046 self.gearman_server.release()
1047 self.waitUntilSettled()
1048
1049 self.assertEqual(A.data['status'], 'MERGED')
1050 self.assertEqual(B.data['status'], 'NEW')
1051 self.assertEqual(C.data['status'], 'NEW')
1052 self.assertEqual(A.reported, 2)
1053 self.assertEqual(B.reported, 1)
1054 self.assertEqual(C.reported, 1)
1055
1056 self.assertHistory([
1057 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1058 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1059 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1060 dict(name='project-merge', result='MERGER_FAILURE', changes='2,1'),
1061 dict(name='project-merge', result='MERGER_FAILURE',
1062 changes='2,1 3,1'),
1063 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001064
James E. Blairdaabed22012-08-15 15:38:57 -07001065 def test_post(self):
1066 "Test that post jobs run"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001067
Zhongyue Luo5d556072012-09-21 02:00:47 +09001068 e = {
1069 "type": "ref-updated",
1070 "submitter": {
1071 "name": "User Name",
1072 },
1073 "refUpdate": {
1074 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1075 "newRev": "d479a0bfcb34da57a31adb2a595c0cf687812543",
1076 "refName": "master",
1077 "project": "org/project",
1078 }
1079 }
James E. Blairdaabed22012-08-15 15:38:57 -07001080 self.fake_gerrit.addEvent(e)
1081 self.waitUntilSettled()
1082
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001083 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001084 self.assertEqual(len(self.history), 1)
1085 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001086
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001087 def test_post_ignore_deletes(self):
1088 "Test that deleting refs does not trigger post jobs"
1089
1090 e = {
1091 "type": "ref-updated",
1092 "submitter": {
1093 "name": "User Name",
1094 },
1095 "refUpdate": {
1096 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1097 "newRev": "0000000000000000000000000000000000000000",
1098 "refName": "master",
1099 "project": "org/project",
1100 }
1101 }
1102 self.fake_gerrit.addEvent(e)
1103 self.waitUntilSettled()
1104
1105 job_names = [x.name for x in self.history]
1106 self.assertEqual(len(self.history), 0)
1107 self.assertNotIn('project-post', job_names)
1108
1109 def test_post_ignore_deletes_negative(self):
1110 "Test that deleting refs does trigger post jobs"
1111
Adam Gandelmanc5e4f1d2016-11-29 14:27:17 -08001112 self.updateConfigLayout('layout-dont-ignore-ref-deletes')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001113 self.sched.reconfigure(self.config)
1114
1115 e = {
1116 "type": "ref-updated",
1117 "submitter": {
1118 "name": "User Name",
1119 },
1120 "refUpdate": {
1121 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1122 "newRev": "0000000000000000000000000000000000000000",
1123 "refName": "master",
1124 "project": "org/project",
1125 }
1126 }
1127 self.fake_gerrit.addEvent(e)
1128 self.waitUntilSettled()
1129
1130 job_names = [x.name for x in self.history]
1131 self.assertEqual(len(self.history), 1)
1132 self.assertIn('project-post', job_names)
1133
James E. Blairec056492016-07-22 09:45:56 -07001134 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001135 def test_build_configuration_branch_interaction(self):
1136 "Test that switching between branches works"
1137 self.test_build_configuration()
1138 self.test_build_configuration_branch()
1139 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001140 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001141 repo = git.Repo(path)
1142 repo.heads.master.commit = repo.commit('init')
1143 self.test_build_configuration()
1144
James E. Blaircaec0c52012-08-22 14:52:22 -07001145 def test_dependent_changes_dequeue(self):
1146 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001147
James E. Blaircaec0c52012-08-22 14:52:22 -07001148 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1149 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1150 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001151 A.addApproval('code-review', 2)
1152 B.addApproval('code-review', 2)
1153 C.addApproval('code-review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001154
1155 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1156 M1.setMerged()
1157
1158 # C -> B -> A -> M1
1159
1160 C.setDependsOn(B, 1)
1161 B.setDependsOn(A, 1)
1162 A.setDependsOn(M1, 1)
1163
Paul Belanger174a8272017-03-14 13:20:10 -04001164 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001165
James E. Blair8b5408c2016-08-08 15:37:46 -07001166 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1167 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1168 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001169
1170 self.waitUntilSettled()
1171
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001172 self.assertEqual(A.data['status'], 'NEW')
1173 self.assertEqual(A.reported, 2)
1174 self.assertEqual(B.data['status'], 'NEW')
1175 self.assertEqual(B.reported, 2)
1176 self.assertEqual(C.data['status'], 'NEW')
1177 self.assertEqual(C.reported, 2)
1178 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001179
James E. Blair972e3c72013-08-29 12:04:55 -07001180 def test_failing_dependent_changes(self):
1181 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001182 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001183 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1184 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1185 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1186 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1187 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
James E. Blair8b5408c2016-08-08 15:37:46 -07001188 A.addApproval('code-review', 2)
1189 B.addApproval('code-review', 2)
1190 C.addApproval('code-review', 2)
1191 D.addApproval('code-review', 2)
1192 E.addApproval('code-review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001193
1194 # E, D -> C -> B, A
1195
1196 D.setDependsOn(C, 1)
1197 C.setDependsOn(B, 1)
1198
Paul Belanger174a8272017-03-14 13:20:10 -04001199 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001200
James E. Blair8b5408c2016-08-08 15:37:46 -07001201 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1202 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
1203 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1204 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1205 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001206
1207 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001208 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001209 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001210 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001211 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001212 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001213 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001214 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001215 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001216 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001217 self.waitUntilSettled()
1218
Paul Belanger174a8272017-03-14 13:20:10 -04001219 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001220 for build in self.builds:
1221 if build.parameters['ZUUL_CHANGE'] != '1':
1222 build.release()
1223 self.waitUntilSettled()
1224
Paul Belanger174a8272017-03-14 13:20:10 -04001225 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001226 self.waitUntilSettled()
1227
1228 self.assertEqual(A.data['status'], 'MERGED')
1229 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001230 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001231 self.assertEqual(B.data['status'], 'NEW')
1232 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001233 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001234 self.assertEqual(C.data['status'], 'NEW')
1235 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001236 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001237 self.assertEqual(D.data['status'], 'NEW')
1238 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001239 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001240 self.assertEqual(E.data['status'], 'MERGED')
1241 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001242 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001243 self.assertEqual(len(self.history), 18)
1244
James E. Blairec590122012-08-22 15:19:31 -07001245 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001246 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001247 # If it's dequeued more than once, we should see extra
1248 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001249
Paul Belanger174a8272017-03-14 13:20:10 -04001250 self.executor_server.hold_jobs_in_build = True
James E. Blairec590122012-08-22 15:19:31 -07001251 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1252 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1253 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001254 A.addApproval('code-review', 2)
1255 B.addApproval('code-review', 2)
1256 C.addApproval('code-review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001257
Paul Belanger174a8272017-03-14 13:20:10 -04001258 self.executor_server.failJob('project-test1', A)
1259 self.executor_server.failJob('project-test2', A)
1260 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairec590122012-08-22 15:19:31 -07001261
James E. Blair8b5408c2016-08-08 15:37:46 -07001262 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1263 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1264 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001265
1266 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001267
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001268 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001269 self.assertEqual(self.builds[0].name, 'project-merge')
1270 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001271
Paul Belanger174a8272017-03-14 13:20:10 -04001272 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001273 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001274 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001275 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001276 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001277 self.waitUntilSettled()
1278
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001279 self.assertEqual(len(self.builds), 9)
Paul Belanger58bf6912016-11-11 19:36:01 -05001280 self.assertEqual(self.builds[0].name, 'project-test1')
1281 self.assertEqual(self.builds[1].name, 'project-test2')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001282 self.assertEqual(self.builds[2].name, 'project1-project2-integration')
Paul Belanger58bf6912016-11-11 19:36:01 -05001283 self.assertEqual(self.builds[3].name, 'project-test1')
1284 self.assertEqual(self.builds[4].name, 'project-test2')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001285 self.assertEqual(self.builds[5].name, 'project1-project2-integration')
Paul Belanger58bf6912016-11-11 19:36:01 -05001286 self.assertEqual(self.builds[6].name, 'project-test1')
1287 self.assertEqual(self.builds[7].name, 'project-test2')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001288 self.assertEqual(self.builds[8].name, 'project1-project2-integration')
James E. Blairec590122012-08-22 15:19:31 -07001289
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001290 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001291 self.waitUntilSettled()
1292
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001293 self.assertEqual(len(self.builds), 3) # test2,integration, merge for B
1294 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 6)
James E. Blairec590122012-08-22 15:19:31 -07001295
Paul Belanger174a8272017-03-14 13:20:10 -04001296 self.executor_server.hold_jobs_in_build = False
1297 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001298 self.waitUntilSettled()
1299
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001300 self.assertEqual(len(self.builds), 0)
1301 self.assertEqual(len(self.history), 20)
James E. Blaircaec0c52012-08-22 14:52:22 -07001302
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001303 self.assertEqual(A.data['status'], 'NEW')
1304 self.assertEqual(B.data['status'], 'MERGED')
1305 self.assertEqual(C.data['status'], 'MERGED')
1306 self.assertEqual(A.reported, 2)
1307 self.assertEqual(B.reported, 2)
1308 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001309
1310 def test_nonvoting_job(self):
1311 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001312
James E. Blair4ec821f2012-08-23 15:28:28 -07001313 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1314 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001315 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001316 self.executor_server.failJob('nonvoting-project-test2', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07001317 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001318
1319 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001320
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001321 self.assertEqual(A.data['status'], 'MERGED')
1322 self.assertEqual(A.reported, 2)
1323 self.assertEqual(
1324 self.getJobFromHistory('nonvoting-project-merge').result,
1325 'SUCCESS')
1326 self.assertEqual(
1327 self.getJobFromHistory('nonvoting-project-test1').result,
1328 'SUCCESS')
1329 self.assertEqual(
1330 self.getJobFromHistory('nonvoting-project-test2').result,
1331 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001332
James E. Blair5821bd92015-09-16 08:48:15 -07001333 for build in self.builds:
1334 self.assertEqual(build.parameters['ZUUL_VOTING'], '0')
1335
James E. Blaire0487072012-08-29 17:38:31 -07001336 def test_check_queue_success(self):
1337 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001338
James E. Blaire0487072012-08-29 17:38:31 -07001339 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1340 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1341
1342 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001343
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001344 self.assertEqual(A.data['status'], 'NEW')
1345 self.assertEqual(A.reported, 1)
1346 self.assertEqual(self.getJobFromHistory('project-merge').result,
1347 'SUCCESS')
1348 self.assertEqual(self.getJobFromHistory('project-test1').result,
1349 'SUCCESS')
1350 self.assertEqual(self.getJobFromHistory('project-test2').result,
1351 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001352
1353 def test_check_queue_failure(self):
1354 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001355
James E. Blaire0487072012-08-29 17:38:31 -07001356 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001357 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001358 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1359
1360 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001361
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001362 self.assertEqual(A.data['status'], 'NEW')
1363 self.assertEqual(A.reported, 1)
1364 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001365 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001366 self.assertEqual(self.getJobFromHistory('project-test1').result,
1367 'SUCCESS')
1368 self.assertEqual(self.getJobFromHistory('project-test2').result,
1369 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001370
1371 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001372 # This particular test does a large amount of merges and needs a little
1373 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001374 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001375 "test that dependent changes behind dequeued changes work"
1376 # This complicated test is a reproduction of a real life bug
1377 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001378
Paul Belanger174a8272017-03-14 13:20:10 -04001379 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001380 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1381 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1382 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1383 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1384 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1385 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1386 D.setDependsOn(C, 1)
1387 E.setDependsOn(D, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07001388 A.addApproval('code-review', 2)
1389 B.addApproval('code-review', 2)
1390 C.addApproval('code-review', 2)
1391 D.addApproval('code-review', 2)
1392 E.addApproval('code-review', 2)
1393 F.addApproval('code-review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001394
1395 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001396
1397 # Change object re-use in the gerrit trigger is hidden if
1398 # changes are added in quick succession; waiting makes it more
1399 # like real life.
James E. Blair8b5408c2016-08-08 15:37:46 -07001400 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001401 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001402 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001403 self.waitUntilSettled()
1404
Paul Belanger174a8272017-03-14 13:20:10 -04001405 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001406 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001407 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001408 self.waitUntilSettled()
1409
James E. Blair8b5408c2016-08-08 15:37:46 -07001410 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001411 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001412 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001413 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001414 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001415 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001416 self.fake_gerrit.addEvent(F.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001417 self.waitUntilSettled()
1418
Paul Belanger174a8272017-03-14 13:20:10 -04001419 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001420 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001421 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001422 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001423 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001424 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001425 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001426 self.waitUntilSettled()
1427
1428 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001429
1430 # Grab pointers to the jobs we want to release before
1431 # releasing any, because list indexes may change as
1432 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001433 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001434 a.release()
1435 b.release()
1436 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001437 self.waitUntilSettled()
1438
Paul Belanger174a8272017-03-14 13:20:10 -04001439 self.executor_server.hold_jobs_in_build = False
1440 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001441 self.waitUntilSettled()
1442
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001443 self.assertEqual(A.data['status'], 'NEW')
1444 self.assertEqual(B.data['status'], 'MERGED')
1445 self.assertEqual(C.data['status'], 'MERGED')
1446 self.assertEqual(D.data['status'], 'MERGED')
1447 self.assertEqual(E.data['status'], 'MERGED')
1448 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001449
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001450 self.assertEqual(A.reported, 2)
1451 self.assertEqual(B.reported, 2)
1452 self.assertEqual(C.reported, 2)
1453 self.assertEqual(D.reported, 2)
1454 self.assertEqual(E.reported, 2)
1455 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001456
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001457 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1458 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001459
1460 def test_merger_repack(self):
1461 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001462
James E. Blair05fed602012-09-07 12:45:24 -07001463 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001464 A.addApproval('code-review', 2)
1465 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001466 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001467 self.assertEqual(self.getJobFromHistory('project-merge').result,
1468 'SUCCESS')
1469 self.assertEqual(self.getJobFromHistory('project-test1').result,
1470 'SUCCESS')
1471 self.assertEqual(self.getJobFromHistory('project-test2').result,
1472 'SUCCESS')
1473 self.assertEqual(A.data['status'], 'MERGED')
1474 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001475 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001476 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001477
Monty Taylord642d852017-02-23 14:05:42 -05001478 path = os.path.join(self.merger_src_root, "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001479 if os.path.exists(path):
1480 repack_repo(path)
Paul Belanger174a8272017-03-14 13:20:10 -04001481 path = os.path.join(self.executor_src_root, "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001482 if os.path.exists(path):
1483 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001484
1485 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001486 A.addApproval('code-review', 2)
1487 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001488 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001489 self.assertEqual(self.getJobFromHistory('project-merge').result,
1490 'SUCCESS')
1491 self.assertEqual(self.getJobFromHistory('project-test1').result,
1492 'SUCCESS')
1493 self.assertEqual(self.getJobFromHistory('project-test2').result,
1494 'SUCCESS')
1495 self.assertEqual(A.data['status'], 'MERGED')
1496 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001497
James E. Blair4886f282012-11-15 09:27:33 -08001498 def test_merger_repack_large_change(self):
1499 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001500 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001501 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001502 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair0ffa0102017-03-30 13:11:33 -07001503 trusted, project = tenant.getProject('org/project1')
1504 url = self.fake_gerrit.getGitUrl(project)
James E. Blair4076e2b2014-01-28 12:42:20 -08001505 self.merge_server.merger.addProject('org/project1', url)
James E. Blair4886f282012-11-15 09:27:33 -08001506 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1507 A.addPatchset(large=True)
Monty Taylorbc758832013-06-17 17:22:42 -04001508 path = os.path.join(self.upstream_root, "org/project1")
James E. Blair8c1be532017-02-07 14:04:12 -08001509 repack_repo(path)
Monty Taylord642d852017-02-23 14:05:42 -05001510 path = os.path.join(self.merger_src_root, "org/project1")
James E. Blair8c1be532017-02-07 14:04:12 -08001511 if os.path.exists(path):
1512 repack_repo(path)
Paul Belanger174a8272017-03-14 13:20:10 -04001513 path = os.path.join(self.executor_src_root, "org/project1")
James E. Blair8c1be532017-02-07 14:04:12 -08001514 if os.path.exists(path):
1515 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001516
James E. Blair8b5408c2016-08-08 15:37:46 -07001517 A.addApproval('code-review', 2)
1518 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001519 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001520 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001521 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001522 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001523 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001524 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001525 'SUCCESS')
1526 self.assertEqual(A.data['status'], 'MERGED')
1527 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001528
James E. Blair2fa50962013-01-30 21:50:41 -08001529 def test_new_patchset_dequeues_old(self):
1530 "Test that a new patchset causes the old to be dequeued"
1531 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001532 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001533 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1534 M.setMerged()
1535
1536 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1537 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1538 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1539 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001540 A.addApproval('code-review', 2)
1541 B.addApproval('code-review', 2)
1542 C.addApproval('code-review', 2)
1543 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001544
1545 C.setDependsOn(B, 1)
1546 B.setDependsOn(A, 1)
1547 A.setDependsOn(M, 1)
1548
James E. Blair8b5408c2016-08-08 15:37:46 -07001549 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1550 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1551 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1552 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001553 self.waitUntilSettled()
1554
1555 B.addPatchset()
1556 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1557 self.waitUntilSettled()
1558
Paul Belanger174a8272017-03-14 13:20:10 -04001559 self.executor_server.hold_jobs_in_build = False
1560 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001561 self.waitUntilSettled()
1562
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001563 self.assertEqual(A.data['status'], 'MERGED')
1564 self.assertEqual(A.reported, 2)
1565 self.assertEqual(B.data['status'], 'NEW')
1566 self.assertEqual(B.reported, 2)
1567 self.assertEqual(C.data['status'], 'NEW')
1568 self.assertEqual(C.reported, 2)
1569 self.assertEqual(D.data['status'], 'MERGED')
1570 self.assertEqual(D.reported, 2)
1571 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001572
James E. Blairba437362015-02-07 11:41:52 -08001573 def test_new_patchset_check(self):
1574 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001575
Paul Belanger174a8272017-03-14 13:20:10 -04001576 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001577
1578 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001579 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001580 tenant = self.sched.abide.tenants.get('tenant-one')
1581 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001582
1583 # Add two git-dependent changes
1584 B.setDependsOn(A, 1)
1585 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1586 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001587 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1588 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001589
1590 # A live item, and a non-live/live pair
1591 items = check_pipeline.getAllItems()
1592 self.assertEqual(len(items), 3)
1593
1594 self.assertEqual(items[0].change.number, '1')
1595 self.assertEqual(items[0].change.patchset, '1')
1596 self.assertFalse(items[0].live)
1597
1598 self.assertEqual(items[1].change.number, '2')
1599 self.assertEqual(items[1].change.patchset, '1')
1600 self.assertTrue(items[1].live)
1601
1602 self.assertEqual(items[2].change.number, '1')
1603 self.assertEqual(items[2].change.patchset, '1')
1604 self.assertTrue(items[2].live)
1605
1606 # Add a new patchset to A
1607 A.addPatchset()
1608 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1609 self.waitUntilSettled()
1610
1611 # The live copy of A,1 should be gone, but the non-live and B
1612 # should continue, and we should have a new A,2
1613 items = check_pipeline.getAllItems()
1614 self.assertEqual(len(items), 3)
1615
1616 self.assertEqual(items[0].change.number, '1')
1617 self.assertEqual(items[0].change.patchset, '1')
1618 self.assertFalse(items[0].live)
1619
1620 self.assertEqual(items[1].change.number, '2')
1621 self.assertEqual(items[1].change.patchset, '1')
1622 self.assertTrue(items[1].live)
1623
1624 self.assertEqual(items[2].change.number, '1')
1625 self.assertEqual(items[2].change.patchset, '2')
1626 self.assertTrue(items[2].live)
1627
1628 # Add a new patchset to B
1629 B.addPatchset()
1630 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1631 self.waitUntilSettled()
1632
1633 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1634 # but we should have a new B,2 (still based on A,1)
1635 items = check_pipeline.getAllItems()
1636 self.assertEqual(len(items), 3)
1637
1638 self.assertEqual(items[0].change.number, '1')
1639 self.assertEqual(items[0].change.patchset, '2')
1640 self.assertTrue(items[0].live)
1641
1642 self.assertEqual(items[1].change.number, '1')
1643 self.assertEqual(items[1].change.patchset, '1')
1644 self.assertFalse(items[1].live)
1645
1646 self.assertEqual(items[2].change.number, '2')
1647 self.assertEqual(items[2].change.patchset, '2')
1648 self.assertTrue(items[2].live)
1649
1650 self.builds[0].release()
1651 self.waitUntilSettled()
1652 self.builds[0].release()
1653 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001654 self.executor_server.hold_jobs_in_build = False
1655 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001656 self.waitUntilSettled()
1657
1658 self.assertEqual(A.reported, 1)
1659 self.assertEqual(B.reported, 1)
1660 self.assertEqual(self.history[0].result, 'ABORTED')
1661 self.assertEqual(self.history[0].changes, '1,1')
1662 self.assertEqual(self.history[1].result, 'ABORTED')
1663 self.assertEqual(self.history[1].changes, '1,1 2,1')
1664 self.assertEqual(self.history[2].result, 'SUCCESS')
1665 self.assertEqual(self.history[2].changes, '1,2')
1666 self.assertEqual(self.history[3].result, 'SUCCESS')
1667 self.assertEqual(self.history[3].changes, '1,1 2,2')
1668
1669 def test_abandoned_gate(self):
1670 "Test that an abandoned change is dequeued from gate"
1671
Paul Belanger174a8272017-03-14 13:20:10 -04001672 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001673
1674 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001675 A.addApproval('code-review', 2)
1676 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001677 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001678 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1679 self.assertEqual(self.builds[0].name, 'project-merge')
1680
1681 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1682 self.waitUntilSettled()
1683
Paul Belanger174a8272017-03-14 13:20:10 -04001684 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001685 self.waitUntilSettled()
1686
Arie5b4048c2016-10-05 16:12:06 +03001687 self.assertBuilds([])
1688 self.assertHistory([
1689 dict(name='project-merge', result='ABORTED', changes='1,1')],
1690 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001691 self.assertEqual(A.reported, 1,
1692 "Abandoned gate change should report only start")
1693
1694 def test_abandoned_check(self):
1695 "Test that an abandoned change is dequeued from check"
1696
Paul Belanger174a8272017-03-14 13:20:10 -04001697 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001698
1699 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1700 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001701 tenant = self.sched.abide.tenants.get('tenant-one')
1702 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001703
1704 # Add two git-dependent changes
1705 B.setDependsOn(A, 1)
1706 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1707 self.waitUntilSettled()
1708 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1709 self.waitUntilSettled()
1710 # A live item, and a non-live/live pair
1711 items = check_pipeline.getAllItems()
1712 self.assertEqual(len(items), 3)
1713
1714 self.assertEqual(items[0].change.number, '1')
1715 self.assertFalse(items[0].live)
1716
1717 self.assertEqual(items[1].change.number, '2')
1718 self.assertTrue(items[1].live)
1719
1720 self.assertEqual(items[2].change.number, '1')
1721 self.assertTrue(items[2].live)
1722
1723 # Abandon A
1724 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1725 self.waitUntilSettled()
1726
1727 # The live copy of A should be gone, but the non-live and B
1728 # should continue
1729 items = check_pipeline.getAllItems()
1730 self.assertEqual(len(items), 2)
1731
1732 self.assertEqual(items[0].change.number, '1')
1733 self.assertFalse(items[0].live)
1734
1735 self.assertEqual(items[1].change.number, '2')
1736 self.assertTrue(items[1].live)
1737
Paul Belanger174a8272017-03-14 13:20:10 -04001738 self.executor_server.hold_jobs_in_build = False
1739 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001740 self.waitUntilSettled()
1741
1742 self.assertEqual(len(self.history), 4)
1743 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001744 'Build should have been aborted')
1745 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001746 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001747
Steve Varnau7b78b312015-04-03 14:49:46 -07001748 def test_abandoned_not_timer(self):
1749 "Test that an abandoned change does not cancel timer jobs"
1750
Paul Belanger174a8272017-03-14 13:20:10 -04001751 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001752
1753 # Start timer trigger - also org/project
Clint Byrumead6c562017-02-01 16:34:04 -08001754 self.updateConfigLayout('layout-idle')
Steve Varnau7b78b312015-04-03 14:49:46 -07001755 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001756 # The pipeline triggers every second, so we should have seen
1757 # several by now.
1758 time.sleep(5)
1759 self.waitUntilSettled()
1760 # Stop queuing timer triggered jobs so that the assertions
1761 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001762 # Must be in same repo, so overwrite config with another one
Clint Byrum58264dc2017-02-07 21:21:22 -08001763 self.commitLayoutUpdate('layout-idle', 'layout-no-timer')
Clint Byrumead6c562017-02-01 16:34:04 -08001764
Steve Varnau7b78b312015-04-03 14:49:46 -07001765 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001766 self.assertEqual(len(self.builds), 2, "Two timer jobs")
1767
1768 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1769 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1770 self.waitUntilSettled()
1771 self.assertEqual(len(self.builds), 3, "One change plus two timer jobs")
1772
1773 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1774 self.waitUntilSettled()
1775
1776 self.assertEqual(len(self.builds), 2, "Two timer jobs remain")
1777
Paul Belanger174a8272017-03-14 13:20:10 -04001778 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001779 self.waitUntilSettled()
1780
Arx Cruzb1b010d2013-10-28 19:49:59 -02001781 def test_zuul_url_return(self):
1782 "Test if ZUUL_URL is returning when zuul_url is set in zuul.conf"
James E. Blair4076e2b2014-01-28 12:42:20 -08001783 self.assertTrue(self.sched.config.has_option('merger', 'zuul_url'))
Paul Belanger174a8272017-03-14 13:20:10 -04001784 self.executor_server.hold_jobs_in_build = True
Arx Cruzb1b010d2013-10-28 19:49:59 -02001785
1786 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001787 A.addApproval('code-review', 2)
1788 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Arx Cruzb1b010d2013-10-28 19:49:59 -02001789 self.waitUntilSettled()
1790
1791 self.assertEqual(len(self.builds), 1)
1792 for build in self.builds:
1793 self.assertTrue('ZUUL_URL' in build.parameters)
1794
Paul Belanger174a8272017-03-14 13:20:10 -04001795 self.executor_server.hold_jobs_in_build = False
1796 self.executor_server.release()
Arx Cruzb1b010d2013-10-28 19:49:59 -02001797 self.waitUntilSettled()
1798
James E. Blair2fa50962013-01-30 21:50:41 -08001799 def test_new_patchset_dequeues_old_on_head(self):
1800 "Test that a new patchset causes the old to be dequeued (at head)"
1801 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001802 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001803 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1804 M.setMerged()
1805 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1806 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1807 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1808 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001809 A.addApproval('code-review', 2)
1810 B.addApproval('code-review', 2)
1811 C.addApproval('code-review', 2)
1812 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001813
1814 C.setDependsOn(B, 1)
1815 B.setDependsOn(A, 1)
1816 A.setDependsOn(M, 1)
1817
James E. Blair8b5408c2016-08-08 15:37:46 -07001818 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1819 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1820 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1821 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001822 self.waitUntilSettled()
1823
1824 A.addPatchset()
1825 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1826 self.waitUntilSettled()
1827
Paul Belanger174a8272017-03-14 13:20:10 -04001828 self.executor_server.hold_jobs_in_build = False
1829 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001830 self.waitUntilSettled()
1831
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001832 self.assertEqual(A.data['status'], 'NEW')
1833 self.assertEqual(A.reported, 2)
1834 self.assertEqual(B.data['status'], 'NEW')
1835 self.assertEqual(B.reported, 2)
1836 self.assertEqual(C.data['status'], 'NEW')
1837 self.assertEqual(C.reported, 2)
1838 self.assertEqual(D.data['status'], 'MERGED')
1839 self.assertEqual(D.reported, 2)
1840 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08001841
1842 def test_new_patchset_dequeues_old_without_dependents(self):
1843 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04001844 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001845 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1846 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1847 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001848 A.addApproval('code-review', 2)
1849 B.addApproval('code-review', 2)
1850 C.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001851
James E. Blair8b5408c2016-08-08 15:37:46 -07001852 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1853 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1854 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001855 self.waitUntilSettled()
1856
1857 B.addPatchset()
1858 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1859 self.waitUntilSettled()
1860
Paul Belanger174a8272017-03-14 13:20:10 -04001861 self.executor_server.hold_jobs_in_build = False
1862 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001863 self.waitUntilSettled()
1864
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001865 self.assertEqual(A.data['status'], 'MERGED')
1866 self.assertEqual(A.reported, 2)
1867 self.assertEqual(B.data['status'], 'NEW')
1868 self.assertEqual(B.reported, 2)
1869 self.assertEqual(C.data['status'], 'MERGED')
1870 self.assertEqual(C.reported, 2)
1871 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08001872
1873 def test_new_patchset_dequeues_old_independent_queue(self):
1874 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04001875 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001876 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1877 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1878 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1879 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1880 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1881 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1882 self.waitUntilSettled()
1883
1884 B.addPatchset()
1885 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1886 self.waitUntilSettled()
1887
Paul Belanger174a8272017-03-14 13:20:10 -04001888 self.executor_server.hold_jobs_in_build = False
1889 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001890 self.waitUntilSettled()
1891
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001892 self.assertEqual(A.data['status'], 'NEW')
1893 self.assertEqual(A.reported, 1)
1894 self.assertEqual(B.data['status'], 'NEW')
1895 self.assertEqual(B.reported, 1)
1896 self.assertEqual(C.data['status'], 'NEW')
1897 self.assertEqual(C.reported, 1)
1898 self.assertEqual(len(self.history), 10)
1899 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001900
James E. Blair18c64442014-03-18 10:14:45 -07001901 def test_noop_job(self):
1902 "Test that the internal noop job works"
1903 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001904 A.addApproval('code-review', 2)
1905 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07001906 self.waitUntilSettled()
1907
1908 self.assertEqual(len(self.gearman_server.getQueue()), 0)
1909 self.assertTrue(self.sched._areAllBuildsComplete())
1910 self.assertEqual(len(self.history), 0)
1911 self.assertEqual(A.data['status'], 'MERGED')
1912 self.assertEqual(A.reported, 2)
1913
James E. Blair06cc3922017-04-19 10:08:10 -07001914 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001915 def test_no_job_project(self):
1916 "Test that reports with no jobs don't get sent"
1917 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
1918 'master', 'A')
1919 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1920 self.waitUntilSettled()
1921
1922 # Change wasn't reported to
1923 self.assertEqual(A.reported, False)
1924
1925 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08001926 tenant = self.sched.abide.tenants.get('tenant-one')
1927 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001928 items = check_pipeline.getAllItems()
1929 self.assertEqual(len(items), 0)
1930
1931 self.assertEqual(len(self.history), 0)
1932
James E. Blair7d0dedc2013-02-21 17:26:09 -08001933 def test_zuul_refs(self):
1934 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04001935 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08001936 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
1937 M1.setMerged()
1938 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
1939 M2.setMerged()
1940
1941 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1942 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1943 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1944 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001945 A.addApproval('code-review', 2)
1946 B.addApproval('code-review', 2)
1947 C.addApproval('code-review', 2)
1948 D.addApproval('code-review', 2)
1949 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1950 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1951 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1952 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001953
1954 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001955 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001956 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001957 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001958 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001959 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001960 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001961 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001962 self.waitUntilSettled()
1963
James E. Blair7d0dedc2013-02-21 17:26:09 -08001964 a_zref = b_zref = c_zref = d_zref = None
Clint Byrum3343e3e2016-11-15 16:05:03 -08001965 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001966 for x in self.builds:
James E. Blair7d0dedc2013-02-21 17:26:09 -08001967 if x.parameters['ZUUL_CHANGE'] == '3':
1968 a_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001969 a_build = x
1970 elif x.parameters['ZUUL_CHANGE'] == '4':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001971 b_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001972 b_build = x
1973 elif x.parameters['ZUUL_CHANGE'] == '5':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001974 c_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001975 c_build = x
1976 elif x.parameters['ZUUL_CHANGE'] == '6':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001977 d_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001978 d_build = x
1979 if a_build and b_build and c_build and d_build:
1980 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08001981
1982 # There are... four... refs.
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001983 self.assertIsNotNone(a_zref)
1984 self.assertIsNotNone(b_zref)
1985 self.assertIsNotNone(c_zref)
1986 self.assertIsNotNone(d_zref)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001987
1988 # And they should all be different
1989 refs = set([a_zref, b_zref, c_zref, d_zref])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001990 self.assertEqual(len(refs), 4)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001991
Clint Byrum3343e3e2016-11-15 16:05:03 -08001992 # should have a, not b, and should not be in project2
1993 self.assertTrue(a_build.hasChanges(A))
1994 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001995
Clint Byrum3343e3e2016-11-15 16:05:03 -08001996 # should have a and b, and should not be in project2
1997 self.assertTrue(b_build.hasChanges(A, B))
1998 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001999
Clint Byrum3343e3e2016-11-15 16:05:03 -08002000 # should have a and b in 1, c in 2
2001 self.assertTrue(c_build.hasChanges(A, B, C))
2002 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002003
Clint Byrum3343e3e2016-11-15 16:05:03 -08002004 # should have a and b in 1, c and d in 2
2005 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002006
Paul Belanger174a8272017-03-14 13:20:10 -04002007 self.executor_server.hold_jobs_in_build = False
2008 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002009 self.waitUntilSettled()
2010
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002011 self.assertEqual(A.data['status'], 'MERGED')
2012 self.assertEqual(A.reported, 2)
2013 self.assertEqual(B.data['status'], 'MERGED')
2014 self.assertEqual(B.reported, 2)
2015 self.assertEqual(C.data['status'], 'MERGED')
2016 self.assertEqual(C.reported, 2)
2017 self.assertEqual(D.data['status'], 'MERGED')
2018 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002019
James E. Blair4a28a882013-08-23 15:17:33 -07002020 def test_rerun_on_error(self):
2021 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002022 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002023 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002024 A.addApproval('code-review', 2)
2025 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002026 self.waitUntilSettled()
2027
James E. Blair412fba82017-01-26 15:00:50 -08002028 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002029 self.executor_server.hold_jobs_in_build = False
2030 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002031 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002032 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002033 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2034
James E. Blair412e5582013-04-22 15:50:12 -07002035 def test_statsd(self):
2036 "Test each of the statsd methods used in the scheduler"
2037 import extras
2038 statsd = extras.try_import('statsd.statsd')
2039 statsd.incr('test-incr')
2040 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002041 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002042 self.assertReportedStat('test-incr', '1|c')
2043 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002044 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002045
James E. Blairdad52252014-02-07 16:59:17 -08002046 def test_stuck_job_cleanup(self):
2047 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002048
2049 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002050 self.gearman_server.hold_jobs_in_queue = True
2051 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002052 A.addApproval('code-review', 2)
2053 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002054 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002055 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002056 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2057
Clint Byrum678e2c32017-03-16 16:27:21 -07002058 self.commitLayoutUpdate('common-config', 'layout-no-jobs')
James E. Blairdad52252014-02-07 16:59:17 -08002059 self.sched.reconfigure(self.config)
2060 self.waitUntilSettled()
2061
James E. Blair18c64442014-03-18 10:14:45 -07002062 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002063 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002064 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002065 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2066 self.assertTrue(self.sched._areAllBuildsComplete())
2067
2068 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002069 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002070 self.assertEqual(self.history[0].result, 'SUCCESS')
2071
James E. Blair879dafb2015-07-17 14:04:49 -07002072 def test_file_head(self):
2073 # This is a regression test for an observed bug. A change
2074 # with a file named "HEAD" in the root directory of the repo
2075 # was processed by a merger. It then was unable to reset the
2076 # repo because of:
2077 # GitCommandError: 'git reset --hard HEAD' returned
2078 # with exit code 128
2079 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2080 # and filename
2081 # Use '--' to separate filenames from revisions'
2082
2083 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002084 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002085 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2086
2087 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2088 self.waitUntilSettled()
2089
2090 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2091 self.waitUntilSettled()
2092
2093 self.assertIn('Build succeeded', A.messages[0])
2094 self.assertIn('Build succeeded', B.messages[0])
2095
James E. Blair70c71582013-03-06 08:50:50 -08002096 def test_file_jobs(self):
2097 "Test that file jobs run only when appropriate"
2098 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002099 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002100 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07002101 A.addApproval('code-review', 2)
2102 B.addApproval('code-review', 2)
2103 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2104 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002105 self.waitUntilSettled()
2106
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002107 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002108 if x.name == 'project-testfile']
2109
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002110 self.assertEqual(len(testfile_jobs), 1)
2111 self.assertEqual(testfile_jobs[0].changes, '1,2')
2112 self.assertEqual(A.data['status'], 'MERGED')
2113 self.assertEqual(A.reported, 2)
2114 self.assertEqual(B.data['status'], 'MERGED')
2115 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002116
Clint Byrum3ee39f32016-11-17 23:45:07 -08002117 def _test_irrelevant_files_jobs(self, should_skip):
2118 "Test that jobs with irrelevant-files filter run only when appropriate"
2119 self.updateConfigLayout('layout-irrelevant-files')
Maru Newby3fe5f852015-01-13 04:22:14 +00002120 self.sched.reconfigure(self.config)
Clint Byrum3ee39f32016-11-17 23:45:07 -08002121
2122 if should_skip:
2123 files = {'ignoreme': 'ignored\n'}
2124 else:
2125 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002126
2127 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002128 'master',
2129 'test irrelevant-files',
2130 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002131 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2132 self.waitUntilSettled()
2133
2134 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002135 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002136
2137 if should_skip:
2138 self.assertEqual([], tested_change_ids)
2139 else:
2140 self.assertIn(change.data['number'], tested_change_ids)
2141
Clint Byrum3ee39f32016-11-17 23:45:07 -08002142 def test_irrelevant_files_match_skips_job(self):
2143 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002144
Clint Byrum3ee39f32016-11-17 23:45:07 -08002145 def test_irrelevant_files_no_match_runs_job(self):
2146 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002147
Clint Byrum85493602016-11-18 11:59:47 -08002148 def test_inherited_jobs_keep_matchers(self):
2149 self.updateConfigLayout('layout-inheritance')
2150 self.sched.reconfigure(self.config)
2151
2152 files = {'ignoreme': 'ignored\n'}
2153
2154 change = self.fake_gerrit.addFakeChange('org/project',
2155 'master',
2156 'test irrelevant-files',
2157 files=files)
2158 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2159 self.waitUntilSettled()
2160
2161 run_jobs = set([build.name for build in self.history])
2162
2163 self.assertEqual(set(['project-test-nomatch-starts-empty',
2164 'project-test-nomatch-starts-full']), run_jobs)
2165
James E. Blairec056492016-07-22 09:45:56 -07002166 @skip("Disabled for early v3 development")
James E. Blair3c5e5b52013-04-26 11:17:03 -07002167 def test_test_config(self):
2168 "Test that we can test the config"
James E. Blairf84026c2015-12-08 16:11:46 -08002169 self.sched.testConfig(self.config.get('zuul', 'tenant_config'),
Joshua Hesketh352264b2015-08-11 23:42:08 +10002170 self.connections)
James E. Blair1f4c2bb2013-04-26 08:40:46 -07002171
James E. Blairc8a1e052014-02-25 09:29:26 -08002172 def test_queue_names(self):
2173 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002174 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002175 (trusted, project1) = tenant.getProject('org/project1')
2176 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002177 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2178 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2179 self.assertEqual(q1.name, 'integrated')
2180 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002181
James E. Blair64ed6f22013-07-10 14:07:23 -07002182 def test_queue_precedence(self):
2183 "Test that queue precedence works"
2184
2185 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002186 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002187 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2188 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
James E. Blair8b5408c2016-08-08 15:37:46 -07002189 A.addApproval('code-review', 2)
2190 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002191
2192 self.waitUntilSettled()
2193 self.gearman_server.hold_jobs_in_queue = False
2194 self.gearman_server.release()
2195 self.waitUntilSettled()
2196
James E. Blair8de58bd2013-07-18 16:23:33 -07002197 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002198 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002199 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002200 self.waitUntilSettled()
2201
James E. Blair64ed6f22013-07-10 14:07:23 -07002202 self.log.debug(self.history)
2203 self.assertEqual(self.history[0].pipeline, 'gate')
2204 self.assertEqual(self.history[1].pipeline, 'check')
2205 self.assertEqual(self.history[2].pipeline, 'gate')
2206 self.assertEqual(self.history[3].pipeline, 'gate')
2207 self.assertEqual(self.history[4].pipeline, 'check')
2208 self.assertEqual(self.history[5].pipeline, 'check')
2209
Clark Boylana5edbe42014-06-03 16:39:10 -07002210 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002211 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002212 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002213 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002214 A.addApproval('code-review', 2)
2215 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002216 self.waitUntilSettled()
2217
Paul Belanger174a8272017-03-14 13:20:10 -04002218 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002219 self.waitUntilSettled()
2220
James E. Blair1843a552013-07-03 14:19:52 -07002221 port = self.webapp.server.socket.getsockname()[1]
2222
Adam Gandelman77a12c72017-02-03 17:43:43 -08002223 req = urllib.request.Request(
2224 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002225 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002226 headers = f.info()
2227 self.assertIn('Content-Length', headers)
2228 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002229 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2230 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002231 self.assertIn('Access-Control-Allow-Origin', headers)
2232 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002233 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002234 self.assertIn('Expires', headers)
James E. Blair1843a552013-07-03 14:19:52 -07002235 data = f.read()
2236
Paul Belanger174a8272017-03-14 13:20:10 -04002237 self.executor_server.hold_jobs_in_build = False
2238 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002239 self.waitUntilSettled()
2240
2241 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002242 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002243 for p in data['pipelines']:
2244 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002245 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002246 self.assertEqual(q['window'], 20)
2247 else:
2248 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002249 for head in q['heads']:
2250 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002251 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002252 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002253 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002254 status_jobs.append(job)
2255 self.assertEqual('project-merge', status_jobs[0]['name'])
2256 self.assertEqual('https://server/job/project-merge/0/',
2257 status_jobs[0]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002258 self.assertEqual('https://server/job/project-merge/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002259 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002260 self.assertEqual('project-test1', status_jobs[1]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002261 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002262 status_jobs[1]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002263 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002264 status_jobs[1]['report_url'])
2265
2266 self.assertEqual('project-test2', status_jobs[2]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002267 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002268 status_jobs[2]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002269 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002270 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002271
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002272 def test_semaphore_one(self):
2273 "Test semaphores with max=1 (mutex)"
2274 self.updateConfigLayout('layout-semaphore')
James E. Blairaf17a972016-02-03 15:07:18 -08002275 self.sched.reconfigure(self.config)
2276
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002277 self.waitUntilSettled()
2278 tenant = self.sched.abide.tenants.get('openstack')
2279
Paul Belanger174a8272017-03-14 13:20:10 -04002280 self.executor_server.hold_jobs_in_build = True
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002281
James E. Blairaf17a972016-02-03 15:07:18 -08002282 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2283 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002284 self.assertFalse('test-semaphore' in
2285 tenant.semaphore_handler.semaphores)
James E. Blairaf17a972016-02-03 15:07:18 -08002286
2287 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2288 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2289 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002290
James E. Blairaf17a972016-02-03 15:07:18 -08002291 self.assertEqual(len(self.builds), 3)
2292 self.assertEqual(self.builds[0].name, 'project-test1')
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002293 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
James E. Blairaf17a972016-02-03 15:07:18 -08002294 self.assertEqual(self.builds[2].name, 'project-test1')
2295
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002296 self.executor_server.release('semaphore-one-test1')
James E. Blairaf17a972016-02-03 15:07:18 -08002297 self.waitUntilSettled()
2298
2299 self.assertEqual(len(self.builds), 3)
2300 self.assertEqual(self.builds[0].name, 'project-test1')
2301 self.assertEqual(self.builds[1].name, 'project-test1')
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002302 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
2303 self.assertTrue('test-semaphore' in
2304 tenant.semaphore_handler.semaphores)
James E. Blairaf17a972016-02-03 15:07:18 -08002305
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002306 self.executor_server.release('semaphore-one-test2')
James E. Blairaf17a972016-02-03 15:07:18 -08002307 self.waitUntilSettled()
2308
2309 self.assertEqual(len(self.builds), 3)
2310 self.assertEqual(self.builds[0].name, 'project-test1')
2311 self.assertEqual(self.builds[1].name, 'project-test1')
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002312 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
2313 self.assertTrue('test-semaphore' in
2314 tenant.semaphore_handler.semaphores)
James E. Blairaf17a972016-02-03 15:07:18 -08002315
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002316 self.executor_server.release('semaphore-one-test1')
James E. Blairaf17a972016-02-03 15:07:18 -08002317 self.waitUntilSettled()
2318
2319 self.assertEqual(len(self.builds), 3)
2320 self.assertEqual(self.builds[0].name, 'project-test1')
2321 self.assertEqual(self.builds[1].name, 'project-test1')
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002322 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
2323 self.assertTrue('test-semaphore' in
2324 tenant.semaphore_handler.semaphores)
James E. Blairaf17a972016-02-03 15:07:18 -08002325
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002326 self.executor_server.release('semaphore-one-test2')
James E. Blairaf17a972016-02-03 15:07:18 -08002327 self.waitUntilSettled()
2328
2329 self.assertEqual(len(self.builds), 2)
2330 self.assertEqual(self.builds[0].name, 'project-test1')
2331 self.assertEqual(self.builds[1].name, 'project-test1')
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002332 self.assertFalse('test-semaphore' in
2333 tenant.semaphore_handler.semaphores)
James E. Blairaf17a972016-02-03 15:07:18 -08002334
Paul Belanger174a8272017-03-14 13:20:10 -04002335 self.executor_server.hold_jobs_in_build = False
2336 self.executor_server.release()
James E. Blairaf17a972016-02-03 15:07:18 -08002337
2338 self.waitUntilSettled()
2339 self.assertEqual(len(self.builds), 0)
2340
2341 self.assertEqual(A.reported, 1)
2342 self.assertEqual(B.reported, 1)
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002343 self.assertFalse('test-semaphore' in
2344 tenant.semaphore_handler.semaphores)
James E. Blairaf17a972016-02-03 15:07:18 -08002345
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002346 def test_semaphore_two(self):
2347 "Test semaphores with max>1"
2348 self.updateConfigLayout('layout-semaphore')
Tobias Henkelfb91a492017-02-15 07:29:43 +01002349 self.sched.reconfigure(self.config)
2350
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002351 self.waitUntilSettled()
2352 tenant = self.sched.abide.tenants.get('openstack')
2353
2354 self.executor_server.hold_jobs_in_build = True
2355 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2356 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2357 self.assertFalse('test-semaphore-two' in
2358 tenant.semaphore_handler.semaphores)
2359
2360 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2361 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2362 self.waitUntilSettled()
2363
2364 self.assertEqual(len(self.builds), 4)
2365 self.assertEqual(self.builds[0].name, 'project-test1')
2366 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
2367 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
2368 self.assertEqual(self.builds[3].name, 'project-test1')
2369 self.assertTrue('test-semaphore-two' in
2370 tenant.semaphore_handler.semaphores)
2371 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
2372 'test-semaphore-two', [])), 2)
2373
2374 self.executor_server.release('semaphore-two-test1')
2375 self.waitUntilSettled()
2376
2377 self.assertEqual(len(self.builds), 4)
2378 self.assertEqual(self.builds[0].name, 'project-test1')
2379 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
2380 self.assertEqual(self.builds[2].name, 'project-test1')
2381 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
2382 self.assertTrue('test-semaphore-two' in
2383 tenant.semaphore_handler.semaphores)
2384 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
2385 'test-semaphore-two', [])), 2)
2386
2387 self.executor_server.release('semaphore-two-test2')
2388 self.waitUntilSettled()
2389
2390 self.assertEqual(len(self.builds), 4)
2391 self.assertEqual(self.builds[0].name, 'project-test1')
2392 self.assertEqual(self.builds[1].name, 'project-test1')
2393 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
2394 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
2395 self.assertTrue('test-semaphore-two' in
2396 tenant.semaphore_handler.semaphores)
2397 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
2398 'test-semaphore-two', [])), 2)
2399
2400 self.executor_server.release('semaphore-two-test1')
2401 self.waitUntilSettled()
2402
2403 self.assertEqual(len(self.builds), 3)
2404 self.assertEqual(self.builds[0].name, 'project-test1')
2405 self.assertEqual(self.builds[1].name, 'project-test1')
2406 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
2407 self.assertTrue('test-semaphore-two' in
2408 tenant.semaphore_handler.semaphores)
2409 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
2410 'test-semaphore-two', [])), 1)
2411
2412 self.executor_server.release('semaphore-two-test2')
2413 self.waitUntilSettled()
2414
2415 self.assertEqual(len(self.builds), 2)
2416 self.assertEqual(self.builds[0].name, 'project-test1')
2417 self.assertEqual(self.builds[1].name, 'project-test1')
2418 self.assertFalse('test-semaphore-two' in
2419 tenant.semaphore_handler.semaphores)
2420
2421 self.executor_server.hold_jobs_in_build = False
2422 self.executor_server.release()
2423
2424 self.waitUntilSettled()
2425 self.assertEqual(len(self.builds), 0)
2426
2427 self.assertEqual(A.reported, 1)
2428 self.assertEqual(B.reported, 1)
2429
2430 def test_semaphore_abandon(self):
2431 "Test abandon with job semaphores"
2432 self.updateConfigLayout('layout-semaphore')
2433 self.sched.reconfigure(self.config)
2434
2435 self.waitUntilSettled()
2436 tenant = self.sched.abide.tenants.get('openstack')
2437
Paul Belanger174a8272017-03-14 13:20:10 -04002438 self.executor_server.hold_jobs_in_build = True
Tobias Henkelfb91a492017-02-15 07:29:43 +01002439
2440 tenant = self.sched.abide.tenants.get('openstack')
2441 check_pipeline = tenant.layout.pipelines['check']
2442
2443 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002444 self.assertFalse('test-semaphore' in
2445 tenant.semaphore_handler.semaphores)
Tobias Henkelfb91a492017-02-15 07:29:43 +01002446
2447 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2448 self.waitUntilSettled()
2449
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002450 self.assertTrue('test-semaphore' in
2451 tenant.semaphore_handler.semaphores)
Tobias Henkelfb91a492017-02-15 07:29:43 +01002452
2453 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
2454 self.waitUntilSettled()
2455
2456 # The check pipeline should be empty
2457 items = check_pipeline.getAllItems()
2458 self.assertEqual(len(items), 0)
2459
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002460 # The semaphore should be released
2461 self.assertFalse('test-semaphore' in
2462 tenant.semaphore_handler.semaphores)
Tobias Henkelfb91a492017-02-15 07:29:43 +01002463
Paul Belanger174a8272017-03-14 13:20:10 -04002464 self.executor_server.hold_jobs_in_build = False
2465 self.executor_server.release()
Tobias Henkelfb91a492017-02-15 07:29:43 +01002466 self.waitUntilSettled()
2467
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002468 def test_semaphore_reconfigure(self):
2469 "Test reconfigure with job semaphores"
2470 self.updateConfigLayout('layout-semaphore')
Tobias Henkelfb91a492017-02-15 07:29:43 +01002471 self.sched.reconfigure(self.config)
2472
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002473 self.waitUntilSettled()
2474 tenant = self.sched.abide.tenants.get('openstack')
2475
Paul Belanger174a8272017-03-14 13:20:10 -04002476 self.executor_server.hold_jobs_in_build = True
Tobias Henkelfb91a492017-02-15 07:29:43 +01002477
2478 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002479 self.assertFalse('test-semaphore' in
2480 tenant.semaphore_handler.semaphores)
Tobias Henkelfb91a492017-02-15 07:29:43 +01002481
2482 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2483 self.waitUntilSettled()
2484
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002485 self.assertTrue('test-semaphore' in
2486 tenant.semaphore_handler.semaphores)
Tobias Henkelfb91a492017-02-15 07:29:43 +01002487
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002488 # reconfigure without layout change
Tobias Henkelfb91a492017-02-15 07:29:43 +01002489 self.sched.reconfigure(self.config)
2490 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002491 tenant = self.sched.abide.tenants.get('openstack')
2492
2493 # semaphore still must be held
2494 self.assertTrue('test-semaphore' in
2495 tenant.semaphore_handler.semaphores)
2496
2497 self.updateConfigLayout('layout-semaphore-reconfiguration')
2498 self.sched.reconfigure(self.config)
2499 self.waitUntilSettled()
2500 tenant = self.sched.abide.tenants.get('openstack')
Tobias Henkelfb91a492017-02-15 07:29:43 +01002501
Paul Belanger174a8272017-03-14 13:20:10 -04002502 self.executor_server.release('project-test1')
Tobias Henkelfb91a492017-02-15 07:29:43 +01002503 self.waitUntilSettled()
2504
2505 # There should be no builds anymore
2506 self.assertEqual(len(self.builds), 0)
2507
Tobias Henkel9a0e1942017-03-20 16:16:02 +01002508 # The semaphore should be released
2509 self.assertFalse('test-semaphore' in
2510 tenant.semaphore_handler.semaphores)
Tobias Henkelfb91a492017-02-15 07:29:43 +01002511
James E. Blaircdccd972013-07-01 12:10:22 -07002512 def test_live_reconfiguration(self):
2513 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002514 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002515 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002516 A.addApproval('code-review', 2)
2517 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002518 self.waitUntilSettled()
2519
2520 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002521 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002522
Paul Belanger174a8272017-03-14 13:20:10 -04002523 self.executor_server.hold_jobs_in_build = False
2524 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002525 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002526 self.assertEqual(self.getJobFromHistory('project-merge').result,
2527 'SUCCESS')
2528 self.assertEqual(self.getJobFromHistory('project-test1').result,
2529 'SUCCESS')
2530 self.assertEqual(self.getJobFromHistory('project-test2').result,
2531 'SUCCESS')
2532 self.assertEqual(A.data['status'], 'MERGED')
2533 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002534
James E. Blairec056492016-07-22 09:45:56 -07002535 @skip("Disabled for early v3 development")
James E. Blair6bc782d2015-07-17 16:20:21 -07002536 def test_live_reconfiguration_merge_conflict(self):
2537 # A real-world bug: a change in a gate queue has a merge
2538 # conflict and a job is added to its project while it's
2539 # sitting in the queue. The job gets added to the change and
2540 # enqueued and the change gets stuck.
2541 self.worker.registerFunction('build:project-test3')
Paul Belanger174a8272017-03-14 13:20:10 -04002542 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002543
2544 # This change is fine. It's here to stop the queue long
2545 # enough for the next change to be subject to the
2546 # reconfiguration, as well as to provide a conflict for the
2547 # next change. This change will succeed and merge.
2548 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2549 A.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002550 A.addApproval('code-review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002551
2552 # This change will be in merge conflict. During the
2553 # reconfiguration, we will add a job. We want to make sure
2554 # that doesn't cause it to get stuck.
2555 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2556 B.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002557 B.addApproval('code-review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002558
James E. Blair8b5408c2016-08-08 15:37:46 -07002559 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2560 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002561
2562 self.waitUntilSettled()
2563
2564 # No jobs have run yet
2565 self.assertEqual(A.data['status'], 'NEW')
2566 self.assertEqual(A.reported, 1)
2567 self.assertEqual(B.data['status'], 'NEW')
2568 self.assertEqual(B.reported, 1)
2569 self.assertEqual(len(self.history), 0)
2570
2571 # Add the "project-test3" job.
James E. Blairf84026c2015-12-08 16:11:46 -08002572 self.updateConfigLayout(
2573 'tests/fixtures/layout-live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002574 self.sched.reconfigure(self.config)
2575 self.waitUntilSettled()
2576
Paul Belanger174a8272017-03-14 13:20:10 -04002577 self.executor_server.hold_jobs_in_build = False
2578 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002579 self.waitUntilSettled()
2580
2581 self.assertEqual(A.data['status'], 'MERGED')
2582 self.assertEqual(A.reported, 2)
2583 self.assertEqual(B.data['status'], 'NEW')
2584 self.assertEqual(B.reported, 2)
2585 self.assertEqual(self.getJobFromHistory('project-merge').result,
2586 'SUCCESS')
2587 self.assertEqual(self.getJobFromHistory('project-test1').result,
2588 'SUCCESS')
2589 self.assertEqual(self.getJobFromHistory('project-test2').result,
2590 'SUCCESS')
2591 self.assertEqual(self.getJobFromHistory('project-test3').result,
2592 'SUCCESS')
2593 self.assertEqual(len(self.history), 4)
2594
James E. Blairec056492016-07-22 09:45:56 -07002595 @skip("Disabled for early v3 development")
James E. Blair400e8fd2015-07-30 17:44:45 -07002596 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002597 # An extrapolation of test_live_reconfiguration_merge_conflict
2598 # that tests a job added to a job tree with a failed root does
2599 # not run.
2600 self.worker.registerFunction('build:project-test3')
Paul Belanger174a8272017-03-14 13:20:10 -04002601 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002602
2603 # This change is fine. It's here to stop the queue long
2604 # enough for the next change to be subject to the
2605 # reconfiguration. This change will succeed and merge.
2606 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2607 A.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002608 A.addApproval('code-review', 2)
2609 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002610 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002611 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002612 self.waitUntilSettled()
2613
2614 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002615 self.executor_server.failJob('project-merge', B)
James E. Blair8b5408c2016-08-08 15:37:46 -07002616 B.addApproval('code-review', 2)
2617 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002618 self.waitUntilSettled()
2619
Paul Belanger174a8272017-03-14 13:20:10 -04002620 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002621 self.waitUntilSettled()
2622
2623 # Both -merge jobs have run, but no others.
2624 self.assertEqual(A.data['status'], 'NEW')
2625 self.assertEqual(A.reported, 1)
2626 self.assertEqual(B.data['status'], 'NEW')
2627 self.assertEqual(B.reported, 1)
2628 self.assertEqual(self.history[0].result, 'SUCCESS')
2629 self.assertEqual(self.history[0].name, 'project-merge')
2630 self.assertEqual(self.history[1].result, 'FAILURE')
2631 self.assertEqual(self.history[1].name, 'project-merge')
2632 self.assertEqual(len(self.history), 2)
2633
2634 # Add the "project-test3" job.
James E. Blairf84026c2015-12-08 16:11:46 -08002635 self.updateConfigLayout(
2636 'tests/fixtures/layout-live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002637 self.sched.reconfigure(self.config)
2638 self.waitUntilSettled()
2639
Paul Belanger174a8272017-03-14 13:20:10 -04002640 self.executor_server.hold_jobs_in_build = False
2641 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002642 self.waitUntilSettled()
2643
2644 self.assertEqual(A.data['status'], 'MERGED')
2645 self.assertEqual(A.reported, 2)
2646 self.assertEqual(B.data['status'], 'NEW')
2647 self.assertEqual(B.reported, 2)
2648 self.assertEqual(self.history[0].result, 'SUCCESS')
2649 self.assertEqual(self.history[0].name, 'project-merge')
2650 self.assertEqual(self.history[1].result, 'FAILURE')
2651 self.assertEqual(self.history[1].name, 'project-merge')
2652 self.assertEqual(self.history[2].result, 'SUCCESS')
2653 self.assertEqual(self.history[3].result, 'SUCCESS')
2654 self.assertEqual(self.history[4].result, 'SUCCESS')
2655 self.assertEqual(len(self.history), 5)
2656
James E. Blairec056492016-07-22 09:45:56 -07002657 @skip("Disabled for early v3 development")
James E. Blair400e8fd2015-07-30 17:44:45 -07002658 def test_live_reconfiguration_failed_job(self):
2659 # Test that a change with a removed failing job does not
2660 # disrupt reconfiguration. If a change has a failed job and
2661 # that job is removed during a reconfiguration, we observed a
2662 # bug where the code to re-set build statuses would run on
2663 # that build and raise an exception because the job no longer
2664 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002665 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002666
2667 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2668
2669 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002670 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002671
2672 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2673 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002674 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002675 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002676 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002677 self.waitUntilSettled()
2678
2679 self.assertEqual(A.data['status'], 'NEW')
2680 self.assertEqual(A.reported, 0)
2681
2682 self.assertEqual(self.getJobFromHistory('project-merge').result,
2683 'SUCCESS')
2684 self.assertEqual(self.getJobFromHistory('project-test1').result,
2685 'FAILURE')
2686 self.assertEqual(len(self.history), 2)
2687
2688 # Remove the test1 job.
James E. Blairf84026c2015-12-08 16:11:46 -08002689 self.updateConfigLayout(
2690 'tests/fixtures/layout-live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002691 self.sched.reconfigure(self.config)
2692 self.waitUntilSettled()
2693
Paul Belanger174a8272017-03-14 13:20:10 -04002694 self.executor_server.hold_jobs_in_build = False
2695 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002696 self.waitUntilSettled()
2697
2698 self.assertEqual(self.getJobFromHistory('project-test2').result,
2699 'SUCCESS')
2700 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2701 'SUCCESS')
2702 self.assertEqual(len(self.history), 4)
2703
2704 self.assertEqual(A.data['status'], 'NEW')
2705 self.assertEqual(A.reported, 1)
2706 self.assertIn('Build succeeded', A.messages[0])
2707 # Ensure the removed job was not included in the report.
2708 self.assertNotIn('project-test1', A.messages[0])
2709
James E. Blairec056492016-07-22 09:45:56 -07002710 @skip("Disabled for early v3 development")
James E. Blairfe707d12015-08-05 15:18:15 -07002711 def test_live_reconfiguration_shared_queue(self):
2712 # Test that a change with a failing job which was removed from
2713 # this project but otherwise still exists in the system does
2714 # not disrupt reconfiguration.
2715
Paul Belanger174a8272017-03-14 13:20:10 -04002716 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002717
2718 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2719
Paul Belanger174a8272017-03-14 13:20:10 -04002720 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002721
2722 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2723 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002724 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002725 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002726 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002727 self.waitUntilSettled()
2728
2729 self.assertEqual(A.data['status'], 'NEW')
2730 self.assertEqual(A.reported, 0)
2731
2732 self.assertEqual(self.getJobFromHistory('project1-merge').result,
2733 'SUCCESS')
2734 self.assertEqual(self.getJobFromHistory(
2735 'project1-project2-integration').result, 'FAILURE')
2736 self.assertEqual(len(self.history), 2)
2737
2738 # Remove the integration job.
James E. Blairf84026c2015-12-08 16:11:46 -08002739 self.updateConfigLayout(
2740 'tests/fixtures/layout-live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002741 self.sched.reconfigure(self.config)
2742 self.waitUntilSettled()
2743
Paul Belanger174a8272017-03-14 13:20:10 -04002744 self.executor_server.hold_jobs_in_build = False
2745 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002746 self.waitUntilSettled()
2747
2748 self.assertEqual(self.getJobFromHistory('project1-merge').result,
2749 'SUCCESS')
2750 self.assertEqual(self.getJobFromHistory('project1-test1').result,
2751 'SUCCESS')
2752 self.assertEqual(self.getJobFromHistory('project1-test2').result,
2753 'SUCCESS')
2754 self.assertEqual(self.getJobFromHistory(
2755 'project1-project2-integration').result, 'FAILURE')
2756 self.assertEqual(len(self.history), 4)
2757
2758 self.assertEqual(A.data['status'], 'NEW')
2759 self.assertEqual(A.reported, 1)
2760 self.assertIn('Build succeeded', A.messages[0])
2761 # Ensure the removed job was not included in the report.
2762 self.assertNotIn('project1-project2-integration', A.messages[0])
2763
James E. Blairec056492016-07-22 09:45:56 -07002764 @skip("Disabled for early v3 development")
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002765 def test_double_live_reconfiguration_shared_queue(self):
2766 # This was a real-world regression. A change is added to
2767 # gate; a reconfigure happens, a second change which depends
2768 # on the first is added, and a second reconfiguration happens.
2769 # Ensure that both changes merge.
2770
2771 # A failure may indicate incorrect caching or cleaning up of
2772 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002773 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002774
2775 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2776 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2777 B.setDependsOn(A, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07002778 A.addApproval('code-review', 2)
2779 B.addApproval('code-review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002780
2781 # Add the parent change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002782 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002783 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002784 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002785 self.waitUntilSettled()
2786
2787 # Reconfigure (with only one change in the pipeline).
2788 self.sched.reconfigure(self.config)
2789 self.waitUntilSettled()
2790
2791 # Add the child change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002792 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002793 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002794 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002795 self.waitUntilSettled()
2796
2797 # Reconfigure (with both in the pipeline).
2798 self.sched.reconfigure(self.config)
2799 self.waitUntilSettled()
2800
Paul Belanger174a8272017-03-14 13:20:10 -04002801 self.executor_server.hold_jobs_in_build = False
2802 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002803 self.waitUntilSettled()
2804
2805 self.assertEqual(len(self.history), 8)
2806
2807 self.assertEqual(A.data['status'], 'MERGED')
2808 self.assertEqual(A.reported, 2)
2809 self.assertEqual(B.data['status'], 'MERGED')
2810 self.assertEqual(B.reported, 2)
2811
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002812 def test_live_reconfiguration_del_project(self):
2813 # Test project deletion from layout
2814 # while changes are enqueued
2815
Paul Belanger174a8272017-03-14 13:20:10 -04002816 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002817 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2818 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2819 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2820
2821 # A Depends-On: B
2822 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2823 A.subject, B.data['id'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002824 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002825
2826 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2827 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2828 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002829 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002830 self.waitUntilSettled()
2831 self.assertEqual(len(self.builds), 5)
2832
2833 # This layout defines only org/project, not org/project1
Clint Byrum0149ada2017-04-04 12:22:01 -07002834 self.commitLayoutUpdate('common-config',
2835 'layout-live-reconfiguration-del-project')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002836 self.sched.reconfigure(self.config)
2837 self.waitUntilSettled()
2838
2839 # Builds for C aborted, builds for A succeed,
2840 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002841 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002842 self.assertEqual(job_c.changes, '3,1')
2843 self.assertEqual(job_c.result, 'ABORTED')
2844
Paul Belanger174a8272017-03-14 13:20:10 -04002845 self.executor_server.hold_jobs_in_build = False
2846 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002847 self.waitUntilSettled()
2848
Clint Byrum0149ada2017-04-04 12:22:01 -07002849 self.assertEqual(
2850 self.getJobFromHistory('project-test1', 'org/project').changes,
2851 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002852
2853 self.assertEqual(A.data['status'], 'NEW')
2854 self.assertEqual(B.data['status'], 'NEW')
2855 self.assertEqual(C.data['status'], 'NEW')
2856 self.assertEqual(A.reported, 1)
2857 self.assertEqual(B.reported, 0)
2858 self.assertEqual(C.reported, 0)
2859
Clint Byrum0149ada2017-04-04 12:22:01 -07002860 tenant = self.sched.abide.tenants.get('tenant-one')
2861 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002862 self.assertIn('Build succeeded', A.messages[0])
2863
James E. Blairec056492016-07-22 09:45:56 -07002864 @skip("Disabled for early v3 development")
James E. Blair287c06d2013-07-24 10:39:30 -07002865 def test_delayed_repo_init(self):
James E. Blairf84026c2015-12-08 16:11:46 -08002866 self.updateConfigLayout(
2867 'tests/fixtures/layout-delayed-repo-init.yaml')
James E. Blair287c06d2013-07-24 10:39:30 -07002868 self.sched.reconfigure(self.config)
2869
2870 self.init_repo("org/new-project")
2871 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2872
James E. Blair8b5408c2016-08-08 15:37:46 -07002873 A.addApproval('code-review', 2)
2874 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002875 self.waitUntilSettled()
2876 self.assertEqual(self.getJobFromHistory('project-merge').result,
2877 'SUCCESS')
2878 self.assertEqual(self.getJobFromHistory('project-test1').result,
2879 'SUCCESS')
2880 self.assertEqual(self.getJobFromHistory('project-test2').result,
2881 'SUCCESS')
2882 self.assertEqual(A.data['status'], 'MERGED')
2883 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002884
Clark Boylan6dbbc482013-10-18 10:57:31 -07002885 def test_repo_deleted(self):
James E. Blair0ffa0102017-03-30 13:11:33 -07002886 self.updateConfigLayout('layout-repo-deleted', ['org/delete-project'])
Clark Boylan6dbbc482013-10-18 10:57:31 -07002887 self.sched.reconfigure(self.config)
2888
2889 self.init_repo("org/delete-project")
2890 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2891
James E. Blair8b5408c2016-08-08 15:37:46 -07002892 A.addApproval('code-review', 2)
2893 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002894 self.waitUntilSettled()
2895 self.assertEqual(self.getJobFromHistory('project-merge').result,
2896 'SUCCESS')
2897 self.assertEqual(self.getJobFromHistory('project-test1').result,
2898 'SUCCESS')
2899 self.assertEqual(self.getJobFromHistory('project-test2').result,
2900 'SUCCESS')
2901 self.assertEqual(A.data['status'], 'MERGED')
2902 self.assertEqual(A.reported, 2)
2903
2904 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002905 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002906 if os.path.exists(os.path.join(self.merger_src_root, p)):
2907 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002908 if os.path.exists(os.path.join(self.executor_src_root, p)):
2909 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002910
2911 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2912
James E. Blair8b5408c2016-08-08 15:37:46 -07002913 B.addApproval('code-review', 2)
2914 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002915 self.waitUntilSettled()
2916 self.assertEqual(self.getJobFromHistory('project-merge').result,
2917 'SUCCESS')
2918 self.assertEqual(self.getJobFromHistory('project-test1').result,
2919 'SUCCESS')
2920 self.assertEqual(self.getJobFromHistory('project-test2').result,
2921 'SUCCESS')
2922 self.assertEqual(B.data['status'], 'MERGED')
2923 self.assertEqual(B.reported, 2)
2924
James E. Blair456f2fb2016-02-09 09:29:33 -08002925 def test_tags(self):
2926 "Test job tags"
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002927 self.updateConfigLayout('layout-tags')
James E. Blair456f2fb2016-02-09 09:29:33 -08002928 self.sched.reconfigure(self.config)
2929
2930 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2931 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2932 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2933 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2934 self.waitUntilSettled()
2935
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002936 self.assertEqual(len(self.history), 8)
2937
2938 results = {self.getJobFromHistory('merge',
2939 project='org/project1').uuid: 'extratag merge',
2940 self.getJobFromHistory('merge',
2941 project='org/project2').uuid: 'merge'}
James E. Blair456f2fb2016-02-09 09:29:33 -08002942
2943 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002944 self.assertEqual(results.get(build.uuid, ''),
2945 build.parameters['vars']['zuul'].get('tags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08002946
James E. Blair63bb0ef2013-07-29 17:14:51 -07002947 def test_timer(self):
2948 "Test that a periodic job is triggered"
Paul Belanger174a8272017-03-14 13:20:10 -04002949 self.executor_server.hold_jobs_in_build = True
Clint Byrum5e729e92017-02-08 06:34:57 -08002950 self.updateConfigLayout('layout-timer')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002951 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002952
Clark Boylan3ee090a2014-04-03 20:55:09 -07002953 # The pipeline triggers every second, so we should have seen
2954 # several by now.
2955 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002956 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07002957
2958 self.assertEqual(len(self.builds), 2)
2959
James E. Blair63bb0ef2013-07-29 17:14:51 -07002960 port = self.webapp.server.socket.getsockname()[1]
2961
Clint Byrum5e729e92017-02-08 06:34:57 -08002962 req = urllib.request.Request(
2963 "http://localhost:%s/openstack/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002964 f = urllib.request.urlopen(req)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002965 data = f.read()
2966
Paul Belanger174a8272017-03-14 13:20:10 -04002967 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07002968 # Stop queuing timer triggered jobs so that the assertions
2969 # below don't race against more jobs being queued.
Clint Byrum5e729e92017-02-08 06:34:57 -08002970 self.commitLayoutUpdate('layout-timer', 'layout-no-timer')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002971 self.sched.reconfigure(self.config)
Paul Belanger174a8272017-03-14 13:20:10 -04002972 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07002973 self.waitUntilSettled()
2974
2975 self.assertEqual(self.getJobFromHistory(
2976 'project-bitrot-stable-old').result, 'SUCCESS')
2977 self.assertEqual(self.getJobFromHistory(
2978 'project-bitrot-stable-older').result, 'SUCCESS')
2979
2980 data = json.loads(data)
2981 status_jobs = set()
2982 for p in data['pipelines']:
2983 for q in p['change_queues']:
2984 for head in q['heads']:
2985 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07002986 for job in change['jobs']:
2987 status_jobs.add(job['name'])
2988 self.assertIn('project-bitrot-stable-old', status_jobs)
2989 self.assertIn('project-bitrot-stable-older', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002990
James E. Blair4f6033c2014-03-27 15:49:09 -07002991 def test_idle(self):
2992 "Test that frequent periodic jobs work"
Paul Belanger174a8272017-03-14 13:20:10 -04002993 self.executor_server.hold_jobs_in_build = True
Clint Byrum58264dc2017-02-07 21:21:22 -08002994 self.updateConfigLayout('layout-idle')
James E. Blair4f6033c2014-03-27 15:49:09 -07002995
Clark Boylan3ee090a2014-04-03 20:55:09 -07002996 for x in range(1, 3):
2997 # Test that timer triggers periodic jobs even across
2998 # layout config reloads.
2999 # Start timer trigger
Clark Boylan3ee090a2014-04-03 20:55:09 -07003000 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08003001 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07003002
Clark Boylan3ee090a2014-04-03 20:55:09 -07003003 # The pipeline triggers every second, so we should have seen
3004 # several by now.
3005 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07003006
3007 # Stop queuing timer triggered jobs so that the assertions
3008 # below don't race against more jobs being queued.
Clint Byrum58264dc2017-02-07 21:21:22 -08003009 before = self.commitLayoutUpdate('layout-idle', 'layout-no-timer')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003010 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08003011 self.waitUntilSettled()
Clint Byrum58264dc2017-02-07 21:21:22 -08003012 self.assertEqual(len(self.builds), 2,
3013 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04003014 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003015 self.waitUntilSettled()
3016 self.assertEqual(len(self.builds), 0)
3017 self.assertEqual(len(self.history), x * 2)
Clint Byrum58264dc2017-02-07 21:21:22 -08003018 # Revert back to layout-idle
3019 repo = git.Repo(os.path.join(self.test_root,
3020 'upstream',
3021 'layout-idle'))
3022 repo.git.reset('--hard', before)
James E. Blair4f6033c2014-03-27 15:49:09 -07003023
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003024 def test_check_smtp_pool(self):
Paul Belanger01be8ca2016-11-11 12:21:06 -05003025 self.updateConfigLayout('layout-smtp')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003026 self.sched.reconfigure(self.config)
3027
3028 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3029 self.waitUntilSettled()
3030
3031 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3032 self.waitUntilSettled()
3033
James E. Blairff80a2f2013-12-27 13:24:06 -08003034 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003035
3036 # A.messages only holds what FakeGerrit places in it. Thus we
3037 # work on the knowledge of what the first message should be as
3038 # it is only configured to go to SMTP.
3039
3040 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003041 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003042 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003043 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003044 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08003045 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003046
3047 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003048 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003049 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003050 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003051 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08003052 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08003053
James E. Blaire5910202013-12-27 09:50:31 -08003054 def test_timer_smtp(self):
3055 "Test that a periodic job is triggered"
Paul Belanger174a8272017-03-14 13:20:10 -04003056 self.executor_server.hold_jobs_in_build = True
Clint Byrum7b71b2f2017-02-08 07:00:52 -08003057 self.updateConfigLayout('layout-timer-smtp')
James E. Blaire5910202013-12-27 09:50:31 -08003058 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08003059
Clark Boylan3ee090a2014-04-03 20:55:09 -07003060 # The pipeline triggers every second, so we should have seen
3061 # several by now.
3062 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08003063 self.waitUntilSettled()
3064
Clark Boylan3ee090a2014-04-03 20:55:09 -07003065 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003066 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003067 self.waitUntilSettled()
3068 self.assertEqual(len(self.history), 2)
3069
James E. Blaire5910202013-12-27 09:50:31 -08003070 self.assertEqual(self.getJobFromHistory(
3071 'project-bitrot-stable-old').result, 'SUCCESS')
3072 self.assertEqual(self.getJobFromHistory(
3073 'project-bitrot-stable-older').result, 'SUCCESS')
3074
James E. Blairff80a2f2013-12-27 13:24:06 -08003075 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08003076
3077 # A.messages only holds what FakeGerrit places in it. Thus we
3078 # work on the knowledge of what the first message should be as
3079 # it is only configured to go to SMTP.
3080
3081 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003082 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08003083 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003084 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08003085 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08003086 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08003087
Clark Boylan3ee090a2014-04-03 20:55:09 -07003088 # Stop queuing timer triggered jobs and let any that may have
3089 # queued through so that end of test assertions pass.
Clint Byrum7b71b2f2017-02-08 07:00:52 -08003090 self.commitLayoutUpdate('layout-timer-smtp', 'layout-no-timer')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003091 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07003092 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003093 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003094 self.waitUntilSettled()
3095
Joshua Hesketh25695cb2017-03-06 12:50:04 +11003096 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00003097 def test_timer_sshkey(self):
3098 "Test that a periodic job can setup SSH key authentication"
3099 self.worker.hold_jobs_in_build = True
3100 self.config.set('zuul', 'layout_config',
3101 'tests/fixtures/layout-timer.yaml')
3102 self.sched.reconfigure(self.config)
3103 self.registerJobs()
3104
3105 # The pipeline triggers every second, so we should have seen
3106 # several by now.
3107 time.sleep(5)
3108 self.waitUntilSettled()
3109
3110 self.assertEqual(len(self.builds), 2)
3111
3112 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
3113 self.assertTrue(os.path.isfile(ssh_wrapper))
3114 with open(ssh_wrapper) as f:
3115 ssh_wrapper_content = f.read()
3116 self.assertIn("fake_id_rsa", ssh_wrapper_content)
3117 # In the unit tests Merger runs in the same process,
3118 # so we see its' environment variables
3119 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
3120
3121 self.worker.release('.*')
3122 self.waitUntilSettled()
3123 self.assertEqual(len(self.history), 2)
3124
3125 self.assertEqual(self.getJobFromHistory(
3126 'project-bitrot-stable-old').result, 'SUCCESS')
3127 self.assertEqual(self.getJobFromHistory(
3128 'project-bitrot-stable-older').result, 'SUCCESS')
3129
3130 # Stop queuing timer triggered jobs and let any that may have
3131 # queued through so that end of test assertions pass.
3132 self.config.set('zuul', 'layout_config',
3133 'tests/fixtures/layout-no-timer.yaml')
3134 self.sched.reconfigure(self.config)
3135 self.registerJobs()
3136 self.waitUntilSettled()
3137 self.worker.release('.*')
3138 self.waitUntilSettled()
3139
James E. Blair91e34592015-07-31 16:45:59 -07003140 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08003141 "Test that the RPC client can enqueue a change"
3142 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003143 A.addApproval('code-review', 2)
3144 A.addApproval('approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08003145
3146 client = zuul.rpcclient.RPCClient('127.0.0.1',
3147 self.gearman_server.port)
Paul Belangerbaca3132016-11-04 12:49:54 -04003148 r = client.enqueue(tenant='tenant-one',
3149 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003150 project='org/project',
3151 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003152 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003153 self.waitUntilSettled()
3154 self.assertEqual(self.getJobFromHistory('project-merge').result,
3155 'SUCCESS')
3156 self.assertEqual(self.getJobFromHistory('project-test1').result,
3157 'SUCCESS')
3158 self.assertEqual(self.getJobFromHistory('project-test2').result,
3159 'SUCCESS')
3160 self.assertEqual(A.data['status'], 'MERGED')
3161 self.assertEqual(A.reported, 2)
3162 self.assertEqual(r, True)
3163
James E. Blair91e34592015-07-31 16:45:59 -07003164 def test_client_enqueue_ref(self):
3165 "Test that the RPC client can enqueue a ref"
3166
3167 client = zuul.rpcclient.RPCClient('127.0.0.1',
3168 self.gearman_server.port)
3169 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04003170 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07003171 pipeline='post',
3172 project='org/project',
3173 trigger='gerrit',
3174 ref='master',
3175 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
3176 newrev='d479a0bfcb34da57a31adb2a595c0cf687812543')
3177 self.waitUntilSettled()
3178 job_names = [x.name for x in self.history]
3179 self.assertEqual(len(self.history), 1)
3180 self.assertIn('project-post', job_names)
3181 self.assertEqual(r, True)
3182
James E. Blairad28e912013-11-27 10:43:22 -08003183 def test_client_enqueue_negative(self):
3184 "Test that the RPC client returns errors"
3185 client = zuul.rpcclient.RPCClient('127.0.0.1',
3186 self.gearman_server.port)
3187 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04003188 "Invalid tenant"):
3189 r = client.enqueue(tenant='tenant-foo',
3190 pipeline='gate',
3191 project='org/project',
3192 trigger='gerrit',
3193 change='1,1')
3194 client.shutdown()
3195 self.assertEqual(r, False)
3196
3197 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08003198 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003199 r = client.enqueue(tenant='tenant-one',
3200 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003201 project='project-does-not-exist',
3202 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003203 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003204 client.shutdown()
3205 self.assertEqual(r, False)
3206
3207 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3208 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003209 r = client.enqueue(tenant='tenant-one',
3210 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08003211 project='org/project',
3212 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003213 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003214 client.shutdown()
3215 self.assertEqual(r, False)
3216
3217 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3218 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003219 r = client.enqueue(tenant='tenant-one',
3220 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003221 project='org/project',
3222 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08003223 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003224 client.shutdown()
3225 self.assertEqual(r, False)
3226
3227 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3228 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003229 r = client.enqueue(tenant='tenant-one',
3230 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003231 project='org/project',
3232 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003233 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003234 client.shutdown()
3235 self.assertEqual(r, False)
3236
3237 self.waitUntilSettled()
3238 self.assertEqual(len(self.history), 0)
3239 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08003240
3241 def test_client_promote(self):
3242 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04003243 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003244 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3245 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3246 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003247 A.addApproval('code-review', 2)
3248 B.addApproval('code-review', 2)
3249 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003250
James E. Blair8b5408c2016-08-08 15:37:46 -07003251 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3252 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3253 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003254
3255 self.waitUntilSettled()
3256
Paul Belangerbaca3132016-11-04 12:49:54 -04003257 tenant = self.sched.abide.tenants.get('tenant-one')
3258 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003259 enqueue_times = {}
3260 for item in items:
3261 enqueue_times[str(item.change)] = item.enqueue_time
3262
James E. Blair36658cf2013-12-06 17:53:48 -08003263 client = zuul.rpcclient.RPCClient('127.0.0.1',
3264 self.gearman_server.port)
Paul Belangerbaca3132016-11-04 12:49:54 -04003265 r = client.promote(tenant='tenant-one',
3266 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003267 change_ids=['2,1', '3,1'])
3268
Sean Daguef39b9ca2014-01-10 21:34:35 -05003269 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003270 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003271 for item in items:
3272 self.assertEqual(
3273 enqueue_times[str(item.change)], item.enqueue_time)
3274
James E. Blair78acec92014-02-06 07:11:32 -08003275 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003276 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003277 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003278 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003279 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003280 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003281 self.waitUntilSettled()
3282
3283 self.assertEqual(len(self.builds), 6)
3284 self.assertEqual(self.builds[0].name, 'project-test1')
3285 self.assertEqual(self.builds[1].name, 'project-test2')
3286 self.assertEqual(self.builds[2].name, 'project-test1')
3287 self.assertEqual(self.builds[3].name, 'project-test2')
3288 self.assertEqual(self.builds[4].name, 'project-test1')
3289 self.assertEqual(self.builds[5].name, 'project-test2')
3290
Paul Belangerbaca3132016-11-04 12:49:54 -04003291 self.assertTrue(self.builds[0].hasChanges(B))
3292 self.assertFalse(self.builds[0].hasChanges(A))
3293 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003294
Paul Belangerbaca3132016-11-04 12:49:54 -04003295 self.assertTrue(self.builds[2].hasChanges(B))
3296 self.assertTrue(self.builds[2].hasChanges(C))
3297 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003298
Paul Belangerbaca3132016-11-04 12:49:54 -04003299 self.assertTrue(self.builds[4].hasChanges(B))
3300 self.assertTrue(self.builds[4].hasChanges(C))
3301 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003302
Paul Belanger174a8272017-03-14 13:20:10 -04003303 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003304 self.waitUntilSettled()
3305
3306 self.assertEqual(A.data['status'], 'MERGED')
3307 self.assertEqual(A.reported, 2)
3308 self.assertEqual(B.data['status'], 'MERGED')
3309 self.assertEqual(B.reported, 2)
3310 self.assertEqual(C.data['status'], 'MERGED')
3311 self.assertEqual(C.reported, 2)
3312
3313 client.shutdown()
3314 self.assertEqual(r, True)
3315
3316 def test_client_promote_dependent(self):
3317 "Test that the RPC client can promote a dependent change"
3318 # C (depends on B) -> B -> A ; then promote C to get:
3319 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003320 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003321 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3322 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3323 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3324
3325 C.setDependsOn(B, 1)
3326
James E. Blair8b5408c2016-08-08 15:37:46 -07003327 A.addApproval('code-review', 2)
3328 B.addApproval('code-review', 2)
3329 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003330
James E. Blair8b5408c2016-08-08 15:37:46 -07003331 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3332 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3333 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003334
3335 self.waitUntilSettled()
3336
3337 client = zuul.rpcclient.RPCClient('127.0.0.1',
3338 self.gearman_server.port)
Paul Belangerbaca3132016-11-04 12:49:54 -04003339 r = client.promote(tenant='tenant-one',
3340 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003341 change_ids=['3,1'])
3342
James E. Blair78acec92014-02-06 07:11:32 -08003343 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003344 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003345 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003346 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003347 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003348 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003349 self.waitUntilSettled()
3350
3351 self.assertEqual(len(self.builds), 6)
3352 self.assertEqual(self.builds[0].name, 'project-test1')
3353 self.assertEqual(self.builds[1].name, 'project-test2')
3354 self.assertEqual(self.builds[2].name, 'project-test1')
3355 self.assertEqual(self.builds[3].name, 'project-test2')
3356 self.assertEqual(self.builds[4].name, 'project-test1')
3357 self.assertEqual(self.builds[5].name, 'project-test2')
3358
Paul Belangerbaca3132016-11-04 12:49:54 -04003359 self.assertTrue(self.builds[0].hasChanges(B))
3360 self.assertFalse(self.builds[0].hasChanges(A))
3361 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003362
Paul Belangerbaca3132016-11-04 12:49:54 -04003363 self.assertTrue(self.builds[2].hasChanges(B))
3364 self.assertTrue(self.builds[2].hasChanges(C))
3365 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003366
Paul Belangerbaca3132016-11-04 12:49:54 -04003367 self.assertTrue(self.builds[4].hasChanges(B))
3368 self.assertTrue(self.builds[4].hasChanges(C))
3369 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003370
Paul Belanger174a8272017-03-14 13:20:10 -04003371 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003372 self.waitUntilSettled()
3373
3374 self.assertEqual(A.data['status'], 'MERGED')
3375 self.assertEqual(A.reported, 2)
3376 self.assertEqual(B.data['status'], 'MERGED')
3377 self.assertEqual(B.reported, 2)
3378 self.assertEqual(C.data['status'], 'MERGED')
3379 self.assertEqual(C.reported, 2)
3380
3381 client.shutdown()
3382 self.assertEqual(r, True)
3383
3384 def test_client_promote_negative(self):
3385 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003386 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003387 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003388 A.addApproval('code-review', 2)
3389 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003390 self.waitUntilSettled()
3391
3392 client = zuul.rpcclient.RPCClient('127.0.0.1',
3393 self.gearman_server.port)
3394
3395 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003396 r = client.promote(tenant='tenant-one',
3397 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003398 change_ids=['2,1', '3,1'])
3399 client.shutdown()
3400 self.assertEqual(r, False)
3401
3402 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003403 r = client.promote(tenant='tenant-one',
3404 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003405 change_ids=['4,1'])
3406 client.shutdown()
3407 self.assertEqual(r, False)
3408
Paul Belanger174a8272017-03-14 13:20:10 -04003409 self.executor_server.hold_jobs_in_build = False
3410 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003411 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003412
3413 def test_queue_rate_limiting(self):
3414 "Test that DependentPipelines are rate limited with dep across window"
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003415 self.updateConfigLayout('layout-rate-limit')
Clark Boylan7603a372014-01-21 11:43:20 -08003416 self.sched.reconfigure(self.config)
Paul Belanger174a8272017-03-14 13:20:10 -04003417 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003418 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3419 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3420 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3421
3422 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003423 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003424
James E. Blair8b5408c2016-08-08 15:37:46 -07003425 A.addApproval('code-review', 2)
3426 B.addApproval('code-review', 2)
3427 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003428
James E. Blair8b5408c2016-08-08 15:37:46 -07003429 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3430 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3431 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003432 self.waitUntilSettled()
3433
3434 # Only A and B will have their merge jobs queued because
3435 # window is 2.
3436 self.assertEqual(len(self.builds), 2)
3437 self.assertEqual(self.builds[0].name, 'project-merge')
3438 self.assertEqual(self.builds[1].name, 'project-merge')
3439
Paul Belanger174a8272017-03-14 13:20:10 -04003440 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003441 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003442 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003443 self.waitUntilSettled()
3444
3445 # Only A and B will have their test jobs queued because
3446 # window is 2.
3447 self.assertEqual(len(self.builds), 4)
3448 self.assertEqual(self.builds[0].name, 'project-test1')
3449 self.assertEqual(self.builds[1].name, 'project-test2')
3450 self.assertEqual(self.builds[2].name, 'project-test1')
3451 self.assertEqual(self.builds[3].name, 'project-test2')
3452
Paul Belanger174a8272017-03-14 13:20:10 -04003453 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003454 self.waitUntilSettled()
3455
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003456 tenant = self.sched.abide.tenants.get('openstack')
3457 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003458 # A failed so window is reduced by 1 to 1.
3459 self.assertEqual(queue.window, 1)
3460 self.assertEqual(queue.window_floor, 1)
3461 self.assertEqual(A.data['status'], 'NEW')
3462
3463 # Gate is reset and only B's merge job is queued because
3464 # window shrunk to 1.
3465 self.assertEqual(len(self.builds), 1)
3466 self.assertEqual(self.builds[0].name, 'project-merge')
3467
Paul Belanger174a8272017-03-14 13:20:10 -04003468 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003469 self.waitUntilSettled()
3470
3471 # Only B's test jobs are queued because window is still 1.
3472 self.assertEqual(len(self.builds), 2)
3473 self.assertEqual(self.builds[0].name, 'project-test1')
3474 self.assertEqual(self.builds[1].name, 'project-test2')
3475
Paul Belanger174a8272017-03-14 13:20:10 -04003476 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003477 self.waitUntilSettled()
3478
3479 # B was successfully merged so window is increased to 2.
3480 self.assertEqual(queue.window, 2)
3481 self.assertEqual(queue.window_floor, 1)
3482 self.assertEqual(B.data['status'], 'MERGED')
3483
3484 # Only C is left and its merge job is queued.
3485 self.assertEqual(len(self.builds), 1)
3486 self.assertEqual(self.builds[0].name, 'project-merge')
3487
Paul Belanger174a8272017-03-14 13:20:10 -04003488 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003489 self.waitUntilSettled()
3490
3491 # After successful merge job the test jobs for C are queued.
3492 self.assertEqual(len(self.builds), 2)
3493 self.assertEqual(self.builds[0].name, 'project-test1')
3494 self.assertEqual(self.builds[1].name, 'project-test2')
3495
Paul Belanger174a8272017-03-14 13:20:10 -04003496 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003497 self.waitUntilSettled()
3498
3499 # C successfully merged so window is bumped to 3.
3500 self.assertEqual(queue.window, 3)
3501 self.assertEqual(queue.window_floor, 1)
3502 self.assertEqual(C.data['status'], 'MERGED')
3503
3504 def test_queue_rate_limiting_dependent(self):
3505 "Test that DependentPipelines are rate limited with dep in window"
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003506 self.updateConfigLayout('layout-rate-limit')
Clark Boylan7603a372014-01-21 11:43:20 -08003507 self.sched.reconfigure(self.config)
Paul Belanger174a8272017-03-14 13:20:10 -04003508 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003509 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3510 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3511 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3512
3513 B.setDependsOn(A, 1)
3514
Paul Belanger174a8272017-03-14 13:20:10 -04003515 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003516
James E. Blair8b5408c2016-08-08 15:37:46 -07003517 A.addApproval('code-review', 2)
3518 B.addApproval('code-review', 2)
3519 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003520
James E. Blair8b5408c2016-08-08 15:37:46 -07003521 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3522 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3523 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003524 self.waitUntilSettled()
3525
3526 # Only A and B will have their merge jobs queued because
3527 # window is 2.
3528 self.assertEqual(len(self.builds), 2)
3529 self.assertEqual(self.builds[0].name, 'project-merge')
3530 self.assertEqual(self.builds[1].name, 'project-merge')
3531
James E. Blairf4a5f022017-04-18 14:01:10 -07003532 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003533
3534 # Only A and B will have their test jobs queued because
3535 # window is 2.
3536 self.assertEqual(len(self.builds), 4)
3537 self.assertEqual(self.builds[0].name, 'project-test1')
3538 self.assertEqual(self.builds[1].name, 'project-test2')
3539 self.assertEqual(self.builds[2].name, 'project-test1')
3540 self.assertEqual(self.builds[3].name, 'project-test2')
3541
Paul Belanger174a8272017-03-14 13:20:10 -04003542 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003543 self.waitUntilSettled()
3544
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003545 tenant = self.sched.abide.tenants.get('openstack')
3546 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003547 # A failed so window is reduced by 1 to 1.
3548 self.assertEqual(queue.window, 1)
3549 self.assertEqual(queue.window_floor, 1)
3550 self.assertEqual(A.data['status'], 'NEW')
3551 self.assertEqual(B.data['status'], 'NEW')
3552
3553 # Gate is reset and only C's merge job is queued because
3554 # window shrunk to 1 and A and B were dequeued.
3555 self.assertEqual(len(self.builds), 1)
3556 self.assertEqual(self.builds[0].name, 'project-merge')
3557
James E. Blairf4a5f022017-04-18 14:01:10 -07003558 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003559
3560 # Only C's test jobs are queued because window is still 1.
3561 self.assertEqual(len(self.builds), 2)
3562 self.assertEqual(self.builds[0].name, 'project-test1')
3563 self.assertEqual(self.builds[1].name, 'project-test2')
3564
Paul Belanger174a8272017-03-14 13:20:10 -04003565 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003566 self.waitUntilSettled()
3567
3568 # C was successfully merged so window is increased to 2.
3569 self.assertEqual(queue.window, 2)
3570 self.assertEqual(queue.window_floor, 1)
3571 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003572
James E. Blairec056492016-07-22 09:45:56 -07003573 @skip("Disabled for early v3 development")
Joshua Heskethba8776a2014-01-12 14:35:40 +08003574 def test_worker_update_metadata(self):
3575 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003576 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003577
3578 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003579 A.addApproval('code-review', 2)
3580 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003581 self.waitUntilSettled()
3582
Paul Belanger174a8272017-03-14 13:20:10 -04003583 self.assertEqual(len(self.executor.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003584
3585 self.log.debug('Current builds:')
Paul Belanger174a8272017-03-14 13:20:10 -04003586 self.log.debug(self.executor.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003587
3588 start = time.time()
3589 while True:
3590 if time.time() - start > 10:
3591 raise Exception("Timeout waiting for gearman server to report "
3592 + "back to the client")
Paul Belanger174a8272017-03-14 13:20:10 -04003593 build = self.executor.builds.values()[0]
Joshua Heskethba8776a2014-01-12 14:35:40 +08003594 if build.worker.name == "My Worker":
3595 break
3596 else:
3597 time.sleep(0)
3598
3599 self.log.debug(build)
3600 self.assertEqual("My Worker", build.worker.name)
3601 self.assertEqual("localhost", build.worker.hostname)
3602 self.assertEqual(['127.0.0.1', '192.168.1.1'], build.worker.ips)
3603 self.assertEqual("zuul.example.org", build.worker.fqdn)
3604 self.assertEqual("FakeBuilder", build.worker.program)
3605 self.assertEqual("v1.1", build.worker.version)
3606 self.assertEqual({'something': 'else'}, build.worker.extra)
3607
Paul Belanger174a8272017-03-14 13:20:10 -04003608 self.executor_server.hold_jobs_in_build = False
3609 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003610 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003611
3612 def test_footer_message(self):
3613 "Test a pipeline's footer message is correctly added to the report."
Adam Gandelman82258fd2017-02-07 16:51:58 -08003614 self.updateConfigLayout('layout-footer-message')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003615 self.sched.reconfigure(self.config)
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003616
3617 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003618 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003619 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003620 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003621 self.waitUntilSettled()
3622
3623 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003624 B.addApproval('code-review', 2)
3625 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003626 self.waitUntilSettled()
3627
3628 self.assertEqual(2, len(self.smtp_messages))
3629
Adam Gandelman82258fd2017-02-07 16:51:58 -08003630 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003631Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003632http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003633
Adam Gandelman82258fd2017-02-07 16:51:58 -08003634 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003635For CI problems and help debugging, contact ci@example.org"""
3636
Adam Gandelman82258fd2017-02-07 16:51:58 -08003637 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3638 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3639 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3640 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003641
James E. Blairec056492016-07-22 09:45:56 -07003642 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003643 def test_merge_failure_reporters(self):
3644 """Check that the config is set up correctly"""
3645
James E. Blairf84026c2015-12-08 16:11:46 -08003646 self.updateConfigLayout(
3647 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003648 self.sched.reconfigure(self.config)
3649 self.registerJobs()
3650
3651 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003652 "Merge Failed.\n\nThis change or one of its cross-repo "
3653 "dependencies was unable to be automatically merged with the "
3654 "current state of its repository. Please rebase the change and "
3655 "upload a new patchset.",
Joshua Heskethb7179772014-01-30 23:30:46 +11003656 self.sched.layout.pipelines['check'].merge_failure_message)
3657 self.assertEqual(
3658 "The merge failed! For more information...",
3659 self.sched.layout.pipelines['gate'].merge_failure_message)
3660
3661 self.assertEqual(
3662 len(self.sched.layout.pipelines['check'].merge_failure_actions), 1)
3663 self.assertEqual(
3664 len(self.sched.layout.pipelines['gate'].merge_failure_actions), 2)
3665
3666 self.assertTrue(isinstance(
Joshua Heskethde958652015-11-10 19:19:50 +11003667 self.sched.layout.pipelines['check'].merge_failure_actions[0],
3668 zuul.reporter.gerrit.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003669
3670 self.assertTrue(
3671 (
3672 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003673 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003674 zuul.reporter.smtp.SMTPReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003675 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003676 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003677 zuul.reporter.gerrit.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003678 ) or (
3679 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003680 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003681 zuul.reporter.gerrit.GerritReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003682 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003683 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003684 zuul.reporter.smtp.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003685 )
3686 )
3687
James E. Blairec056492016-07-22 09:45:56 -07003688 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003689 def test_merge_failure_reports(self):
3690 """Check that when a change fails to merge the correct message is sent
3691 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003692 self.updateConfigLayout(
3693 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003694 self.sched.reconfigure(self.config)
3695 self.registerJobs()
3696
3697 # Check a test failure isn't reported to SMTP
3698 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003699 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003700 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003701 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003702 self.waitUntilSettled()
3703
3704 self.assertEqual(3, len(self.history)) # 3 jobs
3705 self.assertEqual(0, len(self.smtp_messages))
3706
3707 # Check a merge failure is reported to SMTP
3708 # B should be merged, but C will conflict with B
3709 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3710 B.addPatchset(['conflict'])
3711 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3712 C.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003713 B.addApproval('code-review', 2)
3714 C.addApproval('code-review', 2)
3715 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3716 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003717 self.waitUntilSettled()
3718
3719 self.assertEqual(6, len(self.history)) # A and B jobs
3720 self.assertEqual(1, len(self.smtp_messages))
3721 self.assertEqual('The merge failed! For more information...',
3722 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003723
James E. Blairec056492016-07-22 09:45:56 -07003724 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003725 def test_default_merge_failure_reports(self):
3726 """Check that the default merge failure reports are correct."""
3727
3728 # A should report success, B should report merge failure.
3729 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3730 A.addPatchset(['conflict'])
3731 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3732 B.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003733 A.addApproval('code-review', 2)
3734 B.addApproval('code-review', 2)
3735 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3736 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003737 self.waitUntilSettled()
3738
3739 self.assertEqual(3, len(self.history)) # A jobs
3740 self.assertEqual(A.reported, 2)
3741 self.assertEqual(B.reported, 2)
3742 self.assertEqual(A.data['status'], 'MERGED')
3743 self.assertEqual(B.data['status'], 'NEW')
3744 self.assertIn('Build succeeded', A.messages[1])
3745 self.assertIn('Merge Failed', B.messages[1])
3746 self.assertIn('automatically merged', B.messages[1])
3747 self.assertNotIn('logs.example.com', B.messages[1])
3748 self.assertNotIn('SKIPPED', B.messages[1])
3749
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003750 def test_client_get_running_jobs(self):
3751 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003752 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003753 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003754 A.addApproval('code-review', 2)
3755 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003756 self.waitUntilSettled()
3757
3758 client = zuul.rpcclient.RPCClient('127.0.0.1',
3759 self.gearman_server.port)
3760
3761 # Wait for gearman server to send the initial workData back to zuul
3762 start = time.time()
3763 while True:
3764 if time.time() - start > 10:
3765 raise Exception("Timeout waiting for gearman server to report "
3766 + "back to the client")
Paul Belanger174a8272017-03-14 13:20:10 -04003767 build = self.executor_client.builds.values()[0]
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003768 if build.worker.name == "My Worker":
3769 break
3770 else:
3771 time.sleep(0)
3772
3773 running_items = client.get_running_jobs()
3774
3775 self.assertEqual(1, len(running_items))
3776 running_item = running_items[0]
3777 self.assertEqual([], running_item['failing_reasons'])
3778 self.assertEqual([], running_item['items_behind'])
3779 self.assertEqual('https://hostname/1', running_item['url'])
3780 self.assertEqual(None, running_item['item_ahead'])
3781 self.assertEqual('org/project', running_item['project'])
3782 self.assertEqual(None, running_item['remaining_time'])
3783 self.assertEqual(True, running_item['active'])
3784 self.assertEqual('1,1', running_item['id'])
3785
3786 self.assertEqual(3, len(running_item['jobs']))
3787 for job in running_item['jobs']:
3788 if job['name'] == 'project-merge':
3789 self.assertEqual('project-merge', job['name'])
3790 self.assertEqual('gate', job['pipeline'])
3791 self.assertEqual(False, job['retry'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003792 self.assertEqual('https://server/job/project-merge/0/',
3793 job['url'])
3794 self.assertEqual(7, len(job['worker']))
3795 self.assertEqual(False, job['canceled'])
3796 self.assertEqual(True, job['voting'])
3797 self.assertEqual(None, job['result'])
3798 self.assertEqual('gate', job['pipeline'])
3799 break
3800
Paul Belanger174a8272017-03-14 13:20:10 -04003801 self.executor_server.hold_jobs_in_build = False
3802 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003803 self.waitUntilSettled()
3804
3805 running_items = client.get_running_jobs()
3806 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003807
James E. Blairb70e55a2017-04-19 12:57:02 -07003808 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003809 def test_nonvoting_pipeline(self):
3810 "Test that a nonvoting pipeline (experimental) can still report"
3811
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003812 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3813 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003814 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3815 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003816
3817 self.assertEqual(self.getJobFromHistory('project-merge').result,
3818 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003819 self.assertEqual(
3820 self.getJobFromHistory('experimental-project-test').result,
3821 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003822 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003823
3824 def test_crd_gate(self):
3825 "Test cross-repo dependencies"
3826 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3827 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003828 A.addApproval('code-review', 2)
3829 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003830
3831 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3832 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3833 AM2.setMerged()
3834 AM1.setMerged()
3835
3836 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3837 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3838 BM2.setMerged()
3839 BM1.setMerged()
3840
3841 # A -> AM1 -> AM2
3842 # B -> BM1 -> BM2
3843 # A Depends-On: B
3844 # M2 is here to make sure it is never queried. If it is, it
3845 # means zuul is walking down the entire history of merged
3846 # changes.
3847
3848 B.setDependsOn(BM1, 1)
3849 BM1.setDependsOn(BM2, 1)
3850
3851 A.setDependsOn(AM1, 1)
3852 AM1.setDependsOn(AM2, 1)
3853
3854 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3855 A.subject, B.data['id'])
3856
James E. Blair8b5408c2016-08-08 15:37:46 -07003857 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003858 self.waitUntilSettled()
3859
3860 self.assertEqual(A.data['status'], 'NEW')
3861 self.assertEqual(B.data['status'], 'NEW')
3862
Paul Belanger5dccbe72016-11-14 11:17:37 -05003863 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11003864 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003865
Paul Belanger174a8272017-03-14 13:20:10 -04003866 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003867 B.addApproval('approved', 1)
3868 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003869 self.waitUntilSettled()
3870
Paul Belanger174a8272017-03-14 13:20:10 -04003871 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003872 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003873 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003874 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003875 self.executor_server.hold_jobs_in_build = False
3876 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003877 self.waitUntilSettled()
3878
3879 self.assertEqual(AM2.queried, 0)
3880 self.assertEqual(BM2.queried, 0)
3881 self.assertEqual(A.data['status'], 'MERGED')
3882 self.assertEqual(B.data['status'], 'MERGED')
3883 self.assertEqual(A.reported, 2)
3884 self.assertEqual(B.reported, 2)
3885
Paul Belanger5dccbe72016-11-14 11:17:37 -05003886 changes = self.getJobFromHistory(
3887 'project-merge', 'org/project1').changes
3888 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003889
3890 def test_crd_branch(self):
3891 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003892
3893 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003894 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3895 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3896 C = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C')
3897 C.data['id'] = B.data['id']
James E. Blair8b5408c2016-08-08 15:37:46 -07003898 A.addApproval('code-review', 2)
3899 B.addApproval('code-review', 2)
3900 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003901
3902 # A Depends-On: B+C
3903 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3904 A.subject, B.data['id'])
3905
Paul Belanger174a8272017-03-14 13:20:10 -04003906 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003907 B.addApproval('approved', 1)
3908 C.addApproval('approved', 1)
3909 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003910 self.waitUntilSettled()
3911
Paul Belanger174a8272017-03-14 13:20:10 -04003912 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003913 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003914 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003915 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003916 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003917 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003918 self.executor_server.hold_jobs_in_build = False
3919 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003920 self.waitUntilSettled()
3921
3922 self.assertEqual(A.data['status'], 'MERGED')
3923 self.assertEqual(B.data['status'], 'MERGED')
3924 self.assertEqual(C.data['status'], 'MERGED')
3925 self.assertEqual(A.reported, 2)
3926 self.assertEqual(B.reported, 2)
3927 self.assertEqual(C.reported, 2)
3928
Paul Belanger6379db12016-11-14 13:57:54 -05003929 changes = self.getJobFromHistory(
3930 'project-merge', 'org/project1').changes
3931 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003932
3933 def test_crd_multiline(self):
3934 "Test multiple depends-on lines in commit"
3935 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3936 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3937 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003938 A.addApproval('code-review', 2)
3939 B.addApproval('code-review', 2)
3940 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003941
3942 # A Depends-On: B+C
3943 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
3944 A.subject, B.data['id'], C.data['id'])
3945
Paul Belanger174a8272017-03-14 13:20:10 -04003946 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003947 B.addApproval('approved', 1)
3948 C.addApproval('approved', 1)
3949 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003950 self.waitUntilSettled()
3951
Paul Belanger174a8272017-03-14 13:20:10 -04003952 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003953 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003954 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003955 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003956 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003957 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003958 self.executor_server.hold_jobs_in_build = False
3959 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003960 self.waitUntilSettled()
3961
3962 self.assertEqual(A.data['status'], 'MERGED')
3963 self.assertEqual(B.data['status'], 'MERGED')
3964 self.assertEqual(C.data['status'], 'MERGED')
3965 self.assertEqual(A.reported, 2)
3966 self.assertEqual(B.reported, 2)
3967 self.assertEqual(C.reported, 2)
3968
Paul Belanger5dccbe72016-11-14 11:17:37 -05003969 changes = self.getJobFromHistory(
3970 'project-merge', 'org/project1').changes
3971 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08003972
3973 def test_crd_unshared_gate(self):
3974 "Test cross-repo dependencies in unshared gate queues"
3975 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3976 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003977 A.addApproval('code-review', 2)
3978 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003979
3980 # A Depends-On: B
3981 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3982 A.subject, B.data['id'])
3983
3984 # A and B do not share a queue, make sure that A is unable to
3985 # enqueue B (and therefore, A is unable to be enqueued).
James E. Blair8b5408c2016-08-08 15:37:46 -07003986 B.addApproval('approved', 1)
3987 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003988 self.waitUntilSettled()
3989
3990 self.assertEqual(A.data['status'], 'NEW')
3991 self.assertEqual(B.data['status'], 'NEW')
3992 self.assertEqual(A.reported, 0)
3993 self.assertEqual(B.reported, 0)
3994 self.assertEqual(len(self.history), 0)
3995
3996 # Enqueue and merge B alone.
James E. Blair8b5408c2016-08-08 15:37:46 -07003997 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003998 self.waitUntilSettled()
3999
4000 self.assertEqual(B.data['status'], 'MERGED')
4001 self.assertEqual(B.reported, 2)
4002
4003 # Now that B is merged, A should be able to be enqueued and
4004 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07004005 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004006 self.waitUntilSettled()
4007
4008 self.assertEqual(A.data['status'], 'MERGED')
4009 self.assertEqual(A.reported, 2)
4010
James E. Blair96698e22015-04-02 07:48:21 -07004011 def test_crd_gate_reverse(self):
4012 "Test reverse cross-repo dependencies"
4013 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4014 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07004015 A.addApproval('code-review', 2)
4016 B.addApproval('code-review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07004017
4018 # A Depends-On: B
4019
4020 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4021 A.subject, B.data['id'])
4022
James E. Blair8b5408c2016-08-08 15:37:46 -07004023 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07004024 self.waitUntilSettled()
4025
4026 self.assertEqual(A.data['status'], 'NEW')
4027 self.assertEqual(B.data['status'], 'NEW')
4028
Paul Belanger174a8272017-03-14 13:20:10 -04004029 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07004030 A.addApproval('approved', 1)
4031 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07004032 self.waitUntilSettled()
4033
Paul Belanger174a8272017-03-14 13:20:10 -04004034 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07004035 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004036 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07004037 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004038 self.executor_server.hold_jobs_in_build = False
4039 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07004040 self.waitUntilSettled()
4041
4042 self.assertEqual(A.data['status'], 'MERGED')
4043 self.assertEqual(B.data['status'], 'MERGED')
4044 self.assertEqual(A.reported, 2)
4045 self.assertEqual(B.reported, 2)
4046
Paul Belanger5dccbe72016-11-14 11:17:37 -05004047 changes = self.getJobFromHistory(
4048 'project-merge', 'org/project1').changes
4049 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07004050
James E. Blair5ee24252014-12-30 10:12:29 -08004051 def test_crd_cycle(self):
4052 "Test cross-repo dependency cycles"
4053 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4054 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07004055 A.addApproval('code-review', 2)
4056 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08004057
4058 # A -> B -> A (via commit-depends)
4059
4060 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4061 A.subject, B.data['id'])
4062 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4063 B.subject, A.data['id'])
4064
James E. Blair8b5408c2016-08-08 15:37:46 -07004065 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004066 self.waitUntilSettled()
4067
4068 self.assertEqual(A.reported, 0)
4069 self.assertEqual(B.reported, 0)
4070 self.assertEqual(A.data['status'], 'NEW')
4071 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08004072
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004073 def test_crd_gate_unknown(self):
4074 "Test unknown projects in dependent pipeline"
4075 self.init_repo("org/unknown")
4076 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4077 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07004078 A.addApproval('code-review', 2)
4079 B.addApproval('code-review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004080
4081 # A Depends-On: B
4082 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4083 A.subject, B.data['id'])
4084
James E. Blair8b5408c2016-08-08 15:37:46 -07004085 B.addApproval('approved', 1)
4086 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004087 self.waitUntilSettled()
4088
4089 # Unknown projects cannot share a queue with any other
4090 # since they don't have common jobs with any other (they have no jobs).
4091 # Changes which depend on unknown project changes
4092 # should not be processed in dependent pipeline
4093 self.assertEqual(A.data['status'], 'NEW')
4094 self.assertEqual(B.data['status'], 'NEW')
4095 self.assertEqual(A.reported, 0)
4096 self.assertEqual(B.reported, 0)
4097 self.assertEqual(len(self.history), 0)
4098
4099 # Simulate change B being gated outside this layout
James E. Blair8b5408c2016-08-08 15:37:46 -07004100 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004101 B.setMerged()
4102 self.waitUntilSettled()
4103 self.assertEqual(len(self.history), 0)
4104
4105 # Now that B is merged, A should be able to be enqueued and
4106 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07004107 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004108 self.waitUntilSettled()
4109
4110 self.assertEqual(A.data['status'], 'MERGED')
4111 self.assertEqual(A.reported, 2)
4112 self.assertEqual(B.data['status'], 'MERGED')
4113 self.assertEqual(B.reported, 0)
4114
James E. Blairbfb8e042014-12-30 17:01:44 -08004115 def test_crd_check(self):
4116 "Test cross-repo dependencies in independent pipelines"
4117
Paul Belanger174a8272017-03-14 13:20:10 -04004118 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08004119 self.gearman_server.hold_jobs_in_queue = True
4120 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4121 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4122
4123 # A Depends-On: B
4124 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4125 A.subject, B.data['id'])
4126
4127 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4128 self.waitUntilSettled()
4129
4130 queue = self.gearman_server.getQueue()
4131 ref = self.getParameter(queue[-1], 'ZUUL_REF')
4132 self.gearman_server.hold_jobs_in_queue = False
4133 self.gearman_server.release()
4134 self.waitUntilSettled()
4135
Paul Belanger174a8272017-03-14 13:20:10 -04004136 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05004137 self.waitUntilSettled()
4138
Monty Taylord642d852017-02-23 14:05:42 -05004139 path = os.path.join(self.builds[0].jobdir.src_root, "org/project1")
James E. Blairbfb8e042014-12-30 17:01:44 -08004140 repo = git.Repo(path)
4141 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4142 repo_messages.reverse()
Paul Belangerb30342b2016-11-14 12:30:43 -05004143 correct_messages = [
4144 'initial commit', 'add content from fixture', 'A-1']
James E. Blairbfb8e042014-12-30 17:01:44 -08004145 self.assertEqual(repo_messages, correct_messages)
4146
Monty Taylord642d852017-02-23 14:05:42 -05004147 path = os.path.join(self.builds[0].jobdir.src_root, "org/project2")
James E. Blairbfb8e042014-12-30 17:01:44 -08004148 repo = git.Repo(path)
4149 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4150 repo_messages.reverse()
Paul Belangerb30342b2016-11-14 12:30:43 -05004151 correct_messages = [
4152 'initial commit', 'add content from fixture', 'B-1']
James E. Blairbfb8e042014-12-30 17:01:44 -08004153 self.assertEqual(repo_messages, correct_messages)
4154
Paul Belanger174a8272017-03-14 13:20:10 -04004155 self.executor_server.hold_jobs_in_build = False
4156 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05004157 self.waitUntilSettled()
4158
James E. Blairbfb8e042014-12-30 17:01:44 -08004159 self.assertEqual(A.data['status'], 'NEW')
4160 self.assertEqual(B.data['status'], 'NEW')
4161 self.assertEqual(A.reported, 1)
4162 self.assertEqual(B.reported, 0)
4163
4164 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05004165 tenant = self.sched.abide.tenants.get('tenant-one')
4166 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08004167
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004168 def test_crd_check_git_depends(self):
4169 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07004170 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004171 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4172 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4173
4174 # Add two git-dependent changes and make sure they both report
4175 # success.
4176 B.setDependsOn(A, 1)
4177 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4178 self.waitUntilSettled()
4179 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4180 self.waitUntilSettled()
4181
James E. Blairb8c16472015-05-05 14:55:26 -07004182 self.orderedRelease()
4183 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004184 self.waitUntilSettled()
4185
4186 self.assertEqual(A.data['status'], 'NEW')
4187 self.assertEqual(B.data['status'], 'NEW')
4188 self.assertEqual(A.reported, 1)
4189 self.assertEqual(B.reported, 1)
4190
4191 self.assertEqual(self.history[0].changes, '1,1')
4192 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04004193 tenant = self.sched.abide.tenants.get('tenant-one')
4194 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004195
4196 self.assertIn('Build succeeded', A.messages[0])
4197 self.assertIn('Build succeeded', B.messages[0])
4198
4199 def test_crd_check_duplicate(self):
4200 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04004201 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004202 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4203 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04004204 tenant = self.sched.abide.tenants.get('tenant-one')
4205 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004206
4207 # Add two git-dependent changes...
4208 B.setDependsOn(A, 1)
4209 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4210 self.waitUntilSettled()
4211 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4212
4213 # ...make sure the live one is not duplicated...
4214 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4215 self.waitUntilSettled()
4216 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4217
4218 # ...but the non-live one is able to be.
4219 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4220 self.waitUntilSettled()
4221 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4222
Clark Boylandd849822015-03-02 12:38:14 -08004223 # Release jobs in order to avoid races with change A jobs
4224 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07004225 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04004226 self.executor_server.hold_jobs_in_build = False
4227 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004228 self.waitUntilSettled()
4229
4230 self.assertEqual(A.data['status'], 'NEW')
4231 self.assertEqual(B.data['status'], 'NEW')
4232 self.assertEqual(A.reported, 1)
4233 self.assertEqual(B.reported, 1)
4234
4235 self.assertEqual(self.history[0].changes, '1,1 2,1')
4236 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04004237 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004238
4239 self.assertIn('Build succeeded', A.messages[0])
4240 self.assertIn('Build succeeded', B.messages[0])
4241
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004242 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08004243 "Test cross-repo dependencies re-enqueued in independent pipelines"
4244
4245 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004246 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
4247 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08004248
4249 # A Depends-On: B
4250 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4251 A.subject, B.data['id'])
4252
4253 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4254 self.waitUntilSettled()
4255
4256 self.sched.reconfigure(self.config)
4257
4258 # Make sure the items still share a change queue, and the
4259 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05004260 tenant = self.sched.abide.tenants.get('tenant-one')
4261 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
4262 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08004263 first_item = queue.queue[0]
4264 for item in queue.queue:
4265 self.assertEqual(item.queue, first_item.queue)
4266 self.assertFalse(first_item.live)
4267 self.assertTrue(queue.queue[1].live)
4268
4269 self.gearman_server.hold_jobs_in_queue = False
4270 self.gearman_server.release()
4271 self.waitUntilSettled()
4272
4273 self.assertEqual(A.data['status'], 'NEW')
4274 self.assertEqual(B.data['status'], 'NEW')
4275 self.assertEqual(A.reported, 1)
4276 self.assertEqual(B.reported, 0)
4277
4278 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004279 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004280
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004281 def test_crd_check_reconfiguration(self):
4282 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4283
4284 def test_crd_undefined_project(self):
4285 """Test that undefined projects in dependencies are handled for
4286 independent pipelines"""
4287 # It's a hack for fake gerrit,
4288 # as it implies repo creation upon the creation of any change
4289 self.init_repo("org/unknown")
4290 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4291
James E. Blair17dd6772015-02-09 14:45:18 -08004292 def test_crd_check_ignore_dependencies(self):
4293 "Test cross-repo dependencies can be ignored"
Clint Byrum12282ca2017-04-03 11:04:02 -07004294 self.updateConfigLayout('layout-ignore-dependencies')
James E. Blair17dd6772015-02-09 14:45:18 -08004295 self.sched.reconfigure(self.config)
James E. Blair17dd6772015-02-09 14:45:18 -08004296
4297 self.gearman_server.hold_jobs_in_queue = True
4298 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4299 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4300 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4301
4302 # A Depends-On: B
4303 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4304 A.subject, B.data['id'])
4305 # C git-depends on B
4306 C.setDependsOn(B, 1)
4307 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4308 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4309 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4310 self.waitUntilSettled()
4311
4312 # Make sure none of the items share a change queue, and all
4313 # are live.
Clint Byrum12282ca2017-04-03 11:04:02 -07004314 tenant = self.sched.abide.tenants.get('openstack')
4315 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004316 self.assertEqual(len(check_pipeline.queues), 3)
4317 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4318 for item in check_pipeline.getAllItems():
4319 self.assertTrue(item.live)
4320
4321 self.gearman_server.hold_jobs_in_queue = False
4322 self.gearman_server.release()
4323 self.waitUntilSettled()
4324
4325 self.assertEqual(A.data['status'], 'NEW')
4326 self.assertEqual(B.data['status'], 'NEW')
4327 self.assertEqual(C.data['status'], 'NEW')
4328 self.assertEqual(A.reported, 1)
4329 self.assertEqual(B.reported, 1)
4330 self.assertEqual(C.reported, 1)
4331
4332 # Each job should have tested exactly one change
4333 for job in self.history:
4334 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004335
4336 def test_crd_check_transitive(self):
4337 "Test transitive cross-repo dependencies"
4338 # Specifically, if A -> B -> C, and C gets a new patchset and
4339 # A gets a new patchset, ensure the test of A,2 includes B,1
4340 # and C,2 (not C,1 which would indicate stale data in the
4341 # cache for B).
4342 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4343 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4344 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4345
4346 # A Depends-On: B
4347 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4348 A.subject, B.data['id'])
4349
4350 # B Depends-On: C
4351 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4352 B.subject, C.data['id'])
4353
4354 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4355 self.waitUntilSettled()
4356 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4357
4358 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4359 self.waitUntilSettled()
4360 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4361
4362 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4363 self.waitUntilSettled()
4364 self.assertEqual(self.history[-1].changes, '3,1')
4365
4366 C.addPatchset()
4367 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4368 self.waitUntilSettled()
4369 self.assertEqual(self.history[-1].changes, '3,2')
4370
4371 A.addPatchset()
4372 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4373 self.waitUntilSettled()
4374 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004375
James E. Blaira8b90b32016-08-24 15:18:50 -07004376 def test_crd_check_unknown(self):
4377 "Test unknown projects in independent pipeline"
4378 self.init_repo("org/unknown")
4379 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4380 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4381 # A Depends-On: B
4382 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4383 A.subject, B.data['id'])
4384
4385 # Make sure zuul has seen an event on B.
4386 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4387 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4388 self.waitUntilSettled()
4389
4390 self.assertEqual(A.data['status'], 'NEW')
4391 self.assertEqual(A.reported, 1)
4392 self.assertEqual(B.data['status'], 'NEW')
4393 self.assertEqual(B.reported, 0)
4394
James E. Blair92464a22016-04-05 10:21:26 -07004395 def test_crd_cycle_join(self):
4396 "Test an updated change creates a cycle"
4397 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4398
4399 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4400 self.waitUntilSettled()
4401
4402 # Create B->A
4403 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4404 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4405 B.subject, A.data['id'])
4406 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4407 self.waitUntilSettled()
4408
4409 # Update A to add A->B (a cycle).
4410 A.addPatchset()
4411 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4412 A.subject, B.data['id'])
4413 # Normally we would submit the patchset-created event for
4414 # processing here, however, we have no way of noting whether
4415 # the dependency cycle detection correctly raised an
4416 # exception, so instead, we reach into the source driver and
4417 # call the method that would ultimately be called by the event
4418 # processing.
4419
Paul Belanger0e155e22016-11-14 14:12:23 -05004420 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07004421 (trusted, project) = tenant.getProject('org/project')
4422 source = project.source
Paul Belanger0e155e22016-11-14 14:12:23 -05004423
4424 # TODO(pabelanger): As we add more source / trigger APIs we should make
4425 # it easier for users to create events for testing.
4426 event = zuul.model.TriggerEvent()
4427 event.trigger_name = 'gerrit'
4428 event.change_number = '1'
4429 event.patch_number = '2'
James E. Blair92464a22016-04-05 10:21:26 -07004430 with testtools.ExpectedException(
4431 Exception, "Dependency cycle detected"):
Paul Belanger0e155e22016-11-14 14:12:23 -05004432 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004433 self.log.debug("Got expected dependency cycle exception")
4434
4435 # Now if we update B to remove the depends-on, everything
4436 # should be okay. B; A->B
4437
4438 B.addPatchset()
4439 B.data['commitMessage'] = '%s\n' % (B.subject,)
Paul Belanger0e155e22016-11-14 14:12:23 -05004440
4441 source.getChange(event, True)
4442 event.change_number = '2'
4443 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004444
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004445 def test_disable_at(self):
4446 "Test a pipeline will only report to the disabled trigger when failing"
4447
Paul Belanger7dc76e82016-11-11 16:51:08 -05004448 self.updateConfigLayout('layout-disabled-at')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004449 self.sched.reconfigure(self.config)
4450
Paul Belanger7dc76e82016-11-11 16:51:08 -05004451 tenant = self.sched.abide.tenants.get('openstack')
4452 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004453 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004454 0, tenant.layout.pipelines['check']._consecutive_failures)
4455 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004456
4457 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4458 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4459 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4460 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4461 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4462 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4463 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4464 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4465 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4466 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4467 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4468
Paul Belanger174a8272017-03-14 13:20:10 -04004469 self.executor_server.failJob('project-test1', A)
4470 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004471 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004472 self.executor_server.failJob('project-test1', D)
4473 self.executor_server.failJob('project-test1', E)
4474 self.executor_server.failJob('project-test1', F)
4475 self.executor_server.failJob('project-test1', G)
4476 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004477 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004478 self.executor_server.failJob('project-test1', J)
4479 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004480
4481 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4482 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4483 self.waitUntilSettled()
4484
4485 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004486 2, tenant.layout.pipelines['check']._consecutive_failures)
4487 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004488
4489 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4490 self.waitUntilSettled()
4491
4492 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004493 0, tenant.layout.pipelines['check']._consecutive_failures)
4494 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004495
4496 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4497 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4498 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4499 self.waitUntilSettled()
4500
4501 # We should be disabled now
4502 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004503 3, tenant.layout.pipelines['check']._consecutive_failures)
4504 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004505
4506 # We need to wait between each of these patches to make sure the
4507 # smtp messages come back in an expected order
4508 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4509 self.waitUntilSettled()
4510 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4511 self.waitUntilSettled()
4512 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4513 self.waitUntilSettled()
4514
4515 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4516 # leaving a message on each change
4517 self.assertEqual(1, len(A.messages))
4518 self.assertIn('Build failed.', A.messages[0])
4519 self.assertEqual(1, len(B.messages))
4520 self.assertIn('Build failed.', B.messages[0])
4521 self.assertEqual(1, len(C.messages))
4522 self.assertIn('Build succeeded.', C.messages[0])
4523 self.assertEqual(1, len(D.messages))
4524 self.assertIn('Build failed.', D.messages[0])
4525 self.assertEqual(1, len(E.messages))
4526 self.assertIn('Build failed.', E.messages[0])
4527 self.assertEqual(1, len(F.messages))
4528 self.assertIn('Build failed.', F.messages[0])
4529
4530 # The last 3 (GHI) would have only reported via smtp.
4531 self.assertEqual(3, len(self.smtp_messages))
4532 self.assertEqual(0, len(G.messages))
4533 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004534 self.assertIn(
4535 'project-test1 https://server/job', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004536 self.assertEqual(0, len(H.messages))
4537 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004538 self.assertIn(
4539 'project-test1 https://server/job', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004540 self.assertEqual(0, len(I.messages))
4541 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004542 self.assertIn(
4543 'project-test1 https://server/job', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004544
4545 # Now reload the configuration (simulate a HUP) to check the pipeline
4546 # comes out of disabled
4547 self.sched.reconfigure(self.config)
4548
Paul Belanger7dc76e82016-11-11 16:51:08 -05004549 tenant = self.sched.abide.tenants.get('openstack')
4550
4551 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004552 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004553 0, tenant.layout.pipelines['check']._consecutive_failures)
4554 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004555
4556 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4557 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4558 self.waitUntilSettled()
4559
4560 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004561 2, tenant.layout.pipelines['check']._consecutive_failures)
4562 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004563
4564 # J and K went back to gerrit
4565 self.assertEqual(1, len(J.messages))
4566 self.assertIn('Build failed.', J.messages[0])
4567 self.assertEqual(1, len(K.messages))
4568 self.assertIn('Build failed.', K.messages[0])
4569 # No more messages reported via smtp
4570 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004571
Paul Belanger71d98172016-11-08 10:56:31 -05004572 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004573 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004574
Paul Belanger174a8272017-03-14 13:20:10 -04004575 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004576 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4577 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4578 self.waitUntilSettled()
4579
Paul Belanger174a8272017-03-14 13:20:10 -04004580 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004581 self.waitUntilSettled()
4582
4583 self.assertEqual(len(self.builds), 2)
4584 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004585 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004586 self.waitUntilSettled()
4587
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004588 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004589 self.assertEqual(len(self.builds), 1,
4590 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004591 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004592 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004593 self.waitUntilSettled()
4594
Paul Belanger174a8272017-03-14 13:20:10 -04004595 self.executor_server.hold_jobs_in_build = False
4596 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004597 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004598 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004599 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4600 self.assertEqual(A.reported, 1)
4601 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004602
James E. Blair15be0e12017-01-03 13:45:20 -08004603 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004604 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004605
4606 self.fake_nodepool.paused = True
4607 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4608 A.addApproval('code-review', 2)
4609 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4610 self.waitUntilSettled()
4611
4612 self.zk.client.stop()
4613 self.zk.client.start()
4614 self.fake_nodepool.paused = False
4615 self.waitUntilSettled()
4616
4617 self.assertEqual(A.data['status'], 'MERGED')
4618 self.assertEqual(A.reported, 2)
4619
James E. Blair6ab79e02017-01-06 10:10:17 -08004620 def test_nodepool_failure(self):
4621 "Test that jobs are reported after a nodepool failure"
4622
4623 self.fake_nodepool.paused = True
4624 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4625 A.addApproval('code-review', 2)
4626 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4627 self.waitUntilSettled()
4628
4629 req = self.fake_nodepool.getNodeRequests()[0]
4630 self.fake_nodepool.addFailRequest(req)
4631
4632 self.fake_nodepool.paused = False
4633 self.waitUntilSettled()
4634
4635 self.assertEqual(A.data['status'], 'NEW')
4636 self.assertEqual(A.reported, 2)
4637 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4638 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4639 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4640
Arieb6f068c2016-10-09 13:11:06 +03004641
James E. Blaira002b032017-04-18 10:35:48 -07004642class TestExecutor(ZuulTestCase):
4643 tenant_config_file = 'config/single-tenant/main.yaml'
4644
4645 def assertFinalState(self):
4646 # In this test, we expect to shut down in a non-final state,
4647 # so skip these checks.
4648 pass
4649
4650 def assertCleanShutdown(self):
4651 self.log.debug("Assert clean shutdown")
4652
4653 # After shutdown, make sure no jobs are running
4654 self.assertEqual({}, self.executor_server.job_workers)
4655
4656 # Make sure that git.Repo objects have been garbage collected.
4657 repos = []
4658 gc.collect()
4659 for obj in gc.get_objects():
4660 if isinstance(obj, git.Repo):
4661 self.log.debug("Leaked git repo object: %s" % repr(obj))
4662 repos.append(obj)
4663 self.assertEqual(len(repos), 0)
4664
4665 def test_executor_shutdown(self):
4666 "Test that the executor can shut down with jobs running"
4667
4668 self.executor_server.hold_jobs_in_build = True
4669 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4670 A.addApproval('code-review', 2)
4671 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4672 self.waitUntilSettled()
4673
4674
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004675class TestDependencyGraph(ZuulTestCase):
4676 tenant_config_file = 'config/dependency-graph/main.yaml'
4677
4678 def test_dependeny_graph_dispatch_jobs_once(self):
4679 "Test a job in a dependency graph is queued only once"
4680 # Job dependencies, starting with A
4681 # A
4682 # / \
4683 # B C
4684 # / \ / \
4685 # D F E
4686 # |
4687 # G
4688
4689 self.executor_server.hold_jobs_in_build = True
4690 change = self.fake_gerrit.addFakeChange(
4691 'org/project', 'master', 'change')
4692 change.addApproval('code-review', 2)
4693 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4694
4695 self.waitUntilSettled()
4696 self.assertEqual([b.name for b in self.builds], ['A'])
4697
4698 self.executor_server.release('A')
4699 self.waitUntilSettled()
4700 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4701
4702 self.executor_server.release('B')
4703 self.waitUntilSettled()
4704 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4705
4706 self.executor_server.release('D')
4707 self.waitUntilSettled()
4708 self.assertEqual([b.name for b in self.builds], ['C'])
4709
4710 self.executor_server.release('C')
4711 self.waitUntilSettled()
4712 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4713
4714 self.executor_server.release('F')
4715 self.waitUntilSettled()
4716 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4717
4718 self.executor_server.release('G')
4719 self.waitUntilSettled()
4720 self.assertEqual([b.name for b in self.builds], ['E'])
4721
4722 self.executor_server.release('E')
4723 self.waitUntilSettled()
4724 self.assertEqual(len(self.builds), 0)
4725
4726 self.executor_server.hold_jobs_in_build = False
4727 self.executor_server.release()
4728 self.waitUntilSettled()
4729
4730 self.assertEqual(len(self.builds), 0)
4731 self.assertEqual(len(self.history), 7)
4732
4733 self.assertEqual(change.data['status'], 'MERGED')
4734 self.assertEqual(change.reported, 2)
4735
4736 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4737 "Test that a job waits till all dependencies are successful"
4738 # Job dependencies, starting with A
4739 # A
4740 # / \
4741 # B C*
4742 # / \ / \
4743 # D F E
4744 # |
4745 # G
4746
4747 self.executor_server.hold_jobs_in_build = True
4748 change = self.fake_gerrit.addFakeChange(
4749 'org/project', 'master', 'change')
4750 change.addApproval('code-review', 2)
4751
4752 self.executor_server.failJob('C', change)
4753
4754 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4755
4756 self.waitUntilSettled()
4757 self.assertEqual([b.name for b in self.builds], ['A'])
4758
4759 self.executor_server.release('A')
4760 self.waitUntilSettled()
4761 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4762
4763 self.executor_server.release('B')
4764 self.waitUntilSettled()
4765 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4766
4767 self.executor_server.release('D')
4768 self.waitUntilSettled()
4769 self.assertEqual([b.name for b in self.builds], ['C'])
4770
4771 self.executor_server.release('C')
4772 self.waitUntilSettled()
4773 self.assertEqual(len(self.builds), 0)
4774
4775 self.executor_server.hold_jobs_in_build = False
4776 self.executor_server.release()
4777 self.waitUntilSettled()
4778
4779 self.assertEqual(len(self.builds), 0)
4780 self.assertEqual(len(self.history), 4)
4781
4782 self.assertEqual(change.data['status'], 'NEW')
4783 self.assertEqual(change.reported, 2)
4784
4785
Arieb6f068c2016-10-09 13:11:06 +03004786class TestDuplicatePipeline(ZuulTestCase):
4787 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
4788
4789 def test_duplicate_pipelines(self):
4790 "Test that a change matching multiple pipelines works"
4791
4792 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4793 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
4794 self.waitUntilSettled()
4795
4796 self.assertHistory([
4797 dict(name='project-test1', result='SUCCESS', changes='1,1',
4798 pipeline='dup1'),
4799 dict(name='project-test1', result='SUCCESS', changes='1,1',
4800 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05004801 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03004802
4803 self.assertEqual(len(A.messages), 2)
4804
Paul Belangera46a3742016-11-09 14:23:03 -05004805 if 'dup1' in A.messages[0]:
4806 self.assertIn('dup1', A.messages[0])
4807 self.assertNotIn('dup2', A.messages[0])
4808 self.assertIn('project-test1', A.messages[0])
4809 self.assertIn('dup2', A.messages[1])
4810 self.assertNotIn('dup1', A.messages[1])
4811 self.assertIn('project-test1', A.messages[1])
4812 else:
4813 self.assertIn('dup1', A.messages[1])
4814 self.assertNotIn('dup2', A.messages[1])
4815 self.assertIn('project-test1', A.messages[1])
4816 self.assertIn('dup2', A.messages[0])
4817 self.assertNotIn('dup1', A.messages[0])
4818 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04004819
4820
4821class TestSchedulerOneJobProject(ZuulTestCase):
4822 tenant_config_file = 'config/one-job-project/main.yaml'
4823
4824 def test_one_job_project(self):
4825 "Test that queueing works with one job"
4826 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4827 'master', 'A')
4828 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4829 'master', 'B')
4830 A.addApproval('code-review', 2)
4831 B.addApproval('code-review', 2)
4832 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4833 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4834 self.waitUntilSettled()
4835
4836 self.assertEqual(A.data['status'], 'MERGED')
4837 self.assertEqual(A.reported, 2)
4838 self.assertEqual(B.data['status'], 'MERGED')
4839 self.assertEqual(B.reported, 2)
Paul Belanger86085b32016-11-03 12:48:57 -04004840
4841
4842class TestSchedulerTemplatedProject(ZuulTestCase):
4843 tenant_config_file = 'config/templated-project/main.yaml'
4844
Paul Belanger174a8272017-03-14 13:20:10 -04004845 def test_job_from_templates_executed(self):
4846 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04004847
4848 A = self.fake_gerrit.addFakeChange(
4849 'org/templated-project', 'master', 'A')
4850 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4851 self.waitUntilSettled()
4852
4853 self.assertEqual(self.getJobFromHistory('project-test1').result,
4854 'SUCCESS')
4855 self.assertEqual(self.getJobFromHistory('project-test2').result,
4856 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04004857
4858 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004859 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04004860
4861 A = self.fake_gerrit.addFakeChange(
4862 'org/layered-project', 'master', 'A')
4863 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4864 self.waitUntilSettled()
4865
4866 self.assertEqual(self.getJobFromHistory('project-test1').result,
4867 'SUCCESS')
4868 self.assertEqual(self.getJobFromHistory('project-test2').result,
4869 'SUCCESS')
4870 self.assertEqual(self.getJobFromHistory('layered-project-test3'
4871 ).result, 'SUCCESS')
4872 self.assertEqual(self.getJobFromHistory('layered-project-test4'
4873 ).result, 'SUCCESS')
4874 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
4875 ).result, 'SUCCESS')
4876 self.assertEqual(self.getJobFromHistory('project-test6').result,
4877 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08004878
4879
4880class TestSchedulerSuccessURL(ZuulTestCase):
4881 tenant_config_file = 'config/success-url/main.yaml'
4882
4883 def test_success_url(self):
4884 "Ensure bad build params are ignored"
4885 self.sched.reconfigure(self.config)
4886 self.init_repo('org/docs')
4887
4888 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
4889 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4890 self.waitUntilSettled()
4891
4892 # Both builds ran: docs-draft-test + docs-draft-test2
4893 self.assertEqual(len(self.history), 2)
4894
4895 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08004896 for build in self.history:
4897 if build.name == 'docs-draft-test':
4898 uuid = build.uuid[:7]
4899 break
Adam Gandelman94a60062016-11-21 16:43:14 -08004900
4901 # Two msgs: 'Starting...' + results
4902 self.assertEqual(len(self.smtp_messages), 2)
4903 body = self.smtp_messages[1]['body'].splitlines()
4904 self.assertEqual('Build succeeded.', body[0])
4905
4906 self.assertIn(
4907 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
4908 'docs-draft-test/%s/publish-docs/' % uuid,
4909 body[2])
4910
Paul Belanger174a8272017-03-14 13:20:10 -04004911 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08004912 self.assertIn(
4913 '- docs-draft-test2 https://server/job',
4914 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08004915
4916
Adam Gandelman4da00f62016-12-09 15:47:33 -08004917class TestSchedulerMerges(ZuulTestCase):
4918 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08004919
4920 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04004921 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08004922 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04004923 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08004924 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
4925 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
4926 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
4927 A.addApproval('code-review', 2)
4928 B.addApproval('code-review', 2)
4929 C.addApproval('code-review', 2)
4930 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4931 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4932 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4933 self.waitUntilSettled()
4934
4935 build = self.builds[-1]
4936 ref = self.getParameter(build, 'ZUUL_REF')
4937
Monty Taylord642d852017-02-23 14:05:42 -05004938 path = os.path.join(build.jobdir.src_root, project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08004939 repo = git.Repo(path)
4940 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4941 repo_messages.reverse()
4942
Paul Belanger174a8272017-03-14 13:20:10 -04004943 self.executor_server.hold_jobs_in_build = False
4944 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08004945 self.waitUntilSettled()
4946
4947 return repo_messages
4948
4949 def _test_merge(self, mode):
4950 us_path = os.path.join(
4951 self.upstream_root, 'org/project-%s' % mode)
4952 expected_messages = [
4953 'initial commit',
4954 'add content from fixture',
4955 # the intermediate commits order is nondeterministic
4956 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
4957 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
4958 ]
4959 result = self._test_project_merge_mode(mode)
4960 self.assertEqual(result[:2], expected_messages[:2])
4961 self.assertEqual(result[-2:], expected_messages[-2:])
4962
4963 def test_project_merge_mode_merge(self):
4964 self._test_merge('merge')
4965
4966 def test_project_merge_mode_merge_resolve(self):
4967 self._test_merge('merge-resolve')
4968
4969 def test_project_merge_mode_cherrypick(self):
4970 expected_messages = [
4971 'initial commit',
4972 'add content from fixture',
4973 'A-1',
4974 'B-1',
4975 'C-1']
4976 result = self._test_project_merge_mode('cherry-pick')
4977 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08004978
4979 def test_merge_branch(self):
4980 "Test that the right commits are on alternate branches"
4981 self.create_branch('org/project-merge-branches', 'mp')
4982
Paul Belanger174a8272017-03-14 13:20:10 -04004983 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004984 A = self.fake_gerrit.addFakeChange(
4985 'org/project-merge-branches', 'mp', 'A')
4986 B = self.fake_gerrit.addFakeChange(
4987 'org/project-merge-branches', 'mp', 'B')
4988 C = self.fake_gerrit.addFakeChange(
4989 'org/project-merge-branches', 'mp', 'C')
4990 A.addApproval('code-review', 2)
4991 B.addApproval('code-review', 2)
4992 C.addApproval('code-review', 2)
4993 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4994 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4995 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4996 self.waitUntilSettled()
4997
Paul Belanger174a8272017-03-14 13:20:10 -04004998 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004999 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04005000 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005001 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04005002 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005003 self.waitUntilSettled()
5004
5005 build = self.builds[-1]
5006 self.assertEqual(self.getParameter(build, 'ZUUL_BRANCH'), 'mp')
5007 ref = self.getParameter(build, 'ZUUL_REF')
5008 path = os.path.join(
Monty Taylord642d852017-02-23 14:05:42 -05005009 build.jobdir.src_root, 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005010 repo = git.Repo(path)
5011
5012 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
5013 repo_messages.reverse()
5014 correct_messages = [
5015 'initial commit',
5016 'add content from fixture',
5017 'mp commit',
5018 'A-1', 'B-1', 'C-1']
5019 self.assertEqual(repo_messages, correct_messages)
5020
Paul Belanger174a8272017-03-14 13:20:10 -04005021 self.executor_server.hold_jobs_in_build = False
5022 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08005023 self.waitUntilSettled()
5024
5025 def test_merge_multi_branch(self):
5026 "Test that dependent changes on multiple branches are merged"
5027 self.create_branch('org/project-merge-branches', 'mp')
5028
Paul Belanger174a8272017-03-14 13:20:10 -04005029 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08005030 A = self.fake_gerrit.addFakeChange(
5031 'org/project-merge-branches', 'master', 'A')
5032 B = self.fake_gerrit.addFakeChange(
5033 'org/project-merge-branches', 'mp', 'B')
5034 C = self.fake_gerrit.addFakeChange(
5035 'org/project-merge-branches', 'master', 'C')
5036 A.addApproval('code-review', 2)
5037 B.addApproval('code-review', 2)
5038 C.addApproval('code-review', 2)
5039 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
5040 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
5041 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
5042 self.waitUntilSettled()
5043
5044 job_A = None
5045 for job in self.builds:
5046 if 'project-merge' in job.name:
5047 job_A = job
5048 ref_A = self.getParameter(job_A, 'ZUUL_REF')
5049 commit_A = self.getParameter(job_A, 'ZUUL_COMMIT')
5050 self.log.debug("Got Zuul ref for change A: %s" % ref_A)
5051 self.log.debug("Got Zuul commit for change A: %s" % commit_A)
5052
5053 path = os.path.join(
Monty Taylord642d852017-02-23 14:05:42 -05005054 job_A.jobdir.src_root, "org/project-merge-branches")
Adam Gandelman4da00f62016-12-09 15:47:33 -08005055 repo = git.Repo(path)
5056 repo_messages = [c.message.strip()
5057 for c in repo.iter_commits(ref_A)]
5058 repo_messages.reverse()
5059 correct_messages = [
5060 'initial commit', 'add content from fixture', 'A-1']
5061 self.assertEqual(repo_messages, correct_messages)
5062
Paul Belanger174a8272017-03-14 13:20:10 -04005063 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005064 self.waitUntilSettled()
5065
5066 job_B = None
5067 for job in self.builds:
5068 if 'project-merge' in job.name:
5069 job_B = job
5070 ref_B = self.getParameter(job_B, 'ZUUL_REF')
5071 commit_B = self.getParameter(job_B, 'ZUUL_COMMIT')
5072 self.log.debug("Got Zuul ref for change B: %s" % ref_B)
5073 self.log.debug("Got Zuul commit for change B: %s" % commit_B)
5074
5075 path = os.path.join(
Monty Taylord642d852017-02-23 14:05:42 -05005076 job_B.jobdir.src_root, "org/project-merge-branches")
Adam Gandelman4da00f62016-12-09 15:47:33 -08005077 repo = git.Repo(path)
5078 repo_messages = [c.message.strip()
5079 for c in repo.iter_commits(ref_B)]
5080 repo_messages.reverse()
5081 correct_messages = [
5082 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
5083 self.assertEqual(repo_messages, correct_messages)
5084
Paul Belanger174a8272017-03-14 13:20:10 -04005085 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005086 self.waitUntilSettled()
5087
5088 job_C = None
5089 for job in self.builds:
5090 if 'project-merge' in job.name:
5091 job_C = job
5092 ref_C = self.getParameter(job_C, 'ZUUL_REF')
5093 commit_C = self.getParameter(job_C, 'ZUUL_COMMIT')
5094 self.log.debug("Got Zuul ref for change C: %s" % ref_C)
5095 self.log.debug("Got Zuul commit for change C: %s" % commit_C)
5096 path = os.path.join(
Monty Taylord642d852017-02-23 14:05:42 -05005097 job_C.jobdir.src_root, "org/project-merge-branches")
Adam Gandelman4da00f62016-12-09 15:47:33 -08005098 repo = git.Repo(path)
5099 repo_messages = [c.message.strip()
5100 for c in repo.iter_commits(ref_C)]
5101
5102 repo_messages.reverse()
5103 correct_messages = [
5104 'initial commit', 'add content from fixture',
5105 'A-1', 'C-1']
5106 # Ensure the right commits are in the history for this ref
5107 self.assertEqual(repo_messages, correct_messages)
5108
Paul Belanger174a8272017-03-14 13:20:10 -04005109 self.executor_server.hold_jobs_in_build = False
5110 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08005111 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005112
5113
5114class TestSemaphoreMultiTenant(ZuulTestCase):
5115 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5116
5117 def test_semaphore_tenant_isolation(self):
5118 "Test semaphores in multiple tenants"
5119
5120 self.waitUntilSettled()
5121 tenant_one = self.sched.abide.tenants.get('tenant-one')
5122 tenant_two = self.sched.abide.tenants.get('tenant-two')
5123
5124 self.executor_server.hold_jobs_in_build = True
5125 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5126 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5127 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5128 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5129 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5130 self.assertFalse('test-semaphore' in
5131 tenant_one.semaphore_handler.semaphores)
5132 self.assertFalse('test-semaphore' in
5133 tenant_two.semaphore_handler.semaphores)
5134
5135 # add patches to project1 of tenant-one
5136 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5137 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5138 self.waitUntilSettled()
5139
5140 # one build of project1-test1 must run
5141 # semaphore of tenant-one must be acquired once
5142 # semaphore of tenant-two must not be acquired
5143 self.assertEqual(len(self.builds), 1)
5144 self.assertEqual(self.builds[0].name, 'project1-test1')
5145 self.assertTrue('test-semaphore' in
5146 tenant_one.semaphore_handler.semaphores)
5147 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5148 'test-semaphore', [])), 1)
5149 self.assertFalse('test-semaphore' in
5150 tenant_two.semaphore_handler.semaphores)
5151
5152 # add patches to project2 of tenant-two
5153 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5154 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5155 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5156 self.waitUntilSettled()
5157
5158 # one build of project1-test1 must run
5159 # two builds of project2-test1 must run
5160 # semaphore of tenant-one must be acquired once
5161 # semaphore of tenant-two must be acquired twice
5162 self.assertEqual(len(self.builds), 3)
5163 self.assertEqual(self.builds[0].name, 'project1-test1')
5164 self.assertEqual(self.builds[1].name, 'project2-test1')
5165 self.assertEqual(self.builds[2].name, 'project2-test1')
5166 self.assertTrue('test-semaphore' in
5167 tenant_one.semaphore_handler.semaphores)
5168 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5169 'test-semaphore', [])), 1)
5170 self.assertTrue('test-semaphore' in
5171 tenant_two.semaphore_handler.semaphores)
5172 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5173 'test-semaphore', [])), 2)
5174
5175 self.executor_server.release('project1-test1')
5176 self.waitUntilSettled()
5177
5178 # one build of project1-test1 must run
5179 # two builds of project2-test1 must run
5180 # semaphore of tenant-one must be acquired once
5181 # semaphore of tenant-two must be acquired twice
5182 self.assertEqual(len(self.builds), 3)
5183 self.assertEqual(self.builds[0].name, 'project2-test1')
5184 self.assertEqual(self.builds[1].name, 'project2-test1')
5185 self.assertEqual(self.builds[2].name, 'project1-test1')
5186 self.assertTrue('test-semaphore' in
5187 tenant_one.semaphore_handler.semaphores)
5188 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5189 'test-semaphore', [])), 1)
5190 self.assertTrue('test-semaphore' in
5191 tenant_two.semaphore_handler.semaphores)
5192 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5193 'test-semaphore', [])), 2)
5194
5195 self.executor_server.release('project2-test1')
5196 self.waitUntilSettled()
5197
5198 # one build of project1-test1 must run
5199 # one build of project2-test1 must run
5200 # semaphore of tenant-one must be acquired once
5201 # semaphore of tenant-two must be acquired once
5202 self.assertEqual(len(self.builds), 2)
5203 self.assertTrue('test-semaphore' in
5204 tenant_one.semaphore_handler.semaphores)
5205 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5206 'test-semaphore', [])), 1)
5207 self.assertTrue('test-semaphore' in
5208 tenant_two.semaphore_handler.semaphores)
5209 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5210 'test-semaphore', [])), 1)
5211
5212 self.executor_server.hold_jobs_in_build = False
5213 self.executor_server.release()
5214
5215 self.waitUntilSettled()
5216
5217 # no build must run
5218 # semaphore of tenant-one must not be acquired
5219 # semaphore of tenant-two must not be acquired
5220 self.assertEqual(len(self.builds), 0)
5221 self.assertFalse('test-semaphore' in
5222 tenant_one.semaphore_handler.semaphores)
5223 self.assertFalse('test-semaphore' in
5224 tenant_two.semaphore_handler.semaphores)
5225
5226 self.assertEqual(A.reported, 1)
5227 self.assertEqual(B.reported, 1)
5228
5229
5230class TestSemaphoreInRepo(ZuulTestCase):
5231 tenant_config_file = 'config/in-repo/main.yaml'
5232
5233 def test_semaphore_in_repo(self):
5234 "Test semaphores in repo config"
5235
5236 # This tests dynamic semaphore handling in project repos. The semaphore
5237 # max value should not be evaluated dynamically but must be updated
5238 # after the change lands.
5239
5240 self.waitUntilSettled()
5241 tenant = self.sched.abide.tenants.get('tenant-one')
5242
5243 in_repo_conf = textwrap.dedent(
5244 """
5245 - job:
5246 name: project-test2
5247 semaphore: test-semaphore
5248
5249 - project:
5250 name: org/project
5251 tenant-one-gate:
5252 jobs:
5253 - project-test2
5254
5255 # the max value in dynamic layout must be ignored
5256 - semaphore:
5257 name: test-semaphore
5258 max: 2
5259 """)
5260
5261 in_repo_playbook = textwrap.dedent(
5262 """
5263 - hosts: all
5264 tasks: []
5265 """)
5266
5267 file_dict = {'.zuul.yaml': in_repo_conf,
5268 'playbooks/project-test2.yaml': in_repo_playbook}
5269 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5270 files=file_dict)
5271 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5272 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5273 B.setDependsOn(A, 1)
5274 C.setDependsOn(A, 1)
5275
5276 self.executor_server.hold_jobs_in_build = True
5277
5278 A.addApproval('code-review', 2)
5279 B.addApproval('code-review', 2)
5280 C.addApproval('code-review', 2)
5281 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
5282 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
5283 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
5284 self.waitUntilSettled()
5285
5286 # check that the layout in a queue item still has max value of 1
5287 # for test-semaphore
5288 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5289 queue = None
5290 for queue_candidate in pipeline.queues:
5291 if queue_candidate.name == 'org/project':
5292 queue = queue_candidate
5293 break
5294 queue_item = queue.queue[0]
5295 item_dynamic_layout = queue_item.current_build_set.layout
5296 dynamic_test_semaphore = \
5297 item_dynamic_layout.semaphores.get('test-semaphore')
5298 self.assertEqual(dynamic_test_semaphore.max, 1)
5299
5300 # one build must be in queue, one semaphores acquired
5301 self.assertEqual(len(self.builds), 1)
5302 self.assertEqual(self.builds[0].name, 'project-test2')
5303 self.assertTrue('test-semaphore' in
5304 tenant.semaphore_handler.semaphores)
5305 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5306 'test-semaphore', [])), 1)
5307
5308 self.executor_server.release('project-test2')
5309 self.waitUntilSettled()
5310
5311 # change A must be merged
5312 self.assertEqual(A.data['status'], 'MERGED')
5313 self.assertEqual(A.reported, 2)
5314
5315 # send change-merged event as the gerrit mock doesn't send it
5316 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5317 self.waitUntilSettled()
5318
5319 # now that change A was merged, the new semaphore max must be effective
5320 tenant = self.sched.abide.tenants.get('tenant-one')
5321 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5322
5323 # two builds must be in queue, two semaphores acquired
5324 self.assertEqual(len(self.builds), 2)
5325 self.assertEqual(self.builds[0].name, 'project-test2')
5326 self.assertEqual(self.builds[1].name, 'project-test2')
5327 self.assertTrue('test-semaphore' in
5328 tenant.semaphore_handler.semaphores)
5329 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5330 'test-semaphore', [])), 2)
5331
5332 self.executor_server.release('project-test2')
5333 self.waitUntilSettled()
5334
5335 self.assertEqual(len(self.builds), 0)
5336 self.assertFalse('test-semaphore' in
5337 tenant.semaphore_handler.semaphores)
5338
5339 self.executor_server.hold_jobs_in_build = False
5340 self.executor_server.release()
5341
5342 self.waitUntilSettled()
5343 self.assertEqual(len(self.builds), 0)
5344
5345 self.assertEqual(A.reported, 2)
5346 self.assertEqual(B.reported, 2)
5347 self.assertEqual(C.reported, 2)