blob: 48e9ffd4e0e5c3f6ae3259c5c9a2fb6fd29a7c17 [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
Clint Byrum03454a52017-05-26 17:14:02 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Morgan Fainberg293f7f82016-05-30 14:01:22 -070028from six.moves import urllib
Monty Taylorbc758832013-06-17 17:22:42 -040029import testtools
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
James E. Blairb0fcae42012-07-17 11:12:10 -070032import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080033import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040034import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070035
Maru Newby3fe5f852015-01-13 04:22:14 +000036from tests.base import (
Maru Newby3fe5f852015-01-13 04:22:14 +000037 ZuulTestCase,
38 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070039 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000040)
James E. Blairb0fcae42012-07-17 11:12:10 -070041
James E. Blairb0fcae42012-07-17 11:12:10 -070042
Clark Boylanb640e052014-04-03 16:41:46 -070043class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070044 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010045
Paul Belanger174a8272017-03-14 13:20:10 -040046 def test_jobs_executed(self):
47 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070048
James E. Blairb0fcae42012-07-17 11:12:10 -070049 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -070050 A.addApproval('code-review', 2)
51 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070052 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040053 self.assertEqual(self.getJobFromHistory('project-merge').result,
54 'SUCCESS')
55 self.assertEqual(self.getJobFromHistory('project-test1').result,
56 'SUCCESS')
57 self.assertEqual(self.getJobFromHistory('project-test2').result,
58 'SUCCESS')
59 self.assertEqual(A.data['status'], 'MERGED')
60 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070061 self.assertEqual(self.getJobFromHistory('project-test1').node,
62 'image1')
Adam Gandelmaneace4692017-02-07 15:18:36 -080063 self.assertIsNone(self.getJobFromHistory('project-test2').node)
James E. Blairb0fcae42012-07-17 11:12:10 -070064
James E. Blair552b54f2016-07-22 13:55:32 -070065 # TODOv3(jeblair): we may want to report stats by tenant (also?).
James E. Blair66eeebf2013-07-27 17:44:32 -070066 self.assertReportedStat('gerrit.event.comment-added', value='1|c')
67 self.assertReportedStat('zuul.pipeline.gate.current_changes',
68 value='1|g')
69 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
70 kind='ms')
71 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
72 value='1|c')
73 self.assertReportedStat('zuul.pipeline.gate.resident_time', kind='ms')
74 self.assertReportedStat('zuul.pipeline.gate.total_changes',
75 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070076 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070077 'zuul.pipeline.gate.org.project.resident_time', kind='ms')
James E. Blair412e5582013-04-22 15:50:12 -070078 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070079 'zuul.pipeline.gate.org.project.total_changes', value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070080
James E. Blair5821bd92015-09-16 08:48:15 -070081 for build in self.builds:
82 self.assertEqual(build.parameters['ZUUL_VOTING'], '1')
83
James E. Blair3cb10702013-08-24 08:56:03 -070084 def test_initial_pipeline_gauges(self):
85 "Test that each pipeline reported its length on start"
James E. Blair7da51b72016-07-25 15:29:43 -070086 self.assertReportedStat('zuul.pipeline.gate.current_changes',
87 value='0|g')
88 self.assertReportedStat('zuul.pipeline.check.current_changes',
89 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -070090
James E. Blair34776ee2016-08-25 13:53:54 -070091 def test_job_branch(self):
92 "Test the correct variant of a job runs on a branch"
93 self.create_branch('org/project', 'stable')
94 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
95 A.addApproval('code-review', 2)
96 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
97 self.waitUntilSettled()
98 self.assertEqual(self.getJobFromHistory('project-test1').result,
99 'SUCCESS')
100 self.assertEqual(self.getJobFromHistory('project-test2').result,
101 'SUCCESS')
102 self.assertEqual(A.data['status'], 'MERGED')
103 self.assertEqual(A.reported, 2,
104 "A should report start and success")
105 self.assertIn('gate', A.messages[1],
106 "A should transit gate")
107 self.assertEqual(self.getJobFromHistory('project-test1').node,
108 'image2')
109
James E. Blairb0fcae42012-07-17 11:12:10 -0700110 def test_parallel_changes(self):
111 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700112
Paul Belanger174a8272017-03-14 13:20:10 -0400113 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700114 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
115 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
116 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700117 A.addApproval('code-review', 2)
118 B.addApproval('code-review', 2)
119 C.addApproval('code-review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700120
James E. Blair8b5408c2016-08-08 15:37:46 -0700121 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
122 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
123 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700124
125 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400126 self.assertEqual(len(self.builds), 1)
127 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700128 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700129
Paul Belanger174a8272017-03-14 13:20:10 -0400130 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700131 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400132 self.assertEqual(len(self.builds), 3)
133 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700134 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400135 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700136 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400137 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700138 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700139
Paul Belanger174a8272017-03-14 13:20:10 -0400140 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700141 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400142 self.assertEqual(len(self.builds), 5)
143 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700144 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400145 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700146 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700147
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400148 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700149 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400150 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700151 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700152
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400153 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700154 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700155
Paul Belanger174a8272017-03-14 13:20:10 -0400156 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700157 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400158 self.assertEqual(len(self.builds), 6)
159 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700160 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400161 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700162 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700163
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400164 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700165 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400166 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700167 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700168
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400169 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700170 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400171 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700172 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700173
Paul Belanger174a8272017-03-14 13:20:10 -0400174 self.executor_server.hold_jobs_in_build = False
175 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700176 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400177 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700178
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400179 self.assertEqual(len(self.history), 9)
180 self.assertEqual(A.data['status'], 'MERGED')
181 self.assertEqual(B.data['status'], 'MERGED')
182 self.assertEqual(C.data['status'], 'MERGED')
183 self.assertEqual(A.reported, 2)
184 self.assertEqual(B.reported, 2)
185 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700186
187 def test_failed_changes(self):
188 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400189 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700190
James E. Blairb02a3bb2012-07-30 17:49:55 -0700191 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
192 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -0700193 A.addApproval('code-review', 2)
194 B.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700195
Paul Belanger174a8272017-03-14 13:20:10 -0400196 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700197
James E. Blair8b5408c2016-08-08 15:37:46 -0700198 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
199 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700200 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700201 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400202
Paul Belanger174a8272017-03-14 13:20:10 -0400203 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400204 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700205 # A/project-merge is complete
206 self.assertBuilds([
207 dict(name='project-test1', changes='1,1'),
208 dict(name='project-test2', changes='1,1'),
209 dict(name='project-merge', changes='1,1 2,1'),
210 ])
James E. Blaire2819012013-06-28 17:17:26 -0400211
Paul Belanger174a8272017-03-14 13:20:10 -0400212 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400213 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700214 # A/project-merge is complete
215 # B/project-merge is complete
216 self.assertBuilds([
217 dict(name='project-test1', changes='1,1'),
218 dict(name='project-test2', changes='1,1'),
219 dict(name='project-test1', changes='1,1 2,1'),
220 dict(name='project-test2', changes='1,1 2,1'),
221 ])
222
223 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400224 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700225 self.builds[0].release()
226 self.waitUntilSettled()
227
228 self.orderedRelease()
229 self.assertHistory([
230 dict(name='project-merge', result='SUCCESS', changes='1,1'),
231 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
232 dict(name='project-test1', result='FAILURE', changes='1,1'),
233 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
234 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
235 dict(name='project-test2', result='SUCCESS', changes='1,1'),
236 dict(name='project-merge', result='SUCCESS', changes='2,1'),
237 dict(name='project-test1', result='SUCCESS', changes='2,1'),
238 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700239 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700240
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400241 self.assertEqual(A.data['status'], 'NEW')
242 self.assertEqual(B.data['status'], 'MERGED')
243 self.assertEqual(A.reported, 2)
244 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700245
246 def test_independent_queues(self):
247 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700248
Paul Belanger174a8272017-03-14 13:20:10 -0400249 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900250 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700251 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
252 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700253 A.addApproval('code-review', 2)
254 B.addApproval('code-review', 2)
255 C.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700256
James E. Blair8b5408c2016-08-08 15:37:46 -0700257 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800258 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700259
James E. Blairf59f3cf2017-02-19 14:50:26 -0800260 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
261 self.waitUntilSettled()
262
263 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700264 self.waitUntilSettled()
265
266 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700267 self.assertBuilds([
268 dict(name='project-merge', changes='1,1'),
269 dict(name='project-merge', changes='2,1'),
270 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700271
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700272 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700273 self.builds[0].release()
274 self.waitUntilSettled()
275 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700276 self.waitUntilSettled()
277 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400278 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700279 self.waitUntilSettled()
280
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700281 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700282 self.assertBuilds([
283 dict(name='project-test1', changes='1,1'),
284 dict(name='project-test2', changes='1,1'),
285 dict(name='project-test1', changes='2,1'),
286 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500287 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700288 dict(name='project-test1', changes='2,1 3,1'),
289 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800290 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700291 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700292
James E. Blair5f0d49e2016-08-19 09:36:50 -0700293 self.orderedRelease()
294 self.assertHistory([
295 dict(name='project-merge', result='SUCCESS', changes='1,1'),
296 dict(name='project-merge', result='SUCCESS', changes='2,1'),
297 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
298 dict(name='project-test1', result='SUCCESS', changes='1,1'),
299 dict(name='project-test2', result='SUCCESS', changes='1,1'),
300 dict(name='project-test1', result='SUCCESS', changes='2,1'),
301 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500302 dict(
303 name='project1-project2-integration',
304 result='SUCCESS',
305 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700306 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
307 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800308 dict(name='project1-project2-integration',
309 result='SUCCESS',
310 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700311 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700312
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400313 self.assertEqual(A.data['status'], 'MERGED')
314 self.assertEqual(B.data['status'], 'MERGED')
315 self.assertEqual(C.data['status'], 'MERGED')
316 self.assertEqual(A.reported, 2)
317 self.assertEqual(B.reported, 2)
318 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700319
320 def test_failed_change_at_head(self):
321 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700322
Paul Belanger174a8272017-03-14 13:20:10 -0400323 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700324 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
325 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
326 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700327 A.addApproval('code-review', 2)
328 B.addApproval('code-review', 2)
329 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700330
Paul Belanger174a8272017-03-14 13:20:10 -0400331 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700332
James E. Blair8b5408c2016-08-08 15:37:46 -0700333 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
334 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
335 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700336
337 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700338
James E. Blairb536ecc2016-08-31 10:11:42 -0700339 self.assertBuilds([
340 dict(name='project-merge', changes='1,1'),
341 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700342
Paul Belanger174a8272017-03-14 13:20:10 -0400343 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700344 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400345 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700346 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400347 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700348 self.waitUntilSettled()
349
James E. Blairb536ecc2016-08-31 10:11:42 -0700350 self.assertBuilds([
351 dict(name='project-test1', changes='1,1'),
352 dict(name='project-test2', changes='1,1'),
353 dict(name='project-test1', changes='1,1 2,1'),
354 dict(name='project-test2', changes='1,1 2,1'),
355 dict(name='project-test1', changes='1,1 2,1 3,1'),
356 dict(name='project-test2', changes='1,1 2,1 3,1'),
357 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700358
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400359 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700360 self.waitUntilSettled()
361
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400362 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700363 self.assertBuilds([
364 dict(name='project-test2', changes='1,1'),
365 dict(name='project-merge', changes='2,1'),
366 ])
367 # Unordered history comparison because the aborts can finish
368 # in any order.
369 self.assertHistory([
370 dict(name='project-merge', result='SUCCESS',
371 changes='1,1'),
372 dict(name='project-merge', result='SUCCESS',
373 changes='1,1 2,1'),
374 dict(name='project-merge', result='SUCCESS',
375 changes='1,1 2,1 3,1'),
376 dict(name='project-test1', result='FAILURE',
377 changes='1,1'),
378 dict(name='project-test1', result='ABORTED',
379 changes='1,1 2,1'),
380 dict(name='project-test2', result='ABORTED',
381 changes='1,1 2,1'),
382 dict(name='project-test1', result='ABORTED',
383 changes='1,1 2,1 3,1'),
384 dict(name='project-test2', result='ABORTED',
385 changes='1,1 2,1 3,1'),
386 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700387
Paul Belanger174a8272017-03-14 13:20:10 -0400388 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700389 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400390 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700391 self.waitUntilSettled()
392 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700393
James E. Blairb536ecc2016-08-31 10:11:42 -0700394 self.assertBuilds([])
395 self.assertHistory([
396 dict(name='project-merge', result='SUCCESS',
397 changes='1,1'),
398 dict(name='project-merge', result='SUCCESS',
399 changes='1,1 2,1'),
400 dict(name='project-merge', result='SUCCESS',
401 changes='1,1 2,1 3,1'),
402 dict(name='project-test1', result='FAILURE',
403 changes='1,1'),
404 dict(name='project-test1', result='ABORTED',
405 changes='1,1 2,1'),
406 dict(name='project-test2', result='ABORTED',
407 changes='1,1 2,1'),
408 dict(name='project-test1', result='ABORTED',
409 changes='1,1 2,1 3,1'),
410 dict(name='project-test2', result='ABORTED',
411 changes='1,1 2,1 3,1'),
412 dict(name='project-merge', result='SUCCESS',
413 changes='2,1'),
414 dict(name='project-merge', result='SUCCESS',
415 changes='2,1 3,1'),
416 dict(name='project-test2', result='SUCCESS',
417 changes='1,1'),
418 dict(name='project-test1', result='SUCCESS',
419 changes='2,1'),
420 dict(name='project-test2', result='SUCCESS',
421 changes='2,1'),
422 dict(name='project-test1', result='SUCCESS',
423 changes='2,1 3,1'),
424 dict(name='project-test2', result='SUCCESS',
425 changes='2,1 3,1'),
426 ], ordered=False)
427
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400428 self.assertEqual(A.data['status'], 'NEW')
429 self.assertEqual(B.data['status'], 'MERGED')
430 self.assertEqual(C.data['status'], 'MERGED')
431 self.assertEqual(A.reported, 2)
432 self.assertEqual(B.reported, 2)
433 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700434
James E. Blair0aac4872013-08-23 14:02:38 -0700435 def test_failed_change_in_middle(self):
436 "Test a failed change in the middle of the queue"
437
Paul Belanger174a8272017-03-14 13:20:10 -0400438 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700439 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
440 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
441 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700442 A.addApproval('code-review', 2)
443 B.addApproval('code-review', 2)
444 C.addApproval('code-review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700445
Paul Belanger174a8272017-03-14 13:20:10 -0400446 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700447
James E. Blair8b5408c2016-08-08 15:37:46 -0700448 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
449 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
450 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700451
452 self.waitUntilSettled()
453
Paul Belanger174a8272017-03-14 13:20:10 -0400454 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700455 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400456 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700457 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400458 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700459 self.waitUntilSettled()
460
461 self.assertEqual(len(self.builds), 6)
462 self.assertEqual(self.builds[0].name, 'project-test1')
463 self.assertEqual(self.builds[1].name, 'project-test2')
464 self.assertEqual(self.builds[2].name, 'project-test1')
465 self.assertEqual(self.builds[3].name, 'project-test2')
466 self.assertEqual(self.builds[4].name, 'project-test1')
467 self.assertEqual(self.builds[5].name, 'project-test2')
468
469 self.release(self.builds[2])
470 self.waitUntilSettled()
471
James E. Blair972e3c72013-08-29 12:04:55 -0700472 # project-test1 and project-test2 for A
473 # project-test2 for B
474 # project-merge for C (without B)
475 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700476 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
477
Paul Belanger174a8272017-03-14 13:20:10 -0400478 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700479 self.waitUntilSettled()
480
481 # project-test1 and project-test2 for A
482 # project-test2 for B
483 # project-test1 and project-test2 for C
484 self.assertEqual(len(self.builds), 5)
485
Paul Belanger2e2a0492016-10-30 18:33:37 -0400486 tenant = self.sched.abide.tenants.get('tenant-one')
487 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700488 builds = items[0].current_build_set.getBuilds()
489 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
490 self.assertEqual(self.countJobResults(builds, None), 2)
491 builds = items[1].current_build_set.getBuilds()
492 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
493 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
494 self.assertEqual(self.countJobResults(builds, None), 1)
495 builds = items[2].current_build_set.getBuilds()
496 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700497 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700498
Paul Belanger174a8272017-03-14 13:20:10 -0400499 self.executor_server.hold_jobs_in_build = False
500 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700501 self.waitUntilSettled()
502
503 self.assertEqual(len(self.builds), 0)
504 self.assertEqual(len(self.history), 12)
505 self.assertEqual(A.data['status'], 'MERGED')
506 self.assertEqual(B.data['status'], 'NEW')
507 self.assertEqual(C.data['status'], 'MERGED')
508 self.assertEqual(A.reported, 2)
509 self.assertEqual(B.reported, 2)
510 self.assertEqual(C.reported, 2)
511
James E. Blaird466dc42012-07-31 10:42:56 -0700512 def test_failed_change_at_head_with_queue(self):
513 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700514
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700515 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700516 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
517 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
518 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700519 A.addApproval('code-review', 2)
520 B.addApproval('code-review', 2)
521 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700522
Paul Belanger174a8272017-03-14 13:20:10 -0400523 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700524
James E. Blair8b5408c2016-08-08 15:37:46 -0700525 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
526 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
527 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700528
529 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700530 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400531 self.assertEqual(len(self.builds), 0)
532 self.assertEqual(len(queue), 1)
Clint Byrumf322fe22017-05-10 20:53:12 -0700533 self.assertEqual(queue[0].name, b'executor:execute')
534 job_args = json.loads(queue[0].arguments.decode('utf8'))
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800535 self.assertEqual(job_args['job'], 'project-merge')
536 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700537
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700538 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700539 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700540 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700541 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700542 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700543 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700544 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700545
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400546 self.assertEqual(len(self.builds), 0)
547 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800548
549 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700550 json.loads(queue[0].arguments.decode('utf8'))['job'],
551 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800552 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700553 json.loads(queue[1].arguments.decode('utf8'))['job'],
554 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800555 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700556 json.loads(queue[2].arguments.decode('utf8'))['job'],
557 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800558 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700559 json.loads(queue[3].arguments.decode('utf8'))['job'],
560 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800561 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700562 json.loads(queue[4].arguments.decode('utf8'))['job'],
563 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800564 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700565 json.loads(queue[5].arguments.decode('utf8'))['job'],
566 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700567
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700568 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700569 self.waitUntilSettled()
570
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400571 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700572 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400573 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
574 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700575
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700576 self.gearman_server.hold_jobs_in_queue = False
577 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700578 self.waitUntilSettled()
579
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400580 self.assertEqual(len(self.builds), 0)
581 self.assertEqual(len(self.history), 11)
582 self.assertEqual(A.data['status'], 'NEW')
583 self.assertEqual(B.data['status'], 'MERGED')
584 self.assertEqual(C.data['status'], 'MERGED')
585 self.assertEqual(A.reported, 2)
586 self.assertEqual(B.reported, 2)
587 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700588
James E. Blairec056492016-07-22 09:45:56 -0700589 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700590 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400591 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700592 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -0700593 A.addApproval('code-review', 2)
594 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700595 self.waitUntilSettled()
596 time.sleep(2)
597
598 data = json.loads(self.sched.formatStatusJSON())
599 found_job = None
600 for pipeline in data['pipelines']:
601 if pipeline['name'] != 'gate':
602 continue
603 for queue in pipeline['change_queues']:
604 for head in queue['heads']:
605 for item in head:
606 for job in item['jobs']:
607 if job['name'] == 'project-merge':
608 found_job = job
609 break
610
611 self.assertIsNotNone(found_job)
612 if iteration == 1:
613 self.assertIsNotNone(found_job['estimated_time'])
614 self.assertIsNone(found_job['remaining_time'])
615 else:
616 self.assertIsNotNone(found_job['estimated_time'])
617 self.assertTrue(found_job['estimated_time'] >= 2)
618 self.assertIsNotNone(found_job['remaining_time'])
619
Paul Belanger174a8272017-03-14 13:20:10 -0400620 self.executor_server.hold_jobs_in_build = False
621 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700622 self.waitUntilSettled()
623
James E. Blairec056492016-07-22 09:45:56 -0700624 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700625 def test_time_database(self):
626 "Test the time database"
627
628 self._test_time_database(1)
629 self._test_time_database(2)
630
James E. Blairfef71632013-09-23 11:15:47 -0700631 def test_two_failed_changes_at_head(self):
632 "Test that changes are reparented correctly if 2 fail at head"
633
Paul Belanger174a8272017-03-14 13:20:10 -0400634 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700635 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
636 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
637 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700638 A.addApproval('code-review', 2)
639 B.addApproval('code-review', 2)
640 C.addApproval('code-review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700641
Paul Belanger174a8272017-03-14 13:20:10 -0400642 self.executor_server.failJob('project-test1', A)
643 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700644
James E. Blair8b5408c2016-08-08 15:37:46 -0700645 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
646 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
647 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700648 self.waitUntilSettled()
649
Paul Belanger174a8272017-03-14 13:20:10 -0400650 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700651 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400652 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700653 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400654 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700655 self.waitUntilSettled()
656
657 self.assertEqual(len(self.builds), 6)
658 self.assertEqual(self.builds[0].name, 'project-test1')
659 self.assertEqual(self.builds[1].name, 'project-test2')
660 self.assertEqual(self.builds[2].name, 'project-test1')
661 self.assertEqual(self.builds[3].name, 'project-test2')
662 self.assertEqual(self.builds[4].name, 'project-test1')
663 self.assertEqual(self.builds[5].name, 'project-test2')
664
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400665 self.assertTrue(self.builds[0].hasChanges(A))
666 self.assertTrue(self.builds[2].hasChanges(A))
667 self.assertTrue(self.builds[2].hasChanges(B))
668 self.assertTrue(self.builds[4].hasChanges(A))
669 self.assertTrue(self.builds[4].hasChanges(B))
670 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700671
672 # Fail change B first
673 self.release(self.builds[2])
674 self.waitUntilSettled()
675
676 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400677 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700678 self.waitUntilSettled()
679
680 self.assertEqual(len(self.builds), 5)
681 self.assertEqual(self.builds[0].name, 'project-test1')
682 self.assertEqual(self.builds[1].name, 'project-test2')
683 self.assertEqual(self.builds[2].name, 'project-test2')
684 self.assertEqual(self.builds[3].name, 'project-test1')
685 self.assertEqual(self.builds[4].name, 'project-test2')
686
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400687 self.assertTrue(self.builds[1].hasChanges(A))
688 self.assertTrue(self.builds[2].hasChanges(A))
689 self.assertTrue(self.builds[2].hasChanges(B))
690 self.assertTrue(self.builds[4].hasChanges(A))
691 self.assertFalse(self.builds[4].hasChanges(B))
692 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700693
694 # Finish running all passing jobs for change A
695 self.release(self.builds[1])
696 self.waitUntilSettled()
697 # Fail and report change A
698 self.release(self.builds[0])
699 self.waitUntilSettled()
700
701 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400702 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700703 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400704 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700705 self.waitUntilSettled()
706
707 self.assertEqual(len(self.builds), 4)
708 self.assertEqual(self.builds[0].name, 'project-test1') # B
709 self.assertEqual(self.builds[1].name, 'project-test2') # B
710 self.assertEqual(self.builds[2].name, 'project-test1') # C
711 self.assertEqual(self.builds[3].name, 'project-test2') # C
712
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400713 self.assertFalse(self.builds[1].hasChanges(A))
714 self.assertTrue(self.builds[1].hasChanges(B))
715 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700716
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400717 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700718 # After A failed and B and C restarted, B should be back in
719 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400720 self.assertTrue(self.builds[2].hasChanges(B))
721 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700722
Paul Belanger174a8272017-03-14 13:20:10 -0400723 self.executor_server.hold_jobs_in_build = False
724 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700725 self.waitUntilSettled()
726
727 self.assertEqual(len(self.builds), 0)
728 self.assertEqual(len(self.history), 21)
729 self.assertEqual(A.data['status'], 'NEW')
730 self.assertEqual(B.data['status'], 'NEW')
731 self.assertEqual(C.data['status'], 'MERGED')
732 self.assertEqual(A.reported, 2)
733 self.assertEqual(B.reported, 2)
734 self.assertEqual(C.reported, 2)
735
James E. Blair8c803f82012-07-31 16:25:42 -0700736 def test_patch_order(self):
737 "Test that dependent patches are tested in the right order"
738 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
739 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
740 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700741 A.addApproval('code-review', 2)
742 B.addApproval('code-review', 2)
743 C.addApproval('code-review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700744
745 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
746 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
747 M2.setMerged()
748 M1.setMerged()
749
750 # C -> B -> A -> M1 -> M2
751 # M2 is here to make sure it is never queried. If it is, it
752 # means zuul is walking down the entire history of merged
753 # changes.
754
755 C.setDependsOn(B, 1)
756 B.setDependsOn(A, 1)
757 A.setDependsOn(M1, 1)
758 M1.setDependsOn(M2, 1)
759
James E. Blair8b5408c2016-08-08 15:37:46 -0700760 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700761
762 self.waitUntilSettled()
763
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400764 self.assertEqual(A.data['status'], 'NEW')
765 self.assertEqual(B.data['status'], 'NEW')
766 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700767
James E. Blair8b5408c2016-08-08 15:37:46 -0700768 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
769 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700770
771 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400772 self.assertEqual(M2.queried, 0)
773 self.assertEqual(A.data['status'], 'MERGED')
774 self.assertEqual(B.data['status'], 'MERGED')
775 self.assertEqual(C.data['status'], 'MERGED')
776 self.assertEqual(A.reported, 2)
777 self.assertEqual(B.reported, 2)
778 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700779
James E. Blair063672f2015-01-29 13:09:12 -0800780 def test_needed_changes_enqueue(self):
781 "Test that a needed change is enqueued ahead"
782 # A Given a git tree like this, if we enqueue
783 # / \ change C, we should walk up and down the tree
784 # B G and enqueue changes in the order ABCDEFG.
785 # /|\ This is also the order that you would get if
786 # *C E F you enqueued changes in the order ABCDEFG, so
787 # / the ordering is stable across re-enqueue events.
788 # D
789
790 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
791 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
792 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
793 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
794 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
795 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
796 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
797 B.setDependsOn(A, 1)
798 C.setDependsOn(B, 1)
799 D.setDependsOn(C, 1)
800 E.setDependsOn(B, 1)
801 F.setDependsOn(B, 1)
802 G.setDependsOn(A, 1)
803
James E. Blair8b5408c2016-08-08 15:37:46 -0700804 A.addApproval('code-review', 2)
805 B.addApproval('code-review', 2)
806 C.addApproval('code-review', 2)
807 D.addApproval('code-review', 2)
808 E.addApproval('code-review', 2)
809 F.addApproval('code-review', 2)
810 G.addApproval('code-review', 2)
811 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800812
813 self.waitUntilSettled()
814
815 self.assertEqual(A.data['status'], 'NEW')
816 self.assertEqual(B.data['status'], 'NEW')
817 self.assertEqual(C.data['status'], 'NEW')
818 self.assertEqual(D.data['status'], 'NEW')
819 self.assertEqual(E.data['status'], 'NEW')
820 self.assertEqual(F.data['status'], 'NEW')
821 self.assertEqual(G.data['status'], 'NEW')
822
823 # We're about to add approvals to changes without adding the
824 # triggering events to Zuul, so that we can be sure that it is
825 # enqueing the changes based on dependencies, not because of
826 # triggering events. Since it will have the changes cached
827 # already (without approvals), we need to clear the cache
828 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400829 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +1100830 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800831
Paul Belanger174a8272017-03-14 13:20:10 -0400832 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -0700833 A.addApproval('approved', 1)
834 B.addApproval('approved', 1)
835 D.addApproval('approved', 1)
836 E.addApproval('approved', 1)
837 F.addApproval('approved', 1)
838 G.addApproval('approved', 1)
839 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800840
841 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400842 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800843 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400844 self.executor_server.hold_jobs_in_build = False
845 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800846 self.waitUntilSettled()
847
848 self.assertEqual(A.data['status'], 'MERGED')
849 self.assertEqual(B.data['status'], 'MERGED')
850 self.assertEqual(C.data['status'], 'MERGED')
851 self.assertEqual(D.data['status'], 'MERGED')
852 self.assertEqual(E.data['status'], 'MERGED')
853 self.assertEqual(F.data['status'], 'MERGED')
854 self.assertEqual(G.data['status'], 'MERGED')
855 self.assertEqual(A.reported, 2)
856 self.assertEqual(B.reported, 2)
857 self.assertEqual(C.reported, 2)
858 self.assertEqual(D.reported, 2)
859 self.assertEqual(E.reported, 2)
860 self.assertEqual(F.reported, 2)
861 self.assertEqual(G.reported, 2)
862 self.assertEqual(self.history[6].changes,
863 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
864
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100865 def test_source_cache(self):
866 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400867 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700868
869 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
870 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
871 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
James E. Blair8b5408c2016-08-08 15:37:46 -0700872 A.addApproval('code-review', 2)
873 B.addApproval('code-review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700874
875 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
876 M1.setMerged()
877
878 B.setDependsOn(A, 1)
879 A.setDependsOn(M1, 1)
880
James E. Blair8b5408c2016-08-08 15:37:46 -0700881 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700882 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
883
884 self.waitUntilSettled()
885
886 for build in self.builds:
887 if build.parameters['ZUUL_PIPELINE'] == 'check':
888 build.release()
889 self.waitUntilSettled()
890 for build in self.builds:
891 if build.parameters['ZUUL_PIPELINE'] == 'check':
892 build.release()
893 self.waitUntilSettled()
894
James E. Blair8b5408c2016-08-08 15:37:46 -0700895 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700896 self.waitUntilSettled()
897
Joshua Hesketh352264b2015-08-11 23:42:08 +1000898 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700899 # there should still be changes in the cache
Joshua Hesketh352264b2015-08-11 23:42:08 +1000900 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700901
Paul Belanger174a8272017-03-14 13:20:10 -0400902 self.executor_server.hold_jobs_in_build = False
903 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700904 self.waitUntilSettled()
905
906 self.assertEqual(A.data['status'], 'MERGED')
907 self.assertEqual(B.data['status'], 'MERGED')
908 self.assertEqual(A.queried, 2) # Initial and isMerged
909 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
910
James E. Blair8c803f82012-07-31 16:25:42 -0700911 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700912 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700913 # TODO: move to test_gerrit (this is a unit test!)
914 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400915 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700916 (trusted, project) = tenant.getProject('org/project')
917 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400918
919 # TODO(pabelanger): As we add more source / trigger APIs we should make
920 # it easier for users to create events for testing.
921 event = zuul.model.TriggerEvent()
922 event.trigger_name = 'gerrit'
923 event.change_number = '1'
924 event.patch_number = '2'
925
926 a = source.getChange(event)
927 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700928 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700929
James E. Blair8b5408c2016-08-08 15:37:46 -0700930 A.addApproval('code-review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400931 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700932 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700933
James E. Blair8b5408c2016-08-08 15:37:46 -0700934 A.addApproval('approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400935 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700936 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700937
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700938 def test_project_merge_conflict(self):
939 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700940
941 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700942 A = self.fake_gerrit.addFakeChange('org/project',
943 'master', 'A',
944 files={'conflict': 'foo'})
945 B = self.fake_gerrit.addFakeChange('org/project',
946 'master', 'B',
947 files={'conflict': 'bar'})
948 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -0700949 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700950 A.addApproval('code-review', 2)
951 B.addApproval('code-review', 2)
952 C.addApproval('code-review', 2)
953 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
954 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
955 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -0700956 self.waitUntilSettled()
957
James E. Blair6736beb2013-07-11 15:18:15 -0700958 self.assertEqual(A.reported, 1)
James E. Blair6736beb2013-07-11 15:18:15 -0700959 self.assertEqual(C.reported, 1)
960
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700961 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700962 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700963 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700964 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700965 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700966 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -0700967
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700968 self.gearman_server.hold_jobs_in_queue = False
969 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -0700970 self.waitUntilSettled()
971
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400972 self.assertEqual(A.data['status'], 'MERGED')
973 self.assertEqual(B.data['status'], 'NEW')
974 self.assertEqual(C.data['status'], 'MERGED')
975 self.assertEqual(A.reported, 2)
Tobias Henkel9842bd72017-05-16 13:40:03 +0200976 self.assertIn('Merge Failed', B.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400977 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700978
979 self.assertHistory([
980 dict(name='project-merge', result='SUCCESS', changes='1,1'),
981 dict(name='project-test1', result='SUCCESS', changes='1,1'),
982 dict(name='project-test2', result='SUCCESS', changes='1,1'),
983 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
984 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
985 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
986 ], ordered=False)
987
988 def test_delayed_merge_conflict(self):
989 "Test that delayed check merge conflicts are handled properly"
990
991 # Hold jobs in the gearman queue so that we can test whether
James E. Blair1960d682017-04-28 15:44:14 -0700992 # the executor sucesfully merges a change based on an old
993 # repo state (frozen by the scheduler) which would otherwise
994 # conflict.
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700995 self.gearman_server.hold_jobs_in_queue = True
996 A = self.fake_gerrit.addFakeChange('org/project',
997 'master', 'A',
998 files={'conflict': 'foo'})
999 B = self.fake_gerrit.addFakeChange('org/project',
1000 'master', 'B',
1001 files={'conflict': 'bar'})
1002 C = self.fake_gerrit.addFakeChange('org/project',
1003 'master', 'C')
1004 C.setDependsOn(B, 1)
1005
1006 # A enters the gate queue; B and C enter the check queue
1007 A.addApproval('code-review', 2)
1008 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1009 self.waitUntilSettled()
1010 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
James E. Blair8d144dc2017-05-05 10:13:45 -07001011 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001012 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1013 self.waitUntilSettled()
1014
1015 self.assertEqual(A.reported, 1)
1016 self.assertEqual(B.reported, 0) # Check does not report start
1017 self.assertEqual(C.reported, 0) # Check does not report start
1018
1019 # A merges while B and C are queued in check
1020 # Release A project-merge
1021 queue = self.gearman_server.getQueue()
1022 self.release(queue[0])
1023 self.waitUntilSettled()
1024
1025 # Release A project-test*
1026 # gate has higher precedence, so A's test jobs are added in
1027 # front of the merge jobs for B and C
1028 queue = self.gearman_server.getQueue()
1029 self.release(queue[0])
1030 self.release(queue[1])
1031 self.waitUntilSettled()
1032
1033 self.assertEqual(A.data['status'], 'MERGED')
1034 self.assertEqual(B.data['status'], 'NEW')
1035 self.assertEqual(C.data['status'], 'NEW')
1036 self.assertEqual(A.reported, 2)
1037 self.assertEqual(B.reported, 0)
1038 self.assertEqual(C.reported, 0)
1039 self.assertHistory([
1040 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1041 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1042 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1043 ], ordered=False)
1044
1045 # B and C report merge conflicts
1046 # Release B project-merge
1047 queue = self.gearman_server.getQueue()
1048 self.release(queue[0])
1049 self.waitUntilSettled()
1050
1051 # Release C
1052 self.gearman_server.hold_jobs_in_queue = False
1053 self.gearman_server.release()
1054 self.waitUntilSettled()
1055
1056 self.assertEqual(A.data['status'], 'MERGED')
1057 self.assertEqual(B.data['status'], 'NEW')
1058 self.assertEqual(C.data['status'], 'NEW')
1059 self.assertEqual(A.reported, 2)
1060 self.assertEqual(B.reported, 1)
1061 self.assertEqual(C.reported, 1)
1062
1063 self.assertHistory([
1064 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1065 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1066 dict(name='project-test2', result='SUCCESS', changes='1,1'),
James E. Blair1960d682017-04-28 15:44:14 -07001067 dict(name='project-merge', result='SUCCESS', changes='2,1'),
1068 dict(name='project-test1', result='SUCCESS', changes='2,1'),
1069 dict(name='project-test2', result='SUCCESS', changes='2,1'),
1070 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
1071 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
1072 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001073 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001074
James E. Blairdaabed22012-08-15 15:38:57 -07001075 def test_post(self):
1076 "Test that post jobs run"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001077
Zhongyue Luo5d556072012-09-21 02:00:47 +09001078 e = {
1079 "type": "ref-updated",
1080 "submitter": {
1081 "name": "User Name",
1082 },
1083 "refUpdate": {
1084 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1085 "newRev": "d479a0bfcb34da57a31adb2a595c0cf687812543",
1086 "refName": "master",
1087 "project": "org/project",
1088 }
1089 }
James E. Blairdaabed22012-08-15 15:38:57 -07001090 self.fake_gerrit.addEvent(e)
1091 self.waitUntilSettled()
1092
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001093 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001094 self.assertEqual(len(self.history), 1)
1095 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001096
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001097 def test_post_ignore_deletes(self):
1098 "Test that deleting refs does not trigger post jobs"
1099
1100 e = {
1101 "type": "ref-updated",
1102 "submitter": {
1103 "name": "User Name",
1104 },
1105 "refUpdate": {
1106 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1107 "newRev": "0000000000000000000000000000000000000000",
1108 "refName": "master",
1109 "project": "org/project",
1110 }
1111 }
1112 self.fake_gerrit.addEvent(e)
1113 self.waitUntilSettled()
1114
1115 job_names = [x.name for x in self.history]
1116 self.assertEqual(len(self.history), 0)
1117 self.assertNotIn('project-post', job_names)
1118
James E. Blaircc324192017-04-19 14:36:08 -07001119 @simple_layout('layouts/dont-ignore-ref-deletes.yaml')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001120 def test_post_ignore_deletes_negative(self):
1121 "Test that deleting refs does trigger post jobs"
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001122 e = {
1123 "type": "ref-updated",
1124 "submitter": {
1125 "name": "User Name",
1126 },
1127 "refUpdate": {
1128 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1129 "newRev": "0000000000000000000000000000000000000000",
1130 "refName": "master",
1131 "project": "org/project",
1132 }
1133 }
1134 self.fake_gerrit.addEvent(e)
1135 self.waitUntilSettled()
1136
1137 job_names = [x.name for x in self.history]
1138 self.assertEqual(len(self.history), 1)
1139 self.assertIn('project-post', job_names)
1140
James E. Blairec056492016-07-22 09:45:56 -07001141 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001142 def test_build_configuration_branch_interaction(self):
1143 "Test that switching between branches works"
1144 self.test_build_configuration()
1145 self.test_build_configuration_branch()
1146 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001147 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001148 repo = git.Repo(path)
1149 repo.heads.master.commit = repo.commit('init')
1150 self.test_build_configuration()
1151
James E. Blaircaec0c52012-08-22 14:52:22 -07001152 def test_dependent_changes_dequeue(self):
1153 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001154
James E. Blaircaec0c52012-08-22 14:52:22 -07001155 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1156 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1157 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001158 A.addApproval('code-review', 2)
1159 B.addApproval('code-review', 2)
1160 C.addApproval('code-review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001161
1162 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1163 M1.setMerged()
1164
1165 # C -> B -> A -> M1
1166
1167 C.setDependsOn(B, 1)
1168 B.setDependsOn(A, 1)
1169 A.setDependsOn(M1, 1)
1170
Paul Belanger174a8272017-03-14 13:20:10 -04001171 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001172
James E. Blair8b5408c2016-08-08 15:37:46 -07001173 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1174 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1175 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001176
1177 self.waitUntilSettled()
1178
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001179 self.assertEqual(A.data['status'], 'NEW')
1180 self.assertEqual(A.reported, 2)
1181 self.assertEqual(B.data['status'], 'NEW')
1182 self.assertEqual(B.reported, 2)
1183 self.assertEqual(C.data['status'], 'NEW')
1184 self.assertEqual(C.reported, 2)
1185 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001186
James E. Blair972e3c72013-08-29 12:04:55 -07001187 def test_failing_dependent_changes(self):
1188 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001189 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001190 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1191 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1192 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1193 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1194 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
James E. Blair8b5408c2016-08-08 15:37:46 -07001195 A.addApproval('code-review', 2)
1196 B.addApproval('code-review', 2)
1197 C.addApproval('code-review', 2)
1198 D.addApproval('code-review', 2)
1199 E.addApproval('code-review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001200
1201 # E, D -> C -> B, A
1202
1203 D.setDependsOn(C, 1)
1204 C.setDependsOn(B, 1)
1205
Paul Belanger174a8272017-03-14 13:20:10 -04001206 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001207
James E. Blair8b5408c2016-08-08 15:37:46 -07001208 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1209 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
1210 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1211 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1212 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001213
1214 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001215 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001216 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001217 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001218 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001219 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001220 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001221 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001222 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001223 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001224 self.waitUntilSettled()
1225
Paul Belanger174a8272017-03-14 13:20:10 -04001226 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001227 for build in self.builds:
1228 if build.parameters['ZUUL_CHANGE'] != '1':
1229 build.release()
1230 self.waitUntilSettled()
1231
Paul Belanger174a8272017-03-14 13:20:10 -04001232 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001233 self.waitUntilSettled()
1234
1235 self.assertEqual(A.data['status'], 'MERGED')
1236 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001237 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001238 self.assertEqual(B.data['status'], 'NEW')
1239 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001240 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001241 self.assertEqual(C.data['status'], 'NEW')
1242 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001243 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001244 self.assertEqual(D.data['status'], 'NEW')
1245 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001246 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001247 self.assertEqual(E.data['status'], 'MERGED')
1248 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001249 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001250 self.assertEqual(len(self.history), 18)
1251
James E. Blairec590122012-08-22 15:19:31 -07001252 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001253 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001254 # If it's dequeued more than once, we should see extra
1255 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001256
Paul Belanger174a8272017-03-14 13:20:10 -04001257 self.executor_server.hold_jobs_in_build = True
James E. Blair6df67132017-04-19 13:53:20 -07001258 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1259 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1260 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001261 A.addApproval('code-review', 2)
1262 B.addApproval('code-review', 2)
1263 C.addApproval('code-review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001264
Paul Belanger174a8272017-03-14 13:20:10 -04001265 self.executor_server.failJob('project-test1', A)
1266 self.executor_server.failJob('project-test2', A)
James E. Blairec590122012-08-22 15:19:31 -07001267
James E. Blair8b5408c2016-08-08 15:37:46 -07001268 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1269 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1270 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001271
1272 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001273
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001274 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001275 self.assertEqual(self.builds[0].name, 'project-merge')
1276 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001277
Paul Belanger174a8272017-03-14 13:20:10 -04001278 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001279 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001280 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001281 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001282 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001283 self.waitUntilSettled()
1284
James E. Blair6df67132017-04-19 13:53:20 -07001285 self.assertEqual(len(self.builds), 6)
Paul Belanger58bf6912016-11-11 19:36:01 -05001286 self.assertEqual(self.builds[0].name, 'project-test1')
1287 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair6df67132017-04-19 13:53:20 -07001288 self.assertEqual(self.builds[2].name, 'project-test1')
1289 self.assertEqual(self.builds[3].name, 'project-test2')
1290 self.assertEqual(self.builds[4].name, 'project-test1')
1291 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blairec590122012-08-22 15:19:31 -07001292
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001293 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001294 self.waitUntilSettled()
1295
James E. Blair6df67132017-04-19 13:53:20 -07001296 self.assertEqual(len(self.builds), 2) # test2, merge for B
1297 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
James E. Blairec590122012-08-22 15:19:31 -07001298
Paul Belanger174a8272017-03-14 13:20:10 -04001299 self.executor_server.hold_jobs_in_build = False
1300 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001301 self.waitUntilSettled()
1302
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001303 self.assertEqual(len(self.builds), 0)
James E. Blair6df67132017-04-19 13:53:20 -07001304 self.assertEqual(len(self.history), 15)
James E. Blaircaec0c52012-08-22 14:52:22 -07001305
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001306 self.assertEqual(A.data['status'], 'NEW')
1307 self.assertEqual(B.data['status'], 'MERGED')
1308 self.assertEqual(C.data['status'], 'MERGED')
1309 self.assertEqual(A.reported, 2)
1310 self.assertEqual(B.reported, 2)
1311 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001312
James E. Blaircc020532017-04-19 13:04:44 -07001313 @simple_layout('layouts/nonvoting-job.yaml')
James E. Blair4ec821f2012-08-23 15:28:28 -07001314 def test_nonvoting_job(self):
1315 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001316
James E. Blair4ec821f2012-08-23 15:28:28 -07001317 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1318 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001319 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001320 self.executor_server.failJob('nonvoting-project-test2', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07001321 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001322
1323 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001324
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001325 self.assertEqual(A.data['status'], 'MERGED')
1326 self.assertEqual(A.reported, 2)
1327 self.assertEqual(
1328 self.getJobFromHistory('nonvoting-project-merge').result,
1329 'SUCCESS')
1330 self.assertEqual(
1331 self.getJobFromHistory('nonvoting-project-test1').result,
1332 'SUCCESS')
1333 self.assertEqual(
1334 self.getJobFromHistory('nonvoting-project-test2').result,
1335 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001336
James E. Blair5821bd92015-09-16 08:48:15 -07001337 for build in self.builds:
1338 self.assertEqual(build.parameters['ZUUL_VOTING'], '0')
1339
James E. Blaire0487072012-08-29 17:38:31 -07001340 def test_check_queue_success(self):
1341 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001342
James E. Blaire0487072012-08-29 17:38:31 -07001343 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1344 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1345
1346 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001347
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001348 self.assertEqual(A.data['status'], 'NEW')
1349 self.assertEqual(A.reported, 1)
1350 self.assertEqual(self.getJobFromHistory('project-merge').result,
1351 'SUCCESS')
1352 self.assertEqual(self.getJobFromHistory('project-test1').result,
1353 'SUCCESS')
1354 self.assertEqual(self.getJobFromHistory('project-test2').result,
1355 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001356
1357 def test_check_queue_failure(self):
1358 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001359
James E. Blaire0487072012-08-29 17:38:31 -07001360 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001361 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001362 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1363
1364 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001365
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001366 self.assertEqual(A.data['status'], 'NEW')
1367 self.assertEqual(A.reported, 1)
1368 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001369 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001370 self.assertEqual(self.getJobFromHistory('project-test1').result,
1371 'SUCCESS')
1372 self.assertEqual(self.getJobFromHistory('project-test2').result,
1373 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001374
James E. Blair7cb84542017-04-19 13:35:05 -07001375 @simple_layout('layouts/three-projects.yaml')
James E. Blair127bc182012-08-28 15:55:15 -07001376 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001377 # This particular test does a large amount of merges and needs a little
1378 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001379 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001380 "test that dependent changes behind dequeued changes work"
1381 # This complicated test is a reproduction of a real life bug
1382 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001383
Paul Belanger174a8272017-03-14 13:20:10 -04001384 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001385 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1386 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1387 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1388 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1389 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1390 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1391 D.setDependsOn(C, 1)
1392 E.setDependsOn(D, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07001393 A.addApproval('code-review', 2)
1394 B.addApproval('code-review', 2)
1395 C.addApproval('code-review', 2)
1396 D.addApproval('code-review', 2)
1397 E.addApproval('code-review', 2)
1398 F.addApproval('code-review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001399
1400 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001401
1402 # Change object re-use in the gerrit trigger is hidden if
1403 # changes are added in quick succession; waiting makes it more
1404 # like real life.
James E. Blair8b5408c2016-08-08 15:37:46 -07001405 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001406 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001407 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001408 self.waitUntilSettled()
1409
Paul Belanger174a8272017-03-14 13:20:10 -04001410 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001411 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001412 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001413 self.waitUntilSettled()
1414
James E. Blair8b5408c2016-08-08 15:37:46 -07001415 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001416 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001417 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001418 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001419 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001420 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001421 self.fake_gerrit.addEvent(F.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001422 self.waitUntilSettled()
1423
Paul Belanger174a8272017-03-14 13:20:10 -04001424 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001425 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001426 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001427 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001428 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001429 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001430 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001431 self.waitUntilSettled()
1432
1433 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001434
1435 # Grab pointers to the jobs we want to release before
1436 # releasing any, because list indexes may change as
1437 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001438 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001439 a.release()
1440 b.release()
1441 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001442 self.waitUntilSettled()
1443
Paul Belanger174a8272017-03-14 13:20:10 -04001444 self.executor_server.hold_jobs_in_build = False
1445 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001446 self.waitUntilSettled()
1447
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001448 self.assertEqual(A.data['status'], 'NEW')
1449 self.assertEqual(B.data['status'], 'MERGED')
1450 self.assertEqual(C.data['status'], 'MERGED')
1451 self.assertEqual(D.data['status'], 'MERGED')
1452 self.assertEqual(E.data['status'], 'MERGED')
1453 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001454
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001455 self.assertEqual(A.reported, 2)
1456 self.assertEqual(B.reported, 2)
1457 self.assertEqual(C.reported, 2)
1458 self.assertEqual(D.reported, 2)
1459 self.assertEqual(E.reported, 2)
1460 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001461
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001462 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1463 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001464
1465 def test_merger_repack(self):
1466 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001467
James E. Blair05fed602012-09-07 12:45:24 -07001468 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001469 A.addApproval('code-review', 2)
1470 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001471 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001472 self.assertEqual(self.getJobFromHistory('project-merge').result,
1473 'SUCCESS')
1474 self.assertEqual(self.getJobFromHistory('project-test1').result,
1475 'SUCCESS')
1476 self.assertEqual(self.getJobFromHistory('project-test2').result,
1477 'SUCCESS')
1478 self.assertEqual(A.data['status'], 'MERGED')
1479 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001480 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001481 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001482
James E. Blair2a535672017-04-27 12:03:15 -07001483 path = os.path.join(self.merger_src_root, "review.example.com",
1484 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001485 if os.path.exists(path):
1486 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001487 path = os.path.join(self.executor_src_root, "review.example.com",
1488 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001489 if os.path.exists(path):
1490 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001491
1492 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001493 A.addApproval('code-review', 2)
1494 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001495 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001496 self.assertEqual(self.getJobFromHistory('project-merge').result,
1497 'SUCCESS')
1498 self.assertEqual(self.getJobFromHistory('project-test1').result,
1499 'SUCCESS')
1500 self.assertEqual(self.getJobFromHistory('project-test2').result,
1501 'SUCCESS')
1502 self.assertEqual(A.data['status'], 'MERGED')
1503 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001504
James E. Blair4886f282012-11-15 09:27:33 -08001505 def test_merger_repack_large_change(self):
1506 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001507 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001508 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001509 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6df67132017-04-19 13:53:20 -07001510 trusted, project = tenant.getProject('org/project')
James E. Blair0ffa0102017-03-30 13:11:33 -07001511 url = self.fake_gerrit.getGitUrl(project)
James E. Blair8d144dc2017-05-05 10:13:45 -07001512 self.executor_server.merger._addProject('review.example.com',
1513 'org/project', url)
James E. Blair6df67132017-04-19 13:53:20 -07001514 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair4886f282012-11-15 09:27:33 -08001515 A.addPatchset(large=True)
James E. Blair2a535672017-04-27 12:03:15 -07001516 # TODOv3(jeblair): add hostname to upstream root
1517 path = os.path.join(self.upstream_root, 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001518 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001519 path = os.path.join(self.merger_src_root, 'review.example.com',
1520 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001521 if os.path.exists(path):
1522 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001523 path = os.path.join(self.executor_src_root, 'review.example.com',
1524 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001525 if os.path.exists(path):
1526 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001527
James E. Blair8b5408c2016-08-08 15:37:46 -07001528 A.addApproval('code-review', 2)
1529 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001530 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001531 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001532 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001533 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001534 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001535 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001536 'SUCCESS')
1537 self.assertEqual(A.data['status'], 'MERGED')
1538 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001539
James E. Blair2fa50962013-01-30 21:50:41 -08001540 def test_new_patchset_dequeues_old(self):
1541 "Test that a new patchset causes the old to be dequeued"
1542 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001543 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001544 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1545 M.setMerged()
1546
1547 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1548 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1549 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1550 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001551 A.addApproval('code-review', 2)
1552 B.addApproval('code-review', 2)
1553 C.addApproval('code-review', 2)
1554 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001555
1556 C.setDependsOn(B, 1)
1557 B.setDependsOn(A, 1)
1558 A.setDependsOn(M, 1)
1559
James E. Blair8b5408c2016-08-08 15:37:46 -07001560 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1561 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1562 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1563 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001564 self.waitUntilSettled()
1565
1566 B.addPatchset()
1567 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1568 self.waitUntilSettled()
1569
Paul Belanger174a8272017-03-14 13:20:10 -04001570 self.executor_server.hold_jobs_in_build = False
1571 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001572 self.waitUntilSettled()
1573
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001574 self.assertEqual(A.data['status'], 'MERGED')
1575 self.assertEqual(A.reported, 2)
1576 self.assertEqual(B.data['status'], 'NEW')
1577 self.assertEqual(B.reported, 2)
1578 self.assertEqual(C.data['status'], 'NEW')
1579 self.assertEqual(C.reported, 2)
1580 self.assertEqual(D.data['status'], 'MERGED')
1581 self.assertEqual(D.reported, 2)
1582 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001583
James E. Blairba437362015-02-07 11:41:52 -08001584 def test_new_patchset_check(self):
1585 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001586
Paul Belanger174a8272017-03-14 13:20:10 -04001587 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001588
1589 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001590 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001591 tenant = self.sched.abide.tenants.get('tenant-one')
1592 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001593
1594 # Add two git-dependent changes
1595 B.setDependsOn(A, 1)
1596 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1597 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001598 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1599 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001600
1601 # A live item, and a non-live/live pair
1602 items = check_pipeline.getAllItems()
1603 self.assertEqual(len(items), 3)
1604
1605 self.assertEqual(items[0].change.number, '1')
1606 self.assertEqual(items[0].change.patchset, '1')
1607 self.assertFalse(items[0].live)
1608
1609 self.assertEqual(items[1].change.number, '2')
1610 self.assertEqual(items[1].change.patchset, '1')
1611 self.assertTrue(items[1].live)
1612
1613 self.assertEqual(items[2].change.number, '1')
1614 self.assertEqual(items[2].change.patchset, '1')
1615 self.assertTrue(items[2].live)
1616
1617 # Add a new patchset to A
1618 A.addPatchset()
1619 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1620 self.waitUntilSettled()
1621
1622 # The live copy of A,1 should be gone, but the non-live and B
1623 # should continue, and we should have a new A,2
1624 items = check_pipeline.getAllItems()
1625 self.assertEqual(len(items), 3)
1626
1627 self.assertEqual(items[0].change.number, '1')
1628 self.assertEqual(items[0].change.patchset, '1')
1629 self.assertFalse(items[0].live)
1630
1631 self.assertEqual(items[1].change.number, '2')
1632 self.assertEqual(items[1].change.patchset, '1')
1633 self.assertTrue(items[1].live)
1634
1635 self.assertEqual(items[2].change.number, '1')
1636 self.assertEqual(items[2].change.patchset, '2')
1637 self.assertTrue(items[2].live)
1638
1639 # Add a new patchset to B
1640 B.addPatchset()
1641 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1642 self.waitUntilSettled()
1643
1644 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1645 # but we should have a new B,2 (still based on A,1)
1646 items = check_pipeline.getAllItems()
1647 self.assertEqual(len(items), 3)
1648
1649 self.assertEqual(items[0].change.number, '1')
1650 self.assertEqual(items[0].change.patchset, '2')
1651 self.assertTrue(items[0].live)
1652
1653 self.assertEqual(items[1].change.number, '1')
1654 self.assertEqual(items[1].change.patchset, '1')
1655 self.assertFalse(items[1].live)
1656
1657 self.assertEqual(items[2].change.number, '2')
1658 self.assertEqual(items[2].change.patchset, '2')
1659 self.assertTrue(items[2].live)
1660
1661 self.builds[0].release()
1662 self.waitUntilSettled()
1663 self.builds[0].release()
1664 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001665 self.executor_server.hold_jobs_in_build = False
1666 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001667 self.waitUntilSettled()
1668
1669 self.assertEqual(A.reported, 1)
1670 self.assertEqual(B.reported, 1)
1671 self.assertEqual(self.history[0].result, 'ABORTED')
1672 self.assertEqual(self.history[0].changes, '1,1')
1673 self.assertEqual(self.history[1].result, 'ABORTED')
1674 self.assertEqual(self.history[1].changes, '1,1 2,1')
1675 self.assertEqual(self.history[2].result, 'SUCCESS')
1676 self.assertEqual(self.history[2].changes, '1,2')
1677 self.assertEqual(self.history[3].result, 'SUCCESS')
1678 self.assertEqual(self.history[3].changes, '1,1 2,2')
1679
1680 def test_abandoned_gate(self):
1681 "Test that an abandoned change is dequeued from gate"
1682
Paul Belanger174a8272017-03-14 13:20:10 -04001683 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001684
1685 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001686 A.addApproval('code-review', 2)
1687 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001688 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001689 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1690 self.assertEqual(self.builds[0].name, 'project-merge')
1691
1692 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1693 self.waitUntilSettled()
1694
Paul Belanger174a8272017-03-14 13:20:10 -04001695 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001696 self.waitUntilSettled()
1697
Arie5b4048c2016-10-05 16:12:06 +03001698 self.assertBuilds([])
1699 self.assertHistory([
1700 dict(name='project-merge', result='ABORTED', changes='1,1')],
1701 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001702 self.assertEqual(A.reported, 1,
1703 "Abandoned gate change should report only start")
1704
1705 def test_abandoned_check(self):
1706 "Test that an abandoned change is dequeued from check"
1707
Paul Belanger174a8272017-03-14 13:20:10 -04001708 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001709
1710 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1711 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001712 tenant = self.sched.abide.tenants.get('tenant-one')
1713 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001714
1715 # Add two git-dependent changes
1716 B.setDependsOn(A, 1)
1717 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1718 self.waitUntilSettled()
1719 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1720 self.waitUntilSettled()
1721 # A live item, and a non-live/live pair
1722 items = check_pipeline.getAllItems()
1723 self.assertEqual(len(items), 3)
1724
1725 self.assertEqual(items[0].change.number, '1')
1726 self.assertFalse(items[0].live)
1727
1728 self.assertEqual(items[1].change.number, '2')
1729 self.assertTrue(items[1].live)
1730
1731 self.assertEqual(items[2].change.number, '1')
1732 self.assertTrue(items[2].live)
1733
1734 # Abandon A
1735 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1736 self.waitUntilSettled()
1737
1738 # The live copy of A should be gone, but the non-live and B
1739 # should continue
1740 items = check_pipeline.getAllItems()
1741 self.assertEqual(len(items), 2)
1742
1743 self.assertEqual(items[0].change.number, '1')
1744 self.assertFalse(items[0].live)
1745
1746 self.assertEqual(items[1].change.number, '2')
1747 self.assertTrue(items[1].live)
1748
Paul Belanger174a8272017-03-14 13:20:10 -04001749 self.executor_server.hold_jobs_in_build = False
1750 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001751 self.waitUntilSettled()
1752
1753 self.assertEqual(len(self.history), 4)
1754 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001755 'Build should have been aborted')
1756 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001757 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001758
Steve Varnau7b78b312015-04-03 14:49:46 -07001759 def test_abandoned_not_timer(self):
1760 "Test that an abandoned change does not cancel timer jobs"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001761 # This test can not use simple_layout because it must start
1762 # with a configuration which does not include a
1763 # timer-triggered job so that we have an opportunity to set
1764 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04001765 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001766 # Start timer trigger - also org/project
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001767 self.commitConfigUpdate('common-config', 'layouts/idle.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001768 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001769 # The pipeline triggers every second, so we should have seen
1770 # several by now.
1771 time.sleep(5)
1772 self.waitUntilSettled()
1773 # Stop queuing timer triggered jobs so that the assertions
1774 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001775 # Must be in same repo, so overwrite config with another one
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001776 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001777 self.sched.reconfigure(self.config)
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001778
Steve Varnau7b78b312015-04-03 14:49:46 -07001779 self.assertEqual(len(self.builds), 2, "Two timer jobs")
1780
1781 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1782 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1783 self.waitUntilSettled()
1784 self.assertEqual(len(self.builds), 3, "One change plus two timer jobs")
1785
1786 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1787 self.waitUntilSettled()
1788
1789 self.assertEqual(len(self.builds), 2, "Two timer jobs remain")
1790
Paul Belanger174a8272017-03-14 13:20:10 -04001791 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001792 self.waitUntilSettled()
1793
Arx Cruzb1b010d2013-10-28 19:49:59 -02001794 def test_zuul_url_return(self):
1795 "Test if ZUUL_URL is returning when zuul_url is set in zuul.conf"
James E. Blair4076e2b2014-01-28 12:42:20 -08001796 self.assertTrue(self.sched.config.has_option('merger', 'zuul_url'))
Paul Belanger174a8272017-03-14 13:20:10 -04001797 self.executor_server.hold_jobs_in_build = True
Arx Cruzb1b010d2013-10-28 19:49:59 -02001798
1799 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001800 A.addApproval('code-review', 2)
1801 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Arx Cruzb1b010d2013-10-28 19:49:59 -02001802 self.waitUntilSettled()
1803
1804 self.assertEqual(len(self.builds), 1)
1805 for build in self.builds:
1806 self.assertTrue('ZUUL_URL' in build.parameters)
1807
Paul Belanger174a8272017-03-14 13:20:10 -04001808 self.executor_server.hold_jobs_in_build = False
1809 self.executor_server.release()
Arx Cruzb1b010d2013-10-28 19:49:59 -02001810 self.waitUntilSettled()
1811
James E. Blair2fa50962013-01-30 21:50:41 -08001812 def test_new_patchset_dequeues_old_on_head(self):
1813 "Test that a new patchset causes the old to be dequeued (at head)"
1814 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001815 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001816 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1817 M.setMerged()
1818 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1819 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1820 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1821 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001822 A.addApproval('code-review', 2)
1823 B.addApproval('code-review', 2)
1824 C.addApproval('code-review', 2)
1825 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001826
1827 C.setDependsOn(B, 1)
1828 B.setDependsOn(A, 1)
1829 A.setDependsOn(M, 1)
1830
James E. Blair8b5408c2016-08-08 15:37:46 -07001831 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1832 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1833 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1834 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001835 self.waitUntilSettled()
1836
1837 A.addPatchset()
1838 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1839 self.waitUntilSettled()
1840
Paul Belanger174a8272017-03-14 13:20:10 -04001841 self.executor_server.hold_jobs_in_build = False
1842 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001843 self.waitUntilSettled()
1844
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001845 self.assertEqual(A.data['status'], 'NEW')
1846 self.assertEqual(A.reported, 2)
1847 self.assertEqual(B.data['status'], 'NEW')
1848 self.assertEqual(B.reported, 2)
1849 self.assertEqual(C.data['status'], 'NEW')
1850 self.assertEqual(C.reported, 2)
1851 self.assertEqual(D.data['status'], 'MERGED')
1852 self.assertEqual(D.reported, 2)
1853 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08001854
1855 def test_new_patchset_dequeues_old_without_dependents(self):
1856 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04001857 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001858 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1859 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1860 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001861 A.addApproval('code-review', 2)
1862 B.addApproval('code-review', 2)
1863 C.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001864
James E. Blair8b5408c2016-08-08 15:37:46 -07001865 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1866 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1867 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001868 self.waitUntilSettled()
1869
1870 B.addPatchset()
1871 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1872 self.waitUntilSettled()
1873
Paul Belanger174a8272017-03-14 13:20:10 -04001874 self.executor_server.hold_jobs_in_build = False
1875 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001876 self.waitUntilSettled()
1877
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001878 self.assertEqual(A.data['status'], 'MERGED')
1879 self.assertEqual(A.reported, 2)
1880 self.assertEqual(B.data['status'], 'NEW')
1881 self.assertEqual(B.reported, 2)
1882 self.assertEqual(C.data['status'], 'MERGED')
1883 self.assertEqual(C.reported, 2)
1884 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08001885
1886 def test_new_patchset_dequeues_old_independent_queue(self):
1887 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04001888 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001889 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1890 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1891 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1892 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1893 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1894 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1895 self.waitUntilSettled()
1896
1897 B.addPatchset()
1898 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1899 self.waitUntilSettled()
1900
Paul Belanger174a8272017-03-14 13:20:10 -04001901 self.executor_server.hold_jobs_in_build = False
1902 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001903 self.waitUntilSettled()
1904
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001905 self.assertEqual(A.data['status'], 'NEW')
1906 self.assertEqual(A.reported, 1)
1907 self.assertEqual(B.data['status'], 'NEW')
1908 self.assertEqual(B.reported, 1)
1909 self.assertEqual(C.data['status'], 'NEW')
1910 self.assertEqual(C.reported, 1)
1911 self.assertEqual(len(self.history), 10)
1912 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001913
James E. Blaircc020532017-04-19 13:04:44 -07001914 @simple_layout('layouts/noop-job.yaml')
James E. Blair18c64442014-03-18 10:14:45 -07001915 def test_noop_job(self):
1916 "Test that the internal noop job works"
1917 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001918 A.addApproval('code-review', 2)
1919 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07001920 self.waitUntilSettled()
1921
1922 self.assertEqual(len(self.gearman_server.getQueue()), 0)
1923 self.assertTrue(self.sched._areAllBuildsComplete())
1924 self.assertEqual(len(self.history), 0)
1925 self.assertEqual(A.data['status'], 'MERGED')
1926 self.assertEqual(A.reported, 2)
1927
James E. Blair06cc3922017-04-19 10:08:10 -07001928 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001929 def test_no_job_project(self):
1930 "Test that reports with no jobs don't get sent"
1931 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
1932 'master', 'A')
1933 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1934 self.waitUntilSettled()
1935
1936 # Change wasn't reported to
1937 self.assertEqual(A.reported, False)
1938
1939 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08001940 tenant = self.sched.abide.tenants.get('tenant-one')
1941 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001942 items = check_pipeline.getAllItems()
1943 self.assertEqual(len(items), 0)
1944
1945 self.assertEqual(len(self.history), 0)
1946
James E. Blair7d0dedc2013-02-21 17:26:09 -08001947 def test_zuul_refs(self):
1948 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04001949 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08001950 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
1951 M1.setMerged()
1952 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
1953 M2.setMerged()
1954
1955 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1956 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1957 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1958 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001959 A.addApproval('code-review', 2)
1960 B.addApproval('code-review', 2)
1961 C.addApproval('code-review', 2)
1962 D.addApproval('code-review', 2)
1963 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1964 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1965 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1966 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001967
1968 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001969 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001970 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001971 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001972 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001973 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001974 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001975 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001976 self.waitUntilSettled()
1977
James E. Blair7d0dedc2013-02-21 17:26:09 -08001978 a_zref = b_zref = c_zref = d_zref = None
Clint Byrum3343e3e2016-11-15 16:05:03 -08001979 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001980 for x in self.builds:
James E. Blair7d0dedc2013-02-21 17:26:09 -08001981 if x.parameters['ZUUL_CHANGE'] == '3':
1982 a_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001983 a_build = x
1984 elif x.parameters['ZUUL_CHANGE'] == '4':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001985 b_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001986 b_build = x
1987 elif x.parameters['ZUUL_CHANGE'] == '5':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001988 c_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001989 c_build = x
1990 elif x.parameters['ZUUL_CHANGE'] == '6':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001991 d_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001992 d_build = x
1993 if a_build and b_build and c_build and d_build:
1994 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08001995
1996 # There are... four... refs.
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001997 self.assertIsNotNone(a_zref)
1998 self.assertIsNotNone(b_zref)
1999 self.assertIsNotNone(c_zref)
2000 self.assertIsNotNone(d_zref)
James E. Blair7d0dedc2013-02-21 17:26:09 -08002001
2002 # And they should all be different
2003 refs = set([a_zref, b_zref, c_zref, d_zref])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002004 self.assertEqual(len(refs), 4)
James E. Blair7d0dedc2013-02-21 17:26:09 -08002005
Clint Byrum3343e3e2016-11-15 16:05:03 -08002006 # should have a, not b, and should not be in project2
2007 self.assertTrue(a_build.hasChanges(A))
2008 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002009
Clint Byrum3343e3e2016-11-15 16:05:03 -08002010 # should have a and b, and should not be in project2
2011 self.assertTrue(b_build.hasChanges(A, B))
2012 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002013
Clint Byrum3343e3e2016-11-15 16:05:03 -08002014 # should have a and b in 1, c in 2
2015 self.assertTrue(c_build.hasChanges(A, B, C))
2016 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002017
Clint Byrum3343e3e2016-11-15 16:05:03 -08002018 # should have a and b in 1, c and d in 2
2019 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002020
Paul Belanger174a8272017-03-14 13:20:10 -04002021 self.executor_server.hold_jobs_in_build = False
2022 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002023 self.waitUntilSettled()
2024
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002025 self.assertEqual(A.data['status'], 'MERGED')
2026 self.assertEqual(A.reported, 2)
2027 self.assertEqual(B.data['status'], 'MERGED')
2028 self.assertEqual(B.reported, 2)
2029 self.assertEqual(C.data['status'], 'MERGED')
2030 self.assertEqual(C.reported, 2)
2031 self.assertEqual(D.data['status'], 'MERGED')
2032 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002033
James E. Blair4a28a882013-08-23 15:17:33 -07002034 def test_rerun_on_error(self):
2035 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002036 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002037 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002038 A.addApproval('code-review', 2)
2039 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002040 self.waitUntilSettled()
2041
James E. Blair412fba82017-01-26 15:00:50 -08002042 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002043 self.executor_server.hold_jobs_in_build = False
2044 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002045 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002046 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002047 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2048
James E. Blair412e5582013-04-22 15:50:12 -07002049 def test_statsd(self):
2050 "Test each of the statsd methods used in the scheduler"
2051 import extras
2052 statsd = extras.try_import('statsd.statsd')
2053 statsd.incr('test-incr')
2054 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002055 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002056 self.assertReportedStat('test-incr', '1|c')
2057 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002058 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002059
James E. Blairdad52252014-02-07 16:59:17 -08002060 def test_stuck_job_cleanup(self):
2061 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002062
2063 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002064 self.gearman_server.hold_jobs_in_queue = True
2065 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002066 A.addApproval('code-review', 2)
2067 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002068 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002069 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002070 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2071
James E. Blair31cb3e82017-04-20 13:08:56 -07002072 self.commitConfigUpdate('common-config', 'layouts/no-jobs.yaml')
James E. Blairdad52252014-02-07 16:59:17 -08002073 self.sched.reconfigure(self.config)
2074 self.waitUntilSettled()
2075
James E. Blair18c64442014-03-18 10:14:45 -07002076 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002077 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002078 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002079 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2080 self.assertTrue(self.sched._areAllBuildsComplete())
2081
2082 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002083 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002084 self.assertEqual(self.history[0].result, 'SUCCESS')
2085
James E. Blair879dafb2015-07-17 14:04:49 -07002086 def test_file_head(self):
2087 # This is a regression test for an observed bug. A change
2088 # with a file named "HEAD" in the root directory of the repo
2089 # was processed by a merger. It then was unable to reset the
2090 # repo because of:
2091 # GitCommandError: 'git reset --hard HEAD' returned
2092 # with exit code 128
2093 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2094 # and filename
2095 # Use '--' to separate filenames from revisions'
2096
2097 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002098 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002099 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2100
2101 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2102 self.waitUntilSettled()
2103
2104 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2105 self.waitUntilSettled()
2106
2107 self.assertIn('Build succeeded', A.messages[0])
2108 self.assertIn('Build succeeded', B.messages[0])
2109
James E. Blair70c71582013-03-06 08:50:50 -08002110 def test_file_jobs(self):
2111 "Test that file jobs run only when appropriate"
2112 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002113 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002114 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07002115 A.addApproval('code-review', 2)
2116 B.addApproval('code-review', 2)
2117 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2118 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002119 self.waitUntilSettled()
2120
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002121 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002122 if x.name == 'project-testfile']
2123
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002124 self.assertEqual(len(testfile_jobs), 1)
2125 self.assertEqual(testfile_jobs[0].changes, '1,2')
2126 self.assertEqual(A.data['status'], 'MERGED')
2127 self.assertEqual(A.reported, 2)
2128 self.assertEqual(B.data['status'], 'MERGED')
2129 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002130
Clint Byrum3ee39f32016-11-17 23:45:07 -08002131 def _test_irrelevant_files_jobs(self, should_skip):
2132 "Test that jobs with irrelevant-files filter run only when appropriate"
Clint Byrum3ee39f32016-11-17 23:45:07 -08002133 if should_skip:
2134 files = {'ignoreme': 'ignored\n'}
2135 else:
2136 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002137
2138 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002139 'master',
2140 'test irrelevant-files',
2141 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002142 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2143 self.waitUntilSettled()
2144
2145 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002146 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002147
2148 if should_skip:
2149 self.assertEqual([], tested_change_ids)
2150 else:
2151 self.assertIn(change.data['number'], tested_change_ids)
2152
James E. Blaircc324192017-04-19 14:36:08 -07002153 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002154 def test_irrelevant_files_match_skips_job(self):
2155 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002156
James E. Blaircc324192017-04-19 14:36:08 -07002157 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002158 def test_irrelevant_files_no_match_runs_job(self):
2159 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002160
James E. Blaircc324192017-04-19 14:36:08 -07002161 @simple_layout('layouts/inheritance.yaml')
Clint Byrum85493602016-11-18 11:59:47 -08002162 def test_inherited_jobs_keep_matchers(self):
Clint Byrum85493602016-11-18 11:59:47 -08002163 files = {'ignoreme': 'ignored\n'}
2164
2165 change = self.fake_gerrit.addFakeChange('org/project',
2166 'master',
2167 'test irrelevant-files',
2168 files=files)
2169 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2170 self.waitUntilSettled()
2171
2172 run_jobs = set([build.name for build in self.history])
2173
2174 self.assertEqual(set(['project-test-nomatch-starts-empty',
2175 'project-test-nomatch-starts-full']), run_jobs)
2176
James E. Blairc8a1e052014-02-25 09:29:26 -08002177 def test_queue_names(self):
2178 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002179 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002180 (trusted, project1) = tenant.getProject('org/project1')
2181 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002182 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2183 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2184 self.assertEqual(q1.name, 'integrated')
2185 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002186
James E. Blair64ed6f22013-07-10 14:07:23 -07002187 def test_queue_precedence(self):
2188 "Test that queue precedence works"
2189
2190 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002191 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002192 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2193 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
James E. Blair8b5408c2016-08-08 15:37:46 -07002194 A.addApproval('code-review', 2)
2195 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002196
2197 self.waitUntilSettled()
2198 self.gearman_server.hold_jobs_in_queue = False
2199 self.gearman_server.release()
2200 self.waitUntilSettled()
2201
James E. Blair8de58bd2013-07-18 16:23:33 -07002202 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002203 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002204 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002205 self.waitUntilSettled()
2206
James E. Blair64ed6f22013-07-10 14:07:23 -07002207 self.log.debug(self.history)
2208 self.assertEqual(self.history[0].pipeline, 'gate')
2209 self.assertEqual(self.history[1].pipeline, 'check')
2210 self.assertEqual(self.history[2].pipeline, 'gate')
2211 self.assertEqual(self.history[3].pipeline, 'gate')
2212 self.assertEqual(self.history[4].pipeline, 'check')
2213 self.assertEqual(self.history[5].pipeline, 'check')
2214
Clark Boylana5edbe42014-06-03 16:39:10 -07002215 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002216 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002217 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002218 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002219 A.addApproval('code-review', 2)
2220 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002221 self.waitUntilSettled()
2222
Paul Belanger174a8272017-03-14 13:20:10 -04002223 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002224 self.waitUntilSettled()
2225
James E. Blair1843a552013-07-03 14:19:52 -07002226 port = self.webapp.server.socket.getsockname()[1]
2227
Adam Gandelman77a12c72017-02-03 17:43:43 -08002228 req = urllib.request.Request(
2229 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002230 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002231 headers = f.info()
2232 self.assertIn('Content-Length', headers)
2233 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002234 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2235 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002236 self.assertIn('Access-Control-Allow-Origin', headers)
2237 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002238 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002239 self.assertIn('Expires', headers)
Clint Byrumf322fe22017-05-10 20:53:12 -07002240 data = f.read().decode('utf8')
James E. Blair1843a552013-07-03 14:19:52 -07002241
Paul Belanger174a8272017-03-14 13:20:10 -04002242 self.executor_server.hold_jobs_in_build = False
2243 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002244 self.waitUntilSettled()
2245
2246 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002247 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002248 for p in data['pipelines']:
2249 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002250 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002251 self.assertEqual(q['window'], 20)
2252 else:
2253 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002254 for head in q['heads']:
2255 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002256 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002257 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002258 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002259 status_jobs.append(job)
2260 self.assertEqual('project-merge', status_jobs[0]['name'])
2261 self.assertEqual('https://server/job/project-merge/0/',
2262 status_jobs[0]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002263 self.assertEqual('https://server/job/project-merge/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002264 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002265 self.assertEqual('project-test1', status_jobs[1]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002266 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002267 status_jobs[1]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002268 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002269 status_jobs[1]['report_url'])
2270
2271 self.assertEqual('project-test2', status_jobs[2]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002272 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002273 status_jobs[2]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002274 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002275 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002276
James E. Blaircdccd972013-07-01 12:10:22 -07002277 def test_live_reconfiguration(self):
2278 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002279 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002280 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002281 A.addApproval('code-review', 2)
2282 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002283 self.waitUntilSettled()
2284
2285 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002286 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002287
Paul Belanger174a8272017-03-14 13:20:10 -04002288 self.executor_server.hold_jobs_in_build = False
2289 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002290 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002291 self.assertEqual(self.getJobFromHistory('project-merge').result,
2292 'SUCCESS')
2293 self.assertEqual(self.getJobFromHistory('project-test1').result,
2294 'SUCCESS')
2295 self.assertEqual(self.getJobFromHistory('project-test2').result,
2296 'SUCCESS')
2297 self.assertEqual(A.data['status'], 'MERGED')
2298 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002299
James E. Blair6bc782d2015-07-17 16:20:21 -07002300 def test_live_reconfiguration_merge_conflict(self):
2301 # A real-world bug: a change in a gate queue has a merge
2302 # conflict and a job is added to its project while it's
2303 # sitting in the queue. The job gets added to the change and
2304 # enqueued and the change gets stuck.
Paul Belanger174a8272017-03-14 13:20:10 -04002305 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002306
2307 # This change is fine. It's here to stop the queue long
2308 # enough for the next change to be subject to the
2309 # reconfiguration, as well as to provide a conflict for the
2310 # next change. This change will succeed and merge.
2311 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum073c00b2017-05-01 13:41:23 -07002312 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002313 A.addApproval('code-review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002314
2315 # This change will be in merge conflict. During the
2316 # reconfiguration, we will add a job. We want to make sure
2317 # that doesn't cause it to get stuck.
2318 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Clint Byrum073c00b2017-05-01 13:41:23 -07002319 B.addPatchset({'conflict': 'B'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002320 B.addApproval('code-review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002321
James E. Blair8b5408c2016-08-08 15:37:46 -07002322 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2323 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002324
2325 self.waitUntilSettled()
2326
2327 # No jobs have run yet
2328 self.assertEqual(A.data['status'], 'NEW')
2329 self.assertEqual(A.reported, 1)
2330 self.assertEqual(B.data['status'], 'NEW')
James E. Blair6bc782d2015-07-17 16:20:21 -07002331 self.assertEqual(len(self.history), 0)
2332
2333 # Add the "project-test3" job.
Clint Byrum073c00b2017-05-01 13:41:23 -07002334 self.commitConfigUpdate('common-config',
2335 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002336 self.sched.reconfigure(self.config)
2337 self.waitUntilSettled()
2338
Paul Belanger174a8272017-03-14 13:20:10 -04002339 self.executor_server.hold_jobs_in_build = False
2340 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002341 self.waitUntilSettled()
2342
2343 self.assertEqual(A.data['status'], 'MERGED')
2344 self.assertEqual(A.reported, 2)
2345 self.assertEqual(B.data['status'], 'NEW')
Tobias Henkel9842bd72017-05-16 13:40:03 +02002346 self.assertIn('Merge Failed', B.messages[-1])
James E. Blair6bc782d2015-07-17 16:20:21 -07002347 self.assertEqual(self.getJobFromHistory('project-merge').result,
2348 'SUCCESS')
2349 self.assertEqual(self.getJobFromHistory('project-test1').result,
2350 'SUCCESS')
2351 self.assertEqual(self.getJobFromHistory('project-test2').result,
2352 'SUCCESS')
2353 self.assertEqual(self.getJobFromHistory('project-test3').result,
2354 'SUCCESS')
2355 self.assertEqual(len(self.history), 4)
2356
James E. Blair400e8fd2015-07-30 17:44:45 -07002357 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002358 # An extrapolation of test_live_reconfiguration_merge_conflict
2359 # that tests a job added to a job tree with a failed root does
2360 # not run.
Paul Belanger174a8272017-03-14 13:20:10 -04002361 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002362
2363 # This change is fine. It's here to stop the queue long
2364 # enough for the next change to be subject to the
2365 # reconfiguration. This change will succeed and merge.
2366 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum3147d652017-05-01 14:01:42 -07002367 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002368 A.addApproval('code-review', 2)
2369 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002370 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002371 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002372 self.waitUntilSettled()
2373
2374 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002375 self.executor_server.failJob('project-merge', B)
James E. Blair8b5408c2016-08-08 15:37:46 -07002376 B.addApproval('code-review', 2)
2377 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002378 self.waitUntilSettled()
2379
Paul Belanger174a8272017-03-14 13:20:10 -04002380 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002381 self.waitUntilSettled()
2382
2383 # Both -merge jobs have run, but no others.
2384 self.assertEqual(A.data['status'], 'NEW')
2385 self.assertEqual(A.reported, 1)
2386 self.assertEqual(B.data['status'], 'NEW')
2387 self.assertEqual(B.reported, 1)
2388 self.assertEqual(self.history[0].result, 'SUCCESS')
2389 self.assertEqual(self.history[0].name, 'project-merge')
2390 self.assertEqual(self.history[1].result, 'FAILURE')
2391 self.assertEqual(self.history[1].name, 'project-merge')
2392 self.assertEqual(len(self.history), 2)
2393
2394 # Add the "project-test3" job.
Clint Byrum3147d652017-05-01 14:01:42 -07002395 self.commitConfigUpdate('common-config',
2396 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002397 self.sched.reconfigure(self.config)
2398 self.waitUntilSettled()
2399
Paul Belanger174a8272017-03-14 13:20:10 -04002400 self.executor_server.hold_jobs_in_build = False
2401 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002402 self.waitUntilSettled()
2403
2404 self.assertEqual(A.data['status'], 'MERGED')
2405 self.assertEqual(A.reported, 2)
2406 self.assertEqual(B.data['status'], 'NEW')
2407 self.assertEqual(B.reported, 2)
2408 self.assertEqual(self.history[0].result, 'SUCCESS')
2409 self.assertEqual(self.history[0].name, 'project-merge')
2410 self.assertEqual(self.history[1].result, 'FAILURE')
2411 self.assertEqual(self.history[1].name, 'project-merge')
2412 self.assertEqual(self.history[2].result, 'SUCCESS')
2413 self.assertEqual(self.history[3].result, 'SUCCESS')
2414 self.assertEqual(self.history[4].result, 'SUCCESS')
2415 self.assertEqual(len(self.history), 5)
2416
James E. Blair400e8fd2015-07-30 17:44:45 -07002417 def test_live_reconfiguration_failed_job(self):
2418 # Test that a change with a removed failing job does not
2419 # disrupt reconfiguration. If a change has a failed job and
2420 # that job is removed during a reconfiguration, we observed a
2421 # bug where the code to re-set build statuses would run on
2422 # that build and raise an exception because the job no longer
2423 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002424 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002425
2426 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2427
2428 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002429 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002430
2431 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2432 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002433 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002434 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002435 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002436 self.waitUntilSettled()
2437
2438 self.assertEqual(A.data['status'], 'NEW')
2439 self.assertEqual(A.reported, 0)
2440
2441 self.assertEqual(self.getJobFromHistory('project-merge').result,
2442 'SUCCESS')
2443 self.assertEqual(self.getJobFromHistory('project-test1').result,
2444 'FAILURE')
2445 self.assertEqual(len(self.history), 2)
2446
2447 # Remove the test1 job.
Clint Byrum841a58c2017-05-01 14:17:21 -07002448 self.commitConfigUpdate('common-config',
2449 'layouts/live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002450 self.sched.reconfigure(self.config)
2451 self.waitUntilSettled()
2452
Paul Belanger174a8272017-03-14 13:20:10 -04002453 self.executor_server.hold_jobs_in_build = False
2454 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002455 self.waitUntilSettled()
2456
2457 self.assertEqual(self.getJobFromHistory('project-test2').result,
2458 'SUCCESS')
2459 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2460 'SUCCESS')
2461 self.assertEqual(len(self.history), 4)
2462
2463 self.assertEqual(A.data['status'], 'NEW')
2464 self.assertEqual(A.reported, 1)
2465 self.assertIn('Build succeeded', A.messages[0])
2466 # Ensure the removed job was not included in the report.
2467 self.assertNotIn('project-test1', A.messages[0])
2468
James E. Blairfe707d12015-08-05 15:18:15 -07002469 def test_live_reconfiguration_shared_queue(self):
2470 # Test that a change with a failing job which was removed from
2471 # this project but otherwise still exists in the system does
2472 # not disrupt reconfiguration.
2473
Paul Belanger174a8272017-03-14 13:20:10 -04002474 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002475
2476 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2477
Paul Belanger174a8272017-03-14 13:20:10 -04002478 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002479
2480 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2481 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002482 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002483 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002484 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002485 self.waitUntilSettled()
2486
2487 self.assertEqual(A.data['status'], 'NEW')
2488 self.assertEqual(A.reported, 0)
2489
Clint Byrum69663d42017-05-01 14:51:04 -07002490 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002491 'SUCCESS')
2492 self.assertEqual(self.getJobFromHistory(
2493 'project1-project2-integration').result, 'FAILURE')
2494 self.assertEqual(len(self.history), 2)
2495
2496 # Remove the integration job.
Clint Byrum69663d42017-05-01 14:51:04 -07002497 self.commitConfigUpdate(
2498 'common-config',
2499 'layouts/live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002500 self.sched.reconfigure(self.config)
2501 self.waitUntilSettled()
2502
Paul Belanger174a8272017-03-14 13:20:10 -04002503 self.executor_server.hold_jobs_in_build = False
2504 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002505 self.waitUntilSettled()
2506
Clint Byrum69663d42017-05-01 14:51:04 -07002507 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002508 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002509 self.assertEqual(self.getJobFromHistory('project-test1').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002510 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002511 self.assertEqual(self.getJobFromHistory('project-test2').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002512 'SUCCESS')
2513 self.assertEqual(self.getJobFromHistory(
2514 'project1-project2-integration').result, 'FAILURE')
2515 self.assertEqual(len(self.history), 4)
2516
2517 self.assertEqual(A.data['status'], 'NEW')
2518 self.assertEqual(A.reported, 1)
2519 self.assertIn('Build succeeded', A.messages[0])
2520 # Ensure the removed job was not included in the report.
2521 self.assertNotIn('project1-project2-integration', A.messages[0])
2522
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002523 def test_double_live_reconfiguration_shared_queue(self):
2524 # This was a real-world regression. A change is added to
2525 # gate; a reconfigure happens, a second change which depends
2526 # on the first is added, and a second reconfiguration happens.
2527 # Ensure that both changes merge.
2528
2529 # A failure may indicate incorrect caching or cleaning up of
2530 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002531 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002532
2533 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2534 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2535 B.setDependsOn(A, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07002536 A.addApproval('code-review', 2)
2537 B.addApproval('code-review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002538
2539 # Add the parent change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002540 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002541 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002542 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002543 self.waitUntilSettled()
2544
2545 # Reconfigure (with only one change in the pipeline).
2546 self.sched.reconfigure(self.config)
2547 self.waitUntilSettled()
2548
2549 # Add the child change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002550 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002551 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002552 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002553 self.waitUntilSettled()
2554
2555 # Reconfigure (with both in the pipeline).
2556 self.sched.reconfigure(self.config)
2557 self.waitUntilSettled()
2558
Paul Belanger174a8272017-03-14 13:20:10 -04002559 self.executor_server.hold_jobs_in_build = False
2560 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002561 self.waitUntilSettled()
2562
2563 self.assertEqual(len(self.history), 8)
2564
2565 self.assertEqual(A.data['status'], 'MERGED')
2566 self.assertEqual(A.reported, 2)
2567 self.assertEqual(B.data['status'], 'MERGED')
2568 self.assertEqual(B.reported, 2)
2569
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002570 def test_live_reconfiguration_del_project(self):
2571 # Test project deletion from layout
2572 # while changes are enqueued
2573
Paul Belanger174a8272017-03-14 13:20:10 -04002574 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002575 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2576 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2577 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2578
2579 # A Depends-On: B
2580 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2581 A.subject, B.data['id'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002582 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002583
2584 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2585 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2586 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002587 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002588 self.waitUntilSettled()
2589 self.assertEqual(len(self.builds), 5)
2590
2591 # This layout defines only org/project, not org/project1
James E. Blair31cb3e82017-04-20 13:08:56 -07002592 self.commitConfigUpdate(
2593 'common-config',
2594 'layouts/live-reconfiguration-del-project.yaml')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002595 self.sched.reconfigure(self.config)
2596 self.waitUntilSettled()
2597
2598 # Builds for C aborted, builds for A succeed,
2599 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002600 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002601 self.assertEqual(job_c.changes, '3,1')
2602 self.assertEqual(job_c.result, 'ABORTED')
2603
Paul Belanger174a8272017-03-14 13:20:10 -04002604 self.executor_server.hold_jobs_in_build = False
2605 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002606 self.waitUntilSettled()
2607
Clint Byrum0149ada2017-04-04 12:22:01 -07002608 self.assertEqual(
2609 self.getJobFromHistory('project-test1', 'org/project').changes,
2610 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002611
2612 self.assertEqual(A.data['status'], 'NEW')
2613 self.assertEqual(B.data['status'], 'NEW')
2614 self.assertEqual(C.data['status'], 'NEW')
2615 self.assertEqual(A.reported, 1)
2616 self.assertEqual(B.reported, 0)
2617 self.assertEqual(C.reported, 0)
2618
Clint Byrum0149ada2017-04-04 12:22:01 -07002619 tenant = self.sched.abide.tenants.get('tenant-one')
2620 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002621 self.assertIn('Build succeeded', A.messages[0])
2622
James E. Blairec056492016-07-22 09:45:56 -07002623 @skip("Disabled for early v3 development")
James E. Blair287c06d2013-07-24 10:39:30 -07002624 def test_delayed_repo_init(self):
James E. Blairf84026c2015-12-08 16:11:46 -08002625 self.updateConfigLayout(
2626 'tests/fixtures/layout-delayed-repo-init.yaml')
James E. Blair287c06d2013-07-24 10:39:30 -07002627 self.sched.reconfigure(self.config)
2628
2629 self.init_repo("org/new-project")
2630 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2631
James E. Blair8b5408c2016-08-08 15:37:46 -07002632 A.addApproval('code-review', 2)
2633 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002634 self.waitUntilSettled()
2635 self.assertEqual(self.getJobFromHistory('project-merge').result,
2636 'SUCCESS')
2637 self.assertEqual(self.getJobFromHistory('project-test1').result,
2638 'SUCCESS')
2639 self.assertEqual(self.getJobFromHistory('project-test2').result,
2640 'SUCCESS')
2641 self.assertEqual(A.data['status'], 'MERGED')
2642 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002643
James E. Blair9ea70072017-04-19 16:05:30 -07002644 @simple_layout('layouts/repo-deleted.yaml')
Clark Boylan6dbbc482013-10-18 10:57:31 -07002645 def test_repo_deleted(self):
Clark Boylan6dbbc482013-10-18 10:57:31 -07002646 self.init_repo("org/delete-project")
2647 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2648
James E. Blair8b5408c2016-08-08 15:37:46 -07002649 A.addApproval('code-review', 2)
2650 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002651 self.waitUntilSettled()
2652 self.assertEqual(self.getJobFromHistory('project-merge').result,
2653 'SUCCESS')
2654 self.assertEqual(self.getJobFromHistory('project-test1').result,
2655 'SUCCESS')
2656 self.assertEqual(self.getJobFromHistory('project-test2').result,
2657 'SUCCESS')
2658 self.assertEqual(A.data['status'], 'MERGED')
2659 self.assertEqual(A.reported, 2)
2660
2661 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002662 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002663 if os.path.exists(os.path.join(self.merger_src_root, p)):
2664 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002665 if os.path.exists(os.path.join(self.executor_src_root, p)):
2666 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002667
2668 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2669
James E. Blair8b5408c2016-08-08 15:37:46 -07002670 B.addApproval('code-review', 2)
2671 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002672 self.waitUntilSettled()
2673 self.assertEqual(self.getJobFromHistory('project-merge').result,
2674 'SUCCESS')
2675 self.assertEqual(self.getJobFromHistory('project-test1').result,
2676 'SUCCESS')
2677 self.assertEqual(self.getJobFromHistory('project-test2').result,
2678 'SUCCESS')
2679 self.assertEqual(B.data['status'], 'MERGED')
2680 self.assertEqual(B.reported, 2)
2681
James E. Blaire68d43f2017-04-19 14:03:30 -07002682 @simple_layout('layouts/tags.yaml')
James E. Blair456f2fb2016-02-09 09:29:33 -08002683 def test_tags(self):
2684 "Test job tags"
James E. Blair456f2fb2016-02-09 09:29:33 -08002685 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2686 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2687 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2688 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2689 self.waitUntilSettled()
2690
James E. Blaire68d43f2017-04-19 14:03:30 -07002691 self.assertEqual(len(self.history), 2)
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002692
2693 results = {self.getJobFromHistory('merge',
2694 project='org/project1').uuid: 'extratag merge',
2695 self.getJobFromHistory('merge',
2696 project='org/project2').uuid: 'merge'}
James E. Blair456f2fb2016-02-09 09:29:33 -08002697
2698 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002699 self.assertEqual(results.get(build.uuid, ''),
2700 build.parameters['vars']['zuul'].get('tags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08002701
James E. Blair63bb0ef2013-07-29 17:14:51 -07002702 def test_timer(self):
2703 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002704 # This test can not use simple_layout because it must start
2705 # with a configuration which does not include a
2706 # timer-triggered job so that we have an opportunity to set
2707 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002708 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002709 self.commitConfigUpdate('common-config', 'layouts/timer.yaml')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002710 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002711
Clark Boylan3ee090a2014-04-03 20:55:09 -07002712 # The pipeline triggers every second, so we should have seen
2713 # several by now.
2714 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002715 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07002716
2717 self.assertEqual(len(self.builds), 2)
2718
James E. Blair63bb0ef2013-07-29 17:14:51 -07002719 port = self.webapp.server.socket.getsockname()[1]
2720
Clint Byrum5e729e92017-02-08 06:34:57 -08002721 req = urllib.request.Request(
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002722 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002723 f = urllib.request.urlopen(req)
Clint Byrumf322fe22017-05-10 20:53:12 -07002724 data = f.read().decode('utf8')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002725
Paul Belanger174a8272017-03-14 13:20:10 -04002726 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07002727 # Stop queuing timer triggered jobs so that the assertions
2728 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002729 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002730 self.sched.reconfigure(self.config)
Paul Belanger174a8272017-03-14 13:20:10 -04002731 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07002732 self.waitUntilSettled()
2733
2734 self.assertEqual(self.getJobFromHistory(
2735 'project-bitrot-stable-old').result, 'SUCCESS')
2736 self.assertEqual(self.getJobFromHistory(
2737 'project-bitrot-stable-older').result, 'SUCCESS')
2738
2739 data = json.loads(data)
2740 status_jobs = set()
2741 for p in data['pipelines']:
2742 for q in p['change_queues']:
2743 for head in q['heads']:
2744 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07002745 for job in change['jobs']:
2746 status_jobs.add(job['name'])
2747 self.assertIn('project-bitrot-stable-old', status_jobs)
2748 self.assertIn('project-bitrot-stable-older', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002749
James E. Blair4f6033c2014-03-27 15:49:09 -07002750 def test_idle(self):
2751 "Test that frequent periodic jobs work"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002752 # This test can not use simple_layout because it must start
2753 # with a configuration which does not include a
2754 # timer-triggered job so that we have an opportunity to set
2755 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002756 self.executor_server.hold_jobs_in_build = True
James E. Blair4f6033c2014-03-27 15:49:09 -07002757
Clark Boylan3ee090a2014-04-03 20:55:09 -07002758 for x in range(1, 3):
2759 # Test that timer triggers periodic jobs even across
2760 # layout config reloads.
2761 # Start timer trigger
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002762 self.commitConfigUpdate('common-config',
2763 'layouts/idle.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002764 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002765 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07002766
Clark Boylan3ee090a2014-04-03 20:55:09 -07002767 # The pipeline triggers every second, so we should have seen
2768 # several by now.
2769 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07002770
2771 # Stop queuing timer triggered jobs so that the assertions
2772 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002773 self.commitConfigUpdate('common-config',
2774 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002775 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002776 self.waitUntilSettled()
Clint Byrum58264dc2017-02-07 21:21:22 -08002777 self.assertEqual(len(self.builds), 2,
2778 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04002779 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002780 self.waitUntilSettled()
2781 self.assertEqual(len(self.builds), 0)
2782 self.assertEqual(len(self.history), x * 2)
James E. Blair4f6033c2014-03-27 15:49:09 -07002783
James E. Blaircc324192017-04-19 14:36:08 -07002784 @simple_layout('layouts/smtp.yaml')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002785 def test_check_smtp_pool(self):
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002786 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2787 self.waitUntilSettled()
2788
2789 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2790 self.waitUntilSettled()
2791
James E. Blairff80a2f2013-12-27 13:24:06 -08002792 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002793
2794 # A.messages only holds what FakeGerrit places in it. Thus we
2795 # work on the knowledge of what the first message should be as
2796 # it is only configured to go to SMTP.
2797
2798 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002799 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002800 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002801 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002802 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08002803 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002804
2805 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002806 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002807 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002808 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002809 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08002810 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08002811
James E. Blaire5910202013-12-27 09:50:31 -08002812 def test_timer_smtp(self):
2813 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002814 # This test can not use simple_layout because it must start
2815 # with a configuration which does not include a
2816 # timer-triggered job so that we have an opportunity to set
2817 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002818 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002819 self.commitConfigUpdate('common-config', 'layouts/timer-smtp.yaml')
James E. Blaire5910202013-12-27 09:50:31 -08002820 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08002821
Clark Boylan3ee090a2014-04-03 20:55:09 -07002822 # The pipeline triggers every second, so we should have seen
2823 # several by now.
2824 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08002825 self.waitUntilSettled()
2826
Clark Boylan3ee090a2014-04-03 20:55:09 -07002827 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04002828 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002829 self.waitUntilSettled()
2830 self.assertEqual(len(self.history), 2)
2831
James E. Blaire5910202013-12-27 09:50:31 -08002832 self.assertEqual(self.getJobFromHistory(
2833 'project-bitrot-stable-old').result, 'SUCCESS')
2834 self.assertEqual(self.getJobFromHistory(
2835 'project-bitrot-stable-older').result, 'SUCCESS')
2836
James E. Blairff80a2f2013-12-27 13:24:06 -08002837 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08002838
2839 # A.messages only holds what FakeGerrit places in it. Thus we
2840 # work on the knowledge of what the first message should be as
2841 # it is only configured to go to SMTP.
2842
2843 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002844 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002845 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002846 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002847 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08002848 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08002849
Clark Boylan3ee090a2014-04-03 20:55:09 -07002850 # Stop queuing timer triggered jobs and let any that may have
2851 # queued through so that end of test assertions pass.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002852 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002853 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07002854 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002855 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002856 self.waitUntilSettled()
2857
Joshua Hesketh25695cb2017-03-06 12:50:04 +11002858 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00002859 def test_timer_sshkey(self):
2860 "Test that a periodic job can setup SSH key authentication"
2861 self.worker.hold_jobs_in_build = True
2862 self.config.set('zuul', 'layout_config',
2863 'tests/fixtures/layout-timer.yaml')
2864 self.sched.reconfigure(self.config)
2865 self.registerJobs()
2866
2867 # The pipeline triggers every second, so we should have seen
2868 # several by now.
2869 time.sleep(5)
2870 self.waitUntilSettled()
2871
2872 self.assertEqual(len(self.builds), 2)
2873
2874 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
2875 self.assertTrue(os.path.isfile(ssh_wrapper))
2876 with open(ssh_wrapper) as f:
2877 ssh_wrapper_content = f.read()
2878 self.assertIn("fake_id_rsa", ssh_wrapper_content)
2879 # In the unit tests Merger runs in the same process,
2880 # so we see its' environment variables
2881 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
2882
2883 self.worker.release('.*')
2884 self.waitUntilSettled()
2885 self.assertEqual(len(self.history), 2)
2886
2887 self.assertEqual(self.getJobFromHistory(
2888 'project-bitrot-stable-old').result, 'SUCCESS')
2889 self.assertEqual(self.getJobFromHistory(
2890 'project-bitrot-stable-older').result, 'SUCCESS')
2891
2892 # Stop queuing timer triggered jobs and let any that may have
2893 # queued through so that end of test assertions pass.
2894 self.config.set('zuul', 'layout_config',
2895 'tests/fixtures/layout-no-timer.yaml')
2896 self.sched.reconfigure(self.config)
2897 self.registerJobs()
2898 self.waitUntilSettled()
2899 self.worker.release('.*')
2900 self.waitUntilSettled()
2901
James E. Blair91e34592015-07-31 16:45:59 -07002902 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08002903 "Test that the RPC client can enqueue a change"
2904 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002905 A.addApproval('code-review', 2)
2906 A.addApproval('approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08002907
2908 client = zuul.rpcclient.RPCClient('127.0.0.1',
2909 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002910 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04002911 r = client.enqueue(tenant='tenant-one',
2912 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002913 project='org/project',
2914 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002915 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002916 self.waitUntilSettled()
2917 self.assertEqual(self.getJobFromHistory('project-merge').result,
2918 'SUCCESS')
2919 self.assertEqual(self.getJobFromHistory('project-test1').result,
2920 'SUCCESS')
2921 self.assertEqual(self.getJobFromHistory('project-test2').result,
2922 'SUCCESS')
2923 self.assertEqual(A.data['status'], 'MERGED')
2924 self.assertEqual(A.reported, 2)
2925 self.assertEqual(r, True)
2926
James E. Blair91e34592015-07-31 16:45:59 -07002927 def test_client_enqueue_ref(self):
2928 "Test that the RPC client can enqueue a ref"
2929
2930 client = zuul.rpcclient.RPCClient('127.0.0.1',
2931 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002932 self.addCleanup(client.shutdown)
James E. Blair91e34592015-07-31 16:45:59 -07002933 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04002934 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07002935 pipeline='post',
2936 project='org/project',
2937 trigger='gerrit',
2938 ref='master',
2939 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
2940 newrev='d479a0bfcb34da57a31adb2a595c0cf687812543')
2941 self.waitUntilSettled()
2942 job_names = [x.name for x in self.history]
2943 self.assertEqual(len(self.history), 1)
2944 self.assertIn('project-post', job_names)
2945 self.assertEqual(r, True)
2946
James E. Blairad28e912013-11-27 10:43:22 -08002947 def test_client_enqueue_negative(self):
2948 "Test that the RPC client returns errors"
2949 client = zuul.rpcclient.RPCClient('127.0.0.1',
2950 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002951 self.addCleanup(client.shutdown)
James E. Blairad28e912013-11-27 10:43:22 -08002952 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04002953 "Invalid tenant"):
2954 r = client.enqueue(tenant='tenant-foo',
2955 pipeline='gate',
2956 project='org/project',
2957 trigger='gerrit',
2958 change='1,1')
Paul Belangerbaca3132016-11-04 12:49:54 -04002959 self.assertEqual(r, False)
2960
2961 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08002962 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002963 r = client.enqueue(tenant='tenant-one',
2964 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002965 project='project-does-not-exist',
2966 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002967 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002968 self.assertEqual(r, False)
2969
2970 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2971 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002972 r = client.enqueue(tenant='tenant-one',
2973 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08002974 project='org/project',
2975 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002976 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002977 self.assertEqual(r, False)
2978
2979 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2980 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002981 r = client.enqueue(tenant='tenant-one',
2982 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002983 project='org/project',
2984 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08002985 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002986 self.assertEqual(r, False)
2987
2988 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2989 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002990 r = client.enqueue(tenant='tenant-one',
2991 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002992 project='org/project',
2993 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002994 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002995 self.assertEqual(r, False)
2996
2997 self.waitUntilSettled()
2998 self.assertEqual(len(self.history), 0)
2999 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08003000
3001 def test_client_promote(self):
3002 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04003003 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003004 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3005 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3006 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003007 A.addApproval('code-review', 2)
3008 B.addApproval('code-review', 2)
3009 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003010
James E. Blair8b5408c2016-08-08 15:37:46 -07003011 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3012 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3013 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003014
3015 self.waitUntilSettled()
3016
Paul Belangerbaca3132016-11-04 12:49:54 -04003017 tenant = self.sched.abide.tenants.get('tenant-one')
3018 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003019 enqueue_times = {}
3020 for item in items:
3021 enqueue_times[str(item.change)] = item.enqueue_time
3022
James E. Blair36658cf2013-12-06 17:53:48 -08003023 client = zuul.rpcclient.RPCClient('127.0.0.1',
3024 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003025 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003026 r = client.promote(tenant='tenant-one',
3027 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003028 change_ids=['2,1', '3,1'])
3029
Sean Daguef39b9ca2014-01-10 21:34:35 -05003030 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003031 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003032 for item in items:
3033 self.assertEqual(
3034 enqueue_times[str(item.change)], item.enqueue_time)
3035
James E. Blair78acec92014-02-06 07:11:32 -08003036 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003037 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003038 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003039 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003040 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003041 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003042 self.waitUntilSettled()
3043
3044 self.assertEqual(len(self.builds), 6)
3045 self.assertEqual(self.builds[0].name, 'project-test1')
3046 self.assertEqual(self.builds[1].name, 'project-test2')
3047 self.assertEqual(self.builds[2].name, 'project-test1')
3048 self.assertEqual(self.builds[3].name, 'project-test2')
3049 self.assertEqual(self.builds[4].name, 'project-test1')
3050 self.assertEqual(self.builds[5].name, 'project-test2')
3051
Paul Belangerbaca3132016-11-04 12:49:54 -04003052 self.assertTrue(self.builds[0].hasChanges(B))
3053 self.assertFalse(self.builds[0].hasChanges(A))
3054 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003055
Paul Belangerbaca3132016-11-04 12:49:54 -04003056 self.assertTrue(self.builds[2].hasChanges(B))
3057 self.assertTrue(self.builds[2].hasChanges(C))
3058 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003059
Paul Belangerbaca3132016-11-04 12:49:54 -04003060 self.assertTrue(self.builds[4].hasChanges(B))
3061 self.assertTrue(self.builds[4].hasChanges(C))
3062 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003063
Paul Belanger174a8272017-03-14 13:20:10 -04003064 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003065 self.waitUntilSettled()
3066
3067 self.assertEqual(A.data['status'], 'MERGED')
3068 self.assertEqual(A.reported, 2)
3069 self.assertEqual(B.data['status'], 'MERGED')
3070 self.assertEqual(B.reported, 2)
3071 self.assertEqual(C.data['status'], 'MERGED')
3072 self.assertEqual(C.reported, 2)
3073
James E. Blair36658cf2013-12-06 17:53:48 -08003074 self.assertEqual(r, True)
3075
3076 def test_client_promote_dependent(self):
3077 "Test that the RPC client can promote a dependent change"
3078 # C (depends on B) -> B -> A ; then promote C to get:
3079 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003080 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003081 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3082 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3083 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3084
3085 C.setDependsOn(B, 1)
3086
James E. Blair8b5408c2016-08-08 15:37:46 -07003087 A.addApproval('code-review', 2)
3088 B.addApproval('code-review', 2)
3089 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003090
James E. Blair8b5408c2016-08-08 15:37:46 -07003091 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3092 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3093 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003094
3095 self.waitUntilSettled()
3096
3097 client = zuul.rpcclient.RPCClient('127.0.0.1',
3098 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003099 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003100 r = client.promote(tenant='tenant-one',
3101 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003102 change_ids=['3,1'])
3103
James E. Blair78acec92014-02-06 07:11:32 -08003104 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003105 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003106 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003107 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003108 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003109 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003110 self.waitUntilSettled()
3111
3112 self.assertEqual(len(self.builds), 6)
3113 self.assertEqual(self.builds[0].name, 'project-test1')
3114 self.assertEqual(self.builds[1].name, 'project-test2')
3115 self.assertEqual(self.builds[2].name, 'project-test1')
3116 self.assertEqual(self.builds[3].name, 'project-test2')
3117 self.assertEqual(self.builds[4].name, 'project-test1')
3118 self.assertEqual(self.builds[5].name, 'project-test2')
3119
Paul Belangerbaca3132016-11-04 12:49:54 -04003120 self.assertTrue(self.builds[0].hasChanges(B))
3121 self.assertFalse(self.builds[0].hasChanges(A))
3122 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003123
Paul Belangerbaca3132016-11-04 12:49:54 -04003124 self.assertTrue(self.builds[2].hasChanges(B))
3125 self.assertTrue(self.builds[2].hasChanges(C))
3126 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003127
Paul Belangerbaca3132016-11-04 12:49:54 -04003128 self.assertTrue(self.builds[4].hasChanges(B))
3129 self.assertTrue(self.builds[4].hasChanges(C))
3130 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003131
Paul Belanger174a8272017-03-14 13:20:10 -04003132 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003133 self.waitUntilSettled()
3134
3135 self.assertEqual(A.data['status'], 'MERGED')
3136 self.assertEqual(A.reported, 2)
3137 self.assertEqual(B.data['status'], 'MERGED')
3138 self.assertEqual(B.reported, 2)
3139 self.assertEqual(C.data['status'], 'MERGED')
3140 self.assertEqual(C.reported, 2)
3141
James E. Blair36658cf2013-12-06 17:53:48 -08003142 self.assertEqual(r, True)
3143
3144 def test_client_promote_negative(self):
3145 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003146 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003147 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003148 A.addApproval('code-review', 2)
3149 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003150 self.waitUntilSettled()
3151
3152 client = zuul.rpcclient.RPCClient('127.0.0.1',
3153 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003154 self.addCleanup(client.shutdown)
James E. Blair36658cf2013-12-06 17:53:48 -08003155
3156 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003157 r = client.promote(tenant='tenant-one',
3158 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003159 change_ids=['2,1', '3,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003160 self.assertEqual(r, False)
3161
3162 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003163 r = client.promote(tenant='tenant-one',
3164 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003165 change_ids=['4,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003166 self.assertEqual(r, False)
3167
Paul Belanger174a8272017-03-14 13:20:10 -04003168 self.executor_server.hold_jobs_in_build = False
3169 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003170 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003171
James E. Blaircc324192017-04-19 14:36:08 -07003172 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003173 def test_queue_rate_limiting(self):
3174 "Test that DependentPipelines are rate limited with dep across window"
Paul Belanger174a8272017-03-14 13:20:10 -04003175 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003176 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3177 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3178 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3179
3180 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003181 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003182
James E. Blair8b5408c2016-08-08 15:37:46 -07003183 A.addApproval('code-review', 2)
3184 B.addApproval('code-review', 2)
3185 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003186
James E. Blair8b5408c2016-08-08 15:37:46 -07003187 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3188 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3189 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003190 self.waitUntilSettled()
3191
3192 # Only A and B will have their merge jobs queued because
3193 # window is 2.
3194 self.assertEqual(len(self.builds), 2)
3195 self.assertEqual(self.builds[0].name, 'project-merge')
3196 self.assertEqual(self.builds[1].name, 'project-merge')
3197
James E. Blair732ee862017-04-21 07:49:26 -07003198 # Release the merge jobs one at a time.
3199 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003200 self.waitUntilSettled()
James E. Blair732ee862017-04-21 07:49:26 -07003201 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003202 self.waitUntilSettled()
3203
3204 # Only A and B will have their test jobs queued because
3205 # window is 2.
3206 self.assertEqual(len(self.builds), 4)
3207 self.assertEqual(self.builds[0].name, 'project-test1')
3208 self.assertEqual(self.builds[1].name, 'project-test2')
3209 self.assertEqual(self.builds[2].name, 'project-test1')
3210 self.assertEqual(self.builds[3].name, 'project-test2')
3211
Paul Belanger174a8272017-03-14 13:20:10 -04003212 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003213 self.waitUntilSettled()
3214
James E. Blaircc324192017-04-19 14:36:08 -07003215 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003216 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003217 # A failed so window is reduced by 1 to 1.
3218 self.assertEqual(queue.window, 1)
3219 self.assertEqual(queue.window_floor, 1)
3220 self.assertEqual(A.data['status'], 'NEW')
3221
3222 # Gate is reset and only B's merge job is queued because
3223 # window shrunk to 1.
3224 self.assertEqual(len(self.builds), 1)
3225 self.assertEqual(self.builds[0].name, 'project-merge')
3226
Paul Belanger174a8272017-03-14 13:20:10 -04003227 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003228 self.waitUntilSettled()
3229
3230 # Only B's test jobs are queued because window is still 1.
3231 self.assertEqual(len(self.builds), 2)
3232 self.assertEqual(self.builds[0].name, 'project-test1')
3233 self.assertEqual(self.builds[1].name, 'project-test2')
3234
Paul Belanger174a8272017-03-14 13:20:10 -04003235 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003236 self.waitUntilSettled()
3237
3238 # B was successfully merged so window is increased to 2.
3239 self.assertEqual(queue.window, 2)
3240 self.assertEqual(queue.window_floor, 1)
3241 self.assertEqual(B.data['status'], 'MERGED')
3242
3243 # Only C is left and its merge job is queued.
3244 self.assertEqual(len(self.builds), 1)
3245 self.assertEqual(self.builds[0].name, 'project-merge')
3246
Paul Belanger174a8272017-03-14 13:20:10 -04003247 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003248 self.waitUntilSettled()
3249
3250 # After successful merge job the test jobs for C are queued.
3251 self.assertEqual(len(self.builds), 2)
3252 self.assertEqual(self.builds[0].name, 'project-test1')
3253 self.assertEqual(self.builds[1].name, 'project-test2')
3254
Paul Belanger174a8272017-03-14 13:20:10 -04003255 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003256 self.waitUntilSettled()
3257
3258 # C successfully merged so window is bumped to 3.
3259 self.assertEqual(queue.window, 3)
3260 self.assertEqual(queue.window_floor, 1)
3261 self.assertEqual(C.data['status'], 'MERGED')
3262
James E. Blaircc324192017-04-19 14:36:08 -07003263 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003264 def test_queue_rate_limiting_dependent(self):
3265 "Test that DependentPipelines are rate limited with dep in window"
Paul Belanger174a8272017-03-14 13:20:10 -04003266 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003267 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3268 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3269 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3270
3271 B.setDependsOn(A, 1)
3272
Paul Belanger174a8272017-03-14 13:20:10 -04003273 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003274
James E. Blair8b5408c2016-08-08 15:37:46 -07003275 A.addApproval('code-review', 2)
3276 B.addApproval('code-review', 2)
3277 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003278
James E. Blair8b5408c2016-08-08 15:37:46 -07003279 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3280 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3281 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003282 self.waitUntilSettled()
3283
3284 # Only A and B will have their merge jobs queued because
3285 # window is 2.
3286 self.assertEqual(len(self.builds), 2)
3287 self.assertEqual(self.builds[0].name, 'project-merge')
3288 self.assertEqual(self.builds[1].name, 'project-merge')
3289
James E. Blairf4a5f022017-04-18 14:01:10 -07003290 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003291
3292 # Only A and B will have their test jobs queued because
3293 # window is 2.
3294 self.assertEqual(len(self.builds), 4)
3295 self.assertEqual(self.builds[0].name, 'project-test1')
3296 self.assertEqual(self.builds[1].name, 'project-test2')
3297 self.assertEqual(self.builds[2].name, 'project-test1')
3298 self.assertEqual(self.builds[3].name, 'project-test2')
3299
Paul Belanger174a8272017-03-14 13:20:10 -04003300 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003301 self.waitUntilSettled()
3302
James E. Blaircc324192017-04-19 14:36:08 -07003303 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003304 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003305 # A failed so window is reduced by 1 to 1.
3306 self.assertEqual(queue.window, 1)
3307 self.assertEqual(queue.window_floor, 1)
3308 self.assertEqual(A.data['status'], 'NEW')
3309 self.assertEqual(B.data['status'], 'NEW')
3310
3311 # Gate is reset and only C's merge job is queued because
3312 # window shrunk to 1 and A and B were dequeued.
3313 self.assertEqual(len(self.builds), 1)
3314 self.assertEqual(self.builds[0].name, 'project-merge')
3315
James E. Blairf4a5f022017-04-18 14:01:10 -07003316 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003317
3318 # Only C's test jobs are queued because window is still 1.
3319 self.assertEqual(len(self.builds), 2)
3320 self.assertEqual(self.builds[0].name, 'project-test1')
3321 self.assertEqual(self.builds[1].name, 'project-test2')
3322
Paul Belanger174a8272017-03-14 13:20:10 -04003323 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003324 self.waitUntilSettled()
3325
3326 # C was successfully merged so window is increased to 2.
3327 self.assertEqual(queue.window, 2)
3328 self.assertEqual(queue.window_floor, 1)
3329 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003330
James E. Blairec056492016-07-22 09:45:56 -07003331 @skip("Disabled for early v3 development")
Joshua Heskethba8776a2014-01-12 14:35:40 +08003332 def test_worker_update_metadata(self):
3333 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003334 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003335
3336 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003337 A.addApproval('code-review', 2)
3338 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003339 self.waitUntilSettled()
3340
Paul Belanger174a8272017-03-14 13:20:10 -04003341 self.assertEqual(len(self.executor.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003342
3343 self.log.debug('Current builds:')
Paul Belanger174a8272017-03-14 13:20:10 -04003344 self.log.debug(self.executor.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003345
3346 start = time.time()
3347 while True:
3348 if time.time() - start > 10:
3349 raise Exception("Timeout waiting for gearman server to report "
3350 + "back to the client")
Clint Byrum1d0c7d12017-05-10 19:40:53 -07003351 build = list(self.executor.builds.values())[0]
Joshua Heskethba8776a2014-01-12 14:35:40 +08003352 if build.worker.name == "My Worker":
3353 break
3354 else:
3355 time.sleep(0)
3356
3357 self.log.debug(build)
3358 self.assertEqual("My Worker", build.worker.name)
3359 self.assertEqual("localhost", build.worker.hostname)
3360 self.assertEqual(['127.0.0.1', '192.168.1.1'], build.worker.ips)
3361 self.assertEqual("zuul.example.org", build.worker.fqdn)
3362 self.assertEqual("FakeBuilder", build.worker.program)
3363 self.assertEqual("v1.1", build.worker.version)
3364 self.assertEqual({'something': 'else'}, build.worker.extra)
3365
Paul Belanger174a8272017-03-14 13:20:10 -04003366 self.executor_server.hold_jobs_in_build = False
3367 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003368 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003369
James E. Blaircc324192017-04-19 14:36:08 -07003370 @simple_layout('layouts/footer-message.yaml')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003371 def test_footer_message(self):
3372 "Test a pipeline's footer message is correctly added to the report."
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003373 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003374 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003375 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003376 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003377 self.waitUntilSettled()
3378
3379 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003380 B.addApproval('code-review', 2)
3381 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003382 self.waitUntilSettled()
3383
3384 self.assertEqual(2, len(self.smtp_messages))
3385
Adam Gandelman82258fd2017-02-07 16:51:58 -08003386 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003387Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003388http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003389
Adam Gandelman82258fd2017-02-07 16:51:58 -08003390 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003391For CI problems and help debugging, contact ci@example.org"""
3392
Adam Gandelman82258fd2017-02-07 16:51:58 -08003393 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3394 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3395 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3396 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003397
Tobias Henkel9842bd72017-05-16 13:40:03 +02003398 @simple_layout('layouts/unmanaged-project.yaml')
3399 def test_unmanaged_project_start_message(self):
3400 "Test start reporting is not done for unmanaged projects."
3401 self.init_repo("org/project", tag='init')
3402 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3403 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3404 self.waitUntilSettled()
3405
3406 self.assertEqual(0, len(A.messages))
3407
James E. Blairec056492016-07-22 09:45:56 -07003408 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003409 def test_merge_failure_reporters(self):
3410 """Check that the config is set up correctly"""
3411
James E. Blairf84026c2015-12-08 16:11:46 -08003412 self.updateConfigLayout(
3413 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003414 self.sched.reconfigure(self.config)
3415 self.registerJobs()
3416
3417 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003418 "Merge Failed.\n\nThis change or one of its cross-repo "
3419 "dependencies was unable to be automatically merged with the "
3420 "current state of its repository. Please rebase the change and "
3421 "upload a new patchset.",
Joshua Heskethb7179772014-01-30 23:30:46 +11003422 self.sched.layout.pipelines['check'].merge_failure_message)
3423 self.assertEqual(
3424 "The merge failed! For more information...",
3425 self.sched.layout.pipelines['gate'].merge_failure_message)
3426
3427 self.assertEqual(
3428 len(self.sched.layout.pipelines['check'].merge_failure_actions), 1)
3429 self.assertEqual(
3430 len(self.sched.layout.pipelines['gate'].merge_failure_actions), 2)
3431
3432 self.assertTrue(isinstance(
Joshua Heskethde958652015-11-10 19:19:50 +11003433 self.sched.layout.pipelines['check'].merge_failure_actions[0],
3434 zuul.reporter.gerrit.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003435
3436 self.assertTrue(
3437 (
3438 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003439 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003440 zuul.reporter.smtp.SMTPReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003441 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003442 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003443 zuul.reporter.gerrit.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003444 ) or (
3445 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003446 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003447 zuul.reporter.gerrit.GerritReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003448 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003449 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003450 zuul.reporter.smtp.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003451 )
3452 )
3453
James E. Blairec056492016-07-22 09:45:56 -07003454 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003455 def test_merge_failure_reports(self):
3456 """Check that when a change fails to merge the correct message is sent
3457 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003458 self.updateConfigLayout(
3459 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003460 self.sched.reconfigure(self.config)
3461 self.registerJobs()
3462
3463 # Check a test failure isn't reported to SMTP
3464 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003465 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003466 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003467 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003468 self.waitUntilSettled()
3469
3470 self.assertEqual(3, len(self.history)) # 3 jobs
3471 self.assertEqual(0, len(self.smtp_messages))
3472
3473 # Check a merge failure is reported to SMTP
3474 # B should be merged, but C will conflict with B
3475 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3476 B.addPatchset(['conflict'])
3477 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3478 C.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003479 B.addApproval('code-review', 2)
3480 C.addApproval('code-review', 2)
3481 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3482 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003483 self.waitUntilSettled()
3484
3485 self.assertEqual(6, len(self.history)) # A and B jobs
3486 self.assertEqual(1, len(self.smtp_messages))
3487 self.assertEqual('The merge failed! For more information...',
3488 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003489
James E. Blairec056492016-07-22 09:45:56 -07003490 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003491 def test_default_merge_failure_reports(self):
3492 """Check that the default merge failure reports are correct."""
3493
3494 # A should report success, B should report merge failure.
3495 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3496 A.addPatchset(['conflict'])
3497 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3498 B.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003499 A.addApproval('code-review', 2)
3500 B.addApproval('code-review', 2)
3501 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3502 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003503 self.waitUntilSettled()
3504
3505 self.assertEqual(3, len(self.history)) # A jobs
3506 self.assertEqual(A.reported, 2)
3507 self.assertEqual(B.reported, 2)
3508 self.assertEqual(A.data['status'], 'MERGED')
3509 self.assertEqual(B.data['status'], 'NEW')
3510 self.assertIn('Build succeeded', A.messages[1])
3511 self.assertIn('Merge Failed', B.messages[1])
3512 self.assertIn('automatically merged', B.messages[1])
3513 self.assertNotIn('logs.example.com', B.messages[1])
3514 self.assertNotIn('SKIPPED', B.messages[1])
3515
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003516 def test_client_get_running_jobs(self):
3517 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003518 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003519 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003520 A.addApproval('code-review', 2)
3521 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003522 self.waitUntilSettled()
3523
3524 client = zuul.rpcclient.RPCClient('127.0.0.1',
3525 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003526 self.addCleanup(client.shutdown)
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003527
3528 # Wait for gearman server to send the initial workData back to zuul
3529 start = time.time()
3530 while True:
3531 if time.time() - start > 10:
3532 raise Exception("Timeout waiting for gearman server to report "
3533 + "back to the client")
Clint Byrum1d0c7d12017-05-10 19:40:53 -07003534 build = list(self.executor_client.builds.values())[0]
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003535 if build.worker.name == "My Worker":
3536 break
3537 else:
3538 time.sleep(0)
3539
3540 running_items = client.get_running_jobs()
3541
3542 self.assertEqual(1, len(running_items))
3543 running_item = running_items[0]
3544 self.assertEqual([], running_item['failing_reasons'])
3545 self.assertEqual([], running_item['items_behind'])
3546 self.assertEqual('https://hostname/1', running_item['url'])
3547 self.assertEqual(None, running_item['item_ahead'])
3548 self.assertEqual('org/project', running_item['project'])
3549 self.assertEqual(None, running_item['remaining_time'])
3550 self.assertEqual(True, running_item['active'])
3551 self.assertEqual('1,1', running_item['id'])
3552
3553 self.assertEqual(3, len(running_item['jobs']))
3554 for job in running_item['jobs']:
3555 if job['name'] == 'project-merge':
3556 self.assertEqual('project-merge', job['name'])
3557 self.assertEqual('gate', job['pipeline'])
3558 self.assertEqual(False, job['retry'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003559 self.assertEqual('https://server/job/project-merge/0/',
3560 job['url'])
3561 self.assertEqual(7, len(job['worker']))
3562 self.assertEqual(False, job['canceled'])
3563 self.assertEqual(True, job['voting'])
3564 self.assertEqual(None, job['result'])
3565 self.assertEqual('gate', job['pipeline'])
3566 break
3567
Paul Belanger174a8272017-03-14 13:20:10 -04003568 self.executor_server.hold_jobs_in_build = False
3569 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003570 self.waitUntilSettled()
3571
3572 running_items = client.get_running_jobs()
3573 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003574
James E. Blairb70e55a2017-04-19 12:57:02 -07003575 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003576 def test_nonvoting_pipeline(self):
3577 "Test that a nonvoting pipeline (experimental) can still report"
3578
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003579 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3580 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003581 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3582 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003583
3584 self.assertEqual(self.getJobFromHistory('project-merge').result,
3585 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003586 self.assertEqual(
3587 self.getJobFromHistory('experimental-project-test').result,
3588 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003589 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003590
3591 def test_crd_gate(self):
3592 "Test cross-repo dependencies"
3593 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3594 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003595 A.addApproval('code-review', 2)
3596 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003597
3598 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3599 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3600 AM2.setMerged()
3601 AM1.setMerged()
3602
3603 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3604 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3605 BM2.setMerged()
3606 BM1.setMerged()
3607
3608 # A -> AM1 -> AM2
3609 # B -> BM1 -> BM2
3610 # A Depends-On: B
3611 # M2 is here to make sure it is never queried. If it is, it
3612 # means zuul is walking down the entire history of merged
3613 # changes.
3614
3615 B.setDependsOn(BM1, 1)
3616 BM1.setDependsOn(BM2, 1)
3617
3618 A.setDependsOn(AM1, 1)
3619 AM1.setDependsOn(AM2, 1)
3620
3621 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3622 A.subject, B.data['id'])
3623
James E. Blair8b5408c2016-08-08 15:37:46 -07003624 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003625 self.waitUntilSettled()
3626
3627 self.assertEqual(A.data['status'], 'NEW')
3628 self.assertEqual(B.data['status'], 'NEW')
3629
Paul Belanger5dccbe72016-11-14 11:17:37 -05003630 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11003631 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003632
Paul Belanger174a8272017-03-14 13:20:10 -04003633 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003634 B.addApproval('approved', 1)
3635 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003636 self.waitUntilSettled()
3637
Paul Belanger174a8272017-03-14 13:20:10 -04003638 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003639 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003640 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003641 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003642 self.executor_server.hold_jobs_in_build = False
3643 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003644 self.waitUntilSettled()
3645
3646 self.assertEqual(AM2.queried, 0)
3647 self.assertEqual(BM2.queried, 0)
3648 self.assertEqual(A.data['status'], 'MERGED')
3649 self.assertEqual(B.data['status'], 'MERGED')
3650 self.assertEqual(A.reported, 2)
3651 self.assertEqual(B.reported, 2)
3652
Paul Belanger5dccbe72016-11-14 11:17:37 -05003653 changes = self.getJobFromHistory(
3654 'project-merge', 'org/project1').changes
3655 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003656
3657 def test_crd_branch(self):
3658 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003659
3660 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003661 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3662 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3663 C = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C')
3664 C.data['id'] = B.data['id']
James E. Blair8b5408c2016-08-08 15:37:46 -07003665 A.addApproval('code-review', 2)
3666 B.addApproval('code-review', 2)
3667 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003668
3669 # A Depends-On: B+C
3670 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3671 A.subject, B.data['id'])
3672
Paul Belanger174a8272017-03-14 13:20:10 -04003673 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003674 B.addApproval('approved', 1)
3675 C.addApproval('approved', 1)
3676 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003677 self.waitUntilSettled()
3678
Paul Belanger174a8272017-03-14 13:20:10 -04003679 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003680 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003681 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003682 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003683 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003684 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003685 self.executor_server.hold_jobs_in_build = False
3686 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003687 self.waitUntilSettled()
3688
3689 self.assertEqual(A.data['status'], 'MERGED')
3690 self.assertEqual(B.data['status'], 'MERGED')
3691 self.assertEqual(C.data['status'], 'MERGED')
3692 self.assertEqual(A.reported, 2)
3693 self.assertEqual(B.reported, 2)
3694 self.assertEqual(C.reported, 2)
3695
Paul Belanger6379db12016-11-14 13:57:54 -05003696 changes = self.getJobFromHistory(
3697 'project-merge', 'org/project1').changes
3698 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003699
3700 def test_crd_multiline(self):
3701 "Test multiple depends-on lines in commit"
3702 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3703 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3704 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003705 A.addApproval('code-review', 2)
3706 B.addApproval('code-review', 2)
3707 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003708
3709 # A Depends-On: B+C
3710 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
3711 A.subject, B.data['id'], C.data['id'])
3712
Paul Belanger174a8272017-03-14 13:20:10 -04003713 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003714 B.addApproval('approved', 1)
3715 C.addApproval('approved', 1)
3716 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003717 self.waitUntilSettled()
3718
Paul Belanger174a8272017-03-14 13:20:10 -04003719 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003720 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003721 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003722 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003723 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003724 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003725 self.executor_server.hold_jobs_in_build = False
3726 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003727 self.waitUntilSettled()
3728
3729 self.assertEqual(A.data['status'], 'MERGED')
3730 self.assertEqual(B.data['status'], 'MERGED')
3731 self.assertEqual(C.data['status'], 'MERGED')
3732 self.assertEqual(A.reported, 2)
3733 self.assertEqual(B.reported, 2)
3734 self.assertEqual(C.reported, 2)
3735
Paul Belanger5dccbe72016-11-14 11:17:37 -05003736 changes = self.getJobFromHistory(
3737 'project-merge', 'org/project1').changes
3738 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08003739
3740 def test_crd_unshared_gate(self):
3741 "Test cross-repo dependencies in unshared gate queues"
3742 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3743 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003744 A.addApproval('code-review', 2)
3745 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003746
3747 # A Depends-On: B
3748 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3749 A.subject, B.data['id'])
3750
3751 # A and B do not share a queue, make sure that A is unable to
3752 # enqueue B (and therefore, A is unable to be enqueued).
James E. Blair8b5408c2016-08-08 15:37:46 -07003753 B.addApproval('approved', 1)
3754 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003755 self.waitUntilSettled()
3756
3757 self.assertEqual(A.data['status'], 'NEW')
3758 self.assertEqual(B.data['status'], 'NEW')
3759 self.assertEqual(A.reported, 0)
3760 self.assertEqual(B.reported, 0)
3761 self.assertEqual(len(self.history), 0)
3762
3763 # Enqueue and merge B alone.
James E. Blair8b5408c2016-08-08 15:37:46 -07003764 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003765 self.waitUntilSettled()
3766
3767 self.assertEqual(B.data['status'], 'MERGED')
3768 self.assertEqual(B.reported, 2)
3769
3770 # Now that B is merged, A should be able to be enqueued and
3771 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003772 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003773 self.waitUntilSettled()
3774
3775 self.assertEqual(A.data['status'], 'MERGED')
3776 self.assertEqual(A.reported, 2)
3777
James E. Blair96698e22015-04-02 07:48:21 -07003778 def test_crd_gate_reverse(self):
3779 "Test reverse cross-repo dependencies"
3780 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3781 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003782 A.addApproval('code-review', 2)
3783 B.addApproval('code-review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07003784
3785 # A Depends-On: B
3786
3787 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3788 A.subject, B.data['id'])
3789
James E. Blair8b5408c2016-08-08 15:37:46 -07003790 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003791 self.waitUntilSettled()
3792
3793 self.assertEqual(A.data['status'], 'NEW')
3794 self.assertEqual(B.data['status'], 'NEW')
3795
Paul Belanger174a8272017-03-14 13:20:10 -04003796 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003797 A.addApproval('approved', 1)
3798 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003799 self.waitUntilSettled()
3800
Paul Belanger174a8272017-03-14 13:20:10 -04003801 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003802 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003803 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003804 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003805 self.executor_server.hold_jobs_in_build = False
3806 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07003807 self.waitUntilSettled()
3808
3809 self.assertEqual(A.data['status'], 'MERGED')
3810 self.assertEqual(B.data['status'], 'MERGED')
3811 self.assertEqual(A.reported, 2)
3812 self.assertEqual(B.reported, 2)
3813
Paul Belanger5dccbe72016-11-14 11:17:37 -05003814 changes = self.getJobFromHistory(
3815 'project-merge', 'org/project1').changes
3816 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07003817
James E. Blair5ee24252014-12-30 10:12:29 -08003818 def test_crd_cycle(self):
3819 "Test cross-repo dependency cycles"
3820 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3821 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003822 A.addApproval('code-review', 2)
3823 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003824
3825 # A -> B -> A (via commit-depends)
3826
3827 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3828 A.subject, B.data['id'])
3829 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3830 B.subject, A.data['id'])
3831
James E. Blair8b5408c2016-08-08 15:37:46 -07003832 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003833 self.waitUntilSettled()
3834
3835 self.assertEqual(A.reported, 0)
3836 self.assertEqual(B.reported, 0)
3837 self.assertEqual(A.data['status'], 'NEW')
3838 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08003839
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003840 def test_crd_gate_unknown(self):
3841 "Test unknown projects in dependent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07003842 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003843 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3844 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003845 A.addApproval('code-review', 2)
3846 B.addApproval('code-review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003847
3848 # A Depends-On: B
3849 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3850 A.subject, B.data['id'])
3851
James E. Blair8b5408c2016-08-08 15:37:46 -07003852 B.addApproval('approved', 1)
3853 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003854 self.waitUntilSettled()
3855
3856 # Unknown projects cannot share a queue with any other
3857 # since they don't have common jobs with any other (they have no jobs).
3858 # Changes which depend on unknown project changes
3859 # should not be processed in dependent pipeline
3860 self.assertEqual(A.data['status'], 'NEW')
3861 self.assertEqual(B.data['status'], 'NEW')
3862 self.assertEqual(A.reported, 0)
3863 self.assertEqual(B.reported, 0)
3864 self.assertEqual(len(self.history), 0)
3865
3866 # Simulate change B being gated outside this layout
James E. Blair8b5408c2016-08-08 15:37:46 -07003867 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003868 B.setMerged()
3869 self.waitUntilSettled()
3870 self.assertEqual(len(self.history), 0)
3871
3872 # Now that B is merged, A should be able to be enqueued and
3873 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003874 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003875 self.waitUntilSettled()
3876
3877 self.assertEqual(A.data['status'], 'MERGED')
3878 self.assertEqual(A.reported, 2)
3879 self.assertEqual(B.data['status'], 'MERGED')
3880 self.assertEqual(B.reported, 0)
3881
James E. Blairbfb8e042014-12-30 17:01:44 -08003882 def test_crd_check(self):
3883 "Test cross-repo dependencies in independent pipelines"
3884
Paul Belanger174a8272017-03-14 13:20:10 -04003885 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08003886 self.gearman_server.hold_jobs_in_queue = True
3887 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3888 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3889
3890 # A Depends-On: B
3891 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3892 A.subject, B.data['id'])
3893
3894 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3895 self.waitUntilSettled()
3896
James E. Blairbfb8e042014-12-30 17:01:44 -08003897 self.gearman_server.hold_jobs_in_queue = False
3898 self.gearman_server.release()
3899 self.waitUntilSettled()
3900
Paul Belanger174a8272017-03-14 13:20:10 -04003901 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05003902 self.waitUntilSettled()
3903
James E. Blair2a535672017-04-27 12:03:15 -07003904 self.assertTrue(self.builds[0].hasChanges(A, B))
James E. Blairbfb8e042014-12-30 17:01:44 -08003905
Paul Belanger174a8272017-03-14 13:20:10 -04003906 self.executor_server.hold_jobs_in_build = False
3907 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05003908 self.waitUntilSettled()
3909
James E. Blairbfb8e042014-12-30 17:01:44 -08003910 self.assertEqual(A.data['status'], 'NEW')
3911 self.assertEqual(B.data['status'], 'NEW')
3912 self.assertEqual(A.reported, 1)
3913 self.assertEqual(B.reported, 0)
3914
3915 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05003916 tenant = self.sched.abide.tenants.get('tenant-one')
3917 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08003918
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003919 def test_crd_check_git_depends(self):
3920 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07003921 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003922 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3923 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
3924
3925 # Add two git-dependent changes and make sure they both report
3926 # success.
3927 B.setDependsOn(A, 1)
3928 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3929 self.waitUntilSettled()
3930 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3931 self.waitUntilSettled()
3932
James E. Blairb8c16472015-05-05 14:55:26 -07003933 self.orderedRelease()
3934 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003935 self.waitUntilSettled()
3936
3937 self.assertEqual(A.data['status'], 'NEW')
3938 self.assertEqual(B.data['status'], 'NEW')
3939 self.assertEqual(A.reported, 1)
3940 self.assertEqual(B.reported, 1)
3941
3942 self.assertEqual(self.history[0].changes, '1,1')
3943 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04003944 tenant = self.sched.abide.tenants.get('tenant-one')
3945 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003946
3947 self.assertIn('Build succeeded', A.messages[0])
3948 self.assertIn('Build succeeded', B.messages[0])
3949
3950 def test_crd_check_duplicate(self):
3951 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04003952 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003953 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3954 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04003955 tenant = self.sched.abide.tenants.get('tenant-one')
3956 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003957
3958 # Add two git-dependent changes...
3959 B.setDependsOn(A, 1)
3960 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3961 self.waitUntilSettled()
3962 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3963
3964 # ...make sure the live one is not duplicated...
3965 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3966 self.waitUntilSettled()
3967 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3968
3969 # ...but the non-live one is able to be.
3970 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3971 self.waitUntilSettled()
3972 self.assertEqual(len(check_pipeline.getAllItems()), 3)
3973
Clark Boylandd849822015-03-02 12:38:14 -08003974 # Release jobs in order to avoid races with change A jobs
3975 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07003976 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04003977 self.executor_server.hold_jobs_in_build = False
3978 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003979 self.waitUntilSettled()
3980
3981 self.assertEqual(A.data['status'], 'NEW')
3982 self.assertEqual(B.data['status'], 'NEW')
3983 self.assertEqual(A.reported, 1)
3984 self.assertEqual(B.reported, 1)
3985
3986 self.assertEqual(self.history[0].changes, '1,1 2,1')
3987 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04003988 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003989
3990 self.assertIn('Build succeeded', A.messages[0])
3991 self.assertIn('Build succeeded', B.messages[0])
3992
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003993 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08003994 "Test cross-repo dependencies re-enqueued in independent pipelines"
3995
3996 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003997 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
3998 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08003999
4000 # A Depends-On: B
4001 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4002 A.subject, B.data['id'])
4003
4004 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4005 self.waitUntilSettled()
4006
4007 self.sched.reconfigure(self.config)
4008
4009 # Make sure the items still share a change queue, and the
4010 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05004011 tenant = self.sched.abide.tenants.get('tenant-one')
4012 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
4013 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08004014 first_item = queue.queue[0]
4015 for item in queue.queue:
4016 self.assertEqual(item.queue, first_item.queue)
4017 self.assertFalse(first_item.live)
4018 self.assertTrue(queue.queue[1].live)
4019
4020 self.gearman_server.hold_jobs_in_queue = False
4021 self.gearman_server.release()
4022 self.waitUntilSettled()
4023
4024 self.assertEqual(A.data['status'], 'NEW')
4025 self.assertEqual(B.data['status'], 'NEW')
4026 self.assertEqual(A.reported, 1)
4027 self.assertEqual(B.reported, 0)
4028
4029 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004030 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004031
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004032 def test_crd_check_reconfiguration(self):
4033 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4034
4035 def test_crd_undefined_project(self):
4036 """Test that undefined projects in dependencies are handled for
4037 independent pipelines"""
4038 # It's a hack for fake gerrit,
4039 # as it implies repo creation upon the creation of any change
James E. Blairc4ba97a2017-04-19 16:26:24 -07004040 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004041 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4042
Jesse Keatingea68ab42017-04-19 15:03:30 -07004043 @simple_layout('layouts/ignore-dependencies.yaml')
James E. Blair17dd6772015-02-09 14:45:18 -08004044 def test_crd_check_ignore_dependencies(self):
4045 "Test cross-repo dependencies can be ignored"
James E. Blair17dd6772015-02-09 14:45:18 -08004046
4047 self.gearman_server.hold_jobs_in_queue = True
4048 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4049 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4050 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4051
4052 # A Depends-On: B
4053 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4054 A.subject, B.data['id'])
4055 # C git-depends on B
4056 C.setDependsOn(B, 1)
4057 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4058 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4059 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4060 self.waitUntilSettled()
4061
4062 # Make sure none of the items share a change queue, and all
4063 # are live.
Jesse Keatingea68ab42017-04-19 15:03:30 -07004064 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum12282ca2017-04-03 11:04:02 -07004065 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004066 self.assertEqual(len(check_pipeline.queues), 3)
4067 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4068 for item in check_pipeline.getAllItems():
4069 self.assertTrue(item.live)
4070
4071 self.gearman_server.hold_jobs_in_queue = False
4072 self.gearman_server.release()
4073 self.waitUntilSettled()
4074
4075 self.assertEqual(A.data['status'], 'NEW')
4076 self.assertEqual(B.data['status'], 'NEW')
4077 self.assertEqual(C.data['status'], 'NEW')
4078 self.assertEqual(A.reported, 1)
4079 self.assertEqual(B.reported, 1)
4080 self.assertEqual(C.reported, 1)
4081
4082 # Each job should have tested exactly one change
4083 for job in self.history:
4084 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004085
James E. Blair7cb84542017-04-19 13:35:05 -07004086 @simple_layout('layouts/three-projects.yaml')
James E. Blair96698e22015-04-02 07:48:21 -07004087 def test_crd_check_transitive(self):
4088 "Test transitive cross-repo dependencies"
4089 # Specifically, if A -> B -> C, and C gets a new patchset and
4090 # A gets a new patchset, ensure the test of A,2 includes B,1
4091 # and C,2 (not C,1 which would indicate stale data in the
4092 # cache for B).
4093 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4094 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4095 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4096
4097 # A Depends-On: B
4098 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4099 A.subject, B.data['id'])
4100
4101 # B Depends-On: C
4102 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4103 B.subject, C.data['id'])
4104
4105 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4106 self.waitUntilSettled()
4107 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4108
4109 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4110 self.waitUntilSettled()
4111 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4112
4113 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4114 self.waitUntilSettled()
4115 self.assertEqual(self.history[-1].changes, '3,1')
4116
4117 C.addPatchset()
4118 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4119 self.waitUntilSettled()
4120 self.assertEqual(self.history[-1].changes, '3,2')
4121
4122 A.addPatchset()
4123 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4124 self.waitUntilSettled()
4125 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004126
James E. Blaira8b90b32016-08-24 15:18:50 -07004127 def test_crd_check_unknown(self):
4128 "Test unknown projects in independent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004129 self.init_repo("org/unknown", tag='init')
James E. Blaira8b90b32016-08-24 15:18:50 -07004130 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4131 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4132 # A Depends-On: B
4133 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4134 A.subject, B.data['id'])
4135
4136 # Make sure zuul has seen an event on B.
4137 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4138 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4139 self.waitUntilSettled()
4140
4141 self.assertEqual(A.data['status'], 'NEW')
4142 self.assertEqual(A.reported, 1)
4143 self.assertEqual(B.data['status'], 'NEW')
4144 self.assertEqual(B.reported, 0)
4145
James E. Blair92464a22016-04-05 10:21:26 -07004146 def test_crd_cycle_join(self):
4147 "Test an updated change creates a cycle"
4148 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4149
4150 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4151 self.waitUntilSettled()
4152
4153 # Create B->A
4154 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4155 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4156 B.subject, A.data['id'])
4157 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4158 self.waitUntilSettled()
4159
4160 # Update A to add A->B (a cycle).
4161 A.addPatchset()
4162 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4163 A.subject, B.data['id'])
4164 # Normally we would submit the patchset-created event for
4165 # processing here, however, we have no way of noting whether
4166 # the dependency cycle detection correctly raised an
4167 # exception, so instead, we reach into the source driver and
4168 # call the method that would ultimately be called by the event
4169 # processing.
4170
Paul Belanger0e155e22016-11-14 14:12:23 -05004171 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07004172 (trusted, project) = tenant.getProject('org/project')
4173 source = project.source
Paul Belanger0e155e22016-11-14 14:12:23 -05004174
4175 # TODO(pabelanger): As we add more source / trigger APIs we should make
4176 # it easier for users to create events for testing.
4177 event = zuul.model.TriggerEvent()
4178 event.trigger_name = 'gerrit'
4179 event.change_number = '1'
4180 event.patch_number = '2'
James E. Blair92464a22016-04-05 10:21:26 -07004181 with testtools.ExpectedException(
4182 Exception, "Dependency cycle detected"):
Paul Belanger0e155e22016-11-14 14:12:23 -05004183 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004184 self.log.debug("Got expected dependency cycle exception")
4185
4186 # Now if we update B to remove the depends-on, everything
4187 # should be okay. B; A->B
4188
4189 B.addPatchset()
4190 B.data['commitMessage'] = '%s\n' % (B.subject,)
Paul Belanger0e155e22016-11-14 14:12:23 -05004191
4192 source.getChange(event, True)
4193 event.change_number = '2'
4194 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004195
Jesse Keatingcc67b122017-04-19 14:54:57 -07004196 @simple_layout('layouts/disable_at.yaml')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004197 def test_disable_at(self):
4198 "Test a pipeline will only report to the disabled trigger when failing"
4199
Jesse Keatingcc67b122017-04-19 14:54:57 -07004200 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004201 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004202 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004203 0, tenant.layout.pipelines['check']._consecutive_failures)
4204 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004205
4206 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4207 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4208 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4209 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4210 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4211 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4212 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4213 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4214 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4215 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4216 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4217
Paul Belanger174a8272017-03-14 13:20:10 -04004218 self.executor_server.failJob('project-test1', A)
4219 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004220 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004221 self.executor_server.failJob('project-test1', D)
4222 self.executor_server.failJob('project-test1', E)
4223 self.executor_server.failJob('project-test1', F)
4224 self.executor_server.failJob('project-test1', G)
4225 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004226 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004227 self.executor_server.failJob('project-test1', J)
4228 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004229
4230 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4231 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4232 self.waitUntilSettled()
4233
4234 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004235 2, tenant.layout.pipelines['check']._consecutive_failures)
4236 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004237
4238 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4239 self.waitUntilSettled()
4240
4241 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004242 0, tenant.layout.pipelines['check']._consecutive_failures)
4243 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004244
4245 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4246 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4247 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4248 self.waitUntilSettled()
4249
4250 # We should be disabled now
4251 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004252 3, tenant.layout.pipelines['check']._consecutive_failures)
4253 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004254
4255 # We need to wait between each of these patches to make sure the
4256 # smtp messages come back in an expected order
4257 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4258 self.waitUntilSettled()
4259 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4260 self.waitUntilSettled()
4261 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4262 self.waitUntilSettled()
4263
4264 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4265 # leaving a message on each change
4266 self.assertEqual(1, len(A.messages))
4267 self.assertIn('Build failed.', A.messages[0])
4268 self.assertEqual(1, len(B.messages))
4269 self.assertIn('Build failed.', B.messages[0])
4270 self.assertEqual(1, len(C.messages))
4271 self.assertIn('Build succeeded.', C.messages[0])
4272 self.assertEqual(1, len(D.messages))
4273 self.assertIn('Build failed.', D.messages[0])
4274 self.assertEqual(1, len(E.messages))
4275 self.assertIn('Build failed.', E.messages[0])
4276 self.assertEqual(1, len(F.messages))
4277 self.assertIn('Build failed.', F.messages[0])
4278
4279 # The last 3 (GHI) would have only reported via smtp.
4280 self.assertEqual(3, len(self.smtp_messages))
4281 self.assertEqual(0, len(G.messages))
4282 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004283 self.assertIn(
4284 'project-test1 https://server/job', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004285 self.assertEqual(0, len(H.messages))
4286 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004287 self.assertIn(
4288 'project-test1 https://server/job', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004289 self.assertEqual(0, len(I.messages))
4290 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004291 self.assertIn(
4292 'project-test1 https://server/job', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004293
4294 # Now reload the configuration (simulate a HUP) to check the pipeline
4295 # comes out of disabled
4296 self.sched.reconfigure(self.config)
4297
Jesse Keatingcc67b122017-04-19 14:54:57 -07004298 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004299
4300 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004301 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004302 0, tenant.layout.pipelines['check']._consecutive_failures)
4303 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004304
4305 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4306 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4307 self.waitUntilSettled()
4308
4309 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004310 2, tenant.layout.pipelines['check']._consecutive_failures)
4311 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004312
4313 # J and K went back to gerrit
4314 self.assertEqual(1, len(J.messages))
4315 self.assertIn('Build failed.', J.messages[0])
4316 self.assertEqual(1, len(K.messages))
4317 self.assertIn('Build failed.', K.messages[0])
4318 # No more messages reported via smtp
4319 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004320
James E. Blaircc020532017-04-19 13:04:44 -07004321 @simple_layout('layouts/one-job-project.yaml')
4322 def test_one_job_project(self):
4323 "Test that queueing works with one job"
4324 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4325 'master', 'A')
4326 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4327 'master', 'B')
4328 A.addApproval('code-review', 2)
4329 B.addApproval('code-review', 2)
4330 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4331 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4332 self.waitUntilSettled()
4333
4334 self.assertEqual(A.data['status'], 'MERGED')
4335 self.assertEqual(A.reported, 2)
4336 self.assertEqual(B.data['status'], 'MERGED')
4337 self.assertEqual(B.reported, 2)
4338
Paul Belanger71d98172016-11-08 10:56:31 -05004339 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004340 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004341
Paul Belanger174a8272017-03-14 13:20:10 -04004342 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004343 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4344 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4345 self.waitUntilSettled()
4346
Paul Belanger174a8272017-03-14 13:20:10 -04004347 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004348 self.waitUntilSettled()
4349
4350 self.assertEqual(len(self.builds), 2)
4351 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004352 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004353 self.waitUntilSettled()
4354
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004355 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004356 self.assertEqual(len(self.builds), 1,
4357 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004358 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004359 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004360 self.waitUntilSettled()
4361
Paul Belanger174a8272017-03-14 13:20:10 -04004362 self.executor_server.hold_jobs_in_build = False
4363 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004364 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004365 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004366 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4367 self.assertEqual(A.reported, 1)
4368 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004369
James E. Blair15be0e12017-01-03 13:45:20 -08004370 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004371 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004372
4373 self.fake_nodepool.paused = True
4374 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4375 A.addApproval('code-review', 2)
4376 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4377 self.waitUntilSettled()
4378
4379 self.zk.client.stop()
4380 self.zk.client.start()
4381 self.fake_nodepool.paused = False
4382 self.waitUntilSettled()
4383
4384 self.assertEqual(A.data['status'], 'MERGED')
4385 self.assertEqual(A.reported, 2)
4386
James E. Blair6ab79e02017-01-06 10:10:17 -08004387 def test_nodepool_failure(self):
4388 "Test that jobs are reported after a nodepool failure"
4389
4390 self.fake_nodepool.paused = True
4391 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4392 A.addApproval('code-review', 2)
4393 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4394 self.waitUntilSettled()
4395
4396 req = self.fake_nodepool.getNodeRequests()[0]
4397 self.fake_nodepool.addFailRequest(req)
4398
4399 self.fake_nodepool.paused = False
4400 self.waitUntilSettled()
4401
4402 self.assertEqual(A.data['status'], 'NEW')
4403 self.assertEqual(A.reported, 2)
4404 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4405 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4406 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4407
Arieb6f068c2016-10-09 13:11:06 +03004408
James E. Blaira002b032017-04-18 10:35:48 -07004409class TestExecutor(ZuulTestCase):
4410 tenant_config_file = 'config/single-tenant/main.yaml'
4411
4412 def assertFinalState(self):
4413 # In this test, we expect to shut down in a non-final state,
4414 # so skip these checks.
4415 pass
4416
4417 def assertCleanShutdown(self):
4418 self.log.debug("Assert clean shutdown")
4419
4420 # After shutdown, make sure no jobs are running
4421 self.assertEqual({}, self.executor_server.job_workers)
4422
4423 # Make sure that git.Repo objects have been garbage collected.
4424 repos = []
4425 gc.collect()
4426 for obj in gc.get_objects():
4427 if isinstance(obj, git.Repo):
4428 self.log.debug("Leaked git repo object: %s" % repr(obj))
4429 repos.append(obj)
4430 self.assertEqual(len(repos), 0)
4431
4432 def test_executor_shutdown(self):
4433 "Test that the executor can shut down with jobs running"
4434
4435 self.executor_server.hold_jobs_in_build = True
4436 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4437 A.addApproval('code-review', 2)
4438 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4439 self.waitUntilSettled()
4440
4441
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004442class TestDependencyGraph(ZuulTestCase):
4443 tenant_config_file = 'config/dependency-graph/main.yaml'
4444
4445 def test_dependeny_graph_dispatch_jobs_once(self):
4446 "Test a job in a dependency graph is queued only once"
4447 # Job dependencies, starting with A
4448 # A
4449 # / \
4450 # B C
4451 # / \ / \
4452 # D F E
4453 # |
4454 # G
4455
4456 self.executor_server.hold_jobs_in_build = True
4457 change = self.fake_gerrit.addFakeChange(
4458 'org/project', 'master', 'change')
4459 change.addApproval('code-review', 2)
4460 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4461
4462 self.waitUntilSettled()
4463 self.assertEqual([b.name for b in self.builds], ['A'])
4464
4465 self.executor_server.release('A')
4466 self.waitUntilSettled()
4467 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4468
4469 self.executor_server.release('B')
4470 self.waitUntilSettled()
4471 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4472
4473 self.executor_server.release('D')
4474 self.waitUntilSettled()
4475 self.assertEqual([b.name for b in self.builds], ['C'])
4476
4477 self.executor_server.release('C')
4478 self.waitUntilSettled()
4479 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4480
4481 self.executor_server.release('F')
4482 self.waitUntilSettled()
4483 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4484
4485 self.executor_server.release('G')
4486 self.waitUntilSettled()
4487 self.assertEqual([b.name for b in self.builds], ['E'])
4488
4489 self.executor_server.release('E')
4490 self.waitUntilSettled()
4491 self.assertEqual(len(self.builds), 0)
4492
4493 self.executor_server.hold_jobs_in_build = False
4494 self.executor_server.release()
4495 self.waitUntilSettled()
4496
4497 self.assertEqual(len(self.builds), 0)
4498 self.assertEqual(len(self.history), 7)
4499
4500 self.assertEqual(change.data['status'], 'MERGED')
4501 self.assertEqual(change.reported, 2)
4502
4503 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4504 "Test that a job waits till all dependencies are successful"
4505 # Job dependencies, starting with A
4506 # A
4507 # / \
4508 # B C*
4509 # / \ / \
4510 # D F E
4511 # |
4512 # G
4513
4514 self.executor_server.hold_jobs_in_build = True
4515 change = self.fake_gerrit.addFakeChange(
4516 'org/project', 'master', 'change')
4517 change.addApproval('code-review', 2)
4518
4519 self.executor_server.failJob('C', change)
4520
4521 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4522
4523 self.waitUntilSettled()
4524 self.assertEqual([b.name for b in self.builds], ['A'])
4525
4526 self.executor_server.release('A')
4527 self.waitUntilSettled()
4528 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4529
4530 self.executor_server.release('B')
4531 self.waitUntilSettled()
4532 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4533
4534 self.executor_server.release('D')
4535 self.waitUntilSettled()
4536 self.assertEqual([b.name for b in self.builds], ['C'])
4537
4538 self.executor_server.release('C')
4539 self.waitUntilSettled()
4540 self.assertEqual(len(self.builds), 0)
4541
4542 self.executor_server.hold_jobs_in_build = False
4543 self.executor_server.release()
4544 self.waitUntilSettled()
4545
4546 self.assertEqual(len(self.builds), 0)
4547 self.assertEqual(len(self.history), 4)
4548
4549 self.assertEqual(change.data['status'], 'NEW')
4550 self.assertEqual(change.reported, 2)
4551
4552
Arieb6f068c2016-10-09 13:11:06 +03004553class TestDuplicatePipeline(ZuulTestCase):
4554 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
4555
4556 def test_duplicate_pipelines(self):
4557 "Test that a change matching multiple pipelines works"
4558
4559 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4560 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
4561 self.waitUntilSettled()
4562
4563 self.assertHistory([
4564 dict(name='project-test1', result='SUCCESS', changes='1,1',
4565 pipeline='dup1'),
4566 dict(name='project-test1', result='SUCCESS', changes='1,1',
4567 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05004568 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03004569
4570 self.assertEqual(len(A.messages), 2)
4571
Paul Belangera46a3742016-11-09 14:23:03 -05004572 if 'dup1' in A.messages[0]:
4573 self.assertIn('dup1', A.messages[0])
4574 self.assertNotIn('dup2', A.messages[0])
4575 self.assertIn('project-test1', A.messages[0])
4576 self.assertIn('dup2', A.messages[1])
4577 self.assertNotIn('dup1', A.messages[1])
4578 self.assertIn('project-test1', A.messages[1])
4579 else:
4580 self.assertIn('dup1', A.messages[1])
4581 self.assertNotIn('dup2', A.messages[1])
4582 self.assertIn('project-test1', A.messages[1])
4583 self.assertIn('dup2', A.messages[0])
4584 self.assertNotIn('dup1', A.messages[0])
4585 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04004586
4587
Paul Belanger86085b32016-11-03 12:48:57 -04004588class TestSchedulerTemplatedProject(ZuulTestCase):
4589 tenant_config_file = 'config/templated-project/main.yaml'
4590
Paul Belanger174a8272017-03-14 13:20:10 -04004591 def test_job_from_templates_executed(self):
4592 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04004593
4594 A = self.fake_gerrit.addFakeChange(
4595 'org/templated-project', 'master', 'A')
4596 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4597 self.waitUntilSettled()
4598
4599 self.assertEqual(self.getJobFromHistory('project-test1').result,
4600 'SUCCESS')
4601 self.assertEqual(self.getJobFromHistory('project-test2').result,
4602 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04004603
4604 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004605 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04004606
4607 A = self.fake_gerrit.addFakeChange(
4608 'org/layered-project', 'master', 'A')
4609 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4610 self.waitUntilSettled()
4611
4612 self.assertEqual(self.getJobFromHistory('project-test1').result,
4613 'SUCCESS')
4614 self.assertEqual(self.getJobFromHistory('project-test2').result,
4615 'SUCCESS')
4616 self.assertEqual(self.getJobFromHistory('layered-project-test3'
4617 ).result, 'SUCCESS')
4618 self.assertEqual(self.getJobFromHistory('layered-project-test4'
4619 ).result, 'SUCCESS')
4620 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
4621 ).result, 'SUCCESS')
4622 self.assertEqual(self.getJobFromHistory('project-test6').result,
4623 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08004624
4625
4626class TestSchedulerSuccessURL(ZuulTestCase):
4627 tenant_config_file = 'config/success-url/main.yaml'
4628
4629 def test_success_url(self):
4630 "Ensure bad build params are ignored"
4631 self.sched.reconfigure(self.config)
4632 self.init_repo('org/docs')
4633
4634 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
4635 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4636 self.waitUntilSettled()
4637
4638 # Both builds ran: docs-draft-test + docs-draft-test2
4639 self.assertEqual(len(self.history), 2)
4640
4641 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08004642 for build in self.history:
4643 if build.name == 'docs-draft-test':
4644 uuid = build.uuid[:7]
4645 break
Adam Gandelman94a60062016-11-21 16:43:14 -08004646
4647 # Two msgs: 'Starting...' + results
4648 self.assertEqual(len(self.smtp_messages), 2)
4649 body = self.smtp_messages[1]['body'].splitlines()
4650 self.assertEqual('Build succeeded.', body[0])
4651
4652 self.assertIn(
4653 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
4654 'docs-draft-test/%s/publish-docs/' % uuid,
4655 body[2])
4656
Paul Belanger174a8272017-03-14 13:20:10 -04004657 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08004658 self.assertIn(
4659 '- docs-draft-test2 https://server/job',
4660 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08004661
4662
Adam Gandelman4da00f62016-12-09 15:47:33 -08004663class TestSchedulerMerges(ZuulTestCase):
4664 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08004665
4666 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04004667 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08004668 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04004669 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08004670 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
4671 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
4672 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
4673 A.addApproval('code-review', 2)
4674 B.addApproval('code-review', 2)
4675 C.addApproval('code-review', 2)
4676 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4677 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4678 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4679 self.waitUntilSettled()
4680
4681 build = self.builds[-1]
4682 ref = self.getParameter(build, 'ZUUL_REF')
4683
James E. Blair2a535672017-04-27 12:03:15 -07004684 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4685 project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08004686 repo = git.Repo(path)
4687 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4688 repo_messages.reverse()
4689
Paul Belanger174a8272017-03-14 13:20:10 -04004690 self.executor_server.hold_jobs_in_build = False
4691 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08004692 self.waitUntilSettled()
4693
4694 return repo_messages
4695
4696 def _test_merge(self, mode):
4697 us_path = os.path.join(
4698 self.upstream_root, 'org/project-%s' % mode)
4699 expected_messages = [
4700 'initial commit',
4701 'add content from fixture',
4702 # the intermediate commits order is nondeterministic
4703 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
4704 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
4705 ]
4706 result = self._test_project_merge_mode(mode)
4707 self.assertEqual(result[:2], expected_messages[:2])
4708 self.assertEqual(result[-2:], expected_messages[-2:])
4709
4710 def test_project_merge_mode_merge(self):
4711 self._test_merge('merge')
4712
4713 def test_project_merge_mode_merge_resolve(self):
4714 self._test_merge('merge-resolve')
4715
4716 def test_project_merge_mode_cherrypick(self):
4717 expected_messages = [
4718 'initial commit',
4719 'add content from fixture',
4720 'A-1',
4721 'B-1',
4722 'C-1']
4723 result = self._test_project_merge_mode('cherry-pick')
4724 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08004725
4726 def test_merge_branch(self):
4727 "Test that the right commits are on alternate branches"
4728 self.create_branch('org/project-merge-branches', 'mp')
4729
Paul Belanger174a8272017-03-14 13:20:10 -04004730 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004731 A = self.fake_gerrit.addFakeChange(
4732 'org/project-merge-branches', 'mp', 'A')
4733 B = self.fake_gerrit.addFakeChange(
4734 'org/project-merge-branches', 'mp', 'B')
4735 C = self.fake_gerrit.addFakeChange(
4736 'org/project-merge-branches', 'mp', 'C')
4737 A.addApproval('code-review', 2)
4738 B.addApproval('code-review', 2)
4739 C.addApproval('code-review', 2)
4740 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4741 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4742 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4743 self.waitUntilSettled()
4744
Paul Belanger174a8272017-03-14 13:20:10 -04004745 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004746 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004747 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004748 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004749 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004750 self.waitUntilSettled()
4751
4752 build = self.builds[-1]
4753 self.assertEqual(self.getParameter(build, 'ZUUL_BRANCH'), 'mp')
4754 ref = self.getParameter(build, 'ZUUL_REF')
James E. Blair2a535672017-04-27 12:03:15 -07004755 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4756 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004757 repo = git.Repo(path)
4758
4759 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4760 repo_messages.reverse()
4761 correct_messages = [
4762 'initial commit',
4763 'add content from fixture',
4764 'mp commit',
4765 'A-1', 'B-1', 'C-1']
4766 self.assertEqual(repo_messages, correct_messages)
4767
Paul Belanger174a8272017-03-14 13:20:10 -04004768 self.executor_server.hold_jobs_in_build = False
4769 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004770 self.waitUntilSettled()
4771
4772 def test_merge_multi_branch(self):
4773 "Test that dependent changes on multiple branches are merged"
4774 self.create_branch('org/project-merge-branches', 'mp')
4775
Paul Belanger174a8272017-03-14 13:20:10 -04004776 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004777 A = self.fake_gerrit.addFakeChange(
4778 'org/project-merge-branches', 'master', 'A')
4779 B = self.fake_gerrit.addFakeChange(
4780 'org/project-merge-branches', 'mp', 'B')
4781 C = self.fake_gerrit.addFakeChange(
4782 'org/project-merge-branches', 'master', 'C')
4783 A.addApproval('code-review', 2)
4784 B.addApproval('code-review', 2)
4785 C.addApproval('code-review', 2)
4786 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4787 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4788 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4789 self.waitUntilSettled()
4790
4791 job_A = None
4792 for job in self.builds:
4793 if 'project-merge' in job.name:
4794 job_A = job
4795 ref_A = self.getParameter(job_A, 'ZUUL_REF')
4796 commit_A = self.getParameter(job_A, 'ZUUL_COMMIT')
4797 self.log.debug("Got Zuul ref for change A: %s" % ref_A)
4798 self.log.debug("Got Zuul commit for change A: %s" % commit_A)
4799
James E. Blair2a535672017-04-27 12:03:15 -07004800 path = os.path.join(job_A.jobdir.src_root, 'review.example.com',
4801 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004802 repo = git.Repo(path)
4803 repo_messages = [c.message.strip()
4804 for c in repo.iter_commits(ref_A)]
4805 repo_messages.reverse()
4806 correct_messages = [
4807 'initial commit', 'add content from fixture', 'A-1']
4808 self.assertEqual(repo_messages, correct_messages)
4809
Paul Belanger174a8272017-03-14 13:20:10 -04004810 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004811 self.waitUntilSettled()
4812
4813 job_B = None
4814 for job in self.builds:
4815 if 'project-merge' in job.name:
4816 job_B = job
4817 ref_B = self.getParameter(job_B, 'ZUUL_REF')
4818 commit_B = self.getParameter(job_B, 'ZUUL_COMMIT')
4819 self.log.debug("Got Zuul ref for change B: %s" % ref_B)
4820 self.log.debug("Got Zuul commit for change B: %s" % commit_B)
4821
James E. Blair2a535672017-04-27 12:03:15 -07004822 path = os.path.join(job_B.jobdir.src_root, 'review.example.com',
4823 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004824 repo = git.Repo(path)
4825 repo_messages = [c.message.strip()
4826 for c in repo.iter_commits(ref_B)]
4827 repo_messages.reverse()
4828 correct_messages = [
4829 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
4830 self.assertEqual(repo_messages, correct_messages)
4831
Paul Belanger174a8272017-03-14 13:20:10 -04004832 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004833 self.waitUntilSettled()
4834
4835 job_C = None
4836 for job in self.builds:
4837 if 'project-merge' in job.name:
4838 job_C = job
4839 ref_C = self.getParameter(job_C, 'ZUUL_REF')
4840 commit_C = self.getParameter(job_C, 'ZUUL_COMMIT')
4841 self.log.debug("Got Zuul ref for change C: %s" % ref_C)
4842 self.log.debug("Got Zuul commit for change C: %s" % commit_C)
James E. Blair2a535672017-04-27 12:03:15 -07004843 path = os.path.join(job_C.jobdir.src_root, 'review.example.com',
4844 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004845 repo = git.Repo(path)
4846 repo_messages = [c.message.strip()
4847 for c in repo.iter_commits(ref_C)]
4848
4849 repo_messages.reverse()
4850 correct_messages = [
4851 'initial commit', 'add content from fixture',
4852 'A-1', 'C-1']
4853 # Ensure the right commits are in the history for this ref
4854 self.assertEqual(repo_messages, correct_messages)
4855
Paul Belanger174a8272017-03-14 13:20:10 -04004856 self.executor_server.hold_jobs_in_build = False
4857 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004858 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01004859
4860
James E. Blair9ea0d0b2017-04-20 09:27:15 -07004861class TestSemaphore(ZuulTestCase):
4862 tenant_config_file = 'config/semaphore/main.yaml'
4863
4864 def test_semaphore_one(self):
4865 "Test semaphores with max=1 (mutex)"
4866 tenant = self.sched.abide.tenants.get('tenant-one')
4867
4868 self.executor_server.hold_jobs_in_build = True
4869
4870 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4871 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4872 self.assertFalse('test-semaphore' in
4873 tenant.semaphore_handler.semaphores)
4874
4875 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4876 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4877 self.waitUntilSettled()
4878
4879 self.assertEqual(len(self.builds), 3)
4880 self.assertEqual(self.builds[0].name, 'project-test1')
4881 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
4882 self.assertEqual(self.builds[2].name, 'project-test1')
4883
4884 self.executor_server.release('semaphore-one-test1')
4885 self.waitUntilSettled()
4886
4887 self.assertEqual(len(self.builds), 3)
4888 self.assertEqual(self.builds[0].name, 'project-test1')
4889 self.assertEqual(self.builds[1].name, 'project-test1')
4890 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4891 self.assertTrue('test-semaphore' in
4892 tenant.semaphore_handler.semaphores)
4893
4894 self.executor_server.release('semaphore-one-test2')
4895 self.waitUntilSettled()
4896
4897 self.assertEqual(len(self.builds), 3)
4898 self.assertEqual(self.builds[0].name, 'project-test1')
4899 self.assertEqual(self.builds[1].name, 'project-test1')
4900 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
4901 self.assertTrue('test-semaphore' in
4902 tenant.semaphore_handler.semaphores)
4903
4904 self.executor_server.release('semaphore-one-test1')
4905 self.waitUntilSettled()
4906
4907 self.assertEqual(len(self.builds), 3)
4908 self.assertEqual(self.builds[0].name, 'project-test1')
4909 self.assertEqual(self.builds[1].name, 'project-test1')
4910 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4911 self.assertTrue('test-semaphore' in
4912 tenant.semaphore_handler.semaphores)
4913
4914 self.executor_server.release('semaphore-one-test2')
4915 self.waitUntilSettled()
4916
4917 self.assertEqual(len(self.builds), 2)
4918 self.assertEqual(self.builds[0].name, 'project-test1')
4919 self.assertEqual(self.builds[1].name, 'project-test1')
4920 self.assertFalse('test-semaphore' in
4921 tenant.semaphore_handler.semaphores)
4922
4923 self.executor_server.hold_jobs_in_build = False
4924 self.executor_server.release()
4925
4926 self.waitUntilSettled()
4927 self.assertEqual(len(self.builds), 0)
4928
4929 self.assertEqual(A.reported, 1)
4930 self.assertEqual(B.reported, 1)
4931 self.assertFalse('test-semaphore' in
4932 tenant.semaphore_handler.semaphores)
4933
4934 def test_semaphore_two(self):
4935 "Test semaphores with max>1"
4936 tenant = self.sched.abide.tenants.get('tenant-one')
4937
4938 self.executor_server.hold_jobs_in_build = True
4939 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4940 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4941 self.assertFalse('test-semaphore-two' in
4942 tenant.semaphore_handler.semaphores)
4943
4944 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4945 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4946 self.waitUntilSettled()
4947
4948 self.assertEqual(len(self.builds), 4)
4949 self.assertEqual(self.builds[0].name, 'project-test1')
4950 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
4951 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
4952 self.assertEqual(self.builds[3].name, 'project-test1')
4953 self.assertTrue('test-semaphore-two' in
4954 tenant.semaphore_handler.semaphores)
4955 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4956 'test-semaphore-two', [])), 2)
4957
4958 self.executor_server.release('semaphore-two-test1')
4959 self.waitUntilSettled()
4960
4961 self.assertEqual(len(self.builds), 4)
4962 self.assertEqual(self.builds[0].name, 'project-test1')
4963 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
4964 self.assertEqual(self.builds[2].name, 'project-test1')
4965 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
4966 self.assertTrue('test-semaphore-two' in
4967 tenant.semaphore_handler.semaphores)
4968 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4969 'test-semaphore-two', [])), 2)
4970
4971 self.executor_server.release('semaphore-two-test2')
4972 self.waitUntilSettled()
4973
4974 self.assertEqual(len(self.builds), 4)
4975 self.assertEqual(self.builds[0].name, 'project-test1')
4976 self.assertEqual(self.builds[1].name, 'project-test1')
4977 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
4978 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
4979 self.assertTrue('test-semaphore-two' in
4980 tenant.semaphore_handler.semaphores)
4981 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4982 'test-semaphore-two', [])), 2)
4983
4984 self.executor_server.release('semaphore-two-test1')
4985 self.waitUntilSettled()
4986
4987 self.assertEqual(len(self.builds), 3)
4988 self.assertEqual(self.builds[0].name, 'project-test1')
4989 self.assertEqual(self.builds[1].name, 'project-test1')
4990 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
4991 self.assertTrue('test-semaphore-two' in
4992 tenant.semaphore_handler.semaphores)
4993 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4994 'test-semaphore-two', [])), 1)
4995
4996 self.executor_server.release('semaphore-two-test2')
4997 self.waitUntilSettled()
4998
4999 self.assertEqual(len(self.builds), 2)
5000 self.assertEqual(self.builds[0].name, 'project-test1')
5001 self.assertEqual(self.builds[1].name, 'project-test1')
5002 self.assertFalse('test-semaphore-two' in
5003 tenant.semaphore_handler.semaphores)
5004
5005 self.executor_server.hold_jobs_in_build = False
5006 self.executor_server.release()
5007
5008 self.waitUntilSettled()
5009 self.assertEqual(len(self.builds), 0)
5010
5011 self.assertEqual(A.reported, 1)
5012 self.assertEqual(B.reported, 1)
5013
5014 def test_semaphore_abandon(self):
5015 "Test abandon with job semaphores"
5016 self.executor_server.hold_jobs_in_build = True
5017 tenant = self.sched.abide.tenants.get('tenant-one')
5018 check_pipeline = tenant.layout.pipelines['check']
5019
5020 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5021 self.assertFalse('test-semaphore' in
5022 tenant.semaphore_handler.semaphores)
5023
5024 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5025 self.waitUntilSettled()
5026
5027 self.assertTrue('test-semaphore' in
5028 tenant.semaphore_handler.semaphores)
5029
5030 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
5031 self.waitUntilSettled()
5032
5033 # The check pipeline should be empty
5034 items = check_pipeline.getAllItems()
5035 self.assertEqual(len(items), 0)
5036
5037 # The semaphore should be released
5038 self.assertFalse('test-semaphore' in
5039 tenant.semaphore_handler.semaphores)
5040
5041 self.executor_server.hold_jobs_in_build = False
5042 self.executor_server.release()
5043 self.waitUntilSettled()
5044
5045 def test_semaphore_reconfigure(self):
5046 "Test reconfigure with job semaphores"
5047 self.executor_server.hold_jobs_in_build = True
5048 tenant = self.sched.abide.tenants.get('tenant-one')
5049 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5050 self.assertFalse('test-semaphore' in
5051 tenant.semaphore_handler.semaphores)
5052
5053 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5054 self.waitUntilSettled()
5055
5056 self.assertTrue('test-semaphore' in
5057 tenant.semaphore_handler.semaphores)
5058
5059 # reconfigure without layout change
5060 self.sched.reconfigure(self.config)
5061 self.waitUntilSettled()
5062 tenant = self.sched.abide.tenants.get('tenant-one')
5063
5064 # semaphore still must be held
5065 self.assertTrue('test-semaphore' in
5066 tenant.semaphore_handler.semaphores)
5067
5068 self.commitConfigUpdate(
5069 'common-config',
5070 'config/semaphore/zuul-reconfiguration.yaml')
5071 self.sched.reconfigure(self.config)
5072 self.waitUntilSettled()
5073 tenant = self.sched.abide.tenants.get('tenant-one')
5074
5075 self.executor_server.release('project-test1')
5076 self.waitUntilSettled()
5077
5078 # There should be no builds anymore
5079 self.assertEqual(len(self.builds), 0)
5080
5081 # The semaphore should be released
5082 self.assertFalse('test-semaphore' in
5083 tenant.semaphore_handler.semaphores)
5084
5085
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005086class TestSemaphoreMultiTenant(ZuulTestCase):
5087 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5088
5089 def test_semaphore_tenant_isolation(self):
5090 "Test semaphores in multiple tenants"
5091
5092 self.waitUntilSettled()
5093 tenant_one = self.sched.abide.tenants.get('tenant-one')
5094 tenant_two = self.sched.abide.tenants.get('tenant-two')
5095
5096 self.executor_server.hold_jobs_in_build = True
5097 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5098 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5099 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5100 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5101 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5102 self.assertFalse('test-semaphore' in
5103 tenant_one.semaphore_handler.semaphores)
5104 self.assertFalse('test-semaphore' in
5105 tenant_two.semaphore_handler.semaphores)
5106
5107 # add patches to project1 of tenant-one
5108 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5109 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5110 self.waitUntilSettled()
5111
5112 # one build of project1-test1 must run
5113 # semaphore of tenant-one must be acquired once
5114 # semaphore of tenant-two must not be acquired
5115 self.assertEqual(len(self.builds), 1)
5116 self.assertEqual(self.builds[0].name, 'project1-test1')
5117 self.assertTrue('test-semaphore' in
5118 tenant_one.semaphore_handler.semaphores)
5119 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5120 'test-semaphore', [])), 1)
5121 self.assertFalse('test-semaphore' in
5122 tenant_two.semaphore_handler.semaphores)
5123
5124 # add patches to project2 of tenant-two
5125 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5126 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5127 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5128 self.waitUntilSettled()
5129
5130 # one build of project1-test1 must run
5131 # two builds of project2-test1 must run
5132 # semaphore of tenant-one must be acquired once
5133 # semaphore of tenant-two must be acquired twice
5134 self.assertEqual(len(self.builds), 3)
5135 self.assertEqual(self.builds[0].name, 'project1-test1')
5136 self.assertEqual(self.builds[1].name, 'project2-test1')
5137 self.assertEqual(self.builds[2].name, 'project2-test1')
5138 self.assertTrue('test-semaphore' in
5139 tenant_one.semaphore_handler.semaphores)
5140 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5141 'test-semaphore', [])), 1)
5142 self.assertTrue('test-semaphore' in
5143 tenant_two.semaphore_handler.semaphores)
5144 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5145 'test-semaphore', [])), 2)
5146
5147 self.executor_server.release('project1-test1')
5148 self.waitUntilSettled()
5149
5150 # one build of project1-test1 must run
5151 # two builds of project2-test1 must run
5152 # semaphore of tenant-one must be acquired once
5153 # semaphore of tenant-two must be acquired twice
5154 self.assertEqual(len(self.builds), 3)
5155 self.assertEqual(self.builds[0].name, 'project2-test1')
5156 self.assertEqual(self.builds[1].name, 'project2-test1')
5157 self.assertEqual(self.builds[2].name, 'project1-test1')
5158 self.assertTrue('test-semaphore' in
5159 tenant_one.semaphore_handler.semaphores)
5160 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5161 'test-semaphore', [])), 1)
5162 self.assertTrue('test-semaphore' in
5163 tenant_two.semaphore_handler.semaphores)
5164 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5165 'test-semaphore', [])), 2)
5166
5167 self.executor_server.release('project2-test1')
5168 self.waitUntilSettled()
5169
5170 # one build of project1-test1 must run
5171 # one build of project2-test1 must run
5172 # semaphore of tenant-one must be acquired once
5173 # semaphore of tenant-two must be acquired once
5174 self.assertEqual(len(self.builds), 2)
5175 self.assertTrue('test-semaphore' in
5176 tenant_one.semaphore_handler.semaphores)
5177 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5178 'test-semaphore', [])), 1)
5179 self.assertTrue('test-semaphore' in
5180 tenant_two.semaphore_handler.semaphores)
5181 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5182 'test-semaphore', [])), 1)
5183
5184 self.executor_server.hold_jobs_in_build = False
5185 self.executor_server.release()
5186
5187 self.waitUntilSettled()
5188
5189 # no build must run
5190 # semaphore of tenant-one must not be acquired
5191 # semaphore of tenant-two must not be acquired
5192 self.assertEqual(len(self.builds), 0)
5193 self.assertFalse('test-semaphore' in
5194 tenant_one.semaphore_handler.semaphores)
5195 self.assertFalse('test-semaphore' in
5196 tenant_two.semaphore_handler.semaphores)
5197
5198 self.assertEqual(A.reported, 1)
5199 self.assertEqual(B.reported, 1)
5200
5201
5202class TestSemaphoreInRepo(ZuulTestCase):
5203 tenant_config_file = 'config/in-repo/main.yaml'
5204
5205 def test_semaphore_in_repo(self):
5206 "Test semaphores in repo config"
5207
5208 # This tests dynamic semaphore handling in project repos. The semaphore
5209 # max value should not be evaluated dynamically but must be updated
5210 # after the change lands.
5211
5212 self.waitUntilSettled()
5213 tenant = self.sched.abide.tenants.get('tenant-one')
5214
5215 in_repo_conf = textwrap.dedent(
5216 """
5217 - job:
5218 name: project-test2
5219 semaphore: test-semaphore
5220
5221 - project:
5222 name: org/project
5223 tenant-one-gate:
5224 jobs:
5225 - project-test2
5226
5227 # the max value in dynamic layout must be ignored
5228 - semaphore:
5229 name: test-semaphore
5230 max: 2
5231 """)
5232
5233 in_repo_playbook = textwrap.dedent(
5234 """
5235 - hosts: all
5236 tasks: []
5237 """)
5238
5239 file_dict = {'.zuul.yaml': in_repo_conf,
5240 'playbooks/project-test2.yaml': in_repo_playbook}
5241 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5242 files=file_dict)
5243 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5244 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5245 B.setDependsOn(A, 1)
5246 C.setDependsOn(A, 1)
5247
5248 self.executor_server.hold_jobs_in_build = True
5249
5250 A.addApproval('code-review', 2)
5251 B.addApproval('code-review', 2)
5252 C.addApproval('code-review', 2)
5253 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
5254 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
5255 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
5256 self.waitUntilSettled()
5257
5258 # check that the layout in a queue item still has max value of 1
5259 # for test-semaphore
5260 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5261 queue = None
5262 for queue_candidate in pipeline.queues:
5263 if queue_candidate.name == 'org/project':
5264 queue = queue_candidate
5265 break
5266 queue_item = queue.queue[0]
5267 item_dynamic_layout = queue_item.current_build_set.layout
5268 dynamic_test_semaphore = \
5269 item_dynamic_layout.semaphores.get('test-semaphore')
5270 self.assertEqual(dynamic_test_semaphore.max, 1)
5271
5272 # one build must be in queue, one semaphores acquired
5273 self.assertEqual(len(self.builds), 1)
5274 self.assertEqual(self.builds[0].name, 'project-test2')
5275 self.assertTrue('test-semaphore' in
5276 tenant.semaphore_handler.semaphores)
5277 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5278 'test-semaphore', [])), 1)
5279
5280 self.executor_server.release('project-test2')
5281 self.waitUntilSettled()
5282
5283 # change A must be merged
5284 self.assertEqual(A.data['status'], 'MERGED')
5285 self.assertEqual(A.reported, 2)
5286
5287 # send change-merged event as the gerrit mock doesn't send it
5288 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5289 self.waitUntilSettled()
5290
5291 # now that change A was merged, the new semaphore max must be effective
5292 tenant = self.sched.abide.tenants.get('tenant-one')
5293 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5294
5295 # two builds must be in queue, two semaphores acquired
5296 self.assertEqual(len(self.builds), 2)
5297 self.assertEqual(self.builds[0].name, 'project-test2')
5298 self.assertEqual(self.builds[1].name, 'project-test2')
5299 self.assertTrue('test-semaphore' in
5300 tenant.semaphore_handler.semaphores)
5301 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5302 'test-semaphore', [])), 2)
5303
5304 self.executor_server.release('project-test2')
5305 self.waitUntilSettled()
5306
5307 self.assertEqual(len(self.builds), 0)
5308 self.assertFalse('test-semaphore' in
5309 tenant.semaphore_handler.semaphores)
5310
5311 self.executor_server.hold_jobs_in_build = False
5312 self.executor_server.release()
5313
5314 self.waitUntilSettled()
5315 self.assertEqual(len(self.builds), 0)
5316
5317 self.assertEqual(A.reported, 2)
5318 self.assertEqual(B.reported, 2)
5319 self.assertEqual(C.reported, 2)