blob: c4ed65655b206e36ec5d372eca54e1ee43c22213 [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
James E. Blairec056492016-07-22 09:45:56 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Morgan Fainberg293f7f82016-05-30 14:01:22 -070028from six.moves import urllib
Monty Taylorbc758832013-06-17 17:22:42 -040029import testtools
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
James E. Blairb0fcae42012-07-17 11:12:10 -070032import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080033import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040034import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070035
Maru Newby3fe5f852015-01-13 04:22:14 +000036from tests.base import (
Maru Newby3fe5f852015-01-13 04:22:14 +000037 ZuulTestCase,
38 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070039 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000040)
James E. Blairb0fcae42012-07-17 11:12:10 -070041
James E. Blairb0fcae42012-07-17 11:12:10 -070042
Clark Boylanb640e052014-04-03 16:41:46 -070043class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070044 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010045
Paul Belanger174a8272017-03-14 13:20:10 -040046 def test_jobs_executed(self):
47 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070048
James E. Blairb0fcae42012-07-17 11:12:10 -070049 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -070050 A.addApproval('code-review', 2)
51 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070052 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040053 self.assertEqual(self.getJobFromHistory('project-merge').result,
54 'SUCCESS')
55 self.assertEqual(self.getJobFromHistory('project-test1').result,
56 'SUCCESS')
57 self.assertEqual(self.getJobFromHistory('project-test2').result,
58 'SUCCESS')
59 self.assertEqual(A.data['status'], 'MERGED')
60 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070061 self.assertEqual(self.getJobFromHistory('project-test1').node,
62 'image1')
Adam Gandelmaneace4692017-02-07 15:18:36 -080063 self.assertIsNone(self.getJobFromHistory('project-test2').node)
James E. Blairb0fcae42012-07-17 11:12:10 -070064
James E. Blair552b54f2016-07-22 13:55:32 -070065 # TODOv3(jeblair): we may want to report stats by tenant (also?).
James E. Blair66eeebf2013-07-27 17:44:32 -070066 self.assertReportedStat('gerrit.event.comment-added', value='1|c')
67 self.assertReportedStat('zuul.pipeline.gate.current_changes',
68 value='1|g')
69 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
70 kind='ms')
71 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
72 value='1|c')
73 self.assertReportedStat('zuul.pipeline.gate.resident_time', kind='ms')
74 self.assertReportedStat('zuul.pipeline.gate.total_changes',
75 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070076 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070077 'zuul.pipeline.gate.org.project.resident_time', kind='ms')
James E. Blair412e5582013-04-22 15:50:12 -070078 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070079 'zuul.pipeline.gate.org.project.total_changes', value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070080
James E. Blair5821bd92015-09-16 08:48:15 -070081 for build in self.builds:
82 self.assertEqual(build.parameters['ZUUL_VOTING'], '1')
83
James E. Blair3cb10702013-08-24 08:56:03 -070084 def test_initial_pipeline_gauges(self):
85 "Test that each pipeline reported its length on start"
James E. Blair7da51b72016-07-25 15:29:43 -070086 self.assertReportedStat('zuul.pipeline.gate.current_changes',
87 value='0|g')
88 self.assertReportedStat('zuul.pipeline.check.current_changes',
89 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -070090
James E. Blair34776ee2016-08-25 13:53:54 -070091 def test_job_branch(self):
92 "Test the correct variant of a job runs on a branch"
93 self.create_branch('org/project', 'stable')
94 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
95 A.addApproval('code-review', 2)
96 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
97 self.waitUntilSettled()
98 self.assertEqual(self.getJobFromHistory('project-test1').result,
99 'SUCCESS')
100 self.assertEqual(self.getJobFromHistory('project-test2').result,
101 'SUCCESS')
102 self.assertEqual(A.data['status'], 'MERGED')
103 self.assertEqual(A.reported, 2,
104 "A should report start and success")
105 self.assertIn('gate', A.messages[1],
106 "A should transit gate")
107 self.assertEqual(self.getJobFromHistory('project-test1').node,
108 'image2')
109
James E. Blairb0fcae42012-07-17 11:12:10 -0700110 def test_parallel_changes(self):
111 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700112
Paul Belanger174a8272017-03-14 13:20:10 -0400113 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700114 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
115 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
116 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700117 A.addApproval('code-review', 2)
118 B.addApproval('code-review', 2)
119 C.addApproval('code-review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700120
James E. Blair8b5408c2016-08-08 15:37:46 -0700121 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
122 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
123 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700124
125 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400126 self.assertEqual(len(self.builds), 1)
127 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700128 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700129
Paul Belanger174a8272017-03-14 13:20:10 -0400130 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700131 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400132 self.assertEqual(len(self.builds), 3)
133 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700134 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400135 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700136 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400137 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700138 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700139
Paul Belanger174a8272017-03-14 13:20:10 -0400140 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700141 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400142 self.assertEqual(len(self.builds), 5)
143 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700144 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400145 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700146 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700147
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400148 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700149 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400150 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700151 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700152
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400153 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700154 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700155
Paul Belanger174a8272017-03-14 13:20:10 -0400156 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700157 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400158 self.assertEqual(len(self.builds), 6)
159 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700160 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400161 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700162 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700163
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400164 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700165 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400166 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700167 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700168
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400169 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700170 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400171 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700172 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700173
Paul Belanger174a8272017-03-14 13:20:10 -0400174 self.executor_server.hold_jobs_in_build = False
175 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700176 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400177 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700178
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400179 self.assertEqual(len(self.history), 9)
180 self.assertEqual(A.data['status'], 'MERGED')
181 self.assertEqual(B.data['status'], 'MERGED')
182 self.assertEqual(C.data['status'], 'MERGED')
183 self.assertEqual(A.reported, 2)
184 self.assertEqual(B.reported, 2)
185 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700186
187 def test_failed_changes(self):
188 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400189 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700190
James E. Blairb02a3bb2012-07-30 17:49:55 -0700191 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
192 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -0700193 A.addApproval('code-review', 2)
194 B.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700195
Paul Belanger174a8272017-03-14 13:20:10 -0400196 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700197
James E. Blair8b5408c2016-08-08 15:37:46 -0700198 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
199 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700200 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700201 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400202
Paul Belanger174a8272017-03-14 13:20:10 -0400203 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400204 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700205 # A/project-merge is complete
206 self.assertBuilds([
207 dict(name='project-test1', changes='1,1'),
208 dict(name='project-test2', changes='1,1'),
209 dict(name='project-merge', changes='1,1 2,1'),
210 ])
James E. Blaire2819012013-06-28 17:17:26 -0400211
Paul Belanger174a8272017-03-14 13:20:10 -0400212 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400213 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700214 # A/project-merge is complete
215 # B/project-merge is complete
216 self.assertBuilds([
217 dict(name='project-test1', changes='1,1'),
218 dict(name='project-test2', changes='1,1'),
219 dict(name='project-test1', changes='1,1 2,1'),
220 dict(name='project-test2', changes='1,1 2,1'),
221 ])
222
223 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400224 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700225 self.builds[0].release()
226 self.waitUntilSettled()
227
228 self.orderedRelease()
229 self.assertHistory([
230 dict(name='project-merge', result='SUCCESS', changes='1,1'),
231 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
232 dict(name='project-test1', result='FAILURE', changes='1,1'),
233 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
234 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
235 dict(name='project-test2', result='SUCCESS', changes='1,1'),
236 dict(name='project-merge', result='SUCCESS', changes='2,1'),
237 dict(name='project-test1', result='SUCCESS', changes='2,1'),
238 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700239 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700240
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400241 self.assertEqual(A.data['status'], 'NEW')
242 self.assertEqual(B.data['status'], 'MERGED')
243 self.assertEqual(A.reported, 2)
244 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700245
246 def test_independent_queues(self):
247 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700248
Paul Belanger174a8272017-03-14 13:20:10 -0400249 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900250 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700251 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
252 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700253 A.addApproval('code-review', 2)
254 B.addApproval('code-review', 2)
255 C.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700256
James E. Blair8b5408c2016-08-08 15:37:46 -0700257 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800258 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700259
James E. Blairf59f3cf2017-02-19 14:50:26 -0800260 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
261 self.waitUntilSettled()
262
263 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700264 self.waitUntilSettled()
265
266 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700267 self.assertBuilds([
268 dict(name='project-merge', changes='1,1'),
269 dict(name='project-merge', changes='2,1'),
270 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700271
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700272 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700273 self.builds[0].release()
274 self.waitUntilSettled()
275 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700276 self.waitUntilSettled()
277 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400278 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700279 self.waitUntilSettled()
280
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700281 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700282 self.assertBuilds([
283 dict(name='project-test1', changes='1,1'),
284 dict(name='project-test2', changes='1,1'),
285 dict(name='project-test1', changes='2,1'),
286 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500287 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700288 dict(name='project-test1', changes='2,1 3,1'),
289 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800290 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700291 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700292
James E. Blair5f0d49e2016-08-19 09:36:50 -0700293 self.orderedRelease()
294 self.assertHistory([
295 dict(name='project-merge', result='SUCCESS', changes='1,1'),
296 dict(name='project-merge', result='SUCCESS', changes='2,1'),
297 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
298 dict(name='project-test1', result='SUCCESS', changes='1,1'),
299 dict(name='project-test2', result='SUCCESS', changes='1,1'),
300 dict(name='project-test1', result='SUCCESS', changes='2,1'),
301 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500302 dict(
303 name='project1-project2-integration',
304 result='SUCCESS',
305 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700306 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
307 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800308 dict(name='project1-project2-integration',
309 result='SUCCESS',
310 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700311 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700312
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400313 self.assertEqual(A.data['status'], 'MERGED')
314 self.assertEqual(B.data['status'], 'MERGED')
315 self.assertEqual(C.data['status'], 'MERGED')
316 self.assertEqual(A.reported, 2)
317 self.assertEqual(B.reported, 2)
318 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700319
320 def test_failed_change_at_head(self):
321 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700322
Paul Belanger174a8272017-03-14 13:20:10 -0400323 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700324 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
325 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
326 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700327 A.addApproval('code-review', 2)
328 B.addApproval('code-review', 2)
329 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700330
Paul Belanger174a8272017-03-14 13:20:10 -0400331 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700332
James E. Blair8b5408c2016-08-08 15:37:46 -0700333 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
334 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
335 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700336
337 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700338
James E. Blairb536ecc2016-08-31 10:11:42 -0700339 self.assertBuilds([
340 dict(name='project-merge', changes='1,1'),
341 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700342
Paul Belanger174a8272017-03-14 13:20:10 -0400343 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700344 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400345 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700346 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400347 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700348 self.waitUntilSettled()
349
James E. Blairb536ecc2016-08-31 10:11:42 -0700350 self.assertBuilds([
351 dict(name='project-test1', changes='1,1'),
352 dict(name='project-test2', changes='1,1'),
353 dict(name='project-test1', changes='1,1 2,1'),
354 dict(name='project-test2', changes='1,1 2,1'),
355 dict(name='project-test1', changes='1,1 2,1 3,1'),
356 dict(name='project-test2', changes='1,1 2,1 3,1'),
357 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700358
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400359 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700360 self.waitUntilSettled()
361
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400362 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700363 self.assertBuilds([
364 dict(name='project-test2', changes='1,1'),
365 dict(name='project-merge', changes='2,1'),
366 ])
367 # Unordered history comparison because the aborts can finish
368 # in any order.
369 self.assertHistory([
370 dict(name='project-merge', result='SUCCESS',
371 changes='1,1'),
372 dict(name='project-merge', result='SUCCESS',
373 changes='1,1 2,1'),
374 dict(name='project-merge', result='SUCCESS',
375 changes='1,1 2,1 3,1'),
376 dict(name='project-test1', result='FAILURE',
377 changes='1,1'),
378 dict(name='project-test1', result='ABORTED',
379 changes='1,1 2,1'),
380 dict(name='project-test2', result='ABORTED',
381 changes='1,1 2,1'),
382 dict(name='project-test1', result='ABORTED',
383 changes='1,1 2,1 3,1'),
384 dict(name='project-test2', result='ABORTED',
385 changes='1,1 2,1 3,1'),
386 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700387
Paul Belanger174a8272017-03-14 13:20:10 -0400388 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700389 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400390 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700391 self.waitUntilSettled()
392 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700393
James E. Blairb536ecc2016-08-31 10:11:42 -0700394 self.assertBuilds([])
395 self.assertHistory([
396 dict(name='project-merge', result='SUCCESS',
397 changes='1,1'),
398 dict(name='project-merge', result='SUCCESS',
399 changes='1,1 2,1'),
400 dict(name='project-merge', result='SUCCESS',
401 changes='1,1 2,1 3,1'),
402 dict(name='project-test1', result='FAILURE',
403 changes='1,1'),
404 dict(name='project-test1', result='ABORTED',
405 changes='1,1 2,1'),
406 dict(name='project-test2', result='ABORTED',
407 changes='1,1 2,1'),
408 dict(name='project-test1', result='ABORTED',
409 changes='1,1 2,1 3,1'),
410 dict(name='project-test2', result='ABORTED',
411 changes='1,1 2,1 3,1'),
412 dict(name='project-merge', result='SUCCESS',
413 changes='2,1'),
414 dict(name='project-merge', result='SUCCESS',
415 changes='2,1 3,1'),
416 dict(name='project-test2', result='SUCCESS',
417 changes='1,1'),
418 dict(name='project-test1', result='SUCCESS',
419 changes='2,1'),
420 dict(name='project-test2', result='SUCCESS',
421 changes='2,1'),
422 dict(name='project-test1', result='SUCCESS',
423 changes='2,1 3,1'),
424 dict(name='project-test2', result='SUCCESS',
425 changes='2,1 3,1'),
426 ], ordered=False)
427
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400428 self.assertEqual(A.data['status'], 'NEW')
429 self.assertEqual(B.data['status'], 'MERGED')
430 self.assertEqual(C.data['status'], 'MERGED')
431 self.assertEqual(A.reported, 2)
432 self.assertEqual(B.reported, 2)
433 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700434
James E. Blair0aac4872013-08-23 14:02:38 -0700435 def test_failed_change_in_middle(self):
436 "Test a failed change in the middle of the queue"
437
Paul Belanger174a8272017-03-14 13:20:10 -0400438 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700439 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
440 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
441 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700442 A.addApproval('code-review', 2)
443 B.addApproval('code-review', 2)
444 C.addApproval('code-review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700445
Paul Belanger174a8272017-03-14 13:20:10 -0400446 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700447
James E. Blair8b5408c2016-08-08 15:37:46 -0700448 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
449 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
450 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700451
452 self.waitUntilSettled()
453
Paul Belanger174a8272017-03-14 13:20:10 -0400454 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700455 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400456 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700457 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400458 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700459 self.waitUntilSettled()
460
461 self.assertEqual(len(self.builds), 6)
462 self.assertEqual(self.builds[0].name, 'project-test1')
463 self.assertEqual(self.builds[1].name, 'project-test2')
464 self.assertEqual(self.builds[2].name, 'project-test1')
465 self.assertEqual(self.builds[3].name, 'project-test2')
466 self.assertEqual(self.builds[4].name, 'project-test1')
467 self.assertEqual(self.builds[5].name, 'project-test2')
468
469 self.release(self.builds[2])
470 self.waitUntilSettled()
471
James E. Blair972e3c72013-08-29 12:04:55 -0700472 # project-test1 and project-test2 for A
473 # project-test2 for B
474 # project-merge for C (without B)
475 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700476 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
477
Paul Belanger174a8272017-03-14 13:20:10 -0400478 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700479 self.waitUntilSettled()
480
481 # project-test1 and project-test2 for A
482 # project-test2 for B
483 # project-test1 and project-test2 for C
484 self.assertEqual(len(self.builds), 5)
485
Paul Belanger2e2a0492016-10-30 18:33:37 -0400486 tenant = self.sched.abide.tenants.get('tenant-one')
487 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700488 builds = items[0].current_build_set.getBuilds()
489 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
490 self.assertEqual(self.countJobResults(builds, None), 2)
491 builds = items[1].current_build_set.getBuilds()
492 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
493 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
494 self.assertEqual(self.countJobResults(builds, None), 1)
495 builds = items[2].current_build_set.getBuilds()
496 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700497 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700498
Paul Belanger174a8272017-03-14 13:20:10 -0400499 self.executor_server.hold_jobs_in_build = False
500 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700501 self.waitUntilSettled()
502
503 self.assertEqual(len(self.builds), 0)
504 self.assertEqual(len(self.history), 12)
505 self.assertEqual(A.data['status'], 'MERGED')
506 self.assertEqual(B.data['status'], 'NEW')
507 self.assertEqual(C.data['status'], 'MERGED')
508 self.assertEqual(A.reported, 2)
509 self.assertEqual(B.reported, 2)
510 self.assertEqual(C.reported, 2)
511
James E. Blaird466dc42012-07-31 10:42:56 -0700512 def test_failed_change_at_head_with_queue(self):
513 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700514
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700515 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700516 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
517 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
518 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700519 A.addApproval('code-review', 2)
520 B.addApproval('code-review', 2)
521 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700522
Paul Belanger174a8272017-03-14 13:20:10 -0400523 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700524
James E. Blair8b5408c2016-08-08 15:37:46 -0700525 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
526 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
527 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700528
529 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700530 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400531 self.assertEqual(len(self.builds), 0)
532 self.assertEqual(len(queue), 1)
Paul Belanger174a8272017-03-14 13:20:10 -0400533 self.assertEqual(queue[0].name, 'executor:execute')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800534 job_args = json.loads(queue[0].arguments)
535 self.assertEqual(job_args['job'], 'project-merge')
536 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700537
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700538 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700539 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700540 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700541 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700542 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700543 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700544 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700545
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400546 self.assertEqual(len(self.builds), 0)
547 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800548
549 self.assertEqual(
550 json.loads(queue[0].arguments)['job'], 'project-test1')
551 self.assertEqual(
552 json.loads(queue[1].arguments)['job'], 'project-test2')
553 self.assertEqual(
554 json.loads(queue[2].arguments)['job'], 'project-test1')
555 self.assertEqual(
556 json.loads(queue[3].arguments)['job'], 'project-test2')
557 self.assertEqual(
558 json.loads(queue[4].arguments)['job'], 'project-test1')
559 self.assertEqual(
560 json.loads(queue[5].arguments)['job'], 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700561
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700562 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700563 self.waitUntilSettled()
564
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400565 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700566 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400567 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
568 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700569
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700570 self.gearman_server.hold_jobs_in_queue = False
571 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700572 self.waitUntilSettled()
573
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400574 self.assertEqual(len(self.builds), 0)
575 self.assertEqual(len(self.history), 11)
576 self.assertEqual(A.data['status'], 'NEW')
577 self.assertEqual(B.data['status'], 'MERGED')
578 self.assertEqual(C.data['status'], 'MERGED')
579 self.assertEqual(A.reported, 2)
580 self.assertEqual(B.reported, 2)
581 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700582
James E. Blairec056492016-07-22 09:45:56 -0700583 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700584 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400585 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700586 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -0700587 A.addApproval('code-review', 2)
588 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700589 self.waitUntilSettled()
590 time.sleep(2)
591
592 data = json.loads(self.sched.formatStatusJSON())
593 found_job = None
594 for pipeline in data['pipelines']:
595 if pipeline['name'] != 'gate':
596 continue
597 for queue in pipeline['change_queues']:
598 for head in queue['heads']:
599 for item in head:
600 for job in item['jobs']:
601 if job['name'] == 'project-merge':
602 found_job = job
603 break
604
605 self.assertIsNotNone(found_job)
606 if iteration == 1:
607 self.assertIsNotNone(found_job['estimated_time'])
608 self.assertIsNone(found_job['remaining_time'])
609 else:
610 self.assertIsNotNone(found_job['estimated_time'])
611 self.assertTrue(found_job['estimated_time'] >= 2)
612 self.assertIsNotNone(found_job['remaining_time'])
613
Paul Belanger174a8272017-03-14 13:20:10 -0400614 self.executor_server.hold_jobs_in_build = False
615 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700616 self.waitUntilSettled()
617
James E. Blairec056492016-07-22 09:45:56 -0700618 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700619 def test_time_database(self):
620 "Test the time database"
621
622 self._test_time_database(1)
623 self._test_time_database(2)
624
James E. Blairfef71632013-09-23 11:15:47 -0700625 def test_two_failed_changes_at_head(self):
626 "Test that changes are reparented correctly if 2 fail at head"
627
Paul Belanger174a8272017-03-14 13:20:10 -0400628 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700629 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
630 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
631 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700632 A.addApproval('code-review', 2)
633 B.addApproval('code-review', 2)
634 C.addApproval('code-review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700635
Paul Belanger174a8272017-03-14 13:20:10 -0400636 self.executor_server.failJob('project-test1', A)
637 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700638
James E. Blair8b5408c2016-08-08 15:37:46 -0700639 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
640 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
641 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700642 self.waitUntilSettled()
643
Paul Belanger174a8272017-03-14 13:20:10 -0400644 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700645 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400646 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700647 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400648 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700649 self.waitUntilSettled()
650
651 self.assertEqual(len(self.builds), 6)
652 self.assertEqual(self.builds[0].name, 'project-test1')
653 self.assertEqual(self.builds[1].name, 'project-test2')
654 self.assertEqual(self.builds[2].name, 'project-test1')
655 self.assertEqual(self.builds[3].name, 'project-test2')
656 self.assertEqual(self.builds[4].name, 'project-test1')
657 self.assertEqual(self.builds[5].name, 'project-test2')
658
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400659 self.assertTrue(self.builds[0].hasChanges(A))
660 self.assertTrue(self.builds[2].hasChanges(A))
661 self.assertTrue(self.builds[2].hasChanges(B))
662 self.assertTrue(self.builds[4].hasChanges(A))
663 self.assertTrue(self.builds[4].hasChanges(B))
664 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700665
666 # Fail change B first
667 self.release(self.builds[2])
668 self.waitUntilSettled()
669
670 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400671 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700672 self.waitUntilSettled()
673
674 self.assertEqual(len(self.builds), 5)
675 self.assertEqual(self.builds[0].name, 'project-test1')
676 self.assertEqual(self.builds[1].name, 'project-test2')
677 self.assertEqual(self.builds[2].name, 'project-test2')
678 self.assertEqual(self.builds[3].name, 'project-test1')
679 self.assertEqual(self.builds[4].name, 'project-test2')
680
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400681 self.assertTrue(self.builds[1].hasChanges(A))
682 self.assertTrue(self.builds[2].hasChanges(A))
683 self.assertTrue(self.builds[2].hasChanges(B))
684 self.assertTrue(self.builds[4].hasChanges(A))
685 self.assertFalse(self.builds[4].hasChanges(B))
686 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700687
688 # Finish running all passing jobs for change A
689 self.release(self.builds[1])
690 self.waitUntilSettled()
691 # Fail and report change A
692 self.release(self.builds[0])
693 self.waitUntilSettled()
694
695 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400696 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700697 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400698 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700699 self.waitUntilSettled()
700
701 self.assertEqual(len(self.builds), 4)
702 self.assertEqual(self.builds[0].name, 'project-test1') # B
703 self.assertEqual(self.builds[1].name, 'project-test2') # B
704 self.assertEqual(self.builds[2].name, 'project-test1') # C
705 self.assertEqual(self.builds[3].name, 'project-test2') # C
706
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400707 self.assertFalse(self.builds[1].hasChanges(A))
708 self.assertTrue(self.builds[1].hasChanges(B))
709 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700710
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400711 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700712 # After A failed and B and C restarted, B should be back in
713 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400714 self.assertTrue(self.builds[2].hasChanges(B))
715 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700716
Paul Belanger174a8272017-03-14 13:20:10 -0400717 self.executor_server.hold_jobs_in_build = False
718 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700719 self.waitUntilSettled()
720
721 self.assertEqual(len(self.builds), 0)
722 self.assertEqual(len(self.history), 21)
723 self.assertEqual(A.data['status'], 'NEW')
724 self.assertEqual(B.data['status'], 'NEW')
725 self.assertEqual(C.data['status'], 'MERGED')
726 self.assertEqual(A.reported, 2)
727 self.assertEqual(B.reported, 2)
728 self.assertEqual(C.reported, 2)
729
James E. Blair8c803f82012-07-31 16:25:42 -0700730 def test_patch_order(self):
731 "Test that dependent patches are tested in the right order"
732 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
733 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
734 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700735 A.addApproval('code-review', 2)
736 B.addApproval('code-review', 2)
737 C.addApproval('code-review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700738
739 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
740 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
741 M2.setMerged()
742 M1.setMerged()
743
744 # C -> B -> A -> M1 -> M2
745 # M2 is here to make sure it is never queried. If it is, it
746 # means zuul is walking down the entire history of merged
747 # changes.
748
749 C.setDependsOn(B, 1)
750 B.setDependsOn(A, 1)
751 A.setDependsOn(M1, 1)
752 M1.setDependsOn(M2, 1)
753
James E. Blair8b5408c2016-08-08 15:37:46 -0700754 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700755
756 self.waitUntilSettled()
757
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400758 self.assertEqual(A.data['status'], 'NEW')
759 self.assertEqual(B.data['status'], 'NEW')
760 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700761
James E. Blair8b5408c2016-08-08 15:37:46 -0700762 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
763 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700764
765 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400766 self.assertEqual(M2.queried, 0)
767 self.assertEqual(A.data['status'], 'MERGED')
768 self.assertEqual(B.data['status'], 'MERGED')
769 self.assertEqual(C.data['status'], 'MERGED')
770 self.assertEqual(A.reported, 2)
771 self.assertEqual(B.reported, 2)
772 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700773
James E. Blair063672f2015-01-29 13:09:12 -0800774 def test_needed_changes_enqueue(self):
775 "Test that a needed change is enqueued ahead"
776 # A Given a git tree like this, if we enqueue
777 # / \ change C, we should walk up and down the tree
778 # B G and enqueue changes in the order ABCDEFG.
779 # /|\ This is also the order that you would get if
780 # *C E F you enqueued changes in the order ABCDEFG, so
781 # / the ordering is stable across re-enqueue events.
782 # D
783
784 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
785 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
786 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
787 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
788 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
789 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
790 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
791 B.setDependsOn(A, 1)
792 C.setDependsOn(B, 1)
793 D.setDependsOn(C, 1)
794 E.setDependsOn(B, 1)
795 F.setDependsOn(B, 1)
796 G.setDependsOn(A, 1)
797
James E. Blair8b5408c2016-08-08 15:37:46 -0700798 A.addApproval('code-review', 2)
799 B.addApproval('code-review', 2)
800 C.addApproval('code-review', 2)
801 D.addApproval('code-review', 2)
802 E.addApproval('code-review', 2)
803 F.addApproval('code-review', 2)
804 G.addApproval('code-review', 2)
805 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800806
807 self.waitUntilSettled()
808
809 self.assertEqual(A.data['status'], 'NEW')
810 self.assertEqual(B.data['status'], 'NEW')
811 self.assertEqual(C.data['status'], 'NEW')
812 self.assertEqual(D.data['status'], 'NEW')
813 self.assertEqual(E.data['status'], 'NEW')
814 self.assertEqual(F.data['status'], 'NEW')
815 self.assertEqual(G.data['status'], 'NEW')
816
817 # We're about to add approvals to changes without adding the
818 # triggering events to Zuul, so that we can be sure that it is
819 # enqueing the changes based on dependencies, not because of
820 # triggering events. Since it will have the changes cached
821 # already (without approvals), we need to clear the cache
822 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400823 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +1100824 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800825
Paul Belanger174a8272017-03-14 13:20:10 -0400826 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -0700827 A.addApproval('approved', 1)
828 B.addApproval('approved', 1)
829 D.addApproval('approved', 1)
830 E.addApproval('approved', 1)
831 F.addApproval('approved', 1)
832 G.addApproval('approved', 1)
833 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800834
835 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400836 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800837 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400838 self.executor_server.hold_jobs_in_build = False
839 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800840 self.waitUntilSettled()
841
842 self.assertEqual(A.data['status'], 'MERGED')
843 self.assertEqual(B.data['status'], 'MERGED')
844 self.assertEqual(C.data['status'], 'MERGED')
845 self.assertEqual(D.data['status'], 'MERGED')
846 self.assertEqual(E.data['status'], 'MERGED')
847 self.assertEqual(F.data['status'], 'MERGED')
848 self.assertEqual(G.data['status'], 'MERGED')
849 self.assertEqual(A.reported, 2)
850 self.assertEqual(B.reported, 2)
851 self.assertEqual(C.reported, 2)
852 self.assertEqual(D.reported, 2)
853 self.assertEqual(E.reported, 2)
854 self.assertEqual(F.reported, 2)
855 self.assertEqual(G.reported, 2)
856 self.assertEqual(self.history[6].changes,
857 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
858
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100859 def test_source_cache(self):
860 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400861 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700862
863 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
864 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
865 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
James E. Blair8b5408c2016-08-08 15:37:46 -0700866 A.addApproval('code-review', 2)
867 B.addApproval('code-review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700868
869 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
870 M1.setMerged()
871
872 B.setDependsOn(A, 1)
873 A.setDependsOn(M1, 1)
874
James E. Blair8b5408c2016-08-08 15:37:46 -0700875 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700876 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
877
878 self.waitUntilSettled()
879
880 for build in self.builds:
881 if build.parameters['ZUUL_PIPELINE'] == 'check':
882 build.release()
883 self.waitUntilSettled()
884 for build in self.builds:
885 if build.parameters['ZUUL_PIPELINE'] == 'check':
886 build.release()
887 self.waitUntilSettled()
888
James E. Blair8b5408c2016-08-08 15:37:46 -0700889 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700890 self.waitUntilSettled()
891
Joshua Hesketh352264b2015-08-11 23:42:08 +1000892 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700893 # there should still be changes in the cache
Joshua Hesketh352264b2015-08-11 23:42:08 +1000894 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700895
Paul Belanger174a8272017-03-14 13:20:10 -0400896 self.executor_server.hold_jobs_in_build = False
897 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700898 self.waitUntilSettled()
899
900 self.assertEqual(A.data['status'], 'MERGED')
901 self.assertEqual(B.data['status'], 'MERGED')
902 self.assertEqual(A.queried, 2) # Initial and isMerged
903 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
904
James E. Blair8c803f82012-07-31 16:25:42 -0700905 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700906 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700907 # TODO: move to test_gerrit (this is a unit test!)
908 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400909 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700910 (trusted, project) = tenant.getProject('org/project')
911 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400912
913 # TODO(pabelanger): As we add more source / trigger APIs we should make
914 # it easier for users to create events for testing.
915 event = zuul.model.TriggerEvent()
916 event.trigger_name = 'gerrit'
917 event.change_number = '1'
918 event.patch_number = '2'
919
920 a = source.getChange(event)
921 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700922 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700923
James E. Blair8b5408c2016-08-08 15:37:46 -0700924 A.addApproval('code-review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400925 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700926 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700927
James E. Blair8b5408c2016-08-08 15:37:46 -0700928 A.addApproval('approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400929 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700930 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700931
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700932 def test_project_merge_conflict(self):
933 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700934
935 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700936 A = self.fake_gerrit.addFakeChange('org/project',
937 'master', 'A',
938 files={'conflict': 'foo'})
939 B = self.fake_gerrit.addFakeChange('org/project',
940 'master', 'B',
941 files={'conflict': 'bar'})
942 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -0700943 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700944 A.addApproval('code-review', 2)
945 B.addApproval('code-review', 2)
946 C.addApproval('code-review', 2)
947 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
948 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
949 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -0700950 self.waitUntilSettled()
951
James E. Blair6736beb2013-07-11 15:18:15 -0700952 self.assertEqual(A.reported, 1)
953 self.assertEqual(B.reported, 1)
954 self.assertEqual(C.reported, 1)
955
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700956 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700957 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700958 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700959 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700960 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700961 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -0700962
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700963 self.gearman_server.hold_jobs_in_queue = False
964 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -0700965 self.waitUntilSettled()
966
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400967 self.assertEqual(A.data['status'], 'MERGED')
968 self.assertEqual(B.data['status'], 'NEW')
969 self.assertEqual(C.data['status'], 'MERGED')
970 self.assertEqual(A.reported, 2)
971 self.assertEqual(B.reported, 2)
972 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700973
974 self.assertHistory([
975 dict(name='project-merge', result='SUCCESS', changes='1,1'),
976 dict(name='project-test1', result='SUCCESS', changes='1,1'),
977 dict(name='project-test2', result='SUCCESS', changes='1,1'),
978 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
979 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
980 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
981 ], ordered=False)
982
983 def test_delayed_merge_conflict(self):
984 "Test that delayed check merge conflicts are handled properly"
985
986 # Hold jobs in the gearman queue so that we can test whether
987 # the executor returns a merge failure after the scheduler has
988 # successfully merged.
989 self.gearman_server.hold_jobs_in_queue = True
990 A = self.fake_gerrit.addFakeChange('org/project',
991 'master', 'A',
992 files={'conflict': 'foo'})
993 B = self.fake_gerrit.addFakeChange('org/project',
994 'master', 'B',
995 files={'conflict': 'bar'})
996 C = self.fake_gerrit.addFakeChange('org/project',
997 'master', 'C')
998 C.setDependsOn(B, 1)
999
1000 # A enters the gate queue; B and C enter the check queue
1001 A.addApproval('code-review', 2)
1002 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1003 self.waitUntilSettled()
1004 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1005 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1006 self.waitUntilSettled()
1007
1008 self.assertEqual(A.reported, 1)
1009 self.assertEqual(B.reported, 0) # Check does not report start
1010 self.assertEqual(C.reported, 0) # Check does not report start
1011
1012 # A merges while B and C are queued in check
1013 # Release A project-merge
1014 queue = self.gearman_server.getQueue()
1015 self.release(queue[0])
1016 self.waitUntilSettled()
1017
1018 # Release A project-test*
1019 # gate has higher precedence, so A's test jobs are added in
1020 # front of the merge jobs for B and C
1021 queue = self.gearman_server.getQueue()
1022 self.release(queue[0])
1023 self.release(queue[1])
1024 self.waitUntilSettled()
1025
1026 self.assertEqual(A.data['status'], 'MERGED')
1027 self.assertEqual(B.data['status'], 'NEW')
1028 self.assertEqual(C.data['status'], 'NEW')
1029 self.assertEqual(A.reported, 2)
1030 self.assertEqual(B.reported, 0)
1031 self.assertEqual(C.reported, 0)
1032 self.assertHistory([
1033 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1034 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1035 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1036 ], ordered=False)
1037
1038 # B and C report merge conflicts
1039 # Release B project-merge
1040 queue = self.gearman_server.getQueue()
1041 self.release(queue[0])
1042 self.waitUntilSettled()
1043
1044 # Release C
1045 self.gearman_server.hold_jobs_in_queue = False
1046 self.gearman_server.release()
1047 self.waitUntilSettled()
1048
1049 self.assertEqual(A.data['status'], 'MERGED')
1050 self.assertEqual(B.data['status'], 'NEW')
1051 self.assertEqual(C.data['status'], 'NEW')
1052 self.assertEqual(A.reported, 2)
1053 self.assertEqual(B.reported, 1)
1054 self.assertEqual(C.reported, 1)
1055
1056 self.assertHistory([
1057 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1058 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1059 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1060 dict(name='project-merge', result='MERGER_FAILURE', changes='2,1'),
1061 dict(name='project-merge', result='MERGER_FAILURE',
1062 changes='2,1 3,1'),
1063 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001064
James E. Blairdaabed22012-08-15 15:38:57 -07001065 def test_post(self):
1066 "Test that post jobs run"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001067
Zhongyue Luo5d556072012-09-21 02:00:47 +09001068 e = {
1069 "type": "ref-updated",
1070 "submitter": {
1071 "name": "User Name",
1072 },
1073 "refUpdate": {
1074 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1075 "newRev": "d479a0bfcb34da57a31adb2a595c0cf687812543",
1076 "refName": "master",
1077 "project": "org/project",
1078 }
1079 }
James E. Blairdaabed22012-08-15 15:38:57 -07001080 self.fake_gerrit.addEvent(e)
1081 self.waitUntilSettled()
1082
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001083 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001084 self.assertEqual(len(self.history), 1)
1085 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001086
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001087 def test_post_ignore_deletes(self):
1088 "Test that deleting refs does not trigger post jobs"
1089
1090 e = {
1091 "type": "ref-updated",
1092 "submitter": {
1093 "name": "User Name",
1094 },
1095 "refUpdate": {
1096 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1097 "newRev": "0000000000000000000000000000000000000000",
1098 "refName": "master",
1099 "project": "org/project",
1100 }
1101 }
1102 self.fake_gerrit.addEvent(e)
1103 self.waitUntilSettled()
1104
1105 job_names = [x.name for x in self.history]
1106 self.assertEqual(len(self.history), 0)
1107 self.assertNotIn('project-post', job_names)
1108
James E. Blaircc324192017-04-19 14:36:08 -07001109 @simple_layout('layouts/dont-ignore-ref-deletes.yaml')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001110 def test_post_ignore_deletes_negative(self):
1111 "Test that deleting refs does trigger post jobs"
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001112 e = {
1113 "type": "ref-updated",
1114 "submitter": {
1115 "name": "User Name",
1116 },
1117 "refUpdate": {
1118 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1119 "newRev": "0000000000000000000000000000000000000000",
1120 "refName": "master",
1121 "project": "org/project",
1122 }
1123 }
1124 self.fake_gerrit.addEvent(e)
1125 self.waitUntilSettled()
1126
1127 job_names = [x.name for x in self.history]
1128 self.assertEqual(len(self.history), 1)
1129 self.assertIn('project-post', job_names)
1130
James E. Blairec056492016-07-22 09:45:56 -07001131 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001132 def test_build_configuration_branch_interaction(self):
1133 "Test that switching between branches works"
1134 self.test_build_configuration()
1135 self.test_build_configuration_branch()
1136 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001137 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001138 repo = git.Repo(path)
1139 repo.heads.master.commit = repo.commit('init')
1140 self.test_build_configuration()
1141
James E. Blaircaec0c52012-08-22 14:52:22 -07001142 def test_dependent_changes_dequeue(self):
1143 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001144
James E. Blaircaec0c52012-08-22 14:52:22 -07001145 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1146 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1147 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001148 A.addApproval('code-review', 2)
1149 B.addApproval('code-review', 2)
1150 C.addApproval('code-review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001151
1152 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1153 M1.setMerged()
1154
1155 # C -> B -> A -> M1
1156
1157 C.setDependsOn(B, 1)
1158 B.setDependsOn(A, 1)
1159 A.setDependsOn(M1, 1)
1160
Paul Belanger174a8272017-03-14 13:20:10 -04001161 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001162
James E. Blair8b5408c2016-08-08 15:37:46 -07001163 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1164 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1165 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001166
1167 self.waitUntilSettled()
1168
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001169 self.assertEqual(A.data['status'], 'NEW')
1170 self.assertEqual(A.reported, 2)
1171 self.assertEqual(B.data['status'], 'NEW')
1172 self.assertEqual(B.reported, 2)
1173 self.assertEqual(C.data['status'], 'NEW')
1174 self.assertEqual(C.reported, 2)
1175 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001176
James E. Blair972e3c72013-08-29 12:04:55 -07001177 def test_failing_dependent_changes(self):
1178 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001179 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001180 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1181 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1182 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1183 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1184 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
James E. Blair8b5408c2016-08-08 15:37:46 -07001185 A.addApproval('code-review', 2)
1186 B.addApproval('code-review', 2)
1187 C.addApproval('code-review', 2)
1188 D.addApproval('code-review', 2)
1189 E.addApproval('code-review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001190
1191 # E, D -> C -> B, A
1192
1193 D.setDependsOn(C, 1)
1194 C.setDependsOn(B, 1)
1195
Paul Belanger174a8272017-03-14 13:20:10 -04001196 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001197
James E. Blair8b5408c2016-08-08 15:37:46 -07001198 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1199 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
1200 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1201 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1202 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001203
1204 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001205 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001206 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001207 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001208 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001209 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001210 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001211 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001212 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001213 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001214 self.waitUntilSettled()
1215
Paul Belanger174a8272017-03-14 13:20:10 -04001216 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001217 for build in self.builds:
1218 if build.parameters['ZUUL_CHANGE'] != '1':
1219 build.release()
1220 self.waitUntilSettled()
1221
Paul Belanger174a8272017-03-14 13:20:10 -04001222 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001223 self.waitUntilSettled()
1224
1225 self.assertEqual(A.data['status'], 'MERGED')
1226 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001227 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001228 self.assertEqual(B.data['status'], 'NEW')
1229 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001230 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001231 self.assertEqual(C.data['status'], 'NEW')
1232 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001233 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001234 self.assertEqual(D.data['status'], 'NEW')
1235 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001236 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001237 self.assertEqual(E.data['status'], 'MERGED')
1238 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001239 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001240 self.assertEqual(len(self.history), 18)
1241
James E. Blairec590122012-08-22 15:19:31 -07001242 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001243 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001244 # If it's dequeued more than once, we should see extra
1245 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001246
Paul Belanger174a8272017-03-14 13:20:10 -04001247 self.executor_server.hold_jobs_in_build = True
James E. Blair6df67132017-04-19 13:53:20 -07001248 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1249 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1250 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001251 A.addApproval('code-review', 2)
1252 B.addApproval('code-review', 2)
1253 C.addApproval('code-review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001254
Paul Belanger174a8272017-03-14 13:20:10 -04001255 self.executor_server.failJob('project-test1', A)
1256 self.executor_server.failJob('project-test2', A)
James E. Blairec590122012-08-22 15:19:31 -07001257
James E. Blair8b5408c2016-08-08 15:37:46 -07001258 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1259 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1260 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001261
1262 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001263
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001264 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001265 self.assertEqual(self.builds[0].name, 'project-merge')
1266 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001267
Paul Belanger174a8272017-03-14 13:20:10 -04001268 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001269 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001270 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001271 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001272 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001273 self.waitUntilSettled()
1274
James E. Blair6df67132017-04-19 13:53:20 -07001275 self.assertEqual(len(self.builds), 6)
Paul Belanger58bf6912016-11-11 19:36:01 -05001276 self.assertEqual(self.builds[0].name, 'project-test1')
1277 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair6df67132017-04-19 13:53:20 -07001278 self.assertEqual(self.builds[2].name, 'project-test1')
1279 self.assertEqual(self.builds[3].name, 'project-test2')
1280 self.assertEqual(self.builds[4].name, 'project-test1')
1281 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blairec590122012-08-22 15:19:31 -07001282
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001283 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001284 self.waitUntilSettled()
1285
James E. Blair6df67132017-04-19 13:53:20 -07001286 self.assertEqual(len(self.builds), 2) # test2, merge for B
1287 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
James E. Blairec590122012-08-22 15:19:31 -07001288
Paul Belanger174a8272017-03-14 13:20:10 -04001289 self.executor_server.hold_jobs_in_build = False
1290 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001291 self.waitUntilSettled()
1292
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001293 self.assertEqual(len(self.builds), 0)
James E. Blair6df67132017-04-19 13:53:20 -07001294 self.assertEqual(len(self.history), 15)
James E. Blaircaec0c52012-08-22 14:52:22 -07001295
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001296 self.assertEqual(A.data['status'], 'NEW')
1297 self.assertEqual(B.data['status'], 'MERGED')
1298 self.assertEqual(C.data['status'], 'MERGED')
1299 self.assertEqual(A.reported, 2)
1300 self.assertEqual(B.reported, 2)
1301 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001302
James E. Blaircc020532017-04-19 13:04:44 -07001303 @simple_layout('layouts/nonvoting-job.yaml')
James E. Blair4ec821f2012-08-23 15:28:28 -07001304 def test_nonvoting_job(self):
1305 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001306
James E. Blair4ec821f2012-08-23 15:28:28 -07001307 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1308 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001309 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001310 self.executor_server.failJob('nonvoting-project-test2', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07001311 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001312
1313 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001314
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001315 self.assertEqual(A.data['status'], 'MERGED')
1316 self.assertEqual(A.reported, 2)
1317 self.assertEqual(
1318 self.getJobFromHistory('nonvoting-project-merge').result,
1319 'SUCCESS')
1320 self.assertEqual(
1321 self.getJobFromHistory('nonvoting-project-test1').result,
1322 'SUCCESS')
1323 self.assertEqual(
1324 self.getJobFromHistory('nonvoting-project-test2').result,
1325 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001326
James E. Blair5821bd92015-09-16 08:48:15 -07001327 for build in self.builds:
1328 self.assertEqual(build.parameters['ZUUL_VOTING'], '0')
1329
James E. Blaire0487072012-08-29 17:38:31 -07001330 def test_check_queue_success(self):
1331 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001332
James E. Blaire0487072012-08-29 17:38:31 -07001333 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1334 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1335
1336 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001337
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001338 self.assertEqual(A.data['status'], 'NEW')
1339 self.assertEqual(A.reported, 1)
1340 self.assertEqual(self.getJobFromHistory('project-merge').result,
1341 'SUCCESS')
1342 self.assertEqual(self.getJobFromHistory('project-test1').result,
1343 'SUCCESS')
1344 self.assertEqual(self.getJobFromHistory('project-test2').result,
1345 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001346
1347 def test_check_queue_failure(self):
1348 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001349
James E. Blaire0487072012-08-29 17:38:31 -07001350 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001351 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001352 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1353
1354 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001355
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001356 self.assertEqual(A.data['status'], 'NEW')
1357 self.assertEqual(A.reported, 1)
1358 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001359 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001360 self.assertEqual(self.getJobFromHistory('project-test1').result,
1361 'SUCCESS')
1362 self.assertEqual(self.getJobFromHistory('project-test2').result,
1363 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001364
James E. Blair7cb84542017-04-19 13:35:05 -07001365 @simple_layout('layouts/three-projects.yaml')
James E. Blair127bc182012-08-28 15:55:15 -07001366 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001367 # This particular test does a large amount of merges and needs a little
1368 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001369 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001370 "test that dependent changes behind dequeued changes work"
1371 # This complicated test is a reproduction of a real life bug
1372 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001373
Paul Belanger174a8272017-03-14 13:20:10 -04001374 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001375 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1376 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1377 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1378 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1379 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1380 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1381 D.setDependsOn(C, 1)
1382 E.setDependsOn(D, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07001383 A.addApproval('code-review', 2)
1384 B.addApproval('code-review', 2)
1385 C.addApproval('code-review', 2)
1386 D.addApproval('code-review', 2)
1387 E.addApproval('code-review', 2)
1388 F.addApproval('code-review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001389
1390 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001391
1392 # Change object re-use in the gerrit trigger is hidden if
1393 # changes are added in quick succession; waiting makes it more
1394 # like real life.
James E. Blair8b5408c2016-08-08 15:37:46 -07001395 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001396 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001397 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001398 self.waitUntilSettled()
1399
Paul Belanger174a8272017-03-14 13:20:10 -04001400 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001401 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001402 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001403 self.waitUntilSettled()
1404
James E. Blair8b5408c2016-08-08 15:37:46 -07001405 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001406 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001407 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001408 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001409 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001410 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001411 self.fake_gerrit.addEvent(F.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001412 self.waitUntilSettled()
1413
Paul Belanger174a8272017-03-14 13:20:10 -04001414 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001415 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001416 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001417 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001418 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001419 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001420 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001421 self.waitUntilSettled()
1422
1423 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001424
1425 # Grab pointers to the jobs we want to release before
1426 # releasing any, because list indexes may change as
1427 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001428 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001429 a.release()
1430 b.release()
1431 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001432 self.waitUntilSettled()
1433
Paul Belanger174a8272017-03-14 13:20:10 -04001434 self.executor_server.hold_jobs_in_build = False
1435 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001436 self.waitUntilSettled()
1437
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001438 self.assertEqual(A.data['status'], 'NEW')
1439 self.assertEqual(B.data['status'], 'MERGED')
1440 self.assertEqual(C.data['status'], 'MERGED')
1441 self.assertEqual(D.data['status'], 'MERGED')
1442 self.assertEqual(E.data['status'], 'MERGED')
1443 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001444
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001445 self.assertEqual(A.reported, 2)
1446 self.assertEqual(B.reported, 2)
1447 self.assertEqual(C.reported, 2)
1448 self.assertEqual(D.reported, 2)
1449 self.assertEqual(E.reported, 2)
1450 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001451
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001452 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1453 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001454
1455 def test_merger_repack(self):
1456 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001457
James E. Blair05fed602012-09-07 12:45:24 -07001458 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001459 A.addApproval('code-review', 2)
1460 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001461 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001462 self.assertEqual(self.getJobFromHistory('project-merge').result,
1463 'SUCCESS')
1464 self.assertEqual(self.getJobFromHistory('project-test1').result,
1465 'SUCCESS')
1466 self.assertEqual(self.getJobFromHistory('project-test2').result,
1467 'SUCCESS')
1468 self.assertEqual(A.data['status'], 'MERGED')
1469 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001470 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001471 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001472
James E. Blair2a535672017-04-27 12:03:15 -07001473 path = os.path.join(self.merger_src_root, "review.example.com",
1474 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001475 if os.path.exists(path):
1476 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001477 path = os.path.join(self.executor_src_root, "review.example.com",
1478 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001479 if os.path.exists(path):
1480 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001481
1482 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001483 A.addApproval('code-review', 2)
1484 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001485 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001486 self.assertEqual(self.getJobFromHistory('project-merge').result,
1487 'SUCCESS')
1488 self.assertEqual(self.getJobFromHistory('project-test1').result,
1489 'SUCCESS')
1490 self.assertEqual(self.getJobFromHistory('project-test2').result,
1491 'SUCCESS')
1492 self.assertEqual(A.data['status'], 'MERGED')
1493 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001494
James E. Blair4886f282012-11-15 09:27:33 -08001495 def test_merger_repack_large_change(self):
1496 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001497 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001498 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001499 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6df67132017-04-19 13:53:20 -07001500 trusted, project = tenant.getProject('org/project')
James E. Blair0ffa0102017-03-30 13:11:33 -07001501 url = self.fake_gerrit.getGitUrl(project)
James E. Blair2a535672017-04-27 12:03:15 -07001502 self.merge_server.merger._addProject('review.example.com',
1503 'org/project', url)
James E. Blair6df67132017-04-19 13:53:20 -07001504 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair4886f282012-11-15 09:27:33 -08001505 A.addPatchset(large=True)
James E. Blair2a535672017-04-27 12:03:15 -07001506 # TODOv3(jeblair): add hostname to upstream root
1507 path = os.path.join(self.upstream_root, 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001508 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001509 path = os.path.join(self.merger_src_root, 'review.example.com',
1510 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001511 if os.path.exists(path):
1512 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001513 path = os.path.join(self.executor_src_root, 'review.example.com',
1514 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001515 if os.path.exists(path):
1516 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001517
James E. Blair8b5408c2016-08-08 15:37:46 -07001518 A.addApproval('code-review', 2)
1519 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001520 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001521 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001522 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001523 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001524 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001525 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001526 'SUCCESS')
1527 self.assertEqual(A.data['status'], 'MERGED')
1528 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001529
James E. Blair2fa50962013-01-30 21:50:41 -08001530 def test_new_patchset_dequeues_old(self):
1531 "Test that a new patchset causes the old to be dequeued"
1532 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001533 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001534 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1535 M.setMerged()
1536
1537 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1538 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1539 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1540 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001541 A.addApproval('code-review', 2)
1542 B.addApproval('code-review', 2)
1543 C.addApproval('code-review', 2)
1544 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001545
1546 C.setDependsOn(B, 1)
1547 B.setDependsOn(A, 1)
1548 A.setDependsOn(M, 1)
1549
James E. Blair8b5408c2016-08-08 15:37:46 -07001550 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1551 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1552 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1553 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001554 self.waitUntilSettled()
1555
1556 B.addPatchset()
1557 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1558 self.waitUntilSettled()
1559
Paul Belanger174a8272017-03-14 13:20:10 -04001560 self.executor_server.hold_jobs_in_build = False
1561 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001562 self.waitUntilSettled()
1563
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001564 self.assertEqual(A.data['status'], 'MERGED')
1565 self.assertEqual(A.reported, 2)
1566 self.assertEqual(B.data['status'], 'NEW')
1567 self.assertEqual(B.reported, 2)
1568 self.assertEqual(C.data['status'], 'NEW')
1569 self.assertEqual(C.reported, 2)
1570 self.assertEqual(D.data['status'], 'MERGED')
1571 self.assertEqual(D.reported, 2)
1572 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001573
James E. Blairba437362015-02-07 11:41:52 -08001574 def test_new_patchset_check(self):
1575 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001576
Paul Belanger174a8272017-03-14 13:20:10 -04001577 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001578
1579 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001580 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001581 tenant = self.sched.abide.tenants.get('tenant-one')
1582 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001583
1584 # Add two git-dependent changes
1585 B.setDependsOn(A, 1)
1586 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1587 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001588 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1589 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001590
1591 # A live item, and a non-live/live pair
1592 items = check_pipeline.getAllItems()
1593 self.assertEqual(len(items), 3)
1594
1595 self.assertEqual(items[0].change.number, '1')
1596 self.assertEqual(items[0].change.patchset, '1')
1597 self.assertFalse(items[0].live)
1598
1599 self.assertEqual(items[1].change.number, '2')
1600 self.assertEqual(items[1].change.patchset, '1')
1601 self.assertTrue(items[1].live)
1602
1603 self.assertEqual(items[2].change.number, '1')
1604 self.assertEqual(items[2].change.patchset, '1')
1605 self.assertTrue(items[2].live)
1606
1607 # Add a new patchset to A
1608 A.addPatchset()
1609 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1610 self.waitUntilSettled()
1611
1612 # The live copy of A,1 should be gone, but the non-live and B
1613 # should continue, and we should have a new A,2
1614 items = check_pipeline.getAllItems()
1615 self.assertEqual(len(items), 3)
1616
1617 self.assertEqual(items[0].change.number, '1')
1618 self.assertEqual(items[0].change.patchset, '1')
1619 self.assertFalse(items[0].live)
1620
1621 self.assertEqual(items[1].change.number, '2')
1622 self.assertEqual(items[1].change.patchset, '1')
1623 self.assertTrue(items[1].live)
1624
1625 self.assertEqual(items[2].change.number, '1')
1626 self.assertEqual(items[2].change.patchset, '2')
1627 self.assertTrue(items[2].live)
1628
1629 # Add a new patchset to B
1630 B.addPatchset()
1631 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1632 self.waitUntilSettled()
1633
1634 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1635 # but we should have a new B,2 (still based on A,1)
1636 items = check_pipeline.getAllItems()
1637 self.assertEqual(len(items), 3)
1638
1639 self.assertEqual(items[0].change.number, '1')
1640 self.assertEqual(items[0].change.patchset, '2')
1641 self.assertTrue(items[0].live)
1642
1643 self.assertEqual(items[1].change.number, '1')
1644 self.assertEqual(items[1].change.patchset, '1')
1645 self.assertFalse(items[1].live)
1646
1647 self.assertEqual(items[2].change.number, '2')
1648 self.assertEqual(items[2].change.patchset, '2')
1649 self.assertTrue(items[2].live)
1650
1651 self.builds[0].release()
1652 self.waitUntilSettled()
1653 self.builds[0].release()
1654 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001655 self.executor_server.hold_jobs_in_build = False
1656 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001657 self.waitUntilSettled()
1658
1659 self.assertEqual(A.reported, 1)
1660 self.assertEqual(B.reported, 1)
1661 self.assertEqual(self.history[0].result, 'ABORTED')
1662 self.assertEqual(self.history[0].changes, '1,1')
1663 self.assertEqual(self.history[1].result, 'ABORTED')
1664 self.assertEqual(self.history[1].changes, '1,1 2,1')
1665 self.assertEqual(self.history[2].result, 'SUCCESS')
1666 self.assertEqual(self.history[2].changes, '1,2')
1667 self.assertEqual(self.history[3].result, 'SUCCESS')
1668 self.assertEqual(self.history[3].changes, '1,1 2,2')
1669
1670 def test_abandoned_gate(self):
1671 "Test that an abandoned change is dequeued from gate"
1672
Paul Belanger174a8272017-03-14 13:20:10 -04001673 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001674
1675 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001676 A.addApproval('code-review', 2)
1677 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001678 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001679 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1680 self.assertEqual(self.builds[0].name, 'project-merge')
1681
1682 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1683 self.waitUntilSettled()
1684
Paul Belanger174a8272017-03-14 13:20:10 -04001685 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001686 self.waitUntilSettled()
1687
Arie5b4048c2016-10-05 16:12:06 +03001688 self.assertBuilds([])
1689 self.assertHistory([
1690 dict(name='project-merge', result='ABORTED', changes='1,1')],
1691 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001692 self.assertEqual(A.reported, 1,
1693 "Abandoned gate change should report only start")
1694
1695 def test_abandoned_check(self):
1696 "Test that an abandoned change is dequeued from check"
1697
Paul Belanger174a8272017-03-14 13:20:10 -04001698 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001699
1700 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1701 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001702 tenant = self.sched.abide.tenants.get('tenant-one')
1703 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001704
1705 # Add two git-dependent changes
1706 B.setDependsOn(A, 1)
1707 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1708 self.waitUntilSettled()
1709 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1710 self.waitUntilSettled()
1711 # A live item, and a non-live/live pair
1712 items = check_pipeline.getAllItems()
1713 self.assertEqual(len(items), 3)
1714
1715 self.assertEqual(items[0].change.number, '1')
1716 self.assertFalse(items[0].live)
1717
1718 self.assertEqual(items[1].change.number, '2')
1719 self.assertTrue(items[1].live)
1720
1721 self.assertEqual(items[2].change.number, '1')
1722 self.assertTrue(items[2].live)
1723
1724 # Abandon A
1725 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1726 self.waitUntilSettled()
1727
1728 # The live copy of A should be gone, but the non-live and B
1729 # should continue
1730 items = check_pipeline.getAllItems()
1731 self.assertEqual(len(items), 2)
1732
1733 self.assertEqual(items[0].change.number, '1')
1734 self.assertFalse(items[0].live)
1735
1736 self.assertEqual(items[1].change.number, '2')
1737 self.assertTrue(items[1].live)
1738
Paul Belanger174a8272017-03-14 13:20:10 -04001739 self.executor_server.hold_jobs_in_build = False
1740 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001741 self.waitUntilSettled()
1742
1743 self.assertEqual(len(self.history), 4)
1744 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001745 'Build should have been aborted')
1746 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001747 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001748
Steve Varnau7b78b312015-04-03 14:49:46 -07001749 def test_abandoned_not_timer(self):
1750 "Test that an abandoned change does not cancel timer jobs"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001751 # This test can not use simple_layout because it must start
1752 # with a configuration which does not include a
1753 # timer-triggered job so that we have an opportunity to set
1754 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04001755 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001756 # Start timer trigger - also org/project
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001757 self.commitConfigUpdate('common-config', 'layouts/idle.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001758 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001759 # The pipeline triggers every second, so we should have seen
1760 # several by now.
1761 time.sleep(5)
1762 self.waitUntilSettled()
1763 # Stop queuing timer triggered jobs so that the assertions
1764 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001765 # Must be in same repo, so overwrite config with another one
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001766 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001767 self.sched.reconfigure(self.config)
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001768
Steve Varnau7b78b312015-04-03 14:49:46 -07001769 self.assertEqual(len(self.builds), 2, "Two timer jobs")
1770
1771 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1772 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1773 self.waitUntilSettled()
1774 self.assertEqual(len(self.builds), 3, "One change plus two timer jobs")
1775
1776 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1777 self.waitUntilSettled()
1778
1779 self.assertEqual(len(self.builds), 2, "Two timer jobs remain")
1780
Paul Belanger174a8272017-03-14 13:20:10 -04001781 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001782 self.waitUntilSettled()
1783
Arx Cruzb1b010d2013-10-28 19:49:59 -02001784 def test_zuul_url_return(self):
1785 "Test if ZUUL_URL is returning when zuul_url is set in zuul.conf"
James E. Blair4076e2b2014-01-28 12:42:20 -08001786 self.assertTrue(self.sched.config.has_option('merger', 'zuul_url'))
Paul Belanger174a8272017-03-14 13:20:10 -04001787 self.executor_server.hold_jobs_in_build = True
Arx Cruzb1b010d2013-10-28 19:49:59 -02001788
1789 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001790 A.addApproval('code-review', 2)
1791 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Arx Cruzb1b010d2013-10-28 19:49:59 -02001792 self.waitUntilSettled()
1793
1794 self.assertEqual(len(self.builds), 1)
1795 for build in self.builds:
1796 self.assertTrue('ZUUL_URL' in build.parameters)
1797
Paul Belanger174a8272017-03-14 13:20:10 -04001798 self.executor_server.hold_jobs_in_build = False
1799 self.executor_server.release()
Arx Cruzb1b010d2013-10-28 19:49:59 -02001800 self.waitUntilSettled()
1801
James E. Blair2fa50962013-01-30 21:50:41 -08001802 def test_new_patchset_dequeues_old_on_head(self):
1803 "Test that a new patchset causes the old to be dequeued (at head)"
1804 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001805 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001806 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1807 M.setMerged()
1808 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1809 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1810 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1811 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001812 A.addApproval('code-review', 2)
1813 B.addApproval('code-review', 2)
1814 C.addApproval('code-review', 2)
1815 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001816
1817 C.setDependsOn(B, 1)
1818 B.setDependsOn(A, 1)
1819 A.setDependsOn(M, 1)
1820
James E. Blair8b5408c2016-08-08 15:37:46 -07001821 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1822 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1823 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1824 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001825 self.waitUntilSettled()
1826
1827 A.addPatchset()
1828 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1829 self.waitUntilSettled()
1830
Paul Belanger174a8272017-03-14 13:20:10 -04001831 self.executor_server.hold_jobs_in_build = False
1832 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001833 self.waitUntilSettled()
1834
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001835 self.assertEqual(A.data['status'], 'NEW')
1836 self.assertEqual(A.reported, 2)
1837 self.assertEqual(B.data['status'], 'NEW')
1838 self.assertEqual(B.reported, 2)
1839 self.assertEqual(C.data['status'], 'NEW')
1840 self.assertEqual(C.reported, 2)
1841 self.assertEqual(D.data['status'], 'MERGED')
1842 self.assertEqual(D.reported, 2)
1843 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08001844
1845 def test_new_patchset_dequeues_old_without_dependents(self):
1846 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04001847 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001848 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1849 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1850 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001851 A.addApproval('code-review', 2)
1852 B.addApproval('code-review', 2)
1853 C.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001854
James E. Blair8b5408c2016-08-08 15:37:46 -07001855 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1856 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1857 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001858 self.waitUntilSettled()
1859
1860 B.addPatchset()
1861 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1862 self.waitUntilSettled()
1863
Paul Belanger174a8272017-03-14 13:20:10 -04001864 self.executor_server.hold_jobs_in_build = False
1865 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001866 self.waitUntilSettled()
1867
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001868 self.assertEqual(A.data['status'], 'MERGED')
1869 self.assertEqual(A.reported, 2)
1870 self.assertEqual(B.data['status'], 'NEW')
1871 self.assertEqual(B.reported, 2)
1872 self.assertEqual(C.data['status'], 'MERGED')
1873 self.assertEqual(C.reported, 2)
1874 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08001875
1876 def test_new_patchset_dequeues_old_independent_queue(self):
1877 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04001878 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001879 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1880 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1881 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1882 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1883 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1884 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1885 self.waitUntilSettled()
1886
1887 B.addPatchset()
1888 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1889 self.waitUntilSettled()
1890
Paul Belanger174a8272017-03-14 13:20:10 -04001891 self.executor_server.hold_jobs_in_build = False
1892 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001893 self.waitUntilSettled()
1894
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001895 self.assertEqual(A.data['status'], 'NEW')
1896 self.assertEqual(A.reported, 1)
1897 self.assertEqual(B.data['status'], 'NEW')
1898 self.assertEqual(B.reported, 1)
1899 self.assertEqual(C.data['status'], 'NEW')
1900 self.assertEqual(C.reported, 1)
1901 self.assertEqual(len(self.history), 10)
1902 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001903
James E. Blaircc020532017-04-19 13:04:44 -07001904 @simple_layout('layouts/noop-job.yaml')
James E. Blair18c64442014-03-18 10:14:45 -07001905 def test_noop_job(self):
1906 "Test that the internal noop job works"
1907 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001908 A.addApproval('code-review', 2)
1909 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07001910 self.waitUntilSettled()
1911
1912 self.assertEqual(len(self.gearman_server.getQueue()), 0)
1913 self.assertTrue(self.sched._areAllBuildsComplete())
1914 self.assertEqual(len(self.history), 0)
1915 self.assertEqual(A.data['status'], 'MERGED')
1916 self.assertEqual(A.reported, 2)
1917
James E. Blair06cc3922017-04-19 10:08:10 -07001918 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001919 def test_no_job_project(self):
1920 "Test that reports with no jobs don't get sent"
1921 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
1922 'master', 'A')
1923 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1924 self.waitUntilSettled()
1925
1926 # Change wasn't reported to
1927 self.assertEqual(A.reported, False)
1928
1929 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08001930 tenant = self.sched.abide.tenants.get('tenant-one')
1931 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001932 items = check_pipeline.getAllItems()
1933 self.assertEqual(len(items), 0)
1934
1935 self.assertEqual(len(self.history), 0)
1936
James E. Blair7d0dedc2013-02-21 17:26:09 -08001937 def test_zuul_refs(self):
1938 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04001939 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08001940 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
1941 M1.setMerged()
1942 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
1943 M2.setMerged()
1944
1945 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1946 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1947 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1948 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001949 A.addApproval('code-review', 2)
1950 B.addApproval('code-review', 2)
1951 C.addApproval('code-review', 2)
1952 D.addApproval('code-review', 2)
1953 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1954 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1955 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1956 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001957
1958 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001959 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001960 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001961 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001962 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001963 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001964 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001965 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001966 self.waitUntilSettled()
1967
James E. Blair7d0dedc2013-02-21 17:26:09 -08001968 a_zref = b_zref = c_zref = d_zref = None
Clint Byrum3343e3e2016-11-15 16:05:03 -08001969 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001970 for x in self.builds:
James E. Blair7d0dedc2013-02-21 17:26:09 -08001971 if x.parameters['ZUUL_CHANGE'] == '3':
1972 a_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001973 a_build = x
1974 elif x.parameters['ZUUL_CHANGE'] == '4':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001975 b_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001976 b_build = x
1977 elif x.parameters['ZUUL_CHANGE'] == '5':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001978 c_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001979 c_build = x
1980 elif x.parameters['ZUUL_CHANGE'] == '6':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001981 d_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001982 d_build = x
1983 if a_build and b_build and c_build and d_build:
1984 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08001985
1986 # There are... four... refs.
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001987 self.assertIsNotNone(a_zref)
1988 self.assertIsNotNone(b_zref)
1989 self.assertIsNotNone(c_zref)
1990 self.assertIsNotNone(d_zref)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001991
1992 # And they should all be different
1993 refs = set([a_zref, b_zref, c_zref, d_zref])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001994 self.assertEqual(len(refs), 4)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001995
Clint Byrum3343e3e2016-11-15 16:05:03 -08001996 # should have a, not b, and should not be in project2
1997 self.assertTrue(a_build.hasChanges(A))
1998 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001999
Clint Byrum3343e3e2016-11-15 16:05:03 -08002000 # should have a and b, and should not be in project2
2001 self.assertTrue(b_build.hasChanges(A, B))
2002 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002003
Clint Byrum3343e3e2016-11-15 16:05:03 -08002004 # should have a and b in 1, c in 2
2005 self.assertTrue(c_build.hasChanges(A, B, C))
2006 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002007
Clint Byrum3343e3e2016-11-15 16:05:03 -08002008 # should have a and b in 1, c and d in 2
2009 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002010
Paul Belanger174a8272017-03-14 13:20:10 -04002011 self.executor_server.hold_jobs_in_build = False
2012 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002013 self.waitUntilSettled()
2014
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002015 self.assertEqual(A.data['status'], 'MERGED')
2016 self.assertEqual(A.reported, 2)
2017 self.assertEqual(B.data['status'], 'MERGED')
2018 self.assertEqual(B.reported, 2)
2019 self.assertEqual(C.data['status'], 'MERGED')
2020 self.assertEqual(C.reported, 2)
2021 self.assertEqual(D.data['status'], 'MERGED')
2022 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002023
James E. Blair4a28a882013-08-23 15:17:33 -07002024 def test_rerun_on_error(self):
2025 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002026 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002027 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002028 A.addApproval('code-review', 2)
2029 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002030 self.waitUntilSettled()
2031
James E. Blair412fba82017-01-26 15:00:50 -08002032 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002033 self.executor_server.hold_jobs_in_build = False
2034 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002035 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002036 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002037 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2038
James E. Blair412e5582013-04-22 15:50:12 -07002039 def test_statsd(self):
2040 "Test each of the statsd methods used in the scheduler"
2041 import extras
2042 statsd = extras.try_import('statsd.statsd')
2043 statsd.incr('test-incr')
2044 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002045 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002046 self.assertReportedStat('test-incr', '1|c')
2047 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002048 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002049
James E. Blairdad52252014-02-07 16:59:17 -08002050 def test_stuck_job_cleanup(self):
2051 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002052
2053 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002054 self.gearman_server.hold_jobs_in_queue = True
2055 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002056 A.addApproval('code-review', 2)
2057 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002058 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002059 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002060 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2061
James E. Blair31cb3e82017-04-20 13:08:56 -07002062 self.commitConfigUpdate('common-config', 'layouts/no-jobs.yaml')
James E. Blairdad52252014-02-07 16:59:17 -08002063 self.sched.reconfigure(self.config)
2064 self.waitUntilSettled()
2065
James E. Blair18c64442014-03-18 10:14:45 -07002066 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002067 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002068 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002069 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2070 self.assertTrue(self.sched._areAllBuildsComplete())
2071
2072 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002073 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002074 self.assertEqual(self.history[0].result, 'SUCCESS')
2075
James E. Blair879dafb2015-07-17 14:04:49 -07002076 def test_file_head(self):
2077 # This is a regression test for an observed bug. A change
2078 # with a file named "HEAD" in the root directory of the repo
2079 # was processed by a merger. It then was unable to reset the
2080 # repo because of:
2081 # GitCommandError: 'git reset --hard HEAD' returned
2082 # with exit code 128
2083 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2084 # and filename
2085 # Use '--' to separate filenames from revisions'
2086
2087 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002088 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002089 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2090
2091 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2092 self.waitUntilSettled()
2093
2094 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2095 self.waitUntilSettled()
2096
2097 self.assertIn('Build succeeded', A.messages[0])
2098 self.assertIn('Build succeeded', B.messages[0])
2099
James E. Blair70c71582013-03-06 08:50:50 -08002100 def test_file_jobs(self):
2101 "Test that file jobs run only when appropriate"
2102 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002103 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002104 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07002105 A.addApproval('code-review', 2)
2106 B.addApproval('code-review', 2)
2107 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2108 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002109 self.waitUntilSettled()
2110
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002111 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002112 if x.name == 'project-testfile']
2113
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002114 self.assertEqual(len(testfile_jobs), 1)
2115 self.assertEqual(testfile_jobs[0].changes, '1,2')
2116 self.assertEqual(A.data['status'], 'MERGED')
2117 self.assertEqual(A.reported, 2)
2118 self.assertEqual(B.data['status'], 'MERGED')
2119 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002120
Clint Byrum3ee39f32016-11-17 23:45:07 -08002121 def _test_irrelevant_files_jobs(self, should_skip):
2122 "Test that jobs with irrelevant-files filter run only when appropriate"
Clint Byrum3ee39f32016-11-17 23:45:07 -08002123 if should_skip:
2124 files = {'ignoreme': 'ignored\n'}
2125 else:
2126 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002127
2128 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002129 'master',
2130 'test irrelevant-files',
2131 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002132 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2133 self.waitUntilSettled()
2134
2135 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002136 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002137
2138 if should_skip:
2139 self.assertEqual([], tested_change_ids)
2140 else:
2141 self.assertIn(change.data['number'], tested_change_ids)
2142
James E. Blaircc324192017-04-19 14:36:08 -07002143 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002144 def test_irrelevant_files_match_skips_job(self):
2145 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002146
James E. Blaircc324192017-04-19 14:36:08 -07002147 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002148 def test_irrelevant_files_no_match_runs_job(self):
2149 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002150
James E. Blaircc324192017-04-19 14:36:08 -07002151 @simple_layout('layouts/inheritance.yaml')
Clint Byrum85493602016-11-18 11:59:47 -08002152 def test_inherited_jobs_keep_matchers(self):
Clint Byrum85493602016-11-18 11:59:47 -08002153 files = {'ignoreme': 'ignored\n'}
2154
2155 change = self.fake_gerrit.addFakeChange('org/project',
2156 'master',
2157 'test irrelevant-files',
2158 files=files)
2159 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2160 self.waitUntilSettled()
2161
2162 run_jobs = set([build.name for build in self.history])
2163
2164 self.assertEqual(set(['project-test-nomatch-starts-empty',
2165 'project-test-nomatch-starts-full']), run_jobs)
2166
James E. Blairec056492016-07-22 09:45:56 -07002167 @skip("Disabled for early v3 development")
James E. Blair3c5e5b52013-04-26 11:17:03 -07002168 def test_test_config(self):
2169 "Test that we can test the config"
James E. Blairf84026c2015-12-08 16:11:46 -08002170 self.sched.testConfig(self.config.get('zuul', 'tenant_config'),
Joshua Hesketh352264b2015-08-11 23:42:08 +10002171 self.connections)
James E. Blair1f4c2bb2013-04-26 08:40:46 -07002172
James E. Blairc8a1e052014-02-25 09:29:26 -08002173 def test_queue_names(self):
2174 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002175 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002176 (trusted, project1) = tenant.getProject('org/project1')
2177 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002178 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2179 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2180 self.assertEqual(q1.name, 'integrated')
2181 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002182
James E. Blair64ed6f22013-07-10 14:07:23 -07002183 def test_queue_precedence(self):
2184 "Test that queue precedence works"
2185
2186 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002187 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002188 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2189 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
James E. Blair8b5408c2016-08-08 15:37:46 -07002190 A.addApproval('code-review', 2)
2191 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002192
2193 self.waitUntilSettled()
2194 self.gearman_server.hold_jobs_in_queue = False
2195 self.gearman_server.release()
2196 self.waitUntilSettled()
2197
James E. Blair8de58bd2013-07-18 16:23:33 -07002198 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002199 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002200 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002201 self.waitUntilSettled()
2202
James E. Blair64ed6f22013-07-10 14:07:23 -07002203 self.log.debug(self.history)
2204 self.assertEqual(self.history[0].pipeline, 'gate')
2205 self.assertEqual(self.history[1].pipeline, 'check')
2206 self.assertEqual(self.history[2].pipeline, 'gate')
2207 self.assertEqual(self.history[3].pipeline, 'gate')
2208 self.assertEqual(self.history[4].pipeline, 'check')
2209 self.assertEqual(self.history[5].pipeline, 'check')
2210
Clark Boylana5edbe42014-06-03 16:39:10 -07002211 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002212 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002213 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002214 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002215 A.addApproval('code-review', 2)
2216 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002217 self.waitUntilSettled()
2218
Paul Belanger174a8272017-03-14 13:20:10 -04002219 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002220 self.waitUntilSettled()
2221
James E. Blair1843a552013-07-03 14:19:52 -07002222 port = self.webapp.server.socket.getsockname()[1]
2223
Adam Gandelman77a12c72017-02-03 17:43:43 -08002224 req = urllib.request.Request(
2225 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002226 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002227 headers = f.info()
2228 self.assertIn('Content-Length', headers)
2229 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002230 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2231 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002232 self.assertIn('Access-Control-Allow-Origin', headers)
2233 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002234 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002235 self.assertIn('Expires', headers)
James E. Blair1843a552013-07-03 14:19:52 -07002236 data = f.read()
2237
Paul Belanger174a8272017-03-14 13:20:10 -04002238 self.executor_server.hold_jobs_in_build = False
2239 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002240 self.waitUntilSettled()
2241
2242 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002243 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002244 for p in data['pipelines']:
2245 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002246 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002247 self.assertEqual(q['window'], 20)
2248 else:
2249 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002250 for head in q['heads']:
2251 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002252 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002253 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002254 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002255 status_jobs.append(job)
2256 self.assertEqual('project-merge', status_jobs[0]['name'])
2257 self.assertEqual('https://server/job/project-merge/0/',
2258 status_jobs[0]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002259 self.assertEqual('https://server/job/project-merge/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002260 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002261 self.assertEqual('project-test1', status_jobs[1]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002262 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002263 status_jobs[1]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002264 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002265 status_jobs[1]['report_url'])
2266
2267 self.assertEqual('project-test2', status_jobs[2]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002268 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002269 status_jobs[2]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002270 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002271 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002272
James E. Blaircdccd972013-07-01 12:10:22 -07002273 def test_live_reconfiguration(self):
2274 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002275 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002276 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002277 A.addApproval('code-review', 2)
2278 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002279 self.waitUntilSettled()
2280
2281 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002282 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002283
Paul Belanger174a8272017-03-14 13:20:10 -04002284 self.executor_server.hold_jobs_in_build = False
2285 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002286 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002287 self.assertEqual(self.getJobFromHistory('project-merge').result,
2288 'SUCCESS')
2289 self.assertEqual(self.getJobFromHistory('project-test1').result,
2290 'SUCCESS')
2291 self.assertEqual(self.getJobFromHistory('project-test2').result,
2292 'SUCCESS')
2293 self.assertEqual(A.data['status'], 'MERGED')
2294 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002295
James E. Blair6bc782d2015-07-17 16:20:21 -07002296 def test_live_reconfiguration_merge_conflict(self):
2297 # A real-world bug: a change in a gate queue has a merge
2298 # conflict and a job is added to its project while it's
2299 # sitting in the queue. The job gets added to the change and
2300 # enqueued and the change gets stuck.
Paul Belanger174a8272017-03-14 13:20:10 -04002301 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002302
2303 # This change is fine. It's here to stop the queue long
2304 # enough for the next change to be subject to the
2305 # reconfiguration, as well as to provide a conflict for the
2306 # next change. This change will succeed and merge.
2307 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum073c00b2017-05-01 13:41:23 -07002308 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002309 A.addApproval('code-review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002310
2311 # This change will be in merge conflict. During the
2312 # reconfiguration, we will add a job. We want to make sure
2313 # that doesn't cause it to get stuck.
2314 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Clint Byrum073c00b2017-05-01 13:41:23 -07002315 B.addPatchset({'conflict': 'B'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002316 B.addApproval('code-review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002317
James E. Blair8b5408c2016-08-08 15:37:46 -07002318 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2319 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002320
2321 self.waitUntilSettled()
2322
2323 # No jobs have run yet
2324 self.assertEqual(A.data['status'], 'NEW')
2325 self.assertEqual(A.reported, 1)
2326 self.assertEqual(B.data['status'], 'NEW')
2327 self.assertEqual(B.reported, 1)
2328 self.assertEqual(len(self.history), 0)
2329
2330 # Add the "project-test3" job.
Clint Byrum073c00b2017-05-01 13:41:23 -07002331 self.commitConfigUpdate('common-config',
2332 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002333 self.sched.reconfigure(self.config)
2334 self.waitUntilSettled()
2335
Paul Belanger174a8272017-03-14 13:20:10 -04002336 self.executor_server.hold_jobs_in_build = False
2337 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002338 self.waitUntilSettled()
2339
2340 self.assertEqual(A.data['status'], 'MERGED')
2341 self.assertEqual(A.reported, 2)
2342 self.assertEqual(B.data['status'], 'NEW')
2343 self.assertEqual(B.reported, 2)
2344 self.assertEqual(self.getJobFromHistory('project-merge').result,
2345 'SUCCESS')
2346 self.assertEqual(self.getJobFromHistory('project-test1').result,
2347 'SUCCESS')
2348 self.assertEqual(self.getJobFromHistory('project-test2').result,
2349 'SUCCESS')
2350 self.assertEqual(self.getJobFromHistory('project-test3').result,
2351 'SUCCESS')
2352 self.assertEqual(len(self.history), 4)
2353
James E. Blair400e8fd2015-07-30 17:44:45 -07002354 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002355 # An extrapolation of test_live_reconfiguration_merge_conflict
2356 # that tests a job added to a job tree with a failed root does
2357 # not run.
Paul Belanger174a8272017-03-14 13:20:10 -04002358 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002359
2360 # This change is fine. It's here to stop the queue long
2361 # enough for the next change to be subject to the
2362 # reconfiguration. This change will succeed and merge.
2363 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum3147d652017-05-01 14:01:42 -07002364 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002365 A.addApproval('code-review', 2)
2366 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002367 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002368 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002369 self.waitUntilSettled()
2370
2371 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002372 self.executor_server.failJob('project-merge', B)
James E. Blair8b5408c2016-08-08 15:37:46 -07002373 B.addApproval('code-review', 2)
2374 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002375 self.waitUntilSettled()
2376
Paul Belanger174a8272017-03-14 13:20:10 -04002377 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002378 self.waitUntilSettled()
2379
2380 # Both -merge jobs have run, but no others.
2381 self.assertEqual(A.data['status'], 'NEW')
2382 self.assertEqual(A.reported, 1)
2383 self.assertEqual(B.data['status'], 'NEW')
2384 self.assertEqual(B.reported, 1)
2385 self.assertEqual(self.history[0].result, 'SUCCESS')
2386 self.assertEqual(self.history[0].name, 'project-merge')
2387 self.assertEqual(self.history[1].result, 'FAILURE')
2388 self.assertEqual(self.history[1].name, 'project-merge')
2389 self.assertEqual(len(self.history), 2)
2390
2391 # Add the "project-test3" job.
Clint Byrum3147d652017-05-01 14:01:42 -07002392 self.commitConfigUpdate('common-config',
2393 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002394 self.sched.reconfigure(self.config)
2395 self.waitUntilSettled()
2396
Paul Belanger174a8272017-03-14 13:20:10 -04002397 self.executor_server.hold_jobs_in_build = False
2398 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002399 self.waitUntilSettled()
2400
2401 self.assertEqual(A.data['status'], 'MERGED')
2402 self.assertEqual(A.reported, 2)
2403 self.assertEqual(B.data['status'], 'NEW')
2404 self.assertEqual(B.reported, 2)
2405 self.assertEqual(self.history[0].result, 'SUCCESS')
2406 self.assertEqual(self.history[0].name, 'project-merge')
2407 self.assertEqual(self.history[1].result, 'FAILURE')
2408 self.assertEqual(self.history[1].name, 'project-merge')
2409 self.assertEqual(self.history[2].result, 'SUCCESS')
2410 self.assertEqual(self.history[3].result, 'SUCCESS')
2411 self.assertEqual(self.history[4].result, 'SUCCESS')
2412 self.assertEqual(len(self.history), 5)
2413
James E. Blairec056492016-07-22 09:45:56 -07002414 @skip("Disabled for early v3 development")
James E. Blair400e8fd2015-07-30 17:44:45 -07002415 def test_live_reconfiguration_failed_job(self):
2416 # Test that a change with a removed failing job does not
2417 # disrupt reconfiguration. If a change has a failed job and
2418 # that job is removed during a reconfiguration, we observed a
2419 # bug where the code to re-set build statuses would run on
2420 # that build and raise an exception because the job no longer
2421 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002422 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002423
2424 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2425
2426 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002427 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002428
2429 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2430 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002431 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002432 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002433 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002434 self.waitUntilSettled()
2435
2436 self.assertEqual(A.data['status'], 'NEW')
2437 self.assertEqual(A.reported, 0)
2438
2439 self.assertEqual(self.getJobFromHistory('project-merge').result,
2440 'SUCCESS')
2441 self.assertEqual(self.getJobFromHistory('project-test1').result,
2442 'FAILURE')
2443 self.assertEqual(len(self.history), 2)
2444
2445 # Remove the test1 job.
James E. Blairf84026c2015-12-08 16:11:46 -08002446 self.updateConfigLayout(
2447 'tests/fixtures/layout-live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002448 self.sched.reconfigure(self.config)
2449 self.waitUntilSettled()
2450
Paul Belanger174a8272017-03-14 13:20:10 -04002451 self.executor_server.hold_jobs_in_build = False
2452 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002453 self.waitUntilSettled()
2454
2455 self.assertEqual(self.getJobFromHistory('project-test2').result,
2456 'SUCCESS')
2457 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2458 'SUCCESS')
2459 self.assertEqual(len(self.history), 4)
2460
2461 self.assertEqual(A.data['status'], 'NEW')
2462 self.assertEqual(A.reported, 1)
2463 self.assertIn('Build succeeded', A.messages[0])
2464 # Ensure the removed job was not included in the report.
2465 self.assertNotIn('project-test1', A.messages[0])
2466
James E. Blairec056492016-07-22 09:45:56 -07002467 @skip("Disabled for early v3 development")
James E. Blairfe707d12015-08-05 15:18:15 -07002468 def test_live_reconfiguration_shared_queue(self):
2469 # Test that a change with a failing job which was removed from
2470 # this project but otherwise still exists in the system does
2471 # not disrupt reconfiguration.
2472
Paul Belanger174a8272017-03-14 13:20:10 -04002473 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002474
2475 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2476
Paul Belanger174a8272017-03-14 13:20:10 -04002477 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002478
2479 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2480 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002481 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002482 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002483 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002484 self.waitUntilSettled()
2485
2486 self.assertEqual(A.data['status'], 'NEW')
2487 self.assertEqual(A.reported, 0)
2488
2489 self.assertEqual(self.getJobFromHistory('project1-merge').result,
2490 'SUCCESS')
2491 self.assertEqual(self.getJobFromHistory(
2492 'project1-project2-integration').result, 'FAILURE')
2493 self.assertEqual(len(self.history), 2)
2494
2495 # Remove the integration job.
James E. Blairf84026c2015-12-08 16:11:46 -08002496 self.updateConfigLayout(
2497 'tests/fixtures/layout-live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002498 self.sched.reconfigure(self.config)
2499 self.waitUntilSettled()
2500
Paul Belanger174a8272017-03-14 13:20:10 -04002501 self.executor_server.hold_jobs_in_build = False
2502 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002503 self.waitUntilSettled()
2504
2505 self.assertEqual(self.getJobFromHistory('project1-merge').result,
2506 'SUCCESS')
2507 self.assertEqual(self.getJobFromHistory('project1-test1').result,
2508 'SUCCESS')
2509 self.assertEqual(self.getJobFromHistory('project1-test2').result,
2510 'SUCCESS')
2511 self.assertEqual(self.getJobFromHistory(
2512 'project1-project2-integration').result, 'FAILURE')
2513 self.assertEqual(len(self.history), 4)
2514
2515 self.assertEqual(A.data['status'], 'NEW')
2516 self.assertEqual(A.reported, 1)
2517 self.assertIn('Build succeeded', A.messages[0])
2518 # Ensure the removed job was not included in the report.
2519 self.assertNotIn('project1-project2-integration', A.messages[0])
2520
James E. Blairec056492016-07-22 09:45:56 -07002521 @skip("Disabled for early v3 development")
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002522 def test_double_live_reconfiguration_shared_queue(self):
2523 # This was a real-world regression. A change is added to
2524 # gate; a reconfigure happens, a second change which depends
2525 # on the first is added, and a second reconfiguration happens.
2526 # Ensure that both changes merge.
2527
2528 # A failure may indicate incorrect caching or cleaning up of
2529 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002530 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002531
2532 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2533 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2534 B.setDependsOn(A, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07002535 A.addApproval('code-review', 2)
2536 B.addApproval('code-review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002537
2538 # Add the parent change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002539 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002540 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002541 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002542 self.waitUntilSettled()
2543
2544 # Reconfigure (with only one change in the pipeline).
2545 self.sched.reconfigure(self.config)
2546 self.waitUntilSettled()
2547
2548 # Add the child change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002549 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002550 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002551 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002552 self.waitUntilSettled()
2553
2554 # Reconfigure (with both in the pipeline).
2555 self.sched.reconfigure(self.config)
2556 self.waitUntilSettled()
2557
Paul Belanger174a8272017-03-14 13:20:10 -04002558 self.executor_server.hold_jobs_in_build = False
2559 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002560 self.waitUntilSettled()
2561
2562 self.assertEqual(len(self.history), 8)
2563
2564 self.assertEqual(A.data['status'], 'MERGED')
2565 self.assertEqual(A.reported, 2)
2566 self.assertEqual(B.data['status'], 'MERGED')
2567 self.assertEqual(B.reported, 2)
2568
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002569 def test_live_reconfiguration_del_project(self):
2570 # Test project deletion from layout
2571 # while changes are enqueued
2572
Paul Belanger174a8272017-03-14 13:20:10 -04002573 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002574 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2575 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2576 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2577
2578 # A Depends-On: B
2579 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2580 A.subject, B.data['id'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002581 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002582
2583 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2584 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2585 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002586 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002587 self.waitUntilSettled()
2588 self.assertEqual(len(self.builds), 5)
2589
2590 # This layout defines only org/project, not org/project1
James E. Blair31cb3e82017-04-20 13:08:56 -07002591 self.commitConfigUpdate(
2592 'common-config',
2593 'layouts/live-reconfiguration-del-project.yaml')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002594 self.sched.reconfigure(self.config)
2595 self.waitUntilSettled()
2596
2597 # Builds for C aborted, builds for A succeed,
2598 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002599 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002600 self.assertEqual(job_c.changes, '3,1')
2601 self.assertEqual(job_c.result, 'ABORTED')
2602
Paul Belanger174a8272017-03-14 13:20:10 -04002603 self.executor_server.hold_jobs_in_build = False
2604 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002605 self.waitUntilSettled()
2606
Clint Byrum0149ada2017-04-04 12:22:01 -07002607 self.assertEqual(
2608 self.getJobFromHistory('project-test1', 'org/project').changes,
2609 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002610
2611 self.assertEqual(A.data['status'], 'NEW')
2612 self.assertEqual(B.data['status'], 'NEW')
2613 self.assertEqual(C.data['status'], 'NEW')
2614 self.assertEqual(A.reported, 1)
2615 self.assertEqual(B.reported, 0)
2616 self.assertEqual(C.reported, 0)
2617
Clint Byrum0149ada2017-04-04 12:22:01 -07002618 tenant = self.sched.abide.tenants.get('tenant-one')
2619 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002620 self.assertIn('Build succeeded', A.messages[0])
2621
James E. Blairec056492016-07-22 09:45:56 -07002622 @skip("Disabled for early v3 development")
James E. Blair287c06d2013-07-24 10:39:30 -07002623 def test_delayed_repo_init(self):
James E. Blairf84026c2015-12-08 16:11:46 -08002624 self.updateConfigLayout(
2625 'tests/fixtures/layout-delayed-repo-init.yaml')
James E. Blair287c06d2013-07-24 10:39:30 -07002626 self.sched.reconfigure(self.config)
2627
2628 self.init_repo("org/new-project")
2629 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2630
James E. Blair8b5408c2016-08-08 15:37:46 -07002631 A.addApproval('code-review', 2)
2632 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002633 self.waitUntilSettled()
2634 self.assertEqual(self.getJobFromHistory('project-merge').result,
2635 'SUCCESS')
2636 self.assertEqual(self.getJobFromHistory('project-test1').result,
2637 'SUCCESS')
2638 self.assertEqual(self.getJobFromHistory('project-test2').result,
2639 'SUCCESS')
2640 self.assertEqual(A.data['status'], 'MERGED')
2641 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002642
James E. Blair9ea70072017-04-19 16:05:30 -07002643 @simple_layout('layouts/repo-deleted.yaml')
Clark Boylan6dbbc482013-10-18 10:57:31 -07002644 def test_repo_deleted(self):
Clark Boylan6dbbc482013-10-18 10:57:31 -07002645 self.init_repo("org/delete-project")
2646 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2647
James E. Blair8b5408c2016-08-08 15:37:46 -07002648 A.addApproval('code-review', 2)
2649 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002650 self.waitUntilSettled()
2651 self.assertEqual(self.getJobFromHistory('project-merge').result,
2652 'SUCCESS')
2653 self.assertEqual(self.getJobFromHistory('project-test1').result,
2654 'SUCCESS')
2655 self.assertEqual(self.getJobFromHistory('project-test2').result,
2656 'SUCCESS')
2657 self.assertEqual(A.data['status'], 'MERGED')
2658 self.assertEqual(A.reported, 2)
2659
2660 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002661 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002662 if os.path.exists(os.path.join(self.merger_src_root, p)):
2663 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002664 if os.path.exists(os.path.join(self.executor_src_root, p)):
2665 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002666
2667 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2668
James E. Blair8b5408c2016-08-08 15:37:46 -07002669 B.addApproval('code-review', 2)
2670 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002671 self.waitUntilSettled()
2672 self.assertEqual(self.getJobFromHistory('project-merge').result,
2673 'SUCCESS')
2674 self.assertEqual(self.getJobFromHistory('project-test1').result,
2675 'SUCCESS')
2676 self.assertEqual(self.getJobFromHistory('project-test2').result,
2677 'SUCCESS')
2678 self.assertEqual(B.data['status'], 'MERGED')
2679 self.assertEqual(B.reported, 2)
2680
James E. Blaire68d43f2017-04-19 14:03:30 -07002681 @simple_layout('layouts/tags.yaml')
James E. Blair456f2fb2016-02-09 09:29:33 -08002682 def test_tags(self):
2683 "Test job tags"
James E. Blair456f2fb2016-02-09 09:29:33 -08002684 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2685 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2686 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2687 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2688 self.waitUntilSettled()
2689
James E. Blaire68d43f2017-04-19 14:03:30 -07002690 self.assertEqual(len(self.history), 2)
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002691
2692 results = {self.getJobFromHistory('merge',
2693 project='org/project1').uuid: 'extratag merge',
2694 self.getJobFromHistory('merge',
2695 project='org/project2').uuid: 'merge'}
James E. Blair456f2fb2016-02-09 09:29:33 -08002696
2697 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002698 self.assertEqual(results.get(build.uuid, ''),
2699 build.parameters['vars']['zuul'].get('tags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08002700
James E. Blair63bb0ef2013-07-29 17:14:51 -07002701 def test_timer(self):
2702 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002703 # This test can not use simple_layout because it must start
2704 # with a configuration which does not include a
2705 # timer-triggered job so that we have an opportunity to set
2706 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002707 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002708 self.commitConfigUpdate('common-config', 'layouts/timer.yaml')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002709 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002710
Clark Boylan3ee090a2014-04-03 20:55:09 -07002711 # The pipeline triggers every second, so we should have seen
2712 # several by now.
2713 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002714 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07002715
2716 self.assertEqual(len(self.builds), 2)
2717
James E. Blair63bb0ef2013-07-29 17:14:51 -07002718 port = self.webapp.server.socket.getsockname()[1]
2719
Clint Byrum5e729e92017-02-08 06:34:57 -08002720 req = urllib.request.Request(
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002721 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002722 f = urllib.request.urlopen(req)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002723 data = f.read()
2724
Paul Belanger174a8272017-03-14 13:20:10 -04002725 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07002726 # Stop queuing timer triggered jobs so that the assertions
2727 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002728 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002729 self.sched.reconfigure(self.config)
Paul Belanger174a8272017-03-14 13:20:10 -04002730 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07002731 self.waitUntilSettled()
2732
2733 self.assertEqual(self.getJobFromHistory(
2734 'project-bitrot-stable-old').result, 'SUCCESS')
2735 self.assertEqual(self.getJobFromHistory(
2736 'project-bitrot-stable-older').result, 'SUCCESS')
2737
2738 data = json.loads(data)
2739 status_jobs = set()
2740 for p in data['pipelines']:
2741 for q in p['change_queues']:
2742 for head in q['heads']:
2743 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07002744 for job in change['jobs']:
2745 status_jobs.add(job['name'])
2746 self.assertIn('project-bitrot-stable-old', status_jobs)
2747 self.assertIn('project-bitrot-stable-older', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002748
James E. Blair4f6033c2014-03-27 15:49:09 -07002749 def test_idle(self):
2750 "Test that frequent periodic jobs work"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002751 # This test can not use simple_layout because it must start
2752 # with a configuration which does not include a
2753 # timer-triggered job so that we have an opportunity to set
2754 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002755 self.executor_server.hold_jobs_in_build = True
James E. Blair4f6033c2014-03-27 15:49:09 -07002756
Clark Boylan3ee090a2014-04-03 20:55:09 -07002757 for x in range(1, 3):
2758 # Test that timer triggers periodic jobs even across
2759 # layout config reloads.
2760 # Start timer trigger
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002761 self.commitConfigUpdate('common-config',
2762 'layouts/idle.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002763 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002764 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07002765
Clark Boylan3ee090a2014-04-03 20:55:09 -07002766 # The pipeline triggers every second, so we should have seen
2767 # several by now.
2768 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07002769
2770 # Stop queuing timer triggered jobs so that the assertions
2771 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002772 self.commitConfigUpdate('common-config',
2773 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002774 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002775 self.waitUntilSettled()
Clint Byrum58264dc2017-02-07 21:21:22 -08002776 self.assertEqual(len(self.builds), 2,
2777 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04002778 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002779 self.waitUntilSettled()
2780 self.assertEqual(len(self.builds), 0)
2781 self.assertEqual(len(self.history), x * 2)
James E. Blair4f6033c2014-03-27 15:49:09 -07002782
James E. Blaircc324192017-04-19 14:36:08 -07002783 @simple_layout('layouts/smtp.yaml')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002784 def test_check_smtp_pool(self):
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002785 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2786 self.waitUntilSettled()
2787
2788 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2789 self.waitUntilSettled()
2790
James E. Blairff80a2f2013-12-27 13:24:06 -08002791 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002792
2793 # A.messages only holds what FakeGerrit places in it. Thus we
2794 # work on the knowledge of what the first message should be as
2795 # it is only configured to go to SMTP.
2796
2797 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002798 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002799 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002800 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002801 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08002802 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002803
2804 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002805 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002806 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002807 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002808 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08002809 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08002810
James E. Blaire5910202013-12-27 09:50:31 -08002811 def test_timer_smtp(self):
2812 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002813 # This test can not use simple_layout because it must start
2814 # with a configuration which does not include a
2815 # timer-triggered job so that we have an opportunity to set
2816 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002817 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002818 self.commitConfigUpdate('common-config', 'layouts/timer-smtp.yaml')
James E. Blaire5910202013-12-27 09:50:31 -08002819 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08002820
Clark Boylan3ee090a2014-04-03 20:55:09 -07002821 # The pipeline triggers every second, so we should have seen
2822 # several by now.
2823 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08002824 self.waitUntilSettled()
2825
Clark Boylan3ee090a2014-04-03 20:55:09 -07002826 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04002827 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002828 self.waitUntilSettled()
2829 self.assertEqual(len(self.history), 2)
2830
James E. Blaire5910202013-12-27 09:50:31 -08002831 self.assertEqual(self.getJobFromHistory(
2832 'project-bitrot-stable-old').result, 'SUCCESS')
2833 self.assertEqual(self.getJobFromHistory(
2834 'project-bitrot-stable-older').result, 'SUCCESS')
2835
James E. Blairff80a2f2013-12-27 13:24:06 -08002836 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08002837
2838 # A.messages only holds what FakeGerrit places in it. Thus we
2839 # work on the knowledge of what the first message should be as
2840 # it is only configured to go to SMTP.
2841
2842 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002843 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002844 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002845 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002846 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08002847 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08002848
Clark Boylan3ee090a2014-04-03 20:55:09 -07002849 # Stop queuing timer triggered jobs and let any that may have
2850 # queued through so that end of test assertions pass.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002851 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002852 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07002853 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002854 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002855 self.waitUntilSettled()
2856
Joshua Hesketh25695cb2017-03-06 12:50:04 +11002857 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00002858 def test_timer_sshkey(self):
2859 "Test that a periodic job can setup SSH key authentication"
2860 self.worker.hold_jobs_in_build = True
2861 self.config.set('zuul', 'layout_config',
2862 'tests/fixtures/layout-timer.yaml')
2863 self.sched.reconfigure(self.config)
2864 self.registerJobs()
2865
2866 # The pipeline triggers every second, so we should have seen
2867 # several by now.
2868 time.sleep(5)
2869 self.waitUntilSettled()
2870
2871 self.assertEqual(len(self.builds), 2)
2872
2873 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
2874 self.assertTrue(os.path.isfile(ssh_wrapper))
2875 with open(ssh_wrapper) as f:
2876 ssh_wrapper_content = f.read()
2877 self.assertIn("fake_id_rsa", ssh_wrapper_content)
2878 # In the unit tests Merger runs in the same process,
2879 # so we see its' environment variables
2880 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
2881
2882 self.worker.release('.*')
2883 self.waitUntilSettled()
2884 self.assertEqual(len(self.history), 2)
2885
2886 self.assertEqual(self.getJobFromHistory(
2887 'project-bitrot-stable-old').result, 'SUCCESS')
2888 self.assertEqual(self.getJobFromHistory(
2889 'project-bitrot-stable-older').result, 'SUCCESS')
2890
2891 # Stop queuing timer triggered jobs and let any that may have
2892 # queued through so that end of test assertions pass.
2893 self.config.set('zuul', 'layout_config',
2894 'tests/fixtures/layout-no-timer.yaml')
2895 self.sched.reconfigure(self.config)
2896 self.registerJobs()
2897 self.waitUntilSettled()
2898 self.worker.release('.*')
2899 self.waitUntilSettled()
2900
James E. Blair91e34592015-07-31 16:45:59 -07002901 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08002902 "Test that the RPC client can enqueue a change"
2903 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002904 A.addApproval('code-review', 2)
2905 A.addApproval('approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08002906
2907 client = zuul.rpcclient.RPCClient('127.0.0.1',
2908 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002909 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04002910 r = client.enqueue(tenant='tenant-one',
2911 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002912 project='org/project',
2913 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002914 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002915 self.waitUntilSettled()
2916 self.assertEqual(self.getJobFromHistory('project-merge').result,
2917 'SUCCESS')
2918 self.assertEqual(self.getJobFromHistory('project-test1').result,
2919 'SUCCESS')
2920 self.assertEqual(self.getJobFromHistory('project-test2').result,
2921 'SUCCESS')
2922 self.assertEqual(A.data['status'], 'MERGED')
2923 self.assertEqual(A.reported, 2)
2924 self.assertEqual(r, True)
2925
James E. Blair91e34592015-07-31 16:45:59 -07002926 def test_client_enqueue_ref(self):
2927 "Test that the RPC client can enqueue a ref"
2928
2929 client = zuul.rpcclient.RPCClient('127.0.0.1',
2930 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002931 self.addCleanup(client.shutdown)
James E. Blair91e34592015-07-31 16:45:59 -07002932 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04002933 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07002934 pipeline='post',
2935 project='org/project',
2936 trigger='gerrit',
2937 ref='master',
2938 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
2939 newrev='d479a0bfcb34da57a31adb2a595c0cf687812543')
2940 self.waitUntilSettled()
2941 job_names = [x.name for x in self.history]
2942 self.assertEqual(len(self.history), 1)
2943 self.assertIn('project-post', job_names)
2944 self.assertEqual(r, True)
2945
James E. Blairad28e912013-11-27 10:43:22 -08002946 def test_client_enqueue_negative(self):
2947 "Test that the RPC client returns errors"
2948 client = zuul.rpcclient.RPCClient('127.0.0.1',
2949 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002950 self.addCleanup(client.shutdown)
James E. Blairad28e912013-11-27 10:43:22 -08002951 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04002952 "Invalid tenant"):
2953 r = client.enqueue(tenant='tenant-foo',
2954 pipeline='gate',
2955 project='org/project',
2956 trigger='gerrit',
2957 change='1,1')
Paul Belangerbaca3132016-11-04 12:49:54 -04002958 self.assertEqual(r, False)
2959
2960 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08002961 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002962 r = client.enqueue(tenant='tenant-one',
2963 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002964 project='project-does-not-exist',
2965 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002966 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002967 self.assertEqual(r, False)
2968
2969 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2970 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002971 r = client.enqueue(tenant='tenant-one',
2972 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08002973 project='org/project',
2974 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002975 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002976 self.assertEqual(r, False)
2977
2978 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2979 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002980 r = client.enqueue(tenant='tenant-one',
2981 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002982 project='org/project',
2983 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08002984 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002985 self.assertEqual(r, False)
2986
2987 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2988 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002989 r = client.enqueue(tenant='tenant-one',
2990 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002991 project='org/project',
2992 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002993 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002994 self.assertEqual(r, False)
2995
2996 self.waitUntilSettled()
2997 self.assertEqual(len(self.history), 0)
2998 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08002999
3000 def test_client_promote(self):
3001 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04003002 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003003 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3004 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3005 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003006 A.addApproval('code-review', 2)
3007 B.addApproval('code-review', 2)
3008 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003009
James E. Blair8b5408c2016-08-08 15:37:46 -07003010 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3011 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3012 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003013
3014 self.waitUntilSettled()
3015
Paul Belangerbaca3132016-11-04 12:49:54 -04003016 tenant = self.sched.abide.tenants.get('tenant-one')
3017 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003018 enqueue_times = {}
3019 for item in items:
3020 enqueue_times[str(item.change)] = item.enqueue_time
3021
James E. Blair36658cf2013-12-06 17:53:48 -08003022 client = zuul.rpcclient.RPCClient('127.0.0.1',
3023 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003024 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003025 r = client.promote(tenant='tenant-one',
3026 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003027 change_ids=['2,1', '3,1'])
3028
Sean Daguef39b9ca2014-01-10 21:34:35 -05003029 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003030 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003031 for item in items:
3032 self.assertEqual(
3033 enqueue_times[str(item.change)], item.enqueue_time)
3034
James E. Blair78acec92014-02-06 07:11:32 -08003035 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003036 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003037 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003038 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003039 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003040 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003041 self.waitUntilSettled()
3042
3043 self.assertEqual(len(self.builds), 6)
3044 self.assertEqual(self.builds[0].name, 'project-test1')
3045 self.assertEqual(self.builds[1].name, 'project-test2')
3046 self.assertEqual(self.builds[2].name, 'project-test1')
3047 self.assertEqual(self.builds[3].name, 'project-test2')
3048 self.assertEqual(self.builds[4].name, 'project-test1')
3049 self.assertEqual(self.builds[5].name, 'project-test2')
3050
Paul Belangerbaca3132016-11-04 12:49:54 -04003051 self.assertTrue(self.builds[0].hasChanges(B))
3052 self.assertFalse(self.builds[0].hasChanges(A))
3053 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003054
Paul Belangerbaca3132016-11-04 12:49:54 -04003055 self.assertTrue(self.builds[2].hasChanges(B))
3056 self.assertTrue(self.builds[2].hasChanges(C))
3057 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003058
Paul Belangerbaca3132016-11-04 12:49:54 -04003059 self.assertTrue(self.builds[4].hasChanges(B))
3060 self.assertTrue(self.builds[4].hasChanges(C))
3061 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003062
Paul Belanger174a8272017-03-14 13:20:10 -04003063 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003064 self.waitUntilSettled()
3065
3066 self.assertEqual(A.data['status'], 'MERGED')
3067 self.assertEqual(A.reported, 2)
3068 self.assertEqual(B.data['status'], 'MERGED')
3069 self.assertEqual(B.reported, 2)
3070 self.assertEqual(C.data['status'], 'MERGED')
3071 self.assertEqual(C.reported, 2)
3072
James E. Blair36658cf2013-12-06 17:53:48 -08003073 self.assertEqual(r, True)
3074
3075 def test_client_promote_dependent(self):
3076 "Test that the RPC client can promote a dependent change"
3077 # C (depends on B) -> B -> A ; then promote C to get:
3078 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003079 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003080 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3081 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3082 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3083
3084 C.setDependsOn(B, 1)
3085
James E. Blair8b5408c2016-08-08 15:37:46 -07003086 A.addApproval('code-review', 2)
3087 B.addApproval('code-review', 2)
3088 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003089
James E. Blair8b5408c2016-08-08 15:37:46 -07003090 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3091 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3092 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003093
3094 self.waitUntilSettled()
3095
3096 client = zuul.rpcclient.RPCClient('127.0.0.1',
3097 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003098 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003099 r = client.promote(tenant='tenant-one',
3100 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003101 change_ids=['3,1'])
3102
James E. Blair78acec92014-02-06 07:11:32 -08003103 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003104 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003105 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003106 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003107 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003108 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003109 self.waitUntilSettled()
3110
3111 self.assertEqual(len(self.builds), 6)
3112 self.assertEqual(self.builds[0].name, 'project-test1')
3113 self.assertEqual(self.builds[1].name, 'project-test2')
3114 self.assertEqual(self.builds[2].name, 'project-test1')
3115 self.assertEqual(self.builds[3].name, 'project-test2')
3116 self.assertEqual(self.builds[4].name, 'project-test1')
3117 self.assertEqual(self.builds[5].name, 'project-test2')
3118
Paul Belangerbaca3132016-11-04 12:49:54 -04003119 self.assertTrue(self.builds[0].hasChanges(B))
3120 self.assertFalse(self.builds[0].hasChanges(A))
3121 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003122
Paul Belangerbaca3132016-11-04 12:49:54 -04003123 self.assertTrue(self.builds[2].hasChanges(B))
3124 self.assertTrue(self.builds[2].hasChanges(C))
3125 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003126
Paul Belangerbaca3132016-11-04 12:49:54 -04003127 self.assertTrue(self.builds[4].hasChanges(B))
3128 self.assertTrue(self.builds[4].hasChanges(C))
3129 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003130
Paul Belanger174a8272017-03-14 13:20:10 -04003131 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003132 self.waitUntilSettled()
3133
3134 self.assertEqual(A.data['status'], 'MERGED')
3135 self.assertEqual(A.reported, 2)
3136 self.assertEqual(B.data['status'], 'MERGED')
3137 self.assertEqual(B.reported, 2)
3138 self.assertEqual(C.data['status'], 'MERGED')
3139 self.assertEqual(C.reported, 2)
3140
James E. Blair36658cf2013-12-06 17:53:48 -08003141 self.assertEqual(r, True)
3142
3143 def test_client_promote_negative(self):
3144 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003145 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003146 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003147 A.addApproval('code-review', 2)
3148 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003149 self.waitUntilSettled()
3150
3151 client = zuul.rpcclient.RPCClient('127.0.0.1',
3152 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003153 self.addCleanup(client.shutdown)
James E. Blair36658cf2013-12-06 17:53:48 -08003154
3155 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003156 r = client.promote(tenant='tenant-one',
3157 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003158 change_ids=['2,1', '3,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003159 self.assertEqual(r, False)
3160
3161 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003162 r = client.promote(tenant='tenant-one',
3163 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003164 change_ids=['4,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003165 self.assertEqual(r, False)
3166
Paul Belanger174a8272017-03-14 13:20:10 -04003167 self.executor_server.hold_jobs_in_build = False
3168 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003169 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003170
James E. Blaircc324192017-04-19 14:36:08 -07003171 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003172 def test_queue_rate_limiting(self):
3173 "Test that DependentPipelines are rate limited with dep across window"
Paul Belanger174a8272017-03-14 13:20:10 -04003174 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003175 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3176 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3177 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3178
3179 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003180 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003181
James E. Blair8b5408c2016-08-08 15:37:46 -07003182 A.addApproval('code-review', 2)
3183 B.addApproval('code-review', 2)
3184 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003185
James E. Blair8b5408c2016-08-08 15:37:46 -07003186 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3187 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3188 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003189 self.waitUntilSettled()
3190
3191 # Only A and B will have their merge jobs queued because
3192 # window is 2.
3193 self.assertEqual(len(self.builds), 2)
3194 self.assertEqual(self.builds[0].name, 'project-merge')
3195 self.assertEqual(self.builds[1].name, 'project-merge')
3196
James E. Blair732ee862017-04-21 07:49:26 -07003197 # Release the merge jobs one at a time.
3198 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003199 self.waitUntilSettled()
James E. Blair732ee862017-04-21 07:49:26 -07003200 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003201 self.waitUntilSettled()
3202
3203 # Only A and B will have their test jobs queued because
3204 # window is 2.
3205 self.assertEqual(len(self.builds), 4)
3206 self.assertEqual(self.builds[0].name, 'project-test1')
3207 self.assertEqual(self.builds[1].name, 'project-test2')
3208 self.assertEqual(self.builds[2].name, 'project-test1')
3209 self.assertEqual(self.builds[3].name, 'project-test2')
3210
Paul Belanger174a8272017-03-14 13:20:10 -04003211 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003212 self.waitUntilSettled()
3213
James E. Blaircc324192017-04-19 14:36:08 -07003214 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003215 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003216 # A failed so window is reduced by 1 to 1.
3217 self.assertEqual(queue.window, 1)
3218 self.assertEqual(queue.window_floor, 1)
3219 self.assertEqual(A.data['status'], 'NEW')
3220
3221 # Gate is reset and only B's merge job is queued because
3222 # window shrunk to 1.
3223 self.assertEqual(len(self.builds), 1)
3224 self.assertEqual(self.builds[0].name, 'project-merge')
3225
Paul Belanger174a8272017-03-14 13:20:10 -04003226 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003227 self.waitUntilSettled()
3228
3229 # Only B's test jobs are queued because window is still 1.
3230 self.assertEqual(len(self.builds), 2)
3231 self.assertEqual(self.builds[0].name, 'project-test1')
3232 self.assertEqual(self.builds[1].name, 'project-test2')
3233
Paul Belanger174a8272017-03-14 13:20:10 -04003234 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003235 self.waitUntilSettled()
3236
3237 # B was successfully merged so window is increased to 2.
3238 self.assertEqual(queue.window, 2)
3239 self.assertEqual(queue.window_floor, 1)
3240 self.assertEqual(B.data['status'], 'MERGED')
3241
3242 # Only C is left and its merge job is queued.
3243 self.assertEqual(len(self.builds), 1)
3244 self.assertEqual(self.builds[0].name, 'project-merge')
3245
Paul Belanger174a8272017-03-14 13:20:10 -04003246 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003247 self.waitUntilSettled()
3248
3249 # After successful merge job the test jobs for C are queued.
3250 self.assertEqual(len(self.builds), 2)
3251 self.assertEqual(self.builds[0].name, 'project-test1')
3252 self.assertEqual(self.builds[1].name, 'project-test2')
3253
Paul Belanger174a8272017-03-14 13:20:10 -04003254 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003255 self.waitUntilSettled()
3256
3257 # C successfully merged so window is bumped to 3.
3258 self.assertEqual(queue.window, 3)
3259 self.assertEqual(queue.window_floor, 1)
3260 self.assertEqual(C.data['status'], 'MERGED')
3261
James E. Blaircc324192017-04-19 14:36:08 -07003262 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003263 def test_queue_rate_limiting_dependent(self):
3264 "Test that DependentPipelines are rate limited with dep in window"
Paul Belanger174a8272017-03-14 13:20:10 -04003265 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003266 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3267 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3268 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3269
3270 B.setDependsOn(A, 1)
3271
Paul Belanger174a8272017-03-14 13:20:10 -04003272 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003273
James E. Blair8b5408c2016-08-08 15:37:46 -07003274 A.addApproval('code-review', 2)
3275 B.addApproval('code-review', 2)
3276 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003277
James E. Blair8b5408c2016-08-08 15:37:46 -07003278 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3279 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3280 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003281 self.waitUntilSettled()
3282
3283 # Only A and B will have their merge jobs queued because
3284 # window is 2.
3285 self.assertEqual(len(self.builds), 2)
3286 self.assertEqual(self.builds[0].name, 'project-merge')
3287 self.assertEqual(self.builds[1].name, 'project-merge')
3288
James E. Blairf4a5f022017-04-18 14:01:10 -07003289 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003290
3291 # Only A and B will have their test jobs queued because
3292 # window is 2.
3293 self.assertEqual(len(self.builds), 4)
3294 self.assertEqual(self.builds[0].name, 'project-test1')
3295 self.assertEqual(self.builds[1].name, 'project-test2')
3296 self.assertEqual(self.builds[2].name, 'project-test1')
3297 self.assertEqual(self.builds[3].name, 'project-test2')
3298
Paul Belanger174a8272017-03-14 13:20:10 -04003299 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003300 self.waitUntilSettled()
3301
James E. Blaircc324192017-04-19 14:36:08 -07003302 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003303 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003304 # A failed so window is reduced by 1 to 1.
3305 self.assertEqual(queue.window, 1)
3306 self.assertEqual(queue.window_floor, 1)
3307 self.assertEqual(A.data['status'], 'NEW')
3308 self.assertEqual(B.data['status'], 'NEW')
3309
3310 # Gate is reset and only C's merge job is queued because
3311 # window shrunk to 1 and A and B were dequeued.
3312 self.assertEqual(len(self.builds), 1)
3313 self.assertEqual(self.builds[0].name, 'project-merge')
3314
James E. Blairf4a5f022017-04-18 14:01:10 -07003315 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003316
3317 # Only C's test jobs are queued because window is still 1.
3318 self.assertEqual(len(self.builds), 2)
3319 self.assertEqual(self.builds[0].name, 'project-test1')
3320 self.assertEqual(self.builds[1].name, 'project-test2')
3321
Paul Belanger174a8272017-03-14 13:20:10 -04003322 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003323 self.waitUntilSettled()
3324
3325 # C was successfully merged so window is increased to 2.
3326 self.assertEqual(queue.window, 2)
3327 self.assertEqual(queue.window_floor, 1)
3328 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003329
James E. Blairec056492016-07-22 09:45:56 -07003330 @skip("Disabled for early v3 development")
Joshua Heskethba8776a2014-01-12 14:35:40 +08003331 def test_worker_update_metadata(self):
3332 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003333 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003334
3335 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003336 A.addApproval('code-review', 2)
3337 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003338 self.waitUntilSettled()
3339
Paul Belanger174a8272017-03-14 13:20:10 -04003340 self.assertEqual(len(self.executor.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003341
3342 self.log.debug('Current builds:')
Paul Belanger174a8272017-03-14 13:20:10 -04003343 self.log.debug(self.executor.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003344
3345 start = time.time()
3346 while True:
3347 if time.time() - start > 10:
3348 raise Exception("Timeout waiting for gearman server to report "
3349 + "back to the client")
Paul Belanger174a8272017-03-14 13:20:10 -04003350 build = self.executor.builds.values()[0]
Joshua Heskethba8776a2014-01-12 14:35:40 +08003351 if build.worker.name == "My Worker":
3352 break
3353 else:
3354 time.sleep(0)
3355
3356 self.log.debug(build)
3357 self.assertEqual("My Worker", build.worker.name)
3358 self.assertEqual("localhost", build.worker.hostname)
3359 self.assertEqual(['127.0.0.1', '192.168.1.1'], build.worker.ips)
3360 self.assertEqual("zuul.example.org", build.worker.fqdn)
3361 self.assertEqual("FakeBuilder", build.worker.program)
3362 self.assertEqual("v1.1", build.worker.version)
3363 self.assertEqual({'something': 'else'}, build.worker.extra)
3364
Paul Belanger174a8272017-03-14 13:20:10 -04003365 self.executor_server.hold_jobs_in_build = False
3366 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003367 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003368
James E. Blaircc324192017-04-19 14:36:08 -07003369 @simple_layout('layouts/footer-message.yaml')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003370 def test_footer_message(self):
3371 "Test a pipeline's footer message is correctly added to the report."
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003372 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003373 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003374 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003375 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003376 self.waitUntilSettled()
3377
3378 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003379 B.addApproval('code-review', 2)
3380 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003381 self.waitUntilSettled()
3382
3383 self.assertEqual(2, len(self.smtp_messages))
3384
Adam Gandelman82258fd2017-02-07 16:51:58 -08003385 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003386Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003387http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003388
Adam Gandelman82258fd2017-02-07 16:51:58 -08003389 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003390For CI problems and help debugging, contact ci@example.org"""
3391
Adam Gandelman82258fd2017-02-07 16:51:58 -08003392 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3393 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3394 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3395 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003396
James E. Blairec056492016-07-22 09:45:56 -07003397 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003398 def test_merge_failure_reporters(self):
3399 """Check that the config is set up correctly"""
3400
James E. Blairf84026c2015-12-08 16:11:46 -08003401 self.updateConfigLayout(
3402 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003403 self.sched.reconfigure(self.config)
3404 self.registerJobs()
3405
3406 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003407 "Merge Failed.\n\nThis change or one of its cross-repo "
3408 "dependencies was unable to be automatically merged with the "
3409 "current state of its repository. Please rebase the change and "
3410 "upload a new patchset.",
Joshua Heskethb7179772014-01-30 23:30:46 +11003411 self.sched.layout.pipelines['check'].merge_failure_message)
3412 self.assertEqual(
3413 "The merge failed! For more information...",
3414 self.sched.layout.pipelines['gate'].merge_failure_message)
3415
3416 self.assertEqual(
3417 len(self.sched.layout.pipelines['check'].merge_failure_actions), 1)
3418 self.assertEqual(
3419 len(self.sched.layout.pipelines['gate'].merge_failure_actions), 2)
3420
3421 self.assertTrue(isinstance(
Joshua Heskethde958652015-11-10 19:19:50 +11003422 self.sched.layout.pipelines['check'].merge_failure_actions[0],
3423 zuul.reporter.gerrit.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003424
3425 self.assertTrue(
3426 (
3427 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003428 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003429 zuul.reporter.smtp.SMTPReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003430 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003431 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003432 zuul.reporter.gerrit.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003433 ) or (
3434 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003435 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003436 zuul.reporter.gerrit.GerritReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003437 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003438 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003439 zuul.reporter.smtp.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003440 )
3441 )
3442
James E. Blairec056492016-07-22 09:45:56 -07003443 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003444 def test_merge_failure_reports(self):
3445 """Check that when a change fails to merge the correct message is sent
3446 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003447 self.updateConfigLayout(
3448 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003449 self.sched.reconfigure(self.config)
3450 self.registerJobs()
3451
3452 # Check a test failure isn't reported to SMTP
3453 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003454 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003455 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003456 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003457 self.waitUntilSettled()
3458
3459 self.assertEqual(3, len(self.history)) # 3 jobs
3460 self.assertEqual(0, len(self.smtp_messages))
3461
3462 # Check a merge failure is reported to SMTP
3463 # B should be merged, but C will conflict with B
3464 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3465 B.addPatchset(['conflict'])
3466 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3467 C.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003468 B.addApproval('code-review', 2)
3469 C.addApproval('code-review', 2)
3470 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3471 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003472 self.waitUntilSettled()
3473
3474 self.assertEqual(6, len(self.history)) # A and B jobs
3475 self.assertEqual(1, len(self.smtp_messages))
3476 self.assertEqual('The merge failed! For more information...',
3477 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003478
James E. Blairec056492016-07-22 09:45:56 -07003479 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003480 def test_default_merge_failure_reports(self):
3481 """Check that the default merge failure reports are correct."""
3482
3483 # A should report success, B should report merge failure.
3484 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3485 A.addPatchset(['conflict'])
3486 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3487 B.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003488 A.addApproval('code-review', 2)
3489 B.addApproval('code-review', 2)
3490 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3491 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003492 self.waitUntilSettled()
3493
3494 self.assertEqual(3, len(self.history)) # A jobs
3495 self.assertEqual(A.reported, 2)
3496 self.assertEqual(B.reported, 2)
3497 self.assertEqual(A.data['status'], 'MERGED')
3498 self.assertEqual(B.data['status'], 'NEW')
3499 self.assertIn('Build succeeded', A.messages[1])
3500 self.assertIn('Merge Failed', B.messages[1])
3501 self.assertIn('automatically merged', B.messages[1])
3502 self.assertNotIn('logs.example.com', B.messages[1])
3503 self.assertNotIn('SKIPPED', B.messages[1])
3504
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003505 def test_client_get_running_jobs(self):
3506 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003507 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003508 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003509 A.addApproval('code-review', 2)
3510 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003511 self.waitUntilSettled()
3512
3513 client = zuul.rpcclient.RPCClient('127.0.0.1',
3514 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003515 self.addCleanup(client.shutdown)
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003516
3517 # Wait for gearman server to send the initial workData back to zuul
3518 start = time.time()
3519 while True:
3520 if time.time() - start > 10:
3521 raise Exception("Timeout waiting for gearman server to report "
3522 + "back to the client")
Paul Belanger174a8272017-03-14 13:20:10 -04003523 build = self.executor_client.builds.values()[0]
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003524 if build.worker.name == "My Worker":
3525 break
3526 else:
3527 time.sleep(0)
3528
3529 running_items = client.get_running_jobs()
3530
3531 self.assertEqual(1, len(running_items))
3532 running_item = running_items[0]
3533 self.assertEqual([], running_item['failing_reasons'])
3534 self.assertEqual([], running_item['items_behind'])
3535 self.assertEqual('https://hostname/1', running_item['url'])
3536 self.assertEqual(None, running_item['item_ahead'])
3537 self.assertEqual('org/project', running_item['project'])
3538 self.assertEqual(None, running_item['remaining_time'])
3539 self.assertEqual(True, running_item['active'])
3540 self.assertEqual('1,1', running_item['id'])
3541
3542 self.assertEqual(3, len(running_item['jobs']))
3543 for job in running_item['jobs']:
3544 if job['name'] == 'project-merge':
3545 self.assertEqual('project-merge', job['name'])
3546 self.assertEqual('gate', job['pipeline'])
3547 self.assertEqual(False, job['retry'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003548 self.assertEqual('https://server/job/project-merge/0/',
3549 job['url'])
3550 self.assertEqual(7, len(job['worker']))
3551 self.assertEqual(False, job['canceled'])
3552 self.assertEqual(True, job['voting'])
3553 self.assertEqual(None, job['result'])
3554 self.assertEqual('gate', job['pipeline'])
3555 break
3556
Paul Belanger174a8272017-03-14 13:20:10 -04003557 self.executor_server.hold_jobs_in_build = False
3558 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003559 self.waitUntilSettled()
3560
3561 running_items = client.get_running_jobs()
3562 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003563
James E. Blairb70e55a2017-04-19 12:57:02 -07003564 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003565 def test_nonvoting_pipeline(self):
3566 "Test that a nonvoting pipeline (experimental) can still report"
3567
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003568 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3569 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003570 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3571 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003572
3573 self.assertEqual(self.getJobFromHistory('project-merge').result,
3574 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003575 self.assertEqual(
3576 self.getJobFromHistory('experimental-project-test').result,
3577 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003578 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003579
3580 def test_crd_gate(self):
3581 "Test cross-repo dependencies"
3582 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3583 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003584 A.addApproval('code-review', 2)
3585 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003586
3587 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3588 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3589 AM2.setMerged()
3590 AM1.setMerged()
3591
3592 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3593 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3594 BM2.setMerged()
3595 BM1.setMerged()
3596
3597 # A -> AM1 -> AM2
3598 # B -> BM1 -> BM2
3599 # A Depends-On: B
3600 # M2 is here to make sure it is never queried. If it is, it
3601 # means zuul is walking down the entire history of merged
3602 # changes.
3603
3604 B.setDependsOn(BM1, 1)
3605 BM1.setDependsOn(BM2, 1)
3606
3607 A.setDependsOn(AM1, 1)
3608 AM1.setDependsOn(AM2, 1)
3609
3610 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3611 A.subject, B.data['id'])
3612
James E. Blair8b5408c2016-08-08 15:37:46 -07003613 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003614 self.waitUntilSettled()
3615
3616 self.assertEqual(A.data['status'], 'NEW')
3617 self.assertEqual(B.data['status'], 'NEW')
3618
Paul Belanger5dccbe72016-11-14 11:17:37 -05003619 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11003620 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003621
Paul Belanger174a8272017-03-14 13:20:10 -04003622 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003623 B.addApproval('approved', 1)
3624 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003625 self.waitUntilSettled()
3626
Paul Belanger174a8272017-03-14 13:20:10 -04003627 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003628 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003629 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003630 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003631 self.executor_server.hold_jobs_in_build = False
3632 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003633 self.waitUntilSettled()
3634
3635 self.assertEqual(AM2.queried, 0)
3636 self.assertEqual(BM2.queried, 0)
3637 self.assertEqual(A.data['status'], 'MERGED')
3638 self.assertEqual(B.data['status'], 'MERGED')
3639 self.assertEqual(A.reported, 2)
3640 self.assertEqual(B.reported, 2)
3641
Paul Belanger5dccbe72016-11-14 11:17:37 -05003642 changes = self.getJobFromHistory(
3643 'project-merge', 'org/project1').changes
3644 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003645
3646 def test_crd_branch(self):
3647 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003648
3649 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003650 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3651 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3652 C = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C')
3653 C.data['id'] = B.data['id']
James E. Blair8b5408c2016-08-08 15:37:46 -07003654 A.addApproval('code-review', 2)
3655 B.addApproval('code-review', 2)
3656 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003657
3658 # A Depends-On: B+C
3659 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3660 A.subject, B.data['id'])
3661
Paul Belanger174a8272017-03-14 13:20:10 -04003662 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003663 B.addApproval('approved', 1)
3664 C.addApproval('approved', 1)
3665 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003666 self.waitUntilSettled()
3667
Paul Belanger174a8272017-03-14 13:20:10 -04003668 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003669 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003670 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003671 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003672 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003673 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003674 self.executor_server.hold_jobs_in_build = False
3675 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003676 self.waitUntilSettled()
3677
3678 self.assertEqual(A.data['status'], 'MERGED')
3679 self.assertEqual(B.data['status'], 'MERGED')
3680 self.assertEqual(C.data['status'], 'MERGED')
3681 self.assertEqual(A.reported, 2)
3682 self.assertEqual(B.reported, 2)
3683 self.assertEqual(C.reported, 2)
3684
Paul Belanger6379db12016-11-14 13:57:54 -05003685 changes = self.getJobFromHistory(
3686 'project-merge', 'org/project1').changes
3687 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003688
3689 def test_crd_multiline(self):
3690 "Test multiple depends-on lines in commit"
3691 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3692 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3693 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003694 A.addApproval('code-review', 2)
3695 B.addApproval('code-review', 2)
3696 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003697
3698 # A Depends-On: B+C
3699 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
3700 A.subject, B.data['id'], C.data['id'])
3701
Paul Belanger174a8272017-03-14 13:20:10 -04003702 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003703 B.addApproval('approved', 1)
3704 C.addApproval('approved', 1)
3705 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003706 self.waitUntilSettled()
3707
Paul Belanger174a8272017-03-14 13:20:10 -04003708 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003709 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003710 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003711 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003712 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003713 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003714 self.executor_server.hold_jobs_in_build = False
3715 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003716 self.waitUntilSettled()
3717
3718 self.assertEqual(A.data['status'], 'MERGED')
3719 self.assertEqual(B.data['status'], 'MERGED')
3720 self.assertEqual(C.data['status'], 'MERGED')
3721 self.assertEqual(A.reported, 2)
3722 self.assertEqual(B.reported, 2)
3723 self.assertEqual(C.reported, 2)
3724
Paul Belanger5dccbe72016-11-14 11:17:37 -05003725 changes = self.getJobFromHistory(
3726 'project-merge', 'org/project1').changes
3727 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08003728
3729 def test_crd_unshared_gate(self):
3730 "Test cross-repo dependencies in unshared gate queues"
3731 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3732 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003733 A.addApproval('code-review', 2)
3734 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003735
3736 # A Depends-On: B
3737 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3738 A.subject, B.data['id'])
3739
3740 # A and B do not share a queue, make sure that A is unable to
3741 # enqueue B (and therefore, A is unable to be enqueued).
James E. Blair8b5408c2016-08-08 15:37:46 -07003742 B.addApproval('approved', 1)
3743 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003744 self.waitUntilSettled()
3745
3746 self.assertEqual(A.data['status'], 'NEW')
3747 self.assertEqual(B.data['status'], 'NEW')
3748 self.assertEqual(A.reported, 0)
3749 self.assertEqual(B.reported, 0)
3750 self.assertEqual(len(self.history), 0)
3751
3752 # Enqueue and merge B alone.
James E. Blair8b5408c2016-08-08 15:37:46 -07003753 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003754 self.waitUntilSettled()
3755
3756 self.assertEqual(B.data['status'], 'MERGED')
3757 self.assertEqual(B.reported, 2)
3758
3759 # Now that B is merged, A should be able to be enqueued and
3760 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003761 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003762 self.waitUntilSettled()
3763
3764 self.assertEqual(A.data['status'], 'MERGED')
3765 self.assertEqual(A.reported, 2)
3766
James E. Blair96698e22015-04-02 07:48:21 -07003767 def test_crd_gate_reverse(self):
3768 "Test reverse cross-repo dependencies"
3769 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3770 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003771 A.addApproval('code-review', 2)
3772 B.addApproval('code-review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07003773
3774 # A Depends-On: B
3775
3776 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3777 A.subject, B.data['id'])
3778
James E. Blair8b5408c2016-08-08 15:37:46 -07003779 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003780 self.waitUntilSettled()
3781
3782 self.assertEqual(A.data['status'], 'NEW')
3783 self.assertEqual(B.data['status'], 'NEW')
3784
Paul Belanger174a8272017-03-14 13:20:10 -04003785 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003786 A.addApproval('approved', 1)
3787 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003788 self.waitUntilSettled()
3789
Paul Belanger174a8272017-03-14 13:20:10 -04003790 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003791 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003792 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003793 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003794 self.executor_server.hold_jobs_in_build = False
3795 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07003796 self.waitUntilSettled()
3797
3798 self.assertEqual(A.data['status'], 'MERGED')
3799 self.assertEqual(B.data['status'], 'MERGED')
3800 self.assertEqual(A.reported, 2)
3801 self.assertEqual(B.reported, 2)
3802
Paul Belanger5dccbe72016-11-14 11:17:37 -05003803 changes = self.getJobFromHistory(
3804 'project-merge', 'org/project1').changes
3805 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07003806
James E. Blair5ee24252014-12-30 10:12:29 -08003807 def test_crd_cycle(self):
3808 "Test cross-repo dependency cycles"
3809 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3810 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003811 A.addApproval('code-review', 2)
3812 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003813
3814 # A -> B -> A (via commit-depends)
3815
3816 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3817 A.subject, B.data['id'])
3818 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3819 B.subject, A.data['id'])
3820
James E. Blair8b5408c2016-08-08 15:37:46 -07003821 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003822 self.waitUntilSettled()
3823
3824 self.assertEqual(A.reported, 0)
3825 self.assertEqual(B.reported, 0)
3826 self.assertEqual(A.data['status'], 'NEW')
3827 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08003828
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003829 def test_crd_gate_unknown(self):
3830 "Test unknown projects in dependent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07003831 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003832 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3833 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003834 A.addApproval('code-review', 2)
3835 B.addApproval('code-review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003836
3837 # A Depends-On: B
3838 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3839 A.subject, B.data['id'])
3840
James E. Blair8b5408c2016-08-08 15:37:46 -07003841 B.addApproval('approved', 1)
3842 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003843 self.waitUntilSettled()
3844
3845 # Unknown projects cannot share a queue with any other
3846 # since they don't have common jobs with any other (they have no jobs).
3847 # Changes which depend on unknown project changes
3848 # should not be processed in dependent pipeline
3849 self.assertEqual(A.data['status'], 'NEW')
3850 self.assertEqual(B.data['status'], 'NEW')
3851 self.assertEqual(A.reported, 0)
3852 self.assertEqual(B.reported, 0)
3853 self.assertEqual(len(self.history), 0)
3854
3855 # Simulate change B being gated outside this layout
James E. Blair8b5408c2016-08-08 15:37:46 -07003856 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003857 B.setMerged()
3858 self.waitUntilSettled()
3859 self.assertEqual(len(self.history), 0)
3860
3861 # Now that B is merged, A should be able to be enqueued and
3862 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003863 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003864 self.waitUntilSettled()
3865
3866 self.assertEqual(A.data['status'], 'MERGED')
3867 self.assertEqual(A.reported, 2)
3868 self.assertEqual(B.data['status'], 'MERGED')
3869 self.assertEqual(B.reported, 0)
3870
James E. Blairbfb8e042014-12-30 17:01:44 -08003871 def test_crd_check(self):
3872 "Test cross-repo dependencies in independent pipelines"
3873
Paul Belanger174a8272017-03-14 13:20:10 -04003874 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08003875 self.gearman_server.hold_jobs_in_queue = True
3876 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3877 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3878
3879 # A Depends-On: B
3880 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3881 A.subject, B.data['id'])
3882
3883 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3884 self.waitUntilSettled()
3885
James E. Blairbfb8e042014-12-30 17:01:44 -08003886 self.gearman_server.hold_jobs_in_queue = False
3887 self.gearman_server.release()
3888 self.waitUntilSettled()
3889
Paul Belanger174a8272017-03-14 13:20:10 -04003890 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05003891 self.waitUntilSettled()
3892
James E. Blair2a535672017-04-27 12:03:15 -07003893 self.assertTrue(self.builds[0].hasChanges(A, B))
James E. Blairbfb8e042014-12-30 17:01:44 -08003894
Paul Belanger174a8272017-03-14 13:20:10 -04003895 self.executor_server.hold_jobs_in_build = False
3896 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05003897 self.waitUntilSettled()
3898
James E. Blairbfb8e042014-12-30 17:01:44 -08003899 self.assertEqual(A.data['status'], 'NEW')
3900 self.assertEqual(B.data['status'], 'NEW')
3901 self.assertEqual(A.reported, 1)
3902 self.assertEqual(B.reported, 0)
3903
3904 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05003905 tenant = self.sched.abide.tenants.get('tenant-one')
3906 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08003907
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003908 def test_crd_check_git_depends(self):
3909 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07003910 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003911 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3912 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
3913
3914 # Add two git-dependent changes and make sure they both report
3915 # success.
3916 B.setDependsOn(A, 1)
3917 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3918 self.waitUntilSettled()
3919 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3920 self.waitUntilSettled()
3921
James E. Blairb8c16472015-05-05 14:55:26 -07003922 self.orderedRelease()
3923 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003924 self.waitUntilSettled()
3925
3926 self.assertEqual(A.data['status'], 'NEW')
3927 self.assertEqual(B.data['status'], 'NEW')
3928 self.assertEqual(A.reported, 1)
3929 self.assertEqual(B.reported, 1)
3930
3931 self.assertEqual(self.history[0].changes, '1,1')
3932 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04003933 tenant = self.sched.abide.tenants.get('tenant-one')
3934 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003935
3936 self.assertIn('Build succeeded', A.messages[0])
3937 self.assertIn('Build succeeded', B.messages[0])
3938
3939 def test_crd_check_duplicate(self):
3940 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04003941 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003942 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3943 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04003944 tenant = self.sched.abide.tenants.get('tenant-one')
3945 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003946
3947 # Add two git-dependent changes...
3948 B.setDependsOn(A, 1)
3949 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3950 self.waitUntilSettled()
3951 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3952
3953 # ...make sure the live one is not duplicated...
3954 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3955 self.waitUntilSettled()
3956 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3957
3958 # ...but the non-live one is able to be.
3959 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3960 self.waitUntilSettled()
3961 self.assertEqual(len(check_pipeline.getAllItems()), 3)
3962
Clark Boylandd849822015-03-02 12:38:14 -08003963 # Release jobs in order to avoid races with change A jobs
3964 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07003965 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04003966 self.executor_server.hold_jobs_in_build = False
3967 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003968 self.waitUntilSettled()
3969
3970 self.assertEqual(A.data['status'], 'NEW')
3971 self.assertEqual(B.data['status'], 'NEW')
3972 self.assertEqual(A.reported, 1)
3973 self.assertEqual(B.reported, 1)
3974
3975 self.assertEqual(self.history[0].changes, '1,1 2,1')
3976 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04003977 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003978
3979 self.assertIn('Build succeeded', A.messages[0])
3980 self.assertIn('Build succeeded', B.messages[0])
3981
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003982 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08003983 "Test cross-repo dependencies re-enqueued in independent pipelines"
3984
3985 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003986 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
3987 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08003988
3989 # A Depends-On: B
3990 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3991 A.subject, B.data['id'])
3992
3993 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3994 self.waitUntilSettled()
3995
3996 self.sched.reconfigure(self.config)
3997
3998 # Make sure the items still share a change queue, and the
3999 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05004000 tenant = self.sched.abide.tenants.get('tenant-one')
4001 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
4002 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08004003 first_item = queue.queue[0]
4004 for item in queue.queue:
4005 self.assertEqual(item.queue, first_item.queue)
4006 self.assertFalse(first_item.live)
4007 self.assertTrue(queue.queue[1].live)
4008
4009 self.gearman_server.hold_jobs_in_queue = False
4010 self.gearman_server.release()
4011 self.waitUntilSettled()
4012
4013 self.assertEqual(A.data['status'], 'NEW')
4014 self.assertEqual(B.data['status'], 'NEW')
4015 self.assertEqual(A.reported, 1)
4016 self.assertEqual(B.reported, 0)
4017
4018 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004019 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004020
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004021 def test_crd_check_reconfiguration(self):
4022 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4023
4024 def test_crd_undefined_project(self):
4025 """Test that undefined projects in dependencies are handled for
4026 independent pipelines"""
4027 # It's a hack for fake gerrit,
4028 # as it implies repo creation upon the creation of any change
James E. Blairc4ba97a2017-04-19 16:26:24 -07004029 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004030 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4031
Jesse Keatingea68ab42017-04-19 15:03:30 -07004032 @simple_layout('layouts/ignore-dependencies.yaml')
James E. Blair17dd6772015-02-09 14:45:18 -08004033 def test_crd_check_ignore_dependencies(self):
4034 "Test cross-repo dependencies can be ignored"
James E. Blair17dd6772015-02-09 14:45:18 -08004035
4036 self.gearman_server.hold_jobs_in_queue = True
4037 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4038 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4039 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4040
4041 # A Depends-On: B
4042 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4043 A.subject, B.data['id'])
4044 # C git-depends on B
4045 C.setDependsOn(B, 1)
4046 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4047 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4048 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4049 self.waitUntilSettled()
4050
4051 # Make sure none of the items share a change queue, and all
4052 # are live.
Jesse Keatingea68ab42017-04-19 15:03:30 -07004053 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum12282ca2017-04-03 11:04:02 -07004054 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004055 self.assertEqual(len(check_pipeline.queues), 3)
4056 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4057 for item in check_pipeline.getAllItems():
4058 self.assertTrue(item.live)
4059
4060 self.gearman_server.hold_jobs_in_queue = False
4061 self.gearman_server.release()
4062 self.waitUntilSettled()
4063
4064 self.assertEqual(A.data['status'], 'NEW')
4065 self.assertEqual(B.data['status'], 'NEW')
4066 self.assertEqual(C.data['status'], 'NEW')
4067 self.assertEqual(A.reported, 1)
4068 self.assertEqual(B.reported, 1)
4069 self.assertEqual(C.reported, 1)
4070
4071 # Each job should have tested exactly one change
4072 for job in self.history:
4073 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004074
James E. Blair7cb84542017-04-19 13:35:05 -07004075 @simple_layout('layouts/three-projects.yaml')
James E. Blair96698e22015-04-02 07:48:21 -07004076 def test_crd_check_transitive(self):
4077 "Test transitive cross-repo dependencies"
4078 # Specifically, if A -> B -> C, and C gets a new patchset and
4079 # A gets a new patchset, ensure the test of A,2 includes B,1
4080 # and C,2 (not C,1 which would indicate stale data in the
4081 # cache for B).
4082 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4083 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4084 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4085
4086 # A Depends-On: B
4087 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4088 A.subject, B.data['id'])
4089
4090 # B Depends-On: C
4091 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4092 B.subject, C.data['id'])
4093
4094 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4095 self.waitUntilSettled()
4096 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4097
4098 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4099 self.waitUntilSettled()
4100 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4101
4102 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4103 self.waitUntilSettled()
4104 self.assertEqual(self.history[-1].changes, '3,1')
4105
4106 C.addPatchset()
4107 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4108 self.waitUntilSettled()
4109 self.assertEqual(self.history[-1].changes, '3,2')
4110
4111 A.addPatchset()
4112 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4113 self.waitUntilSettled()
4114 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004115
James E. Blaira8b90b32016-08-24 15:18:50 -07004116 def test_crd_check_unknown(self):
4117 "Test unknown projects in independent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004118 self.init_repo("org/unknown", tag='init')
James E. Blaira8b90b32016-08-24 15:18:50 -07004119 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4120 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4121 # A Depends-On: B
4122 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4123 A.subject, B.data['id'])
4124
4125 # Make sure zuul has seen an event on B.
4126 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4127 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4128 self.waitUntilSettled()
4129
4130 self.assertEqual(A.data['status'], 'NEW')
4131 self.assertEqual(A.reported, 1)
4132 self.assertEqual(B.data['status'], 'NEW')
4133 self.assertEqual(B.reported, 0)
4134
James E. Blair92464a22016-04-05 10:21:26 -07004135 def test_crd_cycle_join(self):
4136 "Test an updated change creates a cycle"
4137 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4138
4139 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4140 self.waitUntilSettled()
4141
4142 # Create B->A
4143 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4144 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4145 B.subject, A.data['id'])
4146 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4147 self.waitUntilSettled()
4148
4149 # Update A to add A->B (a cycle).
4150 A.addPatchset()
4151 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4152 A.subject, B.data['id'])
4153 # Normally we would submit the patchset-created event for
4154 # processing here, however, we have no way of noting whether
4155 # the dependency cycle detection correctly raised an
4156 # exception, so instead, we reach into the source driver and
4157 # call the method that would ultimately be called by the event
4158 # processing.
4159
Paul Belanger0e155e22016-11-14 14:12:23 -05004160 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07004161 (trusted, project) = tenant.getProject('org/project')
4162 source = project.source
Paul Belanger0e155e22016-11-14 14:12:23 -05004163
4164 # TODO(pabelanger): As we add more source / trigger APIs we should make
4165 # it easier for users to create events for testing.
4166 event = zuul.model.TriggerEvent()
4167 event.trigger_name = 'gerrit'
4168 event.change_number = '1'
4169 event.patch_number = '2'
James E. Blair92464a22016-04-05 10:21:26 -07004170 with testtools.ExpectedException(
4171 Exception, "Dependency cycle detected"):
Paul Belanger0e155e22016-11-14 14:12:23 -05004172 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004173 self.log.debug("Got expected dependency cycle exception")
4174
4175 # Now if we update B to remove the depends-on, everything
4176 # should be okay. B; A->B
4177
4178 B.addPatchset()
4179 B.data['commitMessage'] = '%s\n' % (B.subject,)
Paul Belanger0e155e22016-11-14 14:12:23 -05004180
4181 source.getChange(event, True)
4182 event.change_number = '2'
4183 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004184
Jesse Keatingcc67b122017-04-19 14:54:57 -07004185 @simple_layout('layouts/disable_at.yaml')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004186 def test_disable_at(self):
4187 "Test a pipeline will only report to the disabled trigger when failing"
4188
Jesse Keatingcc67b122017-04-19 14:54:57 -07004189 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004190 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004191 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004192 0, tenant.layout.pipelines['check']._consecutive_failures)
4193 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004194
4195 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4196 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4197 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4198 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4199 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4200 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4201 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4202 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4203 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4204 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4205 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4206
Paul Belanger174a8272017-03-14 13:20:10 -04004207 self.executor_server.failJob('project-test1', A)
4208 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004209 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004210 self.executor_server.failJob('project-test1', D)
4211 self.executor_server.failJob('project-test1', E)
4212 self.executor_server.failJob('project-test1', F)
4213 self.executor_server.failJob('project-test1', G)
4214 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004215 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004216 self.executor_server.failJob('project-test1', J)
4217 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004218
4219 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4220 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4221 self.waitUntilSettled()
4222
4223 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004224 2, tenant.layout.pipelines['check']._consecutive_failures)
4225 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004226
4227 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4228 self.waitUntilSettled()
4229
4230 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004231 0, tenant.layout.pipelines['check']._consecutive_failures)
4232 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004233
4234 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4235 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4236 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4237 self.waitUntilSettled()
4238
4239 # We should be disabled now
4240 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004241 3, tenant.layout.pipelines['check']._consecutive_failures)
4242 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004243
4244 # We need to wait between each of these patches to make sure the
4245 # smtp messages come back in an expected order
4246 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4247 self.waitUntilSettled()
4248 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4249 self.waitUntilSettled()
4250 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4251 self.waitUntilSettled()
4252
4253 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4254 # leaving a message on each change
4255 self.assertEqual(1, len(A.messages))
4256 self.assertIn('Build failed.', A.messages[0])
4257 self.assertEqual(1, len(B.messages))
4258 self.assertIn('Build failed.', B.messages[0])
4259 self.assertEqual(1, len(C.messages))
4260 self.assertIn('Build succeeded.', C.messages[0])
4261 self.assertEqual(1, len(D.messages))
4262 self.assertIn('Build failed.', D.messages[0])
4263 self.assertEqual(1, len(E.messages))
4264 self.assertIn('Build failed.', E.messages[0])
4265 self.assertEqual(1, len(F.messages))
4266 self.assertIn('Build failed.', F.messages[0])
4267
4268 # The last 3 (GHI) would have only reported via smtp.
4269 self.assertEqual(3, len(self.smtp_messages))
4270 self.assertEqual(0, len(G.messages))
4271 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004272 self.assertIn(
4273 'project-test1 https://server/job', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004274 self.assertEqual(0, len(H.messages))
4275 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004276 self.assertIn(
4277 'project-test1 https://server/job', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004278 self.assertEqual(0, len(I.messages))
4279 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004280 self.assertIn(
4281 'project-test1 https://server/job', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004282
4283 # Now reload the configuration (simulate a HUP) to check the pipeline
4284 # comes out of disabled
4285 self.sched.reconfigure(self.config)
4286
Jesse Keatingcc67b122017-04-19 14:54:57 -07004287 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004288
4289 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004290 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004291 0, tenant.layout.pipelines['check']._consecutive_failures)
4292 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004293
4294 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4295 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4296 self.waitUntilSettled()
4297
4298 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004299 2, tenant.layout.pipelines['check']._consecutive_failures)
4300 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004301
4302 # J and K went back to gerrit
4303 self.assertEqual(1, len(J.messages))
4304 self.assertIn('Build failed.', J.messages[0])
4305 self.assertEqual(1, len(K.messages))
4306 self.assertIn('Build failed.', K.messages[0])
4307 # No more messages reported via smtp
4308 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004309
James E. Blaircc020532017-04-19 13:04:44 -07004310 @simple_layout('layouts/one-job-project.yaml')
4311 def test_one_job_project(self):
4312 "Test that queueing works with one job"
4313 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4314 'master', 'A')
4315 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4316 'master', 'B')
4317 A.addApproval('code-review', 2)
4318 B.addApproval('code-review', 2)
4319 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4320 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4321 self.waitUntilSettled()
4322
4323 self.assertEqual(A.data['status'], 'MERGED')
4324 self.assertEqual(A.reported, 2)
4325 self.assertEqual(B.data['status'], 'MERGED')
4326 self.assertEqual(B.reported, 2)
4327
Paul Belanger71d98172016-11-08 10:56:31 -05004328 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004329 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004330
Paul Belanger174a8272017-03-14 13:20:10 -04004331 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004332 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4333 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4334 self.waitUntilSettled()
4335
Paul Belanger174a8272017-03-14 13:20:10 -04004336 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004337 self.waitUntilSettled()
4338
4339 self.assertEqual(len(self.builds), 2)
4340 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004341 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004342 self.waitUntilSettled()
4343
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004344 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004345 self.assertEqual(len(self.builds), 1,
4346 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004347 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004348 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004349 self.waitUntilSettled()
4350
Paul Belanger174a8272017-03-14 13:20:10 -04004351 self.executor_server.hold_jobs_in_build = False
4352 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004353 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004354 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004355 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4356 self.assertEqual(A.reported, 1)
4357 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004358
James E. Blair15be0e12017-01-03 13:45:20 -08004359 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004360 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004361
4362 self.fake_nodepool.paused = True
4363 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4364 A.addApproval('code-review', 2)
4365 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4366 self.waitUntilSettled()
4367
4368 self.zk.client.stop()
4369 self.zk.client.start()
4370 self.fake_nodepool.paused = False
4371 self.waitUntilSettled()
4372
4373 self.assertEqual(A.data['status'], 'MERGED')
4374 self.assertEqual(A.reported, 2)
4375
James E. Blair6ab79e02017-01-06 10:10:17 -08004376 def test_nodepool_failure(self):
4377 "Test that jobs are reported after a nodepool failure"
4378
4379 self.fake_nodepool.paused = True
4380 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4381 A.addApproval('code-review', 2)
4382 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4383 self.waitUntilSettled()
4384
4385 req = self.fake_nodepool.getNodeRequests()[0]
4386 self.fake_nodepool.addFailRequest(req)
4387
4388 self.fake_nodepool.paused = False
4389 self.waitUntilSettled()
4390
4391 self.assertEqual(A.data['status'], 'NEW')
4392 self.assertEqual(A.reported, 2)
4393 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4394 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4395 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4396
Arieb6f068c2016-10-09 13:11:06 +03004397
James E. Blaira002b032017-04-18 10:35:48 -07004398class TestExecutor(ZuulTestCase):
4399 tenant_config_file = 'config/single-tenant/main.yaml'
4400
4401 def assertFinalState(self):
4402 # In this test, we expect to shut down in a non-final state,
4403 # so skip these checks.
4404 pass
4405
4406 def assertCleanShutdown(self):
4407 self.log.debug("Assert clean shutdown")
4408
4409 # After shutdown, make sure no jobs are running
4410 self.assertEqual({}, self.executor_server.job_workers)
4411
4412 # Make sure that git.Repo objects have been garbage collected.
4413 repos = []
4414 gc.collect()
4415 for obj in gc.get_objects():
4416 if isinstance(obj, git.Repo):
4417 self.log.debug("Leaked git repo object: %s" % repr(obj))
4418 repos.append(obj)
4419 self.assertEqual(len(repos), 0)
4420
4421 def test_executor_shutdown(self):
4422 "Test that the executor can shut down with jobs running"
4423
4424 self.executor_server.hold_jobs_in_build = True
4425 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4426 A.addApproval('code-review', 2)
4427 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4428 self.waitUntilSettled()
4429
4430
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004431class TestDependencyGraph(ZuulTestCase):
4432 tenant_config_file = 'config/dependency-graph/main.yaml'
4433
4434 def test_dependeny_graph_dispatch_jobs_once(self):
4435 "Test a job in a dependency graph is queued only once"
4436 # Job dependencies, starting with A
4437 # A
4438 # / \
4439 # B C
4440 # / \ / \
4441 # D F E
4442 # |
4443 # G
4444
4445 self.executor_server.hold_jobs_in_build = True
4446 change = self.fake_gerrit.addFakeChange(
4447 'org/project', 'master', 'change')
4448 change.addApproval('code-review', 2)
4449 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4450
4451 self.waitUntilSettled()
4452 self.assertEqual([b.name for b in self.builds], ['A'])
4453
4454 self.executor_server.release('A')
4455 self.waitUntilSettled()
4456 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4457
4458 self.executor_server.release('B')
4459 self.waitUntilSettled()
4460 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4461
4462 self.executor_server.release('D')
4463 self.waitUntilSettled()
4464 self.assertEqual([b.name for b in self.builds], ['C'])
4465
4466 self.executor_server.release('C')
4467 self.waitUntilSettled()
4468 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4469
4470 self.executor_server.release('F')
4471 self.waitUntilSettled()
4472 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4473
4474 self.executor_server.release('G')
4475 self.waitUntilSettled()
4476 self.assertEqual([b.name for b in self.builds], ['E'])
4477
4478 self.executor_server.release('E')
4479 self.waitUntilSettled()
4480 self.assertEqual(len(self.builds), 0)
4481
4482 self.executor_server.hold_jobs_in_build = False
4483 self.executor_server.release()
4484 self.waitUntilSettled()
4485
4486 self.assertEqual(len(self.builds), 0)
4487 self.assertEqual(len(self.history), 7)
4488
4489 self.assertEqual(change.data['status'], 'MERGED')
4490 self.assertEqual(change.reported, 2)
4491
4492 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4493 "Test that a job waits till all dependencies are successful"
4494 # Job dependencies, starting with A
4495 # A
4496 # / \
4497 # B C*
4498 # / \ / \
4499 # D F E
4500 # |
4501 # G
4502
4503 self.executor_server.hold_jobs_in_build = True
4504 change = self.fake_gerrit.addFakeChange(
4505 'org/project', 'master', 'change')
4506 change.addApproval('code-review', 2)
4507
4508 self.executor_server.failJob('C', change)
4509
4510 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4511
4512 self.waitUntilSettled()
4513 self.assertEqual([b.name for b in self.builds], ['A'])
4514
4515 self.executor_server.release('A')
4516 self.waitUntilSettled()
4517 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4518
4519 self.executor_server.release('B')
4520 self.waitUntilSettled()
4521 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4522
4523 self.executor_server.release('D')
4524 self.waitUntilSettled()
4525 self.assertEqual([b.name for b in self.builds], ['C'])
4526
4527 self.executor_server.release('C')
4528 self.waitUntilSettled()
4529 self.assertEqual(len(self.builds), 0)
4530
4531 self.executor_server.hold_jobs_in_build = False
4532 self.executor_server.release()
4533 self.waitUntilSettled()
4534
4535 self.assertEqual(len(self.builds), 0)
4536 self.assertEqual(len(self.history), 4)
4537
4538 self.assertEqual(change.data['status'], 'NEW')
4539 self.assertEqual(change.reported, 2)
4540
4541
Arieb6f068c2016-10-09 13:11:06 +03004542class TestDuplicatePipeline(ZuulTestCase):
4543 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
4544
4545 def test_duplicate_pipelines(self):
4546 "Test that a change matching multiple pipelines works"
4547
4548 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4549 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
4550 self.waitUntilSettled()
4551
4552 self.assertHistory([
4553 dict(name='project-test1', result='SUCCESS', changes='1,1',
4554 pipeline='dup1'),
4555 dict(name='project-test1', result='SUCCESS', changes='1,1',
4556 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05004557 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03004558
4559 self.assertEqual(len(A.messages), 2)
4560
Paul Belangera46a3742016-11-09 14:23:03 -05004561 if 'dup1' in A.messages[0]:
4562 self.assertIn('dup1', A.messages[0])
4563 self.assertNotIn('dup2', A.messages[0])
4564 self.assertIn('project-test1', A.messages[0])
4565 self.assertIn('dup2', A.messages[1])
4566 self.assertNotIn('dup1', A.messages[1])
4567 self.assertIn('project-test1', A.messages[1])
4568 else:
4569 self.assertIn('dup1', A.messages[1])
4570 self.assertNotIn('dup2', A.messages[1])
4571 self.assertIn('project-test1', A.messages[1])
4572 self.assertIn('dup2', A.messages[0])
4573 self.assertNotIn('dup1', A.messages[0])
4574 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04004575
4576
Paul Belanger86085b32016-11-03 12:48:57 -04004577class TestSchedulerTemplatedProject(ZuulTestCase):
4578 tenant_config_file = 'config/templated-project/main.yaml'
4579
Paul Belanger174a8272017-03-14 13:20:10 -04004580 def test_job_from_templates_executed(self):
4581 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04004582
4583 A = self.fake_gerrit.addFakeChange(
4584 'org/templated-project', 'master', 'A')
4585 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4586 self.waitUntilSettled()
4587
4588 self.assertEqual(self.getJobFromHistory('project-test1').result,
4589 'SUCCESS')
4590 self.assertEqual(self.getJobFromHistory('project-test2').result,
4591 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04004592
4593 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004594 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04004595
4596 A = self.fake_gerrit.addFakeChange(
4597 'org/layered-project', 'master', 'A')
4598 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4599 self.waitUntilSettled()
4600
4601 self.assertEqual(self.getJobFromHistory('project-test1').result,
4602 'SUCCESS')
4603 self.assertEqual(self.getJobFromHistory('project-test2').result,
4604 'SUCCESS')
4605 self.assertEqual(self.getJobFromHistory('layered-project-test3'
4606 ).result, 'SUCCESS')
4607 self.assertEqual(self.getJobFromHistory('layered-project-test4'
4608 ).result, 'SUCCESS')
4609 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
4610 ).result, 'SUCCESS')
4611 self.assertEqual(self.getJobFromHistory('project-test6').result,
4612 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08004613
4614
4615class TestSchedulerSuccessURL(ZuulTestCase):
4616 tenant_config_file = 'config/success-url/main.yaml'
4617
4618 def test_success_url(self):
4619 "Ensure bad build params are ignored"
4620 self.sched.reconfigure(self.config)
4621 self.init_repo('org/docs')
4622
4623 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
4624 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4625 self.waitUntilSettled()
4626
4627 # Both builds ran: docs-draft-test + docs-draft-test2
4628 self.assertEqual(len(self.history), 2)
4629
4630 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08004631 for build in self.history:
4632 if build.name == 'docs-draft-test':
4633 uuid = build.uuid[:7]
4634 break
Adam Gandelman94a60062016-11-21 16:43:14 -08004635
4636 # Two msgs: 'Starting...' + results
4637 self.assertEqual(len(self.smtp_messages), 2)
4638 body = self.smtp_messages[1]['body'].splitlines()
4639 self.assertEqual('Build succeeded.', body[0])
4640
4641 self.assertIn(
4642 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
4643 'docs-draft-test/%s/publish-docs/' % uuid,
4644 body[2])
4645
Paul Belanger174a8272017-03-14 13:20:10 -04004646 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08004647 self.assertIn(
4648 '- docs-draft-test2 https://server/job',
4649 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08004650
4651
Adam Gandelman4da00f62016-12-09 15:47:33 -08004652class TestSchedulerMerges(ZuulTestCase):
4653 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08004654
4655 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04004656 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08004657 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04004658 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08004659 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
4660 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
4661 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
4662 A.addApproval('code-review', 2)
4663 B.addApproval('code-review', 2)
4664 C.addApproval('code-review', 2)
4665 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4666 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4667 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4668 self.waitUntilSettled()
4669
4670 build = self.builds[-1]
4671 ref = self.getParameter(build, 'ZUUL_REF')
4672
James E. Blair2a535672017-04-27 12:03:15 -07004673 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4674 project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08004675 repo = git.Repo(path)
4676 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4677 repo_messages.reverse()
4678
Paul Belanger174a8272017-03-14 13:20:10 -04004679 self.executor_server.hold_jobs_in_build = False
4680 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08004681 self.waitUntilSettled()
4682
4683 return repo_messages
4684
4685 def _test_merge(self, mode):
4686 us_path = os.path.join(
4687 self.upstream_root, 'org/project-%s' % mode)
4688 expected_messages = [
4689 'initial commit',
4690 'add content from fixture',
4691 # the intermediate commits order is nondeterministic
4692 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
4693 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
4694 ]
4695 result = self._test_project_merge_mode(mode)
4696 self.assertEqual(result[:2], expected_messages[:2])
4697 self.assertEqual(result[-2:], expected_messages[-2:])
4698
4699 def test_project_merge_mode_merge(self):
4700 self._test_merge('merge')
4701
4702 def test_project_merge_mode_merge_resolve(self):
4703 self._test_merge('merge-resolve')
4704
4705 def test_project_merge_mode_cherrypick(self):
4706 expected_messages = [
4707 'initial commit',
4708 'add content from fixture',
4709 'A-1',
4710 'B-1',
4711 'C-1']
4712 result = self._test_project_merge_mode('cherry-pick')
4713 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08004714
4715 def test_merge_branch(self):
4716 "Test that the right commits are on alternate branches"
4717 self.create_branch('org/project-merge-branches', 'mp')
4718
Paul Belanger174a8272017-03-14 13:20:10 -04004719 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004720 A = self.fake_gerrit.addFakeChange(
4721 'org/project-merge-branches', 'mp', 'A')
4722 B = self.fake_gerrit.addFakeChange(
4723 'org/project-merge-branches', 'mp', 'B')
4724 C = self.fake_gerrit.addFakeChange(
4725 'org/project-merge-branches', 'mp', 'C')
4726 A.addApproval('code-review', 2)
4727 B.addApproval('code-review', 2)
4728 C.addApproval('code-review', 2)
4729 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4730 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4731 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4732 self.waitUntilSettled()
4733
Paul Belanger174a8272017-03-14 13:20:10 -04004734 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004735 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004736 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004737 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004738 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004739 self.waitUntilSettled()
4740
4741 build = self.builds[-1]
4742 self.assertEqual(self.getParameter(build, 'ZUUL_BRANCH'), 'mp')
4743 ref = self.getParameter(build, 'ZUUL_REF')
James E. Blair2a535672017-04-27 12:03:15 -07004744 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4745 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004746 repo = git.Repo(path)
4747
4748 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4749 repo_messages.reverse()
4750 correct_messages = [
4751 'initial commit',
4752 'add content from fixture',
4753 'mp commit',
4754 'A-1', 'B-1', 'C-1']
4755 self.assertEqual(repo_messages, correct_messages)
4756
Paul Belanger174a8272017-03-14 13:20:10 -04004757 self.executor_server.hold_jobs_in_build = False
4758 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004759 self.waitUntilSettled()
4760
4761 def test_merge_multi_branch(self):
4762 "Test that dependent changes on multiple branches are merged"
4763 self.create_branch('org/project-merge-branches', 'mp')
4764
Paul Belanger174a8272017-03-14 13:20:10 -04004765 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004766 A = self.fake_gerrit.addFakeChange(
4767 'org/project-merge-branches', 'master', 'A')
4768 B = self.fake_gerrit.addFakeChange(
4769 'org/project-merge-branches', 'mp', 'B')
4770 C = self.fake_gerrit.addFakeChange(
4771 'org/project-merge-branches', 'master', 'C')
4772 A.addApproval('code-review', 2)
4773 B.addApproval('code-review', 2)
4774 C.addApproval('code-review', 2)
4775 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4776 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4777 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4778 self.waitUntilSettled()
4779
4780 job_A = None
4781 for job in self.builds:
4782 if 'project-merge' in job.name:
4783 job_A = job
4784 ref_A = self.getParameter(job_A, 'ZUUL_REF')
4785 commit_A = self.getParameter(job_A, 'ZUUL_COMMIT')
4786 self.log.debug("Got Zuul ref for change A: %s" % ref_A)
4787 self.log.debug("Got Zuul commit for change A: %s" % commit_A)
4788
James E. Blair2a535672017-04-27 12:03:15 -07004789 path = os.path.join(job_A.jobdir.src_root, 'review.example.com',
4790 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004791 repo = git.Repo(path)
4792 repo_messages = [c.message.strip()
4793 for c in repo.iter_commits(ref_A)]
4794 repo_messages.reverse()
4795 correct_messages = [
4796 'initial commit', 'add content from fixture', 'A-1']
4797 self.assertEqual(repo_messages, correct_messages)
4798
Paul Belanger174a8272017-03-14 13:20:10 -04004799 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004800 self.waitUntilSettled()
4801
4802 job_B = None
4803 for job in self.builds:
4804 if 'project-merge' in job.name:
4805 job_B = job
4806 ref_B = self.getParameter(job_B, 'ZUUL_REF')
4807 commit_B = self.getParameter(job_B, 'ZUUL_COMMIT')
4808 self.log.debug("Got Zuul ref for change B: %s" % ref_B)
4809 self.log.debug("Got Zuul commit for change B: %s" % commit_B)
4810
James E. Blair2a535672017-04-27 12:03:15 -07004811 path = os.path.join(job_B.jobdir.src_root, 'review.example.com',
4812 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004813 repo = git.Repo(path)
4814 repo_messages = [c.message.strip()
4815 for c in repo.iter_commits(ref_B)]
4816 repo_messages.reverse()
4817 correct_messages = [
4818 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
4819 self.assertEqual(repo_messages, correct_messages)
4820
Paul Belanger174a8272017-03-14 13:20:10 -04004821 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004822 self.waitUntilSettled()
4823
4824 job_C = None
4825 for job in self.builds:
4826 if 'project-merge' in job.name:
4827 job_C = job
4828 ref_C = self.getParameter(job_C, 'ZUUL_REF')
4829 commit_C = self.getParameter(job_C, 'ZUUL_COMMIT')
4830 self.log.debug("Got Zuul ref for change C: %s" % ref_C)
4831 self.log.debug("Got Zuul commit for change C: %s" % commit_C)
James E. Blair2a535672017-04-27 12:03:15 -07004832 path = os.path.join(job_C.jobdir.src_root, 'review.example.com',
4833 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004834 repo = git.Repo(path)
4835 repo_messages = [c.message.strip()
4836 for c in repo.iter_commits(ref_C)]
4837
4838 repo_messages.reverse()
4839 correct_messages = [
4840 'initial commit', 'add content from fixture',
4841 'A-1', 'C-1']
4842 # Ensure the right commits are in the history for this ref
4843 self.assertEqual(repo_messages, correct_messages)
4844
Paul Belanger174a8272017-03-14 13:20:10 -04004845 self.executor_server.hold_jobs_in_build = False
4846 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004847 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01004848
4849
James E. Blair9ea0d0b2017-04-20 09:27:15 -07004850class TestSemaphore(ZuulTestCase):
4851 tenant_config_file = 'config/semaphore/main.yaml'
4852
4853 def test_semaphore_one(self):
4854 "Test semaphores with max=1 (mutex)"
4855 tenant = self.sched.abide.tenants.get('tenant-one')
4856
4857 self.executor_server.hold_jobs_in_build = True
4858
4859 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4860 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4861 self.assertFalse('test-semaphore' in
4862 tenant.semaphore_handler.semaphores)
4863
4864 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4865 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4866 self.waitUntilSettled()
4867
4868 self.assertEqual(len(self.builds), 3)
4869 self.assertEqual(self.builds[0].name, 'project-test1')
4870 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
4871 self.assertEqual(self.builds[2].name, 'project-test1')
4872
4873 self.executor_server.release('semaphore-one-test1')
4874 self.waitUntilSettled()
4875
4876 self.assertEqual(len(self.builds), 3)
4877 self.assertEqual(self.builds[0].name, 'project-test1')
4878 self.assertEqual(self.builds[1].name, 'project-test1')
4879 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4880 self.assertTrue('test-semaphore' in
4881 tenant.semaphore_handler.semaphores)
4882
4883 self.executor_server.release('semaphore-one-test2')
4884 self.waitUntilSettled()
4885
4886 self.assertEqual(len(self.builds), 3)
4887 self.assertEqual(self.builds[0].name, 'project-test1')
4888 self.assertEqual(self.builds[1].name, 'project-test1')
4889 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
4890 self.assertTrue('test-semaphore' in
4891 tenant.semaphore_handler.semaphores)
4892
4893 self.executor_server.release('semaphore-one-test1')
4894 self.waitUntilSettled()
4895
4896 self.assertEqual(len(self.builds), 3)
4897 self.assertEqual(self.builds[0].name, 'project-test1')
4898 self.assertEqual(self.builds[1].name, 'project-test1')
4899 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4900 self.assertTrue('test-semaphore' in
4901 tenant.semaphore_handler.semaphores)
4902
4903 self.executor_server.release('semaphore-one-test2')
4904 self.waitUntilSettled()
4905
4906 self.assertEqual(len(self.builds), 2)
4907 self.assertEqual(self.builds[0].name, 'project-test1')
4908 self.assertEqual(self.builds[1].name, 'project-test1')
4909 self.assertFalse('test-semaphore' in
4910 tenant.semaphore_handler.semaphores)
4911
4912 self.executor_server.hold_jobs_in_build = False
4913 self.executor_server.release()
4914
4915 self.waitUntilSettled()
4916 self.assertEqual(len(self.builds), 0)
4917
4918 self.assertEqual(A.reported, 1)
4919 self.assertEqual(B.reported, 1)
4920 self.assertFalse('test-semaphore' in
4921 tenant.semaphore_handler.semaphores)
4922
4923 def test_semaphore_two(self):
4924 "Test semaphores with max>1"
4925 tenant = self.sched.abide.tenants.get('tenant-one')
4926
4927 self.executor_server.hold_jobs_in_build = True
4928 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4929 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4930 self.assertFalse('test-semaphore-two' in
4931 tenant.semaphore_handler.semaphores)
4932
4933 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4934 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4935 self.waitUntilSettled()
4936
4937 self.assertEqual(len(self.builds), 4)
4938 self.assertEqual(self.builds[0].name, 'project-test1')
4939 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
4940 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
4941 self.assertEqual(self.builds[3].name, 'project-test1')
4942 self.assertTrue('test-semaphore-two' in
4943 tenant.semaphore_handler.semaphores)
4944 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4945 'test-semaphore-two', [])), 2)
4946
4947 self.executor_server.release('semaphore-two-test1')
4948 self.waitUntilSettled()
4949
4950 self.assertEqual(len(self.builds), 4)
4951 self.assertEqual(self.builds[0].name, 'project-test1')
4952 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
4953 self.assertEqual(self.builds[2].name, 'project-test1')
4954 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
4955 self.assertTrue('test-semaphore-two' in
4956 tenant.semaphore_handler.semaphores)
4957 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4958 'test-semaphore-two', [])), 2)
4959
4960 self.executor_server.release('semaphore-two-test2')
4961 self.waitUntilSettled()
4962
4963 self.assertEqual(len(self.builds), 4)
4964 self.assertEqual(self.builds[0].name, 'project-test1')
4965 self.assertEqual(self.builds[1].name, 'project-test1')
4966 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
4967 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
4968 self.assertTrue('test-semaphore-two' in
4969 tenant.semaphore_handler.semaphores)
4970 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4971 'test-semaphore-two', [])), 2)
4972
4973 self.executor_server.release('semaphore-two-test1')
4974 self.waitUntilSettled()
4975
4976 self.assertEqual(len(self.builds), 3)
4977 self.assertEqual(self.builds[0].name, 'project-test1')
4978 self.assertEqual(self.builds[1].name, 'project-test1')
4979 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
4980 self.assertTrue('test-semaphore-two' in
4981 tenant.semaphore_handler.semaphores)
4982 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4983 'test-semaphore-two', [])), 1)
4984
4985 self.executor_server.release('semaphore-two-test2')
4986 self.waitUntilSettled()
4987
4988 self.assertEqual(len(self.builds), 2)
4989 self.assertEqual(self.builds[0].name, 'project-test1')
4990 self.assertEqual(self.builds[1].name, 'project-test1')
4991 self.assertFalse('test-semaphore-two' in
4992 tenant.semaphore_handler.semaphores)
4993
4994 self.executor_server.hold_jobs_in_build = False
4995 self.executor_server.release()
4996
4997 self.waitUntilSettled()
4998 self.assertEqual(len(self.builds), 0)
4999
5000 self.assertEqual(A.reported, 1)
5001 self.assertEqual(B.reported, 1)
5002
5003 def test_semaphore_abandon(self):
5004 "Test abandon with job semaphores"
5005 self.executor_server.hold_jobs_in_build = True
5006 tenant = self.sched.abide.tenants.get('tenant-one')
5007 check_pipeline = tenant.layout.pipelines['check']
5008
5009 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5010 self.assertFalse('test-semaphore' in
5011 tenant.semaphore_handler.semaphores)
5012
5013 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5014 self.waitUntilSettled()
5015
5016 self.assertTrue('test-semaphore' in
5017 tenant.semaphore_handler.semaphores)
5018
5019 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
5020 self.waitUntilSettled()
5021
5022 # The check pipeline should be empty
5023 items = check_pipeline.getAllItems()
5024 self.assertEqual(len(items), 0)
5025
5026 # The semaphore should be released
5027 self.assertFalse('test-semaphore' in
5028 tenant.semaphore_handler.semaphores)
5029
5030 self.executor_server.hold_jobs_in_build = False
5031 self.executor_server.release()
5032 self.waitUntilSettled()
5033
5034 def test_semaphore_reconfigure(self):
5035 "Test reconfigure with job semaphores"
5036 self.executor_server.hold_jobs_in_build = True
5037 tenant = self.sched.abide.tenants.get('tenant-one')
5038 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5039 self.assertFalse('test-semaphore' in
5040 tenant.semaphore_handler.semaphores)
5041
5042 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5043 self.waitUntilSettled()
5044
5045 self.assertTrue('test-semaphore' in
5046 tenant.semaphore_handler.semaphores)
5047
5048 # reconfigure without layout change
5049 self.sched.reconfigure(self.config)
5050 self.waitUntilSettled()
5051 tenant = self.sched.abide.tenants.get('tenant-one')
5052
5053 # semaphore still must be held
5054 self.assertTrue('test-semaphore' in
5055 tenant.semaphore_handler.semaphores)
5056
5057 self.commitConfigUpdate(
5058 'common-config',
5059 'config/semaphore/zuul-reconfiguration.yaml')
5060 self.sched.reconfigure(self.config)
5061 self.waitUntilSettled()
5062 tenant = self.sched.abide.tenants.get('tenant-one')
5063
5064 self.executor_server.release('project-test1')
5065 self.waitUntilSettled()
5066
5067 # There should be no builds anymore
5068 self.assertEqual(len(self.builds), 0)
5069
5070 # The semaphore should be released
5071 self.assertFalse('test-semaphore' in
5072 tenant.semaphore_handler.semaphores)
5073
5074
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005075class TestSemaphoreMultiTenant(ZuulTestCase):
5076 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5077
5078 def test_semaphore_tenant_isolation(self):
5079 "Test semaphores in multiple tenants"
5080
5081 self.waitUntilSettled()
5082 tenant_one = self.sched.abide.tenants.get('tenant-one')
5083 tenant_two = self.sched.abide.tenants.get('tenant-two')
5084
5085 self.executor_server.hold_jobs_in_build = True
5086 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5087 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5088 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5089 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5090 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5091 self.assertFalse('test-semaphore' in
5092 tenant_one.semaphore_handler.semaphores)
5093 self.assertFalse('test-semaphore' in
5094 tenant_two.semaphore_handler.semaphores)
5095
5096 # add patches to project1 of tenant-one
5097 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5098 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5099 self.waitUntilSettled()
5100
5101 # one build of project1-test1 must run
5102 # semaphore of tenant-one must be acquired once
5103 # semaphore of tenant-two must not be acquired
5104 self.assertEqual(len(self.builds), 1)
5105 self.assertEqual(self.builds[0].name, 'project1-test1')
5106 self.assertTrue('test-semaphore' in
5107 tenant_one.semaphore_handler.semaphores)
5108 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5109 'test-semaphore', [])), 1)
5110 self.assertFalse('test-semaphore' in
5111 tenant_two.semaphore_handler.semaphores)
5112
5113 # add patches to project2 of tenant-two
5114 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5115 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5116 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5117 self.waitUntilSettled()
5118
5119 # one build of project1-test1 must run
5120 # two builds of project2-test1 must run
5121 # semaphore of tenant-one must be acquired once
5122 # semaphore of tenant-two must be acquired twice
5123 self.assertEqual(len(self.builds), 3)
5124 self.assertEqual(self.builds[0].name, 'project1-test1')
5125 self.assertEqual(self.builds[1].name, 'project2-test1')
5126 self.assertEqual(self.builds[2].name, 'project2-test1')
5127 self.assertTrue('test-semaphore' in
5128 tenant_one.semaphore_handler.semaphores)
5129 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5130 'test-semaphore', [])), 1)
5131 self.assertTrue('test-semaphore' in
5132 tenant_two.semaphore_handler.semaphores)
5133 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5134 'test-semaphore', [])), 2)
5135
5136 self.executor_server.release('project1-test1')
5137 self.waitUntilSettled()
5138
5139 # one build of project1-test1 must run
5140 # two builds of project2-test1 must run
5141 # semaphore of tenant-one must be acquired once
5142 # semaphore of tenant-two must be acquired twice
5143 self.assertEqual(len(self.builds), 3)
5144 self.assertEqual(self.builds[0].name, 'project2-test1')
5145 self.assertEqual(self.builds[1].name, 'project2-test1')
5146 self.assertEqual(self.builds[2].name, 'project1-test1')
5147 self.assertTrue('test-semaphore' in
5148 tenant_one.semaphore_handler.semaphores)
5149 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5150 'test-semaphore', [])), 1)
5151 self.assertTrue('test-semaphore' in
5152 tenant_two.semaphore_handler.semaphores)
5153 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5154 'test-semaphore', [])), 2)
5155
5156 self.executor_server.release('project2-test1')
5157 self.waitUntilSettled()
5158
5159 # one build of project1-test1 must run
5160 # one build of project2-test1 must run
5161 # semaphore of tenant-one must be acquired once
5162 # semaphore of tenant-two must be acquired once
5163 self.assertEqual(len(self.builds), 2)
5164 self.assertTrue('test-semaphore' in
5165 tenant_one.semaphore_handler.semaphores)
5166 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5167 'test-semaphore', [])), 1)
5168 self.assertTrue('test-semaphore' in
5169 tenant_two.semaphore_handler.semaphores)
5170 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5171 'test-semaphore', [])), 1)
5172
5173 self.executor_server.hold_jobs_in_build = False
5174 self.executor_server.release()
5175
5176 self.waitUntilSettled()
5177
5178 # no build must run
5179 # semaphore of tenant-one must not be acquired
5180 # semaphore of tenant-two must not be acquired
5181 self.assertEqual(len(self.builds), 0)
5182 self.assertFalse('test-semaphore' in
5183 tenant_one.semaphore_handler.semaphores)
5184 self.assertFalse('test-semaphore' in
5185 tenant_two.semaphore_handler.semaphores)
5186
5187 self.assertEqual(A.reported, 1)
5188 self.assertEqual(B.reported, 1)
5189
5190
5191class TestSemaphoreInRepo(ZuulTestCase):
5192 tenant_config_file = 'config/in-repo/main.yaml'
5193
5194 def test_semaphore_in_repo(self):
5195 "Test semaphores in repo config"
5196
5197 # This tests dynamic semaphore handling in project repos. The semaphore
5198 # max value should not be evaluated dynamically but must be updated
5199 # after the change lands.
5200
5201 self.waitUntilSettled()
5202 tenant = self.sched.abide.tenants.get('tenant-one')
5203
5204 in_repo_conf = textwrap.dedent(
5205 """
5206 - job:
5207 name: project-test2
5208 semaphore: test-semaphore
5209
5210 - project:
5211 name: org/project
5212 tenant-one-gate:
5213 jobs:
5214 - project-test2
5215
5216 # the max value in dynamic layout must be ignored
5217 - semaphore:
5218 name: test-semaphore
5219 max: 2
5220 """)
5221
5222 in_repo_playbook = textwrap.dedent(
5223 """
5224 - hosts: all
5225 tasks: []
5226 """)
5227
5228 file_dict = {'.zuul.yaml': in_repo_conf,
5229 'playbooks/project-test2.yaml': in_repo_playbook}
5230 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5231 files=file_dict)
5232 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5233 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5234 B.setDependsOn(A, 1)
5235 C.setDependsOn(A, 1)
5236
5237 self.executor_server.hold_jobs_in_build = True
5238
5239 A.addApproval('code-review', 2)
5240 B.addApproval('code-review', 2)
5241 C.addApproval('code-review', 2)
5242 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
5243 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
5244 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
5245 self.waitUntilSettled()
5246
5247 # check that the layout in a queue item still has max value of 1
5248 # for test-semaphore
5249 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5250 queue = None
5251 for queue_candidate in pipeline.queues:
5252 if queue_candidate.name == 'org/project':
5253 queue = queue_candidate
5254 break
5255 queue_item = queue.queue[0]
5256 item_dynamic_layout = queue_item.current_build_set.layout
5257 dynamic_test_semaphore = \
5258 item_dynamic_layout.semaphores.get('test-semaphore')
5259 self.assertEqual(dynamic_test_semaphore.max, 1)
5260
5261 # one build must be in queue, one semaphores acquired
5262 self.assertEqual(len(self.builds), 1)
5263 self.assertEqual(self.builds[0].name, 'project-test2')
5264 self.assertTrue('test-semaphore' in
5265 tenant.semaphore_handler.semaphores)
5266 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5267 'test-semaphore', [])), 1)
5268
5269 self.executor_server.release('project-test2')
5270 self.waitUntilSettled()
5271
5272 # change A must be merged
5273 self.assertEqual(A.data['status'], 'MERGED')
5274 self.assertEqual(A.reported, 2)
5275
5276 # send change-merged event as the gerrit mock doesn't send it
5277 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5278 self.waitUntilSettled()
5279
5280 # now that change A was merged, the new semaphore max must be effective
5281 tenant = self.sched.abide.tenants.get('tenant-one')
5282 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5283
5284 # two builds must be in queue, two semaphores acquired
5285 self.assertEqual(len(self.builds), 2)
5286 self.assertEqual(self.builds[0].name, 'project-test2')
5287 self.assertEqual(self.builds[1].name, 'project-test2')
5288 self.assertTrue('test-semaphore' in
5289 tenant.semaphore_handler.semaphores)
5290 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5291 'test-semaphore', [])), 2)
5292
5293 self.executor_server.release('project-test2')
5294 self.waitUntilSettled()
5295
5296 self.assertEqual(len(self.builds), 0)
5297 self.assertFalse('test-semaphore' in
5298 tenant.semaphore_handler.semaphores)
5299
5300 self.executor_server.hold_jobs_in_build = False
5301 self.executor_server.release()
5302
5303 self.waitUntilSettled()
5304 self.assertEqual(len(self.builds), 0)
5305
5306 self.assertEqual(A.reported, 2)
5307 self.assertEqual(B.reported, 2)
5308 self.assertEqual(C.reported, 2)