blob: 75b88fb374a12de8a48f5b4f35db999013ac582c [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
Clint Byrum03454a52017-05-26 17:14:02 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Monty Taylorbc758832013-06-17 17:22:42 -040028import testtools
Monty Taylorb934c1a2017-06-16 19:31:47 -050029import urllib
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
Clint Byrumb9de8be2017-05-27 13:49:19 -070032from zuul.driver.gerrit import gerritreporter
James E. Blairb0fcae42012-07-17 11:12:10 -070033import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080034import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040035import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070036
Maru Newby3fe5f852015-01-13 04:22:14 +000037from tests.base import (
Paul Belanger0a21f0a2017-06-13 13:14:42 -040038 SSLZuulTestCase,
Maru Newby3fe5f852015-01-13 04:22:14 +000039 ZuulTestCase,
40 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070041 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000042)
James E. Blairb0fcae42012-07-17 11:12:10 -070043
James E. Blairb0fcae42012-07-17 11:12:10 -070044
Paul Belanger0a21f0a2017-06-13 13:14:42 -040045class TestSchedulerSSL(SSLZuulTestCase):
46 tenant_config_file = 'config/single-tenant/main.yaml'
47
48 def test_jobs_executed(self):
49 "Test that jobs are executed and a change is merged"
Paul Belanger0a21f0a2017-06-13 13:14:42 -040050 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +020051 A.addApproval('Code-Review', 2)
52 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Paul Belanger0a21f0a2017-06-13 13:14:42 -040053 self.waitUntilSettled()
54 self.assertEqual(self.getJobFromHistory('project-merge').result,
55 'SUCCESS')
56 self.assertEqual(self.getJobFromHistory('project-test1').result,
57 'SUCCESS')
58 self.assertEqual(self.getJobFromHistory('project-test2').result,
59 'SUCCESS')
60 self.assertEqual(A.data['status'], 'MERGED')
61 self.assertEqual(A.reported, 2)
62 self.assertEqual(self.getJobFromHistory('project-test1').node,
63 'label1')
James E. Blairfcbf95d2017-07-25 16:38:09 -070064 self.assertEqual(self.getJobFromHistory('project-test2').node,
65 'label1')
Paul Belanger0a21f0a2017-06-13 13:14:42 -040066
67
Clark Boylanb640e052014-04-03 16:41:46 -070068class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070069 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010070
Paul Belanger174a8272017-03-14 13:20:10 -040071 def test_jobs_executed(self):
72 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070073
James E. Blairb0fcae42012-07-17 11:12:10 -070074 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +020075 A.addApproval('Code-Review', 2)
76 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070077 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040078 self.assertEqual(self.getJobFromHistory('project-merge').result,
79 'SUCCESS')
80 self.assertEqual(self.getJobFromHistory('project-test1').result,
81 'SUCCESS')
82 self.assertEqual(self.getJobFromHistory('project-test2').result,
83 'SUCCESS')
84 self.assertEqual(A.data['status'], 'MERGED')
85 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070086 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -070087 'label1')
James E. Blairfcbf95d2017-07-25 16:38:09 -070088 self.assertEqual(self.getJobFromHistory('project-test2').node,
89 'label1')
James E. Blairb0fcae42012-07-17 11:12:10 -070090
James E. Blair80ac1582017-10-09 07:02:40 -070091 for stat in self.statsd.stats:
92 k, v = stat.decode('utf-8').split(':')
93 self.log.debug('stat %s:%s', k, v)
James E. Blair552b54f2016-07-22 13:55:32 -070094 # TODOv3(jeblair): we may want to report stats by tenant (also?).
Monty Taylorf1385042017-05-27 12:25:05 -050095 # Per-driver
96 self.assertReportedStat('zuul.event.gerrit.comment-added', value='1|c')
97 # Per-driver per-connection
98 self.assertReportedStat('zuul.event.gerrit.gerrit.comment-added',
99 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -0700100 self.assertReportedStat(
James E. Blair80ac1582017-10-09 07:02:40 -0700101 'zuul.tenant.tenant-one.pipeline.gate.current_changes',
102 value='1|g')
James E. Blair412e5582013-04-22 15:50:12 -0700103 self.assertReportedStat(
James E. Blair80ac1582017-10-09 07:02:40 -0700104 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
105 'org_project.master.job.project-merge.SUCCESS', kind='ms')
106 self.assertReportedStat(
107 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
108 'org_project.master.job.project-merge.SUCCESS', value='1|c')
109 self.assertReportedStat(
110 'zuul.tenant.tenant-one.pipeline.gate.resident_time', kind='ms')
111 self.assertReportedStat(
112 'zuul.tenant.tenant-one.pipeline.gate.total_changes', value='1|c')
113 self.assertReportedStat(
114 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
115 'org_project.master.resident_time', kind='ms')
116 self.assertReportedStat(
117 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
118 'org_project.master.total_changes', value='1|c')
James E. Blairfaf81982017-10-10 15:42:26 -0700119 exec_key = 'zuul.executor.%s' % self.executor_server.hostname
120 self.assertReportedStat(exec_key + '.builds', value='1|c')
James E. Blair4f1731b2017-10-10 18:11:42 -0700121 self.assertReportedStat('zuul.nodepool.requested', value='1|c')
122 self.assertReportedStat('zuul.nodepool.requested.label.label1',
123 value='1|c')
124 self.assertReportedStat('zuul.nodepool.fulfilled.label.label1',
125 value='1|c')
126 self.assertReportedStat('zuul.nodepool.requested.size.1', value='1|c')
127 self.assertReportedStat('zuul.nodepool.fulfilled.size.1', value='1|c')
128 self.assertReportedStat('zuul.nodepool.current_requests', value='1|g')
James E. Blairbdd50e62017-10-21 08:18:55 -0700129 self.assertReportedStat('zuul.executors.online', value='1|g')
130 self.assertReportedStat('zuul.executors.accepting', value='1|g')
131 self.assertReportedStat('zuul.mergers.online', value='1|g')
James E. Blair412e5582013-04-22 15:50:12 -0700132
James E. Blair2ef29e92017-07-21 15:25:05 -0700133 for build in self.history:
134 self.assertTrue(build.parameters['zuul']['voting'])
James E. Blair5821bd92015-09-16 08:48:15 -0700135
James E. Blair3cb10702013-08-24 08:56:03 -0700136 def test_initial_pipeline_gauges(self):
137 "Test that each pipeline reported its length on start"
James E. Blair7da51b72016-07-25 15:29:43 -0700138 self.assertReportedStat('zuul.pipeline.gate.current_changes',
139 value='0|g')
140 self.assertReportedStat('zuul.pipeline.check.current_changes',
141 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -0700142
James E. Blair34776ee2016-08-25 13:53:54 -0700143 def test_job_branch(self):
144 "Test the correct variant of a job runs on a branch"
145 self.create_branch('org/project', 'stable')
146 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200147 A.addApproval('Code-Review', 2)
148 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair34776ee2016-08-25 13:53:54 -0700149 self.waitUntilSettled()
150 self.assertEqual(self.getJobFromHistory('project-test1').result,
151 'SUCCESS')
152 self.assertEqual(self.getJobFromHistory('project-test2').result,
153 'SUCCESS')
154 self.assertEqual(A.data['status'], 'MERGED')
155 self.assertEqual(A.reported, 2,
156 "A should report start and success")
157 self.assertIn('gate', A.messages[1],
158 "A should transit gate")
159 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -0700160 'label2')
James E. Blair34776ee2016-08-25 13:53:54 -0700161
James E. Blairb0fcae42012-07-17 11:12:10 -0700162 def test_parallel_changes(self):
163 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700164
Paul Belanger174a8272017-03-14 13:20:10 -0400165 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700166 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
167 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
168 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200169 A.addApproval('Code-Review', 2)
170 B.addApproval('Code-Review', 2)
171 C.addApproval('Code-Review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700172
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200173 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
174 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
175 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700176
177 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400178 self.assertEqual(len(self.builds), 1)
179 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700180 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700181
Paul Belanger174a8272017-03-14 13:20:10 -0400182 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700183 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400184 self.assertEqual(len(self.builds), 3)
185 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700186 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400187 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700188 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400189 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700190 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700191
Paul Belanger174a8272017-03-14 13:20:10 -0400192 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700193 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400194 self.assertEqual(len(self.builds), 5)
195 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700196 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400197 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700198 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700199
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400200 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700201 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400202 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700203 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700204
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400205 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700206 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700207
Paul Belanger174a8272017-03-14 13:20:10 -0400208 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700209 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400210 self.assertEqual(len(self.builds), 6)
211 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700212 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400213 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700214 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700215
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400216 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700217 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400218 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700219 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700220
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400221 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700222 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400223 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700224 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700225
Paul Belanger174a8272017-03-14 13:20:10 -0400226 self.executor_server.hold_jobs_in_build = False
227 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700228 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400229 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700230
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400231 self.assertEqual(len(self.history), 9)
232 self.assertEqual(A.data['status'], 'MERGED')
233 self.assertEqual(B.data['status'], 'MERGED')
234 self.assertEqual(C.data['status'], 'MERGED')
235 self.assertEqual(A.reported, 2)
236 self.assertEqual(B.reported, 2)
237 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700238
239 def test_failed_changes(self):
240 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400241 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700242
James E. Blairb02a3bb2012-07-30 17:49:55 -0700243 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
244 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200245 A.addApproval('Code-Review', 2)
246 B.addApproval('Code-Review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700247
Paul Belanger174a8272017-03-14 13:20:10 -0400248 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700249
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200250 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
251 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700252 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700253 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400254
Paul Belanger174a8272017-03-14 13:20:10 -0400255 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400256 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700257 # A/project-merge is complete
258 self.assertBuilds([
259 dict(name='project-test1', changes='1,1'),
260 dict(name='project-test2', changes='1,1'),
261 dict(name='project-merge', changes='1,1 2,1'),
262 ])
James E. Blaire2819012013-06-28 17:17:26 -0400263
Paul Belanger174a8272017-03-14 13:20:10 -0400264 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400265 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700266 # A/project-merge is complete
267 # B/project-merge is complete
268 self.assertBuilds([
269 dict(name='project-test1', changes='1,1'),
270 dict(name='project-test2', changes='1,1'),
271 dict(name='project-test1', changes='1,1 2,1'),
272 dict(name='project-test2', changes='1,1 2,1'),
273 ])
274
275 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400276 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700277 self.builds[0].release()
278 self.waitUntilSettled()
279
280 self.orderedRelease()
281 self.assertHistory([
282 dict(name='project-merge', result='SUCCESS', changes='1,1'),
283 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
284 dict(name='project-test1', result='FAILURE', changes='1,1'),
285 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
286 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
287 dict(name='project-test2', result='SUCCESS', changes='1,1'),
288 dict(name='project-merge', result='SUCCESS', changes='2,1'),
289 dict(name='project-test1', result='SUCCESS', changes='2,1'),
290 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700291 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700292
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400293 self.assertEqual(A.data['status'], 'NEW')
294 self.assertEqual(B.data['status'], 'MERGED')
295 self.assertEqual(A.reported, 2)
296 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700297
298 def test_independent_queues(self):
299 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700300
Paul Belanger174a8272017-03-14 13:20:10 -0400301 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900302 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700303 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
304 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200305 A.addApproval('Code-Review', 2)
306 B.addApproval('Code-Review', 2)
307 C.addApproval('Code-Review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700308
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200309 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800310 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700311
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200312 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800313 self.waitUntilSettled()
314
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200315 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700316 self.waitUntilSettled()
317
318 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700319 self.assertBuilds([
320 dict(name='project-merge', changes='1,1'),
321 dict(name='project-merge', changes='2,1'),
322 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700323
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700324 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700325 self.builds[0].release()
326 self.waitUntilSettled()
327 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700328 self.waitUntilSettled()
329 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400330 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700331 self.waitUntilSettled()
332
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700333 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700334 self.assertBuilds([
335 dict(name='project-test1', changes='1,1'),
336 dict(name='project-test2', changes='1,1'),
337 dict(name='project-test1', changes='2,1'),
338 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500339 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700340 dict(name='project-test1', changes='2,1 3,1'),
341 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800342 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700343 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700344
James E. Blair5f0d49e2016-08-19 09:36:50 -0700345 self.orderedRelease()
346 self.assertHistory([
347 dict(name='project-merge', result='SUCCESS', changes='1,1'),
348 dict(name='project-merge', result='SUCCESS', changes='2,1'),
349 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
350 dict(name='project-test1', result='SUCCESS', changes='1,1'),
351 dict(name='project-test2', result='SUCCESS', changes='1,1'),
352 dict(name='project-test1', result='SUCCESS', changes='2,1'),
353 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500354 dict(
355 name='project1-project2-integration',
356 result='SUCCESS',
357 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700358 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
359 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800360 dict(name='project1-project2-integration',
361 result='SUCCESS',
362 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700363 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700364
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400365 self.assertEqual(A.data['status'], 'MERGED')
366 self.assertEqual(B.data['status'], 'MERGED')
367 self.assertEqual(C.data['status'], 'MERGED')
368 self.assertEqual(A.reported, 2)
369 self.assertEqual(B.reported, 2)
370 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700371
372 def test_failed_change_at_head(self):
373 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700374
Paul Belanger174a8272017-03-14 13:20:10 -0400375 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700376 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
377 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
378 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200379 A.addApproval('Code-Review', 2)
380 B.addApproval('Code-Review', 2)
381 C.addApproval('Code-Review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700382
Paul Belanger174a8272017-03-14 13:20:10 -0400383 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700384
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200385 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
386 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
387 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700388
389 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700390
James E. Blairb536ecc2016-08-31 10:11:42 -0700391 self.assertBuilds([
392 dict(name='project-merge', changes='1,1'),
393 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700394
Paul Belanger174a8272017-03-14 13:20:10 -0400395 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700396 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400397 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700398 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400399 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700400 self.waitUntilSettled()
401
James E. Blairb536ecc2016-08-31 10:11:42 -0700402 self.assertBuilds([
403 dict(name='project-test1', changes='1,1'),
404 dict(name='project-test2', changes='1,1'),
405 dict(name='project-test1', changes='1,1 2,1'),
406 dict(name='project-test2', changes='1,1 2,1'),
407 dict(name='project-test1', changes='1,1 2,1 3,1'),
408 dict(name='project-test2', changes='1,1 2,1 3,1'),
409 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700410
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400411 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700412 self.waitUntilSettled()
413
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400414 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700415 self.assertBuilds([
416 dict(name='project-test2', changes='1,1'),
417 dict(name='project-merge', changes='2,1'),
418 ])
419 # Unordered history comparison because the aborts can finish
420 # in any order.
421 self.assertHistory([
422 dict(name='project-merge', result='SUCCESS',
423 changes='1,1'),
424 dict(name='project-merge', result='SUCCESS',
425 changes='1,1 2,1'),
426 dict(name='project-merge', result='SUCCESS',
427 changes='1,1 2,1 3,1'),
428 dict(name='project-test1', result='FAILURE',
429 changes='1,1'),
430 dict(name='project-test1', result='ABORTED',
431 changes='1,1 2,1'),
432 dict(name='project-test2', result='ABORTED',
433 changes='1,1 2,1'),
434 dict(name='project-test1', result='ABORTED',
435 changes='1,1 2,1 3,1'),
436 dict(name='project-test2', result='ABORTED',
437 changes='1,1 2,1 3,1'),
438 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700439
Paul Belanger174a8272017-03-14 13:20:10 -0400440 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700441 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400442 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700443 self.waitUntilSettled()
444 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700445
James E. Blairb536ecc2016-08-31 10:11:42 -0700446 self.assertBuilds([])
447 self.assertHistory([
448 dict(name='project-merge', result='SUCCESS',
449 changes='1,1'),
450 dict(name='project-merge', result='SUCCESS',
451 changes='1,1 2,1'),
452 dict(name='project-merge', result='SUCCESS',
453 changes='1,1 2,1 3,1'),
454 dict(name='project-test1', result='FAILURE',
455 changes='1,1'),
456 dict(name='project-test1', result='ABORTED',
457 changes='1,1 2,1'),
458 dict(name='project-test2', result='ABORTED',
459 changes='1,1 2,1'),
460 dict(name='project-test1', result='ABORTED',
461 changes='1,1 2,1 3,1'),
462 dict(name='project-test2', result='ABORTED',
463 changes='1,1 2,1 3,1'),
464 dict(name='project-merge', result='SUCCESS',
465 changes='2,1'),
466 dict(name='project-merge', result='SUCCESS',
467 changes='2,1 3,1'),
468 dict(name='project-test2', result='SUCCESS',
469 changes='1,1'),
470 dict(name='project-test1', result='SUCCESS',
471 changes='2,1'),
472 dict(name='project-test2', result='SUCCESS',
473 changes='2,1'),
474 dict(name='project-test1', result='SUCCESS',
475 changes='2,1 3,1'),
476 dict(name='project-test2', result='SUCCESS',
477 changes='2,1 3,1'),
478 ], ordered=False)
479
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400480 self.assertEqual(A.data['status'], 'NEW')
481 self.assertEqual(B.data['status'], 'MERGED')
482 self.assertEqual(C.data['status'], 'MERGED')
483 self.assertEqual(A.reported, 2)
484 self.assertEqual(B.reported, 2)
485 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700486
James E. Blair0aac4872013-08-23 14:02:38 -0700487 def test_failed_change_in_middle(self):
488 "Test a failed change in the middle of the queue"
489
Paul Belanger174a8272017-03-14 13:20:10 -0400490 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700491 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
492 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
493 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200494 A.addApproval('Code-Review', 2)
495 B.addApproval('Code-Review', 2)
496 C.addApproval('Code-Review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700497
Paul Belanger174a8272017-03-14 13:20:10 -0400498 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700499
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200500 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
501 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
502 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700503
504 self.waitUntilSettled()
505
Paul Belanger174a8272017-03-14 13:20:10 -0400506 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700507 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400508 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700509 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400510 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700511 self.waitUntilSettled()
512
513 self.assertEqual(len(self.builds), 6)
514 self.assertEqual(self.builds[0].name, 'project-test1')
515 self.assertEqual(self.builds[1].name, 'project-test2')
516 self.assertEqual(self.builds[2].name, 'project-test1')
517 self.assertEqual(self.builds[3].name, 'project-test2')
518 self.assertEqual(self.builds[4].name, 'project-test1')
519 self.assertEqual(self.builds[5].name, 'project-test2')
520
521 self.release(self.builds[2])
522 self.waitUntilSettled()
523
James E. Blair972e3c72013-08-29 12:04:55 -0700524 # project-test1 and project-test2 for A
525 # project-test2 for B
526 # project-merge for C (without B)
527 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700528 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
529
Paul Belanger174a8272017-03-14 13:20:10 -0400530 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700531 self.waitUntilSettled()
532
533 # project-test1 and project-test2 for A
534 # project-test2 for B
535 # project-test1 and project-test2 for C
536 self.assertEqual(len(self.builds), 5)
537
Paul Belanger2e2a0492016-10-30 18:33:37 -0400538 tenant = self.sched.abide.tenants.get('tenant-one')
539 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700540 builds = items[0].current_build_set.getBuilds()
541 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
542 self.assertEqual(self.countJobResults(builds, None), 2)
543 builds = items[1].current_build_set.getBuilds()
544 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
545 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
546 self.assertEqual(self.countJobResults(builds, None), 1)
547 builds = items[2].current_build_set.getBuilds()
548 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700549 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700550
Paul Belanger174a8272017-03-14 13:20:10 -0400551 self.executor_server.hold_jobs_in_build = False
552 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700553 self.waitUntilSettled()
554
555 self.assertEqual(len(self.builds), 0)
556 self.assertEqual(len(self.history), 12)
557 self.assertEqual(A.data['status'], 'MERGED')
558 self.assertEqual(B.data['status'], 'NEW')
559 self.assertEqual(C.data['status'], 'MERGED')
560 self.assertEqual(A.reported, 2)
561 self.assertEqual(B.reported, 2)
562 self.assertEqual(C.reported, 2)
563
James E. Blaird466dc42012-07-31 10:42:56 -0700564 def test_failed_change_at_head_with_queue(self):
565 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700566
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700567 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700568 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
569 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
570 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200571 A.addApproval('Code-Review', 2)
572 B.addApproval('Code-Review', 2)
573 C.addApproval('Code-Review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700574
Paul Belanger174a8272017-03-14 13:20:10 -0400575 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700576
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200577 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
578 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
579 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700580
581 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700582 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400583 self.assertEqual(len(self.builds), 0)
584 self.assertEqual(len(queue), 1)
Clint Byrumf322fe22017-05-10 20:53:12 -0700585 self.assertEqual(queue[0].name, b'executor:execute')
586 job_args = json.loads(queue[0].arguments.decode('utf8'))
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800587 self.assertEqual(job_args['job'], 'project-merge')
588 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700589
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700590 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700591 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700592 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700593 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700594 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700595 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700596 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700597
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400598 self.assertEqual(len(self.builds), 0)
599 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800600
601 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700602 json.loads(queue[0].arguments.decode('utf8'))['job'],
603 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800604 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700605 json.loads(queue[1].arguments.decode('utf8'))['job'],
606 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800607 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700608 json.loads(queue[2].arguments.decode('utf8'))['job'],
609 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800610 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700611 json.loads(queue[3].arguments.decode('utf8'))['job'],
612 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800613 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700614 json.loads(queue[4].arguments.decode('utf8'))['job'],
615 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800616 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700617 json.loads(queue[5].arguments.decode('utf8'))['job'],
618 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700619
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700620 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700621 self.waitUntilSettled()
622
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400623 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700624 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400625 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
626 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700627
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700628 self.gearman_server.hold_jobs_in_queue = False
629 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700630 self.waitUntilSettled()
631
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400632 self.assertEqual(len(self.builds), 0)
633 self.assertEqual(len(self.history), 11)
634 self.assertEqual(A.data['status'], 'NEW')
635 self.assertEqual(B.data['status'], 'MERGED')
636 self.assertEqual(C.data['status'], 'MERGED')
637 self.assertEqual(A.reported, 2)
638 self.assertEqual(B.reported, 2)
639 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700640
James E. Blairce8a2132016-05-19 15:21:52 -0700641 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400642 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700643 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200644 A.addApproval('Code-Review', 2)
645 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700646 self.waitUntilSettled()
647 time.sleep(2)
648
James E. Blairae0f23c2017-09-13 10:55:15 -0600649 data = json.loads(self.sched.formatStatusJSON('tenant-one'))
James E. Blairce8a2132016-05-19 15:21:52 -0700650 found_job = None
651 for pipeline in data['pipelines']:
652 if pipeline['name'] != 'gate':
653 continue
654 for queue in pipeline['change_queues']:
655 for head in queue['heads']:
656 for item in head:
657 for job in item['jobs']:
658 if job['name'] == 'project-merge':
659 found_job = job
660 break
661
662 self.assertIsNotNone(found_job)
663 if iteration == 1:
664 self.assertIsNotNone(found_job['estimated_time'])
665 self.assertIsNone(found_job['remaining_time'])
666 else:
667 self.assertIsNotNone(found_job['estimated_time'])
668 self.assertTrue(found_job['estimated_time'] >= 2)
669 self.assertIsNotNone(found_job['remaining_time'])
670
Paul Belanger174a8272017-03-14 13:20:10 -0400671 self.executor_server.hold_jobs_in_build = False
672 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700673 self.waitUntilSettled()
674
675 def test_time_database(self):
676 "Test the time database"
677
678 self._test_time_database(1)
679 self._test_time_database(2)
680
James E. Blairfef71632013-09-23 11:15:47 -0700681 def test_two_failed_changes_at_head(self):
682 "Test that changes are reparented correctly if 2 fail at head"
683
Paul Belanger174a8272017-03-14 13:20:10 -0400684 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700685 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
686 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
687 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200688 A.addApproval('Code-Review', 2)
689 B.addApproval('Code-Review', 2)
690 C.addApproval('Code-Review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700691
Paul Belanger174a8272017-03-14 13:20:10 -0400692 self.executor_server.failJob('project-test1', A)
693 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700694
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200695 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
696 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
697 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700698 self.waitUntilSettled()
699
Paul Belanger174a8272017-03-14 13:20:10 -0400700 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700701 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400702 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700703 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400704 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700705 self.waitUntilSettled()
706
707 self.assertEqual(len(self.builds), 6)
708 self.assertEqual(self.builds[0].name, 'project-test1')
709 self.assertEqual(self.builds[1].name, 'project-test2')
710 self.assertEqual(self.builds[2].name, 'project-test1')
711 self.assertEqual(self.builds[3].name, 'project-test2')
712 self.assertEqual(self.builds[4].name, 'project-test1')
713 self.assertEqual(self.builds[5].name, 'project-test2')
714
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400715 self.assertTrue(self.builds[0].hasChanges(A))
716 self.assertTrue(self.builds[2].hasChanges(A))
717 self.assertTrue(self.builds[2].hasChanges(B))
718 self.assertTrue(self.builds[4].hasChanges(A))
719 self.assertTrue(self.builds[4].hasChanges(B))
720 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700721
722 # Fail change B first
723 self.release(self.builds[2])
724 self.waitUntilSettled()
725
726 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400727 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700728 self.waitUntilSettled()
729
730 self.assertEqual(len(self.builds), 5)
731 self.assertEqual(self.builds[0].name, 'project-test1')
732 self.assertEqual(self.builds[1].name, 'project-test2')
733 self.assertEqual(self.builds[2].name, 'project-test2')
734 self.assertEqual(self.builds[3].name, 'project-test1')
735 self.assertEqual(self.builds[4].name, 'project-test2')
736
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400737 self.assertTrue(self.builds[1].hasChanges(A))
738 self.assertTrue(self.builds[2].hasChanges(A))
739 self.assertTrue(self.builds[2].hasChanges(B))
740 self.assertTrue(self.builds[4].hasChanges(A))
741 self.assertFalse(self.builds[4].hasChanges(B))
742 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700743
744 # Finish running all passing jobs for change A
745 self.release(self.builds[1])
746 self.waitUntilSettled()
747 # Fail and report change A
748 self.release(self.builds[0])
749 self.waitUntilSettled()
750
751 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400752 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700753 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400754 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700755 self.waitUntilSettled()
756
757 self.assertEqual(len(self.builds), 4)
758 self.assertEqual(self.builds[0].name, 'project-test1') # B
759 self.assertEqual(self.builds[1].name, 'project-test2') # B
760 self.assertEqual(self.builds[2].name, 'project-test1') # C
761 self.assertEqual(self.builds[3].name, 'project-test2') # C
762
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400763 self.assertFalse(self.builds[1].hasChanges(A))
764 self.assertTrue(self.builds[1].hasChanges(B))
765 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700766
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400767 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700768 # After A failed and B and C restarted, B should be back in
769 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400770 self.assertTrue(self.builds[2].hasChanges(B))
771 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700772
Paul Belanger174a8272017-03-14 13:20:10 -0400773 self.executor_server.hold_jobs_in_build = False
774 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700775 self.waitUntilSettled()
776
777 self.assertEqual(len(self.builds), 0)
778 self.assertEqual(len(self.history), 21)
779 self.assertEqual(A.data['status'], 'NEW')
780 self.assertEqual(B.data['status'], 'NEW')
781 self.assertEqual(C.data['status'], 'MERGED')
782 self.assertEqual(A.reported, 2)
783 self.assertEqual(B.reported, 2)
784 self.assertEqual(C.reported, 2)
785
James E. Blair8c803f82012-07-31 16:25:42 -0700786 def test_patch_order(self):
787 "Test that dependent patches are tested in the right order"
788 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
789 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
790 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200791 A.addApproval('Code-Review', 2)
792 B.addApproval('Code-Review', 2)
793 C.addApproval('Code-Review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700794
795 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
796 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
797 M2.setMerged()
798 M1.setMerged()
799
800 # C -> B -> A -> M1 -> M2
801 # M2 is here to make sure it is never queried. If it is, it
802 # means zuul is walking down the entire history of merged
803 # changes.
804
805 C.setDependsOn(B, 1)
806 B.setDependsOn(A, 1)
807 A.setDependsOn(M1, 1)
808 M1.setDependsOn(M2, 1)
809
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200810 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700811
812 self.waitUntilSettled()
813
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400814 self.assertEqual(A.data['status'], 'NEW')
815 self.assertEqual(B.data['status'], 'NEW')
816 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700817
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200818 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
819 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700820
821 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400822 self.assertEqual(M2.queried, 0)
823 self.assertEqual(A.data['status'], 'MERGED')
824 self.assertEqual(B.data['status'], 'MERGED')
825 self.assertEqual(C.data['status'], 'MERGED')
826 self.assertEqual(A.reported, 2)
827 self.assertEqual(B.reported, 2)
828 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700829
James E. Blair063672f2015-01-29 13:09:12 -0800830 def test_needed_changes_enqueue(self):
831 "Test that a needed change is enqueued ahead"
832 # A Given a git tree like this, if we enqueue
833 # / \ change C, we should walk up and down the tree
834 # B G and enqueue changes in the order ABCDEFG.
835 # /|\ This is also the order that you would get if
836 # *C E F you enqueued changes in the order ABCDEFG, so
837 # / the ordering is stable across re-enqueue events.
838 # D
839
840 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
841 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
842 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
843 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
844 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
845 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
846 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
847 B.setDependsOn(A, 1)
848 C.setDependsOn(B, 1)
849 D.setDependsOn(C, 1)
850 E.setDependsOn(B, 1)
851 F.setDependsOn(B, 1)
852 G.setDependsOn(A, 1)
853
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200854 A.addApproval('Code-Review', 2)
855 B.addApproval('Code-Review', 2)
856 C.addApproval('Code-Review', 2)
857 D.addApproval('Code-Review', 2)
858 E.addApproval('Code-Review', 2)
859 F.addApproval('Code-Review', 2)
860 G.addApproval('Code-Review', 2)
861 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800862
863 self.waitUntilSettled()
864
865 self.assertEqual(A.data['status'], 'NEW')
866 self.assertEqual(B.data['status'], 'NEW')
867 self.assertEqual(C.data['status'], 'NEW')
868 self.assertEqual(D.data['status'], 'NEW')
869 self.assertEqual(E.data['status'], 'NEW')
870 self.assertEqual(F.data['status'], 'NEW')
871 self.assertEqual(G.data['status'], 'NEW')
872
873 # We're about to add approvals to changes without adding the
874 # triggering events to Zuul, so that we can be sure that it is
875 # enqueing the changes based on dependencies, not because of
876 # triggering events. Since it will have the changes cached
877 # already (without approvals), we need to clear the cache
878 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400879 for connection in self.connections.connections.values():
James E. Blairb0a95ab2017-10-18 09:39:18 -0700880 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800881
Paul Belanger174a8272017-03-14 13:20:10 -0400882 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200883 A.addApproval('Approved', 1)
884 B.addApproval('Approved', 1)
885 D.addApproval('Approved', 1)
886 E.addApproval('Approved', 1)
887 F.addApproval('Approved', 1)
888 G.addApproval('Approved', 1)
889 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800890
891 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400892 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800893 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400894 self.executor_server.hold_jobs_in_build = False
895 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800896 self.waitUntilSettled()
897
898 self.assertEqual(A.data['status'], 'MERGED')
899 self.assertEqual(B.data['status'], 'MERGED')
900 self.assertEqual(C.data['status'], 'MERGED')
901 self.assertEqual(D.data['status'], 'MERGED')
902 self.assertEqual(E.data['status'], 'MERGED')
903 self.assertEqual(F.data['status'], 'MERGED')
904 self.assertEqual(G.data['status'], 'MERGED')
905 self.assertEqual(A.reported, 2)
906 self.assertEqual(B.reported, 2)
907 self.assertEqual(C.reported, 2)
908 self.assertEqual(D.reported, 2)
909 self.assertEqual(E.reported, 2)
910 self.assertEqual(F.reported, 2)
911 self.assertEqual(G.reported, 2)
912 self.assertEqual(self.history[6].changes,
913 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
914
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100915 def test_source_cache(self):
916 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400917 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700918
919 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
920 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
921 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200922 A.addApproval('Code-Review', 2)
923 B.addApproval('Code-Review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700924
925 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
926 M1.setMerged()
927
928 B.setDependsOn(A, 1)
929 A.setDependsOn(M1, 1)
930
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200931 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700932 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
933
934 self.waitUntilSettled()
935
936 for build in self.builds:
James E. Blaire675d682017-07-21 15:29:35 -0700937 if build.pipeline == 'check':
James E. Blair0e933c52013-07-11 10:18:52 -0700938 build.release()
939 self.waitUntilSettled()
940 for build in self.builds:
James E. Blaire675d682017-07-21 15:29:35 -0700941 if build.pipeline == 'check':
James E. Blair0e933c52013-07-11 10:18:52 -0700942 build.release()
943 self.waitUntilSettled()
944
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200945 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700946 self.waitUntilSettled()
947
Joshua Hesketh352264b2015-08-11 23:42:08 +1000948 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700949 # there should still be changes in the cache
James E. Blairb0a95ab2017-10-18 09:39:18 -0700950 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700951
Paul Belanger174a8272017-03-14 13:20:10 -0400952 self.executor_server.hold_jobs_in_build = False
953 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700954 self.waitUntilSettled()
955
956 self.assertEqual(A.data['status'], 'MERGED')
957 self.assertEqual(B.data['status'], 'MERGED')
958 self.assertEqual(A.queried, 2) # Initial and isMerged
959 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
960
James E. Blair8c803f82012-07-31 16:25:42 -0700961 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700962 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700963 # TODO: move to test_gerrit (this is a unit test!)
964 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400965 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700966 (trusted, project) = tenant.getProject('org/project')
967 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400968
969 # TODO(pabelanger): As we add more source / trigger APIs we should make
970 # it easier for users to create events for testing.
971 event = zuul.model.TriggerEvent()
972 event.trigger_name = 'gerrit'
973 event.change_number = '1'
974 event.patch_number = '2'
975
976 a = source.getChange(event)
977 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700978 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700979
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200980 A.addApproval('Code-Review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400981 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700982 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700983
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200984 A.addApproval('Approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400985 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700986 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700987
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700988 def test_project_merge_conflict(self):
989 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700990
991 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700992 A = self.fake_gerrit.addFakeChange('org/project',
993 'master', 'A',
994 files={'conflict': 'foo'})
995 B = self.fake_gerrit.addFakeChange('org/project',
996 'master', 'B',
997 files={'conflict': 'bar'})
998 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -0700999 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001000 A.addApproval('Code-Review', 2)
1001 B.addApproval('Code-Review', 2)
1002 C.addApproval('Code-Review', 2)
1003 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1004 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1005 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -07001006 self.waitUntilSettled()
1007
James E. Blair6736beb2013-07-11 15:18:15 -07001008 self.assertEqual(A.reported, 1)
James E. Blair6736beb2013-07-11 15:18:15 -07001009 self.assertEqual(C.reported, 1)
1010
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001011 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -07001012 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001013 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -07001014 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001015 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -07001016 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -07001017
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001018 self.gearman_server.hold_jobs_in_queue = False
1019 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -07001020 self.waitUntilSettled()
1021
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001022 self.assertEqual(A.data['status'], 'MERGED')
1023 self.assertEqual(B.data['status'], 'NEW')
1024 self.assertEqual(C.data['status'], 'MERGED')
1025 self.assertEqual(A.reported, 2)
Tobias Henkel9842bd72017-05-16 13:40:03 +02001026 self.assertIn('Merge Failed', B.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001027 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001028
1029 self.assertHistory([
1030 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1031 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1032 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1033 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
1034 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
1035 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
1036 ], ordered=False)
1037
1038 def test_delayed_merge_conflict(self):
1039 "Test that delayed check merge conflicts are handled properly"
1040
1041 # Hold jobs in the gearman queue so that we can test whether
James E. Blair1960d682017-04-28 15:44:14 -07001042 # the executor sucesfully merges a change based on an old
1043 # repo state (frozen by the scheduler) which would otherwise
1044 # conflict.
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001045 self.gearman_server.hold_jobs_in_queue = True
1046 A = self.fake_gerrit.addFakeChange('org/project',
1047 'master', 'A',
1048 files={'conflict': 'foo'})
1049 B = self.fake_gerrit.addFakeChange('org/project',
1050 'master', 'B',
1051 files={'conflict': 'bar'})
1052 C = self.fake_gerrit.addFakeChange('org/project',
1053 'master', 'C')
1054 C.setDependsOn(B, 1)
1055
1056 # A enters the gate queue; B and C enter the check queue
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001057 A.addApproval('Code-Review', 2)
1058 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001059 self.waitUntilSettled()
1060 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
James E. Blair8d144dc2017-05-05 10:13:45 -07001061 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001062 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1063 self.waitUntilSettled()
1064
1065 self.assertEqual(A.reported, 1)
1066 self.assertEqual(B.reported, 0) # Check does not report start
1067 self.assertEqual(C.reported, 0) # Check does not report start
1068
1069 # A merges while B and C are queued in check
1070 # Release A project-merge
1071 queue = self.gearman_server.getQueue()
1072 self.release(queue[0])
1073 self.waitUntilSettled()
1074
1075 # Release A project-test*
1076 # gate has higher precedence, so A's test jobs are added in
1077 # front of the merge jobs for B and C
1078 queue = self.gearman_server.getQueue()
1079 self.release(queue[0])
1080 self.release(queue[1])
1081 self.waitUntilSettled()
1082
1083 self.assertEqual(A.data['status'], 'MERGED')
1084 self.assertEqual(B.data['status'], 'NEW')
1085 self.assertEqual(C.data['status'], 'NEW')
1086 self.assertEqual(A.reported, 2)
1087 self.assertEqual(B.reported, 0)
1088 self.assertEqual(C.reported, 0)
1089 self.assertHistory([
1090 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1091 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1092 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1093 ], ordered=False)
1094
1095 # B and C report merge conflicts
1096 # Release B project-merge
1097 queue = self.gearman_server.getQueue()
1098 self.release(queue[0])
1099 self.waitUntilSettled()
1100
1101 # Release C
1102 self.gearman_server.hold_jobs_in_queue = False
1103 self.gearman_server.release()
1104 self.waitUntilSettled()
1105
1106 self.assertEqual(A.data['status'], 'MERGED')
1107 self.assertEqual(B.data['status'], 'NEW')
1108 self.assertEqual(C.data['status'], 'NEW')
1109 self.assertEqual(A.reported, 2)
1110 self.assertEqual(B.reported, 1)
1111 self.assertEqual(C.reported, 1)
1112
1113 self.assertHistory([
1114 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1115 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1116 dict(name='project-test2', result='SUCCESS', changes='1,1'),
James E. Blair1960d682017-04-28 15:44:14 -07001117 dict(name='project-merge', result='SUCCESS', changes='2,1'),
1118 dict(name='project-test1', result='SUCCESS', changes='2,1'),
1119 dict(name='project-test2', result='SUCCESS', changes='2,1'),
1120 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
1121 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
1122 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001123 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001124
James E. Blairdaabed22012-08-15 15:38:57 -07001125 def test_post(self):
1126 "Test that post jobs run"
James E. Blair289f5932017-07-27 15:02:29 -07001127 p = "review.example.com/org/project"
1128 upstream = self.getUpstreamRepos([p])
1129 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1130 A.setMerged()
1131 A_commit = str(upstream[p].commit('master'))
1132 self.log.debug("A commit: %s" % A_commit)
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001133
Zhongyue Luo5d556072012-09-21 02:00:47 +09001134 e = {
1135 "type": "ref-updated",
1136 "submitter": {
1137 "name": "User Name",
1138 },
1139 "refUpdate": {
1140 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
James E. Blair289f5932017-07-27 15:02:29 -07001141 "newRev": A_commit,
Zhongyue Luo5d556072012-09-21 02:00:47 +09001142 "refName": "master",
1143 "project": "org/project",
1144 }
1145 }
James E. Blairdaabed22012-08-15 15:38:57 -07001146 self.fake_gerrit.addEvent(e)
1147 self.waitUntilSettled()
1148
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001149 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001150 self.assertEqual(len(self.history), 1)
1151 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001152
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001153 def test_post_ignore_deletes(self):
1154 "Test that deleting refs does not trigger post jobs"
1155
1156 e = {
1157 "type": "ref-updated",
1158 "submitter": {
1159 "name": "User Name",
1160 },
1161 "refUpdate": {
1162 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1163 "newRev": "0000000000000000000000000000000000000000",
1164 "refName": "master",
1165 "project": "org/project",
1166 }
1167 }
1168 self.fake_gerrit.addEvent(e)
1169 self.waitUntilSettled()
1170
1171 job_names = [x.name for x in self.history]
1172 self.assertEqual(len(self.history), 0)
1173 self.assertNotIn('project-post', job_names)
1174
James E. Blaircc324192017-04-19 14:36:08 -07001175 @simple_layout('layouts/dont-ignore-ref-deletes.yaml')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001176 def test_post_ignore_deletes_negative(self):
1177 "Test that deleting refs does trigger post jobs"
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001178 e = {
1179 "type": "ref-updated",
1180 "submitter": {
1181 "name": "User Name",
1182 },
1183 "refUpdate": {
1184 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1185 "newRev": "0000000000000000000000000000000000000000",
James E. Blair289f5932017-07-27 15:02:29 -07001186 "refName": "testbranch",
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001187 "project": "org/project",
1188 }
1189 }
1190 self.fake_gerrit.addEvent(e)
1191 self.waitUntilSettled()
1192
1193 job_names = [x.name for x in self.history]
1194 self.assertEqual(len(self.history), 1)
1195 self.assertIn('project-post', job_names)
1196
James E. Blairec056492016-07-22 09:45:56 -07001197 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001198 def test_build_configuration_branch_interaction(self):
1199 "Test that switching between branches works"
1200 self.test_build_configuration()
1201 self.test_build_configuration_branch()
1202 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001203 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001204 repo = git.Repo(path)
1205 repo.heads.master.commit = repo.commit('init')
1206 self.test_build_configuration()
1207
James E. Blairdb93b302017-07-19 15:33:11 -07001208 def test_dependent_changes_rebase(self):
1209 # Test that no errors occur when we walk a dependency tree
1210 # with an unused leaf node due to a rebase.
1211 # Start by constructing: C -> B -> A
1212 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1213 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1214 B.setDependsOn(A, 1)
1215
1216 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1217 C.setDependsOn(B, 1)
1218
1219 # Then rebase to form: D -> C -> A
1220 C.addPatchset() # C,2
1221 C.setDependsOn(A, 1)
1222
1223 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1224 D.setDependsOn(C, 2)
1225
1226 # Walk the entire tree
1227 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1228 self.waitUntilSettled()
1229 self.assertEqual(len(self.history), 3)
1230
1231 # Verify that walking just part of the tree still works
1232 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
1233 self.waitUntilSettled()
1234 self.assertEqual(len(self.history), 6)
1235
James E. Blaircaec0c52012-08-22 14:52:22 -07001236 def test_dependent_changes_dequeue(self):
1237 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001238
James E. Blaircaec0c52012-08-22 14:52:22 -07001239 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1240 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1241 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001242 A.addApproval('Code-Review', 2)
1243 B.addApproval('Code-Review', 2)
1244 C.addApproval('Code-Review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001245
1246 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1247 M1.setMerged()
1248
1249 # C -> B -> A -> M1
1250
1251 C.setDependsOn(B, 1)
1252 B.setDependsOn(A, 1)
1253 A.setDependsOn(M1, 1)
1254
Paul Belanger174a8272017-03-14 13:20:10 -04001255 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001256
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001257 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1258 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1259 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001260
1261 self.waitUntilSettled()
1262
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001263 self.assertEqual(A.data['status'], 'NEW')
1264 self.assertEqual(A.reported, 2)
1265 self.assertEqual(B.data['status'], 'NEW')
1266 self.assertEqual(B.reported, 2)
1267 self.assertEqual(C.data['status'], 'NEW')
James E. Blair0d3e83b2017-06-05 13:51:57 -07001268 self.assertIn('This change depends on a change that failed to merge.',
1269 C.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001270 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001271
James E. Blair972e3c72013-08-29 12:04:55 -07001272 def test_failing_dependent_changes(self):
1273 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001274 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001275 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1276 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1277 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1278 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1279 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001280 A.addApproval('Code-Review', 2)
1281 B.addApproval('Code-Review', 2)
1282 C.addApproval('Code-Review', 2)
1283 D.addApproval('Code-Review', 2)
1284 E.addApproval('Code-Review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001285
1286 # E, D -> C -> B, A
1287
1288 D.setDependsOn(C, 1)
1289 C.setDependsOn(B, 1)
1290
Paul Belanger174a8272017-03-14 13:20:10 -04001291 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001292
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001293 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1294 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
1295 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1296 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1297 self.fake_gerrit.addEvent(E.addApproval('Approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001298
1299 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001300 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001301 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001302 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001303 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001304 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001305 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001306 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001307 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001308 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001309 self.waitUntilSettled()
1310
Paul Belanger174a8272017-03-14 13:20:10 -04001311 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001312 for build in self.builds:
James E. Blaire3db2952017-07-21 15:03:36 -07001313 if build.parameters['zuul']['change'] != '1':
James E. Blair972e3c72013-08-29 12:04:55 -07001314 build.release()
1315 self.waitUntilSettled()
1316
Paul Belanger174a8272017-03-14 13:20:10 -04001317 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001318 self.waitUntilSettled()
1319
1320 self.assertEqual(A.data['status'], 'MERGED')
1321 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001322 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001323 self.assertEqual(B.data['status'], 'NEW')
1324 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001325 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001326 self.assertEqual(C.data['status'], 'NEW')
1327 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001328 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001329 self.assertEqual(D.data['status'], 'NEW')
1330 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001331 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001332 self.assertEqual(E.data['status'], 'MERGED')
1333 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001334 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001335 self.assertEqual(len(self.history), 18)
1336
James E. Blairec590122012-08-22 15:19:31 -07001337 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001338 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001339 # If it's dequeued more than once, we should see extra
1340 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001341
Paul Belanger174a8272017-03-14 13:20:10 -04001342 self.executor_server.hold_jobs_in_build = True
James E. Blair6df67132017-04-19 13:53:20 -07001343 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1344 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1345 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001346 A.addApproval('Code-Review', 2)
1347 B.addApproval('Code-Review', 2)
1348 C.addApproval('Code-Review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001349
Paul Belanger174a8272017-03-14 13:20:10 -04001350 self.executor_server.failJob('project-test1', A)
1351 self.executor_server.failJob('project-test2', A)
James E. Blairec590122012-08-22 15:19:31 -07001352
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001353 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1354 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1355 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001356
1357 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001358
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001359 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001360 self.assertEqual(self.builds[0].name, 'project-merge')
1361 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001362
Paul Belanger174a8272017-03-14 13:20:10 -04001363 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001364 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001365 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001366 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001367 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001368 self.waitUntilSettled()
1369
James E. Blair6df67132017-04-19 13:53:20 -07001370 self.assertEqual(len(self.builds), 6)
Paul Belanger58bf6912016-11-11 19:36:01 -05001371 self.assertEqual(self.builds[0].name, 'project-test1')
1372 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair6df67132017-04-19 13:53:20 -07001373 self.assertEqual(self.builds[2].name, 'project-test1')
1374 self.assertEqual(self.builds[3].name, 'project-test2')
1375 self.assertEqual(self.builds[4].name, 'project-test1')
1376 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blairec590122012-08-22 15:19:31 -07001377
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001378 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001379 self.waitUntilSettled()
1380
James E. Blair6df67132017-04-19 13:53:20 -07001381 self.assertEqual(len(self.builds), 2) # test2, merge for B
1382 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
James E. Blairec590122012-08-22 15:19:31 -07001383
Paul Belanger174a8272017-03-14 13:20:10 -04001384 self.executor_server.hold_jobs_in_build = False
1385 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001386 self.waitUntilSettled()
1387
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001388 self.assertEqual(len(self.builds), 0)
James E. Blair6df67132017-04-19 13:53:20 -07001389 self.assertEqual(len(self.history), 15)
James E. Blaircaec0c52012-08-22 14:52:22 -07001390
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001391 self.assertEqual(A.data['status'], 'NEW')
1392 self.assertEqual(B.data['status'], 'MERGED')
1393 self.assertEqual(C.data['status'], 'MERGED')
1394 self.assertEqual(A.reported, 2)
1395 self.assertEqual(B.reported, 2)
1396 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001397
James E. Blaircc020532017-04-19 13:04:44 -07001398 @simple_layout('layouts/nonvoting-job.yaml')
James E. Blair4ec821f2012-08-23 15:28:28 -07001399 def test_nonvoting_job(self):
1400 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001401
James E. Blair4ec821f2012-08-23 15:28:28 -07001402 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1403 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001404 A.addApproval('Code-Review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001405 self.executor_server.failJob('nonvoting-project-test2', A)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001406 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001407
1408 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001409
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001410 self.assertEqual(A.data['status'], 'MERGED')
1411 self.assertEqual(A.reported, 2)
1412 self.assertEqual(
1413 self.getJobFromHistory('nonvoting-project-merge').result,
1414 'SUCCESS')
1415 self.assertEqual(
1416 self.getJobFromHistory('nonvoting-project-test1').result,
1417 'SUCCESS')
1418 self.assertEqual(
1419 self.getJobFromHistory('nonvoting-project-test2').result,
1420 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001421
James E. Blair2ef29e92017-07-21 15:25:05 -07001422 self.assertTrue(self.getJobFromHistory('nonvoting-project-merge').
1423 parameters['zuul']['voting'])
1424 self.assertTrue(self.getJobFromHistory('nonvoting-project-test1').
1425 parameters['zuul']['voting'])
1426 self.assertFalse(self.getJobFromHistory('nonvoting-project-test2').
1427 parameters['zuul']['voting'])
James E. Blair5821bd92015-09-16 08:48:15 -07001428
James E. Blaire0487072012-08-29 17:38:31 -07001429 def test_check_queue_success(self):
1430 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001431
James E. Blaire0487072012-08-29 17:38:31 -07001432 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1433 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1434
1435 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001436
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001437 self.assertEqual(A.data['status'], 'NEW')
1438 self.assertEqual(A.reported, 1)
1439 self.assertEqual(self.getJobFromHistory('project-merge').result,
1440 'SUCCESS')
1441 self.assertEqual(self.getJobFromHistory('project-test1').result,
1442 'SUCCESS')
1443 self.assertEqual(self.getJobFromHistory('project-test2').result,
1444 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001445
1446 def test_check_queue_failure(self):
1447 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001448
James E. Blaire0487072012-08-29 17:38:31 -07001449 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001450 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001451 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1452
1453 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001454
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001455 self.assertEqual(A.data['status'], 'NEW')
1456 self.assertEqual(A.reported, 1)
1457 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001458 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001459 self.assertEqual(self.getJobFromHistory('project-test1').result,
1460 'SUCCESS')
1461 self.assertEqual(self.getJobFromHistory('project-test2').result,
1462 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001463
David Shrewsburyffab07a2017-07-24 12:45:07 -04001464 @simple_layout('layouts/autohold.yaml')
1465 def test_autohold(self):
1466 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1467
1468 client = zuul.rpcclient.RPCClient('127.0.0.1',
1469 self.gearman_server.port)
1470 self.addCleanup(client.shutdown)
David Shrewsbury36b2adf2017-07-31 15:40:13 -04001471 r = client.autohold('tenant-one', 'org/project', 'project-test2',
1472 "reason text", 1)
David Shrewsburyffab07a2017-07-24 12:45:07 -04001473 self.assertTrue(r)
1474
1475 self.executor_server.failJob('project-test2', A)
1476 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1477
1478 self.waitUntilSettled()
1479
1480 self.assertEqual(A.data['status'], 'NEW')
1481 self.assertEqual(A.reported, 1)
1482 self.assertEqual(self.getJobFromHistory('project-test2').result,
1483 'FAILURE')
1484
1485 # Check nodepool for a held node
1486 held_node = None
1487 for node in self.fake_nodepool.getNodes():
1488 if node['state'] == zuul.model.STATE_HOLD:
1489 held_node = node
1490 break
1491 self.assertIsNotNone(held_node)
1492
1493 # Validate node has recorded the failed job
1494 self.assertEqual(
1495 held_node['hold_job'],
1496 " ".join(['tenant-one',
1497 'review.example.com/org/project',
1498 'project-test2'])
1499 )
David Shrewsburyf9af9df2017-08-01 15:19:26 -04001500 self.assertEqual(held_node['comment'], "reason text")
David Shrewsburyffab07a2017-07-24 12:45:07 -04001501
1502 # Another failed change should not hold any more nodes
1503 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1504 self.executor_server.failJob('project-test2', B)
1505 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1506 self.waitUntilSettled()
1507 self.assertEqual(B.data['status'], 'NEW')
1508 self.assertEqual(B.reported, 1)
1509 self.assertEqual(self.getJobFromHistory('project-test2').result,
1510 'FAILURE')
1511
1512 held_nodes = 0
1513 for node in self.fake_nodepool.getNodes():
1514 if node['state'] == zuul.model.STATE_HOLD:
1515 held_nodes += 1
1516 self.assertEqual(held_nodes, 1)
1517
David Shrewsburyc4676132017-10-16 12:41:57 -04001518 @simple_layout('layouts/autohold.yaml')
1519 def test_autohold_list(self):
1520 client = zuul.rpcclient.RPCClient('127.0.0.1',
1521 self.gearman_server.port)
1522 self.addCleanup(client.shutdown)
1523
1524 r = client.autohold('tenant-one', 'org/project', 'project-test2',
1525 "reason text", 1)
1526 self.assertTrue(r)
1527
1528 autohold_requests = client.autohold_list()
1529 self.assertNotEqual({}, autohold_requests)
1530 self.assertEqual(1, len(autohold_requests.keys()))
1531
1532 # The single dict key should be a CSV string value
1533 key = list(autohold_requests.keys())[0]
1534 tenant, project, job = key.split(',')
1535
1536 self.assertEqual('tenant-one', tenant)
1537 self.assertIn('org/project', project)
1538 self.assertEqual('project-test2', job)
1539
1540 # Note: the value is converted from set to list by json.
1541 self.assertEqual([1, "reason text"], autohold_requests[key])
1542
James E. Blair7cb84542017-04-19 13:35:05 -07001543 @simple_layout('layouts/three-projects.yaml')
James E. Blair127bc182012-08-28 15:55:15 -07001544 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001545 # This particular test does a large amount of merges and needs a little
1546 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001547 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001548 "test that dependent changes behind dequeued changes work"
1549 # This complicated test is a reproduction of a real life bug
1550 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001551
Paul Belanger174a8272017-03-14 13:20:10 -04001552 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001553 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1554 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1555 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1556 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1557 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1558 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1559 D.setDependsOn(C, 1)
1560 E.setDependsOn(D, 1)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001561 A.addApproval('Code-Review', 2)
1562 B.addApproval('Code-Review', 2)
1563 C.addApproval('Code-Review', 2)
1564 D.addApproval('Code-Review', 2)
1565 E.addApproval('Code-Review', 2)
1566 F.addApproval('Code-Review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001567
1568 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001569
1570 # Change object re-use in the gerrit trigger is hidden if
1571 # changes are added in quick succession; waiting makes it more
1572 # like real life.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001573 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001574 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001575 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001576 self.waitUntilSettled()
1577
Paul Belanger174a8272017-03-14 13:20:10 -04001578 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001579 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001580 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001581 self.waitUntilSettled()
1582
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001583 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001584 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001585 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001586 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001587 self.fake_gerrit.addEvent(E.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001588 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001589 self.fake_gerrit.addEvent(F.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001590 self.waitUntilSettled()
1591
Paul Belanger174a8272017-03-14 13:20:10 -04001592 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001593 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001594 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001595 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001596 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001597 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001598 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001599 self.waitUntilSettled()
1600
1601 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001602
1603 # Grab pointers to the jobs we want to release before
1604 # releasing any, because list indexes may change as
1605 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001606 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001607 a.release()
1608 b.release()
1609 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001610 self.waitUntilSettled()
1611
Paul Belanger174a8272017-03-14 13:20:10 -04001612 self.executor_server.hold_jobs_in_build = False
1613 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001614 self.waitUntilSettled()
1615
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001616 self.assertEqual(A.data['status'], 'NEW')
1617 self.assertEqual(B.data['status'], 'MERGED')
1618 self.assertEqual(C.data['status'], 'MERGED')
1619 self.assertEqual(D.data['status'], 'MERGED')
1620 self.assertEqual(E.data['status'], 'MERGED')
1621 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001622
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001623 self.assertEqual(A.reported, 2)
1624 self.assertEqual(B.reported, 2)
1625 self.assertEqual(C.reported, 2)
1626 self.assertEqual(D.reported, 2)
1627 self.assertEqual(E.reported, 2)
1628 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001629
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001630 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1631 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001632
1633 def test_merger_repack(self):
1634 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001635
James E. Blair05fed602012-09-07 12:45:24 -07001636 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001637 A.addApproval('Code-Review', 2)
1638 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001639 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001640 self.assertEqual(self.getJobFromHistory('project-merge').result,
1641 'SUCCESS')
1642 self.assertEqual(self.getJobFromHistory('project-test1').result,
1643 'SUCCESS')
1644 self.assertEqual(self.getJobFromHistory('project-test2').result,
1645 'SUCCESS')
1646 self.assertEqual(A.data['status'], 'MERGED')
1647 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001648 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001649 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001650
James E. Blair2a535672017-04-27 12:03:15 -07001651 path = os.path.join(self.merger_src_root, "review.example.com",
1652 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001653 if os.path.exists(path):
1654 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001655 path = os.path.join(self.executor_src_root, "review.example.com",
1656 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001657 if os.path.exists(path):
1658 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001659
1660 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001661 A.addApproval('Code-Review', 2)
1662 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001663 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001664 self.assertEqual(self.getJobFromHistory('project-merge').result,
1665 'SUCCESS')
1666 self.assertEqual(self.getJobFromHistory('project-test1').result,
1667 'SUCCESS')
1668 self.assertEqual(self.getJobFromHistory('project-test2').result,
1669 'SUCCESS')
1670 self.assertEqual(A.data['status'], 'MERGED')
1671 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001672
James E. Blair4886f282012-11-15 09:27:33 -08001673 def test_merger_repack_large_change(self):
1674 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001675 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001676 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001677 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6df67132017-04-19 13:53:20 -07001678 trusted, project = tenant.getProject('org/project')
James E. Blair0ffa0102017-03-30 13:11:33 -07001679 url = self.fake_gerrit.getGitUrl(project)
James E. Blair8d144dc2017-05-05 10:13:45 -07001680 self.executor_server.merger._addProject('review.example.com',
James E. Blair197e8202017-06-09 12:54:28 -07001681 'org/project', url, None)
James E. Blair6df67132017-04-19 13:53:20 -07001682 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair4886f282012-11-15 09:27:33 -08001683 A.addPatchset(large=True)
James E. Blair2a535672017-04-27 12:03:15 -07001684 # TODOv3(jeblair): add hostname to upstream root
1685 path = os.path.join(self.upstream_root, 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001686 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001687 path = os.path.join(self.merger_src_root, 'review.example.com',
1688 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001689 if os.path.exists(path):
1690 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001691 path = os.path.join(self.executor_src_root, 'review.example.com',
1692 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001693 if os.path.exists(path):
1694 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001695
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001696 A.addApproval('Code-Review', 2)
1697 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001698 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001699 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001700 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001701 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001702 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001703 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001704 'SUCCESS')
1705 self.assertEqual(A.data['status'], 'MERGED')
1706 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001707
James E. Blair2fa50962013-01-30 21:50:41 -08001708 def test_new_patchset_dequeues_old(self):
1709 "Test that a new patchset causes the old to be dequeued"
1710 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001711 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001712 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1713 M.setMerged()
1714
1715 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1716 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1717 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1718 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001719 A.addApproval('Code-Review', 2)
1720 B.addApproval('Code-Review', 2)
1721 C.addApproval('Code-Review', 2)
1722 D.addApproval('Code-Review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001723
1724 C.setDependsOn(B, 1)
1725 B.setDependsOn(A, 1)
1726 A.setDependsOn(M, 1)
1727
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001728 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1729 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1730 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1731 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001732 self.waitUntilSettled()
1733
1734 B.addPatchset()
1735 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1736 self.waitUntilSettled()
1737
Paul Belanger174a8272017-03-14 13:20:10 -04001738 self.executor_server.hold_jobs_in_build = False
1739 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001740 self.waitUntilSettled()
1741
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001742 self.assertEqual(A.data['status'], 'MERGED')
1743 self.assertEqual(A.reported, 2)
1744 self.assertEqual(B.data['status'], 'NEW')
1745 self.assertEqual(B.reported, 2)
1746 self.assertEqual(C.data['status'], 'NEW')
1747 self.assertEqual(C.reported, 2)
1748 self.assertEqual(D.data['status'], 'MERGED')
1749 self.assertEqual(D.reported, 2)
1750 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001751
James E. Blairba437362015-02-07 11:41:52 -08001752 def test_new_patchset_check(self):
1753 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001754
Paul Belanger174a8272017-03-14 13:20:10 -04001755 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001756
1757 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001758 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001759 tenant = self.sched.abide.tenants.get('tenant-one')
1760 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001761
1762 # Add two git-dependent changes
1763 B.setDependsOn(A, 1)
1764 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1765 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001766 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1767 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001768
1769 # A live item, and a non-live/live pair
1770 items = check_pipeline.getAllItems()
1771 self.assertEqual(len(items), 3)
1772
1773 self.assertEqual(items[0].change.number, '1')
1774 self.assertEqual(items[0].change.patchset, '1')
1775 self.assertFalse(items[0].live)
1776
1777 self.assertEqual(items[1].change.number, '2')
1778 self.assertEqual(items[1].change.patchset, '1')
1779 self.assertTrue(items[1].live)
1780
1781 self.assertEqual(items[2].change.number, '1')
1782 self.assertEqual(items[2].change.patchset, '1')
1783 self.assertTrue(items[2].live)
1784
1785 # Add a new patchset to A
1786 A.addPatchset()
1787 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1788 self.waitUntilSettled()
1789
1790 # The live copy of A,1 should be gone, but the non-live and B
1791 # should continue, and we should have a new A,2
1792 items = check_pipeline.getAllItems()
1793 self.assertEqual(len(items), 3)
1794
1795 self.assertEqual(items[0].change.number, '1')
1796 self.assertEqual(items[0].change.patchset, '1')
1797 self.assertFalse(items[0].live)
1798
1799 self.assertEqual(items[1].change.number, '2')
1800 self.assertEqual(items[1].change.patchset, '1')
1801 self.assertTrue(items[1].live)
1802
1803 self.assertEqual(items[2].change.number, '1')
1804 self.assertEqual(items[2].change.patchset, '2')
1805 self.assertTrue(items[2].live)
1806
1807 # Add a new patchset to B
1808 B.addPatchset()
1809 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1810 self.waitUntilSettled()
1811
1812 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1813 # but we should have a new B,2 (still based on A,1)
1814 items = check_pipeline.getAllItems()
1815 self.assertEqual(len(items), 3)
1816
1817 self.assertEqual(items[0].change.number, '1')
1818 self.assertEqual(items[0].change.patchset, '2')
1819 self.assertTrue(items[0].live)
1820
1821 self.assertEqual(items[1].change.number, '1')
1822 self.assertEqual(items[1].change.patchset, '1')
1823 self.assertFalse(items[1].live)
1824
1825 self.assertEqual(items[2].change.number, '2')
1826 self.assertEqual(items[2].change.patchset, '2')
1827 self.assertTrue(items[2].live)
1828
1829 self.builds[0].release()
1830 self.waitUntilSettled()
1831 self.builds[0].release()
1832 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001833 self.executor_server.hold_jobs_in_build = False
1834 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001835 self.waitUntilSettled()
1836
1837 self.assertEqual(A.reported, 1)
1838 self.assertEqual(B.reported, 1)
1839 self.assertEqual(self.history[0].result, 'ABORTED')
1840 self.assertEqual(self.history[0].changes, '1,1')
1841 self.assertEqual(self.history[1].result, 'ABORTED')
1842 self.assertEqual(self.history[1].changes, '1,1 2,1')
1843 self.assertEqual(self.history[2].result, 'SUCCESS')
1844 self.assertEqual(self.history[2].changes, '1,2')
1845 self.assertEqual(self.history[3].result, 'SUCCESS')
1846 self.assertEqual(self.history[3].changes, '1,1 2,2')
1847
1848 def test_abandoned_gate(self):
1849 "Test that an abandoned change is dequeued from gate"
1850
Paul Belanger174a8272017-03-14 13:20:10 -04001851 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001852
1853 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001854 A.addApproval('Code-Review', 2)
1855 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001856 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001857 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1858 self.assertEqual(self.builds[0].name, 'project-merge')
1859
1860 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1861 self.waitUntilSettled()
1862
Paul Belanger174a8272017-03-14 13:20:10 -04001863 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001864 self.waitUntilSettled()
1865
Arie5b4048c2016-10-05 16:12:06 +03001866 self.assertBuilds([])
1867 self.assertHistory([
1868 dict(name='project-merge', result='ABORTED', changes='1,1')],
1869 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001870 self.assertEqual(A.reported, 1,
1871 "Abandoned gate change should report only start")
1872
1873 def test_abandoned_check(self):
1874 "Test that an abandoned change is dequeued from check"
1875
Paul Belanger174a8272017-03-14 13:20:10 -04001876 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001877
1878 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1879 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001880 tenant = self.sched.abide.tenants.get('tenant-one')
1881 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001882
1883 # Add two git-dependent changes
1884 B.setDependsOn(A, 1)
1885 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1886 self.waitUntilSettled()
1887 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1888 self.waitUntilSettled()
1889 # A live item, and a non-live/live pair
1890 items = check_pipeline.getAllItems()
1891 self.assertEqual(len(items), 3)
1892
1893 self.assertEqual(items[0].change.number, '1')
1894 self.assertFalse(items[0].live)
1895
1896 self.assertEqual(items[1].change.number, '2')
1897 self.assertTrue(items[1].live)
1898
1899 self.assertEqual(items[2].change.number, '1')
1900 self.assertTrue(items[2].live)
1901
1902 # Abandon A
1903 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1904 self.waitUntilSettled()
1905
1906 # The live copy of A should be gone, but the non-live and B
1907 # should continue
1908 items = check_pipeline.getAllItems()
1909 self.assertEqual(len(items), 2)
1910
1911 self.assertEqual(items[0].change.number, '1')
1912 self.assertFalse(items[0].live)
1913
1914 self.assertEqual(items[1].change.number, '2')
1915 self.assertTrue(items[1].live)
1916
Paul Belanger174a8272017-03-14 13:20:10 -04001917 self.executor_server.hold_jobs_in_build = False
1918 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001919 self.waitUntilSettled()
1920
1921 self.assertEqual(len(self.history), 4)
1922 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001923 'Build should have been aborted')
1924 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001925 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001926
Steve Varnau7b78b312015-04-03 14:49:46 -07001927 def test_abandoned_not_timer(self):
1928 "Test that an abandoned change does not cancel timer jobs"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001929 # This test can not use simple_layout because it must start
1930 # with a configuration which does not include a
1931 # timer-triggered job so that we have an opportunity to set
1932 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04001933 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001934 # Start timer trigger - also org/project
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001935 self.commitConfigUpdate('common-config', 'layouts/idle.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001936 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001937 # The pipeline triggers every second, so we should have seen
1938 # several by now.
1939 time.sleep(5)
1940 self.waitUntilSettled()
1941 # Stop queuing timer triggered jobs so that the assertions
1942 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001943 # Must be in same repo, so overwrite config with another one
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001944 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001945 self.sched.reconfigure(self.config)
James E. Blair0b137b42017-07-27 08:51:25 -07001946 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07001947 # If APScheduler is in mid-event when we remove the job, we
1948 # can end up with one more event firing, so give it an extra
1949 # second to settle.
1950 time.sleep(1)
1951 self.waitUntilSettled()
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001952
James E. Blair21037782017-07-19 11:56:55 -07001953 self.assertEqual(len(self.builds), 1, "One timer job")
Steve Varnau7b78b312015-04-03 14:49:46 -07001954
1955 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1956 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1957 self.waitUntilSettled()
James E. Blair21037782017-07-19 11:56:55 -07001958 self.assertEqual(len(self.builds), 2, "One change plus one timer job")
Steve Varnau7b78b312015-04-03 14:49:46 -07001959
1960 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1961 self.waitUntilSettled()
1962
James E. Blair21037782017-07-19 11:56:55 -07001963 self.assertEqual(len(self.builds), 1, "One timer job remains")
Steve Varnau7b78b312015-04-03 14:49:46 -07001964
Paul Belanger174a8272017-03-14 13:20:10 -04001965 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001966 self.waitUntilSettled()
1967
James E. Blair2fa50962013-01-30 21:50:41 -08001968 def test_new_patchset_dequeues_old_on_head(self):
1969 "Test that a new patchset causes the old to be dequeued (at head)"
1970 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001971 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001972 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1973 M.setMerged()
1974 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1975 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1976 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1977 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001978 A.addApproval('Code-Review', 2)
1979 B.addApproval('Code-Review', 2)
1980 C.addApproval('Code-Review', 2)
1981 D.addApproval('Code-Review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001982
1983 C.setDependsOn(B, 1)
1984 B.setDependsOn(A, 1)
1985 A.setDependsOn(M, 1)
1986
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001987 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1988 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1989 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1990 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001991 self.waitUntilSettled()
1992
1993 A.addPatchset()
1994 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1995 self.waitUntilSettled()
1996
Paul Belanger174a8272017-03-14 13:20:10 -04001997 self.executor_server.hold_jobs_in_build = False
1998 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001999 self.waitUntilSettled()
2000
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002001 self.assertEqual(A.data['status'], 'NEW')
2002 self.assertEqual(A.reported, 2)
2003 self.assertEqual(B.data['status'], 'NEW')
2004 self.assertEqual(B.reported, 2)
2005 self.assertEqual(C.data['status'], 'NEW')
2006 self.assertEqual(C.reported, 2)
2007 self.assertEqual(D.data['status'], 'MERGED')
2008 self.assertEqual(D.reported, 2)
2009 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08002010
2011 def test_new_patchset_dequeues_old_without_dependents(self):
2012 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04002013 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08002014 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2015 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2016 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002017 A.addApproval('Code-Review', 2)
2018 B.addApproval('Code-Review', 2)
2019 C.addApproval('Code-Review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08002020
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002021 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
2022 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
2023 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08002024 self.waitUntilSettled()
2025
2026 B.addPatchset()
2027 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
2028 self.waitUntilSettled()
2029
Paul Belanger174a8272017-03-14 13:20:10 -04002030 self.executor_server.hold_jobs_in_build = False
2031 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08002032 self.waitUntilSettled()
2033
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002034 self.assertEqual(A.data['status'], 'MERGED')
2035 self.assertEqual(A.reported, 2)
2036 self.assertEqual(B.data['status'], 'NEW')
2037 self.assertEqual(B.reported, 2)
2038 self.assertEqual(C.data['status'], 'MERGED')
2039 self.assertEqual(C.reported, 2)
2040 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08002041
2042 def test_new_patchset_dequeues_old_independent_queue(self):
2043 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04002044 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08002045 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2046 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2047 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
2048 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2049 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2050 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2051 self.waitUntilSettled()
2052
2053 B.addPatchset()
2054 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
2055 self.waitUntilSettled()
2056
Paul Belanger174a8272017-03-14 13:20:10 -04002057 self.executor_server.hold_jobs_in_build = False
2058 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08002059 self.waitUntilSettled()
2060
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002061 self.assertEqual(A.data['status'], 'NEW')
2062 self.assertEqual(A.reported, 1)
2063 self.assertEqual(B.data['status'], 'NEW')
2064 self.assertEqual(B.reported, 1)
2065 self.assertEqual(C.data['status'], 'NEW')
2066 self.assertEqual(C.reported, 1)
2067 self.assertEqual(len(self.history), 10)
2068 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08002069
James E. Blaircc020532017-04-19 13:04:44 -07002070 @simple_layout('layouts/noop-job.yaml')
James E. Blair18c64442014-03-18 10:14:45 -07002071 def test_noop_job(self):
2072 "Test that the internal noop job works"
2073 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002074 A.addApproval('Code-Review', 2)
2075 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07002076 self.waitUntilSettled()
2077
2078 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2079 self.assertTrue(self.sched._areAllBuildsComplete())
2080 self.assertEqual(len(self.history), 0)
2081 self.assertEqual(A.data['status'], 'MERGED')
2082 self.assertEqual(A.reported, 2)
2083
James E. Blair06cc3922017-04-19 10:08:10 -07002084 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00002085 def test_no_job_project(self):
2086 "Test that reports with no jobs don't get sent"
2087 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
2088 'master', 'A')
2089 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2090 self.waitUntilSettled()
2091
2092 # Change wasn't reported to
2093 self.assertEqual(A.reported, False)
2094
2095 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08002096 tenant = self.sched.abide.tenants.get('tenant-one')
2097 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00002098 items = check_pipeline.getAllItems()
2099 self.assertEqual(len(items), 0)
2100
2101 self.assertEqual(len(self.history), 0)
2102
James E. Blair7d0dedc2013-02-21 17:26:09 -08002103 def test_zuul_refs(self):
2104 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04002105 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08002106 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
2107 M1.setMerged()
2108 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
2109 M2.setMerged()
2110
2111 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2112 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2113 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
2114 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002115 A.addApproval('Code-Review', 2)
2116 B.addApproval('Code-Review', 2)
2117 C.addApproval('Code-Review', 2)
2118 D.addApproval('Code-Review', 2)
2119 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2120 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
2121 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
2122 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002123
2124 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002125 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002126 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002127 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002128 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002129 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002130 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002131 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002132 self.waitUntilSettled()
2133
Clint Byrum3343e3e2016-11-15 16:05:03 -08002134 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002135 for x in self.builds:
James E. Blaire3db2952017-07-21 15:03:36 -07002136 if x.parameters['zuul']['change'] == '3':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002137 a_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002138 elif x.parameters['zuul']['change'] == '4':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002139 b_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002140 elif x.parameters['zuul']['change'] == '5':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002141 c_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002142 elif x.parameters['zuul']['change'] == '6':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002143 d_build = x
2144 if a_build and b_build and c_build and d_build:
2145 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08002146
Clint Byrum3343e3e2016-11-15 16:05:03 -08002147 # should have a, not b, and should not be in project2
2148 self.assertTrue(a_build.hasChanges(A))
2149 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002150
Clint Byrum3343e3e2016-11-15 16:05:03 -08002151 # should have a and b, and should not be in project2
2152 self.assertTrue(b_build.hasChanges(A, B))
2153 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002154
Clint Byrum3343e3e2016-11-15 16:05:03 -08002155 # should have a and b in 1, c in 2
2156 self.assertTrue(c_build.hasChanges(A, B, C))
2157 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002158
Clint Byrum3343e3e2016-11-15 16:05:03 -08002159 # should have a and b in 1, c and d in 2
2160 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002161
Paul Belanger174a8272017-03-14 13:20:10 -04002162 self.executor_server.hold_jobs_in_build = False
2163 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002164 self.waitUntilSettled()
2165
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002166 self.assertEqual(A.data['status'], 'MERGED')
2167 self.assertEqual(A.reported, 2)
2168 self.assertEqual(B.data['status'], 'MERGED')
2169 self.assertEqual(B.reported, 2)
2170 self.assertEqual(C.data['status'], 'MERGED')
2171 self.assertEqual(C.reported, 2)
2172 self.assertEqual(D.data['status'], 'MERGED')
2173 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002174
James E. Blair4a28a882013-08-23 15:17:33 -07002175 def test_rerun_on_error(self):
2176 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002177 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002178 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002179 A.addApproval('Code-Review', 2)
2180 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002181 self.waitUntilSettled()
2182
James E. Blair412fba82017-01-26 15:00:50 -08002183 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002184 self.executor_server.hold_jobs_in_build = False
2185 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002186 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002187 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002188 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2189
James E. Blair412e5582013-04-22 15:50:12 -07002190 def test_statsd(self):
2191 "Test each of the statsd methods used in the scheduler"
James E. Blairded241e2017-10-10 13:22:40 -07002192 statsd = self.sched.statsd
James E. Blair412e5582013-04-22 15:50:12 -07002193 statsd.incr('test-incr')
2194 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002195 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002196 self.assertReportedStat('test-incr', '1|c')
2197 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002198 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002199
James E. Blairdad52252014-02-07 16:59:17 -08002200 def test_stuck_job_cleanup(self):
2201 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002202
2203 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002204 self.gearman_server.hold_jobs_in_queue = True
2205 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002206 A.addApproval('Code-Review', 2)
2207 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002208 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002209 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002210 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2211
James E. Blair31cb3e82017-04-20 13:08:56 -07002212 self.commitConfigUpdate('common-config', 'layouts/no-jobs.yaml')
James E. Blairdad52252014-02-07 16:59:17 -08002213 self.sched.reconfigure(self.config)
2214 self.waitUntilSettled()
2215
James E. Blair18c64442014-03-18 10:14:45 -07002216 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002217 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002218 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002219 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2220 self.assertTrue(self.sched._areAllBuildsComplete())
2221
2222 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002223 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002224 self.assertEqual(self.history[0].result, 'SUCCESS')
2225
James E. Blair879dafb2015-07-17 14:04:49 -07002226 def test_file_head(self):
2227 # This is a regression test for an observed bug. A change
2228 # with a file named "HEAD" in the root directory of the repo
2229 # was processed by a merger. It then was unable to reset the
2230 # repo because of:
2231 # GitCommandError: 'git reset --hard HEAD' returned
2232 # with exit code 128
2233 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2234 # and filename
2235 # Use '--' to separate filenames from revisions'
2236
2237 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002238 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002239 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2240
2241 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2242 self.waitUntilSettled()
2243
2244 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2245 self.waitUntilSettled()
2246
2247 self.assertIn('Build succeeded', A.messages[0])
2248 self.assertIn('Build succeeded', B.messages[0])
2249
James E. Blair70c71582013-03-06 08:50:50 -08002250 def test_file_jobs(self):
2251 "Test that file jobs run only when appropriate"
2252 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002253 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002254 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002255 A.addApproval('Code-Review', 2)
2256 B.addApproval('Code-Review', 2)
2257 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2258 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002259 self.waitUntilSettled()
2260
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002261 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002262 if x.name == 'project-testfile']
2263
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002264 self.assertEqual(len(testfile_jobs), 1)
2265 self.assertEqual(testfile_jobs[0].changes, '1,2')
2266 self.assertEqual(A.data['status'], 'MERGED')
2267 self.assertEqual(A.reported, 2)
2268 self.assertEqual(B.data['status'], 'MERGED')
2269 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002270
Clint Byrum3ee39f32016-11-17 23:45:07 -08002271 def _test_irrelevant_files_jobs(self, should_skip):
2272 "Test that jobs with irrelevant-files filter run only when appropriate"
Clint Byrum3ee39f32016-11-17 23:45:07 -08002273 if should_skip:
2274 files = {'ignoreme': 'ignored\n'}
2275 else:
2276 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002277
2278 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002279 'master',
2280 'test irrelevant-files',
2281 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002282 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2283 self.waitUntilSettled()
2284
2285 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002286 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002287
2288 if should_skip:
2289 self.assertEqual([], tested_change_ids)
2290 else:
2291 self.assertIn(change.data['number'], tested_change_ids)
2292
James E. Blaircc324192017-04-19 14:36:08 -07002293 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002294 def test_irrelevant_files_match_skips_job(self):
2295 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002296
James E. Blaircc324192017-04-19 14:36:08 -07002297 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002298 def test_irrelevant_files_no_match_runs_job(self):
2299 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002300
James E. Blaircc324192017-04-19 14:36:08 -07002301 @simple_layout('layouts/inheritance.yaml')
Clint Byrum85493602016-11-18 11:59:47 -08002302 def test_inherited_jobs_keep_matchers(self):
Clint Byrum85493602016-11-18 11:59:47 -08002303 files = {'ignoreme': 'ignored\n'}
2304
2305 change = self.fake_gerrit.addFakeChange('org/project',
2306 'master',
2307 'test irrelevant-files',
2308 files=files)
2309 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2310 self.waitUntilSettled()
2311
2312 run_jobs = set([build.name for build in self.history])
2313
2314 self.assertEqual(set(['project-test-nomatch-starts-empty',
2315 'project-test-nomatch-starts-full']), run_jobs)
2316
James E. Blairaf8b2082017-10-03 15:38:27 -07002317 @simple_layout('layouts/job-vars.yaml')
2318 def test_inherited_job_variables(self):
2319 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2320 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2321 self.waitUntilSettled()
2322 self.assertHistory([
2323 dict(name='parentjob', result='SUCCESS'),
2324 dict(name='child1', result='SUCCESS'),
2325 dict(name='child2', result='SUCCESS'),
2326 dict(name='child3', result='SUCCESS'),
2327 ], ordered=False)
2328 j = self.getJobFromHistory('parentjob')
2329 rp = set([p['name'] for p in j.parameters['projects']])
2330 self.assertEqual(j.parameters['vars']['override'], 0)
2331 self.assertEqual(j.parameters['vars']['child1override'], 0)
2332 self.assertEqual(j.parameters['vars']['parent'], 0)
2333 self.assertFalse('child1' in j.parameters['vars'])
2334 self.assertFalse('child2' in j.parameters['vars'])
2335 self.assertFalse('child3' in j.parameters['vars'])
2336 self.assertEqual(rp, set(['org/project', 'org/project0',
2337 'org/project0']))
2338 j = self.getJobFromHistory('child1')
2339 rp = set([p['name'] for p in j.parameters['projects']])
2340 self.assertEqual(j.parameters['vars']['override'], 1)
2341 self.assertEqual(j.parameters['vars']['child1override'], 1)
2342 self.assertEqual(j.parameters['vars']['parent'], 0)
2343 self.assertEqual(j.parameters['vars']['child1'], 1)
2344 self.assertFalse('child2' in j.parameters['vars'])
2345 self.assertFalse('child3' in j.parameters['vars'])
2346 self.assertEqual(rp, set(['org/project', 'org/project0',
2347 'org/project1']))
2348 j = self.getJobFromHistory('child2')
2349 rp = set([p['name'] for p in j.parameters['projects']])
2350 self.assertEqual(j.parameters['vars']['override'], 2)
2351 self.assertEqual(j.parameters['vars']['child1override'], 0)
2352 self.assertEqual(j.parameters['vars']['parent'], 0)
2353 self.assertFalse('child1' in j.parameters['vars'])
2354 self.assertEqual(j.parameters['vars']['child2'], 2)
2355 self.assertFalse('child3' in j.parameters['vars'])
2356 self.assertEqual(rp, set(['org/project', 'org/project0',
2357 'org/project2']))
2358 j = self.getJobFromHistory('child3')
2359 rp = set([p['name'] for p in j.parameters['projects']])
2360 self.assertEqual(j.parameters['vars']['override'], 3)
2361 self.assertEqual(j.parameters['vars']['child1override'], 0)
2362 self.assertEqual(j.parameters['vars']['parent'], 0)
2363 self.assertFalse('child1' in j.parameters['vars'])
2364 self.assertFalse('child2' in j.parameters['vars'])
2365 self.assertEqual(j.parameters['vars']['child3'], 3)
2366 self.assertEqual(rp, set(['org/project', 'org/project0',
2367 'org/project3']))
2368
James E. Blairc8a1e052014-02-25 09:29:26 -08002369 def test_queue_names(self):
2370 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002371 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002372 (trusted, project1) = tenant.getProject('org/project1')
2373 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002374 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2375 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2376 self.assertEqual(q1.name, 'integrated')
2377 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002378
James E. Blair64ed6f22013-07-10 14:07:23 -07002379 def test_queue_precedence(self):
2380 "Test that queue precedence works"
2381
2382 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002383 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002384 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2385 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002386 A.addApproval('Code-Review', 2)
2387 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002388
2389 self.waitUntilSettled()
2390 self.gearman_server.hold_jobs_in_queue = False
2391 self.gearman_server.release()
2392 self.waitUntilSettled()
2393
James E. Blair8de58bd2013-07-18 16:23:33 -07002394 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002395 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002396 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002397 self.waitUntilSettled()
2398
James E. Blair64ed6f22013-07-10 14:07:23 -07002399 self.log.debug(self.history)
2400 self.assertEqual(self.history[0].pipeline, 'gate')
2401 self.assertEqual(self.history[1].pipeline, 'check')
2402 self.assertEqual(self.history[2].pipeline, 'gate')
2403 self.assertEqual(self.history[3].pipeline, 'gate')
2404 self.assertEqual(self.history[4].pipeline, 'check')
2405 self.assertEqual(self.history[5].pipeline, 'check')
2406
Clark Boylana5edbe42014-06-03 16:39:10 -07002407 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002408 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002409 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002410 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002411 A.addApproval('Code-Review', 2)
2412 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002413 self.waitUntilSettled()
2414
Paul Belanger174a8272017-03-14 13:20:10 -04002415 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002416 self.waitUntilSettled()
2417
James E. Blair1843a552013-07-03 14:19:52 -07002418 port = self.webapp.server.socket.getsockname()[1]
2419
Adam Gandelman77a12c72017-02-03 17:43:43 -08002420 req = urllib.request.Request(
2421 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002422 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002423 headers = f.info()
2424 self.assertIn('Content-Length', headers)
2425 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002426 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2427 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002428 self.assertIn('Access-Control-Allow-Origin', headers)
2429 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002430 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002431 self.assertIn('Expires', headers)
Clint Byrumf322fe22017-05-10 20:53:12 -07002432 data = f.read().decode('utf8')
James E. Blair1843a552013-07-03 14:19:52 -07002433
Paul Belanger174a8272017-03-14 13:20:10 -04002434 self.executor_server.hold_jobs_in_build = False
2435 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002436 self.waitUntilSettled()
2437
2438 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002439 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002440 for p in data['pipelines']:
2441 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002442 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002443 self.assertEqual(q['window'], 20)
2444 else:
2445 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002446 for head in q['heads']:
2447 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002448 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002449 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002450 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002451 status_jobs.append(job)
2452 self.assertEqual('project-merge', status_jobs[0]['name'])
Monty Taylorde8242c2017-02-23 20:29:53 -06002453 # TODO(mordred) pull uuids from self.builds
Monty Taylor51139a02016-05-24 11:28:10 -05002454 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002455 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2456 uuid=status_jobs[0]['uuid']),
2457 status_jobs[0]['url'])
2458 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002459 'finger://{hostname}/{uuid}'.format(
2460 hostname=self.executor_server.hostname,
2461 uuid=status_jobs[0]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002462 status_jobs[0]['finger_url'])
Monty Taylorde8242c2017-02-23 20:29:53 -06002463 # TOOD(mordred) configure a success-url on the base job
Monty Taylor51139a02016-05-24 11:28:10 -05002464 self.assertEqual(
2465 'finger://{hostname}/{uuid}'.format(
2466 hostname=self.executor_server.hostname,
2467 uuid=status_jobs[0]['uuid']),
2468 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002469 self.assertEqual('project-test1', status_jobs[1]['name'])
Monty Taylor51139a02016-05-24 11:28:10 -05002470 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002471 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2472 uuid=status_jobs[1]['uuid']),
2473 status_jobs[1]['url'])
2474 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002475 'finger://{hostname}/{uuid}'.format(
2476 hostname=self.executor_server.hostname,
2477 uuid=status_jobs[1]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002478 status_jobs[1]['finger_url'])
Monty Taylor51139a02016-05-24 11:28:10 -05002479 self.assertEqual(
2480 'finger://{hostname}/{uuid}'.format(
2481 hostname=self.executor_server.hostname,
2482 uuid=status_jobs[1]['uuid']),
2483 status_jobs[1]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002484
2485 self.assertEqual('project-test2', status_jobs[2]['name'])
Monty Taylor51139a02016-05-24 11:28:10 -05002486 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002487 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2488 uuid=status_jobs[2]['uuid']),
2489 status_jobs[2]['url'])
2490 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002491 'finger://{hostname}/{uuid}'.format(
2492 hostname=self.executor_server.hostname,
2493 uuid=status_jobs[2]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002494 status_jobs[2]['finger_url'])
Monty Taylor51139a02016-05-24 11:28:10 -05002495 self.assertEqual(
2496 'finger://{hostname}/{uuid}'.format(
2497 hostname=self.executor_server.hostname,
2498 uuid=status_jobs[2]['uuid']),
2499 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002500
Tobias Henkel65639f82017-07-10 10:25:42 +02002501 # check job dependencies
2502 self.assertIsNotNone(status_jobs[0]['dependencies'])
2503 self.assertIsNotNone(status_jobs[1]['dependencies'])
2504 self.assertIsNotNone(status_jobs[2]['dependencies'])
2505 self.assertEqual(len(status_jobs[0]['dependencies']), 0)
2506 self.assertEqual(len(status_jobs[1]['dependencies']), 1)
2507 self.assertEqual(len(status_jobs[2]['dependencies']), 1)
2508 self.assertIn('project-merge', status_jobs[1]['dependencies'])
2509 self.assertIn('project-merge', status_jobs[2]['dependencies'])
2510
James E. Blair419a8672017-10-18 14:48:25 -07002511 def test_reconfigure_merge(self):
2512 """Test that two reconfigure events are merged"""
2513
2514 tenant = self.sched.abide.tenants['tenant-one']
2515 (trusted, project) = tenant.getProject('org/project')
2516
2517 self.sched.run_handler_lock.acquire()
2518 self.assertEqual(self.sched.management_event_queue.qsize(), 0)
2519
2520 self.sched.reconfigureTenant(tenant, project)
2521 self.assertEqual(self.sched.management_event_queue.qsize(), 1)
2522
2523 self.sched.reconfigureTenant(tenant, project)
2524 # The second event should have been combined with the first
2525 # so we should still only have one entry.
2526 self.assertEqual(self.sched.management_event_queue.qsize(), 1)
2527
2528 self.sched.run_handler_lock.release()
2529 self.waitUntilSettled()
2530
2531 self.assertEqual(self.sched.management_event_queue.qsize(), 0)
2532
James E. Blaircdccd972013-07-01 12:10:22 -07002533 def test_live_reconfiguration(self):
2534 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002535 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002536 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002537 A.addApproval('Code-Review', 2)
2538 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002539 self.waitUntilSettled()
2540
2541 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002542 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002543
Paul Belanger174a8272017-03-14 13:20:10 -04002544 self.executor_server.hold_jobs_in_build = False
2545 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002546 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002547 self.assertEqual(self.getJobFromHistory('project-merge').result,
2548 'SUCCESS')
2549 self.assertEqual(self.getJobFromHistory('project-test1').result,
2550 'SUCCESS')
2551 self.assertEqual(self.getJobFromHistory('project-test2').result,
2552 'SUCCESS')
2553 self.assertEqual(A.data['status'], 'MERGED')
2554 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002555
James E. Blair027ba992017-09-20 13:48:32 -07002556 def test_live_reconfiguration_abort(self):
2557 # Raise an exception during reconfiguration and verify we
2558 # still function.
2559 self.executor_server.hold_jobs_in_build = True
2560 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2561 A.addApproval('Code-Review', 2)
2562 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2563 self.waitUntilSettled()
2564
2565 tenant = self.sched.abide.tenants.get('tenant-one')
2566 pipeline = tenant.layout.pipelines['gate']
2567 change = pipeline.getAllItems()[0].change
2568 # Set this to an invalid value to cause an exception during
2569 # reconfiguration.
2570 change.branch = None
2571
2572 self.sched.reconfigure(self.config)
2573 self.waitUntilSettled()
2574
2575 self.executor_server.hold_jobs_in_build = False
2576 self.executor_server.release()
2577
2578 self.waitUntilSettled()
2579 self.assertEqual(self.getJobFromHistory('project-merge').result,
2580 'ABORTED')
2581 self.assertEqual(A.data['status'], 'NEW')
2582 # The final report fails because of the invalid value set above.
2583 self.assertEqual(A.reported, 1)
2584
James E. Blair6bc782d2015-07-17 16:20:21 -07002585 def test_live_reconfiguration_merge_conflict(self):
2586 # A real-world bug: a change in a gate queue has a merge
2587 # conflict and a job is added to its project while it's
2588 # sitting in the queue. The job gets added to the change and
2589 # enqueued and the change gets stuck.
Paul Belanger174a8272017-03-14 13:20:10 -04002590 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002591
2592 # This change is fine. It's here to stop the queue long
2593 # enough for the next change to be subject to the
2594 # reconfiguration, as well as to provide a conflict for the
2595 # next change. This change will succeed and merge.
2596 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum073c00b2017-05-01 13:41:23 -07002597 A.addPatchset({'conflict': 'A'})
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002598 A.addApproval('Code-Review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002599
2600 # This change will be in merge conflict. During the
2601 # reconfiguration, we will add a job. We want to make sure
2602 # that doesn't cause it to get stuck.
2603 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Clint Byrum073c00b2017-05-01 13:41:23 -07002604 B.addPatchset({'conflict': 'B'})
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002605 B.addApproval('Code-Review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002606
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002607 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2608 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002609
2610 self.waitUntilSettled()
2611
2612 # No jobs have run yet
2613 self.assertEqual(A.data['status'], 'NEW')
2614 self.assertEqual(A.reported, 1)
2615 self.assertEqual(B.data['status'], 'NEW')
James E. Blair6bc782d2015-07-17 16:20:21 -07002616 self.assertEqual(len(self.history), 0)
2617
2618 # Add the "project-test3" job.
Clint Byrum073c00b2017-05-01 13:41:23 -07002619 self.commitConfigUpdate('common-config',
2620 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002621 self.sched.reconfigure(self.config)
2622 self.waitUntilSettled()
2623
Paul Belanger174a8272017-03-14 13:20:10 -04002624 self.executor_server.hold_jobs_in_build = False
2625 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002626 self.waitUntilSettled()
2627
2628 self.assertEqual(A.data['status'], 'MERGED')
2629 self.assertEqual(A.reported, 2)
2630 self.assertEqual(B.data['status'], 'NEW')
Tobias Henkel9842bd72017-05-16 13:40:03 +02002631 self.assertIn('Merge Failed', B.messages[-1])
James E. Blair6bc782d2015-07-17 16:20:21 -07002632 self.assertEqual(self.getJobFromHistory('project-merge').result,
2633 'SUCCESS')
2634 self.assertEqual(self.getJobFromHistory('project-test1').result,
2635 'SUCCESS')
2636 self.assertEqual(self.getJobFromHistory('project-test2').result,
2637 'SUCCESS')
2638 self.assertEqual(self.getJobFromHistory('project-test3').result,
2639 'SUCCESS')
2640 self.assertEqual(len(self.history), 4)
2641
James E. Blair400e8fd2015-07-30 17:44:45 -07002642 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002643 # An extrapolation of test_live_reconfiguration_merge_conflict
2644 # that tests a job added to a job tree with a failed root does
2645 # not run.
Paul Belanger174a8272017-03-14 13:20:10 -04002646 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002647
2648 # This change is fine. It's here to stop the queue long
2649 # enough for the next change to be subject to the
2650 # reconfiguration. This change will succeed and merge.
2651 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum3147d652017-05-01 14:01:42 -07002652 A.addPatchset({'conflict': 'A'})
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002653 A.addApproval('Code-Review', 2)
2654 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002655 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002656 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002657 self.waitUntilSettled()
2658
2659 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002660 self.executor_server.failJob('project-merge', B)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002661 B.addApproval('Code-Review', 2)
2662 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002663 self.waitUntilSettled()
2664
Paul Belanger174a8272017-03-14 13:20:10 -04002665 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002666 self.waitUntilSettled()
2667
2668 # Both -merge jobs have run, but no others.
2669 self.assertEqual(A.data['status'], 'NEW')
2670 self.assertEqual(A.reported, 1)
2671 self.assertEqual(B.data['status'], 'NEW')
2672 self.assertEqual(B.reported, 1)
2673 self.assertEqual(self.history[0].result, 'SUCCESS')
2674 self.assertEqual(self.history[0].name, 'project-merge')
2675 self.assertEqual(self.history[1].result, 'FAILURE')
2676 self.assertEqual(self.history[1].name, 'project-merge')
2677 self.assertEqual(len(self.history), 2)
2678
2679 # Add the "project-test3" job.
Clint Byrum3147d652017-05-01 14:01:42 -07002680 self.commitConfigUpdate('common-config',
2681 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002682 self.sched.reconfigure(self.config)
2683 self.waitUntilSettled()
2684
Paul Belanger174a8272017-03-14 13:20:10 -04002685 self.executor_server.hold_jobs_in_build = False
2686 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002687 self.waitUntilSettled()
2688
2689 self.assertEqual(A.data['status'], 'MERGED')
2690 self.assertEqual(A.reported, 2)
2691 self.assertEqual(B.data['status'], 'NEW')
2692 self.assertEqual(B.reported, 2)
2693 self.assertEqual(self.history[0].result, 'SUCCESS')
2694 self.assertEqual(self.history[0].name, 'project-merge')
2695 self.assertEqual(self.history[1].result, 'FAILURE')
2696 self.assertEqual(self.history[1].name, 'project-merge')
2697 self.assertEqual(self.history[2].result, 'SUCCESS')
2698 self.assertEqual(self.history[3].result, 'SUCCESS')
2699 self.assertEqual(self.history[4].result, 'SUCCESS')
2700 self.assertEqual(len(self.history), 5)
2701
James E. Blair400e8fd2015-07-30 17:44:45 -07002702 def test_live_reconfiguration_failed_job(self):
2703 # Test that a change with a removed failing job does not
2704 # disrupt reconfiguration. If a change has a failed job and
2705 # that job is removed during a reconfiguration, we observed a
2706 # bug where the code to re-set build statuses would run on
2707 # that build and raise an exception because the job no longer
2708 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002709 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002710
2711 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2712
2713 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002714 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002715
2716 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2717 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002718 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002719 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002720 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002721 self.waitUntilSettled()
2722
2723 self.assertEqual(A.data['status'], 'NEW')
2724 self.assertEqual(A.reported, 0)
2725
2726 self.assertEqual(self.getJobFromHistory('project-merge').result,
2727 'SUCCESS')
2728 self.assertEqual(self.getJobFromHistory('project-test1').result,
2729 'FAILURE')
2730 self.assertEqual(len(self.history), 2)
2731
2732 # Remove the test1 job.
Clint Byrum841a58c2017-05-01 14:17:21 -07002733 self.commitConfigUpdate('common-config',
2734 'layouts/live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002735 self.sched.reconfigure(self.config)
2736 self.waitUntilSettled()
2737
Paul Belanger174a8272017-03-14 13:20:10 -04002738 self.executor_server.hold_jobs_in_build = False
2739 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002740 self.waitUntilSettled()
2741
2742 self.assertEqual(self.getJobFromHistory('project-test2').result,
2743 'SUCCESS')
2744 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2745 'SUCCESS')
2746 self.assertEqual(len(self.history), 4)
2747
2748 self.assertEqual(A.data['status'], 'NEW')
2749 self.assertEqual(A.reported, 1)
2750 self.assertIn('Build succeeded', A.messages[0])
2751 # Ensure the removed job was not included in the report.
2752 self.assertNotIn('project-test1', A.messages[0])
2753
James E. Blairfe707d12015-08-05 15:18:15 -07002754 def test_live_reconfiguration_shared_queue(self):
2755 # Test that a change with a failing job which was removed from
2756 # this project but otherwise still exists in the system does
2757 # not disrupt reconfiguration.
2758
Paul Belanger174a8272017-03-14 13:20:10 -04002759 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002760
2761 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2762
Paul Belanger174a8272017-03-14 13:20:10 -04002763 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002764
2765 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2766 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002767 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002768 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002769 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002770 self.waitUntilSettled()
2771
2772 self.assertEqual(A.data['status'], 'NEW')
2773 self.assertEqual(A.reported, 0)
2774
Clint Byrum69663d42017-05-01 14:51:04 -07002775 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002776 'SUCCESS')
2777 self.assertEqual(self.getJobFromHistory(
2778 'project1-project2-integration').result, 'FAILURE')
2779 self.assertEqual(len(self.history), 2)
2780
2781 # Remove the integration job.
Clint Byrum69663d42017-05-01 14:51:04 -07002782 self.commitConfigUpdate(
2783 'common-config',
2784 'layouts/live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002785 self.sched.reconfigure(self.config)
2786 self.waitUntilSettled()
2787
Paul Belanger174a8272017-03-14 13:20:10 -04002788 self.executor_server.hold_jobs_in_build = False
2789 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002790 self.waitUntilSettled()
2791
Clint Byrum69663d42017-05-01 14:51:04 -07002792 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002793 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002794 self.assertEqual(self.getJobFromHistory('project-test1').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002795 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002796 self.assertEqual(self.getJobFromHistory('project-test2').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002797 'SUCCESS')
2798 self.assertEqual(self.getJobFromHistory(
2799 'project1-project2-integration').result, 'FAILURE')
2800 self.assertEqual(len(self.history), 4)
2801
2802 self.assertEqual(A.data['status'], 'NEW')
2803 self.assertEqual(A.reported, 1)
2804 self.assertIn('Build succeeded', A.messages[0])
2805 # Ensure the removed job was not included in the report.
2806 self.assertNotIn('project1-project2-integration', A.messages[0])
2807
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002808 def test_double_live_reconfiguration_shared_queue(self):
2809 # This was a real-world regression. A change is added to
2810 # gate; a reconfigure happens, a second change which depends
2811 # on the first is added, and a second reconfiguration happens.
2812 # Ensure that both changes merge.
2813
2814 # A failure may indicate incorrect caching or cleaning up of
2815 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002816 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002817
2818 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2819 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2820 B.setDependsOn(A, 1)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002821 A.addApproval('Code-Review', 2)
2822 B.addApproval('Code-Review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002823
2824 # Add the parent change.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002825 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002826 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002827 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002828 self.waitUntilSettled()
2829
2830 # Reconfigure (with only one change in the pipeline).
2831 self.sched.reconfigure(self.config)
2832 self.waitUntilSettled()
2833
2834 # Add the child change.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002835 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002836 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002837 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002838 self.waitUntilSettled()
2839
2840 # Reconfigure (with both in the pipeline).
2841 self.sched.reconfigure(self.config)
2842 self.waitUntilSettled()
2843
Paul Belanger174a8272017-03-14 13:20:10 -04002844 self.executor_server.hold_jobs_in_build = False
2845 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002846 self.waitUntilSettled()
2847
2848 self.assertEqual(len(self.history), 8)
2849
2850 self.assertEqual(A.data['status'], 'MERGED')
2851 self.assertEqual(A.reported, 2)
2852 self.assertEqual(B.data['status'], 'MERGED')
2853 self.assertEqual(B.reported, 2)
2854
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002855 def test_live_reconfiguration_del_project(self):
2856 # Test project deletion from layout
2857 # while changes are enqueued
2858
Paul Belanger174a8272017-03-14 13:20:10 -04002859 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002860 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2861 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2862 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2863
2864 # A Depends-On: B
2865 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2866 A.subject, B.data['id'])
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002867 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002868
2869 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2870 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2871 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002872 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002873 self.waitUntilSettled()
2874 self.assertEqual(len(self.builds), 5)
2875
2876 # This layout defines only org/project, not org/project1
James E. Blair31cb3e82017-04-20 13:08:56 -07002877 self.commitConfigUpdate(
2878 'common-config',
2879 'layouts/live-reconfiguration-del-project.yaml')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002880 self.sched.reconfigure(self.config)
2881 self.waitUntilSettled()
2882
2883 # Builds for C aborted, builds for A succeed,
2884 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002885 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002886 self.assertEqual(job_c.changes, '3,1')
2887 self.assertEqual(job_c.result, 'ABORTED')
2888
Paul Belanger174a8272017-03-14 13:20:10 -04002889 self.executor_server.hold_jobs_in_build = False
2890 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002891 self.waitUntilSettled()
2892
Clint Byrum0149ada2017-04-04 12:22:01 -07002893 self.assertEqual(
2894 self.getJobFromHistory('project-test1', 'org/project').changes,
2895 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002896
2897 self.assertEqual(A.data['status'], 'NEW')
2898 self.assertEqual(B.data['status'], 'NEW')
2899 self.assertEqual(C.data['status'], 'NEW')
2900 self.assertEqual(A.reported, 1)
2901 self.assertEqual(B.reported, 0)
2902 self.assertEqual(C.reported, 0)
2903
Clint Byrum0149ada2017-04-04 12:22:01 -07002904 tenant = self.sched.abide.tenants.get('tenant-one')
2905 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002906 self.assertIn('Build succeeded', A.messages[0])
2907
James E. Blair287c06d2013-07-24 10:39:30 -07002908 def test_delayed_repo_init(self):
James E. Blair287c06d2013-07-24 10:39:30 -07002909 self.init_repo("org/new-project")
Clint Byrum627ba362017-08-14 13:20:40 -07002910 files = {'README': ''}
2911 self.addCommitToRepo("org/new-project", 'Initial commit',
2912 files=files, tag='init')
2913 self.newTenantConfig('tenants/delayed-repo-init.yaml')
2914 self.commitConfigUpdate(
2915 'common-config',
2916 'layouts/delayed-repo-init.yaml')
2917 self.sched.reconfigure(self.config)
2918 self.waitUntilSettled()
2919
James E. Blair287c06d2013-07-24 10:39:30 -07002920 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2921
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002922 A.addApproval('Code-Review', 2)
2923 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002924 self.waitUntilSettled()
2925 self.assertEqual(self.getJobFromHistory('project-merge').result,
2926 'SUCCESS')
2927 self.assertEqual(self.getJobFromHistory('project-test1').result,
2928 'SUCCESS')
2929 self.assertEqual(self.getJobFromHistory('project-test2').result,
2930 'SUCCESS')
2931 self.assertEqual(A.data['status'], 'MERGED')
2932 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002933
James E. Blair9ea70072017-04-19 16:05:30 -07002934 @simple_layout('layouts/repo-deleted.yaml')
Clark Boylan6dbbc482013-10-18 10:57:31 -07002935 def test_repo_deleted(self):
Clark Boylan6dbbc482013-10-18 10:57:31 -07002936 self.init_repo("org/delete-project")
2937 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2938
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002939 A.addApproval('Code-Review', 2)
2940 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002941 self.waitUntilSettled()
2942 self.assertEqual(self.getJobFromHistory('project-merge').result,
2943 'SUCCESS')
2944 self.assertEqual(self.getJobFromHistory('project-test1').result,
2945 'SUCCESS')
2946 self.assertEqual(self.getJobFromHistory('project-test2').result,
2947 'SUCCESS')
2948 self.assertEqual(A.data['status'], 'MERGED')
2949 self.assertEqual(A.reported, 2)
2950
2951 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002952 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002953 if os.path.exists(os.path.join(self.merger_src_root, p)):
2954 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002955 if os.path.exists(os.path.join(self.executor_src_root, p)):
2956 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002957
2958 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2959
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002960 B.addApproval('Code-Review', 2)
2961 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002962 self.waitUntilSettled()
2963 self.assertEqual(self.getJobFromHistory('project-merge').result,
2964 'SUCCESS')
2965 self.assertEqual(self.getJobFromHistory('project-test1').result,
2966 'SUCCESS')
2967 self.assertEqual(self.getJobFromHistory('project-test2').result,
2968 'SUCCESS')
2969 self.assertEqual(B.data['status'], 'MERGED')
2970 self.assertEqual(B.reported, 2)
2971
James E. Blair892cca62017-08-09 11:36:58 -07002972 @simple_layout('layouts/untrusted-secrets.yaml')
2973 def test_untrusted_secrets(self):
2974 "Test untrusted secrets"
2975 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2976 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2977 self.waitUntilSettled()
2978
2979 self.assertHistory([])
2980 self.assertEqual(A.patchsets[0]['approvals'][0]['value'], "-1")
James E. Blair8eb564a2017-08-10 09:21:41 -07002981 self.assertIn('does not allow post-review job',
James E. Blair892cca62017-08-09 11:36:58 -07002982 A.messages[0])
2983
James E. Blaire68d43f2017-04-19 14:03:30 -07002984 @simple_layout('layouts/tags.yaml')
James E. Blair456f2fb2016-02-09 09:29:33 -08002985 def test_tags(self):
2986 "Test job tags"
James E. Blair456f2fb2016-02-09 09:29:33 -08002987 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2988 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2989 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2990 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2991 self.waitUntilSettled()
2992
James E. Blaire68d43f2017-04-19 14:03:30 -07002993 self.assertEqual(len(self.history), 2)
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002994
2995 results = {self.getJobFromHistory('merge',
James E. Blair9d46f092017-07-20 16:06:20 -07002996 project='org/project1').uuid: ['extratag', 'merge'],
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002997 self.getJobFromHistory('merge',
James E. Blair9d46f092017-07-20 16:06:20 -07002998 project='org/project2').uuid: ['merge']}
James E. Blair456f2fb2016-02-09 09:29:33 -08002999
3000 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06003001 self.assertEqual(results.get(build.uuid, ''),
James E. Blair9d46f092017-07-20 16:06:20 -07003002 build.parameters['zuul'].get('jobtags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08003003
James E. Blair63bb0ef2013-07-29 17:14:51 -07003004 def test_timer(self):
3005 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003006 # This test can not use simple_layout because it must start
3007 # with a configuration which does not include a
3008 # timer-triggered job so that we have an opportunity to set
3009 # the hold flag before the first job.
James E. Blair21037782017-07-19 11:56:55 -07003010 self.create_branch('org/project', 'stable')
Paul Belanger174a8272017-03-14 13:20:10 -04003011 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003012 self.commitConfigUpdate('common-config', 'layouts/timer.yaml')
James E. Blair63bb0ef2013-07-29 17:14:51 -07003013 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07003014
Clark Boylan3ee090a2014-04-03 20:55:09 -07003015 # The pipeline triggers every second, so we should have seen
3016 # several by now.
3017 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07003018 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07003019
3020 self.assertEqual(len(self.builds), 2)
3021
James E. Blair63bb0ef2013-07-29 17:14:51 -07003022 port = self.webapp.server.socket.getsockname()[1]
3023
Clint Byrum5e729e92017-02-08 06:34:57 -08003024 req = urllib.request.Request(
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003025 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07003026 f = urllib.request.urlopen(req)
Clint Byrumf322fe22017-05-10 20:53:12 -07003027 data = f.read().decode('utf8')
James E. Blair63bb0ef2013-07-29 17:14:51 -07003028
Paul Belanger174a8272017-03-14 13:20:10 -04003029 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07003030 # Stop queuing timer triggered jobs so that the assertions
3031 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003032 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003033 self.sched.reconfigure(self.config)
James E. Blair78ae4782017-08-02 14:19:10 -07003034 self.waitUntilSettled()
3035 # If APScheduler is in mid-event when we remove the job, we
3036 # can end up with one more event firing, so give it an extra
3037 # second to settle.
3038 time.sleep(1)
3039 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003040 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07003041 self.waitUntilSettled()
3042
James E. Blair21037782017-07-19 11:56:55 -07003043 self.assertHistory([
3044 dict(name='project-bitrot', result='SUCCESS',
3045 ref='refs/heads/master'),
3046 dict(name='project-bitrot', result='SUCCESS',
3047 ref='refs/heads/stable'),
3048 ], ordered=False)
James E. Blair63bb0ef2013-07-29 17:14:51 -07003049
3050 data = json.loads(data)
3051 status_jobs = set()
3052 for p in data['pipelines']:
3053 for q in p['change_queues']:
3054 for head in q['heads']:
3055 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07003056 for job in change['jobs']:
3057 status_jobs.add(job['name'])
James E. Blair21037782017-07-19 11:56:55 -07003058 self.assertIn('project-bitrot', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003059
James E. Blair4f6033c2014-03-27 15:49:09 -07003060 def test_idle(self):
3061 "Test that frequent periodic jobs work"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003062 # This test can not use simple_layout because it must start
3063 # with a configuration which does not include a
3064 # timer-triggered job so that we have an opportunity to set
3065 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04003066 self.executor_server.hold_jobs_in_build = True
James E. Blair4f6033c2014-03-27 15:49:09 -07003067
Clark Boylan3ee090a2014-04-03 20:55:09 -07003068 for x in range(1, 3):
3069 # Test that timer triggers periodic jobs even across
3070 # layout config reloads.
3071 # Start timer trigger
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003072 self.commitConfigUpdate('common-config',
3073 'layouts/idle.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003074 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08003075 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07003076
Clark Boylan3ee090a2014-04-03 20:55:09 -07003077 # The pipeline triggers every second, so we should have seen
3078 # several by now.
3079 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07003080
3081 # Stop queuing timer triggered jobs so that the assertions
3082 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003083 self.commitConfigUpdate('common-config',
3084 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003085 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08003086 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07003087 # If APScheduler is in mid-event when we remove the job,
3088 # we can end up with one more event firing, so give it an
3089 # extra second to settle.
3090 time.sleep(1)
3091 self.waitUntilSettled()
James E. Blair21037782017-07-19 11:56:55 -07003092 self.assertEqual(len(self.builds), 1,
Clint Byrum58264dc2017-02-07 21:21:22 -08003093 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04003094 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003095 self.waitUntilSettled()
3096 self.assertEqual(len(self.builds), 0)
James E. Blair21037782017-07-19 11:56:55 -07003097 self.assertEqual(len(self.history), x)
James E. Blair4f6033c2014-03-27 15:49:09 -07003098
James E. Blaircc324192017-04-19 14:36:08 -07003099 @simple_layout('layouts/smtp.yaml')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003100 def test_check_smtp_pool(self):
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003101 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3102 self.waitUntilSettled()
3103
3104 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3105 self.waitUntilSettled()
3106
James E. Blairff80a2f2013-12-27 13:24:06 -08003107 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003108
3109 # A.messages only holds what FakeGerrit places in it. Thus we
3110 # work on the knowledge of what the first message should be as
3111 # it is only configured to go to SMTP.
3112
3113 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003114 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003115 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003116 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003117 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08003118 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003119
3120 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003121 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003122 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003123 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003124 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08003125 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08003126
James E. Blaire5910202013-12-27 09:50:31 -08003127 def test_timer_smtp(self):
3128 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003129 # This test can not use simple_layout because it must start
3130 # with a configuration which does not include a
3131 # timer-triggered job so that we have an opportunity to set
3132 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04003133 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003134 self.commitConfigUpdate('common-config', 'layouts/timer-smtp.yaml')
James E. Blaire5910202013-12-27 09:50:31 -08003135 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08003136
Clark Boylan3ee090a2014-04-03 20:55:09 -07003137 # The pipeline triggers every second, so we should have seen
3138 # several by now.
3139 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08003140 self.waitUntilSettled()
3141
Clark Boylan3ee090a2014-04-03 20:55:09 -07003142 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003143 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003144 self.waitUntilSettled()
3145 self.assertEqual(len(self.history), 2)
3146
James E. Blaire5910202013-12-27 09:50:31 -08003147 self.assertEqual(self.getJobFromHistory(
3148 'project-bitrot-stable-old').result, 'SUCCESS')
3149 self.assertEqual(self.getJobFromHistory(
3150 'project-bitrot-stable-older').result, 'SUCCESS')
3151
James E. Blairff80a2f2013-12-27 13:24:06 -08003152 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08003153
3154 # A.messages only holds what FakeGerrit places in it. Thus we
3155 # work on the knowledge of what the first message should be as
3156 # it is only configured to go to SMTP.
3157
3158 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003159 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08003160 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003161 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08003162 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08003163 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08003164
Clark Boylan3ee090a2014-04-03 20:55:09 -07003165 # Stop queuing timer triggered jobs and let any that may have
3166 # queued through so that end of test assertions pass.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003167 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003168 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07003169 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07003170 # If APScheduler is in mid-event when we remove the job, we
3171 # can end up with one more event firing, so give it an extra
3172 # second to settle.
3173 time.sleep(1)
3174 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003175 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003176 self.waitUntilSettled()
3177
Joshua Hesketh25695cb2017-03-06 12:50:04 +11003178 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00003179 def test_timer_sshkey(self):
3180 "Test that a periodic job can setup SSH key authentication"
3181 self.worker.hold_jobs_in_build = True
3182 self.config.set('zuul', 'layout_config',
3183 'tests/fixtures/layout-timer.yaml')
3184 self.sched.reconfigure(self.config)
3185 self.registerJobs()
3186
3187 # The pipeline triggers every second, so we should have seen
3188 # several by now.
3189 time.sleep(5)
3190 self.waitUntilSettled()
3191
3192 self.assertEqual(len(self.builds), 2)
3193
3194 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
3195 self.assertTrue(os.path.isfile(ssh_wrapper))
3196 with open(ssh_wrapper) as f:
3197 ssh_wrapper_content = f.read()
3198 self.assertIn("fake_id_rsa", ssh_wrapper_content)
3199 # In the unit tests Merger runs in the same process,
3200 # so we see its' environment variables
3201 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
3202
3203 self.worker.release('.*')
3204 self.waitUntilSettled()
3205 self.assertEqual(len(self.history), 2)
3206
3207 self.assertEqual(self.getJobFromHistory(
3208 'project-bitrot-stable-old').result, 'SUCCESS')
3209 self.assertEqual(self.getJobFromHistory(
3210 'project-bitrot-stable-older').result, 'SUCCESS')
3211
3212 # Stop queuing timer triggered jobs and let any that may have
3213 # queued through so that end of test assertions pass.
3214 self.config.set('zuul', 'layout_config',
3215 'tests/fixtures/layout-no-timer.yaml')
3216 self.sched.reconfigure(self.config)
3217 self.registerJobs()
3218 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07003219 # If APScheduler is in mid-event when we remove the job, we
3220 # can end up with one more event firing, so give it an extra
3221 # second to settle.
3222 time.sleep(1)
3223 self.waitUntilSettled()
Evgeny Antyshevda90a502017-02-08 08:42:59 +00003224 self.worker.release('.*')
3225 self.waitUntilSettled()
3226
James E. Blair91e34592015-07-31 16:45:59 -07003227 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08003228 "Test that the RPC client can enqueue a change"
3229 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003230 A.addApproval('Code-Review', 2)
3231 A.addApproval('Approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08003232
3233 client = zuul.rpcclient.RPCClient('127.0.0.1',
3234 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003235 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003236 r = client.enqueue(tenant='tenant-one',
3237 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003238 project='org/project',
3239 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003240 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003241 self.waitUntilSettled()
3242 self.assertEqual(self.getJobFromHistory('project-merge').result,
3243 'SUCCESS')
3244 self.assertEqual(self.getJobFromHistory('project-test1').result,
3245 'SUCCESS')
3246 self.assertEqual(self.getJobFromHistory('project-test2').result,
3247 'SUCCESS')
3248 self.assertEqual(A.data['status'], 'MERGED')
3249 self.assertEqual(A.reported, 2)
3250 self.assertEqual(r, True)
3251
James E. Blair91e34592015-07-31 16:45:59 -07003252 def test_client_enqueue_ref(self):
3253 "Test that the RPC client can enqueue a ref"
James E. Blair289f5932017-07-27 15:02:29 -07003254 p = "review.example.com/org/project"
3255 upstream = self.getUpstreamRepos([p])
3256 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3257 A.setMerged()
3258 A_commit = str(upstream[p].commit('master'))
3259 self.log.debug("A commit: %s" % A_commit)
James E. Blair91e34592015-07-31 16:45:59 -07003260
3261 client = zuul.rpcclient.RPCClient('127.0.0.1',
3262 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003263 self.addCleanup(client.shutdown)
James E. Blair91e34592015-07-31 16:45:59 -07003264 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04003265 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07003266 pipeline='post',
3267 project='org/project',
3268 trigger='gerrit',
3269 ref='master',
3270 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
James E. Blair289f5932017-07-27 15:02:29 -07003271 newrev=A_commit)
James E. Blair91e34592015-07-31 16:45:59 -07003272 self.waitUntilSettled()
3273 job_names = [x.name for x in self.history]
3274 self.assertEqual(len(self.history), 1)
3275 self.assertIn('project-post', job_names)
3276 self.assertEqual(r, True)
3277
James E. Blairad28e912013-11-27 10:43:22 -08003278 def test_client_enqueue_negative(self):
3279 "Test that the RPC client returns errors"
3280 client = zuul.rpcclient.RPCClient('127.0.0.1',
3281 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003282 self.addCleanup(client.shutdown)
James E. Blairad28e912013-11-27 10:43:22 -08003283 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04003284 "Invalid tenant"):
3285 r = client.enqueue(tenant='tenant-foo',
3286 pipeline='gate',
3287 project='org/project',
3288 trigger='gerrit',
3289 change='1,1')
Paul Belangerbaca3132016-11-04 12:49:54 -04003290 self.assertEqual(r, False)
3291
3292 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08003293 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003294 r = client.enqueue(tenant='tenant-one',
3295 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003296 project='project-does-not-exist',
3297 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003298 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003299 self.assertEqual(r, False)
3300
3301 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3302 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003303 r = client.enqueue(tenant='tenant-one',
3304 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08003305 project='org/project',
3306 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003307 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003308 self.assertEqual(r, False)
3309
3310 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3311 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003312 r = client.enqueue(tenant='tenant-one',
3313 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003314 project='org/project',
3315 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08003316 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003317 self.assertEqual(r, False)
3318
3319 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3320 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003321 r = client.enqueue(tenant='tenant-one',
3322 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003323 project='org/project',
3324 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003325 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003326 self.assertEqual(r, False)
3327
3328 self.waitUntilSettled()
3329 self.assertEqual(len(self.history), 0)
3330 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08003331
3332 def test_client_promote(self):
3333 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04003334 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003335 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3336 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3337 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003338 A.addApproval('Code-Review', 2)
3339 B.addApproval('Code-Review', 2)
3340 C.addApproval('Code-Review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003341
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003342 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3343 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3344 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003345
3346 self.waitUntilSettled()
3347
Paul Belangerbaca3132016-11-04 12:49:54 -04003348 tenant = self.sched.abide.tenants.get('tenant-one')
3349 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003350 enqueue_times = {}
3351 for item in items:
3352 enqueue_times[str(item.change)] = item.enqueue_time
3353
James E. Blair36658cf2013-12-06 17:53:48 -08003354 client = zuul.rpcclient.RPCClient('127.0.0.1',
3355 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003356 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003357 r = client.promote(tenant='tenant-one',
3358 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003359 change_ids=['2,1', '3,1'])
3360
Sean Daguef39b9ca2014-01-10 21:34:35 -05003361 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003362 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003363 for item in items:
3364 self.assertEqual(
3365 enqueue_times[str(item.change)], item.enqueue_time)
3366
James E. Blair78acec92014-02-06 07:11:32 -08003367 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003368 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003369 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003370 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003371 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003372 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003373 self.waitUntilSettled()
3374
3375 self.assertEqual(len(self.builds), 6)
3376 self.assertEqual(self.builds[0].name, 'project-test1')
3377 self.assertEqual(self.builds[1].name, 'project-test2')
3378 self.assertEqual(self.builds[2].name, 'project-test1')
3379 self.assertEqual(self.builds[3].name, 'project-test2')
3380 self.assertEqual(self.builds[4].name, 'project-test1')
3381 self.assertEqual(self.builds[5].name, 'project-test2')
3382
Paul Belangerbaca3132016-11-04 12:49:54 -04003383 self.assertTrue(self.builds[0].hasChanges(B))
3384 self.assertFalse(self.builds[0].hasChanges(A))
3385 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003386
Paul Belangerbaca3132016-11-04 12:49:54 -04003387 self.assertTrue(self.builds[2].hasChanges(B))
3388 self.assertTrue(self.builds[2].hasChanges(C))
3389 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003390
Paul Belangerbaca3132016-11-04 12:49:54 -04003391 self.assertTrue(self.builds[4].hasChanges(B))
3392 self.assertTrue(self.builds[4].hasChanges(C))
3393 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003394
Paul Belanger174a8272017-03-14 13:20:10 -04003395 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003396 self.waitUntilSettled()
3397
3398 self.assertEqual(A.data['status'], 'MERGED')
3399 self.assertEqual(A.reported, 2)
3400 self.assertEqual(B.data['status'], 'MERGED')
3401 self.assertEqual(B.reported, 2)
3402 self.assertEqual(C.data['status'], 'MERGED')
3403 self.assertEqual(C.reported, 2)
3404
James E. Blair36658cf2013-12-06 17:53:48 -08003405 self.assertEqual(r, True)
3406
3407 def test_client_promote_dependent(self):
3408 "Test that the RPC client can promote a dependent change"
3409 # C (depends on B) -> B -> A ; then promote C to get:
3410 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003411 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003412 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3413 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3414 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3415
3416 C.setDependsOn(B, 1)
3417
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003418 A.addApproval('Code-Review', 2)
3419 B.addApproval('Code-Review', 2)
3420 C.addApproval('Code-Review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003421
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003422 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3423 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3424 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003425
3426 self.waitUntilSettled()
3427
3428 client = zuul.rpcclient.RPCClient('127.0.0.1',
3429 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003430 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003431 r = client.promote(tenant='tenant-one',
3432 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003433 change_ids=['3,1'])
3434
James E. Blair78acec92014-02-06 07:11:32 -08003435 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003436 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003437 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003438 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003439 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003440 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003441 self.waitUntilSettled()
3442
3443 self.assertEqual(len(self.builds), 6)
3444 self.assertEqual(self.builds[0].name, 'project-test1')
3445 self.assertEqual(self.builds[1].name, 'project-test2')
3446 self.assertEqual(self.builds[2].name, 'project-test1')
3447 self.assertEqual(self.builds[3].name, 'project-test2')
3448 self.assertEqual(self.builds[4].name, 'project-test1')
3449 self.assertEqual(self.builds[5].name, 'project-test2')
3450
Paul Belangerbaca3132016-11-04 12:49:54 -04003451 self.assertTrue(self.builds[0].hasChanges(B))
3452 self.assertFalse(self.builds[0].hasChanges(A))
3453 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003454
Paul Belangerbaca3132016-11-04 12:49:54 -04003455 self.assertTrue(self.builds[2].hasChanges(B))
3456 self.assertTrue(self.builds[2].hasChanges(C))
3457 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003458
Paul Belangerbaca3132016-11-04 12:49:54 -04003459 self.assertTrue(self.builds[4].hasChanges(B))
3460 self.assertTrue(self.builds[4].hasChanges(C))
3461 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003462
Paul Belanger174a8272017-03-14 13:20:10 -04003463 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003464 self.waitUntilSettled()
3465
3466 self.assertEqual(A.data['status'], 'MERGED')
3467 self.assertEqual(A.reported, 2)
3468 self.assertEqual(B.data['status'], 'MERGED')
3469 self.assertEqual(B.reported, 2)
3470 self.assertEqual(C.data['status'], 'MERGED')
3471 self.assertEqual(C.reported, 2)
3472
James E. Blair36658cf2013-12-06 17:53:48 -08003473 self.assertEqual(r, True)
3474
3475 def test_client_promote_negative(self):
3476 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003477 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003478 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003479 A.addApproval('Code-Review', 2)
3480 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003481 self.waitUntilSettled()
3482
3483 client = zuul.rpcclient.RPCClient('127.0.0.1',
3484 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003485 self.addCleanup(client.shutdown)
James E. Blair36658cf2013-12-06 17:53:48 -08003486
3487 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003488 r = client.promote(tenant='tenant-one',
3489 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003490 change_ids=['2,1', '3,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003491 self.assertEqual(r, False)
3492
3493 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003494 r = client.promote(tenant='tenant-one',
3495 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003496 change_ids=['4,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003497 self.assertEqual(r, False)
3498
Paul Belanger174a8272017-03-14 13:20:10 -04003499 self.executor_server.hold_jobs_in_build = False
3500 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003501 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003502
James E. Blaircc324192017-04-19 14:36:08 -07003503 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003504 def test_queue_rate_limiting(self):
3505 "Test that DependentPipelines are rate limited with dep across window"
Paul Belanger174a8272017-03-14 13:20:10 -04003506 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003507 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3508 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3509 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3510
3511 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003512 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003513
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003514 A.addApproval('Code-Review', 2)
3515 B.addApproval('Code-Review', 2)
3516 C.addApproval('Code-Review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003517
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003518 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3519 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3520 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003521 self.waitUntilSettled()
3522
3523 # Only A and B will have their merge jobs queued because
3524 # window is 2.
3525 self.assertEqual(len(self.builds), 2)
3526 self.assertEqual(self.builds[0].name, 'project-merge')
3527 self.assertEqual(self.builds[1].name, 'project-merge')
3528
James E. Blair732ee862017-04-21 07:49:26 -07003529 # Release the merge jobs one at a time.
3530 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003531 self.waitUntilSettled()
James E. Blair732ee862017-04-21 07:49:26 -07003532 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003533 self.waitUntilSettled()
3534
3535 # Only A and B will have their test jobs queued because
3536 # window is 2.
3537 self.assertEqual(len(self.builds), 4)
3538 self.assertEqual(self.builds[0].name, 'project-test1')
3539 self.assertEqual(self.builds[1].name, 'project-test2')
3540 self.assertEqual(self.builds[2].name, 'project-test1')
3541 self.assertEqual(self.builds[3].name, 'project-test2')
3542
Paul Belanger174a8272017-03-14 13:20:10 -04003543 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003544 self.waitUntilSettled()
3545
James E. Blaircc324192017-04-19 14:36:08 -07003546 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003547 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003548 # A failed so window is reduced by 1 to 1.
3549 self.assertEqual(queue.window, 1)
3550 self.assertEqual(queue.window_floor, 1)
3551 self.assertEqual(A.data['status'], 'NEW')
3552
3553 # Gate is reset and only B's merge job is queued because
3554 # window shrunk to 1.
3555 self.assertEqual(len(self.builds), 1)
3556 self.assertEqual(self.builds[0].name, 'project-merge')
3557
Paul Belanger174a8272017-03-14 13:20:10 -04003558 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003559 self.waitUntilSettled()
3560
3561 # Only B's test jobs are queued because window is still 1.
3562 self.assertEqual(len(self.builds), 2)
3563 self.assertEqual(self.builds[0].name, 'project-test1')
3564 self.assertEqual(self.builds[1].name, 'project-test2')
3565
Paul Belanger174a8272017-03-14 13:20:10 -04003566 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003567 self.waitUntilSettled()
3568
3569 # B was successfully merged so window is increased to 2.
3570 self.assertEqual(queue.window, 2)
3571 self.assertEqual(queue.window_floor, 1)
3572 self.assertEqual(B.data['status'], 'MERGED')
3573
3574 # Only C is left and its merge job is queued.
3575 self.assertEqual(len(self.builds), 1)
3576 self.assertEqual(self.builds[0].name, 'project-merge')
3577
Paul Belanger174a8272017-03-14 13:20:10 -04003578 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003579 self.waitUntilSettled()
3580
3581 # After successful merge job the test jobs for C are queued.
3582 self.assertEqual(len(self.builds), 2)
3583 self.assertEqual(self.builds[0].name, 'project-test1')
3584 self.assertEqual(self.builds[1].name, 'project-test2')
3585
Paul Belanger174a8272017-03-14 13:20:10 -04003586 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003587 self.waitUntilSettled()
3588
3589 # C successfully merged so window is bumped to 3.
3590 self.assertEqual(queue.window, 3)
3591 self.assertEqual(queue.window_floor, 1)
3592 self.assertEqual(C.data['status'], 'MERGED')
3593
James E. Blaircc324192017-04-19 14:36:08 -07003594 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003595 def test_queue_rate_limiting_dependent(self):
3596 "Test that DependentPipelines are rate limited with dep in window"
Paul Belanger174a8272017-03-14 13:20:10 -04003597 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003598 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3599 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3600 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3601
3602 B.setDependsOn(A, 1)
3603
Paul Belanger174a8272017-03-14 13:20:10 -04003604 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003605
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003606 A.addApproval('Code-Review', 2)
3607 B.addApproval('Code-Review', 2)
3608 C.addApproval('Code-Review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003609
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003610 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3611 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3612 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003613 self.waitUntilSettled()
3614
3615 # Only A and B will have their merge jobs queued because
3616 # window is 2.
3617 self.assertEqual(len(self.builds), 2)
3618 self.assertEqual(self.builds[0].name, 'project-merge')
3619 self.assertEqual(self.builds[1].name, 'project-merge')
3620
James E. Blairf4a5f022017-04-18 14:01:10 -07003621 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003622
3623 # Only A and B will have their test jobs queued because
3624 # window is 2.
3625 self.assertEqual(len(self.builds), 4)
3626 self.assertEqual(self.builds[0].name, 'project-test1')
3627 self.assertEqual(self.builds[1].name, 'project-test2')
3628 self.assertEqual(self.builds[2].name, 'project-test1')
3629 self.assertEqual(self.builds[3].name, 'project-test2')
3630
Paul Belanger174a8272017-03-14 13:20:10 -04003631 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003632 self.waitUntilSettled()
3633
James E. Blaircc324192017-04-19 14:36:08 -07003634 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003635 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003636 # A failed so window is reduced by 1 to 1.
3637 self.assertEqual(queue.window, 1)
3638 self.assertEqual(queue.window_floor, 1)
3639 self.assertEqual(A.data['status'], 'NEW')
3640 self.assertEqual(B.data['status'], 'NEW')
3641
3642 # Gate is reset and only C's merge job is queued because
3643 # window shrunk to 1 and A and B were dequeued.
3644 self.assertEqual(len(self.builds), 1)
3645 self.assertEqual(self.builds[0].name, 'project-merge')
3646
James E. Blairf4a5f022017-04-18 14:01:10 -07003647 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003648
3649 # Only C's test jobs are queued because window is still 1.
3650 self.assertEqual(len(self.builds), 2)
James E. Blairdf25ddc2017-07-08 07:57:09 -07003651 builds = self.getSortedBuilds()
3652 self.assertEqual(builds[0].name, 'project-test1')
3653 self.assertEqual(builds[1].name, 'project-test2')
Clark Boylan7603a372014-01-21 11:43:20 -08003654
Paul Belanger174a8272017-03-14 13:20:10 -04003655 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003656 self.waitUntilSettled()
3657
3658 # C was successfully merged so window is increased to 2.
3659 self.assertEqual(queue.window, 2)
3660 self.assertEqual(queue.window_floor, 1)
3661 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003662
3663 def test_worker_update_metadata(self):
3664 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003665 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003666
3667 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003668 A.addApproval('Code-Review', 2)
3669 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003670 self.waitUntilSettled()
3671
Clint Byrumd4de79a2017-05-27 11:39:13 -07003672 self.assertEqual(len(self.executor_client.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003673
3674 self.log.debug('Current builds:')
Clint Byrumd4de79a2017-05-27 11:39:13 -07003675 self.log.debug(self.executor_client.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003676
3677 start = time.time()
3678 while True:
3679 if time.time() - start > 10:
3680 raise Exception("Timeout waiting for gearman server to report "
3681 + "back to the client")
Clint Byrumd4de79a2017-05-27 11:39:13 -07003682 build = list(self.executor_client.builds.values())[0]
Monty Tayloreea6bb92017-06-14 11:56:54 -05003683 if build.worker.name == self.executor_server.hostname:
Joshua Heskethba8776a2014-01-12 14:35:40 +08003684 break
3685 else:
3686 time.sleep(0)
3687
3688 self.log.debug(build)
Monty Tayloreea6bb92017-06-14 11:56:54 -05003689 self.assertEqual(self.executor_server.hostname, build.worker.name)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003690
Paul Belanger174a8272017-03-14 13:20:10 -04003691 self.executor_server.hold_jobs_in_build = False
3692 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003693 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003694
James E. Blaircc324192017-04-19 14:36:08 -07003695 @simple_layout('layouts/footer-message.yaml')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003696 def test_footer_message(self):
3697 "Test a pipeline's footer message is correctly added to the report."
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003698 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003699 A.addApproval('Code-Review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003700 self.executor_server.failJob('project-test1', A)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003701 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003702 self.waitUntilSettled()
3703
3704 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003705 B.addApproval('Code-Review', 2)
3706 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003707 self.waitUntilSettled()
3708
3709 self.assertEqual(2, len(self.smtp_messages))
3710
Adam Gandelman82258fd2017-02-07 16:51:58 -08003711 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003712Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003713http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003714
Adam Gandelman82258fd2017-02-07 16:51:58 -08003715 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003716For CI problems and help debugging, contact ci@example.org"""
3717
Adam Gandelman82258fd2017-02-07 16:51:58 -08003718 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3719 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3720 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3721 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003722
Tobias Henkel9842bd72017-05-16 13:40:03 +02003723 @simple_layout('layouts/unmanaged-project.yaml')
3724 def test_unmanaged_project_start_message(self):
3725 "Test start reporting is not done for unmanaged projects."
3726 self.init_repo("org/project", tag='init')
3727 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3728 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3729 self.waitUntilSettled()
3730
3731 self.assertEqual(0, len(A.messages))
3732
Clint Byrumb9de8be2017-05-27 13:49:19 -07003733 @simple_layout('layouts/merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003734 def test_merge_failure_reporters(self):
3735 """Check that the config is set up correctly"""
3736
Clint Byrumb9de8be2017-05-27 13:49:19 -07003737 tenant = self.sched.abide.tenants.get('tenant-one')
Joshua Heskethb7179772014-01-30 23:30:46 +11003738 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003739 "Merge Failed.\n\nThis change or one of its cross-repo "
3740 "dependencies was unable to be automatically merged with the "
3741 "current state of its repository. Please rebase the change and "
3742 "upload a new patchset.",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003743 tenant.layout.pipelines['check'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003744 self.assertEqual(
3745 "The merge failed! For more information...",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003746 tenant.layout.pipelines['gate'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003747
3748 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003749 len(tenant.layout.pipelines['check'].merge_failure_actions), 1)
Joshua Heskethb7179772014-01-30 23:30:46 +11003750 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003751 len(tenant.layout.pipelines['gate'].merge_failure_actions), 2)
Joshua Heskethb7179772014-01-30 23:30:46 +11003752
3753 self.assertTrue(isinstance(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003754 tenant.layout.pipelines['check'].merge_failure_actions[0],
3755 gerritreporter.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003756
3757 self.assertTrue(
3758 (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003759 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003760 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003761 zuul.driver.smtp.smtpreporter.SMTPReporter) and
3762 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003763 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003764 gerritreporter.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003765 ) or (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003766 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003767 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003768 gerritreporter.GerritReporter) and
3769 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003770 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003771 zuul.driver.smtp.smtpreporter.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003772 )
3773 )
3774
James E. Blairec056492016-07-22 09:45:56 -07003775 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003776 def test_merge_failure_reports(self):
3777 """Check that when a change fails to merge the correct message is sent
3778 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003779 self.updateConfigLayout(
3780 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003781 self.sched.reconfigure(self.config)
3782 self.registerJobs()
3783
3784 # Check a test failure isn't reported to SMTP
3785 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003786 A.addApproval('Code-Review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003787 self.executor_server.failJob('project-test1', A)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003788 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003789 self.waitUntilSettled()
3790
3791 self.assertEqual(3, len(self.history)) # 3 jobs
3792 self.assertEqual(0, len(self.smtp_messages))
3793
3794 # Check a merge failure is reported to SMTP
3795 # B should be merged, but C will conflict with B
3796 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3797 B.addPatchset(['conflict'])
3798 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3799 C.addPatchset(['conflict'])
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003800 B.addApproval('Code-Review', 2)
3801 C.addApproval('Code-Review', 2)
3802 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3803 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003804 self.waitUntilSettled()
3805
3806 self.assertEqual(6, len(self.history)) # A and B jobs
3807 self.assertEqual(1, len(self.smtp_messages))
3808 self.assertEqual('The merge failed! For more information...',
3809 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003810
James E. Blairec056492016-07-22 09:45:56 -07003811 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003812 def test_default_merge_failure_reports(self):
3813 """Check that the default merge failure reports are correct."""
3814
3815 # A should report success, B should report merge failure.
3816 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3817 A.addPatchset(['conflict'])
3818 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3819 B.addPatchset(['conflict'])
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003820 A.addApproval('Code-Review', 2)
3821 B.addApproval('Code-Review', 2)
3822 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3823 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003824 self.waitUntilSettled()
3825
3826 self.assertEqual(3, len(self.history)) # A jobs
3827 self.assertEqual(A.reported, 2)
3828 self.assertEqual(B.reported, 2)
3829 self.assertEqual(A.data['status'], 'MERGED')
3830 self.assertEqual(B.data['status'], 'NEW')
3831 self.assertIn('Build succeeded', A.messages[1])
3832 self.assertIn('Merge Failed', B.messages[1])
3833 self.assertIn('automatically merged', B.messages[1])
3834 self.assertNotIn('logs.example.com', B.messages[1])
3835 self.assertNotIn('SKIPPED', B.messages[1])
3836
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003837 def test_client_get_running_jobs(self):
3838 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003839 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003840 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003841 A.addApproval('Code-Review', 2)
3842 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003843 self.waitUntilSettled()
3844
3845 client = zuul.rpcclient.RPCClient('127.0.0.1',
3846 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003847 self.addCleanup(client.shutdown)
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003848
3849 # Wait for gearman server to send the initial workData back to zuul
3850 start = time.time()
3851 while True:
3852 if time.time() - start > 10:
3853 raise Exception("Timeout waiting for gearman server to report "
3854 + "back to the client")
Clint Byrum1d0c7d12017-05-10 19:40:53 -07003855 build = list(self.executor_client.builds.values())[0]
Monty Tayloreea6bb92017-06-14 11:56:54 -05003856 if build.worker.name == self.executor_server.hostname:
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003857 break
3858 else:
3859 time.sleep(0)
3860
3861 running_items = client.get_running_jobs()
3862
3863 self.assertEqual(1, len(running_items))
3864 running_item = running_items[0]
3865 self.assertEqual([], running_item['failing_reasons'])
3866 self.assertEqual([], running_item['items_behind'])
3867 self.assertEqual('https://hostname/1', running_item['url'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003868 self.assertIsNone(running_item['item_ahead'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003869 self.assertEqual('org/project', running_item['project'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003870 self.assertIsNone(running_item['remaining_time'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003871 self.assertEqual(True, running_item['active'])
3872 self.assertEqual('1,1', running_item['id'])
3873
3874 self.assertEqual(3, len(running_item['jobs']))
3875 for job in running_item['jobs']:
3876 if job['name'] == 'project-merge':
3877 self.assertEqual('project-merge', job['name'])
3878 self.assertEqual('gate', job['pipeline'])
3879 self.assertEqual(False, job['retry'])
Monty Taylor51139a02016-05-24 11:28:10 -05003880 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02003881 'static/stream.html?uuid={uuid}&logfile=console.log'
3882 .format(uuid=job['uuid']), job['url'])
3883 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05003884 'finger://{hostname}/{uuid}'.format(
3885 hostname=self.executor_server.hostname,
3886 uuid=job['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02003887 job['finger_url'])
Clint Byrumd4de79a2017-05-27 11:39:13 -07003888 self.assertEqual(2, len(job['worker']))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003889 self.assertEqual(False, job['canceled'])
3890 self.assertEqual(True, job['voting'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003891 self.assertIsNone(job['result'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003892 self.assertEqual('gate', job['pipeline'])
3893 break
3894
Paul Belanger174a8272017-03-14 13:20:10 -04003895 self.executor_server.hold_jobs_in_build = False
3896 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003897 self.waitUntilSettled()
3898
3899 running_items = client.get_running_jobs()
3900 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003901
James E. Blairb70e55a2017-04-19 12:57:02 -07003902 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003903 def test_nonvoting_pipeline(self):
3904 "Test that a nonvoting pipeline (experimental) can still report"
3905
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003906 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3907 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003908 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3909 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003910
3911 self.assertEqual(self.getJobFromHistory('project-merge').result,
3912 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003913 self.assertEqual(
3914 self.getJobFromHistory('experimental-project-test').result,
3915 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003916 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003917
3918 def test_crd_gate(self):
3919 "Test cross-repo dependencies"
3920 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3921 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003922 A.addApproval('Code-Review', 2)
3923 B.addApproval('Code-Review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003924
3925 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3926 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3927 AM2.setMerged()
3928 AM1.setMerged()
3929
3930 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3931 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3932 BM2.setMerged()
3933 BM1.setMerged()
3934
3935 # A -> AM1 -> AM2
3936 # B -> BM1 -> BM2
3937 # A Depends-On: B
3938 # M2 is here to make sure it is never queried. If it is, it
3939 # means zuul is walking down the entire history of merged
3940 # changes.
3941
3942 B.setDependsOn(BM1, 1)
3943 BM1.setDependsOn(BM2, 1)
3944
3945 A.setDependsOn(AM1, 1)
3946 AM1.setDependsOn(AM2, 1)
3947
3948 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3949 A.subject, B.data['id'])
3950
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003951 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003952 self.waitUntilSettled()
3953
3954 self.assertEqual(A.data['status'], 'NEW')
3955 self.assertEqual(B.data['status'], 'NEW')
3956
Paul Belanger5dccbe72016-11-14 11:17:37 -05003957 for connection in self.connections.connections.values():
James E. Blairb0a95ab2017-10-18 09:39:18 -07003958 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003959
Paul Belanger174a8272017-03-14 13:20:10 -04003960 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003961 B.addApproval('Approved', 1)
3962 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003963 self.waitUntilSettled()
3964
Paul Belanger174a8272017-03-14 13:20:10 -04003965 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003966 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003967 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003968 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003969 self.executor_server.hold_jobs_in_build = False
3970 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003971 self.waitUntilSettled()
3972
3973 self.assertEqual(AM2.queried, 0)
3974 self.assertEqual(BM2.queried, 0)
3975 self.assertEqual(A.data['status'], 'MERGED')
3976 self.assertEqual(B.data['status'], 'MERGED')
3977 self.assertEqual(A.reported, 2)
3978 self.assertEqual(B.reported, 2)
3979
Paul Belanger5dccbe72016-11-14 11:17:37 -05003980 changes = self.getJobFromHistory(
3981 'project-merge', 'org/project1').changes
3982 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003983
3984 def test_crd_branch(self):
3985 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003986
3987 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003988 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3989 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04003990 C1 = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C1')
3991 C2 = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C2',
3992 status='ABANDONED')
3993 C1.data['id'] = B.data['id']
3994 C2.data['id'] = B.data['id']
3995
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003996 A.addApproval('Code-Review', 2)
3997 B.addApproval('Code-Review', 2)
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04003998 C1.addApproval('Code-Review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003999
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004000 # A Depends-On: B+C1
James E. Blair8f78d882015-02-05 08:51:37 -08004001 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4002 A.subject, B.data['id'])
4003
Paul Belanger174a8272017-03-14 13:20:10 -04004004 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004005 B.addApproval('Approved', 1)
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004006 C1.addApproval('Approved', 1)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004007 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08004008 self.waitUntilSettled()
4009
Paul Belanger174a8272017-03-14 13:20:10 -04004010 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004011 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004012 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004013 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004014 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004015 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004016 self.executor_server.hold_jobs_in_build = False
4017 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08004018 self.waitUntilSettled()
4019
4020 self.assertEqual(A.data['status'], 'MERGED')
4021 self.assertEqual(B.data['status'], 'MERGED')
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004022 self.assertEqual(C1.data['status'], 'MERGED')
James E. Blair8f78d882015-02-05 08:51:37 -08004023 self.assertEqual(A.reported, 2)
4024 self.assertEqual(B.reported, 2)
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004025 self.assertEqual(C1.reported, 2)
James E. Blair8f78d882015-02-05 08:51:37 -08004026
Paul Belanger6379db12016-11-14 13:57:54 -05004027 changes = self.getJobFromHistory(
4028 'project-merge', 'org/project1').changes
4029 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08004030
4031 def test_crd_multiline(self):
4032 "Test multiple depends-on lines in commit"
4033 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4034 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4035 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004036 A.addApproval('Code-Review', 2)
4037 B.addApproval('Code-Review', 2)
4038 C.addApproval('Code-Review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08004039
4040 # A Depends-On: B+C
4041 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
4042 A.subject, B.data['id'], C.data['id'])
4043
Paul Belanger174a8272017-03-14 13:20:10 -04004044 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004045 B.addApproval('Approved', 1)
4046 C.addApproval('Approved', 1)
4047 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08004048 self.waitUntilSettled()
4049
Paul Belanger174a8272017-03-14 13:20:10 -04004050 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004051 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004052 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004053 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004054 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004055 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004056 self.executor_server.hold_jobs_in_build = False
4057 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08004058 self.waitUntilSettled()
4059
4060 self.assertEqual(A.data['status'], 'MERGED')
4061 self.assertEqual(B.data['status'], 'MERGED')
4062 self.assertEqual(C.data['status'], 'MERGED')
4063 self.assertEqual(A.reported, 2)
4064 self.assertEqual(B.reported, 2)
4065 self.assertEqual(C.reported, 2)
4066
Paul Belanger5dccbe72016-11-14 11:17:37 -05004067 changes = self.getJobFromHistory(
4068 'project-merge', 'org/project1').changes
4069 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08004070
4071 def test_crd_unshared_gate(self):
4072 "Test cross-repo dependencies in unshared gate queues"
4073 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4074 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004075 A.addApproval('Code-Review', 2)
4076 B.addApproval('Code-Review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08004077
4078 # A Depends-On: B
4079 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4080 A.subject, B.data['id'])
4081
4082 # A and B do not share a queue, make sure that A is unable to
4083 # enqueue B (and therefore, A is unable to be enqueued).
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004084 B.addApproval('Approved', 1)
4085 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004086 self.waitUntilSettled()
4087
4088 self.assertEqual(A.data['status'], 'NEW')
4089 self.assertEqual(B.data['status'], 'NEW')
4090 self.assertEqual(A.reported, 0)
4091 self.assertEqual(B.reported, 0)
4092 self.assertEqual(len(self.history), 0)
4093
4094 # Enqueue and merge B alone.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004095 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004096 self.waitUntilSettled()
4097
4098 self.assertEqual(B.data['status'], 'MERGED')
4099 self.assertEqual(B.reported, 2)
4100
4101 # Now that B is merged, A should be able to be enqueued and
4102 # merged.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004103 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004104 self.waitUntilSettled()
4105
4106 self.assertEqual(A.data['status'], 'MERGED')
4107 self.assertEqual(A.reported, 2)
4108
James E. Blair96698e22015-04-02 07:48:21 -07004109 def test_crd_gate_reverse(self):
4110 "Test reverse cross-repo dependencies"
4111 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4112 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004113 A.addApproval('Code-Review', 2)
4114 B.addApproval('Code-Review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07004115
4116 # A Depends-On: B
4117
4118 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4119 A.subject, B.data['id'])
4120
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004121 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07004122 self.waitUntilSettled()
4123
4124 self.assertEqual(A.data['status'], 'NEW')
4125 self.assertEqual(B.data['status'], 'NEW')
4126
Paul Belanger174a8272017-03-14 13:20:10 -04004127 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004128 A.addApproval('Approved', 1)
4129 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07004130 self.waitUntilSettled()
4131
Paul Belanger174a8272017-03-14 13:20:10 -04004132 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07004133 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004134 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07004135 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004136 self.executor_server.hold_jobs_in_build = False
4137 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07004138 self.waitUntilSettled()
4139
4140 self.assertEqual(A.data['status'], 'MERGED')
4141 self.assertEqual(B.data['status'], 'MERGED')
4142 self.assertEqual(A.reported, 2)
4143 self.assertEqual(B.reported, 2)
4144
Paul Belanger5dccbe72016-11-14 11:17:37 -05004145 changes = self.getJobFromHistory(
4146 'project-merge', 'org/project1').changes
4147 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07004148
James E. Blair5ee24252014-12-30 10:12:29 -08004149 def test_crd_cycle(self):
4150 "Test cross-repo dependency cycles"
4151 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4152 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004153 A.addApproval('Code-Review', 2)
4154 B.addApproval('Code-Review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08004155
4156 # A -> B -> A (via commit-depends)
4157
4158 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4159 A.subject, B.data['id'])
4160 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4161 B.subject, A.data['id'])
4162
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004163 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004164 self.waitUntilSettled()
4165
4166 self.assertEqual(A.reported, 0)
4167 self.assertEqual(B.reported, 0)
4168 self.assertEqual(A.data['status'], 'NEW')
4169 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08004170
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004171 def test_crd_gate_unknown(self):
4172 "Test unknown projects in dependent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004173 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004174 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4175 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004176 A.addApproval('Code-Review', 2)
4177 B.addApproval('Code-Review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004178
4179 # A Depends-On: B
4180 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4181 A.subject, B.data['id'])
4182
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004183 B.addApproval('Approved', 1)
4184 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004185 self.waitUntilSettled()
4186
4187 # Unknown projects cannot share a queue with any other
4188 # since they don't have common jobs with any other (they have no jobs).
4189 # Changes which depend on unknown project changes
4190 # should not be processed in dependent pipeline
4191 self.assertEqual(A.data['status'], 'NEW')
4192 self.assertEqual(B.data['status'], 'NEW')
4193 self.assertEqual(A.reported, 0)
4194 self.assertEqual(B.reported, 0)
4195 self.assertEqual(len(self.history), 0)
4196
James E. Blair7720b402017-06-07 08:51:49 -07004197 # Simulate change B being gated outside this layout Set the
4198 # change merged before submitting the event so that when the
4199 # event triggers a gerrit query to update the change, we get
4200 # the information that it was merged.
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004201 B.setMerged()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004202 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004203 self.waitUntilSettled()
4204 self.assertEqual(len(self.history), 0)
4205
4206 # Now that B is merged, A should be able to be enqueued and
4207 # merged.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004208 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004209 self.waitUntilSettled()
4210
4211 self.assertEqual(A.data['status'], 'MERGED')
4212 self.assertEqual(A.reported, 2)
4213 self.assertEqual(B.data['status'], 'MERGED')
4214 self.assertEqual(B.reported, 0)
4215
James E. Blairbfb8e042014-12-30 17:01:44 -08004216 def test_crd_check(self):
4217 "Test cross-repo dependencies in independent pipelines"
4218
Paul Belanger174a8272017-03-14 13:20:10 -04004219 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08004220 self.gearman_server.hold_jobs_in_queue = True
4221 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4222 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4223
4224 # A Depends-On: B
4225 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4226 A.subject, B.data['id'])
4227
4228 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4229 self.waitUntilSettled()
4230
James E. Blairbfb8e042014-12-30 17:01:44 -08004231 self.gearman_server.hold_jobs_in_queue = False
4232 self.gearman_server.release()
4233 self.waitUntilSettled()
4234
Paul Belanger174a8272017-03-14 13:20:10 -04004235 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05004236 self.waitUntilSettled()
4237
James E. Blair2a535672017-04-27 12:03:15 -07004238 self.assertTrue(self.builds[0].hasChanges(A, B))
James E. Blairbfb8e042014-12-30 17:01:44 -08004239
Paul Belanger174a8272017-03-14 13:20:10 -04004240 self.executor_server.hold_jobs_in_build = False
4241 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05004242 self.waitUntilSettled()
4243
James E. Blairbfb8e042014-12-30 17:01:44 -08004244 self.assertEqual(A.data['status'], 'NEW')
4245 self.assertEqual(B.data['status'], 'NEW')
4246 self.assertEqual(A.reported, 1)
4247 self.assertEqual(B.reported, 0)
4248
4249 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05004250 tenant = self.sched.abide.tenants.get('tenant-one')
4251 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08004252
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004253 def test_crd_check_git_depends(self):
4254 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07004255 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004256 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4257 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4258
4259 # Add two git-dependent changes and make sure they both report
4260 # success.
4261 B.setDependsOn(A, 1)
4262 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4263 self.waitUntilSettled()
4264 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4265 self.waitUntilSettled()
4266
James E. Blairb8c16472015-05-05 14:55:26 -07004267 self.orderedRelease()
4268 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004269 self.waitUntilSettled()
4270
4271 self.assertEqual(A.data['status'], 'NEW')
4272 self.assertEqual(B.data['status'], 'NEW')
4273 self.assertEqual(A.reported, 1)
4274 self.assertEqual(B.reported, 1)
4275
4276 self.assertEqual(self.history[0].changes, '1,1')
4277 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04004278 tenant = self.sched.abide.tenants.get('tenant-one')
4279 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004280
4281 self.assertIn('Build succeeded', A.messages[0])
4282 self.assertIn('Build succeeded', B.messages[0])
4283
4284 def test_crd_check_duplicate(self):
4285 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04004286 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004287 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4288 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04004289 tenant = self.sched.abide.tenants.get('tenant-one')
4290 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004291
4292 # Add two git-dependent changes...
4293 B.setDependsOn(A, 1)
4294 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4295 self.waitUntilSettled()
4296 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4297
4298 # ...make sure the live one is not duplicated...
4299 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4300 self.waitUntilSettled()
4301 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4302
4303 # ...but the non-live one is able to be.
4304 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4305 self.waitUntilSettled()
4306 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4307
Clark Boylandd849822015-03-02 12:38:14 -08004308 # Release jobs in order to avoid races with change A jobs
4309 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07004310 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04004311 self.executor_server.hold_jobs_in_build = False
4312 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004313 self.waitUntilSettled()
4314
4315 self.assertEqual(A.data['status'], 'NEW')
4316 self.assertEqual(B.data['status'], 'NEW')
4317 self.assertEqual(A.reported, 1)
4318 self.assertEqual(B.reported, 1)
4319
4320 self.assertEqual(self.history[0].changes, '1,1 2,1')
4321 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04004322 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004323
4324 self.assertIn('Build succeeded', A.messages[0])
4325 self.assertIn('Build succeeded', B.messages[0])
4326
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004327 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08004328 "Test cross-repo dependencies re-enqueued in independent pipelines"
4329
4330 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004331 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
4332 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08004333
4334 # A Depends-On: B
4335 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4336 A.subject, B.data['id'])
4337
4338 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4339 self.waitUntilSettled()
4340
4341 self.sched.reconfigure(self.config)
4342
4343 # Make sure the items still share a change queue, and the
4344 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05004345 tenant = self.sched.abide.tenants.get('tenant-one')
4346 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
4347 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08004348 first_item = queue.queue[0]
4349 for item in queue.queue:
4350 self.assertEqual(item.queue, first_item.queue)
4351 self.assertFalse(first_item.live)
4352 self.assertTrue(queue.queue[1].live)
4353
4354 self.gearman_server.hold_jobs_in_queue = False
4355 self.gearman_server.release()
4356 self.waitUntilSettled()
4357
4358 self.assertEqual(A.data['status'], 'NEW')
4359 self.assertEqual(B.data['status'], 'NEW')
4360 self.assertEqual(A.reported, 1)
4361 self.assertEqual(B.reported, 0)
4362
4363 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004364 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004365
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004366 def test_crd_check_reconfiguration(self):
4367 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4368
4369 def test_crd_undefined_project(self):
4370 """Test that undefined projects in dependencies are handled for
4371 independent pipelines"""
4372 # It's a hack for fake gerrit,
4373 # as it implies repo creation upon the creation of any change
James E. Blairc4ba97a2017-04-19 16:26:24 -07004374 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004375 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4376
Jesse Keatingea68ab42017-04-19 15:03:30 -07004377 @simple_layout('layouts/ignore-dependencies.yaml')
James E. Blair17dd6772015-02-09 14:45:18 -08004378 def test_crd_check_ignore_dependencies(self):
4379 "Test cross-repo dependencies can be ignored"
James E. Blair17dd6772015-02-09 14:45:18 -08004380
4381 self.gearman_server.hold_jobs_in_queue = True
4382 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4383 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4384 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4385
4386 # A Depends-On: B
4387 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4388 A.subject, B.data['id'])
4389 # C git-depends on B
4390 C.setDependsOn(B, 1)
4391 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4392 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4393 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4394 self.waitUntilSettled()
4395
4396 # Make sure none of the items share a change queue, and all
4397 # are live.
Jesse Keatingea68ab42017-04-19 15:03:30 -07004398 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum12282ca2017-04-03 11:04:02 -07004399 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004400 self.assertEqual(len(check_pipeline.queues), 3)
4401 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4402 for item in check_pipeline.getAllItems():
4403 self.assertTrue(item.live)
4404
4405 self.gearman_server.hold_jobs_in_queue = False
4406 self.gearman_server.release()
4407 self.waitUntilSettled()
4408
4409 self.assertEqual(A.data['status'], 'NEW')
4410 self.assertEqual(B.data['status'], 'NEW')
4411 self.assertEqual(C.data['status'], 'NEW')
4412 self.assertEqual(A.reported, 1)
4413 self.assertEqual(B.reported, 1)
4414 self.assertEqual(C.reported, 1)
4415
4416 # Each job should have tested exactly one change
4417 for job in self.history:
4418 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004419
James E. Blair7cb84542017-04-19 13:35:05 -07004420 @simple_layout('layouts/three-projects.yaml')
James E. Blair96698e22015-04-02 07:48:21 -07004421 def test_crd_check_transitive(self):
4422 "Test transitive cross-repo dependencies"
4423 # Specifically, if A -> B -> C, and C gets a new patchset and
4424 # A gets a new patchset, ensure the test of A,2 includes B,1
4425 # and C,2 (not C,1 which would indicate stale data in the
4426 # cache for B).
4427 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4428 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4429 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4430
4431 # A Depends-On: B
4432 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4433 A.subject, B.data['id'])
4434
4435 # B Depends-On: C
4436 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4437 B.subject, C.data['id'])
4438
4439 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4440 self.waitUntilSettled()
4441 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4442
4443 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4444 self.waitUntilSettled()
4445 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4446
4447 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4448 self.waitUntilSettled()
4449 self.assertEqual(self.history[-1].changes, '3,1')
4450
4451 C.addPatchset()
4452 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4453 self.waitUntilSettled()
4454 self.assertEqual(self.history[-1].changes, '3,2')
4455
4456 A.addPatchset()
4457 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4458 self.waitUntilSettled()
4459 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004460
James E. Blaira8b90b32016-08-24 15:18:50 -07004461 def test_crd_check_unknown(self):
4462 "Test unknown projects in independent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004463 self.init_repo("org/unknown", tag='init')
James E. Blaira8b90b32016-08-24 15:18:50 -07004464 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4465 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4466 # A Depends-On: B
4467 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4468 A.subject, B.data['id'])
4469
4470 # Make sure zuul has seen an event on B.
4471 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4472 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4473 self.waitUntilSettled()
4474
4475 self.assertEqual(A.data['status'], 'NEW')
4476 self.assertEqual(A.reported, 1)
4477 self.assertEqual(B.data['status'], 'NEW')
4478 self.assertEqual(B.reported, 0)
4479
James E. Blair92464a22016-04-05 10:21:26 -07004480 def test_crd_cycle_join(self):
4481 "Test an updated change creates a cycle"
4482 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4483
4484 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4485 self.waitUntilSettled()
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004486 self.assertEqual(A.reported, 1)
James E. Blair92464a22016-04-05 10:21:26 -07004487
4488 # Create B->A
4489 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4490 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4491 B.subject, A.data['id'])
4492 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4493 self.waitUntilSettled()
4494
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004495 # Dep is there so zuul should have reported on B
4496 self.assertEqual(B.reported, 1)
4497
James E. Blair92464a22016-04-05 10:21:26 -07004498 # Update A to add A->B (a cycle).
4499 A.addPatchset()
4500 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4501 A.subject, B.data['id'])
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004502 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4503 self.waitUntilSettled()
James E. Blair92464a22016-04-05 10:21:26 -07004504
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004505 # Dependency cycle injected so zuul should not have reported again on A
4506 self.assertEqual(A.reported, 1)
James E. Blair92464a22016-04-05 10:21:26 -07004507
4508 # Now if we update B to remove the depends-on, everything
4509 # should be okay. B; A->B
4510
4511 B.addPatchset()
4512 B.data['commitMessage'] = '%s\n' % (B.subject,)
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004513 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4514 self.waitUntilSettled()
Paul Belanger0e155e22016-11-14 14:12:23 -05004515
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004516 # Cycle was removed so now zuul should have reported again on A
4517 self.assertEqual(A.reported, 2)
4518
4519 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
4520 self.waitUntilSettled()
4521 self.assertEqual(B.reported, 2)
James E. Blair92464a22016-04-05 10:21:26 -07004522
Jesse Keatingcc67b122017-04-19 14:54:57 -07004523 @simple_layout('layouts/disable_at.yaml')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004524 def test_disable_at(self):
4525 "Test a pipeline will only report to the disabled trigger when failing"
4526
Jesse Keatingcc67b122017-04-19 14:54:57 -07004527 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004528 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004529 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004530 0, tenant.layout.pipelines['check']._consecutive_failures)
4531 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004532
4533 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4534 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4535 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4536 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4537 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4538 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4539 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4540 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4541 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4542 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4543 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4544
Paul Belanger174a8272017-03-14 13:20:10 -04004545 self.executor_server.failJob('project-test1', A)
4546 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004547 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004548 self.executor_server.failJob('project-test1', D)
4549 self.executor_server.failJob('project-test1', E)
4550 self.executor_server.failJob('project-test1', F)
4551 self.executor_server.failJob('project-test1', G)
4552 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004553 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004554 self.executor_server.failJob('project-test1', J)
4555 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004556
4557 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4558 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4559 self.waitUntilSettled()
4560
4561 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004562 2, tenant.layout.pipelines['check']._consecutive_failures)
4563 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004564
4565 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4566 self.waitUntilSettled()
4567
4568 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004569 0, tenant.layout.pipelines['check']._consecutive_failures)
4570 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004571
4572 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4573 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4574 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4575 self.waitUntilSettled()
4576
4577 # We should be disabled now
4578 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004579 3, tenant.layout.pipelines['check']._consecutive_failures)
4580 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004581
4582 # We need to wait between each of these patches to make sure the
4583 # smtp messages come back in an expected order
4584 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4585 self.waitUntilSettled()
4586 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4587 self.waitUntilSettled()
4588 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4589 self.waitUntilSettled()
4590
4591 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4592 # leaving a message on each change
4593 self.assertEqual(1, len(A.messages))
4594 self.assertIn('Build failed.', A.messages[0])
4595 self.assertEqual(1, len(B.messages))
4596 self.assertIn('Build failed.', B.messages[0])
4597 self.assertEqual(1, len(C.messages))
4598 self.assertIn('Build succeeded.', C.messages[0])
4599 self.assertEqual(1, len(D.messages))
4600 self.assertIn('Build failed.', D.messages[0])
4601 self.assertEqual(1, len(E.messages))
4602 self.assertIn('Build failed.', E.messages[0])
4603 self.assertEqual(1, len(F.messages))
4604 self.assertIn('Build failed.', F.messages[0])
4605
4606 # The last 3 (GHI) would have only reported via smtp.
4607 self.assertEqual(3, len(self.smtp_messages))
4608 self.assertEqual(0, len(G.messages))
4609 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004610 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004611 'project-test1 finger://', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004612 self.assertEqual(0, len(H.messages))
4613 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004614 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004615 'project-test1 finger://', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004616 self.assertEqual(0, len(I.messages))
4617 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004618 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004619 'project-test1 finger://', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004620
4621 # Now reload the configuration (simulate a HUP) to check the pipeline
4622 # comes out of disabled
4623 self.sched.reconfigure(self.config)
4624
Jesse Keatingcc67b122017-04-19 14:54:57 -07004625 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004626
4627 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004628 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004629 0, tenant.layout.pipelines['check']._consecutive_failures)
4630 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004631
4632 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4633 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4634 self.waitUntilSettled()
4635
4636 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004637 2, tenant.layout.pipelines['check']._consecutive_failures)
4638 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004639
4640 # J and K went back to gerrit
4641 self.assertEqual(1, len(J.messages))
4642 self.assertIn('Build failed.', J.messages[0])
4643 self.assertEqual(1, len(K.messages))
4644 self.assertIn('Build failed.', K.messages[0])
4645 # No more messages reported via smtp
4646 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004647
James E. Blaircc020532017-04-19 13:04:44 -07004648 @simple_layout('layouts/one-job-project.yaml')
4649 def test_one_job_project(self):
4650 "Test that queueing works with one job"
4651 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4652 'master', 'A')
4653 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4654 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004655 A.addApproval('Code-Review', 2)
4656 B.addApproval('Code-Review', 2)
4657 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
4658 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blaircc020532017-04-19 13:04:44 -07004659 self.waitUntilSettled()
4660
4661 self.assertEqual(A.data['status'], 'MERGED')
4662 self.assertEqual(A.reported, 2)
4663 self.assertEqual(B.data['status'], 'MERGED')
4664 self.assertEqual(B.reported, 2)
4665
Paul Belanger32023542017-10-06 14:48:50 -04004666 def test_job_aborted(self):
4667 "Test that if a execute server aborts a job, it is run again"
4668 self.executor_server.hold_jobs_in_build = True
4669 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4670 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4671 self.waitUntilSettled()
4672
4673 self.executor_server.release('.*-merge')
4674 self.waitUntilSettled()
4675
4676 self.assertEqual(len(self.builds), 2)
Tobias Henkel26fa8a32017-10-07 07:08:36 +00004677
4678 # first abort
4679 self.builds[0].aborted = True
4680 self.executor_server.release('.*-test*')
4681 self.waitUntilSettled()
4682 self.assertEqual(len(self.builds), 1)
4683
4684 # second abort
4685 self.builds[0].aborted = True
4686 self.executor_server.release('.*-test*')
4687 self.waitUntilSettled()
4688 self.assertEqual(len(self.builds), 1)
4689
4690 # third abort
4691 self.builds[0].aborted = True
4692 self.executor_server.release('.*-test*')
4693 self.waitUntilSettled()
4694 self.assertEqual(len(self.builds), 1)
4695
4696 # fourth abort
Paul Belanger32023542017-10-06 14:48:50 -04004697 self.builds[0].aborted = True
4698 self.executor_server.release('.*-test*')
4699 self.waitUntilSettled()
4700 self.assertEqual(len(self.builds), 1)
4701
4702 self.executor_server.hold_jobs_in_build = False
4703 self.executor_server.release()
4704 self.waitUntilSettled()
4705
Tobias Henkel26fa8a32017-10-07 07:08:36 +00004706 self.assertEqual(len(self.history), 7)
4707 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
Paul Belanger32023542017-10-06 14:48:50 -04004708 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
4709
Paul Belanger71d98172016-11-08 10:56:31 -05004710 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004711 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004712
Paul Belanger174a8272017-03-14 13:20:10 -04004713 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004714 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4715 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4716 self.waitUntilSettled()
4717
Paul Belanger174a8272017-03-14 13:20:10 -04004718 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004719 self.waitUntilSettled()
4720
4721 self.assertEqual(len(self.builds), 2)
4722 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004723 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004724 self.waitUntilSettled()
4725
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004726 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004727 self.assertEqual(len(self.builds), 1,
4728 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004729 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004730 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004731 self.waitUntilSettled()
4732
Paul Belanger174a8272017-03-14 13:20:10 -04004733 self.executor_server.hold_jobs_in_build = False
4734 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004735 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004736 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004737 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4738 self.assertEqual(A.reported, 1)
4739 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004740
James E. Blair15be0e12017-01-03 13:45:20 -08004741 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004742 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004743
4744 self.fake_nodepool.paused = True
4745 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004746 A.addApproval('Code-Review', 2)
4747 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair15be0e12017-01-03 13:45:20 -08004748 self.waitUntilSettled()
4749
4750 self.zk.client.stop()
4751 self.zk.client.start()
4752 self.fake_nodepool.paused = False
4753 self.waitUntilSettled()
4754
4755 self.assertEqual(A.data['status'], 'MERGED')
4756 self.assertEqual(A.reported, 2)
4757
James E. Blair6ab79e02017-01-06 10:10:17 -08004758 def test_nodepool_failure(self):
4759 "Test that jobs are reported after a nodepool failure"
4760
4761 self.fake_nodepool.paused = True
4762 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004763 A.addApproval('Code-Review', 2)
4764 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair6ab79e02017-01-06 10:10:17 -08004765 self.waitUntilSettled()
4766
4767 req = self.fake_nodepool.getNodeRequests()[0]
4768 self.fake_nodepool.addFailRequest(req)
4769
4770 self.fake_nodepool.paused = False
4771 self.waitUntilSettled()
4772
4773 self.assertEqual(A.data['status'], 'NEW')
4774 self.assertEqual(A.reported, 2)
4775 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4776 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4777 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4778
Monty Taylor6dc5bc12017-09-29 15:47:31 -05004779 def test_nodepool_priority(self):
4780 "Test that nodes are requested at the correct priority"
4781
4782 self.fake_nodepool.paused = True
4783
4784 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4785 self.fake_gerrit.addEvent(A.getRefUpdatedEvent())
4786
4787 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4788 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4789
4790 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4791 C.addApproval('Code-Review', 2)
4792 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
4793
4794 self.waitUntilSettled()
4795
4796 reqs = self.fake_nodepool.getNodeRequests()
4797
4798 # The requests come back sorted by oid. Since we have three requests
4799 # for the three changes each with a different priority.
4800 # Also they get a serial number based on order they were received
4801 # so the number on the endof the oid should map to order submitted.
4802
4803 # * gate first - high priority - change C
4804 self.assertEqual(reqs[0]['_oid'], '100-0000000002')
4805 self.assertEqual(reqs[0]['node_types'], ['label1'])
4806 # * check second - normal priority - change B
4807 self.assertEqual(reqs[1]['_oid'], '200-0000000001')
4808 self.assertEqual(reqs[1]['node_types'], ['label1'])
4809 # * post third - low priority - change A
4810 # additionally, the post job defined uses an ubuntu-xenial node,
4811 # so we include that check just as an extra verification
4812 self.assertEqual(reqs[2]['_oid'], '300-0000000000')
4813 self.assertEqual(reqs[2]['node_types'], ['ubuntu-xenial'])
4814
4815 self.fake_nodepool.paused = False
4816 self.waitUntilSettled()
4817
James E. Blairfceaf412017-09-29 13:44:57 -07004818 @simple_layout('layouts/multiple-templates.yaml')
4819 def test_multiple_project_templates(self):
4820 # Test that applying multiple project templates to a project
4821 # doesn't alter them when used for a second project.
4822 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4823 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4824 self.waitUntilSettled()
4825
4826 build = self.getJobFromHistory('py27')
4827 self.assertEqual(build.parameters['zuul']['jobtags'], [])
4828
James E. Blair29c77002017-10-05 14:56:35 -07004829 def test_pending_merge_in_reconfig(self):
4830 # Test that if we are waiting for an outstanding merge on
4831 # reconfiguration that we continue to do so.
4832 self.gearman_server.hold_merge_jobs_in_queue = True
4833 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4834 A.setMerged()
4835 self.fake_gerrit.addEvent(A.getRefUpdatedEvent())
4836 self.waitUntilSettled()
4837 # Reconfigure while we still have an outstanding merge job
4838 self.sched.reconfigureTenant(self.sched.abide.tenants['tenant-one'],
4839 None)
4840 self.waitUntilSettled()
4841 # Verify the merge job is still running and that the item is
4842 # in the pipeline
4843 self.assertEqual(len(self.sched.merger.jobs), 1)
4844 tenant = self.sched.abide.tenants.get('tenant-one')
4845 pipeline = tenant.layout.pipelines['post']
4846 self.assertEqual(len(pipeline.getAllItems()), 1)
4847 self.gearman_server.hold_merge_jobs_in_queue = False
4848 self.gearman_server.release()
4849 self.waitUntilSettled()
4850
Arieb6f068c2016-10-09 13:11:06 +03004851
James E. Blaira002b032017-04-18 10:35:48 -07004852class TestExecutor(ZuulTestCase):
4853 tenant_config_file = 'config/single-tenant/main.yaml'
4854
4855 def assertFinalState(self):
4856 # In this test, we expect to shut down in a non-final state,
4857 # so skip these checks.
4858 pass
4859
4860 def assertCleanShutdown(self):
4861 self.log.debug("Assert clean shutdown")
4862
4863 # After shutdown, make sure no jobs are running
4864 self.assertEqual({}, self.executor_server.job_workers)
4865
4866 # Make sure that git.Repo objects have been garbage collected.
4867 repos = []
4868 gc.collect()
4869 for obj in gc.get_objects():
4870 if isinstance(obj, git.Repo):
4871 self.log.debug("Leaked git repo object: %s" % repr(obj))
4872 repos.append(obj)
4873 self.assertEqual(len(repos), 0)
4874
4875 def test_executor_shutdown(self):
4876 "Test that the executor can shut down with jobs running"
4877
4878 self.executor_server.hold_jobs_in_build = True
4879 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004880 A.addApproval('Code-Review', 2)
4881 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blaira002b032017-04-18 10:35:48 -07004882 self.waitUntilSettled()
4883
4884
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004885class TestDependencyGraph(ZuulTestCase):
4886 tenant_config_file = 'config/dependency-graph/main.yaml'
4887
4888 def test_dependeny_graph_dispatch_jobs_once(self):
4889 "Test a job in a dependency graph is queued only once"
4890 # Job dependencies, starting with A
4891 # A
4892 # / \
4893 # B C
4894 # / \ / \
4895 # D F E
4896 # |
4897 # G
4898
4899 self.executor_server.hold_jobs_in_build = True
4900 change = self.fake_gerrit.addFakeChange(
4901 'org/project', 'master', 'change')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004902 change.addApproval('Code-Review', 2)
4903 self.fake_gerrit.addEvent(change.addApproval('Approved', 1))
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004904
4905 self.waitUntilSettled()
4906 self.assertEqual([b.name for b in self.builds], ['A'])
4907
4908 self.executor_server.release('A')
4909 self.waitUntilSettled()
4910 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4911
4912 self.executor_server.release('B')
4913 self.waitUntilSettled()
4914 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4915
4916 self.executor_server.release('D')
4917 self.waitUntilSettled()
4918 self.assertEqual([b.name for b in self.builds], ['C'])
4919
4920 self.executor_server.release('C')
4921 self.waitUntilSettled()
4922 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4923
4924 self.executor_server.release('F')
4925 self.waitUntilSettled()
4926 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4927
4928 self.executor_server.release('G')
4929 self.waitUntilSettled()
4930 self.assertEqual([b.name for b in self.builds], ['E'])
4931
4932 self.executor_server.release('E')
4933 self.waitUntilSettled()
4934 self.assertEqual(len(self.builds), 0)
4935
4936 self.executor_server.hold_jobs_in_build = False
4937 self.executor_server.release()
4938 self.waitUntilSettled()
4939
4940 self.assertEqual(len(self.builds), 0)
4941 self.assertEqual(len(self.history), 7)
4942
4943 self.assertEqual(change.data['status'], 'MERGED')
4944 self.assertEqual(change.reported, 2)
4945
4946 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4947 "Test that a job waits till all dependencies are successful"
4948 # Job dependencies, starting with A
4949 # A
4950 # / \
4951 # B C*
4952 # / \ / \
4953 # D F E
4954 # |
4955 # G
4956
4957 self.executor_server.hold_jobs_in_build = True
4958 change = self.fake_gerrit.addFakeChange(
4959 'org/project', 'master', 'change')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004960 change.addApproval('Code-Review', 2)
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004961
4962 self.executor_server.failJob('C', change)
4963
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004964 self.fake_gerrit.addEvent(change.addApproval('Approved', 1))
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004965
4966 self.waitUntilSettled()
4967 self.assertEqual([b.name for b in self.builds], ['A'])
4968
4969 self.executor_server.release('A')
4970 self.waitUntilSettled()
4971 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4972
4973 self.executor_server.release('B')
4974 self.waitUntilSettled()
4975 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4976
4977 self.executor_server.release('D')
4978 self.waitUntilSettled()
4979 self.assertEqual([b.name for b in self.builds], ['C'])
4980
4981 self.executor_server.release('C')
4982 self.waitUntilSettled()
4983 self.assertEqual(len(self.builds), 0)
4984
4985 self.executor_server.hold_jobs_in_build = False
4986 self.executor_server.release()
4987 self.waitUntilSettled()
4988
4989 self.assertEqual(len(self.builds), 0)
4990 self.assertEqual(len(self.history), 4)
4991
4992 self.assertEqual(change.data['status'], 'NEW')
4993 self.assertEqual(change.reported, 2)
4994
4995
Arieb6f068c2016-10-09 13:11:06 +03004996class TestDuplicatePipeline(ZuulTestCase):
4997 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
4998
4999 def test_duplicate_pipelines(self):
5000 "Test that a change matching multiple pipelines works"
5001
5002 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5003 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
5004 self.waitUntilSettled()
5005
5006 self.assertHistory([
5007 dict(name='project-test1', result='SUCCESS', changes='1,1',
5008 pipeline='dup1'),
5009 dict(name='project-test1', result='SUCCESS', changes='1,1',
5010 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05005011 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03005012
5013 self.assertEqual(len(A.messages), 2)
5014
Paul Belangera46a3742016-11-09 14:23:03 -05005015 if 'dup1' in A.messages[0]:
5016 self.assertIn('dup1', A.messages[0])
5017 self.assertNotIn('dup2', A.messages[0])
5018 self.assertIn('project-test1', A.messages[0])
5019 self.assertIn('dup2', A.messages[1])
5020 self.assertNotIn('dup1', A.messages[1])
5021 self.assertIn('project-test1', A.messages[1])
5022 else:
5023 self.assertIn('dup1', A.messages[1])
5024 self.assertNotIn('dup2', A.messages[1])
5025 self.assertIn('project-test1', A.messages[1])
5026 self.assertIn('dup2', A.messages[0])
5027 self.assertNotIn('dup1', A.messages[0])
5028 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04005029
5030
Paul Belanger86085b32016-11-03 12:48:57 -04005031class TestSchedulerTemplatedProject(ZuulTestCase):
5032 tenant_config_file = 'config/templated-project/main.yaml'
5033
Paul Belanger174a8272017-03-14 13:20:10 -04005034 def test_job_from_templates_executed(self):
5035 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04005036
5037 A = self.fake_gerrit.addFakeChange(
5038 'org/templated-project', 'master', 'A')
5039 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5040 self.waitUntilSettled()
5041
5042 self.assertEqual(self.getJobFromHistory('project-test1').result,
5043 'SUCCESS')
5044 self.assertEqual(self.getJobFromHistory('project-test2').result,
5045 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04005046
5047 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04005048 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04005049
5050 A = self.fake_gerrit.addFakeChange(
5051 'org/layered-project', 'master', 'A')
5052 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5053 self.waitUntilSettled()
5054
5055 self.assertEqual(self.getJobFromHistory('project-test1').result,
5056 'SUCCESS')
5057 self.assertEqual(self.getJobFromHistory('project-test2').result,
5058 'SUCCESS')
5059 self.assertEqual(self.getJobFromHistory('layered-project-test3'
5060 ).result, 'SUCCESS')
5061 self.assertEqual(self.getJobFromHistory('layered-project-test4'
5062 ).result, 'SUCCESS')
5063 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
5064 ).result, 'SUCCESS')
5065 self.assertEqual(self.getJobFromHistory('project-test6').result,
5066 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08005067
James E. Blaire74f5712017-09-29 15:14:31 -07005068 def test_unimplied_branch_matchers(self):
5069 # This tests that there are no implied branch matchers added
5070 # by project templates.
5071 self.create_branch('org/layered-project', 'stable')
5072
5073 A = self.fake_gerrit.addFakeChange(
5074 'org/layered-project', 'stable', 'A')
5075
5076 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5077 self.waitUntilSettled()
5078
5079 self.assertEqual(self.getJobFromHistory('project-test1').result,
5080 'SUCCESS')
5081 print(self.getJobFromHistory('project-test1').
5082 parameters['zuul']['_inheritance_path'])
5083
5084 def test_implied_branch_matchers(self):
5085 # This tests that there is an implied branch matcher when a
5086 # template is used on an in-repo project pipeline definition.
5087 self.create_branch('untrusted-config', 'stable')
5088 self.fake_gerrit.addEvent(
5089 self.fake_gerrit.getFakeBranchCreatedEvent(
5090 'untrusted-config', 'stable'))
5091 self.waitUntilSettled()
5092
5093 A = self.fake_gerrit.addFakeChange(
5094 'untrusted-config', 'stable', 'A')
5095
5096 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5097 self.waitUntilSettled()
5098
5099 self.assertEqual(self.getJobFromHistory('project-test1').result,
5100 'SUCCESS')
5101 print(self.getJobFromHistory('project-test1').
5102 parameters['zuul']['_inheritance_path'])
5103
Adam Gandelman94a60062016-11-21 16:43:14 -08005104
5105class TestSchedulerSuccessURL(ZuulTestCase):
5106 tenant_config_file = 'config/success-url/main.yaml'
5107
5108 def test_success_url(self):
5109 "Ensure bad build params are ignored"
5110 self.sched.reconfigure(self.config)
5111 self.init_repo('org/docs')
5112
5113 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
5114 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5115 self.waitUntilSettled()
5116
5117 # Both builds ran: docs-draft-test + docs-draft-test2
5118 self.assertEqual(len(self.history), 2)
5119
5120 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08005121 for build in self.history:
5122 if build.name == 'docs-draft-test':
5123 uuid = build.uuid[:7]
Monty Taylorde8242c2017-02-23 20:29:53 -06005124 elif build.name == 'docs-draft-test2':
5125 uuid_test2 = build.uuid
Adam Gandelman94a60062016-11-21 16:43:14 -08005126
5127 # Two msgs: 'Starting...' + results
5128 self.assertEqual(len(self.smtp_messages), 2)
5129 body = self.smtp_messages[1]['body'].splitlines()
5130 self.assertEqual('Build succeeded.', body[0])
5131
5132 self.assertIn(
5133 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
5134 'docs-draft-test/%s/publish-docs/' % uuid,
5135 body[2])
5136
Paul Belanger174a8272017-03-14 13:20:10 -04005137 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08005138 self.assertIn(
Monty Taylor51139a02016-05-24 11:28:10 -05005139 '- docs-draft-test2 finger://{hostname}/{uuid}'.format(
5140 hostname=self.executor_server.hostname,
Monty Taylorde8242c2017-02-23 20:29:53 -06005141 uuid=uuid_test2),
Adam Gandelman94a60062016-11-21 16:43:14 -08005142 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08005143
5144
Adam Gandelman4da00f62016-12-09 15:47:33 -08005145class TestSchedulerMerges(ZuulTestCase):
5146 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08005147
5148 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04005149 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08005150 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04005151 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08005152 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
5153 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
5154 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005155 A.addApproval('Code-Review', 2)
5156 B.addApproval('Code-Review', 2)
5157 C.addApproval('Code-Review', 2)
5158 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5159 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5160 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Adam Gandelman8bd57102016-12-02 12:58:42 -08005161 self.waitUntilSettled()
5162
5163 build = self.builds[-1]
James E. Blair2a535672017-04-27 12:03:15 -07005164 path = os.path.join(build.jobdir.src_root, 'review.example.com',
5165 project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08005166 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07005167 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman8bd57102016-12-02 12:58:42 -08005168 repo_messages.reverse()
5169
Paul Belanger174a8272017-03-14 13:20:10 -04005170 self.executor_server.hold_jobs_in_build = False
5171 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08005172 self.waitUntilSettled()
5173
5174 return repo_messages
5175
5176 def _test_merge(self, mode):
5177 us_path = os.path.join(
5178 self.upstream_root, 'org/project-%s' % mode)
5179 expected_messages = [
5180 'initial commit',
5181 'add content from fixture',
5182 # the intermediate commits order is nondeterministic
5183 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
5184 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
5185 ]
5186 result = self._test_project_merge_mode(mode)
5187 self.assertEqual(result[:2], expected_messages[:2])
5188 self.assertEqual(result[-2:], expected_messages[-2:])
5189
5190 def test_project_merge_mode_merge(self):
5191 self._test_merge('merge')
5192
5193 def test_project_merge_mode_merge_resolve(self):
5194 self._test_merge('merge-resolve')
5195
5196 def test_project_merge_mode_cherrypick(self):
5197 expected_messages = [
5198 'initial commit',
5199 'add content from fixture',
5200 'A-1',
5201 'B-1',
5202 'C-1']
5203 result = self._test_project_merge_mode('cherry-pick')
5204 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08005205
5206 def test_merge_branch(self):
5207 "Test that the right commits are on alternate branches"
5208 self.create_branch('org/project-merge-branches', 'mp')
5209
Paul Belanger174a8272017-03-14 13:20:10 -04005210 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08005211 A = self.fake_gerrit.addFakeChange(
5212 'org/project-merge-branches', 'mp', 'A')
5213 B = self.fake_gerrit.addFakeChange(
5214 'org/project-merge-branches', 'mp', 'B')
5215 C = self.fake_gerrit.addFakeChange(
5216 'org/project-merge-branches', 'mp', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005217 A.addApproval('Code-Review', 2)
5218 B.addApproval('Code-Review', 2)
5219 C.addApproval('Code-Review', 2)
5220 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5221 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5222 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Adam Gandelman4da00f62016-12-09 15:47:33 -08005223 self.waitUntilSettled()
5224
Paul Belanger174a8272017-03-14 13:20:10 -04005225 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005226 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04005227 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005228 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04005229 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005230 self.waitUntilSettled()
5231
5232 build = self.builds[-1]
James E. Blair3b222492017-07-21 15:17:37 -07005233 self.assertEqual(build.parameters['zuul']['branch'], 'mp')
James E. Blair2a535672017-04-27 12:03:15 -07005234 path = os.path.join(build.jobdir.src_root, 'review.example.com',
5235 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005236 repo = git.Repo(path)
5237
James E. Blair247cab72017-07-20 16:52:36 -07005238 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005239 repo_messages.reverse()
5240 correct_messages = [
5241 'initial commit',
5242 'add content from fixture',
5243 'mp commit',
5244 'A-1', 'B-1', 'C-1']
5245 self.assertEqual(repo_messages, correct_messages)
5246
Paul Belanger174a8272017-03-14 13:20:10 -04005247 self.executor_server.hold_jobs_in_build = False
5248 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08005249 self.waitUntilSettled()
5250
5251 def test_merge_multi_branch(self):
5252 "Test that dependent changes on multiple branches are merged"
5253 self.create_branch('org/project-merge-branches', 'mp')
5254
Paul Belanger174a8272017-03-14 13:20:10 -04005255 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08005256 A = self.fake_gerrit.addFakeChange(
5257 'org/project-merge-branches', 'master', 'A')
5258 B = self.fake_gerrit.addFakeChange(
5259 'org/project-merge-branches', 'mp', 'B')
5260 C = self.fake_gerrit.addFakeChange(
5261 'org/project-merge-branches', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005262 A.addApproval('Code-Review', 2)
5263 B.addApproval('Code-Review', 2)
5264 C.addApproval('Code-Review', 2)
5265 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5266 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5267 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Adam Gandelman4da00f62016-12-09 15:47:33 -08005268 self.waitUntilSettled()
5269
5270 job_A = None
5271 for job in self.builds:
5272 if 'project-merge' in job.name:
5273 job_A = job
Adam Gandelman4da00f62016-12-09 15:47:33 -08005274
James E. Blair2a535672017-04-27 12:03:15 -07005275 path = os.path.join(job_A.jobdir.src_root, 'review.example.com',
5276 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005277 repo = git.Repo(path)
5278 repo_messages = [c.message.strip()
James E. Blair247cab72017-07-20 16:52:36 -07005279 for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005280 repo_messages.reverse()
5281 correct_messages = [
5282 'initial commit', 'add content from fixture', 'A-1']
5283 self.assertEqual(repo_messages, correct_messages)
5284
Paul Belanger174a8272017-03-14 13:20:10 -04005285 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005286 self.waitUntilSettled()
5287
5288 job_B = None
5289 for job in self.builds:
5290 if 'project-merge' in job.name:
5291 job_B = job
Adam Gandelman4da00f62016-12-09 15:47:33 -08005292
James E. Blair2a535672017-04-27 12:03:15 -07005293 path = os.path.join(job_B.jobdir.src_root, 'review.example.com',
5294 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005295 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07005296 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005297 repo_messages.reverse()
5298 correct_messages = [
5299 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
5300 self.assertEqual(repo_messages, correct_messages)
5301
Paul Belanger174a8272017-03-14 13:20:10 -04005302 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005303 self.waitUntilSettled()
5304
5305 job_C = None
5306 for job in self.builds:
5307 if 'project-merge' in job.name:
5308 job_C = job
James E. Blairb1345832017-07-21 14:51:35 -07005309
James E. Blair2a535672017-04-27 12:03:15 -07005310 path = os.path.join(job_C.jobdir.src_root, 'review.example.com',
5311 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005312 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07005313 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005314
5315 repo_messages.reverse()
5316 correct_messages = [
5317 'initial commit', 'add content from fixture',
5318 'A-1', 'C-1']
5319 # Ensure the right commits are in the history for this ref
5320 self.assertEqual(repo_messages, correct_messages)
5321
Paul Belanger174a8272017-03-14 13:20:10 -04005322 self.executor_server.hold_jobs_in_build = False
5323 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08005324 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005325
5326
James E. Blair9ea0d0b2017-04-20 09:27:15 -07005327class TestSemaphore(ZuulTestCase):
5328 tenant_config_file = 'config/semaphore/main.yaml'
5329
5330 def test_semaphore_one(self):
5331 "Test semaphores with max=1 (mutex)"
5332 tenant = self.sched.abide.tenants.get('tenant-one')
5333
5334 self.executor_server.hold_jobs_in_build = True
5335
5336 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5337 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5338 self.assertFalse('test-semaphore' in
5339 tenant.semaphore_handler.semaphores)
5340
5341 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5342 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5343 self.waitUntilSettled()
5344
5345 self.assertEqual(len(self.builds), 3)
5346 self.assertEqual(self.builds[0].name, 'project-test1')
5347 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
5348 self.assertEqual(self.builds[2].name, 'project-test1')
5349
5350 self.executor_server.release('semaphore-one-test1')
5351 self.waitUntilSettled()
5352
5353 self.assertEqual(len(self.builds), 3)
5354 self.assertEqual(self.builds[0].name, 'project-test1')
5355 self.assertEqual(self.builds[1].name, 'project-test1')
5356 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
5357 self.assertTrue('test-semaphore' in
5358 tenant.semaphore_handler.semaphores)
5359
5360 self.executor_server.release('semaphore-one-test2')
5361 self.waitUntilSettled()
5362
5363 self.assertEqual(len(self.builds), 3)
5364 self.assertEqual(self.builds[0].name, 'project-test1')
5365 self.assertEqual(self.builds[1].name, 'project-test1')
5366 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
5367 self.assertTrue('test-semaphore' in
5368 tenant.semaphore_handler.semaphores)
5369
5370 self.executor_server.release('semaphore-one-test1')
5371 self.waitUntilSettled()
5372
5373 self.assertEqual(len(self.builds), 3)
5374 self.assertEqual(self.builds[0].name, 'project-test1')
5375 self.assertEqual(self.builds[1].name, 'project-test1')
5376 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
5377 self.assertTrue('test-semaphore' in
5378 tenant.semaphore_handler.semaphores)
5379
5380 self.executor_server.release('semaphore-one-test2')
5381 self.waitUntilSettled()
5382
5383 self.assertEqual(len(self.builds), 2)
5384 self.assertEqual(self.builds[0].name, 'project-test1')
5385 self.assertEqual(self.builds[1].name, 'project-test1')
5386 self.assertFalse('test-semaphore' in
5387 tenant.semaphore_handler.semaphores)
5388
5389 self.executor_server.hold_jobs_in_build = False
5390 self.executor_server.release()
5391
5392 self.waitUntilSettled()
5393 self.assertEqual(len(self.builds), 0)
5394
5395 self.assertEqual(A.reported, 1)
5396 self.assertEqual(B.reported, 1)
5397 self.assertFalse('test-semaphore' in
5398 tenant.semaphore_handler.semaphores)
5399
5400 def test_semaphore_two(self):
5401 "Test semaphores with max>1"
5402 tenant = self.sched.abide.tenants.get('tenant-one')
5403
5404 self.executor_server.hold_jobs_in_build = True
5405 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5406 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5407 self.assertFalse('test-semaphore-two' in
5408 tenant.semaphore_handler.semaphores)
5409
5410 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5411 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5412 self.waitUntilSettled()
5413
5414 self.assertEqual(len(self.builds), 4)
5415 self.assertEqual(self.builds[0].name, 'project-test1')
5416 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
5417 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
5418 self.assertEqual(self.builds[3].name, 'project-test1')
5419 self.assertTrue('test-semaphore-two' in
5420 tenant.semaphore_handler.semaphores)
5421 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5422 'test-semaphore-two', [])), 2)
5423
5424 self.executor_server.release('semaphore-two-test1')
5425 self.waitUntilSettled()
5426
5427 self.assertEqual(len(self.builds), 4)
5428 self.assertEqual(self.builds[0].name, 'project-test1')
5429 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
5430 self.assertEqual(self.builds[2].name, 'project-test1')
5431 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
5432 self.assertTrue('test-semaphore-two' in
5433 tenant.semaphore_handler.semaphores)
5434 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5435 'test-semaphore-two', [])), 2)
5436
5437 self.executor_server.release('semaphore-two-test2')
5438 self.waitUntilSettled()
5439
5440 self.assertEqual(len(self.builds), 4)
5441 self.assertEqual(self.builds[0].name, 'project-test1')
5442 self.assertEqual(self.builds[1].name, 'project-test1')
5443 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
5444 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
5445 self.assertTrue('test-semaphore-two' in
5446 tenant.semaphore_handler.semaphores)
5447 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5448 'test-semaphore-two', [])), 2)
5449
5450 self.executor_server.release('semaphore-two-test1')
5451 self.waitUntilSettled()
5452
5453 self.assertEqual(len(self.builds), 3)
5454 self.assertEqual(self.builds[0].name, 'project-test1')
5455 self.assertEqual(self.builds[1].name, 'project-test1')
5456 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
5457 self.assertTrue('test-semaphore-two' in
5458 tenant.semaphore_handler.semaphores)
5459 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5460 'test-semaphore-two', [])), 1)
5461
5462 self.executor_server.release('semaphore-two-test2')
5463 self.waitUntilSettled()
5464
5465 self.assertEqual(len(self.builds), 2)
5466 self.assertEqual(self.builds[0].name, 'project-test1')
5467 self.assertEqual(self.builds[1].name, 'project-test1')
5468 self.assertFalse('test-semaphore-two' in
5469 tenant.semaphore_handler.semaphores)
5470
5471 self.executor_server.hold_jobs_in_build = False
5472 self.executor_server.release()
5473
5474 self.waitUntilSettled()
5475 self.assertEqual(len(self.builds), 0)
5476
5477 self.assertEqual(A.reported, 1)
5478 self.assertEqual(B.reported, 1)
5479
5480 def test_semaphore_abandon(self):
5481 "Test abandon with job semaphores"
5482 self.executor_server.hold_jobs_in_build = True
5483 tenant = self.sched.abide.tenants.get('tenant-one')
5484 check_pipeline = tenant.layout.pipelines['check']
5485
5486 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5487 self.assertFalse('test-semaphore' in
5488 tenant.semaphore_handler.semaphores)
5489
5490 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5491 self.waitUntilSettled()
5492
5493 self.assertTrue('test-semaphore' in
5494 tenant.semaphore_handler.semaphores)
5495
5496 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
5497 self.waitUntilSettled()
5498
5499 # The check pipeline should be empty
5500 items = check_pipeline.getAllItems()
5501 self.assertEqual(len(items), 0)
5502
5503 # The semaphore should be released
5504 self.assertFalse('test-semaphore' in
5505 tenant.semaphore_handler.semaphores)
5506
5507 self.executor_server.hold_jobs_in_build = False
5508 self.executor_server.release()
5509 self.waitUntilSettled()
5510
Tobias Henkel0f714002017-06-30 23:30:52 +02005511 def test_semaphore_new_patchset(self):
5512 "Test new patchset with job semaphores"
5513 self.executor_server.hold_jobs_in_build = True
5514 tenant = self.sched.abide.tenants.get('tenant-one')
5515 check_pipeline = tenant.layout.pipelines['check']
5516
5517 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5518 self.assertFalse('test-semaphore' in
5519 tenant.semaphore_handler.semaphores)
5520
5521 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5522 self.waitUntilSettled()
5523
5524 self.assertTrue('test-semaphore' in
5525 tenant.semaphore_handler.semaphores)
5526 semaphore = tenant.semaphore_handler.semaphores['test-semaphore']
5527 self.assertEqual(len(semaphore), 1)
5528
5529 A.addPatchset()
5530 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
5531 self.waitUntilSettled()
5532
5533 self.assertTrue('test-semaphore' in
5534 tenant.semaphore_handler.semaphores)
5535 semaphore = tenant.semaphore_handler.semaphores['test-semaphore']
5536 self.assertEqual(len(semaphore), 1)
5537
5538 items = check_pipeline.getAllItems()
5539 self.assertEqual(items[0].change.number, '1')
5540 self.assertEqual(items[0].change.patchset, '2')
5541 self.assertTrue(items[0].live)
5542
5543 self.executor_server.hold_jobs_in_build = False
5544 self.executor_server.release()
5545 self.waitUntilSettled()
5546
5547 # The semaphore should be released
5548 self.assertFalse('test-semaphore' in
5549 tenant.semaphore_handler.semaphores)
5550
James E. Blair9ea0d0b2017-04-20 09:27:15 -07005551 def test_semaphore_reconfigure(self):
5552 "Test reconfigure with job semaphores"
5553 self.executor_server.hold_jobs_in_build = True
5554 tenant = self.sched.abide.tenants.get('tenant-one')
5555 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5556 self.assertFalse('test-semaphore' in
5557 tenant.semaphore_handler.semaphores)
5558
5559 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5560 self.waitUntilSettled()
5561
5562 self.assertTrue('test-semaphore' in
5563 tenant.semaphore_handler.semaphores)
5564
5565 # reconfigure without layout change
5566 self.sched.reconfigure(self.config)
5567 self.waitUntilSettled()
5568 tenant = self.sched.abide.tenants.get('tenant-one')
5569
5570 # semaphore still must be held
5571 self.assertTrue('test-semaphore' in
5572 tenant.semaphore_handler.semaphores)
5573
5574 self.commitConfigUpdate(
5575 'common-config',
5576 'config/semaphore/zuul-reconfiguration.yaml')
5577 self.sched.reconfigure(self.config)
5578 self.waitUntilSettled()
5579 tenant = self.sched.abide.tenants.get('tenant-one')
5580
5581 self.executor_server.release('project-test1')
5582 self.waitUntilSettled()
5583
5584 # There should be no builds anymore
5585 self.assertEqual(len(self.builds), 0)
5586
5587 # The semaphore should be released
5588 self.assertFalse('test-semaphore' in
5589 tenant.semaphore_handler.semaphores)
5590
5591
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005592class TestSemaphoreMultiTenant(ZuulTestCase):
5593 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5594
5595 def test_semaphore_tenant_isolation(self):
5596 "Test semaphores in multiple tenants"
5597
5598 self.waitUntilSettled()
5599 tenant_one = self.sched.abide.tenants.get('tenant-one')
5600 tenant_two = self.sched.abide.tenants.get('tenant-two')
5601
5602 self.executor_server.hold_jobs_in_build = True
5603 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5604 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5605 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5606 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5607 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5608 self.assertFalse('test-semaphore' in
5609 tenant_one.semaphore_handler.semaphores)
5610 self.assertFalse('test-semaphore' in
5611 tenant_two.semaphore_handler.semaphores)
5612
5613 # add patches to project1 of tenant-one
5614 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5615 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5616 self.waitUntilSettled()
5617
5618 # one build of project1-test1 must run
5619 # semaphore of tenant-one must be acquired once
5620 # semaphore of tenant-two must not be acquired
5621 self.assertEqual(len(self.builds), 1)
5622 self.assertEqual(self.builds[0].name, 'project1-test1')
5623 self.assertTrue('test-semaphore' in
5624 tenant_one.semaphore_handler.semaphores)
5625 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5626 'test-semaphore', [])), 1)
5627 self.assertFalse('test-semaphore' in
5628 tenant_two.semaphore_handler.semaphores)
5629
5630 # add patches to project2 of tenant-two
5631 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5632 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5633 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5634 self.waitUntilSettled()
5635
5636 # one build of project1-test1 must run
5637 # two builds of project2-test1 must run
5638 # semaphore of tenant-one must be acquired once
5639 # semaphore of tenant-two must be acquired twice
5640 self.assertEqual(len(self.builds), 3)
5641 self.assertEqual(self.builds[0].name, 'project1-test1')
5642 self.assertEqual(self.builds[1].name, 'project2-test1')
5643 self.assertEqual(self.builds[2].name, 'project2-test1')
5644 self.assertTrue('test-semaphore' in
5645 tenant_one.semaphore_handler.semaphores)
5646 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5647 'test-semaphore', [])), 1)
5648 self.assertTrue('test-semaphore' in
5649 tenant_two.semaphore_handler.semaphores)
5650 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5651 'test-semaphore', [])), 2)
5652
5653 self.executor_server.release('project1-test1')
5654 self.waitUntilSettled()
5655
5656 # one build of project1-test1 must run
5657 # two builds of project2-test1 must run
5658 # semaphore of tenant-one must be acquired once
5659 # semaphore of tenant-two must be acquired twice
5660 self.assertEqual(len(self.builds), 3)
5661 self.assertEqual(self.builds[0].name, 'project2-test1')
5662 self.assertEqual(self.builds[1].name, 'project2-test1')
5663 self.assertEqual(self.builds[2].name, 'project1-test1')
5664 self.assertTrue('test-semaphore' in
5665 tenant_one.semaphore_handler.semaphores)
5666 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5667 'test-semaphore', [])), 1)
5668 self.assertTrue('test-semaphore' in
5669 tenant_two.semaphore_handler.semaphores)
5670 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5671 'test-semaphore', [])), 2)
5672
5673 self.executor_server.release('project2-test1')
5674 self.waitUntilSettled()
5675
5676 # one build of project1-test1 must run
5677 # one build of project2-test1 must run
5678 # semaphore of tenant-one must be acquired once
5679 # semaphore of tenant-two must be acquired once
5680 self.assertEqual(len(self.builds), 2)
5681 self.assertTrue('test-semaphore' in
5682 tenant_one.semaphore_handler.semaphores)
5683 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5684 'test-semaphore', [])), 1)
5685 self.assertTrue('test-semaphore' in
5686 tenant_two.semaphore_handler.semaphores)
5687 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5688 'test-semaphore', [])), 1)
5689
5690 self.executor_server.hold_jobs_in_build = False
5691 self.executor_server.release()
5692
5693 self.waitUntilSettled()
5694
5695 # no build must run
5696 # semaphore of tenant-one must not be acquired
5697 # semaphore of tenant-two must not be acquired
5698 self.assertEqual(len(self.builds), 0)
5699 self.assertFalse('test-semaphore' in
5700 tenant_one.semaphore_handler.semaphores)
5701 self.assertFalse('test-semaphore' in
5702 tenant_two.semaphore_handler.semaphores)
5703
5704 self.assertEqual(A.reported, 1)
5705 self.assertEqual(B.reported, 1)
5706
5707
5708class TestSemaphoreInRepo(ZuulTestCase):
Tobias Henkelabf973e2017-07-28 10:07:34 +02005709 config_file = 'zuul-connections-gerrit-and-github.conf'
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005710 tenant_config_file = 'config/in-repo/main.yaml'
5711
5712 def test_semaphore_in_repo(self):
5713 "Test semaphores in repo config"
5714
5715 # This tests dynamic semaphore handling in project repos. The semaphore
5716 # max value should not be evaluated dynamically but must be updated
5717 # after the change lands.
5718
5719 self.waitUntilSettled()
5720 tenant = self.sched.abide.tenants.get('tenant-one')
5721
5722 in_repo_conf = textwrap.dedent(
5723 """
5724 - job:
Tobias Henkelf02cf512017-07-21 22:55:34 +02005725 name: project-test1
5726
5727 - job:
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005728 name: project-test2
5729 semaphore: test-semaphore
5730
5731 - project:
5732 name: org/project
5733 tenant-one-gate:
5734 jobs:
5735 - project-test2
5736
5737 # the max value in dynamic layout must be ignored
5738 - semaphore:
5739 name: test-semaphore
5740 max: 2
5741 """)
5742
5743 in_repo_playbook = textwrap.dedent(
5744 """
5745 - hosts: all
5746 tasks: []
5747 """)
5748
5749 file_dict = {'.zuul.yaml': in_repo_conf,
5750 'playbooks/project-test2.yaml': in_repo_playbook}
5751 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5752 files=file_dict)
5753 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5754 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5755 B.setDependsOn(A, 1)
5756 C.setDependsOn(A, 1)
5757
5758 self.executor_server.hold_jobs_in_build = True
5759
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005760 A.addApproval('Code-Review', 2)
5761 B.addApproval('Code-Review', 2)
5762 C.addApproval('Code-Review', 2)
5763 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5764 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5765 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005766 self.waitUntilSettled()
5767
5768 # check that the layout in a queue item still has max value of 1
5769 # for test-semaphore
5770 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5771 queue = None
5772 for queue_candidate in pipeline.queues:
5773 if queue_candidate.name == 'org/project':
5774 queue = queue_candidate
5775 break
5776 queue_item = queue.queue[0]
James E. Blair29a24fd2017-10-02 15:04:56 -07005777 item_dynamic_layout = queue_item.layout
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005778 dynamic_test_semaphore = \
5779 item_dynamic_layout.semaphores.get('test-semaphore')
5780 self.assertEqual(dynamic_test_semaphore.max, 1)
5781
5782 # one build must be in queue, one semaphores acquired
5783 self.assertEqual(len(self.builds), 1)
5784 self.assertEqual(self.builds[0].name, 'project-test2')
5785 self.assertTrue('test-semaphore' in
5786 tenant.semaphore_handler.semaphores)
5787 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5788 'test-semaphore', [])), 1)
5789
5790 self.executor_server.release('project-test2')
5791 self.waitUntilSettled()
5792
5793 # change A must be merged
5794 self.assertEqual(A.data['status'], 'MERGED')
5795 self.assertEqual(A.reported, 2)
5796
5797 # send change-merged event as the gerrit mock doesn't send it
5798 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5799 self.waitUntilSettled()
5800
5801 # now that change A was merged, the new semaphore max must be effective
5802 tenant = self.sched.abide.tenants.get('tenant-one')
5803 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5804
5805 # two builds must be in queue, two semaphores acquired
5806 self.assertEqual(len(self.builds), 2)
5807 self.assertEqual(self.builds[0].name, 'project-test2')
5808 self.assertEqual(self.builds[1].name, 'project-test2')
5809 self.assertTrue('test-semaphore' in
5810 tenant.semaphore_handler.semaphores)
5811 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5812 'test-semaphore', [])), 2)
5813
5814 self.executor_server.release('project-test2')
5815 self.waitUntilSettled()
5816
5817 self.assertEqual(len(self.builds), 0)
5818 self.assertFalse('test-semaphore' in
5819 tenant.semaphore_handler.semaphores)
5820
5821 self.executor_server.hold_jobs_in_build = False
5822 self.executor_server.release()
5823
5824 self.waitUntilSettled()
5825 self.assertEqual(len(self.builds), 0)
5826
5827 self.assertEqual(A.reported, 2)
5828 self.assertEqual(B.reported, 2)
5829 self.assertEqual(C.reported, 2)
David Shrewsburyf6dc1762017-10-02 13:34:37 -04005830
5831
5832class TestSchedulerBranchMatcher(ZuulTestCase):
5833
5834 @simple_layout('layouts/matcher-test.yaml')
5835 def test_job_branch_ignored(self):
5836 '''
5837 Test that branch matching logic works.
5838
5839 The 'ignore-branch' job has a branch matcher that is supposed to
5840 match every branch except for the 'featureA' branch, so it should
5841 not be run on a change to that branch.
5842 '''
5843 self.create_branch('org/project', 'featureA')
5844 A = self.fake_gerrit.addFakeChange('org/project', 'featureA', 'A')
5845 A.addApproval('Code-Review', 2)
5846 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5847 self.waitUntilSettled()
5848 self.printHistory()
5849 self.assertEqual(self.getJobFromHistory('project-test1').result,
5850 'SUCCESS')
5851 self.assertJobNotInHistory('ignore-branch')
5852 self.assertEqual(A.data['status'], 'MERGED')
5853 self.assertEqual(A.reported, 2,
5854 "A should report start and success")
5855 self.assertIn('gate', A.messages[1],
5856 "A should transit gate")