Remove ZUUL_VOTING and add zuul.voting

Removing old ZUUL_ env variables which have been replaced with
Ansible variables.

Also, fix the tests which examined the voting flag since neither
actually worked.

Change-Id: I1c1dcfb8333bbe6984fdb198eda2d448989ae0ee
3 files changed