blob: 6efc43fdfb402c36afcfe815083b4a2eb09f0062 [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
Clint Byrum03454a52017-05-26 17:14:02 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Monty Taylorbc758832013-06-17 17:22:42 -040028import testtools
Monty Taylorb934c1a2017-06-16 19:31:47 -050029import urllib
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
Clint Byrumb9de8be2017-05-27 13:49:19 -070032from zuul.driver.gerrit import gerritreporter
James E. Blairb0fcae42012-07-17 11:12:10 -070033import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080034import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040035import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070036
Maru Newby3fe5f852015-01-13 04:22:14 +000037from tests.base import (
Paul Belanger0a21f0a2017-06-13 13:14:42 -040038 SSLZuulTestCase,
Maru Newby3fe5f852015-01-13 04:22:14 +000039 ZuulTestCase,
40 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070041 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000042)
James E. Blairb0fcae42012-07-17 11:12:10 -070043
James E. Blairb0fcae42012-07-17 11:12:10 -070044
Paul Belanger0a21f0a2017-06-13 13:14:42 -040045class TestSchedulerSSL(SSLZuulTestCase):
46 tenant_config_file = 'config/single-tenant/main.yaml'
47
48 def test_jobs_executed(self):
49 "Test that jobs are executed and a change is merged"
50
51 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +020052 A.addApproval('Code-Review', 2)
53 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Paul Belanger0a21f0a2017-06-13 13:14:42 -040054 self.waitUntilSettled()
55 self.assertEqual(self.getJobFromHistory('project-merge').result,
56 'SUCCESS')
57 self.assertEqual(self.getJobFromHistory('project-test1').result,
58 'SUCCESS')
59 self.assertEqual(self.getJobFromHistory('project-test2').result,
60 'SUCCESS')
61 self.assertEqual(A.data['status'], 'MERGED')
62 self.assertEqual(A.reported, 2)
63 self.assertEqual(self.getJobFromHistory('project-test1').node,
64 'label1')
James E. Blairfcbf95d2017-07-25 16:38:09 -070065 self.assertEqual(self.getJobFromHistory('project-test2').node,
66 'label1')
Paul Belanger0a21f0a2017-06-13 13:14:42 -040067
68
Clark Boylanb640e052014-04-03 16:41:46 -070069class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070070 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010071
Paul Belanger174a8272017-03-14 13:20:10 -040072 def test_jobs_executed(self):
73 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070074
James E. Blairb0fcae42012-07-17 11:12:10 -070075 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +020076 A.addApproval('Code-Review', 2)
77 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070078 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040079 self.assertEqual(self.getJobFromHistory('project-merge').result,
80 'SUCCESS')
81 self.assertEqual(self.getJobFromHistory('project-test1').result,
82 'SUCCESS')
83 self.assertEqual(self.getJobFromHistory('project-test2').result,
84 'SUCCESS')
85 self.assertEqual(A.data['status'], 'MERGED')
86 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070087 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -070088 'label1')
James E. Blairfcbf95d2017-07-25 16:38:09 -070089 self.assertEqual(self.getJobFromHistory('project-test2').node,
90 'label1')
James E. Blairb0fcae42012-07-17 11:12:10 -070091
James E. Blair80ac1582017-10-09 07:02:40 -070092 for stat in self.statsd.stats:
93 k, v = stat.decode('utf-8').split(':')
94 self.log.debug('stat %s:%s', k, v)
James E. Blair552b54f2016-07-22 13:55:32 -070095 # TODOv3(jeblair): we may want to report stats by tenant (also?).
Monty Taylorf1385042017-05-27 12:25:05 -050096 # Per-driver
97 self.assertReportedStat('zuul.event.gerrit.comment-added', value='1|c')
98 # Per-driver per-connection
99 self.assertReportedStat('zuul.event.gerrit.gerrit.comment-added',
100 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -0700101 self.assertReportedStat(
James E. Blair80ac1582017-10-09 07:02:40 -0700102 'zuul.tenant.tenant-one.pipeline.gate.current_changes',
103 value='1|g')
James E. Blair412e5582013-04-22 15:50:12 -0700104 self.assertReportedStat(
James E. Blair80ac1582017-10-09 07:02:40 -0700105 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
106 'org_project.master.job.project-merge.SUCCESS', kind='ms')
107 self.assertReportedStat(
108 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
109 'org_project.master.job.project-merge.SUCCESS', value='1|c')
110 self.assertReportedStat(
111 'zuul.tenant.tenant-one.pipeline.gate.resident_time', kind='ms')
112 self.assertReportedStat(
113 'zuul.tenant.tenant-one.pipeline.gate.total_changes', value='1|c')
114 self.assertReportedStat(
115 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
116 'org_project.master.resident_time', kind='ms')
117 self.assertReportedStat(
118 'zuul.tenant.tenant-one.pipeline.gate.project.review_example_com.'
119 'org_project.master.total_changes', value='1|c')
James E. Blairfaf81982017-10-10 15:42:26 -0700120 exec_key = 'zuul.executor.%s' % self.executor_server.hostname
121 self.assertReportedStat(exec_key + '.builds', value='1|c')
James E. Blair4f1731b2017-10-10 18:11:42 -0700122 self.assertReportedStat('zuul.nodepool.requested', value='1|c')
123 self.assertReportedStat('zuul.nodepool.requested.label.label1',
124 value='1|c')
125 self.assertReportedStat('zuul.nodepool.fulfilled.label.label1',
126 value='1|c')
127 self.assertReportedStat('zuul.nodepool.requested.size.1', value='1|c')
128 self.assertReportedStat('zuul.nodepool.fulfilled.size.1', value='1|c')
129 self.assertReportedStat('zuul.nodepool.current_requests', value='1|g')
James E. Blair412e5582013-04-22 15:50:12 -0700130
James E. Blair2ef29e92017-07-21 15:25:05 -0700131 for build in self.history:
132 self.assertTrue(build.parameters['zuul']['voting'])
James E. Blair5821bd92015-09-16 08:48:15 -0700133
James E. Blair3cb10702013-08-24 08:56:03 -0700134 def test_initial_pipeline_gauges(self):
135 "Test that each pipeline reported its length on start"
James E. Blair7da51b72016-07-25 15:29:43 -0700136 self.assertReportedStat('zuul.pipeline.gate.current_changes',
137 value='0|g')
138 self.assertReportedStat('zuul.pipeline.check.current_changes',
139 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -0700140
James E. Blair34776ee2016-08-25 13:53:54 -0700141 def test_job_branch(self):
142 "Test the correct variant of a job runs on a branch"
143 self.create_branch('org/project', 'stable')
144 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200145 A.addApproval('Code-Review', 2)
146 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair34776ee2016-08-25 13:53:54 -0700147 self.waitUntilSettled()
148 self.assertEqual(self.getJobFromHistory('project-test1').result,
149 'SUCCESS')
150 self.assertEqual(self.getJobFromHistory('project-test2').result,
151 'SUCCESS')
152 self.assertEqual(A.data['status'], 'MERGED')
153 self.assertEqual(A.reported, 2,
154 "A should report start and success")
155 self.assertIn('gate', A.messages[1],
156 "A should transit gate")
157 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -0700158 'label2')
James E. Blair34776ee2016-08-25 13:53:54 -0700159
James E. Blairb0fcae42012-07-17 11:12:10 -0700160 def test_parallel_changes(self):
161 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700162
Paul Belanger174a8272017-03-14 13:20:10 -0400163 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700164 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
165 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
166 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200167 A.addApproval('Code-Review', 2)
168 B.addApproval('Code-Review', 2)
169 C.addApproval('Code-Review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700170
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200171 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
172 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
173 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700174
175 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400176 self.assertEqual(len(self.builds), 1)
177 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700178 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700179
Paul Belanger174a8272017-03-14 13:20:10 -0400180 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700181 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400182 self.assertEqual(len(self.builds), 3)
183 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700184 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400185 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700186 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400187 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700188 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700189
Paul Belanger174a8272017-03-14 13:20:10 -0400190 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700191 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400192 self.assertEqual(len(self.builds), 5)
193 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700194 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400195 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700196 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700197
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400198 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700199 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400200 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700201 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700202
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400203 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700204 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700205
Paul Belanger174a8272017-03-14 13:20:10 -0400206 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700207 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400208 self.assertEqual(len(self.builds), 6)
209 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700210 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400211 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700212 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700213
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400214 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700215 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400216 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700217 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700218
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400219 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700220 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400221 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700222 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700223
Paul Belanger174a8272017-03-14 13:20:10 -0400224 self.executor_server.hold_jobs_in_build = False
225 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700226 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400227 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700228
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400229 self.assertEqual(len(self.history), 9)
230 self.assertEqual(A.data['status'], 'MERGED')
231 self.assertEqual(B.data['status'], 'MERGED')
232 self.assertEqual(C.data['status'], 'MERGED')
233 self.assertEqual(A.reported, 2)
234 self.assertEqual(B.reported, 2)
235 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700236
237 def test_failed_changes(self):
238 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400239 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700240
James E. Blairb02a3bb2012-07-30 17:49:55 -0700241 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
242 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200243 A.addApproval('Code-Review', 2)
244 B.addApproval('Code-Review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700245
Paul Belanger174a8272017-03-14 13:20:10 -0400246 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700247
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200248 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
249 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700250 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700251 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400252
Paul Belanger174a8272017-03-14 13:20:10 -0400253 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400254 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700255 # A/project-merge is complete
256 self.assertBuilds([
257 dict(name='project-test1', changes='1,1'),
258 dict(name='project-test2', changes='1,1'),
259 dict(name='project-merge', changes='1,1 2,1'),
260 ])
James E. Blaire2819012013-06-28 17:17:26 -0400261
Paul Belanger174a8272017-03-14 13:20:10 -0400262 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400263 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700264 # A/project-merge is complete
265 # B/project-merge is complete
266 self.assertBuilds([
267 dict(name='project-test1', changes='1,1'),
268 dict(name='project-test2', changes='1,1'),
269 dict(name='project-test1', changes='1,1 2,1'),
270 dict(name='project-test2', changes='1,1 2,1'),
271 ])
272
273 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400274 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700275 self.builds[0].release()
276 self.waitUntilSettled()
277
278 self.orderedRelease()
279 self.assertHistory([
280 dict(name='project-merge', result='SUCCESS', changes='1,1'),
281 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
282 dict(name='project-test1', result='FAILURE', changes='1,1'),
283 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
284 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
285 dict(name='project-test2', result='SUCCESS', changes='1,1'),
286 dict(name='project-merge', result='SUCCESS', changes='2,1'),
287 dict(name='project-test1', result='SUCCESS', changes='2,1'),
288 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700289 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700290
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400291 self.assertEqual(A.data['status'], 'NEW')
292 self.assertEqual(B.data['status'], 'MERGED')
293 self.assertEqual(A.reported, 2)
294 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700295
296 def test_independent_queues(self):
297 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700298
Paul Belanger174a8272017-03-14 13:20:10 -0400299 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900300 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700301 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
302 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200303 A.addApproval('Code-Review', 2)
304 B.addApproval('Code-Review', 2)
305 C.addApproval('Code-Review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700306
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200307 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800308 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700309
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200310 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800311 self.waitUntilSettled()
312
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200313 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700314 self.waitUntilSettled()
315
316 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700317 self.assertBuilds([
318 dict(name='project-merge', changes='1,1'),
319 dict(name='project-merge', changes='2,1'),
320 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700321
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700322 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700323 self.builds[0].release()
324 self.waitUntilSettled()
325 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700326 self.waitUntilSettled()
327 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400328 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700329 self.waitUntilSettled()
330
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700331 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700332 self.assertBuilds([
333 dict(name='project-test1', changes='1,1'),
334 dict(name='project-test2', changes='1,1'),
335 dict(name='project-test1', changes='2,1'),
336 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500337 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700338 dict(name='project-test1', changes='2,1 3,1'),
339 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800340 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700341 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700342
James E. Blair5f0d49e2016-08-19 09:36:50 -0700343 self.orderedRelease()
344 self.assertHistory([
345 dict(name='project-merge', result='SUCCESS', changes='1,1'),
346 dict(name='project-merge', result='SUCCESS', changes='2,1'),
347 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
348 dict(name='project-test1', result='SUCCESS', changes='1,1'),
349 dict(name='project-test2', result='SUCCESS', changes='1,1'),
350 dict(name='project-test1', result='SUCCESS', changes='2,1'),
351 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500352 dict(
353 name='project1-project2-integration',
354 result='SUCCESS',
355 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700356 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
357 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800358 dict(name='project1-project2-integration',
359 result='SUCCESS',
360 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700361 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700362
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400363 self.assertEqual(A.data['status'], 'MERGED')
364 self.assertEqual(B.data['status'], 'MERGED')
365 self.assertEqual(C.data['status'], 'MERGED')
366 self.assertEqual(A.reported, 2)
367 self.assertEqual(B.reported, 2)
368 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700369
370 def test_failed_change_at_head(self):
371 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700372
Paul Belanger174a8272017-03-14 13:20:10 -0400373 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700374 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
375 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
376 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200377 A.addApproval('Code-Review', 2)
378 B.addApproval('Code-Review', 2)
379 C.addApproval('Code-Review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700380
Paul Belanger174a8272017-03-14 13:20:10 -0400381 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700382
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200383 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
384 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
385 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700386
387 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700388
James E. Blairb536ecc2016-08-31 10:11:42 -0700389 self.assertBuilds([
390 dict(name='project-merge', changes='1,1'),
391 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700392
Paul Belanger174a8272017-03-14 13:20:10 -0400393 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700394 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400395 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700396 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400397 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700398 self.waitUntilSettled()
399
James E. Blairb536ecc2016-08-31 10:11:42 -0700400 self.assertBuilds([
401 dict(name='project-test1', changes='1,1'),
402 dict(name='project-test2', changes='1,1'),
403 dict(name='project-test1', changes='1,1 2,1'),
404 dict(name='project-test2', changes='1,1 2,1'),
405 dict(name='project-test1', changes='1,1 2,1 3,1'),
406 dict(name='project-test2', changes='1,1 2,1 3,1'),
407 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700408
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400409 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700410 self.waitUntilSettled()
411
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400412 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700413 self.assertBuilds([
414 dict(name='project-test2', changes='1,1'),
415 dict(name='project-merge', changes='2,1'),
416 ])
417 # Unordered history comparison because the aborts can finish
418 # in any order.
419 self.assertHistory([
420 dict(name='project-merge', result='SUCCESS',
421 changes='1,1'),
422 dict(name='project-merge', result='SUCCESS',
423 changes='1,1 2,1'),
424 dict(name='project-merge', result='SUCCESS',
425 changes='1,1 2,1 3,1'),
426 dict(name='project-test1', result='FAILURE',
427 changes='1,1'),
428 dict(name='project-test1', result='ABORTED',
429 changes='1,1 2,1'),
430 dict(name='project-test2', result='ABORTED',
431 changes='1,1 2,1'),
432 dict(name='project-test1', result='ABORTED',
433 changes='1,1 2,1 3,1'),
434 dict(name='project-test2', result='ABORTED',
435 changes='1,1 2,1 3,1'),
436 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700437
Paul Belanger174a8272017-03-14 13:20:10 -0400438 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700439 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400440 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700441 self.waitUntilSettled()
442 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700443
James E. Blairb536ecc2016-08-31 10:11:42 -0700444 self.assertBuilds([])
445 self.assertHistory([
446 dict(name='project-merge', result='SUCCESS',
447 changes='1,1'),
448 dict(name='project-merge', result='SUCCESS',
449 changes='1,1 2,1'),
450 dict(name='project-merge', result='SUCCESS',
451 changes='1,1 2,1 3,1'),
452 dict(name='project-test1', result='FAILURE',
453 changes='1,1'),
454 dict(name='project-test1', result='ABORTED',
455 changes='1,1 2,1'),
456 dict(name='project-test2', result='ABORTED',
457 changes='1,1 2,1'),
458 dict(name='project-test1', result='ABORTED',
459 changes='1,1 2,1 3,1'),
460 dict(name='project-test2', result='ABORTED',
461 changes='1,1 2,1 3,1'),
462 dict(name='project-merge', result='SUCCESS',
463 changes='2,1'),
464 dict(name='project-merge', result='SUCCESS',
465 changes='2,1 3,1'),
466 dict(name='project-test2', result='SUCCESS',
467 changes='1,1'),
468 dict(name='project-test1', result='SUCCESS',
469 changes='2,1'),
470 dict(name='project-test2', result='SUCCESS',
471 changes='2,1'),
472 dict(name='project-test1', result='SUCCESS',
473 changes='2,1 3,1'),
474 dict(name='project-test2', result='SUCCESS',
475 changes='2,1 3,1'),
476 ], ordered=False)
477
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400478 self.assertEqual(A.data['status'], 'NEW')
479 self.assertEqual(B.data['status'], 'MERGED')
480 self.assertEqual(C.data['status'], 'MERGED')
481 self.assertEqual(A.reported, 2)
482 self.assertEqual(B.reported, 2)
483 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700484
James E. Blair0aac4872013-08-23 14:02:38 -0700485 def test_failed_change_in_middle(self):
486 "Test a failed change in the middle of the queue"
487
Paul Belanger174a8272017-03-14 13:20:10 -0400488 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700489 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
490 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
491 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200492 A.addApproval('Code-Review', 2)
493 B.addApproval('Code-Review', 2)
494 C.addApproval('Code-Review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700495
Paul Belanger174a8272017-03-14 13:20:10 -0400496 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700497
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200498 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
499 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
500 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700501
502 self.waitUntilSettled()
503
Paul Belanger174a8272017-03-14 13:20:10 -0400504 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700505 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400506 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700507 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400508 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700509 self.waitUntilSettled()
510
511 self.assertEqual(len(self.builds), 6)
512 self.assertEqual(self.builds[0].name, 'project-test1')
513 self.assertEqual(self.builds[1].name, 'project-test2')
514 self.assertEqual(self.builds[2].name, 'project-test1')
515 self.assertEqual(self.builds[3].name, 'project-test2')
516 self.assertEqual(self.builds[4].name, 'project-test1')
517 self.assertEqual(self.builds[5].name, 'project-test2')
518
519 self.release(self.builds[2])
520 self.waitUntilSettled()
521
James E. Blair972e3c72013-08-29 12:04:55 -0700522 # project-test1 and project-test2 for A
523 # project-test2 for B
524 # project-merge for C (without B)
525 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700526 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
527
Paul Belanger174a8272017-03-14 13:20:10 -0400528 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700529 self.waitUntilSettled()
530
531 # project-test1 and project-test2 for A
532 # project-test2 for B
533 # project-test1 and project-test2 for C
534 self.assertEqual(len(self.builds), 5)
535
Paul Belanger2e2a0492016-10-30 18:33:37 -0400536 tenant = self.sched.abide.tenants.get('tenant-one')
537 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700538 builds = items[0].current_build_set.getBuilds()
539 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
540 self.assertEqual(self.countJobResults(builds, None), 2)
541 builds = items[1].current_build_set.getBuilds()
542 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
543 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
544 self.assertEqual(self.countJobResults(builds, None), 1)
545 builds = items[2].current_build_set.getBuilds()
546 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700547 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700548
Paul Belanger174a8272017-03-14 13:20:10 -0400549 self.executor_server.hold_jobs_in_build = False
550 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700551 self.waitUntilSettled()
552
553 self.assertEqual(len(self.builds), 0)
554 self.assertEqual(len(self.history), 12)
555 self.assertEqual(A.data['status'], 'MERGED')
556 self.assertEqual(B.data['status'], 'NEW')
557 self.assertEqual(C.data['status'], 'MERGED')
558 self.assertEqual(A.reported, 2)
559 self.assertEqual(B.reported, 2)
560 self.assertEqual(C.reported, 2)
561
James E. Blaird466dc42012-07-31 10:42:56 -0700562 def test_failed_change_at_head_with_queue(self):
563 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700564
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700565 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700566 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
567 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
568 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200569 A.addApproval('Code-Review', 2)
570 B.addApproval('Code-Review', 2)
571 C.addApproval('Code-Review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700572
Paul Belanger174a8272017-03-14 13:20:10 -0400573 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700574
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200575 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
576 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
577 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700578
579 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700580 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400581 self.assertEqual(len(self.builds), 0)
582 self.assertEqual(len(queue), 1)
Clint Byrumf322fe22017-05-10 20:53:12 -0700583 self.assertEqual(queue[0].name, b'executor:execute')
584 job_args = json.loads(queue[0].arguments.decode('utf8'))
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800585 self.assertEqual(job_args['job'], 'project-merge')
586 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700587
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700588 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700589 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700590 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700591 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700592 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700593 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700594 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700595
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400596 self.assertEqual(len(self.builds), 0)
597 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800598
599 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700600 json.loads(queue[0].arguments.decode('utf8'))['job'],
601 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800602 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700603 json.loads(queue[1].arguments.decode('utf8'))['job'],
604 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800605 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700606 json.loads(queue[2].arguments.decode('utf8'))['job'],
607 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800608 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700609 json.loads(queue[3].arguments.decode('utf8'))['job'],
610 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800611 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700612 json.loads(queue[4].arguments.decode('utf8'))['job'],
613 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800614 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700615 json.loads(queue[5].arguments.decode('utf8'))['job'],
616 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700617
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700618 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700619 self.waitUntilSettled()
620
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400621 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700622 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400623 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
624 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700625
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700626 self.gearman_server.hold_jobs_in_queue = False
627 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700628 self.waitUntilSettled()
629
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400630 self.assertEqual(len(self.builds), 0)
631 self.assertEqual(len(self.history), 11)
632 self.assertEqual(A.data['status'], 'NEW')
633 self.assertEqual(B.data['status'], 'MERGED')
634 self.assertEqual(C.data['status'], 'MERGED')
635 self.assertEqual(A.reported, 2)
636 self.assertEqual(B.reported, 2)
637 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700638
James E. Blairce8a2132016-05-19 15:21:52 -0700639 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400640 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700641 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200642 A.addApproval('Code-Review', 2)
643 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700644 self.waitUntilSettled()
645 time.sleep(2)
646
James E. Blairae0f23c2017-09-13 10:55:15 -0600647 data = json.loads(self.sched.formatStatusJSON('tenant-one'))
James E. Blairce8a2132016-05-19 15:21:52 -0700648 found_job = None
649 for pipeline in data['pipelines']:
650 if pipeline['name'] != 'gate':
651 continue
652 for queue in pipeline['change_queues']:
653 for head in queue['heads']:
654 for item in head:
655 for job in item['jobs']:
656 if job['name'] == 'project-merge':
657 found_job = job
658 break
659
660 self.assertIsNotNone(found_job)
661 if iteration == 1:
662 self.assertIsNotNone(found_job['estimated_time'])
663 self.assertIsNone(found_job['remaining_time'])
664 else:
665 self.assertIsNotNone(found_job['estimated_time'])
666 self.assertTrue(found_job['estimated_time'] >= 2)
667 self.assertIsNotNone(found_job['remaining_time'])
668
Paul Belanger174a8272017-03-14 13:20:10 -0400669 self.executor_server.hold_jobs_in_build = False
670 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700671 self.waitUntilSettled()
672
673 def test_time_database(self):
674 "Test the time database"
675
676 self._test_time_database(1)
677 self._test_time_database(2)
678
James E. Blairfef71632013-09-23 11:15:47 -0700679 def test_two_failed_changes_at_head(self):
680 "Test that changes are reparented correctly if 2 fail at head"
681
Paul Belanger174a8272017-03-14 13:20:10 -0400682 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700683 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
684 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
685 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200686 A.addApproval('Code-Review', 2)
687 B.addApproval('Code-Review', 2)
688 C.addApproval('Code-Review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700689
Paul Belanger174a8272017-03-14 13:20:10 -0400690 self.executor_server.failJob('project-test1', A)
691 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700692
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200693 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
694 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
695 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700696 self.waitUntilSettled()
697
Paul Belanger174a8272017-03-14 13:20:10 -0400698 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700699 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400700 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700701 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400702 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700703 self.waitUntilSettled()
704
705 self.assertEqual(len(self.builds), 6)
706 self.assertEqual(self.builds[0].name, 'project-test1')
707 self.assertEqual(self.builds[1].name, 'project-test2')
708 self.assertEqual(self.builds[2].name, 'project-test1')
709 self.assertEqual(self.builds[3].name, 'project-test2')
710 self.assertEqual(self.builds[4].name, 'project-test1')
711 self.assertEqual(self.builds[5].name, 'project-test2')
712
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400713 self.assertTrue(self.builds[0].hasChanges(A))
714 self.assertTrue(self.builds[2].hasChanges(A))
715 self.assertTrue(self.builds[2].hasChanges(B))
716 self.assertTrue(self.builds[4].hasChanges(A))
717 self.assertTrue(self.builds[4].hasChanges(B))
718 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700719
720 # Fail change B first
721 self.release(self.builds[2])
722 self.waitUntilSettled()
723
724 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400725 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700726 self.waitUntilSettled()
727
728 self.assertEqual(len(self.builds), 5)
729 self.assertEqual(self.builds[0].name, 'project-test1')
730 self.assertEqual(self.builds[1].name, 'project-test2')
731 self.assertEqual(self.builds[2].name, 'project-test2')
732 self.assertEqual(self.builds[3].name, 'project-test1')
733 self.assertEqual(self.builds[4].name, 'project-test2')
734
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400735 self.assertTrue(self.builds[1].hasChanges(A))
736 self.assertTrue(self.builds[2].hasChanges(A))
737 self.assertTrue(self.builds[2].hasChanges(B))
738 self.assertTrue(self.builds[4].hasChanges(A))
739 self.assertFalse(self.builds[4].hasChanges(B))
740 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700741
742 # Finish running all passing jobs for change A
743 self.release(self.builds[1])
744 self.waitUntilSettled()
745 # Fail and report change A
746 self.release(self.builds[0])
747 self.waitUntilSettled()
748
749 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400750 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700751 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400752 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700753 self.waitUntilSettled()
754
755 self.assertEqual(len(self.builds), 4)
756 self.assertEqual(self.builds[0].name, 'project-test1') # B
757 self.assertEqual(self.builds[1].name, 'project-test2') # B
758 self.assertEqual(self.builds[2].name, 'project-test1') # C
759 self.assertEqual(self.builds[3].name, 'project-test2') # C
760
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400761 self.assertFalse(self.builds[1].hasChanges(A))
762 self.assertTrue(self.builds[1].hasChanges(B))
763 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700764
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400765 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700766 # After A failed and B and C restarted, B should be back in
767 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400768 self.assertTrue(self.builds[2].hasChanges(B))
769 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700770
Paul Belanger174a8272017-03-14 13:20:10 -0400771 self.executor_server.hold_jobs_in_build = False
772 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700773 self.waitUntilSettled()
774
775 self.assertEqual(len(self.builds), 0)
776 self.assertEqual(len(self.history), 21)
777 self.assertEqual(A.data['status'], 'NEW')
778 self.assertEqual(B.data['status'], 'NEW')
779 self.assertEqual(C.data['status'], 'MERGED')
780 self.assertEqual(A.reported, 2)
781 self.assertEqual(B.reported, 2)
782 self.assertEqual(C.reported, 2)
783
James E. Blair8c803f82012-07-31 16:25:42 -0700784 def test_patch_order(self):
785 "Test that dependent patches are tested in the right order"
786 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
787 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
788 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200789 A.addApproval('Code-Review', 2)
790 B.addApproval('Code-Review', 2)
791 C.addApproval('Code-Review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700792
793 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
794 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
795 M2.setMerged()
796 M1.setMerged()
797
798 # C -> B -> A -> M1 -> M2
799 # M2 is here to make sure it is never queried. If it is, it
800 # means zuul is walking down the entire history of merged
801 # changes.
802
803 C.setDependsOn(B, 1)
804 B.setDependsOn(A, 1)
805 A.setDependsOn(M1, 1)
806 M1.setDependsOn(M2, 1)
807
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200808 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700809
810 self.waitUntilSettled()
811
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400812 self.assertEqual(A.data['status'], 'NEW')
813 self.assertEqual(B.data['status'], 'NEW')
814 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700815
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200816 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
817 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700818
819 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400820 self.assertEqual(M2.queried, 0)
821 self.assertEqual(A.data['status'], 'MERGED')
822 self.assertEqual(B.data['status'], 'MERGED')
823 self.assertEqual(C.data['status'], 'MERGED')
824 self.assertEqual(A.reported, 2)
825 self.assertEqual(B.reported, 2)
826 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700827
James E. Blair063672f2015-01-29 13:09:12 -0800828 def test_needed_changes_enqueue(self):
829 "Test that a needed change is enqueued ahead"
830 # A Given a git tree like this, if we enqueue
831 # / \ change C, we should walk up and down the tree
832 # B G and enqueue changes in the order ABCDEFG.
833 # /|\ This is also the order that you would get if
834 # *C E F you enqueued changes in the order ABCDEFG, so
835 # / the ordering is stable across re-enqueue events.
836 # D
837
838 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
839 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
840 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
841 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
842 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
843 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
844 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
845 B.setDependsOn(A, 1)
846 C.setDependsOn(B, 1)
847 D.setDependsOn(C, 1)
848 E.setDependsOn(B, 1)
849 F.setDependsOn(B, 1)
850 G.setDependsOn(A, 1)
851
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200852 A.addApproval('Code-Review', 2)
853 B.addApproval('Code-Review', 2)
854 C.addApproval('Code-Review', 2)
855 D.addApproval('Code-Review', 2)
856 E.addApproval('Code-Review', 2)
857 F.addApproval('Code-Review', 2)
858 G.addApproval('Code-Review', 2)
859 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800860
861 self.waitUntilSettled()
862
863 self.assertEqual(A.data['status'], 'NEW')
864 self.assertEqual(B.data['status'], 'NEW')
865 self.assertEqual(C.data['status'], 'NEW')
866 self.assertEqual(D.data['status'], 'NEW')
867 self.assertEqual(E.data['status'], 'NEW')
868 self.assertEqual(F.data['status'], 'NEW')
869 self.assertEqual(G.data['status'], 'NEW')
870
871 # We're about to add approvals to changes without adding the
872 # triggering events to Zuul, so that we can be sure that it is
873 # enqueing the changes based on dependencies, not because of
874 # triggering events. Since it will have the changes cached
875 # already (without approvals), we need to clear the cache
876 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400877 for connection in self.connections.connections.values():
James E. Blairb0a95ab2017-10-18 09:39:18 -0700878 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800879
Paul Belanger174a8272017-03-14 13:20:10 -0400880 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200881 A.addApproval('Approved', 1)
882 B.addApproval('Approved', 1)
883 D.addApproval('Approved', 1)
884 E.addApproval('Approved', 1)
885 F.addApproval('Approved', 1)
886 G.addApproval('Approved', 1)
887 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800888
889 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400890 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800891 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400892 self.executor_server.hold_jobs_in_build = False
893 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800894 self.waitUntilSettled()
895
896 self.assertEqual(A.data['status'], 'MERGED')
897 self.assertEqual(B.data['status'], 'MERGED')
898 self.assertEqual(C.data['status'], 'MERGED')
899 self.assertEqual(D.data['status'], 'MERGED')
900 self.assertEqual(E.data['status'], 'MERGED')
901 self.assertEqual(F.data['status'], 'MERGED')
902 self.assertEqual(G.data['status'], 'MERGED')
903 self.assertEqual(A.reported, 2)
904 self.assertEqual(B.reported, 2)
905 self.assertEqual(C.reported, 2)
906 self.assertEqual(D.reported, 2)
907 self.assertEqual(E.reported, 2)
908 self.assertEqual(F.reported, 2)
909 self.assertEqual(G.reported, 2)
910 self.assertEqual(self.history[6].changes,
911 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
912
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100913 def test_source_cache(self):
914 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400915 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700916
917 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
918 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
919 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200920 A.addApproval('Code-Review', 2)
921 B.addApproval('Code-Review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700922
923 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
924 M1.setMerged()
925
926 B.setDependsOn(A, 1)
927 A.setDependsOn(M1, 1)
928
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200929 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700930 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
931
932 self.waitUntilSettled()
933
934 for build in self.builds:
James E. Blaire675d682017-07-21 15:29:35 -0700935 if build.pipeline == 'check':
James E. Blair0e933c52013-07-11 10:18:52 -0700936 build.release()
937 self.waitUntilSettled()
938 for build in self.builds:
James E. Blaire675d682017-07-21 15:29:35 -0700939 if build.pipeline == 'check':
James E. Blair0e933c52013-07-11 10:18:52 -0700940 build.release()
941 self.waitUntilSettled()
942
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200943 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700944 self.waitUntilSettled()
945
Joshua Hesketh352264b2015-08-11 23:42:08 +1000946 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700947 # there should still be changes in the cache
James E. Blairb0a95ab2017-10-18 09:39:18 -0700948 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700949
Paul Belanger174a8272017-03-14 13:20:10 -0400950 self.executor_server.hold_jobs_in_build = False
951 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700952 self.waitUntilSettled()
953
954 self.assertEqual(A.data['status'], 'MERGED')
955 self.assertEqual(B.data['status'], 'MERGED')
956 self.assertEqual(A.queried, 2) # Initial and isMerged
957 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
958
James E. Blair8c803f82012-07-31 16:25:42 -0700959 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700960 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700961 # TODO: move to test_gerrit (this is a unit test!)
962 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400963 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700964 (trusted, project) = tenant.getProject('org/project')
965 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400966
967 # TODO(pabelanger): As we add more source / trigger APIs we should make
968 # it easier for users to create events for testing.
969 event = zuul.model.TriggerEvent()
970 event.trigger_name = 'gerrit'
971 event.change_number = '1'
972 event.patch_number = '2'
973
974 a = source.getChange(event)
975 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700976 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700977
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200978 A.addApproval('Code-Review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400979 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700980 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700981
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200982 A.addApproval('Approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400983 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700984 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700985
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700986 def test_project_merge_conflict(self):
987 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700988
989 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700990 A = self.fake_gerrit.addFakeChange('org/project',
991 'master', 'A',
992 files={'conflict': 'foo'})
993 B = self.fake_gerrit.addFakeChange('org/project',
994 'master', 'B',
995 files={'conflict': 'bar'})
996 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -0700997 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +0200998 A.addApproval('Code-Review', 2)
999 B.addApproval('Code-Review', 2)
1000 C.addApproval('Code-Review', 2)
1001 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1002 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1003 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -07001004 self.waitUntilSettled()
1005
James E. Blair6736beb2013-07-11 15:18:15 -07001006 self.assertEqual(A.reported, 1)
James E. Blair6736beb2013-07-11 15:18:15 -07001007 self.assertEqual(C.reported, 1)
1008
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001009 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -07001010 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001011 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -07001012 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001013 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -07001014 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -07001015
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001016 self.gearman_server.hold_jobs_in_queue = False
1017 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -07001018 self.waitUntilSettled()
1019
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001020 self.assertEqual(A.data['status'], 'MERGED')
1021 self.assertEqual(B.data['status'], 'NEW')
1022 self.assertEqual(C.data['status'], 'MERGED')
1023 self.assertEqual(A.reported, 2)
Tobias Henkel9842bd72017-05-16 13:40:03 +02001024 self.assertIn('Merge Failed', B.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001025 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001026
1027 self.assertHistory([
1028 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1029 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1030 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1031 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
1032 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
1033 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
1034 ], ordered=False)
1035
1036 def test_delayed_merge_conflict(self):
1037 "Test that delayed check merge conflicts are handled properly"
1038
1039 # Hold jobs in the gearman queue so that we can test whether
James E. Blair1960d682017-04-28 15:44:14 -07001040 # the executor sucesfully merges a change based on an old
1041 # repo state (frozen by the scheduler) which would otherwise
1042 # conflict.
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001043 self.gearman_server.hold_jobs_in_queue = True
1044 A = self.fake_gerrit.addFakeChange('org/project',
1045 'master', 'A',
1046 files={'conflict': 'foo'})
1047 B = self.fake_gerrit.addFakeChange('org/project',
1048 'master', 'B',
1049 files={'conflict': 'bar'})
1050 C = self.fake_gerrit.addFakeChange('org/project',
1051 'master', 'C')
1052 C.setDependsOn(B, 1)
1053
1054 # A enters the gate queue; B and C enter the check queue
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001055 A.addApproval('Code-Review', 2)
1056 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001057 self.waitUntilSettled()
1058 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
James E. Blair8d144dc2017-05-05 10:13:45 -07001059 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001060 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1061 self.waitUntilSettled()
1062
1063 self.assertEqual(A.reported, 1)
1064 self.assertEqual(B.reported, 0) # Check does not report start
1065 self.assertEqual(C.reported, 0) # Check does not report start
1066
1067 # A merges while B and C are queued in check
1068 # Release A project-merge
1069 queue = self.gearman_server.getQueue()
1070 self.release(queue[0])
1071 self.waitUntilSettled()
1072
1073 # Release A project-test*
1074 # gate has higher precedence, so A's test jobs are added in
1075 # front of the merge jobs for B and C
1076 queue = self.gearman_server.getQueue()
1077 self.release(queue[0])
1078 self.release(queue[1])
1079 self.waitUntilSettled()
1080
1081 self.assertEqual(A.data['status'], 'MERGED')
1082 self.assertEqual(B.data['status'], 'NEW')
1083 self.assertEqual(C.data['status'], 'NEW')
1084 self.assertEqual(A.reported, 2)
1085 self.assertEqual(B.reported, 0)
1086 self.assertEqual(C.reported, 0)
1087 self.assertHistory([
1088 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1089 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1090 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1091 ], ordered=False)
1092
1093 # B and C report merge conflicts
1094 # Release B project-merge
1095 queue = self.gearman_server.getQueue()
1096 self.release(queue[0])
1097 self.waitUntilSettled()
1098
1099 # Release C
1100 self.gearman_server.hold_jobs_in_queue = False
1101 self.gearman_server.release()
1102 self.waitUntilSettled()
1103
1104 self.assertEqual(A.data['status'], 'MERGED')
1105 self.assertEqual(B.data['status'], 'NEW')
1106 self.assertEqual(C.data['status'], 'NEW')
1107 self.assertEqual(A.reported, 2)
1108 self.assertEqual(B.reported, 1)
1109 self.assertEqual(C.reported, 1)
1110
1111 self.assertHistory([
1112 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1113 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1114 dict(name='project-test2', result='SUCCESS', changes='1,1'),
James E. Blair1960d682017-04-28 15:44:14 -07001115 dict(name='project-merge', result='SUCCESS', changes='2,1'),
1116 dict(name='project-test1', result='SUCCESS', changes='2,1'),
1117 dict(name='project-test2', result='SUCCESS', changes='2,1'),
1118 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
1119 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
1120 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001121 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001122
James E. Blairdaabed22012-08-15 15:38:57 -07001123 def test_post(self):
1124 "Test that post jobs run"
James E. Blair289f5932017-07-27 15:02:29 -07001125 p = "review.example.com/org/project"
1126 upstream = self.getUpstreamRepos([p])
1127 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1128 A.setMerged()
1129 A_commit = str(upstream[p].commit('master'))
1130 self.log.debug("A commit: %s" % A_commit)
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001131
Zhongyue Luo5d556072012-09-21 02:00:47 +09001132 e = {
1133 "type": "ref-updated",
1134 "submitter": {
1135 "name": "User Name",
1136 },
1137 "refUpdate": {
1138 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
James E. Blair289f5932017-07-27 15:02:29 -07001139 "newRev": A_commit,
Zhongyue Luo5d556072012-09-21 02:00:47 +09001140 "refName": "master",
1141 "project": "org/project",
1142 }
1143 }
James E. Blairdaabed22012-08-15 15:38:57 -07001144 self.fake_gerrit.addEvent(e)
1145 self.waitUntilSettled()
1146
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001147 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001148 self.assertEqual(len(self.history), 1)
1149 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001150
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001151 def test_post_ignore_deletes(self):
1152 "Test that deleting refs does not trigger post jobs"
1153
1154 e = {
1155 "type": "ref-updated",
1156 "submitter": {
1157 "name": "User Name",
1158 },
1159 "refUpdate": {
1160 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1161 "newRev": "0000000000000000000000000000000000000000",
1162 "refName": "master",
1163 "project": "org/project",
1164 }
1165 }
1166 self.fake_gerrit.addEvent(e)
1167 self.waitUntilSettled()
1168
1169 job_names = [x.name for x in self.history]
1170 self.assertEqual(len(self.history), 0)
1171 self.assertNotIn('project-post', job_names)
1172
James E. Blaircc324192017-04-19 14:36:08 -07001173 @simple_layout('layouts/dont-ignore-ref-deletes.yaml')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001174 def test_post_ignore_deletes_negative(self):
1175 "Test that deleting refs does trigger post jobs"
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001176 e = {
1177 "type": "ref-updated",
1178 "submitter": {
1179 "name": "User Name",
1180 },
1181 "refUpdate": {
1182 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1183 "newRev": "0000000000000000000000000000000000000000",
James E. Blair289f5932017-07-27 15:02:29 -07001184 "refName": "testbranch",
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001185 "project": "org/project",
1186 }
1187 }
1188 self.fake_gerrit.addEvent(e)
1189 self.waitUntilSettled()
1190
1191 job_names = [x.name for x in self.history]
1192 self.assertEqual(len(self.history), 1)
1193 self.assertIn('project-post', job_names)
1194
James E. Blairec056492016-07-22 09:45:56 -07001195 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001196 def test_build_configuration_branch_interaction(self):
1197 "Test that switching between branches works"
1198 self.test_build_configuration()
1199 self.test_build_configuration_branch()
1200 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001201 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001202 repo = git.Repo(path)
1203 repo.heads.master.commit = repo.commit('init')
1204 self.test_build_configuration()
1205
James E. Blairdb93b302017-07-19 15:33:11 -07001206 def test_dependent_changes_rebase(self):
1207 # Test that no errors occur when we walk a dependency tree
1208 # with an unused leaf node due to a rebase.
1209 # Start by constructing: C -> B -> A
1210 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1211 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1212 B.setDependsOn(A, 1)
1213
1214 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1215 C.setDependsOn(B, 1)
1216
1217 # Then rebase to form: D -> C -> A
1218 C.addPatchset() # C,2
1219 C.setDependsOn(A, 1)
1220
1221 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1222 D.setDependsOn(C, 2)
1223
1224 # Walk the entire tree
1225 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1226 self.waitUntilSettled()
1227 self.assertEqual(len(self.history), 3)
1228
1229 # Verify that walking just part of the tree still works
1230 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
1231 self.waitUntilSettled()
1232 self.assertEqual(len(self.history), 6)
1233
James E. Blaircaec0c52012-08-22 14:52:22 -07001234 def test_dependent_changes_dequeue(self):
1235 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001236
James E. Blaircaec0c52012-08-22 14:52:22 -07001237 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1238 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1239 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001240 A.addApproval('Code-Review', 2)
1241 B.addApproval('Code-Review', 2)
1242 C.addApproval('Code-Review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001243
1244 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1245 M1.setMerged()
1246
1247 # C -> B -> A -> M1
1248
1249 C.setDependsOn(B, 1)
1250 B.setDependsOn(A, 1)
1251 A.setDependsOn(M1, 1)
1252
Paul Belanger174a8272017-03-14 13:20:10 -04001253 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001254
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001255 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1256 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1257 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001258
1259 self.waitUntilSettled()
1260
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001261 self.assertEqual(A.data['status'], 'NEW')
1262 self.assertEqual(A.reported, 2)
1263 self.assertEqual(B.data['status'], 'NEW')
1264 self.assertEqual(B.reported, 2)
1265 self.assertEqual(C.data['status'], 'NEW')
James E. Blair0d3e83b2017-06-05 13:51:57 -07001266 self.assertIn('This change depends on a change that failed to merge.',
1267 C.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001268 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001269
James E. Blair972e3c72013-08-29 12:04:55 -07001270 def test_failing_dependent_changes(self):
1271 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001272 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001273 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1274 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1275 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1276 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1277 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001278 A.addApproval('Code-Review', 2)
1279 B.addApproval('Code-Review', 2)
1280 C.addApproval('Code-Review', 2)
1281 D.addApproval('Code-Review', 2)
1282 E.addApproval('Code-Review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001283
1284 # E, D -> C -> B, A
1285
1286 D.setDependsOn(C, 1)
1287 C.setDependsOn(B, 1)
1288
Paul Belanger174a8272017-03-14 13:20:10 -04001289 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001290
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001291 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1292 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
1293 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1294 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1295 self.fake_gerrit.addEvent(E.addApproval('Approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001296
1297 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001298 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001299 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001300 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001301 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001302 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001303 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001304 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001305 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001306 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001307 self.waitUntilSettled()
1308
Paul Belanger174a8272017-03-14 13:20:10 -04001309 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001310 for build in self.builds:
James E. Blaire3db2952017-07-21 15:03:36 -07001311 if build.parameters['zuul']['change'] != '1':
James E. Blair972e3c72013-08-29 12:04:55 -07001312 build.release()
1313 self.waitUntilSettled()
1314
Paul Belanger174a8272017-03-14 13:20:10 -04001315 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001316 self.waitUntilSettled()
1317
1318 self.assertEqual(A.data['status'], 'MERGED')
1319 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001320 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001321 self.assertEqual(B.data['status'], 'NEW')
1322 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001323 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001324 self.assertEqual(C.data['status'], 'NEW')
1325 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001326 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001327 self.assertEqual(D.data['status'], 'NEW')
1328 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001329 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001330 self.assertEqual(E.data['status'], 'MERGED')
1331 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001332 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001333 self.assertEqual(len(self.history), 18)
1334
James E. Blairec590122012-08-22 15:19:31 -07001335 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001336 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001337 # If it's dequeued more than once, we should see extra
1338 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001339
Paul Belanger174a8272017-03-14 13:20:10 -04001340 self.executor_server.hold_jobs_in_build = True
James E. Blair6df67132017-04-19 13:53:20 -07001341 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1342 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1343 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001344 A.addApproval('Code-Review', 2)
1345 B.addApproval('Code-Review', 2)
1346 C.addApproval('Code-Review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001347
Paul Belanger174a8272017-03-14 13:20:10 -04001348 self.executor_server.failJob('project-test1', A)
1349 self.executor_server.failJob('project-test2', A)
James E. Blairec590122012-08-22 15:19:31 -07001350
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001351 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1352 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1353 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001354
1355 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001356
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001357 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001358 self.assertEqual(self.builds[0].name, 'project-merge')
1359 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001360
Paul Belanger174a8272017-03-14 13:20:10 -04001361 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001362 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001363 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001364 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001365 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001366 self.waitUntilSettled()
1367
James E. Blair6df67132017-04-19 13:53:20 -07001368 self.assertEqual(len(self.builds), 6)
Paul Belanger58bf6912016-11-11 19:36:01 -05001369 self.assertEqual(self.builds[0].name, 'project-test1')
1370 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair6df67132017-04-19 13:53:20 -07001371 self.assertEqual(self.builds[2].name, 'project-test1')
1372 self.assertEqual(self.builds[3].name, 'project-test2')
1373 self.assertEqual(self.builds[4].name, 'project-test1')
1374 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blairec590122012-08-22 15:19:31 -07001375
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001376 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001377 self.waitUntilSettled()
1378
James E. Blair6df67132017-04-19 13:53:20 -07001379 self.assertEqual(len(self.builds), 2) # test2, merge for B
1380 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
James E. Blairec590122012-08-22 15:19:31 -07001381
Paul Belanger174a8272017-03-14 13:20:10 -04001382 self.executor_server.hold_jobs_in_build = False
1383 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001384 self.waitUntilSettled()
1385
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001386 self.assertEqual(len(self.builds), 0)
James E. Blair6df67132017-04-19 13:53:20 -07001387 self.assertEqual(len(self.history), 15)
James E. Blaircaec0c52012-08-22 14:52:22 -07001388
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001389 self.assertEqual(A.data['status'], 'NEW')
1390 self.assertEqual(B.data['status'], 'MERGED')
1391 self.assertEqual(C.data['status'], 'MERGED')
1392 self.assertEqual(A.reported, 2)
1393 self.assertEqual(B.reported, 2)
1394 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001395
James E. Blaircc020532017-04-19 13:04:44 -07001396 @simple_layout('layouts/nonvoting-job.yaml')
James E. Blair4ec821f2012-08-23 15:28:28 -07001397 def test_nonvoting_job(self):
1398 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001399
James E. Blair4ec821f2012-08-23 15:28:28 -07001400 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1401 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001402 A.addApproval('Code-Review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001403 self.executor_server.failJob('nonvoting-project-test2', A)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001404 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001405
1406 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001407
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001408 self.assertEqual(A.data['status'], 'MERGED')
1409 self.assertEqual(A.reported, 2)
1410 self.assertEqual(
1411 self.getJobFromHistory('nonvoting-project-merge').result,
1412 'SUCCESS')
1413 self.assertEqual(
1414 self.getJobFromHistory('nonvoting-project-test1').result,
1415 'SUCCESS')
1416 self.assertEqual(
1417 self.getJobFromHistory('nonvoting-project-test2').result,
1418 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001419
James E. Blair2ef29e92017-07-21 15:25:05 -07001420 self.assertTrue(self.getJobFromHistory('nonvoting-project-merge').
1421 parameters['zuul']['voting'])
1422 self.assertTrue(self.getJobFromHistory('nonvoting-project-test1').
1423 parameters['zuul']['voting'])
1424 self.assertFalse(self.getJobFromHistory('nonvoting-project-test2').
1425 parameters['zuul']['voting'])
James E. Blair5821bd92015-09-16 08:48:15 -07001426
James E. Blaire0487072012-08-29 17:38:31 -07001427 def test_check_queue_success(self):
1428 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001429
James E. Blaire0487072012-08-29 17:38:31 -07001430 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1431 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1432
1433 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001434
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001435 self.assertEqual(A.data['status'], 'NEW')
1436 self.assertEqual(A.reported, 1)
1437 self.assertEqual(self.getJobFromHistory('project-merge').result,
1438 'SUCCESS')
1439 self.assertEqual(self.getJobFromHistory('project-test1').result,
1440 'SUCCESS')
1441 self.assertEqual(self.getJobFromHistory('project-test2').result,
1442 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001443
1444 def test_check_queue_failure(self):
1445 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001446
James E. Blaire0487072012-08-29 17:38:31 -07001447 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001448 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001449 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1450
1451 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001452
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001453 self.assertEqual(A.data['status'], 'NEW')
1454 self.assertEqual(A.reported, 1)
1455 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001456 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001457 self.assertEqual(self.getJobFromHistory('project-test1').result,
1458 'SUCCESS')
1459 self.assertEqual(self.getJobFromHistory('project-test2').result,
1460 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001461
David Shrewsburyffab07a2017-07-24 12:45:07 -04001462 @simple_layout('layouts/autohold.yaml')
1463 def test_autohold(self):
1464 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1465
1466 client = zuul.rpcclient.RPCClient('127.0.0.1',
1467 self.gearman_server.port)
1468 self.addCleanup(client.shutdown)
David Shrewsbury36b2adf2017-07-31 15:40:13 -04001469 r = client.autohold('tenant-one', 'org/project', 'project-test2',
1470 "reason text", 1)
David Shrewsburyffab07a2017-07-24 12:45:07 -04001471 self.assertTrue(r)
1472
1473 self.executor_server.failJob('project-test2', A)
1474 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1475
1476 self.waitUntilSettled()
1477
1478 self.assertEqual(A.data['status'], 'NEW')
1479 self.assertEqual(A.reported, 1)
1480 self.assertEqual(self.getJobFromHistory('project-test2').result,
1481 'FAILURE')
1482
1483 # Check nodepool for a held node
1484 held_node = None
1485 for node in self.fake_nodepool.getNodes():
1486 if node['state'] == zuul.model.STATE_HOLD:
1487 held_node = node
1488 break
1489 self.assertIsNotNone(held_node)
1490
1491 # Validate node has recorded the failed job
1492 self.assertEqual(
1493 held_node['hold_job'],
1494 " ".join(['tenant-one',
1495 'review.example.com/org/project',
1496 'project-test2'])
1497 )
David Shrewsburyf9af9df2017-08-01 15:19:26 -04001498 self.assertEqual(held_node['comment'], "reason text")
David Shrewsburyffab07a2017-07-24 12:45:07 -04001499
1500 # Another failed change should not hold any more nodes
1501 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1502 self.executor_server.failJob('project-test2', B)
1503 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1504 self.waitUntilSettled()
1505 self.assertEqual(B.data['status'], 'NEW')
1506 self.assertEqual(B.reported, 1)
1507 self.assertEqual(self.getJobFromHistory('project-test2').result,
1508 'FAILURE')
1509
1510 held_nodes = 0
1511 for node in self.fake_nodepool.getNodes():
1512 if node['state'] == zuul.model.STATE_HOLD:
1513 held_nodes += 1
1514 self.assertEqual(held_nodes, 1)
1515
David Shrewsburyc4676132017-10-16 12:41:57 -04001516 @simple_layout('layouts/autohold.yaml')
1517 def test_autohold_list(self):
1518 client = zuul.rpcclient.RPCClient('127.0.0.1',
1519 self.gearman_server.port)
1520 self.addCleanup(client.shutdown)
1521
1522 r = client.autohold('tenant-one', 'org/project', 'project-test2',
1523 "reason text", 1)
1524 self.assertTrue(r)
1525
1526 autohold_requests = client.autohold_list()
1527 self.assertNotEqual({}, autohold_requests)
1528 self.assertEqual(1, len(autohold_requests.keys()))
1529
1530 # The single dict key should be a CSV string value
1531 key = list(autohold_requests.keys())[0]
1532 tenant, project, job = key.split(',')
1533
1534 self.assertEqual('tenant-one', tenant)
1535 self.assertIn('org/project', project)
1536 self.assertEqual('project-test2', job)
1537
1538 # Note: the value is converted from set to list by json.
1539 self.assertEqual([1, "reason text"], autohold_requests[key])
1540
James E. Blair7cb84542017-04-19 13:35:05 -07001541 @simple_layout('layouts/three-projects.yaml')
James E. Blair127bc182012-08-28 15:55:15 -07001542 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001543 # This particular test does a large amount of merges and needs a little
1544 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001545 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001546 "test that dependent changes behind dequeued changes work"
1547 # This complicated test is a reproduction of a real life bug
1548 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001549
Paul Belanger174a8272017-03-14 13:20:10 -04001550 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001551 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1552 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1553 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1554 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1555 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1556 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1557 D.setDependsOn(C, 1)
1558 E.setDependsOn(D, 1)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001559 A.addApproval('Code-Review', 2)
1560 B.addApproval('Code-Review', 2)
1561 C.addApproval('Code-Review', 2)
1562 D.addApproval('Code-Review', 2)
1563 E.addApproval('Code-Review', 2)
1564 F.addApproval('Code-Review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001565
1566 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001567
1568 # Change object re-use in the gerrit trigger is hidden if
1569 # changes are added in quick succession; waiting makes it more
1570 # like real life.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001571 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001572 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001573 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001574 self.waitUntilSettled()
1575
Paul Belanger174a8272017-03-14 13:20:10 -04001576 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001577 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001578 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001579 self.waitUntilSettled()
1580
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001581 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001582 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001583 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001584 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001585 self.fake_gerrit.addEvent(E.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001586 self.waitUntilSettled()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001587 self.fake_gerrit.addEvent(F.addApproval('Approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001588 self.waitUntilSettled()
1589
Paul Belanger174a8272017-03-14 13:20:10 -04001590 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001591 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001592 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001593 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001594 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001595 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001596 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001597 self.waitUntilSettled()
1598
1599 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001600
1601 # Grab pointers to the jobs we want to release before
1602 # releasing any, because list indexes may change as
1603 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001604 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001605 a.release()
1606 b.release()
1607 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001608 self.waitUntilSettled()
1609
Paul Belanger174a8272017-03-14 13:20:10 -04001610 self.executor_server.hold_jobs_in_build = False
1611 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001612 self.waitUntilSettled()
1613
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001614 self.assertEqual(A.data['status'], 'NEW')
1615 self.assertEqual(B.data['status'], 'MERGED')
1616 self.assertEqual(C.data['status'], 'MERGED')
1617 self.assertEqual(D.data['status'], 'MERGED')
1618 self.assertEqual(E.data['status'], 'MERGED')
1619 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001620
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001621 self.assertEqual(A.reported, 2)
1622 self.assertEqual(B.reported, 2)
1623 self.assertEqual(C.reported, 2)
1624 self.assertEqual(D.reported, 2)
1625 self.assertEqual(E.reported, 2)
1626 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001627
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001628 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1629 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001630
1631 def test_merger_repack(self):
1632 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001633
James E. Blair05fed602012-09-07 12:45:24 -07001634 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001635 A.addApproval('Code-Review', 2)
1636 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001637 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001638 self.assertEqual(self.getJobFromHistory('project-merge').result,
1639 'SUCCESS')
1640 self.assertEqual(self.getJobFromHistory('project-test1').result,
1641 'SUCCESS')
1642 self.assertEqual(self.getJobFromHistory('project-test2').result,
1643 'SUCCESS')
1644 self.assertEqual(A.data['status'], 'MERGED')
1645 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001646 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001647 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001648
James E. Blair2a535672017-04-27 12:03:15 -07001649 path = os.path.join(self.merger_src_root, "review.example.com",
1650 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001651 if os.path.exists(path):
1652 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001653 path = os.path.join(self.executor_src_root, "review.example.com",
1654 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001655 if os.path.exists(path):
1656 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001657
1658 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001659 A.addApproval('Code-Review', 2)
1660 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001661 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001662 self.assertEqual(self.getJobFromHistory('project-merge').result,
1663 'SUCCESS')
1664 self.assertEqual(self.getJobFromHistory('project-test1').result,
1665 'SUCCESS')
1666 self.assertEqual(self.getJobFromHistory('project-test2').result,
1667 'SUCCESS')
1668 self.assertEqual(A.data['status'], 'MERGED')
1669 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001670
James E. Blair4886f282012-11-15 09:27:33 -08001671 def test_merger_repack_large_change(self):
1672 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001673 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001674 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001675 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6df67132017-04-19 13:53:20 -07001676 trusted, project = tenant.getProject('org/project')
James E. Blair0ffa0102017-03-30 13:11:33 -07001677 url = self.fake_gerrit.getGitUrl(project)
James E. Blair8d144dc2017-05-05 10:13:45 -07001678 self.executor_server.merger._addProject('review.example.com',
James E. Blair197e8202017-06-09 12:54:28 -07001679 'org/project', url, None)
James E. Blair6df67132017-04-19 13:53:20 -07001680 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair4886f282012-11-15 09:27:33 -08001681 A.addPatchset(large=True)
James E. Blair2a535672017-04-27 12:03:15 -07001682 # TODOv3(jeblair): add hostname to upstream root
1683 path = os.path.join(self.upstream_root, 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001684 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001685 path = os.path.join(self.merger_src_root, 'review.example.com',
1686 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001687 if os.path.exists(path):
1688 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001689 path = os.path.join(self.executor_src_root, 'review.example.com',
1690 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001691 if os.path.exists(path):
1692 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001693
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001694 A.addApproval('Code-Review', 2)
1695 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001696 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001697 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001698 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001699 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001700 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001701 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001702 'SUCCESS')
1703 self.assertEqual(A.data['status'], 'MERGED')
1704 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001705
James E. Blair2fa50962013-01-30 21:50:41 -08001706 def test_new_patchset_dequeues_old(self):
1707 "Test that a new patchset causes the old to be dequeued"
1708 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001709 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001710 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1711 M.setMerged()
1712
1713 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1714 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1715 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1716 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001717 A.addApproval('Code-Review', 2)
1718 B.addApproval('Code-Review', 2)
1719 C.addApproval('Code-Review', 2)
1720 D.addApproval('Code-Review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001721
1722 C.setDependsOn(B, 1)
1723 B.setDependsOn(A, 1)
1724 A.setDependsOn(M, 1)
1725
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001726 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1727 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1728 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1729 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001730 self.waitUntilSettled()
1731
1732 B.addPatchset()
1733 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1734 self.waitUntilSettled()
1735
Paul Belanger174a8272017-03-14 13:20:10 -04001736 self.executor_server.hold_jobs_in_build = False
1737 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001738 self.waitUntilSettled()
1739
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001740 self.assertEqual(A.data['status'], 'MERGED')
1741 self.assertEqual(A.reported, 2)
1742 self.assertEqual(B.data['status'], 'NEW')
1743 self.assertEqual(B.reported, 2)
1744 self.assertEqual(C.data['status'], 'NEW')
1745 self.assertEqual(C.reported, 2)
1746 self.assertEqual(D.data['status'], 'MERGED')
1747 self.assertEqual(D.reported, 2)
1748 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001749
James E. Blairba437362015-02-07 11:41:52 -08001750 def test_new_patchset_check(self):
1751 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001752
Paul Belanger174a8272017-03-14 13:20:10 -04001753 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001754
1755 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001756 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001757 tenant = self.sched.abide.tenants.get('tenant-one')
1758 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001759
1760 # Add two git-dependent changes
1761 B.setDependsOn(A, 1)
1762 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1763 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001764 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1765 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001766
1767 # A live item, and a non-live/live pair
1768 items = check_pipeline.getAllItems()
1769 self.assertEqual(len(items), 3)
1770
1771 self.assertEqual(items[0].change.number, '1')
1772 self.assertEqual(items[0].change.patchset, '1')
1773 self.assertFalse(items[0].live)
1774
1775 self.assertEqual(items[1].change.number, '2')
1776 self.assertEqual(items[1].change.patchset, '1')
1777 self.assertTrue(items[1].live)
1778
1779 self.assertEqual(items[2].change.number, '1')
1780 self.assertEqual(items[2].change.patchset, '1')
1781 self.assertTrue(items[2].live)
1782
1783 # Add a new patchset to A
1784 A.addPatchset()
1785 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1786 self.waitUntilSettled()
1787
1788 # The live copy of A,1 should be gone, but the non-live and B
1789 # should continue, and we should have a new A,2
1790 items = check_pipeline.getAllItems()
1791 self.assertEqual(len(items), 3)
1792
1793 self.assertEqual(items[0].change.number, '1')
1794 self.assertEqual(items[0].change.patchset, '1')
1795 self.assertFalse(items[0].live)
1796
1797 self.assertEqual(items[1].change.number, '2')
1798 self.assertEqual(items[1].change.patchset, '1')
1799 self.assertTrue(items[1].live)
1800
1801 self.assertEqual(items[2].change.number, '1')
1802 self.assertEqual(items[2].change.patchset, '2')
1803 self.assertTrue(items[2].live)
1804
1805 # Add a new patchset to B
1806 B.addPatchset()
1807 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1808 self.waitUntilSettled()
1809
1810 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1811 # but we should have a new B,2 (still based on A,1)
1812 items = check_pipeline.getAllItems()
1813 self.assertEqual(len(items), 3)
1814
1815 self.assertEqual(items[0].change.number, '1')
1816 self.assertEqual(items[0].change.patchset, '2')
1817 self.assertTrue(items[0].live)
1818
1819 self.assertEqual(items[1].change.number, '1')
1820 self.assertEqual(items[1].change.patchset, '1')
1821 self.assertFalse(items[1].live)
1822
1823 self.assertEqual(items[2].change.number, '2')
1824 self.assertEqual(items[2].change.patchset, '2')
1825 self.assertTrue(items[2].live)
1826
1827 self.builds[0].release()
1828 self.waitUntilSettled()
1829 self.builds[0].release()
1830 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001831 self.executor_server.hold_jobs_in_build = False
1832 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001833 self.waitUntilSettled()
1834
1835 self.assertEqual(A.reported, 1)
1836 self.assertEqual(B.reported, 1)
1837 self.assertEqual(self.history[0].result, 'ABORTED')
1838 self.assertEqual(self.history[0].changes, '1,1')
1839 self.assertEqual(self.history[1].result, 'ABORTED')
1840 self.assertEqual(self.history[1].changes, '1,1 2,1')
1841 self.assertEqual(self.history[2].result, 'SUCCESS')
1842 self.assertEqual(self.history[2].changes, '1,2')
1843 self.assertEqual(self.history[3].result, 'SUCCESS')
1844 self.assertEqual(self.history[3].changes, '1,1 2,2')
1845
1846 def test_abandoned_gate(self):
1847 "Test that an abandoned change is dequeued from gate"
1848
Paul Belanger174a8272017-03-14 13:20:10 -04001849 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001850
1851 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001852 A.addApproval('Code-Review', 2)
1853 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001854 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001855 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1856 self.assertEqual(self.builds[0].name, 'project-merge')
1857
1858 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1859 self.waitUntilSettled()
1860
Paul Belanger174a8272017-03-14 13:20:10 -04001861 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001862 self.waitUntilSettled()
1863
Arie5b4048c2016-10-05 16:12:06 +03001864 self.assertBuilds([])
1865 self.assertHistory([
1866 dict(name='project-merge', result='ABORTED', changes='1,1')],
1867 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001868 self.assertEqual(A.reported, 1,
1869 "Abandoned gate change should report only start")
1870
1871 def test_abandoned_check(self):
1872 "Test that an abandoned change is dequeued from check"
1873
Paul Belanger174a8272017-03-14 13:20:10 -04001874 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001875
1876 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1877 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001878 tenant = self.sched.abide.tenants.get('tenant-one')
1879 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001880
1881 # Add two git-dependent changes
1882 B.setDependsOn(A, 1)
1883 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1884 self.waitUntilSettled()
1885 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1886 self.waitUntilSettled()
1887 # A live item, and a non-live/live pair
1888 items = check_pipeline.getAllItems()
1889 self.assertEqual(len(items), 3)
1890
1891 self.assertEqual(items[0].change.number, '1')
1892 self.assertFalse(items[0].live)
1893
1894 self.assertEqual(items[1].change.number, '2')
1895 self.assertTrue(items[1].live)
1896
1897 self.assertEqual(items[2].change.number, '1')
1898 self.assertTrue(items[2].live)
1899
1900 # Abandon A
1901 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1902 self.waitUntilSettled()
1903
1904 # The live copy of A should be gone, but the non-live and B
1905 # should continue
1906 items = check_pipeline.getAllItems()
1907 self.assertEqual(len(items), 2)
1908
1909 self.assertEqual(items[0].change.number, '1')
1910 self.assertFalse(items[0].live)
1911
1912 self.assertEqual(items[1].change.number, '2')
1913 self.assertTrue(items[1].live)
1914
Paul Belanger174a8272017-03-14 13:20:10 -04001915 self.executor_server.hold_jobs_in_build = False
1916 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001917 self.waitUntilSettled()
1918
1919 self.assertEqual(len(self.history), 4)
1920 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001921 'Build should have been aborted')
1922 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001923 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001924
Steve Varnau7b78b312015-04-03 14:49:46 -07001925 def test_abandoned_not_timer(self):
1926 "Test that an abandoned change does not cancel timer jobs"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001927 # This test can not use simple_layout because it must start
1928 # with a configuration which does not include a
1929 # timer-triggered job so that we have an opportunity to set
1930 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04001931 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001932 # Start timer trigger - also org/project
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001933 self.commitConfigUpdate('common-config', 'layouts/idle.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001934 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001935 # The pipeline triggers every second, so we should have seen
1936 # several by now.
1937 time.sleep(5)
1938 self.waitUntilSettled()
1939 # Stop queuing timer triggered jobs so that the assertions
1940 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001941 # Must be in same repo, so overwrite config with another one
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001942 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001943 self.sched.reconfigure(self.config)
James E. Blair0b137b42017-07-27 08:51:25 -07001944 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07001945 # If APScheduler is in mid-event when we remove the job, we
1946 # can end up with one more event firing, so give it an extra
1947 # second to settle.
1948 time.sleep(1)
1949 self.waitUntilSettled()
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001950
James E. Blair21037782017-07-19 11:56:55 -07001951 self.assertEqual(len(self.builds), 1, "One timer job")
Steve Varnau7b78b312015-04-03 14:49:46 -07001952
1953 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1954 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1955 self.waitUntilSettled()
James E. Blair21037782017-07-19 11:56:55 -07001956 self.assertEqual(len(self.builds), 2, "One change plus one timer job")
Steve Varnau7b78b312015-04-03 14:49:46 -07001957
1958 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1959 self.waitUntilSettled()
1960
James E. Blair21037782017-07-19 11:56:55 -07001961 self.assertEqual(len(self.builds), 1, "One timer job remains")
Steve Varnau7b78b312015-04-03 14:49:46 -07001962
Paul Belanger174a8272017-03-14 13:20:10 -04001963 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001964 self.waitUntilSettled()
1965
James E. Blair2fa50962013-01-30 21:50:41 -08001966 def test_new_patchset_dequeues_old_on_head(self):
1967 "Test that a new patchset causes the old to be dequeued (at head)"
1968 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001969 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001970 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1971 M.setMerged()
1972 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1973 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1974 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1975 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001976 A.addApproval('Code-Review', 2)
1977 B.addApproval('Code-Review', 2)
1978 C.addApproval('Code-Review', 2)
1979 D.addApproval('Code-Review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001980
1981 C.setDependsOn(B, 1)
1982 B.setDependsOn(A, 1)
1983 A.setDependsOn(M, 1)
1984
Tobias Henkelbf24fd12017-07-27 06:13:07 +02001985 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
1986 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
1987 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
1988 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001989 self.waitUntilSettled()
1990
1991 A.addPatchset()
1992 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1993 self.waitUntilSettled()
1994
Paul Belanger174a8272017-03-14 13:20:10 -04001995 self.executor_server.hold_jobs_in_build = False
1996 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001997 self.waitUntilSettled()
1998
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001999 self.assertEqual(A.data['status'], 'NEW')
2000 self.assertEqual(A.reported, 2)
2001 self.assertEqual(B.data['status'], 'NEW')
2002 self.assertEqual(B.reported, 2)
2003 self.assertEqual(C.data['status'], 'NEW')
2004 self.assertEqual(C.reported, 2)
2005 self.assertEqual(D.data['status'], 'MERGED')
2006 self.assertEqual(D.reported, 2)
2007 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08002008
2009 def test_new_patchset_dequeues_old_without_dependents(self):
2010 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04002011 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08002012 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2013 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2014 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002015 A.addApproval('Code-Review', 2)
2016 B.addApproval('Code-Review', 2)
2017 C.addApproval('Code-Review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08002018
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002019 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
2020 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
2021 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08002022 self.waitUntilSettled()
2023
2024 B.addPatchset()
2025 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
2026 self.waitUntilSettled()
2027
Paul Belanger174a8272017-03-14 13:20:10 -04002028 self.executor_server.hold_jobs_in_build = False
2029 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08002030 self.waitUntilSettled()
2031
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002032 self.assertEqual(A.data['status'], 'MERGED')
2033 self.assertEqual(A.reported, 2)
2034 self.assertEqual(B.data['status'], 'NEW')
2035 self.assertEqual(B.reported, 2)
2036 self.assertEqual(C.data['status'], 'MERGED')
2037 self.assertEqual(C.reported, 2)
2038 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08002039
2040 def test_new_patchset_dequeues_old_independent_queue(self):
2041 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04002042 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08002043 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2044 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2045 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
2046 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2047 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2048 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2049 self.waitUntilSettled()
2050
2051 B.addPatchset()
2052 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
2053 self.waitUntilSettled()
2054
Paul Belanger174a8272017-03-14 13:20:10 -04002055 self.executor_server.hold_jobs_in_build = False
2056 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08002057 self.waitUntilSettled()
2058
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002059 self.assertEqual(A.data['status'], 'NEW')
2060 self.assertEqual(A.reported, 1)
2061 self.assertEqual(B.data['status'], 'NEW')
2062 self.assertEqual(B.reported, 1)
2063 self.assertEqual(C.data['status'], 'NEW')
2064 self.assertEqual(C.reported, 1)
2065 self.assertEqual(len(self.history), 10)
2066 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08002067
James E. Blaircc020532017-04-19 13:04:44 -07002068 @simple_layout('layouts/noop-job.yaml')
James E. Blair18c64442014-03-18 10:14:45 -07002069 def test_noop_job(self):
2070 "Test that the internal noop job works"
2071 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002072 A.addApproval('Code-Review', 2)
2073 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07002074 self.waitUntilSettled()
2075
2076 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2077 self.assertTrue(self.sched._areAllBuildsComplete())
2078 self.assertEqual(len(self.history), 0)
2079 self.assertEqual(A.data['status'], 'MERGED')
2080 self.assertEqual(A.reported, 2)
2081
James E. Blair06cc3922017-04-19 10:08:10 -07002082 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00002083 def test_no_job_project(self):
2084 "Test that reports with no jobs don't get sent"
2085 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
2086 'master', 'A')
2087 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2088 self.waitUntilSettled()
2089
2090 # Change wasn't reported to
2091 self.assertEqual(A.reported, False)
2092
2093 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08002094 tenant = self.sched.abide.tenants.get('tenant-one')
2095 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00002096 items = check_pipeline.getAllItems()
2097 self.assertEqual(len(items), 0)
2098
2099 self.assertEqual(len(self.history), 0)
2100
James E. Blair7d0dedc2013-02-21 17:26:09 -08002101 def test_zuul_refs(self):
2102 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04002103 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08002104 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
2105 M1.setMerged()
2106 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
2107 M2.setMerged()
2108
2109 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2110 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2111 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
2112 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002113 A.addApproval('Code-Review', 2)
2114 B.addApproval('Code-Review', 2)
2115 C.addApproval('Code-Review', 2)
2116 D.addApproval('Code-Review', 2)
2117 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2118 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
2119 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
2120 self.fake_gerrit.addEvent(D.addApproval('Approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002121
2122 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002123 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002124 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002125 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002126 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002127 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002128 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002129 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002130 self.waitUntilSettled()
2131
Clint Byrum3343e3e2016-11-15 16:05:03 -08002132 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002133 for x in self.builds:
James E. Blaire3db2952017-07-21 15:03:36 -07002134 if x.parameters['zuul']['change'] == '3':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002135 a_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002136 elif x.parameters['zuul']['change'] == '4':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002137 b_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002138 elif x.parameters['zuul']['change'] == '5':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002139 c_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002140 elif x.parameters['zuul']['change'] == '6':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002141 d_build = x
2142 if a_build and b_build and c_build and d_build:
2143 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08002144
Clint Byrum3343e3e2016-11-15 16:05:03 -08002145 # should have a, not b, and should not be in project2
2146 self.assertTrue(a_build.hasChanges(A))
2147 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002148
Clint Byrum3343e3e2016-11-15 16:05:03 -08002149 # should have a and b, and should not be in project2
2150 self.assertTrue(b_build.hasChanges(A, B))
2151 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002152
Clint Byrum3343e3e2016-11-15 16:05:03 -08002153 # should have a and b in 1, c in 2
2154 self.assertTrue(c_build.hasChanges(A, B, C))
2155 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002156
Clint Byrum3343e3e2016-11-15 16:05:03 -08002157 # should have a and b in 1, c and d in 2
2158 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002159
Paul Belanger174a8272017-03-14 13:20:10 -04002160 self.executor_server.hold_jobs_in_build = False
2161 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002162 self.waitUntilSettled()
2163
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002164 self.assertEqual(A.data['status'], 'MERGED')
2165 self.assertEqual(A.reported, 2)
2166 self.assertEqual(B.data['status'], 'MERGED')
2167 self.assertEqual(B.reported, 2)
2168 self.assertEqual(C.data['status'], 'MERGED')
2169 self.assertEqual(C.reported, 2)
2170 self.assertEqual(D.data['status'], 'MERGED')
2171 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002172
James E. Blair4a28a882013-08-23 15:17:33 -07002173 def test_rerun_on_error(self):
2174 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002175 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002176 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002177 A.addApproval('Code-Review', 2)
2178 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002179 self.waitUntilSettled()
2180
James E. Blair412fba82017-01-26 15:00:50 -08002181 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002182 self.executor_server.hold_jobs_in_build = False
2183 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002184 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002185 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002186 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2187
James E. Blair412e5582013-04-22 15:50:12 -07002188 def test_statsd(self):
2189 "Test each of the statsd methods used in the scheduler"
James E. Blairded241e2017-10-10 13:22:40 -07002190 statsd = self.sched.statsd
James E. Blair412e5582013-04-22 15:50:12 -07002191 statsd.incr('test-incr')
2192 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002193 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002194 self.assertReportedStat('test-incr', '1|c')
2195 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002196 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002197
James E. Blairdad52252014-02-07 16:59:17 -08002198 def test_stuck_job_cleanup(self):
2199 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002200
2201 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002202 self.gearman_server.hold_jobs_in_queue = True
2203 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002204 A.addApproval('Code-Review', 2)
2205 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002206 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002207 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002208 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2209
James E. Blair31cb3e82017-04-20 13:08:56 -07002210 self.commitConfigUpdate('common-config', 'layouts/no-jobs.yaml')
James E. Blairdad52252014-02-07 16:59:17 -08002211 self.sched.reconfigure(self.config)
2212 self.waitUntilSettled()
2213
James E. Blair18c64442014-03-18 10:14:45 -07002214 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002215 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002216 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002217 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2218 self.assertTrue(self.sched._areAllBuildsComplete())
2219
2220 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002221 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002222 self.assertEqual(self.history[0].result, 'SUCCESS')
2223
James E. Blair879dafb2015-07-17 14:04:49 -07002224 def test_file_head(self):
2225 # This is a regression test for an observed bug. A change
2226 # with a file named "HEAD" in the root directory of the repo
2227 # was processed by a merger. It then was unable to reset the
2228 # repo because of:
2229 # GitCommandError: 'git reset --hard HEAD' returned
2230 # with exit code 128
2231 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2232 # and filename
2233 # Use '--' to separate filenames from revisions'
2234
2235 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002236 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002237 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2238
2239 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2240 self.waitUntilSettled()
2241
2242 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2243 self.waitUntilSettled()
2244
2245 self.assertIn('Build succeeded', A.messages[0])
2246 self.assertIn('Build succeeded', B.messages[0])
2247
James E. Blair70c71582013-03-06 08:50:50 -08002248 def test_file_jobs(self):
2249 "Test that file jobs run only when appropriate"
2250 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002251 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002252 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002253 A.addApproval('Code-Review', 2)
2254 B.addApproval('Code-Review', 2)
2255 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2256 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002257 self.waitUntilSettled()
2258
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002259 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002260 if x.name == 'project-testfile']
2261
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002262 self.assertEqual(len(testfile_jobs), 1)
2263 self.assertEqual(testfile_jobs[0].changes, '1,2')
2264 self.assertEqual(A.data['status'], 'MERGED')
2265 self.assertEqual(A.reported, 2)
2266 self.assertEqual(B.data['status'], 'MERGED')
2267 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002268
Clint Byrum3ee39f32016-11-17 23:45:07 -08002269 def _test_irrelevant_files_jobs(self, should_skip):
2270 "Test that jobs with irrelevant-files filter run only when appropriate"
Clint Byrum3ee39f32016-11-17 23:45:07 -08002271 if should_skip:
2272 files = {'ignoreme': 'ignored\n'}
2273 else:
2274 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002275
2276 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002277 'master',
2278 'test irrelevant-files',
2279 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002280 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2281 self.waitUntilSettled()
2282
2283 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002284 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002285
2286 if should_skip:
2287 self.assertEqual([], tested_change_ids)
2288 else:
2289 self.assertIn(change.data['number'], tested_change_ids)
2290
James E. Blaircc324192017-04-19 14:36:08 -07002291 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002292 def test_irrelevant_files_match_skips_job(self):
2293 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002294
James E. Blaircc324192017-04-19 14:36:08 -07002295 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002296 def test_irrelevant_files_no_match_runs_job(self):
2297 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002298
James E. Blaircc324192017-04-19 14:36:08 -07002299 @simple_layout('layouts/inheritance.yaml')
Clint Byrum85493602016-11-18 11:59:47 -08002300 def test_inherited_jobs_keep_matchers(self):
Clint Byrum85493602016-11-18 11:59:47 -08002301 files = {'ignoreme': 'ignored\n'}
2302
2303 change = self.fake_gerrit.addFakeChange('org/project',
2304 'master',
2305 'test irrelevant-files',
2306 files=files)
2307 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2308 self.waitUntilSettled()
2309
2310 run_jobs = set([build.name for build in self.history])
2311
2312 self.assertEqual(set(['project-test-nomatch-starts-empty',
2313 'project-test-nomatch-starts-full']), run_jobs)
2314
James E. Blairaf8b2082017-10-03 15:38:27 -07002315 @simple_layout('layouts/job-vars.yaml')
2316 def test_inherited_job_variables(self):
2317 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2318 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2319 self.waitUntilSettled()
2320 self.assertHistory([
2321 dict(name='parentjob', result='SUCCESS'),
2322 dict(name='child1', result='SUCCESS'),
2323 dict(name='child2', result='SUCCESS'),
2324 dict(name='child3', result='SUCCESS'),
2325 ], ordered=False)
2326 j = self.getJobFromHistory('parentjob')
2327 rp = set([p['name'] for p in j.parameters['projects']])
2328 self.assertEqual(j.parameters['vars']['override'], 0)
2329 self.assertEqual(j.parameters['vars']['child1override'], 0)
2330 self.assertEqual(j.parameters['vars']['parent'], 0)
2331 self.assertFalse('child1' in j.parameters['vars'])
2332 self.assertFalse('child2' in j.parameters['vars'])
2333 self.assertFalse('child3' in j.parameters['vars'])
2334 self.assertEqual(rp, set(['org/project', 'org/project0',
2335 'org/project0']))
2336 j = self.getJobFromHistory('child1')
2337 rp = set([p['name'] for p in j.parameters['projects']])
2338 self.assertEqual(j.parameters['vars']['override'], 1)
2339 self.assertEqual(j.parameters['vars']['child1override'], 1)
2340 self.assertEqual(j.parameters['vars']['parent'], 0)
2341 self.assertEqual(j.parameters['vars']['child1'], 1)
2342 self.assertFalse('child2' in j.parameters['vars'])
2343 self.assertFalse('child3' in j.parameters['vars'])
2344 self.assertEqual(rp, set(['org/project', 'org/project0',
2345 'org/project1']))
2346 j = self.getJobFromHistory('child2')
2347 rp = set([p['name'] for p in j.parameters['projects']])
2348 self.assertEqual(j.parameters['vars']['override'], 2)
2349 self.assertEqual(j.parameters['vars']['child1override'], 0)
2350 self.assertEqual(j.parameters['vars']['parent'], 0)
2351 self.assertFalse('child1' in j.parameters['vars'])
2352 self.assertEqual(j.parameters['vars']['child2'], 2)
2353 self.assertFalse('child3' in j.parameters['vars'])
2354 self.assertEqual(rp, set(['org/project', 'org/project0',
2355 'org/project2']))
2356 j = self.getJobFromHistory('child3')
2357 rp = set([p['name'] for p in j.parameters['projects']])
2358 self.assertEqual(j.parameters['vars']['override'], 3)
2359 self.assertEqual(j.parameters['vars']['child1override'], 0)
2360 self.assertEqual(j.parameters['vars']['parent'], 0)
2361 self.assertFalse('child1' in j.parameters['vars'])
2362 self.assertFalse('child2' in j.parameters['vars'])
2363 self.assertEqual(j.parameters['vars']['child3'], 3)
2364 self.assertEqual(rp, set(['org/project', 'org/project0',
2365 'org/project3']))
2366
James E. Blairc8a1e052014-02-25 09:29:26 -08002367 def test_queue_names(self):
2368 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002369 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002370 (trusted, project1) = tenant.getProject('org/project1')
2371 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002372 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2373 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2374 self.assertEqual(q1.name, 'integrated')
2375 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002376
James E. Blair64ed6f22013-07-10 14:07:23 -07002377 def test_queue_precedence(self):
2378 "Test that queue precedence works"
2379
2380 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002381 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002382 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2383 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002384 A.addApproval('Code-Review', 2)
2385 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002386
2387 self.waitUntilSettled()
2388 self.gearman_server.hold_jobs_in_queue = False
2389 self.gearman_server.release()
2390 self.waitUntilSettled()
2391
James E. Blair8de58bd2013-07-18 16:23:33 -07002392 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002393 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002394 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002395 self.waitUntilSettled()
2396
James E. Blair64ed6f22013-07-10 14:07:23 -07002397 self.log.debug(self.history)
2398 self.assertEqual(self.history[0].pipeline, 'gate')
2399 self.assertEqual(self.history[1].pipeline, 'check')
2400 self.assertEqual(self.history[2].pipeline, 'gate')
2401 self.assertEqual(self.history[3].pipeline, 'gate')
2402 self.assertEqual(self.history[4].pipeline, 'check')
2403 self.assertEqual(self.history[5].pipeline, 'check')
2404
Clark Boylana5edbe42014-06-03 16:39:10 -07002405 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002406 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002407 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002408 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002409 A.addApproval('Code-Review', 2)
2410 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002411 self.waitUntilSettled()
2412
Paul Belanger174a8272017-03-14 13:20:10 -04002413 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002414 self.waitUntilSettled()
2415
James E. Blair1843a552013-07-03 14:19:52 -07002416 port = self.webapp.server.socket.getsockname()[1]
2417
Adam Gandelman77a12c72017-02-03 17:43:43 -08002418 req = urllib.request.Request(
2419 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002420 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002421 headers = f.info()
2422 self.assertIn('Content-Length', headers)
2423 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002424 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2425 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002426 self.assertIn('Access-Control-Allow-Origin', headers)
2427 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002428 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002429 self.assertIn('Expires', headers)
Clint Byrumf322fe22017-05-10 20:53:12 -07002430 data = f.read().decode('utf8')
James E. Blair1843a552013-07-03 14:19:52 -07002431
Paul Belanger174a8272017-03-14 13:20:10 -04002432 self.executor_server.hold_jobs_in_build = False
2433 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002434 self.waitUntilSettled()
2435
2436 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002437 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002438 for p in data['pipelines']:
2439 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002440 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002441 self.assertEqual(q['window'], 20)
2442 else:
2443 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002444 for head in q['heads']:
2445 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002446 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002447 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002448 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002449 status_jobs.append(job)
2450 self.assertEqual('project-merge', status_jobs[0]['name'])
Monty Taylorde8242c2017-02-23 20:29:53 -06002451 # TODO(mordred) pull uuids from self.builds
Monty Taylor51139a02016-05-24 11:28:10 -05002452 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002453 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2454 uuid=status_jobs[0]['uuid']),
2455 status_jobs[0]['url'])
2456 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002457 'finger://{hostname}/{uuid}'.format(
2458 hostname=self.executor_server.hostname,
2459 uuid=status_jobs[0]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002460 status_jobs[0]['finger_url'])
Monty Taylorde8242c2017-02-23 20:29:53 -06002461 # TOOD(mordred) configure a success-url on the base job
Monty Taylor51139a02016-05-24 11:28:10 -05002462 self.assertEqual(
2463 'finger://{hostname}/{uuid}'.format(
2464 hostname=self.executor_server.hostname,
2465 uuid=status_jobs[0]['uuid']),
2466 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002467 self.assertEqual('project-test1', status_jobs[1]['name'])
Monty Taylor51139a02016-05-24 11:28:10 -05002468 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002469 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2470 uuid=status_jobs[1]['uuid']),
2471 status_jobs[1]['url'])
2472 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002473 'finger://{hostname}/{uuid}'.format(
2474 hostname=self.executor_server.hostname,
2475 uuid=status_jobs[1]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002476 status_jobs[1]['finger_url'])
Monty Taylor51139a02016-05-24 11:28:10 -05002477 self.assertEqual(
2478 'finger://{hostname}/{uuid}'.format(
2479 hostname=self.executor_server.hostname,
2480 uuid=status_jobs[1]['uuid']),
2481 status_jobs[1]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002482
2483 self.assertEqual('project-test2', status_jobs[2]['name'])
Monty Taylor51139a02016-05-24 11:28:10 -05002484 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002485 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2486 uuid=status_jobs[2]['uuid']),
2487 status_jobs[2]['url'])
2488 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002489 'finger://{hostname}/{uuid}'.format(
2490 hostname=self.executor_server.hostname,
2491 uuid=status_jobs[2]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002492 status_jobs[2]['finger_url'])
Monty Taylor51139a02016-05-24 11:28:10 -05002493 self.assertEqual(
2494 'finger://{hostname}/{uuid}'.format(
2495 hostname=self.executor_server.hostname,
2496 uuid=status_jobs[2]['uuid']),
2497 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002498
Tobias Henkel65639f82017-07-10 10:25:42 +02002499 # check job dependencies
2500 self.assertIsNotNone(status_jobs[0]['dependencies'])
2501 self.assertIsNotNone(status_jobs[1]['dependencies'])
2502 self.assertIsNotNone(status_jobs[2]['dependencies'])
2503 self.assertEqual(len(status_jobs[0]['dependencies']), 0)
2504 self.assertEqual(len(status_jobs[1]['dependencies']), 1)
2505 self.assertEqual(len(status_jobs[2]['dependencies']), 1)
2506 self.assertIn('project-merge', status_jobs[1]['dependencies'])
2507 self.assertIn('project-merge', status_jobs[2]['dependencies'])
2508
James E. Blaircdccd972013-07-01 12:10:22 -07002509 def test_live_reconfiguration(self):
2510 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002511 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002512 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002513 A.addApproval('Code-Review', 2)
2514 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002515 self.waitUntilSettled()
2516
2517 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002518 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002519
Paul Belanger174a8272017-03-14 13:20:10 -04002520 self.executor_server.hold_jobs_in_build = False
2521 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002522 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002523 self.assertEqual(self.getJobFromHistory('project-merge').result,
2524 'SUCCESS')
2525 self.assertEqual(self.getJobFromHistory('project-test1').result,
2526 'SUCCESS')
2527 self.assertEqual(self.getJobFromHistory('project-test2').result,
2528 'SUCCESS')
2529 self.assertEqual(A.data['status'], 'MERGED')
2530 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002531
James E. Blair027ba992017-09-20 13:48:32 -07002532 def test_live_reconfiguration_abort(self):
2533 # Raise an exception during reconfiguration and verify we
2534 # still function.
2535 self.executor_server.hold_jobs_in_build = True
2536 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2537 A.addApproval('Code-Review', 2)
2538 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2539 self.waitUntilSettled()
2540
2541 tenant = self.sched.abide.tenants.get('tenant-one')
2542 pipeline = tenant.layout.pipelines['gate']
2543 change = pipeline.getAllItems()[0].change
2544 # Set this to an invalid value to cause an exception during
2545 # reconfiguration.
2546 change.branch = None
2547
2548 self.sched.reconfigure(self.config)
2549 self.waitUntilSettled()
2550
2551 self.executor_server.hold_jobs_in_build = False
2552 self.executor_server.release()
2553
2554 self.waitUntilSettled()
2555 self.assertEqual(self.getJobFromHistory('project-merge').result,
2556 'ABORTED')
2557 self.assertEqual(A.data['status'], 'NEW')
2558 # The final report fails because of the invalid value set above.
2559 self.assertEqual(A.reported, 1)
2560
James E. Blair6bc782d2015-07-17 16:20:21 -07002561 def test_live_reconfiguration_merge_conflict(self):
2562 # A real-world bug: a change in a gate queue has a merge
2563 # conflict and a job is added to its project while it's
2564 # sitting in the queue. The job gets added to the change and
2565 # enqueued and the change gets stuck.
Paul Belanger174a8272017-03-14 13:20:10 -04002566 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002567
2568 # This change is fine. It's here to stop the queue long
2569 # enough for the next change to be subject to the
2570 # reconfiguration, as well as to provide a conflict for the
2571 # next change. This change will succeed and merge.
2572 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum073c00b2017-05-01 13:41:23 -07002573 A.addPatchset({'conflict': 'A'})
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002574 A.addApproval('Code-Review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002575
2576 # This change will be in merge conflict. During the
2577 # reconfiguration, we will add a job. We want to make sure
2578 # that doesn't cause it to get stuck.
2579 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Clint Byrum073c00b2017-05-01 13:41:23 -07002580 B.addPatchset({'conflict': 'B'})
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002581 B.addApproval('Code-Review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002582
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002583 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
2584 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002585
2586 self.waitUntilSettled()
2587
2588 # No jobs have run yet
2589 self.assertEqual(A.data['status'], 'NEW')
2590 self.assertEqual(A.reported, 1)
2591 self.assertEqual(B.data['status'], 'NEW')
James E. Blair6bc782d2015-07-17 16:20:21 -07002592 self.assertEqual(len(self.history), 0)
2593
2594 # Add the "project-test3" job.
Clint Byrum073c00b2017-05-01 13:41:23 -07002595 self.commitConfigUpdate('common-config',
2596 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002597 self.sched.reconfigure(self.config)
2598 self.waitUntilSettled()
2599
Paul Belanger174a8272017-03-14 13:20:10 -04002600 self.executor_server.hold_jobs_in_build = False
2601 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002602 self.waitUntilSettled()
2603
2604 self.assertEqual(A.data['status'], 'MERGED')
2605 self.assertEqual(A.reported, 2)
2606 self.assertEqual(B.data['status'], 'NEW')
Tobias Henkel9842bd72017-05-16 13:40:03 +02002607 self.assertIn('Merge Failed', B.messages[-1])
James E. Blair6bc782d2015-07-17 16:20:21 -07002608 self.assertEqual(self.getJobFromHistory('project-merge').result,
2609 'SUCCESS')
2610 self.assertEqual(self.getJobFromHistory('project-test1').result,
2611 'SUCCESS')
2612 self.assertEqual(self.getJobFromHistory('project-test2').result,
2613 'SUCCESS')
2614 self.assertEqual(self.getJobFromHistory('project-test3').result,
2615 'SUCCESS')
2616 self.assertEqual(len(self.history), 4)
2617
James E. Blair400e8fd2015-07-30 17:44:45 -07002618 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002619 # An extrapolation of test_live_reconfiguration_merge_conflict
2620 # that tests a job added to a job tree with a failed root does
2621 # not run.
Paul Belanger174a8272017-03-14 13:20:10 -04002622 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002623
2624 # This change is fine. It's here to stop the queue long
2625 # enough for the next change to be subject to the
2626 # reconfiguration. This change will succeed and merge.
2627 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum3147d652017-05-01 14:01:42 -07002628 A.addPatchset({'conflict': 'A'})
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002629 A.addApproval('Code-Review', 2)
2630 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002631 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002632 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002633 self.waitUntilSettled()
2634
2635 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002636 self.executor_server.failJob('project-merge', B)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002637 B.addApproval('Code-Review', 2)
2638 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002639 self.waitUntilSettled()
2640
Paul Belanger174a8272017-03-14 13:20:10 -04002641 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002642 self.waitUntilSettled()
2643
2644 # Both -merge jobs have run, but no others.
2645 self.assertEqual(A.data['status'], 'NEW')
2646 self.assertEqual(A.reported, 1)
2647 self.assertEqual(B.data['status'], 'NEW')
2648 self.assertEqual(B.reported, 1)
2649 self.assertEqual(self.history[0].result, 'SUCCESS')
2650 self.assertEqual(self.history[0].name, 'project-merge')
2651 self.assertEqual(self.history[1].result, 'FAILURE')
2652 self.assertEqual(self.history[1].name, 'project-merge')
2653 self.assertEqual(len(self.history), 2)
2654
2655 # Add the "project-test3" job.
Clint Byrum3147d652017-05-01 14:01:42 -07002656 self.commitConfigUpdate('common-config',
2657 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002658 self.sched.reconfigure(self.config)
2659 self.waitUntilSettled()
2660
Paul Belanger174a8272017-03-14 13:20:10 -04002661 self.executor_server.hold_jobs_in_build = False
2662 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002663 self.waitUntilSettled()
2664
2665 self.assertEqual(A.data['status'], 'MERGED')
2666 self.assertEqual(A.reported, 2)
2667 self.assertEqual(B.data['status'], 'NEW')
2668 self.assertEqual(B.reported, 2)
2669 self.assertEqual(self.history[0].result, 'SUCCESS')
2670 self.assertEqual(self.history[0].name, 'project-merge')
2671 self.assertEqual(self.history[1].result, 'FAILURE')
2672 self.assertEqual(self.history[1].name, 'project-merge')
2673 self.assertEqual(self.history[2].result, 'SUCCESS')
2674 self.assertEqual(self.history[3].result, 'SUCCESS')
2675 self.assertEqual(self.history[4].result, 'SUCCESS')
2676 self.assertEqual(len(self.history), 5)
2677
James E. Blair400e8fd2015-07-30 17:44:45 -07002678 def test_live_reconfiguration_failed_job(self):
2679 # Test that a change with a removed failing job does not
2680 # disrupt reconfiguration. If a change has a failed job and
2681 # that job is removed during a reconfiguration, we observed a
2682 # bug where the code to re-set build statuses would run on
2683 # that build and raise an exception because the job no longer
2684 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002685 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002686
2687 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2688
2689 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002690 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002691
2692 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2693 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002694 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002695 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002696 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002697 self.waitUntilSettled()
2698
2699 self.assertEqual(A.data['status'], 'NEW')
2700 self.assertEqual(A.reported, 0)
2701
2702 self.assertEqual(self.getJobFromHistory('project-merge').result,
2703 'SUCCESS')
2704 self.assertEqual(self.getJobFromHistory('project-test1').result,
2705 'FAILURE')
2706 self.assertEqual(len(self.history), 2)
2707
2708 # Remove the test1 job.
Clint Byrum841a58c2017-05-01 14:17:21 -07002709 self.commitConfigUpdate('common-config',
2710 'layouts/live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002711 self.sched.reconfigure(self.config)
2712 self.waitUntilSettled()
2713
Paul Belanger174a8272017-03-14 13:20:10 -04002714 self.executor_server.hold_jobs_in_build = False
2715 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002716 self.waitUntilSettled()
2717
2718 self.assertEqual(self.getJobFromHistory('project-test2').result,
2719 'SUCCESS')
2720 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2721 'SUCCESS')
2722 self.assertEqual(len(self.history), 4)
2723
2724 self.assertEqual(A.data['status'], 'NEW')
2725 self.assertEqual(A.reported, 1)
2726 self.assertIn('Build succeeded', A.messages[0])
2727 # Ensure the removed job was not included in the report.
2728 self.assertNotIn('project-test1', A.messages[0])
2729
James E. Blairfe707d12015-08-05 15:18:15 -07002730 def test_live_reconfiguration_shared_queue(self):
2731 # Test that a change with a failing job which was removed from
2732 # this project but otherwise still exists in the system does
2733 # not disrupt reconfiguration.
2734
Paul Belanger174a8272017-03-14 13:20:10 -04002735 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002736
2737 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2738
Paul Belanger174a8272017-03-14 13:20:10 -04002739 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002740
2741 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2742 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002743 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002744 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002745 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002746 self.waitUntilSettled()
2747
2748 self.assertEqual(A.data['status'], 'NEW')
2749 self.assertEqual(A.reported, 0)
2750
Clint Byrum69663d42017-05-01 14:51:04 -07002751 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002752 'SUCCESS')
2753 self.assertEqual(self.getJobFromHistory(
2754 'project1-project2-integration').result, 'FAILURE')
2755 self.assertEqual(len(self.history), 2)
2756
2757 # Remove the integration job.
Clint Byrum69663d42017-05-01 14:51:04 -07002758 self.commitConfigUpdate(
2759 'common-config',
2760 'layouts/live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002761 self.sched.reconfigure(self.config)
2762 self.waitUntilSettled()
2763
Paul Belanger174a8272017-03-14 13:20:10 -04002764 self.executor_server.hold_jobs_in_build = False
2765 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002766 self.waitUntilSettled()
2767
Clint Byrum69663d42017-05-01 14:51:04 -07002768 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002769 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002770 self.assertEqual(self.getJobFromHistory('project-test1').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002771 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002772 self.assertEqual(self.getJobFromHistory('project-test2').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002773 'SUCCESS')
2774 self.assertEqual(self.getJobFromHistory(
2775 'project1-project2-integration').result, 'FAILURE')
2776 self.assertEqual(len(self.history), 4)
2777
2778 self.assertEqual(A.data['status'], 'NEW')
2779 self.assertEqual(A.reported, 1)
2780 self.assertIn('Build succeeded', A.messages[0])
2781 # Ensure the removed job was not included in the report.
2782 self.assertNotIn('project1-project2-integration', A.messages[0])
2783
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002784 def test_double_live_reconfiguration_shared_queue(self):
2785 # This was a real-world regression. A change is added to
2786 # gate; a reconfigure happens, a second change which depends
2787 # on the first is added, and a second reconfiguration happens.
2788 # Ensure that both changes merge.
2789
2790 # A failure may indicate incorrect caching or cleaning up of
2791 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002792 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002793
2794 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2795 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2796 B.setDependsOn(A, 1)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002797 A.addApproval('Code-Review', 2)
2798 B.addApproval('Code-Review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002799
2800 # Add the parent change.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002801 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002802 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002803 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002804 self.waitUntilSettled()
2805
2806 # Reconfigure (with only one change in the pipeline).
2807 self.sched.reconfigure(self.config)
2808 self.waitUntilSettled()
2809
2810 # Add the child change.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002811 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002812 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002813 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002814 self.waitUntilSettled()
2815
2816 # Reconfigure (with both in the pipeline).
2817 self.sched.reconfigure(self.config)
2818 self.waitUntilSettled()
2819
Paul Belanger174a8272017-03-14 13:20:10 -04002820 self.executor_server.hold_jobs_in_build = False
2821 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002822 self.waitUntilSettled()
2823
2824 self.assertEqual(len(self.history), 8)
2825
2826 self.assertEqual(A.data['status'], 'MERGED')
2827 self.assertEqual(A.reported, 2)
2828 self.assertEqual(B.data['status'], 'MERGED')
2829 self.assertEqual(B.reported, 2)
2830
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002831 def test_live_reconfiguration_del_project(self):
2832 # Test project deletion from layout
2833 # while changes are enqueued
2834
Paul Belanger174a8272017-03-14 13:20:10 -04002835 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002836 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2837 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2838 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2839
2840 # A Depends-On: B
2841 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2842 A.subject, B.data['id'])
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002843 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002844
2845 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2846 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2847 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002848 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002849 self.waitUntilSettled()
2850 self.assertEqual(len(self.builds), 5)
2851
2852 # This layout defines only org/project, not org/project1
James E. Blair31cb3e82017-04-20 13:08:56 -07002853 self.commitConfigUpdate(
2854 'common-config',
2855 'layouts/live-reconfiguration-del-project.yaml')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002856 self.sched.reconfigure(self.config)
2857 self.waitUntilSettled()
2858
2859 # Builds for C aborted, builds for A succeed,
2860 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002861 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002862 self.assertEqual(job_c.changes, '3,1')
2863 self.assertEqual(job_c.result, 'ABORTED')
2864
Paul Belanger174a8272017-03-14 13:20:10 -04002865 self.executor_server.hold_jobs_in_build = False
2866 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002867 self.waitUntilSettled()
2868
Clint Byrum0149ada2017-04-04 12:22:01 -07002869 self.assertEqual(
2870 self.getJobFromHistory('project-test1', 'org/project').changes,
2871 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002872
2873 self.assertEqual(A.data['status'], 'NEW')
2874 self.assertEqual(B.data['status'], 'NEW')
2875 self.assertEqual(C.data['status'], 'NEW')
2876 self.assertEqual(A.reported, 1)
2877 self.assertEqual(B.reported, 0)
2878 self.assertEqual(C.reported, 0)
2879
Clint Byrum0149ada2017-04-04 12:22:01 -07002880 tenant = self.sched.abide.tenants.get('tenant-one')
2881 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002882 self.assertIn('Build succeeded', A.messages[0])
2883
James E. Blair287c06d2013-07-24 10:39:30 -07002884 def test_delayed_repo_init(self):
James E. Blair287c06d2013-07-24 10:39:30 -07002885 self.init_repo("org/new-project")
Clint Byrum627ba362017-08-14 13:20:40 -07002886 files = {'README': ''}
2887 self.addCommitToRepo("org/new-project", 'Initial commit',
2888 files=files, tag='init')
2889 self.newTenantConfig('tenants/delayed-repo-init.yaml')
2890 self.commitConfigUpdate(
2891 'common-config',
2892 'layouts/delayed-repo-init.yaml')
2893 self.sched.reconfigure(self.config)
2894 self.waitUntilSettled()
2895
James E. Blair287c06d2013-07-24 10:39:30 -07002896 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2897
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002898 A.addApproval('Code-Review', 2)
2899 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002900 self.waitUntilSettled()
2901 self.assertEqual(self.getJobFromHistory('project-merge').result,
2902 'SUCCESS')
2903 self.assertEqual(self.getJobFromHistory('project-test1').result,
2904 'SUCCESS')
2905 self.assertEqual(self.getJobFromHistory('project-test2').result,
2906 'SUCCESS')
2907 self.assertEqual(A.data['status'], 'MERGED')
2908 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002909
James E. Blair9ea70072017-04-19 16:05:30 -07002910 @simple_layout('layouts/repo-deleted.yaml')
Clark Boylan6dbbc482013-10-18 10:57:31 -07002911 def test_repo_deleted(self):
Clark Boylan6dbbc482013-10-18 10:57:31 -07002912 self.init_repo("org/delete-project")
2913 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2914
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002915 A.addApproval('Code-Review', 2)
2916 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002917 self.waitUntilSettled()
2918 self.assertEqual(self.getJobFromHistory('project-merge').result,
2919 'SUCCESS')
2920 self.assertEqual(self.getJobFromHistory('project-test1').result,
2921 'SUCCESS')
2922 self.assertEqual(self.getJobFromHistory('project-test2').result,
2923 'SUCCESS')
2924 self.assertEqual(A.data['status'], 'MERGED')
2925 self.assertEqual(A.reported, 2)
2926
2927 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002928 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002929 if os.path.exists(os.path.join(self.merger_src_root, p)):
2930 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002931 if os.path.exists(os.path.join(self.executor_src_root, p)):
2932 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002933
2934 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2935
Tobias Henkelbf24fd12017-07-27 06:13:07 +02002936 B.addApproval('Code-Review', 2)
2937 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002938 self.waitUntilSettled()
2939 self.assertEqual(self.getJobFromHistory('project-merge').result,
2940 'SUCCESS')
2941 self.assertEqual(self.getJobFromHistory('project-test1').result,
2942 'SUCCESS')
2943 self.assertEqual(self.getJobFromHistory('project-test2').result,
2944 'SUCCESS')
2945 self.assertEqual(B.data['status'], 'MERGED')
2946 self.assertEqual(B.reported, 2)
2947
James E. Blair892cca62017-08-09 11:36:58 -07002948 @simple_layout('layouts/untrusted-secrets.yaml')
2949 def test_untrusted_secrets(self):
2950 "Test untrusted secrets"
2951 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2952 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2953 self.waitUntilSettled()
2954
2955 self.assertHistory([])
2956 self.assertEqual(A.patchsets[0]['approvals'][0]['value'], "-1")
James E. Blair8eb564a2017-08-10 09:21:41 -07002957 self.assertIn('does not allow post-review job',
James E. Blair892cca62017-08-09 11:36:58 -07002958 A.messages[0])
2959
James E. Blaire68d43f2017-04-19 14:03:30 -07002960 @simple_layout('layouts/tags.yaml')
James E. Blair456f2fb2016-02-09 09:29:33 -08002961 def test_tags(self):
2962 "Test job tags"
James E. Blair456f2fb2016-02-09 09:29:33 -08002963 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2964 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2965 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2966 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2967 self.waitUntilSettled()
2968
James E. Blaire68d43f2017-04-19 14:03:30 -07002969 self.assertEqual(len(self.history), 2)
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002970
2971 results = {self.getJobFromHistory('merge',
James E. Blair9d46f092017-07-20 16:06:20 -07002972 project='org/project1').uuid: ['extratag', 'merge'],
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002973 self.getJobFromHistory('merge',
James E. Blair9d46f092017-07-20 16:06:20 -07002974 project='org/project2').uuid: ['merge']}
James E. Blair456f2fb2016-02-09 09:29:33 -08002975
2976 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002977 self.assertEqual(results.get(build.uuid, ''),
James E. Blair9d46f092017-07-20 16:06:20 -07002978 build.parameters['zuul'].get('jobtags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08002979
James E. Blair63bb0ef2013-07-29 17:14:51 -07002980 def test_timer(self):
2981 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002982 # This test can not use simple_layout because it must start
2983 # with a configuration which does not include a
2984 # timer-triggered job so that we have an opportunity to set
2985 # the hold flag before the first job.
James E. Blair21037782017-07-19 11:56:55 -07002986 self.create_branch('org/project', 'stable')
Paul Belanger174a8272017-03-14 13:20:10 -04002987 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002988 self.commitConfigUpdate('common-config', 'layouts/timer.yaml')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002989 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002990
Clark Boylan3ee090a2014-04-03 20:55:09 -07002991 # The pipeline triggers every second, so we should have seen
2992 # several by now.
2993 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002994 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07002995
2996 self.assertEqual(len(self.builds), 2)
2997
James E. Blair63bb0ef2013-07-29 17:14:51 -07002998 port = self.webapp.server.socket.getsockname()[1]
2999
Clint Byrum5e729e92017-02-08 06:34:57 -08003000 req = urllib.request.Request(
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003001 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07003002 f = urllib.request.urlopen(req)
Clint Byrumf322fe22017-05-10 20:53:12 -07003003 data = f.read().decode('utf8')
James E. Blair63bb0ef2013-07-29 17:14:51 -07003004
Paul Belanger174a8272017-03-14 13:20:10 -04003005 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07003006 # Stop queuing timer triggered jobs so that the assertions
3007 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003008 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003009 self.sched.reconfigure(self.config)
James E. Blair78ae4782017-08-02 14:19:10 -07003010 self.waitUntilSettled()
3011 # If APScheduler is in mid-event when we remove the job, we
3012 # can end up with one more event firing, so give it an extra
3013 # second to settle.
3014 time.sleep(1)
3015 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003016 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07003017 self.waitUntilSettled()
3018
James E. Blair21037782017-07-19 11:56:55 -07003019 self.assertHistory([
3020 dict(name='project-bitrot', result='SUCCESS',
3021 ref='refs/heads/master'),
3022 dict(name='project-bitrot', result='SUCCESS',
3023 ref='refs/heads/stable'),
3024 ], ordered=False)
James E. Blair63bb0ef2013-07-29 17:14:51 -07003025
3026 data = json.loads(data)
3027 status_jobs = set()
3028 for p in data['pipelines']:
3029 for q in p['change_queues']:
3030 for head in q['heads']:
3031 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07003032 for job in change['jobs']:
3033 status_jobs.add(job['name'])
James E. Blair21037782017-07-19 11:56:55 -07003034 self.assertIn('project-bitrot', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003035
James E. Blair4f6033c2014-03-27 15:49:09 -07003036 def test_idle(self):
3037 "Test that frequent periodic jobs work"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003038 # This test can not use simple_layout because it must start
3039 # with a configuration which does not include a
3040 # timer-triggered job so that we have an opportunity to set
3041 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04003042 self.executor_server.hold_jobs_in_build = True
James E. Blair4f6033c2014-03-27 15:49:09 -07003043
Clark Boylan3ee090a2014-04-03 20:55:09 -07003044 for x in range(1, 3):
3045 # Test that timer triggers periodic jobs even across
3046 # layout config reloads.
3047 # Start timer trigger
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003048 self.commitConfigUpdate('common-config',
3049 'layouts/idle.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003050 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08003051 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07003052
Clark Boylan3ee090a2014-04-03 20:55:09 -07003053 # The pipeline triggers every second, so we should have seen
3054 # several by now.
3055 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07003056
3057 # Stop queuing timer triggered jobs so that the assertions
3058 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003059 self.commitConfigUpdate('common-config',
3060 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003061 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08003062 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07003063 # If APScheduler is in mid-event when we remove the job,
3064 # we can end up with one more event firing, so give it an
3065 # extra second to settle.
3066 time.sleep(1)
3067 self.waitUntilSettled()
James E. Blair21037782017-07-19 11:56:55 -07003068 self.assertEqual(len(self.builds), 1,
Clint Byrum58264dc2017-02-07 21:21:22 -08003069 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04003070 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003071 self.waitUntilSettled()
3072 self.assertEqual(len(self.builds), 0)
James E. Blair21037782017-07-19 11:56:55 -07003073 self.assertEqual(len(self.history), x)
James E. Blair4f6033c2014-03-27 15:49:09 -07003074
James E. Blaircc324192017-04-19 14:36:08 -07003075 @simple_layout('layouts/smtp.yaml')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003076 def test_check_smtp_pool(self):
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003077 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3078 self.waitUntilSettled()
3079
3080 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3081 self.waitUntilSettled()
3082
James E. Blairff80a2f2013-12-27 13:24:06 -08003083 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003084
3085 # A.messages only holds what FakeGerrit places in it. Thus we
3086 # work on the knowledge of what the first message should be as
3087 # it is only configured to go to SMTP.
3088
3089 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003090 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003091 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003092 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003093 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08003094 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003095
3096 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003097 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003098 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003099 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10003100 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08003101 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08003102
James E. Blaire5910202013-12-27 09:50:31 -08003103 def test_timer_smtp(self):
3104 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003105 # This test can not use simple_layout because it must start
3106 # with a configuration which does not include a
3107 # timer-triggered job so that we have an opportunity to set
3108 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04003109 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003110 self.commitConfigUpdate('common-config', 'layouts/timer-smtp.yaml')
James E. Blaire5910202013-12-27 09:50:31 -08003111 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08003112
Clark Boylan3ee090a2014-04-03 20:55:09 -07003113 # The pipeline triggers every second, so we should have seen
3114 # several by now.
3115 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08003116 self.waitUntilSettled()
3117
Clark Boylan3ee090a2014-04-03 20:55:09 -07003118 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003119 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003120 self.waitUntilSettled()
3121 self.assertEqual(len(self.history), 2)
3122
James E. Blaire5910202013-12-27 09:50:31 -08003123 self.assertEqual(self.getJobFromHistory(
3124 'project-bitrot-stable-old').result, 'SUCCESS')
3125 self.assertEqual(self.getJobFromHistory(
3126 'project-bitrot-stable-older').result, 'SUCCESS')
3127
James E. Blairff80a2f2013-12-27 13:24:06 -08003128 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08003129
3130 # A.messages only holds what FakeGerrit places in it. Thus we
3131 # work on the knowledge of what the first message should be as
3132 # it is only configured to go to SMTP.
3133
3134 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08003135 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08003136 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08003137 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08003138 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08003139 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08003140
Clark Boylan3ee090a2014-04-03 20:55:09 -07003141 # Stop queuing timer triggered jobs and let any that may have
3142 # queued through so that end of test assertions pass.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07003143 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003144 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07003145 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07003146 # If APScheduler is in mid-event when we remove the job, we
3147 # can end up with one more event firing, so give it an extra
3148 # second to settle.
3149 time.sleep(1)
3150 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003151 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07003152 self.waitUntilSettled()
3153
Joshua Hesketh25695cb2017-03-06 12:50:04 +11003154 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00003155 def test_timer_sshkey(self):
3156 "Test that a periodic job can setup SSH key authentication"
3157 self.worker.hold_jobs_in_build = True
3158 self.config.set('zuul', 'layout_config',
3159 'tests/fixtures/layout-timer.yaml')
3160 self.sched.reconfigure(self.config)
3161 self.registerJobs()
3162
3163 # The pipeline triggers every second, so we should have seen
3164 # several by now.
3165 time.sleep(5)
3166 self.waitUntilSettled()
3167
3168 self.assertEqual(len(self.builds), 2)
3169
3170 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
3171 self.assertTrue(os.path.isfile(ssh_wrapper))
3172 with open(ssh_wrapper) as f:
3173 ssh_wrapper_content = f.read()
3174 self.assertIn("fake_id_rsa", ssh_wrapper_content)
3175 # In the unit tests Merger runs in the same process,
3176 # so we see its' environment variables
3177 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
3178
3179 self.worker.release('.*')
3180 self.waitUntilSettled()
3181 self.assertEqual(len(self.history), 2)
3182
3183 self.assertEqual(self.getJobFromHistory(
3184 'project-bitrot-stable-old').result, 'SUCCESS')
3185 self.assertEqual(self.getJobFromHistory(
3186 'project-bitrot-stable-older').result, 'SUCCESS')
3187
3188 # Stop queuing timer triggered jobs and let any that may have
3189 # queued through so that end of test assertions pass.
3190 self.config.set('zuul', 'layout_config',
3191 'tests/fixtures/layout-no-timer.yaml')
3192 self.sched.reconfigure(self.config)
3193 self.registerJobs()
3194 self.waitUntilSettled()
James E. Blair78ae4782017-08-02 14:19:10 -07003195 # If APScheduler is in mid-event when we remove the job, we
3196 # can end up with one more event firing, so give it an extra
3197 # second to settle.
3198 time.sleep(1)
3199 self.waitUntilSettled()
Evgeny Antyshevda90a502017-02-08 08:42:59 +00003200 self.worker.release('.*')
3201 self.waitUntilSettled()
3202
James E. Blair91e34592015-07-31 16:45:59 -07003203 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08003204 "Test that the RPC client can enqueue a change"
3205 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003206 A.addApproval('Code-Review', 2)
3207 A.addApproval('Approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08003208
3209 client = zuul.rpcclient.RPCClient('127.0.0.1',
3210 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003211 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003212 r = client.enqueue(tenant='tenant-one',
3213 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003214 project='org/project',
3215 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003216 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003217 self.waitUntilSettled()
3218 self.assertEqual(self.getJobFromHistory('project-merge').result,
3219 'SUCCESS')
3220 self.assertEqual(self.getJobFromHistory('project-test1').result,
3221 'SUCCESS')
3222 self.assertEqual(self.getJobFromHistory('project-test2').result,
3223 'SUCCESS')
3224 self.assertEqual(A.data['status'], 'MERGED')
3225 self.assertEqual(A.reported, 2)
3226 self.assertEqual(r, True)
3227
James E. Blair91e34592015-07-31 16:45:59 -07003228 def test_client_enqueue_ref(self):
3229 "Test that the RPC client can enqueue a ref"
James E. Blair289f5932017-07-27 15:02:29 -07003230 p = "review.example.com/org/project"
3231 upstream = self.getUpstreamRepos([p])
3232 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3233 A.setMerged()
3234 A_commit = str(upstream[p].commit('master'))
3235 self.log.debug("A commit: %s" % A_commit)
James E. Blair91e34592015-07-31 16:45:59 -07003236
3237 client = zuul.rpcclient.RPCClient('127.0.0.1',
3238 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003239 self.addCleanup(client.shutdown)
James E. Blair91e34592015-07-31 16:45:59 -07003240 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04003241 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07003242 pipeline='post',
3243 project='org/project',
3244 trigger='gerrit',
3245 ref='master',
3246 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
James E. Blair289f5932017-07-27 15:02:29 -07003247 newrev=A_commit)
James E. Blair91e34592015-07-31 16:45:59 -07003248 self.waitUntilSettled()
3249 job_names = [x.name for x in self.history]
3250 self.assertEqual(len(self.history), 1)
3251 self.assertIn('project-post', job_names)
3252 self.assertEqual(r, True)
3253
James E. Blairad28e912013-11-27 10:43:22 -08003254 def test_client_enqueue_negative(self):
3255 "Test that the RPC client returns errors"
3256 client = zuul.rpcclient.RPCClient('127.0.0.1',
3257 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003258 self.addCleanup(client.shutdown)
James E. Blairad28e912013-11-27 10:43:22 -08003259 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04003260 "Invalid tenant"):
3261 r = client.enqueue(tenant='tenant-foo',
3262 pipeline='gate',
3263 project='org/project',
3264 trigger='gerrit',
3265 change='1,1')
Paul Belangerbaca3132016-11-04 12:49:54 -04003266 self.assertEqual(r, False)
3267
3268 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08003269 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003270 r = client.enqueue(tenant='tenant-one',
3271 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003272 project='project-does-not-exist',
3273 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003274 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003275 self.assertEqual(r, False)
3276
3277 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3278 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003279 r = client.enqueue(tenant='tenant-one',
3280 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08003281 project='org/project',
3282 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003283 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003284 self.assertEqual(r, False)
3285
3286 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3287 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003288 r = client.enqueue(tenant='tenant-one',
3289 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003290 project='org/project',
3291 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08003292 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003293 self.assertEqual(r, False)
3294
3295 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3296 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003297 r = client.enqueue(tenant='tenant-one',
3298 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003299 project='org/project',
3300 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003301 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003302 self.assertEqual(r, False)
3303
3304 self.waitUntilSettled()
3305 self.assertEqual(len(self.history), 0)
3306 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08003307
3308 def test_client_promote(self):
3309 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04003310 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003311 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3312 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3313 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003314 A.addApproval('Code-Review', 2)
3315 B.addApproval('Code-Review', 2)
3316 C.addApproval('Code-Review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003317
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003318 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3319 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3320 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003321
3322 self.waitUntilSettled()
3323
Paul Belangerbaca3132016-11-04 12:49:54 -04003324 tenant = self.sched.abide.tenants.get('tenant-one')
3325 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003326 enqueue_times = {}
3327 for item in items:
3328 enqueue_times[str(item.change)] = item.enqueue_time
3329
James E. Blair36658cf2013-12-06 17:53:48 -08003330 client = zuul.rpcclient.RPCClient('127.0.0.1',
3331 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003332 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003333 r = client.promote(tenant='tenant-one',
3334 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003335 change_ids=['2,1', '3,1'])
3336
Sean Daguef39b9ca2014-01-10 21:34:35 -05003337 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003338 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003339 for item in items:
3340 self.assertEqual(
3341 enqueue_times[str(item.change)], item.enqueue_time)
3342
James E. Blair78acec92014-02-06 07:11:32 -08003343 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003344 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003345 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003346 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003347 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003348 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003349 self.waitUntilSettled()
3350
3351 self.assertEqual(len(self.builds), 6)
3352 self.assertEqual(self.builds[0].name, 'project-test1')
3353 self.assertEqual(self.builds[1].name, 'project-test2')
3354 self.assertEqual(self.builds[2].name, 'project-test1')
3355 self.assertEqual(self.builds[3].name, 'project-test2')
3356 self.assertEqual(self.builds[4].name, 'project-test1')
3357 self.assertEqual(self.builds[5].name, 'project-test2')
3358
Paul Belangerbaca3132016-11-04 12:49:54 -04003359 self.assertTrue(self.builds[0].hasChanges(B))
3360 self.assertFalse(self.builds[0].hasChanges(A))
3361 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003362
Paul Belangerbaca3132016-11-04 12:49:54 -04003363 self.assertTrue(self.builds[2].hasChanges(B))
3364 self.assertTrue(self.builds[2].hasChanges(C))
3365 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003366
Paul Belangerbaca3132016-11-04 12:49:54 -04003367 self.assertTrue(self.builds[4].hasChanges(B))
3368 self.assertTrue(self.builds[4].hasChanges(C))
3369 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003370
Paul Belanger174a8272017-03-14 13:20:10 -04003371 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003372 self.waitUntilSettled()
3373
3374 self.assertEqual(A.data['status'], 'MERGED')
3375 self.assertEqual(A.reported, 2)
3376 self.assertEqual(B.data['status'], 'MERGED')
3377 self.assertEqual(B.reported, 2)
3378 self.assertEqual(C.data['status'], 'MERGED')
3379 self.assertEqual(C.reported, 2)
3380
James E. Blair36658cf2013-12-06 17:53:48 -08003381 self.assertEqual(r, True)
3382
3383 def test_client_promote_dependent(self):
3384 "Test that the RPC client can promote a dependent change"
3385 # C (depends on B) -> B -> A ; then promote C to get:
3386 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003387 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003388 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3389 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3390 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3391
3392 C.setDependsOn(B, 1)
3393
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003394 A.addApproval('Code-Review', 2)
3395 B.addApproval('Code-Review', 2)
3396 C.addApproval('Code-Review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003397
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003398 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3399 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3400 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003401
3402 self.waitUntilSettled()
3403
3404 client = zuul.rpcclient.RPCClient('127.0.0.1',
3405 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003406 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003407 r = client.promote(tenant='tenant-one',
3408 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003409 change_ids=['3,1'])
3410
James E. Blair78acec92014-02-06 07:11:32 -08003411 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003412 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003413 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003414 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003415 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003416 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003417 self.waitUntilSettled()
3418
3419 self.assertEqual(len(self.builds), 6)
3420 self.assertEqual(self.builds[0].name, 'project-test1')
3421 self.assertEqual(self.builds[1].name, 'project-test2')
3422 self.assertEqual(self.builds[2].name, 'project-test1')
3423 self.assertEqual(self.builds[3].name, 'project-test2')
3424 self.assertEqual(self.builds[4].name, 'project-test1')
3425 self.assertEqual(self.builds[5].name, 'project-test2')
3426
Paul Belangerbaca3132016-11-04 12:49:54 -04003427 self.assertTrue(self.builds[0].hasChanges(B))
3428 self.assertFalse(self.builds[0].hasChanges(A))
3429 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003430
Paul Belangerbaca3132016-11-04 12:49:54 -04003431 self.assertTrue(self.builds[2].hasChanges(B))
3432 self.assertTrue(self.builds[2].hasChanges(C))
3433 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003434
Paul Belangerbaca3132016-11-04 12:49:54 -04003435 self.assertTrue(self.builds[4].hasChanges(B))
3436 self.assertTrue(self.builds[4].hasChanges(C))
3437 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003438
Paul Belanger174a8272017-03-14 13:20:10 -04003439 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003440 self.waitUntilSettled()
3441
3442 self.assertEqual(A.data['status'], 'MERGED')
3443 self.assertEqual(A.reported, 2)
3444 self.assertEqual(B.data['status'], 'MERGED')
3445 self.assertEqual(B.reported, 2)
3446 self.assertEqual(C.data['status'], 'MERGED')
3447 self.assertEqual(C.reported, 2)
3448
James E. Blair36658cf2013-12-06 17:53:48 -08003449 self.assertEqual(r, True)
3450
3451 def test_client_promote_negative(self):
3452 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003453 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003454 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003455 A.addApproval('Code-Review', 2)
3456 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003457 self.waitUntilSettled()
3458
3459 client = zuul.rpcclient.RPCClient('127.0.0.1',
3460 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003461 self.addCleanup(client.shutdown)
James E. Blair36658cf2013-12-06 17:53:48 -08003462
3463 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003464 r = client.promote(tenant='tenant-one',
3465 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003466 change_ids=['2,1', '3,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003467 self.assertEqual(r, False)
3468
3469 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003470 r = client.promote(tenant='tenant-one',
3471 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003472 change_ids=['4,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003473 self.assertEqual(r, False)
3474
Paul Belanger174a8272017-03-14 13:20:10 -04003475 self.executor_server.hold_jobs_in_build = False
3476 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003477 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003478
James E. Blaircc324192017-04-19 14:36:08 -07003479 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003480 def test_queue_rate_limiting(self):
3481 "Test that DependentPipelines are rate limited with dep across window"
Paul Belanger174a8272017-03-14 13:20:10 -04003482 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003483 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3484 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3485 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3486
3487 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003488 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003489
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003490 A.addApproval('Code-Review', 2)
3491 B.addApproval('Code-Review', 2)
3492 C.addApproval('Code-Review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003493
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003494 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3495 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3496 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003497 self.waitUntilSettled()
3498
3499 # Only A and B will have their merge jobs queued because
3500 # window is 2.
3501 self.assertEqual(len(self.builds), 2)
3502 self.assertEqual(self.builds[0].name, 'project-merge')
3503 self.assertEqual(self.builds[1].name, 'project-merge')
3504
James E. Blair732ee862017-04-21 07:49:26 -07003505 # Release the merge jobs one at a time.
3506 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003507 self.waitUntilSettled()
James E. Blair732ee862017-04-21 07:49:26 -07003508 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003509 self.waitUntilSettled()
3510
3511 # Only A and B will have their test jobs queued because
3512 # window is 2.
3513 self.assertEqual(len(self.builds), 4)
3514 self.assertEqual(self.builds[0].name, 'project-test1')
3515 self.assertEqual(self.builds[1].name, 'project-test2')
3516 self.assertEqual(self.builds[2].name, 'project-test1')
3517 self.assertEqual(self.builds[3].name, 'project-test2')
3518
Paul Belanger174a8272017-03-14 13:20:10 -04003519 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003520 self.waitUntilSettled()
3521
James E. Blaircc324192017-04-19 14:36:08 -07003522 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003523 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003524 # A failed so window is reduced by 1 to 1.
3525 self.assertEqual(queue.window, 1)
3526 self.assertEqual(queue.window_floor, 1)
3527 self.assertEqual(A.data['status'], 'NEW')
3528
3529 # Gate is reset and only B's merge job is queued because
3530 # window shrunk to 1.
3531 self.assertEqual(len(self.builds), 1)
3532 self.assertEqual(self.builds[0].name, 'project-merge')
3533
Paul Belanger174a8272017-03-14 13:20:10 -04003534 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003535 self.waitUntilSettled()
3536
3537 # Only B's test jobs are queued because window is still 1.
3538 self.assertEqual(len(self.builds), 2)
3539 self.assertEqual(self.builds[0].name, 'project-test1')
3540 self.assertEqual(self.builds[1].name, 'project-test2')
3541
Paul Belanger174a8272017-03-14 13:20:10 -04003542 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003543 self.waitUntilSettled()
3544
3545 # B was successfully merged so window is increased to 2.
3546 self.assertEqual(queue.window, 2)
3547 self.assertEqual(queue.window_floor, 1)
3548 self.assertEqual(B.data['status'], 'MERGED')
3549
3550 # Only C is left and its merge job is queued.
3551 self.assertEqual(len(self.builds), 1)
3552 self.assertEqual(self.builds[0].name, 'project-merge')
3553
Paul Belanger174a8272017-03-14 13:20:10 -04003554 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003555 self.waitUntilSettled()
3556
3557 # After successful merge job the test jobs for C are queued.
3558 self.assertEqual(len(self.builds), 2)
3559 self.assertEqual(self.builds[0].name, 'project-test1')
3560 self.assertEqual(self.builds[1].name, 'project-test2')
3561
Paul Belanger174a8272017-03-14 13:20:10 -04003562 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003563 self.waitUntilSettled()
3564
3565 # C successfully merged so window is bumped to 3.
3566 self.assertEqual(queue.window, 3)
3567 self.assertEqual(queue.window_floor, 1)
3568 self.assertEqual(C.data['status'], 'MERGED')
3569
James E. Blaircc324192017-04-19 14:36:08 -07003570 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003571 def test_queue_rate_limiting_dependent(self):
3572 "Test that DependentPipelines are rate limited with dep in window"
Paul Belanger174a8272017-03-14 13:20:10 -04003573 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003574 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3575 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3576 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3577
3578 B.setDependsOn(A, 1)
3579
Paul Belanger174a8272017-03-14 13:20:10 -04003580 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003581
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003582 A.addApproval('Code-Review', 2)
3583 B.addApproval('Code-Review', 2)
3584 C.addApproval('Code-Review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003585
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003586 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3587 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3588 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003589 self.waitUntilSettled()
3590
3591 # Only A and B will have their merge jobs queued because
3592 # window is 2.
3593 self.assertEqual(len(self.builds), 2)
3594 self.assertEqual(self.builds[0].name, 'project-merge')
3595 self.assertEqual(self.builds[1].name, 'project-merge')
3596
James E. Blairf4a5f022017-04-18 14:01:10 -07003597 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003598
3599 # Only A and B will have their test jobs queued because
3600 # window is 2.
3601 self.assertEqual(len(self.builds), 4)
3602 self.assertEqual(self.builds[0].name, 'project-test1')
3603 self.assertEqual(self.builds[1].name, 'project-test2')
3604 self.assertEqual(self.builds[2].name, 'project-test1')
3605 self.assertEqual(self.builds[3].name, 'project-test2')
3606
Paul Belanger174a8272017-03-14 13:20:10 -04003607 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003608 self.waitUntilSettled()
3609
James E. Blaircc324192017-04-19 14:36:08 -07003610 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003611 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003612 # A failed so window is reduced by 1 to 1.
3613 self.assertEqual(queue.window, 1)
3614 self.assertEqual(queue.window_floor, 1)
3615 self.assertEqual(A.data['status'], 'NEW')
3616 self.assertEqual(B.data['status'], 'NEW')
3617
3618 # Gate is reset and only C's merge job is queued because
3619 # window shrunk to 1 and A and B were dequeued.
3620 self.assertEqual(len(self.builds), 1)
3621 self.assertEqual(self.builds[0].name, 'project-merge')
3622
James E. Blairf4a5f022017-04-18 14:01:10 -07003623 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003624
3625 # Only C's test jobs are queued because window is still 1.
3626 self.assertEqual(len(self.builds), 2)
James E. Blairdf25ddc2017-07-08 07:57:09 -07003627 builds = self.getSortedBuilds()
3628 self.assertEqual(builds[0].name, 'project-test1')
3629 self.assertEqual(builds[1].name, 'project-test2')
Clark Boylan7603a372014-01-21 11:43:20 -08003630
Paul Belanger174a8272017-03-14 13:20:10 -04003631 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003632 self.waitUntilSettled()
3633
3634 # C was successfully merged so window is increased to 2.
3635 self.assertEqual(queue.window, 2)
3636 self.assertEqual(queue.window_floor, 1)
3637 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003638
3639 def test_worker_update_metadata(self):
3640 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003641 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003642
3643 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003644 A.addApproval('Code-Review', 2)
3645 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003646 self.waitUntilSettled()
3647
Clint Byrumd4de79a2017-05-27 11:39:13 -07003648 self.assertEqual(len(self.executor_client.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003649
3650 self.log.debug('Current builds:')
Clint Byrumd4de79a2017-05-27 11:39:13 -07003651 self.log.debug(self.executor_client.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003652
3653 start = time.time()
3654 while True:
3655 if time.time() - start > 10:
3656 raise Exception("Timeout waiting for gearman server to report "
3657 + "back to the client")
Clint Byrumd4de79a2017-05-27 11:39:13 -07003658 build = list(self.executor_client.builds.values())[0]
Monty Tayloreea6bb92017-06-14 11:56:54 -05003659 if build.worker.name == self.executor_server.hostname:
Joshua Heskethba8776a2014-01-12 14:35:40 +08003660 break
3661 else:
3662 time.sleep(0)
3663
3664 self.log.debug(build)
Monty Tayloreea6bb92017-06-14 11:56:54 -05003665 self.assertEqual(self.executor_server.hostname, build.worker.name)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003666
Paul Belanger174a8272017-03-14 13:20:10 -04003667 self.executor_server.hold_jobs_in_build = False
3668 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003669 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003670
James E. Blaircc324192017-04-19 14:36:08 -07003671 @simple_layout('layouts/footer-message.yaml')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003672 def test_footer_message(self):
3673 "Test a pipeline's footer message is correctly added to the report."
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003674 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003675 A.addApproval('Code-Review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003676 self.executor_server.failJob('project-test1', A)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003677 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003678 self.waitUntilSettled()
3679
3680 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003681 B.addApproval('Code-Review', 2)
3682 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003683 self.waitUntilSettled()
3684
3685 self.assertEqual(2, len(self.smtp_messages))
3686
Adam Gandelman82258fd2017-02-07 16:51:58 -08003687 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003688Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003689http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003690
Adam Gandelman82258fd2017-02-07 16:51:58 -08003691 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003692For CI problems and help debugging, contact ci@example.org"""
3693
Adam Gandelman82258fd2017-02-07 16:51:58 -08003694 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3695 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3696 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3697 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003698
Tobias Henkel9842bd72017-05-16 13:40:03 +02003699 @simple_layout('layouts/unmanaged-project.yaml')
3700 def test_unmanaged_project_start_message(self):
3701 "Test start reporting is not done for unmanaged projects."
3702 self.init_repo("org/project", tag='init')
3703 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3704 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3705 self.waitUntilSettled()
3706
3707 self.assertEqual(0, len(A.messages))
3708
Clint Byrumb9de8be2017-05-27 13:49:19 -07003709 @simple_layout('layouts/merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003710 def test_merge_failure_reporters(self):
3711 """Check that the config is set up correctly"""
3712
Clint Byrumb9de8be2017-05-27 13:49:19 -07003713 tenant = self.sched.abide.tenants.get('tenant-one')
Joshua Heskethb7179772014-01-30 23:30:46 +11003714 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003715 "Merge Failed.\n\nThis change or one of its cross-repo "
3716 "dependencies was unable to be automatically merged with the "
3717 "current state of its repository. Please rebase the change and "
3718 "upload a new patchset.",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003719 tenant.layout.pipelines['check'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003720 self.assertEqual(
3721 "The merge failed! For more information...",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003722 tenant.layout.pipelines['gate'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003723
3724 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003725 len(tenant.layout.pipelines['check'].merge_failure_actions), 1)
Joshua Heskethb7179772014-01-30 23:30:46 +11003726 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003727 len(tenant.layout.pipelines['gate'].merge_failure_actions), 2)
Joshua Heskethb7179772014-01-30 23:30:46 +11003728
3729 self.assertTrue(isinstance(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003730 tenant.layout.pipelines['check'].merge_failure_actions[0],
3731 gerritreporter.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003732
3733 self.assertTrue(
3734 (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003735 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003736 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003737 zuul.driver.smtp.smtpreporter.SMTPReporter) and
3738 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003739 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003740 gerritreporter.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003741 ) or (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003742 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003743 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003744 gerritreporter.GerritReporter) and
3745 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003746 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003747 zuul.driver.smtp.smtpreporter.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003748 )
3749 )
3750
James E. Blairec056492016-07-22 09:45:56 -07003751 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003752 def test_merge_failure_reports(self):
3753 """Check that when a change fails to merge the correct message is sent
3754 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003755 self.updateConfigLayout(
3756 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003757 self.sched.reconfigure(self.config)
3758 self.registerJobs()
3759
3760 # Check a test failure isn't reported to SMTP
3761 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003762 A.addApproval('Code-Review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003763 self.executor_server.failJob('project-test1', A)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003764 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003765 self.waitUntilSettled()
3766
3767 self.assertEqual(3, len(self.history)) # 3 jobs
3768 self.assertEqual(0, len(self.smtp_messages))
3769
3770 # Check a merge failure is reported to SMTP
3771 # B should be merged, but C will conflict with B
3772 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3773 B.addPatchset(['conflict'])
3774 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3775 C.addPatchset(['conflict'])
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003776 B.addApproval('Code-Review', 2)
3777 C.addApproval('Code-Review', 2)
3778 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
3779 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003780 self.waitUntilSettled()
3781
3782 self.assertEqual(6, len(self.history)) # A and B jobs
3783 self.assertEqual(1, len(self.smtp_messages))
3784 self.assertEqual('The merge failed! For more information...',
3785 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003786
James E. Blairec056492016-07-22 09:45:56 -07003787 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003788 def test_default_merge_failure_reports(self):
3789 """Check that the default merge failure reports are correct."""
3790
3791 # A should report success, B should report merge failure.
3792 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3793 A.addPatchset(['conflict'])
3794 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3795 B.addPatchset(['conflict'])
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003796 A.addApproval('Code-Review', 2)
3797 B.addApproval('Code-Review', 2)
3798 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
3799 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003800 self.waitUntilSettled()
3801
3802 self.assertEqual(3, len(self.history)) # A jobs
3803 self.assertEqual(A.reported, 2)
3804 self.assertEqual(B.reported, 2)
3805 self.assertEqual(A.data['status'], 'MERGED')
3806 self.assertEqual(B.data['status'], 'NEW')
3807 self.assertIn('Build succeeded', A.messages[1])
3808 self.assertIn('Merge Failed', B.messages[1])
3809 self.assertIn('automatically merged', B.messages[1])
3810 self.assertNotIn('logs.example.com', B.messages[1])
3811 self.assertNotIn('SKIPPED', B.messages[1])
3812
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003813 def test_client_get_running_jobs(self):
3814 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003815 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003816 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003817 A.addApproval('Code-Review', 2)
3818 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003819 self.waitUntilSettled()
3820
3821 client = zuul.rpcclient.RPCClient('127.0.0.1',
3822 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003823 self.addCleanup(client.shutdown)
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003824
3825 # Wait for gearman server to send the initial workData back to zuul
3826 start = time.time()
3827 while True:
3828 if time.time() - start > 10:
3829 raise Exception("Timeout waiting for gearman server to report "
3830 + "back to the client")
Clint Byrum1d0c7d12017-05-10 19:40:53 -07003831 build = list(self.executor_client.builds.values())[0]
Monty Tayloreea6bb92017-06-14 11:56:54 -05003832 if build.worker.name == self.executor_server.hostname:
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003833 break
3834 else:
3835 time.sleep(0)
3836
3837 running_items = client.get_running_jobs()
3838
3839 self.assertEqual(1, len(running_items))
3840 running_item = running_items[0]
3841 self.assertEqual([], running_item['failing_reasons'])
3842 self.assertEqual([], running_item['items_behind'])
3843 self.assertEqual('https://hostname/1', running_item['url'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003844 self.assertIsNone(running_item['item_ahead'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003845 self.assertEqual('org/project', running_item['project'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003846 self.assertIsNone(running_item['remaining_time'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003847 self.assertEqual(True, running_item['active'])
3848 self.assertEqual('1,1', running_item['id'])
3849
3850 self.assertEqual(3, len(running_item['jobs']))
3851 for job in running_item['jobs']:
3852 if job['name'] == 'project-merge':
3853 self.assertEqual('project-merge', job['name'])
3854 self.assertEqual('gate', job['pipeline'])
3855 self.assertEqual(False, job['retry'])
Monty Taylor51139a02016-05-24 11:28:10 -05003856 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02003857 'static/stream.html?uuid={uuid}&logfile=console.log'
3858 .format(uuid=job['uuid']), job['url'])
3859 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05003860 'finger://{hostname}/{uuid}'.format(
3861 hostname=self.executor_server.hostname,
3862 uuid=job['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02003863 job['finger_url'])
Clint Byrumd4de79a2017-05-27 11:39:13 -07003864 self.assertEqual(2, len(job['worker']))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003865 self.assertEqual(False, job['canceled'])
3866 self.assertEqual(True, job['voting'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003867 self.assertIsNone(job['result'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003868 self.assertEqual('gate', job['pipeline'])
3869 break
3870
Paul Belanger174a8272017-03-14 13:20:10 -04003871 self.executor_server.hold_jobs_in_build = False
3872 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003873 self.waitUntilSettled()
3874
3875 running_items = client.get_running_jobs()
3876 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003877
James E. Blairb70e55a2017-04-19 12:57:02 -07003878 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003879 def test_nonvoting_pipeline(self):
3880 "Test that a nonvoting pipeline (experimental) can still report"
3881
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003882 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3883 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003884 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3885 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003886
3887 self.assertEqual(self.getJobFromHistory('project-merge').result,
3888 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003889 self.assertEqual(
3890 self.getJobFromHistory('experimental-project-test').result,
3891 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003892 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003893
3894 def test_crd_gate(self):
3895 "Test cross-repo dependencies"
3896 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3897 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003898 A.addApproval('Code-Review', 2)
3899 B.addApproval('Code-Review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003900
3901 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3902 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3903 AM2.setMerged()
3904 AM1.setMerged()
3905
3906 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3907 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3908 BM2.setMerged()
3909 BM1.setMerged()
3910
3911 # A -> AM1 -> AM2
3912 # B -> BM1 -> BM2
3913 # A Depends-On: B
3914 # M2 is here to make sure it is never queried. If it is, it
3915 # means zuul is walking down the entire history of merged
3916 # changes.
3917
3918 B.setDependsOn(BM1, 1)
3919 BM1.setDependsOn(BM2, 1)
3920
3921 A.setDependsOn(AM1, 1)
3922 AM1.setDependsOn(AM2, 1)
3923
3924 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3925 A.subject, B.data['id'])
3926
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003927 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003928 self.waitUntilSettled()
3929
3930 self.assertEqual(A.data['status'], 'NEW')
3931 self.assertEqual(B.data['status'], 'NEW')
3932
Paul Belanger5dccbe72016-11-14 11:17:37 -05003933 for connection in self.connections.connections.values():
James E. Blairb0a95ab2017-10-18 09:39:18 -07003934 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003935
Paul Belanger174a8272017-03-14 13:20:10 -04003936 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003937 B.addApproval('Approved', 1)
3938 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003939 self.waitUntilSettled()
3940
Paul Belanger174a8272017-03-14 13:20:10 -04003941 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003942 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003943 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003944 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003945 self.executor_server.hold_jobs_in_build = False
3946 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003947 self.waitUntilSettled()
3948
3949 self.assertEqual(AM2.queried, 0)
3950 self.assertEqual(BM2.queried, 0)
3951 self.assertEqual(A.data['status'], 'MERGED')
3952 self.assertEqual(B.data['status'], 'MERGED')
3953 self.assertEqual(A.reported, 2)
3954 self.assertEqual(B.reported, 2)
3955
Paul Belanger5dccbe72016-11-14 11:17:37 -05003956 changes = self.getJobFromHistory(
3957 'project-merge', 'org/project1').changes
3958 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003959
3960 def test_crd_branch(self):
3961 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003962
3963 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003964 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3965 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04003966 C1 = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C1')
3967 C2 = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C2',
3968 status='ABANDONED')
3969 C1.data['id'] = B.data['id']
3970 C2.data['id'] = B.data['id']
3971
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003972 A.addApproval('Code-Review', 2)
3973 B.addApproval('Code-Review', 2)
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04003974 C1.addApproval('Code-Review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003975
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04003976 # A Depends-On: B+C1
James E. Blair8f78d882015-02-05 08:51:37 -08003977 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3978 A.subject, B.data['id'])
3979
Paul Belanger174a8272017-03-14 13:20:10 -04003980 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003981 B.addApproval('Approved', 1)
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04003982 C1.addApproval('Approved', 1)
Tobias Henkelbf24fd12017-07-27 06:13:07 +02003983 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003984 self.waitUntilSettled()
3985
Paul Belanger174a8272017-03-14 13:20:10 -04003986 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003987 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003988 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003989 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003990 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003991 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003992 self.executor_server.hold_jobs_in_build = False
3993 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003994 self.waitUntilSettled()
3995
3996 self.assertEqual(A.data['status'], 'MERGED')
3997 self.assertEqual(B.data['status'], 'MERGED')
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04003998 self.assertEqual(C1.data['status'], 'MERGED')
James E. Blair8f78d882015-02-05 08:51:37 -08003999 self.assertEqual(A.reported, 2)
4000 self.assertEqual(B.reported, 2)
K Jonathan Harkerd1d51d22017-08-23 11:57:40 -04004001 self.assertEqual(C1.reported, 2)
James E. Blair8f78d882015-02-05 08:51:37 -08004002
Paul Belanger6379db12016-11-14 13:57:54 -05004003 changes = self.getJobFromHistory(
4004 'project-merge', 'org/project1').changes
4005 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08004006
4007 def test_crd_multiline(self):
4008 "Test multiple depends-on lines in commit"
4009 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4010 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4011 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004012 A.addApproval('Code-Review', 2)
4013 B.addApproval('Code-Review', 2)
4014 C.addApproval('Code-Review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08004015
4016 # A Depends-On: B+C
4017 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
4018 A.subject, B.data['id'], C.data['id'])
4019
Paul Belanger174a8272017-03-14 13:20:10 -04004020 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004021 B.addApproval('Approved', 1)
4022 C.addApproval('Approved', 1)
4023 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08004024 self.waitUntilSettled()
4025
Paul Belanger174a8272017-03-14 13:20:10 -04004026 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004027 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004028 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004029 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004030 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08004031 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004032 self.executor_server.hold_jobs_in_build = False
4033 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08004034 self.waitUntilSettled()
4035
4036 self.assertEqual(A.data['status'], 'MERGED')
4037 self.assertEqual(B.data['status'], 'MERGED')
4038 self.assertEqual(C.data['status'], 'MERGED')
4039 self.assertEqual(A.reported, 2)
4040 self.assertEqual(B.reported, 2)
4041 self.assertEqual(C.reported, 2)
4042
Paul Belanger5dccbe72016-11-14 11:17:37 -05004043 changes = self.getJobFromHistory(
4044 'project-merge', 'org/project1').changes
4045 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08004046
4047 def test_crd_unshared_gate(self):
4048 "Test cross-repo dependencies in unshared gate queues"
4049 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4050 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004051 A.addApproval('Code-Review', 2)
4052 B.addApproval('Code-Review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08004053
4054 # A Depends-On: B
4055 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4056 A.subject, B.data['id'])
4057
4058 # A and B do not share a queue, make sure that A is unable to
4059 # enqueue B (and therefore, A is unable to be enqueued).
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004060 B.addApproval('Approved', 1)
4061 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004062 self.waitUntilSettled()
4063
4064 self.assertEqual(A.data['status'], 'NEW')
4065 self.assertEqual(B.data['status'], 'NEW')
4066 self.assertEqual(A.reported, 0)
4067 self.assertEqual(B.reported, 0)
4068 self.assertEqual(len(self.history), 0)
4069
4070 # Enqueue and merge B alone.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004071 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004072 self.waitUntilSettled()
4073
4074 self.assertEqual(B.data['status'], 'MERGED')
4075 self.assertEqual(B.reported, 2)
4076
4077 # Now that B is merged, A should be able to be enqueued and
4078 # merged.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004079 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004080 self.waitUntilSettled()
4081
4082 self.assertEqual(A.data['status'], 'MERGED')
4083 self.assertEqual(A.reported, 2)
4084
James E. Blair96698e22015-04-02 07:48:21 -07004085 def test_crd_gate_reverse(self):
4086 "Test reverse cross-repo dependencies"
4087 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4088 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004089 A.addApproval('Code-Review', 2)
4090 B.addApproval('Code-Review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07004091
4092 # A Depends-On: B
4093
4094 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4095 A.subject, B.data['id'])
4096
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004097 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07004098 self.waitUntilSettled()
4099
4100 self.assertEqual(A.data['status'], 'NEW')
4101 self.assertEqual(B.data['status'], 'NEW')
4102
Paul Belanger174a8272017-03-14 13:20:10 -04004103 self.executor_server.hold_jobs_in_build = True
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004104 A.addApproval('Approved', 1)
4105 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07004106 self.waitUntilSettled()
4107
Paul Belanger174a8272017-03-14 13:20:10 -04004108 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07004109 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004110 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07004111 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004112 self.executor_server.hold_jobs_in_build = False
4113 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07004114 self.waitUntilSettled()
4115
4116 self.assertEqual(A.data['status'], 'MERGED')
4117 self.assertEqual(B.data['status'], 'MERGED')
4118 self.assertEqual(A.reported, 2)
4119 self.assertEqual(B.reported, 2)
4120
Paul Belanger5dccbe72016-11-14 11:17:37 -05004121 changes = self.getJobFromHistory(
4122 'project-merge', 'org/project1').changes
4123 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07004124
James E. Blair5ee24252014-12-30 10:12:29 -08004125 def test_crd_cycle(self):
4126 "Test cross-repo dependency cycles"
4127 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4128 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004129 A.addApproval('Code-Review', 2)
4130 B.addApproval('Code-Review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08004131
4132 # A -> B -> A (via commit-depends)
4133
4134 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4135 A.subject, B.data['id'])
4136 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4137 B.subject, A.data['id'])
4138
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004139 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08004140 self.waitUntilSettled()
4141
4142 self.assertEqual(A.reported, 0)
4143 self.assertEqual(B.reported, 0)
4144 self.assertEqual(A.data['status'], 'NEW')
4145 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08004146
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004147 def test_crd_gate_unknown(self):
4148 "Test unknown projects in dependent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004149 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004150 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4151 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004152 A.addApproval('Code-Review', 2)
4153 B.addApproval('Code-Review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004154
4155 # A Depends-On: B
4156 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4157 A.subject, B.data['id'])
4158
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004159 B.addApproval('Approved', 1)
4160 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004161 self.waitUntilSettled()
4162
4163 # Unknown projects cannot share a queue with any other
4164 # since they don't have common jobs with any other (they have no jobs).
4165 # Changes which depend on unknown project changes
4166 # should not be processed in dependent pipeline
4167 self.assertEqual(A.data['status'], 'NEW')
4168 self.assertEqual(B.data['status'], 'NEW')
4169 self.assertEqual(A.reported, 0)
4170 self.assertEqual(B.reported, 0)
4171 self.assertEqual(len(self.history), 0)
4172
James E. Blair7720b402017-06-07 08:51:49 -07004173 # Simulate change B being gated outside this layout Set the
4174 # change merged before submitting the event so that when the
4175 # event triggers a gerrit query to update the change, we get
4176 # the information that it was merged.
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004177 B.setMerged()
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004178 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004179 self.waitUntilSettled()
4180 self.assertEqual(len(self.history), 0)
4181
4182 # Now that B is merged, A should be able to be enqueued and
4183 # merged.
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004184 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004185 self.waitUntilSettled()
4186
4187 self.assertEqual(A.data['status'], 'MERGED')
4188 self.assertEqual(A.reported, 2)
4189 self.assertEqual(B.data['status'], 'MERGED')
4190 self.assertEqual(B.reported, 0)
4191
James E. Blairbfb8e042014-12-30 17:01:44 -08004192 def test_crd_check(self):
4193 "Test cross-repo dependencies in independent pipelines"
4194
Paul Belanger174a8272017-03-14 13:20:10 -04004195 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08004196 self.gearman_server.hold_jobs_in_queue = True
4197 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4198 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4199
4200 # A Depends-On: B
4201 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4202 A.subject, B.data['id'])
4203
4204 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4205 self.waitUntilSettled()
4206
James E. Blairbfb8e042014-12-30 17:01:44 -08004207 self.gearman_server.hold_jobs_in_queue = False
4208 self.gearman_server.release()
4209 self.waitUntilSettled()
4210
Paul Belanger174a8272017-03-14 13:20:10 -04004211 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05004212 self.waitUntilSettled()
4213
James E. Blair2a535672017-04-27 12:03:15 -07004214 self.assertTrue(self.builds[0].hasChanges(A, B))
James E. Blairbfb8e042014-12-30 17:01:44 -08004215
Paul Belanger174a8272017-03-14 13:20:10 -04004216 self.executor_server.hold_jobs_in_build = False
4217 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05004218 self.waitUntilSettled()
4219
James E. Blairbfb8e042014-12-30 17:01:44 -08004220 self.assertEqual(A.data['status'], 'NEW')
4221 self.assertEqual(B.data['status'], 'NEW')
4222 self.assertEqual(A.reported, 1)
4223 self.assertEqual(B.reported, 0)
4224
4225 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05004226 tenant = self.sched.abide.tenants.get('tenant-one')
4227 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08004228
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004229 def test_crd_check_git_depends(self):
4230 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07004231 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004232 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4233 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4234
4235 # Add two git-dependent changes and make sure they both report
4236 # success.
4237 B.setDependsOn(A, 1)
4238 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4239 self.waitUntilSettled()
4240 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4241 self.waitUntilSettled()
4242
James E. Blairb8c16472015-05-05 14:55:26 -07004243 self.orderedRelease()
4244 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004245 self.waitUntilSettled()
4246
4247 self.assertEqual(A.data['status'], 'NEW')
4248 self.assertEqual(B.data['status'], 'NEW')
4249 self.assertEqual(A.reported, 1)
4250 self.assertEqual(B.reported, 1)
4251
4252 self.assertEqual(self.history[0].changes, '1,1')
4253 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04004254 tenant = self.sched.abide.tenants.get('tenant-one')
4255 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004256
4257 self.assertIn('Build succeeded', A.messages[0])
4258 self.assertIn('Build succeeded', B.messages[0])
4259
4260 def test_crd_check_duplicate(self):
4261 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04004262 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004263 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4264 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04004265 tenant = self.sched.abide.tenants.get('tenant-one')
4266 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004267
4268 # Add two git-dependent changes...
4269 B.setDependsOn(A, 1)
4270 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4271 self.waitUntilSettled()
4272 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4273
4274 # ...make sure the live one is not duplicated...
4275 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4276 self.waitUntilSettled()
4277 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4278
4279 # ...but the non-live one is able to be.
4280 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4281 self.waitUntilSettled()
4282 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4283
Clark Boylandd849822015-03-02 12:38:14 -08004284 # Release jobs in order to avoid races with change A jobs
4285 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07004286 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04004287 self.executor_server.hold_jobs_in_build = False
4288 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004289 self.waitUntilSettled()
4290
4291 self.assertEqual(A.data['status'], 'NEW')
4292 self.assertEqual(B.data['status'], 'NEW')
4293 self.assertEqual(A.reported, 1)
4294 self.assertEqual(B.reported, 1)
4295
4296 self.assertEqual(self.history[0].changes, '1,1 2,1')
4297 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04004298 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004299
4300 self.assertIn('Build succeeded', A.messages[0])
4301 self.assertIn('Build succeeded', B.messages[0])
4302
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004303 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08004304 "Test cross-repo dependencies re-enqueued in independent pipelines"
4305
4306 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004307 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
4308 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08004309
4310 # A Depends-On: B
4311 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4312 A.subject, B.data['id'])
4313
4314 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4315 self.waitUntilSettled()
4316
4317 self.sched.reconfigure(self.config)
4318
4319 # Make sure the items still share a change queue, and the
4320 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05004321 tenant = self.sched.abide.tenants.get('tenant-one')
4322 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
4323 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08004324 first_item = queue.queue[0]
4325 for item in queue.queue:
4326 self.assertEqual(item.queue, first_item.queue)
4327 self.assertFalse(first_item.live)
4328 self.assertTrue(queue.queue[1].live)
4329
4330 self.gearman_server.hold_jobs_in_queue = False
4331 self.gearman_server.release()
4332 self.waitUntilSettled()
4333
4334 self.assertEqual(A.data['status'], 'NEW')
4335 self.assertEqual(B.data['status'], 'NEW')
4336 self.assertEqual(A.reported, 1)
4337 self.assertEqual(B.reported, 0)
4338
4339 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004340 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004341
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004342 def test_crd_check_reconfiguration(self):
4343 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4344
4345 def test_crd_undefined_project(self):
4346 """Test that undefined projects in dependencies are handled for
4347 independent pipelines"""
4348 # It's a hack for fake gerrit,
4349 # as it implies repo creation upon the creation of any change
James E. Blairc4ba97a2017-04-19 16:26:24 -07004350 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004351 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4352
Jesse Keatingea68ab42017-04-19 15:03:30 -07004353 @simple_layout('layouts/ignore-dependencies.yaml')
James E. Blair17dd6772015-02-09 14:45:18 -08004354 def test_crd_check_ignore_dependencies(self):
4355 "Test cross-repo dependencies can be ignored"
James E. Blair17dd6772015-02-09 14:45:18 -08004356
4357 self.gearman_server.hold_jobs_in_queue = True
4358 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4359 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4360 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4361
4362 # A Depends-On: B
4363 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4364 A.subject, B.data['id'])
4365 # C git-depends on B
4366 C.setDependsOn(B, 1)
4367 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4368 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4369 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4370 self.waitUntilSettled()
4371
4372 # Make sure none of the items share a change queue, and all
4373 # are live.
Jesse Keatingea68ab42017-04-19 15:03:30 -07004374 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum12282ca2017-04-03 11:04:02 -07004375 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004376 self.assertEqual(len(check_pipeline.queues), 3)
4377 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4378 for item in check_pipeline.getAllItems():
4379 self.assertTrue(item.live)
4380
4381 self.gearman_server.hold_jobs_in_queue = False
4382 self.gearman_server.release()
4383 self.waitUntilSettled()
4384
4385 self.assertEqual(A.data['status'], 'NEW')
4386 self.assertEqual(B.data['status'], 'NEW')
4387 self.assertEqual(C.data['status'], 'NEW')
4388 self.assertEqual(A.reported, 1)
4389 self.assertEqual(B.reported, 1)
4390 self.assertEqual(C.reported, 1)
4391
4392 # Each job should have tested exactly one change
4393 for job in self.history:
4394 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004395
James E. Blair7cb84542017-04-19 13:35:05 -07004396 @simple_layout('layouts/three-projects.yaml')
James E. Blair96698e22015-04-02 07:48:21 -07004397 def test_crd_check_transitive(self):
4398 "Test transitive cross-repo dependencies"
4399 # Specifically, if A -> B -> C, and C gets a new patchset and
4400 # A gets a new patchset, ensure the test of A,2 includes B,1
4401 # and C,2 (not C,1 which would indicate stale data in the
4402 # cache for B).
4403 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4404 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4405 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4406
4407 # A Depends-On: B
4408 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4409 A.subject, B.data['id'])
4410
4411 # B Depends-On: C
4412 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4413 B.subject, C.data['id'])
4414
4415 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4416 self.waitUntilSettled()
4417 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4418
4419 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4420 self.waitUntilSettled()
4421 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4422
4423 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4424 self.waitUntilSettled()
4425 self.assertEqual(self.history[-1].changes, '3,1')
4426
4427 C.addPatchset()
4428 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4429 self.waitUntilSettled()
4430 self.assertEqual(self.history[-1].changes, '3,2')
4431
4432 A.addPatchset()
4433 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4434 self.waitUntilSettled()
4435 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004436
James E. Blaira8b90b32016-08-24 15:18:50 -07004437 def test_crd_check_unknown(self):
4438 "Test unknown projects in independent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004439 self.init_repo("org/unknown", tag='init')
James E. Blaira8b90b32016-08-24 15:18:50 -07004440 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4441 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4442 # A Depends-On: B
4443 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4444 A.subject, B.data['id'])
4445
4446 # Make sure zuul has seen an event on B.
4447 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4448 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4449 self.waitUntilSettled()
4450
4451 self.assertEqual(A.data['status'], 'NEW')
4452 self.assertEqual(A.reported, 1)
4453 self.assertEqual(B.data['status'], 'NEW')
4454 self.assertEqual(B.reported, 0)
4455
James E. Blair92464a22016-04-05 10:21:26 -07004456 def test_crd_cycle_join(self):
4457 "Test an updated change creates a cycle"
4458 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4459
4460 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4461 self.waitUntilSettled()
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004462 self.assertEqual(A.reported, 1)
James E. Blair92464a22016-04-05 10:21:26 -07004463
4464 # Create B->A
4465 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4466 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4467 B.subject, A.data['id'])
4468 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4469 self.waitUntilSettled()
4470
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004471 # Dep is there so zuul should have reported on B
4472 self.assertEqual(B.reported, 1)
4473
James E. Blair92464a22016-04-05 10:21:26 -07004474 # Update A to add A->B (a cycle).
4475 A.addPatchset()
4476 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4477 A.subject, B.data['id'])
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004478 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4479 self.waitUntilSettled()
James E. Blair92464a22016-04-05 10:21:26 -07004480
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004481 # Dependency cycle injected so zuul should not have reported again on A
4482 self.assertEqual(A.reported, 1)
James E. Blair92464a22016-04-05 10:21:26 -07004483
4484 # Now if we update B to remove the depends-on, everything
4485 # should be okay. B; A->B
4486
4487 B.addPatchset()
4488 B.data['commitMessage'] = '%s\n' % (B.subject,)
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004489 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4490 self.waitUntilSettled()
Paul Belanger0e155e22016-11-14 14:12:23 -05004491
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004492 # Cycle was removed so now zuul should have reported again on A
4493 self.assertEqual(A.reported, 2)
4494
4495 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
4496 self.waitUntilSettled()
4497 self.assertEqual(B.reported, 2)
James E. Blair92464a22016-04-05 10:21:26 -07004498
Jesse Keatingcc67b122017-04-19 14:54:57 -07004499 @simple_layout('layouts/disable_at.yaml')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004500 def test_disable_at(self):
4501 "Test a pipeline will only report to the disabled trigger when failing"
4502
Jesse Keatingcc67b122017-04-19 14:54:57 -07004503 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004504 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004505 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004506 0, tenant.layout.pipelines['check']._consecutive_failures)
4507 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004508
4509 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4510 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4511 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4512 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4513 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4514 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4515 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4516 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4517 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4518 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4519 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4520
Paul Belanger174a8272017-03-14 13:20:10 -04004521 self.executor_server.failJob('project-test1', A)
4522 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004523 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004524 self.executor_server.failJob('project-test1', D)
4525 self.executor_server.failJob('project-test1', E)
4526 self.executor_server.failJob('project-test1', F)
4527 self.executor_server.failJob('project-test1', G)
4528 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004529 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004530 self.executor_server.failJob('project-test1', J)
4531 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004532
4533 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4534 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4535 self.waitUntilSettled()
4536
4537 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004538 2, tenant.layout.pipelines['check']._consecutive_failures)
4539 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004540
4541 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4542 self.waitUntilSettled()
4543
4544 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004545 0, tenant.layout.pipelines['check']._consecutive_failures)
4546 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004547
4548 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4549 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4550 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4551 self.waitUntilSettled()
4552
4553 # We should be disabled now
4554 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004555 3, tenant.layout.pipelines['check']._consecutive_failures)
4556 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004557
4558 # We need to wait between each of these patches to make sure the
4559 # smtp messages come back in an expected order
4560 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4561 self.waitUntilSettled()
4562 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4563 self.waitUntilSettled()
4564 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4565 self.waitUntilSettled()
4566
4567 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4568 # leaving a message on each change
4569 self.assertEqual(1, len(A.messages))
4570 self.assertIn('Build failed.', A.messages[0])
4571 self.assertEqual(1, len(B.messages))
4572 self.assertIn('Build failed.', B.messages[0])
4573 self.assertEqual(1, len(C.messages))
4574 self.assertIn('Build succeeded.', C.messages[0])
4575 self.assertEqual(1, len(D.messages))
4576 self.assertIn('Build failed.', D.messages[0])
4577 self.assertEqual(1, len(E.messages))
4578 self.assertIn('Build failed.', E.messages[0])
4579 self.assertEqual(1, len(F.messages))
4580 self.assertIn('Build failed.', F.messages[0])
4581
4582 # The last 3 (GHI) would have only reported via smtp.
4583 self.assertEqual(3, len(self.smtp_messages))
4584 self.assertEqual(0, len(G.messages))
4585 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004586 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004587 'project-test1 finger://', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004588 self.assertEqual(0, len(H.messages))
4589 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004590 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004591 'project-test1 finger://', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004592 self.assertEqual(0, len(I.messages))
4593 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004594 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004595 'project-test1 finger://', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004596
4597 # Now reload the configuration (simulate a HUP) to check the pipeline
4598 # comes out of disabled
4599 self.sched.reconfigure(self.config)
4600
Jesse Keatingcc67b122017-04-19 14:54:57 -07004601 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004602
4603 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004604 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004605 0, tenant.layout.pipelines['check']._consecutive_failures)
4606 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004607
4608 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4609 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4610 self.waitUntilSettled()
4611
4612 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004613 2, tenant.layout.pipelines['check']._consecutive_failures)
4614 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004615
4616 # J and K went back to gerrit
4617 self.assertEqual(1, len(J.messages))
4618 self.assertIn('Build failed.', J.messages[0])
4619 self.assertEqual(1, len(K.messages))
4620 self.assertIn('Build failed.', K.messages[0])
4621 # No more messages reported via smtp
4622 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004623
James E. Blaircc020532017-04-19 13:04:44 -07004624 @simple_layout('layouts/one-job-project.yaml')
4625 def test_one_job_project(self):
4626 "Test that queueing works with one job"
4627 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4628 'master', 'A')
4629 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4630 'master', 'B')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004631 A.addApproval('Code-Review', 2)
4632 B.addApproval('Code-Review', 2)
4633 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
4634 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
James E. Blaircc020532017-04-19 13:04:44 -07004635 self.waitUntilSettled()
4636
4637 self.assertEqual(A.data['status'], 'MERGED')
4638 self.assertEqual(A.reported, 2)
4639 self.assertEqual(B.data['status'], 'MERGED')
4640 self.assertEqual(B.reported, 2)
4641
Paul Belanger32023542017-10-06 14:48:50 -04004642 def test_job_aborted(self):
4643 "Test that if a execute server aborts a job, it is run again"
4644 self.executor_server.hold_jobs_in_build = True
4645 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4646 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4647 self.waitUntilSettled()
4648
4649 self.executor_server.release('.*-merge')
4650 self.waitUntilSettled()
4651
4652 self.assertEqual(len(self.builds), 2)
Tobias Henkel26fa8a32017-10-07 07:08:36 +00004653
4654 # first abort
4655 self.builds[0].aborted = True
4656 self.executor_server.release('.*-test*')
4657 self.waitUntilSettled()
4658 self.assertEqual(len(self.builds), 1)
4659
4660 # second abort
4661 self.builds[0].aborted = True
4662 self.executor_server.release('.*-test*')
4663 self.waitUntilSettled()
4664 self.assertEqual(len(self.builds), 1)
4665
4666 # third abort
4667 self.builds[0].aborted = True
4668 self.executor_server.release('.*-test*')
4669 self.waitUntilSettled()
4670 self.assertEqual(len(self.builds), 1)
4671
4672 # fourth abort
Paul Belanger32023542017-10-06 14:48:50 -04004673 self.builds[0].aborted = True
4674 self.executor_server.release('.*-test*')
4675 self.waitUntilSettled()
4676 self.assertEqual(len(self.builds), 1)
4677
4678 self.executor_server.hold_jobs_in_build = False
4679 self.executor_server.release()
4680 self.waitUntilSettled()
4681
Tobias Henkel26fa8a32017-10-07 07:08:36 +00004682 self.assertEqual(len(self.history), 7)
4683 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
Paul Belanger32023542017-10-06 14:48:50 -04004684 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
4685
Paul Belanger71d98172016-11-08 10:56:31 -05004686 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004687 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004688
Paul Belanger174a8272017-03-14 13:20:10 -04004689 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004690 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4691 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4692 self.waitUntilSettled()
4693
Paul Belanger174a8272017-03-14 13:20:10 -04004694 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004695 self.waitUntilSettled()
4696
4697 self.assertEqual(len(self.builds), 2)
4698 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004699 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004700 self.waitUntilSettled()
4701
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004702 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004703 self.assertEqual(len(self.builds), 1,
4704 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004705 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004706 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004707 self.waitUntilSettled()
4708
Paul Belanger174a8272017-03-14 13:20:10 -04004709 self.executor_server.hold_jobs_in_build = False
4710 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004711 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004712 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004713 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4714 self.assertEqual(A.reported, 1)
4715 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004716
James E. Blair15be0e12017-01-03 13:45:20 -08004717 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004718 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004719
4720 self.fake_nodepool.paused = True
4721 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004722 A.addApproval('Code-Review', 2)
4723 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair15be0e12017-01-03 13:45:20 -08004724 self.waitUntilSettled()
4725
4726 self.zk.client.stop()
4727 self.zk.client.start()
4728 self.fake_nodepool.paused = False
4729 self.waitUntilSettled()
4730
4731 self.assertEqual(A.data['status'], 'MERGED')
4732 self.assertEqual(A.reported, 2)
4733
James E. Blair6ab79e02017-01-06 10:10:17 -08004734 def test_nodepool_failure(self):
4735 "Test that jobs are reported after a nodepool failure"
4736
4737 self.fake_nodepool.paused = True
4738 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004739 A.addApproval('Code-Review', 2)
4740 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blair6ab79e02017-01-06 10:10:17 -08004741 self.waitUntilSettled()
4742
4743 req = self.fake_nodepool.getNodeRequests()[0]
4744 self.fake_nodepool.addFailRequest(req)
4745
4746 self.fake_nodepool.paused = False
4747 self.waitUntilSettled()
4748
4749 self.assertEqual(A.data['status'], 'NEW')
4750 self.assertEqual(A.reported, 2)
4751 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4752 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4753 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4754
Monty Taylor6dc5bc12017-09-29 15:47:31 -05004755 def test_nodepool_priority(self):
4756 "Test that nodes are requested at the correct priority"
4757
4758 self.fake_nodepool.paused = True
4759
4760 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4761 self.fake_gerrit.addEvent(A.getRefUpdatedEvent())
4762
4763 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4764 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4765
4766 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4767 C.addApproval('Code-Review', 2)
4768 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
4769
4770 self.waitUntilSettled()
4771
4772 reqs = self.fake_nodepool.getNodeRequests()
4773
4774 # The requests come back sorted by oid. Since we have three requests
4775 # for the three changes each with a different priority.
4776 # Also they get a serial number based on order they were received
4777 # so the number on the endof the oid should map to order submitted.
4778
4779 # * gate first - high priority - change C
4780 self.assertEqual(reqs[0]['_oid'], '100-0000000002')
4781 self.assertEqual(reqs[0]['node_types'], ['label1'])
4782 # * check second - normal priority - change B
4783 self.assertEqual(reqs[1]['_oid'], '200-0000000001')
4784 self.assertEqual(reqs[1]['node_types'], ['label1'])
4785 # * post third - low priority - change A
4786 # additionally, the post job defined uses an ubuntu-xenial node,
4787 # so we include that check just as an extra verification
4788 self.assertEqual(reqs[2]['_oid'], '300-0000000000')
4789 self.assertEqual(reqs[2]['node_types'], ['ubuntu-xenial'])
4790
4791 self.fake_nodepool.paused = False
4792 self.waitUntilSettled()
4793
James E. Blairfceaf412017-09-29 13:44:57 -07004794 @simple_layout('layouts/multiple-templates.yaml')
4795 def test_multiple_project_templates(self):
4796 # Test that applying multiple project templates to a project
4797 # doesn't alter them when used for a second project.
4798 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4799 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4800 self.waitUntilSettled()
4801
4802 build = self.getJobFromHistory('py27')
4803 self.assertEqual(build.parameters['zuul']['jobtags'], [])
4804
James E. Blair29c77002017-10-05 14:56:35 -07004805 def test_pending_merge_in_reconfig(self):
4806 # Test that if we are waiting for an outstanding merge on
4807 # reconfiguration that we continue to do so.
4808 self.gearman_server.hold_merge_jobs_in_queue = True
4809 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4810 A.setMerged()
4811 self.fake_gerrit.addEvent(A.getRefUpdatedEvent())
4812 self.waitUntilSettled()
4813 # Reconfigure while we still have an outstanding merge job
4814 self.sched.reconfigureTenant(self.sched.abide.tenants['tenant-one'],
4815 None)
4816 self.waitUntilSettled()
4817 # Verify the merge job is still running and that the item is
4818 # in the pipeline
4819 self.assertEqual(len(self.sched.merger.jobs), 1)
4820 tenant = self.sched.abide.tenants.get('tenant-one')
4821 pipeline = tenant.layout.pipelines['post']
4822 self.assertEqual(len(pipeline.getAllItems()), 1)
4823 self.gearman_server.hold_merge_jobs_in_queue = False
4824 self.gearman_server.release()
4825 self.waitUntilSettled()
4826
Arieb6f068c2016-10-09 13:11:06 +03004827
James E. Blaira002b032017-04-18 10:35:48 -07004828class TestExecutor(ZuulTestCase):
4829 tenant_config_file = 'config/single-tenant/main.yaml'
4830
4831 def assertFinalState(self):
4832 # In this test, we expect to shut down in a non-final state,
4833 # so skip these checks.
4834 pass
4835
4836 def assertCleanShutdown(self):
4837 self.log.debug("Assert clean shutdown")
4838
4839 # After shutdown, make sure no jobs are running
4840 self.assertEqual({}, self.executor_server.job_workers)
4841
4842 # Make sure that git.Repo objects have been garbage collected.
4843 repos = []
4844 gc.collect()
4845 for obj in gc.get_objects():
4846 if isinstance(obj, git.Repo):
4847 self.log.debug("Leaked git repo object: %s" % repr(obj))
4848 repos.append(obj)
4849 self.assertEqual(len(repos), 0)
4850
4851 def test_executor_shutdown(self):
4852 "Test that the executor can shut down with jobs running"
4853
4854 self.executor_server.hold_jobs_in_build = True
4855 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004856 A.addApproval('Code-Review', 2)
4857 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
James E. Blaira002b032017-04-18 10:35:48 -07004858 self.waitUntilSettled()
4859
4860
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004861class TestDependencyGraph(ZuulTestCase):
4862 tenant_config_file = 'config/dependency-graph/main.yaml'
4863
4864 def test_dependeny_graph_dispatch_jobs_once(self):
4865 "Test a job in a dependency graph is queued only once"
4866 # Job dependencies, starting with A
4867 # A
4868 # / \
4869 # B C
4870 # / \ / \
4871 # D F E
4872 # |
4873 # G
4874
4875 self.executor_server.hold_jobs_in_build = True
4876 change = self.fake_gerrit.addFakeChange(
4877 'org/project', 'master', 'change')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004878 change.addApproval('Code-Review', 2)
4879 self.fake_gerrit.addEvent(change.addApproval('Approved', 1))
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004880
4881 self.waitUntilSettled()
4882 self.assertEqual([b.name for b in self.builds], ['A'])
4883
4884 self.executor_server.release('A')
4885 self.waitUntilSettled()
4886 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4887
4888 self.executor_server.release('B')
4889 self.waitUntilSettled()
4890 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4891
4892 self.executor_server.release('D')
4893 self.waitUntilSettled()
4894 self.assertEqual([b.name for b in self.builds], ['C'])
4895
4896 self.executor_server.release('C')
4897 self.waitUntilSettled()
4898 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4899
4900 self.executor_server.release('F')
4901 self.waitUntilSettled()
4902 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4903
4904 self.executor_server.release('G')
4905 self.waitUntilSettled()
4906 self.assertEqual([b.name for b in self.builds], ['E'])
4907
4908 self.executor_server.release('E')
4909 self.waitUntilSettled()
4910 self.assertEqual(len(self.builds), 0)
4911
4912 self.executor_server.hold_jobs_in_build = False
4913 self.executor_server.release()
4914 self.waitUntilSettled()
4915
4916 self.assertEqual(len(self.builds), 0)
4917 self.assertEqual(len(self.history), 7)
4918
4919 self.assertEqual(change.data['status'], 'MERGED')
4920 self.assertEqual(change.reported, 2)
4921
4922 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4923 "Test that a job waits till all dependencies are successful"
4924 # Job dependencies, starting with A
4925 # A
4926 # / \
4927 # B C*
4928 # / \ / \
4929 # D F E
4930 # |
4931 # G
4932
4933 self.executor_server.hold_jobs_in_build = True
4934 change = self.fake_gerrit.addFakeChange(
4935 'org/project', 'master', 'change')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004936 change.addApproval('Code-Review', 2)
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004937
4938 self.executor_server.failJob('C', change)
4939
Tobias Henkelbf24fd12017-07-27 06:13:07 +02004940 self.fake_gerrit.addEvent(change.addApproval('Approved', 1))
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004941
4942 self.waitUntilSettled()
4943 self.assertEqual([b.name for b in self.builds], ['A'])
4944
4945 self.executor_server.release('A')
4946 self.waitUntilSettled()
4947 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4948
4949 self.executor_server.release('B')
4950 self.waitUntilSettled()
4951 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4952
4953 self.executor_server.release('D')
4954 self.waitUntilSettled()
4955 self.assertEqual([b.name for b in self.builds], ['C'])
4956
4957 self.executor_server.release('C')
4958 self.waitUntilSettled()
4959 self.assertEqual(len(self.builds), 0)
4960
4961 self.executor_server.hold_jobs_in_build = False
4962 self.executor_server.release()
4963 self.waitUntilSettled()
4964
4965 self.assertEqual(len(self.builds), 0)
4966 self.assertEqual(len(self.history), 4)
4967
4968 self.assertEqual(change.data['status'], 'NEW')
4969 self.assertEqual(change.reported, 2)
4970
4971
Arieb6f068c2016-10-09 13:11:06 +03004972class TestDuplicatePipeline(ZuulTestCase):
4973 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
4974
4975 def test_duplicate_pipelines(self):
4976 "Test that a change matching multiple pipelines works"
4977
4978 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4979 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
4980 self.waitUntilSettled()
4981
4982 self.assertHistory([
4983 dict(name='project-test1', result='SUCCESS', changes='1,1',
4984 pipeline='dup1'),
4985 dict(name='project-test1', result='SUCCESS', changes='1,1',
4986 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05004987 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03004988
4989 self.assertEqual(len(A.messages), 2)
4990
Paul Belangera46a3742016-11-09 14:23:03 -05004991 if 'dup1' in A.messages[0]:
4992 self.assertIn('dup1', A.messages[0])
4993 self.assertNotIn('dup2', A.messages[0])
4994 self.assertIn('project-test1', A.messages[0])
4995 self.assertIn('dup2', A.messages[1])
4996 self.assertNotIn('dup1', A.messages[1])
4997 self.assertIn('project-test1', A.messages[1])
4998 else:
4999 self.assertIn('dup1', A.messages[1])
5000 self.assertNotIn('dup2', A.messages[1])
5001 self.assertIn('project-test1', A.messages[1])
5002 self.assertIn('dup2', A.messages[0])
5003 self.assertNotIn('dup1', A.messages[0])
5004 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04005005
5006
Paul Belanger86085b32016-11-03 12:48:57 -04005007class TestSchedulerTemplatedProject(ZuulTestCase):
5008 tenant_config_file = 'config/templated-project/main.yaml'
5009
Paul Belanger174a8272017-03-14 13:20:10 -04005010 def test_job_from_templates_executed(self):
5011 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04005012
5013 A = self.fake_gerrit.addFakeChange(
5014 'org/templated-project', 'master', 'A')
5015 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5016 self.waitUntilSettled()
5017
5018 self.assertEqual(self.getJobFromHistory('project-test1').result,
5019 'SUCCESS')
5020 self.assertEqual(self.getJobFromHistory('project-test2').result,
5021 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04005022
5023 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04005024 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04005025
5026 A = self.fake_gerrit.addFakeChange(
5027 'org/layered-project', 'master', 'A')
5028 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5029 self.waitUntilSettled()
5030
5031 self.assertEqual(self.getJobFromHistory('project-test1').result,
5032 'SUCCESS')
5033 self.assertEqual(self.getJobFromHistory('project-test2').result,
5034 'SUCCESS')
5035 self.assertEqual(self.getJobFromHistory('layered-project-test3'
5036 ).result, 'SUCCESS')
5037 self.assertEqual(self.getJobFromHistory('layered-project-test4'
5038 ).result, 'SUCCESS')
5039 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
5040 ).result, 'SUCCESS')
5041 self.assertEqual(self.getJobFromHistory('project-test6').result,
5042 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08005043
James E. Blaire74f5712017-09-29 15:14:31 -07005044 def test_unimplied_branch_matchers(self):
5045 # This tests that there are no implied branch matchers added
5046 # by project templates.
5047 self.create_branch('org/layered-project', 'stable')
5048
5049 A = self.fake_gerrit.addFakeChange(
5050 'org/layered-project', 'stable', 'A')
5051
5052 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5053 self.waitUntilSettled()
5054
5055 self.assertEqual(self.getJobFromHistory('project-test1').result,
5056 'SUCCESS')
5057 print(self.getJobFromHistory('project-test1').
5058 parameters['zuul']['_inheritance_path'])
5059
5060 def test_implied_branch_matchers(self):
5061 # This tests that there is an implied branch matcher when a
5062 # template is used on an in-repo project pipeline definition.
5063 self.create_branch('untrusted-config', 'stable')
5064 self.fake_gerrit.addEvent(
5065 self.fake_gerrit.getFakeBranchCreatedEvent(
5066 'untrusted-config', 'stable'))
5067 self.waitUntilSettled()
5068
5069 A = self.fake_gerrit.addFakeChange(
5070 'untrusted-config', 'stable', 'A')
5071
5072 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5073 self.waitUntilSettled()
5074
5075 self.assertEqual(self.getJobFromHistory('project-test1').result,
5076 'SUCCESS')
5077 print(self.getJobFromHistory('project-test1').
5078 parameters['zuul']['_inheritance_path'])
5079
Adam Gandelman94a60062016-11-21 16:43:14 -08005080
5081class TestSchedulerSuccessURL(ZuulTestCase):
5082 tenant_config_file = 'config/success-url/main.yaml'
5083
5084 def test_success_url(self):
5085 "Ensure bad build params are ignored"
5086 self.sched.reconfigure(self.config)
5087 self.init_repo('org/docs')
5088
5089 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
5090 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5091 self.waitUntilSettled()
5092
5093 # Both builds ran: docs-draft-test + docs-draft-test2
5094 self.assertEqual(len(self.history), 2)
5095
5096 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08005097 for build in self.history:
5098 if build.name == 'docs-draft-test':
5099 uuid = build.uuid[:7]
Monty Taylorde8242c2017-02-23 20:29:53 -06005100 elif build.name == 'docs-draft-test2':
5101 uuid_test2 = build.uuid
Adam Gandelman94a60062016-11-21 16:43:14 -08005102
5103 # Two msgs: 'Starting...' + results
5104 self.assertEqual(len(self.smtp_messages), 2)
5105 body = self.smtp_messages[1]['body'].splitlines()
5106 self.assertEqual('Build succeeded.', body[0])
5107
5108 self.assertIn(
5109 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
5110 'docs-draft-test/%s/publish-docs/' % uuid,
5111 body[2])
5112
Paul Belanger174a8272017-03-14 13:20:10 -04005113 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08005114 self.assertIn(
Monty Taylor51139a02016-05-24 11:28:10 -05005115 '- docs-draft-test2 finger://{hostname}/{uuid}'.format(
5116 hostname=self.executor_server.hostname,
Monty Taylorde8242c2017-02-23 20:29:53 -06005117 uuid=uuid_test2),
Adam Gandelman94a60062016-11-21 16:43:14 -08005118 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08005119
5120
Adam Gandelman4da00f62016-12-09 15:47:33 -08005121class TestSchedulerMerges(ZuulTestCase):
5122 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08005123
5124 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04005125 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08005126 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04005127 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08005128 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
5129 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
5130 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005131 A.addApproval('Code-Review', 2)
5132 B.addApproval('Code-Review', 2)
5133 C.addApproval('Code-Review', 2)
5134 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5135 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5136 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Adam Gandelman8bd57102016-12-02 12:58:42 -08005137 self.waitUntilSettled()
5138
5139 build = self.builds[-1]
James E. Blair2a535672017-04-27 12:03:15 -07005140 path = os.path.join(build.jobdir.src_root, 'review.example.com',
5141 project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08005142 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07005143 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman8bd57102016-12-02 12:58:42 -08005144 repo_messages.reverse()
5145
Paul Belanger174a8272017-03-14 13:20:10 -04005146 self.executor_server.hold_jobs_in_build = False
5147 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08005148 self.waitUntilSettled()
5149
5150 return repo_messages
5151
5152 def _test_merge(self, mode):
5153 us_path = os.path.join(
5154 self.upstream_root, 'org/project-%s' % mode)
5155 expected_messages = [
5156 'initial commit',
5157 'add content from fixture',
5158 # the intermediate commits order is nondeterministic
5159 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
5160 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
5161 ]
5162 result = self._test_project_merge_mode(mode)
5163 self.assertEqual(result[:2], expected_messages[:2])
5164 self.assertEqual(result[-2:], expected_messages[-2:])
5165
5166 def test_project_merge_mode_merge(self):
5167 self._test_merge('merge')
5168
5169 def test_project_merge_mode_merge_resolve(self):
5170 self._test_merge('merge-resolve')
5171
5172 def test_project_merge_mode_cherrypick(self):
5173 expected_messages = [
5174 'initial commit',
5175 'add content from fixture',
5176 'A-1',
5177 'B-1',
5178 'C-1']
5179 result = self._test_project_merge_mode('cherry-pick')
5180 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08005181
5182 def test_merge_branch(self):
5183 "Test that the right commits are on alternate branches"
5184 self.create_branch('org/project-merge-branches', 'mp')
5185
Paul Belanger174a8272017-03-14 13:20:10 -04005186 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08005187 A = self.fake_gerrit.addFakeChange(
5188 'org/project-merge-branches', 'mp', 'A')
5189 B = self.fake_gerrit.addFakeChange(
5190 'org/project-merge-branches', 'mp', 'B')
5191 C = self.fake_gerrit.addFakeChange(
5192 'org/project-merge-branches', 'mp', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005193 A.addApproval('Code-Review', 2)
5194 B.addApproval('Code-Review', 2)
5195 C.addApproval('Code-Review', 2)
5196 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5197 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5198 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Adam Gandelman4da00f62016-12-09 15:47:33 -08005199 self.waitUntilSettled()
5200
Paul Belanger174a8272017-03-14 13:20:10 -04005201 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005202 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04005203 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005204 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04005205 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005206 self.waitUntilSettled()
5207
5208 build = self.builds[-1]
James E. Blair3b222492017-07-21 15:17:37 -07005209 self.assertEqual(build.parameters['zuul']['branch'], 'mp')
James E. Blair2a535672017-04-27 12:03:15 -07005210 path = os.path.join(build.jobdir.src_root, 'review.example.com',
5211 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005212 repo = git.Repo(path)
5213
James E. Blair247cab72017-07-20 16:52:36 -07005214 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005215 repo_messages.reverse()
5216 correct_messages = [
5217 'initial commit',
5218 'add content from fixture',
5219 'mp commit',
5220 'A-1', 'B-1', 'C-1']
5221 self.assertEqual(repo_messages, correct_messages)
5222
Paul Belanger174a8272017-03-14 13:20:10 -04005223 self.executor_server.hold_jobs_in_build = False
5224 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08005225 self.waitUntilSettled()
5226
5227 def test_merge_multi_branch(self):
5228 "Test that dependent changes on multiple branches are merged"
5229 self.create_branch('org/project-merge-branches', 'mp')
5230
Paul Belanger174a8272017-03-14 13:20:10 -04005231 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08005232 A = self.fake_gerrit.addFakeChange(
5233 'org/project-merge-branches', 'master', 'A')
5234 B = self.fake_gerrit.addFakeChange(
5235 'org/project-merge-branches', 'mp', 'B')
5236 C = self.fake_gerrit.addFakeChange(
5237 'org/project-merge-branches', 'master', 'C')
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005238 A.addApproval('Code-Review', 2)
5239 B.addApproval('Code-Review', 2)
5240 C.addApproval('Code-Review', 2)
5241 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5242 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5243 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Adam Gandelman4da00f62016-12-09 15:47:33 -08005244 self.waitUntilSettled()
5245
5246 job_A = None
5247 for job in self.builds:
5248 if 'project-merge' in job.name:
5249 job_A = job
Adam Gandelman4da00f62016-12-09 15:47:33 -08005250
James E. Blair2a535672017-04-27 12:03:15 -07005251 path = os.path.join(job_A.jobdir.src_root, 'review.example.com',
5252 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005253 repo = git.Repo(path)
5254 repo_messages = [c.message.strip()
James E. Blair247cab72017-07-20 16:52:36 -07005255 for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005256 repo_messages.reverse()
5257 correct_messages = [
5258 'initial commit', 'add content from fixture', 'A-1']
5259 self.assertEqual(repo_messages, correct_messages)
5260
Paul Belanger174a8272017-03-14 13:20:10 -04005261 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005262 self.waitUntilSettled()
5263
5264 job_B = None
5265 for job in self.builds:
5266 if 'project-merge' in job.name:
5267 job_B = job
Adam Gandelman4da00f62016-12-09 15:47:33 -08005268
James E. Blair2a535672017-04-27 12:03:15 -07005269 path = os.path.join(job_B.jobdir.src_root, 'review.example.com',
5270 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005271 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07005272 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005273 repo_messages.reverse()
5274 correct_messages = [
5275 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
5276 self.assertEqual(repo_messages, correct_messages)
5277
Paul Belanger174a8272017-03-14 13:20:10 -04005278 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005279 self.waitUntilSettled()
5280
5281 job_C = None
5282 for job in self.builds:
5283 if 'project-merge' in job.name:
5284 job_C = job
James E. Blairb1345832017-07-21 14:51:35 -07005285
James E. Blair2a535672017-04-27 12:03:15 -07005286 path = os.path.join(job_C.jobdir.src_root, 'review.example.com',
5287 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08005288 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07005289 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08005290
5291 repo_messages.reverse()
5292 correct_messages = [
5293 'initial commit', 'add content from fixture',
5294 'A-1', 'C-1']
5295 # Ensure the right commits are in the history for this ref
5296 self.assertEqual(repo_messages, correct_messages)
5297
Paul Belanger174a8272017-03-14 13:20:10 -04005298 self.executor_server.hold_jobs_in_build = False
5299 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08005300 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005301
5302
James E. Blair9ea0d0b2017-04-20 09:27:15 -07005303class TestSemaphore(ZuulTestCase):
5304 tenant_config_file = 'config/semaphore/main.yaml'
5305
5306 def test_semaphore_one(self):
5307 "Test semaphores with max=1 (mutex)"
5308 tenant = self.sched.abide.tenants.get('tenant-one')
5309
5310 self.executor_server.hold_jobs_in_build = True
5311
5312 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5313 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5314 self.assertFalse('test-semaphore' in
5315 tenant.semaphore_handler.semaphores)
5316
5317 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5318 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5319 self.waitUntilSettled()
5320
5321 self.assertEqual(len(self.builds), 3)
5322 self.assertEqual(self.builds[0].name, 'project-test1')
5323 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
5324 self.assertEqual(self.builds[2].name, 'project-test1')
5325
5326 self.executor_server.release('semaphore-one-test1')
5327 self.waitUntilSettled()
5328
5329 self.assertEqual(len(self.builds), 3)
5330 self.assertEqual(self.builds[0].name, 'project-test1')
5331 self.assertEqual(self.builds[1].name, 'project-test1')
5332 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
5333 self.assertTrue('test-semaphore' in
5334 tenant.semaphore_handler.semaphores)
5335
5336 self.executor_server.release('semaphore-one-test2')
5337 self.waitUntilSettled()
5338
5339 self.assertEqual(len(self.builds), 3)
5340 self.assertEqual(self.builds[0].name, 'project-test1')
5341 self.assertEqual(self.builds[1].name, 'project-test1')
5342 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
5343 self.assertTrue('test-semaphore' in
5344 tenant.semaphore_handler.semaphores)
5345
5346 self.executor_server.release('semaphore-one-test1')
5347 self.waitUntilSettled()
5348
5349 self.assertEqual(len(self.builds), 3)
5350 self.assertEqual(self.builds[0].name, 'project-test1')
5351 self.assertEqual(self.builds[1].name, 'project-test1')
5352 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
5353 self.assertTrue('test-semaphore' in
5354 tenant.semaphore_handler.semaphores)
5355
5356 self.executor_server.release('semaphore-one-test2')
5357 self.waitUntilSettled()
5358
5359 self.assertEqual(len(self.builds), 2)
5360 self.assertEqual(self.builds[0].name, 'project-test1')
5361 self.assertEqual(self.builds[1].name, 'project-test1')
5362 self.assertFalse('test-semaphore' in
5363 tenant.semaphore_handler.semaphores)
5364
5365 self.executor_server.hold_jobs_in_build = False
5366 self.executor_server.release()
5367
5368 self.waitUntilSettled()
5369 self.assertEqual(len(self.builds), 0)
5370
5371 self.assertEqual(A.reported, 1)
5372 self.assertEqual(B.reported, 1)
5373 self.assertFalse('test-semaphore' in
5374 tenant.semaphore_handler.semaphores)
5375
5376 def test_semaphore_two(self):
5377 "Test semaphores with max>1"
5378 tenant = self.sched.abide.tenants.get('tenant-one')
5379
5380 self.executor_server.hold_jobs_in_build = True
5381 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5382 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5383 self.assertFalse('test-semaphore-two' in
5384 tenant.semaphore_handler.semaphores)
5385
5386 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5387 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5388 self.waitUntilSettled()
5389
5390 self.assertEqual(len(self.builds), 4)
5391 self.assertEqual(self.builds[0].name, 'project-test1')
5392 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
5393 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
5394 self.assertEqual(self.builds[3].name, 'project-test1')
5395 self.assertTrue('test-semaphore-two' in
5396 tenant.semaphore_handler.semaphores)
5397 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5398 'test-semaphore-two', [])), 2)
5399
5400 self.executor_server.release('semaphore-two-test1')
5401 self.waitUntilSettled()
5402
5403 self.assertEqual(len(self.builds), 4)
5404 self.assertEqual(self.builds[0].name, 'project-test1')
5405 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
5406 self.assertEqual(self.builds[2].name, 'project-test1')
5407 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
5408 self.assertTrue('test-semaphore-two' in
5409 tenant.semaphore_handler.semaphores)
5410 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5411 'test-semaphore-two', [])), 2)
5412
5413 self.executor_server.release('semaphore-two-test2')
5414 self.waitUntilSettled()
5415
5416 self.assertEqual(len(self.builds), 4)
5417 self.assertEqual(self.builds[0].name, 'project-test1')
5418 self.assertEqual(self.builds[1].name, 'project-test1')
5419 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
5420 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
5421 self.assertTrue('test-semaphore-two' in
5422 tenant.semaphore_handler.semaphores)
5423 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5424 'test-semaphore-two', [])), 2)
5425
5426 self.executor_server.release('semaphore-two-test1')
5427 self.waitUntilSettled()
5428
5429 self.assertEqual(len(self.builds), 3)
5430 self.assertEqual(self.builds[0].name, 'project-test1')
5431 self.assertEqual(self.builds[1].name, 'project-test1')
5432 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
5433 self.assertTrue('test-semaphore-two' in
5434 tenant.semaphore_handler.semaphores)
5435 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5436 'test-semaphore-two', [])), 1)
5437
5438 self.executor_server.release('semaphore-two-test2')
5439 self.waitUntilSettled()
5440
5441 self.assertEqual(len(self.builds), 2)
5442 self.assertEqual(self.builds[0].name, 'project-test1')
5443 self.assertEqual(self.builds[1].name, 'project-test1')
5444 self.assertFalse('test-semaphore-two' in
5445 tenant.semaphore_handler.semaphores)
5446
5447 self.executor_server.hold_jobs_in_build = False
5448 self.executor_server.release()
5449
5450 self.waitUntilSettled()
5451 self.assertEqual(len(self.builds), 0)
5452
5453 self.assertEqual(A.reported, 1)
5454 self.assertEqual(B.reported, 1)
5455
5456 def test_semaphore_abandon(self):
5457 "Test abandon with job semaphores"
5458 self.executor_server.hold_jobs_in_build = True
5459 tenant = self.sched.abide.tenants.get('tenant-one')
5460 check_pipeline = tenant.layout.pipelines['check']
5461
5462 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5463 self.assertFalse('test-semaphore' in
5464 tenant.semaphore_handler.semaphores)
5465
5466 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5467 self.waitUntilSettled()
5468
5469 self.assertTrue('test-semaphore' in
5470 tenant.semaphore_handler.semaphores)
5471
5472 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
5473 self.waitUntilSettled()
5474
5475 # The check pipeline should be empty
5476 items = check_pipeline.getAllItems()
5477 self.assertEqual(len(items), 0)
5478
5479 # The semaphore should be released
5480 self.assertFalse('test-semaphore' in
5481 tenant.semaphore_handler.semaphores)
5482
5483 self.executor_server.hold_jobs_in_build = False
5484 self.executor_server.release()
5485 self.waitUntilSettled()
5486
Tobias Henkel0f714002017-06-30 23:30:52 +02005487 def test_semaphore_new_patchset(self):
5488 "Test new patchset with job semaphores"
5489 self.executor_server.hold_jobs_in_build = True
5490 tenant = self.sched.abide.tenants.get('tenant-one')
5491 check_pipeline = tenant.layout.pipelines['check']
5492
5493 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5494 self.assertFalse('test-semaphore' in
5495 tenant.semaphore_handler.semaphores)
5496
5497 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5498 self.waitUntilSettled()
5499
5500 self.assertTrue('test-semaphore' in
5501 tenant.semaphore_handler.semaphores)
5502 semaphore = tenant.semaphore_handler.semaphores['test-semaphore']
5503 self.assertEqual(len(semaphore), 1)
5504
5505 A.addPatchset()
5506 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
5507 self.waitUntilSettled()
5508
5509 self.assertTrue('test-semaphore' in
5510 tenant.semaphore_handler.semaphores)
5511 semaphore = tenant.semaphore_handler.semaphores['test-semaphore']
5512 self.assertEqual(len(semaphore), 1)
5513
5514 items = check_pipeline.getAllItems()
5515 self.assertEqual(items[0].change.number, '1')
5516 self.assertEqual(items[0].change.patchset, '2')
5517 self.assertTrue(items[0].live)
5518
5519 self.executor_server.hold_jobs_in_build = False
5520 self.executor_server.release()
5521 self.waitUntilSettled()
5522
5523 # The semaphore should be released
5524 self.assertFalse('test-semaphore' in
5525 tenant.semaphore_handler.semaphores)
5526
James E. Blair9ea0d0b2017-04-20 09:27:15 -07005527 def test_semaphore_reconfigure(self):
5528 "Test reconfigure with job semaphores"
5529 self.executor_server.hold_jobs_in_build = True
5530 tenant = self.sched.abide.tenants.get('tenant-one')
5531 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5532 self.assertFalse('test-semaphore' in
5533 tenant.semaphore_handler.semaphores)
5534
5535 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5536 self.waitUntilSettled()
5537
5538 self.assertTrue('test-semaphore' in
5539 tenant.semaphore_handler.semaphores)
5540
5541 # reconfigure without layout change
5542 self.sched.reconfigure(self.config)
5543 self.waitUntilSettled()
5544 tenant = self.sched.abide.tenants.get('tenant-one')
5545
5546 # semaphore still must be held
5547 self.assertTrue('test-semaphore' in
5548 tenant.semaphore_handler.semaphores)
5549
5550 self.commitConfigUpdate(
5551 'common-config',
5552 'config/semaphore/zuul-reconfiguration.yaml')
5553 self.sched.reconfigure(self.config)
5554 self.waitUntilSettled()
5555 tenant = self.sched.abide.tenants.get('tenant-one')
5556
5557 self.executor_server.release('project-test1')
5558 self.waitUntilSettled()
5559
5560 # There should be no builds anymore
5561 self.assertEqual(len(self.builds), 0)
5562
5563 # The semaphore should be released
5564 self.assertFalse('test-semaphore' in
5565 tenant.semaphore_handler.semaphores)
5566
5567
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005568class TestSemaphoreMultiTenant(ZuulTestCase):
5569 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5570
5571 def test_semaphore_tenant_isolation(self):
5572 "Test semaphores in multiple tenants"
5573
5574 self.waitUntilSettled()
5575 tenant_one = self.sched.abide.tenants.get('tenant-one')
5576 tenant_two = self.sched.abide.tenants.get('tenant-two')
5577
5578 self.executor_server.hold_jobs_in_build = True
5579 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5580 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5581 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5582 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5583 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5584 self.assertFalse('test-semaphore' in
5585 tenant_one.semaphore_handler.semaphores)
5586 self.assertFalse('test-semaphore' in
5587 tenant_two.semaphore_handler.semaphores)
5588
5589 # add patches to project1 of tenant-one
5590 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5591 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5592 self.waitUntilSettled()
5593
5594 # one build of project1-test1 must run
5595 # semaphore of tenant-one must be acquired once
5596 # semaphore of tenant-two must not be acquired
5597 self.assertEqual(len(self.builds), 1)
5598 self.assertEqual(self.builds[0].name, 'project1-test1')
5599 self.assertTrue('test-semaphore' in
5600 tenant_one.semaphore_handler.semaphores)
5601 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5602 'test-semaphore', [])), 1)
5603 self.assertFalse('test-semaphore' in
5604 tenant_two.semaphore_handler.semaphores)
5605
5606 # add patches to project2 of tenant-two
5607 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5608 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5609 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5610 self.waitUntilSettled()
5611
5612 # one build of project1-test1 must run
5613 # two builds of project2-test1 must run
5614 # semaphore of tenant-one must be acquired once
5615 # semaphore of tenant-two must be acquired twice
5616 self.assertEqual(len(self.builds), 3)
5617 self.assertEqual(self.builds[0].name, 'project1-test1')
5618 self.assertEqual(self.builds[1].name, 'project2-test1')
5619 self.assertEqual(self.builds[2].name, 'project2-test1')
5620 self.assertTrue('test-semaphore' in
5621 tenant_one.semaphore_handler.semaphores)
5622 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5623 'test-semaphore', [])), 1)
5624 self.assertTrue('test-semaphore' in
5625 tenant_two.semaphore_handler.semaphores)
5626 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5627 'test-semaphore', [])), 2)
5628
5629 self.executor_server.release('project1-test1')
5630 self.waitUntilSettled()
5631
5632 # one build of project1-test1 must run
5633 # two builds of project2-test1 must run
5634 # semaphore of tenant-one must be acquired once
5635 # semaphore of tenant-two must be acquired twice
5636 self.assertEqual(len(self.builds), 3)
5637 self.assertEqual(self.builds[0].name, 'project2-test1')
5638 self.assertEqual(self.builds[1].name, 'project2-test1')
5639 self.assertEqual(self.builds[2].name, 'project1-test1')
5640 self.assertTrue('test-semaphore' in
5641 tenant_one.semaphore_handler.semaphores)
5642 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5643 'test-semaphore', [])), 1)
5644 self.assertTrue('test-semaphore' in
5645 tenant_two.semaphore_handler.semaphores)
5646 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5647 'test-semaphore', [])), 2)
5648
5649 self.executor_server.release('project2-test1')
5650 self.waitUntilSettled()
5651
5652 # one build of project1-test1 must run
5653 # one build of project2-test1 must run
5654 # semaphore of tenant-one must be acquired once
5655 # semaphore of tenant-two must be acquired once
5656 self.assertEqual(len(self.builds), 2)
5657 self.assertTrue('test-semaphore' in
5658 tenant_one.semaphore_handler.semaphores)
5659 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5660 'test-semaphore', [])), 1)
5661 self.assertTrue('test-semaphore' in
5662 tenant_two.semaphore_handler.semaphores)
5663 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5664 'test-semaphore', [])), 1)
5665
5666 self.executor_server.hold_jobs_in_build = False
5667 self.executor_server.release()
5668
5669 self.waitUntilSettled()
5670
5671 # no build must run
5672 # semaphore of tenant-one must not be acquired
5673 # semaphore of tenant-two must not be acquired
5674 self.assertEqual(len(self.builds), 0)
5675 self.assertFalse('test-semaphore' in
5676 tenant_one.semaphore_handler.semaphores)
5677 self.assertFalse('test-semaphore' in
5678 tenant_two.semaphore_handler.semaphores)
5679
5680 self.assertEqual(A.reported, 1)
5681 self.assertEqual(B.reported, 1)
5682
5683
5684class TestSemaphoreInRepo(ZuulTestCase):
Tobias Henkelabf973e2017-07-28 10:07:34 +02005685 config_file = 'zuul-connections-gerrit-and-github.conf'
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005686 tenant_config_file = 'config/in-repo/main.yaml'
5687
5688 def test_semaphore_in_repo(self):
5689 "Test semaphores in repo config"
5690
5691 # This tests dynamic semaphore handling in project repos. The semaphore
5692 # max value should not be evaluated dynamically but must be updated
5693 # after the change lands.
5694
5695 self.waitUntilSettled()
5696 tenant = self.sched.abide.tenants.get('tenant-one')
5697
5698 in_repo_conf = textwrap.dedent(
5699 """
5700 - job:
Tobias Henkelf02cf512017-07-21 22:55:34 +02005701 name: project-test1
5702
5703 - job:
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005704 name: project-test2
5705 semaphore: test-semaphore
5706
5707 - project:
5708 name: org/project
5709 tenant-one-gate:
5710 jobs:
5711 - project-test2
5712
5713 # the max value in dynamic layout must be ignored
5714 - semaphore:
5715 name: test-semaphore
5716 max: 2
5717 """)
5718
5719 in_repo_playbook = textwrap.dedent(
5720 """
5721 - hosts: all
5722 tasks: []
5723 """)
5724
5725 file_dict = {'.zuul.yaml': in_repo_conf,
5726 'playbooks/project-test2.yaml': in_repo_playbook}
5727 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5728 files=file_dict)
5729 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5730 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5731 B.setDependsOn(A, 1)
5732 C.setDependsOn(A, 1)
5733
5734 self.executor_server.hold_jobs_in_build = True
5735
Tobias Henkelbf24fd12017-07-27 06:13:07 +02005736 A.addApproval('Code-Review', 2)
5737 B.addApproval('Code-Review', 2)
5738 C.addApproval('Code-Review', 2)
5739 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5740 self.fake_gerrit.addEvent(B.addApproval('Approved', 1))
5741 self.fake_gerrit.addEvent(C.addApproval('Approved', 1))
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005742 self.waitUntilSettled()
5743
5744 # check that the layout in a queue item still has max value of 1
5745 # for test-semaphore
5746 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5747 queue = None
5748 for queue_candidate in pipeline.queues:
5749 if queue_candidate.name == 'org/project':
5750 queue = queue_candidate
5751 break
5752 queue_item = queue.queue[0]
James E. Blair29a24fd2017-10-02 15:04:56 -07005753 item_dynamic_layout = queue_item.layout
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005754 dynamic_test_semaphore = \
5755 item_dynamic_layout.semaphores.get('test-semaphore')
5756 self.assertEqual(dynamic_test_semaphore.max, 1)
5757
5758 # one build must be in queue, one semaphores acquired
5759 self.assertEqual(len(self.builds), 1)
5760 self.assertEqual(self.builds[0].name, 'project-test2')
5761 self.assertTrue('test-semaphore' in
5762 tenant.semaphore_handler.semaphores)
5763 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5764 'test-semaphore', [])), 1)
5765
5766 self.executor_server.release('project-test2')
5767 self.waitUntilSettled()
5768
5769 # change A must be merged
5770 self.assertEqual(A.data['status'], 'MERGED')
5771 self.assertEqual(A.reported, 2)
5772
5773 # send change-merged event as the gerrit mock doesn't send it
5774 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5775 self.waitUntilSettled()
5776
5777 # now that change A was merged, the new semaphore max must be effective
5778 tenant = self.sched.abide.tenants.get('tenant-one')
5779 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5780
5781 # two builds must be in queue, two semaphores acquired
5782 self.assertEqual(len(self.builds), 2)
5783 self.assertEqual(self.builds[0].name, 'project-test2')
5784 self.assertEqual(self.builds[1].name, 'project-test2')
5785 self.assertTrue('test-semaphore' in
5786 tenant.semaphore_handler.semaphores)
5787 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5788 'test-semaphore', [])), 2)
5789
5790 self.executor_server.release('project-test2')
5791 self.waitUntilSettled()
5792
5793 self.assertEqual(len(self.builds), 0)
5794 self.assertFalse('test-semaphore' in
5795 tenant.semaphore_handler.semaphores)
5796
5797 self.executor_server.hold_jobs_in_build = False
5798 self.executor_server.release()
5799
5800 self.waitUntilSettled()
5801 self.assertEqual(len(self.builds), 0)
5802
5803 self.assertEqual(A.reported, 2)
5804 self.assertEqual(B.reported, 2)
5805 self.assertEqual(C.reported, 2)
David Shrewsburyf6dc1762017-10-02 13:34:37 -04005806
5807
5808class TestSchedulerBranchMatcher(ZuulTestCase):
5809
5810 @simple_layout('layouts/matcher-test.yaml')
5811 def test_job_branch_ignored(self):
5812 '''
5813 Test that branch matching logic works.
5814
5815 The 'ignore-branch' job has a branch matcher that is supposed to
5816 match every branch except for the 'featureA' branch, so it should
5817 not be run on a change to that branch.
5818 '''
5819 self.create_branch('org/project', 'featureA')
5820 A = self.fake_gerrit.addFakeChange('org/project', 'featureA', 'A')
5821 A.addApproval('Code-Review', 2)
5822 self.fake_gerrit.addEvent(A.addApproval('Approved', 1))
5823 self.waitUntilSettled()
5824 self.printHistory()
5825 self.assertEqual(self.getJobFromHistory('project-test1').result,
5826 'SUCCESS')
5827 self.assertJobNotInHistory('ignore-branch')
5828 self.assertEqual(A.data['status'], 'MERGED')
5829 self.assertEqual(A.reported, 2,
5830 "A should report start and success")
5831 self.assertIn('gate', A.messages[1],
5832 "A should transit gate")