blob: 5fecfbefb236a06de32c00284e758993093d66cd [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
Clint Byrum03454a52017-05-26 17:14:02 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Monty Taylorbc758832013-06-17 17:22:42 -040028import testtools
Monty Taylorb934c1a2017-06-16 19:31:47 -050029import urllib
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
Clint Byrumb9de8be2017-05-27 13:49:19 -070032from zuul.driver.gerrit import gerritreporter
James E. Blairb0fcae42012-07-17 11:12:10 -070033import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080034import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040035import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070036
Maru Newby3fe5f852015-01-13 04:22:14 +000037from tests.base import (
Paul Belanger0a21f0a2017-06-13 13:14:42 -040038 SSLZuulTestCase,
Maru Newby3fe5f852015-01-13 04:22:14 +000039 ZuulTestCase,
40 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070041 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000042)
James E. Blairb0fcae42012-07-17 11:12:10 -070043
James E. Blairb0fcae42012-07-17 11:12:10 -070044
Paul Belanger0a21f0a2017-06-13 13:14:42 -040045class TestSchedulerSSL(SSLZuulTestCase):
46 tenant_config_file = 'config/single-tenant/main.yaml'
47
48 def test_jobs_executed(self):
49 "Test that jobs are executed and a change is merged"
50
51 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
52 A.addApproval('code-review', 2)
53 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
54 self.waitUntilSettled()
55 self.assertEqual(self.getJobFromHistory('project-merge').result,
56 'SUCCESS')
57 self.assertEqual(self.getJobFromHistory('project-test1').result,
58 'SUCCESS')
59 self.assertEqual(self.getJobFromHistory('project-test2').result,
60 'SUCCESS')
61 self.assertEqual(A.data['status'], 'MERGED')
62 self.assertEqual(A.reported, 2)
63 self.assertEqual(self.getJobFromHistory('project-test1').node,
64 'label1')
65 self.assertIsNone(self.getJobFromHistory('project-test2').node)
66
67
Clark Boylanb640e052014-04-03 16:41:46 -070068class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070069 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010070
Paul Belanger174a8272017-03-14 13:20:10 -040071 def test_jobs_executed(self):
72 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070073
James E. Blairb0fcae42012-07-17 11:12:10 -070074 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -070075 A.addApproval('code-review', 2)
76 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070077 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040078 self.assertEqual(self.getJobFromHistory('project-merge').result,
79 'SUCCESS')
80 self.assertEqual(self.getJobFromHistory('project-test1').result,
81 'SUCCESS')
82 self.assertEqual(self.getJobFromHistory('project-test2').result,
83 'SUCCESS')
84 self.assertEqual(A.data['status'], 'MERGED')
85 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070086 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -070087 'label1')
Adam Gandelmaneace4692017-02-07 15:18:36 -080088 self.assertIsNone(self.getJobFromHistory('project-test2').node)
James E. Blairb0fcae42012-07-17 11:12:10 -070089
James E. Blair552b54f2016-07-22 13:55:32 -070090 # TODOv3(jeblair): we may want to report stats by tenant (also?).
Monty Taylorf1385042017-05-27 12:25:05 -050091 # Per-driver
92 self.assertReportedStat('zuul.event.gerrit.comment-added', value='1|c')
93 # Per-driver per-connection
94 self.assertReportedStat('zuul.event.gerrit.gerrit.comment-added',
95 value='1|c')
James E. Blair66eeebf2013-07-27 17:44:32 -070096 self.assertReportedStat('zuul.pipeline.gate.current_changes',
97 value='1|g')
98 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
99 kind='ms')
100 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
101 value='1|c')
102 self.assertReportedStat('zuul.pipeline.gate.resident_time', kind='ms')
103 self.assertReportedStat('zuul.pipeline.gate.total_changes',
104 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -0700105 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -0700106 'zuul.pipeline.gate.org.project.resident_time', kind='ms')
James E. Blair412e5582013-04-22 15:50:12 -0700107 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -0700108 'zuul.pipeline.gate.org.project.total_changes', value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -0700109
James E. Blair2ef29e92017-07-21 15:25:05 -0700110 for build in self.history:
111 self.assertTrue(build.parameters['zuul']['voting'])
James E. Blair5821bd92015-09-16 08:48:15 -0700112
James E. Blair3cb10702013-08-24 08:56:03 -0700113 def test_initial_pipeline_gauges(self):
114 "Test that each pipeline reported its length on start"
James E. Blair7da51b72016-07-25 15:29:43 -0700115 self.assertReportedStat('zuul.pipeline.gate.current_changes',
116 value='0|g')
117 self.assertReportedStat('zuul.pipeline.check.current_changes',
118 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -0700119
James E. Blair34776ee2016-08-25 13:53:54 -0700120 def test_job_branch(self):
121 "Test the correct variant of a job runs on a branch"
122 self.create_branch('org/project', 'stable')
123 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
124 A.addApproval('code-review', 2)
125 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
126 self.waitUntilSettled()
127 self.assertEqual(self.getJobFromHistory('project-test1').result,
128 'SUCCESS')
129 self.assertEqual(self.getJobFromHistory('project-test2').result,
130 'SUCCESS')
131 self.assertEqual(A.data['status'], 'MERGED')
132 self.assertEqual(A.reported, 2,
133 "A should report start and success")
134 self.assertIn('gate', A.messages[1],
135 "A should transit gate")
136 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -0700137 'label2')
James E. Blair34776ee2016-08-25 13:53:54 -0700138
James E. Blairb0fcae42012-07-17 11:12:10 -0700139 def test_parallel_changes(self):
140 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700141
Paul Belanger174a8272017-03-14 13:20:10 -0400142 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700143 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
144 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
145 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700146 A.addApproval('code-review', 2)
147 B.addApproval('code-review', 2)
148 C.addApproval('code-review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700149
James E. Blair8b5408c2016-08-08 15:37:46 -0700150 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
151 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
152 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700153
154 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400155 self.assertEqual(len(self.builds), 1)
156 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700157 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700158
Paul Belanger174a8272017-03-14 13:20:10 -0400159 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700160 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400161 self.assertEqual(len(self.builds), 3)
162 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700163 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400164 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700165 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400166 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700167 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700168
Paul Belanger174a8272017-03-14 13:20:10 -0400169 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700170 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400171 self.assertEqual(len(self.builds), 5)
172 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700173 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400174 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700175 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700176
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400177 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700178 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400179 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700180 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700181
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400182 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700183 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700184
Paul Belanger174a8272017-03-14 13:20:10 -0400185 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700186 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400187 self.assertEqual(len(self.builds), 6)
188 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700189 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400190 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700191 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700192
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400193 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700194 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400195 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700196 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700197
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400198 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700199 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400200 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700201 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700202
Paul Belanger174a8272017-03-14 13:20:10 -0400203 self.executor_server.hold_jobs_in_build = False
204 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700205 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400206 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700207
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400208 self.assertEqual(len(self.history), 9)
209 self.assertEqual(A.data['status'], 'MERGED')
210 self.assertEqual(B.data['status'], 'MERGED')
211 self.assertEqual(C.data['status'], 'MERGED')
212 self.assertEqual(A.reported, 2)
213 self.assertEqual(B.reported, 2)
214 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700215
216 def test_failed_changes(self):
217 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400218 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700219
James E. Blairb02a3bb2012-07-30 17:49:55 -0700220 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
221 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -0700222 A.addApproval('code-review', 2)
223 B.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700224
Paul Belanger174a8272017-03-14 13:20:10 -0400225 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700226
James E. Blair8b5408c2016-08-08 15:37:46 -0700227 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
228 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700229 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700230 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400231
Paul Belanger174a8272017-03-14 13:20:10 -0400232 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400233 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700234 # A/project-merge is complete
235 self.assertBuilds([
236 dict(name='project-test1', changes='1,1'),
237 dict(name='project-test2', changes='1,1'),
238 dict(name='project-merge', changes='1,1 2,1'),
239 ])
James E. Blaire2819012013-06-28 17:17:26 -0400240
Paul Belanger174a8272017-03-14 13:20:10 -0400241 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400242 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700243 # A/project-merge is complete
244 # B/project-merge is complete
245 self.assertBuilds([
246 dict(name='project-test1', changes='1,1'),
247 dict(name='project-test2', changes='1,1'),
248 dict(name='project-test1', changes='1,1 2,1'),
249 dict(name='project-test2', changes='1,1 2,1'),
250 ])
251
252 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400253 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700254 self.builds[0].release()
255 self.waitUntilSettled()
256
257 self.orderedRelease()
258 self.assertHistory([
259 dict(name='project-merge', result='SUCCESS', changes='1,1'),
260 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
261 dict(name='project-test1', result='FAILURE', changes='1,1'),
262 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
263 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
264 dict(name='project-test2', result='SUCCESS', changes='1,1'),
265 dict(name='project-merge', result='SUCCESS', changes='2,1'),
266 dict(name='project-test1', result='SUCCESS', changes='2,1'),
267 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700268 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700269
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400270 self.assertEqual(A.data['status'], 'NEW')
271 self.assertEqual(B.data['status'], 'MERGED')
272 self.assertEqual(A.reported, 2)
273 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700274
275 def test_independent_queues(self):
276 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700277
Paul Belanger174a8272017-03-14 13:20:10 -0400278 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900279 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700280 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
281 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700282 A.addApproval('code-review', 2)
283 B.addApproval('code-review', 2)
284 C.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700285
James E. Blair8b5408c2016-08-08 15:37:46 -0700286 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800287 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700288
James E. Blairf59f3cf2017-02-19 14:50:26 -0800289 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
290 self.waitUntilSettled()
291
292 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700293 self.waitUntilSettled()
294
295 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700296 self.assertBuilds([
297 dict(name='project-merge', changes='1,1'),
298 dict(name='project-merge', changes='2,1'),
299 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700300
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700301 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700302 self.builds[0].release()
303 self.waitUntilSettled()
304 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700305 self.waitUntilSettled()
306 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400307 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700308 self.waitUntilSettled()
309
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700310 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700311 self.assertBuilds([
312 dict(name='project-test1', changes='1,1'),
313 dict(name='project-test2', changes='1,1'),
314 dict(name='project-test1', changes='2,1'),
315 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500316 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700317 dict(name='project-test1', changes='2,1 3,1'),
318 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800319 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700320 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700321
James E. Blair5f0d49e2016-08-19 09:36:50 -0700322 self.orderedRelease()
323 self.assertHistory([
324 dict(name='project-merge', result='SUCCESS', changes='1,1'),
325 dict(name='project-merge', result='SUCCESS', changes='2,1'),
326 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
327 dict(name='project-test1', result='SUCCESS', changes='1,1'),
328 dict(name='project-test2', result='SUCCESS', changes='1,1'),
329 dict(name='project-test1', result='SUCCESS', changes='2,1'),
330 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500331 dict(
332 name='project1-project2-integration',
333 result='SUCCESS',
334 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700335 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
336 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800337 dict(name='project1-project2-integration',
338 result='SUCCESS',
339 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700340 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700341
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400342 self.assertEqual(A.data['status'], 'MERGED')
343 self.assertEqual(B.data['status'], 'MERGED')
344 self.assertEqual(C.data['status'], 'MERGED')
345 self.assertEqual(A.reported, 2)
346 self.assertEqual(B.reported, 2)
347 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700348
349 def test_failed_change_at_head(self):
350 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700351
Paul Belanger174a8272017-03-14 13:20:10 -0400352 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700353 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
354 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
355 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700356 A.addApproval('code-review', 2)
357 B.addApproval('code-review', 2)
358 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700359
Paul Belanger174a8272017-03-14 13:20:10 -0400360 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700361
James E. Blair8b5408c2016-08-08 15:37:46 -0700362 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
363 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
364 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700365
366 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700367
James E. Blairb536ecc2016-08-31 10:11:42 -0700368 self.assertBuilds([
369 dict(name='project-merge', changes='1,1'),
370 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700371
Paul Belanger174a8272017-03-14 13:20:10 -0400372 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700373 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400374 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700375 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400376 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700377 self.waitUntilSettled()
378
James E. Blairb536ecc2016-08-31 10:11:42 -0700379 self.assertBuilds([
380 dict(name='project-test1', changes='1,1'),
381 dict(name='project-test2', changes='1,1'),
382 dict(name='project-test1', changes='1,1 2,1'),
383 dict(name='project-test2', changes='1,1 2,1'),
384 dict(name='project-test1', changes='1,1 2,1 3,1'),
385 dict(name='project-test2', changes='1,1 2,1 3,1'),
386 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700387
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400388 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700389 self.waitUntilSettled()
390
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400391 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700392 self.assertBuilds([
393 dict(name='project-test2', changes='1,1'),
394 dict(name='project-merge', changes='2,1'),
395 ])
396 # Unordered history comparison because the aborts can finish
397 # in any order.
398 self.assertHistory([
399 dict(name='project-merge', result='SUCCESS',
400 changes='1,1'),
401 dict(name='project-merge', result='SUCCESS',
402 changes='1,1 2,1'),
403 dict(name='project-merge', result='SUCCESS',
404 changes='1,1 2,1 3,1'),
405 dict(name='project-test1', result='FAILURE',
406 changes='1,1'),
407 dict(name='project-test1', result='ABORTED',
408 changes='1,1 2,1'),
409 dict(name='project-test2', result='ABORTED',
410 changes='1,1 2,1'),
411 dict(name='project-test1', result='ABORTED',
412 changes='1,1 2,1 3,1'),
413 dict(name='project-test2', result='ABORTED',
414 changes='1,1 2,1 3,1'),
415 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700416
Paul Belanger174a8272017-03-14 13:20:10 -0400417 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700418 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400419 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700420 self.waitUntilSettled()
421 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700422
James E. Blairb536ecc2016-08-31 10:11:42 -0700423 self.assertBuilds([])
424 self.assertHistory([
425 dict(name='project-merge', result='SUCCESS',
426 changes='1,1'),
427 dict(name='project-merge', result='SUCCESS',
428 changes='1,1 2,1'),
429 dict(name='project-merge', result='SUCCESS',
430 changes='1,1 2,1 3,1'),
431 dict(name='project-test1', result='FAILURE',
432 changes='1,1'),
433 dict(name='project-test1', result='ABORTED',
434 changes='1,1 2,1'),
435 dict(name='project-test2', result='ABORTED',
436 changes='1,1 2,1'),
437 dict(name='project-test1', result='ABORTED',
438 changes='1,1 2,1 3,1'),
439 dict(name='project-test2', result='ABORTED',
440 changes='1,1 2,1 3,1'),
441 dict(name='project-merge', result='SUCCESS',
442 changes='2,1'),
443 dict(name='project-merge', result='SUCCESS',
444 changes='2,1 3,1'),
445 dict(name='project-test2', result='SUCCESS',
446 changes='1,1'),
447 dict(name='project-test1', result='SUCCESS',
448 changes='2,1'),
449 dict(name='project-test2', result='SUCCESS',
450 changes='2,1'),
451 dict(name='project-test1', result='SUCCESS',
452 changes='2,1 3,1'),
453 dict(name='project-test2', result='SUCCESS',
454 changes='2,1 3,1'),
455 ], ordered=False)
456
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400457 self.assertEqual(A.data['status'], 'NEW')
458 self.assertEqual(B.data['status'], 'MERGED')
459 self.assertEqual(C.data['status'], 'MERGED')
460 self.assertEqual(A.reported, 2)
461 self.assertEqual(B.reported, 2)
462 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700463
James E. Blair0aac4872013-08-23 14:02:38 -0700464 def test_failed_change_in_middle(self):
465 "Test a failed change in the middle of the queue"
466
Paul Belanger174a8272017-03-14 13:20:10 -0400467 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700468 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
469 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
470 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700471 A.addApproval('code-review', 2)
472 B.addApproval('code-review', 2)
473 C.addApproval('code-review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700474
Paul Belanger174a8272017-03-14 13:20:10 -0400475 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700476
James E. Blair8b5408c2016-08-08 15:37:46 -0700477 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
478 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
479 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700480
481 self.waitUntilSettled()
482
Paul Belanger174a8272017-03-14 13:20:10 -0400483 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700484 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400485 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700486 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400487 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700488 self.waitUntilSettled()
489
490 self.assertEqual(len(self.builds), 6)
491 self.assertEqual(self.builds[0].name, 'project-test1')
492 self.assertEqual(self.builds[1].name, 'project-test2')
493 self.assertEqual(self.builds[2].name, 'project-test1')
494 self.assertEqual(self.builds[3].name, 'project-test2')
495 self.assertEqual(self.builds[4].name, 'project-test1')
496 self.assertEqual(self.builds[5].name, 'project-test2')
497
498 self.release(self.builds[2])
499 self.waitUntilSettled()
500
James E. Blair972e3c72013-08-29 12:04:55 -0700501 # project-test1 and project-test2 for A
502 # project-test2 for B
503 # project-merge for C (without B)
504 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700505 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
506
Paul Belanger174a8272017-03-14 13:20:10 -0400507 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700508 self.waitUntilSettled()
509
510 # project-test1 and project-test2 for A
511 # project-test2 for B
512 # project-test1 and project-test2 for C
513 self.assertEqual(len(self.builds), 5)
514
Paul Belanger2e2a0492016-10-30 18:33:37 -0400515 tenant = self.sched.abide.tenants.get('tenant-one')
516 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700517 builds = items[0].current_build_set.getBuilds()
518 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
519 self.assertEqual(self.countJobResults(builds, None), 2)
520 builds = items[1].current_build_set.getBuilds()
521 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
522 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
523 self.assertEqual(self.countJobResults(builds, None), 1)
524 builds = items[2].current_build_set.getBuilds()
525 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700526 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700527
Paul Belanger174a8272017-03-14 13:20:10 -0400528 self.executor_server.hold_jobs_in_build = False
529 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700530 self.waitUntilSettled()
531
532 self.assertEqual(len(self.builds), 0)
533 self.assertEqual(len(self.history), 12)
534 self.assertEqual(A.data['status'], 'MERGED')
535 self.assertEqual(B.data['status'], 'NEW')
536 self.assertEqual(C.data['status'], 'MERGED')
537 self.assertEqual(A.reported, 2)
538 self.assertEqual(B.reported, 2)
539 self.assertEqual(C.reported, 2)
540
James E. Blaird466dc42012-07-31 10:42:56 -0700541 def test_failed_change_at_head_with_queue(self):
542 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700543
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700544 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700545 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
546 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
547 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700548 A.addApproval('code-review', 2)
549 B.addApproval('code-review', 2)
550 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700551
Paul Belanger174a8272017-03-14 13:20:10 -0400552 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700553
James E. Blair8b5408c2016-08-08 15:37:46 -0700554 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
555 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
556 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700557
558 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700559 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400560 self.assertEqual(len(self.builds), 0)
561 self.assertEqual(len(queue), 1)
Clint Byrumf322fe22017-05-10 20:53:12 -0700562 self.assertEqual(queue[0].name, b'executor:execute')
563 job_args = json.loads(queue[0].arguments.decode('utf8'))
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800564 self.assertEqual(job_args['job'], 'project-merge')
565 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700566
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700567 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700568 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700569 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700570 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700571 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700572 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700573 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700574
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400575 self.assertEqual(len(self.builds), 0)
576 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800577
578 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700579 json.loads(queue[0].arguments.decode('utf8'))['job'],
580 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800581 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700582 json.loads(queue[1].arguments.decode('utf8'))['job'],
583 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800584 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700585 json.loads(queue[2].arguments.decode('utf8'))['job'],
586 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800587 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700588 json.loads(queue[3].arguments.decode('utf8'))['job'],
589 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800590 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700591 json.loads(queue[4].arguments.decode('utf8'))['job'],
592 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800593 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700594 json.loads(queue[5].arguments.decode('utf8'))['job'],
595 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700596
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700597 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700598 self.waitUntilSettled()
599
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400600 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700601 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400602 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
603 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700604
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700605 self.gearman_server.hold_jobs_in_queue = False
606 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700607 self.waitUntilSettled()
608
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400609 self.assertEqual(len(self.builds), 0)
610 self.assertEqual(len(self.history), 11)
611 self.assertEqual(A.data['status'], 'NEW')
612 self.assertEqual(B.data['status'], 'MERGED')
613 self.assertEqual(C.data['status'], 'MERGED')
614 self.assertEqual(A.reported, 2)
615 self.assertEqual(B.reported, 2)
616 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700617
James E. Blairec056492016-07-22 09:45:56 -0700618 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700619 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400620 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700621 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -0700622 A.addApproval('code-review', 2)
623 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700624 self.waitUntilSettled()
625 time.sleep(2)
626
627 data = json.loads(self.sched.formatStatusJSON())
628 found_job = None
629 for pipeline in data['pipelines']:
630 if pipeline['name'] != 'gate':
631 continue
632 for queue in pipeline['change_queues']:
633 for head in queue['heads']:
634 for item in head:
635 for job in item['jobs']:
636 if job['name'] == 'project-merge':
637 found_job = job
638 break
639
640 self.assertIsNotNone(found_job)
641 if iteration == 1:
642 self.assertIsNotNone(found_job['estimated_time'])
643 self.assertIsNone(found_job['remaining_time'])
644 else:
645 self.assertIsNotNone(found_job['estimated_time'])
646 self.assertTrue(found_job['estimated_time'] >= 2)
647 self.assertIsNotNone(found_job['remaining_time'])
648
Paul Belanger174a8272017-03-14 13:20:10 -0400649 self.executor_server.hold_jobs_in_build = False
650 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700651 self.waitUntilSettled()
652
James E. Blairec056492016-07-22 09:45:56 -0700653 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700654 def test_time_database(self):
655 "Test the time database"
656
657 self._test_time_database(1)
658 self._test_time_database(2)
659
James E. Blairfef71632013-09-23 11:15:47 -0700660 def test_two_failed_changes_at_head(self):
661 "Test that changes are reparented correctly if 2 fail at head"
662
Paul Belanger174a8272017-03-14 13:20:10 -0400663 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700664 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
665 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
666 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700667 A.addApproval('code-review', 2)
668 B.addApproval('code-review', 2)
669 C.addApproval('code-review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700670
Paul Belanger174a8272017-03-14 13:20:10 -0400671 self.executor_server.failJob('project-test1', A)
672 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700673
James E. Blair8b5408c2016-08-08 15:37:46 -0700674 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
675 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
676 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700677 self.waitUntilSettled()
678
Paul Belanger174a8272017-03-14 13:20:10 -0400679 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700680 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400681 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700682 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400683 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700684 self.waitUntilSettled()
685
686 self.assertEqual(len(self.builds), 6)
687 self.assertEqual(self.builds[0].name, 'project-test1')
688 self.assertEqual(self.builds[1].name, 'project-test2')
689 self.assertEqual(self.builds[2].name, 'project-test1')
690 self.assertEqual(self.builds[3].name, 'project-test2')
691 self.assertEqual(self.builds[4].name, 'project-test1')
692 self.assertEqual(self.builds[5].name, 'project-test2')
693
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400694 self.assertTrue(self.builds[0].hasChanges(A))
695 self.assertTrue(self.builds[2].hasChanges(A))
696 self.assertTrue(self.builds[2].hasChanges(B))
697 self.assertTrue(self.builds[4].hasChanges(A))
698 self.assertTrue(self.builds[4].hasChanges(B))
699 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700700
701 # Fail change B first
702 self.release(self.builds[2])
703 self.waitUntilSettled()
704
705 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400706 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700707 self.waitUntilSettled()
708
709 self.assertEqual(len(self.builds), 5)
710 self.assertEqual(self.builds[0].name, 'project-test1')
711 self.assertEqual(self.builds[1].name, 'project-test2')
712 self.assertEqual(self.builds[2].name, 'project-test2')
713 self.assertEqual(self.builds[3].name, 'project-test1')
714 self.assertEqual(self.builds[4].name, 'project-test2')
715
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400716 self.assertTrue(self.builds[1].hasChanges(A))
717 self.assertTrue(self.builds[2].hasChanges(A))
718 self.assertTrue(self.builds[2].hasChanges(B))
719 self.assertTrue(self.builds[4].hasChanges(A))
720 self.assertFalse(self.builds[4].hasChanges(B))
721 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700722
723 # Finish running all passing jobs for change A
724 self.release(self.builds[1])
725 self.waitUntilSettled()
726 # Fail and report change A
727 self.release(self.builds[0])
728 self.waitUntilSettled()
729
730 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400731 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700732 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400733 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700734 self.waitUntilSettled()
735
736 self.assertEqual(len(self.builds), 4)
737 self.assertEqual(self.builds[0].name, 'project-test1') # B
738 self.assertEqual(self.builds[1].name, 'project-test2') # B
739 self.assertEqual(self.builds[2].name, 'project-test1') # C
740 self.assertEqual(self.builds[3].name, 'project-test2') # C
741
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400742 self.assertFalse(self.builds[1].hasChanges(A))
743 self.assertTrue(self.builds[1].hasChanges(B))
744 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700745
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400746 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700747 # After A failed and B and C restarted, B should be back in
748 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400749 self.assertTrue(self.builds[2].hasChanges(B))
750 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700751
Paul Belanger174a8272017-03-14 13:20:10 -0400752 self.executor_server.hold_jobs_in_build = False
753 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700754 self.waitUntilSettled()
755
756 self.assertEqual(len(self.builds), 0)
757 self.assertEqual(len(self.history), 21)
758 self.assertEqual(A.data['status'], 'NEW')
759 self.assertEqual(B.data['status'], 'NEW')
760 self.assertEqual(C.data['status'], 'MERGED')
761 self.assertEqual(A.reported, 2)
762 self.assertEqual(B.reported, 2)
763 self.assertEqual(C.reported, 2)
764
James E. Blair8c803f82012-07-31 16:25:42 -0700765 def test_patch_order(self):
766 "Test that dependent patches are tested in the right order"
767 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
768 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
769 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700770 A.addApproval('code-review', 2)
771 B.addApproval('code-review', 2)
772 C.addApproval('code-review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700773
774 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
775 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
776 M2.setMerged()
777 M1.setMerged()
778
779 # C -> B -> A -> M1 -> M2
780 # M2 is here to make sure it is never queried. If it is, it
781 # means zuul is walking down the entire history of merged
782 # changes.
783
784 C.setDependsOn(B, 1)
785 B.setDependsOn(A, 1)
786 A.setDependsOn(M1, 1)
787 M1.setDependsOn(M2, 1)
788
James E. Blair8b5408c2016-08-08 15:37:46 -0700789 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700790
791 self.waitUntilSettled()
792
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400793 self.assertEqual(A.data['status'], 'NEW')
794 self.assertEqual(B.data['status'], 'NEW')
795 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700796
James E. Blair8b5408c2016-08-08 15:37:46 -0700797 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
798 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700799
800 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400801 self.assertEqual(M2.queried, 0)
802 self.assertEqual(A.data['status'], 'MERGED')
803 self.assertEqual(B.data['status'], 'MERGED')
804 self.assertEqual(C.data['status'], 'MERGED')
805 self.assertEqual(A.reported, 2)
806 self.assertEqual(B.reported, 2)
807 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700808
James E. Blair063672f2015-01-29 13:09:12 -0800809 def test_needed_changes_enqueue(self):
810 "Test that a needed change is enqueued ahead"
811 # A Given a git tree like this, if we enqueue
812 # / \ change C, we should walk up and down the tree
813 # B G and enqueue changes in the order ABCDEFG.
814 # /|\ This is also the order that you would get if
815 # *C E F you enqueued changes in the order ABCDEFG, so
816 # / the ordering is stable across re-enqueue events.
817 # D
818
819 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
820 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
821 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
822 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
823 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
824 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
825 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
826 B.setDependsOn(A, 1)
827 C.setDependsOn(B, 1)
828 D.setDependsOn(C, 1)
829 E.setDependsOn(B, 1)
830 F.setDependsOn(B, 1)
831 G.setDependsOn(A, 1)
832
James E. Blair8b5408c2016-08-08 15:37:46 -0700833 A.addApproval('code-review', 2)
834 B.addApproval('code-review', 2)
835 C.addApproval('code-review', 2)
836 D.addApproval('code-review', 2)
837 E.addApproval('code-review', 2)
838 F.addApproval('code-review', 2)
839 G.addApproval('code-review', 2)
840 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800841
842 self.waitUntilSettled()
843
844 self.assertEqual(A.data['status'], 'NEW')
845 self.assertEqual(B.data['status'], 'NEW')
846 self.assertEqual(C.data['status'], 'NEW')
847 self.assertEqual(D.data['status'], 'NEW')
848 self.assertEqual(E.data['status'], 'NEW')
849 self.assertEqual(F.data['status'], 'NEW')
850 self.assertEqual(G.data['status'], 'NEW')
851
852 # We're about to add approvals to changes without adding the
853 # triggering events to Zuul, so that we can be sure that it is
854 # enqueing the changes based on dependencies, not because of
855 # triggering events. Since it will have the changes cached
856 # already (without approvals), we need to clear the cache
857 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400858 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +1100859 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800860
Paul Belanger174a8272017-03-14 13:20:10 -0400861 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -0700862 A.addApproval('approved', 1)
863 B.addApproval('approved', 1)
864 D.addApproval('approved', 1)
865 E.addApproval('approved', 1)
866 F.addApproval('approved', 1)
867 G.addApproval('approved', 1)
868 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800869
870 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400871 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800872 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400873 self.executor_server.hold_jobs_in_build = False
874 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800875 self.waitUntilSettled()
876
877 self.assertEqual(A.data['status'], 'MERGED')
878 self.assertEqual(B.data['status'], 'MERGED')
879 self.assertEqual(C.data['status'], 'MERGED')
880 self.assertEqual(D.data['status'], 'MERGED')
881 self.assertEqual(E.data['status'], 'MERGED')
882 self.assertEqual(F.data['status'], 'MERGED')
883 self.assertEqual(G.data['status'], 'MERGED')
884 self.assertEqual(A.reported, 2)
885 self.assertEqual(B.reported, 2)
886 self.assertEqual(C.reported, 2)
887 self.assertEqual(D.reported, 2)
888 self.assertEqual(E.reported, 2)
889 self.assertEqual(F.reported, 2)
890 self.assertEqual(G.reported, 2)
891 self.assertEqual(self.history[6].changes,
892 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
893
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100894 def test_source_cache(self):
895 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400896 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700897
898 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
899 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
900 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
James E. Blair8b5408c2016-08-08 15:37:46 -0700901 A.addApproval('code-review', 2)
902 B.addApproval('code-review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700903
904 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
905 M1.setMerged()
906
907 B.setDependsOn(A, 1)
908 A.setDependsOn(M1, 1)
909
James E. Blair8b5408c2016-08-08 15:37:46 -0700910 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700911 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
912
913 self.waitUntilSettled()
914
915 for build in self.builds:
James E. Blaire675d682017-07-21 15:29:35 -0700916 if build.pipeline == 'check':
James E. Blair0e933c52013-07-11 10:18:52 -0700917 build.release()
918 self.waitUntilSettled()
919 for build in self.builds:
James E. Blaire675d682017-07-21 15:29:35 -0700920 if build.pipeline == 'check':
James E. Blair0e933c52013-07-11 10:18:52 -0700921 build.release()
922 self.waitUntilSettled()
923
James E. Blair8b5408c2016-08-08 15:37:46 -0700924 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700925 self.waitUntilSettled()
926
Joshua Hesketh352264b2015-08-11 23:42:08 +1000927 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700928 # there should still be changes in the cache
Joshua Hesketh352264b2015-08-11 23:42:08 +1000929 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700930
Paul Belanger174a8272017-03-14 13:20:10 -0400931 self.executor_server.hold_jobs_in_build = False
932 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700933 self.waitUntilSettled()
934
935 self.assertEqual(A.data['status'], 'MERGED')
936 self.assertEqual(B.data['status'], 'MERGED')
937 self.assertEqual(A.queried, 2) # Initial and isMerged
938 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
939
James E. Blair8c803f82012-07-31 16:25:42 -0700940 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700941 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700942 # TODO: move to test_gerrit (this is a unit test!)
943 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400944 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700945 (trusted, project) = tenant.getProject('org/project')
946 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400947
948 # TODO(pabelanger): As we add more source / trigger APIs we should make
949 # it easier for users to create events for testing.
950 event = zuul.model.TriggerEvent()
951 event.trigger_name = 'gerrit'
952 event.change_number = '1'
953 event.patch_number = '2'
954
955 a = source.getChange(event)
956 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700957 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700958
James E. Blair8b5408c2016-08-08 15:37:46 -0700959 A.addApproval('code-review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400960 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700961 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700962
James E. Blair8b5408c2016-08-08 15:37:46 -0700963 A.addApproval('approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400964 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700965 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700966
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700967 def test_project_merge_conflict(self):
968 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700969
970 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700971 A = self.fake_gerrit.addFakeChange('org/project',
972 'master', 'A',
973 files={'conflict': 'foo'})
974 B = self.fake_gerrit.addFakeChange('org/project',
975 'master', 'B',
976 files={'conflict': 'bar'})
977 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -0700978 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700979 A.addApproval('code-review', 2)
980 B.addApproval('code-review', 2)
981 C.addApproval('code-review', 2)
982 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
983 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
984 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -0700985 self.waitUntilSettled()
986
James E. Blair6736beb2013-07-11 15:18:15 -0700987 self.assertEqual(A.reported, 1)
James E. Blair6736beb2013-07-11 15:18:15 -0700988 self.assertEqual(C.reported, 1)
989
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700990 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700991 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700992 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700993 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700994 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700995 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -0700996
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700997 self.gearman_server.hold_jobs_in_queue = False
998 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -0700999 self.waitUntilSettled()
1000
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001001 self.assertEqual(A.data['status'], 'MERGED')
1002 self.assertEqual(B.data['status'], 'NEW')
1003 self.assertEqual(C.data['status'], 'MERGED')
1004 self.assertEqual(A.reported, 2)
Tobias Henkel9842bd72017-05-16 13:40:03 +02001005 self.assertIn('Merge Failed', B.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001006 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001007
1008 self.assertHistory([
1009 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1010 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1011 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1012 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
1013 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
1014 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
1015 ], ordered=False)
1016
1017 def test_delayed_merge_conflict(self):
1018 "Test that delayed check merge conflicts are handled properly"
1019
1020 # Hold jobs in the gearman queue so that we can test whether
James E. Blair1960d682017-04-28 15:44:14 -07001021 # the executor sucesfully merges a change based on an old
1022 # repo state (frozen by the scheduler) which would otherwise
1023 # conflict.
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001024 self.gearman_server.hold_jobs_in_queue = True
1025 A = self.fake_gerrit.addFakeChange('org/project',
1026 'master', 'A',
1027 files={'conflict': 'foo'})
1028 B = self.fake_gerrit.addFakeChange('org/project',
1029 'master', 'B',
1030 files={'conflict': 'bar'})
1031 C = self.fake_gerrit.addFakeChange('org/project',
1032 'master', 'C')
1033 C.setDependsOn(B, 1)
1034
1035 # A enters the gate queue; B and C enter the check queue
1036 A.addApproval('code-review', 2)
1037 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1038 self.waitUntilSettled()
1039 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
James E. Blair8d144dc2017-05-05 10:13:45 -07001040 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001041 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1042 self.waitUntilSettled()
1043
1044 self.assertEqual(A.reported, 1)
1045 self.assertEqual(B.reported, 0) # Check does not report start
1046 self.assertEqual(C.reported, 0) # Check does not report start
1047
1048 # A merges while B and C are queued in check
1049 # Release A project-merge
1050 queue = self.gearman_server.getQueue()
1051 self.release(queue[0])
1052 self.waitUntilSettled()
1053
1054 # Release A project-test*
1055 # gate has higher precedence, so A's test jobs are added in
1056 # front of the merge jobs for B and C
1057 queue = self.gearman_server.getQueue()
1058 self.release(queue[0])
1059 self.release(queue[1])
1060 self.waitUntilSettled()
1061
1062 self.assertEqual(A.data['status'], 'MERGED')
1063 self.assertEqual(B.data['status'], 'NEW')
1064 self.assertEqual(C.data['status'], 'NEW')
1065 self.assertEqual(A.reported, 2)
1066 self.assertEqual(B.reported, 0)
1067 self.assertEqual(C.reported, 0)
1068 self.assertHistory([
1069 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1070 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1071 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1072 ], ordered=False)
1073
1074 # B and C report merge conflicts
1075 # Release B project-merge
1076 queue = self.gearman_server.getQueue()
1077 self.release(queue[0])
1078 self.waitUntilSettled()
1079
1080 # Release C
1081 self.gearman_server.hold_jobs_in_queue = False
1082 self.gearman_server.release()
1083 self.waitUntilSettled()
1084
1085 self.assertEqual(A.data['status'], 'MERGED')
1086 self.assertEqual(B.data['status'], 'NEW')
1087 self.assertEqual(C.data['status'], 'NEW')
1088 self.assertEqual(A.reported, 2)
1089 self.assertEqual(B.reported, 1)
1090 self.assertEqual(C.reported, 1)
1091
1092 self.assertHistory([
1093 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1094 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1095 dict(name='project-test2', result='SUCCESS', changes='1,1'),
James E. Blair1960d682017-04-28 15:44:14 -07001096 dict(name='project-merge', result='SUCCESS', changes='2,1'),
1097 dict(name='project-test1', result='SUCCESS', changes='2,1'),
1098 dict(name='project-test2', result='SUCCESS', changes='2,1'),
1099 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
1100 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
1101 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001102 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001103
James E. Blairdaabed22012-08-15 15:38:57 -07001104 def test_post(self):
1105 "Test that post jobs run"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001106
Zhongyue Luo5d556072012-09-21 02:00:47 +09001107 e = {
1108 "type": "ref-updated",
1109 "submitter": {
1110 "name": "User Name",
1111 },
1112 "refUpdate": {
1113 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1114 "newRev": "d479a0bfcb34da57a31adb2a595c0cf687812543",
1115 "refName": "master",
1116 "project": "org/project",
1117 }
1118 }
James E. Blairdaabed22012-08-15 15:38:57 -07001119 self.fake_gerrit.addEvent(e)
1120 self.waitUntilSettled()
1121
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001122 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001123 self.assertEqual(len(self.history), 1)
1124 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001125
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001126 def test_post_ignore_deletes(self):
1127 "Test that deleting refs does not trigger post jobs"
1128
1129 e = {
1130 "type": "ref-updated",
1131 "submitter": {
1132 "name": "User Name",
1133 },
1134 "refUpdate": {
1135 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1136 "newRev": "0000000000000000000000000000000000000000",
1137 "refName": "master",
1138 "project": "org/project",
1139 }
1140 }
1141 self.fake_gerrit.addEvent(e)
1142 self.waitUntilSettled()
1143
1144 job_names = [x.name for x in self.history]
1145 self.assertEqual(len(self.history), 0)
1146 self.assertNotIn('project-post', job_names)
1147
James E. Blaircc324192017-04-19 14:36:08 -07001148 @simple_layout('layouts/dont-ignore-ref-deletes.yaml')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001149 def test_post_ignore_deletes_negative(self):
1150 "Test that deleting refs does trigger post jobs"
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001151 e = {
1152 "type": "ref-updated",
1153 "submitter": {
1154 "name": "User Name",
1155 },
1156 "refUpdate": {
1157 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1158 "newRev": "0000000000000000000000000000000000000000",
1159 "refName": "master",
1160 "project": "org/project",
1161 }
1162 }
1163 self.fake_gerrit.addEvent(e)
1164 self.waitUntilSettled()
1165
1166 job_names = [x.name for x in self.history]
1167 self.assertEqual(len(self.history), 1)
1168 self.assertIn('project-post', job_names)
1169
James E. Blairec056492016-07-22 09:45:56 -07001170 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001171 def test_build_configuration_branch_interaction(self):
1172 "Test that switching between branches works"
1173 self.test_build_configuration()
1174 self.test_build_configuration_branch()
1175 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001176 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001177 repo = git.Repo(path)
1178 repo.heads.master.commit = repo.commit('init')
1179 self.test_build_configuration()
1180
James E. Blairdb93b302017-07-19 15:33:11 -07001181 def test_dependent_changes_rebase(self):
1182 # Test that no errors occur when we walk a dependency tree
1183 # with an unused leaf node due to a rebase.
1184 # Start by constructing: C -> B -> A
1185 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1186 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1187 B.setDependsOn(A, 1)
1188
1189 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1190 C.setDependsOn(B, 1)
1191
1192 # Then rebase to form: D -> C -> A
1193 C.addPatchset() # C,2
1194 C.setDependsOn(A, 1)
1195
1196 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1197 D.setDependsOn(C, 2)
1198
1199 # Walk the entire tree
1200 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1201 self.waitUntilSettled()
1202 self.assertEqual(len(self.history), 3)
1203
1204 # Verify that walking just part of the tree still works
1205 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
1206 self.waitUntilSettled()
1207 self.assertEqual(len(self.history), 6)
1208
James E. Blaircaec0c52012-08-22 14:52:22 -07001209 def test_dependent_changes_dequeue(self):
1210 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001211
James E. Blaircaec0c52012-08-22 14:52:22 -07001212 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1213 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1214 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001215 A.addApproval('code-review', 2)
1216 B.addApproval('code-review', 2)
1217 C.addApproval('code-review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001218
1219 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1220 M1.setMerged()
1221
1222 # C -> B -> A -> M1
1223
1224 C.setDependsOn(B, 1)
1225 B.setDependsOn(A, 1)
1226 A.setDependsOn(M1, 1)
1227
Paul Belanger174a8272017-03-14 13:20:10 -04001228 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001229
James E. Blair8b5408c2016-08-08 15:37:46 -07001230 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1231 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1232 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001233
1234 self.waitUntilSettled()
1235
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001236 self.assertEqual(A.data['status'], 'NEW')
1237 self.assertEqual(A.reported, 2)
1238 self.assertEqual(B.data['status'], 'NEW')
1239 self.assertEqual(B.reported, 2)
1240 self.assertEqual(C.data['status'], 'NEW')
James E. Blair0d3e83b2017-06-05 13:51:57 -07001241 self.assertIn('This change depends on a change that failed to merge.',
1242 C.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001243 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001244
James E. Blair972e3c72013-08-29 12:04:55 -07001245 def test_failing_dependent_changes(self):
1246 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001247 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001248 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1249 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1250 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1251 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1252 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
James E. Blair8b5408c2016-08-08 15:37:46 -07001253 A.addApproval('code-review', 2)
1254 B.addApproval('code-review', 2)
1255 C.addApproval('code-review', 2)
1256 D.addApproval('code-review', 2)
1257 E.addApproval('code-review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001258
1259 # E, D -> C -> B, A
1260
1261 D.setDependsOn(C, 1)
1262 C.setDependsOn(B, 1)
1263
Paul Belanger174a8272017-03-14 13:20:10 -04001264 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001265
James E. Blair8b5408c2016-08-08 15:37:46 -07001266 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1267 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
1268 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1269 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1270 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001271
1272 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001273 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001274 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001275 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001276 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001277 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001278 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001279 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001280 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001281 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001282 self.waitUntilSettled()
1283
Paul Belanger174a8272017-03-14 13:20:10 -04001284 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001285 for build in self.builds:
James E. Blaire3db2952017-07-21 15:03:36 -07001286 if build.parameters['zuul']['change'] != '1':
James E. Blair972e3c72013-08-29 12:04:55 -07001287 build.release()
1288 self.waitUntilSettled()
1289
Paul Belanger174a8272017-03-14 13:20:10 -04001290 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001291 self.waitUntilSettled()
1292
1293 self.assertEqual(A.data['status'], 'MERGED')
1294 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001295 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001296 self.assertEqual(B.data['status'], 'NEW')
1297 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001298 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001299 self.assertEqual(C.data['status'], 'NEW')
1300 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001301 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001302 self.assertEqual(D.data['status'], 'NEW')
1303 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001304 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001305 self.assertEqual(E.data['status'], 'MERGED')
1306 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001307 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001308 self.assertEqual(len(self.history), 18)
1309
James E. Blairec590122012-08-22 15:19:31 -07001310 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001311 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001312 # If it's dequeued more than once, we should see extra
1313 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001314
Paul Belanger174a8272017-03-14 13:20:10 -04001315 self.executor_server.hold_jobs_in_build = True
James E. Blair6df67132017-04-19 13:53:20 -07001316 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1317 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1318 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001319 A.addApproval('code-review', 2)
1320 B.addApproval('code-review', 2)
1321 C.addApproval('code-review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001322
Paul Belanger174a8272017-03-14 13:20:10 -04001323 self.executor_server.failJob('project-test1', A)
1324 self.executor_server.failJob('project-test2', A)
James E. Blairec590122012-08-22 15:19:31 -07001325
James E. Blair8b5408c2016-08-08 15:37:46 -07001326 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1327 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1328 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001329
1330 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001331
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001332 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001333 self.assertEqual(self.builds[0].name, 'project-merge')
1334 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001335
Paul Belanger174a8272017-03-14 13:20:10 -04001336 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001337 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001338 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001339 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001340 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001341 self.waitUntilSettled()
1342
James E. Blair6df67132017-04-19 13:53:20 -07001343 self.assertEqual(len(self.builds), 6)
Paul Belanger58bf6912016-11-11 19:36:01 -05001344 self.assertEqual(self.builds[0].name, 'project-test1')
1345 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair6df67132017-04-19 13:53:20 -07001346 self.assertEqual(self.builds[2].name, 'project-test1')
1347 self.assertEqual(self.builds[3].name, 'project-test2')
1348 self.assertEqual(self.builds[4].name, 'project-test1')
1349 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blairec590122012-08-22 15:19:31 -07001350
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001351 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001352 self.waitUntilSettled()
1353
James E. Blair6df67132017-04-19 13:53:20 -07001354 self.assertEqual(len(self.builds), 2) # test2, merge for B
1355 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
James E. Blairec590122012-08-22 15:19:31 -07001356
Paul Belanger174a8272017-03-14 13:20:10 -04001357 self.executor_server.hold_jobs_in_build = False
1358 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001359 self.waitUntilSettled()
1360
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001361 self.assertEqual(len(self.builds), 0)
James E. Blair6df67132017-04-19 13:53:20 -07001362 self.assertEqual(len(self.history), 15)
James E. Blaircaec0c52012-08-22 14:52:22 -07001363
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001364 self.assertEqual(A.data['status'], 'NEW')
1365 self.assertEqual(B.data['status'], 'MERGED')
1366 self.assertEqual(C.data['status'], 'MERGED')
1367 self.assertEqual(A.reported, 2)
1368 self.assertEqual(B.reported, 2)
1369 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001370
James E. Blaircc020532017-04-19 13:04:44 -07001371 @simple_layout('layouts/nonvoting-job.yaml')
James E. Blair4ec821f2012-08-23 15:28:28 -07001372 def test_nonvoting_job(self):
1373 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001374
James E. Blair4ec821f2012-08-23 15:28:28 -07001375 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1376 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001377 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001378 self.executor_server.failJob('nonvoting-project-test2', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07001379 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001380
1381 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001382
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001383 self.assertEqual(A.data['status'], 'MERGED')
1384 self.assertEqual(A.reported, 2)
1385 self.assertEqual(
1386 self.getJobFromHistory('nonvoting-project-merge').result,
1387 'SUCCESS')
1388 self.assertEqual(
1389 self.getJobFromHistory('nonvoting-project-test1').result,
1390 'SUCCESS')
1391 self.assertEqual(
1392 self.getJobFromHistory('nonvoting-project-test2').result,
1393 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001394
James E. Blair2ef29e92017-07-21 15:25:05 -07001395 self.assertTrue(self.getJobFromHistory('nonvoting-project-merge').
1396 parameters['zuul']['voting'])
1397 self.assertTrue(self.getJobFromHistory('nonvoting-project-test1').
1398 parameters['zuul']['voting'])
1399 self.assertFalse(self.getJobFromHistory('nonvoting-project-test2').
1400 parameters['zuul']['voting'])
James E. Blair5821bd92015-09-16 08:48:15 -07001401
James E. Blaire0487072012-08-29 17:38:31 -07001402 def test_check_queue_success(self):
1403 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001404
James E. Blaire0487072012-08-29 17:38:31 -07001405 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1406 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1407
1408 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001409
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001410 self.assertEqual(A.data['status'], 'NEW')
1411 self.assertEqual(A.reported, 1)
1412 self.assertEqual(self.getJobFromHistory('project-merge').result,
1413 'SUCCESS')
1414 self.assertEqual(self.getJobFromHistory('project-test1').result,
1415 'SUCCESS')
1416 self.assertEqual(self.getJobFromHistory('project-test2').result,
1417 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001418
1419 def test_check_queue_failure(self):
1420 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001421
James E. Blaire0487072012-08-29 17:38:31 -07001422 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001423 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001424 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1425
1426 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001427
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001428 self.assertEqual(A.data['status'], 'NEW')
1429 self.assertEqual(A.reported, 1)
1430 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001431 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001432 self.assertEqual(self.getJobFromHistory('project-test1').result,
1433 'SUCCESS')
1434 self.assertEqual(self.getJobFromHistory('project-test2').result,
1435 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001436
James E. Blair7cb84542017-04-19 13:35:05 -07001437 @simple_layout('layouts/three-projects.yaml')
James E. Blair127bc182012-08-28 15:55:15 -07001438 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001439 # This particular test does a large amount of merges and needs a little
1440 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001441 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001442 "test that dependent changes behind dequeued changes work"
1443 # This complicated test is a reproduction of a real life bug
1444 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001445
Paul Belanger174a8272017-03-14 13:20:10 -04001446 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001447 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1448 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1449 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1450 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1451 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1452 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1453 D.setDependsOn(C, 1)
1454 E.setDependsOn(D, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07001455 A.addApproval('code-review', 2)
1456 B.addApproval('code-review', 2)
1457 C.addApproval('code-review', 2)
1458 D.addApproval('code-review', 2)
1459 E.addApproval('code-review', 2)
1460 F.addApproval('code-review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001461
1462 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001463
1464 # Change object re-use in the gerrit trigger is hidden if
1465 # changes are added in quick succession; waiting makes it more
1466 # like real life.
James E. Blair8b5408c2016-08-08 15:37:46 -07001467 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001468 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001469 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001470 self.waitUntilSettled()
1471
Paul Belanger174a8272017-03-14 13:20:10 -04001472 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001473 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001474 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001475 self.waitUntilSettled()
1476
James E. Blair8b5408c2016-08-08 15:37:46 -07001477 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001478 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001479 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001480 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001481 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001482 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001483 self.fake_gerrit.addEvent(F.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001484 self.waitUntilSettled()
1485
Paul Belanger174a8272017-03-14 13:20:10 -04001486 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001487 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001488 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001489 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001490 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001491 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001492 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001493 self.waitUntilSettled()
1494
1495 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001496
1497 # Grab pointers to the jobs we want to release before
1498 # releasing any, because list indexes may change as
1499 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001500 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001501 a.release()
1502 b.release()
1503 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001504 self.waitUntilSettled()
1505
Paul Belanger174a8272017-03-14 13:20:10 -04001506 self.executor_server.hold_jobs_in_build = False
1507 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001508 self.waitUntilSettled()
1509
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001510 self.assertEqual(A.data['status'], 'NEW')
1511 self.assertEqual(B.data['status'], 'MERGED')
1512 self.assertEqual(C.data['status'], 'MERGED')
1513 self.assertEqual(D.data['status'], 'MERGED')
1514 self.assertEqual(E.data['status'], 'MERGED')
1515 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001516
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001517 self.assertEqual(A.reported, 2)
1518 self.assertEqual(B.reported, 2)
1519 self.assertEqual(C.reported, 2)
1520 self.assertEqual(D.reported, 2)
1521 self.assertEqual(E.reported, 2)
1522 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001523
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001524 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1525 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001526
1527 def test_merger_repack(self):
1528 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001529
James E. Blair05fed602012-09-07 12:45:24 -07001530 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001531 A.addApproval('code-review', 2)
1532 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001533 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001534 self.assertEqual(self.getJobFromHistory('project-merge').result,
1535 'SUCCESS')
1536 self.assertEqual(self.getJobFromHistory('project-test1').result,
1537 'SUCCESS')
1538 self.assertEqual(self.getJobFromHistory('project-test2').result,
1539 'SUCCESS')
1540 self.assertEqual(A.data['status'], 'MERGED')
1541 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001542 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001543 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001544
James E. Blair2a535672017-04-27 12:03:15 -07001545 path = os.path.join(self.merger_src_root, "review.example.com",
1546 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001547 if os.path.exists(path):
1548 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001549 path = os.path.join(self.executor_src_root, "review.example.com",
1550 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001551 if os.path.exists(path):
1552 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001553
1554 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001555 A.addApproval('code-review', 2)
1556 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001557 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001558 self.assertEqual(self.getJobFromHistory('project-merge').result,
1559 'SUCCESS')
1560 self.assertEqual(self.getJobFromHistory('project-test1').result,
1561 'SUCCESS')
1562 self.assertEqual(self.getJobFromHistory('project-test2').result,
1563 'SUCCESS')
1564 self.assertEqual(A.data['status'], 'MERGED')
1565 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001566
James E. Blair4886f282012-11-15 09:27:33 -08001567 def test_merger_repack_large_change(self):
1568 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001569 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001570 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001571 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6df67132017-04-19 13:53:20 -07001572 trusted, project = tenant.getProject('org/project')
James E. Blair0ffa0102017-03-30 13:11:33 -07001573 url = self.fake_gerrit.getGitUrl(project)
James E. Blair8d144dc2017-05-05 10:13:45 -07001574 self.executor_server.merger._addProject('review.example.com',
James E. Blair197e8202017-06-09 12:54:28 -07001575 'org/project', url, None)
James E. Blair6df67132017-04-19 13:53:20 -07001576 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair4886f282012-11-15 09:27:33 -08001577 A.addPatchset(large=True)
James E. Blair2a535672017-04-27 12:03:15 -07001578 # TODOv3(jeblair): add hostname to upstream root
1579 path = os.path.join(self.upstream_root, 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001580 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001581 path = os.path.join(self.merger_src_root, 'review.example.com',
1582 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001583 if os.path.exists(path):
1584 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001585 path = os.path.join(self.executor_src_root, 'review.example.com',
1586 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001587 if os.path.exists(path):
1588 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001589
James E. Blair8b5408c2016-08-08 15:37:46 -07001590 A.addApproval('code-review', 2)
1591 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001592 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001593 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001594 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001595 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001596 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001597 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001598 'SUCCESS')
1599 self.assertEqual(A.data['status'], 'MERGED')
1600 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001601
James E. Blair2fa50962013-01-30 21:50:41 -08001602 def test_new_patchset_dequeues_old(self):
1603 "Test that a new patchset causes the old to be dequeued"
1604 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001605 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001606 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1607 M.setMerged()
1608
1609 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1610 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1611 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1612 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001613 A.addApproval('code-review', 2)
1614 B.addApproval('code-review', 2)
1615 C.addApproval('code-review', 2)
1616 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001617
1618 C.setDependsOn(B, 1)
1619 B.setDependsOn(A, 1)
1620 A.setDependsOn(M, 1)
1621
James E. Blair8b5408c2016-08-08 15:37:46 -07001622 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1623 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1624 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1625 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001626 self.waitUntilSettled()
1627
1628 B.addPatchset()
1629 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1630 self.waitUntilSettled()
1631
Paul Belanger174a8272017-03-14 13:20:10 -04001632 self.executor_server.hold_jobs_in_build = False
1633 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001634 self.waitUntilSettled()
1635
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001636 self.assertEqual(A.data['status'], 'MERGED')
1637 self.assertEqual(A.reported, 2)
1638 self.assertEqual(B.data['status'], 'NEW')
1639 self.assertEqual(B.reported, 2)
1640 self.assertEqual(C.data['status'], 'NEW')
1641 self.assertEqual(C.reported, 2)
1642 self.assertEqual(D.data['status'], 'MERGED')
1643 self.assertEqual(D.reported, 2)
1644 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001645
James E. Blairba437362015-02-07 11:41:52 -08001646 def test_new_patchset_check(self):
1647 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001648
Paul Belanger174a8272017-03-14 13:20:10 -04001649 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001650
1651 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001652 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001653 tenant = self.sched.abide.tenants.get('tenant-one')
1654 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001655
1656 # Add two git-dependent changes
1657 B.setDependsOn(A, 1)
1658 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1659 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001660 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1661 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001662
1663 # A live item, and a non-live/live pair
1664 items = check_pipeline.getAllItems()
1665 self.assertEqual(len(items), 3)
1666
1667 self.assertEqual(items[0].change.number, '1')
1668 self.assertEqual(items[0].change.patchset, '1')
1669 self.assertFalse(items[0].live)
1670
1671 self.assertEqual(items[1].change.number, '2')
1672 self.assertEqual(items[1].change.patchset, '1')
1673 self.assertTrue(items[1].live)
1674
1675 self.assertEqual(items[2].change.number, '1')
1676 self.assertEqual(items[2].change.patchset, '1')
1677 self.assertTrue(items[2].live)
1678
1679 # Add a new patchset to A
1680 A.addPatchset()
1681 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1682 self.waitUntilSettled()
1683
1684 # The live copy of A,1 should be gone, but the non-live and B
1685 # should continue, and we should have a new A,2
1686 items = check_pipeline.getAllItems()
1687 self.assertEqual(len(items), 3)
1688
1689 self.assertEqual(items[0].change.number, '1')
1690 self.assertEqual(items[0].change.patchset, '1')
1691 self.assertFalse(items[0].live)
1692
1693 self.assertEqual(items[1].change.number, '2')
1694 self.assertEqual(items[1].change.patchset, '1')
1695 self.assertTrue(items[1].live)
1696
1697 self.assertEqual(items[2].change.number, '1')
1698 self.assertEqual(items[2].change.patchset, '2')
1699 self.assertTrue(items[2].live)
1700
1701 # Add a new patchset to B
1702 B.addPatchset()
1703 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1704 self.waitUntilSettled()
1705
1706 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1707 # but we should have a new B,2 (still based on A,1)
1708 items = check_pipeline.getAllItems()
1709 self.assertEqual(len(items), 3)
1710
1711 self.assertEqual(items[0].change.number, '1')
1712 self.assertEqual(items[0].change.patchset, '2')
1713 self.assertTrue(items[0].live)
1714
1715 self.assertEqual(items[1].change.number, '1')
1716 self.assertEqual(items[1].change.patchset, '1')
1717 self.assertFalse(items[1].live)
1718
1719 self.assertEqual(items[2].change.number, '2')
1720 self.assertEqual(items[2].change.patchset, '2')
1721 self.assertTrue(items[2].live)
1722
1723 self.builds[0].release()
1724 self.waitUntilSettled()
1725 self.builds[0].release()
1726 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001727 self.executor_server.hold_jobs_in_build = False
1728 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001729 self.waitUntilSettled()
1730
1731 self.assertEqual(A.reported, 1)
1732 self.assertEqual(B.reported, 1)
1733 self.assertEqual(self.history[0].result, 'ABORTED')
1734 self.assertEqual(self.history[0].changes, '1,1')
1735 self.assertEqual(self.history[1].result, 'ABORTED')
1736 self.assertEqual(self.history[1].changes, '1,1 2,1')
1737 self.assertEqual(self.history[2].result, 'SUCCESS')
1738 self.assertEqual(self.history[2].changes, '1,2')
1739 self.assertEqual(self.history[3].result, 'SUCCESS')
1740 self.assertEqual(self.history[3].changes, '1,1 2,2')
1741
1742 def test_abandoned_gate(self):
1743 "Test that an abandoned change is dequeued from gate"
1744
Paul Belanger174a8272017-03-14 13:20:10 -04001745 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001746
1747 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001748 A.addApproval('code-review', 2)
1749 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001750 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001751 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1752 self.assertEqual(self.builds[0].name, 'project-merge')
1753
1754 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1755 self.waitUntilSettled()
1756
Paul Belanger174a8272017-03-14 13:20:10 -04001757 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001758 self.waitUntilSettled()
1759
Arie5b4048c2016-10-05 16:12:06 +03001760 self.assertBuilds([])
1761 self.assertHistory([
1762 dict(name='project-merge', result='ABORTED', changes='1,1')],
1763 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001764 self.assertEqual(A.reported, 1,
1765 "Abandoned gate change should report only start")
1766
1767 def test_abandoned_check(self):
1768 "Test that an abandoned change is dequeued from check"
1769
Paul Belanger174a8272017-03-14 13:20:10 -04001770 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001771
1772 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1773 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001774 tenant = self.sched.abide.tenants.get('tenant-one')
1775 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001776
1777 # Add two git-dependent changes
1778 B.setDependsOn(A, 1)
1779 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1780 self.waitUntilSettled()
1781 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1782 self.waitUntilSettled()
1783 # A live item, and a non-live/live pair
1784 items = check_pipeline.getAllItems()
1785 self.assertEqual(len(items), 3)
1786
1787 self.assertEqual(items[0].change.number, '1')
1788 self.assertFalse(items[0].live)
1789
1790 self.assertEqual(items[1].change.number, '2')
1791 self.assertTrue(items[1].live)
1792
1793 self.assertEqual(items[2].change.number, '1')
1794 self.assertTrue(items[2].live)
1795
1796 # Abandon A
1797 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1798 self.waitUntilSettled()
1799
1800 # The live copy of A should be gone, but the non-live and B
1801 # should continue
1802 items = check_pipeline.getAllItems()
1803 self.assertEqual(len(items), 2)
1804
1805 self.assertEqual(items[0].change.number, '1')
1806 self.assertFalse(items[0].live)
1807
1808 self.assertEqual(items[1].change.number, '2')
1809 self.assertTrue(items[1].live)
1810
Paul Belanger174a8272017-03-14 13:20:10 -04001811 self.executor_server.hold_jobs_in_build = False
1812 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001813 self.waitUntilSettled()
1814
1815 self.assertEqual(len(self.history), 4)
1816 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001817 'Build should have been aborted')
1818 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001819 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001820
Steve Varnau7b78b312015-04-03 14:49:46 -07001821 def test_abandoned_not_timer(self):
1822 "Test that an abandoned change does not cancel timer jobs"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001823 # This test can not use simple_layout because it must start
1824 # with a configuration which does not include a
1825 # timer-triggered job so that we have an opportunity to set
1826 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04001827 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001828 # Start timer trigger - also org/project
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001829 self.commitConfigUpdate('common-config', 'layouts/idle.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001830 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001831 # The pipeline triggers every second, so we should have seen
1832 # several by now.
1833 time.sleep(5)
1834 self.waitUntilSettled()
1835 # Stop queuing timer triggered jobs so that the assertions
1836 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001837 # Must be in same repo, so overwrite config with another one
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001838 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001839 self.sched.reconfigure(self.config)
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001840
James E. Blair21037782017-07-19 11:56:55 -07001841 self.assertEqual(len(self.builds), 1, "One timer job")
Steve Varnau7b78b312015-04-03 14:49:46 -07001842
1843 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1844 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1845 self.waitUntilSettled()
James E. Blair21037782017-07-19 11:56:55 -07001846 self.assertEqual(len(self.builds), 2, "One change plus one timer job")
Steve Varnau7b78b312015-04-03 14:49:46 -07001847
1848 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1849 self.waitUntilSettled()
1850
James E. Blair21037782017-07-19 11:56:55 -07001851 self.assertEqual(len(self.builds), 1, "One timer job remains")
Steve Varnau7b78b312015-04-03 14:49:46 -07001852
Paul Belanger174a8272017-03-14 13:20:10 -04001853 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001854 self.waitUntilSettled()
1855
James E. Blair2fa50962013-01-30 21:50:41 -08001856 def test_new_patchset_dequeues_old_on_head(self):
1857 "Test that a new patchset causes the old to be dequeued (at head)"
1858 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001859 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001860 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1861 M.setMerged()
1862 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1863 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1864 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1865 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001866 A.addApproval('code-review', 2)
1867 B.addApproval('code-review', 2)
1868 C.addApproval('code-review', 2)
1869 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001870
1871 C.setDependsOn(B, 1)
1872 B.setDependsOn(A, 1)
1873 A.setDependsOn(M, 1)
1874
James E. Blair8b5408c2016-08-08 15:37:46 -07001875 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1876 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1877 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1878 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001879 self.waitUntilSettled()
1880
1881 A.addPatchset()
1882 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1883 self.waitUntilSettled()
1884
Paul Belanger174a8272017-03-14 13:20:10 -04001885 self.executor_server.hold_jobs_in_build = False
1886 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001887 self.waitUntilSettled()
1888
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001889 self.assertEqual(A.data['status'], 'NEW')
1890 self.assertEqual(A.reported, 2)
1891 self.assertEqual(B.data['status'], 'NEW')
1892 self.assertEqual(B.reported, 2)
1893 self.assertEqual(C.data['status'], 'NEW')
1894 self.assertEqual(C.reported, 2)
1895 self.assertEqual(D.data['status'], 'MERGED')
1896 self.assertEqual(D.reported, 2)
1897 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08001898
1899 def test_new_patchset_dequeues_old_without_dependents(self):
1900 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04001901 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001902 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1903 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1904 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001905 A.addApproval('code-review', 2)
1906 B.addApproval('code-review', 2)
1907 C.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001908
James E. Blair8b5408c2016-08-08 15:37:46 -07001909 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1910 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1911 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001912 self.waitUntilSettled()
1913
1914 B.addPatchset()
1915 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1916 self.waitUntilSettled()
1917
Paul Belanger174a8272017-03-14 13:20:10 -04001918 self.executor_server.hold_jobs_in_build = False
1919 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001920 self.waitUntilSettled()
1921
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001922 self.assertEqual(A.data['status'], 'MERGED')
1923 self.assertEqual(A.reported, 2)
1924 self.assertEqual(B.data['status'], 'NEW')
1925 self.assertEqual(B.reported, 2)
1926 self.assertEqual(C.data['status'], 'MERGED')
1927 self.assertEqual(C.reported, 2)
1928 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08001929
1930 def test_new_patchset_dequeues_old_independent_queue(self):
1931 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04001932 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001933 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1934 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1935 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1936 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1937 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1938 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1939 self.waitUntilSettled()
1940
1941 B.addPatchset()
1942 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1943 self.waitUntilSettled()
1944
Paul Belanger174a8272017-03-14 13:20:10 -04001945 self.executor_server.hold_jobs_in_build = False
1946 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001947 self.waitUntilSettled()
1948
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001949 self.assertEqual(A.data['status'], 'NEW')
1950 self.assertEqual(A.reported, 1)
1951 self.assertEqual(B.data['status'], 'NEW')
1952 self.assertEqual(B.reported, 1)
1953 self.assertEqual(C.data['status'], 'NEW')
1954 self.assertEqual(C.reported, 1)
1955 self.assertEqual(len(self.history), 10)
1956 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001957
James E. Blaircc020532017-04-19 13:04:44 -07001958 @simple_layout('layouts/noop-job.yaml')
James E. Blair18c64442014-03-18 10:14:45 -07001959 def test_noop_job(self):
1960 "Test that the internal noop job works"
1961 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001962 A.addApproval('code-review', 2)
1963 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07001964 self.waitUntilSettled()
1965
1966 self.assertEqual(len(self.gearman_server.getQueue()), 0)
1967 self.assertTrue(self.sched._areAllBuildsComplete())
1968 self.assertEqual(len(self.history), 0)
1969 self.assertEqual(A.data['status'], 'MERGED')
1970 self.assertEqual(A.reported, 2)
1971
James E. Blair06cc3922017-04-19 10:08:10 -07001972 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001973 def test_no_job_project(self):
1974 "Test that reports with no jobs don't get sent"
1975 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
1976 'master', 'A')
1977 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1978 self.waitUntilSettled()
1979
1980 # Change wasn't reported to
1981 self.assertEqual(A.reported, False)
1982
1983 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08001984 tenant = self.sched.abide.tenants.get('tenant-one')
1985 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001986 items = check_pipeline.getAllItems()
1987 self.assertEqual(len(items), 0)
1988
1989 self.assertEqual(len(self.history), 0)
1990
James E. Blair7d0dedc2013-02-21 17:26:09 -08001991 def test_zuul_refs(self):
1992 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04001993 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08001994 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
1995 M1.setMerged()
1996 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
1997 M2.setMerged()
1998
1999 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2000 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2001 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
2002 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07002003 A.addApproval('code-review', 2)
2004 B.addApproval('code-review', 2)
2005 C.addApproval('code-review', 2)
2006 D.addApproval('code-review', 2)
2007 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2008 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
2009 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
2010 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002011
2012 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002013 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002014 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002015 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002016 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002017 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002018 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002019 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002020 self.waitUntilSettled()
2021
Clint Byrum3343e3e2016-11-15 16:05:03 -08002022 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002023 for x in self.builds:
James E. Blaire3db2952017-07-21 15:03:36 -07002024 if x.parameters['zuul']['change'] == '3':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002025 a_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002026 elif x.parameters['zuul']['change'] == '4':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002027 b_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002028 elif x.parameters['zuul']['change'] == '5':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002029 c_build = x
James E. Blaire3db2952017-07-21 15:03:36 -07002030 elif x.parameters['zuul']['change'] == '6':
Clint Byrum3343e3e2016-11-15 16:05:03 -08002031 d_build = x
2032 if a_build and b_build and c_build and d_build:
2033 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08002034
Clint Byrum3343e3e2016-11-15 16:05:03 -08002035 # should have a, not b, and should not be in project2
2036 self.assertTrue(a_build.hasChanges(A))
2037 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002038
Clint Byrum3343e3e2016-11-15 16:05:03 -08002039 # should have a and b, and should not be in project2
2040 self.assertTrue(b_build.hasChanges(A, B))
2041 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002042
Clint Byrum3343e3e2016-11-15 16:05:03 -08002043 # should have a and b in 1, c in 2
2044 self.assertTrue(c_build.hasChanges(A, B, C))
2045 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002046
Clint Byrum3343e3e2016-11-15 16:05:03 -08002047 # should have a and b in 1, c and d in 2
2048 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002049
Paul Belanger174a8272017-03-14 13:20:10 -04002050 self.executor_server.hold_jobs_in_build = False
2051 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002052 self.waitUntilSettled()
2053
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002054 self.assertEqual(A.data['status'], 'MERGED')
2055 self.assertEqual(A.reported, 2)
2056 self.assertEqual(B.data['status'], 'MERGED')
2057 self.assertEqual(B.reported, 2)
2058 self.assertEqual(C.data['status'], 'MERGED')
2059 self.assertEqual(C.reported, 2)
2060 self.assertEqual(D.data['status'], 'MERGED')
2061 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002062
James E. Blair4a28a882013-08-23 15:17:33 -07002063 def test_rerun_on_error(self):
2064 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002065 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002066 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002067 A.addApproval('code-review', 2)
2068 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002069 self.waitUntilSettled()
2070
James E. Blair412fba82017-01-26 15:00:50 -08002071 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002072 self.executor_server.hold_jobs_in_build = False
2073 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002074 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002075 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002076 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2077
James E. Blair412e5582013-04-22 15:50:12 -07002078 def test_statsd(self):
2079 "Test each of the statsd methods used in the scheduler"
2080 import extras
2081 statsd = extras.try_import('statsd.statsd')
2082 statsd.incr('test-incr')
2083 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002084 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002085 self.assertReportedStat('test-incr', '1|c')
2086 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002087 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002088
James E. Blairdad52252014-02-07 16:59:17 -08002089 def test_stuck_job_cleanup(self):
2090 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002091
2092 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002093 self.gearman_server.hold_jobs_in_queue = True
2094 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002095 A.addApproval('code-review', 2)
2096 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002097 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002098 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002099 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2100
James E. Blair31cb3e82017-04-20 13:08:56 -07002101 self.commitConfigUpdate('common-config', 'layouts/no-jobs.yaml')
James E. Blairdad52252014-02-07 16:59:17 -08002102 self.sched.reconfigure(self.config)
2103 self.waitUntilSettled()
2104
James E. Blair18c64442014-03-18 10:14:45 -07002105 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002106 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002107 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002108 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2109 self.assertTrue(self.sched._areAllBuildsComplete())
2110
2111 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002112 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002113 self.assertEqual(self.history[0].result, 'SUCCESS')
2114
James E. Blair879dafb2015-07-17 14:04:49 -07002115 def test_file_head(self):
2116 # This is a regression test for an observed bug. A change
2117 # with a file named "HEAD" in the root directory of the repo
2118 # was processed by a merger. It then was unable to reset the
2119 # repo because of:
2120 # GitCommandError: 'git reset --hard HEAD' returned
2121 # with exit code 128
2122 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2123 # and filename
2124 # Use '--' to separate filenames from revisions'
2125
2126 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002127 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002128 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2129
2130 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2131 self.waitUntilSettled()
2132
2133 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2134 self.waitUntilSettled()
2135
2136 self.assertIn('Build succeeded', A.messages[0])
2137 self.assertIn('Build succeeded', B.messages[0])
2138
James E. Blair70c71582013-03-06 08:50:50 -08002139 def test_file_jobs(self):
2140 "Test that file jobs run only when appropriate"
2141 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002142 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002143 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07002144 A.addApproval('code-review', 2)
2145 B.addApproval('code-review', 2)
2146 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2147 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002148 self.waitUntilSettled()
2149
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002150 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002151 if x.name == 'project-testfile']
2152
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002153 self.assertEqual(len(testfile_jobs), 1)
2154 self.assertEqual(testfile_jobs[0].changes, '1,2')
2155 self.assertEqual(A.data['status'], 'MERGED')
2156 self.assertEqual(A.reported, 2)
2157 self.assertEqual(B.data['status'], 'MERGED')
2158 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002159
Clint Byrum3ee39f32016-11-17 23:45:07 -08002160 def _test_irrelevant_files_jobs(self, should_skip):
2161 "Test that jobs with irrelevant-files filter run only when appropriate"
Clint Byrum3ee39f32016-11-17 23:45:07 -08002162 if should_skip:
2163 files = {'ignoreme': 'ignored\n'}
2164 else:
2165 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002166
2167 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002168 'master',
2169 'test irrelevant-files',
2170 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002171 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2172 self.waitUntilSettled()
2173
2174 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002175 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002176
2177 if should_skip:
2178 self.assertEqual([], tested_change_ids)
2179 else:
2180 self.assertIn(change.data['number'], tested_change_ids)
2181
James E. Blaircc324192017-04-19 14:36:08 -07002182 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002183 def test_irrelevant_files_match_skips_job(self):
2184 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002185
James E. Blaircc324192017-04-19 14:36:08 -07002186 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002187 def test_irrelevant_files_no_match_runs_job(self):
2188 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002189
James E. Blaircc324192017-04-19 14:36:08 -07002190 @simple_layout('layouts/inheritance.yaml')
Clint Byrum85493602016-11-18 11:59:47 -08002191 def test_inherited_jobs_keep_matchers(self):
Clint Byrum85493602016-11-18 11:59:47 -08002192 files = {'ignoreme': 'ignored\n'}
2193
2194 change = self.fake_gerrit.addFakeChange('org/project',
2195 'master',
2196 'test irrelevant-files',
2197 files=files)
2198 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2199 self.waitUntilSettled()
2200
2201 run_jobs = set([build.name for build in self.history])
2202
2203 self.assertEqual(set(['project-test-nomatch-starts-empty',
2204 'project-test-nomatch-starts-full']), run_jobs)
2205
James E. Blairc8a1e052014-02-25 09:29:26 -08002206 def test_queue_names(self):
2207 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002208 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002209 (trusted, project1) = tenant.getProject('org/project1')
2210 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002211 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2212 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2213 self.assertEqual(q1.name, 'integrated')
2214 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002215
James E. Blair64ed6f22013-07-10 14:07:23 -07002216 def test_queue_precedence(self):
2217 "Test that queue precedence works"
2218
2219 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002220 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002221 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2222 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
James E. Blair8b5408c2016-08-08 15:37:46 -07002223 A.addApproval('code-review', 2)
2224 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002225
2226 self.waitUntilSettled()
2227 self.gearman_server.hold_jobs_in_queue = False
2228 self.gearman_server.release()
2229 self.waitUntilSettled()
2230
James E. Blair8de58bd2013-07-18 16:23:33 -07002231 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002232 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002233 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002234 self.waitUntilSettled()
2235
James E. Blair64ed6f22013-07-10 14:07:23 -07002236 self.log.debug(self.history)
2237 self.assertEqual(self.history[0].pipeline, 'gate')
2238 self.assertEqual(self.history[1].pipeline, 'check')
2239 self.assertEqual(self.history[2].pipeline, 'gate')
2240 self.assertEqual(self.history[3].pipeline, 'gate')
2241 self.assertEqual(self.history[4].pipeline, 'check')
2242 self.assertEqual(self.history[5].pipeline, 'check')
2243
Clark Boylana5edbe42014-06-03 16:39:10 -07002244 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002245 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002246 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002247 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002248 A.addApproval('code-review', 2)
2249 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002250 self.waitUntilSettled()
2251
Paul Belanger174a8272017-03-14 13:20:10 -04002252 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002253 self.waitUntilSettled()
2254
James E. Blair1843a552013-07-03 14:19:52 -07002255 port = self.webapp.server.socket.getsockname()[1]
2256
Adam Gandelman77a12c72017-02-03 17:43:43 -08002257 req = urllib.request.Request(
2258 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002259 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002260 headers = f.info()
2261 self.assertIn('Content-Length', headers)
2262 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002263 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2264 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002265 self.assertIn('Access-Control-Allow-Origin', headers)
2266 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002267 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002268 self.assertIn('Expires', headers)
Clint Byrumf322fe22017-05-10 20:53:12 -07002269 data = f.read().decode('utf8')
James E. Blair1843a552013-07-03 14:19:52 -07002270
Paul Belanger174a8272017-03-14 13:20:10 -04002271 self.executor_server.hold_jobs_in_build = False
2272 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002273 self.waitUntilSettled()
2274
2275 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002276 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002277 for p in data['pipelines']:
2278 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002279 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002280 self.assertEqual(q['window'], 20)
2281 else:
2282 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002283 for head in q['heads']:
2284 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002285 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002286 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002287 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002288 status_jobs.append(job)
2289 self.assertEqual('project-merge', status_jobs[0]['name'])
Monty Taylorde8242c2017-02-23 20:29:53 -06002290 # TODO(mordred) pull uuids from self.builds
Monty Taylor51139a02016-05-24 11:28:10 -05002291 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002292 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2293 uuid=status_jobs[0]['uuid']),
2294 status_jobs[0]['url'])
2295 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002296 'finger://{hostname}/{uuid}'.format(
2297 hostname=self.executor_server.hostname,
2298 uuid=status_jobs[0]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002299 status_jobs[0]['finger_url'])
Monty Taylorde8242c2017-02-23 20:29:53 -06002300 # TOOD(mordred) configure a success-url on the base job
Monty Taylor51139a02016-05-24 11:28:10 -05002301 self.assertEqual(
2302 'finger://{hostname}/{uuid}'.format(
2303 hostname=self.executor_server.hostname,
2304 uuid=status_jobs[0]['uuid']),
2305 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002306 self.assertEqual('project-test1', status_jobs[1]['name'])
Monty Taylor51139a02016-05-24 11:28:10 -05002307 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002308 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2309 uuid=status_jobs[1]['uuid']),
2310 status_jobs[1]['url'])
2311 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002312 'finger://{hostname}/{uuid}'.format(
2313 hostname=self.executor_server.hostname,
2314 uuid=status_jobs[1]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002315 status_jobs[1]['finger_url'])
Monty Taylor51139a02016-05-24 11:28:10 -05002316 self.assertEqual(
2317 'finger://{hostname}/{uuid}'.format(
2318 hostname=self.executor_server.hostname,
2319 uuid=status_jobs[1]['uuid']),
2320 status_jobs[1]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002321
2322 self.assertEqual('project-test2', status_jobs[2]['name'])
Monty Taylor51139a02016-05-24 11:28:10 -05002323 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002324 'static/stream.html?uuid={uuid}&logfile=console.log'.format(
2325 uuid=status_jobs[2]['uuid']),
2326 status_jobs[2]['url'])
2327 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05002328 'finger://{hostname}/{uuid}'.format(
2329 hostname=self.executor_server.hostname,
2330 uuid=status_jobs[2]['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02002331 status_jobs[2]['finger_url'])
Monty Taylor51139a02016-05-24 11:28:10 -05002332 self.assertEqual(
2333 'finger://{hostname}/{uuid}'.format(
2334 hostname=self.executor_server.hostname,
2335 uuid=status_jobs[2]['uuid']),
2336 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002337
Tobias Henkel65639f82017-07-10 10:25:42 +02002338 # check job dependencies
2339 self.assertIsNotNone(status_jobs[0]['dependencies'])
2340 self.assertIsNotNone(status_jobs[1]['dependencies'])
2341 self.assertIsNotNone(status_jobs[2]['dependencies'])
2342 self.assertEqual(len(status_jobs[0]['dependencies']), 0)
2343 self.assertEqual(len(status_jobs[1]['dependencies']), 1)
2344 self.assertEqual(len(status_jobs[2]['dependencies']), 1)
2345 self.assertIn('project-merge', status_jobs[1]['dependencies'])
2346 self.assertIn('project-merge', status_jobs[2]['dependencies'])
2347
James E. Blaircdccd972013-07-01 12:10:22 -07002348 def test_live_reconfiguration(self):
2349 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002350 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002351 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002352 A.addApproval('code-review', 2)
2353 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002354 self.waitUntilSettled()
2355
2356 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002357 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002358
Paul Belanger174a8272017-03-14 13:20:10 -04002359 self.executor_server.hold_jobs_in_build = False
2360 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002361 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002362 self.assertEqual(self.getJobFromHistory('project-merge').result,
2363 'SUCCESS')
2364 self.assertEqual(self.getJobFromHistory('project-test1').result,
2365 'SUCCESS')
2366 self.assertEqual(self.getJobFromHistory('project-test2').result,
2367 'SUCCESS')
2368 self.assertEqual(A.data['status'], 'MERGED')
2369 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002370
James E. Blair6bc782d2015-07-17 16:20:21 -07002371 def test_live_reconfiguration_merge_conflict(self):
2372 # A real-world bug: a change in a gate queue has a merge
2373 # conflict and a job is added to its project while it's
2374 # sitting in the queue. The job gets added to the change and
2375 # enqueued and the change gets stuck.
Paul Belanger174a8272017-03-14 13:20:10 -04002376 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002377
2378 # This change is fine. It's here to stop the queue long
2379 # enough for the next change to be subject to the
2380 # reconfiguration, as well as to provide a conflict for the
2381 # next change. This change will succeed and merge.
2382 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum073c00b2017-05-01 13:41:23 -07002383 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002384 A.addApproval('code-review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002385
2386 # This change will be in merge conflict. During the
2387 # reconfiguration, we will add a job. We want to make sure
2388 # that doesn't cause it to get stuck.
2389 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Clint Byrum073c00b2017-05-01 13:41:23 -07002390 B.addPatchset({'conflict': 'B'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002391 B.addApproval('code-review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002392
James E. Blair8b5408c2016-08-08 15:37:46 -07002393 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2394 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002395
2396 self.waitUntilSettled()
2397
2398 # No jobs have run yet
2399 self.assertEqual(A.data['status'], 'NEW')
2400 self.assertEqual(A.reported, 1)
2401 self.assertEqual(B.data['status'], 'NEW')
James E. Blair6bc782d2015-07-17 16:20:21 -07002402 self.assertEqual(len(self.history), 0)
2403
2404 # Add the "project-test3" job.
Clint Byrum073c00b2017-05-01 13:41:23 -07002405 self.commitConfigUpdate('common-config',
2406 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002407 self.sched.reconfigure(self.config)
2408 self.waitUntilSettled()
2409
Paul Belanger174a8272017-03-14 13:20:10 -04002410 self.executor_server.hold_jobs_in_build = False
2411 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002412 self.waitUntilSettled()
2413
2414 self.assertEqual(A.data['status'], 'MERGED')
2415 self.assertEqual(A.reported, 2)
2416 self.assertEqual(B.data['status'], 'NEW')
Tobias Henkel9842bd72017-05-16 13:40:03 +02002417 self.assertIn('Merge Failed', B.messages[-1])
James E. Blair6bc782d2015-07-17 16:20:21 -07002418 self.assertEqual(self.getJobFromHistory('project-merge').result,
2419 'SUCCESS')
2420 self.assertEqual(self.getJobFromHistory('project-test1').result,
2421 'SUCCESS')
2422 self.assertEqual(self.getJobFromHistory('project-test2').result,
2423 'SUCCESS')
2424 self.assertEqual(self.getJobFromHistory('project-test3').result,
2425 'SUCCESS')
2426 self.assertEqual(len(self.history), 4)
2427
James E. Blair400e8fd2015-07-30 17:44:45 -07002428 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002429 # An extrapolation of test_live_reconfiguration_merge_conflict
2430 # that tests a job added to a job tree with a failed root does
2431 # not run.
Paul Belanger174a8272017-03-14 13:20:10 -04002432 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002433
2434 # This change is fine. It's here to stop the queue long
2435 # enough for the next change to be subject to the
2436 # reconfiguration. This change will succeed and merge.
2437 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum3147d652017-05-01 14:01:42 -07002438 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002439 A.addApproval('code-review', 2)
2440 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002441 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002442 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002443 self.waitUntilSettled()
2444
2445 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002446 self.executor_server.failJob('project-merge', B)
James E. Blair8b5408c2016-08-08 15:37:46 -07002447 B.addApproval('code-review', 2)
2448 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002449 self.waitUntilSettled()
2450
Paul Belanger174a8272017-03-14 13:20:10 -04002451 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002452 self.waitUntilSettled()
2453
2454 # Both -merge jobs have run, but no others.
2455 self.assertEqual(A.data['status'], 'NEW')
2456 self.assertEqual(A.reported, 1)
2457 self.assertEqual(B.data['status'], 'NEW')
2458 self.assertEqual(B.reported, 1)
2459 self.assertEqual(self.history[0].result, 'SUCCESS')
2460 self.assertEqual(self.history[0].name, 'project-merge')
2461 self.assertEqual(self.history[1].result, 'FAILURE')
2462 self.assertEqual(self.history[1].name, 'project-merge')
2463 self.assertEqual(len(self.history), 2)
2464
2465 # Add the "project-test3" job.
Clint Byrum3147d652017-05-01 14:01:42 -07002466 self.commitConfigUpdate('common-config',
2467 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002468 self.sched.reconfigure(self.config)
2469 self.waitUntilSettled()
2470
Paul Belanger174a8272017-03-14 13:20:10 -04002471 self.executor_server.hold_jobs_in_build = False
2472 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002473 self.waitUntilSettled()
2474
2475 self.assertEqual(A.data['status'], 'MERGED')
2476 self.assertEqual(A.reported, 2)
2477 self.assertEqual(B.data['status'], 'NEW')
2478 self.assertEqual(B.reported, 2)
2479 self.assertEqual(self.history[0].result, 'SUCCESS')
2480 self.assertEqual(self.history[0].name, 'project-merge')
2481 self.assertEqual(self.history[1].result, 'FAILURE')
2482 self.assertEqual(self.history[1].name, 'project-merge')
2483 self.assertEqual(self.history[2].result, 'SUCCESS')
2484 self.assertEqual(self.history[3].result, 'SUCCESS')
2485 self.assertEqual(self.history[4].result, 'SUCCESS')
2486 self.assertEqual(len(self.history), 5)
2487
James E. Blair400e8fd2015-07-30 17:44:45 -07002488 def test_live_reconfiguration_failed_job(self):
2489 # Test that a change with a removed failing job does not
2490 # disrupt reconfiguration. If a change has a failed job and
2491 # that job is removed during a reconfiguration, we observed a
2492 # bug where the code to re-set build statuses would run on
2493 # that build and raise an exception because the job no longer
2494 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002495 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002496
2497 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2498
2499 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002500 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002501
2502 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2503 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002504 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002505 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002506 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002507 self.waitUntilSettled()
2508
2509 self.assertEqual(A.data['status'], 'NEW')
2510 self.assertEqual(A.reported, 0)
2511
2512 self.assertEqual(self.getJobFromHistory('project-merge').result,
2513 'SUCCESS')
2514 self.assertEqual(self.getJobFromHistory('project-test1').result,
2515 'FAILURE')
2516 self.assertEqual(len(self.history), 2)
2517
2518 # Remove the test1 job.
Clint Byrum841a58c2017-05-01 14:17:21 -07002519 self.commitConfigUpdate('common-config',
2520 'layouts/live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002521 self.sched.reconfigure(self.config)
2522 self.waitUntilSettled()
2523
Paul Belanger174a8272017-03-14 13:20:10 -04002524 self.executor_server.hold_jobs_in_build = False
2525 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002526 self.waitUntilSettled()
2527
2528 self.assertEqual(self.getJobFromHistory('project-test2').result,
2529 'SUCCESS')
2530 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2531 'SUCCESS')
2532 self.assertEqual(len(self.history), 4)
2533
2534 self.assertEqual(A.data['status'], 'NEW')
2535 self.assertEqual(A.reported, 1)
2536 self.assertIn('Build succeeded', A.messages[0])
2537 # Ensure the removed job was not included in the report.
2538 self.assertNotIn('project-test1', A.messages[0])
2539
James E. Blairfe707d12015-08-05 15:18:15 -07002540 def test_live_reconfiguration_shared_queue(self):
2541 # Test that a change with a failing job which was removed from
2542 # this project but otherwise still exists in the system does
2543 # not disrupt reconfiguration.
2544
Paul Belanger174a8272017-03-14 13:20:10 -04002545 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002546
2547 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2548
Paul Belanger174a8272017-03-14 13:20:10 -04002549 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002550
2551 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2552 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002553 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002554 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002555 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002556 self.waitUntilSettled()
2557
2558 self.assertEqual(A.data['status'], 'NEW')
2559 self.assertEqual(A.reported, 0)
2560
Clint Byrum69663d42017-05-01 14:51:04 -07002561 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002562 'SUCCESS')
2563 self.assertEqual(self.getJobFromHistory(
2564 'project1-project2-integration').result, 'FAILURE')
2565 self.assertEqual(len(self.history), 2)
2566
2567 # Remove the integration job.
Clint Byrum69663d42017-05-01 14:51:04 -07002568 self.commitConfigUpdate(
2569 'common-config',
2570 'layouts/live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002571 self.sched.reconfigure(self.config)
2572 self.waitUntilSettled()
2573
Paul Belanger174a8272017-03-14 13:20:10 -04002574 self.executor_server.hold_jobs_in_build = False
2575 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002576 self.waitUntilSettled()
2577
Clint Byrum69663d42017-05-01 14:51:04 -07002578 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002579 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002580 self.assertEqual(self.getJobFromHistory('project-test1').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002581 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002582 self.assertEqual(self.getJobFromHistory('project-test2').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002583 'SUCCESS')
2584 self.assertEqual(self.getJobFromHistory(
2585 'project1-project2-integration').result, 'FAILURE')
2586 self.assertEqual(len(self.history), 4)
2587
2588 self.assertEqual(A.data['status'], 'NEW')
2589 self.assertEqual(A.reported, 1)
2590 self.assertIn('Build succeeded', A.messages[0])
2591 # Ensure the removed job was not included in the report.
2592 self.assertNotIn('project1-project2-integration', A.messages[0])
2593
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002594 def test_double_live_reconfiguration_shared_queue(self):
2595 # This was a real-world regression. A change is added to
2596 # gate; a reconfigure happens, a second change which depends
2597 # on the first is added, and a second reconfiguration happens.
2598 # Ensure that both changes merge.
2599
2600 # A failure may indicate incorrect caching or cleaning up of
2601 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002602 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002603
2604 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2605 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2606 B.setDependsOn(A, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07002607 A.addApproval('code-review', 2)
2608 B.addApproval('code-review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002609
2610 # Add the parent change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002611 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002612 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002613 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002614 self.waitUntilSettled()
2615
2616 # Reconfigure (with only one change in the pipeline).
2617 self.sched.reconfigure(self.config)
2618 self.waitUntilSettled()
2619
2620 # Add the child change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002621 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002622 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002623 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002624 self.waitUntilSettled()
2625
2626 # Reconfigure (with both in the pipeline).
2627 self.sched.reconfigure(self.config)
2628 self.waitUntilSettled()
2629
Paul Belanger174a8272017-03-14 13:20:10 -04002630 self.executor_server.hold_jobs_in_build = False
2631 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002632 self.waitUntilSettled()
2633
2634 self.assertEqual(len(self.history), 8)
2635
2636 self.assertEqual(A.data['status'], 'MERGED')
2637 self.assertEqual(A.reported, 2)
2638 self.assertEqual(B.data['status'], 'MERGED')
2639 self.assertEqual(B.reported, 2)
2640
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002641 def test_live_reconfiguration_del_project(self):
2642 # Test project deletion from layout
2643 # while changes are enqueued
2644
Paul Belanger174a8272017-03-14 13:20:10 -04002645 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002646 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2647 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2648 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2649
2650 # A Depends-On: B
2651 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2652 A.subject, B.data['id'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002653 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002654
2655 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2656 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2657 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002658 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002659 self.waitUntilSettled()
2660 self.assertEqual(len(self.builds), 5)
2661
2662 # This layout defines only org/project, not org/project1
James E. Blair31cb3e82017-04-20 13:08:56 -07002663 self.commitConfigUpdate(
2664 'common-config',
2665 'layouts/live-reconfiguration-del-project.yaml')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002666 self.sched.reconfigure(self.config)
2667 self.waitUntilSettled()
2668
2669 # Builds for C aborted, builds for A succeed,
2670 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002671 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002672 self.assertEqual(job_c.changes, '3,1')
2673 self.assertEqual(job_c.result, 'ABORTED')
2674
Paul Belanger174a8272017-03-14 13:20:10 -04002675 self.executor_server.hold_jobs_in_build = False
2676 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002677 self.waitUntilSettled()
2678
Clint Byrum0149ada2017-04-04 12:22:01 -07002679 self.assertEqual(
2680 self.getJobFromHistory('project-test1', 'org/project').changes,
2681 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002682
2683 self.assertEqual(A.data['status'], 'NEW')
2684 self.assertEqual(B.data['status'], 'NEW')
2685 self.assertEqual(C.data['status'], 'NEW')
2686 self.assertEqual(A.reported, 1)
2687 self.assertEqual(B.reported, 0)
2688 self.assertEqual(C.reported, 0)
2689
Clint Byrum0149ada2017-04-04 12:22:01 -07002690 tenant = self.sched.abide.tenants.get('tenant-one')
2691 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002692 self.assertIn('Build succeeded', A.messages[0])
2693
James E. Blairec056492016-07-22 09:45:56 -07002694 @skip("Disabled for early v3 development")
James E. Blair287c06d2013-07-24 10:39:30 -07002695 def test_delayed_repo_init(self):
James E. Blairf84026c2015-12-08 16:11:46 -08002696 self.updateConfigLayout(
2697 'tests/fixtures/layout-delayed-repo-init.yaml')
James E. Blair287c06d2013-07-24 10:39:30 -07002698 self.sched.reconfigure(self.config)
2699
2700 self.init_repo("org/new-project")
2701 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2702
James E. Blair8b5408c2016-08-08 15:37:46 -07002703 A.addApproval('code-review', 2)
2704 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002705 self.waitUntilSettled()
2706 self.assertEqual(self.getJobFromHistory('project-merge').result,
2707 'SUCCESS')
2708 self.assertEqual(self.getJobFromHistory('project-test1').result,
2709 'SUCCESS')
2710 self.assertEqual(self.getJobFromHistory('project-test2').result,
2711 'SUCCESS')
2712 self.assertEqual(A.data['status'], 'MERGED')
2713 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002714
James E. Blair9ea70072017-04-19 16:05:30 -07002715 @simple_layout('layouts/repo-deleted.yaml')
Clark Boylan6dbbc482013-10-18 10:57:31 -07002716 def test_repo_deleted(self):
Clark Boylan6dbbc482013-10-18 10:57:31 -07002717 self.init_repo("org/delete-project")
2718 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2719
James E. Blair8b5408c2016-08-08 15:37:46 -07002720 A.addApproval('code-review', 2)
2721 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002722 self.waitUntilSettled()
2723 self.assertEqual(self.getJobFromHistory('project-merge').result,
2724 'SUCCESS')
2725 self.assertEqual(self.getJobFromHistory('project-test1').result,
2726 'SUCCESS')
2727 self.assertEqual(self.getJobFromHistory('project-test2').result,
2728 'SUCCESS')
2729 self.assertEqual(A.data['status'], 'MERGED')
2730 self.assertEqual(A.reported, 2)
2731
2732 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002733 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002734 if os.path.exists(os.path.join(self.merger_src_root, p)):
2735 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002736 if os.path.exists(os.path.join(self.executor_src_root, p)):
2737 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002738
2739 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2740
James E. Blair8b5408c2016-08-08 15:37:46 -07002741 B.addApproval('code-review', 2)
2742 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002743 self.waitUntilSettled()
2744 self.assertEqual(self.getJobFromHistory('project-merge').result,
2745 'SUCCESS')
2746 self.assertEqual(self.getJobFromHistory('project-test1').result,
2747 'SUCCESS')
2748 self.assertEqual(self.getJobFromHistory('project-test2').result,
2749 'SUCCESS')
2750 self.assertEqual(B.data['status'], 'MERGED')
2751 self.assertEqual(B.reported, 2)
2752
James E. Blaire68d43f2017-04-19 14:03:30 -07002753 @simple_layout('layouts/tags.yaml')
James E. Blair456f2fb2016-02-09 09:29:33 -08002754 def test_tags(self):
2755 "Test job tags"
James E. Blair456f2fb2016-02-09 09:29:33 -08002756 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2757 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2758 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2759 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2760 self.waitUntilSettled()
2761
James E. Blaire68d43f2017-04-19 14:03:30 -07002762 self.assertEqual(len(self.history), 2)
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002763
2764 results = {self.getJobFromHistory('merge',
James E. Blair9d46f092017-07-20 16:06:20 -07002765 project='org/project1').uuid: ['extratag', 'merge'],
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002766 self.getJobFromHistory('merge',
James E. Blair9d46f092017-07-20 16:06:20 -07002767 project='org/project2').uuid: ['merge']}
James E. Blair456f2fb2016-02-09 09:29:33 -08002768
2769 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002770 self.assertEqual(results.get(build.uuid, ''),
James E. Blair9d46f092017-07-20 16:06:20 -07002771 build.parameters['zuul'].get('jobtags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08002772
James E. Blair63bb0ef2013-07-29 17:14:51 -07002773 def test_timer(self):
2774 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002775 # This test can not use simple_layout because it must start
2776 # with a configuration which does not include a
2777 # timer-triggered job so that we have an opportunity to set
2778 # the hold flag before the first job.
James E. Blair21037782017-07-19 11:56:55 -07002779 self.create_branch('org/project', 'stable')
Paul Belanger174a8272017-03-14 13:20:10 -04002780 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002781 self.commitConfigUpdate('common-config', 'layouts/timer.yaml')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002782 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002783
Clark Boylan3ee090a2014-04-03 20:55:09 -07002784 # The pipeline triggers every second, so we should have seen
2785 # several by now.
2786 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002787 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07002788
2789 self.assertEqual(len(self.builds), 2)
2790
James E. Blair63bb0ef2013-07-29 17:14:51 -07002791 port = self.webapp.server.socket.getsockname()[1]
2792
Clint Byrum5e729e92017-02-08 06:34:57 -08002793 req = urllib.request.Request(
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002794 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002795 f = urllib.request.urlopen(req)
Clint Byrumf322fe22017-05-10 20:53:12 -07002796 data = f.read().decode('utf8')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002797
Paul Belanger174a8272017-03-14 13:20:10 -04002798 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07002799 # Stop queuing timer triggered jobs so that the assertions
2800 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002801 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002802 self.sched.reconfigure(self.config)
Paul Belanger174a8272017-03-14 13:20:10 -04002803 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07002804 self.waitUntilSettled()
2805
James E. Blair21037782017-07-19 11:56:55 -07002806 self.assertHistory([
2807 dict(name='project-bitrot', result='SUCCESS',
2808 ref='refs/heads/master'),
2809 dict(name='project-bitrot', result='SUCCESS',
2810 ref='refs/heads/stable'),
2811 ], ordered=False)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002812
2813 data = json.loads(data)
2814 status_jobs = set()
2815 for p in data['pipelines']:
2816 for q in p['change_queues']:
2817 for head in q['heads']:
2818 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07002819 for job in change['jobs']:
2820 status_jobs.add(job['name'])
James E. Blair21037782017-07-19 11:56:55 -07002821 self.assertIn('project-bitrot', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002822
James E. Blair4f6033c2014-03-27 15:49:09 -07002823 def test_idle(self):
2824 "Test that frequent periodic jobs work"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002825 # This test can not use simple_layout because it must start
2826 # with a configuration which does not include a
2827 # timer-triggered job so that we have an opportunity to set
2828 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002829 self.executor_server.hold_jobs_in_build = True
James E. Blair4f6033c2014-03-27 15:49:09 -07002830
Clark Boylan3ee090a2014-04-03 20:55:09 -07002831 for x in range(1, 3):
2832 # Test that timer triggers periodic jobs even across
2833 # layout config reloads.
2834 # Start timer trigger
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002835 self.commitConfigUpdate('common-config',
2836 'layouts/idle.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002837 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002838 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07002839
Clark Boylan3ee090a2014-04-03 20:55:09 -07002840 # The pipeline triggers every second, so we should have seen
2841 # several by now.
2842 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07002843
2844 # Stop queuing timer triggered jobs so that the assertions
2845 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002846 self.commitConfigUpdate('common-config',
2847 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002848 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002849 self.waitUntilSettled()
James E. Blair21037782017-07-19 11:56:55 -07002850 self.assertEqual(len(self.builds), 1,
Clint Byrum58264dc2017-02-07 21:21:22 -08002851 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04002852 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002853 self.waitUntilSettled()
2854 self.assertEqual(len(self.builds), 0)
James E. Blair21037782017-07-19 11:56:55 -07002855 self.assertEqual(len(self.history), x)
James E. Blair4f6033c2014-03-27 15:49:09 -07002856
James E. Blaircc324192017-04-19 14:36:08 -07002857 @simple_layout('layouts/smtp.yaml')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002858 def test_check_smtp_pool(self):
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002859 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2860 self.waitUntilSettled()
2861
2862 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2863 self.waitUntilSettled()
2864
James E. Blairff80a2f2013-12-27 13:24:06 -08002865 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002866
2867 # A.messages only holds what FakeGerrit places in it. Thus we
2868 # work on the knowledge of what the first message should be as
2869 # it is only configured to go to SMTP.
2870
2871 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002872 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002873 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002874 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002875 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08002876 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002877
2878 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002879 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002880 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002881 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002882 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08002883 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08002884
James E. Blaire5910202013-12-27 09:50:31 -08002885 def test_timer_smtp(self):
2886 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002887 # This test can not use simple_layout because it must start
2888 # with a configuration which does not include a
2889 # timer-triggered job so that we have an opportunity to set
2890 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002891 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002892 self.commitConfigUpdate('common-config', 'layouts/timer-smtp.yaml')
James E. Blaire5910202013-12-27 09:50:31 -08002893 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08002894
Clark Boylan3ee090a2014-04-03 20:55:09 -07002895 # The pipeline triggers every second, so we should have seen
2896 # several by now.
2897 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08002898 self.waitUntilSettled()
2899
Clark Boylan3ee090a2014-04-03 20:55:09 -07002900 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04002901 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002902 self.waitUntilSettled()
2903 self.assertEqual(len(self.history), 2)
2904
James E. Blaire5910202013-12-27 09:50:31 -08002905 self.assertEqual(self.getJobFromHistory(
2906 'project-bitrot-stable-old').result, 'SUCCESS')
2907 self.assertEqual(self.getJobFromHistory(
2908 'project-bitrot-stable-older').result, 'SUCCESS')
2909
James E. Blairff80a2f2013-12-27 13:24:06 -08002910 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08002911
2912 # A.messages only holds what FakeGerrit places in it. Thus we
2913 # work on the knowledge of what the first message should be as
2914 # it is only configured to go to SMTP.
2915
2916 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002917 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002918 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002919 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002920 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08002921 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08002922
Clark Boylan3ee090a2014-04-03 20:55:09 -07002923 # Stop queuing timer triggered jobs and let any that may have
2924 # queued through so that end of test assertions pass.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002925 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002926 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07002927 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002928 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002929 self.waitUntilSettled()
2930
Joshua Hesketh25695cb2017-03-06 12:50:04 +11002931 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00002932 def test_timer_sshkey(self):
2933 "Test that a periodic job can setup SSH key authentication"
2934 self.worker.hold_jobs_in_build = True
2935 self.config.set('zuul', 'layout_config',
2936 'tests/fixtures/layout-timer.yaml')
2937 self.sched.reconfigure(self.config)
2938 self.registerJobs()
2939
2940 # The pipeline triggers every second, so we should have seen
2941 # several by now.
2942 time.sleep(5)
2943 self.waitUntilSettled()
2944
2945 self.assertEqual(len(self.builds), 2)
2946
2947 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
2948 self.assertTrue(os.path.isfile(ssh_wrapper))
2949 with open(ssh_wrapper) as f:
2950 ssh_wrapper_content = f.read()
2951 self.assertIn("fake_id_rsa", ssh_wrapper_content)
2952 # In the unit tests Merger runs in the same process,
2953 # so we see its' environment variables
2954 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
2955
2956 self.worker.release('.*')
2957 self.waitUntilSettled()
2958 self.assertEqual(len(self.history), 2)
2959
2960 self.assertEqual(self.getJobFromHistory(
2961 'project-bitrot-stable-old').result, 'SUCCESS')
2962 self.assertEqual(self.getJobFromHistory(
2963 'project-bitrot-stable-older').result, 'SUCCESS')
2964
2965 # Stop queuing timer triggered jobs and let any that may have
2966 # queued through so that end of test assertions pass.
2967 self.config.set('zuul', 'layout_config',
2968 'tests/fixtures/layout-no-timer.yaml')
2969 self.sched.reconfigure(self.config)
2970 self.registerJobs()
2971 self.waitUntilSettled()
2972 self.worker.release('.*')
2973 self.waitUntilSettled()
2974
James E. Blair91e34592015-07-31 16:45:59 -07002975 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08002976 "Test that the RPC client can enqueue a change"
2977 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002978 A.addApproval('code-review', 2)
2979 A.addApproval('approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08002980
2981 client = zuul.rpcclient.RPCClient('127.0.0.1',
2982 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002983 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04002984 r = client.enqueue(tenant='tenant-one',
2985 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002986 project='org/project',
2987 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002988 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002989 self.waitUntilSettled()
2990 self.assertEqual(self.getJobFromHistory('project-merge').result,
2991 'SUCCESS')
2992 self.assertEqual(self.getJobFromHistory('project-test1').result,
2993 'SUCCESS')
2994 self.assertEqual(self.getJobFromHistory('project-test2').result,
2995 'SUCCESS')
2996 self.assertEqual(A.data['status'], 'MERGED')
2997 self.assertEqual(A.reported, 2)
2998 self.assertEqual(r, True)
2999
James E. Blair91e34592015-07-31 16:45:59 -07003000 def test_client_enqueue_ref(self):
3001 "Test that the RPC client can enqueue a ref"
3002
3003 client = zuul.rpcclient.RPCClient('127.0.0.1',
3004 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003005 self.addCleanup(client.shutdown)
James E. Blair91e34592015-07-31 16:45:59 -07003006 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04003007 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07003008 pipeline='post',
3009 project='org/project',
3010 trigger='gerrit',
3011 ref='master',
3012 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
3013 newrev='d479a0bfcb34da57a31adb2a595c0cf687812543')
3014 self.waitUntilSettled()
3015 job_names = [x.name for x in self.history]
3016 self.assertEqual(len(self.history), 1)
3017 self.assertIn('project-post', job_names)
3018 self.assertEqual(r, True)
3019
James E. Blairad28e912013-11-27 10:43:22 -08003020 def test_client_enqueue_negative(self):
3021 "Test that the RPC client returns errors"
3022 client = zuul.rpcclient.RPCClient('127.0.0.1',
3023 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003024 self.addCleanup(client.shutdown)
James E. Blairad28e912013-11-27 10:43:22 -08003025 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04003026 "Invalid tenant"):
3027 r = client.enqueue(tenant='tenant-foo',
3028 pipeline='gate',
3029 project='org/project',
3030 trigger='gerrit',
3031 change='1,1')
Paul Belangerbaca3132016-11-04 12:49:54 -04003032 self.assertEqual(r, False)
3033
3034 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08003035 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003036 r = client.enqueue(tenant='tenant-one',
3037 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003038 project='project-does-not-exist',
3039 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003040 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003041 self.assertEqual(r, False)
3042
3043 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3044 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003045 r = client.enqueue(tenant='tenant-one',
3046 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08003047 project='org/project',
3048 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003049 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003050 self.assertEqual(r, False)
3051
3052 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3053 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003054 r = client.enqueue(tenant='tenant-one',
3055 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003056 project='org/project',
3057 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08003058 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003059 self.assertEqual(r, False)
3060
3061 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3062 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003063 r = client.enqueue(tenant='tenant-one',
3064 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003065 project='org/project',
3066 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003067 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003068 self.assertEqual(r, False)
3069
3070 self.waitUntilSettled()
3071 self.assertEqual(len(self.history), 0)
3072 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08003073
3074 def test_client_promote(self):
3075 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04003076 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003077 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3078 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3079 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003080 A.addApproval('code-review', 2)
3081 B.addApproval('code-review', 2)
3082 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003083
James E. Blair8b5408c2016-08-08 15:37:46 -07003084 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3085 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3086 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003087
3088 self.waitUntilSettled()
3089
Paul Belangerbaca3132016-11-04 12:49:54 -04003090 tenant = self.sched.abide.tenants.get('tenant-one')
3091 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003092 enqueue_times = {}
3093 for item in items:
3094 enqueue_times[str(item.change)] = item.enqueue_time
3095
James E. Blair36658cf2013-12-06 17:53:48 -08003096 client = zuul.rpcclient.RPCClient('127.0.0.1',
3097 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003098 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003099 r = client.promote(tenant='tenant-one',
3100 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003101 change_ids=['2,1', '3,1'])
3102
Sean Daguef39b9ca2014-01-10 21:34:35 -05003103 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003104 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003105 for item in items:
3106 self.assertEqual(
3107 enqueue_times[str(item.change)], item.enqueue_time)
3108
James E. Blair78acec92014-02-06 07:11:32 -08003109 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003110 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003111 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003112 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003113 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003114 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003115 self.waitUntilSettled()
3116
3117 self.assertEqual(len(self.builds), 6)
3118 self.assertEqual(self.builds[0].name, 'project-test1')
3119 self.assertEqual(self.builds[1].name, 'project-test2')
3120 self.assertEqual(self.builds[2].name, 'project-test1')
3121 self.assertEqual(self.builds[3].name, 'project-test2')
3122 self.assertEqual(self.builds[4].name, 'project-test1')
3123 self.assertEqual(self.builds[5].name, 'project-test2')
3124
Paul Belangerbaca3132016-11-04 12:49:54 -04003125 self.assertTrue(self.builds[0].hasChanges(B))
3126 self.assertFalse(self.builds[0].hasChanges(A))
3127 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003128
Paul Belangerbaca3132016-11-04 12:49:54 -04003129 self.assertTrue(self.builds[2].hasChanges(B))
3130 self.assertTrue(self.builds[2].hasChanges(C))
3131 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003132
Paul Belangerbaca3132016-11-04 12:49:54 -04003133 self.assertTrue(self.builds[4].hasChanges(B))
3134 self.assertTrue(self.builds[4].hasChanges(C))
3135 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003136
Paul Belanger174a8272017-03-14 13:20:10 -04003137 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003138 self.waitUntilSettled()
3139
3140 self.assertEqual(A.data['status'], 'MERGED')
3141 self.assertEqual(A.reported, 2)
3142 self.assertEqual(B.data['status'], 'MERGED')
3143 self.assertEqual(B.reported, 2)
3144 self.assertEqual(C.data['status'], 'MERGED')
3145 self.assertEqual(C.reported, 2)
3146
James E. Blair36658cf2013-12-06 17:53:48 -08003147 self.assertEqual(r, True)
3148
3149 def test_client_promote_dependent(self):
3150 "Test that the RPC client can promote a dependent change"
3151 # C (depends on B) -> B -> A ; then promote C to get:
3152 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003153 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003154 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3155 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3156 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3157
3158 C.setDependsOn(B, 1)
3159
James E. Blair8b5408c2016-08-08 15:37:46 -07003160 A.addApproval('code-review', 2)
3161 B.addApproval('code-review', 2)
3162 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003163
James E. Blair8b5408c2016-08-08 15:37:46 -07003164 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3165 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3166 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003167
3168 self.waitUntilSettled()
3169
3170 client = zuul.rpcclient.RPCClient('127.0.0.1',
3171 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003172 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003173 r = client.promote(tenant='tenant-one',
3174 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003175 change_ids=['3,1'])
3176
James E. Blair78acec92014-02-06 07:11:32 -08003177 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003178 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003179 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003180 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003181 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003182 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003183 self.waitUntilSettled()
3184
3185 self.assertEqual(len(self.builds), 6)
3186 self.assertEqual(self.builds[0].name, 'project-test1')
3187 self.assertEqual(self.builds[1].name, 'project-test2')
3188 self.assertEqual(self.builds[2].name, 'project-test1')
3189 self.assertEqual(self.builds[3].name, 'project-test2')
3190 self.assertEqual(self.builds[4].name, 'project-test1')
3191 self.assertEqual(self.builds[5].name, 'project-test2')
3192
Paul Belangerbaca3132016-11-04 12:49:54 -04003193 self.assertTrue(self.builds[0].hasChanges(B))
3194 self.assertFalse(self.builds[0].hasChanges(A))
3195 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003196
Paul Belangerbaca3132016-11-04 12:49:54 -04003197 self.assertTrue(self.builds[2].hasChanges(B))
3198 self.assertTrue(self.builds[2].hasChanges(C))
3199 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003200
Paul Belangerbaca3132016-11-04 12:49:54 -04003201 self.assertTrue(self.builds[4].hasChanges(B))
3202 self.assertTrue(self.builds[4].hasChanges(C))
3203 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003204
Paul Belanger174a8272017-03-14 13:20:10 -04003205 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003206 self.waitUntilSettled()
3207
3208 self.assertEqual(A.data['status'], 'MERGED')
3209 self.assertEqual(A.reported, 2)
3210 self.assertEqual(B.data['status'], 'MERGED')
3211 self.assertEqual(B.reported, 2)
3212 self.assertEqual(C.data['status'], 'MERGED')
3213 self.assertEqual(C.reported, 2)
3214
James E. Blair36658cf2013-12-06 17:53:48 -08003215 self.assertEqual(r, True)
3216
3217 def test_client_promote_negative(self):
3218 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003219 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003220 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003221 A.addApproval('code-review', 2)
3222 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003223 self.waitUntilSettled()
3224
3225 client = zuul.rpcclient.RPCClient('127.0.0.1',
3226 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003227 self.addCleanup(client.shutdown)
James E. Blair36658cf2013-12-06 17:53:48 -08003228
3229 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003230 r = client.promote(tenant='tenant-one',
3231 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003232 change_ids=['2,1', '3,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003233 self.assertEqual(r, False)
3234
3235 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003236 r = client.promote(tenant='tenant-one',
3237 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003238 change_ids=['4,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003239 self.assertEqual(r, False)
3240
Paul Belanger174a8272017-03-14 13:20:10 -04003241 self.executor_server.hold_jobs_in_build = False
3242 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003243 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003244
James E. Blaircc324192017-04-19 14:36:08 -07003245 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003246 def test_queue_rate_limiting(self):
3247 "Test that DependentPipelines are rate limited with dep across window"
Paul Belanger174a8272017-03-14 13:20:10 -04003248 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003249 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3250 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3251 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3252
3253 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003254 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003255
James E. Blair8b5408c2016-08-08 15:37:46 -07003256 A.addApproval('code-review', 2)
3257 B.addApproval('code-review', 2)
3258 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003259
James E. Blair8b5408c2016-08-08 15:37:46 -07003260 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3261 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3262 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003263 self.waitUntilSettled()
3264
3265 # Only A and B will have their merge jobs queued because
3266 # window is 2.
3267 self.assertEqual(len(self.builds), 2)
3268 self.assertEqual(self.builds[0].name, 'project-merge')
3269 self.assertEqual(self.builds[1].name, 'project-merge')
3270
James E. Blair732ee862017-04-21 07:49:26 -07003271 # Release the merge jobs one at a time.
3272 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003273 self.waitUntilSettled()
James E. Blair732ee862017-04-21 07:49:26 -07003274 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003275 self.waitUntilSettled()
3276
3277 # Only A and B will have their test jobs queued because
3278 # window is 2.
3279 self.assertEqual(len(self.builds), 4)
3280 self.assertEqual(self.builds[0].name, 'project-test1')
3281 self.assertEqual(self.builds[1].name, 'project-test2')
3282 self.assertEqual(self.builds[2].name, 'project-test1')
3283 self.assertEqual(self.builds[3].name, 'project-test2')
3284
Paul Belanger174a8272017-03-14 13:20:10 -04003285 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003286 self.waitUntilSettled()
3287
James E. Blaircc324192017-04-19 14:36:08 -07003288 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003289 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003290 # A failed so window is reduced by 1 to 1.
3291 self.assertEqual(queue.window, 1)
3292 self.assertEqual(queue.window_floor, 1)
3293 self.assertEqual(A.data['status'], 'NEW')
3294
3295 # Gate is reset and only B's merge job is queued because
3296 # window shrunk to 1.
3297 self.assertEqual(len(self.builds), 1)
3298 self.assertEqual(self.builds[0].name, 'project-merge')
3299
Paul Belanger174a8272017-03-14 13:20:10 -04003300 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003301 self.waitUntilSettled()
3302
3303 # Only B's test jobs are queued because window is still 1.
3304 self.assertEqual(len(self.builds), 2)
3305 self.assertEqual(self.builds[0].name, 'project-test1')
3306 self.assertEqual(self.builds[1].name, 'project-test2')
3307
Paul Belanger174a8272017-03-14 13:20:10 -04003308 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003309 self.waitUntilSettled()
3310
3311 # B was successfully merged so window is increased to 2.
3312 self.assertEqual(queue.window, 2)
3313 self.assertEqual(queue.window_floor, 1)
3314 self.assertEqual(B.data['status'], 'MERGED')
3315
3316 # Only C is left and its merge job is queued.
3317 self.assertEqual(len(self.builds), 1)
3318 self.assertEqual(self.builds[0].name, 'project-merge')
3319
Paul Belanger174a8272017-03-14 13:20:10 -04003320 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003321 self.waitUntilSettled()
3322
3323 # After successful merge job the test jobs for C are queued.
3324 self.assertEqual(len(self.builds), 2)
3325 self.assertEqual(self.builds[0].name, 'project-test1')
3326 self.assertEqual(self.builds[1].name, 'project-test2')
3327
Paul Belanger174a8272017-03-14 13:20:10 -04003328 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003329 self.waitUntilSettled()
3330
3331 # C successfully merged so window is bumped to 3.
3332 self.assertEqual(queue.window, 3)
3333 self.assertEqual(queue.window_floor, 1)
3334 self.assertEqual(C.data['status'], 'MERGED')
3335
James E. Blaircc324192017-04-19 14:36:08 -07003336 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003337 def test_queue_rate_limiting_dependent(self):
3338 "Test that DependentPipelines are rate limited with dep in window"
Paul Belanger174a8272017-03-14 13:20:10 -04003339 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003340 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3341 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3342 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3343
3344 B.setDependsOn(A, 1)
3345
Paul Belanger174a8272017-03-14 13:20:10 -04003346 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003347
James E. Blair8b5408c2016-08-08 15:37:46 -07003348 A.addApproval('code-review', 2)
3349 B.addApproval('code-review', 2)
3350 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003351
James E. Blair8b5408c2016-08-08 15:37:46 -07003352 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3353 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3354 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003355 self.waitUntilSettled()
3356
3357 # Only A and B will have their merge jobs queued because
3358 # window is 2.
3359 self.assertEqual(len(self.builds), 2)
3360 self.assertEqual(self.builds[0].name, 'project-merge')
3361 self.assertEqual(self.builds[1].name, 'project-merge')
3362
James E. Blairf4a5f022017-04-18 14:01:10 -07003363 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003364
3365 # Only A and B will have their test jobs queued because
3366 # window is 2.
3367 self.assertEqual(len(self.builds), 4)
3368 self.assertEqual(self.builds[0].name, 'project-test1')
3369 self.assertEqual(self.builds[1].name, 'project-test2')
3370 self.assertEqual(self.builds[2].name, 'project-test1')
3371 self.assertEqual(self.builds[3].name, 'project-test2')
3372
Paul Belanger174a8272017-03-14 13:20:10 -04003373 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003374 self.waitUntilSettled()
3375
James E. Blaircc324192017-04-19 14:36:08 -07003376 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003377 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003378 # A failed so window is reduced by 1 to 1.
3379 self.assertEqual(queue.window, 1)
3380 self.assertEqual(queue.window_floor, 1)
3381 self.assertEqual(A.data['status'], 'NEW')
3382 self.assertEqual(B.data['status'], 'NEW')
3383
3384 # Gate is reset and only C's merge job is queued because
3385 # window shrunk to 1 and A and B were dequeued.
3386 self.assertEqual(len(self.builds), 1)
3387 self.assertEqual(self.builds[0].name, 'project-merge')
3388
James E. Blairf4a5f022017-04-18 14:01:10 -07003389 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003390
3391 # Only C's test jobs are queued because window is still 1.
3392 self.assertEqual(len(self.builds), 2)
James E. Blairdf25ddc2017-07-08 07:57:09 -07003393 builds = self.getSortedBuilds()
3394 self.assertEqual(builds[0].name, 'project-test1')
3395 self.assertEqual(builds[1].name, 'project-test2')
Clark Boylan7603a372014-01-21 11:43:20 -08003396
Paul Belanger174a8272017-03-14 13:20:10 -04003397 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003398 self.waitUntilSettled()
3399
3400 # C was successfully merged so window is increased to 2.
3401 self.assertEqual(queue.window, 2)
3402 self.assertEqual(queue.window_floor, 1)
3403 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003404
3405 def test_worker_update_metadata(self):
3406 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003407 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003408
3409 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003410 A.addApproval('code-review', 2)
3411 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003412 self.waitUntilSettled()
3413
Clint Byrumd4de79a2017-05-27 11:39:13 -07003414 self.assertEqual(len(self.executor_client.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003415
3416 self.log.debug('Current builds:')
Clint Byrumd4de79a2017-05-27 11:39:13 -07003417 self.log.debug(self.executor_client.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003418
3419 start = time.time()
3420 while True:
3421 if time.time() - start > 10:
3422 raise Exception("Timeout waiting for gearman server to report "
3423 + "back to the client")
Clint Byrumd4de79a2017-05-27 11:39:13 -07003424 build = list(self.executor_client.builds.values())[0]
Monty Tayloreea6bb92017-06-14 11:56:54 -05003425 if build.worker.name == self.executor_server.hostname:
Joshua Heskethba8776a2014-01-12 14:35:40 +08003426 break
3427 else:
3428 time.sleep(0)
3429
3430 self.log.debug(build)
Monty Tayloreea6bb92017-06-14 11:56:54 -05003431 self.assertEqual(self.executor_server.hostname, build.worker.name)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003432
Paul Belanger174a8272017-03-14 13:20:10 -04003433 self.executor_server.hold_jobs_in_build = False
3434 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003435 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003436
James E. Blaircc324192017-04-19 14:36:08 -07003437 @simple_layout('layouts/footer-message.yaml')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003438 def test_footer_message(self):
3439 "Test a pipeline's footer message is correctly added to the report."
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003440 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003441 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003442 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003443 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003444 self.waitUntilSettled()
3445
3446 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003447 B.addApproval('code-review', 2)
3448 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003449 self.waitUntilSettled()
3450
3451 self.assertEqual(2, len(self.smtp_messages))
3452
Adam Gandelman82258fd2017-02-07 16:51:58 -08003453 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003454Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003455http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003456
Adam Gandelman82258fd2017-02-07 16:51:58 -08003457 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003458For CI problems and help debugging, contact ci@example.org"""
3459
Adam Gandelman82258fd2017-02-07 16:51:58 -08003460 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3461 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3462 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3463 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003464
Tobias Henkel9842bd72017-05-16 13:40:03 +02003465 @simple_layout('layouts/unmanaged-project.yaml')
3466 def test_unmanaged_project_start_message(self):
3467 "Test start reporting is not done for unmanaged projects."
3468 self.init_repo("org/project", tag='init')
3469 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3470 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3471 self.waitUntilSettled()
3472
3473 self.assertEqual(0, len(A.messages))
3474
Clint Byrumb9de8be2017-05-27 13:49:19 -07003475 @simple_layout('layouts/merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003476 def test_merge_failure_reporters(self):
3477 """Check that the config is set up correctly"""
3478
Clint Byrumb9de8be2017-05-27 13:49:19 -07003479 tenant = self.sched.abide.tenants.get('tenant-one')
Joshua Heskethb7179772014-01-30 23:30:46 +11003480 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003481 "Merge Failed.\n\nThis change or one of its cross-repo "
3482 "dependencies was unable to be automatically merged with the "
3483 "current state of its repository. Please rebase the change and "
3484 "upload a new patchset.",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003485 tenant.layout.pipelines['check'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003486 self.assertEqual(
3487 "The merge failed! For more information...",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003488 tenant.layout.pipelines['gate'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003489
3490 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003491 len(tenant.layout.pipelines['check'].merge_failure_actions), 1)
Joshua Heskethb7179772014-01-30 23:30:46 +11003492 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003493 len(tenant.layout.pipelines['gate'].merge_failure_actions), 2)
Joshua Heskethb7179772014-01-30 23:30:46 +11003494
3495 self.assertTrue(isinstance(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003496 tenant.layout.pipelines['check'].merge_failure_actions[0],
3497 gerritreporter.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003498
3499 self.assertTrue(
3500 (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003501 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003502 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003503 zuul.driver.smtp.smtpreporter.SMTPReporter) and
3504 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003505 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003506 gerritreporter.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003507 ) or (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003508 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003509 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003510 gerritreporter.GerritReporter) and
3511 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003512 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003513 zuul.driver.smtp.smtpreporter.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003514 )
3515 )
3516
James E. Blairec056492016-07-22 09:45:56 -07003517 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003518 def test_merge_failure_reports(self):
3519 """Check that when a change fails to merge the correct message is sent
3520 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003521 self.updateConfigLayout(
3522 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003523 self.sched.reconfigure(self.config)
3524 self.registerJobs()
3525
3526 # Check a test failure isn't reported to SMTP
3527 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003528 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003529 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003530 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003531 self.waitUntilSettled()
3532
3533 self.assertEqual(3, len(self.history)) # 3 jobs
3534 self.assertEqual(0, len(self.smtp_messages))
3535
3536 # Check a merge failure is reported to SMTP
3537 # B should be merged, but C will conflict with B
3538 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3539 B.addPatchset(['conflict'])
3540 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3541 C.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003542 B.addApproval('code-review', 2)
3543 C.addApproval('code-review', 2)
3544 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3545 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003546 self.waitUntilSettled()
3547
3548 self.assertEqual(6, len(self.history)) # A and B jobs
3549 self.assertEqual(1, len(self.smtp_messages))
3550 self.assertEqual('The merge failed! For more information...',
3551 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003552
James E. Blairec056492016-07-22 09:45:56 -07003553 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003554 def test_default_merge_failure_reports(self):
3555 """Check that the default merge failure reports are correct."""
3556
3557 # A should report success, B should report merge failure.
3558 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3559 A.addPatchset(['conflict'])
3560 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3561 B.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003562 A.addApproval('code-review', 2)
3563 B.addApproval('code-review', 2)
3564 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3565 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003566 self.waitUntilSettled()
3567
3568 self.assertEqual(3, len(self.history)) # A jobs
3569 self.assertEqual(A.reported, 2)
3570 self.assertEqual(B.reported, 2)
3571 self.assertEqual(A.data['status'], 'MERGED')
3572 self.assertEqual(B.data['status'], 'NEW')
3573 self.assertIn('Build succeeded', A.messages[1])
3574 self.assertIn('Merge Failed', B.messages[1])
3575 self.assertIn('automatically merged', B.messages[1])
3576 self.assertNotIn('logs.example.com', B.messages[1])
3577 self.assertNotIn('SKIPPED', B.messages[1])
3578
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003579 def test_client_get_running_jobs(self):
3580 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003581 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003582 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003583 A.addApproval('code-review', 2)
3584 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003585 self.waitUntilSettled()
3586
3587 client = zuul.rpcclient.RPCClient('127.0.0.1',
3588 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003589 self.addCleanup(client.shutdown)
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003590
3591 # Wait for gearman server to send the initial workData back to zuul
3592 start = time.time()
3593 while True:
3594 if time.time() - start > 10:
3595 raise Exception("Timeout waiting for gearman server to report "
3596 + "back to the client")
Clint Byrum1d0c7d12017-05-10 19:40:53 -07003597 build = list(self.executor_client.builds.values())[0]
Monty Tayloreea6bb92017-06-14 11:56:54 -05003598 if build.worker.name == self.executor_server.hostname:
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003599 break
3600 else:
3601 time.sleep(0)
3602
3603 running_items = client.get_running_jobs()
3604
3605 self.assertEqual(1, len(running_items))
3606 running_item = running_items[0]
3607 self.assertEqual([], running_item['failing_reasons'])
3608 self.assertEqual([], running_item['items_behind'])
3609 self.assertEqual('https://hostname/1', running_item['url'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003610 self.assertIsNone(running_item['item_ahead'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003611 self.assertEqual('org/project', running_item['project'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003612 self.assertIsNone(running_item['remaining_time'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003613 self.assertEqual(True, running_item['active'])
3614 self.assertEqual('1,1', running_item['id'])
3615
3616 self.assertEqual(3, len(running_item['jobs']))
3617 for job in running_item['jobs']:
3618 if job['name'] == 'project-merge':
3619 self.assertEqual('project-merge', job['name'])
3620 self.assertEqual('gate', job['pipeline'])
3621 self.assertEqual(False, job['retry'])
Monty Taylor51139a02016-05-24 11:28:10 -05003622 self.assertEqual(
Tobias Henkelb4407fc2017-07-07 13:52:56 +02003623 'static/stream.html?uuid={uuid}&logfile=console.log'
3624 .format(uuid=job['uuid']), job['url'])
3625 self.assertEqual(
Monty Taylor51139a02016-05-24 11:28:10 -05003626 'finger://{hostname}/{uuid}'.format(
3627 hostname=self.executor_server.hostname,
3628 uuid=job['uuid']),
Tobias Henkelb4407fc2017-07-07 13:52:56 +02003629 job['finger_url'])
Clint Byrumd4de79a2017-05-27 11:39:13 -07003630 self.assertEqual(2, len(job['worker']))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003631 self.assertEqual(False, job['canceled'])
3632 self.assertEqual(True, job['voting'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003633 self.assertIsNone(job['result'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003634 self.assertEqual('gate', job['pipeline'])
3635 break
3636
Paul Belanger174a8272017-03-14 13:20:10 -04003637 self.executor_server.hold_jobs_in_build = False
3638 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003639 self.waitUntilSettled()
3640
3641 running_items = client.get_running_jobs()
3642 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003643
James E. Blairb70e55a2017-04-19 12:57:02 -07003644 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003645 def test_nonvoting_pipeline(self):
3646 "Test that a nonvoting pipeline (experimental) can still report"
3647
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003648 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3649 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003650 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3651 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003652
3653 self.assertEqual(self.getJobFromHistory('project-merge').result,
3654 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003655 self.assertEqual(
3656 self.getJobFromHistory('experimental-project-test').result,
3657 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003658 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003659
3660 def test_crd_gate(self):
3661 "Test cross-repo dependencies"
3662 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3663 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003664 A.addApproval('code-review', 2)
3665 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003666
3667 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3668 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3669 AM2.setMerged()
3670 AM1.setMerged()
3671
3672 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3673 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3674 BM2.setMerged()
3675 BM1.setMerged()
3676
3677 # A -> AM1 -> AM2
3678 # B -> BM1 -> BM2
3679 # A Depends-On: B
3680 # M2 is here to make sure it is never queried. If it is, it
3681 # means zuul is walking down the entire history of merged
3682 # changes.
3683
3684 B.setDependsOn(BM1, 1)
3685 BM1.setDependsOn(BM2, 1)
3686
3687 A.setDependsOn(AM1, 1)
3688 AM1.setDependsOn(AM2, 1)
3689
3690 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3691 A.subject, B.data['id'])
3692
James E. Blair8b5408c2016-08-08 15:37:46 -07003693 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003694 self.waitUntilSettled()
3695
3696 self.assertEqual(A.data['status'], 'NEW')
3697 self.assertEqual(B.data['status'], 'NEW')
3698
Paul Belanger5dccbe72016-11-14 11:17:37 -05003699 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11003700 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003701
Paul Belanger174a8272017-03-14 13:20:10 -04003702 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003703 B.addApproval('approved', 1)
3704 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003705 self.waitUntilSettled()
3706
Paul Belanger174a8272017-03-14 13:20:10 -04003707 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003708 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003709 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003710 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003711 self.executor_server.hold_jobs_in_build = False
3712 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003713 self.waitUntilSettled()
3714
3715 self.assertEqual(AM2.queried, 0)
3716 self.assertEqual(BM2.queried, 0)
3717 self.assertEqual(A.data['status'], 'MERGED')
3718 self.assertEqual(B.data['status'], 'MERGED')
3719 self.assertEqual(A.reported, 2)
3720 self.assertEqual(B.reported, 2)
3721
Paul Belanger5dccbe72016-11-14 11:17:37 -05003722 changes = self.getJobFromHistory(
3723 'project-merge', 'org/project1').changes
3724 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003725
3726 def test_crd_branch(self):
3727 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003728
3729 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003730 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3731 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3732 C = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C')
3733 C.data['id'] = B.data['id']
James E. Blair8b5408c2016-08-08 15:37:46 -07003734 A.addApproval('code-review', 2)
3735 B.addApproval('code-review', 2)
3736 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003737
3738 # A Depends-On: B+C
3739 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3740 A.subject, B.data['id'])
3741
Paul Belanger174a8272017-03-14 13:20:10 -04003742 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003743 B.addApproval('approved', 1)
3744 C.addApproval('approved', 1)
3745 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003746 self.waitUntilSettled()
3747
Paul Belanger174a8272017-03-14 13:20:10 -04003748 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003749 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003750 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003751 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003752 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003753 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003754 self.executor_server.hold_jobs_in_build = False
3755 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003756 self.waitUntilSettled()
3757
3758 self.assertEqual(A.data['status'], 'MERGED')
3759 self.assertEqual(B.data['status'], 'MERGED')
3760 self.assertEqual(C.data['status'], 'MERGED')
3761 self.assertEqual(A.reported, 2)
3762 self.assertEqual(B.reported, 2)
3763 self.assertEqual(C.reported, 2)
3764
Paul Belanger6379db12016-11-14 13:57:54 -05003765 changes = self.getJobFromHistory(
3766 'project-merge', 'org/project1').changes
3767 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003768
3769 def test_crd_multiline(self):
3770 "Test multiple depends-on lines in commit"
3771 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3772 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3773 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003774 A.addApproval('code-review', 2)
3775 B.addApproval('code-review', 2)
3776 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003777
3778 # A Depends-On: B+C
3779 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
3780 A.subject, B.data['id'], C.data['id'])
3781
Paul Belanger174a8272017-03-14 13:20:10 -04003782 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003783 B.addApproval('approved', 1)
3784 C.addApproval('approved', 1)
3785 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003786 self.waitUntilSettled()
3787
Paul Belanger174a8272017-03-14 13:20:10 -04003788 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003789 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003790 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003791 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003792 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003793 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003794 self.executor_server.hold_jobs_in_build = False
3795 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003796 self.waitUntilSettled()
3797
3798 self.assertEqual(A.data['status'], 'MERGED')
3799 self.assertEqual(B.data['status'], 'MERGED')
3800 self.assertEqual(C.data['status'], 'MERGED')
3801 self.assertEqual(A.reported, 2)
3802 self.assertEqual(B.reported, 2)
3803 self.assertEqual(C.reported, 2)
3804
Paul Belanger5dccbe72016-11-14 11:17:37 -05003805 changes = self.getJobFromHistory(
3806 'project-merge', 'org/project1').changes
3807 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08003808
3809 def test_crd_unshared_gate(self):
3810 "Test cross-repo dependencies in unshared gate queues"
3811 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3812 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003813 A.addApproval('code-review', 2)
3814 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003815
3816 # A Depends-On: B
3817 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3818 A.subject, B.data['id'])
3819
3820 # A and B do not share a queue, make sure that A is unable to
3821 # enqueue B (and therefore, A is unable to be enqueued).
James E. Blair8b5408c2016-08-08 15:37:46 -07003822 B.addApproval('approved', 1)
3823 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003824 self.waitUntilSettled()
3825
3826 self.assertEqual(A.data['status'], 'NEW')
3827 self.assertEqual(B.data['status'], 'NEW')
3828 self.assertEqual(A.reported, 0)
3829 self.assertEqual(B.reported, 0)
3830 self.assertEqual(len(self.history), 0)
3831
3832 # Enqueue and merge B alone.
James E. Blair8b5408c2016-08-08 15:37:46 -07003833 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003834 self.waitUntilSettled()
3835
3836 self.assertEqual(B.data['status'], 'MERGED')
3837 self.assertEqual(B.reported, 2)
3838
3839 # Now that B is merged, A should be able to be enqueued and
3840 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003841 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003842 self.waitUntilSettled()
3843
3844 self.assertEqual(A.data['status'], 'MERGED')
3845 self.assertEqual(A.reported, 2)
3846
James E. Blair96698e22015-04-02 07:48:21 -07003847 def test_crd_gate_reverse(self):
3848 "Test reverse cross-repo dependencies"
3849 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3850 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003851 A.addApproval('code-review', 2)
3852 B.addApproval('code-review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07003853
3854 # A Depends-On: B
3855
3856 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3857 A.subject, B.data['id'])
3858
James E. Blair8b5408c2016-08-08 15:37:46 -07003859 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003860 self.waitUntilSettled()
3861
3862 self.assertEqual(A.data['status'], 'NEW')
3863 self.assertEqual(B.data['status'], 'NEW')
3864
Paul Belanger174a8272017-03-14 13:20:10 -04003865 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003866 A.addApproval('approved', 1)
3867 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003868 self.waitUntilSettled()
3869
Paul Belanger174a8272017-03-14 13:20:10 -04003870 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003871 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003872 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003873 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003874 self.executor_server.hold_jobs_in_build = False
3875 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07003876 self.waitUntilSettled()
3877
3878 self.assertEqual(A.data['status'], 'MERGED')
3879 self.assertEqual(B.data['status'], 'MERGED')
3880 self.assertEqual(A.reported, 2)
3881 self.assertEqual(B.reported, 2)
3882
Paul Belanger5dccbe72016-11-14 11:17:37 -05003883 changes = self.getJobFromHistory(
3884 'project-merge', 'org/project1').changes
3885 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07003886
James E. Blair5ee24252014-12-30 10:12:29 -08003887 def test_crd_cycle(self):
3888 "Test cross-repo dependency cycles"
3889 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3890 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003891 A.addApproval('code-review', 2)
3892 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003893
3894 # A -> B -> A (via commit-depends)
3895
3896 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3897 A.subject, B.data['id'])
3898 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3899 B.subject, A.data['id'])
3900
James E. Blair8b5408c2016-08-08 15:37:46 -07003901 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003902 self.waitUntilSettled()
3903
3904 self.assertEqual(A.reported, 0)
3905 self.assertEqual(B.reported, 0)
3906 self.assertEqual(A.data['status'], 'NEW')
3907 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08003908
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003909 def test_crd_gate_unknown(self):
3910 "Test unknown projects in dependent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07003911 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003912 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3913 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003914 A.addApproval('code-review', 2)
3915 B.addApproval('code-review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003916
3917 # A Depends-On: B
3918 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3919 A.subject, B.data['id'])
3920
James E. Blair8b5408c2016-08-08 15:37:46 -07003921 B.addApproval('approved', 1)
3922 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003923 self.waitUntilSettled()
3924
3925 # Unknown projects cannot share a queue with any other
3926 # since they don't have common jobs with any other (they have no jobs).
3927 # Changes which depend on unknown project changes
3928 # should not be processed in dependent pipeline
3929 self.assertEqual(A.data['status'], 'NEW')
3930 self.assertEqual(B.data['status'], 'NEW')
3931 self.assertEqual(A.reported, 0)
3932 self.assertEqual(B.reported, 0)
3933 self.assertEqual(len(self.history), 0)
3934
James E. Blair7720b402017-06-07 08:51:49 -07003935 # Simulate change B being gated outside this layout Set the
3936 # change merged before submitting the event so that when the
3937 # event triggers a gerrit query to update the change, we get
3938 # the information that it was merged.
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003939 B.setMerged()
James E. Blair7720b402017-06-07 08:51:49 -07003940 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003941 self.waitUntilSettled()
3942 self.assertEqual(len(self.history), 0)
3943
3944 # Now that B is merged, A should be able to be enqueued and
3945 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003946 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003947 self.waitUntilSettled()
3948
3949 self.assertEqual(A.data['status'], 'MERGED')
3950 self.assertEqual(A.reported, 2)
3951 self.assertEqual(B.data['status'], 'MERGED')
3952 self.assertEqual(B.reported, 0)
3953
James E. Blairbfb8e042014-12-30 17:01:44 -08003954 def test_crd_check(self):
3955 "Test cross-repo dependencies in independent pipelines"
3956
Paul Belanger174a8272017-03-14 13:20:10 -04003957 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08003958 self.gearman_server.hold_jobs_in_queue = True
3959 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3960 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3961
3962 # A Depends-On: B
3963 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3964 A.subject, B.data['id'])
3965
3966 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3967 self.waitUntilSettled()
3968
James E. Blairbfb8e042014-12-30 17:01:44 -08003969 self.gearman_server.hold_jobs_in_queue = False
3970 self.gearman_server.release()
3971 self.waitUntilSettled()
3972
Paul Belanger174a8272017-03-14 13:20:10 -04003973 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05003974 self.waitUntilSettled()
3975
James E. Blair2a535672017-04-27 12:03:15 -07003976 self.assertTrue(self.builds[0].hasChanges(A, B))
James E. Blairbfb8e042014-12-30 17:01:44 -08003977
Paul Belanger174a8272017-03-14 13:20:10 -04003978 self.executor_server.hold_jobs_in_build = False
3979 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05003980 self.waitUntilSettled()
3981
James E. Blairbfb8e042014-12-30 17:01:44 -08003982 self.assertEqual(A.data['status'], 'NEW')
3983 self.assertEqual(B.data['status'], 'NEW')
3984 self.assertEqual(A.reported, 1)
3985 self.assertEqual(B.reported, 0)
3986
3987 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05003988 tenant = self.sched.abide.tenants.get('tenant-one')
3989 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08003990
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003991 def test_crd_check_git_depends(self):
3992 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07003993 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003994 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3995 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
3996
3997 # Add two git-dependent changes and make sure they both report
3998 # success.
3999 B.setDependsOn(A, 1)
4000 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4001 self.waitUntilSettled()
4002 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4003 self.waitUntilSettled()
4004
James E. Blairb8c16472015-05-05 14:55:26 -07004005 self.orderedRelease()
4006 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004007 self.waitUntilSettled()
4008
4009 self.assertEqual(A.data['status'], 'NEW')
4010 self.assertEqual(B.data['status'], 'NEW')
4011 self.assertEqual(A.reported, 1)
4012 self.assertEqual(B.reported, 1)
4013
4014 self.assertEqual(self.history[0].changes, '1,1')
4015 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04004016 tenant = self.sched.abide.tenants.get('tenant-one')
4017 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004018
4019 self.assertIn('Build succeeded', A.messages[0])
4020 self.assertIn('Build succeeded', B.messages[0])
4021
4022 def test_crd_check_duplicate(self):
4023 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04004024 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004025 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4026 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04004027 tenant = self.sched.abide.tenants.get('tenant-one')
4028 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004029
4030 # Add two git-dependent changes...
4031 B.setDependsOn(A, 1)
4032 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4033 self.waitUntilSettled()
4034 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4035
4036 # ...make sure the live one is not duplicated...
4037 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4038 self.waitUntilSettled()
4039 self.assertEqual(len(check_pipeline.getAllItems()), 2)
4040
4041 # ...but the non-live one is able to be.
4042 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4043 self.waitUntilSettled()
4044 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4045
Clark Boylandd849822015-03-02 12:38:14 -08004046 # Release jobs in order to avoid races with change A jobs
4047 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07004048 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04004049 self.executor_server.hold_jobs_in_build = False
4050 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004051 self.waitUntilSettled()
4052
4053 self.assertEqual(A.data['status'], 'NEW')
4054 self.assertEqual(B.data['status'], 'NEW')
4055 self.assertEqual(A.reported, 1)
4056 self.assertEqual(B.reported, 1)
4057
4058 self.assertEqual(self.history[0].changes, '1,1 2,1')
4059 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04004060 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004061
4062 self.assertIn('Build succeeded', A.messages[0])
4063 self.assertIn('Build succeeded', B.messages[0])
4064
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004065 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08004066 "Test cross-repo dependencies re-enqueued in independent pipelines"
4067
4068 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004069 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
4070 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08004071
4072 # A Depends-On: B
4073 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4074 A.subject, B.data['id'])
4075
4076 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4077 self.waitUntilSettled()
4078
4079 self.sched.reconfigure(self.config)
4080
4081 # Make sure the items still share a change queue, and the
4082 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05004083 tenant = self.sched.abide.tenants.get('tenant-one')
4084 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
4085 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08004086 first_item = queue.queue[0]
4087 for item in queue.queue:
4088 self.assertEqual(item.queue, first_item.queue)
4089 self.assertFalse(first_item.live)
4090 self.assertTrue(queue.queue[1].live)
4091
4092 self.gearman_server.hold_jobs_in_queue = False
4093 self.gearman_server.release()
4094 self.waitUntilSettled()
4095
4096 self.assertEqual(A.data['status'], 'NEW')
4097 self.assertEqual(B.data['status'], 'NEW')
4098 self.assertEqual(A.reported, 1)
4099 self.assertEqual(B.reported, 0)
4100
4101 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004102 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004103
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004104 def test_crd_check_reconfiguration(self):
4105 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4106
4107 def test_crd_undefined_project(self):
4108 """Test that undefined projects in dependencies are handled for
4109 independent pipelines"""
4110 # It's a hack for fake gerrit,
4111 # as it implies repo creation upon the creation of any change
James E. Blairc4ba97a2017-04-19 16:26:24 -07004112 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004113 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4114
Jesse Keatingea68ab42017-04-19 15:03:30 -07004115 @simple_layout('layouts/ignore-dependencies.yaml')
James E. Blair17dd6772015-02-09 14:45:18 -08004116 def test_crd_check_ignore_dependencies(self):
4117 "Test cross-repo dependencies can be ignored"
James E. Blair17dd6772015-02-09 14:45:18 -08004118
4119 self.gearman_server.hold_jobs_in_queue = True
4120 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4121 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4122 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4123
4124 # A Depends-On: B
4125 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4126 A.subject, B.data['id'])
4127 # C git-depends on B
4128 C.setDependsOn(B, 1)
4129 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4130 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4131 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4132 self.waitUntilSettled()
4133
4134 # Make sure none of the items share a change queue, and all
4135 # are live.
Jesse Keatingea68ab42017-04-19 15:03:30 -07004136 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum12282ca2017-04-03 11:04:02 -07004137 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004138 self.assertEqual(len(check_pipeline.queues), 3)
4139 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4140 for item in check_pipeline.getAllItems():
4141 self.assertTrue(item.live)
4142
4143 self.gearman_server.hold_jobs_in_queue = False
4144 self.gearman_server.release()
4145 self.waitUntilSettled()
4146
4147 self.assertEqual(A.data['status'], 'NEW')
4148 self.assertEqual(B.data['status'], 'NEW')
4149 self.assertEqual(C.data['status'], 'NEW')
4150 self.assertEqual(A.reported, 1)
4151 self.assertEqual(B.reported, 1)
4152 self.assertEqual(C.reported, 1)
4153
4154 # Each job should have tested exactly one change
4155 for job in self.history:
4156 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004157
James E. Blair7cb84542017-04-19 13:35:05 -07004158 @simple_layout('layouts/three-projects.yaml')
James E. Blair96698e22015-04-02 07:48:21 -07004159 def test_crd_check_transitive(self):
4160 "Test transitive cross-repo dependencies"
4161 # Specifically, if A -> B -> C, and C gets a new patchset and
4162 # A gets a new patchset, ensure the test of A,2 includes B,1
4163 # and C,2 (not C,1 which would indicate stale data in the
4164 # cache for B).
4165 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4166 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4167 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4168
4169 # A Depends-On: B
4170 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4171 A.subject, B.data['id'])
4172
4173 # B Depends-On: C
4174 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4175 B.subject, C.data['id'])
4176
4177 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4178 self.waitUntilSettled()
4179 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4180
4181 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4182 self.waitUntilSettled()
4183 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4184
4185 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4186 self.waitUntilSettled()
4187 self.assertEqual(self.history[-1].changes, '3,1')
4188
4189 C.addPatchset()
4190 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4191 self.waitUntilSettled()
4192 self.assertEqual(self.history[-1].changes, '3,2')
4193
4194 A.addPatchset()
4195 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4196 self.waitUntilSettled()
4197 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004198
James E. Blaira8b90b32016-08-24 15:18:50 -07004199 def test_crd_check_unknown(self):
4200 "Test unknown projects in independent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004201 self.init_repo("org/unknown", tag='init')
James E. Blaira8b90b32016-08-24 15:18:50 -07004202 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4203 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4204 # A Depends-On: B
4205 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4206 A.subject, B.data['id'])
4207
4208 # Make sure zuul has seen an event on B.
4209 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4210 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4211 self.waitUntilSettled()
4212
4213 self.assertEqual(A.data['status'], 'NEW')
4214 self.assertEqual(A.reported, 1)
4215 self.assertEqual(B.data['status'], 'NEW')
4216 self.assertEqual(B.reported, 0)
4217
James E. Blair92464a22016-04-05 10:21:26 -07004218 def test_crd_cycle_join(self):
4219 "Test an updated change creates a cycle"
4220 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4221
4222 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4223 self.waitUntilSettled()
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004224 self.assertEqual(A.reported, 1)
James E. Blair92464a22016-04-05 10:21:26 -07004225
4226 # Create B->A
4227 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4228 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4229 B.subject, A.data['id'])
4230 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4231 self.waitUntilSettled()
4232
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004233 # Dep is there so zuul should have reported on B
4234 self.assertEqual(B.reported, 1)
4235
James E. Blair92464a22016-04-05 10:21:26 -07004236 # Update A to add A->B (a cycle).
4237 A.addPatchset()
4238 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4239 A.subject, B.data['id'])
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004240 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4241 self.waitUntilSettled()
James E. Blair92464a22016-04-05 10:21:26 -07004242
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004243 # Dependency cycle injected so zuul should not have reported again on A
4244 self.assertEqual(A.reported, 1)
James E. Blair92464a22016-04-05 10:21:26 -07004245
4246 # Now if we update B to remove the depends-on, everything
4247 # should be okay. B; A->B
4248
4249 B.addPatchset()
4250 B.data['commitMessage'] = '%s\n' % (B.subject,)
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004251 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4252 self.waitUntilSettled()
Paul Belanger0e155e22016-11-14 14:12:23 -05004253
Tobias Henkel6b9390f2017-03-28 11:23:21 +02004254 # Cycle was removed so now zuul should have reported again on A
4255 self.assertEqual(A.reported, 2)
4256
4257 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
4258 self.waitUntilSettled()
4259 self.assertEqual(B.reported, 2)
James E. Blair92464a22016-04-05 10:21:26 -07004260
Jesse Keatingcc67b122017-04-19 14:54:57 -07004261 @simple_layout('layouts/disable_at.yaml')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004262 def test_disable_at(self):
4263 "Test a pipeline will only report to the disabled trigger when failing"
4264
Jesse Keatingcc67b122017-04-19 14:54:57 -07004265 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004266 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004267 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004268 0, tenant.layout.pipelines['check']._consecutive_failures)
4269 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004270
4271 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4272 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4273 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4274 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4275 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4276 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4277 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4278 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4279 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4280 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4281 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4282
Paul Belanger174a8272017-03-14 13:20:10 -04004283 self.executor_server.failJob('project-test1', A)
4284 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004285 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004286 self.executor_server.failJob('project-test1', D)
4287 self.executor_server.failJob('project-test1', E)
4288 self.executor_server.failJob('project-test1', F)
4289 self.executor_server.failJob('project-test1', G)
4290 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004291 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004292 self.executor_server.failJob('project-test1', J)
4293 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004294
4295 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4296 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4297 self.waitUntilSettled()
4298
4299 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004300 2, tenant.layout.pipelines['check']._consecutive_failures)
4301 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004302
4303 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4304 self.waitUntilSettled()
4305
4306 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004307 0, tenant.layout.pipelines['check']._consecutive_failures)
4308 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004309
4310 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4311 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4312 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4313 self.waitUntilSettled()
4314
4315 # We should be disabled now
4316 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004317 3, tenant.layout.pipelines['check']._consecutive_failures)
4318 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004319
4320 # We need to wait between each of these patches to make sure the
4321 # smtp messages come back in an expected order
4322 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4323 self.waitUntilSettled()
4324 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4325 self.waitUntilSettled()
4326 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4327 self.waitUntilSettled()
4328
4329 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4330 # leaving a message on each change
4331 self.assertEqual(1, len(A.messages))
4332 self.assertIn('Build failed.', A.messages[0])
4333 self.assertEqual(1, len(B.messages))
4334 self.assertIn('Build failed.', B.messages[0])
4335 self.assertEqual(1, len(C.messages))
4336 self.assertIn('Build succeeded.', C.messages[0])
4337 self.assertEqual(1, len(D.messages))
4338 self.assertIn('Build failed.', D.messages[0])
4339 self.assertEqual(1, len(E.messages))
4340 self.assertIn('Build failed.', E.messages[0])
4341 self.assertEqual(1, len(F.messages))
4342 self.assertIn('Build failed.', F.messages[0])
4343
4344 # The last 3 (GHI) would have only reported via smtp.
4345 self.assertEqual(3, len(self.smtp_messages))
4346 self.assertEqual(0, len(G.messages))
4347 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004348 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004349 'project-test1 finger://', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004350 self.assertEqual(0, len(H.messages))
4351 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004352 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004353 'project-test1 finger://', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004354 self.assertEqual(0, len(I.messages))
4355 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004356 self.assertIn(
Monty Taylorde8242c2017-02-23 20:29:53 -06004357 'project-test1 finger://', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004358
4359 # Now reload the configuration (simulate a HUP) to check the pipeline
4360 # comes out of disabled
4361 self.sched.reconfigure(self.config)
4362
Jesse Keatingcc67b122017-04-19 14:54:57 -07004363 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004364
4365 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004366 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004367 0, tenant.layout.pipelines['check']._consecutive_failures)
4368 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004369
4370 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4371 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4372 self.waitUntilSettled()
4373
4374 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004375 2, tenant.layout.pipelines['check']._consecutive_failures)
4376 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004377
4378 # J and K went back to gerrit
4379 self.assertEqual(1, len(J.messages))
4380 self.assertIn('Build failed.', J.messages[0])
4381 self.assertEqual(1, len(K.messages))
4382 self.assertIn('Build failed.', K.messages[0])
4383 # No more messages reported via smtp
4384 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004385
James E. Blaircc020532017-04-19 13:04:44 -07004386 @simple_layout('layouts/one-job-project.yaml')
4387 def test_one_job_project(self):
4388 "Test that queueing works with one job"
4389 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4390 'master', 'A')
4391 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4392 'master', 'B')
4393 A.addApproval('code-review', 2)
4394 B.addApproval('code-review', 2)
4395 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4396 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4397 self.waitUntilSettled()
4398
4399 self.assertEqual(A.data['status'], 'MERGED')
4400 self.assertEqual(A.reported, 2)
4401 self.assertEqual(B.data['status'], 'MERGED')
4402 self.assertEqual(B.reported, 2)
4403
Paul Belanger71d98172016-11-08 10:56:31 -05004404 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004405 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004406
Paul Belanger174a8272017-03-14 13:20:10 -04004407 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004408 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4409 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4410 self.waitUntilSettled()
4411
Paul Belanger174a8272017-03-14 13:20:10 -04004412 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004413 self.waitUntilSettled()
4414
4415 self.assertEqual(len(self.builds), 2)
4416 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004417 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004418 self.waitUntilSettled()
4419
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004420 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004421 self.assertEqual(len(self.builds), 1,
4422 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004423 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004424 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004425 self.waitUntilSettled()
4426
Paul Belanger174a8272017-03-14 13:20:10 -04004427 self.executor_server.hold_jobs_in_build = False
4428 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004429 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004430 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004431 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4432 self.assertEqual(A.reported, 1)
4433 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004434
James E. Blair15be0e12017-01-03 13:45:20 -08004435 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004436 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004437
4438 self.fake_nodepool.paused = True
4439 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4440 A.addApproval('code-review', 2)
4441 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4442 self.waitUntilSettled()
4443
4444 self.zk.client.stop()
4445 self.zk.client.start()
4446 self.fake_nodepool.paused = False
4447 self.waitUntilSettled()
4448
4449 self.assertEqual(A.data['status'], 'MERGED')
4450 self.assertEqual(A.reported, 2)
4451
James E. Blair6ab79e02017-01-06 10:10:17 -08004452 def test_nodepool_failure(self):
4453 "Test that jobs are reported after a nodepool failure"
4454
4455 self.fake_nodepool.paused = True
4456 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4457 A.addApproval('code-review', 2)
4458 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4459 self.waitUntilSettled()
4460
4461 req = self.fake_nodepool.getNodeRequests()[0]
4462 self.fake_nodepool.addFailRequest(req)
4463
4464 self.fake_nodepool.paused = False
4465 self.waitUntilSettled()
4466
4467 self.assertEqual(A.data['status'], 'NEW')
4468 self.assertEqual(A.reported, 2)
4469 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4470 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4471 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4472
Arieb6f068c2016-10-09 13:11:06 +03004473
James E. Blaira002b032017-04-18 10:35:48 -07004474class TestExecutor(ZuulTestCase):
4475 tenant_config_file = 'config/single-tenant/main.yaml'
4476
4477 def assertFinalState(self):
4478 # In this test, we expect to shut down in a non-final state,
4479 # so skip these checks.
4480 pass
4481
4482 def assertCleanShutdown(self):
4483 self.log.debug("Assert clean shutdown")
4484
4485 # After shutdown, make sure no jobs are running
4486 self.assertEqual({}, self.executor_server.job_workers)
4487
4488 # Make sure that git.Repo objects have been garbage collected.
4489 repos = []
4490 gc.collect()
4491 for obj in gc.get_objects():
4492 if isinstance(obj, git.Repo):
4493 self.log.debug("Leaked git repo object: %s" % repr(obj))
4494 repos.append(obj)
4495 self.assertEqual(len(repos), 0)
4496
4497 def test_executor_shutdown(self):
4498 "Test that the executor can shut down with jobs running"
4499
4500 self.executor_server.hold_jobs_in_build = True
4501 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4502 A.addApproval('code-review', 2)
4503 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4504 self.waitUntilSettled()
4505
4506
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004507class TestDependencyGraph(ZuulTestCase):
4508 tenant_config_file = 'config/dependency-graph/main.yaml'
4509
4510 def test_dependeny_graph_dispatch_jobs_once(self):
4511 "Test a job in a dependency graph is queued only once"
4512 # Job dependencies, starting with A
4513 # A
4514 # / \
4515 # B C
4516 # / \ / \
4517 # D F E
4518 # |
4519 # G
4520
4521 self.executor_server.hold_jobs_in_build = True
4522 change = self.fake_gerrit.addFakeChange(
4523 'org/project', 'master', 'change')
4524 change.addApproval('code-review', 2)
4525 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4526
4527 self.waitUntilSettled()
4528 self.assertEqual([b.name for b in self.builds], ['A'])
4529
4530 self.executor_server.release('A')
4531 self.waitUntilSettled()
4532 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4533
4534 self.executor_server.release('B')
4535 self.waitUntilSettled()
4536 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4537
4538 self.executor_server.release('D')
4539 self.waitUntilSettled()
4540 self.assertEqual([b.name for b in self.builds], ['C'])
4541
4542 self.executor_server.release('C')
4543 self.waitUntilSettled()
4544 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4545
4546 self.executor_server.release('F')
4547 self.waitUntilSettled()
4548 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4549
4550 self.executor_server.release('G')
4551 self.waitUntilSettled()
4552 self.assertEqual([b.name for b in self.builds], ['E'])
4553
4554 self.executor_server.release('E')
4555 self.waitUntilSettled()
4556 self.assertEqual(len(self.builds), 0)
4557
4558 self.executor_server.hold_jobs_in_build = False
4559 self.executor_server.release()
4560 self.waitUntilSettled()
4561
4562 self.assertEqual(len(self.builds), 0)
4563 self.assertEqual(len(self.history), 7)
4564
4565 self.assertEqual(change.data['status'], 'MERGED')
4566 self.assertEqual(change.reported, 2)
4567
4568 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4569 "Test that a job waits till all dependencies are successful"
4570 # Job dependencies, starting with A
4571 # A
4572 # / \
4573 # B C*
4574 # / \ / \
4575 # D F E
4576 # |
4577 # G
4578
4579 self.executor_server.hold_jobs_in_build = True
4580 change = self.fake_gerrit.addFakeChange(
4581 'org/project', 'master', 'change')
4582 change.addApproval('code-review', 2)
4583
4584 self.executor_server.failJob('C', change)
4585
4586 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4587
4588 self.waitUntilSettled()
4589 self.assertEqual([b.name for b in self.builds], ['A'])
4590
4591 self.executor_server.release('A')
4592 self.waitUntilSettled()
4593 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4594
4595 self.executor_server.release('B')
4596 self.waitUntilSettled()
4597 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4598
4599 self.executor_server.release('D')
4600 self.waitUntilSettled()
4601 self.assertEqual([b.name for b in self.builds], ['C'])
4602
4603 self.executor_server.release('C')
4604 self.waitUntilSettled()
4605 self.assertEqual(len(self.builds), 0)
4606
4607 self.executor_server.hold_jobs_in_build = False
4608 self.executor_server.release()
4609 self.waitUntilSettled()
4610
4611 self.assertEqual(len(self.builds), 0)
4612 self.assertEqual(len(self.history), 4)
4613
4614 self.assertEqual(change.data['status'], 'NEW')
4615 self.assertEqual(change.reported, 2)
4616
4617
Arieb6f068c2016-10-09 13:11:06 +03004618class TestDuplicatePipeline(ZuulTestCase):
4619 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
4620
4621 def test_duplicate_pipelines(self):
4622 "Test that a change matching multiple pipelines works"
4623
4624 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4625 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
4626 self.waitUntilSettled()
4627
4628 self.assertHistory([
4629 dict(name='project-test1', result='SUCCESS', changes='1,1',
4630 pipeline='dup1'),
4631 dict(name='project-test1', result='SUCCESS', changes='1,1',
4632 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05004633 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03004634
4635 self.assertEqual(len(A.messages), 2)
4636
Paul Belangera46a3742016-11-09 14:23:03 -05004637 if 'dup1' in A.messages[0]:
4638 self.assertIn('dup1', A.messages[0])
4639 self.assertNotIn('dup2', A.messages[0])
4640 self.assertIn('project-test1', A.messages[0])
4641 self.assertIn('dup2', A.messages[1])
4642 self.assertNotIn('dup1', A.messages[1])
4643 self.assertIn('project-test1', A.messages[1])
4644 else:
4645 self.assertIn('dup1', A.messages[1])
4646 self.assertNotIn('dup2', A.messages[1])
4647 self.assertIn('project-test1', A.messages[1])
4648 self.assertIn('dup2', A.messages[0])
4649 self.assertNotIn('dup1', A.messages[0])
4650 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04004651
4652
Paul Belanger86085b32016-11-03 12:48:57 -04004653class TestSchedulerTemplatedProject(ZuulTestCase):
4654 tenant_config_file = 'config/templated-project/main.yaml'
4655
Paul Belanger174a8272017-03-14 13:20:10 -04004656 def test_job_from_templates_executed(self):
4657 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04004658
4659 A = self.fake_gerrit.addFakeChange(
4660 'org/templated-project', 'master', 'A')
4661 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4662 self.waitUntilSettled()
4663
4664 self.assertEqual(self.getJobFromHistory('project-test1').result,
4665 'SUCCESS')
4666 self.assertEqual(self.getJobFromHistory('project-test2').result,
4667 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04004668
4669 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004670 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04004671
4672 A = self.fake_gerrit.addFakeChange(
4673 'org/layered-project', 'master', 'A')
4674 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4675 self.waitUntilSettled()
4676
4677 self.assertEqual(self.getJobFromHistory('project-test1').result,
4678 'SUCCESS')
4679 self.assertEqual(self.getJobFromHistory('project-test2').result,
4680 'SUCCESS')
4681 self.assertEqual(self.getJobFromHistory('layered-project-test3'
4682 ).result, 'SUCCESS')
4683 self.assertEqual(self.getJobFromHistory('layered-project-test4'
4684 ).result, 'SUCCESS')
4685 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
4686 ).result, 'SUCCESS')
4687 self.assertEqual(self.getJobFromHistory('project-test6').result,
4688 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08004689
4690
4691class TestSchedulerSuccessURL(ZuulTestCase):
4692 tenant_config_file = 'config/success-url/main.yaml'
4693
4694 def test_success_url(self):
4695 "Ensure bad build params are ignored"
4696 self.sched.reconfigure(self.config)
4697 self.init_repo('org/docs')
4698
4699 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
4700 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4701 self.waitUntilSettled()
4702
4703 # Both builds ran: docs-draft-test + docs-draft-test2
4704 self.assertEqual(len(self.history), 2)
4705
4706 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08004707 for build in self.history:
4708 if build.name == 'docs-draft-test':
4709 uuid = build.uuid[:7]
Monty Taylorde8242c2017-02-23 20:29:53 -06004710 elif build.name == 'docs-draft-test2':
4711 uuid_test2 = build.uuid
Adam Gandelman94a60062016-11-21 16:43:14 -08004712
4713 # Two msgs: 'Starting...' + results
4714 self.assertEqual(len(self.smtp_messages), 2)
4715 body = self.smtp_messages[1]['body'].splitlines()
4716 self.assertEqual('Build succeeded.', body[0])
4717
4718 self.assertIn(
4719 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
4720 'docs-draft-test/%s/publish-docs/' % uuid,
4721 body[2])
4722
Paul Belanger174a8272017-03-14 13:20:10 -04004723 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08004724 self.assertIn(
Monty Taylor51139a02016-05-24 11:28:10 -05004725 '- docs-draft-test2 finger://{hostname}/{uuid}'.format(
4726 hostname=self.executor_server.hostname,
Monty Taylorde8242c2017-02-23 20:29:53 -06004727 uuid=uuid_test2),
Adam Gandelman94a60062016-11-21 16:43:14 -08004728 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08004729
4730
Adam Gandelman4da00f62016-12-09 15:47:33 -08004731class TestSchedulerMerges(ZuulTestCase):
4732 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08004733
4734 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04004735 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08004736 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04004737 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08004738 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
4739 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
4740 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
4741 A.addApproval('code-review', 2)
4742 B.addApproval('code-review', 2)
4743 C.addApproval('code-review', 2)
4744 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4745 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4746 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4747 self.waitUntilSettled()
4748
4749 build = self.builds[-1]
James E. Blair2a535672017-04-27 12:03:15 -07004750 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4751 project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08004752 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07004753 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman8bd57102016-12-02 12:58:42 -08004754 repo_messages.reverse()
4755
Paul Belanger174a8272017-03-14 13:20:10 -04004756 self.executor_server.hold_jobs_in_build = False
4757 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08004758 self.waitUntilSettled()
4759
4760 return repo_messages
4761
4762 def _test_merge(self, mode):
4763 us_path = os.path.join(
4764 self.upstream_root, 'org/project-%s' % mode)
4765 expected_messages = [
4766 'initial commit',
4767 'add content from fixture',
4768 # the intermediate commits order is nondeterministic
4769 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
4770 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
4771 ]
4772 result = self._test_project_merge_mode(mode)
4773 self.assertEqual(result[:2], expected_messages[:2])
4774 self.assertEqual(result[-2:], expected_messages[-2:])
4775
4776 def test_project_merge_mode_merge(self):
4777 self._test_merge('merge')
4778
4779 def test_project_merge_mode_merge_resolve(self):
4780 self._test_merge('merge-resolve')
4781
4782 def test_project_merge_mode_cherrypick(self):
4783 expected_messages = [
4784 'initial commit',
4785 'add content from fixture',
4786 'A-1',
4787 'B-1',
4788 'C-1']
4789 result = self._test_project_merge_mode('cherry-pick')
4790 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08004791
4792 def test_merge_branch(self):
4793 "Test that the right commits are on alternate branches"
4794 self.create_branch('org/project-merge-branches', 'mp')
4795
Paul Belanger174a8272017-03-14 13:20:10 -04004796 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004797 A = self.fake_gerrit.addFakeChange(
4798 'org/project-merge-branches', 'mp', 'A')
4799 B = self.fake_gerrit.addFakeChange(
4800 'org/project-merge-branches', 'mp', 'B')
4801 C = self.fake_gerrit.addFakeChange(
4802 'org/project-merge-branches', 'mp', 'C')
4803 A.addApproval('code-review', 2)
4804 B.addApproval('code-review', 2)
4805 C.addApproval('code-review', 2)
4806 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4807 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4808 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4809 self.waitUntilSettled()
4810
Paul Belanger174a8272017-03-14 13:20:10 -04004811 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004812 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004813 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004814 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004815 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004816 self.waitUntilSettled()
4817
4818 build = self.builds[-1]
James E. Blair3b222492017-07-21 15:17:37 -07004819 self.assertEqual(build.parameters['zuul']['branch'], 'mp')
James E. Blair2a535672017-04-27 12:03:15 -07004820 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4821 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004822 repo = git.Repo(path)
4823
James E. Blair247cab72017-07-20 16:52:36 -07004824 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08004825 repo_messages.reverse()
4826 correct_messages = [
4827 'initial commit',
4828 'add content from fixture',
4829 'mp commit',
4830 'A-1', 'B-1', 'C-1']
4831 self.assertEqual(repo_messages, correct_messages)
4832
Paul Belanger174a8272017-03-14 13:20:10 -04004833 self.executor_server.hold_jobs_in_build = False
4834 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004835 self.waitUntilSettled()
4836
4837 def test_merge_multi_branch(self):
4838 "Test that dependent changes on multiple branches are merged"
4839 self.create_branch('org/project-merge-branches', 'mp')
4840
Paul Belanger174a8272017-03-14 13:20:10 -04004841 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004842 A = self.fake_gerrit.addFakeChange(
4843 'org/project-merge-branches', 'master', 'A')
4844 B = self.fake_gerrit.addFakeChange(
4845 'org/project-merge-branches', 'mp', 'B')
4846 C = self.fake_gerrit.addFakeChange(
4847 'org/project-merge-branches', 'master', 'C')
4848 A.addApproval('code-review', 2)
4849 B.addApproval('code-review', 2)
4850 C.addApproval('code-review', 2)
4851 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4852 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4853 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4854 self.waitUntilSettled()
4855
4856 job_A = None
4857 for job in self.builds:
4858 if 'project-merge' in job.name:
4859 job_A = job
Adam Gandelman4da00f62016-12-09 15:47:33 -08004860
James E. Blair2a535672017-04-27 12:03:15 -07004861 path = os.path.join(job_A.jobdir.src_root, 'review.example.com',
4862 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004863 repo = git.Repo(path)
4864 repo_messages = [c.message.strip()
James E. Blair247cab72017-07-20 16:52:36 -07004865 for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08004866 repo_messages.reverse()
4867 correct_messages = [
4868 'initial commit', 'add content from fixture', 'A-1']
4869 self.assertEqual(repo_messages, correct_messages)
4870
Paul Belanger174a8272017-03-14 13:20:10 -04004871 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004872 self.waitUntilSettled()
4873
4874 job_B = None
4875 for job in self.builds:
4876 if 'project-merge' in job.name:
4877 job_B = job
Adam Gandelman4da00f62016-12-09 15:47:33 -08004878
James E. Blair2a535672017-04-27 12:03:15 -07004879 path = os.path.join(job_B.jobdir.src_root, 'review.example.com',
4880 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004881 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07004882 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08004883 repo_messages.reverse()
4884 correct_messages = [
4885 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
4886 self.assertEqual(repo_messages, correct_messages)
4887
Paul Belanger174a8272017-03-14 13:20:10 -04004888 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004889 self.waitUntilSettled()
4890
4891 job_C = None
4892 for job in self.builds:
4893 if 'project-merge' in job.name:
4894 job_C = job
James E. Blairb1345832017-07-21 14:51:35 -07004895
James E. Blair2a535672017-04-27 12:03:15 -07004896 path = os.path.join(job_C.jobdir.src_root, 'review.example.com',
4897 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004898 repo = git.Repo(path)
James E. Blair247cab72017-07-20 16:52:36 -07004899 repo_messages = [c.message.strip() for c in repo.iter_commits()]
Adam Gandelman4da00f62016-12-09 15:47:33 -08004900
4901 repo_messages.reverse()
4902 correct_messages = [
4903 'initial commit', 'add content from fixture',
4904 'A-1', 'C-1']
4905 # Ensure the right commits are in the history for this ref
4906 self.assertEqual(repo_messages, correct_messages)
4907
Paul Belanger174a8272017-03-14 13:20:10 -04004908 self.executor_server.hold_jobs_in_build = False
4909 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004910 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01004911
4912
James E. Blair9ea0d0b2017-04-20 09:27:15 -07004913class TestSemaphore(ZuulTestCase):
4914 tenant_config_file = 'config/semaphore/main.yaml'
4915
4916 def test_semaphore_one(self):
4917 "Test semaphores with max=1 (mutex)"
4918 tenant = self.sched.abide.tenants.get('tenant-one')
4919
4920 self.executor_server.hold_jobs_in_build = True
4921
4922 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4923 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4924 self.assertFalse('test-semaphore' in
4925 tenant.semaphore_handler.semaphores)
4926
4927 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4928 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4929 self.waitUntilSettled()
4930
4931 self.assertEqual(len(self.builds), 3)
4932 self.assertEqual(self.builds[0].name, 'project-test1')
4933 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
4934 self.assertEqual(self.builds[2].name, 'project-test1')
4935
4936 self.executor_server.release('semaphore-one-test1')
4937 self.waitUntilSettled()
4938
4939 self.assertEqual(len(self.builds), 3)
4940 self.assertEqual(self.builds[0].name, 'project-test1')
4941 self.assertEqual(self.builds[1].name, 'project-test1')
4942 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4943 self.assertTrue('test-semaphore' in
4944 tenant.semaphore_handler.semaphores)
4945
4946 self.executor_server.release('semaphore-one-test2')
4947 self.waitUntilSettled()
4948
4949 self.assertEqual(len(self.builds), 3)
4950 self.assertEqual(self.builds[0].name, 'project-test1')
4951 self.assertEqual(self.builds[1].name, 'project-test1')
4952 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
4953 self.assertTrue('test-semaphore' in
4954 tenant.semaphore_handler.semaphores)
4955
4956 self.executor_server.release('semaphore-one-test1')
4957 self.waitUntilSettled()
4958
4959 self.assertEqual(len(self.builds), 3)
4960 self.assertEqual(self.builds[0].name, 'project-test1')
4961 self.assertEqual(self.builds[1].name, 'project-test1')
4962 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4963 self.assertTrue('test-semaphore' in
4964 tenant.semaphore_handler.semaphores)
4965
4966 self.executor_server.release('semaphore-one-test2')
4967 self.waitUntilSettled()
4968
4969 self.assertEqual(len(self.builds), 2)
4970 self.assertEqual(self.builds[0].name, 'project-test1')
4971 self.assertEqual(self.builds[1].name, 'project-test1')
4972 self.assertFalse('test-semaphore' in
4973 tenant.semaphore_handler.semaphores)
4974
4975 self.executor_server.hold_jobs_in_build = False
4976 self.executor_server.release()
4977
4978 self.waitUntilSettled()
4979 self.assertEqual(len(self.builds), 0)
4980
4981 self.assertEqual(A.reported, 1)
4982 self.assertEqual(B.reported, 1)
4983 self.assertFalse('test-semaphore' in
4984 tenant.semaphore_handler.semaphores)
4985
4986 def test_semaphore_two(self):
4987 "Test semaphores with max>1"
4988 tenant = self.sched.abide.tenants.get('tenant-one')
4989
4990 self.executor_server.hold_jobs_in_build = True
4991 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4992 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4993 self.assertFalse('test-semaphore-two' in
4994 tenant.semaphore_handler.semaphores)
4995
4996 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4997 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4998 self.waitUntilSettled()
4999
5000 self.assertEqual(len(self.builds), 4)
5001 self.assertEqual(self.builds[0].name, 'project-test1')
5002 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
5003 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
5004 self.assertEqual(self.builds[3].name, 'project-test1')
5005 self.assertTrue('test-semaphore-two' in
5006 tenant.semaphore_handler.semaphores)
5007 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5008 'test-semaphore-two', [])), 2)
5009
5010 self.executor_server.release('semaphore-two-test1')
5011 self.waitUntilSettled()
5012
5013 self.assertEqual(len(self.builds), 4)
5014 self.assertEqual(self.builds[0].name, 'project-test1')
5015 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
5016 self.assertEqual(self.builds[2].name, 'project-test1')
5017 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
5018 self.assertTrue('test-semaphore-two' in
5019 tenant.semaphore_handler.semaphores)
5020 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5021 'test-semaphore-two', [])), 2)
5022
5023 self.executor_server.release('semaphore-two-test2')
5024 self.waitUntilSettled()
5025
5026 self.assertEqual(len(self.builds), 4)
5027 self.assertEqual(self.builds[0].name, 'project-test1')
5028 self.assertEqual(self.builds[1].name, 'project-test1')
5029 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
5030 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
5031 self.assertTrue('test-semaphore-two' in
5032 tenant.semaphore_handler.semaphores)
5033 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5034 'test-semaphore-two', [])), 2)
5035
5036 self.executor_server.release('semaphore-two-test1')
5037 self.waitUntilSettled()
5038
5039 self.assertEqual(len(self.builds), 3)
5040 self.assertEqual(self.builds[0].name, 'project-test1')
5041 self.assertEqual(self.builds[1].name, 'project-test1')
5042 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
5043 self.assertTrue('test-semaphore-two' in
5044 tenant.semaphore_handler.semaphores)
5045 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5046 'test-semaphore-two', [])), 1)
5047
5048 self.executor_server.release('semaphore-two-test2')
5049 self.waitUntilSettled()
5050
5051 self.assertEqual(len(self.builds), 2)
5052 self.assertEqual(self.builds[0].name, 'project-test1')
5053 self.assertEqual(self.builds[1].name, 'project-test1')
5054 self.assertFalse('test-semaphore-two' in
5055 tenant.semaphore_handler.semaphores)
5056
5057 self.executor_server.hold_jobs_in_build = False
5058 self.executor_server.release()
5059
5060 self.waitUntilSettled()
5061 self.assertEqual(len(self.builds), 0)
5062
5063 self.assertEqual(A.reported, 1)
5064 self.assertEqual(B.reported, 1)
5065
5066 def test_semaphore_abandon(self):
5067 "Test abandon with job semaphores"
5068 self.executor_server.hold_jobs_in_build = True
5069 tenant = self.sched.abide.tenants.get('tenant-one')
5070 check_pipeline = tenant.layout.pipelines['check']
5071
5072 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5073 self.assertFalse('test-semaphore' in
5074 tenant.semaphore_handler.semaphores)
5075
5076 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5077 self.waitUntilSettled()
5078
5079 self.assertTrue('test-semaphore' in
5080 tenant.semaphore_handler.semaphores)
5081
5082 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
5083 self.waitUntilSettled()
5084
5085 # The check pipeline should be empty
5086 items = check_pipeline.getAllItems()
5087 self.assertEqual(len(items), 0)
5088
5089 # The semaphore should be released
5090 self.assertFalse('test-semaphore' in
5091 tenant.semaphore_handler.semaphores)
5092
5093 self.executor_server.hold_jobs_in_build = False
5094 self.executor_server.release()
5095 self.waitUntilSettled()
5096
Tobias Henkel0f714002017-06-30 23:30:52 +02005097 def test_semaphore_new_patchset(self):
5098 "Test new patchset with job semaphores"
5099 self.executor_server.hold_jobs_in_build = True
5100 tenant = self.sched.abide.tenants.get('tenant-one')
5101 check_pipeline = tenant.layout.pipelines['check']
5102
5103 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5104 self.assertFalse('test-semaphore' in
5105 tenant.semaphore_handler.semaphores)
5106
5107 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5108 self.waitUntilSettled()
5109
5110 self.assertTrue('test-semaphore' in
5111 tenant.semaphore_handler.semaphores)
5112 semaphore = tenant.semaphore_handler.semaphores['test-semaphore']
5113 self.assertEqual(len(semaphore), 1)
5114
5115 A.addPatchset()
5116 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
5117 self.waitUntilSettled()
5118
5119 self.assertTrue('test-semaphore' in
5120 tenant.semaphore_handler.semaphores)
5121 semaphore = tenant.semaphore_handler.semaphores['test-semaphore']
5122 self.assertEqual(len(semaphore), 1)
5123
5124 items = check_pipeline.getAllItems()
5125 self.assertEqual(items[0].change.number, '1')
5126 self.assertEqual(items[0].change.patchset, '2')
5127 self.assertTrue(items[0].live)
5128
5129 self.executor_server.hold_jobs_in_build = False
5130 self.executor_server.release()
5131 self.waitUntilSettled()
5132
5133 # The semaphore should be released
5134 self.assertFalse('test-semaphore' in
5135 tenant.semaphore_handler.semaphores)
5136
James E. Blair9ea0d0b2017-04-20 09:27:15 -07005137 def test_semaphore_reconfigure(self):
5138 "Test reconfigure with job semaphores"
5139 self.executor_server.hold_jobs_in_build = True
5140 tenant = self.sched.abide.tenants.get('tenant-one')
5141 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5142 self.assertFalse('test-semaphore' in
5143 tenant.semaphore_handler.semaphores)
5144
5145 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5146 self.waitUntilSettled()
5147
5148 self.assertTrue('test-semaphore' in
5149 tenant.semaphore_handler.semaphores)
5150
5151 # reconfigure without layout change
5152 self.sched.reconfigure(self.config)
5153 self.waitUntilSettled()
5154 tenant = self.sched.abide.tenants.get('tenant-one')
5155
5156 # semaphore still must be held
5157 self.assertTrue('test-semaphore' in
5158 tenant.semaphore_handler.semaphores)
5159
5160 self.commitConfigUpdate(
5161 'common-config',
5162 'config/semaphore/zuul-reconfiguration.yaml')
5163 self.sched.reconfigure(self.config)
5164 self.waitUntilSettled()
5165 tenant = self.sched.abide.tenants.get('tenant-one')
5166
5167 self.executor_server.release('project-test1')
5168 self.waitUntilSettled()
5169
5170 # There should be no builds anymore
5171 self.assertEqual(len(self.builds), 0)
5172
5173 # The semaphore should be released
5174 self.assertFalse('test-semaphore' in
5175 tenant.semaphore_handler.semaphores)
5176
5177
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005178class TestSemaphoreMultiTenant(ZuulTestCase):
5179 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5180
5181 def test_semaphore_tenant_isolation(self):
5182 "Test semaphores in multiple tenants"
5183
5184 self.waitUntilSettled()
5185 tenant_one = self.sched.abide.tenants.get('tenant-one')
5186 tenant_two = self.sched.abide.tenants.get('tenant-two')
5187
5188 self.executor_server.hold_jobs_in_build = True
5189 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5190 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5191 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5192 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5193 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5194 self.assertFalse('test-semaphore' in
5195 tenant_one.semaphore_handler.semaphores)
5196 self.assertFalse('test-semaphore' in
5197 tenant_two.semaphore_handler.semaphores)
5198
5199 # add patches to project1 of tenant-one
5200 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5201 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5202 self.waitUntilSettled()
5203
5204 # one build of project1-test1 must run
5205 # semaphore of tenant-one must be acquired once
5206 # semaphore of tenant-two must not be acquired
5207 self.assertEqual(len(self.builds), 1)
5208 self.assertEqual(self.builds[0].name, 'project1-test1')
5209 self.assertTrue('test-semaphore' in
5210 tenant_one.semaphore_handler.semaphores)
5211 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5212 'test-semaphore', [])), 1)
5213 self.assertFalse('test-semaphore' in
5214 tenant_two.semaphore_handler.semaphores)
5215
5216 # add patches to project2 of tenant-two
5217 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5218 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5219 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5220 self.waitUntilSettled()
5221
5222 # one build of project1-test1 must run
5223 # two builds of project2-test1 must run
5224 # semaphore of tenant-one must be acquired once
5225 # semaphore of tenant-two must be acquired twice
5226 self.assertEqual(len(self.builds), 3)
5227 self.assertEqual(self.builds[0].name, 'project1-test1')
5228 self.assertEqual(self.builds[1].name, 'project2-test1')
5229 self.assertEqual(self.builds[2].name, 'project2-test1')
5230 self.assertTrue('test-semaphore' in
5231 tenant_one.semaphore_handler.semaphores)
5232 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5233 'test-semaphore', [])), 1)
5234 self.assertTrue('test-semaphore' in
5235 tenant_two.semaphore_handler.semaphores)
5236 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5237 'test-semaphore', [])), 2)
5238
5239 self.executor_server.release('project1-test1')
5240 self.waitUntilSettled()
5241
5242 # one build of project1-test1 must run
5243 # two builds of project2-test1 must run
5244 # semaphore of tenant-one must be acquired once
5245 # semaphore of tenant-two must be acquired twice
5246 self.assertEqual(len(self.builds), 3)
5247 self.assertEqual(self.builds[0].name, 'project2-test1')
5248 self.assertEqual(self.builds[1].name, 'project2-test1')
5249 self.assertEqual(self.builds[2].name, 'project1-test1')
5250 self.assertTrue('test-semaphore' in
5251 tenant_one.semaphore_handler.semaphores)
5252 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5253 'test-semaphore', [])), 1)
5254 self.assertTrue('test-semaphore' in
5255 tenant_two.semaphore_handler.semaphores)
5256 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5257 'test-semaphore', [])), 2)
5258
5259 self.executor_server.release('project2-test1')
5260 self.waitUntilSettled()
5261
5262 # one build of project1-test1 must run
5263 # one build of project2-test1 must run
5264 # semaphore of tenant-one must be acquired once
5265 # semaphore of tenant-two must be acquired once
5266 self.assertEqual(len(self.builds), 2)
5267 self.assertTrue('test-semaphore' in
5268 tenant_one.semaphore_handler.semaphores)
5269 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5270 'test-semaphore', [])), 1)
5271 self.assertTrue('test-semaphore' in
5272 tenant_two.semaphore_handler.semaphores)
5273 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5274 'test-semaphore', [])), 1)
5275
5276 self.executor_server.hold_jobs_in_build = False
5277 self.executor_server.release()
5278
5279 self.waitUntilSettled()
5280
5281 # no build must run
5282 # semaphore of tenant-one must not be acquired
5283 # semaphore of tenant-two must not be acquired
5284 self.assertEqual(len(self.builds), 0)
5285 self.assertFalse('test-semaphore' in
5286 tenant_one.semaphore_handler.semaphores)
5287 self.assertFalse('test-semaphore' in
5288 tenant_two.semaphore_handler.semaphores)
5289
5290 self.assertEqual(A.reported, 1)
5291 self.assertEqual(B.reported, 1)
5292
5293
5294class TestSemaphoreInRepo(ZuulTestCase):
5295 tenant_config_file = 'config/in-repo/main.yaml'
5296
5297 def test_semaphore_in_repo(self):
5298 "Test semaphores in repo config"
5299
5300 # This tests dynamic semaphore handling in project repos. The semaphore
5301 # max value should not be evaluated dynamically but must be updated
5302 # after the change lands.
5303
5304 self.waitUntilSettled()
5305 tenant = self.sched.abide.tenants.get('tenant-one')
5306
5307 in_repo_conf = textwrap.dedent(
5308 """
5309 - job:
5310 name: project-test2
5311 semaphore: test-semaphore
5312
5313 - project:
5314 name: org/project
5315 tenant-one-gate:
5316 jobs:
5317 - project-test2
5318
5319 # the max value in dynamic layout must be ignored
5320 - semaphore:
5321 name: test-semaphore
5322 max: 2
5323 """)
5324
5325 in_repo_playbook = textwrap.dedent(
5326 """
5327 - hosts: all
5328 tasks: []
5329 """)
5330
5331 file_dict = {'.zuul.yaml': in_repo_conf,
5332 'playbooks/project-test2.yaml': in_repo_playbook}
5333 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5334 files=file_dict)
5335 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5336 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5337 B.setDependsOn(A, 1)
5338 C.setDependsOn(A, 1)
5339
5340 self.executor_server.hold_jobs_in_build = True
5341
5342 A.addApproval('code-review', 2)
5343 B.addApproval('code-review', 2)
5344 C.addApproval('code-review', 2)
5345 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
5346 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
5347 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
5348 self.waitUntilSettled()
5349
5350 # check that the layout in a queue item still has max value of 1
5351 # for test-semaphore
5352 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5353 queue = None
5354 for queue_candidate in pipeline.queues:
5355 if queue_candidate.name == 'org/project':
5356 queue = queue_candidate
5357 break
5358 queue_item = queue.queue[0]
5359 item_dynamic_layout = queue_item.current_build_set.layout
5360 dynamic_test_semaphore = \
5361 item_dynamic_layout.semaphores.get('test-semaphore')
5362 self.assertEqual(dynamic_test_semaphore.max, 1)
5363
5364 # one build must be in queue, one semaphores acquired
5365 self.assertEqual(len(self.builds), 1)
5366 self.assertEqual(self.builds[0].name, 'project-test2')
5367 self.assertTrue('test-semaphore' in
5368 tenant.semaphore_handler.semaphores)
5369 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5370 'test-semaphore', [])), 1)
5371
5372 self.executor_server.release('project-test2')
5373 self.waitUntilSettled()
5374
5375 # change A must be merged
5376 self.assertEqual(A.data['status'], 'MERGED')
5377 self.assertEqual(A.reported, 2)
5378
5379 # send change-merged event as the gerrit mock doesn't send it
5380 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5381 self.waitUntilSettled()
5382
5383 # now that change A was merged, the new semaphore max must be effective
5384 tenant = self.sched.abide.tenants.get('tenant-one')
5385 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5386
5387 # two builds must be in queue, two semaphores acquired
5388 self.assertEqual(len(self.builds), 2)
5389 self.assertEqual(self.builds[0].name, 'project-test2')
5390 self.assertEqual(self.builds[1].name, 'project-test2')
5391 self.assertTrue('test-semaphore' in
5392 tenant.semaphore_handler.semaphores)
5393 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5394 'test-semaphore', [])), 2)
5395
5396 self.executor_server.release('project-test2')
5397 self.waitUntilSettled()
5398
5399 self.assertEqual(len(self.builds), 0)
5400 self.assertFalse('test-semaphore' in
5401 tenant.semaphore_handler.semaphores)
5402
5403 self.executor_server.hold_jobs_in_build = False
5404 self.executor_server.release()
5405
5406 self.waitUntilSettled()
5407 self.assertEqual(len(self.builds), 0)
5408
5409 self.assertEqual(A.reported, 2)
5410 self.assertEqual(B.reported, 2)
5411 self.assertEqual(C.reported, 2)