blob: 1124beb6df0c97ee978dfc7d3d74b1fe3f182400 [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
Clint Byrum03454a52017-05-26 17:14:02 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Morgan Fainberg293f7f82016-05-30 14:01:22 -070028from six.moves import urllib
Monty Taylorbc758832013-06-17 17:22:42 -040029import testtools
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
Clint Byrumb9de8be2017-05-27 13:49:19 -070032from zuul.driver.gerrit import gerritreporter
James E. Blairb0fcae42012-07-17 11:12:10 -070033import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080034import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040035import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070036
Maru Newby3fe5f852015-01-13 04:22:14 +000037from tests.base import (
Paul Belanger0a21f0a2017-06-13 13:14:42 -040038 SSLZuulTestCase,
Maru Newby3fe5f852015-01-13 04:22:14 +000039 ZuulTestCase,
40 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070041 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000042)
James E. Blairb0fcae42012-07-17 11:12:10 -070043
James E. Blairb0fcae42012-07-17 11:12:10 -070044
Paul Belanger0a21f0a2017-06-13 13:14:42 -040045class TestSchedulerSSL(SSLZuulTestCase):
46 tenant_config_file = 'config/single-tenant/main.yaml'
47
48 def test_jobs_executed(self):
49 "Test that jobs are executed and a change is merged"
50
51 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
52 A.addApproval('code-review', 2)
53 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
54 self.waitUntilSettled()
55 self.assertEqual(self.getJobFromHistory('project-merge').result,
56 'SUCCESS')
57 self.assertEqual(self.getJobFromHistory('project-test1').result,
58 'SUCCESS')
59 self.assertEqual(self.getJobFromHistory('project-test2').result,
60 'SUCCESS')
61 self.assertEqual(A.data['status'], 'MERGED')
62 self.assertEqual(A.reported, 2)
63 self.assertEqual(self.getJobFromHistory('project-test1').node,
64 'label1')
65 self.assertIsNone(self.getJobFromHistory('project-test2').node)
66
67
Clark Boylanb640e052014-04-03 16:41:46 -070068class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070069 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010070
Paul Belanger174a8272017-03-14 13:20:10 -040071 def test_jobs_executed(self):
72 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070073
James E. Blairb0fcae42012-07-17 11:12:10 -070074 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -070075 A.addApproval('code-review', 2)
76 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070077 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040078 self.assertEqual(self.getJobFromHistory('project-merge').result,
79 'SUCCESS')
80 self.assertEqual(self.getJobFromHistory('project-test1').result,
81 'SUCCESS')
82 self.assertEqual(self.getJobFromHistory('project-test2').result,
83 'SUCCESS')
84 self.assertEqual(A.data['status'], 'MERGED')
85 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070086 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -070087 'label1')
Adam Gandelmaneace4692017-02-07 15:18:36 -080088 self.assertIsNone(self.getJobFromHistory('project-test2').node)
James E. Blairb0fcae42012-07-17 11:12:10 -070089
James E. Blair552b54f2016-07-22 13:55:32 -070090 # TODOv3(jeblair): we may want to report stats by tenant (also?).
Monty Taylorf1385042017-05-27 12:25:05 -050091 # Per-driver
92 self.assertReportedStat('zuul.event.gerrit.comment-added', value='1|c')
93 # Per-driver per-connection
94 self.assertReportedStat('zuul.event.gerrit.gerrit.comment-added',
95 value='1|c')
James E. Blair66eeebf2013-07-27 17:44:32 -070096 self.assertReportedStat('zuul.pipeline.gate.current_changes',
97 value='1|g')
98 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
99 kind='ms')
100 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
101 value='1|c')
102 self.assertReportedStat('zuul.pipeline.gate.resident_time', kind='ms')
103 self.assertReportedStat('zuul.pipeline.gate.total_changes',
104 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -0700105 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -0700106 'zuul.pipeline.gate.org.project.resident_time', kind='ms')
James E. Blair412e5582013-04-22 15:50:12 -0700107 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -0700108 'zuul.pipeline.gate.org.project.total_changes', value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -0700109
James E. Blair5821bd92015-09-16 08:48:15 -0700110 for build in self.builds:
111 self.assertEqual(build.parameters['ZUUL_VOTING'], '1')
112
James E. Blair3cb10702013-08-24 08:56:03 -0700113 def test_initial_pipeline_gauges(self):
114 "Test that each pipeline reported its length on start"
James E. Blair7da51b72016-07-25 15:29:43 -0700115 self.assertReportedStat('zuul.pipeline.gate.current_changes',
116 value='0|g')
117 self.assertReportedStat('zuul.pipeline.check.current_changes',
118 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -0700119
James E. Blair34776ee2016-08-25 13:53:54 -0700120 def test_job_branch(self):
121 "Test the correct variant of a job runs on a branch"
122 self.create_branch('org/project', 'stable')
123 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
124 A.addApproval('code-review', 2)
125 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
126 self.waitUntilSettled()
127 self.assertEqual(self.getJobFromHistory('project-test1').result,
128 'SUCCESS')
129 self.assertEqual(self.getJobFromHistory('project-test2').result,
130 'SUCCESS')
131 self.assertEqual(A.data['status'], 'MERGED')
132 self.assertEqual(A.reported, 2,
133 "A should report start and success")
134 self.assertIn('gate', A.messages[1],
135 "A should transit gate")
136 self.assertEqual(self.getJobFromHistory('project-test1').node,
James E. Blair16d96a02017-06-08 11:32:56 -0700137 'label2')
James E. Blair34776ee2016-08-25 13:53:54 -0700138
James E. Blairb0fcae42012-07-17 11:12:10 -0700139 def test_parallel_changes(self):
140 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700141
Paul Belanger174a8272017-03-14 13:20:10 -0400142 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700143 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
144 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
145 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700146 A.addApproval('code-review', 2)
147 B.addApproval('code-review', 2)
148 C.addApproval('code-review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700149
James E. Blair8b5408c2016-08-08 15:37:46 -0700150 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
151 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
152 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700153
154 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400155 self.assertEqual(len(self.builds), 1)
156 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700157 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700158
Paul Belanger174a8272017-03-14 13:20:10 -0400159 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700160 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400161 self.assertEqual(len(self.builds), 3)
162 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700163 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400164 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700165 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400166 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700167 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700168
Paul Belanger174a8272017-03-14 13:20:10 -0400169 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700170 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400171 self.assertEqual(len(self.builds), 5)
172 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700173 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400174 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700175 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700176
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400177 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700178 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400179 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700180 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700181
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400182 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700183 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700184
Paul Belanger174a8272017-03-14 13:20:10 -0400185 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700186 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400187 self.assertEqual(len(self.builds), 6)
188 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700189 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400190 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700191 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700192
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400193 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700194 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400195 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700196 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700197
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400198 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700199 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400200 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700201 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700202
Paul Belanger174a8272017-03-14 13:20:10 -0400203 self.executor_server.hold_jobs_in_build = False
204 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700205 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400206 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700207
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400208 self.assertEqual(len(self.history), 9)
209 self.assertEqual(A.data['status'], 'MERGED')
210 self.assertEqual(B.data['status'], 'MERGED')
211 self.assertEqual(C.data['status'], 'MERGED')
212 self.assertEqual(A.reported, 2)
213 self.assertEqual(B.reported, 2)
214 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700215
216 def test_failed_changes(self):
217 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400218 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700219
James E. Blairb02a3bb2012-07-30 17:49:55 -0700220 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
221 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -0700222 A.addApproval('code-review', 2)
223 B.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700224
Paul Belanger174a8272017-03-14 13:20:10 -0400225 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700226
James E. Blair8b5408c2016-08-08 15:37:46 -0700227 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
228 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700229 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700230 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400231
Paul Belanger174a8272017-03-14 13:20:10 -0400232 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400233 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700234 # A/project-merge is complete
235 self.assertBuilds([
236 dict(name='project-test1', changes='1,1'),
237 dict(name='project-test2', changes='1,1'),
238 dict(name='project-merge', changes='1,1 2,1'),
239 ])
James E. Blaire2819012013-06-28 17:17:26 -0400240
Paul Belanger174a8272017-03-14 13:20:10 -0400241 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400242 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700243 # A/project-merge is complete
244 # B/project-merge is complete
245 self.assertBuilds([
246 dict(name='project-test1', changes='1,1'),
247 dict(name='project-test2', changes='1,1'),
248 dict(name='project-test1', changes='1,1 2,1'),
249 dict(name='project-test2', changes='1,1 2,1'),
250 ])
251
252 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400253 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700254 self.builds[0].release()
255 self.waitUntilSettled()
256
257 self.orderedRelease()
258 self.assertHistory([
259 dict(name='project-merge', result='SUCCESS', changes='1,1'),
260 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
261 dict(name='project-test1', result='FAILURE', changes='1,1'),
262 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
263 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
264 dict(name='project-test2', result='SUCCESS', changes='1,1'),
265 dict(name='project-merge', result='SUCCESS', changes='2,1'),
266 dict(name='project-test1', result='SUCCESS', changes='2,1'),
267 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700268 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700269
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400270 self.assertEqual(A.data['status'], 'NEW')
271 self.assertEqual(B.data['status'], 'MERGED')
272 self.assertEqual(A.reported, 2)
273 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700274
275 def test_independent_queues(self):
276 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700277
Paul Belanger174a8272017-03-14 13:20:10 -0400278 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900279 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700280 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
281 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700282 A.addApproval('code-review', 2)
283 B.addApproval('code-review', 2)
284 C.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700285
James E. Blair8b5408c2016-08-08 15:37:46 -0700286 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800287 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700288
James E. Blairf59f3cf2017-02-19 14:50:26 -0800289 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
290 self.waitUntilSettled()
291
292 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700293 self.waitUntilSettled()
294
295 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700296 self.assertBuilds([
297 dict(name='project-merge', changes='1,1'),
298 dict(name='project-merge', changes='2,1'),
299 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700300
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700301 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700302 self.builds[0].release()
303 self.waitUntilSettled()
304 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700305 self.waitUntilSettled()
306 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400307 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700308 self.waitUntilSettled()
309
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700310 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700311 self.assertBuilds([
312 dict(name='project-test1', changes='1,1'),
313 dict(name='project-test2', changes='1,1'),
314 dict(name='project-test1', changes='2,1'),
315 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500316 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700317 dict(name='project-test1', changes='2,1 3,1'),
318 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800319 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700320 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700321
James E. Blair5f0d49e2016-08-19 09:36:50 -0700322 self.orderedRelease()
323 self.assertHistory([
324 dict(name='project-merge', result='SUCCESS', changes='1,1'),
325 dict(name='project-merge', result='SUCCESS', changes='2,1'),
326 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
327 dict(name='project-test1', result='SUCCESS', changes='1,1'),
328 dict(name='project-test2', result='SUCCESS', changes='1,1'),
329 dict(name='project-test1', result='SUCCESS', changes='2,1'),
330 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500331 dict(
332 name='project1-project2-integration',
333 result='SUCCESS',
334 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700335 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
336 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800337 dict(name='project1-project2-integration',
338 result='SUCCESS',
339 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700340 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700341
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400342 self.assertEqual(A.data['status'], 'MERGED')
343 self.assertEqual(B.data['status'], 'MERGED')
344 self.assertEqual(C.data['status'], 'MERGED')
345 self.assertEqual(A.reported, 2)
346 self.assertEqual(B.reported, 2)
347 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700348
349 def test_failed_change_at_head(self):
350 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700351
Paul Belanger174a8272017-03-14 13:20:10 -0400352 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700353 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
354 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
355 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700356 A.addApproval('code-review', 2)
357 B.addApproval('code-review', 2)
358 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700359
Paul Belanger174a8272017-03-14 13:20:10 -0400360 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700361
James E. Blair8b5408c2016-08-08 15:37:46 -0700362 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
363 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
364 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700365
366 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700367
James E. Blairb536ecc2016-08-31 10:11:42 -0700368 self.assertBuilds([
369 dict(name='project-merge', changes='1,1'),
370 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700371
Paul Belanger174a8272017-03-14 13:20:10 -0400372 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700373 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400374 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700375 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400376 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700377 self.waitUntilSettled()
378
James E. Blairb536ecc2016-08-31 10:11:42 -0700379 self.assertBuilds([
380 dict(name='project-test1', changes='1,1'),
381 dict(name='project-test2', changes='1,1'),
382 dict(name='project-test1', changes='1,1 2,1'),
383 dict(name='project-test2', changes='1,1 2,1'),
384 dict(name='project-test1', changes='1,1 2,1 3,1'),
385 dict(name='project-test2', changes='1,1 2,1 3,1'),
386 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700387
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400388 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700389 self.waitUntilSettled()
390
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400391 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700392 self.assertBuilds([
393 dict(name='project-test2', changes='1,1'),
394 dict(name='project-merge', changes='2,1'),
395 ])
396 # Unordered history comparison because the aborts can finish
397 # in any order.
398 self.assertHistory([
399 dict(name='project-merge', result='SUCCESS',
400 changes='1,1'),
401 dict(name='project-merge', result='SUCCESS',
402 changes='1,1 2,1'),
403 dict(name='project-merge', result='SUCCESS',
404 changes='1,1 2,1 3,1'),
405 dict(name='project-test1', result='FAILURE',
406 changes='1,1'),
407 dict(name='project-test1', result='ABORTED',
408 changes='1,1 2,1'),
409 dict(name='project-test2', result='ABORTED',
410 changes='1,1 2,1'),
411 dict(name='project-test1', result='ABORTED',
412 changes='1,1 2,1 3,1'),
413 dict(name='project-test2', result='ABORTED',
414 changes='1,1 2,1 3,1'),
415 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700416
Paul Belanger174a8272017-03-14 13:20:10 -0400417 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700418 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400419 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700420 self.waitUntilSettled()
421 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700422
James E. Blairb536ecc2016-08-31 10:11:42 -0700423 self.assertBuilds([])
424 self.assertHistory([
425 dict(name='project-merge', result='SUCCESS',
426 changes='1,1'),
427 dict(name='project-merge', result='SUCCESS',
428 changes='1,1 2,1'),
429 dict(name='project-merge', result='SUCCESS',
430 changes='1,1 2,1 3,1'),
431 dict(name='project-test1', result='FAILURE',
432 changes='1,1'),
433 dict(name='project-test1', result='ABORTED',
434 changes='1,1 2,1'),
435 dict(name='project-test2', result='ABORTED',
436 changes='1,1 2,1'),
437 dict(name='project-test1', result='ABORTED',
438 changes='1,1 2,1 3,1'),
439 dict(name='project-test2', result='ABORTED',
440 changes='1,1 2,1 3,1'),
441 dict(name='project-merge', result='SUCCESS',
442 changes='2,1'),
443 dict(name='project-merge', result='SUCCESS',
444 changes='2,1 3,1'),
445 dict(name='project-test2', result='SUCCESS',
446 changes='1,1'),
447 dict(name='project-test1', result='SUCCESS',
448 changes='2,1'),
449 dict(name='project-test2', result='SUCCESS',
450 changes='2,1'),
451 dict(name='project-test1', result='SUCCESS',
452 changes='2,1 3,1'),
453 dict(name='project-test2', result='SUCCESS',
454 changes='2,1 3,1'),
455 ], ordered=False)
456
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400457 self.assertEqual(A.data['status'], 'NEW')
458 self.assertEqual(B.data['status'], 'MERGED')
459 self.assertEqual(C.data['status'], 'MERGED')
460 self.assertEqual(A.reported, 2)
461 self.assertEqual(B.reported, 2)
462 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700463
James E. Blair0aac4872013-08-23 14:02:38 -0700464 def test_failed_change_in_middle(self):
465 "Test a failed change in the middle of the queue"
466
Paul Belanger174a8272017-03-14 13:20:10 -0400467 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700468 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
469 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
470 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700471 A.addApproval('code-review', 2)
472 B.addApproval('code-review', 2)
473 C.addApproval('code-review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700474
Paul Belanger174a8272017-03-14 13:20:10 -0400475 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700476
James E. Blair8b5408c2016-08-08 15:37:46 -0700477 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
478 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
479 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700480
481 self.waitUntilSettled()
482
Paul Belanger174a8272017-03-14 13:20:10 -0400483 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700484 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400485 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700486 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400487 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700488 self.waitUntilSettled()
489
490 self.assertEqual(len(self.builds), 6)
491 self.assertEqual(self.builds[0].name, 'project-test1')
492 self.assertEqual(self.builds[1].name, 'project-test2')
493 self.assertEqual(self.builds[2].name, 'project-test1')
494 self.assertEqual(self.builds[3].name, 'project-test2')
495 self.assertEqual(self.builds[4].name, 'project-test1')
496 self.assertEqual(self.builds[5].name, 'project-test2')
497
498 self.release(self.builds[2])
499 self.waitUntilSettled()
500
James E. Blair972e3c72013-08-29 12:04:55 -0700501 # project-test1 and project-test2 for A
502 # project-test2 for B
503 # project-merge for C (without B)
504 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700505 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
506
Paul Belanger174a8272017-03-14 13:20:10 -0400507 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700508 self.waitUntilSettled()
509
510 # project-test1 and project-test2 for A
511 # project-test2 for B
512 # project-test1 and project-test2 for C
513 self.assertEqual(len(self.builds), 5)
514
Paul Belanger2e2a0492016-10-30 18:33:37 -0400515 tenant = self.sched.abide.tenants.get('tenant-one')
516 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700517 builds = items[0].current_build_set.getBuilds()
518 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
519 self.assertEqual(self.countJobResults(builds, None), 2)
520 builds = items[1].current_build_set.getBuilds()
521 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
522 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
523 self.assertEqual(self.countJobResults(builds, None), 1)
524 builds = items[2].current_build_set.getBuilds()
525 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700526 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700527
Paul Belanger174a8272017-03-14 13:20:10 -0400528 self.executor_server.hold_jobs_in_build = False
529 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700530 self.waitUntilSettled()
531
532 self.assertEqual(len(self.builds), 0)
533 self.assertEqual(len(self.history), 12)
534 self.assertEqual(A.data['status'], 'MERGED')
535 self.assertEqual(B.data['status'], 'NEW')
536 self.assertEqual(C.data['status'], 'MERGED')
537 self.assertEqual(A.reported, 2)
538 self.assertEqual(B.reported, 2)
539 self.assertEqual(C.reported, 2)
540
James E. Blaird466dc42012-07-31 10:42:56 -0700541 def test_failed_change_at_head_with_queue(self):
542 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700543
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700544 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700545 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
546 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
547 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700548 A.addApproval('code-review', 2)
549 B.addApproval('code-review', 2)
550 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700551
Paul Belanger174a8272017-03-14 13:20:10 -0400552 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700553
James E. Blair8b5408c2016-08-08 15:37:46 -0700554 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
555 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
556 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700557
558 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700559 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400560 self.assertEqual(len(self.builds), 0)
561 self.assertEqual(len(queue), 1)
Clint Byrumf322fe22017-05-10 20:53:12 -0700562 self.assertEqual(queue[0].name, b'executor:execute')
563 job_args = json.loads(queue[0].arguments.decode('utf8'))
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800564 self.assertEqual(job_args['job'], 'project-merge')
565 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700566
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700567 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700568 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700569 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700570 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700571 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700572 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700573 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700574
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400575 self.assertEqual(len(self.builds), 0)
576 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800577
578 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700579 json.loads(queue[0].arguments.decode('utf8'))['job'],
580 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800581 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700582 json.loads(queue[1].arguments.decode('utf8'))['job'],
583 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800584 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700585 json.loads(queue[2].arguments.decode('utf8'))['job'],
586 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800587 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700588 json.loads(queue[3].arguments.decode('utf8'))['job'],
589 'project-test2')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800590 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700591 json.loads(queue[4].arguments.decode('utf8'))['job'],
592 'project-test1')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800593 self.assertEqual(
Clint Byrumf322fe22017-05-10 20:53:12 -0700594 json.loads(queue[5].arguments.decode('utf8'))['job'],
595 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700596
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700597 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700598 self.waitUntilSettled()
599
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400600 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700601 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400602 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
603 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700604
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700605 self.gearman_server.hold_jobs_in_queue = False
606 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700607 self.waitUntilSettled()
608
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400609 self.assertEqual(len(self.builds), 0)
610 self.assertEqual(len(self.history), 11)
611 self.assertEqual(A.data['status'], 'NEW')
612 self.assertEqual(B.data['status'], 'MERGED')
613 self.assertEqual(C.data['status'], 'MERGED')
614 self.assertEqual(A.reported, 2)
615 self.assertEqual(B.reported, 2)
616 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700617
James E. Blairec056492016-07-22 09:45:56 -0700618 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700619 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400620 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700621 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -0700622 A.addApproval('code-review', 2)
623 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700624 self.waitUntilSettled()
625 time.sleep(2)
626
627 data = json.loads(self.sched.formatStatusJSON())
628 found_job = None
629 for pipeline in data['pipelines']:
630 if pipeline['name'] != 'gate':
631 continue
632 for queue in pipeline['change_queues']:
633 for head in queue['heads']:
634 for item in head:
635 for job in item['jobs']:
636 if job['name'] == 'project-merge':
637 found_job = job
638 break
639
640 self.assertIsNotNone(found_job)
641 if iteration == 1:
642 self.assertIsNotNone(found_job['estimated_time'])
643 self.assertIsNone(found_job['remaining_time'])
644 else:
645 self.assertIsNotNone(found_job['estimated_time'])
646 self.assertTrue(found_job['estimated_time'] >= 2)
647 self.assertIsNotNone(found_job['remaining_time'])
648
Paul Belanger174a8272017-03-14 13:20:10 -0400649 self.executor_server.hold_jobs_in_build = False
650 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700651 self.waitUntilSettled()
652
James E. Blairec056492016-07-22 09:45:56 -0700653 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700654 def test_time_database(self):
655 "Test the time database"
656
657 self._test_time_database(1)
658 self._test_time_database(2)
659
James E. Blairfef71632013-09-23 11:15:47 -0700660 def test_two_failed_changes_at_head(self):
661 "Test that changes are reparented correctly if 2 fail at head"
662
Paul Belanger174a8272017-03-14 13:20:10 -0400663 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700664 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
665 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
666 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700667 A.addApproval('code-review', 2)
668 B.addApproval('code-review', 2)
669 C.addApproval('code-review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700670
Paul Belanger174a8272017-03-14 13:20:10 -0400671 self.executor_server.failJob('project-test1', A)
672 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700673
James E. Blair8b5408c2016-08-08 15:37:46 -0700674 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
675 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
676 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700677 self.waitUntilSettled()
678
Paul Belanger174a8272017-03-14 13:20:10 -0400679 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700680 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400681 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700682 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400683 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700684 self.waitUntilSettled()
685
686 self.assertEqual(len(self.builds), 6)
687 self.assertEqual(self.builds[0].name, 'project-test1')
688 self.assertEqual(self.builds[1].name, 'project-test2')
689 self.assertEqual(self.builds[2].name, 'project-test1')
690 self.assertEqual(self.builds[3].name, 'project-test2')
691 self.assertEqual(self.builds[4].name, 'project-test1')
692 self.assertEqual(self.builds[5].name, 'project-test2')
693
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400694 self.assertTrue(self.builds[0].hasChanges(A))
695 self.assertTrue(self.builds[2].hasChanges(A))
696 self.assertTrue(self.builds[2].hasChanges(B))
697 self.assertTrue(self.builds[4].hasChanges(A))
698 self.assertTrue(self.builds[4].hasChanges(B))
699 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700700
701 # Fail change B first
702 self.release(self.builds[2])
703 self.waitUntilSettled()
704
705 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400706 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700707 self.waitUntilSettled()
708
709 self.assertEqual(len(self.builds), 5)
710 self.assertEqual(self.builds[0].name, 'project-test1')
711 self.assertEqual(self.builds[1].name, 'project-test2')
712 self.assertEqual(self.builds[2].name, 'project-test2')
713 self.assertEqual(self.builds[3].name, 'project-test1')
714 self.assertEqual(self.builds[4].name, 'project-test2')
715
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400716 self.assertTrue(self.builds[1].hasChanges(A))
717 self.assertTrue(self.builds[2].hasChanges(A))
718 self.assertTrue(self.builds[2].hasChanges(B))
719 self.assertTrue(self.builds[4].hasChanges(A))
720 self.assertFalse(self.builds[4].hasChanges(B))
721 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700722
723 # Finish running all passing jobs for change A
724 self.release(self.builds[1])
725 self.waitUntilSettled()
726 # Fail and report change A
727 self.release(self.builds[0])
728 self.waitUntilSettled()
729
730 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400731 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700732 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400733 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700734 self.waitUntilSettled()
735
736 self.assertEqual(len(self.builds), 4)
737 self.assertEqual(self.builds[0].name, 'project-test1') # B
738 self.assertEqual(self.builds[1].name, 'project-test2') # B
739 self.assertEqual(self.builds[2].name, 'project-test1') # C
740 self.assertEqual(self.builds[3].name, 'project-test2') # C
741
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400742 self.assertFalse(self.builds[1].hasChanges(A))
743 self.assertTrue(self.builds[1].hasChanges(B))
744 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700745
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400746 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700747 # After A failed and B and C restarted, B should be back in
748 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400749 self.assertTrue(self.builds[2].hasChanges(B))
750 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700751
Paul Belanger174a8272017-03-14 13:20:10 -0400752 self.executor_server.hold_jobs_in_build = False
753 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700754 self.waitUntilSettled()
755
756 self.assertEqual(len(self.builds), 0)
757 self.assertEqual(len(self.history), 21)
758 self.assertEqual(A.data['status'], 'NEW')
759 self.assertEqual(B.data['status'], 'NEW')
760 self.assertEqual(C.data['status'], 'MERGED')
761 self.assertEqual(A.reported, 2)
762 self.assertEqual(B.reported, 2)
763 self.assertEqual(C.reported, 2)
764
James E. Blair8c803f82012-07-31 16:25:42 -0700765 def test_patch_order(self):
766 "Test that dependent patches are tested in the right order"
767 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
768 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
769 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700770 A.addApproval('code-review', 2)
771 B.addApproval('code-review', 2)
772 C.addApproval('code-review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700773
774 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
775 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
776 M2.setMerged()
777 M1.setMerged()
778
779 # C -> B -> A -> M1 -> M2
780 # M2 is here to make sure it is never queried. If it is, it
781 # means zuul is walking down the entire history of merged
782 # changes.
783
784 C.setDependsOn(B, 1)
785 B.setDependsOn(A, 1)
786 A.setDependsOn(M1, 1)
787 M1.setDependsOn(M2, 1)
788
James E. Blair8b5408c2016-08-08 15:37:46 -0700789 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700790
791 self.waitUntilSettled()
792
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400793 self.assertEqual(A.data['status'], 'NEW')
794 self.assertEqual(B.data['status'], 'NEW')
795 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700796
James E. Blair8b5408c2016-08-08 15:37:46 -0700797 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
798 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700799
800 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400801 self.assertEqual(M2.queried, 0)
802 self.assertEqual(A.data['status'], 'MERGED')
803 self.assertEqual(B.data['status'], 'MERGED')
804 self.assertEqual(C.data['status'], 'MERGED')
805 self.assertEqual(A.reported, 2)
806 self.assertEqual(B.reported, 2)
807 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700808
James E. Blair063672f2015-01-29 13:09:12 -0800809 def test_needed_changes_enqueue(self):
810 "Test that a needed change is enqueued ahead"
811 # A Given a git tree like this, if we enqueue
812 # / \ change C, we should walk up and down the tree
813 # B G and enqueue changes in the order ABCDEFG.
814 # /|\ This is also the order that you would get if
815 # *C E F you enqueued changes in the order ABCDEFG, so
816 # / the ordering is stable across re-enqueue events.
817 # D
818
819 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
820 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
821 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
822 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
823 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
824 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
825 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
826 B.setDependsOn(A, 1)
827 C.setDependsOn(B, 1)
828 D.setDependsOn(C, 1)
829 E.setDependsOn(B, 1)
830 F.setDependsOn(B, 1)
831 G.setDependsOn(A, 1)
832
James E. Blair8b5408c2016-08-08 15:37:46 -0700833 A.addApproval('code-review', 2)
834 B.addApproval('code-review', 2)
835 C.addApproval('code-review', 2)
836 D.addApproval('code-review', 2)
837 E.addApproval('code-review', 2)
838 F.addApproval('code-review', 2)
839 G.addApproval('code-review', 2)
840 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800841
842 self.waitUntilSettled()
843
844 self.assertEqual(A.data['status'], 'NEW')
845 self.assertEqual(B.data['status'], 'NEW')
846 self.assertEqual(C.data['status'], 'NEW')
847 self.assertEqual(D.data['status'], 'NEW')
848 self.assertEqual(E.data['status'], 'NEW')
849 self.assertEqual(F.data['status'], 'NEW')
850 self.assertEqual(G.data['status'], 'NEW')
851
852 # We're about to add approvals to changes without adding the
853 # triggering events to Zuul, so that we can be sure that it is
854 # enqueing the changes based on dependencies, not because of
855 # triggering events. Since it will have the changes cached
856 # already (without approvals), we need to clear the cache
857 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400858 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +1100859 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800860
Paul Belanger174a8272017-03-14 13:20:10 -0400861 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -0700862 A.addApproval('approved', 1)
863 B.addApproval('approved', 1)
864 D.addApproval('approved', 1)
865 E.addApproval('approved', 1)
866 F.addApproval('approved', 1)
867 G.addApproval('approved', 1)
868 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800869
870 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400871 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800872 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400873 self.executor_server.hold_jobs_in_build = False
874 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800875 self.waitUntilSettled()
876
877 self.assertEqual(A.data['status'], 'MERGED')
878 self.assertEqual(B.data['status'], 'MERGED')
879 self.assertEqual(C.data['status'], 'MERGED')
880 self.assertEqual(D.data['status'], 'MERGED')
881 self.assertEqual(E.data['status'], 'MERGED')
882 self.assertEqual(F.data['status'], 'MERGED')
883 self.assertEqual(G.data['status'], 'MERGED')
884 self.assertEqual(A.reported, 2)
885 self.assertEqual(B.reported, 2)
886 self.assertEqual(C.reported, 2)
887 self.assertEqual(D.reported, 2)
888 self.assertEqual(E.reported, 2)
889 self.assertEqual(F.reported, 2)
890 self.assertEqual(G.reported, 2)
891 self.assertEqual(self.history[6].changes,
892 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
893
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100894 def test_source_cache(self):
895 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400896 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700897
898 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
899 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
900 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
James E. Blair8b5408c2016-08-08 15:37:46 -0700901 A.addApproval('code-review', 2)
902 B.addApproval('code-review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700903
904 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
905 M1.setMerged()
906
907 B.setDependsOn(A, 1)
908 A.setDependsOn(M1, 1)
909
James E. Blair8b5408c2016-08-08 15:37:46 -0700910 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700911 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
912
913 self.waitUntilSettled()
914
915 for build in self.builds:
916 if build.parameters['ZUUL_PIPELINE'] == 'check':
917 build.release()
918 self.waitUntilSettled()
919 for build in self.builds:
920 if build.parameters['ZUUL_PIPELINE'] == 'check':
921 build.release()
922 self.waitUntilSettled()
923
James E. Blair8b5408c2016-08-08 15:37:46 -0700924 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700925 self.waitUntilSettled()
926
Joshua Hesketh352264b2015-08-11 23:42:08 +1000927 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700928 # there should still be changes in the cache
Joshua Hesketh352264b2015-08-11 23:42:08 +1000929 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700930
Paul Belanger174a8272017-03-14 13:20:10 -0400931 self.executor_server.hold_jobs_in_build = False
932 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700933 self.waitUntilSettled()
934
935 self.assertEqual(A.data['status'], 'MERGED')
936 self.assertEqual(B.data['status'], 'MERGED')
937 self.assertEqual(A.queried, 2) # Initial and isMerged
938 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
939
James E. Blair8c803f82012-07-31 16:25:42 -0700940 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700941 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700942 # TODO: move to test_gerrit (this is a unit test!)
943 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400944 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700945 (trusted, project) = tenant.getProject('org/project')
946 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400947
948 # TODO(pabelanger): As we add more source / trigger APIs we should make
949 # it easier for users to create events for testing.
950 event = zuul.model.TriggerEvent()
951 event.trigger_name = 'gerrit'
952 event.change_number = '1'
953 event.patch_number = '2'
954
955 a = source.getChange(event)
956 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700957 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700958
James E. Blair8b5408c2016-08-08 15:37:46 -0700959 A.addApproval('code-review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400960 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700961 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700962
James E. Blair8b5408c2016-08-08 15:37:46 -0700963 A.addApproval('approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400964 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700965 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700966
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700967 def test_project_merge_conflict(self):
968 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700969
970 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700971 A = self.fake_gerrit.addFakeChange('org/project',
972 'master', 'A',
973 files={'conflict': 'foo'})
974 B = self.fake_gerrit.addFakeChange('org/project',
975 'master', 'B',
976 files={'conflict': 'bar'})
977 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -0700978 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700979 A.addApproval('code-review', 2)
980 B.addApproval('code-review', 2)
981 C.addApproval('code-review', 2)
982 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
983 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
984 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -0700985 self.waitUntilSettled()
986
James E. Blair6736beb2013-07-11 15:18:15 -0700987 self.assertEqual(A.reported, 1)
James E. Blair6736beb2013-07-11 15:18:15 -0700988 self.assertEqual(C.reported, 1)
989
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700990 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700991 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700992 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700993 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700994 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700995 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -0700996
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700997 self.gearman_server.hold_jobs_in_queue = False
998 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -0700999 self.waitUntilSettled()
1000
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001001 self.assertEqual(A.data['status'], 'MERGED')
1002 self.assertEqual(B.data['status'], 'NEW')
1003 self.assertEqual(C.data['status'], 'MERGED')
1004 self.assertEqual(A.reported, 2)
Tobias Henkel9842bd72017-05-16 13:40:03 +02001005 self.assertIn('Merge Failed', B.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001006 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001007
1008 self.assertHistory([
1009 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1010 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1011 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1012 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
1013 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
1014 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
1015 ], ordered=False)
1016
1017 def test_delayed_merge_conflict(self):
1018 "Test that delayed check merge conflicts are handled properly"
1019
1020 # Hold jobs in the gearman queue so that we can test whether
James E. Blair1960d682017-04-28 15:44:14 -07001021 # the executor sucesfully merges a change based on an old
1022 # repo state (frozen by the scheduler) which would otherwise
1023 # conflict.
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001024 self.gearman_server.hold_jobs_in_queue = True
1025 A = self.fake_gerrit.addFakeChange('org/project',
1026 'master', 'A',
1027 files={'conflict': 'foo'})
1028 B = self.fake_gerrit.addFakeChange('org/project',
1029 'master', 'B',
1030 files={'conflict': 'bar'})
1031 C = self.fake_gerrit.addFakeChange('org/project',
1032 'master', 'C')
1033 C.setDependsOn(B, 1)
1034
1035 # A enters the gate queue; B and C enter the check queue
1036 A.addApproval('code-review', 2)
1037 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1038 self.waitUntilSettled()
1039 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
James E. Blair8d144dc2017-05-05 10:13:45 -07001040 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001041 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1042 self.waitUntilSettled()
1043
1044 self.assertEqual(A.reported, 1)
1045 self.assertEqual(B.reported, 0) # Check does not report start
1046 self.assertEqual(C.reported, 0) # Check does not report start
1047
1048 # A merges while B and C are queued in check
1049 # Release A project-merge
1050 queue = self.gearman_server.getQueue()
1051 self.release(queue[0])
1052 self.waitUntilSettled()
1053
1054 # Release A project-test*
1055 # gate has higher precedence, so A's test jobs are added in
1056 # front of the merge jobs for B and C
1057 queue = self.gearman_server.getQueue()
1058 self.release(queue[0])
1059 self.release(queue[1])
1060 self.waitUntilSettled()
1061
1062 self.assertEqual(A.data['status'], 'MERGED')
1063 self.assertEqual(B.data['status'], 'NEW')
1064 self.assertEqual(C.data['status'], 'NEW')
1065 self.assertEqual(A.reported, 2)
1066 self.assertEqual(B.reported, 0)
1067 self.assertEqual(C.reported, 0)
1068 self.assertHistory([
1069 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1070 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1071 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1072 ], ordered=False)
1073
1074 # B and C report merge conflicts
1075 # Release B project-merge
1076 queue = self.gearman_server.getQueue()
1077 self.release(queue[0])
1078 self.waitUntilSettled()
1079
1080 # Release C
1081 self.gearman_server.hold_jobs_in_queue = False
1082 self.gearman_server.release()
1083 self.waitUntilSettled()
1084
1085 self.assertEqual(A.data['status'], 'MERGED')
1086 self.assertEqual(B.data['status'], 'NEW')
1087 self.assertEqual(C.data['status'], 'NEW')
1088 self.assertEqual(A.reported, 2)
1089 self.assertEqual(B.reported, 1)
1090 self.assertEqual(C.reported, 1)
1091
1092 self.assertHistory([
1093 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1094 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1095 dict(name='project-test2', result='SUCCESS', changes='1,1'),
James E. Blair1960d682017-04-28 15:44:14 -07001096 dict(name='project-merge', result='SUCCESS', changes='2,1'),
1097 dict(name='project-test1', result='SUCCESS', changes='2,1'),
1098 dict(name='project-test2', result='SUCCESS', changes='2,1'),
1099 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
1100 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
1101 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -07001102 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001103
James E. Blairdaabed22012-08-15 15:38:57 -07001104 def test_post(self):
1105 "Test that post jobs run"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001106
Zhongyue Luo5d556072012-09-21 02:00:47 +09001107 e = {
1108 "type": "ref-updated",
1109 "submitter": {
1110 "name": "User Name",
1111 },
1112 "refUpdate": {
1113 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1114 "newRev": "d479a0bfcb34da57a31adb2a595c0cf687812543",
1115 "refName": "master",
1116 "project": "org/project",
1117 }
1118 }
James E. Blairdaabed22012-08-15 15:38:57 -07001119 self.fake_gerrit.addEvent(e)
1120 self.waitUntilSettled()
1121
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001122 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001123 self.assertEqual(len(self.history), 1)
1124 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001125
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001126 def test_post_ignore_deletes(self):
1127 "Test that deleting refs does not trigger post jobs"
1128
1129 e = {
1130 "type": "ref-updated",
1131 "submitter": {
1132 "name": "User Name",
1133 },
1134 "refUpdate": {
1135 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1136 "newRev": "0000000000000000000000000000000000000000",
1137 "refName": "master",
1138 "project": "org/project",
1139 }
1140 }
1141 self.fake_gerrit.addEvent(e)
1142 self.waitUntilSettled()
1143
1144 job_names = [x.name for x in self.history]
1145 self.assertEqual(len(self.history), 0)
1146 self.assertNotIn('project-post', job_names)
1147
James E. Blaircc324192017-04-19 14:36:08 -07001148 @simple_layout('layouts/dont-ignore-ref-deletes.yaml')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001149 def test_post_ignore_deletes_negative(self):
1150 "Test that deleting refs does trigger post jobs"
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001151 e = {
1152 "type": "ref-updated",
1153 "submitter": {
1154 "name": "User Name",
1155 },
1156 "refUpdate": {
1157 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1158 "newRev": "0000000000000000000000000000000000000000",
1159 "refName": "master",
1160 "project": "org/project",
1161 }
1162 }
1163 self.fake_gerrit.addEvent(e)
1164 self.waitUntilSettled()
1165
1166 job_names = [x.name for x in self.history]
1167 self.assertEqual(len(self.history), 1)
1168 self.assertIn('project-post', job_names)
1169
James E. Blairec056492016-07-22 09:45:56 -07001170 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001171 def test_build_configuration_branch_interaction(self):
1172 "Test that switching between branches works"
1173 self.test_build_configuration()
1174 self.test_build_configuration_branch()
1175 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001176 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001177 repo = git.Repo(path)
1178 repo.heads.master.commit = repo.commit('init')
1179 self.test_build_configuration()
1180
James E. Blaircaec0c52012-08-22 14:52:22 -07001181 def test_dependent_changes_dequeue(self):
1182 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001183
James E. Blaircaec0c52012-08-22 14:52:22 -07001184 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1185 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1186 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001187 A.addApproval('code-review', 2)
1188 B.addApproval('code-review', 2)
1189 C.addApproval('code-review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001190
1191 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1192 M1.setMerged()
1193
1194 # C -> B -> A -> M1
1195
1196 C.setDependsOn(B, 1)
1197 B.setDependsOn(A, 1)
1198 A.setDependsOn(M1, 1)
1199
Paul Belanger174a8272017-03-14 13:20:10 -04001200 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001201
James E. Blair8b5408c2016-08-08 15:37:46 -07001202 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1203 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1204 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001205
1206 self.waitUntilSettled()
1207
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001208 self.assertEqual(A.data['status'], 'NEW')
1209 self.assertEqual(A.reported, 2)
1210 self.assertEqual(B.data['status'], 'NEW')
1211 self.assertEqual(B.reported, 2)
1212 self.assertEqual(C.data['status'], 'NEW')
James E. Blair0d3e83b2017-06-05 13:51:57 -07001213 self.assertIn('This change depends on a change that failed to merge.',
1214 C.messages[-1])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001215 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001216
James E. Blair972e3c72013-08-29 12:04:55 -07001217 def test_failing_dependent_changes(self):
1218 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001219 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001220 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1221 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1222 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1223 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1224 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
James E. Blair8b5408c2016-08-08 15:37:46 -07001225 A.addApproval('code-review', 2)
1226 B.addApproval('code-review', 2)
1227 C.addApproval('code-review', 2)
1228 D.addApproval('code-review', 2)
1229 E.addApproval('code-review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001230
1231 # E, D -> C -> B, A
1232
1233 D.setDependsOn(C, 1)
1234 C.setDependsOn(B, 1)
1235
Paul Belanger174a8272017-03-14 13:20:10 -04001236 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001237
James E. Blair8b5408c2016-08-08 15:37:46 -07001238 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1239 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
1240 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1241 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1242 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001243
1244 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001245 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001246 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001247 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001248 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001249 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001250 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001251 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001252 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001253 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001254 self.waitUntilSettled()
1255
Paul Belanger174a8272017-03-14 13:20:10 -04001256 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001257 for build in self.builds:
1258 if build.parameters['ZUUL_CHANGE'] != '1':
1259 build.release()
1260 self.waitUntilSettled()
1261
Paul Belanger174a8272017-03-14 13:20:10 -04001262 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001263 self.waitUntilSettled()
1264
1265 self.assertEqual(A.data['status'], 'MERGED')
1266 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001267 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001268 self.assertEqual(B.data['status'], 'NEW')
1269 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001270 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001271 self.assertEqual(C.data['status'], 'NEW')
1272 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001273 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001274 self.assertEqual(D.data['status'], 'NEW')
1275 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001276 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001277 self.assertEqual(E.data['status'], 'MERGED')
1278 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001279 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001280 self.assertEqual(len(self.history), 18)
1281
James E. Blairec590122012-08-22 15:19:31 -07001282 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001283 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001284 # If it's dequeued more than once, we should see extra
1285 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001286
Paul Belanger174a8272017-03-14 13:20:10 -04001287 self.executor_server.hold_jobs_in_build = True
James E. Blair6df67132017-04-19 13:53:20 -07001288 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1289 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1290 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001291 A.addApproval('code-review', 2)
1292 B.addApproval('code-review', 2)
1293 C.addApproval('code-review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001294
Paul Belanger174a8272017-03-14 13:20:10 -04001295 self.executor_server.failJob('project-test1', A)
1296 self.executor_server.failJob('project-test2', A)
James E. Blairec590122012-08-22 15:19:31 -07001297
James E. Blair8b5408c2016-08-08 15:37:46 -07001298 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1299 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1300 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001301
1302 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001303
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001304 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001305 self.assertEqual(self.builds[0].name, 'project-merge')
1306 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001307
Paul Belanger174a8272017-03-14 13:20:10 -04001308 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001309 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001310 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001311 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001312 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001313 self.waitUntilSettled()
1314
James E. Blair6df67132017-04-19 13:53:20 -07001315 self.assertEqual(len(self.builds), 6)
Paul Belanger58bf6912016-11-11 19:36:01 -05001316 self.assertEqual(self.builds[0].name, 'project-test1')
1317 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair6df67132017-04-19 13:53:20 -07001318 self.assertEqual(self.builds[2].name, 'project-test1')
1319 self.assertEqual(self.builds[3].name, 'project-test2')
1320 self.assertEqual(self.builds[4].name, 'project-test1')
1321 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blairec590122012-08-22 15:19:31 -07001322
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001323 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001324 self.waitUntilSettled()
1325
James E. Blair6df67132017-04-19 13:53:20 -07001326 self.assertEqual(len(self.builds), 2) # test2, merge for B
1327 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
James E. Blairec590122012-08-22 15:19:31 -07001328
Paul Belanger174a8272017-03-14 13:20:10 -04001329 self.executor_server.hold_jobs_in_build = False
1330 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001331 self.waitUntilSettled()
1332
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001333 self.assertEqual(len(self.builds), 0)
James E. Blair6df67132017-04-19 13:53:20 -07001334 self.assertEqual(len(self.history), 15)
James E. Blaircaec0c52012-08-22 14:52:22 -07001335
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001336 self.assertEqual(A.data['status'], 'NEW')
1337 self.assertEqual(B.data['status'], 'MERGED')
1338 self.assertEqual(C.data['status'], 'MERGED')
1339 self.assertEqual(A.reported, 2)
1340 self.assertEqual(B.reported, 2)
1341 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001342
James E. Blaircc020532017-04-19 13:04:44 -07001343 @simple_layout('layouts/nonvoting-job.yaml')
James E. Blair4ec821f2012-08-23 15:28:28 -07001344 def test_nonvoting_job(self):
1345 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001346
James E. Blair4ec821f2012-08-23 15:28:28 -07001347 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1348 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001349 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001350 self.executor_server.failJob('nonvoting-project-test2', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07001351 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001352
1353 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001354
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001355 self.assertEqual(A.data['status'], 'MERGED')
1356 self.assertEqual(A.reported, 2)
1357 self.assertEqual(
1358 self.getJobFromHistory('nonvoting-project-merge').result,
1359 'SUCCESS')
1360 self.assertEqual(
1361 self.getJobFromHistory('nonvoting-project-test1').result,
1362 'SUCCESS')
1363 self.assertEqual(
1364 self.getJobFromHistory('nonvoting-project-test2').result,
1365 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001366
James E. Blair5821bd92015-09-16 08:48:15 -07001367 for build in self.builds:
1368 self.assertEqual(build.parameters['ZUUL_VOTING'], '0')
1369
James E. Blaire0487072012-08-29 17:38:31 -07001370 def test_check_queue_success(self):
1371 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001372
James E. Blaire0487072012-08-29 17:38:31 -07001373 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1374 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1375
1376 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001377
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001378 self.assertEqual(A.data['status'], 'NEW')
1379 self.assertEqual(A.reported, 1)
1380 self.assertEqual(self.getJobFromHistory('project-merge').result,
1381 'SUCCESS')
1382 self.assertEqual(self.getJobFromHistory('project-test1').result,
1383 'SUCCESS')
1384 self.assertEqual(self.getJobFromHistory('project-test2').result,
1385 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001386
1387 def test_check_queue_failure(self):
1388 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001389
James E. Blaire0487072012-08-29 17:38:31 -07001390 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001391 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001392 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1393
1394 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001395
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001396 self.assertEqual(A.data['status'], 'NEW')
1397 self.assertEqual(A.reported, 1)
1398 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001399 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001400 self.assertEqual(self.getJobFromHistory('project-test1').result,
1401 'SUCCESS')
1402 self.assertEqual(self.getJobFromHistory('project-test2').result,
1403 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001404
James E. Blair7cb84542017-04-19 13:35:05 -07001405 @simple_layout('layouts/three-projects.yaml')
James E. Blair127bc182012-08-28 15:55:15 -07001406 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001407 # This particular test does a large amount of merges and needs a little
1408 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001409 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001410 "test that dependent changes behind dequeued changes work"
1411 # This complicated test is a reproduction of a real life bug
1412 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001413
Paul Belanger174a8272017-03-14 13:20:10 -04001414 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001415 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1416 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1417 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1418 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1419 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1420 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1421 D.setDependsOn(C, 1)
1422 E.setDependsOn(D, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07001423 A.addApproval('code-review', 2)
1424 B.addApproval('code-review', 2)
1425 C.addApproval('code-review', 2)
1426 D.addApproval('code-review', 2)
1427 E.addApproval('code-review', 2)
1428 F.addApproval('code-review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001429
1430 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001431
1432 # Change object re-use in the gerrit trigger is hidden if
1433 # changes are added in quick succession; waiting makes it more
1434 # like real life.
James E. Blair8b5408c2016-08-08 15:37:46 -07001435 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001436 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001437 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001438 self.waitUntilSettled()
1439
Paul Belanger174a8272017-03-14 13:20:10 -04001440 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001441 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001442 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001443 self.waitUntilSettled()
1444
James E. Blair8b5408c2016-08-08 15:37:46 -07001445 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001446 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001447 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001448 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001449 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001450 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001451 self.fake_gerrit.addEvent(F.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001452 self.waitUntilSettled()
1453
Paul Belanger174a8272017-03-14 13:20:10 -04001454 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001455 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001456 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001457 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001458 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001459 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001460 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001461 self.waitUntilSettled()
1462
1463 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001464
1465 # Grab pointers to the jobs we want to release before
1466 # releasing any, because list indexes may change as
1467 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001468 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001469 a.release()
1470 b.release()
1471 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001472 self.waitUntilSettled()
1473
Paul Belanger174a8272017-03-14 13:20:10 -04001474 self.executor_server.hold_jobs_in_build = False
1475 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001476 self.waitUntilSettled()
1477
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001478 self.assertEqual(A.data['status'], 'NEW')
1479 self.assertEqual(B.data['status'], 'MERGED')
1480 self.assertEqual(C.data['status'], 'MERGED')
1481 self.assertEqual(D.data['status'], 'MERGED')
1482 self.assertEqual(E.data['status'], 'MERGED')
1483 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001484
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001485 self.assertEqual(A.reported, 2)
1486 self.assertEqual(B.reported, 2)
1487 self.assertEqual(C.reported, 2)
1488 self.assertEqual(D.reported, 2)
1489 self.assertEqual(E.reported, 2)
1490 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001491
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001492 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1493 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001494
1495 def test_merger_repack(self):
1496 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001497
James E. Blair05fed602012-09-07 12:45:24 -07001498 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001499 A.addApproval('code-review', 2)
1500 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001501 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001502 self.assertEqual(self.getJobFromHistory('project-merge').result,
1503 'SUCCESS')
1504 self.assertEqual(self.getJobFromHistory('project-test1').result,
1505 'SUCCESS')
1506 self.assertEqual(self.getJobFromHistory('project-test2').result,
1507 'SUCCESS')
1508 self.assertEqual(A.data['status'], 'MERGED')
1509 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001510 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001511 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001512
James E. Blair2a535672017-04-27 12:03:15 -07001513 path = os.path.join(self.merger_src_root, "review.example.com",
1514 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001515 if os.path.exists(path):
1516 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001517 path = os.path.join(self.executor_src_root, "review.example.com",
1518 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001519 if os.path.exists(path):
1520 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001521
1522 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001523 A.addApproval('code-review', 2)
1524 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001525 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001526 self.assertEqual(self.getJobFromHistory('project-merge').result,
1527 'SUCCESS')
1528 self.assertEqual(self.getJobFromHistory('project-test1').result,
1529 'SUCCESS')
1530 self.assertEqual(self.getJobFromHistory('project-test2').result,
1531 'SUCCESS')
1532 self.assertEqual(A.data['status'], 'MERGED')
1533 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001534
James E. Blair4886f282012-11-15 09:27:33 -08001535 def test_merger_repack_large_change(self):
1536 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001537 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001538 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001539 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6df67132017-04-19 13:53:20 -07001540 trusted, project = tenant.getProject('org/project')
James E. Blair0ffa0102017-03-30 13:11:33 -07001541 url = self.fake_gerrit.getGitUrl(project)
James E. Blair8d144dc2017-05-05 10:13:45 -07001542 self.executor_server.merger._addProject('review.example.com',
James E. Blair197e8202017-06-09 12:54:28 -07001543 'org/project', url, None)
James E. Blair6df67132017-04-19 13:53:20 -07001544 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair4886f282012-11-15 09:27:33 -08001545 A.addPatchset(large=True)
James E. Blair2a535672017-04-27 12:03:15 -07001546 # TODOv3(jeblair): add hostname to upstream root
1547 path = os.path.join(self.upstream_root, 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001548 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001549 path = os.path.join(self.merger_src_root, 'review.example.com',
1550 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001551 if os.path.exists(path):
1552 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001553 path = os.path.join(self.executor_src_root, 'review.example.com',
1554 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001555 if os.path.exists(path):
1556 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001557
James E. Blair8b5408c2016-08-08 15:37:46 -07001558 A.addApproval('code-review', 2)
1559 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001560 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001561 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001562 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001563 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001564 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001565 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001566 'SUCCESS')
1567 self.assertEqual(A.data['status'], 'MERGED')
1568 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001569
James E. Blair2fa50962013-01-30 21:50:41 -08001570 def test_new_patchset_dequeues_old(self):
1571 "Test that a new patchset causes the old to be dequeued"
1572 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001573 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001574 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1575 M.setMerged()
1576
1577 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1578 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1579 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1580 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001581 A.addApproval('code-review', 2)
1582 B.addApproval('code-review', 2)
1583 C.addApproval('code-review', 2)
1584 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001585
1586 C.setDependsOn(B, 1)
1587 B.setDependsOn(A, 1)
1588 A.setDependsOn(M, 1)
1589
James E. Blair8b5408c2016-08-08 15:37:46 -07001590 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1591 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1592 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1593 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001594 self.waitUntilSettled()
1595
1596 B.addPatchset()
1597 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1598 self.waitUntilSettled()
1599
Paul Belanger174a8272017-03-14 13:20:10 -04001600 self.executor_server.hold_jobs_in_build = False
1601 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001602 self.waitUntilSettled()
1603
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001604 self.assertEqual(A.data['status'], 'MERGED')
1605 self.assertEqual(A.reported, 2)
1606 self.assertEqual(B.data['status'], 'NEW')
1607 self.assertEqual(B.reported, 2)
1608 self.assertEqual(C.data['status'], 'NEW')
1609 self.assertEqual(C.reported, 2)
1610 self.assertEqual(D.data['status'], 'MERGED')
1611 self.assertEqual(D.reported, 2)
1612 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001613
James E. Blairba437362015-02-07 11:41:52 -08001614 def test_new_patchset_check(self):
1615 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001616
Paul Belanger174a8272017-03-14 13:20:10 -04001617 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001618
1619 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001620 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001621 tenant = self.sched.abide.tenants.get('tenant-one')
1622 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001623
1624 # Add two git-dependent changes
1625 B.setDependsOn(A, 1)
1626 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1627 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001628 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1629 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001630
1631 # A live item, and a non-live/live pair
1632 items = check_pipeline.getAllItems()
1633 self.assertEqual(len(items), 3)
1634
1635 self.assertEqual(items[0].change.number, '1')
1636 self.assertEqual(items[0].change.patchset, '1')
1637 self.assertFalse(items[0].live)
1638
1639 self.assertEqual(items[1].change.number, '2')
1640 self.assertEqual(items[1].change.patchset, '1')
1641 self.assertTrue(items[1].live)
1642
1643 self.assertEqual(items[2].change.number, '1')
1644 self.assertEqual(items[2].change.patchset, '1')
1645 self.assertTrue(items[2].live)
1646
1647 # Add a new patchset to A
1648 A.addPatchset()
1649 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1650 self.waitUntilSettled()
1651
1652 # The live copy of A,1 should be gone, but the non-live and B
1653 # should continue, and we should have a new A,2
1654 items = check_pipeline.getAllItems()
1655 self.assertEqual(len(items), 3)
1656
1657 self.assertEqual(items[0].change.number, '1')
1658 self.assertEqual(items[0].change.patchset, '1')
1659 self.assertFalse(items[0].live)
1660
1661 self.assertEqual(items[1].change.number, '2')
1662 self.assertEqual(items[1].change.patchset, '1')
1663 self.assertTrue(items[1].live)
1664
1665 self.assertEqual(items[2].change.number, '1')
1666 self.assertEqual(items[2].change.patchset, '2')
1667 self.assertTrue(items[2].live)
1668
1669 # Add a new patchset to B
1670 B.addPatchset()
1671 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1672 self.waitUntilSettled()
1673
1674 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1675 # but we should have a new B,2 (still based on A,1)
1676 items = check_pipeline.getAllItems()
1677 self.assertEqual(len(items), 3)
1678
1679 self.assertEqual(items[0].change.number, '1')
1680 self.assertEqual(items[0].change.patchset, '2')
1681 self.assertTrue(items[0].live)
1682
1683 self.assertEqual(items[1].change.number, '1')
1684 self.assertEqual(items[1].change.patchset, '1')
1685 self.assertFalse(items[1].live)
1686
1687 self.assertEqual(items[2].change.number, '2')
1688 self.assertEqual(items[2].change.patchset, '2')
1689 self.assertTrue(items[2].live)
1690
1691 self.builds[0].release()
1692 self.waitUntilSettled()
1693 self.builds[0].release()
1694 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001695 self.executor_server.hold_jobs_in_build = False
1696 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001697 self.waitUntilSettled()
1698
1699 self.assertEqual(A.reported, 1)
1700 self.assertEqual(B.reported, 1)
1701 self.assertEqual(self.history[0].result, 'ABORTED')
1702 self.assertEqual(self.history[0].changes, '1,1')
1703 self.assertEqual(self.history[1].result, 'ABORTED')
1704 self.assertEqual(self.history[1].changes, '1,1 2,1')
1705 self.assertEqual(self.history[2].result, 'SUCCESS')
1706 self.assertEqual(self.history[2].changes, '1,2')
1707 self.assertEqual(self.history[3].result, 'SUCCESS')
1708 self.assertEqual(self.history[3].changes, '1,1 2,2')
1709
1710 def test_abandoned_gate(self):
1711 "Test that an abandoned change is dequeued from gate"
1712
Paul Belanger174a8272017-03-14 13:20:10 -04001713 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001714
1715 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001716 A.addApproval('code-review', 2)
1717 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001718 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001719 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1720 self.assertEqual(self.builds[0].name, 'project-merge')
1721
1722 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1723 self.waitUntilSettled()
1724
Paul Belanger174a8272017-03-14 13:20:10 -04001725 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001726 self.waitUntilSettled()
1727
Arie5b4048c2016-10-05 16:12:06 +03001728 self.assertBuilds([])
1729 self.assertHistory([
1730 dict(name='project-merge', result='ABORTED', changes='1,1')],
1731 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001732 self.assertEqual(A.reported, 1,
1733 "Abandoned gate change should report only start")
1734
1735 def test_abandoned_check(self):
1736 "Test that an abandoned change is dequeued from check"
1737
Paul Belanger174a8272017-03-14 13:20:10 -04001738 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001739
1740 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1741 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001742 tenant = self.sched.abide.tenants.get('tenant-one')
1743 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001744
1745 # Add two git-dependent changes
1746 B.setDependsOn(A, 1)
1747 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1748 self.waitUntilSettled()
1749 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1750 self.waitUntilSettled()
1751 # A live item, and a non-live/live pair
1752 items = check_pipeline.getAllItems()
1753 self.assertEqual(len(items), 3)
1754
1755 self.assertEqual(items[0].change.number, '1')
1756 self.assertFalse(items[0].live)
1757
1758 self.assertEqual(items[1].change.number, '2')
1759 self.assertTrue(items[1].live)
1760
1761 self.assertEqual(items[2].change.number, '1')
1762 self.assertTrue(items[2].live)
1763
1764 # Abandon A
1765 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1766 self.waitUntilSettled()
1767
1768 # The live copy of A should be gone, but the non-live and B
1769 # should continue
1770 items = check_pipeline.getAllItems()
1771 self.assertEqual(len(items), 2)
1772
1773 self.assertEqual(items[0].change.number, '1')
1774 self.assertFalse(items[0].live)
1775
1776 self.assertEqual(items[1].change.number, '2')
1777 self.assertTrue(items[1].live)
1778
Paul Belanger174a8272017-03-14 13:20:10 -04001779 self.executor_server.hold_jobs_in_build = False
1780 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001781 self.waitUntilSettled()
1782
1783 self.assertEqual(len(self.history), 4)
1784 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001785 'Build should have been aborted')
1786 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001787 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001788
Steve Varnau7b78b312015-04-03 14:49:46 -07001789 def test_abandoned_not_timer(self):
1790 "Test that an abandoned change does not cancel timer jobs"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001791 # This test can not use simple_layout because it must start
1792 # with a configuration which does not include a
1793 # timer-triggered job so that we have an opportunity to set
1794 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04001795 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001796 # Start timer trigger - also org/project
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001797 self.commitConfigUpdate('common-config', 'layouts/idle.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001798 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001799 # The pipeline triggers every second, so we should have seen
1800 # several by now.
1801 time.sleep(5)
1802 self.waitUntilSettled()
1803 # Stop queuing timer triggered jobs so that the assertions
1804 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001805 # Must be in same repo, so overwrite config with another one
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001806 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001807 self.sched.reconfigure(self.config)
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001808
Steve Varnau7b78b312015-04-03 14:49:46 -07001809 self.assertEqual(len(self.builds), 2, "Two timer jobs")
1810
1811 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1812 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1813 self.waitUntilSettled()
1814 self.assertEqual(len(self.builds), 3, "One change plus two timer jobs")
1815
1816 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1817 self.waitUntilSettled()
1818
1819 self.assertEqual(len(self.builds), 2, "Two timer jobs remain")
1820
Paul Belanger174a8272017-03-14 13:20:10 -04001821 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001822 self.waitUntilSettled()
1823
Arx Cruzb1b010d2013-10-28 19:49:59 -02001824 def test_zuul_url_return(self):
1825 "Test if ZUUL_URL is returning when zuul_url is set in zuul.conf"
James E. Blair4076e2b2014-01-28 12:42:20 -08001826 self.assertTrue(self.sched.config.has_option('merger', 'zuul_url'))
Paul Belanger174a8272017-03-14 13:20:10 -04001827 self.executor_server.hold_jobs_in_build = True
Arx Cruzb1b010d2013-10-28 19:49:59 -02001828
1829 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001830 A.addApproval('code-review', 2)
1831 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Arx Cruzb1b010d2013-10-28 19:49:59 -02001832 self.waitUntilSettled()
1833
1834 self.assertEqual(len(self.builds), 1)
1835 for build in self.builds:
1836 self.assertTrue('ZUUL_URL' in build.parameters)
1837
Paul Belanger174a8272017-03-14 13:20:10 -04001838 self.executor_server.hold_jobs_in_build = False
1839 self.executor_server.release()
Arx Cruzb1b010d2013-10-28 19:49:59 -02001840 self.waitUntilSettled()
1841
James E. Blair2fa50962013-01-30 21:50:41 -08001842 def test_new_patchset_dequeues_old_on_head(self):
1843 "Test that a new patchset causes the old to be dequeued (at head)"
1844 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001845 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001846 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1847 M.setMerged()
1848 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1849 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1850 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1851 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001852 A.addApproval('code-review', 2)
1853 B.addApproval('code-review', 2)
1854 C.addApproval('code-review', 2)
1855 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001856
1857 C.setDependsOn(B, 1)
1858 B.setDependsOn(A, 1)
1859 A.setDependsOn(M, 1)
1860
James E. Blair8b5408c2016-08-08 15:37:46 -07001861 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1862 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1863 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1864 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001865 self.waitUntilSettled()
1866
1867 A.addPatchset()
1868 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1869 self.waitUntilSettled()
1870
Paul Belanger174a8272017-03-14 13:20:10 -04001871 self.executor_server.hold_jobs_in_build = False
1872 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001873 self.waitUntilSettled()
1874
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001875 self.assertEqual(A.data['status'], 'NEW')
1876 self.assertEqual(A.reported, 2)
1877 self.assertEqual(B.data['status'], 'NEW')
1878 self.assertEqual(B.reported, 2)
1879 self.assertEqual(C.data['status'], 'NEW')
1880 self.assertEqual(C.reported, 2)
1881 self.assertEqual(D.data['status'], 'MERGED')
1882 self.assertEqual(D.reported, 2)
1883 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08001884
1885 def test_new_patchset_dequeues_old_without_dependents(self):
1886 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04001887 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001888 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1889 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1890 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001891 A.addApproval('code-review', 2)
1892 B.addApproval('code-review', 2)
1893 C.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001894
James E. Blair8b5408c2016-08-08 15:37:46 -07001895 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1896 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1897 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001898 self.waitUntilSettled()
1899
1900 B.addPatchset()
1901 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1902 self.waitUntilSettled()
1903
Paul Belanger174a8272017-03-14 13:20:10 -04001904 self.executor_server.hold_jobs_in_build = False
1905 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001906 self.waitUntilSettled()
1907
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001908 self.assertEqual(A.data['status'], 'MERGED')
1909 self.assertEqual(A.reported, 2)
1910 self.assertEqual(B.data['status'], 'NEW')
1911 self.assertEqual(B.reported, 2)
1912 self.assertEqual(C.data['status'], 'MERGED')
1913 self.assertEqual(C.reported, 2)
1914 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08001915
1916 def test_new_patchset_dequeues_old_independent_queue(self):
1917 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04001918 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001919 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1920 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1921 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1922 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1923 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1924 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1925 self.waitUntilSettled()
1926
1927 B.addPatchset()
1928 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1929 self.waitUntilSettled()
1930
Paul Belanger174a8272017-03-14 13:20:10 -04001931 self.executor_server.hold_jobs_in_build = False
1932 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001933 self.waitUntilSettled()
1934
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001935 self.assertEqual(A.data['status'], 'NEW')
1936 self.assertEqual(A.reported, 1)
1937 self.assertEqual(B.data['status'], 'NEW')
1938 self.assertEqual(B.reported, 1)
1939 self.assertEqual(C.data['status'], 'NEW')
1940 self.assertEqual(C.reported, 1)
1941 self.assertEqual(len(self.history), 10)
1942 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001943
James E. Blaircc020532017-04-19 13:04:44 -07001944 @simple_layout('layouts/noop-job.yaml')
James E. Blair18c64442014-03-18 10:14:45 -07001945 def test_noop_job(self):
1946 "Test that the internal noop job works"
1947 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001948 A.addApproval('code-review', 2)
1949 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07001950 self.waitUntilSettled()
1951
1952 self.assertEqual(len(self.gearman_server.getQueue()), 0)
1953 self.assertTrue(self.sched._areAllBuildsComplete())
1954 self.assertEqual(len(self.history), 0)
1955 self.assertEqual(A.data['status'], 'MERGED')
1956 self.assertEqual(A.reported, 2)
1957
James E. Blair06cc3922017-04-19 10:08:10 -07001958 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001959 def test_no_job_project(self):
1960 "Test that reports with no jobs don't get sent"
1961 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
1962 'master', 'A')
1963 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1964 self.waitUntilSettled()
1965
1966 # Change wasn't reported to
1967 self.assertEqual(A.reported, False)
1968
1969 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08001970 tenant = self.sched.abide.tenants.get('tenant-one')
1971 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001972 items = check_pipeline.getAllItems()
1973 self.assertEqual(len(items), 0)
1974
1975 self.assertEqual(len(self.history), 0)
1976
James E. Blair7d0dedc2013-02-21 17:26:09 -08001977 def test_zuul_refs(self):
1978 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04001979 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08001980 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
1981 M1.setMerged()
1982 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
1983 M2.setMerged()
1984
1985 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1986 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1987 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1988 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001989 A.addApproval('code-review', 2)
1990 B.addApproval('code-review', 2)
1991 C.addApproval('code-review', 2)
1992 D.addApproval('code-review', 2)
1993 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1994 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1995 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1996 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001997
1998 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001999 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002000 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002001 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002002 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002003 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002004 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002005 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08002006 self.waitUntilSettled()
2007
James E. Blair7d0dedc2013-02-21 17:26:09 -08002008 a_zref = b_zref = c_zref = d_zref = None
Clint Byrum3343e3e2016-11-15 16:05:03 -08002009 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002010 for x in self.builds:
James E. Blair7d0dedc2013-02-21 17:26:09 -08002011 if x.parameters['ZUUL_CHANGE'] == '3':
2012 a_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08002013 a_build = x
2014 elif x.parameters['ZUUL_CHANGE'] == '4':
James E. Blair7d0dedc2013-02-21 17:26:09 -08002015 b_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08002016 b_build = x
2017 elif x.parameters['ZUUL_CHANGE'] == '5':
James E. Blair7d0dedc2013-02-21 17:26:09 -08002018 c_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08002019 c_build = x
2020 elif x.parameters['ZUUL_CHANGE'] == '6':
James E. Blair7d0dedc2013-02-21 17:26:09 -08002021 d_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08002022 d_build = x
2023 if a_build and b_build and c_build and d_build:
2024 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08002025
2026 # There are... four... refs.
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002027 self.assertIsNotNone(a_zref)
2028 self.assertIsNotNone(b_zref)
2029 self.assertIsNotNone(c_zref)
2030 self.assertIsNotNone(d_zref)
James E. Blair7d0dedc2013-02-21 17:26:09 -08002031
2032 # And they should all be different
2033 refs = set([a_zref, b_zref, c_zref, d_zref])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002034 self.assertEqual(len(refs), 4)
James E. Blair7d0dedc2013-02-21 17:26:09 -08002035
Clint Byrum3343e3e2016-11-15 16:05:03 -08002036 # should have a, not b, and should not be in project2
2037 self.assertTrue(a_build.hasChanges(A))
2038 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002039
Clint Byrum3343e3e2016-11-15 16:05:03 -08002040 # should have a and b, and should not be in project2
2041 self.assertTrue(b_build.hasChanges(A, B))
2042 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002043
Clint Byrum3343e3e2016-11-15 16:05:03 -08002044 # should have a and b in 1, c in 2
2045 self.assertTrue(c_build.hasChanges(A, B, C))
2046 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002047
Clint Byrum3343e3e2016-11-15 16:05:03 -08002048 # should have a and b in 1, c and d in 2
2049 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002050
Paul Belanger174a8272017-03-14 13:20:10 -04002051 self.executor_server.hold_jobs_in_build = False
2052 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002053 self.waitUntilSettled()
2054
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002055 self.assertEqual(A.data['status'], 'MERGED')
2056 self.assertEqual(A.reported, 2)
2057 self.assertEqual(B.data['status'], 'MERGED')
2058 self.assertEqual(B.reported, 2)
2059 self.assertEqual(C.data['status'], 'MERGED')
2060 self.assertEqual(C.reported, 2)
2061 self.assertEqual(D.data['status'], 'MERGED')
2062 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002063
James E. Blair4a28a882013-08-23 15:17:33 -07002064 def test_rerun_on_error(self):
2065 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002066 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002067 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002068 A.addApproval('code-review', 2)
2069 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002070 self.waitUntilSettled()
2071
James E. Blair412fba82017-01-26 15:00:50 -08002072 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002073 self.executor_server.hold_jobs_in_build = False
2074 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002075 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002076 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002077 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2078
James E. Blair412e5582013-04-22 15:50:12 -07002079 def test_statsd(self):
2080 "Test each of the statsd methods used in the scheduler"
2081 import extras
2082 statsd = extras.try_import('statsd.statsd')
2083 statsd.incr('test-incr')
2084 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002085 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002086 self.assertReportedStat('test-incr', '1|c')
2087 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002088 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002089
James E. Blairdad52252014-02-07 16:59:17 -08002090 def test_stuck_job_cleanup(self):
2091 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002092
2093 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002094 self.gearman_server.hold_jobs_in_queue = True
2095 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002096 A.addApproval('code-review', 2)
2097 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002098 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002099 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002100 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2101
James E. Blair31cb3e82017-04-20 13:08:56 -07002102 self.commitConfigUpdate('common-config', 'layouts/no-jobs.yaml')
James E. Blairdad52252014-02-07 16:59:17 -08002103 self.sched.reconfigure(self.config)
2104 self.waitUntilSettled()
2105
James E. Blair18c64442014-03-18 10:14:45 -07002106 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002107 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002108 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002109 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2110 self.assertTrue(self.sched._areAllBuildsComplete())
2111
2112 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002113 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002114 self.assertEqual(self.history[0].result, 'SUCCESS')
2115
James E. Blair879dafb2015-07-17 14:04:49 -07002116 def test_file_head(self):
2117 # This is a regression test for an observed bug. A change
2118 # with a file named "HEAD" in the root directory of the repo
2119 # was processed by a merger. It then was unable to reset the
2120 # repo because of:
2121 # GitCommandError: 'git reset --hard HEAD' returned
2122 # with exit code 128
2123 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2124 # and filename
2125 # Use '--' to separate filenames from revisions'
2126
2127 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002128 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002129 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2130
2131 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2132 self.waitUntilSettled()
2133
2134 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2135 self.waitUntilSettled()
2136
2137 self.assertIn('Build succeeded', A.messages[0])
2138 self.assertIn('Build succeeded', B.messages[0])
2139
James E. Blair70c71582013-03-06 08:50:50 -08002140 def test_file_jobs(self):
2141 "Test that file jobs run only when appropriate"
2142 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002143 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002144 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07002145 A.addApproval('code-review', 2)
2146 B.addApproval('code-review', 2)
2147 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2148 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002149 self.waitUntilSettled()
2150
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002151 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002152 if x.name == 'project-testfile']
2153
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002154 self.assertEqual(len(testfile_jobs), 1)
2155 self.assertEqual(testfile_jobs[0].changes, '1,2')
2156 self.assertEqual(A.data['status'], 'MERGED')
2157 self.assertEqual(A.reported, 2)
2158 self.assertEqual(B.data['status'], 'MERGED')
2159 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002160
Clint Byrum3ee39f32016-11-17 23:45:07 -08002161 def _test_irrelevant_files_jobs(self, should_skip):
2162 "Test that jobs with irrelevant-files filter run only when appropriate"
Clint Byrum3ee39f32016-11-17 23:45:07 -08002163 if should_skip:
2164 files = {'ignoreme': 'ignored\n'}
2165 else:
2166 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002167
2168 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002169 'master',
2170 'test irrelevant-files',
2171 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002172 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2173 self.waitUntilSettled()
2174
2175 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002176 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002177
2178 if should_skip:
2179 self.assertEqual([], tested_change_ids)
2180 else:
2181 self.assertIn(change.data['number'], tested_change_ids)
2182
James E. Blaircc324192017-04-19 14:36:08 -07002183 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002184 def test_irrelevant_files_match_skips_job(self):
2185 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002186
James E. Blaircc324192017-04-19 14:36:08 -07002187 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002188 def test_irrelevant_files_no_match_runs_job(self):
2189 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002190
James E. Blaircc324192017-04-19 14:36:08 -07002191 @simple_layout('layouts/inheritance.yaml')
Clint Byrum85493602016-11-18 11:59:47 -08002192 def test_inherited_jobs_keep_matchers(self):
Clint Byrum85493602016-11-18 11:59:47 -08002193 files = {'ignoreme': 'ignored\n'}
2194
2195 change = self.fake_gerrit.addFakeChange('org/project',
2196 'master',
2197 'test irrelevant-files',
2198 files=files)
2199 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2200 self.waitUntilSettled()
2201
2202 run_jobs = set([build.name for build in self.history])
2203
2204 self.assertEqual(set(['project-test-nomatch-starts-empty',
2205 'project-test-nomatch-starts-full']), run_jobs)
2206
James E. Blairc8a1e052014-02-25 09:29:26 -08002207 def test_queue_names(self):
2208 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002209 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002210 (trusted, project1) = tenant.getProject('org/project1')
2211 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002212 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2213 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2214 self.assertEqual(q1.name, 'integrated')
2215 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002216
James E. Blair64ed6f22013-07-10 14:07:23 -07002217 def test_queue_precedence(self):
2218 "Test that queue precedence works"
2219
2220 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002221 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002222 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2223 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
James E. Blair8b5408c2016-08-08 15:37:46 -07002224 A.addApproval('code-review', 2)
2225 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002226
2227 self.waitUntilSettled()
2228 self.gearman_server.hold_jobs_in_queue = False
2229 self.gearman_server.release()
2230 self.waitUntilSettled()
2231
James E. Blair8de58bd2013-07-18 16:23:33 -07002232 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002233 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002234 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002235 self.waitUntilSettled()
2236
James E. Blair64ed6f22013-07-10 14:07:23 -07002237 self.log.debug(self.history)
2238 self.assertEqual(self.history[0].pipeline, 'gate')
2239 self.assertEqual(self.history[1].pipeline, 'check')
2240 self.assertEqual(self.history[2].pipeline, 'gate')
2241 self.assertEqual(self.history[3].pipeline, 'gate')
2242 self.assertEqual(self.history[4].pipeline, 'check')
2243 self.assertEqual(self.history[5].pipeline, 'check')
2244
Clark Boylana5edbe42014-06-03 16:39:10 -07002245 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002246 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002247 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002248 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002249 A.addApproval('code-review', 2)
2250 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002251 self.waitUntilSettled()
2252
Paul Belanger174a8272017-03-14 13:20:10 -04002253 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002254 self.waitUntilSettled()
2255
James E. Blair1843a552013-07-03 14:19:52 -07002256 port = self.webapp.server.socket.getsockname()[1]
2257
Adam Gandelman77a12c72017-02-03 17:43:43 -08002258 req = urllib.request.Request(
2259 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002260 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002261 headers = f.info()
2262 self.assertIn('Content-Length', headers)
2263 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002264 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2265 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002266 self.assertIn('Access-Control-Allow-Origin', headers)
2267 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002268 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002269 self.assertIn('Expires', headers)
Clint Byrumf322fe22017-05-10 20:53:12 -07002270 data = f.read().decode('utf8')
James E. Blair1843a552013-07-03 14:19:52 -07002271
Paul Belanger174a8272017-03-14 13:20:10 -04002272 self.executor_server.hold_jobs_in_build = False
2273 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002274 self.waitUntilSettled()
2275
2276 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002277 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002278 for p in data['pipelines']:
2279 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002280 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002281 self.assertEqual(q['window'], 20)
2282 else:
2283 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002284 for head in q['heads']:
2285 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002286 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002287 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002288 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002289 status_jobs.append(job)
2290 self.assertEqual('project-merge', status_jobs[0]['name'])
2291 self.assertEqual('https://server/job/project-merge/0/',
2292 status_jobs[0]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002293 self.assertEqual('https://server/job/project-merge/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002294 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002295 self.assertEqual('project-test1', status_jobs[1]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002296 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002297 status_jobs[1]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002298 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002299 status_jobs[1]['report_url'])
2300
2301 self.assertEqual('project-test2', status_jobs[2]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002302 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002303 status_jobs[2]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002304 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002305 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002306
James E. Blaircdccd972013-07-01 12:10:22 -07002307 def test_live_reconfiguration(self):
2308 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002309 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002310 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002311 A.addApproval('code-review', 2)
2312 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002313 self.waitUntilSettled()
2314
2315 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002316 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002317
Paul Belanger174a8272017-03-14 13:20:10 -04002318 self.executor_server.hold_jobs_in_build = False
2319 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002320 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002321 self.assertEqual(self.getJobFromHistory('project-merge').result,
2322 'SUCCESS')
2323 self.assertEqual(self.getJobFromHistory('project-test1').result,
2324 'SUCCESS')
2325 self.assertEqual(self.getJobFromHistory('project-test2').result,
2326 'SUCCESS')
2327 self.assertEqual(A.data['status'], 'MERGED')
2328 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002329
James E. Blair6bc782d2015-07-17 16:20:21 -07002330 def test_live_reconfiguration_merge_conflict(self):
2331 # A real-world bug: a change in a gate queue has a merge
2332 # conflict and a job is added to its project while it's
2333 # sitting in the queue. The job gets added to the change and
2334 # enqueued and the change gets stuck.
Paul Belanger174a8272017-03-14 13:20:10 -04002335 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002336
2337 # This change is fine. It's here to stop the queue long
2338 # enough for the next change to be subject to the
2339 # reconfiguration, as well as to provide a conflict for the
2340 # next change. This change will succeed and merge.
2341 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum073c00b2017-05-01 13:41:23 -07002342 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002343 A.addApproval('code-review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002344
2345 # This change will be in merge conflict. During the
2346 # reconfiguration, we will add a job. We want to make sure
2347 # that doesn't cause it to get stuck.
2348 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Clint Byrum073c00b2017-05-01 13:41:23 -07002349 B.addPatchset({'conflict': 'B'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002350 B.addApproval('code-review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002351
James E. Blair8b5408c2016-08-08 15:37:46 -07002352 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2353 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002354
2355 self.waitUntilSettled()
2356
2357 # No jobs have run yet
2358 self.assertEqual(A.data['status'], 'NEW')
2359 self.assertEqual(A.reported, 1)
2360 self.assertEqual(B.data['status'], 'NEW')
James E. Blair6bc782d2015-07-17 16:20:21 -07002361 self.assertEqual(len(self.history), 0)
2362
2363 # Add the "project-test3" job.
Clint Byrum073c00b2017-05-01 13:41:23 -07002364 self.commitConfigUpdate('common-config',
2365 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002366 self.sched.reconfigure(self.config)
2367 self.waitUntilSettled()
2368
Paul Belanger174a8272017-03-14 13:20:10 -04002369 self.executor_server.hold_jobs_in_build = False
2370 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002371 self.waitUntilSettled()
2372
2373 self.assertEqual(A.data['status'], 'MERGED')
2374 self.assertEqual(A.reported, 2)
2375 self.assertEqual(B.data['status'], 'NEW')
Tobias Henkel9842bd72017-05-16 13:40:03 +02002376 self.assertIn('Merge Failed', B.messages[-1])
James E. Blair6bc782d2015-07-17 16:20:21 -07002377 self.assertEqual(self.getJobFromHistory('project-merge').result,
2378 'SUCCESS')
2379 self.assertEqual(self.getJobFromHistory('project-test1').result,
2380 'SUCCESS')
2381 self.assertEqual(self.getJobFromHistory('project-test2').result,
2382 'SUCCESS')
2383 self.assertEqual(self.getJobFromHistory('project-test3').result,
2384 'SUCCESS')
2385 self.assertEqual(len(self.history), 4)
2386
James E. Blair400e8fd2015-07-30 17:44:45 -07002387 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002388 # An extrapolation of test_live_reconfiguration_merge_conflict
2389 # that tests a job added to a job tree with a failed root does
2390 # not run.
Paul Belanger174a8272017-03-14 13:20:10 -04002391 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002392
2393 # This change is fine. It's here to stop the queue long
2394 # enough for the next change to be subject to the
2395 # reconfiguration. This change will succeed and merge.
2396 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum3147d652017-05-01 14:01:42 -07002397 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002398 A.addApproval('code-review', 2)
2399 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002400 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002401 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002402 self.waitUntilSettled()
2403
2404 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002405 self.executor_server.failJob('project-merge', B)
James E. Blair8b5408c2016-08-08 15:37:46 -07002406 B.addApproval('code-review', 2)
2407 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002408 self.waitUntilSettled()
2409
Paul Belanger174a8272017-03-14 13:20:10 -04002410 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002411 self.waitUntilSettled()
2412
2413 # Both -merge jobs have run, but no others.
2414 self.assertEqual(A.data['status'], 'NEW')
2415 self.assertEqual(A.reported, 1)
2416 self.assertEqual(B.data['status'], 'NEW')
2417 self.assertEqual(B.reported, 1)
2418 self.assertEqual(self.history[0].result, 'SUCCESS')
2419 self.assertEqual(self.history[0].name, 'project-merge')
2420 self.assertEqual(self.history[1].result, 'FAILURE')
2421 self.assertEqual(self.history[1].name, 'project-merge')
2422 self.assertEqual(len(self.history), 2)
2423
2424 # Add the "project-test3" job.
Clint Byrum3147d652017-05-01 14:01:42 -07002425 self.commitConfigUpdate('common-config',
2426 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002427 self.sched.reconfigure(self.config)
2428 self.waitUntilSettled()
2429
Paul Belanger174a8272017-03-14 13:20:10 -04002430 self.executor_server.hold_jobs_in_build = False
2431 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002432 self.waitUntilSettled()
2433
2434 self.assertEqual(A.data['status'], 'MERGED')
2435 self.assertEqual(A.reported, 2)
2436 self.assertEqual(B.data['status'], 'NEW')
2437 self.assertEqual(B.reported, 2)
2438 self.assertEqual(self.history[0].result, 'SUCCESS')
2439 self.assertEqual(self.history[0].name, 'project-merge')
2440 self.assertEqual(self.history[1].result, 'FAILURE')
2441 self.assertEqual(self.history[1].name, 'project-merge')
2442 self.assertEqual(self.history[2].result, 'SUCCESS')
2443 self.assertEqual(self.history[3].result, 'SUCCESS')
2444 self.assertEqual(self.history[4].result, 'SUCCESS')
2445 self.assertEqual(len(self.history), 5)
2446
James E. Blair400e8fd2015-07-30 17:44:45 -07002447 def test_live_reconfiguration_failed_job(self):
2448 # Test that a change with a removed failing job does not
2449 # disrupt reconfiguration. If a change has a failed job and
2450 # that job is removed during a reconfiguration, we observed a
2451 # bug where the code to re-set build statuses would run on
2452 # that build and raise an exception because the job no longer
2453 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002454 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002455
2456 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2457
2458 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002459 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002460
2461 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2462 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002463 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002464 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002465 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002466 self.waitUntilSettled()
2467
2468 self.assertEqual(A.data['status'], 'NEW')
2469 self.assertEqual(A.reported, 0)
2470
2471 self.assertEqual(self.getJobFromHistory('project-merge').result,
2472 'SUCCESS')
2473 self.assertEqual(self.getJobFromHistory('project-test1').result,
2474 'FAILURE')
2475 self.assertEqual(len(self.history), 2)
2476
2477 # Remove the test1 job.
Clint Byrum841a58c2017-05-01 14:17:21 -07002478 self.commitConfigUpdate('common-config',
2479 'layouts/live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002480 self.sched.reconfigure(self.config)
2481 self.waitUntilSettled()
2482
Paul Belanger174a8272017-03-14 13:20:10 -04002483 self.executor_server.hold_jobs_in_build = False
2484 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002485 self.waitUntilSettled()
2486
2487 self.assertEqual(self.getJobFromHistory('project-test2').result,
2488 'SUCCESS')
2489 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2490 'SUCCESS')
2491 self.assertEqual(len(self.history), 4)
2492
2493 self.assertEqual(A.data['status'], 'NEW')
2494 self.assertEqual(A.reported, 1)
2495 self.assertIn('Build succeeded', A.messages[0])
2496 # Ensure the removed job was not included in the report.
2497 self.assertNotIn('project-test1', A.messages[0])
2498
James E. Blairfe707d12015-08-05 15:18:15 -07002499 def test_live_reconfiguration_shared_queue(self):
2500 # Test that a change with a failing job which was removed from
2501 # this project but otherwise still exists in the system does
2502 # not disrupt reconfiguration.
2503
Paul Belanger174a8272017-03-14 13:20:10 -04002504 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002505
2506 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2507
Paul Belanger174a8272017-03-14 13:20:10 -04002508 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002509
2510 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2511 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002512 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002513 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002514 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002515 self.waitUntilSettled()
2516
2517 self.assertEqual(A.data['status'], 'NEW')
2518 self.assertEqual(A.reported, 0)
2519
Clint Byrum69663d42017-05-01 14:51:04 -07002520 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002521 'SUCCESS')
2522 self.assertEqual(self.getJobFromHistory(
2523 'project1-project2-integration').result, 'FAILURE')
2524 self.assertEqual(len(self.history), 2)
2525
2526 # Remove the integration job.
Clint Byrum69663d42017-05-01 14:51:04 -07002527 self.commitConfigUpdate(
2528 'common-config',
2529 'layouts/live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002530 self.sched.reconfigure(self.config)
2531 self.waitUntilSettled()
2532
Paul Belanger174a8272017-03-14 13:20:10 -04002533 self.executor_server.hold_jobs_in_build = False
2534 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002535 self.waitUntilSettled()
2536
Clint Byrum69663d42017-05-01 14:51:04 -07002537 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002538 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002539 self.assertEqual(self.getJobFromHistory('project-test1').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002540 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002541 self.assertEqual(self.getJobFromHistory('project-test2').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002542 'SUCCESS')
2543 self.assertEqual(self.getJobFromHistory(
2544 'project1-project2-integration').result, 'FAILURE')
2545 self.assertEqual(len(self.history), 4)
2546
2547 self.assertEqual(A.data['status'], 'NEW')
2548 self.assertEqual(A.reported, 1)
2549 self.assertIn('Build succeeded', A.messages[0])
2550 # Ensure the removed job was not included in the report.
2551 self.assertNotIn('project1-project2-integration', A.messages[0])
2552
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002553 def test_double_live_reconfiguration_shared_queue(self):
2554 # This was a real-world regression. A change is added to
2555 # gate; a reconfigure happens, a second change which depends
2556 # on the first is added, and a second reconfiguration happens.
2557 # Ensure that both changes merge.
2558
2559 # A failure may indicate incorrect caching or cleaning up of
2560 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002561 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002562
2563 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2564 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2565 B.setDependsOn(A, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07002566 A.addApproval('code-review', 2)
2567 B.addApproval('code-review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002568
2569 # Add the parent change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002570 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002571 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002572 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002573 self.waitUntilSettled()
2574
2575 # Reconfigure (with only one change in the pipeline).
2576 self.sched.reconfigure(self.config)
2577 self.waitUntilSettled()
2578
2579 # Add the child change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002580 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002581 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002582 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002583 self.waitUntilSettled()
2584
2585 # Reconfigure (with both in the pipeline).
2586 self.sched.reconfigure(self.config)
2587 self.waitUntilSettled()
2588
Paul Belanger174a8272017-03-14 13:20:10 -04002589 self.executor_server.hold_jobs_in_build = False
2590 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002591 self.waitUntilSettled()
2592
2593 self.assertEqual(len(self.history), 8)
2594
2595 self.assertEqual(A.data['status'], 'MERGED')
2596 self.assertEqual(A.reported, 2)
2597 self.assertEqual(B.data['status'], 'MERGED')
2598 self.assertEqual(B.reported, 2)
2599
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002600 def test_live_reconfiguration_del_project(self):
2601 # Test project deletion from layout
2602 # while changes are enqueued
2603
Paul Belanger174a8272017-03-14 13:20:10 -04002604 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002605 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2606 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2607 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2608
2609 # A Depends-On: B
2610 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2611 A.subject, B.data['id'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002612 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002613
2614 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2615 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2616 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002617 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002618 self.waitUntilSettled()
2619 self.assertEqual(len(self.builds), 5)
2620
2621 # This layout defines only org/project, not org/project1
James E. Blair31cb3e82017-04-20 13:08:56 -07002622 self.commitConfigUpdate(
2623 'common-config',
2624 'layouts/live-reconfiguration-del-project.yaml')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002625 self.sched.reconfigure(self.config)
2626 self.waitUntilSettled()
2627
2628 # Builds for C aborted, builds for A succeed,
2629 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002630 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002631 self.assertEqual(job_c.changes, '3,1')
2632 self.assertEqual(job_c.result, 'ABORTED')
2633
Paul Belanger174a8272017-03-14 13:20:10 -04002634 self.executor_server.hold_jobs_in_build = False
2635 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002636 self.waitUntilSettled()
2637
Clint Byrum0149ada2017-04-04 12:22:01 -07002638 self.assertEqual(
2639 self.getJobFromHistory('project-test1', 'org/project').changes,
2640 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002641
2642 self.assertEqual(A.data['status'], 'NEW')
2643 self.assertEqual(B.data['status'], 'NEW')
2644 self.assertEqual(C.data['status'], 'NEW')
2645 self.assertEqual(A.reported, 1)
2646 self.assertEqual(B.reported, 0)
2647 self.assertEqual(C.reported, 0)
2648
Clint Byrum0149ada2017-04-04 12:22:01 -07002649 tenant = self.sched.abide.tenants.get('tenant-one')
2650 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002651 self.assertIn('Build succeeded', A.messages[0])
2652
James E. Blairec056492016-07-22 09:45:56 -07002653 @skip("Disabled for early v3 development")
James E. Blair287c06d2013-07-24 10:39:30 -07002654 def test_delayed_repo_init(self):
James E. Blairf84026c2015-12-08 16:11:46 -08002655 self.updateConfigLayout(
2656 'tests/fixtures/layout-delayed-repo-init.yaml')
James E. Blair287c06d2013-07-24 10:39:30 -07002657 self.sched.reconfigure(self.config)
2658
2659 self.init_repo("org/new-project")
2660 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2661
James E. Blair8b5408c2016-08-08 15:37:46 -07002662 A.addApproval('code-review', 2)
2663 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002664 self.waitUntilSettled()
2665 self.assertEqual(self.getJobFromHistory('project-merge').result,
2666 'SUCCESS')
2667 self.assertEqual(self.getJobFromHistory('project-test1').result,
2668 'SUCCESS')
2669 self.assertEqual(self.getJobFromHistory('project-test2').result,
2670 'SUCCESS')
2671 self.assertEqual(A.data['status'], 'MERGED')
2672 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002673
James E. Blair9ea70072017-04-19 16:05:30 -07002674 @simple_layout('layouts/repo-deleted.yaml')
Clark Boylan6dbbc482013-10-18 10:57:31 -07002675 def test_repo_deleted(self):
Clark Boylan6dbbc482013-10-18 10:57:31 -07002676 self.init_repo("org/delete-project")
2677 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2678
James E. Blair8b5408c2016-08-08 15:37:46 -07002679 A.addApproval('code-review', 2)
2680 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002681 self.waitUntilSettled()
2682 self.assertEqual(self.getJobFromHistory('project-merge').result,
2683 'SUCCESS')
2684 self.assertEqual(self.getJobFromHistory('project-test1').result,
2685 'SUCCESS')
2686 self.assertEqual(self.getJobFromHistory('project-test2').result,
2687 'SUCCESS')
2688 self.assertEqual(A.data['status'], 'MERGED')
2689 self.assertEqual(A.reported, 2)
2690
2691 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002692 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002693 if os.path.exists(os.path.join(self.merger_src_root, p)):
2694 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002695 if os.path.exists(os.path.join(self.executor_src_root, p)):
2696 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002697
2698 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2699
James E. Blair8b5408c2016-08-08 15:37:46 -07002700 B.addApproval('code-review', 2)
2701 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002702 self.waitUntilSettled()
2703 self.assertEqual(self.getJobFromHistory('project-merge').result,
2704 'SUCCESS')
2705 self.assertEqual(self.getJobFromHistory('project-test1').result,
2706 'SUCCESS')
2707 self.assertEqual(self.getJobFromHistory('project-test2').result,
2708 'SUCCESS')
2709 self.assertEqual(B.data['status'], 'MERGED')
2710 self.assertEqual(B.reported, 2)
2711
James E. Blaire68d43f2017-04-19 14:03:30 -07002712 @simple_layout('layouts/tags.yaml')
James E. Blair456f2fb2016-02-09 09:29:33 -08002713 def test_tags(self):
2714 "Test job tags"
James E. Blair456f2fb2016-02-09 09:29:33 -08002715 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2716 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2717 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2718 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2719 self.waitUntilSettled()
2720
James E. Blaire68d43f2017-04-19 14:03:30 -07002721 self.assertEqual(len(self.history), 2)
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002722
2723 results = {self.getJobFromHistory('merge',
2724 project='org/project1').uuid: 'extratag merge',
2725 self.getJobFromHistory('merge',
2726 project='org/project2').uuid: 'merge'}
James E. Blair456f2fb2016-02-09 09:29:33 -08002727
2728 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002729 self.assertEqual(results.get(build.uuid, ''),
2730 build.parameters['vars']['zuul'].get('tags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08002731
James E. Blair63bb0ef2013-07-29 17:14:51 -07002732 def test_timer(self):
2733 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002734 # This test can not use simple_layout because it must start
2735 # with a configuration which does not include a
2736 # timer-triggered job so that we have an opportunity to set
2737 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002738 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002739 self.commitConfigUpdate('common-config', 'layouts/timer.yaml')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002740 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002741
Clark Boylan3ee090a2014-04-03 20:55:09 -07002742 # The pipeline triggers every second, so we should have seen
2743 # several by now.
2744 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002745 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07002746
2747 self.assertEqual(len(self.builds), 2)
2748
James E. Blair63bb0ef2013-07-29 17:14:51 -07002749 port = self.webapp.server.socket.getsockname()[1]
2750
Clint Byrum5e729e92017-02-08 06:34:57 -08002751 req = urllib.request.Request(
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002752 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002753 f = urllib.request.urlopen(req)
Clint Byrumf322fe22017-05-10 20:53:12 -07002754 data = f.read().decode('utf8')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002755
Paul Belanger174a8272017-03-14 13:20:10 -04002756 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07002757 # Stop queuing timer triggered jobs so that the assertions
2758 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002759 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002760 self.sched.reconfigure(self.config)
Paul Belanger174a8272017-03-14 13:20:10 -04002761 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07002762 self.waitUntilSettled()
2763
2764 self.assertEqual(self.getJobFromHistory(
2765 'project-bitrot-stable-old').result, 'SUCCESS')
2766 self.assertEqual(self.getJobFromHistory(
2767 'project-bitrot-stable-older').result, 'SUCCESS')
2768
2769 data = json.loads(data)
2770 status_jobs = set()
2771 for p in data['pipelines']:
2772 for q in p['change_queues']:
2773 for head in q['heads']:
2774 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07002775 for job in change['jobs']:
2776 status_jobs.add(job['name'])
2777 self.assertIn('project-bitrot-stable-old', status_jobs)
2778 self.assertIn('project-bitrot-stable-older', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002779
James E. Blair4f6033c2014-03-27 15:49:09 -07002780 def test_idle(self):
2781 "Test that frequent periodic jobs work"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002782 # This test can not use simple_layout because it must start
2783 # with a configuration which does not include a
2784 # timer-triggered job so that we have an opportunity to set
2785 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002786 self.executor_server.hold_jobs_in_build = True
James E. Blair4f6033c2014-03-27 15:49:09 -07002787
Clark Boylan3ee090a2014-04-03 20:55:09 -07002788 for x in range(1, 3):
2789 # Test that timer triggers periodic jobs even across
2790 # layout config reloads.
2791 # Start timer trigger
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002792 self.commitConfigUpdate('common-config',
2793 'layouts/idle.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002794 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002795 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07002796
Clark Boylan3ee090a2014-04-03 20:55:09 -07002797 # The pipeline triggers every second, so we should have seen
2798 # several by now.
2799 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07002800
2801 # Stop queuing timer triggered jobs so that the assertions
2802 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002803 self.commitConfigUpdate('common-config',
2804 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002805 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002806 self.waitUntilSettled()
Clint Byrum58264dc2017-02-07 21:21:22 -08002807 self.assertEqual(len(self.builds), 2,
2808 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04002809 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002810 self.waitUntilSettled()
2811 self.assertEqual(len(self.builds), 0)
2812 self.assertEqual(len(self.history), x * 2)
James E. Blair4f6033c2014-03-27 15:49:09 -07002813
James E. Blaircc324192017-04-19 14:36:08 -07002814 @simple_layout('layouts/smtp.yaml')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002815 def test_check_smtp_pool(self):
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002816 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2817 self.waitUntilSettled()
2818
2819 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2820 self.waitUntilSettled()
2821
James E. Blairff80a2f2013-12-27 13:24:06 -08002822 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002823
2824 # A.messages only holds what FakeGerrit places in it. Thus we
2825 # work on the knowledge of what the first message should be as
2826 # it is only configured to go to SMTP.
2827
2828 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002829 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002830 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002831 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002832 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08002833 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002834
2835 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002836 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002837 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002838 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002839 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08002840 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08002841
James E. Blaire5910202013-12-27 09:50:31 -08002842 def test_timer_smtp(self):
2843 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002844 # This test can not use simple_layout because it must start
2845 # with a configuration which does not include a
2846 # timer-triggered job so that we have an opportunity to set
2847 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002848 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002849 self.commitConfigUpdate('common-config', 'layouts/timer-smtp.yaml')
James E. Blaire5910202013-12-27 09:50:31 -08002850 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08002851
Clark Boylan3ee090a2014-04-03 20:55:09 -07002852 # The pipeline triggers every second, so we should have seen
2853 # several by now.
2854 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08002855 self.waitUntilSettled()
2856
Clark Boylan3ee090a2014-04-03 20:55:09 -07002857 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04002858 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002859 self.waitUntilSettled()
2860 self.assertEqual(len(self.history), 2)
2861
James E. Blaire5910202013-12-27 09:50:31 -08002862 self.assertEqual(self.getJobFromHistory(
2863 'project-bitrot-stable-old').result, 'SUCCESS')
2864 self.assertEqual(self.getJobFromHistory(
2865 'project-bitrot-stable-older').result, 'SUCCESS')
2866
James E. Blairff80a2f2013-12-27 13:24:06 -08002867 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08002868
2869 # A.messages only holds what FakeGerrit places in it. Thus we
2870 # work on the knowledge of what the first message should be as
2871 # it is only configured to go to SMTP.
2872
2873 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002874 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002875 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002876 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002877 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08002878 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08002879
Clark Boylan3ee090a2014-04-03 20:55:09 -07002880 # Stop queuing timer triggered jobs and let any that may have
2881 # queued through so that end of test assertions pass.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002882 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002883 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07002884 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002885 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002886 self.waitUntilSettled()
2887
Joshua Hesketh25695cb2017-03-06 12:50:04 +11002888 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00002889 def test_timer_sshkey(self):
2890 "Test that a periodic job can setup SSH key authentication"
2891 self.worker.hold_jobs_in_build = True
2892 self.config.set('zuul', 'layout_config',
2893 'tests/fixtures/layout-timer.yaml')
2894 self.sched.reconfigure(self.config)
2895 self.registerJobs()
2896
2897 # The pipeline triggers every second, so we should have seen
2898 # several by now.
2899 time.sleep(5)
2900 self.waitUntilSettled()
2901
2902 self.assertEqual(len(self.builds), 2)
2903
2904 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
2905 self.assertTrue(os.path.isfile(ssh_wrapper))
2906 with open(ssh_wrapper) as f:
2907 ssh_wrapper_content = f.read()
2908 self.assertIn("fake_id_rsa", ssh_wrapper_content)
2909 # In the unit tests Merger runs in the same process,
2910 # so we see its' environment variables
2911 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
2912
2913 self.worker.release('.*')
2914 self.waitUntilSettled()
2915 self.assertEqual(len(self.history), 2)
2916
2917 self.assertEqual(self.getJobFromHistory(
2918 'project-bitrot-stable-old').result, 'SUCCESS')
2919 self.assertEqual(self.getJobFromHistory(
2920 'project-bitrot-stable-older').result, 'SUCCESS')
2921
2922 # Stop queuing timer triggered jobs and let any that may have
2923 # queued through so that end of test assertions pass.
2924 self.config.set('zuul', 'layout_config',
2925 'tests/fixtures/layout-no-timer.yaml')
2926 self.sched.reconfigure(self.config)
2927 self.registerJobs()
2928 self.waitUntilSettled()
2929 self.worker.release('.*')
2930 self.waitUntilSettled()
2931
James E. Blair91e34592015-07-31 16:45:59 -07002932 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08002933 "Test that the RPC client can enqueue a change"
2934 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002935 A.addApproval('code-review', 2)
2936 A.addApproval('approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08002937
2938 client = zuul.rpcclient.RPCClient('127.0.0.1',
2939 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002940 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04002941 r = client.enqueue(tenant='tenant-one',
2942 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002943 project='org/project',
2944 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002945 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002946 self.waitUntilSettled()
2947 self.assertEqual(self.getJobFromHistory('project-merge').result,
2948 'SUCCESS')
2949 self.assertEqual(self.getJobFromHistory('project-test1').result,
2950 'SUCCESS')
2951 self.assertEqual(self.getJobFromHistory('project-test2').result,
2952 'SUCCESS')
2953 self.assertEqual(A.data['status'], 'MERGED')
2954 self.assertEqual(A.reported, 2)
2955 self.assertEqual(r, True)
2956
James E. Blair91e34592015-07-31 16:45:59 -07002957 def test_client_enqueue_ref(self):
2958 "Test that the RPC client can enqueue a ref"
2959
2960 client = zuul.rpcclient.RPCClient('127.0.0.1',
2961 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002962 self.addCleanup(client.shutdown)
James E. Blair91e34592015-07-31 16:45:59 -07002963 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04002964 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07002965 pipeline='post',
2966 project='org/project',
2967 trigger='gerrit',
2968 ref='master',
2969 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
2970 newrev='d479a0bfcb34da57a31adb2a595c0cf687812543')
2971 self.waitUntilSettled()
2972 job_names = [x.name for x in self.history]
2973 self.assertEqual(len(self.history), 1)
2974 self.assertIn('project-post', job_names)
2975 self.assertEqual(r, True)
2976
James E. Blairad28e912013-11-27 10:43:22 -08002977 def test_client_enqueue_negative(self):
2978 "Test that the RPC client returns errors"
2979 client = zuul.rpcclient.RPCClient('127.0.0.1',
2980 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002981 self.addCleanup(client.shutdown)
James E. Blairad28e912013-11-27 10:43:22 -08002982 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04002983 "Invalid tenant"):
2984 r = client.enqueue(tenant='tenant-foo',
2985 pipeline='gate',
2986 project='org/project',
2987 trigger='gerrit',
2988 change='1,1')
Paul Belangerbaca3132016-11-04 12:49:54 -04002989 self.assertEqual(r, False)
2990
2991 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08002992 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002993 r = client.enqueue(tenant='tenant-one',
2994 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002995 project='project-does-not-exist',
2996 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002997 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002998 self.assertEqual(r, False)
2999
3000 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3001 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003002 r = client.enqueue(tenant='tenant-one',
3003 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08003004 project='org/project',
3005 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003006 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003007 self.assertEqual(r, False)
3008
3009 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3010 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003011 r = client.enqueue(tenant='tenant-one',
3012 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003013 project='org/project',
3014 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08003015 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003016 self.assertEqual(r, False)
3017
3018 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
3019 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04003020 r = client.enqueue(tenant='tenant-one',
3021 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08003022 project='org/project',
3023 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08003024 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08003025 self.assertEqual(r, False)
3026
3027 self.waitUntilSettled()
3028 self.assertEqual(len(self.history), 0)
3029 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08003030
3031 def test_client_promote(self):
3032 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04003033 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003034 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3035 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3036 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003037 A.addApproval('code-review', 2)
3038 B.addApproval('code-review', 2)
3039 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003040
James E. Blair8b5408c2016-08-08 15:37:46 -07003041 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3042 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3043 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003044
3045 self.waitUntilSettled()
3046
Paul Belangerbaca3132016-11-04 12:49:54 -04003047 tenant = self.sched.abide.tenants.get('tenant-one')
3048 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003049 enqueue_times = {}
3050 for item in items:
3051 enqueue_times[str(item.change)] = item.enqueue_time
3052
James E. Blair36658cf2013-12-06 17:53:48 -08003053 client = zuul.rpcclient.RPCClient('127.0.0.1',
3054 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003055 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003056 r = client.promote(tenant='tenant-one',
3057 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003058 change_ids=['2,1', '3,1'])
3059
Sean Daguef39b9ca2014-01-10 21:34:35 -05003060 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003061 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003062 for item in items:
3063 self.assertEqual(
3064 enqueue_times[str(item.change)], item.enqueue_time)
3065
James E. Blair78acec92014-02-06 07:11:32 -08003066 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003067 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003068 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003069 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003070 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003071 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003072 self.waitUntilSettled()
3073
3074 self.assertEqual(len(self.builds), 6)
3075 self.assertEqual(self.builds[0].name, 'project-test1')
3076 self.assertEqual(self.builds[1].name, 'project-test2')
3077 self.assertEqual(self.builds[2].name, 'project-test1')
3078 self.assertEqual(self.builds[3].name, 'project-test2')
3079 self.assertEqual(self.builds[4].name, 'project-test1')
3080 self.assertEqual(self.builds[5].name, 'project-test2')
3081
Paul Belangerbaca3132016-11-04 12:49:54 -04003082 self.assertTrue(self.builds[0].hasChanges(B))
3083 self.assertFalse(self.builds[0].hasChanges(A))
3084 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003085
Paul Belangerbaca3132016-11-04 12:49:54 -04003086 self.assertTrue(self.builds[2].hasChanges(B))
3087 self.assertTrue(self.builds[2].hasChanges(C))
3088 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003089
Paul Belangerbaca3132016-11-04 12:49:54 -04003090 self.assertTrue(self.builds[4].hasChanges(B))
3091 self.assertTrue(self.builds[4].hasChanges(C))
3092 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003093
Paul Belanger174a8272017-03-14 13:20:10 -04003094 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003095 self.waitUntilSettled()
3096
3097 self.assertEqual(A.data['status'], 'MERGED')
3098 self.assertEqual(A.reported, 2)
3099 self.assertEqual(B.data['status'], 'MERGED')
3100 self.assertEqual(B.reported, 2)
3101 self.assertEqual(C.data['status'], 'MERGED')
3102 self.assertEqual(C.reported, 2)
3103
James E. Blair36658cf2013-12-06 17:53:48 -08003104 self.assertEqual(r, True)
3105
3106 def test_client_promote_dependent(self):
3107 "Test that the RPC client can promote a dependent change"
3108 # C (depends on B) -> B -> A ; then promote C to get:
3109 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003110 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003111 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3112 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3113 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3114
3115 C.setDependsOn(B, 1)
3116
James E. Blair8b5408c2016-08-08 15:37:46 -07003117 A.addApproval('code-review', 2)
3118 B.addApproval('code-review', 2)
3119 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003120
James E. Blair8b5408c2016-08-08 15:37:46 -07003121 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3122 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3123 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003124
3125 self.waitUntilSettled()
3126
3127 client = zuul.rpcclient.RPCClient('127.0.0.1',
3128 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003129 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003130 r = client.promote(tenant='tenant-one',
3131 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003132 change_ids=['3,1'])
3133
James E. Blair78acec92014-02-06 07:11:32 -08003134 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003135 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003136 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003137 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003138 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003139 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003140 self.waitUntilSettled()
3141
3142 self.assertEqual(len(self.builds), 6)
3143 self.assertEqual(self.builds[0].name, 'project-test1')
3144 self.assertEqual(self.builds[1].name, 'project-test2')
3145 self.assertEqual(self.builds[2].name, 'project-test1')
3146 self.assertEqual(self.builds[3].name, 'project-test2')
3147 self.assertEqual(self.builds[4].name, 'project-test1')
3148 self.assertEqual(self.builds[5].name, 'project-test2')
3149
Paul Belangerbaca3132016-11-04 12:49:54 -04003150 self.assertTrue(self.builds[0].hasChanges(B))
3151 self.assertFalse(self.builds[0].hasChanges(A))
3152 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003153
Paul Belangerbaca3132016-11-04 12:49:54 -04003154 self.assertTrue(self.builds[2].hasChanges(B))
3155 self.assertTrue(self.builds[2].hasChanges(C))
3156 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003157
Paul Belangerbaca3132016-11-04 12:49:54 -04003158 self.assertTrue(self.builds[4].hasChanges(B))
3159 self.assertTrue(self.builds[4].hasChanges(C))
3160 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003161
Paul Belanger174a8272017-03-14 13:20:10 -04003162 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003163 self.waitUntilSettled()
3164
3165 self.assertEqual(A.data['status'], 'MERGED')
3166 self.assertEqual(A.reported, 2)
3167 self.assertEqual(B.data['status'], 'MERGED')
3168 self.assertEqual(B.reported, 2)
3169 self.assertEqual(C.data['status'], 'MERGED')
3170 self.assertEqual(C.reported, 2)
3171
James E. Blair36658cf2013-12-06 17:53:48 -08003172 self.assertEqual(r, True)
3173
3174 def test_client_promote_negative(self):
3175 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003176 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003177 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003178 A.addApproval('code-review', 2)
3179 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003180 self.waitUntilSettled()
3181
3182 client = zuul.rpcclient.RPCClient('127.0.0.1',
3183 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003184 self.addCleanup(client.shutdown)
James E. Blair36658cf2013-12-06 17:53:48 -08003185
3186 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003187 r = client.promote(tenant='tenant-one',
3188 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003189 change_ids=['2,1', '3,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003190 self.assertEqual(r, False)
3191
3192 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003193 r = client.promote(tenant='tenant-one',
3194 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003195 change_ids=['4,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003196 self.assertEqual(r, False)
3197
Paul Belanger174a8272017-03-14 13:20:10 -04003198 self.executor_server.hold_jobs_in_build = False
3199 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003200 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003201
James E. Blaircc324192017-04-19 14:36:08 -07003202 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003203 def test_queue_rate_limiting(self):
3204 "Test that DependentPipelines are rate limited with dep across window"
Paul Belanger174a8272017-03-14 13:20:10 -04003205 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003206 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3207 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3208 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3209
3210 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003211 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003212
James E. Blair8b5408c2016-08-08 15:37:46 -07003213 A.addApproval('code-review', 2)
3214 B.addApproval('code-review', 2)
3215 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003216
James E. Blair8b5408c2016-08-08 15:37:46 -07003217 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3218 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3219 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003220 self.waitUntilSettled()
3221
3222 # Only A and B will have their merge jobs queued because
3223 # window is 2.
3224 self.assertEqual(len(self.builds), 2)
3225 self.assertEqual(self.builds[0].name, 'project-merge')
3226 self.assertEqual(self.builds[1].name, 'project-merge')
3227
James E. Blair732ee862017-04-21 07:49:26 -07003228 # Release the merge jobs one at a time.
3229 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003230 self.waitUntilSettled()
James E. Blair732ee862017-04-21 07:49:26 -07003231 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003232 self.waitUntilSettled()
3233
3234 # Only A and B will have their test jobs queued because
3235 # window is 2.
3236 self.assertEqual(len(self.builds), 4)
3237 self.assertEqual(self.builds[0].name, 'project-test1')
3238 self.assertEqual(self.builds[1].name, 'project-test2')
3239 self.assertEqual(self.builds[2].name, 'project-test1')
3240 self.assertEqual(self.builds[3].name, 'project-test2')
3241
Paul Belanger174a8272017-03-14 13:20:10 -04003242 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003243 self.waitUntilSettled()
3244
James E. Blaircc324192017-04-19 14:36:08 -07003245 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003246 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003247 # A failed so window is reduced by 1 to 1.
3248 self.assertEqual(queue.window, 1)
3249 self.assertEqual(queue.window_floor, 1)
3250 self.assertEqual(A.data['status'], 'NEW')
3251
3252 # Gate is reset and only B's merge job is queued because
3253 # window shrunk to 1.
3254 self.assertEqual(len(self.builds), 1)
3255 self.assertEqual(self.builds[0].name, 'project-merge')
3256
Paul Belanger174a8272017-03-14 13:20:10 -04003257 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003258 self.waitUntilSettled()
3259
3260 # Only B's test jobs are queued because window is still 1.
3261 self.assertEqual(len(self.builds), 2)
3262 self.assertEqual(self.builds[0].name, 'project-test1')
3263 self.assertEqual(self.builds[1].name, 'project-test2')
3264
Paul Belanger174a8272017-03-14 13:20:10 -04003265 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003266 self.waitUntilSettled()
3267
3268 # B was successfully merged so window is increased to 2.
3269 self.assertEqual(queue.window, 2)
3270 self.assertEqual(queue.window_floor, 1)
3271 self.assertEqual(B.data['status'], 'MERGED')
3272
3273 # Only C is left and its merge job is queued.
3274 self.assertEqual(len(self.builds), 1)
3275 self.assertEqual(self.builds[0].name, 'project-merge')
3276
Paul Belanger174a8272017-03-14 13:20:10 -04003277 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003278 self.waitUntilSettled()
3279
3280 # After successful merge job the test jobs for C are queued.
3281 self.assertEqual(len(self.builds), 2)
3282 self.assertEqual(self.builds[0].name, 'project-test1')
3283 self.assertEqual(self.builds[1].name, 'project-test2')
3284
Paul Belanger174a8272017-03-14 13:20:10 -04003285 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003286 self.waitUntilSettled()
3287
3288 # C successfully merged so window is bumped to 3.
3289 self.assertEqual(queue.window, 3)
3290 self.assertEqual(queue.window_floor, 1)
3291 self.assertEqual(C.data['status'], 'MERGED')
3292
James E. Blaircc324192017-04-19 14:36:08 -07003293 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003294 def test_queue_rate_limiting_dependent(self):
3295 "Test that DependentPipelines are rate limited with dep in window"
Paul Belanger174a8272017-03-14 13:20:10 -04003296 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003297 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3298 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3299 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3300
3301 B.setDependsOn(A, 1)
3302
Paul Belanger174a8272017-03-14 13:20:10 -04003303 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003304
James E. Blair8b5408c2016-08-08 15:37:46 -07003305 A.addApproval('code-review', 2)
3306 B.addApproval('code-review', 2)
3307 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003308
James E. Blair8b5408c2016-08-08 15:37:46 -07003309 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3310 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3311 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003312 self.waitUntilSettled()
3313
3314 # Only A and B will have their merge jobs queued because
3315 # window is 2.
3316 self.assertEqual(len(self.builds), 2)
3317 self.assertEqual(self.builds[0].name, 'project-merge')
3318 self.assertEqual(self.builds[1].name, 'project-merge')
3319
James E. Blairf4a5f022017-04-18 14:01:10 -07003320 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003321
3322 # Only A and B will have their test jobs queued because
3323 # window is 2.
3324 self.assertEqual(len(self.builds), 4)
3325 self.assertEqual(self.builds[0].name, 'project-test1')
3326 self.assertEqual(self.builds[1].name, 'project-test2')
3327 self.assertEqual(self.builds[2].name, 'project-test1')
3328 self.assertEqual(self.builds[3].name, 'project-test2')
3329
Paul Belanger174a8272017-03-14 13:20:10 -04003330 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003331 self.waitUntilSettled()
3332
James E. Blaircc324192017-04-19 14:36:08 -07003333 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003334 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003335 # A failed so window is reduced by 1 to 1.
3336 self.assertEqual(queue.window, 1)
3337 self.assertEqual(queue.window_floor, 1)
3338 self.assertEqual(A.data['status'], 'NEW')
3339 self.assertEqual(B.data['status'], 'NEW')
3340
3341 # Gate is reset and only C's merge job is queued because
3342 # window shrunk to 1 and A and B were dequeued.
3343 self.assertEqual(len(self.builds), 1)
3344 self.assertEqual(self.builds[0].name, 'project-merge')
3345
James E. Blairf4a5f022017-04-18 14:01:10 -07003346 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003347
3348 # Only C's test jobs are queued because window is still 1.
3349 self.assertEqual(len(self.builds), 2)
3350 self.assertEqual(self.builds[0].name, 'project-test1')
3351 self.assertEqual(self.builds[1].name, 'project-test2')
3352
Paul Belanger174a8272017-03-14 13:20:10 -04003353 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003354 self.waitUntilSettled()
3355
3356 # C was successfully merged so window is increased to 2.
3357 self.assertEqual(queue.window, 2)
3358 self.assertEqual(queue.window_floor, 1)
3359 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003360
3361 def test_worker_update_metadata(self):
3362 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003363 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003364
3365 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003366 A.addApproval('code-review', 2)
3367 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003368 self.waitUntilSettled()
3369
Clint Byrumd4de79a2017-05-27 11:39:13 -07003370 self.assertEqual(len(self.executor_client.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003371
3372 self.log.debug('Current builds:')
Clint Byrumd4de79a2017-05-27 11:39:13 -07003373 self.log.debug(self.executor_client.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003374
3375 start = time.time()
3376 while True:
3377 if time.time() - start > 10:
3378 raise Exception("Timeout waiting for gearman server to report "
3379 + "back to the client")
Clint Byrumd4de79a2017-05-27 11:39:13 -07003380 build = list(self.executor_client.builds.values())[0]
Joshua Heskethba8776a2014-01-12 14:35:40 +08003381 if build.worker.name == "My Worker":
3382 break
3383 else:
3384 time.sleep(0)
3385
3386 self.log.debug(build)
3387 self.assertEqual("My Worker", build.worker.name)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003388
Paul Belanger174a8272017-03-14 13:20:10 -04003389 self.executor_server.hold_jobs_in_build = False
3390 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003391 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003392
James E. Blaircc324192017-04-19 14:36:08 -07003393 @simple_layout('layouts/footer-message.yaml')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003394 def test_footer_message(self):
3395 "Test a pipeline's footer message is correctly added to the report."
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003396 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003397 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003398 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003399 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003400 self.waitUntilSettled()
3401
3402 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003403 B.addApproval('code-review', 2)
3404 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003405 self.waitUntilSettled()
3406
3407 self.assertEqual(2, len(self.smtp_messages))
3408
Adam Gandelman82258fd2017-02-07 16:51:58 -08003409 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003410Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003411http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003412
Adam Gandelman82258fd2017-02-07 16:51:58 -08003413 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003414For CI problems and help debugging, contact ci@example.org"""
3415
Adam Gandelman82258fd2017-02-07 16:51:58 -08003416 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3417 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3418 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3419 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003420
Tobias Henkel9842bd72017-05-16 13:40:03 +02003421 @simple_layout('layouts/unmanaged-project.yaml')
3422 def test_unmanaged_project_start_message(self):
3423 "Test start reporting is not done for unmanaged projects."
3424 self.init_repo("org/project", tag='init')
3425 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3426 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3427 self.waitUntilSettled()
3428
3429 self.assertEqual(0, len(A.messages))
3430
Clint Byrumb9de8be2017-05-27 13:49:19 -07003431 @simple_layout('layouts/merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003432 def test_merge_failure_reporters(self):
3433 """Check that the config is set up correctly"""
3434
Clint Byrumb9de8be2017-05-27 13:49:19 -07003435 tenant = self.sched.abide.tenants.get('tenant-one')
Joshua Heskethb7179772014-01-30 23:30:46 +11003436 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003437 "Merge Failed.\n\nThis change or one of its cross-repo "
3438 "dependencies was unable to be automatically merged with the "
3439 "current state of its repository. Please rebase the change and "
3440 "upload a new patchset.",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003441 tenant.layout.pipelines['check'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003442 self.assertEqual(
3443 "The merge failed! For more information...",
Clint Byrumb9de8be2017-05-27 13:49:19 -07003444 tenant.layout.pipelines['gate'].merge_failure_message)
Joshua Heskethb7179772014-01-30 23:30:46 +11003445
3446 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003447 len(tenant.layout.pipelines['check'].merge_failure_actions), 1)
Joshua Heskethb7179772014-01-30 23:30:46 +11003448 self.assertEqual(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003449 len(tenant.layout.pipelines['gate'].merge_failure_actions), 2)
Joshua Heskethb7179772014-01-30 23:30:46 +11003450
3451 self.assertTrue(isinstance(
Clint Byrumb9de8be2017-05-27 13:49:19 -07003452 tenant.layout.pipelines['check'].merge_failure_actions[0],
3453 gerritreporter.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003454
3455 self.assertTrue(
3456 (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003457 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003458 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003459 zuul.driver.smtp.smtpreporter.SMTPReporter) and
3460 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003461 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003462 gerritreporter.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003463 ) or (
Clint Byrumb9de8be2017-05-27 13:49:19 -07003464 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003465 merge_failure_actions[0],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003466 gerritreporter.GerritReporter) and
3467 isinstance(tenant.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003468 merge_failure_actions[1],
Clint Byrumb9de8be2017-05-27 13:49:19 -07003469 zuul.driver.smtp.smtpreporter.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003470 )
3471 )
3472
James E. Blairec056492016-07-22 09:45:56 -07003473 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003474 def test_merge_failure_reports(self):
3475 """Check that when a change fails to merge the correct message is sent
3476 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003477 self.updateConfigLayout(
3478 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003479 self.sched.reconfigure(self.config)
3480 self.registerJobs()
3481
3482 # Check a test failure isn't reported to SMTP
3483 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003484 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003485 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003486 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003487 self.waitUntilSettled()
3488
3489 self.assertEqual(3, len(self.history)) # 3 jobs
3490 self.assertEqual(0, len(self.smtp_messages))
3491
3492 # Check a merge failure is reported to SMTP
3493 # B should be merged, but C will conflict with B
3494 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3495 B.addPatchset(['conflict'])
3496 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3497 C.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003498 B.addApproval('code-review', 2)
3499 C.addApproval('code-review', 2)
3500 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3501 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003502 self.waitUntilSettled()
3503
3504 self.assertEqual(6, len(self.history)) # A and B jobs
3505 self.assertEqual(1, len(self.smtp_messages))
3506 self.assertEqual('The merge failed! For more information...',
3507 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003508
James E. Blairec056492016-07-22 09:45:56 -07003509 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003510 def test_default_merge_failure_reports(self):
3511 """Check that the default merge failure reports are correct."""
3512
3513 # A should report success, B should report merge failure.
3514 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3515 A.addPatchset(['conflict'])
3516 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3517 B.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003518 A.addApproval('code-review', 2)
3519 B.addApproval('code-review', 2)
3520 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3521 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003522 self.waitUntilSettled()
3523
3524 self.assertEqual(3, len(self.history)) # A jobs
3525 self.assertEqual(A.reported, 2)
3526 self.assertEqual(B.reported, 2)
3527 self.assertEqual(A.data['status'], 'MERGED')
3528 self.assertEqual(B.data['status'], 'NEW')
3529 self.assertIn('Build succeeded', A.messages[1])
3530 self.assertIn('Merge Failed', B.messages[1])
3531 self.assertIn('automatically merged', B.messages[1])
3532 self.assertNotIn('logs.example.com', B.messages[1])
3533 self.assertNotIn('SKIPPED', B.messages[1])
3534
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003535 def test_client_get_running_jobs(self):
3536 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003537 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003538 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003539 A.addApproval('code-review', 2)
3540 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003541 self.waitUntilSettled()
3542
3543 client = zuul.rpcclient.RPCClient('127.0.0.1',
3544 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003545 self.addCleanup(client.shutdown)
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003546
3547 # Wait for gearman server to send the initial workData back to zuul
3548 start = time.time()
3549 while True:
3550 if time.time() - start > 10:
3551 raise Exception("Timeout waiting for gearman server to report "
3552 + "back to the client")
Clint Byrum1d0c7d12017-05-10 19:40:53 -07003553 build = list(self.executor_client.builds.values())[0]
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003554 if build.worker.name == "My Worker":
3555 break
3556 else:
3557 time.sleep(0)
3558
3559 running_items = client.get_running_jobs()
3560
3561 self.assertEqual(1, len(running_items))
3562 running_item = running_items[0]
3563 self.assertEqual([], running_item['failing_reasons'])
3564 self.assertEqual([], running_item['items_behind'])
3565 self.assertEqual('https://hostname/1', running_item['url'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003566 self.assertIsNone(running_item['item_ahead'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003567 self.assertEqual('org/project', running_item['project'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003568 self.assertIsNone(running_item['remaining_time'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003569 self.assertEqual(True, running_item['active'])
3570 self.assertEqual('1,1', running_item['id'])
3571
3572 self.assertEqual(3, len(running_item['jobs']))
3573 for job in running_item['jobs']:
3574 if job['name'] == 'project-merge':
3575 self.assertEqual('project-merge', job['name'])
3576 self.assertEqual('gate', job['pipeline'])
3577 self.assertEqual(False, job['retry'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003578 self.assertEqual('https://server/job/project-merge/0/',
3579 job['url'])
Clint Byrumd4de79a2017-05-27 11:39:13 -07003580 self.assertEqual(2, len(job['worker']))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003581 self.assertEqual(False, job['canceled'])
3582 self.assertEqual(True, job['voting'])
Monty Taylor38b553a2017-06-05 13:06:10 -05003583 self.assertIsNone(job['result'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003584 self.assertEqual('gate', job['pipeline'])
3585 break
3586
Paul Belanger174a8272017-03-14 13:20:10 -04003587 self.executor_server.hold_jobs_in_build = False
3588 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003589 self.waitUntilSettled()
3590
3591 running_items = client.get_running_jobs()
3592 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003593
James E. Blairb70e55a2017-04-19 12:57:02 -07003594 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003595 def test_nonvoting_pipeline(self):
3596 "Test that a nonvoting pipeline (experimental) can still report"
3597
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003598 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3599 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003600 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3601 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003602
3603 self.assertEqual(self.getJobFromHistory('project-merge').result,
3604 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003605 self.assertEqual(
3606 self.getJobFromHistory('experimental-project-test').result,
3607 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003608 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003609
3610 def test_crd_gate(self):
3611 "Test cross-repo dependencies"
3612 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3613 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003614 A.addApproval('code-review', 2)
3615 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003616
3617 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3618 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3619 AM2.setMerged()
3620 AM1.setMerged()
3621
3622 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3623 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3624 BM2.setMerged()
3625 BM1.setMerged()
3626
3627 # A -> AM1 -> AM2
3628 # B -> BM1 -> BM2
3629 # A Depends-On: B
3630 # M2 is here to make sure it is never queried. If it is, it
3631 # means zuul is walking down the entire history of merged
3632 # changes.
3633
3634 B.setDependsOn(BM1, 1)
3635 BM1.setDependsOn(BM2, 1)
3636
3637 A.setDependsOn(AM1, 1)
3638 AM1.setDependsOn(AM2, 1)
3639
3640 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3641 A.subject, B.data['id'])
3642
James E. Blair8b5408c2016-08-08 15:37:46 -07003643 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003644 self.waitUntilSettled()
3645
3646 self.assertEqual(A.data['status'], 'NEW')
3647 self.assertEqual(B.data['status'], 'NEW')
3648
Paul Belanger5dccbe72016-11-14 11:17:37 -05003649 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11003650 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003651
Paul Belanger174a8272017-03-14 13:20:10 -04003652 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003653 B.addApproval('approved', 1)
3654 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003655 self.waitUntilSettled()
3656
Paul Belanger174a8272017-03-14 13:20:10 -04003657 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003658 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003659 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003660 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003661 self.executor_server.hold_jobs_in_build = False
3662 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003663 self.waitUntilSettled()
3664
3665 self.assertEqual(AM2.queried, 0)
3666 self.assertEqual(BM2.queried, 0)
3667 self.assertEqual(A.data['status'], 'MERGED')
3668 self.assertEqual(B.data['status'], 'MERGED')
3669 self.assertEqual(A.reported, 2)
3670 self.assertEqual(B.reported, 2)
3671
Paul Belanger5dccbe72016-11-14 11:17:37 -05003672 changes = self.getJobFromHistory(
3673 'project-merge', 'org/project1').changes
3674 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003675
3676 def test_crd_branch(self):
3677 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003678
3679 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003680 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3681 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3682 C = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C')
3683 C.data['id'] = B.data['id']
James E. Blair8b5408c2016-08-08 15:37:46 -07003684 A.addApproval('code-review', 2)
3685 B.addApproval('code-review', 2)
3686 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003687
3688 # A Depends-On: B+C
3689 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3690 A.subject, B.data['id'])
3691
Paul Belanger174a8272017-03-14 13:20:10 -04003692 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003693 B.addApproval('approved', 1)
3694 C.addApproval('approved', 1)
3695 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003696 self.waitUntilSettled()
3697
Paul Belanger174a8272017-03-14 13:20:10 -04003698 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003699 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003700 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003701 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003702 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003703 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003704 self.executor_server.hold_jobs_in_build = False
3705 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003706 self.waitUntilSettled()
3707
3708 self.assertEqual(A.data['status'], 'MERGED')
3709 self.assertEqual(B.data['status'], 'MERGED')
3710 self.assertEqual(C.data['status'], 'MERGED')
3711 self.assertEqual(A.reported, 2)
3712 self.assertEqual(B.reported, 2)
3713 self.assertEqual(C.reported, 2)
3714
Paul Belanger6379db12016-11-14 13:57:54 -05003715 changes = self.getJobFromHistory(
3716 'project-merge', 'org/project1').changes
3717 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003718
3719 def test_crd_multiline(self):
3720 "Test multiple depends-on lines in commit"
3721 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3722 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3723 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003724 A.addApproval('code-review', 2)
3725 B.addApproval('code-review', 2)
3726 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003727
3728 # A Depends-On: B+C
3729 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
3730 A.subject, B.data['id'], C.data['id'])
3731
Paul Belanger174a8272017-03-14 13:20:10 -04003732 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003733 B.addApproval('approved', 1)
3734 C.addApproval('approved', 1)
3735 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003736 self.waitUntilSettled()
3737
Paul Belanger174a8272017-03-14 13:20:10 -04003738 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003739 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003740 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003741 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003742 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003743 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003744 self.executor_server.hold_jobs_in_build = False
3745 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003746 self.waitUntilSettled()
3747
3748 self.assertEqual(A.data['status'], 'MERGED')
3749 self.assertEqual(B.data['status'], 'MERGED')
3750 self.assertEqual(C.data['status'], 'MERGED')
3751 self.assertEqual(A.reported, 2)
3752 self.assertEqual(B.reported, 2)
3753 self.assertEqual(C.reported, 2)
3754
Paul Belanger5dccbe72016-11-14 11:17:37 -05003755 changes = self.getJobFromHistory(
3756 'project-merge', 'org/project1').changes
3757 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08003758
3759 def test_crd_unshared_gate(self):
3760 "Test cross-repo dependencies in unshared gate queues"
3761 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3762 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003763 A.addApproval('code-review', 2)
3764 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003765
3766 # A Depends-On: B
3767 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3768 A.subject, B.data['id'])
3769
3770 # A and B do not share a queue, make sure that A is unable to
3771 # enqueue B (and therefore, A is unable to be enqueued).
James E. Blair8b5408c2016-08-08 15:37:46 -07003772 B.addApproval('approved', 1)
3773 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003774 self.waitUntilSettled()
3775
3776 self.assertEqual(A.data['status'], 'NEW')
3777 self.assertEqual(B.data['status'], 'NEW')
3778 self.assertEqual(A.reported, 0)
3779 self.assertEqual(B.reported, 0)
3780 self.assertEqual(len(self.history), 0)
3781
3782 # Enqueue and merge B alone.
James E. Blair8b5408c2016-08-08 15:37:46 -07003783 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003784 self.waitUntilSettled()
3785
3786 self.assertEqual(B.data['status'], 'MERGED')
3787 self.assertEqual(B.reported, 2)
3788
3789 # Now that B is merged, A should be able to be enqueued and
3790 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003791 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003792 self.waitUntilSettled()
3793
3794 self.assertEqual(A.data['status'], 'MERGED')
3795 self.assertEqual(A.reported, 2)
3796
James E. Blair96698e22015-04-02 07:48:21 -07003797 def test_crd_gate_reverse(self):
3798 "Test reverse cross-repo dependencies"
3799 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3800 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003801 A.addApproval('code-review', 2)
3802 B.addApproval('code-review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07003803
3804 # A Depends-On: B
3805
3806 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3807 A.subject, B.data['id'])
3808
James E. Blair8b5408c2016-08-08 15:37:46 -07003809 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003810 self.waitUntilSettled()
3811
3812 self.assertEqual(A.data['status'], 'NEW')
3813 self.assertEqual(B.data['status'], 'NEW')
3814
Paul Belanger174a8272017-03-14 13:20:10 -04003815 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003816 A.addApproval('approved', 1)
3817 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003818 self.waitUntilSettled()
3819
Paul Belanger174a8272017-03-14 13:20:10 -04003820 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003821 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003822 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003823 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003824 self.executor_server.hold_jobs_in_build = False
3825 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07003826 self.waitUntilSettled()
3827
3828 self.assertEqual(A.data['status'], 'MERGED')
3829 self.assertEqual(B.data['status'], 'MERGED')
3830 self.assertEqual(A.reported, 2)
3831 self.assertEqual(B.reported, 2)
3832
Paul Belanger5dccbe72016-11-14 11:17:37 -05003833 changes = self.getJobFromHistory(
3834 'project-merge', 'org/project1').changes
3835 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07003836
James E. Blair5ee24252014-12-30 10:12:29 -08003837 def test_crd_cycle(self):
3838 "Test cross-repo dependency cycles"
3839 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3840 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003841 A.addApproval('code-review', 2)
3842 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003843
3844 # A -> B -> A (via commit-depends)
3845
3846 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3847 A.subject, B.data['id'])
3848 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3849 B.subject, A.data['id'])
3850
James E. Blair8b5408c2016-08-08 15:37:46 -07003851 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003852 self.waitUntilSettled()
3853
3854 self.assertEqual(A.reported, 0)
3855 self.assertEqual(B.reported, 0)
3856 self.assertEqual(A.data['status'], 'NEW')
3857 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08003858
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003859 def test_crd_gate_unknown(self):
3860 "Test unknown projects in dependent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07003861 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003862 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3863 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003864 A.addApproval('code-review', 2)
3865 B.addApproval('code-review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003866
3867 # A Depends-On: B
3868 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3869 A.subject, B.data['id'])
3870
James E. Blair8b5408c2016-08-08 15:37:46 -07003871 B.addApproval('approved', 1)
3872 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003873 self.waitUntilSettled()
3874
3875 # Unknown projects cannot share a queue with any other
3876 # since they don't have common jobs with any other (they have no jobs).
3877 # Changes which depend on unknown project changes
3878 # should not be processed in dependent pipeline
3879 self.assertEqual(A.data['status'], 'NEW')
3880 self.assertEqual(B.data['status'], 'NEW')
3881 self.assertEqual(A.reported, 0)
3882 self.assertEqual(B.reported, 0)
3883 self.assertEqual(len(self.history), 0)
3884
James E. Blair7720b402017-06-07 08:51:49 -07003885 # Simulate change B being gated outside this layout Set the
3886 # change merged before submitting the event so that when the
3887 # event triggers a gerrit query to update the change, we get
3888 # the information that it was merged.
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003889 B.setMerged()
James E. Blair7720b402017-06-07 08:51:49 -07003890 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003891 self.waitUntilSettled()
3892 self.assertEqual(len(self.history), 0)
3893
3894 # Now that B is merged, A should be able to be enqueued and
3895 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003896 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003897 self.waitUntilSettled()
3898
3899 self.assertEqual(A.data['status'], 'MERGED')
3900 self.assertEqual(A.reported, 2)
3901 self.assertEqual(B.data['status'], 'MERGED')
3902 self.assertEqual(B.reported, 0)
3903
James E. Blairbfb8e042014-12-30 17:01:44 -08003904 def test_crd_check(self):
3905 "Test cross-repo dependencies in independent pipelines"
3906
Paul Belanger174a8272017-03-14 13:20:10 -04003907 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08003908 self.gearman_server.hold_jobs_in_queue = True
3909 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3910 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3911
3912 # A Depends-On: B
3913 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3914 A.subject, B.data['id'])
3915
3916 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3917 self.waitUntilSettled()
3918
James E. Blairbfb8e042014-12-30 17:01:44 -08003919 self.gearman_server.hold_jobs_in_queue = False
3920 self.gearman_server.release()
3921 self.waitUntilSettled()
3922
Paul Belanger174a8272017-03-14 13:20:10 -04003923 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05003924 self.waitUntilSettled()
3925
James E. Blair2a535672017-04-27 12:03:15 -07003926 self.assertTrue(self.builds[0].hasChanges(A, B))
James E. Blairbfb8e042014-12-30 17:01:44 -08003927
Paul Belanger174a8272017-03-14 13:20:10 -04003928 self.executor_server.hold_jobs_in_build = False
3929 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05003930 self.waitUntilSettled()
3931
James E. Blairbfb8e042014-12-30 17:01:44 -08003932 self.assertEqual(A.data['status'], 'NEW')
3933 self.assertEqual(B.data['status'], 'NEW')
3934 self.assertEqual(A.reported, 1)
3935 self.assertEqual(B.reported, 0)
3936
3937 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05003938 tenant = self.sched.abide.tenants.get('tenant-one')
3939 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08003940
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003941 def test_crd_check_git_depends(self):
3942 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07003943 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003944 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3945 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
3946
3947 # Add two git-dependent changes and make sure they both report
3948 # success.
3949 B.setDependsOn(A, 1)
3950 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3951 self.waitUntilSettled()
3952 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3953 self.waitUntilSettled()
3954
James E. Blairb8c16472015-05-05 14:55:26 -07003955 self.orderedRelease()
3956 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003957 self.waitUntilSettled()
3958
3959 self.assertEqual(A.data['status'], 'NEW')
3960 self.assertEqual(B.data['status'], 'NEW')
3961 self.assertEqual(A.reported, 1)
3962 self.assertEqual(B.reported, 1)
3963
3964 self.assertEqual(self.history[0].changes, '1,1')
3965 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04003966 tenant = self.sched.abide.tenants.get('tenant-one')
3967 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003968
3969 self.assertIn('Build succeeded', A.messages[0])
3970 self.assertIn('Build succeeded', B.messages[0])
3971
3972 def test_crd_check_duplicate(self):
3973 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04003974 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003975 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3976 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04003977 tenant = self.sched.abide.tenants.get('tenant-one')
3978 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003979
3980 # Add two git-dependent changes...
3981 B.setDependsOn(A, 1)
3982 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3983 self.waitUntilSettled()
3984 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3985
3986 # ...make sure the live one is not duplicated...
3987 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3988 self.waitUntilSettled()
3989 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3990
3991 # ...but the non-live one is able to be.
3992 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3993 self.waitUntilSettled()
3994 self.assertEqual(len(check_pipeline.getAllItems()), 3)
3995
Clark Boylandd849822015-03-02 12:38:14 -08003996 # Release jobs in order to avoid races with change A jobs
3997 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07003998 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04003999 self.executor_server.hold_jobs_in_build = False
4000 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004001 self.waitUntilSettled()
4002
4003 self.assertEqual(A.data['status'], 'NEW')
4004 self.assertEqual(B.data['status'], 'NEW')
4005 self.assertEqual(A.reported, 1)
4006 self.assertEqual(B.reported, 1)
4007
4008 self.assertEqual(self.history[0].changes, '1,1 2,1')
4009 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04004010 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08004011
4012 self.assertIn('Build succeeded', A.messages[0])
4013 self.assertIn('Build succeeded', B.messages[0])
4014
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004015 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08004016 "Test cross-repo dependencies re-enqueued in independent pipelines"
4017
4018 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004019 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
4020 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08004021
4022 # A Depends-On: B
4023 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4024 A.subject, B.data['id'])
4025
4026 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4027 self.waitUntilSettled()
4028
4029 self.sched.reconfigure(self.config)
4030
4031 # Make sure the items still share a change queue, and the
4032 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05004033 tenant = self.sched.abide.tenants.get('tenant-one')
4034 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
4035 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08004036 first_item = queue.queue[0]
4037 for item in queue.queue:
4038 self.assertEqual(item.queue, first_item.queue)
4039 self.assertFalse(first_item.live)
4040 self.assertTrue(queue.queue[1].live)
4041
4042 self.gearman_server.hold_jobs_in_queue = False
4043 self.gearman_server.release()
4044 self.waitUntilSettled()
4045
4046 self.assertEqual(A.data['status'], 'NEW')
4047 self.assertEqual(B.data['status'], 'NEW')
4048 self.assertEqual(A.reported, 1)
4049 self.assertEqual(B.reported, 0)
4050
4051 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004052 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004053
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004054 def test_crd_check_reconfiguration(self):
4055 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4056
4057 def test_crd_undefined_project(self):
4058 """Test that undefined projects in dependencies are handled for
4059 independent pipelines"""
4060 # It's a hack for fake gerrit,
4061 # as it implies repo creation upon the creation of any change
James E. Blairc4ba97a2017-04-19 16:26:24 -07004062 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004063 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4064
Jesse Keatingea68ab42017-04-19 15:03:30 -07004065 @simple_layout('layouts/ignore-dependencies.yaml')
James E. Blair17dd6772015-02-09 14:45:18 -08004066 def test_crd_check_ignore_dependencies(self):
4067 "Test cross-repo dependencies can be ignored"
James E. Blair17dd6772015-02-09 14:45:18 -08004068
4069 self.gearman_server.hold_jobs_in_queue = True
4070 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4071 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4072 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4073
4074 # A Depends-On: B
4075 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4076 A.subject, B.data['id'])
4077 # C git-depends on B
4078 C.setDependsOn(B, 1)
4079 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4080 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4081 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4082 self.waitUntilSettled()
4083
4084 # Make sure none of the items share a change queue, and all
4085 # are live.
Jesse Keatingea68ab42017-04-19 15:03:30 -07004086 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum12282ca2017-04-03 11:04:02 -07004087 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004088 self.assertEqual(len(check_pipeline.queues), 3)
4089 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4090 for item in check_pipeline.getAllItems():
4091 self.assertTrue(item.live)
4092
4093 self.gearman_server.hold_jobs_in_queue = False
4094 self.gearman_server.release()
4095 self.waitUntilSettled()
4096
4097 self.assertEqual(A.data['status'], 'NEW')
4098 self.assertEqual(B.data['status'], 'NEW')
4099 self.assertEqual(C.data['status'], 'NEW')
4100 self.assertEqual(A.reported, 1)
4101 self.assertEqual(B.reported, 1)
4102 self.assertEqual(C.reported, 1)
4103
4104 # Each job should have tested exactly one change
4105 for job in self.history:
4106 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004107
James E. Blair7cb84542017-04-19 13:35:05 -07004108 @simple_layout('layouts/three-projects.yaml')
James E. Blair96698e22015-04-02 07:48:21 -07004109 def test_crd_check_transitive(self):
4110 "Test transitive cross-repo dependencies"
4111 # Specifically, if A -> B -> C, and C gets a new patchset and
4112 # A gets a new patchset, ensure the test of A,2 includes B,1
4113 # and C,2 (not C,1 which would indicate stale data in the
4114 # cache for B).
4115 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4116 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4117 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4118
4119 # A Depends-On: B
4120 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4121 A.subject, B.data['id'])
4122
4123 # B Depends-On: C
4124 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4125 B.subject, C.data['id'])
4126
4127 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4128 self.waitUntilSettled()
4129 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4130
4131 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4132 self.waitUntilSettled()
4133 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4134
4135 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4136 self.waitUntilSettled()
4137 self.assertEqual(self.history[-1].changes, '3,1')
4138
4139 C.addPatchset()
4140 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4141 self.waitUntilSettled()
4142 self.assertEqual(self.history[-1].changes, '3,2')
4143
4144 A.addPatchset()
4145 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4146 self.waitUntilSettled()
4147 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004148
James E. Blaira8b90b32016-08-24 15:18:50 -07004149 def test_crd_check_unknown(self):
4150 "Test unknown projects in independent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004151 self.init_repo("org/unknown", tag='init')
James E. Blaira8b90b32016-08-24 15:18:50 -07004152 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4153 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4154 # A Depends-On: B
4155 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4156 A.subject, B.data['id'])
4157
4158 # Make sure zuul has seen an event on B.
4159 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4160 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4161 self.waitUntilSettled()
4162
4163 self.assertEqual(A.data['status'], 'NEW')
4164 self.assertEqual(A.reported, 1)
4165 self.assertEqual(B.data['status'], 'NEW')
4166 self.assertEqual(B.reported, 0)
4167
James E. Blair92464a22016-04-05 10:21:26 -07004168 def test_crd_cycle_join(self):
4169 "Test an updated change creates a cycle"
4170 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4171
4172 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4173 self.waitUntilSettled()
4174
4175 # Create B->A
4176 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4177 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4178 B.subject, A.data['id'])
4179 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4180 self.waitUntilSettled()
4181
4182 # Update A to add A->B (a cycle).
4183 A.addPatchset()
4184 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4185 A.subject, B.data['id'])
4186 # Normally we would submit the patchset-created event for
4187 # processing here, however, we have no way of noting whether
4188 # the dependency cycle detection correctly raised an
4189 # exception, so instead, we reach into the source driver and
4190 # call the method that would ultimately be called by the event
4191 # processing.
4192
Paul Belanger0e155e22016-11-14 14:12:23 -05004193 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07004194 (trusted, project) = tenant.getProject('org/project')
4195 source = project.source
Paul Belanger0e155e22016-11-14 14:12:23 -05004196
4197 # TODO(pabelanger): As we add more source / trigger APIs we should make
4198 # it easier for users to create events for testing.
4199 event = zuul.model.TriggerEvent()
4200 event.trigger_name = 'gerrit'
4201 event.change_number = '1'
4202 event.patch_number = '2'
James E. Blair92464a22016-04-05 10:21:26 -07004203 with testtools.ExpectedException(
4204 Exception, "Dependency cycle detected"):
Paul Belanger0e155e22016-11-14 14:12:23 -05004205 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004206 self.log.debug("Got expected dependency cycle exception")
4207
4208 # Now if we update B to remove the depends-on, everything
4209 # should be okay. B; A->B
4210
4211 B.addPatchset()
4212 B.data['commitMessage'] = '%s\n' % (B.subject,)
Paul Belanger0e155e22016-11-14 14:12:23 -05004213
4214 source.getChange(event, True)
4215 event.change_number = '2'
4216 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004217
Jesse Keatingcc67b122017-04-19 14:54:57 -07004218 @simple_layout('layouts/disable_at.yaml')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004219 def test_disable_at(self):
4220 "Test a pipeline will only report to the disabled trigger when failing"
4221
Jesse Keatingcc67b122017-04-19 14:54:57 -07004222 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004223 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004224 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004225 0, tenant.layout.pipelines['check']._consecutive_failures)
4226 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004227
4228 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4229 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4230 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4231 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4232 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4233 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4234 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4235 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4236 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4237 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4238 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4239
Paul Belanger174a8272017-03-14 13:20:10 -04004240 self.executor_server.failJob('project-test1', A)
4241 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004242 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004243 self.executor_server.failJob('project-test1', D)
4244 self.executor_server.failJob('project-test1', E)
4245 self.executor_server.failJob('project-test1', F)
4246 self.executor_server.failJob('project-test1', G)
4247 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004248 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004249 self.executor_server.failJob('project-test1', J)
4250 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004251
4252 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4253 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4254 self.waitUntilSettled()
4255
4256 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004257 2, tenant.layout.pipelines['check']._consecutive_failures)
4258 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004259
4260 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4261 self.waitUntilSettled()
4262
4263 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004264 0, tenant.layout.pipelines['check']._consecutive_failures)
4265 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004266
4267 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4268 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4269 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4270 self.waitUntilSettled()
4271
4272 # We should be disabled now
4273 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004274 3, tenant.layout.pipelines['check']._consecutive_failures)
4275 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004276
4277 # We need to wait between each of these patches to make sure the
4278 # smtp messages come back in an expected order
4279 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4280 self.waitUntilSettled()
4281 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4282 self.waitUntilSettled()
4283 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4284 self.waitUntilSettled()
4285
4286 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4287 # leaving a message on each change
4288 self.assertEqual(1, len(A.messages))
4289 self.assertIn('Build failed.', A.messages[0])
4290 self.assertEqual(1, len(B.messages))
4291 self.assertIn('Build failed.', B.messages[0])
4292 self.assertEqual(1, len(C.messages))
4293 self.assertIn('Build succeeded.', C.messages[0])
4294 self.assertEqual(1, len(D.messages))
4295 self.assertIn('Build failed.', D.messages[0])
4296 self.assertEqual(1, len(E.messages))
4297 self.assertIn('Build failed.', E.messages[0])
4298 self.assertEqual(1, len(F.messages))
4299 self.assertIn('Build failed.', F.messages[0])
4300
4301 # The last 3 (GHI) would have only reported via smtp.
4302 self.assertEqual(3, len(self.smtp_messages))
4303 self.assertEqual(0, len(G.messages))
4304 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004305 self.assertIn(
4306 'project-test1 https://server/job', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004307 self.assertEqual(0, len(H.messages))
4308 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004309 self.assertIn(
4310 'project-test1 https://server/job', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004311 self.assertEqual(0, len(I.messages))
4312 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004313 self.assertIn(
4314 'project-test1 https://server/job', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004315
4316 # Now reload the configuration (simulate a HUP) to check the pipeline
4317 # comes out of disabled
4318 self.sched.reconfigure(self.config)
4319
Jesse Keatingcc67b122017-04-19 14:54:57 -07004320 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004321
4322 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004323 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004324 0, tenant.layout.pipelines['check']._consecutive_failures)
4325 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004326
4327 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4328 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4329 self.waitUntilSettled()
4330
4331 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004332 2, tenant.layout.pipelines['check']._consecutive_failures)
4333 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004334
4335 # J and K went back to gerrit
4336 self.assertEqual(1, len(J.messages))
4337 self.assertIn('Build failed.', J.messages[0])
4338 self.assertEqual(1, len(K.messages))
4339 self.assertIn('Build failed.', K.messages[0])
4340 # No more messages reported via smtp
4341 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004342
James E. Blaircc020532017-04-19 13:04:44 -07004343 @simple_layout('layouts/one-job-project.yaml')
4344 def test_one_job_project(self):
4345 "Test that queueing works with one job"
4346 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4347 'master', 'A')
4348 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4349 'master', 'B')
4350 A.addApproval('code-review', 2)
4351 B.addApproval('code-review', 2)
4352 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4353 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4354 self.waitUntilSettled()
4355
4356 self.assertEqual(A.data['status'], 'MERGED')
4357 self.assertEqual(A.reported, 2)
4358 self.assertEqual(B.data['status'], 'MERGED')
4359 self.assertEqual(B.reported, 2)
4360
Paul Belanger71d98172016-11-08 10:56:31 -05004361 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004362 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004363
Paul Belanger174a8272017-03-14 13:20:10 -04004364 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004365 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4366 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4367 self.waitUntilSettled()
4368
Paul Belanger174a8272017-03-14 13:20:10 -04004369 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004370 self.waitUntilSettled()
4371
4372 self.assertEqual(len(self.builds), 2)
4373 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004374 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004375 self.waitUntilSettled()
4376
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004377 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004378 self.assertEqual(len(self.builds), 1,
4379 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004380 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004381 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004382 self.waitUntilSettled()
4383
Paul Belanger174a8272017-03-14 13:20:10 -04004384 self.executor_server.hold_jobs_in_build = False
4385 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004386 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004387 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004388 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4389 self.assertEqual(A.reported, 1)
4390 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004391
James E. Blair15be0e12017-01-03 13:45:20 -08004392 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004393 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004394
4395 self.fake_nodepool.paused = True
4396 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4397 A.addApproval('code-review', 2)
4398 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4399 self.waitUntilSettled()
4400
4401 self.zk.client.stop()
4402 self.zk.client.start()
4403 self.fake_nodepool.paused = False
4404 self.waitUntilSettled()
4405
4406 self.assertEqual(A.data['status'], 'MERGED')
4407 self.assertEqual(A.reported, 2)
4408
James E. Blair6ab79e02017-01-06 10:10:17 -08004409 def test_nodepool_failure(self):
4410 "Test that jobs are reported after a nodepool failure"
4411
4412 self.fake_nodepool.paused = True
4413 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4414 A.addApproval('code-review', 2)
4415 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4416 self.waitUntilSettled()
4417
4418 req = self.fake_nodepool.getNodeRequests()[0]
4419 self.fake_nodepool.addFailRequest(req)
4420
4421 self.fake_nodepool.paused = False
4422 self.waitUntilSettled()
4423
4424 self.assertEqual(A.data['status'], 'NEW')
4425 self.assertEqual(A.reported, 2)
4426 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4427 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4428 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4429
Arieb6f068c2016-10-09 13:11:06 +03004430
James E. Blaira002b032017-04-18 10:35:48 -07004431class TestExecutor(ZuulTestCase):
4432 tenant_config_file = 'config/single-tenant/main.yaml'
4433
4434 def assertFinalState(self):
4435 # In this test, we expect to shut down in a non-final state,
4436 # so skip these checks.
4437 pass
4438
4439 def assertCleanShutdown(self):
4440 self.log.debug("Assert clean shutdown")
4441
4442 # After shutdown, make sure no jobs are running
4443 self.assertEqual({}, self.executor_server.job_workers)
4444
4445 # Make sure that git.Repo objects have been garbage collected.
4446 repos = []
4447 gc.collect()
4448 for obj in gc.get_objects():
4449 if isinstance(obj, git.Repo):
4450 self.log.debug("Leaked git repo object: %s" % repr(obj))
4451 repos.append(obj)
4452 self.assertEqual(len(repos), 0)
4453
4454 def test_executor_shutdown(self):
4455 "Test that the executor can shut down with jobs running"
4456
4457 self.executor_server.hold_jobs_in_build = True
4458 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4459 A.addApproval('code-review', 2)
4460 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4461 self.waitUntilSettled()
4462
4463
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004464class TestDependencyGraph(ZuulTestCase):
4465 tenant_config_file = 'config/dependency-graph/main.yaml'
4466
4467 def test_dependeny_graph_dispatch_jobs_once(self):
4468 "Test a job in a dependency graph is queued only once"
4469 # Job dependencies, starting with A
4470 # A
4471 # / \
4472 # B C
4473 # / \ / \
4474 # D F E
4475 # |
4476 # G
4477
4478 self.executor_server.hold_jobs_in_build = True
4479 change = self.fake_gerrit.addFakeChange(
4480 'org/project', 'master', 'change')
4481 change.addApproval('code-review', 2)
4482 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4483
4484 self.waitUntilSettled()
4485 self.assertEqual([b.name for b in self.builds], ['A'])
4486
4487 self.executor_server.release('A')
4488 self.waitUntilSettled()
4489 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4490
4491 self.executor_server.release('B')
4492 self.waitUntilSettled()
4493 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4494
4495 self.executor_server.release('D')
4496 self.waitUntilSettled()
4497 self.assertEqual([b.name for b in self.builds], ['C'])
4498
4499 self.executor_server.release('C')
4500 self.waitUntilSettled()
4501 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4502
4503 self.executor_server.release('F')
4504 self.waitUntilSettled()
4505 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4506
4507 self.executor_server.release('G')
4508 self.waitUntilSettled()
4509 self.assertEqual([b.name for b in self.builds], ['E'])
4510
4511 self.executor_server.release('E')
4512 self.waitUntilSettled()
4513 self.assertEqual(len(self.builds), 0)
4514
4515 self.executor_server.hold_jobs_in_build = False
4516 self.executor_server.release()
4517 self.waitUntilSettled()
4518
4519 self.assertEqual(len(self.builds), 0)
4520 self.assertEqual(len(self.history), 7)
4521
4522 self.assertEqual(change.data['status'], 'MERGED')
4523 self.assertEqual(change.reported, 2)
4524
4525 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4526 "Test that a job waits till all dependencies are successful"
4527 # Job dependencies, starting with A
4528 # A
4529 # / \
4530 # B C*
4531 # / \ / \
4532 # D F E
4533 # |
4534 # G
4535
4536 self.executor_server.hold_jobs_in_build = True
4537 change = self.fake_gerrit.addFakeChange(
4538 'org/project', 'master', 'change')
4539 change.addApproval('code-review', 2)
4540
4541 self.executor_server.failJob('C', change)
4542
4543 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4544
4545 self.waitUntilSettled()
4546 self.assertEqual([b.name for b in self.builds], ['A'])
4547
4548 self.executor_server.release('A')
4549 self.waitUntilSettled()
4550 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4551
4552 self.executor_server.release('B')
4553 self.waitUntilSettled()
4554 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4555
4556 self.executor_server.release('D')
4557 self.waitUntilSettled()
4558 self.assertEqual([b.name for b in self.builds], ['C'])
4559
4560 self.executor_server.release('C')
4561 self.waitUntilSettled()
4562 self.assertEqual(len(self.builds), 0)
4563
4564 self.executor_server.hold_jobs_in_build = False
4565 self.executor_server.release()
4566 self.waitUntilSettled()
4567
4568 self.assertEqual(len(self.builds), 0)
4569 self.assertEqual(len(self.history), 4)
4570
4571 self.assertEqual(change.data['status'], 'NEW')
4572 self.assertEqual(change.reported, 2)
4573
4574
Arieb6f068c2016-10-09 13:11:06 +03004575class TestDuplicatePipeline(ZuulTestCase):
4576 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
4577
4578 def test_duplicate_pipelines(self):
4579 "Test that a change matching multiple pipelines works"
4580
4581 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4582 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
4583 self.waitUntilSettled()
4584
4585 self.assertHistory([
4586 dict(name='project-test1', result='SUCCESS', changes='1,1',
4587 pipeline='dup1'),
4588 dict(name='project-test1', result='SUCCESS', changes='1,1',
4589 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05004590 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03004591
4592 self.assertEqual(len(A.messages), 2)
4593
Paul Belangera46a3742016-11-09 14:23:03 -05004594 if 'dup1' in A.messages[0]:
4595 self.assertIn('dup1', A.messages[0])
4596 self.assertNotIn('dup2', A.messages[0])
4597 self.assertIn('project-test1', A.messages[0])
4598 self.assertIn('dup2', A.messages[1])
4599 self.assertNotIn('dup1', A.messages[1])
4600 self.assertIn('project-test1', A.messages[1])
4601 else:
4602 self.assertIn('dup1', A.messages[1])
4603 self.assertNotIn('dup2', A.messages[1])
4604 self.assertIn('project-test1', A.messages[1])
4605 self.assertIn('dup2', A.messages[0])
4606 self.assertNotIn('dup1', A.messages[0])
4607 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04004608
4609
Paul Belanger86085b32016-11-03 12:48:57 -04004610class TestSchedulerTemplatedProject(ZuulTestCase):
4611 tenant_config_file = 'config/templated-project/main.yaml'
4612
Paul Belanger174a8272017-03-14 13:20:10 -04004613 def test_job_from_templates_executed(self):
4614 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04004615
4616 A = self.fake_gerrit.addFakeChange(
4617 'org/templated-project', 'master', 'A')
4618 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4619 self.waitUntilSettled()
4620
4621 self.assertEqual(self.getJobFromHistory('project-test1').result,
4622 'SUCCESS')
4623 self.assertEqual(self.getJobFromHistory('project-test2').result,
4624 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04004625
4626 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004627 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04004628
4629 A = self.fake_gerrit.addFakeChange(
4630 'org/layered-project', 'master', 'A')
4631 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4632 self.waitUntilSettled()
4633
4634 self.assertEqual(self.getJobFromHistory('project-test1').result,
4635 'SUCCESS')
4636 self.assertEqual(self.getJobFromHistory('project-test2').result,
4637 'SUCCESS')
4638 self.assertEqual(self.getJobFromHistory('layered-project-test3'
4639 ).result, 'SUCCESS')
4640 self.assertEqual(self.getJobFromHistory('layered-project-test4'
4641 ).result, 'SUCCESS')
4642 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
4643 ).result, 'SUCCESS')
4644 self.assertEqual(self.getJobFromHistory('project-test6').result,
4645 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08004646
4647
4648class TestSchedulerSuccessURL(ZuulTestCase):
4649 tenant_config_file = 'config/success-url/main.yaml'
4650
4651 def test_success_url(self):
4652 "Ensure bad build params are ignored"
4653 self.sched.reconfigure(self.config)
4654 self.init_repo('org/docs')
4655
4656 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
4657 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4658 self.waitUntilSettled()
4659
4660 # Both builds ran: docs-draft-test + docs-draft-test2
4661 self.assertEqual(len(self.history), 2)
4662
4663 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08004664 for build in self.history:
4665 if build.name == 'docs-draft-test':
4666 uuid = build.uuid[:7]
4667 break
Adam Gandelman94a60062016-11-21 16:43:14 -08004668
4669 # Two msgs: 'Starting...' + results
4670 self.assertEqual(len(self.smtp_messages), 2)
4671 body = self.smtp_messages[1]['body'].splitlines()
4672 self.assertEqual('Build succeeded.', body[0])
4673
4674 self.assertIn(
4675 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
4676 'docs-draft-test/%s/publish-docs/' % uuid,
4677 body[2])
4678
Paul Belanger174a8272017-03-14 13:20:10 -04004679 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08004680 self.assertIn(
4681 '- docs-draft-test2 https://server/job',
4682 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08004683
4684
Adam Gandelman4da00f62016-12-09 15:47:33 -08004685class TestSchedulerMerges(ZuulTestCase):
4686 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08004687
4688 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04004689 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08004690 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04004691 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08004692 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
4693 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
4694 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
4695 A.addApproval('code-review', 2)
4696 B.addApproval('code-review', 2)
4697 C.addApproval('code-review', 2)
4698 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4699 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4700 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4701 self.waitUntilSettled()
4702
4703 build = self.builds[-1]
4704 ref = self.getParameter(build, 'ZUUL_REF')
4705
James E. Blair2a535672017-04-27 12:03:15 -07004706 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4707 project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08004708 repo = git.Repo(path)
4709 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4710 repo_messages.reverse()
4711
Paul Belanger174a8272017-03-14 13:20:10 -04004712 self.executor_server.hold_jobs_in_build = False
4713 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08004714 self.waitUntilSettled()
4715
4716 return repo_messages
4717
4718 def _test_merge(self, mode):
4719 us_path = os.path.join(
4720 self.upstream_root, 'org/project-%s' % mode)
4721 expected_messages = [
4722 'initial commit',
4723 'add content from fixture',
4724 # the intermediate commits order is nondeterministic
4725 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
4726 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
4727 ]
4728 result = self._test_project_merge_mode(mode)
4729 self.assertEqual(result[:2], expected_messages[:2])
4730 self.assertEqual(result[-2:], expected_messages[-2:])
4731
4732 def test_project_merge_mode_merge(self):
4733 self._test_merge('merge')
4734
4735 def test_project_merge_mode_merge_resolve(self):
4736 self._test_merge('merge-resolve')
4737
4738 def test_project_merge_mode_cherrypick(self):
4739 expected_messages = [
4740 'initial commit',
4741 'add content from fixture',
4742 'A-1',
4743 'B-1',
4744 'C-1']
4745 result = self._test_project_merge_mode('cherry-pick')
4746 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08004747
4748 def test_merge_branch(self):
4749 "Test that the right commits are on alternate branches"
4750 self.create_branch('org/project-merge-branches', 'mp')
4751
Paul Belanger174a8272017-03-14 13:20:10 -04004752 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004753 A = self.fake_gerrit.addFakeChange(
4754 'org/project-merge-branches', 'mp', 'A')
4755 B = self.fake_gerrit.addFakeChange(
4756 'org/project-merge-branches', 'mp', 'B')
4757 C = self.fake_gerrit.addFakeChange(
4758 'org/project-merge-branches', 'mp', 'C')
4759 A.addApproval('code-review', 2)
4760 B.addApproval('code-review', 2)
4761 C.addApproval('code-review', 2)
4762 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4763 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4764 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4765 self.waitUntilSettled()
4766
Paul Belanger174a8272017-03-14 13:20:10 -04004767 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004768 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004769 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004770 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004771 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004772 self.waitUntilSettled()
4773
4774 build = self.builds[-1]
4775 self.assertEqual(self.getParameter(build, 'ZUUL_BRANCH'), 'mp')
4776 ref = self.getParameter(build, 'ZUUL_REF')
James E. Blair2a535672017-04-27 12:03:15 -07004777 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4778 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004779 repo = git.Repo(path)
4780
4781 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4782 repo_messages.reverse()
4783 correct_messages = [
4784 'initial commit',
4785 'add content from fixture',
4786 'mp commit',
4787 'A-1', 'B-1', 'C-1']
4788 self.assertEqual(repo_messages, correct_messages)
4789
Paul Belanger174a8272017-03-14 13:20:10 -04004790 self.executor_server.hold_jobs_in_build = False
4791 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004792 self.waitUntilSettled()
4793
4794 def test_merge_multi_branch(self):
4795 "Test that dependent changes on multiple branches are merged"
4796 self.create_branch('org/project-merge-branches', 'mp')
4797
Paul Belanger174a8272017-03-14 13:20:10 -04004798 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004799 A = self.fake_gerrit.addFakeChange(
4800 'org/project-merge-branches', 'master', 'A')
4801 B = self.fake_gerrit.addFakeChange(
4802 'org/project-merge-branches', 'mp', 'B')
4803 C = self.fake_gerrit.addFakeChange(
4804 'org/project-merge-branches', 'master', 'C')
4805 A.addApproval('code-review', 2)
4806 B.addApproval('code-review', 2)
4807 C.addApproval('code-review', 2)
4808 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4809 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4810 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4811 self.waitUntilSettled()
4812
4813 job_A = None
4814 for job in self.builds:
4815 if 'project-merge' in job.name:
4816 job_A = job
4817 ref_A = self.getParameter(job_A, 'ZUUL_REF')
4818 commit_A = self.getParameter(job_A, 'ZUUL_COMMIT')
4819 self.log.debug("Got Zuul ref for change A: %s" % ref_A)
4820 self.log.debug("Got Zuul commit for change A: %s" % commit_A)
4821
James E. Blair2a535672017-04-27 12:03:15 -07004822 path = os.path.join(job_A.jobdir.src_root, 'review.example.com',
4823 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004824 repo = git.Repo(path)
4825 repo_messages = [c.message.strip()
4826 for c in repo.iter_commits(ref_A)]
4827 repo_messages.reverse()
4828 correct_messages = [
4829 'initial commit', 'add content from fixture', 'A-1']
4830 self.assertEqual(repo_messages, correct_messages)
4831
Paul Belanger174a8272017-03-14 13:20:10 -04004832 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004833 self.waitUntilSettled()
4834
4835 job_B = None
4836 for job in self.builds:
4837 if 'project-merge' in job.name:
4838 job_B = job
4839 ref_B = self.getParameter(job_B, 'ZUUL_REF')
4840 commit_B = self.getParameter(job_B, 'ZUUL_COMMIT')
4841 self.log.debug("Got Zuul ref for change B: %s" % ref_B)
4842 self.log.debug("Got Zuul commit for change B: %s" % commit_B)
4843
James E. Blair2a535672017-04-27 12:03:15 -07004844 path = os.path.join(job_B.jobdir.src_root, 'review.example.com',
4845 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004846 repo = git.Repo(path)
4847 repo_messages = [c.message.strip()
4848 for c in repo.iter_commits(ref_B)]
4849 repo_messages.reverse()
4850 correct_messages = [
4851 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
4852 self.assertEqual(repo_messages, correct_messages)
4853
Paul Belanger174a8272017-03-14 13:20:10 -04004854 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004855 self.waitUntilSettled()
4856
4857 job_C = None
4858 for job in self.builds:
4859 if 'project-merge' in job.name:
4860 job_C = job
4861 ref_C = self.getParameter(job_C, 'ZUUL_REF')
4862 commit_C = self.getParameter(job_C, 'ZUUL_COMMIT')
4863 self.log.debug("Got Zuul ref for change C: %s" % ref_C)
4864 self.log.debug("Got Zuul commit for change C: %s" % commit_C)
James E. Blair2a535672017-04-27 12:03:15 -07004865 path = os.path.join(job_C.jobdir.src_root, 'review.example.com',
4866 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004867 repo = git.Repo(path)
4868 repo_messages = [c.message.strip()
4869 for c in repo.iter_commits(ref_C)]
4870
4871 repo_messages.reverse()
4872 correct_messages = [
4873 'initial commit', 'add content from fixture',
4874 'A-1', 'C-1']
4875 # Ensure the right commits are in the history for this ref
4876 self.assertEqual(repo_messages, correct_messages)
4877
Paul Belanger174a8272017-03-14 13:20:10 -04004878 self.executor_server.hold_jobs_in_build = False
4879 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004880 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01004881
4882
James E. Blair9ea0d0b2017-04-20 09:27:15 -07004883class TestSemaphore(ZuulTestCase):
4884 tenant_config_file = 'config/semaphore/main.yaml'
4885
4886 def test_semaphore_one(self):
4887 "Test semaphores with max=1 (mutex)"
4888 tenant = self.sched.abide.tenants.get('tenant-one')
4889
4890 self.executor_server.hold_jobs_in_build = True
4891
4892 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4893 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4894 self.assertFalse('test-semaphore' in
4895 tenant.semaphore_handler.semaphores)
4896
4897 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4898 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4899 self.waitUntilSettled()
4900
4901 self.assertEqual(len(self.builds), 3)
4902 self.assertEqual(self.builds[0].name, 'project-test1')
4903 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
4904 self.assertEqual(self.builds[2].name, 'project-test1')
4905
4906 self.executor_server.release('semaphore-one-test1')
4907 self.waitUntilSettled()
4908
4909 self.assertEqual(len(self.builds), 3)
4910 self.assertEqual(self.builds[0].name, 'project-test1')
4911 self.assertEqual(self.builds[1].name, 'project-test1')
4912 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4913 self.assertTrue('test-semaphore' in
4914 tenant.semaphore_handler.semaphores)
4915
4916 self.executor_server.release('semaphore-one-test2')
4917 self.waitUntilSettled()
4918
4919 self.assertEqual(len(self.builds), 3)
4920 self.assertEqual(self.builds[0].name, 'project-test1')
4921 self.assertEqual(self.builds[1].name, 'project-test1')
4922 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
4923 self.assertTrue('test-semaphore' in
4924 tenant.semaphore_handler.semaphores)
4925
4926 self.executor_server.release('semaphore-one-test1')
4927 self.waitUntilSettled()
4928
4929 self.assertEqual(len(self.builds), 3)
4930 self.assertEqual(self.builds[0].name, 'project-test1')
4931 self.assertEqual(self.builds[1].name, 'project-test1')
4932 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4933 self.assertTrue('test-semaphore' in
4934 tenant.semaphore_handler.semaphores)
4935
4936 self.executor_server.release('semaphore-one-test2')
4937 self.waitUntilSettled()
4938
4939 self.assertEqual(len(self.builds), 2)
4940 self.assertEqual(self.builds[0].name, 'project-test1')
4941 self.assertEqual(self.builds[1].name, 'project-test1')
4942 self.assertFalse('test-semaphore' in
4943 tenant.semaphore_handler.semaphores)
4944
4945 self.executor_server.hold_jobs_in_build = False
4946 self.executor_server.release()
4947
4948 self.waitUntilSettled()
4949 self.assertEqual(len(self.builds), 0)
4950
4951 self.assertEqual(A.reported, 1)
4952 self.assertEqual(B.reported, 1)
4953 self.assertFalse('test-semaphore' in
4954 tenant.semaphore_handler.semaphores)
4955
4956 def test_semaphore_two(self):
4957 "Test semaphores with max>1"
4958 tenant = self.sched.abide.tenants.get('tenant-one')
4959
4960 self.executor_server.hold_jobs_in_build = True
4961 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4962 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4963 self.assertFalse('test-semaphore-two' in
4964 tenant.semaphore_handler.semaphores)
4965
4966 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4967 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4968 self.waitUntilSettled()
4969
4970 self.assertEqual(len(self.builds), 4)
4971 self.assertEqual(self.builds[0].name, 'project-test1')
4972 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
4973 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
4974 self.assertEqual(self.builds[3].name, 'project-test1')
4975 self.assertTrue('test-semaphore-two' in
4976 tenant.semaphore_handler.semaphores)
4977 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4978 'test-semaphore-two', [])), 2)
4979
4980 self.executor_server.release('semaphore-two-test1')
4981 self.waitUntilSettled()
4982
4983 self.assertEqual(len(self.builds), 4)
4984 self.assertEqual(self.builds[0].name, 'project-test1')
4985 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
4986 self.assertEqual(self.builds[2].name, 'project-test1')
4987 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
4988 self.assertTrue('test-semaphore-two' in
4989 tenant.semaphore_handler.semaphores)
4990 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4991 'test-semaphore-two', [])), 2)
4992
4993 self.executor_server.release('semaphore-two-test2')
4994 self.waitUntilSettled()
4995
4996 self.assertEqual(len(self.builds), 4)
4997 self.assertEqual(self.builds[0].name, 'project-test1')
4998 self.assertEqual(self.builds[1].name, 'project-test1')
4999 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
5000 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
5001 self.assertTrue('test-semaphore-two' in
5002 tenant.semaphore_handler.semaphores)
5003 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5004 'test-semaphore-two', [])), 2)
5005
5006 self.executor_server.release('semaphore-two-test1')
5007 self.waitUntilSettled()
5008
5009 self.assertEqual(len(self.builds), 3)
5010 self.assertEqual(self.builds[0].name, 'project-test1')
5011 self.assertEqual(self.builds[1].name, 'project-test1')
5012 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
5013 self.assertTrue('test-semaphore-two' in
5014 tenant.semaphore_handler.semaphores)
5015 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5016 'test-semaphore-two', [])), 1)
5017
5018 self.executor_server.release('semaphore-two-test2')
5019 self.waitUntilSettled()
5020
5021 self.assertEqual(len(self.builds), 2)
5022 self.assertEqual(self.builds[0].name, 'project-test1')
5023 self.assertEqual(self.builds[1].name, 'project-test1')
5024 self.assertFalse('test-semaphore-two' in
5025 tenant.semaphore_handler.semaphores)
5026
5027 self.executor_server.hold_jobs_in_build = False
5028 self.executor_server.release()
5029
5030 self.waitUntilSettled()
5031 self.assertEqual(len(self.builds), 0)
5032
5033 self.assertEqual(A.reported, 1)
5034 self.assertEqual(B.reported, 1)
5035
5036 def test_semaphore_abandon(self):
5037 "Test abandon with job semaphores"
5038 self.executor_server.hold_jobs_in_build = True
5039 tenant = self.sched.abide.tenants.get('tenant-one')
5040 check_pipeline = tenant.layout.pipelines['check']
5041
5042 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5043 self.assertFalse('test-semaphore' in
5044 tenant.semaphore_handler.semaphores)
5045
5046 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5047 self.waitUntilSettled()
5048
5049 self.assertTrue('test-semaphore' in
5050 tenant.semaphore_handler.semaphores)
5051
5052 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
5053 self.waitUntilSettled()
5054
5055 # The check pipeline should be empty
5056 items = check_pipeline.getAllItems()
5057 self.assertEqual(len(items), 0)
5058
5059 # The semaphore should be released
5060 self.assertFalse('test-semaphore' in
5061 tenant.semaphore_handler.semaphores)
5062
5063 self.executor_server.hold_jobs_in_build = False
5064 self.executor_server.release()
5065 self.waitUntilSettled()
5066
5067 def test_semaphore_reconfigure(self):
5068 "Test reconfigure with job semaphores"
5069 self.executor_server.hold_jobs_in_build = True
5070 tenant = self.sched.abide.tenants.get('tenant-one')
5071 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5072 self.assertFalse('test-semaphore' in
5073 tenant.semaphore_handler.semaphores)
5074
5075 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5076 self.waitUntilSettled()
5077
5078 self.assertTrue('test-semaphore' in
5079 tenant.semaphore_handler.semaphores)
5080
5081 # reconfigure without layout change
5082 self.sched.reconfigure(self.config)
5083 self.waitUntilSettled()
5084 tenant = self.sched.abide.tenants.get('tenant-one')
5085
5086 # semaphore still must be held
5087 self.assertTrue('test-semaphore' in
5088 tenant.semaphore_handler.semaphores)
5089
5090 self.commitConfigUpdate(
5091 'common-config',
5092 'config/semaphore/zuul-reconfiguration.yaml')
5093 self.sched.reconfigure(self.config)
5094 self.waitUntilSettled()
5095 tenant = self.sched.abide.tenants.get('tenant-one')
5096
5097 self.executor_server.release('project-test1')
5098 self.waitUntilSettled()
5099
5100 # There should be no builds anymore
5101 self.assertEqual(len(self.builds), 0)
5102
5103 # The semaphore should be released
5104 self.assertFalse('test-semaphore' in
5105 tenant.semaphore_handler.semaphores)
5106
5107
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005108class TestSemaphoreMultiTenant(ZuulTestCase):
5109 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5110
5111 def test_semaphore_tenant_isolation(self):
5112 "Test semaphores in multiple tenants"
5113
5114 self.waitUntilSettled()
5115 tenant_one = self.sched.abide.tenants.get('tenant-one')
5116 tenant_two = self.sched.abide.tenants.get('tenant-two')
5117
5118 self.executor_server.hold_jobs_in_build = True
5119 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5120 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5121 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5122 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5123 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5124 self.assertFalse('test-semaphore' in
5125 tenant_one.semaphore_handler.semaphores)
5126 self.assertFalse('test-semaphore' in
5127 tenant_two.semaphore_handler.semaphores)
5128
5129 # add patches to project1 of tenant-one
5130 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5131 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5132 self.waitUntilSettled()
5133
5134 # one build of project1-test1 must run
5135 # semaphore of tenant-one must be acquired once
5136 # semaphore of tenant-two must not be acquired
5137 self.assertEqual(len(self.builds), 1)
5138 self.assertEqual(self.builds[0].name, 'project1-test1')
5139 self.assertTrue('test-semaphore' in
5140 tenant_one.semaphore_handler.semaphores)
5141 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5142 'test-semaphore', [])), 1)
5143 self.assertFalse('test-semaphore' in
5144 tenant_two.semaphore_handler.semaphores)
5145
5146 # add patches to project2 of tenant-two
5147 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5148 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5149 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5150 self.waitUntilSettled()
5151
5152 # one build of project1-test1 must run
5153 # two builds of project2-test1 must run
5154 # semaphore of tenant-one must be acquired once
5155 # semaphore of tenant-two must be acquired twice
5156 self.assertEqual(len(self.builds), 3)
5157 self.assertEqual(self.builds[0].name, 'project1-test1')
5158 self.assertEqual(self.builds[1].name, 'project2-test1')
5159 self.assertEqual(self.builds[2].name, 'project2-test1')
5160 self.assertTrue('test-semaphore' in
5161 tenant_one.semaphore_handler.semaphores)
5162 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5163 'test-semaphore', [])), 1)
5164 self.assertTrue('test-semaphore' in
5165 tenant_two.semaphore_handler.semaphores)
5166 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5167 'test-semaphore', [])), 2)
5168
5169 self.executor_server.release('project1-test1')
5170 self.waitUntilSettled()
5171
5172 # one build of project1-test1 must run
5173 # two builds of project2-test1 must run
5174 # semaphore of tenant-one must be acquired once
5175 # semaphore of tenant-two must be acquired twice
5176 self.assertEqual(len(self.builds), 3)
5177 self.assertEqual(self.builds[0].name, 'project2-test1')
5178 self.assertEqual(self.builds[1].name, 'project2-test1')
5179 self.assertEqual(self.builds[2].name, 'project1-test1')
5180 self.assertTrue('test-semaphore' in
5181 tenant_one.semaphore_handler.semaphores)
5182 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5183 'test-semaphore', [])), 1)
5184 self.assertTrue('test-semaphore' in
5185 tenant_two.semaphore_handler.semaphores)
5186 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5187 'test-semaphore', [])), 2)
5188
5189 self.executor_server.release('project2-test1')
5190 self.waitUntilSettled()
5191
5192 # one build of project1-test1 must run
5193 # one build of project2-test1 must run
5194 # semaphore of tenant-one must be acquired once
5195 # semaphore of tenant-two must be acquired once
5196 self.assertEqual(len(self.builds), 2)
5197 self.assertTrue('test-semaphore' in
5198 tenant_one.semaphore_handler.semaphores)
5199 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5200 'test-semaphore', [])), 1)
5201 self.assertTrue('test-semaphore' in
5202 tenant_two.semaphore_handler.semaphores)
5203 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5204 'test-semaphore', [])), 1)
5205
5206 self.executor_server.hold_jobs_in_build = False
5207 self.executor_server.release()
5208
5209 self.waitUntilSettled()
5210
5211 # no build must run
5212 # semaphore of tenant-one must not be acquired
5213 # semaphore of tenant-two must not be acquired
5214 self.assertEqual(len(self.builds), 0)
5215 self.assertFalse('test-semaphore' in
5216 tenant_one.semaphore_handler.semaphores)
5217 self.assertFalse('test-semaphore' in
5218 tenant_two.semaphore_handler.semaphores)
5219
5220 self.assertEqual(A.reported, 1)
5221 self.assertEqual(B.reported, 1)
5222
5223
5224class TestSemaphoreInRepo(ZuulTestCase):
5225 tenant_config_file = 'config/in-repo/main.yaml'
5226
5227 def test_semaphore_in_repo(self):
5228 "Test semaphores in repo config"
5229
5230 # This tests dynamic semaphore handling in project repos. The semaphore
5231 # max value should not be evaluated dynamically but must be updated
5232 # after the change lands.
5233
5234 self.waitUntilSettled()
5235 tenant = self.sched.abide.tenants.get('tenant-one')
5236
5237 in_repo_conf = textwrap.dedent(
5238 """
5239 - job:
5240 name: project-test2
5241 semaphore: test-semaphore
5242
5243 - project:
5244 name: org/project
5245 tenant-one-gate:
5246 jobs:
5247 - project-test2
5248
5249 # the max value in dynamic layout must be ignored
5250 - semaphore:
5251 name: test-semaphore
5252 max: 2
5253 """)
5254
5255 in_repo_playbook = textwrap.dedent(
5256 """
5257 - hosts: all
5258 tasks: []
5259 """)
5260
5261 file_dict = {'.zuul.yaml': in_repo_conf,
5262 'playbooks/project-test2.yaml': in_repo_playbook}
5263 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5264 files=file_dict)
5265 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5266 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5267 B.setDependsOn(A, 1)
5268 C.setDependsOn(A, 1)
5269
5270 self.executor_server.hold_jobs_in_build = True
5271
5272 A.addApproval('code-review', 2)
5273 B.addApproval('code-review', 2)
5274 C.addApproval('code-review', 2)
5275 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
5276 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
5277 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
5278 self.waitUntilSettled()
5279
5280 # check that the layout in a queue item still has max value of 1
5281 # for test-semaphore
5282 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5283 queue = None
5284 for queue_candidate in pipeline.queues:
5285 if queue_candidate.name == 'org/project':
5286 queue = queue_candidate
5287 break
5288 queue_item = queue.queue[0]
5289 item_dynamic_layout = queue_item.current_build_set.layout
5290 dynamic_test_semaphore = \
5291 item_dynamic_layout.semaphores.get('test-semaphore')
5292 self.assertEqual(dynamic_test_semaphore.max, 1)
5293
5294 # one build must be in queue, one semaphores acquired
5295 self.assertEqual(len(self.builds), 1)
5296 self.assertEqual(self.builds[0].name, 'project-test2')
5297 self.assertTrue('test-semaphore' in
5298 tenant.semaphore_handler.semaphores)
5299 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5300 'test-semaphore', [])), 1)
5301
5302 self.executor_server.release('project-test2')
5303 self.waitUntilSettled()
5304
5305 # change A must be merged
5306 self.assertEqual(A.data['status'], 'MERGED')
5307 self.assertEqual(A.reported, 2)
5308
5309 # send change-merged event as the gerrit mock doesn't send it
5310 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5311 self.waitUntilSettled()
5312
5313 # now that change A was merged, the new semaphore max must be effective
5314 tenant = self.sched.abide.tenants.get('tenant-one')
5315 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5316
5317 # two builds must be in queue, two semaphores acquired
5318 self.assertEqual(len(self.builds), 2)
5319 self.assertEqual(self.builds[0].name, 'project-test2')
5320 self.assertEqual(self.builds[1].name, 'project-test2')
5321 self.assertTrue('test-semaphore' in
5322 tenant.semaphore_handler.semaphores)
5323 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5324 'test-semaphore', [])), 2)
5325
5326 self.executor_server.release('project-test2')
5327 self.waitUntilSettled()
5328
5329 self.assertEqual(len(self.builds), 0)
5330 self.assertFalse('test-semaphore' in
5331 tenant.semaphore_handler.semaphores)
5332
5333 self.executor_server.hold_jobs_in_build = False
5334 self.executor_server.release()
5335
5336 self.waitUntilSettled()
5337 self.assertEqual(len(self.builds), 0)
5338
5339 self.assertEqual(A.reported, 2)
5340 self.assertEqual(B.reported, 2)
5341 self.assertEqual(C.reported, 2)