blob: bc827b3d4296d121da4d5cc4ea83cd781ab2a0d5 [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
James E. Blairec056492016-07-22 09:45:56 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Morgan Fainberg293f7f82016-05-30 14:01:22 -070028from six.moves import urllib
Monty Taylorbc758832013-06-17 17:22:42 -040029import testtools
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
James E. Blairb0fcae42012-07-17 11:12:10 -070032import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080033import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040034import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070035
Maru Newby3fe5f852015-01-13 04:22:14 +000036from tests.base import (
Maru Newby3fe5f852015-01-13 04:22:14 +000037 ZuulTestCase,
38 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070039 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000040)
James E. Blairb0fcae42012-07-17 11:12:10 -070041
James E. Blairb0fcae42012-07-17 11:12:10 -070042
Clark Boylanb640e052014-04-03 16:41:46 -070043class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070044 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010045
Paul Belanger174a8272017-03-14 13:20:10 -040046 def test_jobs_executed(self):
47 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070048
James E. Blairb0fcae42012-07-17 11:12:10 -070049 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -070050 A.addApproval('code-review', 2)
51 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070052 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040053 self.assertEqual(self.getJobFromHistory('project-merge').result,
54 'SUCCESS')
55 self.assertEqual(self.getJobFromHistory('project-test1').result,
56 'SUCCESS')
57 self.assertEqual(self.getJobFromHistory('project-test2').result,
58 'SUCCESS')
59 self.assertEqual(A.data['status'], 'MERGED')
60 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070061 self.assertEqual(self.getJobFromHistory('project-test1').node,
62 'image1')
Adam Gandelmaneace4692017-02-07 15:18:36 -080063 self.assertIsNone(self.getJobFromHistory('project-test2').node)
James E. Blairb0fcae42012-07-17 11:12:10 -070064
James E. Blair552b54f2016-07-22 13:55:32 -070065 # TODOv3(jeblair): we may want to report stats by tenant (also?).
James E. Blair66eeebf2013-07-27 17:44:32 -070066 self.assertReportedStat('gerrit.event.comment-added', value='1|c')
67 self.assertReportedStat('zuul.pipeline.gate.current_changes',
68 value='1|g')
69 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
70 kind='ms')
71 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
72 value='1|c')
73 self.assertReportedStat('zuul.pipeline.gate.resident_time', kind='ms')
74 self.assertReportedStat('zuul.pipeline.gate.total_changes',
75 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070076 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070077 'zuul.pipeline.gate.org.project.resident_time', kind='ms')
James E. Blair412e5582013-04-22 15:50:12 -070078 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070079 'zuul.pipeline.gate.org.project.total_changes', value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070080
James E. Blair5821bd92015-09-16 08:48:15 -070081 for build in self.builds:
82 self.assertEqual(build.parameters['ZUUL_VOTING'], '1')
83
James E. Blair3cb10702013-08-24 08:56:03 -070084 def test_initial_pipeline_gauges(self):
85 "Test that each pipeline reported its length on start"
James E. Blair7da51b72016-07-25 15:29:43 -070086 self.assertReportedStat('zuul.pipeline.gate.current_changes',
87 value='0|g')
88 self.assertReportedStat('zuul.pipeline.check.current_changes',
89 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -070090
James E. Blair34776ee2016-08-25 13:53:54 -070091 def test_job_branch(self):
92 "Test the correct variant of a job runs on a branch"
93 self.create_branch('org/project', 'stable')
94 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
95 A.addApproval('code-review', 2)
96 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
97 self.waitUntilSettled()
98 self.assertEqual(self.getJobFromHistory('project-test1').result,
99 'SUCCESS')
100 self.assertEqual(self.getJobFromHistory('project-test2').result,
101 'SUCCESS')
102 self.assertEqual(A.data['status'], 'MERGED')
103 self.assertEqual(A.reported, 2,
104 "A should report start and success")
105 self.assertIn('gate', A.messages[1],
106 "A should transit gate")
107 self.assertEqual(self.getJobFromHistory('project-test1').node,
108 'image2')
109
James E. Blairb0fcae42012-07-17 11:12:10 -0700110 def test_parallel_changes(self):
111 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700112
Paul Belanger174a8272017-03-14 13:20:10 -0400113 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700114 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
115 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
116 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700117 A.addApproval('code-review', 2)
118 B.addApproval('code-review', 2)
119 C.addApproval('code-review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700120
James E. Blair8b5408c2016-08-08 15:37:46 -0700121 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
122 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
123 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700124
125 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400126 self.assertEqual(len(self.builds), 1)
127 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700128 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700129
Paul Belanger174a8272017-03-14 13:20:10 -0400130 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700131 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400132 self.assertEqual(len(self.builds), 3)
133 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700134 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400135 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700136 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400137 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700138 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700139
Paul Belanger174a8272017-03-14 13:20:10 -0400140 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700141 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400142 self.assertEqual(len(self.builds), 5)
143 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700144 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400145 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700146 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700147
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400148 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700149 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400150 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700151 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700152
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400153 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700154 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700155
Paul Belanger174a8272017-03-14 13:20:10 -0400156 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700157 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400158 self.assertEqual(len(self.builds), 6)
159 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700160 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400161 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700162 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700163
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400164 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700165 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400166 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700167 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700168
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400169 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700170 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400171 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700172 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700173
Paul Belanger174a8272017-03-14 13:20:10 -0400174 self.executor_server.hold_jobs_in_build = False
175 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700176 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400177 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700178
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400179 self.assertEqual(len(self.history), 9)
180 self.assertEqual(A.data['status'], 'MERGED')
181 self.assertEqual(B.data['status'], 'MERGED')
182 self.assertEqual(C.data['status'], 'MERGED')
183 self.assertEqual(A.reported, 2)
184 self.assertEqual(B.reported, 2)
185 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700186
187 def test_failed_changes(self):
188 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400189 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700190
James E. Blairb02a3bb2012-07-30 17:49:55 -0700191 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
192 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -0700193 A.addApproval('code-review', 2)
194 B.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700195
Paul Belanger174a8272017-03-14 13:20:10 -0400196 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700197
James E. Blair8b5408c2016-08-08 15:37:46 -0700198 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
199 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700200 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700201 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400202
Paul Belanger174a8272017-03-14 13:20:10 -0400203 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400204 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700205 # A/project-merge is complete
206 self.assertBuilds([
207 dict(name='project-test1', changes='1,1'),
208 dict(name='project-test2', changes='1,1'),
209 dict(name='project-merge', changes='1,1 2,1'),
210 ])
James E. Blaire2819012013-06-28 17:17:26 -0400211
Paul Belanger174a8272017-03-14 13:20:10 -0400212 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400213 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700214 # A/project-merge is complete
215 # B/project-merge is complete
216 self.assertBuilds([
217 dict(name='project-test1', changes='1,1'),
218 dict(name='project-test2', changes='1,1'),
219 dict(name='project-test1', changes='1,1 2,1'),
220 dict(name='project-test2', changes='1,1 2,1'),
221 ])
222
223 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400224 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700225 self.builds[0].release()
226 self.waitUntilSettled()
227
228 self.orderedRelease()
229 self.assertHistory([
230 dict(name='project-merge', result='SUCCESS', changes='1,1'),
231 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
232 dict(name='project-test1', result='FAILURE', changes='1,1'),
233 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
234 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
235 dict(name='project-test2', result='SUCCESS', changes='1,1'),
236 dict(name='project-merge', result='SUCCESS', changes='2,1'),
237 dict(name='project-test1', result='SUCCESS', changes='2,1'),
238 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700239 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700240
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400241 self.assertEqual(A.data['status'], 'NEW')
242 self.assertEqual(B.data['status'], 'MERGED')
243 self.assertEqual(A.reported, 2)
244 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700245
246 def test_independent_queues(self):
247 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700248
Paul Belanger174a8272017-03-14 13:20:10 -0400249 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900250 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700251 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
252 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700253 A.addApproval('code-review', 2)
254 B.addApproval('code-review', 2)
255 C.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700256
James E. Blair8b5408c2016-08-08 15:37:46 -0700257 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800258 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700259
James E. Blairf59f3cf2017-02-19 14:50:26 -0800260 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
261 self.waitUntilSettled()
262
263 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700264 self.waitUntilSettled()
265
266 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700267 self.assertBuilds([
268 dict(name='project-merge', changes='1,1'),
269 dict(name='project-merge', changes='2,1'),
270 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700271
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700272 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700273 self.builds[0].release()
274 self.waitUntilSettled()
275 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700276 self.waitUntilSettled()
277 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400278 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700279 self.waitUntilSettled()
280
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700281 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700282 self.assertBuilds([
283 dict(name='project-test1', changes='1,1'),
284 dict(name='project-test2', changes='1,1'),
285 dict(name='project-test1', changes='2,1'),
286 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500287 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700288 dict(name='project-test1', changes='2,1 3,1'),
289 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800290 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700291 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700292
James E. Blair5f0d49e2016-08-19 09:36:50 -0700293 self.orderedRelease()
294 self.assertHistory([
295 dict(name='project-merge', result='SUCCESS', changes='1,1'),
296 dict(name='project-merge', result='SUCCESS', changes='2,1'),
297 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
298 dict(name='project-test1', result='SUCCESS', changes='1,1'),
299 dict(name='project-test2', result='SUCCESS', changes='1,1'),
300 dict(name='project-test1', result='SUCCESS', changes='2,1'),
301 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500302 dict(
303 name='project1-project2-integration',
304 result='SUCCESS',
305 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700306 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
307 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800308 dict(name='project1-project2-integration',
309 result='SUCCESS',
310 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700311 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700312
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400313 self.assertEqual(A.data['status'], 'MERGED')
314 self.assertEqual(B.data['status'], 'MERGED')
315 self.assertEqual(C.data['status'], 'MERGED')
316 self.assertEqual(A.reported, 2)
317 self.assertEqual(B.reported, 2)
318 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700319
320 def test_failed_change_at_head(self):
321 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700322
Paul Belanger174a8272017-03-14 13:20:10 -0400323 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700324 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
325 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
326 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700327 A.addApproval('code-review', 2)
328 B.addApproval('code-review', 2)
329 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700330
Paul Belanger174a8272017-03-14 13:20:10 -0400331 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700332
James E. Blair8b5408c2016-08-08 15:37:46 -0700333 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
334 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
335 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700336
337 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700338
James E. Blairb536ecc2016-08-31 10:11:42 -0700339 self.assertBuilds([
340 dict(name='project-merge', changes='1,1'),
341 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700342
Paul Belanger174a8272017-03-14 13:20:10 -0400343 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700344 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400345 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700346 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400347 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700348 self.waitUntilSettled()
349
James E. Blairb536ecc2016-08-31 10:11:42 -0700350 self.assertBuilds([
351 dict(name='project-test1', changes='1,1'),
352 dict(name='project-test2', changes='1,1'),
353 dict(name='project-test1', changes='1,1 2,1'),
354 dict(name='project-test2', changes='1,1 2,1'),
355 dict(name='project-test1', changes='1,1 2,1 3,1'),
356 dict(name='project-test2', changes='1,1 2,1 3,1'),
357 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700358
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400359 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700360 self.waitUntilSettled()
361
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400362 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700363 self.assertBuilds([
364 dict(name='project-test2', changes='1,1'),
365 dict(name='project-merge', changes='2,1'),
366 ])
367 # Unordered history comparison because the aborts can finish
368 # in any order.
369 self.assertHistory([
370 dict(name='project-merge', result='SUCCESS',
371 changes='1,1'),
372 dict(name='project-merge', result='SUCCESS',
373 changes='1,1 2,1'),
374 dict(name='project-merge', result='SUCCESS',
375 changes='1,1 2,1 3,1'),
376 dict(name='project-test1', result='FAILURE',
377 changes='1,1'),
378 dict(name='project-test1', result='ABORTED',
379 changes='1,1 2,1'),
380 dict(name='project-test2', result='ABORTED',
381 changes='1,1 2,1'),
382 dict(name='project-test1', result='ABORTED',
383 changes='1,1 2,1 3,1'),
384 dict(name='project-test2', result='ABORTED',
385 changes='1,1 2,1 3,1'),
386 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700387
Paul Belanger174a8272017-03-14 13:20:10 -0400388 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700389 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400390 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700391 self.waitUntilSettled()
392 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700393
James E. Blairb536ecc2016-08-31 10:11:42 -0700394 self.assertBuilds([])
395 self.assertHistory([
396 dict(name='project-merge', result='SUCCESS',
397 changes='1,1'),
398 dict(name='project-merge', result='SUCCESS',
399 changes='1,1 2,1'),
400 dict(name='project-merge', result='SUCCESS',
401 changes='1,1 2,1 3,1'),
402 dict(name='project-test1', result='FAILURE',
403 changes='1,1'),
404 dict(name='project-test1', result='ABORTED',
405 changes='1,1 2,1'),
406 dict(name='project-test2', result='ABORTED',
407 changes='1,1 2,1'),
408 dict(name='project-test1', result='ABORTED',
409 changes='1,1 2,1 3,1'),
410 dict(name='project-test2', result='ABORTED',
411 changes='1,1 2,1 3,1'),
412 dict(name='project-merge', result='SUCCESS',
413 changes='2,1'),
414 dict(name='project-merge', result='SUCCESS',
415 changes='2,1 3,1'),
416 dict(name='project-test2', result='SUCCESS',
417 changes='1,1'),
418 dict(name='project-test1', result='SUCCESS',
419 changes='2,1'),
420 dict(name='project-test2', result='SUCCESS',
421 changes='2,1'),
422 dict(name='project-test1', result='SUCCESS',
423 changes='2,1 3,1'),
424 dict(name='project-test2', result='SUCCESS',
425 changes='2,1 3,1'),
426 ], ordered=False)
427
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400428 self.assertEqual(A.data['status'], 'NEW')
429 self.assertEqual(B.data['status'], 'MERGED')
430 self.assertEqual(C.data['status'], 'MERGED')
431 self.assertEqual(A.reported, 2)
432 self.assertEqual(B.reported, 2)
433 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700434
James E. Blair0aac4872013-08-23 14:02:38 -0700435 def test_failed_change_in_middle(self):
436 "Test a failed change in the middle of the queue"
437
Paul Belanger174a8272017-03-14 13:20:10 -0400438 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700439 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
440 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
441 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700442 A.addApproval('code-review', 2)
443 B.addApproval('code-review', 2)
444 C.addApproval('code-review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700445
Paul Belanger174a8272017-03-14 13:20:10 -0400446 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700447
James E. Blair8b5408c2016-08-08 15:37:46 -0700448 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
449 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
450 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700451
452 self.waitUntilSettled()
453
Paul Belanger174a8272017-03-14 13:20:10 -0400454 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700455 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400456 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700457 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400458 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700459 self.waitUntilSettled()
460
461 self.assertEqual(len(self.builds), 6)
462 self.assertEqual(self.builds[0].name, 'project-test1')
463 self.assertEqual(self.builds[1].name, 'project-test2')
464 self.assertEqual(self.builds[2].name, 'project-test1')
465 self.assertEqual(self.builds[3].name, 'project-test2')
466 self.assertEqual(self.builds[4].name, 'project-test1')
467 self.assertEqual(self.builds[5].name, 'project-test2')
468
469 self.release(self.builds[2])
470 self.waitUntilSettled()
471
James E. Blair972e3c72013-08-29 12:04:55 -0700472 # project-test1 and project-test2 for A
473 # project-test2 for B
474 # project-merge for C (without B)
475 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700476 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
477
Paul Belanger174a8272017-03-14 13:20:10 -0400478 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700479 self.waitUntilSettled()
480
481 # project-test1 and project-test2 for A
482 # project-test2 for B
483 # project-test1 and project-test2 for C
484 self.assertEqual(len(self.builds), 5)
485
Paul Belanger2e2a0492016-10-30 18:33:37 -0400486 tenant = self.sched.abide.tenants.get('tenant-one')
487 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700488 builds = items[0].current_build_set.getBuilds()
489 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
490 self.assertEqual(self.countJobResults(builds, None), 2)
491 builds = items[1].current_build_set.getBuilds()
492 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
493 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
494 self.assertEqual(self.countJobResults(builds, None), 1)
495 builds = items[2].current_build_set.getBuilds()
496 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700497 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700498
Paul Belanger174a8272017-03-14 13:20:10 -0400499 self.executor_server.hold_jobs_in_build = False
500 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700501 self.waitUntilSettled()
502
503 self.assertEqual(len(self.builds), 0)
504 self.assertEqual(len(self.history), 12)
505 self.assertEqual(A.data['status'], 'MERGED')
506 self.assertEqual(B.data['status'], 'NEW')
507 self.assertEqual(C.data['status'], 'MERGED')
508 self.assertEqual(A.reported, 2)
509 self.assertEqual(B.reported, 2)
510 self.assertEqual(C.reported, 2)
511
James E. Blaird466dc42012-07-31 10:42:56 -0700512 def test_failed_change_at_head_with_queue(self):
513 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700514
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700515 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700516 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
517 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
518 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700519 A.addApproval('code-review', 2)
520 B.addApproval('code-review', 2)
521 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700522
Paul Belanger174a8272017-03-14 13:20:10 -0400523 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700524
James E. Blair8b5408c2016-08-08 15:37:46 -0700525 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
526 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
527 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700528
529 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700530 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400531 self.assertEqual(len(self.builds), 0)
532 self.assertEqual(len(queue), 1)
Paul Belanger174a8272017-03-14 13:20:10 -0400533 self.assertEqual(queue[0].name, 'executor:execute')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800534 job_args = json.loads(queue[0].arguments)
535 self.assertEqual(job_args['job'], 'project-merge')
536 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700537
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700538 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700539 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700540 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700541 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700542 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700543 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700544 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700545
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400546 self.assertEqual(len(self.builds), 0)
547 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800548
549 self.assertEqual(
550 json.loads(queue[0].arguments)['job'], 'project-test1')
551 self.assertEqual(
552 json.loads(queue[1].arguments)['job'], 'project-test2')
553 self.assertEqual(
554 json.loads(queue[2].arguments)['job'], 'project-test1')
555 self.assertEqual(
556 json.loads(queue[3].arguments)['job'], 'project-test2')
557 self.assertEqual(
558 json.loads(queue[4].arguments)['job'], 'project-test1')
559 self.assertEqual(
560 json.loads(queue[5].arguments)['job'], 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700561
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700562 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700563 self.waitUntilSettled()
564
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400565 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700566 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400567 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
568 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700569
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700570 self.gearman_server.hold_jobs_in_queue = False
571 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700572 self.waitUntilSettled()
573
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400574 self.assertEqual(len(self.builds), 0)
575 self.assertEqual(len(self.history), 11)
576 self.assertEqual(A.data['status'], 'NEW')
577 self.assertEqual(B.data['status'], 'MERGED')
578 self.assertEqual(C.data['status'], 'MERGED')
579 self.assertEqual(A.reported, 2)
580 self.assertEqual(B.reported, 2)
581 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700582
James E. Blairec056492016-07-22 09:45:56 -0700583 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700584 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400585 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700586 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -0700587 A.addApproval('code-review', 2)
588 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700589 self.waitUntilSettled()
590 time.sleep(2)
591
592 data = json.loads(self.sched.formatStatusJSON())
593 found_job = None
594 for pipeline in data['pipelines']:
595 if pipeline['name'] != 'gate':
596 continue
597 for queue in pipeline['change_queues']:
598 for head in queue['heads']:
599 for item in head:
600 for job in item['jobs']:
601 if job['name'] == 'project-merge':
602 found_job = job
603 break
604
605 self.assertIsNotNone(found_job)
606 if iteration == 1:
607 self.assertIsNotNone(found_job['estimated_time'])
608 self.assertIsNone(found_job['remaining_time'])
609 else:
610 self.assertIsNotNone(found_job['estimated_time'])
611 self.assertTrue(found_job['estimated_time'] >= 2)
612 self.assertIsNotNone(found_job['remaining_time'])
613
Paul Belanger174a8272017-03-14 13:20:10 -0400614 self.executor_server.hold_jobs_in_build = False
615 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700616 self.waitUntilSettled()
617
James E. Blairec056492016-07-22 09:45:56 -0700618 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700619 def test_time_database(self):
620 "Test the time database"
621
622 self._test_time_database(1)
623 self._test_time_database(2)
624
James E. Blairfef71632013-09-23 11:15:47 -0700625 def test_two_failed_changes_at_head(self):
626 "Test that changes are reparented correctly if 2 fail at head"
627
Paul Belanger174a8272017-03-14 13:20:10 -0400628 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700629 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
630 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
631 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700632 A.addApproval('code-review', 2)
633 B.addApproval('code-review', 2)
634 C.addApproval('code-review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700635
Paul Belanger174a8272017-03-14 13:20:10 -0400636 self.executor_server.failJob('project-test1', A)
637 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700638
James E. Blair8b5408c2016-08-08 15:37:46 -0700639 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
640 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
641 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700642 self.waitUntilSettled()
643
Paul Belanger174a8272017-03-14 13:20:10 -0400644 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700645 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400646 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700647 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400648 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700649 self.waitUntilSettled()
650
651 self.assertEqual(len(self.builds), 6)
652 self.assertEqual(self.builds[0].name, 'project-test1')
653 self.assertEqual(self.builds[1].name, 'project-test2')
654 self.assertEqual(self.builds[2].name, 'project-test1')
655 self.assertEqual(self.builds[3].name, 'project-test2')
656 self.assertEqual(self.builds[4].name, 'project-test1')
657 self.assertEqual(self.builds[5].name, 'project-test2')
658
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400659 self.assertTrue(self.builds[0].hasChanges(A))
660 self.assertTrue(self.builds[2].hasChanges(A))
661 self.assertTrue(self.builds[2].hasChanges(B))
662 self.assertTrue(self.builds[4].hasChanges(A))
663 self.assertTrue(self.builds[4].hasChanges(B))
664 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700665
666 # Fail change B first
667 self.release(self.builds[2])
668 self.waitUntilSettled()
669
670 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400671 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700672 self.waitUntilSettled()
673
674 self.assertEqual(len(self.builds), 5)
675 self.assertEqual(self.builds[0].name, 'project-test1')
676 self.assertEqual(self.builds[1].name, 'project-test2')
677 self.assertEqual(self.builds[2].name, 'project-test2')
678 self.assertEqual(self.builds[3].name, 'project-test1')
679 self.assertEqual(self.builds[4].name, 'project-test2')
680
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400681 self.assertTrue(self.builds[1].hasChanges(A))
682 self.assertTrue(self.builds[2].hasChanges(A))
683 self.assertTrue(self.builds[2].hasChanges(B))
684 self.assertTrue(self.builds[4].hasChanges(A))
685 self.assertFalse(self.builds[4].hasChanges(B))
686 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700687
688 # Finish running all passing jobs for change A
689 self.release(self.builds[1])
690 self.waitUntilSettled()
691 # Fail and report change A
692 self.release(self.builds[0])
693 self.waitUntilSettled()
694
695 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400696 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700697 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400698 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700699 self.waitUntilSettled()
700
701 self.assertEqual(len(self.builds), 4)
702 self.assertEqual(self.builds[0].name, 'project-test1') # B
703 self.assertEqual(self.builds[1].name, 'project-test2') # B
704 self.assertEqual(self.builds[2].name, 'project-test1') # C
705 self.assertEqual(self.builds[3].name, 'project-test2') # C
706
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400707 self.assertFalse(self.builds[1].hasChanges(A))
708 self.assertTrue(self.builds[1].hasChanges(B))
709 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700710
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400711 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700712 # After A failed and B and C restarted, B should be back in
713 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400714 self.assertTrue(self.builds[2].hasChanges(B))
715 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700716
Paul Belanger174a8272017-03-14 13:20:10 -0400717 self.executor_server.hold_jobs_in_build = False
718 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700719 self.waitUntilSettled()
720
721 self.assertEqual(len(self.builds), 0)
722 self.assertEqual(len(self.history), 21)
723 self.assertEqual(A.data['status'], 'NEW')
724 self.assertEqual(B.data['status'], 'NEW')
725 self.assertEqual(C.data['status'], 'MERGED')
726 self.assertEqual(A.reported, 2)
727 self.assertEqual(B.reported, 2)
728 self.assertEqual(C.reported, 2)
729
James E. Blair8c803f82012-07-31 16:25:42 -0700730 def test_patch_order(self):
731 "Test that dependent patches are tested in the right order"
732 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
733 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
734 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700735 A.addApproval('code-review', 2)
736 B.addApproval('code-review', 2)
737 C.addApproval('code-review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700738
739 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
740 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
741 M2.setMerged()
742 M1.setMerged()
743
744 # C -> B -> A -> M1 -> M2
745 # M2 is here to make sure it is never queried. If it is, it
746 # means zuul is walking down the entire history of merged
747 # changes.
748
749 C.setDependsOn(B, 1)
750 B.setDependsOn(A, 1)
751 A.setDependsOn(M1, 1)
752 M1.setDependsOn(M2, 1)
753
James E. Blair8b5408c2016-08-08 15:37:46 -0700754 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700755
756 self.waitUntilSettled()
757
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400758 self.assertEqual(A.data['status'], 'NEW')
759 self.assertEqual(B.data['status'], 'NEW')
760 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700761
James E. Blair8b5408c2016-08-08 15:37:46 -0700762 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
763 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700764
765 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400766 self.assertEqual(M2.queried, 0)
767 self.assertEqual(A.data['status'], 'MERGED')
768 self.assertEqual(B.data['status'], 'MERGED')
769 self.assertEqual(C.data['status'], 'MERGED')
770 self.assertEqual(A.reported, 2)
771 self.assertEqual(B.reported, 2)
772 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700773
James E. Blair063672f2015-01-29 13:09:12 -0800774 def test_needed_changes_enqueue(self):
775 "Test that a needed change is enqueued ahead"
776 # A Given a git tree like this, if we enqueue
777 # / \ change C, we should walk up and down the tree
778 # B G and enqueue changes in the order ABCDEFG.
779 # /|\ This is also the order that you would get if
780 # *C E F you enqueued changes in the order ABCDEFG, so
781 # / the ordering is stable across re-enqueue events.
782 # D
783
784 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
785 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
786 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
787 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
788 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
789 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
790 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
791 B.setDependsOn(A, 1)
792 C.setDependsOn(B, 1)
793 D.setDependsOn(C, 1)
794 E.setDependsOn(B, 1)
795 F.setDependsOn(B, 1)
796 G.setDependsOn(A, 1)
797
James E. Blair8b5408c2016-08-08 15:37:46 -0700798 A.addApproval('code-review', 2)
799 B.addApproval('code-review', 2)
800 C.addApproval('code-review', 2)
801 D.addApproval('code-review', 2)
802 E.addApproval('code-review', 2)
803 F.addApproval('code-review', 2)
804 G.addApproval('code-review', 2)
805 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800806
807 self.waitUntilSettled()
808
809 self.assertEqual(A.data['status'], 'NEW')
810 self.assertEqual(B.data['status'], 'NEW')
811 self.assertEqual(C.data['status'], 'NEW')
812 self.assertEqual(D.data['status'], 'NEW')
813 self.assertEqual(E.data['status'], 'NEW')
814 self.assertEqual(F.data['status'], 'NEW')
815 self.assertEqual(G.data['status'], 'NEW')
816
817 # We're about to add approvals to changes without adding the
818 # triggering events to Zuul, so that we can be sure that it is
819 # enqueing the changes based on dependencies, not because of
820 # triggering events. Since it will have the changes cached
821 # already (without approvals), we need to clear the cache
822 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400823 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +1100824 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800825
Paul Belanger174a8272017-03-14 13:20:10 -0400826 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -0700827 A.addApproval('approved', 1)
828 B.addApproval('approved', 1)
829 D.addApproval('approved', 1)
830 E.addApproval('approved', 1)
831 F.addApproval('approved', 1)
832 G.addApproval('approved', 1)
833 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800834
835 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400836 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800837 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400838 self.executor_server.hold_jobs_in_build = False
839 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800840 self.waitUntilSettled()
841
842 self.assertEqual(A.data['status'], 'MERGED')
843 self.assertEqual(B.data['status'], 'MERGED')
844 self.assertEqual(C.data['status'], 'MERGED')
845 self.assertEqual(D.data['status'], 'MERGED')
846 self.assertEqual(E.data['status'], 'MERGED')
847 self.assertEqual(F.data['status'], 'MERGED')
848 self.assertEqual(G.data['status'], 'MERGED')
849 self.assertEqual(A.reported, 2)
850 self.assertEqual(B.reported, 2)
851 self.assertEqual(C.reported, 2)
852 self.assertEqual(D.reported, 2)
853 self.assertEqual(E.reported, 2)
854 self.assertEqual(F.reported, 2)
855 self.assertEqual(G.reported, 2)
856 self.assertEqual(self.history[6].changes,
857 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
858
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100859 def test_source_cache(self):
860 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400861 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700862
863 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
864 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
865 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
James E. Blair8b5408c2016-08-08 15:37:46 -0700866 A.addApproval('code-review', 2)
867 B.addApproval('code-review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700868
869 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
870 M1.setMerged()
871
872 B.setDependsOn(A, 1)
873 A.setDependsOn(M1, 1)
874
James E. Blair8b5408c2016-08-08 15:37:46 -0700875 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700876 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
877
878 self.waitUntilSettled()
879
880 for build in self.builds:
881 if build.parameters['ZUUL_PIPELINE'] == 'check':
882 build.release()
883 self.waitUntilSettled()
884 for build in self.builds:
885 if build.parameters['ZUUL_PIPELINE'] == 'check':
886 build.release()
887 self.waitUntilSettled()
888
James E. Blair8b5408c2016-08-08 15:37:46 -0700889 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700890 self.waitUntilSettled()
891
Joshua Hesketh352264b2015-08-11 23:42:08 +1000892 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700893 # there should still be changes in the cache
Joshua Hesketh352264b2015-08-11 23:42:08 +1000894 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700895
Paul Belanger174a8272017-03-14 13:20:10 -0400896 self.executor_server.hold_jobs_in_build = False
897 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700898 self.waitUntilSettled()
899
900 self.assertEqual(A.data['status'], 'MERGED')
901 self.assertEqual(B.data['status'], 'MERGED')
902 self.assertEqual(A.queried, 2) # Initial and isMerged
903 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
904
James E. Blair8c803f82012-07-31 16:25:42 -0700905 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700906 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700907 # TODO: move to test_gerrit (this is a unit test!)
908 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400909 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700910 (trusted, project) = tenant.getProject('org/project')
911 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400912
913 # TODO(pabelanger): As we add more source / trigger APIs we should make
914 # it easier for users to create events for testing.
915 event = zuul.model.TriggerEvent()
916 event.trigger_name = 'gerrit'
917 event.change_number = '1'
918 event.patch_number = '2'
919
920 a = source.getChange(event)
921 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700922 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700923
James E. Blair8b5408c2016-08-08 15:37:46 -0700924 A.addApproval('code-review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400925 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700926 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700927
James E. Blair8b5408c2016-08-08 15:37:46 -0700928 A.addApproval('approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400929 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700930 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700931
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700932 def test_project_merge_conflict(self):
933 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700934
935 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700936 A = self.fake_gerrit.addFakeChange('org/project',
937 'master', 'A',
938 files={'conflict': 'foo'})
939 B = self.fake_gerrit.addFakeChange('org/project',
940 'master', 'B',
941 files={'conflict': 'bar'})
942 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -0700943 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700944 A.addApproval('code-review', 2)
945 B.addApproval('code-review', 2)
946 C.addApproval('code-review', 2)
947 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
948 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
949 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -0700950 self.waitUntilSettled()
951
James E. Blair6736beb2013-07-11 15:18:15 -0700952 self.assertEqual(A.reported, 1)
953 self.assertEqual(B.reported, 1)
954 self.assertEqual(C.reported, 1)
955
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700956 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700957 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700958 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700959 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700960 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700961 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -0700962
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700963 self.gearman_server.hold_jobs_in_queue = False
964 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -0700965 self.waitUntilSettled()
966
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400967 self.assertEqual(A.data['status'], 'MERGED')
968 self.assertEqual(B.data['status'], 'NEW')
969 self.assertEqual(C.data['status'], 'MERGED')
970 self.assertEqual(A.reported, 2)
971 self.assertEqual(B.reported, 2)
972 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700973
974 self.assertHistory([
975 dict(name='project-merge', result='SUCCESS', changes='1,1'),
976 dict(name='project-test1', result='SUCCESS', changes='1,1'),
977 dict(name='project-test2', result='SUCCESS', changes='1,1'),
978 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
979 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
980 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
981 ], ordered=False)
982
983 def test_delayed_merge_conflict(self):
984 "Test that delayed check merge conflicts are handled properly"
985
986 # Hold jobs in the gearman queue so that we can test whether
987 # the executor returns a merge failure after the scheduler has
988 # successfully merged.
989 self.gearman_server.hold_jobs_in_queue = True
990 A = self.fake_gerrit.addFakeChange('org/project',
991 'master', 'A',
992 files={'conflict': 'foo'})
993 B = self.fake_gerrit.addFakeChange('org/project',
994 'master', 'B',
995 files={'conflict': 'bar'})
996 C = self.fake_gerrit.addFakeChange('org/project',
997 'master', 'C')
998 C.setDependsOn(B, 1)
999
1000 # A enters the gate queue; B and C enter the check queue
1001 A.addApproval('code-review', 2)
1002 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1003 self.waitUntilSettled()
1004 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1005 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1006 self.waitUntilSettled()
1007
1008 self.assertEqual(A.reported, 1)
1009 self.assertEqual(B.reported, 0) # Check does not report start
1010 self.assertEqual(C.reported, 0) # Check does not report start
1011
1012 # A merges while B and C are queued in check
1013 # Release A project-merge
1014 queue = self.gearman_server.getQueue()
1015 self.release(queue[0])
1016 self.waitUntilSettled()
1017
1018 # Release A project-test*
1019 # gate has higher precedence, so A's test jobs are added in
1020 # front of the merge jobs for B and C
1021 queue = self.gearman_server.getQueue()
1022 self.release(queue[0])
1023 self.release(queue[1])
1024 self.waitUntilSettled()
1025
1026 self.assertEqual(A.data['status'], 'MERGED')
1027 self.assertEqual(B.data['status'], 'NEW')
1028 self.assertEqual(C.data['status'], 'NEW')
1029 self.assertEqual(A.reported, 2)
1030 self.assertEqual(B.reported, 0)
1031 self.assertEqual(C.reported, 0)
1032 self.assertHistory([
1033 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1034 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1035 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1036 ], ordered=False)
1037
1038 # B and C report merge conflicts
1039 # Release B project-merge
1040 queue = self.gearman_server.getQueue()
1041 self.release(queue[0])
1042 self.waitUntilSettled()
1043
1044 # Release C
1045 self.gearman_server.hold_jobs_in_queue = False
1046 self.gearman_server.release()
1047 self.waitUntilSettled()
1048
1049 self.assertEqual(A.data['status'], 'MERGED')
1050 self.assertEqual(B.data['status'], 'NEW')
1051 self.assertEqual(C.data['status'], 'NEW')
1052 self.assertEqual(A.reported, 2)
1053 self.assertEqual(B.reported, 1)
1054 self.assertEqual(C.reported, 1)
1055
1056 self.assertHistory([
1057 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1058 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1059 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1060 dict(name='project-merge', result='MERGER_FAILURE', changes='2,1'),
1061 dict(name='project-merge', result='MERGER_FAILURE',
1062 changes='2,1 3,1'),
1063 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001064
James E. Blairdaabed22012-08-15 15:38:57 -07001065 def test_post(self):
1066 "Test that post jobs run"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001067
Zhongyue Luo5d556072012-09-21 02:00:47 +09001068 e = {
1069 "type": "ref-updated",
1070 "submitter": {
1071 "name": "User Name",
1072 },
1073 "refUpdate": {
1074 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1075 "newRev": "d479a0bfcb34da57a31adb2a595c0cf687812543",
1076 "refName": "master",
1077 "project": "org/project",
1078 }
1079 }
James E. Blairdaabed22012-08-15 15:38:57 -07001080 self.fake_gerrit.addEvent(e)
1081 self.waitUntilSettled()
1082
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001083 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001084 self.assertEqual(len(self.history), 1)
1085 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001086
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001087 def test_post_ignore_deletes(self):
1088 "Test that deleting refs does not trigger post jobs"
1089
1090 e = {
1091 "type": "ref-updated",
1092 "submitter": {
1093 "name": "User Name",
1094 },
1095 "refUpdate": {
1096 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1097 "newRev": "0000000000000000000000000000000000000000",
1098 "refName": "master",
1099 "project": "org/project",
1100 }
1101 }
1102 self.fake_gerrit.addEvent(e)
1103 self.waitUntilSettled()
1104
1105 job_names = [x.name for x in self.history]
1106 self.assertEqual(len(self.history), 0)
1107 self.assertNotIn('project-post', job_names)
1108
James E. Blaircc324192017-04-19 14:36:08 -07001109 @simple_layout('layouts/dont-ignore-ref-deletes.yaml')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001110 def test_post_ignore_deletes_negative(self):
1111 "Test that deleting refs does trigger post jobs"
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001112 e = {
1113 "type": "ref-updated",
1114 "submitter": {
1115 "name": "User Name",
1116 },
1117 "refUpdate": {
1118 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1119 "newRev": "0000000000000000000000000000000000000000",
1120 "refName": "master",
1121 "project": "org/project",
1122 }
1123 }
1124 self.fake_gerrit.addEvent(e)
1125 self.waitUntilSettled()
1126
1127 job_names = [x.name for x in self.history]
1128 self.assertEqual(len(self.history), 1)
1129 self.assertIn('project-post', job_names)
1130
James E. Blairec056492016-07-22 09:45:56 -07001131 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001132 def test_build_configuration_branch_interaction(self):
1133 "Test that switching between branches works"
1134 self.test_build_configuration()
1135 self.test_build_configuration_branch()
1136 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001137 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001138 repo = git.Repo(path)
1139 repo.heads.master.commit = repo.commit('init')
1140 self.test_build_configuration()
1141
James E. Blaircaec0c52012-08-22 14:52:22 -07001142 def test_dependent_changes_dequeue(self):
1143 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001144
James E. Blaircaec0c52012-08-22 14:52:22 -07001145 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1146 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1147 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001148 A.addApproval('code-review', 2)
1149 B.addApproval('code-review', 2)
1150 C.addApproval('code-review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001151
1152 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1153 M1.setMerged()
1154
1155 # C -> B -> A -> M1
1156
1157 C.setDependsOn(B, 1)
1158 B.setDependsOn(A, 1)
1159 A.setDependsOn(M1, 1)
1160
Paul Belanger174a8272017-03-14 13:20:10 -04001161 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001162
James E. Blair8b5408c2016-08-08 15:37:46 -07001163 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1164 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1165 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001166
1167 self.waitUntilSettled()
1168
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001169 self.assertEqual(A.data['status'], 'NEW')
1170 self.assertEqual(A.reported, 2)
1171 self.assertEqual(B.data['status'], 'NEW')
1172 self.assertEqual(B.reported, 2)
1173 self.assertEqual(C.data['status'], 'NEW')
1174 self.assertEqual(C.reported, 2)
1175 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001176
James E. Blair972e3c72013-08-29 12:04:55 -07001177 def test_failing_dependent_changes(self):
1178 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001179 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001180 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1181 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1182 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1183 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1184 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
James E. Blair8b5408c2016-08-08 15:37:46 -07001185 A.addApproval('code-review', 2)
1186 B.addApproval('code-review', 2)
1187 C.addApproval('code-review', 2)
1188 D.addApproval('code-review', 2)
1189 E.addApproval('code-review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001190
1191 # E, D -> C -> B, A
1192
1193 D.setDependsOn(C, 1)
1194 C.setDependsOn(B, 1)
1195
Paul Belanger174a8272017-03-14 13:20:10 -04001196 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001197
James E. Blair8b5408c2016-08-08 15:37:46 -07001198 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1199 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
1200 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1201 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1202 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001203
1204 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001205 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001206 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001207 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001208 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001209 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001210 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001211 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001212 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001213 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001214 self.waitUntilSettled()
1215
Paul Belanger174a8272017-03-14 13:20:10 -04001216 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001217 for build in self.builds:
1218 if build.parameters['ZUUL_CHANGE'] != '1':
1219 build.release()
1220 self.waitUntilSettled()
1221
Paul Belanger174a8272017-03-14 13:20:10 -04001222 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001223 self.waitUntilSettled()
1224
1225 self.assertEqual(A.data['status'], 'MERGED')
1226 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001227 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001228 self.assertEqual(B.data['status'], 'NEW')
1229 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001230 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001231 self.assertEqual(C.data['status'], 'NEW')
1232 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001233 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001234 self.assertEqual(D.data['status'], 'NEW')
1235 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001236 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001237 self.assertEqual(E.data['status'], 'MERGED')
1238 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001239 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001240 self.assertEqual(len(self.history), 18)
1241
James E. Blairec590122012-08-22 15:19:31 -07001242 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001243 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001244 # If it's dequeued more than once, we should see extra
1245 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001246
Paul Belanger174a8272017-03-14 13:20:10 -04001247 self.executor_server.hold_jobs_in_build = True
James E. Blair6df67132017-04-19 13:53:20 -07001248 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1249 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1250 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001251 A.addApproval('code-review', 2)
1252 B.addApproval('code-review', 2)
1253 C.addApproval('code-review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001254
Paul Belanger174a8272017-03-14 13:20:10 -04001255 self.executor_server.failJob('project-test1', A)
1256 self.executor_server.failJob('project-test2', A)
James E. Blairec590122012-08-22 15:19:31 -07001257
James E. Blair8b5408c2016-08-08 15:37:46 -07001258 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1259 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1260 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001261
1262 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001263
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001264 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001265 self.assertEqual(self.builds[0].name, 'project-merge')
1266 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001267
Paul Belanger174a8272017-03-14 13:20:10 -04001268 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001269 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001270 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001271 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001272 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001273 self.waitUntilSettled()
1274
James E. Blair6df67132017-04-19 13:53:20 -07001275 self.assertEqual(len(self.builds), 6)
Paul Belanger58bf6912016-11-11 19:36:01 -05001276 self.assertEqual(self.builds[0].name, 'project-test1')
1277 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair6df67132017-04-19 13:53:20 -07001278 self.assertEqual(self.builds[2].name, 'project-test1')
1279 self.assertEqual(self.builds[3].name, 'project-test2')
1280 self.assertEqual(self.builds[4].name, 'project-test1')
1281 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blairec590122012-08-22 15:19:31 -07001282
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001283 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001284 self.waitUntilSettled()
1285
James E. Blair6df67132017-04-19 13:53:20 -07001286 self.assertEqual(len(self.builds), 2) # test2, merge for B
1287 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
James E. Blairec590122012-08-22 15:19:31 -07001288
Paul Belanger174a8272017-03-14 13:20:10 -04001289 self.executor_server.hold_jobs_in_build = False
1290 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001291 self.waitUntilSettled()
1292
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001293 self.assertEqual(len(self.builds), 0)
James E. Blair6df67132017-04-19 13:53:20 -07001294 self.assertEqual(len(self.history), 15)
James E. Blaircaec0c52012-08-22 14:52:22 -07001295
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001296 self.assertEqual(A.data['status'], 'NEW')
1297 self.assertEqual(B.data['status'], 'MERGED')
1298 self.assertEqual(C.data['status'], 'MERGED')
1299 self.assertEqual(A.reported, 2)
1300 self.assertEqual(B.reported, 2)
1301 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001302
James E. Blaircc020532017-04-19 13:04:44 -07001303 @simple_layout('layouts/nonvoting-job.yaml')
James E. Blair4ec821f2012-08-23 15:28:28 -07001304 def test_nonvoting_job(self):
1305 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001306
James E. Blair4ec821f2012-08-23 15:28:28 -07001307 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1308 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001309 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001310 self.executor_server.failJob('nonvoting-project-test2', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07001311 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001312
1313 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001314
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001315 self.assertEqual(A.data['status'], 'MERGED')
1316 self.assertEqual(A.reported, 2)
1317 self.assertEqual(
1318 self.getJobFromHistory('nonvoting-project-merge').result,
1319 'SUCCESS')
1320 self.assertEqual(
1321 self.getJobFromHistory('nonvoting-project-test1').result,
1322 'SUCCESS')
1323 self.assertEqual(
1324 self.getJobFromHistory('nonvoting-project-test2').result,
1325 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001326
James E. Blair5821bd92015-09-16 08:48:15 -07001327 for build in self.builds:
1328 self.assertEqual(build.parameters['ZUUL_VOTING'], '0')
1329
James E. Blaire0487072012-08-29 17:38:31 -07001330 def test_check_queue_success(self):
1331 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001332
James E. Blaire0487072012-08-29 17:38:31 -07001333 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1334 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1335
1336 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001337
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001338 self.assertEqual(A.data['status'], 'NEW')
1339 self.assertEqual(A.reported, 1)
1340 self.assertEqual(self.getJobFromHistory('project-merge').result,
1341 'SUCCESS')
1342 self.assertEqual(self.getJobFromHistory('project-test1').result,
1343 'SUCCESS')
1344 self.assertEqual(self.getJobFromHistory('project-test2').result,
1345 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001346
1347 def test_check_queue_failure(self):
1348 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001349
James E. Blaire0487072012-08-29 17:38:31 -07001350 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001351 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001352 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1353
1354 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001355
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001356 self.assertEqual(A.data['status'], 'NEW')
1357 self.assertEqual(A.reported, 1)
1358 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001359 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001360 self.assertEqual(self.getJobFromHistory('project-test1').result,
1361 'SUCCESS')
1362 self.assertEqual(self.getJobFromHistory('project-test2').result,
1363 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001364
James E. Blair7cb84542017-04-19 13:35:05 -07001365 @simple_layout('layouts/three-projects.yaml')
James E. Blair127bc182012-08-28 15:55:15 -07001366 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001367 # This particular test does a large amount of merges and needs a little
1368 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001369 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001370 "test that dependent changes behind dequeued changes work"
1371 # This complicated test is a reproduction of a real life bug
1372 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001373
Paul Belanger174a8272017-03-14 13:20:10 -04001374 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001375 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1376 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1377 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1378 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1379 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1380 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1381 D.setDependsOn(C, 1)
1382 E.setDependsOn(D, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07001383 A.addApproval('code-review', 2)
1384 B.addApproval('code-review', 2)
1385 C.addApproval('code-review', 2)
1386 D.addApproval('code-review', 2)
1387 E.addApproval('code-review', 2)
1388 F.addApproval('code-review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001389
1390 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001391
1392 # Change object re-use in the gerrit trigger is hidden if
1393 # changes are added in quick succession; waiting makes it more
1394 # like real life.
James E. Blair8b5408c2016-08-08 15:37:46 -07001395 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001396 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001397 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001398 self.waitUntilSettled()
1399
Paul Belanger174a8272017-03-14 13:20:10 -04001400 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001401 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001402 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001403 self.waitUntilSettled()
1404
James E. Blair8b5408c2016-08-08 15:37:46 -07001405 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001406 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001407 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001408 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001409 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001410 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001411 self.fake_gerrit.addEvent(F.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001412 self.waitUntilSettled()
1413
Paul Belanger174a8272017-03-14 13:20:10 -04001414 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001415 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001416 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001417 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001418 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001419 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001420 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001421 self.waitUntilSettled()
1422
1423 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001424
1425 # Grab pointers to the jobs we want to release before
1426 # releasing any, because list indexes may change as
1427 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001428 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001429 a.release()
1430 b.release()
1431 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001432 self.waitUntilSettled()
1433
Paul Belanger174a8272017-03-14 13:20:10 -04001434 self.executor_server.hold_jobs_in_build = False
1435 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001436 self.waitUntilSettled()
1437
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001438 self.assertEqual(A.data['status'], 'NEW')
1439 self.assertEqual(B.data['status'], 'MERGED')
1440 self.assertEqual(C.data['status'], 'MERGED')
1441 self.assertEqual(D.data['status'], 'MERGED')
1442 self.assertEqual(E.data['status'], 'MERGED')
1443 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001444
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001445 self.assertEqual(A.reported, 2)
1446 self.assertEqual(B.reported, 2)
1447 self.assertEqual(C.reported, 2)
1448 self.assertEqual(D.reported, 2)
1449 self.assertEqual(E.reported, 2)
1450 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001451
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001452 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1453 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001454
1455 def test_merger_repack(self):
1456 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001457
James E. Blair05fed602012-09-07 12:45:24 -07001458 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001459 A.addApproval('code-review', 2)
1460 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001461 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001462 self.assertEqual(self.getJobFromHistory('project-merge').result,
1463 'SUCCESS')
1464 self.assertEqual(self.getJobFromHistory('project-test1').result,
1465 'SUCCESS')
1466 self.assertEqual(self.getJobFromHistory('project-test2').result,
1467 'SUCCESS')
1468 self.assertEqual(A.data['status'], 'MERGED')
1469 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001470 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001471 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001472
James E. Blair2a535672017-04-27 12:03:15 -07001473 path = os.path.join(self.merger_src_root, "review.example.com",
1474 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001475 if os.path.exists(path):
1476 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001477 path = os.path.join(self.executor_src_root, "review.example.com",
1478 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001479 if os.path.exists(path):
1480 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001481
1482 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001483 A.addApproval('code-review', 2)
1484 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001485 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001486 self.assertEqual(self.getJobFromHistory('project-merge').result,
1487 'SUCCESS')
1488 self.assertEqual(self.getJobFromHistory('project-test1').result,
1489 'SUCCESS')
1490 self.assertEqual(self.getJobFromHistory('project-test2').result,
1491 'SUCCESS')
1492 self.assertEqual(A.data['status'], 'MERGED')
1493 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001494
James E. Blair4886f282012-11-15 09:27:33 -08001495 def test_merger_repack_large_change(self):
1496 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001497 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001498 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001499 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6df67132017-04-19 13:53:20 -07001500 trusted, project = tenant.getProject('org/project')
James E. Blair0ffa0102017-03-30 13:11:33 -07001501 url = self.fake_gerrit.getGitUrl(project)
James E. Blair2a535672017-04-27 12:03:15 -07001502 self.merge_server.merger._addProject('review.example.com',
1503 'org/project', url)
James E. Blair6df67132017-04-19 13:53:20 -07001504 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair4886f282012-11-15 09:27:33 -08001505 A.addPatchset(large=True)
James E. Blair2a535672017-04-27 12:03:15 -07001506 # TODOv3(jeblair): add hostname to upstream root
1507 path = os.path.join(self.upstream_root, 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001508 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001509 path = os.path.join(self.merger_src_root, 'review.example.com',
1510 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001511 if os.path.exists(path):
1512 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001513 path = os.path.join(self.executor_src_root, 'review.example.com',
1514 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001515 if os.path.exists(path):
1516 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001517
James E. Blair8b5408c2016-08-08 15:37:46 -07001518 A.addApproval('code-review', 2)
1519 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001520 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001521 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001522 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001523 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001524 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001525 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001526 'SUCCESS')
1527 self.assertEqual(A.data['status'], 'MERGED')
1528 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001529
James E. Blair2fa50962013-01-30 21:50:41 -08001530 def test_new_patchset_dequeues_old(self):
1531 "Test that a new patchset causes the old to be dequeued"
1532 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001533 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001534 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1535 M.setMerged()
1536
1537 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1538 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1539 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1540 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001541 A.addApproval('code-review', 2)
1542 B.addApproval('code-review', 2)
1543 C.addApproval('code-review', 2)
1544 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001545
1546 C.setDependsOn(B, 1)
1547 B.setDependsOn(A, 1)
1548 A.setDependsOn(M, 1)
1549
James E. Blair8b5408c2016-08-08 15:37:46 -07001550 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1551 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1552 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1553 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001554 self.waitUntilSettled()
1555
1556 B.addPatchset()
1557 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1558 self.waitUntilSettled()
1559
Paul Belanger174a8272017-03-14 13:20:10 -04001560 self.executor_server.hold_jobs_in_build = False
1561 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001562 self.waitUntilSettled()
1563
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001564 self.assertEqual(A.data['status'], 'MERGED')
1565 self.assertEqual(A.reported, 2)
1566 self.assertEqual(B.data['status'], 'NEW')
1567 self.assertEqual(B.reported, 2)
1568 self.assertEqual(C.data['status'], 'NEW')
1569 self.assertEqual(C.reported, 2)
1570 self.assertEqual(D.data['status'], 'MERGED')
1571 self.assertEqual(D.reported, 2)
1572 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001573
James E. Blairba437362015-02-07 11:41:52 -08001574 def test_new_patchset_check(self):
1575 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001576
Paul Belanger174a8272017-03-14 13:20:10 -04001577 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001578
1579 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001580 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001581 tenant = self.sched.abide.tenants.get('tenant-one')
1582 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001583
1584 # Add two git-dependent changes
1585 B.setDependsOn(A, 1)
1586 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1587 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001588 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1589 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001590
1591 # A live item, and a non-live/live pair
1592 items = check_pipeline.getAllItems()
1593 self.assertEqual(len(items), 3)
1594
1595 self.assertEqual(items[0].change.number, '1')
1596 self.assertEqual(items[0].change.patchset, '1')
1597 self.assertFalse(items[0].live)
1598
1599 self.assertEqual(items[1].change.number, '2')
1600 self.assertEqual(items[1].change.patchset, '1')
1601 self.assertTrue(items[1].live)
1602
1603 self.assertEqual(items[2].change.number, '1')
1604 self.assertEqual(items[2].change.patchset, '1')
1605 self.assertTrue(items[2].live)
1606
1607 # Add a new patchset to A
1608 A.addPatchset()
1609 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1610 self.waitUntilSettled()
1611
1612 # The live copy of A,1 should be gone, but the non-live and B
1613 # should continue, and we should have a new A,2
1614 items = check_pipeline.getAllItems()
1615 self.assertEqual(len(items), 3)
1616
1617 self.assertEqual(items[0].change.number, '1')
1618 self.assertEqual(items[0].change.patchset, '1')
1619 self.assertFalse(items[0].live)
1620
1621 self.assertEqual(items[1].change.number, '2')
1622 self.assertEqual(items[1].change.patchset, '1')
1623 self.assertTrue(items[1].live)
1624
1625 self.assertEqual(items[2].change.number, '1')
1626 self.assertEqual(items[2].change.patchset, '2')
1627 self.assertTrue(items[2].live)
1628
1629 # Add a new patchset to B
1630 B.addPatchset()
1631 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1632 self.waitUntilSettled()
1633
1634 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1635 # but we should have a new B,2 (still based on A,1)
1636 items = check_pipeline.getAllItems()
1637 self.assertEqual(len(items), 3)
1638
1639 self.assertEqual(items[0].change.number, '1')
1640 self.assertEqual(items[0].change.patchset, '2')
1641 self.assertTrue(items[0].live)
1642
1643 self.assertEqual(items[1].change.number, '1')
1644 self.assertEqual(items[1].change.patchset, '1')
1645 self.assertFalse(items[1].live)
1646
1647 self.assertEqual(items[2].change.number, '2')
1648 self.assertEqual(items[2].change.patchset, '2')
1649 self.assertTrue(items[2].live)
1650
1651 self.builds[0].release()
1652 self.waitUntilSettled()
1653 self.builds[0].release()
1654 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001655 self.executor_server.hold_jobs_in_build = False
1656 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001657 self.waitUntilSettled()
1658
1659 self.assertEqual(A.reported, 1)
1660 self.assertEqual(B.reported, 1)
1661 self.assertEqual(self.history[0].result, 'ABORTED')
1662 self.assertEqual(self.history[0].changes, '1,1')
1663 self.assertEqual(self.history[1].result, 'ABORTED')
1664 self.assertEqual(self.history[1].changes, '1,1 2,1')
1665 self.assertEqual(self.history[2].result, 'SUCCESS')
1666 self.assertEqual(self.history[2].changes, '1,2')
1667 self.assertEqual(self.history[3].result, 'SUCCESS')
1668 self.assertEqual(self.history[3].changes, '1,1 2,2')
1669
1670 def test_abandoned_gate(self):
1671 "Test that an abandoned change is dequeued from gate"
1672
Paul Belanger174a8272017-03-14 13:20:10 -04001673 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001674
1675 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001676 A.addApproval('code-review', 2)
1677 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001678 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001679 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1680 self.assertEqual(self.builds[0].name, 'project-merge')
1681
1682 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1683 self.waitUntilSettled()
1684
Paul Belanger174a8272017-03-14 13:20:10 -04001685 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001686 self.waitUntilSettled()
1687
Arie5b4048c2016-10-05 16:12:06 +03001688 self.assertBuilds([])
1689 self.assertHistory([
1690 dict(name='project-merge', result='ABORTED', changes='1,1')],
1691 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001692 self.assertEqual(A.reported, 1,
1693 "Abandoned gate change should report only start")
1694
1695 def test_abandoned_check(self):
1696 "Test that an abandoned change is dequeued from check"
1697
Paul Belanger174a8272017-03-14 13:20:10 -04001698 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001699
1700 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1701 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001702 tenant = self.sched.abide.tenants.get('tenant-one')
1703 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001704
1705 # Add two git-dependent changes
1706 B.setDependsOn(A, 1)
1707 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1708 self.waitUntilSettled()
1709 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1710 self.waitUntilSettled()
1711 # A live item, and a non-live/live pair
1712 items = check_pipeline.getAllItems()
1713 self.assertEqual(len(items), 3)
1714
1715 self.assertEqual(items[0].change.number, '1')
1716 self.assertFalse(items[0].live)
1717
1718 self.assertEqual(items[1].change.number, '2')
1719 self.assertTrue(items[1].live)
1720
1721 self.assertEqual(items[2].change.number, '1')
1722 self.assertTrue(items[2].live)
1723
1724 # Abandon A
1725 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1726 self.waitUntilSettled()
1727
1728 # The live copy of A should be gone, but the non-live and B
1729 # should continue
1730 items = check_pipeline.getAllItems()
1731 self.assertEqual(len(items), 2)
1732
1733 self.assertEqual(items[0].change.number, '1')
1734 self.assertFalse(items[0].live)
1735
1736 self.assertEqual(items[1].change.number, '2')
1737 self.assertTrue(items[1].live)
1738
Paul Belanger174a8272017-03-14 13:20:10 -04001739 self.executor_server.hold_jobs_in_build = False
1740 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001741 self.waitUntilSettled()
1742
1743 self.assertEqual(len(self.history), 4)
1744 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001745 'Build should have been aborted')
1746 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001747 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001748
Steve Varnau7b78b312015-04-03 14:49:46 -07001749 def test_abandoned_not_timer(self):
1750 "Test that an abandoned change does not cancel timer jobs"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001751 # This test can not use simple_layout because it must start
1752 # with a configuration which does not include a
1753 # timer-triggered job so that we have an opportunity to set
1754 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04001755 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001756 # Start timer trigger - also org/project
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001757 self.commitConfigUpdate('common-config', 'layouts/idle.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001758 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001759 # The pipeline triggers every second, so we should have seen
1760 # several by now.
1761 time.sleep(5)
1762 self.waitUntilSettled()
1763 # Stop queuing timer triggered jobs so that the assertions
1764 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001765 # Must be in same repo, so overwrite config with another one
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001766 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001767 self.sched.reconfigure(self.config)
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001768
Steve Varnau7b78b312015-04-03 14:49:46 -07001769 self.assertEqual(len(self.builds), 2, "Two timer jobs")
1770
1771 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1772 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1773 self.waitUntilSettled()
1774 self.assertEqual(len(self.builds), 3, "One change plus two timer jobs")
1775
1776 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1777 self.waitUntilSettled()
1778
1779 self.assertEqual(len(self.builds), 2, "Two timer jobs remain")
1780
Paul Belanger174a8272017-03-14 13:20:10 -04001781 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001782 self.waitUntilSettled()
1783
Arx Cruzb1b010d2013-10-28 19:49:59 -02001784 def test_zuul_url_return(self):
1785 "Test if ZUUL_URL is returning when zuul_url is set in zuul.conf"
James E. Blair4076e2b2014-01-28 12:42:20 -08001786 self.assertTrue(self.sched.config.has_option('merger', 'zuul_url'))
Paul Belanger174a8272017-03-14 13:20:10 -04001787 self.executor_server.hold_jobs_in_build = True
Arx Cruzb1b010d2013-10-28 19:49:59 -02001788
1789 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001790 A.addApproval('code-review', 2)
1791 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Arx Cruzb1b010d2013-10-28 19:49:59 -02001792 self.waitUntilSettled()
1793
1794 self.assertEqual(len(self.builds), 1)
1795 for build in self.builds:
1796 self.assertTrue('ZUUL_URL' in build.parameters)
1797
Paul Belanger174a8272017-03-14 13:20:10 -04001798 self.executor_server.hold_jobs_in_build = False
1799 self.executor_server.release()
Arx Cruzb1b010d2013-10-28 19:49:59 -02001800 self.waitUntilSettled()
1801
James E. Blair2fa50962013-01-30 21:50:41 -08001802 def test_new_patchset_dequeues_old_on_head(self):
1803 "Test that a new patchset causes the old to be dequeued (at head)"
1804 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001805 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001806 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1807 M.setMerged()
1808 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1809 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1810 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1811 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001812 A.addApproval('code-review', 2)
1813 B.addApproval('code-review', 2)
1814 C.addApproval('code-review', 2)
1815 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001816
1817 C.setDependsOn(B, 1)
1818 B.setDependsOn(A, 1)
1819 A.setDependsOn(M, 1)
1820
James E. Blair8b5408c2016-08-08 15:37:46 -07001821 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1822 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1823 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1824 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001825 self.waitUntilSettled()
1826
1827 A.addPatchset()
1828 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1829 self.waitUntilSettled()
1830
Paul Belanger174a8272017-03-14 13:20:10 -04001831 self.executor_server.hold_jobs_in_build = False
1832 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001833 self.waitUntilSettled()
1834
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001835 self.assertEqual(A.data['status'], 'NEW')
1836 self.assertEqual(A.reported, 2)
1837 self.assertEqual(B.data['status'], 'NEW')
1838 self.assertEqual(B.reported, 2)
1839 self.assertEqual(C.data['status'], 'NEW')
1840 self.assertEqual(C.reported, 2)
1841 self.assertEqual(D.data['status'], 'MERGED')
1842 self.assertEqual(D.reported, 2)
1843 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08001844
1845 def test_new_patchset_dequeues_old_without_dependents(self):
1846 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04001847 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001848 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1849 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1850 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001851 A.addApproval('code-review', 2)
1852 B.addApproval('code-review', 2)
1853 C.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001854
James E. Blair8b5408c2016-08-08 15:37:46 -07001855 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1856 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1857 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001858 self.waitUntilSettled()
1859
1860 B.addPatchset()
1861 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1862 self.waitUntilSettled()
1863
Paul Belanger174a8272017-03-14 13:20:10 -04001864 self.executor_server.hold_jobs_in_build = False
1865 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001866 self.waitUntilSettled()
1867
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001868 self.assertEqual(A.data['status'], 'MERGED')
1869 self.assertEqual(A.reported, 2)
1870 self.assertEqual(B.data['status'], 'NEW')
1871 self.assertEqual(B.reported, 2)
1872 self.assertEqual(C.data['status'], 'MERGED')
1873 self.assertEqual(C.reported, 2)
1874 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08001875
1876 def test_new_patchset_dequeues_old_independent_queue(self):
1877 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04001878 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001879 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1880 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1881 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1882 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1883 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1884 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1885 self.waitUntilSettled()
1886
1887 B.addPatchset()
1888 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1889 self.waitUntilSettled()
1890
Paul Belanger174a8272017-03-14 13:20:10 -04001891 self.executor_server.hold_jobs_in_build = False
1892 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001893 self.waitUntilSettled()
1894
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001895 self.assertEqual(A.data['status'], 'NEW')
1896 self.assertEqual(A.reported, 1)
1897 self.assertEqual(B.data['status'], 'NEW')
1898 self.assertEqual(B.reported, 1)
1899 self.assertEqual(C.data['status'], 'NEW')
1900 self.assertEqual(C.reported, 1)
1901 self.assertEqual(len(self.history), 10)
1902 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001903
James E. Blaircc020532017-04-19 13:04:44 -07001904 @simple_layout('layouts/noop-job.yaml')
James E. Blair18c64442014-03-18 10:14:45 -07001905 def test_noop_job(self):
1906 "Test that the internal noop job works"
1907 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001908 A.addApproval('code-review', 2)
1909 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07001910 self.waitUntilSettled()
1911
1912 self.assertEqual(len(self.gearman_server.getQueue()), 0)
1913 self.assertTrue(self.sched._areAllBuildsComplete())
1914 self.assertEqual(len(self.history), 0)
1915 self.assertEqual(A.data['status'], 'MERGED')
1916 self.assertEqual(A.reported, 2)
1917
James E. Blair06cc3922017-04-19 10:08:10 -07001918 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001919 def test_no_job_project(self):
1920 "Test that reports with no jobs don't get sent"
1921 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
1922 'master', 'A')
1923 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1924 self.waitUntilSettled()
1925
1926 # Change wasn't reported to
1927 self.assertEqual(A.reported, False)
1928
1929 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08001930 tenant = self.sched.abide.tenants.get('tenant-one')
1931 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001932 items = check_pipeline.getAllItems()
1933 self.assertEqual(len(items), 0)
1934
1935 self.assertEqual(len(self.history), 0)
1936
James E. Blair7d0dedc2013-02-21 17:26:09 -08001937 def test_zuul_refs(self):
1938 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04001939 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08001940 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
1941 M1.setMerged()
1942 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
1943 M2.setMerged()
1944
1945 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1946 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1947 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1948 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001949 A.addApproval('code-review', 2)
1950 B.addApproval('code-review', 2)
1951 C.addApproval('code-review', 2)
1952 D.addApproval('code-review', 2)
1953 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1954 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1955 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1956 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001957
1958 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001959 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001960 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001961 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001962 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001963 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001964 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001965 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001966 self.waitUntilSettled()
1967
James E. Blair7d0dedc2013-02-21 17:26:09 -08001968 a_zref = b_zref = c_zref = d_zref = None
Clint Byrum3343e3e2016-11-15 16:05:03 -08001969 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001970 for x in self.builds:
James E. Blair7d0dedc2013-02-21 17:26:09 -08001971 if x.parameters['ZUUL_CHANGE'] == '3':
1972 a_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001973 a_build = x
1974 elif x.parameters['ZUUL_CHANGE'] == '4':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001975 b_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001976 b_build = x
1977 elif x.parameters['ZUUL_CHANGE'] == '5':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001978 c_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001979 c_build = x
1980 elif x.parameters['ZUUL_CHANGE'] == '6':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001981 d_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001982 d_build = x
1983 if a_build and b_build and c_build and d_build:
1984 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08001985
1986 # There are... four... refs.
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001987 self.assertIsNotNone(a_zref)
1988 self.assertIsNotNone(b_zref)
1989 self.assertIsNotNone(c_zref)
1990 self.assertIsNotNone(d_zref)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001991
1992 # And they should all be different
1993 refs = set([a_zref, b_zref, c_zref, d_zref])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001994 self.assertEqual(len(refs), 4)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001995
Clint Byrum3343e3e2016-11-15 16:05:03 -08001996 # should have a, not b, and should not be in project2
1997 self.assertTrue(a_build.hasChanges(A))
1998 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001999
Clint Byrum3343e3e2016-11-15 16:05:03 -08002000 # should have a and b, and should not be in project2
2001 self.assertTrue(b_build.hasChanges(A, B))
2002 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002003
Clint Byrum3343e3e2016-11-15 16:05:03 -08002004 # should have a and b in 1, c in 2
2005 self.assertTrue(c_build.hasChanges(A, B, C))
2006 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002007
Clint Byrum3343e3e2016-11-15 16:05:03 -08002008 # should have a and b in 1, c and d in 2
2009 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002010
Paul Belanger174a8272017-03-14 13:20:10 -04002011 self.executor_server.hold_jobs_in_build = False
2012 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002013 self.waitUntilSettled()
2014
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002015 self.assertEqual(A.data['status'], 'MERGED')
2016 self.assertEqual(A.reported, 2)
2017 self.assertEqual(B.data['status'], 'MERGED')
2018 self.assertEqual(B.reported, 2)
2019 self.assertEqual(C.data['status'], 'MERGED')
2020 self.assertEqual(C.reported, 2)
2021 self.assertEqual(D.data['status'], 'MERGED')
2022 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002023
James E. Blair4a28a882013-08-23 15:17:33 -07002024 def test_rerun_on_error(self):
2025 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002026 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002027 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002028 A.addApproval('code-review', 2)
2029 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002030 self.waitUntilSettled()
2031
James E. Blair412fba82017-01-26 15:00:50 -08002032 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002033 self.executor_server.hold_jobs_in_build = False
2034 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002035 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002036 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002037 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2038
James E. Blair412e5582013-04-22 15:50:12 -07002039 def test_statsd(self):
2040 "Test each of the statsd methods used in the scheduler"
2041 import extras
2042 statsd = extras.try_import('statsd.statsd')
2043 statsd.incr('test-incr')
2044 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002045 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002046 self.assertReportedStat('test-incr', '1|c')
2047 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002048 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002049
James E. Blairdad52252014-02-07 16:59:17 -08002050 def test_stuck_job_cleanup(self):
2051 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002052
2053 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002054 self.gearman_server.hold_jobs_in_queue = True
2055 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002056 A.addApproval('code-review', 2)
2057 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002058 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002059 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002060 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2061
James E. Blair31cb3e82017-04-20 13:08:56 -07002062 self.commitConfigUpdate('common-config', 'layouts/no-jobs.yaml')
James E. Blairdad52252014-02-07 16:59:17 -08002063 self.sched.reconfigure(self.config)
2064 self.waitUntilSettled()
2065
James E. Blair18c64442014-03-18 10:14:45 -07002066 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002067 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002068 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002069 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2070 self.assertTrue(self.sched._areAllBuildsComplete())
2071
2072 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002073 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002074 self.assertEqual(self.history[0].result, 'SUCCESS')
2075
James E. Blair879dafb2015-07-17 14:04:49 -07002076 def test_file_head(self):
2077 # This is a regression test for an observed bug. A change
2078 # with a file named "HEAD" in the root directory of the repo
2079 # was processed by a merger. It then was unable to reset the
2080 # repo because of:
2081 # GitCommandError: 'git reset --hard HEAD' returned
2082 # with exit code 128
2083 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2084 # and filename
2085 # Use '--' to separate filenames from revisions'
2086
2087 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002088 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002089 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2090
2091 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2092 self.waitUntilSettled()
2093
2094 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2095 self.waitUntilSettled()
2096
2097 self.assertIn('Build succeeded', A.messages[0])
2098 self.assertIn('Build succeeded', B.messages[0])
2099
James E. Blair70c71582013-03-06 08:50:50 -08002100 def test_file_jobs(self):
2101 "Test that file jobs run only when appropriate"
2102 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002103 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002104 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07002105 A.addApproval('code-review', 2)
2106 B.addApproval('code-review', 2)
2107 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2108 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002109 self.waitUntilSettled()
2110
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002111 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002112 if x.name == 'project-testfile']
2113
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002114 self.assertEqual(len(testfile_jobs), 1)
2115 self.assertEqual(testfile_jobs[0].changes, '1,2')
2116 self.assertEqual(A.data['status'], 'MERGED')
2117 self.assertEqual(A.reported, 2)
2118 self.assertEqual(B.data['status'], 'MERGED')
2119 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002120
Clint Byrum3ee39f32016-11-17 23:45:07 -08002121 def _test_irrelevant_files_jobs(self, should_skip):
2122 "Test that jobs with irrelevant-files filter run only when appropriate"
Clint Byrum3ee39f32016-11-17 23:45:07 -08002123 if should_skip:
2124 files = {'ignoreme': 'ignored\n'}
2125 else:
2126 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002127
2128 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002129 'master',
2130 'test irrelevant-files',
2131 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002132 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2133 self.waitUntilSettled()
2134
2135 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002136 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002137
2138 if should_skip:
2139 self.assertEqual([], tested_change_ids)
2140 else:
2141 self.assertIn(change.data['number'], tested_change_ids)
2142
James E. Blaircc324192017-04-19 14:36:08 -07002143 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002144 def test_irrelevant_files_match_skips_job(self):
2145 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002146
James E. Blaircc324192017-04-19 14:36:08 -07002147 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002148 def test_irrelevant_files_no_match_runs_job(self):
2149 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002150
James E. Blaircc324192017-04-19 14:36:08 -07002151 @simple_layout('layouts/inheritance.yaml')
Clint Byrum85493602016-11-18 11:59:47 -08002152 def test_inherited_jobs_keep_matchers(self):
Clint Byrum85493602016-11-18 11:59:47 -08002153 files = {'ignoreme': 'ignored\n'}
2154
2155 change = self.fake_gerrit.addFakeChange('org/project',
2156 'master',
2157 'test irrelevant-files',
2158 files=files)
2159 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2160 self.waitUntilSettled()
2161
2162 run_jobs = set([build.name for build in self.history])
2163
2164 self.assertEqual(set(['project-test-nomatch-starts-empty',
2165 'project-test-nomatch-starts-full']), run_jobs)
2166
James E. Blairc8a1e052014-02-25 09:29:26 -08002167 def test_queue_names(self):
2168 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002169 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002170 (trusted, project1) = tenant.getProject('org/project1')
2171 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002172 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2173 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2174 self.assertEqual(q1.name, 'integrated')
2175 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002176
James E. Blair64ed6f22013-07-10 14:07:23 -07002177 def test_queue_precedence(self):
2178 "Test that queue precedence works"
2179
2180 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002181 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002182 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2183 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
James E. Blair8b5408c2016-08-08 15:37:46 -07002184 A.addApproval('code-review', 2)
2185 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002186
2187 self.waitUntilSettled()
2188 self.gearman_server.hold_jobs_in_queue = False
2189 self.gearman_server.release()
2190 self.waitUntilSettled()
2191
James E. Blair8de58bd2013-07-18 16:23:33 -07002192 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002193 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002194 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002195 self.waitUntilSettled()
2196
James E. Blair64ed6f22013-07-10 14:07:23 -07002197 self.log.debug(self.history)
2198 self.assertEqual(self.history[0].pipeline, 'gate')
2199 self.assertEqual(self.history[1].pipeline, 'check')
2200 self.assertEqual(self.history[2].pipeline, 'gate')
2201 self.assertEqual(self.history[3].pipeline, 'gate')
2202 self.assertEqual(self.history[4].pipeline, 'check')
2203 self.assertEqual(self.history[5].pipeline, 'check')
2204
Clark Boylana5edbe42014-06-03 16:39:10 -07002205 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002206 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002207 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002208 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002209 A.addApproval('code-review', 2)
2210 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002211 self.waitUntilSettled()
2212
Paul Belanger174a8272017-03-14 13:20:10 -04002213 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002214 self.waitUntilSettled()
2215
James E. Blair1843a552013-07-03 14:19:52 -07002216 port = self.webapp.server.socket.getsockname()[1]
2217
Adam Gandelman77a12c72017-02-03 17:43:43 -08002218 req = urllib.request.Request(
2219 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002220 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002221 headers = f.info()
2222 self.assertIn('Content-Length', headers)
2223 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002224 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2225 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002226 self.assertIn('Access-Control-Allow-Origin', headers)
2227 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002228 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002229 self.assertIn('Expires', headers)
James E. Blair1843a552013-07-03 14:19:52 -07002230 data = f.read()
2231
Paul Belanger174a8272017-03-14 13:20:10 -04002232 self.executor_server.hold_jobs_in_build = False
2233 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002234 self.waitUntilSettled()
2235
2236 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002237 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002238 for p in data['pipelines']:
2239 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002240 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002241 self.assertEqual(q['window'], 20)
2242 else:
2243 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002244 for head in q['heads']:
2245 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002246 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002247 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002248 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002249 status_jobs.append(job)
2250 self.assertEqual('project-merge', status_jobs[0]['name'])
2251 self.assertEqual('https://server/job/project-merge/0/',
2252 status_jobs[0]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002253 self.assertEqual('https://server/job/project-merge/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002254 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002255 self.assertEqual('project-test1', status_jobs[1]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002256 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002257 status_jobs[1]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002258 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002259 status_jobs[1]['report_url'])
2260
2261 self.assertEqual('project-test2', status_jobs[2]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002262 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002263 status_jobs[2]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002264 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002265 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002266
James E. Blaircdccd972013-07-01 12:10:22 -07002267 def test_live_reconfiguration(self):
2268 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002269 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002270 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002271 A.addApproval('code-review', 2)
2272 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002273 self.waitUntilSettled()
2274
2275 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002276 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002277
Paul Belanger174a8272017-03-14 13:20:10 -04002278 self.executor_server.hold_jobs_in_build = False
2279 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002280 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002281 self.assertEqual(self.getJobFromHistory('project-merge').result,
2282 'SUCCESS')
2283 self.assertEqual(self.getJobFromHistory('project-test1').result,
2284 'SUCCESS')
2285 self.assertEqual(self.getJobFromHistory('project-test2').result,
2286 'SUCCESS')
2287 self.assertEqual(A.data['status'], 'MERGED')
2288 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002289
James E. Blair6bc782d2015-07-17 16:20:21 -07002290 def test_live_reconfiguration_merge_conflict(self):
2291 # A real-world bug: a change in a gate queue has a merge
2292 # conflict and a job is added to its project while it's
2293 # sitting in the queue. The job gets added to the change and
2294 # enqueued and the change gets stuck.
Paul Belanger174a8272017-03-14 13:20:10 -04002295 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002296
2297 # This change is fine. It's here to stop the queue long
2298 # enough for the next change to be subject to the
2299 # reconfiguration, as well as to provide a conflict for the
2300 # next change. This change will succeed and merge.
2301 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum073c00b2017-05-01 13:41:23 -07002302 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002303 A.addApproval('code-review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002304
2305 # This change will be in merge conflict. During the
2306 # reconfiguration, we will add a job. We want to make sure
2307 # that doesn't cause it to get stuck.
2308 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Clint Byrum073c00b2017-05-01 13:41:23 -07002309 B.addPatchset({'conflict': 'B'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002310 B.addApproval('code-review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002311
James E. Blair8b5408c2016-08-08 15:37:46 -07002312 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2313 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002314
2315 self.waitUntilSettled()
2316
2317 # No jobs have run yet
2318 self.assertEqual(A.data['status'], 'NEW')
2319 self.assertEqual(A.reported, 1)
2320 self.assertEqual(B.data['status'], 'NEW')
2321 self.assertEqual(B.reported, 1)
2322 self.assertEqual(len(self.history), 0)
2323
2324 # Add the "project-test3" job.
Clint Byrum073c00b2017-05-01 13:41:23 -07002325 self.commitConfigUpdate('common-config',
2326 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002327 self.sched.reconfigure(self.config)
2328 self.waitUntilSettled()
2329
Paul Belanger174a8272017-03-14 13:20:10 -04002330 self.executor_server.hold_jobs_in_build = False
2331 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002332 self.waitUntilSettled()
2333
2334 self.assertEqual(A.data['status'], 'MERGED')
2335 self.assertEqual(A.reported, 2)
2336 self.assertEqual(B.data['status'], 'NEW')
2337 self.assertEqual(B.reported, 2)
2338 self.assertEqual(self.getJobFromHistory('project-merge').result,
2339 'SUCCESS')
2340 self.assertEqual(self.getJobFromHistory('project-test1').result,
2341 'SUCCESS')
2342 self.assertEqual(self.getJobFromHistory('project-test2').result,
2343 'SUCCESS')
2344 self.assertEqual(self.getJobFromHistory('project-test3').result,
2345 'SUCCESS')
2346 self.assertEqual(len(self.history), 4)
2347
James E. Blair400e8fd2015-07-30 17:44:45 -07002348 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002349 # An extrapolation of test_live_reconfiguration_merge_conflict
2350 # that tests a job added to a job tree with a failed root does
2351 # not run.
Paul Belanger174a8272017-03-14 13:20:10 -04002352 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002353
2354 # This change is fine. It's here to stop the queue long
2355 # enough for the next change to be subject to the
2356 # reconfiguration. This change will succeed and merge.
2357 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Clint Byrum3147d652017-05-01 14:01:42 -07002358 A.addPatchset({'conflict': 'A'})
James E. Blair8b5408c2016-08-08 15:37:46 -07002359 A.addApproval('code-review', 2)
2360 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002361 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002362 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002363 self.waitUntilSettled()
2364
2365 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002366 self.executor_server.failJob('project-merge', B)
James E. Blair8b5408c2016-08-08 15:37:46 -07002367 B.addApproval('code-review', 2)
2368 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002369 self.waitUntilSettled()
2370
Paul Belanger174a8272017-03-14 13:20:10 -04002371 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002372 self.waitUntilSettled()
2373
2374 # Both -merge jobs have run, but no others.
2375 self.assertEqual(A.data['status'], 'NEW')
2376 self.assertEqual(A.reported, 1)
2377 self.assertEqual(B.data['status'], 'NEW')
2378 self.assertEqual(B.reported, 1)
2379 self.assertEqual(self.history[0].result, 'SUCCESS')
2380 self.assertEqual(self.history[0].name, 'project-merge')
2381 self.assertEqual(self.history[1].result, 'FAILURE')
2382 self.assertEqual(self.history[1].name, 'project-merge')
2383 self.assertEqual(len(self.history), 2)
2384
2385 # Add the "project-test3" job.
Clint Byrum3147d652017-05-01 14:01:42 -07002386 self.commitConfigUpdate('common-config',
2387 'layouts/live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002388 self.sched.reconfigure(self.config)
2389 self.waitUntilSettled()
2390
Paul Belanger174a8272017-03-14 13:20:10 -04002391 self.executor_server.hold_jobs_in_build = False
2392 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002393 self.waitUntilSettled()
2394
2395 self.assertEqual(A.data['status'], 'MERGED')
2396 self.assertEqual(A.reported, 2)
2397 self.assertEqual(B.data['status'], 'NEW')
2398 self.assertEqual(B.reported, 2)
2399 self.assertEqual(self.history[0].result, 'SUCCESS')
2400 self.assertEqual(self.history[0].name, 'project-merge')
2401 self.assertEqual(self.history[1].result, 'FAILURE')
2402 self.assertEqual(self.history[1].name, 'project-merge')
2403 self.assertEqual(self.history[2].result, 'SUCCESS')
2404 self.assertEqual(self.history[3].result, 'SUCCESS')
2405 self.assertEqual(self.history[4].result, 'SUCCESS')
2406 self.assertEqual(len(self.history), 5)
2407
James E. Blair400e8fd2015-07-30 17:44:45 -07002408 def test_live_reconfiguration_failed_job(self):
2409 # Test that a change with a removed failing job does not
2410 # disrupt reconfiguration. If a change has a failed job and
2411 # that job is removed during a reconfiguration, we observed a
2412 # bug where the code to re-set build statuses would run on
2413 # that build and raise an exception because the job no longer
2414 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002415 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002416
2417 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2418
2419 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002420 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002421
2422 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2423 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002424 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002425 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002426 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002427 self.waitUntilSettled()
2428
2429 self.assertEqual(A.data['status'], 'NEW')
2430 self.assertEqual(A.reported, 0)
2431
2432 self.assertEqual(self.getJobFromHistory('project-merge').result,
2433 'SUCCESS')
2434 self.assertEqual(self.getJobFromHistory('project-test1').result,
2435 'FAILURE')
2436 self.assertEqual(len(self.history), 2)
2437
2438 # Remove the test1 job.
Clint Byrum841a58c2017-05-01 14:17:21 -07002439 self.commitConfigUpdate('common-config',
2440 'layouts/live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002441 self.sched.reconfigure(self.config)
2442 self.waitUntilSettled()
2443
Paul Belanger174a8272017-03-14 13:20:10 -04002444 self.executor_server.hold_jobs_in_build = False
2445 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002446 self.waitUntilSettled()
2447
2448 self.assertEqual(self.getJobFromHistory('project-test2').result,
2449 'SUCCESS')
2450 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2451 'SUCCESS')
2452 self.assertEqual(len(self.history), 4)
2453
2454 self.assertEqual(A.data['status'], 'NEW')
2455 self.assertEqual(A.reported, 1)
2456 self.assertIn('Build succeeded', A.messages[0])
2457 # Ensure the removed job was not included in the report.
2458 self.assertNotIn('project-test1', A.messages[0])
2459
James E. Blairfe707d12015-08-05 15:18:15 -07002460 def test_live_reconfiguration_shared_queue(self):
2461 # Test that a change with a failing job which was removed from
2462 # this project but otherwise still exists in the system does
2463 # not disrupt reconfiguration.
2464
Paul Belanger174a8272017-03-14 13:20:10 -04002465 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002466
2467 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2468
Paul Belanger174a8272017-03-14 13:20:10 -04002469 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002470
2471 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2472 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002473 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002474 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002475 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002476 self.waitUntilSettled()
2477
2478 self.assertEqual(A.data['status'], 'NEW')
2479 self.assertEqual(A.reported, 0)
2480
Clint Byrum69663d42017-05-01 14:51:04 -07002481 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002482 'SUCCESS')
2483 self.assertEqual(self.getJobFromHistory(
2484 'project1-project2-integration').result, 'FAILURE')
2485 self.assertEqual(len(self.history), 2)
2486
2487 # Remove the integration job.
Clint Byrum69663d42017-05-01 14:51:04 -07002488 self.commitConfigUpdate(
2489 'common-config',
2490 'layouts/live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002491 self.sched.reconfigure(self.config)
2492 self.waitUntilSettled()
2493
Paul Belanger174a8272017-03-14 13:20:10 -04002494 self.executor_server.hold_jobs_in_build = False
2495 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002496 self.waitUntilSettled()
2497
Clint Byrum69663d42017-05-01 14:51:04 -07002498 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002499 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002500 self.assertEqual(self.getJobFromHistory('project-test1').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002501 'SUCCESS')
Clint Byrum69663d42017-05-01 14:51:04 -07002502 self.assertEqual(self.getJobFromHistory('project-test2').result,
James E. Blairfe707d12015-08-05 15:18:15 -07002503 'SUCCESS')
2504 self.assertEqual(self.getJobFromHistory(
2505 'project1-project2-integration').result, 'FAILURE')
2506 self.assertEqual(len(self.history), 4)
2507
2508 self.assertEqual(A.data['status'], 'NEW')
2509 self.assertEqual(A.reported, 1)
2510 self.assertIn('Build succeeded', A.messages[0])
2511 # Ensure the removed job was not included in the report.
2512 self.assertNotIn('project1-project2-integration', A.messages[0])
2513
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002514 def test_double_live_reconfiguration_shared_queue(self):
2515 # This was a real-world regression. A change is added to
2516 # gate; a reconfigure happens, a second change which depends
2517 # on the first is added, and a second reconfiguration happens.
2518 # Ensure that both changes merge.
2519
2520 # A failure may indicate incorrect caching or cleaning up of
2521 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002522 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002523
2524 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2525 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2526 B.setDependsOn(A, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07002527 A.addApproval('code-review', 2)
2528 B.addApproval('code-review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002529
2530 # Add the parent change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002531 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002532 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002533 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002534 self.waitUntilSettled()
2535
2536 # Reconfigure (with only one change in the pipeline).
2537 self.sched.reconfigure(self.config)
2538 self.waitUntilSettled()
2539
2540 # Add the child change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002541 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002542 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002543 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002544 self.waitUntilSettled()
2545
2546 # Reconfigure (with both in the pipeline).
2547 self.sched.reconfigure(self.config)
2548 self.waitUntilSettled()
2549
Paul Belanger174a8272017-03-14 13:20:10 -04002550 self.executor_server.hold_jobs_in_build = False
2551 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002552 self.waitUntilSettled()
2553
2554 self.assertEqual(len(self.history), 8)
2555
2556 self.assertEqual(A.data['status'], 'MERGED')
2557 self.assertEqual(A.reported, 2)
2558 self.assertEqual(B.data['status'], 'MERGED')
2559 self.assertEqual(B.reported, 2)
2560
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002561 def test_live_reconfiguration_del_project(self):
2562 # Test project deletion from layout
2563 # while changes are enqueued
2564
Paul Belanger174a8272017-03-14 13:20:10 -04002565 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002566 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2567 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2568 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2569
2570 # A Depends-On: B
2571 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2572 A.subject, B.data['id'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002573 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002574
2575 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2576 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2577 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002578 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002579 self.waitUntilSettled()
2580 self.assertEqual(len(self.builds), 5)
2581
2582 # This layout defines only org/project, not org/project1
James E. Blair31cb3e82017-04-20 13:08:56 -07002583 self.commitConfigUpdate(
2584 'common-config',
2585 'layouts/live-reconfiguration-del-project.yaml')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002586 self.sched.reconfigure(self.config)
2587 self.waitUntilSettled()
2588
2589 # Builds for C aborted, builds for A succeed,
2590 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002591 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002592 self.assertEqual(job_c.changes, '3,1')
2593 self.assertEqual(job_c.result, 'ABORTED')
2594
Paul Belanger174a8272017-03-14 13:20:10 -04002595 self.executor_server.hold_jobs_in_build = False
2596 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002597 self.waitUntilSettled()
2598
Clint Byrum0149ada2017-04-04 12:22:01 -07002599 self.assertEqual(
2600 self.getJobFromHistory('project-test1', 'org/project').changes,
2601 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002602
2603 self.assertEqual(A.data['status'], 'NEW')
2604 self.assertEqual(B.data['status'], 'NEW')
2605 self.assertEqual(C.data['status'], 'NEW')
2606 self.assertEqual(A.reported, 1)
2607 self.assertEqual(B.reported, 0)
2608 self.assertEqual(C.reported, 0)
2609
Clint Byrum0149ada2017-04-04 12:22:01 -07002610 tenant = self.sched.abide.tenants.get('tenant-one')
2611 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002612 self.assertIn('Build succeeded', A.messages[0])
2613
James E. Blairec056492016-07-22 09:45:56 -07002614 @skip("Disabled for early v3 development")
James E. Blair287c06d2013-07-24 10:39:30 -07002615 def test_delayed_repo_init(self):
James E. Blairf84026c2015-12-08 16:11:46 -08002616 self.updateConfigLayout(
2617 'tests/fixtures/layout-delayed-repo-init.yaml')
James E. Blair287c06d2013-07-24 10:39:30 -07002618 self.sched.reconfigure(self.config)
2619
2620 self.init_repo("org/new-project")
2621 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2622
James E. Blair8b5408c2016-08-08 15:37:46 -07002623 A.addApproval('code-review', 2)
2624 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002625 self.waitUntilSettled()
2626 self.assertEqual(self.getJobFromHistory('project-merge').result,
2627 'SUCCESS')
2628 self.assertEqual(self.getJobFromHistory('project-test1').result,
2629 'SUCCESS')
2630 self.assertEqual(self.getJobFromHistory('project-test2').result,
2631 'SUCCESS')
2632 self.assertEqual(A.data['status'], 'MERGED')
2633 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002634
James E. Blair9ea70072017-04-19 16:05:30 -07002635 @simple_layout('layouts/repo-deleted.yaml')
Clark Boylan6dbbc482013-10-18 10:57:31 -07002636 def test_repo_deleted(self):
Clark Boylan6dbbc482013-10-18 10:57:31 -07002637 self.init_repo("org/delete-project")
2638 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2639
James E. Blair8b5408c2016-08-08 15:37:46 -07002640 A.addApproval('code-review', 2)
2641 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002642 self.waitUntilSettled()
2643 self.assertEqual(self.getJobFromHistory('project-merge').result,
2644 'SUCCESS')
2645 self.assertEqual(self.getJobFromHistory('project-test1').result,
2646 'SUCCESS')
2647 self.assertEqual(self.getJobFromHistory('project-test2').result,
2648 'SUCCESS')
2649 self.assertEqual(A.data['status'], 'MERGED')
2650 self.assertEqual(A.reported, 2)
2651
2652 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002653 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002654 if os.path.exists(os.path.join(self.merger_src_root, p)):
2655 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002656 if os.path.exists(os.path.join(self.executor_src_root, p)):
2657 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002658
2659 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2660
James E. Blair8b5408c2016-08-08 15:37:46 -07002661 B.addApproval('code-review', 2)
2662 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002663 self.waitUntilSettled()
2664 self.assertEqual(self.getJobFromHistory('project-merge').result,
2665 'SUCCESS')
2666 self.assertEqual(self.getJobFromHistory('project-test1').result,
2667 'SUCCESS')
2668 self.assertEqual(self.getJobFromHistory('project-test2').result,
2669 'SUCCESS')
2670 self.assertEqual(B.data['status'], 'MERGED')
2671 self.assertEqual(B.reported, 2)
2672
James E. Blaire68d43f2017-04-19 14:03:30 -07002673 @simple_layout('layouts/tags.yaml')
James E. Blair456f2fb2016-02-09 09:29:33 -08002674 def test_tags(self):
2675 "Test job tags"
James E. Blair456f2fb2016-02-09 09:29:33 -08002676 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2677 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2678 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2679 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2680 self.waitUntilSettled()
2681
James E. Blaire68d43f2017-04-19 14:03:30 -07002682 self.assertEqual(len(self.history), 2)
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002683
2684 results = {self.getJobFromHistory('merge',
2685 project='org/project1').uuid: 'extratag merge',
2686 self.getJobFromHistory('merge',
2687 project='org/project2').uuid: 'merge'}
James E. Blair456f2fb2016-02-09 09:29:33 -08002688
2689 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002690 self.assertEqual(results.get(build.uuid, ''),
2691 build.parameters['vars']['zuul'].get('tags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08002692
James E. Blair63bb0ef2013-07-29 17:14:51 -07002693 def test_timer(self):
2694 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002695 # This test can not use simple_layout because it must start
2696 # with a configuration which does not include a
2697 # timer-triggered job so that we have an opportunity to set
2698 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002699 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002700 self.commitConfigUpdate('common-config', 'layouts/timer.yaml')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002701 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002702
Clark Boylan3ee090a2014-04-03 20:55:09 -07002703 # The pipeline triggers every second, so we should have seen
2704 # several by now.
2705 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002706 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07002707
2708 self.assertEqual(len(self.builds), 2)
2709
James E. Blair63bb0ef2013-07-29 17:14:51 -07002710 port = self.webapp.server.socket.getsockname()[1]
2711
Clint Byrum5e729e92017-02-08 06:34:57 -08002712 req = urllib.request.Request(
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002713 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002714 f = urllib.request.urlopen(req)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002715 data = f.read()
2716
Paul Belanger174a8272017-03-14 13:20:10 -04002717 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07002718 # Stop queuing timer triggered jobs so that the assertions
2719 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002720 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002721 self.sched.reconfigure(self.config)
Paul Belanger174a8272017-03-14 13:20:10 -04002722 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07002723 self.waitUntilSettled()
2724
2725 self.assertEqual(self.getJobFromHistory(
2726 'project-bitrot-stable-old').result, 'SUCCESS')
2727 self.assertEqual(self.getJobFromHistory(
2728 'project-bitrot-stable-older').result, 'SUCCESS')
2729
2730 data = json.loads(data)
2731 status_jobs = set()
2732 for p in data['pipelines']:
2733 for q in p['change_queues']:
2734 for head in q['heads']:
2735 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07002736 for job in change['jobs']:
2737 status_jobs.add(job['name'])
2738 self.assertIn('project-bitrot-stable-old', status_jobs)
2739 self.assertIn('project-bitrot-stable-older', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002740
James E. Blair4f6033c2014-03-27 15:49:09 -07002741 def test_idle(self):
2742 "Test that frequent periodic jobs work"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002743 # This test can not use simple_layout because it must start
2744 # with a configuration which does not include a
2745 # timer-triggered job so that we have an opportunity to set
2746 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002747 self.executor_server.hold_jobs_in_build = True
James E. Blair4f6033c2014-03-27 15:49:09 -07002748
Clark Boylan3ee090a2014-04-03 20:55:09 -07002749 for x in range(1, 3):
2750 # Test that timer triggers periodic jobs even across
2751 # layout config reloads.
2752 # Start timer trigger
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002753 self.commitConfigUpdate('common-config',
2754 'layouts/idle.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002755 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002756 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07002757
Clark Boylan3ee090a2014-04-03 20:55:09 -07002758 # The pipeline triggers every second, so we should have seen
2759 # several by now.
2760 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07002761
2762 # Stop queuing timer triggered jobs so that the assertions
2763 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002764 self.commitConfigUpdate('common-config',
2765 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002766 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002767 self.waitUntilSettled()
Clint Byrum58264dc2017-02-07 21:21:22 -08002768 self.assertEqual(len(self.builds), 2,
2769 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04002770 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002771 self.waitUntilSettled()
2772 self.assertEqual(len(self.builds), 0)
2773 self.assertEqual(len(self.history), x * 2)
James E. Blair4f6033c2014-03-27 15:49:09 -07002774
James E. Blaircc324192017-04-19 14:36:08 -07002775 @simple_layout('layouts/smtp.yaml')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002776 def test_check_smtp_pool(self):
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002777 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2778 self.waitUntilSettled()
2779
2780 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2781 self.waitUntilSettled()
2782
James E. Blairff80a2f2013-12-27 13:24:06 -08002783 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002784
2785 # A.messages only holds what FakeGerrit places in it. Thus we
2786 # work on the knowledge of what the first message should be as
2787 # it is only configured to go to SMTP.
2788
2789 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002790 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002791 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002792 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002793 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08002794 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002795
2796 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002797 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002798 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002799 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002800 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08002801 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08002802
James E. Blaire5910202013-12-27 09:50:31 -08002803 def test_timer_smtp(self):
2804 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002805 # This test can not use simple_layout because it must start
2806 # with a configuration which does not include a
2807 # timer-triggered job so that we have an opportunity to set
2808 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002809 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002810 self.commitConfigUpdate('common-config', 'layouts/timer-smtp.yaml')
James E. Blaire5910202013-12-27 09:50:31 -08002811 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08002812
Clark Boylan3ee090a2014-04-03 20:55:09 -07002813 # The pipeline triggers every second, so we should have seen
2814 # several by now.
2815 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08002816 self.waitUntilSettled()
2817
Clark Boylan3ee090a2014-04-03 20:55:09 -07002818 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04002819 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002820 self.waitUntilSettled()
2821 self.assertEqual(len(self.history), 2)
2822
James E. Blaire5910202013-12-27 09:50:31 -08002823 self.assertEqual(self.getJobFromHistory(
2824 'project-bitrot-stable-old').result, 'SUCCESS')
2825 self.assertEqual(self.getJobFromHistory(
2826 'project-bitrot-stable-older').result, 'SUCCESS')
2827
James E. Blairff80a2f2013-12-27 13:24:06 -08002828 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08002829
2830 # A.messages only holds what FakeGerrit places in it. Thus we
2831 # work on the knowledge of what the first message should be as
2832 # it is only configured to go to SMTP.
2833
2834 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002835 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002836 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002837 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002838 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08002839 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08002840
Clark Boylan3ee090a2014-04-03 20:55:09 -07002841 # Stop queuing timer triggered jobs and let any that may have
2842 # queued through so that end of test assertions pass.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002843 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002844 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07002845 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002846 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002847 self.waitUntilSettled()
2848
Joshua Hesketh25695cb2017-03-06 12:50:04 +11002849 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00002850 def test_timer_sshkey(self):
2851 "Test that a periodic job can setup SSH key authentication"
2852 self.worker.hold_jobs_in_build = True
2853 self.config.set('zuul', 'layout_config',
2854 'tests/fixtures/layout-timer.yaml')
2855 self.sched.reconfigure(self.config)
2856 self.registerJobs()
2857
2858 # The pipeline triggers every second, so we should have seen
2859 # several by now.
2860 time.sleep(5)
2861 self.waitUntilSettled()
2862
2863 self.assertEqual(len(self.builds), 2)
2864
2865 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
2866 self.assertTrue(os.path.isfile(ssh_wrapper))
2867 with open(ssh_wrapper) as f:
2868 ssh_wrapper_content = f.read()
2869 self.assertIn("fake_id_rsa", ssh_wrapper_content)
2870 # In the unit tests Merger runs in the same process,
2871 # so we see its' environment variables
2872 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
2873
2874 self.worker.release('.*')
2875 self.waitUntilSettled()
2876 self.assertEqual(len(self.history), 2)
2877
2878 self.assertEqual(self.getJobFromHistory(
2879 'project-bitrot-stable-old').result, 'SUCCESS')
2880 self.assertEqual(self.getJobFromHistory(
2881 'project-bitrot-stable-older').result, 'SUCCESS')
2882
2883 # Stop queuing timer triggered jobs and let any that may have
2884 # queued through so that end of test assertions pass.
2885 self.config.set('zuul', 'layout_config',
2886 'tests/fixtures/layout-no-timer.yaml')
2887 self.sched.reconfigure(self.config)
2888 self.registerJobs()
2889 self.waitUntilSettled()
2890 self.worker.release('.*')
2891 self.waitUntilSettled()
2892
James E. Blair91e34592015-07-31 16:45:59 -07002893 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08002894 "Test that the RPC client can enqueue a change"
2895 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002896 A.addApproval('code-review', 2)
2897 A.addApproval('approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08002898
2899 client = zuul.rpcclient.RPCClient('127.0.0.1',
2900 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002901 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04002902 r = client.enqueue(tenant='tenant-one',
2903 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002904 project='org/project',
2905 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002906 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002907 self.waitUntilSettled()
2908 self.assertEqual(self.getJobFromHistory('project-merge').result,
2909 'SUCCESS')
2910 self.assertEqual(self.getJobFromHistory('project-test1').result,
2911 'SUCCESS')
2912 self.assertEqual(self.getJobFromHistory('project-test2').result,
2913 'SUCCESS')
2914 self.assertEqual(A.data['status'], 'MERGED')
2915 self.assertEqual(A.reported, 2)
2916 self.assertEqual(r, True)
2917
James E. Blair91e34592015-07-31 16:45:59 -07002918 def test_client_enqueue_ref(self):
2919 "Test that the RPC client can enqueue a ref"
2920
2921 client = zuul.rpcclient.RPCClient('127.0.0.1',
2922 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002923 self.addCleanup(client.shutdown)
James E. Blair91e34592015-07-31 16:45:59 -07002924 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04002925 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07002926 pipeline='post',
2927 project='org/project',
2928 trigger='gerrit',
2929 ref='master',
2930 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
2931 newrev='d479a0bfcb34da57a31adb2a595c0cf687812543')
2932 self.waitUntilSettled()
2933 job_names = [x.name for x in self.history]
2934 self.assertEqual(len(self.history), 1)
2935 self.assertIn('project-post', job_names)
2936 self.assertEqual(r, True)
2937
James E. Blairad28e912013-11-27 10:43:22 -08002938 def test_client_enqueue_negative(self):
2939 "Test that the RPC client returns errors"
2940 client = zuul.rpcclient.RPCClient('127.0.0.1',
2941 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002942 self.addCleanup(client.shutdown)
James E. Blairad28e912013-11-27 10:43:22 -08002943 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04002944 "Invalid tenant"):
2945 r = client.enqueue(tenant='tenant-foo',
2946 pipeline='gate',
2947 project='org/project',
2948 trigger='gerrit',
2949 change='1,1')
Paul Belangerbaca3132016-11-04 12:49:54 -04002950 self.assertEqual(r, False)
2951
2952 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08002953 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002954 r = client.enqueue(tenant='tenant-one',
2955 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002956 project='project-does-not-exist',
2957 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002958 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002959 self.assertEqual(r, False)
2960
2961 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2962 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002963 r = client.enqueue(tenant='tenant-one',
2964 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08002965 project='org/project',
2966 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002967 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002968 self.assertEqual(r, False)
2969
2970 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2971 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002972 r = client.enqueue(tenant='tenant-one',
2973 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002974 project='org/project',
2975 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08002976 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002977 self.assertEqual(r, False)
2978
2979 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2980 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002981 r = client.enqueue(tenant='tenant-one',
2982 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002983 project='org/project',
2984 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002985 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002986 self.assertEqual(r, False)
2987
2988 self.waitUntilSettled()
2989 self.assertEqual(len(self.history), 0)
2990 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08002991
2992 def test_client_promote(self):
2993 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04002994 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08002995 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2996 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2997 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07002998 A.addApproval('code-review', 2)
2999 B.addApproval('code-review', 2)
3000 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003001
James E. Blair8b5408c2016-08-08 15:37:46 -07003002 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3003 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3004 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003005
3006 self.waitUntilSettled()
3007
Paul Belangerbaca3132016-11-04 12:49:54 -04003008 tenant = self.sched.abide.tenants.get('tenant-one')
3009 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003010 enqueue_times = {}
3011 for item in items:
3012 enqueue_times[str(item.change)] = item.enqueue_time
3013
James E. Blair36658cf2013-12-06 17:53:48 -08003014 client = zuul.rpcclient.RPCClient('127.0.0.1',
3015 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003016 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003017 r = client.promote(tenant='tenant-one',
3018 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003019 change_ids=['2,1', '3,1'])
3020
Sean Daguef39b9ca2014-01-10 21:34:35 -05003021 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003022 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003023 for item in items:
3024 self.assertEqual(
3025 enqueue_times[str(item.change)], item.enqueue_time)
3026
James E. Blair78acec92014-02-06 07:11:32 -08003027 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003028 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003029 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003030 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003031 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003032 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003033 self.waitUntilSettled()
3034
3035 self.assertEqual(len(self.builds), 6)
3036 self.assertEqual(self.builds[0].name, 'project-test1')
3037 self.assertEqual(self.builds[1].name, 'project-test2')
3038 self.assertEqual(self.builds[2].name, 'project-test1')
3039 self.assertEqual(self.builds[3].name, 'project-test2')
3040 self.assertEqual(self.builds[4].name, 'project-test1')
3041 self.assertEqual(self.builds[5].name, 'project-test2')
3042
Paul Belangerbaca3132016-11-04 12:49:54 -04003043 self.assertTrue(self.builds[0].hasChanges(B))
3044 self.assertFalse(self.builds[0].hasChanges(A))
3045 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003046
Paul Belangerbaca3132016-11-04 12:49:54 -04003047 self.assertTrue(self.builds[2].hasChanges(B))
3048 self.assertTrue(self.builds[2].hasChanges(C))
3049 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003050
Paul Belangerbaca3132016-11-04 12:49:54 -04003051 self.assertTrue(self.builds[4].hasChanges(B))
3052 self.assertTrue(self.builds[4].hasChanges(C))
3053 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003054
Paul Belanger174a8272017-03-14 13:20:10 -04003055 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003056 self.waitUntilSettled()
3057
3058 self.assertEqual(A.data['status'], 'MERGED')
3059 self.assertEqual(A.reported, 2)
3060 self.assertEqual(B.data['status'], 'MERGED')
3061 self.assertEqual(B.reported, 2)
3062 self.assertEqual(C.data['status'], 'MERGED')
3063 self.assertEqual(C.reported, 2)
3064
James E. Blair36658cf2013-12-06 17:53:48 -08003065 self.assertEqual(r, True)
3066
3067 def test_client_promote_dependent(self):
3068 "Test that the RPC client can promote a dependent change"
3069 # C (depends on B) -> B -> A ; then promote C to get:
3070 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003071 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003072 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3073 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3074 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3075
3076 C.setDependsOn(B, 1)
3077
James E. Blair8b5408c2016-08-08 15:37:46 -07003078 A.addApproval('code-review', 2)
3079 B.addApproval('code-review', 2)
3080 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003081
James E. Blair8b5408c2016-08-08 15:37:46 -07003082 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3083 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3084 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003085
3086 self.waitUntilSettled()
3087
3088 client = zuul.rpcclient.RPCClient('127.0.0.1',
3089 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003090 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003091 r = client.promote(tenant='tenant-one',
3092 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003093 change_ids=['3,1'])
3094
James E. Blair78acec92014-02-06 07:11:32 -08003095 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003096 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003097 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003098 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003099 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003100 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003101 self.waitUntilSettled()
3102
3103 self.assertEqual(len(self.builds), 6)
3104 self.assertEqual(self.builds[0].name, 'project-test1')
3105 self.assertEqual(self.builds[1].name, 'project-test2')
3106 self.assertEqual(self.builds[2].name, 'project-test1')
3107 self.assertEqual(self.builds[3].name, 'project-test2')
3108 self.assertEqual(self.builds[4].name, 'project-test1')
3109 self.assertEqual(self.builds[5].name, 'project-test2')
3110
Paul Belangerbaca3132016-11-04 12:49:54 -04003111 self.assertTrue(self.builds[0].hasChanges(B))
3112 self.assertFalse(self.builds[0].hasChanges(A))
3113 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003114
Paul Belangerbaca3132016-11-04 12:49:54 -04003115 self.assertTrue(self.builds[2].hasChanges(B))
3116 self.assertTrue(self.builds[2].hasChanges(C))
3117 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003118
Paul Belangerbaca3132016-11-04 12:49:54 -04003119 self.assertTrue(self.builds[4].hasChanges(B))
3120 self.assertTrue(self.builds[4].hasChanges(C))
3121 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003122
Paul Belanger174a8272017-03-14 13:20:10 -04003123 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003124 self.waitUntilSettled()
3125
3126 self.assertEqual(A.data['status'], 'MERGED')
3127 self.assertEqual(A.reported, 2)
3128 self.assertEqual(B.data['status'], 'MERGED')
3129 self.assertEqual(B.reported, 2)
3130 self.assertEqual(C.data['status'], 'MERGED')
3131 self.assertEqual(C.reported, 2)
3132
James E. Blair36658cf2013-12-06 17:53:48 -08003133 self.assertEqual(r, True)
3134
3135 def test_client_promote_negative(self):
3136 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003137 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003138 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003139 A.addApproval('code-review', 2)
3140 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003141 self.waitUntilSettled()
3142
3143 client = zuul.rpcclient.RPCClient('127.0.0.1',
3144 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003145 self.addCleanup(client.shutdown)
James E. Blair36658cf2013-12-06 17:53:48 -08003146
3147 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003148 r = client.promote(tenant='tenant-one',
3149 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003150 change_ids=['2,1', '3,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003151 self.assertEqual(r, False)
3152
3153 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003154 r = client.promote(tenant='tenant-one',
3155 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003156 change_ids=['4,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003157 self.assertEqual(r, False)
3158
Paul Belanger174a8272017-03-14 13:20:10 -04003159 self.executor_server.hold_jobs_in_build = False
3160 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003161 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003162
James E. Blaircc324192017-04-19 14:36:08 -07003163 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003164 def test_queue_rate_limiting(self):
3165 "Test that DependentPipelines are rate limited with dep across window"
Paul Belanger174a8272017-03-14 13:20:10 -04003166 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003167 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3168 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3169 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3170
3171 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003172 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003173
James E. Blair8b5408c2016-08-08 15:37:46 -07003174 A.addApproval('code-review', 2)
3175 B.addApproval('code-review', 2)
3176 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003177
James E. Blair8b5408c2016-08-08 15:37:46 -07003178 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3179 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3180 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003181 self.waitUntilSettled()
3182
3183 # Only A and B will have their merge jobs queued because
3184 # window is 2.
3185 self.assertEqual(len(self.builds), 2)
3186 self.assertEqual(self.builds[0].name, 'project-merge')
3187 self.assertEqual(self.builds[1].name, 'project-merge')
3188
James E. Blair732ee862017-04-21 07:49:26 -07003189 # Release the merge jobs one at a time.
3190 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003191 self.waitUntilSettled()
James E. Blair732ee862017-04-21 07:49:26 -07003192 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003193 self.waitUntilSettled()
3194
3195 # Only A and B will have their test jobs queued because
3196 # window is 2.
3197 self.assertEqual(len(self.builds), 4)
3198 self.assertEqual(self.builds[0].name, 'project-test1')
3199 self.assertEqual(self.builds[1].name, 'project-test2')
3200 self.assertEqual(self.builds[2].name, 'project-test1')
3201 self.assertEqual(self.builds[3].name, 'project-test2')
3202
Paul Belanger174a8272017-03-14 13:20:10 -04003203 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003204 self.waitUntilSettled()
3205
James E. Blaircc324192017-04-19 14:36:08 -07003206 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003207 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003208 # A failed so window is reduced by 1 to 1.
3209 self.assertEqual(queue.window, 1)
3210 self.assertEqual(queue.window_floor, 1)
3211 self.assertEqual(A.data['status'], 'NEW')
3212
3213 # Gate is reset and only B's merge job is queued because
3214 # window shrunk to 1.
3215 self.assertEqual(len(self.builds), 1)
3216 self.assertEqual(self.builds[0].name, 'project-merge')
3217
Paul Belanger174a8272017-03-14 13:20:10 -04003218 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003219 self.waitUntilSettled()
3220
3221 # Only B's test jobs are queued because window is still 1.
3222 self.assertEqual(len(self.builds), 2)
3223 self.assertEqual(self.builds[0].name, 'project-test1')
3224 self.assertEqual(self.builds[1].name, 'project-test2')
3225
Paul Belanger174a8272017-03-14 13:20:10 -04003226 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003227 self.waitUntilSettled()
3228
3229 # B was successfully merged so window is increased to 2.
3230 self.assertEqual(queue.window, 2)
3231 self.assertEqual(queue.window_floor, 1)
3232 self.assertEqual(B.data['status'], 'MERGED')
3233
3234 # Only C is left and its merge job is queued.
3235 self.assertEqual(len(self.builds), 1)
3236 self.assertEqual(self.builds[0].name, 'project-merge')
3237
Paul Belanger174a8272017-03-14 13:20:10 -04003238 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003239 self.waitUntilSettled()
3240
3241 # After successful merge job the test jobs for C are queued.
3242 self.assertEqual(len(self.builds), 2)
3243 self.assertEqual(self.builds[0].name, 'project-test1')
3244 self.assertEqual(self.builds[1].name, 'project-test2')
3245
Paul Belanger174a8272017-03-14 13:20:10 -04003246 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003247 self.waitUntilSettled()
3248
3249 # C successfully merged so window is bumped to 3.
3250 self.assertEqual(queue.window, 3)
3251 self.assertEqual(queue.window_floor, 1)
3252 self.assertEqual(C.data['status'], 'MERGED')
3253
James E. Blaircc324192017-04-19 14:36:08 -07003254 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003255 def test_queue_rate_limiting_dependent(self):
3256 "Test that DependentPipelines are rate limited with dep in window"
Paul Belanger174a8272017-03-14 13:20:10 -04003257 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003258 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3259 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3260 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3261
3262 B.setDependsOn(A, 1)
3263
Paul Belanger174a8272017-03-14 13:20:10 -04003264 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003265
James E. Blair8b5408c2016-08-08 15:37:46 -07003266 A.addApproval('code-review', 2)
3267 B.addApproval('code-review', 2)
3268 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003269
James E. Blair8b5408c2016-08-08 15:37:46 -07003270 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3271 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3272 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003273 self.waitUntilSettled()
3274
3275 # Only A and B will have their merge jobs queued because
3276 # window is 2.
3277 self.assertEqual(len(self.builds), 2)
3278 self.assertEqual(self.builds[0].name, 'project-merge')
3279 self.assertEqual(self.builds[1].name, 'project-merge')
3280
James E. Blairf4a5f022017-04-18 14:01:10 -07003281 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003282
3283 # Only A and B will have their test jobs queued because
3284 # window is 2.
3285 self.assertEqual(len(self.builds), 4)
3286 self.assertEqual(self.builds[0].name, 'project-test1')
3287 self.assertEqual(self.builds[1].name, 'project-test2')
3288 self.assertEqual(self.builds[2].name, 'project-test1')
3289 self.assertEqual(self.builds[3].name, 'project-test2')
3290
Paul Belanger174a8272017-03-14 13:20:10 -04003291 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003292 self.waitUntilSettled()
3293
James E. Blaircc324192017-04-19 14:36:08 -07003294 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003295 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003296 # A failed so window is reduced by 1 to 1.
3297 self.assertEqual(queue.window, 1)
3298 self.assertEqual(queue.window_floor, 1)
3299 self.assertEqual(A.data['status'], 'NEW')
3300 self.assertEqual(B.data['status'], 'NEW')
3301
3302 # Gate is reset and only C's merge job is queued because
3303 # window shrunk to 1 and A and B were dequeued.
3304 self.assertEqual(len(self.builds), 1)
3305 self.assertEqual(self.builds[0].name, 'project-merge')
3306
James E. Blairf4a5f022017-04-18 14:01:10 -07003307 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003308
3309 # Only C's test jobs are queued because window is still 1.
3310 self.assertEqual(len(self.builds), 2)
3311 self.assertEqual(self.builds[0].name, 'project-test1')
3312 self.assertEqual(self.builds[1].name, 'project-test2')
3313
Paul Belanger174a8272017-03-14 13:20:10 -04003314 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003315 self.waitUntilSettled()
3316
3317 # C was successfully merged so window is increased to 2.
3318 self.assertEqual(queue.window, 2)
3319 self.assertEqual(queue.window_floor, 1)
3320 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003321
James E. Blairec056492016-07-22 09:45:56 -07003322 @skip("Disabled for early v3 development")
Joshua Heskethba8776a2014-01-12 14:35:40 +08003323 def test_worker_update_metadata(self):
3324 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003325 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003326
3327 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003328 A.addApproval('code-review', 2)
3329 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003330 self.waitUntilSettled()
3331
Paul Belanger174a8272017-03-14 13:20:10 -04003332 self.assertEqual(len(self.executor.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003333
3334 self.log.debug('Current builds:')
Paul Belanger174a8272017-03-14 13:20:10 -04003335 self.log.debug(self.executor.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003336
3337 start = time.time()
3338 while True:
3339 if time.time() - start > 10:
3340 raise Exception("Timeout waiting for gearman server to report "
3341 + "back to the client")
Paul Belanger174a8272017-03-14 13:20:10 -04003342 build = self.executor.builds.values()[0]
Joshua Heskethba8776a2014-01-12 14:35:40 +08003343 if build.worker.name == "My Worker":
3344 break
3345 else:
3346 time.sleep(0)
3347
3348 self.log.debug(build)
3349 self.assertEqual("My Worker", build.worker.name)
3350 self.assertEqual("localhost", build.worker.hostname)
3351 self.assertEqual(['127.0.0.1', '192.168.1.1'], build.worker.ips)
3352 self.assertEqual("zuul.example.org", build.worker.fqdn)
3353 self.assertEqual("FakeBuilder", build.worker.program)
3354 self.assertEqual("v1.1", build.worker.version)
3355 self.assertEqual({'something': 'else'}, build.worker.extra)
3356
Paul Belanger174a8272017-03-14 13:20:10 -04003357 self.executor_server.hold_jobs_in_build = False
3358 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003359 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003360
James E. Blaircc324192017-04-19 14:36:08 -07003361 @simple_layout('layouts/footer-message.yaml')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003362 def test_footer_message(self):
3363 "Test a pipeline's footer message is correctly added to the report."
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003364 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003365 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003366 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003367 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003368 self.waitUntilSettled()
3369
3370 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003371 B.addApproval('code-review', 2)
3372 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003373 self.waitUntilSettled()
3374
3375 self.assertEqual(2, len(self.smtp_messages))
3376
Adam Gandelman82258fd2017-02-07 16:51:58 -08003377 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003378Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003379http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003380
Adam Gandelman82258fd2017-02-07 16:51:58 -08003381 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003382For CI problems and help debugging, contact ci@example.org"""
3383
Adam Gandelman82258fd2017-02-07 16:51:58 -08003384 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3385 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3386 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3387 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003388
James E. Blairec056492016-07-22 09:45:56 -07003389 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003390 def test_merge_failure_reporters(self):
3391 """Check that the config is set up correctly"""
3392
James E. Blairf84026c2015-12-08 16:11:46 -08003393 self.updateConfigLayout(
3394 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003395 self.sched.reconfigure(self.config)
3396 self.registerJobs()
3397
3398 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003399 "Merge Failed.\n\nThis change or one of its cross-repo "
3400 "dependencies was unable to be automatically merged with the "
3401 "current state of its repository. Please rebase the change and "
3402 "upload a new patchset.",
Joshua Heskethb7179772014-01-30 23:30:46 +11003403 self.sched.layout.pipelines['check'].merge_failure_message)
3404 self.assertEqual(
3405 "The merge failed! For more information...",
3406 self.sched.layout.pipelines['gate'].merge_failure_message)
3407
3408 self.assertEqual(
3409 len(self.sched.layout.pipelines['check'].merge_failure_actions), 1)
3410 self.assertEqual(
3411 len(self.sched.layout.pipelines['gate'].merge_failure_actions), 2)
3412
3413 self.assertTrue(isinstance(
Joshua Heskethde958652015-11-10 19:19:50 +11003414 self.sched.layout.pipelines['check'].merge_failure_actions[0],
3415 zuul.reporter.gerrit.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003416
3417 self.assertTrue(
3418 (
3419 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003420 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003421 zuul.reporter.smtp.SMTPReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003422 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003423 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003424 zuul.reporter.gerrit.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003425 ) or (
3426 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003427 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003428 zuul.reporter.gerrit.GerritReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003429 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003430 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003431 zuul.reporter.smtp.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003432 )
3433 )
3434
James E. Blairec056492016-07-22 09:45:56 -07003435 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003436 def test_merge_failure_reports(self):
3437 """Check that when a change fails to merge the correct message is sent
3438 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003439 self.updateConfigLayout(
3440 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003441 self.sched.reconfigure(self.config)
3442 self.registerJobs()
3443
3444 # Check a test failure isn't reported to SMTP
3445 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003446 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003447 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003448 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003449 self.waitUntilSettled()
3450
3451 self.assertEqual(3, len(self.history)) # 3 jobs
3452 self.assertEqual(0, len(self.smtp_messages))
3453
3454 # Check a merge failure is reported to SMTP
3455 # B should be merged, but C will conflict with B
3456 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3457 B.addPatchset(['conflict'])
3458 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3459 C.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003460 B.addApproval('code-review', 2)
3461 C.addApproval('code-review', 2)
3462 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3463 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003464 self.waitUntilSettled()
3465
3466 self.assertEqual(6, len(self.history)) # A and B jobs
3467 self.assertEqual(1, len(self.smtp_messages))
3468 self.assertEqual('The merge failed! For more information...',
3469 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003470
James E. Blairec056492016-07-22 09:45:56 -07003471 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003472 def test_default_merge_failure_reports(self):
3473 """Check that the default merge failure reports are correct."""
3474
3475 # A should report success, B should report merge failure.
3476 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3477 A.addPatchset(['conflict'])
3478 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3479 B.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003480 A.addApproval('code-review', 2)
3481 B.addApproval('code-review', 2)
3482 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3483 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003484 self.waitUntilSettled()
3485
3486 self.assertEqual(3, len(self.history)) # A jobs
3487 self.assertEqual(A.reported, 2)
3488 self.assertEqual(B.reported, 2)
3489 self.assertEqual(A.data['status'], 'MERGED')
3490 self.assertEqual(B.data['status'], 'NEW')
3491 self.assertIn('Build succeeded', A.messages[1])
3492 self.assertIn('Merge Failed', B.messages[1])
3493 self.assertIn('automatically merged', B.messages[1])
3494 self.assertNotIn('logs.example.com', B.messages[1])
3495 self.assertNotIn('SKIPPED', B.messages[1])
3496
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003497 def test_client_get_running_jobs(self):
3498 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003499 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003500 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003501 A.addApproval('code-review', 2)
3502 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003503 self.waitUntilSettled()
3504
3505 client = zuul.rpcclient.RPCClient('127.0.0.1',
3506 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003507 self.addCleanup(client.shutdown)
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003508
3509 # Wait for gearman server to send the initial workData back to zuul
3510 start = time.time()
3511 while True:
3512 if time.time() - start > 10:
3513 raise Exception("Timeout waiting for gearman server to report "
3514 + "back to the client")
Paul Belanger174a8272017-03-14 13:20:10 -04003515 build = self.executor_client.builds.values()[0]
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003516 if build.worker.name == "My Worker":
3517 break
3518 else:
3519 time.sleep(0)
3520
3521 running_items = client.get_running_jobs()
3522
3523 self.assertEqual(1, len(running_items))
3524 running_item = running_items[0]
3525 self.assertEqual([], running_item['failing_reasons'])
3526 self.assertEqual([], running_item['items_behind'])
3527 self.assertEqual('https://hostname/1', running_item['url'])
3528 self.assertEqual(None, running_item['item_ahead'])
3529 self.assertEqual('org/project', running_item['project'])
3530 self.assertEqual(None, running_item['remaining_time'])
3531 self.assertEqual(True, running_item['active'])
3532 self.assertEqual('1,1', running_item['id'])
3533
3534 self.assertEqual(3, len(running_item['jobs']))
3535 for job in running_item['jobs']:
3536 if job['name'] == 'project-merge':
3537 self.assertEqual('project-merge', job['name'])
3538 self.assertEqual('gate', job['pipeline'])
3539 self.assertEqual(False, job['retry'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003540 self.assertEqual('https://server/job/project-merge/0/',
3541 job['url'])
3542 self.assertEqual(7, len(job['worker']))
3543 self.assertEqual(False, job['canceled'])
3544 self.assertEqual(True, job['voting'])
3545 self.assertEqual(None, job['result'])
3546 self.assertEqual('gate', job['pipeline'])
3547 break
3548
Paul Belanger174a8272017-03-14 13:20:10 -04003549 self.executor_server.hold_jobs_in_build = False
3550 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003551 self.waitUntilSettled()
3552
3553 running_items = client.get_running_jobs()
3554 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003555
James E. Blairb70e55a2017-04-19 12:57:02 -07003556 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003557 def test_nonvoting_pipeline(self):
3558 "Test that a nonvoting pipeline (experimental) can still report"
3559
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003560 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3561 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003562 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3563 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003564
3565 self.assertEqual(self.getJobFromHistory('project-merge').result,
3566 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003567 self.assertEqual(
3568 self.getJobFromHistory('experimental-project-test').result,
3569 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003570 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003571
3572 def test_crd_gate(self):
3573 "Test cross-repo dependencies"
3574 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3575 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003576 A.addApproval('code-review', 2)
3577 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003578
3579 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3580 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3581 AM2.setMerged()
3582 AM1.setMerged()
3583
3584 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3585 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3586 BM2.setMerged()
3587 BM1.setMerged()
3588
3589 # A -> AM1 -> AM2
3590 # B -> BM1 -> BM2
3591 # A Depends-On: B
3592 # M2 is here to make sure it is never queried. If it is, it
3593 # means zuul is walking down the entire history of merged
3594 # changes.
3595
3596 B.setDependsOn(BM1, 1)
3597 BM1.setDependsOn(BM2, 1)
3598
3599 A.setDependsOn(AM1, 1)
3600 AM1.setDependsOn(AM2, 1)
3601
3602 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3603 A.subject, B.data['id'])
3604
James E. Blair8b5408c2016-08-08 15:37:46 -07003605 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003606 self.waitUntilSettled()
3607
3608 self.assertEqual(A.data['status'], 'NEW')
3609 self.assertEqual(B.data['status'], 'NEW')
3610
Paul Belanger5dccbe72016-11-14 11:17:37 -05003611 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11003612 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003613
Paul Belanger174a8272017-03-14 13:20:10 -04003614 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003615 B.addApproval('approved', 1)
3616 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003617 self.waitUntilSettled()
3618
Paul Belanger174a8272017-03-14 13:20:10 -04003619 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003620 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003621 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003622 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003623 self.executor_server.hold_jobs_in_build = False
3624 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003625 self.waitUntilSettled()
3626
3627 self.assertEqual(AM2.queried, 0)
3628 self.assertEqual(BM2.queried, 0)
3629 self.assertEqual(A.data['status'], 'MERGED')
3630 self.assertEqual(B.data['status'], 'MERGED')
3631 self.assertEqual(A.reported, 2)
3632 self.assertEqual(B.reported, 2)
3633
Paul Belanger5dccbe72016-11-14 11:17:37 -05003634 changes = self.getJobFromHistory(
3635 'project-merge', 'org/project1').changes
3636 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003637
3638 def test_crd_branch(self):
3639 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003640
3641 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003642 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3643 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3644 C = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C')
3645 C.data['id'] = B.data['id']
James E. Blair8b5408c2016-08-08 15:37:46 -07003646 A.addApproval('code-review', 2)
3647 B.addApproval('code-review', 2)
3648 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003649
3650 # A Depends-On: B+C
3651 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3652 A.subject, B.data['id'])
3653
Paul Belanger174a8272017-03-14 13:20:10 -04003654 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003655 B.addApproval('approved', 1)
3656 C.addApproval('approved', 1)
3657 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003658 self.waitUntilSettled()
3659
Paul Belanger174a8272017-03-14 13:20:10 -04003660 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003661 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003662 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003663 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003664 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003665 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003666 self.executor_server.hold_jobs_in_build = False
3667 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003668 self.waitUntilSettled()
3669
3670 self.assertEqual(A.data['status'], 'MERGED')
3671 self.assertEqual(B.data['status'], 'MERGED')
3672 self.assertEqual(C.data['status'], 'MERGED')
3673 self.assertEqual(A.reported, 2)
3674 self.assertEqual(B.reported, 2)
3675 self.assertEqual(C.reported, 2)
3676
Paul Belanger6379db12016-11-14 13:57:54 -05003677 changes = self.getJobFromHistory(
3678 'project-merge', 'org/project1').changes
3679 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003680
3681 def test_crd_multiline(self):
3682 "Test multiple depends-on lines in commit"
3683 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3684 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3685 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003686 A.addApproval('code-review', 2)
3687 B.addApproval('code-review', 2)
3688 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003689
3690 # A Depends-On: B+C
3691 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
3692 A.subject, B.data['id'], C.data['id'])
3693
Paul Belanger174a8272017-03-14 13:20:10 -04003694 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003695 B.addApproval('approved', 1)
3696 C.addApproval('approved', 1)
3697 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003698 self.waitUntilSettled()
3699
Paul Belanger174a8272017-03-14 13:20:10 -04003700 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003701 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003702 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003703 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003704 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003705 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003706 self.executor_server.hold_jobs_in_build = False
3707 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003708 self.waitUntilSettled()
3709
3710 self.assertEqual(A.data['status'], 'MERGED')
3711 self.assertEqual(B.data['status'], 'MERGED')
3712 self.assertEqual(C.data['status'], 'MERGED')
3713 self.assertEqual(A.reported, 2)
3714 self.assertEqual(B.reported, 2)
3715 self.assertEqual(C.reported, 2)
3716
Paul Belanger5dccbe72016-11-14 11:17:37 -05003717 changes = self.getJobFromHistory(
3718 'project-merge', 'org/project1').changes
3719 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08003720
3721 def test_crd_unshared_gate(self):
3722 "Test cross-repo dependencies in unshared gate queues"
3723 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3724 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003725 A.addApproval('code-review', 2)
3726 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003727
3728 # A Depends-On: B
3729 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3730 A.subject, B.data['id'])
3731
3732 # A and B do not share a queue, make sure that A is unable to
3733 # enqueue B (and therefore, A is unable to be enqueued).
James E. Blair8b5408c2016-08-08 15:37:46 -07003734 B.addApproval('approved', 1)
3735 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003736 self.waitUntilSettled()
3737
3738 self.assertEqual(A.data['status'], 'NEW')
3739 self.assertEqual(B.data['status'], 'NEW')
3740 self.assertEqual(A.reported, 0)
3741 self.assertEqual(B.reported, 0)
3742 self.assertEqual(len(self.history), 0)
3743
3744 # Enqueue and merge B alone.
James E. Blair8b5408c2016-08-08 15:37:46 -07003745 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003746 self.waitUntilSettled()
3747
3748 self.assertEqual(B.data['status'], 'MERGED')
3749 self.assertEqual(B.reported, 2)
3750
3751 # Now that B is merged, A should be able to be enqueued and
3752 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003753 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003754 self.waitUntilSettled()
3755
3756 self.assertEqual(A.data['status'], 'MERGED')
3757 self.assertEqual(A.reported, 2)
3758
James E. Blair96698e22015-04-02 07:48:21 -07003759 def test_crd_gate_reverse(self):
3760 "Test reverse cross-repo dependencies"
3761 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3762 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003763 A.addApproval('code-review', 2)
3764 B.addApproval('code-review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07003765
3766 # A Depends-On: B
3767
3768 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3769 A.subject, B.data['id'])
3770
James E. Blair8b5408c2016-08-08 15:37:46 -07003771 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003772 self.waitUntilSettled()
3773
3774 self.assertEqual(A.data['status'], 'NEW')
3775 self.assertEqual(B.data['status'], 'NEW')
3776
Paul Belanger174a8272017-03-14 13:20:10 -04003777 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003778 A.addApproval('approved', 1)
3779 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003780 self.waitUntilSettled()
3781
Paul Belanger174a8272017-03-14 13:20:10 -04003782 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003783 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003784 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003785 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003786 self.executor_server.hold_jobs_in_build = False
3787 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07003788 self.waitUntilSettled()
3789
3790 self.assertEqual(A.data['status'], 'MERGED')
3791 self.assertEqual(B.data['status'], 'MERGED')
3792 self.assertEqual(A.reported, 2)
3793 self.assertEqual(B.reported, 2)
3794
Paul Belanger5dccbe72016-11-14 11:17:37 -05003795 changes = self.getJobFromHistory(
3796 'project-merge', 'org/project1').changes
3797 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07003798
James E. Blair5ee24252014-12-30 10:12:29 -08003799 def test_crd_cycle(self):
3800 "Test cross-repo dependency cycles"
3801 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3802 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003803 A.addApproval('code-review', 2)
3804 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003805
3806 # A -> B -> A (via commit-depends)
3807
3808 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3809 A.subject, B.data['id'])
3810 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3811 B.subject, A.data['id'])
3812
James E. Blair8b5408c2016-08-08 15:37:46 -07003813 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003814 self.waitUntilSettled()
3815
3816 self.assertEqual(A.reported, 0)
3817 self.assertEqual(B.reported, 0)
3818 self.assertEqual(A.data['status'], 'NEW')
3819 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08003820
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003821 def test_crd_gate_unknown(self):
3822 "Test unknown projects in dependent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07003823 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003824 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3825 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003826 A.addApproval('code-review', 2)
3827 B.addApproval('code-review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003828
3829 # A Depends-On: B
3830 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3831 A.subject, B.data['id'])
3832
James E. Blair8b5408c2016-08-08 15:37:46 -07003833 B.addApproval('approved', 1)
3834 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003835 self.waitUntilSettled()
3836
3837 # Unknown projects cannot share a queue with any other
3838 # since they don't have common jobs with any other (they have no jobs).
3839 # Changes which depend on unknown project changes
3840 # should not be processed in dependent pipeline
3841 self.assertEqual(A.data['status'], 'NEW')
3842 self.assertEqual(B.data['status'], 'NEW')
3843 self.assertEqual(A.reported, 0)
3844 self.assertEqual(B.reported, 0)
3845 self.assertEqual(len(self.history), 0)
3846
3847 # Simulate change B being gated outside this layout
James E. Blair8b5408c2016-08-08 15:37:46 -07003848 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003849 B.setMerged()
3850 self.waitUntilSettled()
3851 self.assertEqual(len(self.history), 0)
3852
3853 # Now that B is merged, A should be able to be enqueued and
3854 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003855 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003856 self.waitUntilSettled()
3857
3858 self.assertEqual(A.data['status'], 'MERGED')
3859 self.assertEqual(A.reported, 2)
3860 self.assertEqual(B.data['status'], 'MERGED')
3861 self.assertEqual(B.reported, 0)
3862
James E. Blairbfb8e042014-12-30 17:01:44 -08003863 def test_crd_check(self):
3864 "Test cross-repo dependencies in independent pipelines"
3865
Paul Belanger174a8272017-03-14 13:20:10 -04003866 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08003867 self.gearman_server.hold_jobs_in_queue = True
3868 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3869 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3870
3871 # A Depends-On: B
3872 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3873 A.subject, B.data['id'])
3874
3875 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3876 self.waitUntilSettled()
3877
James E. Blairbfb8e042014-12-30 17:01:44 -08003878 self.gearman_server.hold_jobs_in_queue = False
3879 self.gearman_server.release()
3880 self.waitUntilSettled()
3881
Paul Belanger174a8272017-03-14 13:20:10 -04003882 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05003883 self.waitUntilSettled()
3884
James E. Blair2a535672017-04-27 12:03:15 -07003885 self.assertTrue(self.builds[0].hasChanges(A, B))
James E. Blairbfb8e042014-12-30 17:01:44 -08003886
Paul Belanger174a8272017-03-14 13:20:10 -04003887 self.executor_server.hold_jobs_in_build = False
3888 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05003889 self.waitUntilSettled()
3890
James E. Blairbfb8e042014-12-30 17:01:44 -08003891 self.assertEqual(A.data['status'], 'NEW')
3892 self.assertEqual(B.data['status'], 'NEW')
3893 self.assertEqual(A.reported, 1)
3894 self.assertEqual(B.reported, 0)
3895
3896 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05003897 tenant = self.sched.abide.tenants.get('tenant-one')
3898 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08003899
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003900 def test_crd_check_git_depends(self):
3901 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07003902 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003903 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3904 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
3905
3906 # Add two git-dependent changes and make sure they both report
3907 # success.
3908 B.setDependsOn(A, 1)
3909 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3910 self.waitUntilSettled()
3911 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3912 self.waitUntilSettled()
3913
James E. Blairb8c16472015-05-05 14:55:26 -07003914 self.orderedRelease()
3915 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003916 self.waitUntilSettled()
3917
3918 self.assertEqual(A.data['status'], 'NEW')
3919 self.assertEqual(B.data['status'], 'NEW')
3920 self.assertEqual(A.reported, 1)
3921 self.assertEqual(B.reported, 1)
3922
3923 self.assertEqual(self.history[0].changes, '1,1')
3924 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04003925 tenant = self.sched.abide.tenants.get('tenant-one')
3926 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003927
3928 self.assertIn('Build succeeded', A.messages[0])
3929 self.assertIn('Build succeeded', B.messages[0])
3930
3931 def test_crd_check_duplicate(self):
3932 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04003933 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003934 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3935 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04003936 tenant = self.sched.abide.tenants.get('tenant-one')
3937 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003938
3939 # Add two git-dependent changes...
3940 B.setDependsOn(A, 1)
3941 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3942 self.waitUntilSettled()
3943 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3944
3945 # ...make sure the live one is not duplicated...
3946 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3947 self.waitUntilSettled()
3948 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3949
3950 # ...but the non-live one is able to be.
3951 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3952 self.waitUntilSettled()
3953 self.assertEqual(len(check_pipeline.getAllItems()), 3)
3954
Clark Boylandd849822015-03-02 12:38:14 -08003955 # Release jobs in order to avoid races with change A jobs
3956 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07003957 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04003958 self.executor_server.hold_jobs_in_build = False
3959 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003960 self.waitUntilSettled()
3961
3962 self.assertEqual(A.data['status'], 'NEW')
3963 self.assertEqual(B.data['status'], 'NEW')
3964 self.assertEqual(A.reported, 1)
3965 self.assertEqual(B.reported, 1)
3966
3967 self.assertEqual(self.history[0].changes, '1,1 2,1')
3968 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04003969 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003970
3971 self.assertIn('Build succeeded', A.messages[0])
3972 self.assertIn('Build succeeded', B.messages[0])
3973
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003974 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08003975 "Test cross-repo dependencies re-enqueued in independent pipelines"
3976
3977 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003978 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
3979 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08003980
3981 # A Depends-On: B
3982 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3983 A.subject, B.data['id'])
3984
3985 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3986 self.waitUntilSettled()
3987
3988 self.sched.reconfigure(self.config)
3989
3990 # Make sure the items still share a change queue, and the
3991 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05003992 tenant = self.sched.abide.tenants.get('tenant-one')
3993 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
3994 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08003995 first_item = queue.queue[0]
3996 for item in queue.queue:
3997 self.assertEqual(item.queue, first_item.queue)
3998 self.assertFalse(first_item.live)
3999 self.assertTrue(queue.queue[1].live)
4000
4001 self.gearman_server.hold_jobs_in_queue = False
4002 self.gearman_server.release()
4003 self.waitUntilSettled()
4004
4005 self.assertEqual(A.data['status'], 'NEW')
4006 self.assertEqual(B.data['status'], 'NEW')
4007 self.assertEqual(A.reported, 1)
4008 self.assertEqual(B.reported, 0)
4009
4010 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004011 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004012
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004013 def test_crd_check_reconfiguration(self):
4014 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4015
4016 def test_crd_undefined_project(self):
4017 """Test that undefined projects in dependencies are handled for
4018 independent pipelines"""
4019 # It's a hack for fake gerrit,
4020 # as it implies repo creation upon the creation of any change
James E. Blairc4ba97a2017-04-19 16:26:24 -07004021 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004022 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4023
Jesse Keatingea68ab42017-04-19 15:03:30 -07004024 @simple_layout('layouts/ignore-dependencies.yaml')
James E. Blair17dd6772015-02-09 14:45:18 -08004025 def test_crd_check_ignore_dependencies(self):
4026 "Test cross-repo dependencies can be ignored"
James E. Blair17dd6772015-02-09 14:45:18 -08004027
4028 self.gearman_server.hold_jobs_in_queue = True
4029 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4030 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4031 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4032
4033 # A Depends-On: B
4034 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4035 A.subject, B.data['id'])
4036 # C git-depends on B
4037 C.setDependsOn(B, 1)
4038 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4039 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4040 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4041 self.waitUntilSettled()
4042
4043 # Make sure none of the items share a change queue, and all
4044 # are live.
Jesse Keatingea68ab42017-04-19 15:03:30 -07004045 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum12282ca2017-04-03 11:04:02 -07004046 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004047 self.assertEqual(len(check_pipeline.queues), 3)
4048 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4049 for item in check_pipeline.getAllItems():
4050 self.assertTrue(item.live)
4051
4052 self.gearman_server.hold_jobs_in_queue = False
4053 self.gearman_server.release()
4054 self.waitUntilSettled()
4055
4056 self.assertEqual(A.data['status'], 'NEW')
4057 self.assertEqual(B.data['status'], 'NEW')
4058 self.assertEqual(C.data['status'], 'NEW')
4059 self.assertEqual(A.reported, 1)
4060 self.assertEqual(B.reported, 1)
4061 self.assertEqual(C.reported, 1)
4062
4063 # Each job should have tested exactly one change
4064 for job in self.history:
4065 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004066
James E. Blair7cb84542017-04-19 13:35:05 -07004067 @simple_layout('layouts/three-projects.yaml')
James E. Blair96698e22015-04-02 07:48:21 -07004068 def test_crd_check_transitive(self):
4069 "Test transitive cross-repo dependencies"
4070 # Specifically, if A -> B -> C, and C gets a new patchset and
4071 # A gets a new patchset, ensure the test of A,2 includes B,1
4072 # and C,2 (not C,1 which would indicate stale data in the
4073 # cache for B).
4074 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4075 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4076 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4077
4078 # A Depends-On: B
4079 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4080 A.subject, B.data['id'])
4081
4082 # B Depends-On: C
4083 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4084 B.subject, C.data['id'])
4085
4086 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4087 self.waitUntilSettled()
4088 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4089
4090 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4091 self.waitUntilSettled()
4092 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4093
4094 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4095 self.waitUntilSettled()
4096 self.assertEqual(self.history[-1].changes, '3,1')
4097
4098 C.addPatchset()
4099 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4100 self.waitUntilSettled()
4101 self.assertEqual(self.history[-1].changes, '3,2')
4102
4103 A.addPatchset()
4104 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4105 self.waitUntilSettled()
4106 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004107
James E. Blaira8b90b32016-08-24 15:18:50 -07004108 def test_crd_check_unknown(self):
4109 "Test unknown projects in independent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004110 self.init_repo("org/unknown", tag='init')
James E. Blaira8b90b32016-08-24 15:18:50 -07004111 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4112 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4113 # A Depends-On: B
4114 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4115 A.subject, B.data['id'])
4116
4117 # Make sure zuul has seen an event on B.
4118 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4119 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4120 self.waitUntilSettled()
4121
4122 self.assertEqual(A.data['status'], 'NEW')
4123 self.assertEqual(A.reported, 1)
4124 self.assertEqual(B.data['status'], 'NEW')
4125 self.assertEqual(B.reported, 0)
4126
James E. Blair92464a22016-04-05 10:21:26 -07004127 def test_crd_cycle_join(self):
4128 "Test an updated change creates a cycle"
4129 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4130
4131 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4132 self.waitUntilSettled()
4133
4134 # Create B->A
4135 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4136 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4137 B.subject, A.data['id'])
4138 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4139 self.waitUntilSettled()
4140
4141 # Update A to add A->B (a cycle).
4142 A.addPatchset()
4143 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4144 A.subject, B.data['id'])
4145 # Normally we would submit the patchset-created event for
4146 # processing here, however, we have no way of noting whether
4147 # the dependency cycle detection correctly raised an
4148 # exception, so instead, we reach into the source driver and
4149 # call the method that would ultimately be called by the event
4150 # processing.
4151
Paul Belanger0e155e22016-11-14 14:12:23 -05004152 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07004153 (trusted, project) = tenant.getProject('org/project')
4154 source = project.source
Paul Belanger0e155e22016-11-14 14:12:23 -05004155
4156 # TODO(pabelanger): As we add more source / trigger APIs we should make
4157 # it easier for users to create events for testing.
4158 event = zuul.model.TriggerEvent()
4159 event.trigger_name = 'gerrit'
4160 event.change_number = '1'
4161 event.patch_number = '2'
James E. Blair92464a22016-04-05 10:21:26 -07004162 with testtools.ExpectedException(
4163 Exception, "Dependency cycle detected"):
Paul Belanger0e155e22016-11-14 14:12:23 -05004164 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004165 self.log.debug("Got expected dependency cycle exception")
4166
4167 # Now if we update B to remove the depends-on, everything
4168 # should be okay. B; A->B
4169
4170 B.addPatchset()
4171 B.data['commitMessage'] = '%s\n' % (B.subject,)
Paul Belanger0e155e22016-11-14 14:12:23 -05004172
4173 source.getChange(event, True)
4174 event.change_number = '2'
4175 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004176
Jesse Keatingcc67b122017-04-19 14:54:57 -07004177 @simple_layout('layouts/disable_at.yaml')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004178 def test_disable_at(self):
4179 "Test a pipeline will only report to the disabled trigger when failing"
4180
Jesse Keatingcc67b122017-04-19 14:54:57 -07004181 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004182 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004183 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004184 0, tenant.layout.pipelines['check']._consecutive_failures)
4185 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004186
4187 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4188 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4189 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4190 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4191 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4192 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4193 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4194 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4195 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4196 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4197 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4198
Paul Belanger174a8272017-03-14 13:20:10 -04004199 self.executor_server.failJob('project-test1', A)
4200 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004201 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004202 self.executor_server.failJob('project-test1', D)
4203 self.executor_server.failJob('project-test1', E)
4204 self.executor_server.failJob('project-test1', F)
4205 self.executor_server.failJob('project-test1', G)
4206 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004207 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004208 self.executor_server.failJob('project-test1', J)
4209 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004210
4211 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4212 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4213 self.waitUntilSettled()
4214
4215 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004216 2, tenant.layout.pipelines['check']._consecutive_failures)
4217 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004218
4219 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4220 self.waitUntilSettled()
4221
4222 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004223 0, tenant.layout.pipelines['check']._consecutive_failures)
4224 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004225
4226 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4227 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4228 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4229 self.waitUntilSettled()
4230
4231 # We should be disabled now
4232 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004233 3, tenant.layout.pipelines['check']._consecutive_failures)
4234 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004235
4236 # We need to wait between each of these patches to make sure the
4237 # smtp messages come back in an expected order
4238 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4239 self.waitUntilSettled()
4240 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4241 self.waitUntilSettled()
4242 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4243 self.waitUntilSettled()
4244
4245 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4246 # leaving a message on each change
4247 self.assertEqual(1, len(A.messages))
4248 self.assertIn('Build failed.', A.messages[0])
4249 self.assertEqual(1, len(B.messages))
4250 self.assertIn('Build failed.', B.messages[0])
4251 self.assertEqual(1, len(C.messages))
4252 self.assertIn('Build succeeded.', C.messages[0])
4253 self.assertEqual(1, len(D.messages))
4254 self.assertIn('Build failed.', D.messages[0])
4255 self.assertEqual(1, len(E.messages))
4256 self.assertIn('Build failed.', E.messages[0])
4257 self.assertEqual(1, len(F.messages))
4258 self.assertIn('Build failed.', F.messages[0])
4259
4260 # The last 3 (GHI) would have only reported via smtp.
4261 self.assertEqual(3, len(self.smtp_messages))
4262 self.assertEqual(0, len(G.messages))
4263 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004264 self.assertIn(
4265 'project-test1 https://server/job', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004266 self.assertEqual(0, len(H.messages))
4267 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004268 self.assertIn(
4269 'project-test1 https://server/job', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004270 self.assertEqual(0, len(I.messages))
4271 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004272 self.assertIn(
4273 'project-test1 https://server/job', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004274
4275 # Now reload the configuration (simulate a HUP) to check the pipeline
4276 # comes out of disabled
4277 self.sched.reconfigure(self.config)
4278
Jesse Keatingcc67b122017-04-19 14:54:57 -07004279 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004280
4281 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004282 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004283 0, tenant.layout.pipelines['check']._consecutive_failures)
4284 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004285
4286 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4287 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4288 self.waitUntilSettled()
4289
4290 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004291 2, tenant.layout.pipelines['check']._consecutive_failures)
4292 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004293
4294 # J and K went back to gerrit
4295 self.assertEqual(1, len(J.messages))
4296 self.assertIn('Build failed.', J.messages[0])
4297 self.assertEqual(1, len(K.messages))
4298 self.assertIn('Build failed.', K.messages[0])
4299 # No more messages reported via smtp
4300 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004301
James E. Blaircc020532017-04-19 13:04:44 -07004302 @simple_layout('layouts/one-job-project.yaml')
4303 def test_one_job_project(self):
4304 "Test that queueing works with one job"
4305 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4306 'master', 'A')
4307 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4308 'master', 'B')
4309 A.addApproval('code-review', 2)
4310 B.addApproval('code-review', 2)
4311 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4312 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4313 self.waitUntilSettled()
4314
4315 self.assertEqual(A.data['status'], 'MERGED')
4316 self.assertEqual(A.reported, 2)
4317 self.assertEqual(B.data['status'], 'MERGED')
4318 self.assertEqual(B.reported, 2)
4319
Paul Belanger71d98172016-11-08 10:56:31 -05004320 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004321 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004322
Paul Belanger174a8272017-03-14 13:20:10 -04004323 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004324 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4325 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4326 self.waitUntilSettled()
4327
Paul Belanger174a8272017-03-14 13:20:10 -04004328 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004329 self.waitUntilSettled()
4330
4331 self.assertEqual(len(self.builds), 2)
4332 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004333 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004334 self.waitUntilSettled()
4335
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004336 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004337 self.assertEqual(len(self.builds), 1,
4338 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004339 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004340 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004341 self.waitUntilSettled()
4342
Paul Belanger174a8272017-03-14 13:20:10 -04004343 self.executor_server.hold_jobs_in_build = False
4344 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004345 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004346 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004347 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4348 self.assertEqual(A.reported, 1)
4349 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004350
James E. Blair15be0e12017-01-03 13:45:20 -08004351 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004352 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004353
4354 self.fake_nodepool.paused = True
4355 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4356 A.addApproval('code-review', 2)
4357 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4358 self.waitUntilSettled()
4359
4360 self.zk.client.stop()
4361 self.zk.client.start()
4362 self.fake_nodepool.paused = False
4363 self.waitUntilSettled()
4364
4365 self.assertEqual(A.data['status'], 'MERGED')
4366 self.assertEqual(A.reported, 2)
4367
James E. Blair6ab79e02017-01-06 10:10:17 -08004368 def test_nodepool_failure(self):
4369 "Test that jobs are reported after a nodepool failure"
4370
4371 self.fake_nodepool.paused = True
4372 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4373 A.addApproval('code-review', 2)
4374 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4375 self.waitUntilSettled()
4376
4377 req = self.fake_nodepool.getNodeRequests()[0]
4378 self.fake_nodepool.addFailRequest(req)
4379
4380 self.fake_nodepool.paused = False
4381 self.waitUntilSettled()
4382
4383 self.assertEqual(A.data['status'], 'NEW')
4384 self.assertEqual(A.reported, 2)
4385 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4386 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4387 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4388
Arieb6f068c2016-10-09 13:11:06 +03004389
James E. Blaira002b032017-04-18 10:35:48 -07004390class TestExecutor(ZuulTestCase):
4391 tenant_config_file = 'config/single-tenant/main.yaml'
4392
4393 def assertFinalState(self):
4394 # In this test, we expect to shut down in a non-final state,
4395 # so skip these checks.
4396 pass
4397
4398 def assertCleanShutdown(self):
4399 self.log.debug("Assert clean shutdown")
4400
4401 # After shutdown, make sure no jobs are running
4402 self.assertEqual({}, self.executor_server.job_workers)
4403
4404 # Make sure that git.Repo objects have been garbage collected.
4405 repos = []
4406 gc.collect()
4407 for obj in gc.get_objects():
4408 if isinstance(obj, git.Repo):
4409 self.log.debug("Leaked git repo object: %s" % repr(obj))
4410 repos.append(obj)
4411 self.assertEqual(len(repos), 0)
4412
4413 def test_executor_shutdown(self):
4414 "Test that the executor can shut down with jobs running"
4415
4416 self.executor_server.hold_jobs_in_build = True
4417 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4418 A.addApproval('code-review', 2)
4419 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4420 self.waitUntilSettled()
4421
4422
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004423class TestDependencyGraph(ZuulTestCase):
4424 tenant_config_file = 'config/dependency-graph/main.yaml'
4425
4426 def test_dependeny_graph_dispatch_jobs_once(self):
4427 "Test a job in a dependency graph is queued only once"
4428 # Job dependencies, starting with A
4429 # A
4430 # / \
4431 # B C
4432 # / \ / \
4433 # D F E
4434 # |
4435 # G
4436
4437 self.executor_server.hold_jobs_in_build = True
4438 change = self.fake_gerrit.addFakeChange(
4439 'org/project', 'master', 'change')
4440 change.addApproval('code-review', 2)
4441 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4442
4443 self.waitUntilSettled()
4444 self.assertEqual([b.name for b in self.builds], ['A'])
4445
4446 self.executor_server.release('A')
4447 self.waitUntilSettled()
4448 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4449
4450 self.executor_server.release('B')
4451 self.waitUntilSettled()
4452 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4453
4454 self.executor_server.release('D')
4455 self.waitUntilSettled()
4456 self.assertEqual([b.name for b in self.builds], ['C'])
4457
4458 self.executor_server.release('C')
4459 self.waitUntilSettled()
4460 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4461
4462 self.executor_server.release('F')
4463 self.waitUntilSettled()
4464 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4465
4466 self.executor_server.release('G')
4467 self.waitUntilSettled()
4468 self.assertEqual([b.name for b in self.builds], ['E'])
4469
4470 self.executor_server.release('E')
4471 self.waitUntilSettled()
4472 self.assertEqual(len(self.builds), 0)
4473
4474 self.executor_server.hold_jobs_in_build = False
4475 self.executor_server.release()
4476 self.waitUntilSettled()
4477
4478 self.assertEqual(len(self.builds), 0)
4479 self.assertEqual(len(self.history), 7)
4480
4481 self.assertEqual(change.data['status'], 'MERGED')
4482 self.assertEqual(change.reported, 2)
4483
4484 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4485 "Test that a job waits till all dependencies are successful"
4486 # Job dependencies, starting with A
4487 # A
4488 # / \
4489 # B C*
4490 # / \ / \
4491 # D F E
4492 # |
4493 # G
4494
4495 self.executor_server.hold_jobs_in_build = True
4496 change = self.fake_gerrit.addFakeChange(
4497 'org/project', 'master', 'change')
4498 change.addApproval('code-review', 2)
4499
4500 self.executor_server.failJob('C', change)
4501
4502 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4503
4504 self.waitUntilSettled()
4505 self.assertEqual([b.name for b in self.builds], ['A'])
4506
4507 self.executor_server.release('A')
4508 self.waitUntilSettled()
4509 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4510
4511 self.executor_server.release('B')
4512 self.waitUntilSettled()
4513 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4514
4515 self.executor_server.release('D')
4516 self.waitUntilSettled()
4517 self.assertEqual([b.name for b in self.builds], ['C'])
4518
4519 self.executor_server.release('C')
4520 self.waitUntilSettled()
4521 self.assertEqual(len(self.builds), 0)
4522
4523 self.executor_server.hold_jobs_in_build = False
4524 self.executor_server.release()
4525 self.waitUntilSettled()
4526
4527 self.assertEqual(len(self.builds), 0)
4528 self.assertEqual(len(self.history), 4)
4529
4530 self.assertEqual(change.data['status'], 'NEW')
4531 self.assertEqual(change.reported, 2)
4532
4533
Arieb6f068c2016-10-09 13:11:06 +03004534class TestDuplicatePipeline(ZuulTestCase):
4535 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
4536
4537 def test_duplicate_pipelines(self):
4538 "Test that a change matching multiple pipelines works"
4539
4540 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4541 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
4542 self.waitUntilSettled()
4543
4544 self.assertHistory([
4545 dict(name='project-test1', result='SUCCESS', changes='1,1',
4546 pipeline='dup1'),
4547 dict(name='project-test1', result='SUCCESS', changes='1,1',
4548 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05004549 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03004550
4551 self.assertEqual(len(A.messages), 2)
4552
Paul Belangera46a3742016-11-09 14:23:03 -05004553 if 'dup1' in A.messages[0]:
4554 self.assertIn('dup1', A.messages[0])
4555 self.assertNotIn('dup2', A.messages[0])
4556 self.assertIn('project-test1', A.messages[0])
4557 self.assertIn('dup2', A.messages[1])
4558 self.assertNotIn('dup1', A.messages[1])
4559 self.assertIn('project-test1', A.messages[1])
4560 else:
4561 self.assertIn('dup1', A.messages[1])
4562 self.assertNotIn('dup2', A.messages[1])
4563 self.assertIn('project-test1', A.messages[1])
4564 self.assertIn('dup2', A.messages[0])
4565 self.assertNotIn('dup1', A.messages[0])
4566 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04004567
4568
Paul Belanger86085b32016-11-03 12:48:57 -04004569class TestSchedulerTemplatedProject(ZuulTestCase):
4570 tenant_config_file = 'config/templated-project/main.yaml'
4571
Paul Belanger174a8272017-03-14 13:20:10 -04004572 def test_job_from_templates_executed(self):
4573 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04004574
4575 A = self.fake_gerrit.addFakeChange(
4576 'org/templated-project', 'master', 'A')
4577 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4578 self.waitUntilSettled()
4579
4580 self.assertEqual(self.getJobFromHistory('project-test1').result,
4581 'SUCCESS')
4582 self.assertEqual(self.getJobFromHistory('project-test2').result,
4583 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04004584
4585 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004586 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04004587
4588 A = self.fake_gerrit.addFakeChange(
4589 'org/layered-project', 'master', 'A')
4590 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4591 self.waitUntilSettled()
4592
4593 self.assertEqual(self.getJobFromHistory('project-test1').result,
4594 'SUCCESS')
4595 self.assertEqual(self.getJobFromHistory('project-test2').result,
4596 'SUCCESS')
4597 self.assertEqual(self.getJobFromHistory('layered-project-test3'
4598 ).result, 'SUCCESS')
4599 self.assertEqual(self.getJobFromHistory('layered-project-test4'
4600 ).result, 'SUCCESS')
4601 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
4602 ).result, 'SUCCESS')
4603 self.assertEqual(self.getJobFromHistory('project-test6').result,
4604 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08004605
4606
4607class TestSchedulerSuccessURL(ZuulTestCase):
4608 tenant_config_file = 'config/success-url/main.yaml'
4609
4610 def test_success_url(self):
4611 "Ensure bad build params are ignored"
4612 self.sched.reconfigure(self.config)
4613 self.init_repo('org/docs')
4614
4615 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
4616 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4617 self.waitUntilSettled()
4618
4619 # Both builds ran: docs-draft-test + docs-draft-test2
4620 self.assertEqual(len(self.history), 2)
4621
4622 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08004623 for build in self.history:
4624 if build.name == 'docs-draft-test':
4625 uuid = build.uuid[:7]
4626 break
Adam Gandelman94a60062016-11-21 16:43:14 -08004627
4628 # Two msgs: 'Starting...' + results
4629 self.assertEqual(len(self.smtp_messages), 2)
4630 body = self.smtp_messages[1]['body'].splitlines()
4631 self.assertEqual('Build succeeded.', body[0])
4632
4633 self.assertIn(
4634 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
4635 'docs-draft-test/%s/publish-docs/' % uuid,
4636 body[2])
4637
Paul Belanger174a8272017-03-14 13:20:10 -04004638 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08004639 self.assertIn(
4640 '- docs-draft-test2 https://server/job',
4641 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08004642
4643
Adam Gandelman4da00f62016-12-09 15:47:33 -08004644class TestSchedulerMerges(ZuulTestCase):
4645 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08004646
4647 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04004648 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08004649 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04004650 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08004651 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
4652 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
4653 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
4654 A.addApproval('code-review', 2)
4655 B.addApproval('code-review', 2)
4656 C.addApproval('code-review', 2)
4657 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4658 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4659 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4660 self.waitUntilSettled()
4661
4662 build = self.builds[-1]
4663 ref = self.getParameter(build, 'ZUUL_REF')
4664
James E. Blair2a535672017-04-27 12:03:15 -07004665 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4666 project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08004667 repo = git.Repo(path)
4668 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4669 repo_messages.reverse()
4670
Paul Belanger174a8272017-03-14 13:20:10 -04004671 self.executor_server.hold_jobs_in_build = False
4672 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08004673 self.waitUntilSettled()
4674
4675 return repo_messages
4676
4677 def _test_merge(self, mode):
4678 us_path = os.path.join(
4679 self.upstream_root, 'org/project-%s' % mode)
4680 expected_messages = [
4681 'initial commit',
4682 'add content from fixture',
4683 # the intermediate commits order is nondeterministic
4684 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
4685 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
4686 ]
4687 result = self._test_project_merge_mode(mode)
4688 self.assertEqual(result[:2], expected_messages[:2])
4689 self.assertEqual(result[-2:], expected_messages[-2:])
4690
4691 def test_project_merge_mode_merge(self):
4692 self._test_merge('merge')
4693
4694 def test_project_merge_mode_merge_resolve(self):
4695 self._test_merge('merge-resolve')
4696
4697 def test_project_merge_mode_cherrypick(self):
4698 expected_messages = [
4699 'initial commit',
4700 'add content from fixture',
4701 'A-1',
4702 'B-1',
4703 'C-1']
4704 result = self._test_project_merge_mode('cherry-pick')
4705 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08004706
4707 def test_merge_branch(self):
4708 "Test that the right commits are on alternate branches"
4709 self.create_branch('org/project-merge-branches', 'mp')
4710
Paul Belanger174a8272017-03-14 13:20:10 -04004711 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004712 A = self.fake_gerrit.addFakeChange(
4713 'org/project-merge-branches', 'mp', 'A')
4714 B = self.fake_gerrit.addFakeChange(
4715 'org/project-merge-branches', 'mp', 'B')
4716 C = self.fake_gerrit.addFakeChange(
4717 'org/project-merge-branches', 'mp', 'C')
4718 A.addApproval('code-review', 2)
4719 B.addApproval('code-review', 2)
4720 C.addApproval('code-review', 2)
4721 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4722 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4723 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4724 self.waitUntilSettled()
4725
Paul Belanger174a8272017-03-14 13:20:10 -04004726 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004727 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004728 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004729 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004730 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004731 self.waitUntilSettled()
4732
4733 build = self.builds[-1]
4734 self.assertEqual(self.getParameter(build, 'ZUUL_BRANCH'), 'mp')
4735 ref = self.getParameter(build, 'ZUUL_REF')
James E. Blair2a535672017-04-27 12:03:15 -07004736 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4737 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004738 repo = git.Repo(path)
4739
4740 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4741 repo_messages.reverse()
4742 correct_messages = [
4743 'initial commit',
4744 'add content from fixture',
4745 'mp commit',
4746 'A-1', 'B-1', 'C-1']
4747 self.assertEqual(repo_messages, correct_messages)
4748
Paul Belanger174a8272017-03-14 13:20:10 -04004749 self.executor_server.hold_jobs_in_build = False
4750 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004751 self.waitUntilSettled()
4752
4753 def test_merge_multi_branch(self):
4754 "Test that dependent changes on multiple branches are merged"
4755 self.create_branch('org/project-merge-branches', 'mp')
4756
Paul Belanger174a8272017-03-14 13:20:10 -04004757 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004758 A = self.fake_gerrit.addFakeChange(
4759 'org/project-merge-branches', 'master', 'A')
4760 B = self.fake_gerrit.addFakeChange(
4761 'org/project-merge-branches', 'mp', 'B')
4762 C = self.fake_gerrit.addFakeChange(
4763 'org/project-merge-branches', 'master', 'C')
4764 A.addApproval('code-review', 2)
4765 B.addApproval('code-review', 2)
4766 C.addApproval('code-review', 2)
4767 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4768 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4769 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4770 self.waitUntilSettled()
4771
4772 job_A = None
4773 for job in self.builds:
4774 if 'project-merge' in job.name:
4775 job_A = job
4776 ref_A = self.getParameter(job_A, 'ZUUL_REF')
4777 commit_A = self.getParameter(job_A, 'ZUUL_COMMIT')
4778 self.log.debug("Got Zuul ref for change A: %s" % ref_A)
4779 self.log.debug("Got Zuul commit for change A: %s" % commit_A)
4780
James E. Blair2a535672017-04-27 12:03:15 -07004781 path = os.path.join(job_A.jobdir.src_root, 'review.example.com',
4782 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004783 repo = git.Repo(path)
4784 repo_messages = [c.message.strip()
4785 for c in repo.iter_commits(ref_A)]
4786 repo_messages.reverse()
4787 correct_messages = [
4788 'initial commit', 'add content from fixture', 'A-1']
4789 self.assertEqual(repo_messages, correct_messages)
4790
Paul Belanger174a8272017-03-14 13:20:10 -04004791 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004792 self.waitUntilSettled()
4793
4794 job_B = None
4795 for job in self.builds:
4796 if 'project-merge' in job.name:
4797 job_B = job
4798 ref_B = self.getParameter(job_B, 'ZUUL_REF')
4799 commit_B = self.getParameter(job_B, 'ZUUL_COMMIT')
4800 self.log.debug("Got Zuul ref for change B: %s" % ref_B)
4801 self.log.debug("Got Zuul commit for change B: %s" % commit_B)
4802
James E. Blair2a535672017-04-27 12:03:15 -07004803 path = os.path.join(job_B.jobdir.src_root, 'review.example.com',
4804 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004805 repo = git.Repo(path)
4806 repo_messages = [c.message.strip()
4807 for c in repo.iter_commits(ref_B)]
4808 repo_messages.reverse()
4809 correct_messages = [
4810 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
4811 self.assertEqual(repo_messages, correct_messages)
4812
Paul Belanger174a8272017-03-14 13:20:10 -04004813 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004814 self.waitUntilSettled()
4815
4816 job_C = None
4817 for job in self.builds:
4818 if 'project-merge' in job.name:
4819 job_C = job
4820 ref_C = self.getParameter(job_C, 'ZUUL_REF')
4821 commit_C = self.getParameter(job_C, 'ZUUL_COMMIT')
4822 self.log.debug("Got Zuul ref for change C: %s" % ref_C)
4823 self.log.debug("Got Zuul commit for change C: %s" % commit_C)
James E. Blair2a535672017-04-27 12:03:15 -07004824 path = os.path.join(job_C.jobdir.src_root, 'review.example.com',
4825 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004826 repo = git.Repo(path)
4827 repo_messages = [c.message.strip()
4828 for c in repo.iter_commits(ref_C)]
4829
4830 repo_messages.reverse()
4831 correct_messages = [
4832 'initial commit', 'add content from fixture',
4833 'A-1', 'C-1']
4834 # Ensure the right commits are in the history for this ref
4835 self.assertEqual(repo_messages, correct_messages)
4836
Paul Belanger174a8272017-03-14 13:20:10 -04004837 self.executor_server.hold_jobs_in_build = False
4838 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004839 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01004840
4841
James E. Blair9ea0d0b2017-04-20 09:27:15 -07004842class TestSemaphore(ZuulTestCase):
4843 tenant_config_file = 'config/semaphore/main.yaml'
4844
4845 def test_semaphore_one(self):
4846 "Test semaphores with max=1 (mutex)"
4847 tenant = self.sched.abide.tenants.get('tenant-one')
4848
4849 self.executor_server.hold_jobs_in_build = True
4850
4851 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4852 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4853 self.assertFalse('test-semaphore' in
4854 tenant.semaphore_handler.semaphores)
4855
4856 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4857 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4858 self.waitUntilSettled()
4859
4860 self.assertEqual(len(self.builds), 3)
4861 self.assertEqual(self.builds[0].name, 'project-test1')
4862 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
4863 self.assertEqual(self.builds[2].name, 'project-test1')
4864
4865 self.executor_server.release('semaphore-one-test1')
4866 self.waitUntilSettled()
4867
4868 self.assertEqual(len(self.builds), 3)
4869 self.assertEqual(self.builds[0].name, 'project-test1')
4870 self.assertEqual(self.builds[1].name, 'project-test1')
4871 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4872 self.assertTrue('test-semaphore' in
4873 tenant.semaphore_handler.semaphores)
4874
4875 self.executor_server.release('semaphore-one-test2')
4876 self.waitUntilSettled()
4877
4878 self.assertEqual(len(self.builds), 3)
4879 self.assertEqual(self.builds[0].name, 'project-test1')
4880 self.assertEqual(self.builds[1].name, 'project-test1')
4881 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
4882 self.assertTrue('test-semaphore' in
4883 tenant.semaphore_handler.semaphores)
4884
4885 self.executor_server.release('semaphore-one-test1')
4886 self.waitUntilSettled()
4887
4888 self.assertEqual(len(self.builds), 3)
4889 self.assertEqual(self.builds[0].name, 'project-test1')
4890 self.assertEqual(self.builds[1].name, 'project-test1')
4891 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4892 self.assertTrue('test-semaphore' in
4893 tenant.semaphore_handler.semaphores)
4894
4895 self.executor_server.release('semaphore-one-test2')
4896 self.waitUntilSettled()
4897
4898 self.assertEqual(len(self.builds), 2)
4899 self.assertEqual(self.builds[0].name, 'project-test1')
4900 self.assertEqual(self.builds[1].name, 'project-test1')
4901 self.assertFalse('test-semaphore' in
4902 tenant.semaphore_handler.semaphores)
4903
4904 self.executor_server.hold_jobs_in_build = False
4905 self.executor_server.release()
4906
4907 self.waitUntilSettled()
4908 self.assertEqual(len(self.builds), 0)
4909
4910 self.assertEqual(A.reported, 1)
4911 self.assertEqual(B.reported, 1)
4912 self.assertFalse('test-semaphore' in
4913 tenant.semaphore_handler.semaphores)
4914
4915 def test_semaphore_two(self):
4916 "Test semaphores with max>1"
4917 tenant = self.sched.abide.tenants.get('tenant-one')
4918
4919 self.executor_server.hold_jobs_in_build = True
4920 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4921 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4922 self.assertFalse('test-semaphore-two' in
4923 tenant.semaphore_handler.semaphores)
4924
4925 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4926 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4927 self.waitUntilSettled()
4928
4929 self.assertEqual(len(self.builds), 4)
4930 self.assertEqual(self.builds[0].name, 'project-test1')
4931 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
4932 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
4933 self.assertEqual(self.builds[3].name, 'project-test1')
4934 self.assertTrue('test-semaphore-two' in
4935 tenant.semaphore_handler.semaphores)
4936 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4937 'test-semaphore-two', [])), 2)
4938
4939 self.executor_server.release('semaphore-two-test1')
4940 self.waitUntilSettled()
4941
4942 self.assertEqual(len(self.builds), 4)
4943 self.assertEqual(self.builds[0].name, 'project-test1')
4944 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
4945 self.assertEqual(self.builds[2].name, 'project-test1')
4946 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
4947 self.assertTrue('test-semaphore-two' in
4948 tenant.semaphore_handler.semaphores)
4949 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4950 'test-semaphore-two', [])), 2)
4951
4952 self.executor_server.release('semaphore-two-test2')
4953 self.waitUntilSettled()
4954
4955 self.assertEqual(len(self.builds), 4)
4956 self.assertEqual(self.builds[0].name, 'project-test1')
4957 self.assertEqual(self.builds[1].name, 'project-test1')
4958 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
4959 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
4960 self.assertTrue('test-semaphore-two' in
4961 tenant.semaphore_handler.semaphores)
4962 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4963 'test-semaphore-two', [])), 2)
4964
4965 self.executor_server.release('semaphore-two-test1')
4966 self.waitUntilSettled()
4967
4968 self.assertEqual(len(self.builds), 3)
4969 self.assertEqual(self.builds[0].name, 'project-test1')
4970 self.assertEqual(self.builds[1].name, 'project-test1')
4971 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
4972 self.assertTrue('test-semaphore-two' in
4973 tenant.semaphore_handler.semaphores)
4974 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4975 'test-semaphore-two', [])), 1)
4976
4977 self.executor_server.release('semaphore-two-test2')
4978 self.waitUntilSettled()
4979
4980 self.assertEqual(len(self.builds), 2)
4981 self.assertEqual(self.builds[0].name, 'project-test1')
4982 self.assertEqual(self.builds[1].name, 'project-test1')
4983 self.assertFalse('test-semaphore-two' in
4984 tenant.semaphore_handler.semaphores)
4985
4986 self.executor_server.hold_jobs_in_build = False
4987 self.executor_server.release()
4988
4989 self.waitUntilSettled()
4990 self.assertEqual(len(self.builds), 0)
4991
4992 self.assertEqual(A.reported, 1)
4993 self.assertEqual(B.reported, 1)
4994
4995 def test_semaphore_abandon(self):
4996 "Test abandon with job semaphores"
4997 self.executor_server.hold_jobs_in_build = True
4998 tenant = self.sched.abide.tenants.get('tenant-one')
4999 check_pipeline = tenant.layout.pipelines['check']
5000
5001 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5002 self.assertFalse('test-semaphore' in
5003 tenant.semaphore_handler.semaphores)
5004
5005 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5006 self.waitUntilSettled()
5007
5008 self.assertTrue('test-semaphore' in
5009 tenant.semaphore_handler.semaphores)
5010
5011 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
5012 self.waitUntilSettled()
5013
5014 # The check pipeline should be empty
5015 items = check_pipeline.getAllItems()
5016 self.assertEqual(len(items), 0)
5017
5018 # The semaphore should be released
5019 self.assertFalse('test-semaphore' in
5020 tenant.semaphore_handler.semaphores)
5021
5022 self.executor_server.hold_jobs_in_build = False
5023 self.executor_server.release()
5024 self.waitUntilSettled()
5025
5026 def test_semaphore_reconfigure(self):
5027 "Test reconfigure with job semaphores"
5028 self.executor_server.hold_jobs_in_build = True
5029 tenant = self.sched.abide.tenants.get('tenant-one')
5030 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5031 self.assertFalse('test-semaphore' in
5032 tenant.semaphore_handler.semaphores)
5033
5034 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5035 self.waitUntilSettled()
5036
5037 self.assertTrue('test-semaphore' in
5038 tenant.semaphore_handler.semaphores)
5039
5040 # reconfigure without layout change
5041 self.sched.reconfigure(self.config)
5042 self.waitUntilSettled()
5043 tenant = self.sched.abide.tenants.get('tenant-one')
5044
5045 # semaphore still must be held
5046 self.assertTrue('test-semaphore' in
5047 tenant.semaphore_handler.semaphores)
5048
5049 self.commitConfigUpdate(
5050 'common-config',
5051 'config/semaphore/zuul-reconfiguration.yaml')
5052 self.sched.reconfigure(self.config)
5053 self.waitUntilSettled()
5054 tenant = self.sched.abide.tenants.get('tenant-one')
5055
5056 self.executor_server.release('project-test1')
5057 self.waitUntilSettled()
5058
5059 # There should be no builds anymore
5060 self.assertEqual(len(self.builds), 0)
5061
5062 # The semaphore should be released
5063 self.assertFalse('test-semaphore' in
5064 tenant.semaphore_handler.semaphores)
5065
5066
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005067class TestSemaphoreMultiTenant(ZuulTestCase):
5068 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5069
5070 def test_semaphore_tenant_isolation(self):
5071 "Test semaphores in multiple tenants"
5072
5073 self.waitUntilSettled()
5074 tenant_one = self.sched.abide.tenants.get('tenant-one')
5075 tenant_two = self.sched.abide.tenants.get('tenant-two')
5076
5077 self.executor_server.hold_jobs_in_build = True
5078 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5079 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5080 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5081 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5082 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5083 self.assertFalse('test-semaphore' in
5084 tenant_one.semaphore_handler.semaphores)
5085 self.assertFalse('test-semaphore' in
5086 tenant_two.semaphore_handler.semaphores)
5087
5088 # add patches to project1 of tenant-one
5089 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5090 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5091 self.waitUntilSettled()
5092
5093 # one build of project1-test1 must run
5094 # semaphore of tenant-one must be acquired once
5095 # semaphore of tenant-two must not be acquired
5096 self.assertEqual(len(self.builds), 1)
5097 self.assertEqual(self.builds[0].name, 'project1-test1')
5098 self.assertTrue('test-semaphore' in
5099 tenant_one.semaphore_handler.semaphores)
5100 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5101 'test-semaphore', [])), 1)
5102 self.assertFalse('test-semaphore' in
5103 tenant_two.semaphore_handler.semaphores)
5104
5105 # add patches to project2 of tenant-two
5106 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5107 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5108 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5109 self.waitUntilSettled()
5110
5111 # one build of project1-test1 must run
5112 # two builds of project2-test1 must run
5113 # semaphore of tenant-one must be acquired once
5114 # semaphore of tenant-two must be acquired twice
5115 self.assertEqual(len(self.builds), 3)
5116 self.assertEqual(self.builds[0].name, 'project1-test1')
5117 self.assertEqual(self.builds[1].name, 'project2-test1')
5118 self.assertEqual(self.builds[2].name, 'project2-test1')
5119 self.assertTrue('test-semaphore' in
5120 tenant_one.semaphore_handler.semaphores)
5121 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5122 'test-semaphore', [])), 1)
5123 self.assertTrue('test-semaphore' in
5124 tenant_two.semaphore_handler.semaphores)
5125 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5126 'test-semaphore', [])), 2)
5127
5128 self.executor_server.release('project1-test1')
5129 self.waitUntilSettled()
5130
5131 # one build of project1-test1 must run
5132 # two builds of project2-test1 must run
5133 # semaphore of tenant-one must be acquired once
5134 # semaphore of tenant-two must be acquired twice
5135 self.assertEqual(len(self.builds), 3)
5136 self.assertEqual(self.builds[0].name, 'project2-test1')
5137 self.assertEqual(self.builds[1].name, 'project2-test1')
5138 self.assertEqual(self.builds[2].name, 'project1-test1')
5139 self.assertTrue('test-semaphore' in
5140 tenant_one.semaphore_handler.semaphores)
5141 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5142 'test-semaphore', [])), 1)
5143 self.assertTrue('test-semaphore' in
5144 tenant_two.semaphore_handler.semaphores)
5145 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5146 'test-semaphore', [])), 2)
5147
5148 self.executor_server.release('project2-test1')
5149 self.waitUntilSettled()
5150
5151 # one build of project1-test1 must run
5152 # one build of project2-test1 must run
5153 # semaphore of tenant-one must be acquired once
5154 # semaphore of tenant-two must be acquired once
5155 self.assertEqual(len(self.builds), 2)
5156 self.assertTrue('test-semaphore' in
5157 tenant_one.semaphore_handler.semaphores)
5158 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5159 'test-semaphore', [])), 1)
5160 self.assertTrue('test-semaphore' in
5161 tenant_two.semaphore_handler.semaphores)
5162 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5163 'test-semaphore', [])), 1)
5164
5165 self.executor_server.hold_jobs_in_build = False
5166 self.executor_server.release()
5167
5168 self.waitUntilSettled()
5169
5170 # no build must run
5171 # semaphore of tenant-one must not be acquired
5172 # semaphore of tenant-two must not be acquired
5173 self.assertEqual(len(self.builds), 0)
5174 self.assertFalse('test-semaphore' in
5175 tenant_one.semaphore_handler.semaphores)
5176 self.assertFalse('test-semaphore' in
5177 tenant_two.semaphore_handler.semaphores)
5178
5179 self.assertEqual(A.reported, 1)
5180 self.assertEqual(B.reported, 1)
5181
5182
5183class TestSemaphoreInRepo(ZuulTestCase):
5184 tenant_config_file = 'config/in-repo/main.yaml'
5185
5186 def test_semaphore_in_repo(self):
5187 "Test semaphores in repo config"
5188
5189 # This tests dynamic semaphore handling in project repos. The semaphore
5190 # max value should not be evaluated dynamically but must be updated
5191 # after the change lands.
5192
5193 self.waitUntilSettled()
5194 tenant = self.sched.abide.tenants.get('tenant-one')
5195
5196 in_repo_conf = textwrap.dedent(
5197 """
5198 - job:
5199 name: project-test2
5200 semaphore: test-semaphore
5201
5202 - project:
5203 name: org/project
5204 tenant-one-gate:
5205 jobs:
5206 - project-test2
5207
5208 # the max value in dynamic layout must be ignored
5209 - semaphore:
5210 name: test-semaphore
5211 max: 2
5212 """)
5213
5214 in_repo_playbook = textwrap.dedent(
5215 """
5216 - hosts: all
5217 tasks: []
5218 """)
5219
5220 file_dict = {'.zuul.yaml': in_repo_conf,
5221 'playbooks/project-test2.yaml': in_repo_playbook}
5222 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5223 files=file_dict)
5224 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5225 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5226 B.setDependsOn(A, 1)
5227 C.setDependsOn(A, 1)
5228
5229 self.executor_server.hold_jobs_in_build = True
5230
5231 A.addApproval('code-review', 2)
5232 B.addApproval('code-review', 2)
5233 C.addApproval('code-review', 2)
5234 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
5235 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
5236 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
5237 self.waitUntilSettled()
5238
5239 # check that the layout in a queue item still has max value of 1
5240 # for test-semaphore
5241 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5242 queue = None
5243 for queue_candidate in pipeline.queues:
5244 if queue_candidate.name == 'org/project':
5245 queue = queue_candidate
5246 break
5247 queue_item = queue.queue[0]
5248 item_dynamic_layout = queue_item.current_build_set.layout
5249 dynamic_test_semaphore = \
5250 item_dynamic_layout.semaphores.get('test-semaphore')
5251 self.assertEqual(dynamic_test_semaphore.max, 1)
5252
5253 # one build must be in queue, one semaphores acquired
5254 self.assertEqual(len(self.builds), 1)
5255 self.assertEqual(self.builds[0].name, 'project-test2')
5256 self.assertTrue('test-semaphore' in
5257 tenant.semaphore_handler.semaphores)
5258 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5259 'test-semaphore', [])), 1)
5260
5261 self.executor_server.release('project-test2')
5262 self.waitUntilSettled()
5263
5264 # change A must be merged
5265 self.assertEqual(A.data['status'], 'MERGED')
5266 self.assertEqual(A.reported, 2)
5267
5268 # send change-merged event as the gerrit mock doesn't send it
5269 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5270 self.waitUntilSettled()
5271
5272 # now that change A was merged, the new semaphore max must be effective
5273 tenant = self.sched.abide.tenants.get('tenant-one')
5274 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5275
5276 # two builds must be in queue, two semaphores acquired
5277 self.assertEqual(len(self.builds), 2)
5278 self.assertEqual(self.builds[0].name, 'project-test2')
5279 self.assertEqual(self.builds[1].name, 'project-test2')
5280 self.assertTrue('test-semaphore' in
5281 tenant.semaphore_handler.semaphores)
5282 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5283 'test-semaphore', [])), 2)
5284
5285 self.executor_server.release('project-test2')
5286 self.waitUntilSettled()
5287
5288 self.assertEqual(len(self.builds), 0)
5289 self.assertFalse('test-semaphore' in
5290 tenant.semaphore_handler.semaphores)
5291
5292 self.executor_server.hold_jobs_in_build = False
5293 self.executor_server.release()
5294
5295 self.waitUntilSettled()
5296 self.assertEqual(len(self.builds), 0)
5297
5298 self.assertEqual(A.reported, 2)
5299 self.assertEqual(B.reported, 2)
5300 self.assertEqual(C.reported, 2)