blob: f67318d7ea09072d7338ef273b9b7a83ec9b6657 [file] [log] [blame]
James E. Blairb0fcae42012-07-17 11:12:10 -07001#!/usr/bin/env python
2
3# Copyright 2012 Hewlett-Packard Development Company, L.P.
4#
5# Licensed under the Apache License, Version 2.0 (the "License"); you may
6# not use this file except in compliance with the License. You may obtain
7# a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14# License for the specific language governing permissions and limitations
15# under the License.
16
James E. Blaira002b032017-04-18 10:35:48 -070017import gc
James E. Blairb0fcae42012-07-17 11:12:10 -070018import json
Tobias Henkel9a0e1942017-03-20 16:16:02 +010019import textwrap
20
Monty Taylorbc758832013-06-17 17:22:42 -040021import os
James E. Blairb0fcae42012-07-17 11:12:10 -070022import re
James E. Blair4886cc12012-07-18 15:39:41 -070023import shutil
Monty Taylorbc758832013-06-17 17:22:42 -040024import time
James E. Blairec056492016-07-22 09:45:56 -070025from unittest import skip
Monty Taylorbc758832013-06-17 17:22:42 -040026
James E. Blair4886cc12012-07-18 15:39:41 -070027import git
Morgan Fainberg293f7f82016-05-30 14:01:22 -070028from six.moves import urllib
Monty Taylorbc758832013-06-17 17:22:42 -040029import testtools
James E. Blairb0fcae42012-07-17 11:12:10 -070030
Maru Newby3fe5f852015-01-13 04:22:14 +000031import zuul.change_matcher
James E. Blairb0fcae42012-07-17 11:12:10 -070032import zuul.scheduler
James E. Blairad28e912013-11-27 10:43:22 -080033import zuul.rpcclient
Paul Belanger9bba4902016-11-02 16:07:33 -040034import zuul.model
James E. Blairb0fcae42012-07-17 11:12:10 -070035
Maru Newby3fe5f852015-01-13 04:22:14 +000036from tests.base import (
Maru Newby3fe5f852015-01-13 04:22:14 +000037 ZuulTestCase,
38 repack_repo,
James E. Blair06cc3922017-04-19 10:08:10 -070039 simple_layout,
Maru Newby3fe5f852015-01-13 04:22:14 +000040)
James E. Blairb0fcae42012-07-17 11:12:10 -070041
James E. Blairb0fcae42012-07-17 11:12:10 -070042
Clark Boylanb640e052014-04-03 16:41:46 -070043class TestScheduler(ZuulTestCase):
James E. Blair552b54f2016-07-22 13:55:32 -070044 tenant_config_file = 'config/single-tenant/main.yaml'
Antoine Mussobd86a312014-01-08 14:51:33 +010045
Paul Belanger174a8272017-03-14 13:20:10 -040046 def test_jobs_executed(self):
47 "Test that jobs are executed and a change is merged"
James E. Blair1f4c2bb2013-04-26 08:40:46 -070048
James E. Blairb0fcae42012-07-17 11:12:10 -070049 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -070050 A.addApproval('code-review', 2)
51 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -070052 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -040053 self.assertEqual(self.getJobFromHistory('project-merge').result,
54 'SUCCESS')
55 self.assertEqual(self.getJobFromHistory('project-test1').result,
56 'SUCCESS')
57 self.assertEqual(self.getJobFromHistory('project-test2').result,
58 'SUCCESS')
59 self.assertEqual(A.data['status'], 'MERGED')
60 self.assertEqual(A.reported, 2)
James E. Blair34776ee2016-08-25 13:53:54 -070061 self.assertEqual(self.getJobFromHistory('project-test1').node,
62 'image1')
Adam Gandelmaneace4692017-02-07 15:18:36 -080063 self.assertIsNone(self.getJobFromHistory('project-test2').node)
James E. Blairb0fcae42012-07-17 11:12:10 -070064
James E. Blair552b54f2016-07-22 13:55:32 -070065 # TODOv3(jeblair): we may want to report stats by tenant (also?).
James E. Blair66eeebf2013-07-27 17:44:32 -070066 self.assertReportedStat('gerrit.event.comment-added', value='1|c')
67 self.assertReportedStat('zuul.pipeline.gate.current_changes',
68 value='1|g')
69 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
70 kind='ms')
71 self.assertReportedStat('zuul.pipeline.gate.job.project-merge.SUCCESS',
72 value='1|c')
73 self.assertReportedStat('zuul.pipeline.gate.resident_time', kind='ms')
74 self.assertReportedStat('zuul.pipeline.gate.total_changes',
75 value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070076 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070077 'zuul.pipeline.gate.org.project.resident_time', kind='ms')
James E. Blair412e5582013-04-22 15:50:12 -070078 self.assertReportedStat(
James E. Blair66eeebf2013-07-27 17:44:32 -070079 'zuul.pipeline.gate.org.project.total_changes', value='1|c')
James E. Blair412e5582013-04-22 15:50:12 -070080
James E. Blair5821bd92015-09-16 08:48:15 -070081 for build in self.builds:
82 self.assertEqual(build.parameters['ZUUL_VOTING'], '1')
83
James E. Blair3cb10702013-08-24 08:56:03 -070084 def test_initial_pipeline_gauges(self):
85 "Test that each pipeline reported its length on start"
James E. Blair7da51b72016-07-25 15:29:43 -070086 self.assertReportedStat('zuul.pipeline.gate.current_changes',
87 value='0|g')
88 self.assertReportedStat('zuul.pipeline.check.current_changes',
89 value='0|g')
James E. Blair3cb10702013-08-24 08:56:03 -070090
James E. Blair34776ee2016-08-25 13:53:54 -070091 def test_job_branch(self):
92 "Test the correct variant of a job runs on a branch"
93 self.create_branch('org/project', 'stable')
94 A = self.fake_gerrit.addFakeChange('org/project', 'stable', 'A')
95 A.addApproval('code-review', 2)
96 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
97 self.waitUntilSettled()
98 self.assertEqual(self.getJobFromHistory('project-test1').result,
99 'SUCCESS')
100 self.assertEqual(self.getJobFromHistory('project-test2').result,
101 'SUCCESS')
102 self.assertEqual(A.data['status'], 'MERGED')
103 self.assertEqual(A.reported, 2,
104 "A should report start and success")
105 self.assertIn('gate', A.messages[1],
106 "A should transit gate")
107 self.assertEqual(self.getJobFromHistory('project-test1').node,
108 'image2')
109
James E. Blairb0fcae42012-07-17 11:12:10 -0700110 def test_parallel_changes(self):
111 "Test that changes are tested in parallel and merged in series"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700112
Paul Belanger174a8272017-03-14 13:20:10 -0400113 self.executor_server.hold_jobs_in_build = True
James E. Blairb0fcae42012-07-17 11:12:10 -0700114 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
115 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
116 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700117 A.addApproval('code-review', 2)
118 B.addApproval('code-review', 2)
119 C.addApproval('code-review', 2)
James E. Blairb0fcae42012-07-17 11:12:10 -0700120
James E. Blair8b5408c2016-08-08 15:37:46 -0700121 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
122 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
123 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb0fcae42012-07-17 11:12:10 -0700124
125 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400126 self.assertEqual(len(self.builds), 1)
127 self.assertEqual(self.builds[0].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700128 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700129
Paul Belanger174a8272017-03-14 13:20:10 -0400130 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700131 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400132 self.assertEqual(len(self.builds), 3)
133 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700134 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400135 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700136 self.assertTrue(self.builds[1].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400137 self.assertEqual(self.builds[2].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700138 self.assertTrue(self.builds[2].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700139
Paul Belanger174a8272017-03-14 13:20:10 -0400140 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700141 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400142 self.assertEqual(len(self.builds), 5)
143 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700144 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400145 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700146 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700147
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400148 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700149 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400150 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700151 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700152
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400153 self.assertEqual(self.builds[4].name, 'project-merge')
James E. Blair791b5392016-08-03 11:25:56 -0700154 self.assertTrue(self.builds[4].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700155
Paul Belanger174a8272017-03-14 13:20:10 -0400156 self.executor_server.release('.*-merge')
James E. Blairb0fcae42012-07-17 11:12:10 -0700157 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400158 self.assertEqual(len(self.builds), 6)
159 self.assertEqual(self.builds[0].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700160 self.assertTrue(self.builds[0].hasChanges(A))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400161 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700162 self.assertTrue(self.builds[1].hasChanges(A))
James E. Blairb0fcae42012-07-17 11:12:10 -0700163
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400164 self.assertEqual(self.builds[2].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700165 self.assertTrue(self.builds[2].hasChanges(A, B))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400166 self.assertEqual(self.builds[3].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700167 self.assertTrue(self.builds[3].hasChanges(A, B))
James E. Blairb0fcae42012-07-17 11:12:10 -0700168
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400169 self.assertEqual(self.builds[4].name, 'project-test1')
James E. Blair791b5392016-08-03 11:25:56 -0700170 self.assertTrue(self.builds[4].hasChanges(A, B, C))
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400171 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blair791b5392016-08-03 11:25:56 -0700172 self.assertTrue(self.builds[5].hasChanges(A, B, C))
James E. Blairb0fcae42012-07-17 11:12:10 -0700173
Paul Belanger174a8272017-03-14 13:20:10 -0400174 self.executor_server.hold_jobs_in_build = False
175 self.executor_server.release()
James E. Blairb0fcae42012-07-17 11:12:10 -0700176 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400177 self.assertEqual(len(self.builds), 0)
James E. Blairb0fcae42012-07-17 11:12:10 -0700178
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400179 self.assertEqual(len(self.history), 9)
180 self.assertEqual(A.data['status'], 'MERGED')
181 self.assertEqual(B.data['status'], 'MERGED')
182 self.assertEqual(C.data['status'], 'MERGED')
183 self.assertEqual(A.reported, 2)
184 self.assertEqual(B.reported, 2)
185 self.assertEqual(C.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700186
187 def test_failed_changes(self):
188 "Test that a change behind a failed change is retested"
Paul Belanger174a8272017-03-14 13:20:10 -0400189 self.executor_server.hold_jobs_in_build = True
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700190
James E. Blairb02a3bb2012-07-30 17:49:55 -0700191 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
192 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -0700193 A.addApproval('code-review', 2)
194 B.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700195
Paul Belanger174a8272017-03-14 13:20:10 -0400196 self.executor_server.failJob('project-test1', A)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700197
James E. Blair8b5408c2016-08-08 15:37:46 -0700198 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
199 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700200 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700201 self.assertBuilds([dict(name='project-merge', changes='1,1')])
James E. Blaire2819012013-06-28 17:17:26 -0400202
Paul Belanger174a8272017-03-14 13:20:10 -0400203 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400204 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700205 # A/project-merge is complete
206 self.assertBuilds([
207 dict(name='project-test1', changes='1,1'),
208 dict(name='project-test2', changes='1,1'),
209 dict(name='project-merge', changes='1,1 2,1'),
210 ])
James E. Blaire2819012013-06-28 17:17:26 -0400211
Paul Belanger174a8272017-03-14 13:20:10 -0400212 self.executor_server.release('.*-merge')
James E. Blaire2819012013-06-28 17:17:26 -0400213 self.waitUntilSettled()
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700214 # A/project-merge is complete
215 # B/project-merge is complete
216 self.assertBuilds([
217 dict(name='project-test1', changes='1,1'),
218 dict(name='project-test2', changes='1,1'),
219 dict(name='project-test1', changes='1,1 2,1'),
220 dict(name='project-test2', changes='1,1 2,1'),
221 ])
222
223 # Release project-test1 for A which will fail. This will
Paul Belanger174a8272017-03-14 13:20:10 -0400224 # abort both running B jobs and reexecute project-merge for B.
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700225 self.builds[0].release()
226 self.waitUntilSettled()
227
228 self.orderedRelease()
229 self.assertHistory([
230 dict(name='project-merge', result='SUCCESS', changes='1,1'),
231 dict(name='project-merge', result='SUCCESS', changes='1,1 2,1'),
232 dict(name='project-test1', result='FAILURE', changes='1,1'),
233 dict(name='project-test1', result='ABORTED', changes='1,1 2,1'),
234 dict(name='project-test2', result='ABORTED', changes='1,1 2,1'),
235 dict(name='project-test2', result='SUCCESS', changes='1,1'),
236 dict(name='project-merge', result='SUCCESS', changes='2,1'),
237 dict(name='project-test1', result='SUCCESS', changes='2,1'),
238 dict(name='project-test2', result='SUCCESS', changes='2,1'),
James E. Blairb536ecc2016-08-31 10:11:42 -0700239 ], ordered=False)
James E. Blair2b2a8ab2016-08-11 14:39:11 -0700240
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400241 self.assertEqual(A.data['status'], 'NEW')
242 self.assertEqual(B.data['status'], 'MERGED')
243 self.assertEqual(A.reported, 2)
244 self.assertEqual(B.reported, 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700245
246 def test_independent_queues(self):
247 "Test that changes end up in the right queues"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700248
Paul Belanger174a8272017-03-14 13:20:10 -0400249 self.executor_server.hold_jobs_in_build = True
Zhongyue Luo5d556072012-09-21 02:00:47 +0900250 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700251 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
252 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700253 A.addApproval('code-review', 2)
254 B.addApproval('code-review', 2)
255 C.addApproval('code-review', 2)
James E. Blairb02a3bb2012-07-30 17:49:55 -0700256
James E. Blair8b5408c2016-08-08 15:37:46 -0700257 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairf59f3cf2017-02-19 14:50:26 -0800258 self.waitUntilSettled()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700259
James E. Blairf59f3cf2017-02-19 14:50:26 -0800260 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
261 self.waitUntilSettled()
262
263 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairb02a3bb2012-07-30 17:49:55 -0700264 self.waitUntilSettled()
265
266 # There should be one merge job at the head of each queue running
James E. Blair5f0d49e2016-08-19 09:36:50 -0700267 self.assertBuilds([
268 dict(name='project-merge', changes='1,1'),
269 dict(name='project-merge', changes='2,1'),
270 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700271
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700272 # Release the current merge builds
James E. Blair5f0d49e2016-08-19 09:36:50 -0700273 self.builds[0].release()
274 self.waitUntilSettled()
275 self.builds[0].release()
James E. Blairb02a3bb2012-07-30 17:49:55 -0700276 self.waitUntilSettled()
277 # Release the merge job for project2 which is behind project1
Paul Belanger174a8272017-03-14 13:20:10 -0400278 self.executor_server.release('.*-merge')
James E. Blairb02a3bb2012-07-30 17:49:55 -0700279 self.waitUntilSettled()
280
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700281 # All the test builds should be running:
James E. Blair5f0d49e2016-08-19 09:36:50 -0700282 self.assertBuilds([
283 dict(name='project-test1', changes='1,1'),
284 dict(name='project-test2', changes='1,1'),
285 dict(name='project-test1', changes='2,1'),
286 dict(name='project-test2', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500287 dict(name='project1-project2-integration', changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700288 dict(name='project-test1', changes='2,1 3,1'),
289 dict(name='project-test2', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800290 dict(name='project1-project2-integration', changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700291 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700292
James E. Blair5f0d49e2016-08-19 09:36:50 -0700293 self.orderedRelease()
294 self.assertHistory([
295 dict(name='project-merge', result='SUCCESS', changes='1,1'),
296 dict(name='project-merge', result='SUCCESS', changes='2,1'),
297 dict(name='project-merge', result='SUCCESS', changes='2,1 3,1'),
298 dict(name='project-test1', result='SUCCESS', changes='1,1'),
299 dict(name='project-test2', result='SUCCESS', changes='1,1'),
300 dict(name='project-test1', result='SUCCESS', changes='2,1'),
301 dict(name='project-test2', result='SUCCESS', changes='2,1'),
Paul Belanger58bf6912016-11-11 19:36:01 -0500302 dict(
303 name='project1-project2-integration',
304 result='SUCCESS',
305 changes='2,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700306 dict(name='project-test1', result='SUCCESS', changes='2,1 3,1'),
307 dict(name='project-test2', result='SUCCESS', changes='2,1 3,1'),
Clint Byrumcd9393f2016-12-21 12:21:07 -0800308 dict(name='project1-project2-integration',
309 result='SUCCESS',
310 changes='2,1 3,1'),
James E. Blair5f0d49e2016-08-19 09:36:50 -0700311 ])
James E. Blairb02a3bb2012-07-30 17:49:55 -0700312
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400313 self.assertEqual(A.data['status'], 'MERGED')
314 self.assertEqual(B.data['status'], 'MERGED')
315 self.assertEqual(C.data['status'], 'MERGED')
316 self.assertEqual(A.reported, 2)
317 self.assertEqual(B.reported, 2)
318 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700319
320 def test_failed_change_at_head(self):
321 "Test that if a change at the head fails, jobs behind it are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700322
Paul Belanger174a8272017-03-14 13:20:10 -0400323 self.executor_server.hold_jobs_in_build = True
James E. Blaird466dc42012-07-31 10:42:56 -0700324 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
325 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
326 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700327 A.addApproval('code-review', 2)
328 B.addApproval('code-review', 2)
329 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700330
Paul Belanger174a8272017-03-14 13:20:10 -0400331 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700332
James E. Blair8b5408c2016-08-08 15:37:46 -0700333 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
334 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
335 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700336
337 self.waitUntilSettled()
James E. Blaird466dc42012-07-31 10:42:56 -0700338
James E. Blairb536ecc2016-08-31 10:11:42 -0700339 self.assertBuilds([
340 dict(name='project-merge', changes='1,1'),
341 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700342
Paul Belanger174a8272017-03-14 13:20:10 -0400343 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700344 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400345 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700346 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400347 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700348 self.waitUntilSettled()
349
James E. Blairb536ecc2016-08-31 10:11:42 -0700350 self.assertBuilds([
351 dict(name='project-test1', changes='1,1'),
352 dict(name='project-test2', changes='1,1'),
353 dict(name='project-test1', changes='1,1 2,1'),
354 dict(name='project-test2', changes='1,1 2,1'),
355 dict(name='project-test1', changes='1,1 2,1 3,1'),
356 dict(name='project-test2', changes='1,1 2,1 3,1'),
357 ])
James E. Blaird466dc42012-07-31 10:42:56 -0700358
Monty Taylor6bef8ef2013-06-02 08:17:12 -0400359 self.release(self.builds[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700360 self.waitUntilSettled()
361
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400362 # project-test2, project-merge for B
James E. Blairb536ecc2016-08-31 10:11:42 -0700363 self.assertBuilds([
364 dict(name='project-test2', changes='1,1'),
365 dict(name='project-merge', changes='2,1'),
366 ])
367 # Unordered history comparison because the aborts can finish
368 # in any order.
369 self.assertHistory([
370 dict(name='project-merge', result='SUCCESS',
371 changes='1,1'),
372 dict(name='project-merge', result='SUCCESS',
373 changes='1,1 2,1'),
374 dict(name='project-merge', result='SUCCESS',
375 changes='1,1 2,1 3,1'),
376 dict(name='project-test1', result='FAILURE',
377 changes='1,1'),
378 dict(name='project-test1', result='ABORTED',
379 changes='1,1 2,1'),
380 dict(name='project-test2', result='ABORTED',
381 changes='1,1 2,1'),
382 dict(name='project-test1', result='ABORTED',
383 changes='1,1 2,1 3,1'),
384 dict(name='project-test2', result='ABORTED',
385 changes='1,1 2,1 3,1'),
386 ], ordered=False)
James E. Blaird466dc42012-07-31 10:42:56 -0700387
Paul Belanger174a8272017-03-14 13:20:10 -0400388 self.executor_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700389 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400390 self.executor_server.release('.*-merge')
James E. Blairb536ecc2016-08-31 10:11:42 -0700391 self.waitUntilSettled()
392 self.orderedRelease()
James E. Blaird466dc42012-07-31 10:42:56 -0700393
James E. Blairb536ecc2016-08-31 10:11:42 -0700394 self.assertBuilds([])
395 self.assertHistory([
396 dict(name='project-merge', result='SUCCESS',
397 changes='1,1'),
398 dict(name='project-merge', result='SUCCESS',
399 changes='1,1 2,1'),
400 dict(name='project-merge', result='SUCCESS',
401 changes='1,1 2,1 3,1'),
402 dict(name='project-test1', result='FAILURE',
403 changes='1,1'),
404 dict(name='project-test1', result='ABORTED',
405 changes='1,1 2,1'),
406 dict(name='project-test2', result='ABORTED',
407 changes='1,1 2,1'),
408 dict(name='project-test1', result='ABORTED',
409 changes='1,1 2,1 3,1'),
410 dict(name='project-test2', result='ABORTED',
411 changes='1,1 2,1 3,1'),
412 dict(name='project-merge', result='SUCCESS',
413 changes='2,1'),
414 dict(name='project-merge', result='SUCCESS',
415 changes='2,1 3,1'),
416 dict(name='project-test2', result='SUCCESS',
417 changes='1,1'),
418 dict(name='project-test1', result='SUCCESS',
419 changes='2,1'),
420 dict(name='project-test2', result='SUCCESS',
421 changes='2,1'),
422 dict(name='project-test1', result='SUCCESS',
423 changes='2,1 3,1'),
424 dict(name='project-test2', result='SUCCESS',
425 changes='2,1 3,1'),
426 ], ordered=False)
427
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400428 self.assertEqual(A.data['status'], 'NEW')
429 self.assertEqual(B.data['status'], 'MERGED')
430 self.assertEqual(C.data['status'], 'MERGED')
431 self.assertEqual(A.reported, 2)
432 self.assertEqual(B.reported, 2)
433 self.assertEqual(C.reported, 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700434
James E. Blair0aac4872013-08-23 14:02:38 -0700435 def test_failed_change_in_middle(self):
436 "Test a failed change in the middle of the queue"
437
Paul Belanger174a8272017-03-14 13:20:10 -0400438 self.executor_server.hold_jobs_in_build = True
James E. Blair0aac4872013-08-23 14:02:38 -0700439 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
440 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
441 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700442 A.addApproval('code-review', 2)
443 B.addApproval('code-review', 2)
444 C.addApproval('code-review', 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700445
Paul Belanger174a8272017-03-14 13:20:10 -0400446 self.executor_server.failJob('project-test1', B)
James E. Blair0aac4872013-08-23 14:02:38 -0700447
James E. Blair8b5408c2016-08-08 15:37:46 -0700448 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
449 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
450 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair0aac4872013-08-23 14:02:38 -0700451
452 self.waitUntilSettled()
453
Paul Belanger174a8272017-03-14 13:20:10 -0400454 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700455 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400456 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700457 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400458 self.executor_server.release('.*-merge')
James E. Blair0aac4872013-08-23 14:02:38 -0700459 self.waitUntilSettled()
460
461 self.assertEqual(len(self.builds), 6)
462 self.assertEqual(self.builds[0].name, 'project-test1')
463 self.assertEqual(self.builds[1].name, 'project-test2')
464 self.assertEqual(self.builds[2].name, 'project-test1')
465 self.assertEqual(self.builds[3].name, 'project-test2')
466 self.assertEqual(self.builds[4].name, 'project-test1')
467 self.assertEqual(self.builds[5].name, 'project-test2')
468
469 self.release(self.builds[2])
470 self.waitUntilSettled()
471
James E. Blair972e3c72013-08-29 12:04:55 -0700472 # project-test1 and project-test2 for A
473 # project-test2 for B
474 # project-merge for C (without B)
475 self.assertEqual(len(self.builds), 4)
James E. Blair0aac4872013-08-23 14:02:38 -0700476 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 2)
477
Paul Belanger174a8272017-03-14 13:20:10 -0400478 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -0700479 self.waitUntilSettled()
480
481 # project-test1 and project-test2 for A
482 # project-test2 for B
483 # project-test1 and project-test2 for C
484 self.assertEqual(len(self.builds), 5)
485
Paul Belanger2e2a0492016-10-30 18:33:37 -0400486 tenant = self.sched.abide.tenants.get('tenant-one')
487 items = tenant.layout.pipelines['gate'].getAllItems()
James E. Blair0aac4872013-08-23 14:02:38 -0700488 builds = items[0].current_build_set.getBuilds()
489 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
490 self.assertEqual(self.countJobResults(builds, None), 2)
491 builds = items[1].current_build_set.getBuilds()
492 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
493 self.assertEqual(self.countJobResults(builds, 'FAILURE'), 1)
494 self.assertEqual(self.countJobResults(builds, None), 1)
495 builds = items[2].current_build_set.getBuilds()
496 self.assertEqual(self.countJobResults(builds, 'SUCCESS'), 1)
James E. Blair972e3c72013-08-29 12:04:55 -0700497 self.assertEqual(self.countJobResults(builds, None), 2)
James E. Blair0aac4872013-08-23 14:02:38 -0700498
Paul Belanger174a8272017-03-14 13:20:10 -0400499 self.executor_server.hold_jobs_in_build = False
500 self.executor_server.release()
James E. Blair0aac4872013-08-23 14:02:38 -0700501 self.waitUntilSettled()
502
503 self.assertEqual(len(self.builds), 0)
504 self.assertEqual(len(self.history), 12)
505 self.assertEqual(A.data['status'], 'MERGED')
506 self.assertEqual(B.data['status'], 'NEW')
507 self.assertEqual(C.data['status'], 'MERGED')
508 self.assertEqual(A.reported, 2)
509 self.assertEqual(B.reported, 2)
510 self.assertEqual(C.reported, 2)
511
James E. Blaird466dc42012-07-31 10:42:56 -0700512 def test_failed_change_at_head_with_queue(self):
513 "Test that if a change at the head fails, queued jobs are canceled"
James E. Blaird466dc42012-07-31 10:42:56 -0700514
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700515 self.gearman_server.hold_jobs_in_queue = True
James E. Blaird466dc42012-07-31 10:42:56 -0700516 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
517 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
518 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700519 A.addApproval('code-review', 2)
520 B.addApproval('code-review', 2)
521 C.addApproval('code-review', 2)
James E. Blaird466dc42012-07-31 10:42:56 -0700522
Paul Belanger174a8272017-03-14 13:20:10 -0400523 self.executor_server.failJob('project-test1', A)
James E. Blaird466dc42012-07-31 10:42:56 -0700524
James E. Blair8b5408c2016-08-08 15:37:46 -0700525 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
526 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
527 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blaird466dc42012-07-31 10:42:56 -0700528
529 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700530 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400531 self.assertEqual(len(self.builds), 0)
532 self.assertEqual(len(queue), 1)
Paul Belanger174a8272017-03-14 13:20:10 -0400533 self.assertEqual(queue[0].name, 'executor:execute')
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800534 job_args = json.loads(queue[0].arguments)
535 self.assertEqual(job_args['job'], 'project-merge')
536 self.assertEqual(job_args['items'][0]['number'], '%d' % A.number)
James E. Blaird466dc42012-07-31 10:42:56 -0700537
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700538 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700539 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700540 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700541 self.waitUntilSettled()
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700542 self.gearman_server.release('.*-merge')
James E. Blaird466dc42012-07-31 10:42:56 -0700543 self.waitUntilSettled()
James E. Blair701c5b42013-06-06 09:34:59 -0700544 queue = self.gearman_server.getQueue()
James E. Blaird466dc42012-07-31 10:42:56 -0700545
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400546 self.assertEqual(len(self.builds), 0)
547 self.assertEqual(len(queue), 6)
Clint Byrum8b2bc0c2016-11-16 16:28:50 -0800548
549 self.assertEqual(
550 json.loads(queue[0].arguments)['job'], 'project-test1')
551 self.assertEqual(
552 json.loads(queue[1].arguments)['job'], 'project-test2')
553 self.assertEqual(
554 json.loads(queue[2].arguments)['job'], 'project-test1')
555 self.assertEqual(
556 json.loads(queue[3].arguments)['job'], 'project-test2')
557 self.assertEqual(
558 json.loads(queue[4].arguments)['job'], 'project-test1')
559 self.assertEqual(
560 json.loads(queue[5].arguments)['job'], 'project-test2')
James E. Blaird466dc42012-07-31 10:42:56 -0700561
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700562 self.release(queue[0])
James E. Blaird466dc42012-07-31 10:42:56 -0700563 self.waitUntilSettled()
564
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400565 self.assertEqual(len(self.builds), 0)
James E. Blair701c5b42013-06-06 09:34:59 -0700566 queue = self.gearman_server.getQueue()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400567 self.assertEqual(len(queue), 2) # project-test2, project-merge for B
568 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 0)
James E. Blaird466dc42012-07-31 10:42:56 -0700569
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700570 self.gearman_server.hold_jobs_in_queue = False
571 self.gearman_server.release()
James E. Blaird466dc42012-07-31 10:42:56 -0700572 self.waitUntilSettled()
573
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400574 self.assertEqual(len(self.builds), 0)
575 self.assertEqual(len(self.history), 11)
576 self.assertEqual(A.data['status'], 'NEW')
577 self.assertEqual(B.data['status'], 'MERGED')
578 self.assertEqual(C.data['status'], 'MERGED')
579 self.assertEqual(A.reported, 2)
580 self.assertEqual(B.reported, 2)
581 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700582
James E. Blairec056492016-07-22 09:45:56 -0700583 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700584 def _test_time_database(self, iteration):
Paul Belanger174a8272017-03-14 13:20:10 -0400585 self.executor_server.hold_jobs_in_build = True
James E. Blairce8a2132016-05-19 15:21:52 -0700586 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -0700587 A.addApproval('code-review', 2)
588 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairce8a2132016-05-19 15:21:52 -0700589 self.waitUntilSettled()
590 time.sleep(2)
591
592 data = json.loads(self.sched.formatStatusJSON())
593 found_job = None
594 for pipeline in data['pipelines']:
595 if pipeline['name'] != 'gate':
596 continue
597 for queue in pipeline['change_queues']:
598 for head in queue['heads']:
599 for item in head:
600 for job in item['jobs']:
601 if job['name'] == 'project-merge':
602 found_job = job
603 break
604
605 self.assertIsNotNone(found_job)
606 if iteration == 1:
607 self.assertIsNotNone(found_job['estimated_time'])
608 self.assertIsNone(found_job['remaining_time'])
609 else:
610 self.assertIsNotNone(found_job['estimated_time'])
611 self.assertTrue(found_job['estimated_time'] >= 2)
612 self.assertIsNotNone(found_job['remaining_time'])
613
Paul Belanger174a8272017-03-14 13:20:10 -0400614 self.executor_server.hold_jobs_in_build = False
615 self.executor_server.release()
James E. Blairce8a2132016-05-19 15:21:52 -0700616 self.waitUntilSettled()
617
James E. Blairec056492016-07-22 09:45:56 -0700618 @skip("Disabled for early v3 development")
James E. Blairce8a2132016-05-19 15:21:52 -0700619 def test_time_database(self):
620 "Test the time database"
621
622 self._test_time_database(1)
623 self._test_time_database(2)
624
James E. Blairfef71632013-09-23 11:15:47 -0700625 def test_two_failed_changes_at_head(self):
626 "Test that changes are reparented correctly if 2 fail at head"
627
Paul Belanger174a8272017-03-14 13:20:10 -0400628 self.executor_server.hold_jobs_in_build = True
James E. Blairfef71632013-09-23 11:15:47 -0700629 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
630 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
631 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700632 A.addApproval('code-review', 2)
633 B.addApproval('code-review', 2)
634 C.addApproval('code-review', 2)
James E. Blairfef71632013-09-23 11:15:47 -0700635
Paul Belanger174a8272017-03-14 13:20:10 -0400636 self.executor_server.failJob('project-test1', A)
637 self.executor_server.failJob('project-test1', B)
James E. Blairfef71632013-09-23 11:15:47 -0700638
James E. Blair8b5408c2016-08-08 15:37:46 -0700639 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
640 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
641 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairfef71632013-09-23 11:15:47 -0700642 self.waitUntilSettled()
643
Paul Belanger174a8272017-03-14 13:20:10 -0400644 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700645 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400646 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700647 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400648 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700649 self.waitUntilSettled()
650
651 self.assertEqual(len(self.builds), 6)
652 self.assertEqual(self.builds[0].name, 'project-test1')
653 self.assertEqual(self.builds[1].name, 'project-test2')
654 self.assertEqual(self.builds[2].name, 'project-test1')
655 self.assertEqual(self.builds[3].name, 'project-test2')
656 self.assertEqual(self.builds[4].name, 'project-test1')
657 self.assertEqual(self.builds[5].name, 'project-test2')
658
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400659 self.assertTrue(self.builds[0].hasChanges(A))
660 self.assertTrue(self.builds[2].hasChanges(A))
661 self.assertTrue(self.builds[2].hasChanges(B))
662 self.assertTrue(self.builds[4].hasChanges(A))
663 self.assertTrue(self.builds[4].hasChanges(B))
664 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700665
666 # Fail change B first
667 self.release(self.builds[2])
668 self.waitUntilSettled()
669
670 # restart of C after B failure
Paul Belanger174a8272017-03-14 13:20:10 -0400671 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700672 self.waitUntilSettled()
673
674 self.assertEqual(len(self.builds), 5)
675 self.assertEqual(self.builds[0].name, 'project-test1')
676 self.assertEqual(self.builds[1].name, 'project-test2')
677 self.assertEqual(self.builds[2].name, 'project-test2')
678 self.assertEqual(self.builds[3].name, 'project-test1')
679 self.assertEqual(self.builds[4].name, 'project-test2')
680
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400681 self.assertTrue(self.builds[1].hasChanges(A))
682 self.assertTrue(self.builds[2].hasChanges(A))
683 self.assertTrue(self.builds[2].hasChanges(B))
684 self.assertTrue(self.builds[4].hasChanges(A))
685 self.assertFalse(self.builds[4].hasChanges(B))
686 self.assertTrue(self.builds[4].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700687
688 # Finish running all passing jobs for change A
689 self.release(self.builds[1])
690 self.waitUntilSettled()
691 # Fail and report change A
692 self.release(self.builds[0])
693 self.waitUntilSettled()
694
695 # restart of B,C after A failure
Paul Belanger174a8272017-03-14 13:20:10 -0400696 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700697 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400698 self.executor_server.release('.*-merge')
James E. Blairfef71632013-09-23 11:15:47 -0700699 self.waitUntilSettled()
700
701 self.assertEqual(len(self.builds), 4)
702 self.assertEqual(self.builds[0].name, 'project-test1') # B
703 self.assertEqual(self.builds[1].name, 'project-test2') # B
704 self.assertEqual(self.builds[2].name, 'project-test1') # C
705 self.assertEqual(self.builds[3].name, 'project-test2') # C
706
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400707 self.assertFalse(self.builds[1].hasChanges(A))
708 self.assertTrue(self.builds[1].hasChanges(B))
709 self.assertFalse(self.builds[1].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700710
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400711 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blairfef71632013-09-23 11:15:47 -0700712 # After A failed and B and C restarted, B should be back in
713 # C's tests because it has not failed yet.
Paul Belanger71dd2fc2016-11-04 19:05:55 -0400714 self.assertTrue(self.builds[2].hasChanges(B))
715 self.assertTrue(self.builds[2].hasChanges(C))
James E. Blairfef71632013-09-23 11:15:47 -0700716
Paul Belanger174a8272017-03-14 13:20:10 -0400717 self.executor_server.hold_jobs_in_build = False
718 self.executor_server.release()
James E. Blairfef71632013-09-23 11:15:47 -0700719 self.waitUntilSettled()
720
721 self.assertEqual(len(self.builds), 0)
722 self.assertEqual(len(self.history), 21)
723 self.assertEqual(A.data['status'], 'NEW')
724 self.assertEqual(B.data['status'], 'NEW')
725 self.assertEqual(C.data['status'], 'MERGED')
726 self.assertEqual(A.reported, 2)
727 self.assertEqual(B.reported, 2)
728 self.assertEqual(C.reported, 2)
729
James E. Blair8c803f82012-07-31 16:25:42 -0700730 def test_patch_order(self):
731 "Test that dependent patches are tested in the right order"
732 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
733 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
734 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700735 A.addApproval('code-review', 2)
736 B.addApproval('code-review', 2)
737 C.addApproval('code-review', 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700738
739 M2 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M2')
740 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
741 M2.setMerged()
742 M1.setMerged()
743
744 # C -> B -> A -> M1 -> M2
745 # M2 is here to make sure it is never queried. If it is, it
746 # means zuul is walking down the entire history of merged
747 # changes.
748
749 C.setDependsOn(B, 1)
750 B.setDependsOn(A, 1)
751 A.setDependsOn(M1, 1)
752 M1.setDependsOn(M2, 1)
753
James E. Blair8b5408c2016-08-08 15:37:46 -0700754 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700755
756 self.waitUntilSettled()
757
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400758 self.assertEqual(A.data['status'], 'NEW')
759 self.assertEqual(B.data['status'], 'NEW')
760 self.assertEqual(C.data['status'], 'NEW')
James E. Blair8c803f82012-07-31 16:25:42 -0700761
James E. Blair8b5408c2016-08-08 15:37:46 -0700762 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
763 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8c803f82012-07-31 16:25:42 -0700764
765 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400766 self.assertEqual(M2.queried, 0)
767 self.assertEqual(A.data['status'], 'MERGED')
768 self.assertEqual(B.data['status'], 'MERGED')
769 self.assertEqual(C.data['status'], 'MERGED')
770 self.assertEqual(A.reported, 2)
771 self.assertEqual(B.reported, 2)
772 self.assertEqual(C.reported, 2)
James E. Blair8c803f82012-07-31 16:25:42 -0700773
James E. Blair063672f2015-01-29 13:09:12 -0800774 def test_needed_changes_enqueue(self):
775 "Test that a needed change is enqueued ahead"
776 # A Given a git tree like this, if we enqueue
777 # / \ change C, we should walk up and down the tree
778 # B G and enqueue changes in the order ABCDEFG.
779 # /|\ This is also the order that you would get if
780 # *C E F you enqueued changes in the order ABCDEFG, so
781 # / the ordering is stable across re-enqueue events.
782 # D
783
784 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
785 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
786 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
787 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
788 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
789 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
790 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
791 B.setDependsOn(A, 1)
792 C.setDependsOn(B, 1)
793 D.setDependsOn(C, 1)
794 E.setDependsOn(B, 1)
795 F.setDependsOn(B, 1)
796 G.setDependsOn(A, 1)
797
James E. Blair8b5408c2016-08-08 15:37:46 -0700798 A.addApproval('code-review', 2)
799 B.addApproval('code-review', 2)
800 C.addApproval('code-review', 2)
801 D.addApproval('code-review', 2)
802 E.addApproval('code-review', 2)
803 F.addApproval('code-review', 2)
804 G.addApproval('code-review', 2)
805 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800806
807 self.waitUntilSettled()
808
809 self.assertEqual(A.data['status'], 'NEW')
810 self.assertEqual(B.data['status'], 'NEW')
811 self.assertEqual(C.data['status'], 'NEW')
812 self.assertEqual(D.data['status'], 'NEW')
813 self.assertEqual(E.data['status'], 'NEW')
814 self.assertEqual(F.data['status'], 'NEW')
815 self.assertEqual(G.data['status'], 'NEW')
816
817 # We're about to add approvals to changes without adding the
818 # triggering events to Zuul, so that we can be sure that it is
819 # enqueing the changes based on dependencies, not because of
820 # triggering events. Since it will have the changes cached
821 # already (without approvals), we need to clear the cache
822 # first.
Paul Belanger593480a2016-11-02 19:06:28 -0400823 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +1100824 connection.maintainCache([])
James E. Blair063672f2015-01-29 13:09:12 -0800825
Paul Belanger174a8272017-03-14 13:20:10 -0400826 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -0700827 A.addApproval('approved', 1)
828 B.addApproval('approved', 1)
829 D.addApproval('approved', 1)
830 E.addApproval('approved', 1)
831 F.addApproval('approved', 1)
832 G.addApproval('approved', 1)
833 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair063672f2015-01-29 13:09:12 -0800834
835 for x in range(8):
Paul Belanger174a8272017-03-14 13:20:10 -0400836 self.executor_server.release('.*-merge')
James E. Blair063672f2015-01-29 13:09:12 -0800837 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -0400838 self.executor_server.hold_jobs_in_build = False
839 self.executor_server.release()
James E. Blair063672f2015-01-29 13:09:12 -0800840 self.waitUntilSettled()
841
842 self.assertEqual(A.data['status'], 'MERGED')
843 self.assertEqual(B.data['status'], 'MERGED')
844 self.assertEqual(C.data['status'], 'MERGED')
845 self.assertEqual(D.data['status'], 'MERGED')
846 self.assertEqual(E.data['status'], 'MERGED')
847 self.assertEqual(F.data['status'], 'MERGED')
848 self.assertEqual(G.data['status'], 'MERGED')
849 self.assertEqual(A.reported, 2)
850 self.assertEqual(B.reported, 2)
851 self.assertEqual(C.reported, 2)
852 self.assertEqual(D.reported, 2)
853 self.assertEqual(E.reported, 2)
854 self.assertEqual(F.reported, 2)
855 self.assertEqual(G.reported, 2)
856 self.assertEqual(self.history[6].changes,
857 '1,1 2,1 3,1 4,1 5,1 6,1 7,1')
858
Joshua Hesketh850ccb62014-11-27 11:31:02 +1100859 def test_source_cache(self):
860 "Test that the source cache operates correctly"
Paul Belanger174a8272017-03-14 13:20:10 -0400861 self.executor_server.hold_jobs_in_build = True
James E. Blair0e933c52013-07-11 10:18:52 -0700862
863 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
864 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
865 X = self.fake_gerrit.addFakeChange('org/project', 'master', 'X')
James E. Blair8b5408c2016-08-08 15:37:46 -0700866 A.addApproval('code-review', 2)
867 B.addApproval('code-review', 2)
James E. Blair0e933c52013-07-11 10:18:52 -0700868
869 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
870 M1.setMerged()
871
872 B.setDependsOn(A, 1)
873 A.setDependsOn(M1, 1)
874
James E. Blair8b5408c2016-08-08 15:37:46 -0700875 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700876 self.fake_gerrit.addEvent(X.getPatchsetCreatedEvent(1))
877
878 self.waitUntilSettled()
879
880 for build in self.builds:
881 if build.parameters['ZUUL_PIPELINE'] == 'check':
882 build.release()
883 self.waitUntilSettled()
884 for build in self.builds:
885 if build.parameters['ZUUL_PIPELINE'] == 'check':
886 build.release()
887 self.waitUntilSettled()
888
James E. Blair8b5408c2016-08-08 15:37:46 -0700889 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair0e933c52013-07-11 10:18:52 -0700890 self.waitUntilSettled()
891
Joshua Hesketh352264b2015-08-11 23:42:08 +1000892 self.log.debug("len %s" % self.fake_gerrit._change_cache.keys())
James E. Blair0e933c52013-07-11 10:18:52 -0700893 # there should still be changes in the cache
Joshua Hesketh352264b2015-08-11 23:42:08 +1000894 self.assertNotEqual(len(self.fake_gerrit._change_cache.keys()), 0)
James E. Blair0e933c52013-07-11 10:18:52 -0700895
Paul Belanger174a8272017-03-14 13:20:10 -0400896 self.executor_server.hold_jobs_in_build = False
897 self.executor_server.release()
James E. Blair0e933c52013-07-11 10:18:52 -0700898 self.waitUntilSettled()
899
900 self.assertEqual(A.data['status'], 'MERGED')
901 self.assertEqual(B.data['status'], 'MERGED')
902 self.assertEqual(A.queried, 2) # Initial and isMerged
903 self.assertEqual(B.queried, 3) # Initial A, refresh from B, isMerged
904
James E. Blair8c803f82012-07-31 16:25:42 -0700905 def test_can_merge(self):
James E. Blair4886cc12012-07-18 15:39:41 -0700906 "Test whether a change is ready to merge"
James E. Blair8c803f82012-07-31 16:25:42 -0700907 # TODO: move to test_gerrit (this is a unit test!)
908 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger9bba4902016-11-02 16:07:33 -0400909 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -0700910 (trusted, project) = tenant.getProject('org/project')
911 source = project.source
Paul Belanger9bba4902016-11-02 16:07:33 -0400912
913 # TODO(pabelanger): As we add more source / trigger APIs we should make
914 # it easier for users to create events for testing.
915 event = zuul.model.TriggerEvent()
916 event.trigger_name = 'gerrit'
917 event.change_number = '1'
918 event.patch_number = '2'
919
920 a = source.getChange(event)
921 mgr = tenant.layout.pipelines['gate'].manager
James E. Blairc0dedf82014-08-06 09:37:52 -0700922 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700923
James E. Blair8b5408c2016-08-08 15:37:46 -0700924 A.addApproval('code-review', 2)
Paul Belanger9bba4902016-11-02 16:07:33 -0400925 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700926 self.assertFalse(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair8c803f82012-07-31 16:25:42 -0700927
James E. Blair8b5408c2016-08-08 15:37:46 -0700928 A.addApproval('approved', 1)
Paul Belanger9bba4902016-11-02 16:07:33 -0400929 a = source.getChange(event, refresh=True)
James E. Blairc0dedf82014-08-06 09:37:52 -0700930 self.assertTrue(source.canMerge(a, mgr.getSubmitAllowNeeds()))
James E. Blair4886cc12012-07-18 15:39:41 -0700931
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700932 def test_project_merge_conflict(self):
933 "Test that gate merge conflicts are handled properly"
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700934
935 self.gearman_server.hold_jobs_in_queue = True
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700936 A = self.fake_gerrit.addFakeChange('org/project',
937 'master', 'A',
938 files={'conflict': 'foo'})
939 B = self.fake_gerrit.addFakeChange('org/project',
940 'master', 'B',
941 files={'conflict': 'bar'})
942 C = self.fake_gerrit.addFakeChange('org/project',
James E. Blair6736beb2013-07-11 15:18:15 -0700943 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -0700944 A.addApproval('code-review', 2)
945 B.addApproval('code-review', 2)
946 C.addApproval('code-review', 2)
947 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
948 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
949 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair973721f2012-08-15 10:19:43 -0700950 self.waitUntilSettled()
951
James E. Blair6736beb2013-07-11 15:18:15 -0700952 self.assertEqual(A.reported, 1)
953 self.assertEqual(B.reported, 1)
954 self.assertEqual(C.reported, 1)
955
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700956 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700957 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700958 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700959 self.waitUntilSettled()
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700960 self.gearman_server.release('project-merge')
James E. Blair973721f2012-08-15 10:19:43 -0700961 self.waitUntilSettled()
James E. Blair972e3c72013-08-29 12:04:55 -0700962
James E. Blair1f4c2bb2013-04-26 08:40:46 -0700963 self.gearman_server.hold_jobs_in_queue = False
964 self.gearman_server.release()
James E. Blair973721f2012-08-15 10:19:43 -0700965 self.waitUntilSettled()
966
Monty Taylor98f0f3e2013-07-06 16:02:31 -0400967 self.assertEqual(A.data['status'], 'MERGED')
968 self.assertEqual(B.data['status'], 'NEW')
969 self.assertEqual(C.data['status'], 'MERGED')
970 self.assertEqual(A.reported, 2)
971 self.assertEqual(B.reported, 2)
972 self.assertEqual(C.reported, 2)
K Jonathan Harkerae04e4c2017-03-15 19:07:11 -0700973
974 self.assertHistory([
975 dict(name='project-merge', result='SUCCESS', changes='1,1'),
976 dict(name='project-test1', result='SUCCESS', changes='1,1'),
977 dict(name='project-test2', result='SUCCESS', changes='1,1'),
978 dict(name='project-merge', result='SUCCESS', changes='1,1 3,1'),
979 dict(name='project-test1', result='SUCCESS', changes='1,1 3,1'),
980 dict(name='project-test2', result='SUCCESS', changes='1,1 3,1'),
981 ], ordered=False)
982
983 def test_delayed_merge_conflict(self):
984 "Test that delayed check merge conflicts are handled properly"
985
986 # Hold jobs in the gearman queue so that we can test whether
987 # the executor returns a merge failure after the scheduler has
988 # successfully merged.
989 self.gearman_server.hold_jobs_in_queue = True
990 A = self.fake_gerrit.addFakeChange('org/project',
991 'master', 'A',
992 files={'conflict': 'foo'})
993 B = self.fake_gerrit.addFakeChange('org/project',
994 'master', 'B',
995 files={'conflict': 'bar'})
996 C = self.fake_gerrit.addFakeChange('org/project',
997 'master', 'C')
998 C.setDependsOn(B, 1)
999
1000 # A enters the gate queue; B and C enter the check queue
1001 A.addApproval('code-review', 2)
1002 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1003 self.waitUntilSettled()
1004 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1005 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1006 self.waitUntilSettled()
1007
1008 self.assertEqual(A.reported, 1)
1009 self.assertEqual(B.reported, 0) # Check does not report start
1010 self.assertEqual(C.reported, 0) # Check does not report start
1011
1012 # A merges while B and C are queued in check
1013 # Release A project-merge
1014 queue = self.gearman_server.getQueue()
1015 self.release(queue[0])
1016 self.waitUntilSettled()
1017
1018 # Release A project-test*
1019 # gate has higher precedence, so A's test jobs are added in
1020 # front of the merge jobs for B and C
1021 queue = self.gearman_server.getQueue()
1022 self.release(queue[0])
1023 self.release(queue[1])
1024 self.waitUntilSettled()
1025
1026 self.assertEqual(A.data['status'], 'MERGED')
1027 self.assertEqual(B.data['status'], 'NEW')
1028 self.assertEqual(C.data['status'], 'NEW')
1029 self.assertEqual(A.reported, 2)
1030 self.assertEqual(B.reported, 0)
1031 self.assertEqual(C.reported, 0)
1032 self.assertHistory([
1033 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1034 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1035 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1036 ], ordered=False)
1037
1038 # B and C report merge conflicts
1039 # Release B project-merge
1040 queue = self.gearman_server.getQueue()
1041 self.release(queue[0])
1042 self.waitUntilSettled()
1043
1044 # Release C
1045 self.gearman_server.hold_jobs_in_queue = False
1046 self.gearman_server.release()
1047 self.waitUntilSettled()
1048
1049 self.assertEqual(A.data['status'], 'MERGED')
1050 self.assertEqual(B.data['status'], 'NEW')
1051 self.assertEqual(C.data['status'], 'NEW')
1052 self.assertEqual(A.reported, 2)
1053 self.assertEqual(B.reported, 1)
1054 self.assertEqual(C.reported, 1)
1055
1056 self.assertHistory([
1057 dict(name='project-merge', result='SUCCESS', changes='1,1'),
1058 dict(name='project-test1', result='SUCCESS', changes='1,1'),
1059 dict(name='project-test2', result='SUCCESS', changes='1,1'),
1060 dict(name='project-merge', result='MERGER_FAILURE', changes='2,1'),
1061 dict(name='project-merge', result='MERGER_FAILURE',
1062 changes='2,1 3,1'),
1063 ], ordered=False)
James E. Blair6736beb2013-07-11 15:18:15 -07001064
James E. Blairdaabed22012-08-15 15:38:57 -07001065 def test_post(self):
1066 "Test that post jobs run"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001067
Zhongyue Luo5d556072012-09-21 02:00:47 +09001068 e = {
1069 "type": "ref-updated",
1070 "submitter": {
1071 "name": "User Name",
1072 },
1073 "refUpdate": {
1074 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1075 "newRev": "d479a0bfcb34da57a31adb2a595c0cf687812543",
1076 "refName": "master",
1077 "project": "org/project",
1078 }
1079 }
James E. Blairdaabed22012-08-15 15:38:57 -07001080 self.fake_gerrit.addEvent(e)
1081 self.waitUntilSettled()
1082
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001083 job_names = [x.name for x in self.history]
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001084 self.assertEqual(len(self.history), 1)
1085 self.assertIn('project-post', job_names)
James E. Blairc6294a52012-08-17 10:19:48 -07001086
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001087 def test_post_ignore_deletes(self):
1088 "Test that deleting refs does not trigger post jobs"
1089
1090 e = {
1091 "type": "ref-updated",
1092 "submitter": {
1093 "name": "User Name",
1094 },
1095 "refUpdate": {
1096 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1097 "newRev": "0000000000000000000000000000000000000000",
1098 "refName": "master",
1099 "project": "org/project",
1100 }
1101 }
1102 self.fake_gerrit.addEvent(e)
1103 self.waitUntilSettled()
1104
1105 job_names = [x.name for x in self.history]
1106 self.assertEqual(len(self.history), 0)
1107 self.assertNotIn('project-post', job_names)
1108
James E. Blaircc324192017-04-19 14:36:08 -07001109 @simple_layout('layouts/dont-ignore-ref-deletes.yaml')
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001110 def test_post_ignore_deletes_negative(self):
1111 "Test that deleting refs does trigger post jobs"
K Jonathan Harkerf95e7232015-04-29 13:33:16 -07001112 e = {
1113 "type": "ref-updated",
1114 "submitter": {
1115 "name": "User Name",
1116 },
1117 "refUpdate": {
1118 "oldRev": "90f173846e3af9154517b88543ffbd1691f31366",
1119 "newRev": "0000000000000000000000000000000000000000",
1120 "refName": "master",
1121 "project": "org/project",
1122 }
1123 }
1124 self.fake_gerrit.addEvent(e)
1125 self.waitUntilSettled()
1126
1127 job_names = [x.name for x in self.history]
1128 self.assertEqual(len(self.history), 1)
1129 self.assertIn('project-post', job_names)
1130
James E. Blairec056492016-07-22 09:45:56 -07001131 @skip("Disabled for early v3 development")
James E. Blairc6294a52012-08-17 10:19:48 -07001132 def test_build_configuration_branch_interaction(self):
1133 "Test that switching between branches works"
1134 self.test_build_configuration()
1135 self.test_build_configuration_branch()
1136 # C has been merged, undo that
Monty Taylorbc758832013-06-17 17:22:42 -04001137 path = os.path.join(self.upstream_root, "org/project")
James E. Blairc6294a52012-08-17 10:19:48 -07001138 repo = git.Repo(path)
1139 repo.heads.master.commit = repo.commit('init')
1140 self.test_build_configuration()
1141
James E. Blaircaec0c52012-08-22 14:52:22 -07001142 def test_dependent_changes_dequeue(self):
1143 "Test that dependent patches are not needlessly tested"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001144
James E. Blaircaec0c52012-08-22 14:52:22 -07001145 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1146 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1147 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001148 A.addApproval('code-review', 2)
1149 B.addApproval('code-review', 2)
1150 C.addApproval('code-review', 2)
James E. Blaircaec0c52012-08-22 14:52:22 -07001151
1152 M1 = self.fake_gerrit.addFakeChange('org/project', 'master', 'M1')
1153 M1.setMerged()
1154
1155 # C -> B -> A -> M1
1156
1157 C.setDependsOn(B, 1)
1158 B.setDependsOn(A, 1)
1159 A.setDependsOn(M1, 1)
1160
Paul Belanger174a8272017-03-14 13:20:10 -04001161 self.executor_server.failJob('project-merge', A)
James E. Blaircaec0c52012-08-22 14:52:22 -07001162
James E. Blair8b5408c2016-08-08 15:37:46 -07001163 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1164 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1165 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircaec0c52012-08-22 14:52:22 -07001166
1167 self.waitUntilSettled()
1168
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001169 self.assertEqual(A.data['status'], 'NEW')
1170 self.assertEqual(A.reported, 2)
1171 self.assertEqual(B.data['status'], 'NEW')
1172 self.assertEqual(B.reported, 2)
1173 self.assertEqual(C.data['status'], 'NEW')
1174 self.assertEqual(C.reported, 2)
1175 self.assertEqual(len(self.history), 1)
James E. Blairec590122012-08-22 15:19:31 -07001176
James E. Blair972e3c72013-08-29 12:04:55 -07001177 def test_failing_dependent_changes(self):
1178 "Test that failing dependent patches are taken out of stream"
Paul Belanger174a8272017-03-14 13:20:10 -04001179 self.executor_server.hold_jobs_in_build = True
James E. Blair972e3c72013-08-29 12:04:55 -07001180 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1181 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1182 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1183 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
1184 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
James E. Blair8b5408c2016-08-08 15:37:46 -07001185 A.addApproval('code-review', 2)
1186 B.addApproval('code-review', 2)
1187 C.addApproval('code-review', 2)
1188 D.addApproval('code-review', 2)
1189 E.addApproval('code-review', 2)
James E. Blair972e3c72013-08-29 12:04:55 -07001190
1191 # E, D -> C -> B, A
1192
1193 D.setDependsOn(C, 1)
1194 C.setDependsOn(B, 1)
1195
Paul Belanger174a8272017-03-14 13:20:10 -04001196 self.executor_server.failJob('project-test1', B)
James E. Blair972e3c72013-08-29 12:04:55 -07001197
James E. Blair8b5408c2016-08-08 15:37:46 -07001198 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1199 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
1200 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1201 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1202 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair972e3c72013-08-29 12:04:55 -07001203
1204 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001205 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001206 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001207 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001208 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001209 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001210 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001211 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001212 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001213 self.executor_server.release('.*-merge')
James E. Blair972e3c72013-08-29 12:04:55 -07001214 self.waitUntilSettled()
1215
Paul Belanger174a8272017-03-14 13:20:10 -04001216 self.executor_server.hold_jobs_in_build = False
James E. Blair972e3c72013-08-29 12:04:55 -07001217 for build in self.builds:
1218 if build.parameters['ZUUL_CHANGE'] != '1':
1219 build.release()
1220 self.waitUntilSettled()
1221
Paul Belanger174a8272017-03-14 13:20:10 -04001222 self.executor_server.release()
James E. Blair972e3c72013-08-29 12:04:55 -07001223 self.waitUntilSettled()
1224
1225 self.assertEqual(A.data['status'], 'MERGED')
1226 self.assertEqual(A.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001227 self.assertIn('Build succeeded', A.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001228 self.assertEqual(B.data['status'], 'NEW')
1229 self.assertEqual(B.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001230 self.assertIn('Build failed', B.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001231 self.assertEqual(C.data['status'], 'NEW')
1232 self.assertEqual(C.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001233 self.assertIn('depends on a change', C.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001234 self.assertEqual(D.data['status'], 'NEW')
1235 self.assertEqual(D.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001236 self.assertIn('depends on a change', D.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001237 self.assertEqual(E.data['status'], 'MERGED')
1238 self.assertEqual(E.reported, 2)
Jeremy Stanley10837132014-08-02 16:10:56 +00001239 self.assertIn('Build succeeded', E.messages[1])
James E. Blair972e3c72013-08-29 12:04:55 -07001240 self.assertEqual(len(self.history), 18)
1241
James E. Blairec590122012-08-22 15:19:31 -07001242 def test_head_is_dequeued_once(self):
James E. Blair2fa50962013-01-30 21:50:41 -08001243 "Test that if a change at the head fails it is dequeued only once"
James E. Blairec590122012-08-22 15:19:31 -07001244 # If it's dequeued more than once, we should see extra
1245 # aborted jobs.
James E. Blairec590122012-08-22 15:19:31 -07001246
Paul Belanger174a8272017-03-14 13:20:10 -04001247 self.executor_server.hold_jobs_in_build = True
James E. Blair6df67132017-04-19 13:53:20 -07001248 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1249 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1250 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001251 A.addApproval('code-review', 2)
1252 B.addApproval('code-review', 2)
1253 C.addApproval('code-review', 2)
James E. Blairec590122012-08-22 15:19:31 -07001254
Paul Belanger174a8272017-03-14 13:20:10 -04001255 self.executor_server.failJob('project-test1', A)
1256 self.executor_server.failJob('project-test2', A)
James E. Blairec590122012-08-22 15:19:31 -07001257
James E. Blair8b5408c2016-08-08 15:37:46 -07001258 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1259 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1260 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blairec590122012-08-22 15:19:31 -07001261
1262 self.waitUntilSettled()
James E. Blairec590122012-08-22 15:19:31 -07001263
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001264 self.assertEqual(len(self.builds), 1)
Paul Belanger58bf6912016-11-11 19:36:01 -05001265 self.assertEqual(self.builds[0].name, 'project-merge')
1266 self.assertTrue(self.builds[0].hasChanges(A))
James E. Blairec590122012-08-22 15:19:31 -07001267
Paul Belanger174a8272017-03-14 13:20:10 -04001268 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001269 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001270 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001271 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001272 self.executor_server.release('.*-merge')
James E. Blairec590122012-08-22 15:19:31 -07001273 self.waitUntilSettled()
1274
James E. Blair6df67132017-04-19 13:53:20 -07001275 self.assertEqual(len(self.builds), 6)
Paul Belanger58bf6912016-11-11 19:36:01 -05001276 self.assertEqual(self.builds[0].name, 'project-test1')
1277 self.assertEqual(self.builds[1].name, 'project-test2')
James E. Blair6df67132017-04-19 13:53:20 -07001278 self.assertEqual(self.builds[2].name, 'project-test1')
1279 self.assertEqual(self.builds[3].name, 'project-test2')
1280 self.assertEqual(self.builds[4].name, 'project-test1')
1281 self.assertEqual(self.builds[5].name, 'project-test2')
James E. Blairec590122012-08-22 15:19:31 -07001282
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001283 self.release(self.builds[0])
James E. Blairec590122012-08-22 15:19:31 -07001284 self.waitUntilSettled()
1285
James E. Blair6df67132017-04-19 13:53:20 -07001286 self.assertEqual(len(self.builds), 2) # test2, merge for B
1287 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 4)
James E. Blairec590122012-08-22 15:19:31 -07001288
Paul Belanger174a8272017-03-14 13:20:10 -04001289 self.executor_server.hold_jobs_in_build = False
1290 self.executor_server.release()
James E. Blairec590122012-08-22 15:19:31 -07001291 self.waitUntilSettled()
1292
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001293 self.assertEqual(len(self.builds), 0)
James E. Blair6df67132017-04-19 13:53:20 -07001294 self.assertEqual(len(self.history), 15)
James E. Blaircaec0c52012-08-22 14:52:22 -07001295
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001296 self.assertEqual(A.data['status'], 'NEW')
1297 self.assertEqual(B.data['status'], 'MERGED')
1298 self.assertEqual(C.data['status'], 'MERGED')
1299 self.assertEqual(A.reported, 2)
1300 self.assertEqual(B.reported, 2)
1301 self.assertEqual(C.reported, 2)
James E. Blair4ec821f2012-08-23 15:28:28 -07001302
James E. Blaircc020532017-04-19 13:04:44 -07001303 @simple_layout('layouts/nonvoting-job.yaml')
James E. Blair4ec821f2012-08-23 15:28:28 -07001304 def test_nonvoting_job(self):
1305 "Test that non-voting jobs don't vote."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001306
James E. Blair4ec821f2012-08-23 15:28:28 -07001307 A = self.fake_gerrit.addFakeChange('org/nonvoting-project',
1308 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001309 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04001310 self.executor_server.failJob('nonvoting-project-test2', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07001311 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4ec821f2012-08-23 15:28:28 -07001312
1313 self.waitUntilSettled()
James E. Blair4ec821f2012-08-23 15:28:28 -07001314
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001315 self.assertEqual(A.data['status'], 'MERGED')
1316 self.assertEqual(A.reported, 2)
1317 self.assertEqual(
1318 self.getJobFromHistory('nonvoting-project-merge').result,
1319 'SUCCESS')
1320 self.assertEqual(
1321 self.getJobFromHistory('nonvoting-project-test1').result,
1322 'SUCCESS')
1323 self.assertEqual(
1324 self.getJobFromHistory('nonvoting-project-test2').result,
1325 'FAILURE')
James E. Blaire0487072012-08-29 17:38:31 -07001326
James E. Blair5821bd92015-09-16 08:48:15 -07001327 for build in self.builds:
1328 self.assertEqual(build.parameters['ZUUL_VOTING'], '0')
1329
James E. Blaire0487072012-08-29 17:38:31 -07001330 def test_check_queue_success(self):
1331 "Test successful check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001332
James E. Blaire0487072012-08-29 17:38:31 -07001333 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1334 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1335
1336 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001337
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001338 self.assertEqual(A.data['status'], 'NEW')
1339 self.assertEqual(A.reported, 1)
1340 self.assertEqual(self.getJobFromHistory('project-merge').result,
1341 'SUCCESS')
1342 self.assertEqual(self.getJobFromHistory('project-test1').result,
1343 'SUCCESS')
1344 self.assertEqual(self.getJobFromHistory('project-test2').result,
1345 'SUCCESS')
James E. Blaire0487072012-08-29 17:38:31 -07001346
1347 def test_check_queue_failure(self):
1348 "Test failed check queue jobs."
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001349
James E. Blaire0487072012-08-29 17:38:31 -07001350 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belanger174a8272017-03-14 13:20:10 -04001351 self.executor_server.failJob('project-test2', A)
James E. Blaire0487072012-08-29 17:38:31 -07001352 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1353
1354 self.waitUntilSettled()
James E. Blaire0487072012-08-29 17:38:31 -07001355
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001356 self.assertEqual(A.data['status'], 'NEW')
1357 self.assertEqual(A.reported, 1)
1358 self.assertEqual(self.getJobFromHistory('project-merge').result,
James E. Blair78e31b32013-07-09 09:11:34 -07001359 'SUCCESS')
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001360 self.assertEqual(self.getJobFromHistory('project-test1').result,
1361 'SUCCESS')
1362 self.assertEqual(self.getJobFromHistory('project-test2').result,
1363 'FAILURE')
James E. Blair127bc182012-08-28 15:55:15 -07001364
James E. Blair7cb84542017-04-19 13:35:05 -07001365 @simple_layout('layouts/three-projects.yaml')
James E. Blair127bc182012-08-28 15:55:15 -07001366 def test_dependent_behind_dequeue(self):
Clint Byruma9626572017-02-22 14:04:00 -05001367 # This particular test does a large amount of merges and needs a little
1368 # more time to complete
James E. Blair267e5162017-04-07 10:08:20 -07001369 self.wait_timeout = 120
James E. Blair127bc182012-08-28 15:55:15 -07001370 "test that dependent changes behind dequeued changes work"
1371 # This complicated test is a reproduction of a real life bug
1372 self.sched.reconfigure(self.config)
James E. Blair127bc182012-08-28 15:55:15 -07001373
Paul Belanger174a8272017-03-14 13:20:10 -04001374 self.executor_server.hold_jobs_in_build = True
James E. Blair127bc182012-08-28 15:55:15 -07001375 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1376 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1377 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1378 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
1379 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
1380 F = self.fake_gerrit.addFakeChange('org/project3', 'master', 'F')
1381 D.setDependsOn(C, 1)
1382 E.setDependsOn(D, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07001383 A.addApproval('code-review', 2)
1384 B.addApproval('code-review', 2)
1385 C.addApproval('code-review', 2)
1386 D.addApproval('code-review', 2)
1387 E.addApproval('code-review', 2)
1388 F.addApproval('code-review', 2)
James E. Blair127bc182012-08-28 15:55:15 -07001389
1390 A.fail_merge = True
James E. Blair127bc182012-08-28 15:55:15 -07001391
1392 # Change object re-use in the gerrit trigger is hidden if
1393 # changes are added in quick succession; waiting makes it more
1394 # like real life.
James E. Blair8b5408c2016-08-08 15:37:46 -07001395 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001396 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001397 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001398 self.waitUntilSettled()
1399
Paul Belanger174a8272017-03-14 13:20:10 -04001400 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001401 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001402 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001403 self.waitUntilSettled()
1404
James E. Blair8b5408c2016-08-08 15:37:46 -07001405 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001406 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001407 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001408 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001409 self.fake_gerrit.addEvent(E.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001410 self.waitUntilSettled()
James E. Blair8b5408c2016-08-08 15:37:46 -07001411 self.fake_gerrit.addEvent(F.addApproval('approved', 1))
James E. Blair127bc182012-08-28 15:55:15 -07001412 self.waitUntilSettled()
1413
Paul Belanger174a8272017-03-14 13:20:10 -04001414 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001415 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001416 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001417 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001418 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001419 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001420 self.executor_server.release('.*-merge')
James E. Blair127bc182012-08-28 15:55:15 -07001421 self.waitUntilSettled()
1422
1423 # all jobs running
James E. Blaire955e062012-10-08 09:49:03 -07001424
1425 # Grab pointers to the jobs we want to release before
1426 # releasing any, because list indexes may change as
1427 # the jobs complete.
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001428 a, b, c = self.builds[:3]
James E. Blaire955e062012-10-08 09:49:03 -07001429 a.release()
1430 b.release()
1431 c.release()
James E. Blair127bc182012-08-28 15:55:15 -07001432 self.waitUntilSettled()
1433
Paul Belanger174a8272017-03-14 13:20:10 -04001434 self.executor_server.hold_jobs_in_build = False
1435 self.executor_server.release()
James E. Blair127bc182012-08-28 15:55:15 -07001436 self.waitUntilSettled()
1437
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001438 self.assertEqual(A.data['status'], 'NEW')
1439 self.assertEqual(B.data['status'], 'MERGED')
1440 self.assertEqual(C.data['status'], 'MERGED')
1441 self.assertEqual(D.data['status'], 'MERGED')
1442 self.assertEqual(E.data['status'], 'MERGED')
1443 self.assertEqual(F.data['status'], 'MERGED')
James E. Blair127bc182012-08-28 15:55:15 -07001444
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001445 self.assertEqual(A.reported, 2)
1446 self.assertEqual(B.reported, 2)
1447 self.assertEqual(C.reported, 2)
1448 self.assertEqual(D.reported, 2)
1449 self.assertEqual(E.reported, 2)
1450 self.assertEqual(F.reported, 2)
James E. Blair127bc182012-08-28 15:55:15 -07001451
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001452 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 15)
1453 self.assertEqual(len(self.history), 44)
James E. Blair05fed602012-09-07 12:45:24 -07001454
1455 def test_merger_repack(self):
1456 "Test that the merger works after a repack"
James E. Blair1f4c2bb2013-04-26 08:40:46 -07001457
James E. Blair05fed602012-09-07 12:45:24 -07001458 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001459 A.addApproval('code-review', 2)
1460 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001461 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001462 self.assertEqual(self.getJobFromHistory('project-merge').result,
1463 'SUCCESS')
1464 self.assertEqual(self.getJobFromHistory('project-test1').result,
1465 'SUCCESS')
1466 self.assertEqual(self.getJobFromHistory('project-test2').result,
1467 'SUCCESS')
1468 self.assertEqual(A.data['status'], 'MERGED')
1469 self.assertEqual(A.reported, 2)
James E. Blair05fed602012-09-07 12:45:24 -07001470 self.assertEmptyQueues()
Paul Belanger5bfe9e72016-11-04 19:20:04 -04001471 self.build_history = []
James E. Blair05fed602012-09-07 12:45:24 -07001472
James E. Blair2a535672017-04-27 12:03:15 -07001473 path = os.path.join(self.merger_src_root, "review.example.com",
1474 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001475 if os.path.exists(path):
1476 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001477 path = os.path.join(self.executor_src_root, "review.example.com",
1478 "org/project")
James E. Blair8c1be532017-02-07 14:04:12 -08001479 if os.path.exists(path):
1480 repack_repo(path)
James E. Blair05fed602012-09-07 12:45:24 -07001481
1482 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001483 A.addApproval('code-review', 2)
1484 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair05fed602012-09-07 12:45:24 -07001485 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001486 self.assertEqual(self.getJobFromHistory('project-merge').result,
1487 'SUCCESS')
1488 self.assertEqual(self.getJobFromHistory('project-test1').result,
1489 'SUCCESS')
1490 self.assertEqual(self.getJobFromHistory('project-test2').result,
1491 'SUCCESS')
1492 self.assertEqual(A.data['status'], 'MERGED')
1493 self.assertEqual(A.reported, 2)
James E. Blair7ee88a22012-09-12 18:59:31 +02001494
James E. Blair4886f282012-11-15 09:27:33 -08001495 def test_merger_repack_large_change(self):
1496 "Test that the merger works with large changes after a repack"
Paul Belanger174a8272017-03-14 13:20:10 -04001497 # https://bugs.executepad.net/zuul/+bug/1078946
James E. Blairac2c3242014-01-24 13:38:51 -08001498 # This test assumes the repo is already cloned; make sure it is
Paul Belanger503bded2016-11-11 19:43:38 -05001499 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6df67132017-04-19 13:53:20 -07001500 trusted, project = tenant.getProject('org/project')
James E. Blair0ffa0102017-03-30 13:11:33 -07001501 url = self.fake_gerrit.getGitUrl(project)
James E. Blair2a535672017-04-27 12:03:15 -07001502 self.merge_server.merger._addProject('review.example.com',
1503 'org/project', url)
James E. Blair6df67132017-04-19 13:53:20 -07001504 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair4886f282012-11-15 09:27:33 -08001505 A.addPatchset(large=True)
James E. Blair2a535672017-04-27 12:03:15 -07001506 # TODOv3(jeblair): add hostname to upstream root
1507 path = os.path.join(self.upstream_root, 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001508 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001509 path = os.path.join(self.merger_src_root, 'review.example.com',
1510 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001511 if os.path.exists(path):
1512 repack_repo(path)
James E. Blair2a535672017-04-27 12:03:15 -07001513 path = os.path.join(self.executor_src_root, 'review.example.com',
1514 'org/project')
James E. Blair8c1be532017-02-07 14:04:12 -08001515 if os.path.exists(path):
1516 repack_repo(path)
James E. Blair4886f282012-11-15 09:27:33 -08001517
James E. Blair8b5408c2016-08-08 15:37:46 -07001518 A.addApproval('code-review', 2)
1519 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4886f282012-11-15 09:27:33 -08001520 self.waitUntilSettled()
Paul Belanger503bded2016-11-11 19:43:38 -05001521 self.assertEqual(self.getJobFromHistory('project-merge').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001522 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001523 self.assertEqual(self.getJobFromHistory('project-test1').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001524 'SUCCESS')
Paul Belanger503bded2016-11-11 19:43:38 -05001525 self.assertEqual(self.getJobFromHistory('project-test2').result,
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001526 'SUCCESS')
1527 self.assertEqual(A.data['status'], 'MERGED')
1528 self.assertEqual(A.reported, 2)
James E. Blair4886f282012-11-15 09:27:33 -08001529
James E. Blair2fa50962013-01-30 21:50:41 -08001530 def test_new_patchset_dequeues_old(self):
1531 "Test that a new patchset causes the old to be dequeued"
1532 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001533 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001534 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1535 M.setMerged()
1536
1537 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1538 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1539 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1540 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001541 A.addApproval('code-review', 2)
1542 B.addApproval('code-review', 2)
1543 C.addApproval('code-review', 2)
1544 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001545
1546 C.setDependsOn(B, 1)
1547 B.setDependsOn(A, 1)
1548 A.setDependsOn(M, 1)
1549
James E. Blair8b5408c2016-08-08 15:37:46 -07001550 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1551 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1552 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1553 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001554 self.waitUntilSettled()
1555
1556 B.addPatchset()
1557 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1558 self.waitUntilSettled()
1559
Paul Belanger174a8272017-03-14 13:20:10 -04001560 self.executor_server.hold_jobs_in_build = False
1561 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001562 self.waitUntilSettled()
1563
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001564 self.assertEqual(A.data['status'], 'MERGED')
1565 self.assertEqual(A.reported, 2)
1566 self.assertEqual(B.data['status'], 'NEW')
1567 self.assertEqual(B.reported, 2)
1568 self.assertEqual(C.data['status'], 'NEW')
1569 self.assertEqual(C.reported, 2)
1570 self.assertEqual(D.data['status'], 'MERGED')
1571 self.assertEqual(D.reported, 2)
1572 self.assertEqual(len(self.history), 9) # 3 each for A, B, D.
James E. Blair2fa50962013-01-30 21:50:41 -08001573
James E. Blairba437362015-02-07 11:41:52 -08001574 def test_new_patchset_check(self):
1575 "Test a new patchset in check"
Antoine Mussobd86a312014-01-08 14:51:33 +01001576
Paul Belanger174a8272017-03-14 13:20:10 -04001577 self.executor_server.hold_jobs_in_build = True
Antoine Mussobd86a312014-01-08 14:51:33 +01001578
1579 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blairba437362015-02-07 11:41:52 -08001580 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001581 tenant = self.sched.abide.tenants.get('tenant-one')
1582 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001583
1584 # Add two git-dependent changes
1585 B.setDependsOn(A, 1)
1586 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1587 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001588 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1589 self.waitUntilSettled()
James E. Blairba437362015-02-07 11:41:52 -08001590
1591 # A live item, and a non-live/live pair
1592 items = check_pipeline.getAllItems()
1593 self.assertEqual(len(items), 3)
1594
1595 self.assertEqual(items[0].change.number, '1')
1596 self.assertEqual(items[0].change.patchset, '1')
1597 self.assertFalse(items[0].live)
1598
1599 self.assertEqual(items[1].change.number, '2')
1600 self.assertEqual(items[1].change.patchset, '1')
1601 self.assertTrue(items[1].live)
1602
1603 self.assertEqual(items[2].change.number, '1')
1604 self.assertEqual(items[2].change.patchset, '1')
1605 self.assertTrue(items[2].live)
1606
1607 # Add a new patchset to A
1608 A.addPatchset()
1609 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1610 self.waitUntilSettled()
1611
1612 # The live copy of A,1 should be gone, but the non-live and B
1613 # should continue, and we should have a new A,2
1614 items = check_pipeline.getAllItems()
1615 self.assertEqual(len(items), 3)
1616
1617 self.assertEqual(items[0].change.number, '1')
1618 self.assertEqual(items[0].change.patchset, '1')
1619 self.assertFalse(items[0].live)
1620
1621 self.assertEqual(items[1].change.number, '2')
1622 self.assertEqual(items[1].change.patchset, '1')
1623 self.assertTrue(items[1].live)
1624
1625 self.assertEqual(items[2].change.number, '1')
1626 self.assertEqual(items[2].change.patchset, '2')
1627 self.assertTrue(items[2].live)
1628
1629 # Add a new patchset to B
1630 B.addPatchset()
1631 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1632 self.waitUntilSettled()
1633
1634 # The live copy of B,1 should be gone, and it's non-live copy of A,1
1635 # but we should have a new B,2 (still based on A,1)
1636 items = check_pipeline.getAllItems()
1637 self.assertEqual(len(items), 3)
1638
1639 self.assertEqual(items[0].change.number, '1')
1640 self.assertEqual(items[0].change.patchset, '2')
1641 self.assertTrue(items[0].live)
1642
1643 self.assertEqual(items[1].change.number, '1')
1644 self.assertEqual(items[1].change.patchset, '1')
1645 self.assertFalse(items[1].live)
1646
1647 self.assertEqual(items[2].change.number, '2')
1648 self.assertEqual(items[2].change.patchset, '2')
1649 self.assertTrue(items[2].live)
1650
1651 self.builds[0].release()
1652 self.waitUntilSettled()
1653 self.builds[0].release()
1654 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001655 self.executor_server.hold_jobs_in_build = False
1656 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001657 self.waitUntilSettled()
1658
1659 self.assertEqual(A.reported, 1)
1660 self.assertEqual(B.reported, 1)
1661 self.assertEqual(self.history[0].result, 'ABORTED')
1662 self.assertEqual(self.history[0].changes, '1,1')
1663 self.assertEqual(self.history[1].result, 'ABORTED')
1664 self.assertEqual(self.history[1].changes, '1,1 2,1')
1665 self.assertEqual(self.history[2].result, 'SUCCESS')
1666 self.assertEqual(self.history[2].changes, '1,2')
1667 self.assertEqual(self.history[3].result, 'SUCCESS')
1668 self.assertEqual(self.history[3].changes, '1,1 2,2')
1669
1670 def test_abandoned_gate(self):
1671 "Test that an abandoned change is dequeued from gate"
1672
Paul Belanger174a8272017-03-14 13:20:10 -04001673 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001674
1675 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001676 A.addApproval('code-review', 2)
1677 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairba437362015-02-07 11:41:52 -08001678 self.waitUntilSettled()
Antoine Mussobd86a312014-01-08 14:51:33 +01001679 self.assertEqual(len(self.builds), 1, "One job being built (on hold)")
1680 self.assertEqual(self.builds[0].name, 'project-merge')
1681
1682 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1683 self.waitUntilSettled()
1684
Paul Belanger174a8272017-03-14 13:20:10 -04001685 self.executor_server.release('.*-merge')
Antoine Mussobd86a312014-01-08 14:51:33 +01001686 self.waitUntilSettled()
1687
Arie5b4048c2016-10-05 16:12:06 +03001688 self.assertBuilds([])
1689 self.assertHistory([
1690 dict(name='project-merge', result='ABORTED', changes='1,1')],
1691 ordered=False)
James E. Blairba437362015-02-07 11:41:52 -08001692 self.assertEqual(A.reported, 1,
1693 "Abandoned gate change should report only start")
1694
1695 def test_abandoned_check(self):
1696 "Test that an abandoned change is dequeued from check"
1697
Paul Belanger174a8272017-03-14 13:20:10 -04001698 self.executor_server.hold_jobs_in_build = True
James E. Blairba437362015-02-07 11:41:52 -08001699
1700 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1701 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger18e5f632016-11-03 15:24:16 -04001702 tenant = self.sched.abide.tenants.get('tenant-one')
1703 check_pipeline = tenant.layout.pipelines['check']
James E. Blairba437362015-02-07 11:41:52 -08001704
1705 # Add two git-dependent changes
1706 B.setDependsOn(A, 1)
1707 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1708 self.waitUntilSettled()
1709 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1710 self.waitUntilSettled()
1711 # A live item, and a non-live/live pair
1712 items = check_pipeline.getAllItems()
1713 self.assertEqual(len(items), 3)
1714
1715 self.assertEqual(items[0].change.number, '1')
1716 self.assertFalse(items[0].live)
1717
1718 self.assertEqual(items[1].change.number, '2')
1719 self.assertTrue(items[1].live)
1720
1721 self.assertEqual(items[2].change.number, '1')
1722 self.assertTrue(items[2].live)
1723
1724 # Abandon A
1725 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1726 self.waitUntilSettled()
1727
1728 # The live copy of A should be gone, but the non-live and B
1729 # should continue
1730 items = check_pipeline.getAllItems()
1731 self.assertEqual(len(items), 2)
1732
1733 self.assertEqual(items[0].change.number, '1')
1734 self.assertFalse(items[0].live)
1735
1736 self.assertEqual(items[1].change.number, '2')
1737 self.assertTrue(items[1].live)
1738
Paul Belanger174a8272017-03-14 13:20:10 -04001739 self.executor_server.hold_jobs_in_build = False
1740 self.executor_server.release()
James E. Blairba437362015-02-07 11:41:52 -08001741 self.waitUntilSettled()
1742
1743 self.assertEqual(len(self.history), 4)
1744 self.assertEqual(self.history[0].result, 'ABORTED',
Antoine Mussobd86a312014-01-08 14:51:33 +01001745 'Build should have been aborted')
1746 self.assertEqual(A.reported, 0, "Abandoned change should not report")
James E. Blairba437362015-02-07 11:41:52 -08001747 self.assertEqual(B.reported, 1, "Change should report")
Antoine Mussobd86a312014-01-08 14:51:33 +01001748
Steve Varnau7b78b312015-04-03 14:49:46 -07001749 def test_abandoned_not_timer(self):
1750 "Test that an abandoned change does not cancel timer jobs"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001751 # This test can not use simple_layout because it must start
1752 # with a configuration which does not include a
1753 # timer-triggered job so that we have an opportunity to set
1754 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04001755 self.executor_server.hold_jobs_in_build = True
Steve Varnau7b78b312015-04-03 14:49:46 -07001756 # Start timer trigger - also org/project
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001757 self.commitConfigUpdate('common-config', 'layouts/idle.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001758 self.sched.reconfigure(self.config)
Steve Varnau7b78b312015-04-03 14:49:46 -07001759 # The pipeline triggers every second, so we should have seen
1760 # several by now.
1761 time.sleep(5)
1762 self.waitUntilSettled()
1763 # Stop queuing timer triggered jobs so that the assertions
1764 # below don't race against more jobs being queued.
Clint Byrumead6c562017-02-01 16:34:04 -08001765 # Must be in same repo, so overwrite config with another one
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001766 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Steve Varnau7b78b312015-04-03 14:49:46 -07001767 self.sched.reconfigure(self.config)
James E. Blairdfdfcfc2017-04-20 10:19:20 -07001768
Steve Varnau7b78b312015-04-03 14:49:46 -07001769 self.assertEqual(len(self.builds), 2, "Two timer jobs")
1770
1771 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1772 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1773 self.waitUntilSettled()
1774 self.assertEqual(len(self.builds), 3, "One change plus two timer jobs")
1775
1776 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
1777 self.waitUntilSettled()
1778
1779 self.assertEqual(len(self.builds), 2, "Two timer jobs remain")
1780
Paul Belanger174a8272017-03-14 13:20:10 -04001781 self.executor_server.release()
Steve Varnau7b78b312015-04-03 14:49:46 -07001782 self.waitUntilSettled()
1783
Arx Cruzb1b010d2013-10-28 19:49:59 -02001784 def test_zuul_url_return(self):
1785 "Test if ZUUL_URL is returning when zuul_url is set in zuul.conf"
James E. Blair4076e2b2014-01-28 12:42:20 -08001786 self.assertTrue(self.sched.config.has_option('merger', 'zuul_url'))
Paul Belanger174a8272017-03-14 13:20:10 -04001787 self.executor_server.hold_jobs_in_build = True
Arx Cruzb1b010d2013-10-28 19:49:59 -02001788
1789 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001790 A.addApproval('code-review', 2)
1791 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Arx Cruzb1b010d2013-10-28 19:49:59 -02001792 self.waitUntilSettled()
1793
1794 self.assertEqual(len(self.builds), 1)
1795 for build in self.builds:
1796 self.assertTrue('ZUUL_URL' in build.parameters)
1797
Paul Belanger174a8272017-03-14 13:20:10 -04001798 self.executor_server.hold_jobs_in_build = False
1799 self.executor_server.release()
Arx Cruzb1b010d2013-10-28 19:49:59 -02001800 self.waitUntilSettled()
1801
James E. Blair2fa50962013-01-30 21:50:41 -08001802 def test_new_patchset_dequeues_old_on_head(self):
1803 "Test that a new patchset causes the old to be dequeued (at head)"
1804 # D -> C (depends on B) -> B (depends on A) -> A -> M
Paul Belanger174a8272017-03-14 13:20:10 -04001805 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001806 M = self.fake_gerrit.addFakeChange('org/project', 'master', 'M')
1807 M.setMerged()
1808 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1809 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1810 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1811 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001812 A.addApproval('code-review', 2)
1813 B.addApproval('code-review', 2)
1814 C.addApproval('code-review', 2)
1815 D.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001816
1817 C.setDependsOn(B, 1)
1818 B.setDependsOn(A, 1)
1819 A.setDependsOn(M, 1)
1820
James E. Blair8b5408c2016-08-08 15:37:46 -07001821 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1822 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1823 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1824 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001825 self.waitUntilSettled()
1826
1827 A.addPatchset()
1828 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
1829 self.waitUntilSettled()
1830
Paul Belanger174a8272017-03-14 13:20:10 -04001831 self.executor_server.hold_jobs_in_build = False
1832 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001833 self.waitUntilSettled()
1834
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001835 self.assertEqual(A.data['status'], 'NEW')
1836 self.assertEqual(A.reported, 2)
1837 self.assertEqual(B.data['status'], 'NEW')
1838 self.assertEqual(B.reported, 2)
1839 self.assertEqual(C.data['status'], 'NEW')
1840 self.assertEqual(C.reported, 2)
1841 self.assertEqual(D.data['status'], 'MERGED')
1842 self.assertEqual(D.reported, 2)
1843 self.assertEqual(len(self.history), 7)
James E. Blair2fa50962013-01-30 21:50:41 -08001844
1845 def test_new_patchset_dequeues_old_without_dependents(self):
1846 "Test that a new patchset causes only the old to be dequeued"
Paul Belanger174a8272017-03-14 13:20:10 -04001847 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001848 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1849 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1850 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07001851 A.addApproval('code-review', 2)
1852 B.addApproval('code-review', 2)
1853 C.addApproval('code-review', 2)
James E. Blair2fa50962013-01-30 21:50:41 -08001854
James E. Blair8b5408c2016-08-08 15:37:46 -07001855 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1856 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1857 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair2fa50962013-01-30 21:50:41 -08001858 self.waitUntilSettled()
1859
1860 B.addPatchset()
1861 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1862 self.waitUntilSettled()
1863
Paul Belanger174a8272017-03-14 13:20:10 -04001864 self.executor_server.hold_jobs_in_build = False
1865 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001866 self.waitUntilSettled()
1867
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001868 self.assertEqual(A.data['status'], 'MERGED')
1869 self.assertEqual(A.reported, 2)
1870 self.assertEqual(B.data['status'], 'NEW')
1871 self.assertEqual(B.reported, 2)
1872 self.assertEqual(C.data['status'], 'MERGED')
1873 self.assertEqual(C.reported, 2)
1874 self.assertEqual(len(self.history), 9)
James E. Blair2fa50962013-01-30 21:50:41 -08001875
1876 def test_new_patchset_dequeues_old_independent_queue(self):
1877 "Test that a new patchset causes the old to be dequeued (independent)"
Paul Belanger174a8272017-03-14 13:20:10 -04001878 self.executor_server.hold_jobs_in_build = True
James E. Blair2fa50962013-01-30 21:50:41 -08001879 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
1880 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
1881 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
1882 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1883 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
1884 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
1885 self.waitUntilSettled()
1886
1887 B.addPatchset()
1888 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2))
1889 self.waitUntilSettled()
1890
Paul Belanger174a8272017-03-14 13:20:10 -04001891 self.executor_server.hold_jobs_in_build = False
1892 self.executor_server.release()
James E. Blair2fa50962013-01-30 21:50:41 -08001893 self.waitUntilSettled()
1894
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001895 self.assertEqual(A.data['status'], 'NEW')
1896 self.assertEqual(A.reported, 1)
1897 self.assertEqual(B.data['status'], 'NEW')
1898 self.assertEqual(B.reported, 1)
1899 self.assertEqual(C.data['status'], 'NEW')
1900 self.assertEqual(C.reported, 1)
1901 self.assertEqual(len(self.history), 10)
1902 self.assertEqual(self.countJobResults(self.history, 'ABORTED'), 1)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001903
James E. Blaircc020532017-04-19 13:04:44 -07001904 @simple_layout('layouts/noop-job.yaml')
James E. Blair18c64442014-03-18 10:14:45 -07001905 def test_noop_job(self):
1906 "Test that the internal noop job works"
1907 A = self.fake_gerrit.addFakeChange('org/noop-project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07001908 A.addApproval('code-review', 2)
1909 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair18c64442014-03-18 10:14:45 -07001910 self.waitUntilSettled()
1911
1912 self.assertEqual(len(self.gearman_server.getQueue()), 0)
1913 self.assertTrue(self.sched._areAllBuildsComplete())
1914 self.assertEqual(len(self.history), 0)
1915 self.assertEqual(A.data['status'], 'MERGED')
1916 self.assertEqual(A.reported, 2)
1917
James E. Blair06cc3922017-04-19 10:08:10 -07001918 @simple_layout('layouts/no-jobs-project.yaml')
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001919 def test_no_job_project(self):
1920 "Test that reports with no jobs don't get sent"
1921 A = self.fake_gerrit.addFakeChange('org/no-jobs-project',
1922 'master', 'A')
1923 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
1924 self.waitUntilSettled()
1925
1926 # Change wasn't reported to
1927 self.assertEqual(A.reported, False)
1928
1929 # Check queue is empty afterwards
Clint Byrum883c30e2016-12-13 11:54:33 -08001930 tenant = self.sched.abide.tenants.get('tenant-one')
1931 check_pipeline = tenant.layout.pipelines['check']
Evgeny Antyshevd6e546c2015-06-11 15:13:57 +00001932 items = check_pipeline.getAllItems()
1933 self.assertEqual(len(items), 0)
1934
1935 self.assertEqual(len(self.history), 0)
1936
James E. Blair7d0dedc2013-02-21 17:26:09 -08001937 def test_zuul_refs(self):
1938 "Test that zuul refs exist and have the right changes"
Paul Belanger174a8272017-03-14 13:20:10 -04001939 self.executor_server.hold_jobs_in_build = True
James E. Blair7d0dedc2013-02-21 17:26:09 -08001940 M1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'M1')
1941 M1.setMerged()
1942 M2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'M2')
1943 M2.setMerged()
1944
1945 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
1946 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
1947 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
1948 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
James E. Blair8b5408c2016-08-08 15:37:46 -07001949 A.addApproval('code-review', 2)
1950 B.addApproval('code-review', 2)
1951 C.addApproval('code-review', 2)
1952 D.addApproval('code-review', 2)
1953 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
1954 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
1955 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
1956 self.fake_gerrit.addEvent(D.addApproval('approved', 1))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001957
1958 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001959 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001960 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001961 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001962 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001963 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001964 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04001965 self.executor_server.release('.*-merge')
James E. Blair7d0dedc2013-02-21 17:26:09 -08001966 self.waitUntilSettled()
1967
James E. Blair7d0dedc2013-02-21 17:26:09 -08001968 a_zref = b_zref = c_zref = d_zref = None
Clint Byrum3343e3e2016-11-15 16:05:03 -08001969 a_build = b_build = c_build = d_build = None
Monty Taylor6bef8ef2013-06-02 08:17:12 -04001970 for x in self.builds:
James E. Blair7d0dedc2013-02-21 17:26:09 -08001971 if x.parameters['ZUUL_CHANGE'] == '3':
1972 a_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001973 a_build = x
1974 elif x.parameters['ZUUL_CHANGE'] == '4':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001975 b_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001976 b_build = x
1977 elif x.parameters['ZUUL_CHANGE'] == '5':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001978 c_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001979 c_build = x
1980 elif x.parameters['ZUUL_CHANGE'] == '6':
James E. Blair7d0dedc2013-02-21 17:26:09 -08001981 d_zref = x.parameters['ZUUL_REF']
Clint Byrum3343e3e2016-11-15 16:05:03 -08001982 d_build = x
1983 if a_build and b_build and c_build and d_build:
1984 break
James E. Blair7d0dedc2013-02-21 17:26:09 -08001985
1986 # There are... four... refs.
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001987 self.assertIsNotNone(a_zref)
1988 self.assertIsNotNone(b_zref)
1989 self.assertIsNotNone(c_zref)
1990 self.assertIsNotNone(d_zref)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001991
1992 # And they should all be different
1993 refs = set([a_zref, b_zref, c_zref, d_zref])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04001994 self.assertEqual(len(refs), 4)
James E. Blair7d0dedc2013-02-21 17:26:09 -08001995
Clint Byrum3343e3e2016-11-15 16:05:03 -08001996 # should have a, not b, and should not be in project2
1997 self.assertTrue(a_build.hasChanges(A))
1998 self.assertFalse(a_build.hasChanges(B, M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08001999
Clint Byrum3343e3e2016-11-15 16:05:03 -08002000 # should have a and b, and should not be in project2
2001 self.assertTrue(b_build.hasChanges(A, B))
2002 self.assertFalse(b_build.hasChanges(M2))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002003
Clint Byrum3343e3e2016-11-15 16:05:03 -08002004 # should have a and b in 1, c in 2
2005 self.assertTrue(c_build.hasChanges(A, B, C))
2006 self.assertFalse(c_build.hasChanges(D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002007
Clint Byrum3343e3e2016-11-15 16:05:03 -08002008 # should have a and b in 1, c and d in 2
2009 self.assertTrue(d_build.hasChanges(A, B, C, D))
James E. Blair7d0dedc2013-02-21 17:26:09 -08002010
Paul Belanger174a8272017-03-14 13:20:10 -04002011 self.executor_server.hold_jobs_in_build = False
2012 self.executor_server.release()
James E. Blair7d0dedc2013-02-21 17:26:09 -08002013 self.waitUntilSettled()
2014
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002015 self.assertEqual(A.data['status'], 'MERGED')
2016 self.assertEqual(A.reported, 2)
2017 self.assertEqual(B.data['status'], 'MERGED')
2018 self.assertEqual(B.reported, 2)
2019 self.assertEqual(C.data['status'], 'MERGED')
2020 self.assertEqual(C.reported, 2)
2021 self.assertEqual(D.data['status'], 'MERGED')
2022 self.assertEqual(D.reported, 2)
James E. Blair70c71582013-03-06 08:50:50 -08002023
James E. Blair4a28a882013-08-23 15:17:33 -07002024 def test_rerun_on_error(self):
2025 "Test that if a worker fails to run a job, it is run again"
Paul Belanger174a8272017-03-14 13:20:10 -04002026 self.executor_server.hold_jobs_in_build = True
James E. Blair4a28a882013-08-23 15:17:33 -07002027 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002028 A.addApproval('code-review', 2)
2029 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair4a28a882013-08-23 15:17:33 -07002030 self.waitUntilSettled()
2031
James E. Blair412fba82017-01-26 15:00:50 -08002032 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002033 self.executor_server.hold_jobs_in_build = False
2034 self.executor_server.release()
James E. Blair4a28a882013-08-23 15:17:33 -07002035 self.waitUntilSettled()
James E. Blair412fba82017-01-26 15:00:50 -08002036 self.assertEqual(self.countJobResults(self.history, None), 1)
James E. Blair4a28a882013-08-23 15:17:33 -07002037 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 3)
2038
James E. Blair412e5582013-04-22 15:50:12 -07002039 def test_statsd(self):
2040 "Test each of the statsd methods used in the scheduler"
2041 import extras
2042 statsd = extras.try_import('statsd.statsd')
2043 statsd.incr('test-incr')
2044 statsd.timing('test-timing', 3)
Alex Gaynor813d39b2014-05-17 16:17:16 -07002045 statsd.gauge('test-gauge', 12)
James E. Blair412e5582013-04-22 15:50:12 -07002046 self.assertReportedStat('test-incr', '1|c')
2047 self.assertReportedStat('test-timing', '3|ms')
Alex Gaynor813d39b2014-05-17 16:17:16 -07002048 self.assertReportedStat('test-gauge', '12|g')
James E. Blair412e5582013-04-22 15:50:12 -07002049
James E. Blairdad52252014-02-07 16:59:17 -08002050 def test_stuck_job_cleanup(self):
2051 "Test that pending jobs are cleaned up if removed from layout"
Clint Byrum678e2c32017-03-16 16:27:21 -07002052
2053 # We want to hold the project-merge job that the fake change enqueues
James E. Blairdad52252014-02-07 16:59:17 -08002054 self.gearman_server.hold_jobs_in_queue = True
2055 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002056 A.addApproval('code-review', 2)
2057 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blairdad52252014-02-07 16:59:17 -08002058 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002059 # The assertion is that we have one job in the queue, project-merge
James E. Blairdad52252014-02-07 16:59:17 -08002060 self.assertEqual(len(self.gearman_server.getQueue()), 1)
2061
James E. Blair31cb3e82017-04-20 13:08:56 -07002062 self.commitConfigUpdate('common-config', 'layouts/no-jobs.yaml')
James E. Blairdad52252014-02-07 16:59:17 -08002063 self.sched.reconfigure(self.config)
2064 self.waitUntilSettled()
2065
James E. Blair18c64442014-03-18 10:14:45 -07002066 self.gearman_server.release('gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002067 self.waitUntilSettled()
Clint Byrum678e2c32017-03-16 16:27:21 -07002068 # asserting that project-merge is removed from queue
James E. Blairdad52252014-02-07 16:59:17 -08002069 self.assertEqual(len(self.gearman_server.getQueue()), 0)
2070 self.assertTrue(self.sched._areAllBuildsComplete())
2071
2072 self.assertEqual(len(self.history), 1)
James E. Blair18c64442014-03-18 10:14:45 -07002073 self.assertEqual(self.history[0].name, 'gate-noop')
James E. Blairdad52252014-02-07 16:59:17 -08002074 self.assertEqual(self.history[0].result, 'SUCCESS')
2075
James E. Blair879dafb2015-07-17 14:04:49 -07002076 def test_file_head(self):
2077 # This is a regression test for an observed bug. A change
2078 # with a file named "HEAD" in the root directory of the repo
2079 # was processed by a merger. It then was unable to reset the
2080 # repo because of:
2081 # GitCommandError: 'git reset --hard HEAD' returned
2082 # with exit code 128
2083 # stderr: 'fatal: ambiguous argument 'HEAD': both revision
2084 # and filename
2085 # Use '--' to separate filenames from revisions'
2086
2087 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Paul Belangera91095f2016-11-04 19:28:48 -04002088 A.addPatchset({'HEAD': ''})
James E. Blair879dafb2015-07-17 14:04:49 -07002089 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2090
2091 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
2092 self.waitUntilSettled()
2093
2094 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2095 self.waitUntilSettled()
2096
2097 self.assertIn('Build succeeded', A.messages[0])
2098 self.assertIn('Build succeeded', B.messages[0])
2099
James E. Blair70c71582013-03-06 08:50:50 -08002100 def test_file_jobs(self):
2101 "Test that file jobs run only when appropriate"
2102 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
Adam Gandelman5661bda2017-02-03 15:58:03 -08002103 A.addPatchset({'pip-requires': 'foo'})
James E. Blair70c71582013-03-06 08:50:50 -08002104 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07002105 A.addApproval('code-review', 2)
2106 B.addApproval('code-review', 2)
2107 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2108 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair70c71582013-03-06 08:50:50 -08002109 self.waitUntilSettled()
2110
Monty Taylor6bef8ef2013-06-02 08:17:12 -04002111 testfile_jobs = [x for x in self.history
James E. Blair70c71582013-03-06 08:50:50 -08002112 if x.name == 'project-testfile']
2113
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002114 self.assertEqual(len(testfile_jobs), 1)
2115 self.assertEqual(testfile_jobs[0].changes, '1,2')
2116 self.assertEqual(A.data['status'], 'MERGED')
2117 self.assertEqual(A.reported, 2)
2118 self.assertEqual(B.data['status'], 'MERGED')
2119 self.assertEqual(B.reported, 2)
James E. Blair3c5e5b52013-04-26 11:17:03 -07002120
Clint Byrum3ee39f32016-11-17 23:45:07 -08002121 def _test_irrelevant_files_jobs(self, should_skip):
2122 "Test that jobs with irrelevant-files filter run only when appropriate"
Clint Byrum3ee39f32016-11-17 23:45:07 -08002123 if should_skip:
2124 files = {'ignoreme': 'ignored\n'}
2125 else:
2126 files = {'respectme': 'please!\n'}
Maru Newby3fe5f852015-01-13 04:22:14 +00002127
2128 change = self.fake_gerrit.addFakeChange('org/project',
Clint Byrum3ee39f32016-11-17 23:45:07 -08002129 'master',
2130 'test irrelevant-files',
2131 files=files)
Maru Newby3fe5f852015-01-13 04:22:14 +00002132 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2133 self.waitUntilSettled()
2134
2135 tested_change_ids = [x.changes[0] for x in self.history
Clint Byrum3ee39f32016-11-17 23:45:07 -08002136 if x.name == 'project-test-irrelevant-files']
Maru Newby3fe5f852015-01-13 04:22:14 +00002137
2138 if should_skip:
2139 self.assertEqual([], tested_change_ids)
2140 else:
2141 self.assertIn(change.data['number'], tested_change_ids)
2142
James E. Blaircc324192017-04-19 14:36:08 -07002143 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002144 def test_irrelevant_files_match_skips_job(self):
2145 self._test_irrelevant_files_jobs(should_skip=True)
Maru Newby3fe5f852015-01-13 04:22:14 +00002146
James E. Blaircc324192017-04-19 14:36:08 -07002147 @simple_layout('layouts/irrelevant-files.yaml')
Clint Byrum3ee39f32016-11-17 23:45:07 -08002148 def test_irrelevant_files_no_match_runs_job(self):
2149 self._test_irrelevant_files_jobs(should_skip=False)
Maru Newby3fe5f852015-01-13 04:22:14 +00002150
James E. Blaircc324192017-04-19 14:36:08 -07002151 @simple_layout('layouts/inheritance.yaml')
Clint Byrum85493602016-11-18 11:59:47 -08002152 def test_inherited_jobs_keep_matchers(self):
Clint Byrum85493602016-11-18 11:59:47 -08002153 files = {'ignoreme': 'ignored\n'}
2154
2155 change = self.fake_gerrit.addFakeChange('org/project',
2156 'master',
2157 'test irrelevant-files',
2158 files=files)
2159 self.fake_gerrit.addEvent(change.getPatchsetCreatedEvent(1))
2160 self.waitUntilSettled()
2161
2162 run_jobs = set([build.name for build in self.history])
2163
2164 self.assertEqual(set(['project-test-nomatch-starts-empty',
2165 'project-test-nomatch-starts-full']), run_jobs)
2166
James E. Blairec056492016-07-22 09:45:56 -07002167 @skip("Disabled for early v3 development")
James E. Blair3c5e5b52013-04-26 11:17:03 -07002168 def test_test_config(self):
2169 "Test that we can test the config"
James E. Blairf84026c2015-12-08 16:11:46 -08002170 self.sched.testConfig(self.config.get('zuul', 'tenant_config'),
Joshua Hesketh352264b2015-08-11 23:42:08 +10002171 self.connections)
James E. Blair1f4c2bb2013-04-26 08:40:46 -07002172
James E. Blairc8a1e052014-02-25 09:29:26 -08002173 def test_queue_names(self):
2174 "Test shared change queue names"
Paul Belanger8e68fc22017-02-06 16:24:49 -05002175 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07002176 (trusted, project1) = tenant.getProject('org/project1')
2177 (trusted, project2) = tenant.getProject('org/project2')
Paul Belanger8e68fc22017-02-06 16:24:49 -05002178 q1 = tenant.layout.pipelines['gate'].getQueue(project1)
2179 q2 = tenant.layout.pipelines['gate'].getQueue(project2)
2180 self.assertEqual(q1.name, 'integrated')
2181 self.assertEqual(q2.name, 'integrated')
James E. Blairc8a1e052014-02-25 09:29:26 -08002182
James E. Blair64ed6f22013-07-10 14:07:23 -07002183 def test_queue_precedence(self):
2184 "Test that queue precedence works"
2185
2186 self.gearman_server.hold_jobs_in_queue = True
Paul Belanger174a8272017-03-14 13:20:10 -04002187 self.executor_server.hold_jobs_in_build = True
James E. Blair64ed6f22013-07-10 14:07:23 -07002188 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2189 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
James E. Blair8b5408c2016-08-08 15:37:46 -07002190 A.addApproval('code-review', 2)
2191 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair64ed6f22013-07-10 14:07:23 -07002192
2193 self.waitUntilSettled()
2194 self.gearman_server.hold_jobs_in_queue = False
2195 self.gearman_server.release()
2196 self.waitUntilSettled()
2197
James E. Blair8de58bd2013-07-18 16:23:33 -07002198 # Run one build at a time to ensure non-race order:
James E. Blairb8c16472015-05-05 14:55:26 -07002199 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04002200 self.executor_server.hold_jobs_in_build = False
James E. Blair8de58bd2013-07-18 16:23:33 -07002201 self.waitUntilSettled()
2202
James E. Blair64ed6f22013-07-10 14:07:23 -07002203 self.log.debug(self.history)
2204 self.assertEqual(self.history[0].pipeline, 'gate')
2205 self.assertEqual(self.history[1].pipeline, 'check')
2206 self.assertEqual(self.history[2].pipeline, 'gate')
2207 self.assertEqual(self.history[3].pipeline, 'gate')
2208 self.assertEqual(self.history[4].pipeline, 'check')
2209 self.assertEqual(self.history[5].pipeline, 'check')
2210
Clark Boylana5edbe42014-06-03 16:39:10 -07002211 def test_json_status(self):
James E. Blair1843a552013-07-03 14:19:52 -07002212 "Test that we can retrieve JSON status info"
Paul Belanger174a8272017-03-14 13:20:10 -04002213 self.executor_server.hold_jobs_in_build = True
James E. Blair1843a552013-07-03 14:19:52 -07002214 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002215 A.addApproval('code-review', 2)
2216 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair1843a552013-07-03 14:19:52 -07002217 self.waitUntilSettled()
2218
Paul Belanger174a8272017-03-14 13:20:10 -04002219 self.executor_server.release('project-merge')
James E. Blairb7273ef2016-04-19 08:58:51 -07002220 self.waitUntilSettled()
2221
James E. Blair1843a552013-07-03 14:19:52 -07002222 port = self.webapp.server.socket.getsockname()[1]
2223
Adam Gandelman77a12c72017-02-03 17:43:43 -08002224 req = urllib.request.Request(
2225 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002226 f = urllib.request.urlopen(req)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002227 headers = f.info()
2228 self.assertIn('Content-Length', headers)
2229 self.assertIn('Content-Type', headers)
Sachi Kingdc963fc2016-03-23 16:00:33 +11002230 self.assertIsNotNone(re.match('^application/json(; charset=UTF-8)?$',
2231 headers['Content-Type']))
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002232 self.assertIn('Access-Control-Allow-Origin', headers)
2233 self.assertIn('Cache-Control', headers)
Clark Boylanaa4f2e72014-06-03 21:22:40 -07002234 self.assertIn('Last-Modified', headers)
Timo Tijhof0ebd2932015-04-02 12:11:21 +01002235 self.assertIn('Expires', headers)
James E. Blair1843a552013-07-03 14:19:52 -07002236 data = f.read()
2237
Paul Belanger174a8272017-03-14 13:20:10 -04002238 self.executor_server.hold_jobs_in_build = False
2239 self.executor_server.release()
James E. Blair1843a552013-07-03 14:19:52 -07002240 self.waitUntilSettled()
2241
2242 data = json.loads(data)
James E. Blairb7273ef2016-04-19 08:58:51 -07002243 status_jobs = []
James E. Blair1843a552013-07-03 14:19:52 -07002244 for p in data['pipelines']:
2245 for q in p['change_queues']:
James E. Blairbfb8e042014-12-30 17:01:44 -08002246 if p['name'] in ['gate', 'conflict']:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002247 self.assertEqual(q['window'], 20)
2248 else:
2249 self.assertEqual(q['window'], 0)
James E. Blair1843a552013-07-03 14:19:52 -07002250 for head in q['heads']:
2251 for change in head:
Clark Boylanaf2476f2014-01-23 14:47:36 -08002252 self.assertTrue(change['active'])
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002253 self.assertEqual(change['id'], '1,1')
James E. Blair1843a552013-07-03 14:19:52 -07002254 for job in change['jobs']:
James E. Blairb7273ef2016-04-19 08:58:51 -07002255 status_jobs.append(job)
2256 self.assertEqual('project-merge', status_jobs[0]['name'])
2257 self.assertEqual('https://server/job/project-merge/0/',
2258 status_jobs[0]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002259 self.assertEqual('https://server/job/project-merge/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002260 status_jobs[0]['report_url'])
James E. Blairb7273ef2016-04-19 08:58:51 -07002261 self.assertEqual('project-test1', status_jobs[1]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002262 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002263 status_jobs[1]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002264 self.assertEqual('https://server/job/project-test1/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002265 status_jobs[1]['report_url'])
2266
2267 self.assertEqual('project-test2', status_jobs[2]['name'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002268 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002269 status_jobs[2]['url'])
Adam Gandelman77a12c72017-02-03 17:43:43 -08002270 self.assertEqual('https://server/job/project-test2/0/',
James E. Blairb7273ef2016-04-19 08:58:51 -07002271 status_jobs[2]['report_url'])
James E. Blair1843a552013-07-03 14:19:52 -07002272
James E. Blaircdccd972013-07-01 12:10:22 -07002273 def test_live_reconfiguration(self):
2274 "Test that live reconfiguration works"
Paul Belanger174a8272017-03-14 13:20:10 -04002275 self.executor_server.hold_jobs_in_build = True
James E. Blaircdccd972013-07-01 12:10:22 -07002276 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002277 A.addApproval('code-review', 2)
2278 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blaircdccd972013-07-01 12:10:22 -07002279 self.waitUntilSettled()
2280
2281 self.sched.reconfigure(self.config)
James E. Blairbd963632017-02-01 09:58:14 -08002282 self.waitUntilSettled()
James E. Blaircdccd972013-07-01 12:10:22 -07002283
Paul Belanger174a8272017-03-14 13:20:10 -04002284 self.executor_server.hold_jobs_in_build = False
2285 self.executor_server.release()
James E. Blaircdccd972013-07-01 12:10:22 -07002286 self.waitUntilSettled()
Monty Taylor98f0f3e2013-07-06 16:02:31 -04002287 self.assertEqual(self.getJobFromHistory('project-merge').result,
2288 'SUCCESS')
2289 self.assertEqual(self.getJobFromHistory('project-test1').result,
2290 'SUCCESS')
2291 self.assertEqual(self.getJobFromHistory('project-test2').result,
2292 'SUCCESS')
2293 self.assertEqual(A.data['status'], 'MERGED')
2294 self.assertEqual(A.reported, 2)
James E. Blair287c06d2013-07-24 10:39:30 -07002295
James E. Blairec056492016-07-22 09:45:56 -07002296 @skip("Disabled for early v3 development")
James E. Blair6bc782d2015-07-17 16:20:21 -07002297 def test_live_reconfiguration_merge_conflict(self):
2298 # A real-world bug: a change in a gate queue has a merge
2299 # conflict and a job is added to its project while it's
2300 # sitting in the queue. The job gets added to the change and
2301 # enqueued and the change gets stuck.
2302 self.worker.registerFunction('build:project-test3')
Paul Belanger174a8272017-03-14 13:20:10 -04002303 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002304
2305 # This change is fine. It's here to stop the queue long
2306 # enough for the next change to be subject to the
2307 # reconfiguration, as well as to provide a conflict for the
2308 # next change. This change will succeed and merge.
2309 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2310 A.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002311 A.addApproval('code-review', 2)
James E. Blair6bc782d2015-07-17 16:20:21 -07002312
2313 # This change will be in merge conflict. During the
2314 # reconfiguration, we will add a job. We want to make sure
2315 # that doesn't cause it to get stuck.
2316 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
2317 B.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002318 B.addApproval('code-review', 2)
James E. Blair4eb21fa2015-07-27 14:56:47 -07002319
James E. Blair8b5408c2016-08-08 15:37:46 -07002320 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
2321 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002322
2323 self.waitUntilSettled()
2324
2325 # No jobs have run yet
2326 self.assertEqual(A.data['status'], 'NEW')
2327 self.assertEqual(A.reported, 1)
2328 self.assertEqual(B.data['status'], 'NEW')
2329 self.assertEqual(B.reported, 1)
2330 self.assertEqual(len(self.history), 0)
2331
2332 # Add the "project-test3" job.
James E. Blairf84026c2015-12-08 16:11:46 -08002333 self.updateConfigLayout(
2334 'tests/fixtures/layout-live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002335 self.sched.reconfigure(self.config)
2336 self.waitUntilSettled()
2337
Paul Belanger174a8272017-03-14 13:20:10 -04002338 self.executor_server.hold_jobs_in_build = False
2339 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002340 self.waitUntilSettled()
2341
2342 self.assertEqual(A.data['status'], 'MERGED')
2343 self.assertEqual(A.reported, 2)
2344 self.assertEqual(B.data['status'], 'NEW')
2345 self.assertEqual(B.reported, 2)
2346 self.assertEqual(self.getJobFromHistory('project-merge').result,
2347 'SUCCESS')
2348 self.assertEqual(self.getJobFromHistory('project-test1').result,
2349 'SUCCESS')
2350 self.assertEqual(self.getJobFromHistory('project-test2').result,
2351 'SUCCESS')
2352 self.assertEqual(self.getJobFromHistory('project-test3').result,
2353 'SUCCESS')
2354 self.assertEqual(len(self.history), 4)
2355
James E. Blairec056492016-07-22 09:45:56 -07002356 @skip("Disabled for early v3 development")
James E. Blair400e8fd2015-07-30 17:44:45 -07002357 def test_live_reconfiguration_failed_root(self):
James E. Blair6bc782d2015-07-17 16:20:21 -07002358 # An extrapolation of test_live_reconfiguration_merge_conflict
2359 # that tests a job added to a job tree with a failed root does
2360 # not run.
2361 self.worker.registerFunction('build:project-test3')
Paul Belanger174a8272017-03-14 13:20:10 -04002362 self.executor_server.hold_jobs_in_build = True
James E. Blair6bc782d2015-07-17 16:20:21 -07002363
2364 # This change is fine. It's here to stop the queue long
2365 # enough for the next change to be subject to the
2366 # reconfiguration. This change will succeed and merge.
2367 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2368 A.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002369 A.addApproval('code-review', 2)
2370 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002371 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002372 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002373 self.waitUntilSettled()
2374
2375 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
Paul Belanger174a8272017-03-14 13:20:10 -04002376 self.executor_server.failJob('project-merge', B)
James E. Blair8b5408c2016-08-08 15:37:46 -07002377 B.addApproval('code-review', 2)
2378 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair6bc782d2015-07-17 16:20:21 -07002379 self.waitUntilSettled()
2380
Paul Belanger174a8272017-03-14 13:20:10 -04002381 self.executor_server.release('.*-merge')
James E. Blair6bc782d2015-07-17 16:20:21 -07002382 self.waitUntilSettled()
2383
2384 # Both -merge jobs have run, but no others.
2385 self.assertEqual(A.data['status'], 'NEW')
2386 self.assertEqual(A.reported, 1)
2387 self.assertEqual(B.data['status'], 'NEW')
2388 self.assertEqual(B.reported, 1)
2389 self.assertEqual(self.history[0].result, 'SUCCESS')
2390 self.assertEqual(self.history[0].name, 'project-merge')
2391 self.assertEqual(self.history[1].result, 'FAILURE')
2392 self.assertEqual(self.history[1].name, 'project-merge')
2393 self.assertEqual(len(self.history), 2)
2394
2395 # Add the "project-test3" job.
James E. Blairf84026c2015-12-08 16:11:46 -08002396 self.updateConfigLayout(
2397 'tests/fixtures/layout-live-reconfiguration-add-job.yaml')
James E. Blair6bc782d2015-07-17 16:20:21 -07002398 self.sched.reconfigure(self.config)
2399 self.waitUntilSettled()
2400
Paul Belanger174a8272017-03-14 13:20:10 -04002401 self.executor_server.hold_jobs_in_build = False
2402 self.executor_server.release()
James E. Blair6bc782d2015-07-17 16:20:21 -07002403 self.waitUntilSettled()
2404
2405 self.assertEqual(A.data['status'], 'MERGED')
2406 self.assertEqual(A.reported, 2)
2407 self.assertEqual(B.data['status'], 'NEW')
2408 self.assertEqual(B.reported, 2)
2409 self.assertEqual(self.history[0].result, 'SUCCESS')
2410 self.assertEqual(self.history[0].name, 'project-merge')
2411 self.assertEqual(self.history[1].result, 'FAILURE')
2412 self.assertEqual(self.history[1].name, 'project-merge')
2413 self.assertEqual(self.history[2].result, 'SUCCESS')
2414 self.assertEqual(self.history[3].result, 'SUCCESS')
2415 self.assertEqual(self.history[4].result, 'SUCCESS')
2416 self.assertEqual(len(self.history), 5)
2417
James E. Blairec056492016-07-22 09:45:56 -07002418 @skip("Disabled for early v3 development")
James E. Blair400e8fd2015-07-30 17:44:45 -07002419 def test_live_reconfiguration_failed_job(self):
2420 # Test that a change with a removed failing job does not
2421 # disrupt reconfiguration. If a change has a failed job and
2422 # that job is removed during a reconfiguration, we observed a
2423 # bug where the code to re-set build statuses would run on
2424 # that build and raise an exception because the job no longer
2425 # existed.
Paul Belanger174a8272017-03-14 13:20:10 -04002426 self.executor_server.hold_jobs_in_build = True
James E. Blair400e8fd2015-07-30 17:44:45 -07002427
2428 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2429
2430 # This change will fail and later be removed by the reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002431 self.executor_server.failJob('project-test1', A)
James E. Blair400e8fd2015-07-30 17:44:45 -07002432
2433 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2434 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002435 self.executor_server.release('.*-merge')
James E. Blair400e8fd2015-07-30 17:44:45 -07002436 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002437 self.executor_server.release('project-test1')
James E. Blair400e8fd2015-07-30 17:44:45 -07002438 self.waitUntilSettled()
2439
2440 self.assertEqual(A.data['status'], 'NEW')
2441 self.assertEqual(A.reported, 0)
2442
2443 self.assertEqual(self.getJobFromHistory('project-merge').result,
2444 'SUCCESS')
2445 self.assertEqual(self.getJobFromHistory('project-test1').result,
2446 'FAILURE')
2447 self.assertEqual(len(self.history), 2)
2448
2449 # Remove the test1 job.
James E. Blairf84026c2015-12-08 16:11:46 -08002450 self.updateConfigLayout(
2451 'tests/fixtures/layout-live-reconfiguration-failed-job.yaml')
James E. Blair400e8fd2015-07-30 17:44:45 -07002452 self.sched.reconfigure(self.config)
2453 self.waitUntilSettled()
2454
Paul Belanger174a8272017-03-14 13:20:10 -04002455 self.executor_server.hold_jobs_in_build = False
2456 self.executor_server.release()
James E. Blair400e8fd2015-07-30 17:44:45 -07002457 self.waitUntilSettled()
2458
2459 self.assertEqual(self.getJobFromHistory('project-test2').result,
2460 'SUCCESS')
2461 self.assertEqual(self.getJobFromHistory('project-testfile').result,
2462 'SUCCESS')
2463 self.assertEqual(len(self.history), 4)
2464
2465 self.assertEqual(A.data['status'], 'NEW')
2466 self.assertEqual(A.reported, 1)
2467 self.assertIn('Build succeeded', A.messages[0])
2468 # Ensure the removed job was not included in the report.
2469 self.assertNotIn('project-test1', A.messages[0])
2470
James E. Blairec056492016-07-22 09:45:56 -07002471 @skip("Disabled for early v3 development")
James E. Blairfe707d12015-08-05 15:18:15 -07002472 def test_live_reconfiguration_shared_queue(self):
2473 # Test that a change with a failing job which was removed from
2474 # this project but otherwise still exists in the system does
2475 # not disrupt reconfiguration.
2476
Paul Belanger174a8272017-03-14 13:20:10 -04002477 self.executor_server.hold_jobs_in_build = True
James E. Blairfe707d12015-08-05 15:18:15 -07002478
2479 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2480
Paul Belanger174a8272017-03-14 13:20:10 -04002481 self.executor_server.failJob('project1-project2-integration', A)
James E. Blairfe707d12015-08-05 15:18:15 -07002482
2483 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2484 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002485 self.executor_server.release('.*-merge')
James E. Blairfe707d12015-08-05 15:18:15 -07002486 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002487 self.executor_server.release('project1-project2-integration')
James E. Blairfe707d12015-08-05 15:18:15 -07002488 self.waitUntilSettled()
2489
2490 self.assertEqual(A.data['status'], 'NEW')
2491 self.assertEqual(A.reported, 0)
2492
2493 self.assertEqual(self.getJobFromHistory('project1-merge').result,
2494 'SUCCESS')
2495 self.assertEqual(self.getJobFromHistory(
2496 'project1-project2-integration').result, 'FAILURE')
2497 self.assertEqual(len(self.history), 2)
2498
2499 # Remove the integration job.
James E. Blairf84026c2015-12-08 16:11:46 -08002500 self.updateConfigLayout(
2501 'tests/fixtures/layout-live-reconfiguration-shared-queue.yaml')
James E. Blairfe707d12015-08-05 15:18:15 -07002502 self.sched.reconfigure(self.config)
2503 self.waitUntilSettled()
2504
Paul Belanger174a8272017-03-14 13:20:10 -04002505 self.executor_server.hold_jobs_in_build = False
2506 self.executor_server.release()
James E. Blairfe707d12015-08-05 15:18:15 -07002507 self.waitUntilSettled()
2508
2509 self.assertEqual(self.getJobFromHistory('project1-merge').result,
2510 'SUCCESS')
2511 self.assertEqual(self.getJobFromHistory('project1-test1').result,
2512 'SUCCESS')
2513 self.assertEqual(self.getJobFromHistory('project1-test2').result,
2514 'SUCCESS')
2515 self.assertEqual(self.getJobFromHistory(
2516 'project1-project2-integration').result, 'FAILURE')
2517 self.assertEqual(len(self.history), 4)
2518
2519 self.assertEqual(A.data['status'], 'NEW')
2520 self.assertEqual(A.reported, 1)
2521 self.assertIn('Build succeeded', A.messages[0])
2522 # Ensure the removed job was not included in the report.
2523 self.assertNotIn('project1-project2-integration', A.messages[0])
2524
James E. Blairec056492016-07-22 09:45:56 -07002525 @skip("Disabled for early v3 development")
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002526 def test_double_live_reconfiguration_shared_queue(self):
2527 # This was a real-world regression. A change is added to
2528 # gate; a reconfigure happens, a second change which depends
2529 # on the first is added, and a second reconfiguration happens.
2530 # Ensure that both changes merge.
2531
2532 # A failure may indicate incorrect caching or cleaning up of
2533 # references during a reconfiguration.
Paul Belanger174a8272017-03-14 13:20:10 -04002534 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002535
2536 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2537 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2538 B.setDependsOn(A, 1)
James E. Blair8b5408c2016-08-08 15:37:46 -07002539 A.addApproval('code-review', 2)
2540 B.addApproval('code-review', 2)
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002541
2542 # Add the parent change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002543 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002544 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002545 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002546 self.waitUntilSettled()
2547
2548 # Reconfigure (with only one change in the pipeline).
2549 self.sched.reconfigure(self.config)
2550 self.waitUntilSettled()
2551
2552 # Add the child change.
James E. Blair8b5408c2016-08-08 15:37:46 -07002553 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002554 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002555 self.executor_server.release('.*-merge')
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002556 self.waitUntilSettled()
2557
2558 # Reconfigure (with both in the pipeline).
2559 self.sched.reconfigure(self.config)
2560 self.waitUntilSettled()
2561
Paul Belanger174a8272017-03-14 13:20:10 -04002562 self.executor_server.hold_jobs_in_build = False
2563 self.executor_server.release()
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11002564 self.waitUntilSettled()
2565
2566 self.assertEqual(len(self.history), 8)
2567
2568 self.assertEqual(A.data['status'], 'MERGED')
2569 self.assertEqual(A.reported, 2)
2570 self.assertEqual(B.data['status'], 'MERGED')
2571 self.assertEqual(B.reported, 2)
2572
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002573 def test_live_reconfiguration_del_project(self):
2574 # Test project deletion from layout
2575 # while changes are enqueued
2576
Paul Belanger174a8272017-03-14 13:20:10 -04002577 self.executor_server.hold_jobs_in_build = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002578 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2579 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
2580 C = self.fake_gerrit.addFakeChange('org/project1', 'master', 'C')
2581
2582 # A Depends-On: B
2583 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
2584 A.subject, B.data['id'])
James E. Blair8b5408c2016-08-08 15:37:46 -07002585 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002586
2587 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2588 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
2589 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002590 self.executor_server.release('.*-merge')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002591 self.waitUntilSettled()
2592 self.assertEqual(len(self.builds), 5)
2593
2594 # This layout defines only org/project, not org/project1
James E. Blair31cb3e82017-04-20 13:08:56 -07002595 self.commitConfigUpdate(
2596 'common-config',
2597 'layouts/live-reconfiguration-del-project.yaml')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002598 self.sched.reconfigure(self.config)
2599 self.waitUntilSettled()
2600
2601 # Builds for C aborted, builds for A succeed,
2602 # and have change B applied ahead
Clint Byrum0149ada2017-04-04 12:22:01 -07002603 job_c = self.getJobFromHistory('project-test1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002604 self.assertEqual(job_c.changes, '3,1')
2605 self.assertEqual(job_c.result, 'ABORTED')
2606
Paul Belanger174a8272017-03-14 13:20:10 -04002607 self.executor_server.hold_jobs_in_build = False
2608 self.executor_server.release()
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002609 self.waitUntilSettled()
2610
Clint Byrum0149ada2017-04-04 12:22:01 -07002611 self.assertEqual(
2612 self.getJobFromHistory('project-test1', 'org/project').changes,
2613 '2,1 1,1')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002614
2615 self.assertEqual(A.data['status'], 'NEW')
2616 self.assertEqual(B.data['status'], 'NEW')
2617 self.assertEqual(C.data['status'], 'NEW')
2618 self.assertEqual(A.reported, 1)
2619 self.assertEqual(B.reported, 0)
2620 self.assertEqual(C.reported, 0)
2621
Clint Byrum0149ada2017-04-04 12:22:01 -07002622 tenant = self.sched.abide.tenants.get('tenant-one')
2623 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00002624 self.assertIn('Build succeeded', A.messages[0])
2625
James E. Blairec056492016-07-22 09:45:56 -07002626 @skip("Disabled for early v3 development")
James E. Blair287c06d2013-07-24 10:39:30 -07002627 def test_delayed_repo_init(self):
James E. Blairf84026c2015-12-08 16:11:46 -08002628 self.updateConfigLayout(
2629 'tests/fixtures/layout-delayed-repo-init.yaml')
James E. Blair287c06d2013-07-24 10:39:30 -07002630 self.sched.reconfigure(self.config)
2631
2632 self.init_repo("org/new-project")
2633 A = self.fake_gerrit.addFakeChange('org/new-project', 'master', 'A')
2634
James E. Blair8b5408c2016-08-08 15:37:46 -07002635 A.addApproval('code-review', 2)
2636 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair287c06d2013-07-24 10:39:30 -07002637 self.waitUntilSettled()
2638 self.assertEqual(self.getJobFromHistory('project-merge').result,
2639 'SUCCESS')
2640 self.assertEqual(self.getJobFromHistory('project-test1').result,
2641 'SUCCESS')
2642 self.assertEqual(self.getJobFromHistory('project-test2').result,
2643 'SUCCESS')
2644 self.assertEqual(A.data['status'], 'MERGED')
2645 self.assertEqual(A.reported, 2)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002646
James E. Blair9ea70072017-04-19 16:05:30 -07002647 @simple_layout('layouts/repo-deleted.yaml')
Clark Boylan6dbbc482013-10-18 10:57:31 -07002648 def test_repo_deleted(self):
Clark Boylan6dbbc482013-10-18 10:57:31 -07002649 self.init_repo("org/delete-project")
2650 A = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'A')
2651
James E. Blair8b5408c2016-08-08 15:37:46 -07002652 A.addApproval('code-review', 2)
2653 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002654 self.waitUntilSettled()
2655 self.assertEqual(self.getJobFromHistory('project-merge').result,
2656 'SUCCESS')
2657 self.assertEqual(self.getJobFromHistory('project-test1').result,
2658 'SUCCESS')
2659 self.assertEqual(self.getJobFromHistory('project-test2').result,
2660 'SUCCESS')
2661 self.assertEqual(A.data['status'], 'MERGED')
2662 self.assertEqual(A.reported, 2)
2663
2664 # Delete org/new-project zuul repo. Should be recloned.
James E. Blair8c1be532017-02-07 14:04:12 -08002665 p = 'org/delete-project'
Monty Taylord642d852017-02-23 14:05:42 -05002666 if os.path.exists(os.path.join(self.merger_src_root, p)):
2667 shutil.rmtree(os.path.join(self.merger_src_root, p))
Paul Belanger174a8272017-03-14 13:20:10 -04002668 if os.path.exists(os.path.join(self.executor_src_root, p)):
2669 shutil.rmtree(os.path.join(self.executor_src_root, p))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002670
2671 B = self.fake_gerrit.addFakeChange('org/delete-project', 'master', 'B')
2672
James E. Blair8b5408c2016-08-08 15:37:46 -07002673 B.addApproval('code-review', 2)
2674 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Clark Boylan6dbbc482013-10-18 10:57:31 -07002675 self.waitUntilSettled()
2676 self.assertEqual(self.getJobFromHistory('project-merge').result,
2677 'SUCCESS')
2678 self.assertEqual(self.getJobFromHistory('project-test1').result,
2679 'SUCCESS')
2680 self.assertEqual(self.getJobFromHistory('project-test2').result,
2681 'SUCCESS')
2682 self.assertEqual(B.data['status'], 'MERGED')
2683 self.assertEqual(B.reported, 2)
2684
James E. Blaire68d43f2017-04-19 14:03:30 -07002685 @simple_layout('layouts/tags.yaml')
James E. Blair456f2fb2016-02-09 09:29:33 -08002686 def test_tags(self):
2687 "Test job tags"
James E. Blair456f2fb2016-02-09 09:29:33 -08002688 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
2689 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
2690 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2691 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
2692 self.waitUntilSettled()
2693
James E. Blaire68d43f2017-04-19 14:03:30 -07002694 self.assertEqual(len(self.history), 2)
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002695
2696 results = {self.getJobFromHistory('merge',
2697 project='org/project1').uuid: 'extratag merge',
2698 self.getJobFromHistory('merge',
2699 project='org/project2').uuid: 'merge'}
James E. Blair456f2fb2016-02-09 09:29:33 -08002700
2701 for build in self.history:
Cullen Taylor3aa6d472017-03-01 15:22:09 -06002702 self.assertEqual(results.get(build.uuid, ''),
2703 build.parameters['vars']['zuul'].get('tags'))
James E. Blair456f2fb2016-02-09 09:29:33 -08002704
James E. Blair63bb0ef2013-07-29 17:14:51 -07002705 def test_timer(self):
2706 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002707 # This test can not use simple_layout because it must start
2708 # with a configuration which does not include a
2709 # timer-triggered job so that we have an opportunity to set
2710 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002711 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002712 self.commitConfigUpdate('common-config', 'layouts/timer.yaml')
James E. Blair63bb0ef2013-07-29 17:14:51 -07002713 self.sched.reconfigure(self.config)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002714
Clark Boylan3ee090a2014-04-03 20:55:09 -07002715 # The pipeline triggers every second, so we should have seen
2716 # several by now.
2717 time.sleep(5)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002718 self.waitUntilSettled()
Clark Boylan3ee090a2014-04-03 20:55:09 -07002719
2720 self.assertEqual(len(self.builds), 2)
2721
James E. Blair63bb0ef2013-07-29 17:14:51 -07002722 port = self.webapp.server.socket.getsockname()[1]
2723
Clint Byrum5e729e92017-02-08 06:34:57 -08002724 req = urllib.request.Request(
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002725 "http://localhost:%s/tenant-one/status" % port)
Morgan Fainberg293f7f82016-05-30 14:01:22 -07002726 f = urllib.request.urlopen(req)
James E. Blair63bb0ef2013-07-29 17:14:51 -07002727 data = f.read()
2728
Paul Belanger174a8272017-03-14 13:20:10 -04002729 self.executor_server.hold_jobs_in_build = False
Clark Boylan3ee090a2014-04-03 20:55:09 -07002730 # Stop queuing timer triggered jobs so that the assertions
2731 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002732 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002733 self.sched.reconfigure(self.config)
Paul Belanger174a8272017-03-14 13:20:10 -04002734 self.executor_server.release()
James E. Blair63bb0ef2013-07-29 17:14:51 -07002735 self.waitUntilSettled()
2736
2737 self.assertEqual(self.getJobFromHistory(
2738 'project-bitrot-stable-old').result, 'SUCCESS')
2739 self.assertEqual(self.getJobFromHistory(
2740 'project-bitrot-stable-older').result, 'SUCCESS')
2741
2742 data = json.loads(data)
2743 status_jobs = set()
2744 for p in data['pipelines']:
2745 for q in p['change_queues']:
2746 for head in q['heads']:
2747 for change in head:
James E. Blair63bb0ef2013-07-29 17:14:51 -07002748 for job in change['jobs']:
2749 status_jobs.add(job['name'])
2750 self.assertIn('project-bitrot-stable-old', status_jobs)
2751 self.assertIn('project-bitrot-stable-older', status_jobs)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002752
James E. Blair4f6033c2014-03-27 15:49:09 -07002753 def test_idle(self):
2754 "Test that frequent periodic jobs work"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002755 # This test can not use simple_layout because it must start
2756 # with a configuration which does not include a
2757 # timer-triggered job so that we have an opportunity to set
2758 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002759 self.executor_server.hold_jobs_in_build = True
James E. Blair4f6033c2014-03-27 15:49:09 -07002760
Clark Boylan3ee090a2014-04-03 20:55:09 -07002761 for x in range(1, 3):
2762 # Test that timer triggers periodic jobs even across
2763 # layout config reloads.
2764 # Start timer trigger
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002765 self.commitConfigUpdate('common-config',
2766 'layouts/idle.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002767 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002768 self.waitUntilSettled()
James E. Blair4f6033c2014-03-27 15:49:09 -07002769
Clark Boylan3ee090a2014-04-03 20:55:09 -07002770 # The pipeline triggers every second, so we should have seen
2771 # several by now.
2772 time.sleep(5)
Clark Boylan3ee090a2014-04-03 20:55:09 -07002773
2774 # Stop queuing timer triggered jobs so that the assertions
2775 # below don't race against more jobs being queued.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002776 self.commitConfigUpdate('common-config',
2777 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002778 self.sched.reconfigure(self.config)
James E. Blair995fc0f2016-02-04 16:48:31 -08002779 self.waitUntilSettled()
Clint Byrum58264dc2017-02-07 21:21:22 -08002780 self.assertEqual(len(self.builds), 2,
2781 'Timer builds iteration #%d' % x)
Paul Belanger174a8272017-03-14 13:20:10 -04002782 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002783 self.waitUntilSettled()
2784 self.assertEqual(len(self.builds), 0)
2785 self.assertEqual(len(self.history), x * 2)
James E. Blair4f6033c2014-03-27 15:49:09 -07002786
James E. Blaircc324192017-04-19 14:36:08 -07002787 @simple_layout('layouts/smtp.yaml')
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002788 def test_check_smtp_pool(self):
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002789 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
2790 self.waitUntilSettled()
2791
2792 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
2793 self.waitUntilSettled()
2794
James E. Blairff80a2f2013-12-27 13:24:06 -08002795 self.assertEqual(len(self.smtp_messages), 2)
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002796
2797 # A.messages only holds what FakeGerrit places in it. Thus we
2798 # work on the knowledge of what the first message should be as
2799 # it is only configured to go to SMTP.
2800
2801 self.assertEqual('zuul@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002802 self.smtp_messages[0]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002803 self.assertEqual(['you@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002804 self.smtp_messages[0]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002805 self.assertEqual('Starting check jobs.',
James E. Blairff80a2f2013-12-27 13:24:06 -08002806 self.smtp_messages[0]['body'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002807
2808 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002809 self.smtp_messages[1]['from_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002810 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002811 self.smtp_messages[1]['to_email'])
Joshua Hesketh5fea8672013-08-19 17:32:01 +10002812 self.assertEqual(A.messages[0],
James E. Blairff80a2f2013-12-27 13:24:06 -08002813 self.smtp_messages[1]['body'])
James E. Blairad28e912013-11-27 10:43:22 -08002814
James E. Blaire5910202013-12-27 09:50:31 -08002815 def test_timer_smtp(self):
2816 "Test that a periodic job is triggered"
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002817 # This test can not use simple_layout because it must start
2818 # with a configuration which does not include a
2819 # timer-triggered job so that we have an opportunity to set
2820 # the hold flag before the first job.
Paul Belanger174a8272017-03-14 13:20:10 -04002821 self.executor_server.hold_jobs_in_build = True
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002822 self.commitConfigUpdate('common-config', 'layouts/timer-smtp.yaml')
James E. Blaire5910202013-12-27 09:50:31 -08002823 self.sched.reconfigure(self.config)
James E. Blaire5910202013-12-27 09:50:31 -08002824
Clark Boylan3ee090a2014-04-03 20:55:09 -07002825 # The pipeline triggers every second, so we should have seen
2826 # several by now.
2827 time.sleep(5)
James E. Blaire5910202013-12-27 09:50:31 -08002828 self.waitUntilSettled()
2829
Clark Boylan3ee090a2014-04-03 20:55:09 -07002830 self.assertEqual(len(self.builds), 2)
Paul Belanger174a8272017-03-14 13:20:10 -04002831 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002832 self.waitUntilSettled()
2833 self.assertEqual(len(self.history), 2)
2834
James E. Blaire5910202013-12-27 09:50:31 -08002835 self.assertEqual(self.getJobFromHistory(
2836 'project-bitrot-stable-old').result, 'SUCCESS')
2837 self.assertEqual(self.getJobFromHistory(
2838 'project-bitrot-stable-older').result, 'SUCCESS')
2839
James E. Blairff80a2f2013-12-27 13:24:06 -08002840 self.assertEqual(len(self.smtp_messages), 1)
James E. Blaire5910202013-12-27 09:50:31 -08002841
2842 # A.messages only holds what FakeGerrit places in it. Thus we
2843 # work on the knowledge of what the first message should be as
2844 # it is only configured to go to SMTP.
2845
2846 self.assertEqual('zuul_from@example.com',
James E. Blairff80a2f2013-12-27 13:24:06 -08002847 self.smtp_messages[0]['from_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002848 self.assertEqual(['alternative_me@example.com'],
James E. Blairff80a2f2013-12-27 13:24:06 -08002849 self.smtp_messages[0]['to_email'])
James E. Blaire5910202013-12-27 09:50:31 -08002850 self.assertIn('Subject: Periodic check for org/project succeeded',
James E. Blairff80a2f2013-12-27 13:24:06 -08002851 self.smtp_messages[0]['headers'])
James E. Blaire5910202013-12-27 09:50:31 -08002852
Clark Boylan3ee090a2014-04-03 20:55:09 -07002853 # Stop queuing timer triggered jobs and let any that may have
2854 # queued through so that end of test assertions pass.
James E. Blairdfdfcfc2017-04-20 10:19:20 -07002855 self.commitConfigUpdate('common-config', 'layouts/no-timer.yaml')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002856 self.sched.reconfigure(self.config)
James E. Blairf8058972014-08-15 16:09:16 -07002857 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04002858 self.executor_server.release('.*')
Clark Boylan3ee090a2014-04-03 20:55:09 -07002859 self.waitUntilSettled()
2860
Joshua Hesketh25695cb2017-03-06 12:50:04 +11002861 @skip("Disabled for early v3 development")
Evgeny Antyshevda90a502017-02-08 08:42:59 +00002862 def test_timer_sshkey(self):
2863 "Test that a periodic job can setup SSH key authentication"
2864 self.worker.hold_jobs_in_build = True
2865 self.config.set('zuul', 'layout_config',
2866 'tests/fixtures/layout-timer.yaml')
2867 self.sched.reconfigure(self.config)
2868 self.registerJobs()
2869
2870 # The pipeline triggers every second, so we should have seen
2871 # several by now.
2872 time.sleep(5)
2873 self.waitUntilSettled()
2874
2875 self.assertEqual(len(self.builds), 2)
2876
2877 ssh_wrapper = os.path.join(self.git_root, ".ssh_wrapper_gerrit")
2878 self.assertTrue(os.path.isfile(ssh_wrapper))
2879 with open(ssh_wrapper) as f:
2880 ssh_wrapper_content = f.read()
2881 self.assertIn("fake_id_rsa", ssh_wrapper_content)
2882 # In the unit tests Merger runs in the same process,
2883 # so we see its' environment variables
2884 self.assertEqual(os.environ['GIT_SSH'], ssh_wrapper)
2885
2886 self.worker.release('.*')
2887 self.waitUntilSettled()
2888 self.assertEqual(len(self.history), 2)
2889
2890 self.assertEqual(self.getJobFromHistory(
2891 'project-bitrot-stable-old').result, 'SUCCESS')
2892 self.assertEqual(self.getJobFromHistory(
2893 'project-bitrot-stable-older').result, 'SUCCESS')
2894
2895 # Stop queuing timer triggered jobs and let any that may have
2896 # queued through so that end of test assertions pass.
2897 self.config.set('zuul', 'layout_config',
2898 'tests/fixtures/layout-no-timer.yaml')
2899 self.sched.reconfigure(self.config)
2900 self.registerJobs()
2901 self.waitUntilSettled()
2902 self.worker.release('.*')
2903 self.waitUntilSettled()
2904
James E. Blair91e34592015-07-31 16:45:59 -07002905 def test_client_enqueue_change(self):
James E. Blairad28e912013-11-27 10:43:22 -08002906 "Test that the RPC client can enqueue a change"
2907 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07002908 A.addApproval('code-review', 2)
2909 A.addApproval('approved', 1)
James E. Blairad28e912013-11-27 10:43:22 -08002910
2911 client = zuul.rpcclient.RPCClient('127.0.0.1',
2912 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002913 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04002914 r = client.enqueue(tenant='tenant-one',
2915 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002916 project='org/project',
2917 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002918 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002919 self.waitUntilSettled()
2920 self.assertEqual(self.getJobFromHistory('project-merge').result,
2921 'SUCCESS')
2922 self.assertEqual(self.getJobFromHistory('project-test1').result,
2923 'SUCCESS')
2924 self.assertEqual(self.getJobFromHistory('project-test2').result,
2925 'SUCCESS')
2926 self.assertEqual(A.data['status'], 'MERGED')
2927 self.assertEqual(A.reported, 2)
2928 self.assertEqual(r, True)
2929
James E. Blair91e34592015-07-31 16:45:59 -07002930 def test_client_enqueue_ref(self):
2931 "Test that the RPC client can enqueue a ref"
2932
2933 client = zuul.rpcclient.RPCClient('127.0.0.1',
2934 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002935 self.addCleanup(client.shutdown)
James E. Blair91e34592015-07-31 16:45:59 -07002936 r = client.enqueue_ref(
Paul Belangerbaca3132016-11-04 12:49:54 -04002937 tenant='tenant-one',
James E. Blair91e34592015-07-31 16:45:59 -07002938 pipeline='post',
2939 project='org/project',
2940 trigger='gerrit',
2941 ref='master',
2942 oldrev='90f173846e3af9154517b88543ffbd1691f31366',
2943 newrev='d479a0bfcb34da57a31adb2a595c0cf687812543')
2944 self.waitUntilSettled()
2945 job_names = [x.name for x in self.history]
2946 self.assertEqual(len(self.history), 1)
2947 self.assertIn('project-post', job_names)
2948 self.assertEqual(r, True)
2949
James E. Blairad28e912013-11-27 10:43:22 -08002950 def test_client_enqueue_negative(self):
2951 "Test that the RPC client returns errors"
2952 client = zuul.rpcclient.RPCClient('127.0.0.1',
2953 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07002954 self.addCleanup(client.shutdown)
James E. Blairad28e912013-11-27 10:43:22 -08002955 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
Paul Belangerbaca3132016-11-04 12:49:54 -04002956 "Invalid tenant"):
2957 r = client.enqueue(tenant='tenant-foo',
2958 pipeline='gate',
2959 project='org/project',
2960 trigger='gerrit',
2961 change='1,1')
Paul Belangerbaca3132016-11-04 12:49:54 -04002962 self.assertEqual(r, False)
2963
2964 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
James E. Blairad28e912013-11-27 10:43:22 -08002965 "Invalid project"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002966 r = client.enqueue(tenant='tenant-one',
2967 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002968 project='project-does-not-exist',
2969 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002970 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002971 self.assertEqual(r, False)
2972
2973 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2974 "Invalid pipeline"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002975 r = client.enqueue(tenant='tenant-one',
2976 pipeline='pipeline-does-not-exist',
James E. Blairad28e912013-11-27 10:43:22 -08002977 project='org/project',
2978 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002979 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002980 self.assertEqual(r, False)
2981
2982 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2983 "Invalid trigger"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002984 r = client.enqueue(tenant='tenant-one',
2985 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002986 project='org/project',
2987 trigger='trigger-does-not-exist',
James E. Blair36658cf2013-12-06 17:53:48 -08002988 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002989 self.assertEqual(r, False)
2990
2991 with testtools.ExpectedException(zuul.rpcclient.RPCFailure,
2992 "Invalid change"):
Paul Belangerbaca3132016-11-04 12:49:54 -04002993 r = client.enqueue(tenant='tenant-one',
2994 pipeline='gate',
James E. Blairad28e912013-11-27 10:43:22 -08002995 project='org/project',
2996 trigger='gerrit',
James E. Blair36658cf2013-12-06 17:53:48 -08002997 change='1,1')
James E. Blairad28e912013-11-27 10:43:22 -08002998 self.assertEqual(r, False)
2999
3000 self.waitUntilSettled()
3001 self.assertEqual(len(self.history), 0)
3002 self.assertEqual(len(self.builds), 0)
James E. Blair36658cf2013-12-06 17:53:48 -08003003
3004 def test_client_promote(self):
3005 "Test that the RPC client can promote a change"
Paul Belanger174a8272017-03-14 13:20:10 -04003006 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003007 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3008 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3009 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003010 A.addApproval('code-review', 2)
3011 B.addApproval('code-review', 2)
3012 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003013
James E. Blair8b5408c2016-08-08 15:37:46 -07003014 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3015 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3016 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003017
3018 self.waitUntilSettled()
3019
Paul Belangerbaca3132016-11-04 12:49:54 -04003020 tenant = self.sched.abide.tenants.get('tenant-one')
3021 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003022 enqueue_times = {}
3023 for item in items:
3024 enqueue_times[str(item.change)] = item.enqueue_time
3025
James E. Blair36658cf2013-12-06 17:53:48 -08003026 client = zuul.rpcclient.RPCClient('127.0.0.1',
3027 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003028 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003029 r = client.promote(tenant='tenant-one',
3030 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003031 change_ids=['2,1', '3,1'])
3032
Sean Daguef39b9ca2014-01-10 21:34:35 -05003033 # ensure that enqueue times are durable
Paul Belangerbaca3132016-11-04 12:49:54 -04003034 items = tenant.layout.pipelines['gate'].getAllItems()
Sean Daguef39b9ca2014-01-10 21:34:35 -05003035 for item in items:
3036 self.assertEqual(
3037 enqueue_times[str(item.change)], item.enqueue_time)
3038
James E. Blair78acec92014-02-06 07:11:32 -08003039 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003040 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003041 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003042 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003043 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003044 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003045 self.waitUntilSettled()
3046
3047 self.assertEqual(len(self.builds), 6)
3048 self.assertEqual(self.builds[0].name, 'project-test1')
3049 self.assertEqual(self.builds[1].name, 'project-test2')
3050 self.assertEqual(self.builds[2].name, 'project-test1')
3051 self.assertEqual(self.builds[3].name, 'project-test2')
3052 self.assertEqual(self.builds[4].name, 'project-test1')
3053 self.assertEqual(self.builds[5].name, 'project-test2')
3054
Paul Belangerbaca3132016-11-04 12:49:54 -04003055 self.assertTrue(self.builds[0].hasChanges(B))
3056 self.assertFalse(self.builds[0].hasChanges(A))
3057 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003058
Paul Belangerbaca3132016-11-04 12:49:54 -04003059 self.assertTrue(self.builds[2].hasChanges(B))
3060 self.assertTrue(self.builds[2].hasChanges(C))
3061 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003062
Paul Belangerbaca3132016-11-04 12:49:54 -04003063 self.assertTrue(self.builds[4].hasChanges(B))
3064 self.assertTrue(self.builds[4].hasChanges(C))
3065 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003066
Paul Belanger174a8272017-03-14 13:20:10 -04003067 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003068 self.waitUntilSettled()
3069
3070 self.assertEqual(A.data['status'], 'MERGED')
3071 self.assertEqual(A.reported, 2)
3072 self.assertEqual(B.data['status'], 'MERGED')
3073 self.assertEqual(B.reported, 2)
3074 self.assertEqual(C.data['status'], 'MERGED')
3075 self.assertEqual(C.reported, 2)
3076
James E. Blair36658cf2013-12-06 17:53:48 -08003077 self.assertEqual(r, True)
3078
3079 def test_client_promote_dependent(self):
3080 "Test that the RPC client can promote a dependent change"
3081 # C (depends on B) -> B -> A ; then promote C to get:
3082 # A -> C (depends on B) -> B
Paul Belanger174a8272017-03-14 13:20:10 -04003083 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003084 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3085 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3086 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3087
3088 C.setDependsOn(B, 1)
3089
James E. Blair8b5408c2016-08-08 15:37:46 -07003090 A.addApproval('code-review', 2)
3091 B.addApproval('code-review', 2)
3092 C.addApproval('code-review', 2)
James E. Blair36658cf2013-12-06 17:53:48 -08003093
James E. Blair8b5408c2016-08-08 15:37:46 -07003094 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3095 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3096 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003097
3098 self.waitUntilSettled()
3099
3100 client = zuul.rpcclient.RPCClient('127.0.0.1',
3101 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003102 self.addCleanup(client.shutdown)
Paul Belangerbaca3132016-11-04 12:49:54 -04003103 r = client.promote(tenant='tenant-one',
3104 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003105 change_ids=['3,1'])
3106
James E. Blair78acec92014-02-06 07:11:32 -08003107 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003108 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003109 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003110 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003111 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003112 self.executor_server.release('.*-merge')
James E. Blair36658cf2013-12-06 17:53:48 -08003113 self.waitUntilSettled()
3114
3115 self.assertEqual(len(self.builds), 6)
3116 self.assertEqual(self.builds[0].name, 'project-test1')
3117 self.assertEqual(self.builds[1].name, 'project-test2')
3118 self.assertEqual(self.builds[2].name, 'project-test1')
3119 self.assertEqual(self.builds[3].name, 'project-test2')
3120 self.assertEqual(self.builds[4].name, 'project-test1')
3121 self.assertEqual(self.builds[5].name, 'project-test2')
3122
Paul Belangerbaca3132016-11-04 12:49:54 -04003123 self.assertTrue(self.builds[0].hasChanges(B))
3124 self.assertFalse(self.builds[0].hasChanges(A))
3125 self.assertFalse(self.builds[0].hasChanges(C))
James E. Blair36658cf2013-12-06 17:53:48 -08003126
Paul Belangerbaca3132016-11-04 12:49:54 -04003127 self.assertTrue(self.builds[2].hasChanges(B))
3128 self.assertTrue(self.builds[2].hasChanges(C))
3129 self.assertFalse(self.builds[2].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003130
Paul Belangerbaca3132016-11-04 12:49:54 -04003131 self.assertTrue(self.builds[4].hasChanges(B))
3132 self.assertTrue(self.builds[4].hasChanges(C))
3133 self.assertTrue(self.builds[4].hasChanges(A))
James E. Blair36658cf2013-12-06 17:53:48 -08003134
Paul Belanger174a8272017-03-14 13:20:10 -04003135 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003136 self.waitUntilSettled()
3137
3138 self.assertEqual(A.data['status'], 'MERGED')
3139 self.assertEqual(A.reported, 2)
3140 self.assertEqual(B.data['status'], 'MERGED')
3141 self.assertEqual(B.reported, 2)
3142 self.assertEqual(C.data['status'], 'MERGED')
3143 self.assertEqual(C.reported, 2)
3144
James E. Blair36658cf2013-12-06 17:53:48 -08003145 self.assertEqual(r, True)
3146
3147 def test_client_promote_negative(self):
3148 "Test that the RPC client returns errors for promotion"
Paul Belanger174a8272017-03-14 13:20:10 -04003149 self.executor_server.hold_jobs_in_build = True
James E. Blair36658cf2013-12-06 17:53:48 -08003150 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003151 A.addApproval('code-review', 2)
3152 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair36658cf2013-12-06 17:53:48 -08003153 self.waitUntilSettled()
3154
3155 client = zuul.rpcclient.RPCClient('127.0.0.1',
3156 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003157 self.addCleanup(client.shutdown)
James E. Blair36658cf2013-12-06 17:53:48 -08003158
3159 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003160 r = client.promote(tenant='tenant-one',
3161 pipeline='nonexistent',
James E. Blair36658cf2013-12-06 17:53:48 -08003162 change_ids=['2,1', '3,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003163 self.assertEqual(r, False)
3164
3165 with testtools.ExpectedException(zuul.rpcclient.RPCFailure):
Paul Belangerbaca3132016-11-04 12:49:54 -04003166 r = client.promote(tenant='tenant-one',
3167 pipeline='gate',
James E. Blair36658cf2013-12-06 17:53:48 -08003168 change_ids=['4,1'])
James E. Blair36658cf2013-12-06 17:53:48 -08003169 self.assertEqual(r, False)
3170
Paul Belanger174a8272017-03-14 13:20:10 -04003171 self.executor_server.hold_jobs_in_build = False
3172 self.executor_server.release()
James E. Blair36658cf2013-12-06 17:53:48 -08003173 self.waitUntilSettled()
Clark Boylan7603a372014-01-21 11:43:20 -08003174
James E. Blaircc324192017-04-19 14:36:08 -07003175 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003176 def test_queue_rate_limiting(self):
3177 "Test that DependentPipelines are rate limited with dep across window"
Paul Belanger174a8272017-03-14 13:20:10 -04003178 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003179 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3180 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3181 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3182
3183 C.setDependsOn(B, 1)
Paul Belanger174a8272017-03-14 13:20:10 -04003184 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003185
James E. Blair8b5408c2016-08-08 15:37:46 -07003186 A.addApproval('code-review', 2)
3187 B.addApproval('code-review', 2)
3188 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003189
James E. Blair8b5408c2016-08-08 15:37:46 -07003190 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3191 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3192 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003193 self.waitUntilSettled()
3194
3195 # Only A and B will have their merge jobs queued because
3196 # window is 2.
3197 self.assertEqual(len(self.builds), 2)
3198 self.assertEqual(self.builds[0].name, 'project-merge')
3199 self.assertEqual(self.builds[1].name, 'project-merge')
3200
James E. Blair732ee862017-04-21 07:49:26 -07003201 # Release the merge jobs one at a time.
3202 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003203 self.waitUntilSettled()
James E. Blair732ee862017-04-21 07:49:26 -07003204 self.builds[0].release()
Clark Boylan7603a372014-01-21 11:43:20 -08003205 self.waitUntilSettled()
3206
3207 # Only A and B will have their test jobs queued because
3208 # window is 2.
3209 self.assertEqual(len(self.builds), 4)
3210 self.assertEqual(self.builds[0].name, 'project-test1')
3211 self.assertEqual(self.builds[1].name, 'project-test2')
3212 self.assertEqual(self.builds[2].name, 'project-test1')
3213 self.assertEqual(self.builds[3].name, 'project-test2')
3214
Paul Belanger174a8272017-03-14 13:20:10 -04003215 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003216 self.waitUntilSettled()
3217
James E. Blaircc324192017-04-19 14:36:08 -07003218 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrumb01f1ca2017-04-02 10:19:52 -07003219 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003220 # A failed so window is reduced by 1 to 1.
3221 self.assertEqual(queue.window, 1)
3222 self.assertEqual(queue.window_floor, 1)
3223 self.assertEqual(A.data['status'], 'NEW')
3224
3225 # Gate is reset and only B's merge job is queued because
3226 # window shrunk to 1.
3227 self.assertEqual(len(self.builds), 1)
3228 self.assertEqual(self.builds[0].name, 'project-merge')
3229
Paul Belanger174a8272017-03-14 13:20:10 -04003230 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003231 self.waitUntilSettled()
3232
3233 # Only B's test jobs are queued because window is still 1.
3234 self.assertEqual(len(self.builds), 2)
3235 self.assertEqual(self.builds[0].name, 'project-test1')
3236 self.assertEqual(self.builds[1].name, 'project-test2')
3237
Paul Belanger174a8272017-03-14 13:20:10 -04003238 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003239 self.waitUntilSettled()
3240
3241 # B was successfully merged so window is increased to 2.
3242 self.assertEqual(queue.window, 2)
3243 self.assertEqual(queue.window_floor, 1)
3244 self.assertEqual(B.data['status'], 'MERGED')
3245
3246 # Only C is left and its merge job is queued.
3247 self.assertEqual(len(self.builds), 1)
3248 self.assertEqual(self.builds[0].name, 'project-merge')
3249
Paul Belanger174a8272017-03-14 13:20:10 -04003250 self.executor_server.release('.*-merge')
Clark Boylan7603a372014-01-21 11:43:20 -08003251 self.waitUntilSettled()
3252
3253 # After successful merge job the test jobs for C are queued.
3254 self.assertEqual(len(self.builds), 2)
3255 self.assertEqual(self.builds[0].name, 'project-test1')
3256 self.assertEqual(self.builds[1].name, 'project-test2')
3257
Paul Belanger174a8272017-03-14 13:20:10 -04003258 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003259 self.waitUntilSettled()
3260
3261 # C successfully merged so window is bumped to 3.
3262 self.assertEqual(queue.window, 3)
3263 self.assertEqual(queue.window_floor, 1)
3264 self.assertEqual(C.data['status'], 'MERGED')
3265
James E. Blaircc324192017-04-19 14:36:08 -07003266 @simple_layout('layouts/rate-limit.yaml')
Clark Boylan7603a372014-01-21 11:43:20 -08003267 def test_queue_rate_limiting_dependent(self):
3268 "Test that DependentPipelines are rate limited with dep in window"
Paul Belanger174a8272017-03-14 13:20:10 -04003269 self.executor_server.hold_jobs_in_build = True
Clark Boylan7603a372014-01-21 11:43:20 -08003270 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3271 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3272 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3273
3274 B.setDependsOn(A, 1)
3275
Paul Belanger174a8272017-03-14 13:20:10 -04003276 self.executor_server.failJob('project-test1', A)
Clark Boylan7603a372014-01-21 11:43:20 -08003277
James E. Blair8b5408c2016-08-08 15:37:46 -07003278 A.addApproval('code-review', 2)
3279 B.addApproval('code-review', 2)
3280 C.addApproval('code-review', 2)
Clark Boylan7603a372014-01-21 11:43:20 -08003281
James E. Blair8b5408c2016-08-08 15:37:46 -07003282 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3283 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3284 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Clark Boylan7603a372014-01-21 11:43:20 -08003285 self.waitUntilSettled()
3286
3287 # Only A and B will have their merge jobs queued because
3288 # window is 2.
3289 self.assertEqual(len(self.builds), 2)
3290 self.assertEqual(self.builds[0].name, 'project-merge')
3291 self.assertEqual(self.builds[1].name, 'project-merge')
3292
James E. Blairf4a5f022017-04-18 14:01:10 -07003293 self.orderedRelease(2)
Clark Boylan7603a372014-01-21 11:43:20 -08003294
3295 # Only A and B will have their test jobs queued because
3296 # window is 2.
3297 self.assertEqual(len(self.builds), 4)
3298 self.assertEqual(self.builds[0].name, 'project-test1')
3299 self.assertEqual(self.builds[1].name, 'project-test2')
3300 self.assertEqual(self.builds[2].name, 'project-test1')
3301 self.assertEqual(self.builds[3].name, 'project-test2')
3302
Paul Belanger174a8272017-03-14 13:20:10 -04003303 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003304 self.waitUntilSettled()
3305
James E. Blaircc324192017-04-19 14:36:08 -07003306 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum14ab6ca2017-04-03 10:15:10 -07003307 queue = tenant.layout.pipelines['gate'].queues[0]
Clark Boylan7603a372014-01-21 11:43:20 -08003308 # A failed so window is reduced by 1 to 1.
3309 self.assertEqual(queue.window, 1)
3310 self.assertEqual(queue.window_floor, 1)
3311 self.assertEqual(A.data['status'], 'NEW')
3312 self.assertEqual(B.data['status'], 'NEW')
3313
3314 # Gate is reset and only C's merge job is queued because
3315 # window shrunk to 1 and A and B were dequeued.
3316 self.assertEqual(len(self.builds), 1)
3317 self.assertEqual(self.builds[0].name, 'project-merge')
3318
James E. Blairf4a5f022017-04-18 14:01:10 -07003319 self.orderedRelease(1)
Clark Boylan7603a372014-01-21 11:43:20 -08003320
3321 # Only C's test jobs are queued because window is still 1.
3322 self.assertEqual(len(self.builds), 2)
3323 self.assertEqual(self.builds[0].name, 'project-test1')
3324 self.assertEqual(self.builds[1].name, 'project-test2')
3325
Paul Belanger174a8272017-03-14 13:20:10 -04003326 self.executor_server.release('project-.*')
Clark Boylan7603a372014-01-21 11:43:20 -08003327 self.waitUntilSettled()
3328
3329 # C was successfully merged so window is increased to 2.
3330 self.assertEqual(queue.window, 2)
3331 self.assertEqual(queue.window_floor, 1)
3332 self.assertEqual(C.data['status'], 'MERGED')
Joshua Heskethba8776a2014-01-12 14:35:40 +08003333
James E. Blairec056492016-07-22 09:45:56 -07003334 @skip("Disabled for early v3 development")
Joshua Heskethba8776a2014-01-12 14:35:40 +08003335 def test_worker_update_metadata(self):
3336 "Test if a worker can send back metadata about itself"
Paul Belanger174a8272017-03-14 13:20:10 -04003337 self.executor_server.hold_jobs_in_build = True
Joshua Heskethba8776a2014-01-12 14:35:40 +08003338
3339 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003340 A.addApproval('code-review', 2)
3341 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethba8776a2014-01-12 14:35:40 +08003342 self.waitUntilSettled()
3343
Paul Belanger174a8272017-03-14 13:20:10 -04003344 self.assertEqual(len(self.executor.builds), 1)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003345
3346 self.log.debug('Current builds:')
Paul Belanger174a8272017-03-14 13:20:10 -04003347 self.log.debug(self.executor.builds)
Joshua Heskethba8776a2014-01-12 14:35:40 +08003348
3349 start = time.time()
3350 while True:
3351 if time.time() - start > 10:
3352 raise Exception("Timeout waiting for gearman server to report "
3353 + "back to the client")
Paul Belanger174a8272017-03-14 13:20:10 -04003354 build = self.executor.builds.values()[0]
Joshua Heskethba8776a2014-01-12 14:35:40 +08003355 if build.worker.name == "My Worker":
3356 break
3357 else:
3358 time.sleep(0)
3359
3360 self.log.debug(build)
3361 self.assertEqual("My Worker", build.worker.name)
3362 self.assertEqual("localhost", build.worker.hostname)
3363 self.assertEqual(['127.0.0.1', '192.168.1.1'], build.worker.ips)
3364 self.assertEqual("zuul.example.org", build.worker.fqdn)
3365 self.assertEqual("FakeBuilder", build.worker.program)
3366 self.assertEqual("v1.1", build.worker.version)
3367 self.assertEqual({'something': 'else'}, build.worker.extra)
3368
Paul Belanger174a8272017-03-14 13:20:10 -04003369 self.executor_server.hold_jobs_in_build = False
3370 self.executor_server.release()
Joshua Heskethba8776a2014-01-12 14:35:40 +08003371 self.waitUntilSettled()
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003372
James E. Blaircc324192017-04-19 14:36:08 -07003373 @simple_layout('layouts/footer-message.yaml')
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003374 def test_footer_message(self):
3375 "Test a pipeline's footer message is correctly added to the report."
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003376 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003377 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003378 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003379 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003380 self.waitUntilSettled()
3381
3382 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003383 B.addApproval('code-review', 2)
3384 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003385 self.waitUntilSettled()
3386
3387 self.assertEqual(2, len(self.smtp_messages))
3388
Adam Gandelman82258fd2017-02-07 16:51:58 -08003389 failure_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003390Build failed. For information on how to proceed, see \
Adam Gandelman82258fd2017-02-07 16:51:58 -08003391http://wiki.example.org/Test_Failures"""
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003392
Adam Gandelman82258fd2017-02-07 16:51:58 -08003393 footer_msg = """\
Joshua Hesketh3979e3e2014-03-04 11:21:10 +11003394For CI problems and help debugging, contact ci@example.org"""
3395
Adam Gandelman82258fd2017-02-07 16:51:58 -08003396 self.assertTrue(self.smtp_messages[0]['body'].startswith(failure_msg))
3397 self.assertTrue(self.smtp_messages[0]['body'].endswith(footer_msg))
3398 self.assertFalse(self.smtp_messages[1]['body'].startswith(failure_msg))
3399 self.assertTrue(self.smtp_messages[1]['body'].endswith(footer_msg))
Joshua Heskethb7179772014-01-30 23:30:46 +11003400
James E. Blairec056492016-07-22 09:45:56 -07003401 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003402 def test_merge_failure_reporters(self):
3403 """Check that the config is set up correctly"""
3404
James E. Blairf84026c2015-12-08 16:11:46 -08003405 self.updateConfigLayout(
3406 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003407 self.sched.reconfigure(self.config)
3408 self.registerJobs()
3409
3410 self.assertEqual(
Jeremy Stanley1c2c3c22015-06-15 21:23:19 +00003411 "Merge Failed.\n\nThis change or one of its cross-repo "
3412 "dependencies was unable to be automatically merged with the "
3413 "current state of its repository. Please rebase the change and "
3414 "upload a new patchset.",
Joshua Heskethb7179772014-01-30 23:30:46 +11003415 self.sched.layout.pipelines['check'].merge_failure_message)
3416 self.assertEqual(
3417 "The merge failed! For more information...",
3418 self.sched.layout.pipelines['gate'].merge_failure_message)
3419
3420 self.assertEqual(
3421 len(self.sched.layout.pipelines['check'].merge_failure_actions), 1)
3422 self.assertEqual(
3423 len(self.sched.layout.pipelines['gate'].merge_failure_actions), 2)
3424
3425 self.assertTrue(isinstance(
Joshua Heskethde958652015-11-10 19:19:50 +11003426 self.sched.layout.pipelines['check'].merge_failure_actions[0],
3427 zuul.reporter.gerrit.GerritReporter))
Joshua Heskethb7179772014-01-30 23:30:46 +11003428
3429 self.assertTrue(
3430 (
3431 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003432 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003433 zuul.reporter.smtp.SMTPReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003434 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003435 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003436 zuul.reporter.gerrit.GerritReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003437 ) or (
3438 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003439 merge_failure_actions[0],
Joshua Heskethffe42062014-09-05 21:43:52 +10003440 zuul.reporter.gerrit.GerritReporter) and
Joshua Heskethb7179772014-01-30 23:30:46 +11003441 isinstance(self.sched.layout.pipelines['gate'].
Joshua Heskethde958652015-11-10 19:19:50 +11003442 merge_failure_actions[1],
Joshua Heskethffe42062014-09-05 21:43:52 +10003443 zuul.reporter.smtp.SMTPReporter)
Joshua Heskethb7179772014-01-30 23:30:46 +11003444 )
3445 )
3446
James E. Blairec056492016-07-22 09:45:56 -07003447 @skip("Disabled for early v3 development")
Joshua Heskethb7179772014-01-30 23:30:46 +11003448 def test_merge_failure_reports(self):
3449 """Check that when a change fails to merge the correct message is sent
3450 to the correct reporter"""
James E. Blairf84026c2015-12-08 16:11:46 -08003451 self.updateConfigLayout(
3452 'tests/fixtures/layout-merge-failure.yaml')
Joshua Heskethb7179772014-01-30 23:30:46 +11003453 self.sched.reconfigure(self.config)
3454 self.registerJobs()
3455
3456 # Check a test failure isn't reported to SMTP
3457 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003458 A.addApproval('code-review', 2)
Paul Belanger174a8272017-03-14 13:20:10 -04003459 self.executor_server.failJob('project-test1', A)
James E. Blair8b5408c2016-08-08 15:37:46 -07003460 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003461 self.waitUntilSettled()
3462
3463 self.assertEqual(3, len(self.history)) # 3 jobs
3464 self.assertEqual(0, len(self.smtp_messages))
3465
3466 # Check a merge failure is reported to SMTP
3467 # B should be merged, but C will conflict with B
3468 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3469 B.addPatchset(['conflict'])
3470 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
3471 C.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003472 B.addApproval('code-review', 2)
3473 C.addApproval('code-review', 2)
3474 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
3475 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
Joshua Heskethb7179772014-01-30 23:30:46 +11003476 self.waitUntilSettled()
3477
3478 self.assertEqual(6, len(self.history)) # A and B jobs
3479 self.assertEqual(1, len(self.smtp_messages))
3480 self.assertEqual('The merge failed! For more information...',
3481 self.smtp_messages[0]['body'])
Joshua Hesketh36c3fa52014-01-22 11:40:52 +11003482
James E. Blairec056492016-07-22 09:45:56 -07003483 @skip("Disabled for early v3 development")
James E. Blairf760f0e2016-02-09 08:44:52 -08003484 def test_default_merge_failure_reports(self):
3485 """Check that the default merge failure reports are correct."""
3486
3487 # A should report success, B should report merge failure.
3488 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3489 A.addPatchset(['conflict'])
3490 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
3491 B.addPatchset(['conflict'])
James E. Blair8b5408c2016-08-08 15:37:46 -07003492 A.addApproval('code-review', 2)
3493 B.addApproval('code-review', 2)
3494 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
3495 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blairf760f0e2016-02-09 08:44:52 -08003496 self.waitUntilSettled()
3497
3498 self.assertEqual(3, len(self.history)) # A jobs
3499 self.assertEqual(A.reported, 2)
3500 self.assertEqual(B.reported, 2)
3501 self.assertEqual(A.data['status'], 'MERGED')
3502 self.assertEqual(B.data['status'], 'NEW')
3503 self.assertIn('Build succeeded', A.messages[1])
3504 self.assertIn('Merge Failed', B.messages[1])
3505 self.assertIn('automatically merged', B.messages[1])
3506 self.assertNotIn('logs.example.com', B.messages[1])
3507 self.assertNotIn('SKIPPED', B.messages[1])
3508
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003509 def test_client_get_running_jobs(self):
3510 "Test that the RPC client can get a list of running jobs"
Paul Belanger174a8272017-03-14 13:20:10 -04003511 self.executor_server.hold_jobs_in_build = True
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003512 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
James E. Blair8b5408c2016-08-08 15:37:46 -07003513 A.addApproval('code-review', 2)
3514 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003515 self.waitUntilSettled()
3516
3517 client = zuul.rpcclient.RPCClient('127.0.0.1',
3518 self.gearman_server.port)
Clark Boylandf4eba22017-04-24 17:37:58 -07003519 self.addCleanup(client.shutdown)
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003520
3521 # Wait for gearman server to send the initial workData back to zuul
3522 start = time.time()
3523 while True:
3524 if time.time() - start > 10:
3525 raise Exception("Timeout waiting for gearman server to report "
3526 + "back to the client")
Paul Belanger174a8272017-03-14 13:20:10 -04003527 build = self.executor_client.builds.values()[0]
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003528 if build.worker.name == "My Worker":
3529 break
3530 else:
3531 time.sleep(0)
3532
3533 running_items = client.get_running_jobs()
3534
3535 self.assertEqual(1, len(running_items))
3536 running_item = running_items[0]
3537 self.assertEqual([], running_item['failing_reasons'])
3538 self.assertEqual([], running_item['items_behind'])
3539 self.assertEqual('https://hostname/1', running_item['url'])
3540 self.assertEqual(None, running_item['item_ahead'])
3541 self.assertEqual('org/project', running_item['project'])
3542 self.assertEqual(None, running_item['remaining_time'])
3543 self.assertEqual(True, running_item['active'])
3544 self.assertEqual('1,1', running_item['id'])
3545
3546 self.assertEqual(3, len(running_item['jobs']))
3547 for job in running_item['jobs']:
3548 if job['name'] == 'project-merge':
3549 self.assertEqual('project-merge', job['name'])
3550 self.assertEqual('gate', job['pipeline'])
3551 self.assertEqual(False, job['retry'])
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003552 self.assertEqual('https://server/job/project-merge/0/',
3553 job['url'])
3554 self.assertEqual(7, len(job['worker']))
3555 self.assertEqual(False, job['canceled'])
3556 self.assertEqual(True, job['voting'])
3557 self.assertEqual(None, job['result'])
3558 self.assertEqual('gate', job['pipeline'])
3559 break
3560
Paul Belanger174a8272017-03-14 13:20:10 -04003561 self.executor_server.hold_jobs_in_build = False
3562 self.executor_server.release()
Joshua Hesketh85af4e92014-02-21 08:28:58 -08003563 self.waitUntilSettled()
3564
3565 running_items = client.get_running_jobs()
3566 self.assertEqual(0, len(running_items))
James E. Blairbadc1ad2014-04-28 13:55:14 -07003567
James E. Blairb70e55a2017-04-19 12:57:02 -07003568 @simple_layout('layouts/nonvoting-pipeline.yaml')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003569 def test_nonvoting_pipeline(self):
3570 "Test that a nonvoting pipeline (experimental) can still report"
3571
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003572 A = self.fake_gerrit.addFakeChange('org/experimental-project',
3573 'master', 'A')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003574 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3575 self.waitUntilSettled()
Paul Belanger15e3e202016-10-14 16:27:34 -04003576
3577 self.assertEqual(self.getJobFromHistory('project-merge').result,
3578 'SUCCESS')
Joshua Heskethcc017ea2014-04-30 19:55:25 +10003579 self.assertEqual(
3580 self.getJobFromHistory('experimental-project-test').result,
3581 'SUCCESS')
James E. Blairbadc1ad2014-04-28 13:55:14 -07003582 self.assertEqual(A.reported, 1)
James E. Blair5ee24252014-12-30 10:12:29 -08003583
3584 def test_crd_gate(self):
3585 "Test cross-repo dependencies"
3586 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3587 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003588 A.addApproval('code-review', 2)
3589 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003590
3591 AM2 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM2')
3592 AM1 = self.fake_gerrit.addFakeChange('org/project1', 'master', 'AM1')
3593 AM2.setMerged()
3594 AM1.setMerged()
3595
3596 BM2 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM2')
3597 BM1 = self.fake_gerrit.addFakeChange('org/project2', 'master', 'BM1')
3598 BM2.setMerged()
3599 BM1.setMerged()
3600
3601 # A -> AM1 -> AM2
3602 # B -> BM1 -> BM2
3603 # A Depends-On: B
3604 # M2 is here to make sure it is never queried. If it is, it
3605 # means zuul is walking down the entire history of merged
3606 # changes.
3607
3608 B.setDependsOn(BM1, 1)
3609 BM1.setDependsOn(BM2, 1)
3610
3611 A.setDependsOn(AM1, 1)
3612 AM1.setDependsOn(AM2, 1)
3613
3614 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3615 A.subject, B.data['id'])
3616
James E. Blair8b5408c2016-08-08 15:37:46 -07003617 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003618 self.waitUntilSettled()
3619
3620 self.assertEqual(A.data['status'], 'NEW')
3621 self.assertEqual(B.data['status'], 'NEW')
3622
Paul Belanger5dccbe72016-11-14 11:17:37 -05003623 for connection in self.connections.connections.values():
Joshua Hesketh4bd7da32016-02-17 20:58:47 +11003624 connection.maintainCache([])
James E. Blair5ee24252014-12-30 10:12:29 -08003625
Paul Belanger174a8272017-03-14 13:20:10 -04003626 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003627 B.addApproval('approved', 1)
3628 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003629 self.waitUntilSettled()
3630
Paul Belanger174a8272017-03-14 13:20:10 -04003631 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003632 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003633 self.executor_server.release('.*-merge')
James E. Blair5ee24252014-12-30 10:12:29 -08003634 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003635 self.executor_server.hold_jobs_in_build = False
3636 self.executor_server.release()
James E. Blair5ee24252014-12-30 10:12:29 -08003637 self.waitUntilSettled()
3638
3639 self.assertEqual(AM2.queried, 0)
3640 self.assertEqual(BM2.queried, 0)
3641 self.assertEqual(A.data['status'], 'MERGED')
3642 self.assertEqual(B.data['status'], 'MERGED')
3643 self.assertEqual(A.reported, 2)
3644 self.assertEqual(B.reported, 2)
3645
Paul Belanger5dccbe72016-11-14 11:17:37 -05003646 changes = self.getJobFromHistory(
3647 'project-merge', 'org/project1').changes
3648 self.assertEqual(changes, '2,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003649
3650 def test_crd_branch(self):
3651 "Test cross-repo dependencies in multiple branches"
Paul Belanger6379db12016-11-14 13:57:54 -05003652
3653 self.create_branch('org/project2', 'mp')
James E. Blair8f78d882015-02-05 08:51:37 -08003654 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3655 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3656 C = self.fake_gerrit.addFakeChange('org/project2', 'mp', 'C')
3657 C.data['id'] = B.data['id']
James E. Blair8b5408c2016-08-08 15:37:46 -07003658 A.addApproval('code-review', 2)
3659 B.addApproval('code-review', 2)
3660 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003661
3662 # A Depends-On: B+C
3663 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3664 A.subject, B.data['id'])
3665
Paul Belanger174a8272017-03-14 13:20:10 -04003666 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003667 B.addApproval('approved', 1)
3668 C.addApproval('approved', 1)
3669 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003670 self.waitUntilSettled()
3671
Paul Belanger174a8272017-03-14 13:20:10 -04003672 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003673 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003674 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003675 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003676 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003677 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003678 self.executor_server.hold_jobs_in_build = False
3679 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003680 self.waitUntilSettled()
3681
3682 self.assertEqual(A.data['status'], 'MERGED')
3683 self.assertEqual(B.data['status'], 'MERGED')
3684 self.assertEqual(C.data['status'], 'MERGED')
3685 self.assertEqual(A.reported, 2)
3686 self.assertEqual(B.reported, 2)
3687 self.assertEqual(C.reported, 2)
3688
Paul Belanger6379db12016-11-14 13:57:54 -05003689 changes = self.getJobFromHistory(
3690 'project-merge', 'org/project1').changes
3691 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair8f78d882015-02-05 08:51:37 -08003692
3693 def test_crd_multiline(self):
3694 "Test multiple depends-on lines in commit"
3695 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3696 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3697 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
James E. Blair8b5408c2016-08-08 15:37:46 -07003698 A.addApproval('code-review', 2)
3699 B.addApproval('code-review', 2)
3700 C.addApproval('code-review', 2)
James E. Blair8f78d882015-02-05 08:51:37 -08003701
3702 # A Depends-On: B+C
3703 A.data['commitMessage'] = '%s\n\nDepends-On: %s\nDepends-On: %s\n' % (
3704 A.subject, B.data['id'], C.data['id'])
3705
Paul Belanger174a8272017-03-14 13:20:10 -04003706 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003707 B.addApproval('approved', 1)
3708 C.addApproval('approved', 1)
3709 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair8f78d882015-02-05 08:51:37 -08003710 self.waitUntilSettled()
3711
Paul Belanger174a8272017-03-14 13:20:10 -04003712 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003713 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003714 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003715 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003716 self.executor_server.release('.*-merge')
James E. Blair8f78d882015-02-05 08:51:37 -08003717 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003718 self.executor_server.hold_jobs_in_build = False
3719 self.executor_server.release()
James E. Blair8f78d882015-02-05 08:51:37 -08003720 self.waitUntilSettled()
3721
3722 self.assertEqual(A.data['status'], 'MERGED')
3723 self.assertEqual(B.data['status'], 'MERGED')
3724 self.assertEqual(C.data['status'], 'MERGED')
3725 self.assertEqual(A.reported, 2)
3726 self.assertEqual(B.reported, 2)
3727 self.assertEqual(C.reported, 2)
3728
Paul Belanger5dccbe72016-11-14 11:17:37 -05003729 changes = self.getJobFromHistory(
3730 'project-merge', 'org/project1').changes
3731 self.assertEqual(changes, '2,1 3,1 1,1')
James E. Blair5ee24252014-12-30 10:12:29 -08003732
3733 def test_crd_unshared_gate(self):
3734 "Test cross-repo dependencies in unshared gate queues"
3735 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3736 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003737 A.addApproval('code-review', 2)
3738 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003739
3740 # A Depends-On: B
3741 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3742 A.subject, B.data['id'])
3743
3744 # A and B do not share a queue, make sure that A is unable to
3745 # enqueue B (and therefore, A is unable to be enqueued).
James E. Blair8b5408c2016-08-08 15:37:46 -07003746 B.addApproval('approved', 1)
3747 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003748 self.waitUntilSettled()
3749
3750 self.assertEqual(A.data['status'], 'NEW')
3751 self.assertEqual(B.data['status'], 'NEW')
3752 self.assertEqual(A.reported, 0)
3753 self.assertEqual(B.reported, 0)
3754 self.assertEqual(len(self.history), 0)
3755
3756 # Enqueue and merge B alone.
James E. Blair8b5408c2016-08-08 15:37:46 -07003757 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003758 self.waitUntilSettled()
3759
3760 self.assertEqual(B.data['status'], 'MERGED')
3761 self.assertEqual(B.reported, 2)
3762
3763 # Now that B is merged, A should be able to be enqueued and
3764 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003765 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003766 self.waitUntilSettled()
3767
3768 self.assertEqual(A.data['status'], 'MERGED')
3769 self.assertEqual(A.reported, 2)
3770
James E. Blair96698e22015-04-02 07:48:21 -07003771 def test_crd_gate_reverse(self):
3772 "Test reverse cross-repo dependencies"
3773 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3774 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003775 A.addApproval('code-review', 2)
3776 B.addApproval('code-review', 2)
James E. Blair96698e22015-04-02 07:48:21 -07003777
3778 # A Depends-On: B
3779
3780 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3781 A.subject, B.data['id'])
3782
James E. Blair8b5408c2016-08-08 15:37:46 -07003783 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003784 self.waitUntilSettled()
3785
3786 self.assertEqual(A.data['status'], 'NEW')
3787 self.assertEqual(B.data['status'], 'NEW')
3788
Paul Belanger174a8272017-03-14 13:20:10 -04003789 self.executor_server.hold_jobs_in_build = True
James E. Blair8b5408c2016-08-08 15:37:46 -07003790 A.addApproval('approved', 1)
3791 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
James E. Blair96698e22015-04-02 07:48:21 -07003792 self.waitUntilSettled()
3793
Paul Belanger174a8272017-03-14 13:20:10 -04003794 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003795 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003796 self.executor_server.release('.*-merge')
James E. Blair96698e22015-04-02 07:48:21 -07003797 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04003798 self.executor_server.hold_jobs_in_build = False
3799 self.executor_server.release()
James E. Blair96698e22015-04-02 07:48:21 -07003800 self.waitUntilSettled()
3801
3802 self.assertEqual(A.data['status'], 'MERGED')
3803 self.assertEqual(B.data['status'], 'MERGED')
3804 self.assertEqual(A.reported, 2)
3805 self.assertEqual(B.reported, 2)
3806
Paul Belanger5dccbe72016-11-14 11:17:37 -05003807 changes = self.getJobFromHistory(
3808 'project-merge', 'org/project1').changes
3809 self.assertEqual(changes, '2,1 1,1')
James E. Blair96698e22015-04-02 07:48:21 -07003810
James E. Blair5ee24252014-12-30 10:12:29 -08003811 def test_crd_cycle(self):
3812 "Test cross-repo dependency cycles"
3813 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3814 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003815 A.addApproval('code-review', 2)
3816 B.addApproval('code-review', 2)
James E. Blair5ee24252014-12-30 10:12:29 -08003817
3818 # A -> B -> A (via commit-depends)
3819
3820 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3821 A.subject, B.data['id'])
3822 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3823 B.subject, A.data['id'])
3824
James E. Blair8b5408c2016-08-08 15:37:46 -07003825 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
James E. Blair5ee24252014-12-30 10:12:29 -08003826 self.waitUntilSettled()
3827
3828 self.assertEqual(A.reported, 0)
3829 self.assertEqual(B.reported, 0)
3830 self.assertEqual(A.data['status'], 'NEW')
3831 self.assertEqual(B.data['status'], 'NEW')
James E. Blairbfb8e042014-12-30 17:01:44 -08003832
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003833 def test_crd_gate_unknown(self):
3834 "Test unknown projects in dependent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07003835 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003836 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
3837 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'B')
James E. Blair8b5408c2016-08-08 15:37:46 -07003838 A.addApproval('code-review', 2)
3839 B.addApproval('code-review', 2)
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003840
3841 # A Depends-On: B
3842 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3843 A.subject, B.data['id'])
3844
James E. Blair8b5408c2016-08-08 15:37:46 -07003845 B.addApproval('approved', 1)
3846 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003847 self.waitUntilSettled()
3848
3849 # Unknown projects cannot share a queue with any other
3850 # since they don't have common jobs with any other (they have no jobs).
3851 # Changes which depend on unknown project changes
3852 # should not be processed in dependent pipeline
3853 self.assertEqual(A.data['status'], 'NEW')
3854 self.assertEqual(B.data['status'], 'NEW')
3855 self.assertEqual(A.reported, 0)
3856 self.assertEqual(B.reported, 0)
3857 self.assertEqual(len(self.history), 0)
3858
3859 # Simulate change B being gated outside this layout
James E. Blair8b5408c2016-08-08 15:37:46 -07003860 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003861 B.setMerged()
3862 self.waitUntilSettled()
3863 self.assertEqual(len(self.history), 0)
3864
3865 # Now that B is merged, A should be able to be enqueued and
3866 # merged.
James E. Blair8b5408c2016-08-08 15:37:46 -07003867 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003868 self.waitUntilSettled()
3869
3870 self.assertEqual(A.data['status'], 'MERGED')
3871 self.assertEqual(A.reported, 2)
3872 self.assertEqual(B.data['status'], 'MERGED')
3873 self.assertEqual(B.reported, 0)
3874
James E. Blairbfb8e042014-12-30 17:01:44 -08003875 def test_crd_check(self):
3876 "Test cross-repo dependencies in independent pipelines"
3877
Paul Belanger174a8272017-03-14 13:20:10 -04003878 self.executor_server.hold_jobs_in_build = True
James E. Blairbfb8e042014-12-30 17:01:44 -08003879 self.gearman_server.hold_jobs_in_queue = True
3880 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3881 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
3882
3883 # A Depends-On: B
3884 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3885 A.subject, B.data['id'])
3886
3887 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3888 self.waitUntilSettled()
3889
James E. Blairbfb8e042014-12-30 17:01:44 -08003890 self.gearman_server.hold_jobs_in_queue = False
3891 self.gearman_server.release()
3892 self.waitUntilSettled()
3893
Paul Belanger174a8272017-03-14 13:20:10 -04003894 self.executor_server.release('.*-merge')
Paul Belangerb30342b2016-11-14 12:30:43 -05003895 self.waitUntilSettled()
3896
James E. Blair2a535672017-04-27 12:03:15 -07003897 self.assertTrue(self.builds[0].hasChanges(A, B))
James E. Blairbfb8e042014-12-30 17:01:44 -08003898
Paul Belanger174a8272017-03-14 13:20:10 -04003899 self.executor_server.hold_jobs_in_build = False
3900 self.executor_server.release()
Paul Belangerb30342b2016-11-14 12:30:43 -05003901 self.waitUntilSettled()
3902
James E. Blairbfb8e042014-12-30 17:01:44 -08003903 self.assertEqual(A.data['status'], 'NEW')
3904 self.assertEqual(B.data['status'], 'NEW')
3905 self.assertEqual(A.reported, 1)
3906 self.assertEqual(B.reported, 0)
3907
3908 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerb30342b2016-11-14 12:30:43 -05003909 tenant = self.sched.abide.tenants.get('tenant-one')
3910 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair8f78d882015-02-05 08:51:37 -08003911
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003912 def test_crd_check_git_depends(self):
3913 "Test single-repo dependencies in independent pipelines"
James E. Blairb8c16472015-05-05 14:55:26 -07003914 self.gearman_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003915 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3916 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
3917
3918 # Add two git-dependent changes and make sure they both report
3919 # success.
3920 B.setDependsOn(A, 1)
3921 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3922 self.waitUntilSettled()
3923 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3924 self.waitUntilSettled()
3925
James E. Blairb8c16472015-05-05 14:55:26 -07003926 self.orderedRelease()
3927 self.gearman_server.hold_jobs_in_build = False
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003928 self.waitUntilSettled()
3929
3930 self.assertEqual(A.data['status'], 'NEW')
3931 self.assertEqual(B.data['status'], 'NEW')
3932 self.assertEqual(A.reported, 1)
3933 self.assertEqual(B.reported, 1)
3934
3935 self.assertEqual(self.history[0].changes, '1,1')
3936 self.assertEqual(self.history[-1].changes, '1,1 2,1')
Paul Belanger08136962016-11-03 17:57:38 -04003937 tenant = self.sched.abide.tenants.get('tenant-one')
3938 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003939
3940 self.assertIn('Build succeeded', A.messages[0])
3941 self.assertIn('Build succeeded', B.messages[0])
3942
3943 def test_crd_check_duplicate(self):
3944 "Test duplicate check in independent pipelines"
Paul Belanger174a8272017-03-14 13:20:10 -04003945 self.executor_server.hold_jobs_in_build = True
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003946 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
3947 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
Paul Belanger08136962016-11-03 17:57:38 -04003948 tenant = self.sched.abide.tenants.get('tenant-one')
3949 check_pipeline = tenant.layout.pipelines['check']
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003950
3951 # Add two git-dependent changes...
3952 B.setDependsOn(A, 1)
3953 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3954 self.waitUntilSettled()
3955 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3956
3957 # ...make sure the live one is not duplicated...
3958 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
3959 self.waitUntilSettled()
3960 self.assertEqual(len(check_pipeline.getAllItems()), 2)
3961
3962 # ...but the non-live one is able to be.
3963 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3964 self.waitUntilSettled()
3965 self.assertEqual(len(check_pipeline.getAllItems()), 3)
3966
Clark Boylandd849822015-03-02 12:38:14 -08003967 # Release jobs in order to avoid races with change A jobs
3968 # finishing before change B jobs.
James E. Blaird7650852015-05-07 15:47:37 -07003969 self.orderedRelease()
Paul Belanger174a8272017-03-14 13:20:10 -04003970 self.executor_server.hold_jobs_in_build = False
3971 self.executor_server.release()
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003972 self.waitUntilSettled()
3973
3974 self.assertEqual(A.data['status'], 'NEW')
3975 self.assertEqual(B.data['status'], 'NEW')
3976 self.assertEqual(A.reported, 1)
3977 self.assertEqual(B.reported, 1)
3978
3979 self.assertEqual(self.history[0].changes, '1,1 2,1')
3980 self.assertEqual(self.history[1].changes, '1,1')
Paul Belanger08136962016-11-03 17:57:38 -04003981 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blairdbfe1cd2015-02-07 11:41:19 -08003982
3983 self.assertIn('Build succeeded', A.messages[0])
3984 self.assertIn('Build succeeded', B.messages[0])
3985
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003986 def _test_crd_check_reconfiguration(self, project1, project2):
James E. Blair8f78d882015-02-05 08:51:37 -08003987 "Test cross-repo dependencies re-enqueued in independent pipelines"
3988
3989 self.gearman_server.hold_jobs_in_queue = True
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00003990 A = self.fake_gerrit.addFakeChange(project1, 'master', 'A')
3991 B = self.fake_gerrit.addFakeChange(project2, 'master', 'B')
James E. Blair8f78d882015-02-05 08:51:37 -08003992
3993 # A Depends-On: B
3994 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
3995 A.subject, B.data['id'])
3996
3997 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
3998 self.waitUntilSettled()
3999
4000 self.sched.reconfigure(self.config)
4001
4002 # Make sure the items still share a change queue, and the
4003 # first one is not live.
Paul Belangerce4485f2016-11-11 17:01:56 -05004004 tenant = self.sched.abide.tenants.get('tenant-one')
4005 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 1)
4006 queue = tenant.layout.pipelines['check'].queues[0]
James E. Blair8f78d882015-02-05 08:51:37 -08004007 first_item = queue.queue[0]
4008 for item in queue.queue:
4009 self.assertEqual(item.queue, first_item.queue)
4010 self.assertFalse(first_item.live)
4011 self.assertTrue(queue.queue[1].live)
4012
4013 self.gearman_server.hold_jobs_in_queue = False
4014 self.gearman_server.release()
4015 self.waitUntilSettled()
4016
4017 self.assertEqual(A.data['status'], 'NEW')
4018 self.assertEqual(B.data['status'], 'NEW')
4019 self.assertEqual(A.reported, 1)
4020 self.assertEqual(B.reported, 0)
4021
4022 self.assertEqual(self.history[0].changes, '2,1 1,1')
Paul Belangerce4485f2016-11-11 17:01:56 -05004023 self.assertEqual(len(tenant.layout.pipelines['check'].queues), 0)
James E. Blair17dd6772015-02-09 14:45:18 -08004024
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004025 def test_crd_check_reconfiguration(self):
4026 self._test_crd_check_reconfiguration('org/project1', 'org/project2')
4027
4028 def test_crd_undefined_project(self):
4029 """Test that undefined projects in dependencies are handled for
4030 independent pipelines"""
4031 # It's a hack for fake gerrit,
4032 # as it implies repo creation upon the creation of any change
James E. Blairc4ba97a2017-04-19 16:26:24 -07004033 self.init_repo("org/unknown", tag='init')
Evgeny Antyshev0deaaad2015-08-03 20:22:56 +00004034 self._test_crd_check_reconfiguration('org/project1', 'org/unknown')
4035
Jesse Keatingea68ab42017-04-19 15:03:30 -07004036 @simple_layout('layouts/ignore-dependencies.yaml')
James E. Blair17dd6772015-02-09 14:45:18 -08004037 def test_crd_check_ignore_dependencies(self):
4038 "Test cross-repo dependencies can be ignored"
James E. Blair17dd6772015-02-09 14:45:18 -08004039
4040 self.gearman_server.hold_jobs_in_queue = True
4041 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4042 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4043 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
4044
4045 # A Depends-On: B
4046 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4047 A.subject, B.data['id'])
4048 # C git-depends on B
4049 C.setDependsOn(B, 1)
4050 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4051 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4052 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4053 self.waitUntilSettled()
4054
4055 # Make sure none of the items share a change queue, and all
4056 # are live.
Jesse Keatingea68ab42017-04-19 15:03:30 -07004057 tenant = self.sched.abide.tenants.get('tenant-one')
Clint Byrum12282ca2017-04-03 11:04:02 -07004058 check_pipeline = tenant.layout.pipelines['check']
James E. Blair17dd6772015-02-09 14:45:18 -08004059 self.assertEqual(len(check_pipeline.queues), 3)
4060 self.assertEqual(len(check_pipeline.getAllItems()), 3)
4061 for item in check_pipeline.getAllItems():
4062 self.assertTrue(item.live)
4063
4064 self.gearman_server.hold_jobs_in_queue = False
4065 self.gearman_server.release()
4066 self.waitUntilSettled()
4067
4068 self.assertEqual(A.data['status'], 'NEW')
4069 self.assertEqual(B.data['status'], 'NEW')
4070 self.assertEqual(C.data['status'], 'NEW')
4071 self.assertEqual(A.reported, 1)
4072 self.assertEqual(B.reported, 1)
4073 self.assertEqual(C.reported, 1)
4074
4075 # Each job should have tested exactly one change
4076 for job in self.history:
4077 self.assertEqual(len(job.changes.split()), 1)
James E. Blair96698e22015-04-02 07:48:21 -07004078
James E. Blair7cb84542017-04-19 13:35:05 -07004079 @simple_layout('layouts/three-projects.yaml')
James E. Blair96698e22015-04-02 07:48:21 -07004080 def test_crd_check_transitive(self):
4081 "Test transitive cross-repo dependencies"
4082 # Specifically, if A -> B -> C, and C gets a new patchset and
4083 # A gets a new patchset, ensure the test of A,2 includes B,1
4084 # and C,2 (not C,1 which would indicate stale data in the
4085 # cache for B).
4086 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4087 B = self.fake_gerrit.addFakeChange('org/project2', 'master', 'B')
4088 C = self.fake_gerrit.addFakeChange('org/project3', 'master', 'C')
4089
4090 # A Depends-On: B
4091 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4092 A.subject, B.data['id'])
4093
4094 # B Depends-On: C
4095 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4096 B.subject, C.data['id'])
4097
4098 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4099 self.waitUntilSettled()
4100 self.assertEqual(self.history[-1].changes, '3,1 2,1 1,1')
4101
4102 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4103 self.waitUntilSettled()
4104 self.assertEqual(self.history[-1].changes, '3,1 2,1')
4105
4106 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4107 self.waitUntilSettled()
4108 self.assertEqual(self.history[-1].changes, '3,1')
4109
4110 C.addPatchset()
4111 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(2))
4112 self.waitUntilSettled()
4113 self.assertEqual(self.history[-1].changes, '3,2')
4114
4115 A.addPatchset()
4116 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(2))
4117 self.waitUntilSettled()
4118 self.assertEqual(self.history[-1].changes, '3,2 2,1 1,2')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004119
James E. Blaira8b90b32016-08-24 15:18:50 -07004120 def test_crd_check_unknown(self):
4121 "Test unknown projects in independent pipeline"
James E. Blairc4ba97a2017-04-19 16:26:24 -07004122 self.init_repo("org/unknown", tag='init')
James E. Blaira8b90b32016-08-24 15:18:50 -07004123 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4124 B = self.fake_gerrit.addFakeChange('org/unknown', 'master', 'D')
4125 # A Depends-On: B
4126 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4127 A.subject, B.data['id'])
4128
4129 # Make sure zuul has seen an event on B.
4130 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4131 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4132 self.waitUntilSettled()
4133
4134 self.assertEqual(A.data['status'], 'NEW')
4135 self.assertEqual(A.reported, 1)
4136 self.assertEqual(B.data['status'], 'NEW')
4137 self.assertEqual(B.reported, 0)
4138
James E. Blair92464a22016-04-05 10:21:26 -07004139 def test_crd_cycle_join(self):
4140 "Test an updated change creates a cycle"
4141 A = self.fake_gerrit.addFakeChange('org/project2', 'master', 'A')
4142
4143 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4144 self.waitUntilSettled()
4145
4146 # Create B->A
4147 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4148 B.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4149 B.subject, A.data['id'])
4150 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4151 self.waitUntilSettled()
4152
4153 # Update A to add A->B (a cycle).
4154 A.addPatchset()
4155 A.data['commitMessage'] = '%s\n\nDepends-On: %s\n' % (
4156 A.subject, B.data['id'])
4157 # Normally we would submit the patchset-created event for
4158 # processing here, however, we have no way of noting whether
4159 # the dependency cycle detection correctly raised an
4160 # exception, so instead, we reach into the source driver and
4161 # call the method that would ultimately be called by the event
4162 # processing.
4163
Paul Belanger0e155e22016-11-14 14:12:23 -05004164 tenant = self.sched.abide.tenants.get('tenant-one')
James E. Blair6053de42017-04-05 11:27:11 -07004165 (trusted, project) = tenant.getProject('org/project')
4166 source = project.source
Paul Belanger0e155e22016-11-14 14:12:23 -05004167
4168 # TODO(pabelanger): As we add more source / trigger APIs we should make
4169 # it easier for users to create events for testing.
4170 event = zuul.model.TriggerEvent()
4171 event.trigger_name = 'gerrit'
4172 event.change_number = '1'
4173 event.patch_number = '2'
James E. Blair92464a22016-04-05 10:21:26 -07004174 with testtools.ExpectedException(
4175 Exception, "Dependency cycle detected"):
Paul Belanger0e155e22016-11-14 14:12:23 -05004176 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004177 self.log.debug("Got expected dependency cycle exception")
4178
4179 # Now if we update B to remove the depends-on, everything
4180 # should be okay. B; A->B
4181
4182 B.addPatchset()
4183 B.data['commitMessage'] = '%s\n' % (B.subject,)
Paul Belanger0e155e22016-11-14 14:12:23 -05004184
4185 source.getChange(event, True)
4186 event.change_number = '2'
4187 source.getChange(event, True)
James E. Blair92464a22016-04-05 10:21:26 -07004188
Jesse Keatingcc67b122017-04-19 14:54:57 -07004189 @simple_layout('layouts/disable_at.yaml')
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004190 def test_disable_at(self):
4191 "Test a pipeline will only report to the disabled trigger when failing"
4192
Jesse Keatingcc67b122017-04-19 14:54:57 -07004193 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004194 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004195 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004196 0, tenant.layout.pipelines['check']._consecutive_failures)
4197 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004198
4199 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4200 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4201 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
4202 D = self.fake_gerrit.addFakeChange('org/project', 'master', 'D')
4203 E = self.fake_gerrit.addFakeChange('org/project', 'master', 'E')
4204 F = self.fake_gerrit.addFakeChange('org/project', 'master', 'F')
4205 G = self.fake_gerrit.addFakeChange('org/project', 'master', 'G')
4206 H = self.fake_gerrit.addFakeChange('org/project', 'master', 'H')
4207 I = self.fake_gerrit.addFakeChange('org/project', 'master', 'I')
4208 J = self.fake_gerrit.addFakeChange('org/project', 'master', 'J')
4209 K = self.fake_gerrit.addFakeChange('org/project', 'master', 'K')
4210
Paul Belanger174a8272017-03-14 13:20:10 -04004211 self.executor_server.failJob('project-test1', A)
4212 self.executor_server.failJob('project-test1', B)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004213 # Let C pass, resetting the counter
Paul Belanger174a8272017-03-14 13:20:10 -04004214 self.executor_server.failJob('project-test1', D)
4215 self.executor_server.failJob('project-test1', E)
4216 self.executor_server.failJob('project-test1', F)
4217 self.executor_server.failJob('project-test1', G)
4218 self.executor_server.failJob('project-test1', H)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004219 # I also passes but should only report to the disabled reporters
Paul Belanger174a8272017-03-14 13:20:10 -04004220 self.executor_server.failJob('project-test1', J)
4221 self.executor_server.failJob('project-test1', K)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004222
4223 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4224 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4225 self.waitUntilSettled()
4226
4227 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004228 2, tenant.layout.pipelines['check']._consecutive_failures)
4229 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004230
4231 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
4232 self.waitUntilSettled()
4233
4234 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004235 0, tenant.layout.pipelines['check']._consecutive_failures)
4236 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004237
4238 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
4239 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
4240 self.fake_gerrit.addEvent(F.getPatchsetCreatedEvent(1))
4241 self.waitUntilSettled()
4242
4243 # We should be disabled now
4244 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004245 3, tenant.layout.pipelines['check']._consecutive_failures)
4246 self.assertTrue(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004247
4248 # We need to wait between each of these patches to make sure the
4249 # smtp messages come back in an expected order
4250 self.fake_gerrit.addEvent(G.getPatchsetCreatedEvent(1))
4251 self.waitUntilSettled()
4252 self.fake_gerrit.addEvent(H.getPatchsetCreatedEvent(1))
4253 self.waitUntilSettled()
4254 self.fake_gerrit.addEvent(I.getPatchsetCreatedEvent(1))
4255 self.waitUntilSettled()
4256
4257 # The first 6 (ABCDEF) jobs should have reported back to gerrt thus
4258 # leaving a message on each change
4259 self.assertEqual(1, len(A.messages))
4260 self.assertIn('Build failed.', A.messages[0])
4261 self.assertEqual(1, len(B.messages))
4262 self.assertIn('Build failed.', B.messages[0])
4263 self.assertEqual(1, len(C.messages))
4264 self.assertIn('Build succeeded.', C.messages[0])
4265 self.assertEqual(1, len(D.messages))
4266 self.assertIn('Build failed.', D.messages[0])
4267 self.assertEqual(1, len(E.messages))
4268 self.assertIn('Build failed.', E.messages[0])
4269 self.assertEqual(1, len(F.messages))
4270 self.assertIn('Build failed.', F.messages[0])
4271
4272 # The last 3 (GHI) would have only reported via smtp.
4273 self.assertEqual(3, len(self.smtp_messages))
4274 self.assertEqual(0, len(G.messages))
4275 self.assertIn('Build failed.', self.smtp_messages[0]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004276 self.assertIn(
4277 'project-test1 https://server/job', self.smtp_messages[0]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004278 self.assertEqual(0, len(H.messages))
4279 self.assertIn('Build failed.', self.smtp_messages[1]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004280 self.assertIn(
4281 'project-test1 https://server/job', self.smtp_messages[1]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004282 self.assertEqual(0, len(I.messages))
4283 self.assertIn('Build succeeded.', self.smtp_messages[2]['body'])
Paul Belanger7dc76e82016-11-11 16:51:08 -05004284 self.assertIn(
4285 'project-test1 https://server/job', self.smtp_messages[2]['body'])
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004286
4287 # Now reload the configuration (simulate a HUP) to check the pipeline
4288 # comes out of disabled
4289 self.sched.reconfigure(self.config)
4290
Jesse Keatingcc67b122017-04-19 14:54:57 -07004291 tenant = self.sched.abide.tenants.get('tenant-one')
Paul Belanger7dc76e82016-11-11 16:51:08 -05004292
4293 self.assertEqual(3, tenant.layout.pipelines['check'].disable_at)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004294 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004295 0, tenant.layout.pipelines['check']._consecutive_failures)
4296 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004297
4298 self.fake_gerrit.addEvent(J.getPatchsetCreatedEvent(1))
4299 self.fake_gerrit.addEvent(K.getPatchsetCreatedEvent(1))
4300 self.waitUntilSettled()
4301
4302 self.assertEqual(
Paul Belanger7dc76e82016-11-11 16:51:08 -05004303 2, tenant.layout.pipelines['check']._consecutive_failures)
4304 self.assertFalse(tenant.layout.pipelines['check']._disabled)
Joshua Hesketh89e829d2015-02-10 16:29:45 +11004305
4306 # J and K went back to gerrit
4307 self.assertEqual(1, len(J.messages))
4308 self.assertIn('Build failed.', J.messages[0])
4309 self.assertEqual(1, len(K.messages))
4310 self.assertIn('Build failed.', K.messages[0])
4311 # No more messages reported via smtp
4312 self.assertEqual(3, len(self.smtp_messages))
Joshua Heskethd6dbd682015-12-22 10:06:54 +11004313
James E. Blaircc020532017-04-19 13:04:44 -07004314 @simple_layout('layouts/one-job-project.yaml')
4315 def test_one_job_project(self):
4316 "Test that queueing works with one job"
4317 A = self.fake_gerrit.addFakeChange('org/one-job-project',
4318 'master', 'A')
4319 B = self.fake_gerrit.addFakeChange('org/one-job-project',
4320 'master', 'B')
4321 A.addApproval('code-review', 2)
4322 B.addApproval('code-review', 2)
4323 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4324 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4325 self.waitUntilSettled()
4326
4327 self.assertEqual(A.data['status'], 'MERGED')
4328 self.assertEqual(A.reported, 2)
4329 self.assertEqual(B.data['status'], 'MERGED')
4330 self.assertEqual(B.reported, 2)
4331
Paul Belanger71d98172016-11-08 10:56:31 -05004332 def test_rerun_on_abort(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004333 "Test that if a execute server fails to run a job, it is run again"
Paul Belanger71d98172016-11-08 10:56:31 -05004334
Paul Belanger174a8272017-03-14 13:20:10 -04004335 self.executor_server.hold_jobs_in_build = True
Paul Belanger71d98172016-11-08 10:56:31 -05004336 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4337 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4338 self.waitUntilSettled()
4339
Paul Belanger174a8272017-03-14 13:20:10 -04004340 self.executor_server.release('.*-merge')
Paul Belanger71d98172016-11-08 10:56:31 -05004341 self.waitUntilSettled()
4342
4343 self.assertEqual(len(self.builds), 2)
4344 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004345 self.executor_server.release('.*-test*')
Paul Belanger71d98172016-11-08 10:56:31 -05004346 self.waitUntilSettled()
4347
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004348 for x in range(3):
Clint Byrumdf0a55b2016-12-05 06:39:11 -08004349 self.assertEqual(len(self.builds), 1,
4350 'len of builds at x=%d is wrong' % x)
Paul Belanger71d98172016-11-08 10:56:31 -05004351 self.builds[0].requeue = True
Paul Belanger174a8272017-03-14 13:20:10 -04004352 self.executor_server.release('.*-test1')
Paul Belanger71d98172016-11-08 10:56:31 -05004353 self.waitUntilSettled()
4354
Paul Belanger174a8272017-03-14 13:20:10 -04004355 self.executor_server.hold_jobs_in_build = False
4356 self.executor_server.release()
Paul Belanger71d98172016-11-08 10:56:31 -05004357 self.waitUntilSettled()
Clint Byrum5bb5feb2016-12-08 12:39:05 -08004358 self.assertEqual(len(self.history), 6)
Paul Belanger71d98172016-11-08 10:56:31 -05004359 self.assertEqual(self.countJobResults(self.history, 'SUCCESS'), 2)
4360 self.assertEqual(A.reported, 1)
4361 self.assertIn('RETRY_LIMIT', A.messages[0])
Joshua Hesketh3f7def32016-11-21 17:36:44 +11004362
James E. Blair15be0e12017-01-03 13:45:20 -08004363 def test_zookeeper_disconnect(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004364 "Test that jobs are executed after a zookeeper disconnect"
James E. Blair15be0e12017-01-03 13:45:20 -08004365
4366 self.fake_nodepool.paused = True
4367 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4368 A.addApproval('code-review', 2)
4369 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4370 self.waitUntilSettled()
4371
4372 self.zk.client.stop()
4373 self.zk.client.start()
4374 self.fake_nodepool.paused = False
4375 self.waitUntilSettled()
4376
4377 self.assertEqual(A.data['status'], 'MERGED')
4378 self.assertEqual(A.reported, 2)
4379
James E. Blair6ab79e02017-01-06 10:10:17 -08004380 def test_nodepool_failure(self):
4381 "Test that jobs are reported after a nodepool failure"
4382
4383 self.fake_nodepool.paused = True
4384 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4385 A.addApproval('code-review', 2)
4386 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4387 self.waitUntilSettled()
4388
4389 req = self.fake_nodepool.getNodeRequests()[0]
4390 self.fake_nodepool.addFailRequest(req)
4391
4392 self.fake_nodepool.paused = False
4393 self.waitUntilSettled()
4394
4395 self.assertEqual(A.data['status'], 'NEW')
4396 self.assertEqual(A.reported, 2)
4397 self.assertIn('project-merge : NODE_FAILURE', A.messages[1])
4398 self.assertIn('project-test1 : SKIPPED', A.messages[1])
4399 self.assertIn('project-test2 : SKIPPED', A.messages[1])
4400
Arieb6f068c2016-10-09 13:11:06 +03004401
James E. Blaira002b032017-04-18 10:35:48 -07004402class TestExecutor(ZuulTestCase):
4403 tenant_config_file = 'config/single-tenant/main.yaml'
4404
4405 def assertFinalState(self):
4406 # In this test, we expect to shut down in a non-final state,
4407 # so skip these checks.
4408 pass
4409
4410 def assertCleanShutdown(self):
4411 self.log.debug("Assert clean shutdown")
4412
4413 # After shutdown, make sure no jobs are running
4414 self.assertEqual({}, self.executor_server.job_workers)
4415
4416 # Make sure that git.Repo objects have been garbage collected.
4417 repos = []
4418 gc.collect()
4419 for obj in gc.get_objects():
4420 if isinstance(obj, git.Repo):
4421 self.log.debug("Leaked git repo object: %s" % repr(obj))
4422 repos.append(obj)
4423 self.assertEqual(len(repos), 0)
4424
4425 def test_executor_shutdown(self):
4426 "Test that the executor can shut down with jobs running"
4427
4428 self.executor_server.hold_jobs_in_build = True
4429 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4430 A.addApproval('code-review', 2)
4431 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4432 self.waitUntilSettled()
4433
4434
Fredrik Medleyf8aec832015-09-28 13:40:20 +02004435class TestDependencyGraph(ZuulTestCase):
4436 tenant_config_file = 'config/dependency-graph/main.yaml'
4437
4438 def test_dependeny_graph_dispatch_jobs_once(self):
4439 "Test a job in a dependency graph is queued only once"
4440 # Job dependencies, starting with A
4441 # A
4442 # / \
4443 # B C
4444 # / \ / \
4445 # D F E
4446 # |
4447 # G
4448
4449 self.executor_server.hold_jobs_in_build = True
4450 change = self.fake_gerrit.addFakeChange(
4451 'org/project', 'master', 'change')
4452 change.addApproval('code-review', 2)
4453 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4454
4455 self.waitUntilSettled()
4456 self.assertEqual([b.name for b in self.builds], ['A'])
4457
4458 self.executor_server.release('A')
4459 self.waitUntilSettled()
4460 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4461
4462 self.executor_server.release('B')
4463 self.waitUntilSettled()
4464 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4465
4466 self.executor_server.release('D')
4467 self.waitUntilSettled()
4468 self.assertEqual([b.name for b in self.builds], ['C'])
4469
4470 self.executor_server.release('C')
4471 self.waitUntilSettled()
4472 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'F'])
4473
4474 self.executor_server.release('F')
4475 self.waitUntilSettled()
4476 self.assertEqual(sorted(b.name for b in self.builds), ['E', 'G'])
4477
4478 self.executor_server.release('G')
4479 self.waitUntilSettled()
4480 self.assertEqual([b.name for b in self.builds], ['E'])
4481
4482 self.executor_server.release('E')
4483 self.waitUntilSettled()
4484 self.assertEqual(len(self.builds), 0)
4485
4486 self.executor_server.hold_jobs_in_build = False
4487 self.executor_server.release()
4488 self.waitUntilSettled()
4489
4490 self.assertEqual(len(self.builds), 0)
4491 self.assertEqual(len(self.history), 7)
4492
4493 self.assertEqual(change.data['status'], 'MERGED')
4494 self.assertEqual(change.reported, 2)
4495
4496 def test_jobs_launched_only_if_all_dependencies_are_successful(self):
4497 "Test that a job waits till all dependencies are successful"
4498 # Job dependencies, starting with A
4499 # A
4500 # / \
4501 # B C*
4502 # / \ / \
4503 # D F E
4504 # |
4505 # G
4506
4507 self.executor_server.hold_jobs_in_build = True
4508 change = self.fake_gerrit.addFakeChange(
4509 'org/project', 'master', 'change')
4510 change.addApproval('code-review', 2)
4511
4512 self.executor_server.failJob('C', change)
4513
4514 self.fake_gerrit.addEvent(change.addApproval('approved', 1))
4515
4516 self.waitUntilSettled()
4517 self.assertEqual([b.name for b in self.builds], ['A'])
4518
4519 self.executor_server.release('A')
4520 self.waitUntilSettled()
4521 self.assertEqual(sorted(b.name for b in self.builds), ['B', 'C'])
4522
4523 self.executor_server.release('B')
4524 self.waitUntilSettled()
4525 self.assertEqual(sorted(b.name for b in self.builds), ['C', 'D'])
4526
4527 self.executor_server.release('D')
4528 self.waitUntilSettled()
4529 self.assertEqual([b.name for b in self.builds], ['C'])
4530
4531 self.executor_server.release('C')
4532 self.waitUntilSettled()
4533 self.assertEqual(len(self.builds), 0)
4534
4535 self.executor_server.hold_jobs_in_build = False
4536 self.executor_server.release()
4537 self.waitUntilSettled()
4538
4539 self.assertEqual(len(self.builds), 0)
4540 self.assertEqual(len(self.history), 4)
4541
4542 self.assertEqual(change.data['status'], 'NEW')
4543 self.assertEqual(change.reported, 2)
4544
4545
Arieb6f068c2016-10-09 13:11:06 +03004546class TestDuplicatePipeline(ZuulTestCase):
4547 tenant_config_file = 'config/duplicate-pipeline/main.yaml'
4548
4549 def test_duplicate_pipelines(self):
4550 "Test that a change matching multiple pipelines works"
4551
4552 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4553 self.fake_gerrit.addEvent(A.getChangeRestoredEvent())
4554 self.waitUntilSettled()
4555
4556 self.assertHistory([
4557 dict(name='project-test1', result='SUCCESS', changes='1,1',
4558 pipeline='dup1'),
4559 dict(name='project-test1', result='SUCCESS', changes='1,1',
4560 pipeline='dup2'),
Paul Belanger73a7d8e2016-11-09 11:12:42 -05004561 ], ordered=False)
Arieb6f068c2016-10-09 13:11:06 +03004562
4563 self.assertEqual(len(A.messages), 2)
4564
Paul Belangera46a3742016-11-09 14:23:03 -05004565 if 'dup1' in A.messages[0]:
4566 self.assertIn('dup1', A.messages[0])
4567 self.assertNotIn('dup2', A.messages[0])
4568 self.assertIn('project-test1', A.messages[0])
4569 self.assertIn('dup2', A.messages[1])
4570 self.assertNotIn('dup1', A.messages[1])
4571 self.assertIn('project-test1', A.messages[1])
4572 else:
4573 self.assertIn('dup1', A.messages[1])
4574 self.assertNotIn('dup2', A.messages[1])
4575 self.assertIn('project-test1', A.messages[1])
4576 self.assertIn('dup2', A.messages[0])
4577 self.assertNotIn('dup1', A.messages[0])
4578 self.assertIn('project-test1', A.messages[0])
Paul Belangerfac69ba2016-11-03 09:03:13 -04004579
4580
Paul Belanger86085b32016-11-03 12:48:57 -04004581class TestSchedulerTemplatedProject(ZuulTestCase):
4582 tenant_config_file = 'config/templated-project/main.yaml'
4583
Paul Belanger174a8272017-03-14 13:20:10 -04004584 def test_job_from_templates_executed(self):
4585 "Test whether a job generated via a template can be executed"
Paul Belanger86085b32016-11-03 12:48:57 -04004586
4587 A = self.fake_gerrit.addFakeChange(
4588 'org/templated-project', 'master', 'A')
4589 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4590 self.waitUntilSettled()
4591
4592 self.assertEqual(self.getJobFromHistory('project-test1').result,
4593 'SUCCESS')
4594 self.assertEqual(self.getJobFromHistory('project-test2').result,
4595 'SUCCESS')
Paul Belanger3adf72f2016-11-03 14:57:31 -04004596
4597 def test_layered_templates(self):
Paul Belanger174a8272017-03-14 13:20:10 -04004598 "Test whether a job generated via a template can be executed"
Paul Belanger3adf72f2016-11-03 14:57:31 -04004599
4600 A = self.fake_gerrit.addFakeChange(
4601 'org/layered-project', 'master', 'A')
4602 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4603 self.waitUntilSettled()
4604
4605 self.assertEqual(self.getJobFromHistory('project-test1').result,
4606 'SUCCESS')
4607 self.assertEqual(self.getJobFromHistory('project-test2').result,
4608 'SUCCESS')
4609 self.assertEqual(self.getJobFromHistory('layered-project-test3'
4610 ).result, 'SUCCESS')
4611 self.assertEqual(self.getJobFromHistory('layered-project-test4'
4612 ).result, 'SUCCESS')
4613 self.assertEqual(self.getJobFromHistory('layered-project-foo-test5'
4614 ).result, 'SUCCESS')
4615 self.assertEqual(self.getJobFromHistory('project-test6').result,
4616 'SUCCESS')
Adam Gandelman94a60062016-11-21 16:43:14 -08004617
4618
4619class TestSchedulerSuccessURL(ZuulTestCase):
4620 tenant_config_file = 'config/success-url/main.yaml'
4621
4622 def test_success_url(self):
4623 "Ensure bad build params are ignored"
4624 self.sched.reconfigure(self.config)
4625 self.init_repo('org/docs')
4626
4627 A = self.fake_gerrit.addFakeChange('org/docs', 'master', 'A')
4628 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4629 self.waitUntilSettled()
4630
4631 # Both builds ran: docs-draft-test + docs-draft-test2
4632 self.assertEqual(len(self.history), 2)
4633
4634 # Grab build id
James E. Blaire7576802016-12-21 16:15:00 -08004635 for build in self.history:
4636 if build.name == 'docs-draft-test':
4637 uuid = build.uuid[:7]
4638 break
Adam Gandelman94a60062016-11-21 16:43:14 -08004639
4640 # Two msgs: 'Starting...' + results
4641 self.assertEqual(len(self.smtp_messages), 2)
4642 body = self.smtp_messages[1]['body'].splitlines()
4643 self.assertEqual('Build succeeded.', body[0])
4644
4645 self.assertIn(
4646 '- docs-draft-test http://docs-draft.example.org/1/1/1/check/'
4647 'docs-draft-test/%s/publish-docs/' % uuid,
4648 body[2])
4649
Paul Belanger174a8272017-03-14 13:20:10 -04004650 # NOTE: This default URL is currently hard-coded in executor/server.py
Adam Gandelman94a60062016-11-21 16:43:14 -08004651 self.assertIn(
4652 '- docs-draft-test2 https://server/job',
4653 body[3])
Adam Gandelman8bd57102016-12-02 12:58:42 -08004654
4655
Adam Gandelman4da00f62016-12-09 15:47:33 -08004656class TestSchedulerMerges(ZuulTestCase):
4657 tenant_config_file = 'config/merges/main.yaml'
Adam Gandelman8bd57102016-12-02 12:58:42 -08004658
4659 def _test_project_merge_mode(self, mode):
Paul Belanger174a8272017-03-14 13:20:10 -04004660 self.executor_server.keep_jobdir = False
Adam Gandelman8bd57102016-12-02 12:58:42 -08004661 project = 'org/project-%s' % mode
Paul Belanger174a8272017-03-14 13:20:10 -04004662 self.executor_server.hold_jobs_in_build = True
Adam Gandelman8bd57102016-12-02 12:58:42 -08004663 A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
4664 B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
4665 C = self.fake_gerrit.addFakeChange(project, 'master', 'C')
4666 A.addApproval('code-review', 2)
4667 B.addApproval('code-review', 2)
4668 C.addApproval('code-review', 2)
4669 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4670 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4671 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4672 self.waitUntilSettled()
4673
4674 build = self.builds[-1]
4675 ref = self.getParameter(build, 'ZUUL_REF')
4676
James E. Blair2a535672017-04-27 12:03:15 -07004677 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4678 project)
Adam Gandelman8bd57102016-12-02 12:58:42 -08004679 repo = git.Repo(path)
4680 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4681 repo_messages.reverse()
4682
Paul Belanger174a8272017-03-14 13:20:10 -04004683 self.executor_server.hold_jobs_in_build = False
4684 self.executor_server.release()
Adam Gandelman8bd57102016-12-02 12:58:42 -08004685 self.waitUntilSettled()
4686
4687 return repo_messages
4688
4689 def _test_merge(self, mode):
4690 us_path = os.path.join(
4691 self.upstream_root, 'org/project-%s' % mode)
4692 expected_messages = [
4693 'initial commit',
4694 'add content from fixture',
4695 # the intermediate commits order is nondeterministic
4696 "Merge commit 'refs/changes/1/2/1' of %s into HEAD" % us_path,
4697 "Merge commit 'refs/changes/1/3/1' of %s into HEAD" % us_path,
4698 ]
4699 result = self._test_project_merge_mode(mode)
4700 self.assertEqual(result[:2], expected_messages[:2])
4701 self.assertEqual(result[-2:], expected_messages[-2:])
4702
4703 def test_project_merge_mode_merge(self):
4704 self._test_merge('merge')
4705
4706 def test_project_merge_mode_merge_resolve(self):
4707 self._test_merge('merge-resolve')
4708
4709 def test_project_merge_mode_cherrypick(self):
4710 expected_messages = [
4711 'initial commit',
4712 'add content from fixture',
4713 'A-1',
4714 'B-1',
4715 'C-1']
4716 result = self._test_project_merge_mode('cherry-pick')
4717 self.assertEqual(result, expected_messages)
Adam Gandelman4da00f62016-12-09 15:47:33 -08004718
4719 def test_merge_branch(self):
4720 "Test that the right commits are on alternate branches"
4721 self.create_branch('org/project-merge-branches', 'mp')
4722
Paul Belanger174a8272017-03-14 13:20:10 -04004723 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004724 A = self.fake_gerrit.addFakeChange(
4725 'org/project-merge-branches', 'mp', 'A')
4726 B = self.fake_gerrit.addFakeChange(
4727 'org/project-merge-branches', 'mp', 'B')
4728 C = self.fake_gerrit.addFakeChange(
4729 'org/project-merge-branches', 'mp', 'C')
4730 A.addApproval('code-review', 2)
4731 B.addApproval('code-review', 2)
4732 C.addApproval('code-review', 2)
4733 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4734 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4735 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4736 self.waitUntilSettled()
4737
Paul Belanger174a8272017-03-14 13:20:10 -04004738 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004739 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004740 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004741 self.waitUntilSettled()
Paul Belanger174a8272017-03-14 13:20:10 -04004742 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004743 self.waitUntilSettled()
4744
4745 build = self.builds[-1]
4746 self.assertEqual(self.getParameter(build, 'ZUUL_BRANCH'), 'mp')
4747 ref = self.getParameter(build, 'ZUUL_REF')
James E. Blair2a535672017-04-27 12:03:15 -07004748 path = os.path.join(build.jobdir.src_root, 'review.example.com',
4749 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004750 repo = git.Repo(path)
4751
4752 repo_messages = [c.message.strip() for c in repo.iter_commits(ref)]
4753 repo_messages.reverse()
4754 correct_messages = [
4755 'initial commit',
4756 'add content from fixture',
4757 'mp commit',
4758 'A-1', 'B-1', 'C-1']
4759 self.assertEqual(repo_messages, correct_messages)
4760
Paul Belanger174a8272017-03-14 13:20:10 -04004761 self.executor_server.hold_jobs_in_build = False
4762 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004763 self.waitUntilSettled()
4764
4765 def test_merge_multi_branch(self):
4766 "Test that dependent changes on multiple branches are merged"
4767 self.create_branch('org/project-merge-branches', 'mp')
4768
Paul Belanger174a8272017-03-14 13:20:10 -04004769 self.executor_server.hold_jobs_in_build = True
Adam Gandelman4da00f62016-12-09 15:47:33 -08004770 A = self.fake_gerrit.addFakeChange(
4771 'org/project-merge-branches', 'master', 'A')
4772 B = self.fake_gerrit.addFakeChange(
4773 'org/project-merge-branches', 'mp', 'B')
4774 C = self.fake_gerrit.addFakeChange(
4775 'org/project-merge-branches', 'master', 'C')
4776 A.addApproval('code-review', 2)
4777 B.addApproval('code-review', 2)
4778 C.addApproval('code-review', 2)
4779 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
4780 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
4781 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
4782 self.waitUntilSettled()
4783
4784 job_A = None
4785 for job in self.builds:
4786 if 'project-merge' in job.name:
4787 job_A = job
4788 ref_A = self.getParameter(job_A, 'ZUUL_REF')
4789 commit_A = self.getParameter(job_A, 'ZUUL_COMMIT')
4790 self.log.debug("Got Zuul ref for change A: %s" % ref_A)
4791 self.log.debug("Got Zuul commit for change A: %s" % commit_A)
4792
James E. Blair2a535672017-04-27 12:03:15 -07004793 path = os.path.join(job_A.jobdir.src_root, 'review.example.com',
4794 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004795 repo = git.Repo(path)
4796 repo_messages = [c.message.strip()
4797 for c in repo.iter_commits(ref_A)]
4798 repo_messages.reverse()
4799 correct_messages = [
4800 'initial commit', 'add content from fixture', 'A-1']
4801 self.assertEqual(repo_messages, correct_messages)
4802
Paul Belanger174a8272017-03-14 13:20:10 -04004803 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004804 self.waitUntilSettled()
4805
4806 job_B = None
4807 for job in self.builds:
4808 if 'project-merge' in job.name:
4809 job_B = job
4810 ref_B = self.getParameter(job_B, 'ZUUL_REF')
4811 commit_B = self.getParameter(job_B, 'ZUUL_COMMIT')
4812 self.log.debug("Got Zuul ref for change B: %s" % ref_B)
4813 self.log.debug("Got Zuul commit for change B: %s" % commit_B)
4814
James E. Blair2a535672017-04-27 12:03:15 -07004815 path = os.path.join(job_B.jobdir.src_root, 'review.example.com',
4816 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004817 repo = git.Repo(path)
4818 repo_messages = [c.message.strip()
4819 for c in repo.iter_commits(ref_B)]
4820 repo_messages.reverse()
4821 correct_messages = [
4822 'initial commit', 'add content from fixture', 'mp commit', 'B-1']
4823 self.assertEqual(repo_messages, correct_messages)
4824
Paul Belanger174a8272017-03-14 13:20:10 -04004825 self.executor_server.release('.*-merge')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004826 self.waitUntilSettled()
4827
4828 job_C = None
4829 for job in self.builds:
4830 if 'project-merge' in job.name:
4831 job_C = job
4832 ref_C = self.getParameter(job_C, 'ZUUL_REF')
4833 commit_C = self.getParameter(job_C, 'ZUUL_COMMIT')
4834 self.log.debug("Got Zuul ref for change C: %s" % ref_C)
4835 self.log.debug("Got Zuul commit for change C: %s" % commit_C)
James E. Blair2a535672017-04-27 12:03:15 -07004836 path = os.path.join(job_C.jobdir.src_root, 'review.example.com',
4837 'org/project-merge-branches')
Adam Gandelman4da00f62016-12-09 15:47:33 -08004838 repo = git.Repo(path)
4839 repo_messages = [c.message.strip()
4840 for c in repo.iter_commits(ref_C)]
4841
4842 repo_messages.reverse()
4843 correct_messages = [
4844 'initial commit', 'add content from fixture',
4845 'A-1', 'C-1']
4846 # Ensure the right commits are in the history for this ref
4847 self.assertEqual(repo_messages, correct_messages)
4848
Paul Belanger174a8272017-03-14 13:20:10 -04004849 self.executor_server.hold_jobs_in_build = False
4850 self.executor_server.release()
Adam Gandelman4da00f62016-12-09 15:47:33 -08004851 self.waitUntilSettled()
Tobias Henkel9a0e1942017-03-20 16:16:02 +01004852
4853
James E. Blair9ea0d0b2017-04-20 09:27:15 -07004854class TestSemaphore(ZuulTestCase):
4855 tenant_config_file = 'config/semaphore/main.yaml'
4856
4857 def test_semaphore_one(self):
4858 "Test semaphores with max=1 (mutex)"
4859 tenant = self.sched.abide.tenants.get('tenant-one')
4860
4861 self.executor_server.hold_jobs_in_build = True
4862
4863 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
4864 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
4865 self.assertFalse('test-semaphore' in
4866 tenant.semaphore_handler.semaphores)
4867
4868 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4869 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4870 self.waitUntilSettled()
4871
4872 self.assertEqual(len(self.builds), 3)
4873 self.assertEqual(self.builds[0].name, 'project-test1')
4874 self.assertEqual(self.builds[1].name, 'semaphore-one-test1')
4875 self.assertEqual(self.builds[2].name, 'project-test1')
4876
4877 self.executor_server.release('semaphore-one-test1')
4878 self.waitUntilSettled()
4879
4880 self.assertEqual(len(self.builds), 3)
4881 self.assertEqual(self.builds[0].name, 'project-test1')
4882 self.assertEqual(self.builds[1].name, 'project-test1')
4883 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4884 self.assertTrue('test-semaphore' in
4885 tenant.semaphore_handler.semaphores)
4886
4887 self.executor_server.release('semaphore-one-test2')
4888 self.waitUntilSettled()
4889
4890 self.assertEqual(len(self.builds), 3)
4891 self.assertEqual(self.builds[0].name, 'project-test1')
4892 self.assertEqual(self.builds[1].name, 'project-test1')
4893 self.assertEqual(self.builds[2].name, 'semaphore-one-test1')
4894 self.assertTrue('test-semaphore' in
4895 tenant.semaphore_handler.semaphores)
4896
4897 self.executor_server.release('semaphore-one-test1')
4898 self.waitUntilSettled()
4899
4900 self.assertEqual(len(self.builds), 3)
4901 self.assertEqual(self.builds[0].name, 'project-test1')
4902 self.assertEqual(self.builds[1].name, 'project-test1')
4903 self.assertEqual(self.builds[2].name, 'semaphore-one-test2')
4904 self.assertTrue('test-semaphore' in
4905 tenant.semaphore_handler.semaphores)
4906
4907 self.executor_server.release('semaphore-one-test2')
4908 self.waitUntilSettled()
4909
4910 self.assertEqual(len(self.builds), 2)
4911 self.assertEqual(self.builds[0].name, 'project-test1')
4912 self.assertEqual(self.builds[1].name, 'project-test1')
4913 self.assertFalse('test-semaphore' in
4914 tenant.semaphore_handler.semaphores)
4915
4916 self.executor_server.hold_jobs_in_build = False
4917 self.executor_server.release()
4918
4919 self.waitUntilSettled()
4920 self.assertEqual(len(self.builds), 0)
4921
4922 self.assertEqual(A.reported, 1)
4923 self.assertEqual(B.reported, 1)
4924 self.assertFalse('test-semaphore' in
4925 tenant.semaphore_handler.semaphores)
4926
4927 def test_semaphore_two(self):
4928 "Test semaphores with max>1"
4929 tenant = self.sched.abide.tenants.get('tenant-one')
4930
4931 self.executor_server.hold_jobs_in_build = True
4932 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
4933 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
4934 self.assertFalse('test-semaphore-two' in
4935 tenant.semaphore_handler.semaphores)
4936
4937 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
4938 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
4939 self.waitUntilSettled()
4940
4941 self.assertEqual(len(self.builds), 4)
4942 self.assertEqual(self.builds[0].name, 'project-test1')
4943 self.assertEqual(self.builds[1].name, 'semaphore-two-test1')
4944 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
4945 self.assertEqual(self.builds[3].name, 'project-test1')
4946 self.assertTrue('test-semaphore-two' in
4947 tenant.semaphore_handler.semaphores)
4948 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4949 'test-semaphore-two', [])), 2)
4950
4951 self.executor_server.release('semaphore-two-test1')
4952 self.waitUntilSettled()
4953
4954 self.assertEqual(len(self.builds), 4)
4955 self.assertEqual(self.builds[0].name, 'project-test1')
4956 self.assertEqual(self.builds[1].name, 'semaphore-two-test2')
4957 self.assertEqual(self.builds[2].name, 'project-test1')
4958 self.assertEqual(self.builds[3].name, 'semaphore-two-test1')
4959 self.assertTrue('test-semaphore-two' in
4960 tenant.semaphore_handler.semaphores)
4961 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4962 'test-semaphore-two', [])), 2)
4963
4964 self.executor_server.release('semaphore-two-test2')
4965 self.waitUntilSettled()
4966
4967 self.assertEqual(len(self.builds), 4)
4968 self.assertEqual(self.builds[0].name, 'project-test1')
4969 self.assertEqual(self.builds[1].name, 'project-test1')
4970 self.assertEqual(self.builds[2].name, 'semaphore-two-test1')
4971 self.assertEqual(self.builds[3].name, 'semaphore-two-test2')
4972 self.assertTrue('test-semaphore-two' in
4973 tenant.semaphore_handler.semaphores)
4974 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4975 'test-semaphore-two', [])), 2)
4976
4977 self.executor_server.release('semaphore-two-test1')
4978 self.waitUntilSettled()
4979
4980 self.assertEqual(len(self.builds), 3)
4981 self.assertEqual(self.builds[0].name, 'project-test1')
4982 self.assertEqual(self.builds[1].name, 'project-test1')
4983 self.assertEqual(self.builds[2].name, 'semaphore-two-test2')
4984 self.assertTrue('test-semaphore-two' in
4985 tenant.semaphore_handler.semaphores)
4986 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
4987 'test-semaphore-two', [])), 1)
4988
4989 self.executor_server.release('semaphore-two-test2')
4990 self.waitUntilSettled()
4991
4992 self.assertEqual(len(self.builds), 2)
4993 self.assertEqual(self.builds[0].name, 'project-test1')
4994 self.assertEqual(self.builds[1].name, 'project-test1')
4995 self.assertFalse('test-semaphore-two' in
4996 tenant.semaphore_handler.semaphores)
4997
4998 self.executor_server.hold_jobs_in_build = False
4999 self.executor_server.release()
5000
5001 self.waitUntilSettled()
5002 self.assertEqual(len(self.builds), 0)
5003
5004 self.assertEqual(A.reported, 1)
5005 self.assertEqual(B.reported, 1)
5006
5007 def test_semaphore_abandon(self):
5008 "Test abandon with job semaphores"
5009 self.executor_server.hold_jobs_in_build = True
5010 tenant = self.sched.abide.tenants.get('tenant-one')
5011 check_pipeline = tenant.layout.pipelines['check']
5012
5013 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5014 self.assertFalse('test-semaphore' in
5015 tenant.semaphore_handler.semaphores)
5016
5017 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5018 self.waitUntilSettled()
5019
5020 self.assertTrue('test-semaphore' in
5021 tenant.semaphore_handler.semaphores)
5022
5023 self.fake_gerrit.addEvent(A.getChangeAbandonedEvent())
5024 self.waitUntilSettled()
5025
5026 # The check pipeline should be empty
5027 items = check_pipeline.getAllItems()
5028 self.assertEqual(len(items), 0)
5029
5030 # The semaphore should be released
5031 self.assertFalse('test-semaphore' in
5032 tenant.semaphore_handler.semaphores)
5033
5034 self.executor_server.hold_jobs_in_build = False
5035 self.executor_server.release()
5036 self.waitUntilSettled()
5037
5038 def test_semaphore_reconfigure(self):
5039 "Test reconfigure with job semaphores"
5040 self.executor_server.hold_jobs_in_build = True
5041 tenant = self.sched.abide.tenants.get('tenant-one')
5042 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A')
5043 self.assertFalse('test-semaphore' in
5044 tenant.semaphore_handler.semaphores)
5045
5046 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5047 self.waitUntilSettled()
5048
5049 self.assertTrue('test-semaphore' in
5050 tenant.semaphore_handler.semaphores)
5051
5052 # reconfigure without layout change
5053 self.sched.reconfigure(self.config)
5054 self.waitUntilSettled()
5055 tenant = self.sched.abide.tenants.get('tenant-one')
5056
5057 # semaphore still must be held
5058 self.assertTrue('test-semaphore' in
5059 tenant.semaphore_handler.semaphores)
5060
5061 self.commitConfigUpdate(
5062 'common-config',
5063 'config/semaphore/zuul-reconfiguration.yaml')
5064 self.sched.reconfigure(self.config)
5065 self.waitUntilSettled()
5066 tenant = self.sched.abide.tenants.get('tenant-one')
5067
5068 self.executor_server.release('project-test1')
5069 self.waitUntilSettled()
5070
5071 # There should be no builds anymore
5072 self.assertEqual(len(self.builds), 0)
5073
5074 # The semaphore should be released
5075 self.assertFalse('test-semaphore' in
5076 tenant.semaphore_handler.semaphores)
5077
5078
Tobias Henkel9a0e1942017-03-20 16:16:02 +01005079class TestSemaphoreMultiTenant(ZuulTestCase):
5080 tenant_config_file = 'config/multi-tenant-semaphore/main.yaml'
5081
5082 def test_semaphore_tenant_isolation(self):
5083 "Test semaphores in multiple tenants"
5084
5085 self.waitUntilSettled()
5086 tenant_one = self.sched.abide.tenants.get('tenant-one')
5087 tenant_two = self.sched.abide.tenants.get('tenant-two')
5088
5089 self.executor_server.hold_jobs_in_build = True
5090 A = self.fake_gerrit.addFakeChange('org/project1', 'master', 'A')
5091 B = self.fake_gerrit.addFakeChange('org/project1', 'master', 'B')
5092 C = self.fake_gerrit.addFakeChange('org/project2', 'master', 'C')
5093 D = self.fake_gerrit.addFakeChange('org/project2', 'master', 'D')
5094 E = self.fake_gerrit.addFakeChange('org/project2', 'master', 'E')
5095 self.assertFalse('test-semaphore' in
5096 tenant_one.semaphore_handler.semaphores)
5097 self.assertFalse('test-semaphore' in
5098 tenant_two.semaphore_handler.semaphores)
5099
5100 # add patches to project1 of tenant-one
5101 self.fake_gerrit.addEvent(A.getPatchsetCreatedEvent(1))
5102 self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
5103 self.waitUntilSettled()
5104
5105 # one build of project1-test1 must run
5106 # semaphore of tenant-one must be acquired once
5107 # semaphore of tenant-two must not be acquired
5108 self.assertEqual(len(self.builds), 1)
5109 self.assertEqual(self.builds[0].name, 'project1-test1')
5110 self.assertTrue('test-semaphore' in
5111 tenant_one.semaphore_handler.semaphores)
5112 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5113 'test-semaphore', [])), 1)
5114 self.assertFalse('test-semaphore' in
5115 tenant_two.semaphore_handler.semaphores)
5116
5117 # add patches to project2 of tenant-two
5118 self.fake_gerrit.addEvent(C.getPatchsetCreatedEvent(1))
5119 self.fake_gerrit.addEvent(D.getPatchsetCreatedEvent(1))
5120 self.fake_gerrit.addEvent(E.getPatchsetCreatedEvent(1))
5121 self.waitUntilSettled()
5122
5123 # one build of project1-test1 must run
5124 # two builds of project2-test1 must run
5125 # semaphore of tenant-one must be acquired once
5126 # semaphore of tenant-two must be acquired twice
5127 self.assertEqual(len(self.builds), 3)
5128 self.assertEqual(self.builds[0].name, 'project1-test1')
5129 self.assertEqual(self.builds[1].name, 'project2-test1')
5130 self.assertEqual(self.builds[2].name, 'project2-test1')
5131 self.assertTrue('test-semaphore' in
5132 tenant_one.semaphore_handler.semaphores)
5133 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5134 'test-semaphore', [])), 1)
5135 self.assertTrue('test-semaphore' in
5136 tenant_two.semaphore_handler.semaphores)
5137 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5138 'test-semaphore', [])), 2)
5139
5140 self.executor_server.release('project1-test1')
5141 self.waitUntilSettled()
5142
5143 # one build of project1-test1 must run
5144 # two builds of project2-test1 must run
5145 # semaphore of tenant-one must be acquired once
5146 # semaphore of tenant-two must be acquired twice
5147 self.assertEqual(len(self.builds), 3)
5148 self.assertEqual(self.builds[0].name, 'project2-test1')
5149 self.assertEqual(self.builds[1].name, 'project2-test1')
5150 self.assertEqual(self.builds[2].name, 'project1-test1')
5151 self.assertTrue('test-semaphore' in
5152 tenant_one.semaphore_handler.semaphores)
5153 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5154 'test-semaphore', [])), 1)
5155 self.assertTrue('test-semaphore' in
5156 tenant_two.semaphore_handler.semaphores)
5157 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5158 'test-semaphore', [])), 2)
5159
5160 self.executor_server.release('project2-test1')
5161 self.waitUntilSettled()
5162
5163 # one build of project1-test1 must run
5164 # one build of project2-test1 must run
5165 # semaphore of tenant-one must be acquired once
5166 # semaphore of tenant-two must be acquired once
5167 self.assertEqual(len(self.builds), 2)
5168 self.assertTrue('test-semaphore' in
5169 tenant_one.semaphore_handler.semaphores)
5170 self.assertEqual(len(tenant_one.semaphore_handler.semaphores.get(
5171 'test-semaphore', [])), 1)
5172 self.assertTrue('test-semaphore' in
5173 tenant_two.semaphore_handler.semaphores)
5174 self.assertEqual(len(tenant_two.semaphore_handler.semaphores.get(
5175 'test-semaphore', [])), 1)
5176
5177 self.executor_server.hold_jobs_in_build = False
5178 self.executor_server.release()
5179
5180 self.waitUntilSettled()
5181
5182 # no build must run
5183 # semaphore of tenant-one must not be acquired
5184 # semaphore of tenant-two must not be acquired
5185 self.assertEqual(len(self.builds), 0)
5186 self.assertFalse('test-semaphore' in
5187 tenant_one.semaphore_handler.semaphores)
5188 self.assertFalse('test-semaphore' in
5189 tenant_two.semaphore_handler.semaphores)
5190
5191 self.assertEqual(A.reported, 1)
5192 self.assertEqual(B.reported, 1)
5193
5194
5195class TestSemaphoreInRepo(ZuulTestCase):
5196 tenant_config_file = 'config/in-repo/main.yaml'
5197
5198 def test_semaphore_in_repo(self):
5199 "Test semaphores in repo config"
5200
5201 # This tests dynamic semaphore handling in project repos. The semaphore
5202 # max value should not be evaluated dynamically but must be updated
5203 # after the change lands.
5204
5205 self.waitUntilSettled()
5206 tenant = self.sched.abide.tenants.get('tenant-one')
5207
5208 in_repo_conf = textwrap.dedent(
5209 """
5210 - job:
5211 name: project-test2
5212 semaphore: test-semaphore
5213
5214 - project:
5215 name: org/project
5216 tenant-one-gate:
5217 jobs:
5218 - project-test2
5219
5220 # the max value in dynamic layout must be ignored
5221 - semaphore:
5222 name: test-semaphore
5223 max: 2
5224 """)
5225
5226 in_repo_playbook = textwrap.dedent(
5227 """
5228 - hosts: all
5229 tasks: []
5230 """)
5231
5232 file_dict = {'.zuul.yaml': in_repo_conf,
5233 'playbooks/project-test2.yaml': in_repo_playbook}
5234 A = self.fake_gerrit.addFakeChange('org/project', 'master', 'A',
5235 files=file_dict)
5236 B = self.fake_gerrit.addFakeChange('org/project', 'master', 'B')
5237 C = self.fake_gerrit.addFakeChange('org/project', 'master', 'C')
5238 B.setDependsOn(A, 1)
5239 C.setDependsOn(A, 1)
5240
5241 self.executor_server.hold_jobs_in_build = True
5242
5243 A.addApproval('code-review', 2)
5244 B.addApproval('code-review', 2)
5245 C.addApproval('code-review', 2)
5246 self.fake_gerrit.addEvent(A.addApproval('approved', 1))
5247 self.fake_gerrit.addEvent(B.addApproval('approved', 1))
5248 self.fake_gerrit.addEvent(C.addApproval('approved', 1))
5249 self.waitUntilSettled()
5250
5251 # check that the layout in a queue item still has max value of 1
5252 # for test-semaphore
5253 pipeline = tenant.layout.pipelines.get('tenant-one-gate')
5254 queue = None
5255 for queue_candidate in pipeline.queues:
5256 if queue_candidate.name == 'org/project':
5257 queue = queue_candidate
5258 break
5259 queue_item = queue.queue[0]
5260 item_dynamic_layout = queue_item.current_build_set.layout
5261 dynamic_test_semaphore = \
5262 item_dynamic_layout.semaphores.get('test-semaphore')
5263 self.assertEqual(dynamic_test_semaphore.max, 1)
5264
5265 # one build must be in queue, one semaphores acquired
5266 self.assertEqual(len(self.builds), 1)
5267 self.assertEqual(self.builds[0].name, 'project-test2')
5268 self.assertTrue('test-semaphore' in
5269 tenant.semaphore_handler.semaphores)
5270 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5271 'test-semaphore', [])), 1)
5272
5273 self.executor_server.release('project-test2')
5274 self.waitUntilSettled()
5275
5276 # change A must be merged
5277 self.assertEqual(A.data['status'], 'MERGED')
5278 self.assertEqual(A.reported, 2)
5279
5280 # send change-merged event as the gerrit mock doesn't send it
5281 self.fake_gerrit.addEvent(A.getChangeMergedEvent())
5282 self.waitUntilSettled()
5283
5284 # now that change A was merged, the new semaphore max must be effective
5285 tenant = self.sched.abide.tenants.get('tenant-one')
5286 self.assertEqual(tenant.layout.semaphores.get('test-semaphore').max, 2)
5287
5288 # two builds must be in queue, two semaphores acquired
5289 self.assertEqual(len(self.builds), 2)
5290 self.assertEqual(self.builds[0].name, 'project-test2')
5291 self.assertEqual(self.builds[1].name, 'project-test2')
5292 self.assertTrue('test-semaphore' in
5293 tenant.semaphore_handler.semaphores)
5294 self.assertEqual(len(tenant.semaphore_handler.semaphores.get(
5295 'test-semaphore', [])), 2)
5296
5297 self.executor_server.release('project-test2')
5298 self.waitUntilSettled()
5299
5300 self.assertEqual(len(self.builds), 0)
5301 self.assertFalse('test-semaphore' in
5302 tenant.semaphore_handler.semaphores)
5303
5304 self.executor_server.hold_jobs_in_build = False
5305 self.executor_server.release()
5306
5307 self.waitUntilSettled()
5308 self.assertEqual(len(self.builds), 0)
5309
5310 self.assertEqual(A.reported, 2)
5311 self.assertEqual(B.reported, 2)
5312 self.assertEqual(C.reported, 2)