Paul Belanger | 8259510 | 2013-04-08 11:30:51 -0400 | [diff] [blame] | 1 | Zuul |
| 2 | ==== |
James E. Blair | d65e22d | 2012-06-01 13:50:21 -0700 | [diff] [blame] | 3 | |
James E. Blair | 4c3e0a3 | 2016-10-12 14:15:20 -0700 | [diff] [blame] | 4 | Zuul is a project gating system developed for the OpenStack Project. |
James E. Blair | d65e22d | 2012-06-01 13:50:21 -0700 | [diff] [blame] | 5 | |
James E. Blair | 7526074 | 2016-10-12 15:12:06 -0700 | [diff] [blame] | 6 | We are currently engaged in a significant development effort in |
| 7 | preparation for the third major version of Zuul. We call this effort |
| 8 | `Zuul v3`_ and it is described in more detail below. |
| 9 | |
Paul Belanger | 8259510 | 2013-04-08 11:30:51 -0400 | [diff] [blame] | 10 | Contributing |
| 11 | ------------ |
James E. Blair | d65e22d | 2012-06-01 13:50:21 -0700 | [diff] [blame] | 12 | |
James E. Blair | 1a42640 | 2016-10-12 15:17:07 -0700 | [diff] [blame] | 13 | We are currently engaged in a significant development effort in |
| 14 | preparation for the third major version of Zuul. We call this effort |
| 15 | `Zuul v3`_ and it is described in this file in the `feature/zuulv3` |
| 16 | branch of this repo. |
| 17 | |
Anita Kuno | 84ed8cd | 2013-12-17 10:14:45 -0500 | [diff] [blame] | 18 | To browse the latest code, see: https://git.openstack.org/cgit/openstack-infra/zuul/tree/ |
| 19 | To clone the latest code, use `git clone git://git.openstack.org/openstack-infra/zuul` |
James E. Blair | d65e22d | 2012-06-01 13:50:21 -0700 | [diff] [blame] | 20 | |
Michael Krotscheck | 8c81dc3 | 2014-11-11 15:59:06 -0800 | [diff] [blame] | 21 | Bugs are handled at: https://storyboard.openstack.org/#!/project/679 |
James E. Blair | d65e22d | 2012-06-01 13:50:21 -0700 | [diff] [blame] | 22 | |
James E. Blair | 4c3e0a3 | 2016-10-12 14:15:20 -0700 | [diff] [blame] | 23 | Code reviews are, as you might expect, handled by gerrit at |
| 24 | https://review.openstack.org |
James E. Blair | d65e22d | 2012-06-01 13:50:21 -0700 | [diff] [blame] | 25 | |
James E. Blair | 4c3e0a3 | 2016-10-12 14:15:20 -0700 | [diff] [blame] | 26 | Use `git review` to submit patches (after creating a Gerrit account |
| 27 | that links to your launchpad account). Example:: |
James E. Blair | d65e22d | 2012-06-01 13:50:21 -0700 | [diff] [blame] | 28 | |
| 29 | # Do your commits |
Paul Belanger | 8259510 | 2013-04-08 11:30:51 -0400 | [diff] [blame] | 30 | $ git review |
Ori Livneh | 7191ee8 | 2013-05-02 19:13:53 -0700 | [diff] [blame] | 31 | # Enter your username if prompted |
James E. Blair | 7526074 | 2016-10-12 15:12:06 -0700 | [diff] [blame] | 32 | |
| 33 | Zuul v3 |
| 34 | ------- |
| 35 | |
| 36 | The Zuul v3 effort involves significant changes to Zuul, and its |
| 37 | companion program, Nodepool. The intent is for Zuul to become more |
| 38 | generally useful outside of the OpenStack community. This is the best |
| 39 | way to get started with this effort: |
| 40 | |
| 41 | 1) Read the Zuul v3 spec: http://specs.openstack.org/openstack-infra/infra-specs/specs/zuulv3.html |
| 42 | |
| 43 | We use specification documents like this to describe large efforts |
| 44 | where we want to make sure that all the participants are in |
| 45 | agreement about what will happen and generally how before starting |
| 46 | development. These specs should contain enough information for |
| 47 | people to evaluate the proposal generally, and sometimes include |
| 48 | specific details that need to be agreed upon in advance. They are |
| 49 | living documents which can change as work gets underway. However, |
| 50 | every change or detail does not need to be reflected in the spec -- |
| 51 | most work is simply done with patches (and revised if necessary in |
| 52 | code review). |
| 53 | |
| 54 | 2) Read the Nodepool build-workers spec: http://specs.openstack.org/openstack-infra/infra-specs/specs/nodepool-zookeeper-workers.html |
| 55 | |
| 56 | 3) Review any proposed updates to these specs: https://review.openstack.org/#/q/status:open+project:openstack-infra/infra-specs+topic:zuulv3 |
| 57 | |
| 58 | Some of the information in the specs may be effectively superceded |
| 59 | by changes here, which are still undergoing review. |
| 60 | |
| 61 | 4) Read documentation on the internal data model and testing: http://docs.openstack.org/infra/zuul/feature/zuulv3/internals.html |
| 62 | |
| 63 | The general philosophy for Zuul tests is to perform functional |
| 64 | testing of either the individual component or the entire end-to-end |
| 65 | system with external systems (such as Gerrit) replaced with fakes. |
| 66 | Before adding additional unit tests with a narrower focus, consider |
| 67 | whether they add value to this system or are merely duplicative of |
| 68 | functional tests. |
| 69 | |
| 70 | 5) Review open changes: https://review.openstack.org/#/q/status:open+branch:feature/zuulv3 |
| 71 | |
| 72 | We find that the most valuable code reviews are ones that spot |
| 73 | problems with the proposed change, or raise questions about how |
| 74 | that might affect other systems or subsequent work. It is also a |
| 75 | great way to stay involved as a team in work performed by others |
| 76 | (for instance, by observing and asking questions about development |
| 77 | while it is in progress). We try not to sweat the small things and |
| 78 | don't worry too much about style suggestions or other nitpicky |
| 79 | things (unless they are relevant -- for instance, a -1 vote on a |
| 80 | change that introduces a yaml change out of character with existing |
| 81 | conventions is useful because it makes the system more |
| 82 | user-friendly; a -1 vote on a change which uses a sub-optimal line |
| 83 | breaking strategy is probably not the best use of anyone's time). |
| 84 | |
| 85 | 6) Join #zuul on Freenode. Let others (especially jeblair who is |
| 86 | trying to coordinate and prioritize work) know what you would like |
| 87 | to work on. |
| 88 | |
James E. Blair | d5dcaa1 | 2016-12-05 13:39:30 -0800 | [diff] [blame] | 89 | 7) Check storyboard for status of current work items: https://storyboard.openstack.org/#!/board/41 |
James E. Blair | 7526074 | 2016-10-12 15:12:06 -0700 | [diff] [blame] | 90 | |
James E. Blair | 903a746 | 2017-03-07 09:28:40 -0800 | [diff] [blame] | 91 | Work items tagged with ``low-hanging-fruit`` are tasks that have |
| 92 | been identified as not requiring an expansive knowledge of the |
| 93 | system. They may still require either some knowledge or |
| 94 | investigation into a specific area, but should be suitable for a |
| 95 | developer who is becoming acquainted with the system. Those items |
| 96 | can be found at: |
| 97 | https://storyboard.openstack.org/#!/story/list?tags=low-hanging-fruit&tags=zuulv3 |
| 98 | |
James E. Blair | 7526074 | 2016-10-12 15:12:06 -0700 | [diff] [blame] | 99 | Once you are up to speed on those items, it will be helpful to know |
| 100 | the following: |
| 101 | |
| 102 | * Zuul v3 includes some substantial changes to Zuul, and in order to |
| 103 | implement them quickly and simultaneously, we temporarily disabled |
| 104 | most of the test suite. That test suite still has relevance, but |
| 105 | tests are likely to need updating individually, with reasons ranging |
| 106 | from something simple such as a test-framework method changing its |
| 107 | name, to more substantial issues, such as a feature being removed as |
| 108 | part of the v3 work. Each test will need to be evaluated |
James E. Blair | d5dcaa1 | 2016-12-05 13:39:30 -0800 | [diff] [blame] | 109 | individually. Feel free to, at any time, claim a test name in this |
| 110 | story and work on re-enabling it: |
| 111 | https://storyboard.openstack.org/#!/story/2000773 |
James E. Blair | 7526074 | 2016-10-12 15:12:06 -0700 | [diff] [blame] | 112 | |
| 113 | * Because of the importance of external systems, as well as the number |
| 114 | of internal Zuul components, actually running Zuul in a development |
| 115 | mode quickly becomes unweildy (imagine uploading changes to Gerrit |
| 116 | repeatedly while altering Zuul source code). Instead, the best way |
| 117 | to develop with Zuul is in fact to write a functional test. |
| 118 | Construct a test to fully simulate the series of events you want to |
| 119 | see, then run it in the foreground. For example:: |
| 120 | |
Paul Belanger | 174a827 | 2017-03-14 13:20:10 -0400 | [diff] [blame] | 121 | .tox/py27/bin/python -m testtools.run tests.test_scheduler.TestScheduler.test_jobs_executed |
James E. Blair | 7526074 | 2016-10-12 15:12:06 -0700 | [diff] [blame] | 122 | |
| 123 | See TESTING.rst for more information. |
| 124 | |
| 125 | * There are many occasions, when working on sweeping changes to Zuul |
| 126 | v3, we left notes for future work items in the code marked with |
| 127 | "TODOv3". These represent potentially serious missing functionality |
| 128 | or other issues which must be resolved before an initial v3 release |
| 129 | (unlike a more conventional TODO note, these really can not be left |
| 130 | indefinitely). These present an opportunity to identify work items |
| 131 | not otherwise tracked. The names associated with TODO or TODOv3 |
| 132 | items do not mean that only that person can address them -- they |
| 133 | simply reflect who to ask to explain the item in more detail if it |
| 134 | is too cryptic. In your own work, feel free to leave TODOv3 notes |
| 135 | if a change would otherwise become too large or unweildy. |
James E. Blair | a3c03ed | 2016-12-05 13:39:39 -0800 | [diff] [blame] | 136 | |
| 137 | Roadmap |
| 138 | ------- |
| 139 | |
James E. Blair | 903a746 | 2017-03-07 09:28:40 -0800 | [diff] [blame] | 140 | * Begin using Zuul v3 to run jobs for Zuul itself |
James E. Blair | a3c03ed | 2016-12-05 13:39:39 -0800 | [diff] [blame] | 141 | * Implement a shim to translate Zuul v2 demand into Nodepool Zookeeper |
| 142 | launcher requests |
| 143 | * Begin using Zookeeper based Nodepool launchers with Zuul v2.5 in |
| 144 | OpenStack Infra |
James E. Blair | a3c03ed | 2016-12-05 13:39:39 -0800 | [diff] [blame] | 145 | * Move OpenStack Infra to use Zuul v3 |
| 146 | * Implement Github support |
| 147 | * Begin using Zuul v3 to run tests on Ansible repos |
| 148 | * Implement support in Nodepool for non-OpenStack clouds |
| 149 | * Add native container support to Zuul / Nodepool |