commit c57b6b7090eab6a83c57175185e53166ab532675
author Heinrich Schuchardt <xypron.glpk@gmx.de> Sun Mar 18 12:01:06 2018 +0100
committer Tom Rini <trini@konsulko.com> Fri Apr 06 20:45:28 2018 -0400
tree 4c0c2281eb94a6582fdb67c179241fb21f67cd11
parent 62896dcbf37b478f7f719e2ce456d9bfe91a291a

regulator: pbias: don't evaluate variable before assignment

We should not evaluate the value of reg before its value is set.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>

drivers/power/regulator/pbias_regulator.c

diff --git a/drivers/power/regulator/pbias_regulator.c b/drivers/power/regulator/pbias_regulator.c
index 116b7f4..adf589b 100644
--- a/drivers/power/regulator/pbias_regulator.c
+++ b/drivers/power/regulator/pbias_regulator.c
@@ -225,9 +225,6 @@
 	int rc;
 	u32 reg;
 
-	debug("Setting %s voltage to %s\n", p->name,
-	      (reg & p->vmode) ? "3.0v" : "1.8v");
-
 	rc = pmic_read(dev->parent, 0, (uint8_t *)&reg, sizeof(reg));
 	if (rc)
 		return rc;
@@ -239,6 +236,9 @@
 	else
 		return -EINVAL;
 
+	debug("Setting %s voltage to %s\n", p->name,
+	      (reg & p->vmode) ? "3.0v" : "1.8v");
+
 	return pmic_write(dev->parent, 0, (uint8_t *)&reg, sizeof(reg));
 }