commit b8b610e7d4c5e086f7e97592878527adfa744075
author Takahiro Kuwano <Takahiro.Kuwano@infineon.com> Tue Oct 15 13:08:33 2024 +0900
committer Tom Rini <trini@konsulko.com> Tue Oct 15 08:57:49 2024 -0600
tree 35c0e12fffcba8c9a14fa3bbc42bc7607f3bb6e1
parent 88057dab2cde8710ccc95d12fb312184e0b023ca

mtd: spi-nor: Check nor->info before setting macronix_octal_fixups

The macronix_octal_fixups should be set only when mfr and flags match.

Fixes: df3d5f9e41 ("mtd: spi-nor: add support for Macronix Octal flash")
Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Signed-off-by: Takahiro Kuwano <Takahiro.Kuwano@infineon.com>
Cc: JaimeLiao <jaimeliao.tw@gmail.com>

drivers/mtd/spi/spi-nor-core.c

diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c
index d39d0ee..466729c 100644
--- a/drivers/mtd/spi/spi-nor-core.c
+++ b/drivers/mtd/spi/spi-nor-core.c
@@ -4423,7 +4423,9 @@
 #endif
 
 #if CONFIG_IS_ENABLED(SPI_FLASH_MACRONIX)
-	nor->fixups = &macronix_octal_fixups;
+	if (JEDEC_MFR(nor->info) == SNOR_MFR_MACRONIX &&
+	    nor->info->flags & SPI_NOR_OCTAL_DTR_READ)
+		nor->fixups = &macronix_octal_fixups;
 #endif /* SPI_FLASH_MACRONIX */
 }