Add base class for sources
and test the all sources adhere to the set contract.
Also standardise the source (triggers to come) class names
to NameSource.
This will make it easier to do more sources in the future and also
add the possibility of loading sources dynamically.
Co-Authored-By: Gregory Haynes <greg@greghaynes.net>
Change-Id: I15b32013904f60873601dd7cc8fce3c158787de4
diff --git a/tests/base.py b/tests/base.py
index 7cd9de3..67de802 100755
--- a/tests/base.py
+++ b/tests/base.py
@@ -500,7 +500,7 @@
return ret
-class FakeGerritSource(zuul.source.gerrit.Gerrit):
+class FakeGerritSource(zuul.source.gerrit.GerritSource):
name = 'gerrit'
def __init__(self, upstream_root, *args):
diff --git a/tests/test_source.py b/tests/test_source.py
new file mode 100644
index 0000000..8a3e7d5
--- /dev/null
+++ b/tests/test_source.py
@@ -0,0 +1,25 @@
+# Copyright 2014 Rackspace Australia
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+import logging
+import testtools
+
+import zuul.source
+
+
+class TestGerritSource(testtools.TestCase):
+ log = logging.getLogger("zuul.test_source")
+
+ def test_source_name(self):
+ self.assertEqual('gerrit', zuul.source.gerrit.GerritSource.name)