Case sensitive label matching
After upgrading Gerrit to 2.13 our gate stopped working. The reason
for this is that after a successful gate run zuul does something like
'gerrit review --label verified=2 --submit'. The verified label in
Gerrit by default is configured as 'Verified'. The newer version of
gerrit behaves different now. It accepts the +2 vote on verified but
doesn't submit the patch anymore if the casing is not correct. This
forces us to specify the label in the same casing as gerrit
expects. In that case the tolower() in canMerge prevents the patch
from entering the gate.
In order to avoid confusion and be consistent, avoid any case
conversions and use the labels exactly as defined in Gerrit.
Note that this patch requires changes to the pipelines such that the
labels are spelled exactly as defined in Gerrit.
Change-Id: I9713a075e07b268e4f2620c0862c128158283c7c
diff --git a/doc/source/user/config.rst b/doc/source/user/config.rst
index c137918..6b63e49 100644
--- a/doc/source/user/config.rst
+++ b/doc/source/user/config.rst
@@ -115,10 +115,10 @@
- event: patchset-created
success:
my_gerrit:
- verified: 1
+ Verified: 1
failure:
my_gerrit
- verified: -1
+ Verified: -1
.. TODO: See TODO for more annotated examples of common pipeline configurations.
@@ -255,9 +255,9 @@
to match. Same format as "older-than".
Any other field is interpreted as a review category and value
- pair. For example ``verified: 1`` would require that the approval
+ pair. For example ``Verified: 1`` would require that the approval
be for a +1 vote in the "Verified" column. The value may either
- be a single value or a list: ``verified: [1, 2]`` would match
+ be a single value or a list: ``Verified: [1, 2]`` would match
either a +1 or +2 vote.
**open**
@@ -287,7 +287,7 @@
reject:
approval:
- - code-review: [-1, -2]
+ - Code-Review: [-1, -2]
**dequeue-on-new-patchset**
Normally, if a new patchset is uploaded to a change that is in a