Don't reload connections on HUP
Previous to the connection work zuul wouldn't stop triggers or therefore
the gerrit watcher on reload.
Reloading the gerrit connection causes challenges for the cache
management which are currently not handled and likely affecting memory
usage.
Rather than support dynamically reloading all of zuul.conf, just reload
the layout and logging and require a full restart for connection
changes to take effect.
This isn't a feature regression as particular changes to zuul.conf
weren't previously picked up (for example, gerrit credentials).
Change-Id: Iff77fbca6ab15c9636f6ae8f12bc1bad78f79aa9
diff --git a/doc/source/zuul.rst b/doc/source/zuul.rst
index d8d72e6..98e4bb8 100644
--- a/doc/source/zuul.rst
+++ b/doc/source/zuul.rst
@@ -997,9 +997,8 @@
If you send signal 1 (SIGHUP) to the zuul-server process, Zuul will
stop executing new jobs, wait until all executing jobs are finished,
-reload its configuration, and resume. Any values in any of the
-configuration files may be changed, except the location of Zuul's PID
-file (a change to that will be ignored until Zuul is restarted).
+reload its layout.yaml, and resume. Changes to any connections or
+the PID file will be ignored until Zuul is restarted.
If you send a SIGUSR1 to the zuul-server process, Zuul will stop
executing new jobs, wait until all executing jobs are finished,
diff --git a/zuul/cmd/server.py b/zuul/cmd/server.py
index 2aca4f2..b1cd050 100755
--- a/zuul/cmd/server.py
+++ b/zuul/cmd/server.py
@@ -61,12 +61,9 @@
def reconfigure_handler(self, signum, frame):
signal.signal(signal.SIGHUP, signal.SIG_IGN)
self.log.debug("Reconfiguration triggered")
- self.sched.stopConnections()
self.read_config()
self.setup_logging('zuul', 'log_config')
try:
- self.configure_connections()
- self.sched.registerConnections(self.connections)
self.sched.reconfigure(self.config)
except Exception:
self.log.exception("Reconfiguration failed:")