commit b0e9fc711a18a3fb0e82970ba3c7346cd349c594
author Zuul <zuul@review.openstack.org> Wed Sep 06 14:19:01 2017 +0000
committer Gerrit Code Review <review@openstack.org> Wed Sep 06 14:19:01 2017 +0000
tree f8c0d730a80c9ed4d083cbd99e0eb7a1f7852fac
parent 8038554e4ac8bdb225690e73a0a06f7776969c66
parent 32cf2ac9c7b3832adb124e66296d8d16971b3c9d

Merge "Close logging config file after write" into feature/zuulv3

zuul/ansible/logconfig.py

diff --git a/zuul/ansible/logconfig.py b/zuul/ansible/logconfig.py
index 7c3507b..5425d72 100644
--- a/zuul/ansible/logconfig.py
+++ b/zuul/ansible/logconfig.py
@@ -161,7 +161,8 @@
         logging.config.dictConfig(self._config)
 
     def writeJson(self, filename: str):
-        open(filename, 'w').write(json.dumps(self._config, indent=2))
+        with open(filename, 'w') as f:
+            f.write(json.dumps(self._config, indent=2))
 
 
 class JobLoggingConfig(DictLoggingConfig):