Update category mapping in tests
Use the newer form of spelled-out category names in tests since
that's what we're writing in config files now.
Change-Id: Ib679e54b53131280956cbda20b84f5602a4953c8
diff --git a/tests/base.py b/tests/base.py
index 9bbaf62..1661957 100755
--- a/tests/base.py
+++ b/tests/base.py
@@ -103,9 +103,9 @@
class FakeChange(object):
- categories = {'APRV': ('Approved', -1, 1),
- 'CRVW': ('Code-Review', -2, 2),
- 'VRFY': ('Verified', -2, 2)}
+ categories = {'approved': ('Approved', -1, 1),
+ 'code-review': ('Code-Review', -2, 2),
+ 'verified': ('Verified', -2, 2)}
def __init__(self, gerrit, number, project, branch, subject,
status='NEW', upstream_root=None, files={}):
@@ -260,7 +260,7 @@
"url": "https://hostname/3"},
"patchSet": self.patchsets[patchset - 1],
"author": {"name": "User Name"},
- "approvals": [{"type": "Code-Review",
+ "approvals": [{"type": "code-review",
"description": "Code-Review",
"value": "0"}],
"comment": "This is a comment"}
@@ -431,10 +431,11 @@
# happens they can add their own verified event into the queue.
# Nevertheless, we can update change with the new review in gerrit.
- for cat in ['CRVW', 'VRFY', 'APRV']:
- if cat in action:
+ for cat in action.keys():
+ if cat != 'submit':
change.addApproval(cat, action[cat], username=self.user)
+ # TODOv3(jeblair): can this be removed?
if 'label' in action:
parts = action['label'].split('=')
change.addApproval(parts[0], parts[2], username=self.user)