Add support to reject changes from approvals
Formally "support for negative requirements"
This change adds support to reject a change from entering a pipeline
based off any existing approvals. This is useful to stop queuing any
changes with a negative vote.
Two new options are added:
reject:
approval:
- ...
To the pipelines, and:
reject-approval:
- ...
To the triggers.
The approval format is the same for the "require approval" section.
Reject approvals could be considered a negative of the require section.
Change-Id: I3369920530e0b7439208b8fd43a9e75994860666
diff --git a/tests/fixtures/layouts/bad_reject.yaml b/tests/fixtures/layouts/bad_reject.yaml
new file mode 100644
index 0000000..b1e7f84
--- /dev/null
+++ b/tests/fixtures/layouts/bad_reject.yaml
@@ -0,0 +1,21 @@
+# Template is going to be called but missing a parameter
+
+pipelines:
+ - name: 'check'
+ manager: IndependentPipelineManager
+ require:
+ open: True
+ current-patchset: True
+ approval:
+ - verified: [1, 2]
+ username: jenkins
+ - workflow: 1
+ reject:
+ # Reject only takes 'approval', has no need for open etc..
+ open: True
+ approval:
+ - code-review: [-1, -2]
+ username: core-person
+ trigger:
+ gerrit:
+ - event: patchset-created