commit 530a4643982a2bc14c942329e576821a5f5b4abb
author Zuul <zuul@review.openstack.org> Sat Sep 30 20:39:23 2017 +0000
committer Gerrit Code Review <review@openstack.org> Sat Sep 30 20:39:23 2017 +0000
tree 8ca746ac6e01d73d6077863cb4edd9225b75d93d
parent 471c75bc08f37c8b0510b6a02d8c1ae5e4ad9a99
parent 6150ebc49db3f966af01941caa16896b0cae480f

Merge "Protect against builds dict changing while we iterate" into feature/zuulv3

zuul/executor/client.py

diff --git a/zuul/executor/client.py b/zuul/executor/client.py
index 0e6544b..2ca69fc 100644
--- a/zuul/executor/client.py
+++ b/zuul/executor/client.py
@@ -445,7 +445,9 @@
 
     def lookForLostBuilds(self):
         self.log.debug("Looking for lost builds")
-        for build in self.builds.values():
+        # Construct a list from the values iterator to protect from it changing
+        # out from underneath us.
+        for build in list(self.builds.values()):
             if build.result:
                 # The build has finished, it will be removed
                 continue