Status: Fix JSHint violations and commit settings
> jquery.zuul.js:19: Use the function form of "use strict".
> jquery.zuul.js:42: 'options' is already defined.
> jquery.zuul.js:619: 'app' is already defined.
> jquery.zuul.js:645: Missing semicolon.
> jquery.zuul.js:900: Missing semicolon.
> jquery.zuul.js:704: 'x' is defined but never used.
> zuul.app.js:22: 'default_layout' is not defined.
> zuul.app.js:37: '$container' is not defined.
> zuul.app.js:38: '$container' is not defined.
> zuul.app.js:38: 'default_layout' is not defined.
> zuul.app.js:20: 'zuul_build_dom' is defined but never used.
> zuul.app.js:42: 'zuul_start' is defined but never used.
Change-Id: I65b86f004ef1bb09651cd916630267ca297b2492
diff --git a/etc/status/public_html/jquery.zuul.js b/etc/status/public_html/jquery.zuul.js
index 40a5d4d..61b25c7 100644
--- a/etc/status/public_html/jquery.zuul.js
+++ b/etc/status/public_html/jquery.zuul.js
@@ -16,9 +16,10 @@
// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
// License for the specific language governing permissions and limitations
// under the License.
-'use strict';
(function ($) {
+ 'use strict';
+
function set_cookie(name, value) {
document.cookie = name + '=' + value + '; path=/';
}
@@ -39,7 +40,7 @@
}
$.zuul = function(options) {
- var options = $.extend({
+ options = $.extend({
'enabled': true,
'graphite_url': '',
'source': 'status.json',
@@ -72,7 +73,7 @@
hideGrid: true,
target: [
"color(stats.gauges.zuul.pipeline." + pipeline_name
- + ".current_changes, '6b8182')"
+ + ".current_changes, '6b8182')"
]
});
}
@@ -616,7 +617,7 @@
var app = {
schedule: function (app) {
- var app = app || this;
+ app = app || this;
if (!options.enabled) {
setTimeout(function() {app.schedule(app);}, 5000);
return;
@@ -642,7 +643,7 @@
this.emit('update-start');
var app = this;
- var $msg = $(options.msg_id)
+ var $msg = $(options.msg_id);
xhr = $.getJSON(options.source)
.done(function (data) {
if ('message' in data) {
@@ -701,7 +702,7 @@
var newimg = new Image();
var parts = url.split('#');
newimg.src = parts[0] + '#' + new Date().getTime();
- $(newimg).load(function (x) {
+ $(newimg).load(function () {
zuul_sparkline_urls[name] = newimg.src;
});
});
@@ -897,5 +898,5 @@
app: app,
jq: $jq
};
- }
+ };
}(jQuery));
diff --git a/etc/status/public_html/zuul.app.js b/etc/status/public_html/zuul.app.js
index 640437b..6321af8 100644
--- a/etc/status/public_html/zuul.app.js
+++ b/etc/status/public_html/zuul.app.js
@@ -17,9 +17,11 @@
// License for the specific language governing permissions and limitations
// under the License.
+/*exported zuul_build_dom, zuul_start */
+
function zuul_build_dom($, container) {
// Build a default-looking DOM
- default_layout = '<div class="container">'
+ var default_layout = '<div class="container">'
+ '<h1>Zuul Status</h1>'
+ '<p>Real-time status monitor of Zuul, the pipeline manager between Gerrit and Workers.</p>'
+ '<div class="zuul-container" id="zuul-container">'
@@ -34,7 +36,7 @@
$(function ($) {
// DOM ready
- $container = $(container);
+ var $container = $(container);
$container.html(default_layout);
});
}