| commit | 3c17d5f351e3d15eef82956eea8c695067a6d4e7 | [log] [tgz] |
|---|---|---|
| author | Tobias Henkel <tobias.henkel@bmw.de> | Thu Aug 03 11:46:54 2017 +0200 |
| committer | Tobias Henkel <tobias.henkel@bmw.de> | Thu Aug 03 19:22:54 2017 +0000 |
| tree | b3c74a573998032d02becfba49a26cb1be6f8755 | |
| parent | eca4620efa07ca1eb8675eba6ec4ab5b6cb35fb2 [diff] |
Remove status handling from FakeGithubConnection The FakeGithubConnection redefines the methods getCommitStatuses and setCommitStatus for test purposes. This implies that the original methods of GithubConnections are untested. This is an attempt to remove these from FakeGithubConnection and pushing the test handling into a FakeGithub object. This way we can do the test handling and at the same time use the original methods of GithubConnection. This also uncovered some test fixtures which are invalid in Github context as there projects require the form <owner>/<project> which is not matched by the 'common-config' which was used in many fixtures. Change-Id: Ib3badca63b77166c1d69332121d78ef05bd899fe
diff --git a/tests/fixtures/config/push-reqs/git/common-config/playbooks/job1.yaml b/tests/fixtures/config/push-reqs/git/org_common-config/playbooks/job1.yaml similarity index 100% rename from tests/fixtures/config/push-reqs/git/common-config/playbooks/job1.yaml rename to tests/fixtures/config/push-reqs/git/org_common-config/playbooks/job1.yaml
diff --git a/tests/fixtures/config/push-reqs/git/common-config/zuul.yaml b/tests/fixtures/config/push-reqs/git/org_common-config/zuul.yaml similarity index 100% rename from tests/fixtures/config/push-reqs/git/common-config/zuul.yaml rename to tests/fixtures/config/push-reqs/git/org_common-config/zuul.yaml
diff --git a/tests/fixtures/config/push-reqs/main.yaml b/tests/fixtures/config/push-reqs/main.yaml index d9f1a42..b58db73 100644 --- a/tests/fixtures/config/push-reqs/main.yaml +++ b/tests/fixtures/config/push-reqs/main.yaml
@@ -3,7 +3,7 @@ source: github: config-projects: - - common-config + - org/common-config untrusted-projects: - org/project1 gerrit: