Merge "Remove -e from requirements" into feature/zuulv3
diff --git a/doc/source/user/config.rst b/doc/source/user/config.rst
index f55fb4f..c4014e2 100644
--- a/doc/source/user/config.rst
+++ b/doc/source/user/config.rst
@@ -952,12 +952,12 @@
A boolean value which indicates whether this job may only be
used in pipelines where :attr:`pipeline.post-review` is
- ``true``. This is automatically set to ``true`` if this job is
- defined in a :term:`untrusted-project`. It may be explicitly
- set to obtain the same behavior for jobs defined in
- :term:`config projects <config-project>`. Once this is set to
- ``true`` anywhere in the inheritance hierarchy for a job, it
- will remain set for all child jobs and variants (it can not be
+ ``true``. This is automatically set to ``true`` if this job
+ uses a :ref:`secret` and is defined in a :term:`untrusted-project`.
+ It may be explicitly set to obtain the same behavior for jobs
+ defined in :term:`config projects <config-project>`. Once this
+ is set to ``true`` anywhere in the inheritance hierarchy for a job,
+ it will remain set for all child jobs and variants (it can not be
set to ``false``).
.. _project:
diff --git a/zuul/executor/server.py b/zuul/executor/server.py
index b22be60..d739c18 100644
--- a/zuul/executor/server.py
+++ b/zuul/executor/server.py
@@ -1225,6 +1225,7 @@
post_status, post_code = self.runAnsiblePlaybook(
playbook, args['timeout'], success, phase='post', index=index)
if post_status != self.RESULT_NORMAL or post_code != 0:
+ success = False
# If we encountered a pre-failure, that takes
# precedence over the post result.
if not pre_failed: