Properly format messages coming out of emitPlaybookBanner
In I7e34206d7968bf128e140468b9a222ecbce3a8f1 we modified how
messages are printed for the playbook banner (and now, footer).
The message wasn't formatted properly due to the lack of assignment.
Additionally, we need to add a line break after these messages,
otherwise the next message starts on the same line.
Change-Id: I808d8908815ffa5fae409e600308dfb9ff9c6e77
diff --git a/zuul/executor/server.py b/zuul/executor/server.py
index 82921fb..f040fd5 100644
--- a/zuul/executor/server.py
+++ b/zuul/executor/server.py
@@ -1759,15 +1759,15 @@
if result is not None:
result = self.RESULT_MAP[result]
msg = "{phase} {step} {result}: [{trusted} : {playbook}@{branch}]"
- msg.format(phase=phase, step=step, result=result,
- trusted=trusted, playbook=playbook, branch=branch)
+ msg = msg.format(phase=phase, step=step, result=result,
+ trusted=trusted, playbook=playbook, branch=branch)
else:
msg = "{phase} {step}: [{trusted} : {playbook}@{branch}]"
- msg.format(phase=phase, step=step, trusted=trusted,
- playbook=playbook, branch=branch)
+ msg = msg.format(phase=phase, step=step, trusted=trusted,
+ playbook=playbook, branch=branch)
with open(self.jobdir.job_output_file, 'a') as job_output:
- job_output.write("{now} | {msg}".format(
+ job_output.write("{now} | {msg}\n".format(
now=datetime.datetime.now(),
msg=msg))