commit dc1470c4e35510664b89658227688344c4a21527
author Michal Vasko <mvasko@cesnet.cz> Wed Nov 18 18:14:40 2020 +0100
committer Radek Krejci <rkrejci@cesnet.cz> Thu Nov 19 08:55:34 2020 +0100
tree ad74f507108413223607bdb3acf49e0435556c65
parent 159b88761d897c78e76f634bc008f8b3576fea19

plugins types BUGFIX empty dynamic value leak

src/plugins_types.c

diff --git a/src/plugins_types.c b/src/plugins_types.c
index 0bb68fc..ca8624d 100644
--- a/src/plugins_types.c
+++ b/src/plugins_types.c
@@ -1311,7 +1311,7 @@
  */
 static LY_ERR
 ly_type_store_empty(const struct ly_ctx *ctx, const struct lysc_type *type, const char *value, size_t value_len,
-        uint32_t UNUSED(options), LY_PREFIX_FORMAT UNUSED(format), void *UNUSED(prefix_data), uint32_t hints,
+        uint32_t options, LY_PREFIX_FORMAT UNUSED(format), void *UNUSED(prefix_data), uint32_t hints,
         const struct lysc_node *UNUSED(ctx_node), struct lyd_value *storage, struct ly_err_item **err)
 {
     /* check hints */
@@ -1328,7 +1328,11 @@
         }
     }
 
-    LY_CHECK_RET(lydict_insert(ctx, "", 0, &storage->canonical));
+    if (options & LY_TYPE_STORE_DYNAMIC) {
+        LY_CHECK_RET(lydict_insert_zc(ctx, (char *)value, &storage->canonical));
+    } else {
+        LY_CHECK_RET(lydict_insert(ctx, value, value_len, &storage->canonical));
+    }
     storage->ptr = NULL;
     storage->realtype = type;