commit dc008d797163c3ac497e83c08768127d1979d975
author Radek Krejci <rkrejci@cesnet.cz> Wed Feb 17 13:12:14 2016 +0100
committer Radek Krejci <rkrejci@cesnet.cz> Wed Feb 17 13:12:14 2016 +0100
tree 905a033a717f8a3e58bc28c19834fb0a15ac1ee9
parent c1ffa4d46f19ad5e6c9e82252a96cdd7ccb959c7

yin parser BUGFIX NULL freed pointer since it is in structure possibly used later

src/parser_yin.c

diff --git a/src/parser_yin.c b/src/parser_yin.c
index b19b6df..be893ab 100644
--- a/src/parser_yin.c
+++ b/src/parser_yin.c
@@ -242,6 +242,7 @@
     struct lys_type_bit bit;
     pcre *precomp;
     int i, j, rc, err_offset;
+    int ret = -1;
     int64_t v, v_;
     int64_t p, p_;
 
@@ -278,8 +279,8 @@
 
     /* the type could not be resolved or it was resolved to an unresolved typedef */
     } else if (rc == EXIT_FAILURE) {
-        lydict_remove(module->ctx, type->module_name);
-        return EXIT_FAILURE;
+        ret = EXIT_FAILURE;
+        goto error;
     }
     type->base = type->der->type.base;
 
@@ -897,8 +898,8 @@
                 type->info.uni.count = 0;
 
                 if (rc == EXIT_FAILURE) {
-                    lydict_remove(module->ctx, type->module_name);
-                    return EXIT_FAILURE;
+                    ret = EXIT_FAILURE;
+                    goto error;
                 }
                 goto error;
             }
@@ -924,8 +925,11 @@
     return EXIT_SUCCESS;
 
 error:
-    lydict_remove(module->ctx, type->module_name);
-    return -1;
+    if (type->module_name) {
+        lydict_remove(module->ctx, type->module_name);
+        type->module_name = NULL;
+    }
+    return ret;
 }
 
 /* logs directly */