commit cb1b7c07ce7e4e5dddd68b3c970d1bdb82b19bd2
author Michal Vasko <mvasko@cesnet.cz> Fri Jul 03 13:38:12 2020 +0200
committer Michal Vasko <mvasko@cesnet.cz> Fri Jul 03 13:38:12 2020 +0200
tree 0da86a78cd49d3aee297328b6dc3581eed05c805
parent 99c71645512e2db270424c117b327c0d4d7ccaa1

xpath MAINTENANCE simplify node replace in moveto_node_hash

src/xpath.c

diff --git a/src/xpath.c b/src/xpath.c
index a096674..0b73a6b 100644
--- a/src/xpath.c
+++ b/src/xpath.c
@@ -5502,7 +5502,6 @@
 {
     LY_ERR ret = LY_SUCCESS;
     uint32_t i;
-    int replaced;
     const struct lyd_node *siblings;
     struct lyd_node *sub, *inst = NULL;
 
@@ -5532,7 +5531,6 @@
     }
 
     for (i = 0; i < set->used; ) {
-        replaced = 0;
         siblings = NULL;
 
         if ((set->val.nodes[i].type == LYXP_NODE_ROOT_CONFIG) || (set->val.nodes[i].type == LYXP_NODE_ROOT)) {
@@ -5560,16 +5558,9 @@
 
         if (sub) {
             /* pos filled later */
-            if (!replaced) {
-                set_replace_node(set, sub, 0, LYXP_NODE_ELEM, i);
-                replaced = 1;
-            } else {
-                set_insert_node(set, sub, 0, LYXP_NODE_ELEM, i);
-            }
+            set_replace_node(set, sub, 0, LYXP_NODE_ELEM, i);
             ++i;
-        }
-
-        if (!replaced) {
+        } else {
             /* no match */
             set_remove_node(set, i);
         }