commit c730448147f5a5d38ef1564d04f19f669bea9699
author Michal Vasko <mvasko@cesnet.cz> Thu Nov 30 15:59:30 2023 +0100
committer Michal Vasko <mvasko@cesnet.cz> Thu Nov 30 15:59:50 2023 +0100
tree 0cb02a1a228ead8de79c30ff005c98604631b42c
parent d108cc52a649c1818309ef4118dc0e5f3947592a

xpath BUGFIX handle input/output name conflicts

Fixes #2137

src/xpath.c

diff --git a/src/xpath.c b/src/xpath.c
index 0843120..06c44df 100644
--- a/src/xpath.c
+++ b/src/xpath.c
@@ -7943,7 +7943,7 @@
         uint32_t name_len, const struct lys_module *moveto_mod, enum lyxp_node_type root_type, LY_VALUE_FORMAT format,
         const struct lysc_node **found)
 {
-    const struct lysc_node *scnode;
+    const struct lysc_node *scnode, *scnode2;
     const struct lys_module *mod;
     uint32_t idx = 0;
 
@@ -7981,7 +7981,19 @@
         }
 
         /* search in children, do not repeat the same search */
-        scnode = lys_find_child(node->schema, moveto_mod, name, name_len, 0, 0);
+        if (node->schema->nodetype & (LYS_RPC | LYS_ACTION)) {
+            /* make sure the node is unique, whether in input or output */
+            scnode = lys_find_child(node->schema, moveto_mod, name, name_len, 0, 0);
+            scnode2 = lys_find_child(node->schema, moveto_mod, name, name_len, 0, LYS_GETNEXT_OUTPUT);
+            if (scnode && scnode2) {
+                /* conflict, do not use hashes */
+                scnode = NULL;
+            } else if (scnode2) {
+                scnode = scnode2;
+            }
+        } else {
+            scnode = lys_find_child(node->schema, moveto_mod, name, name_len, 0, 0);
+        }
     } /* else skip redundant search */
 
     /* additional context check */