commit b1aa77fc5599184b34da6dd4c9f5b1b0602ccf0a
author Jan Kundrát <jan.kundrat@cesnet.cz> Mon Dec 13 15:16:47 2021 +0100
committer Michal Vasko <mvasko@cesnet.cz> Thu Dec 16 12:12:03 2021 +0100
tree 238b11fbf07e156eb19f8720edc7628103e44f97
parent 13ed8125b19bce698e48530502d79fef96597754

Windows: use binary I/O everywhere

...because newlines matter, at least in the test suite, and because
having a stable file format really helps. No LF/CRLF changes for me,
please.

tests/utests/basic/test_inout.c

diff --git a/tests/utests/basic/test_inout.c b/tests/utests/basic/test_inout.c
index 99af939..b3b605f 100644
--- a/tests/utests/basic/test_inout.c
+++ b/tests/utests/basic/test_inout.c
@@ -83,8 +83,8 @@
     assert_int_equal(LY_EINVAL, ly_in_new_file(NULL, NULL));
     assert_null(ly_in_file(NULL, NULL));
 
-    assert_int_not_equal(-1, f1 = fopen(__FILE__, "r"));
-    assert_int_not_equal(-1, f2 = fopen(__FILE__, "r"));
+    assert_int_not_equal(-1, f1 = fopen(__FILE__, "rb"));
+    assert_int_not_equal(-1, f2 = fopen(__FILE__, "rb"));
 
     assert_int_equal(LY_EINVAL, ly_in_new_file(f1, NULL));
 
@@ -203,8 +203,8 @@
     char buf[31] = {0};
     const char *filepath = TESTS_BIN "/libyang_test_output";
 
-    assert_int_not_equal(-1, f1 = fopen(filepath, "w"));
-    assert_int_not_equal(-1, f2 = fopen(filepath, "w"));
+    assert_int_not_equal(-1, f1 = fopen(filepath, "wb"));
+    assert_int_not_equal(-1, f2 = fopen(filepath, "wb"));
 
     /* manipulate with the handler */
     assert_int_equal(LY_SUCCESS, ly_out_new_file(f1, &out));
@@ -218,8 +218,8 @@
     ly_out_free(out, NULL, 1);
 
     /* writing data */
-    assert_int_not_equal(-1, f1 = fopen(filepath, "w"));
-    assert_int_not_equal(-1, f2 = fopen(filepath, "r"));
+    assert_int_not_equal(-1, f1 = fopen(filepath, "wb"));
+    assert_int_not_equal(-1, f2 = fopen(filepath, "rb"));
 
     assert_int_equal(LY_SUCCESS, ly_out_new_file(f1, &out));
     assert_int_equal(LY_SUCCESS, ly_print(out, "test %s", "print"));
@@ -260,7 +260,7 @@
     ly_out_free(out, NULL, 1);
 
     /* writing data */
-    assert_int_not_equal(-1, f1 = fopen(fp1, "r"));
+    assert_int_not_equal(-1, f1 = fopen(fp1, "rb"));
 
     assert_int_equal(LY_SUCCESS, ly_out_new_filepath(fp1, &out));
     assert_int_equal(LY_SUCCESS, ly_print(out, "test %s", "print"));