commit b07b5c9f5467ab5865198d05aee24cc66ae6de7c
author Radek Krejci <rkrejci@cesnet.cz> Mon Apr 08 10:56:37 2019 +0200
committer Radek Krejci <rkrejci@cesnet.cz> Mon Apr 08 10:56:37 2019 +0200
tree e388d339466164433f5a1c815b88c84e6bd3a257
parent e0734d24dde392775ca056045162fb069e434e65

BUGFIX possible NULL pointer dereferences

src/parser_yang.c

diff --git a/src/parser_yang.c b/src/parser_yang.c
index 98c27d2..08b5189 100644
--- a/src/parser_yang.c
+++ b/src/parser_yang.c
@@ -268,6 +268,9 @@
         /* in case of realloc */
         *word_p = *word_b;
     } else if (need_buf) {
+        /* check  valid combination of input paremeters - if need_buf specified, word_b must be provided */
+        assert(word_b);
+
         /* first time we need a buffer, copy everything read up to now */
         if (*word_len) {
             *word_b = malloc(*word_len);

src/tree_schema.c

diff --git a/src/tree_schema.c b/src/tree_schema.c
index cabccb2..07a661d 100644
--- a/src/tree_schema.c
+++ b/src/tree_schema.c
@@ -165,7 +165,7 @@
         goto repeat;
     default:
         /* we should not be here */
-        LOGINT(last->module->ctx);
+        LOGINT(module ? module->mod->ctx : parent->module->ctx);
         return NULL;
     }
 

src/tree_schema_helpers.c

diff --git a/src/tree_schema_helpers.c b/src/tree_schema_helpers.c
index 57c381b..7132f56 100644
--- a/src/tree_schema_helpers.c
+++ b/src/tree_schema_helpers.c
@@ -631,7 +631,7 @@
         /* check revision of the parsed model */
         if (!revs || strcmp(info->revision, revs[0].date)) {
             LOGERR(ctx, LY_EINVAL, "Module \"%s\" parsed with the wrong revision (\"%s\" instead \"%s\").", name,
-                   revs[0].date, info->revision);
+                   revs ? revs[0].date : "none", info->revision);
             return LY_EINVAL;
         }
     }