commit 899c7ce27faa14c93b71638c59a75e1246f1b430
author Michal Vasko <mvasko@cesnet.cz> Fri Feb 18 09:18:37 2022 +0100
committer Michal Vasko <mvasko@cesnet.cz> Fri Feb 18 09:18:37 2022 +0100
tree fb3855da121cadfd9fda5fc5d0fa22fcf1697ac3
parent 59e69e70a2b18c56e3cd249ef43887cfc8ee827b

schema compile BUGFIX duplicate parsed ext child stmt

Fixes #1790

src/schema_compile.h

diff --git a/src/schema_compile.h b/src/schema_compile.h
index 37f69dd..ff41115 100644
--- a/src/schema_compile.h
+++ b/src/schema_compile.h
@@ -120,9 +120,9 @@
  * @param[out] DUP Where to store the result.
  * @param[out] RET Where to store the return code.
  */
-#define DUP_STRING(CTX, ORIG, DUP, RET) if (ORIG) {RET = lydict_insert(CTX, ORIG, 0, &DUP);}
-#define DUP_STRING_RET(CTX, ORIG, DUP) if (ORIG) {LY_ERR __ret = lydict_insert(CTX, ORIG, 0, &DUP); LY_CHECK_RET(__ret);}
-#define DUP_STRING_GOTO(CTX, ORIG, DUP, RET, GOTO) if (ORIG) {LY_CHECK_GOTO(RET = lydict_insert(CTX, ORIG, 0, &DUP), GOTO);}
+#define DUP_STRING(CTX, ORIG, DUP, RET) RET = lydict_insert(CTX, ORIG, 0, &(DUP))
+#define DUP_STRING_RET(CTX, ORIG, DUP) LY_CHECK_RET(lydict_insert(CTX, ORIG, 0, &(DUP)))
+#define DUP_STRING_GOTO(CTX, ORIG, DUP, RET, GOTO) LY_CHECK_GOTO(RET = lydict_insert(CTX, ORIG, 0, &(DUP)), GOTO)
 
 #define DUP_ARRAY(CTX, ORIG_ARRAY, NEW_ARRAY, DUP_FUNC) \
     if (ORIG_ARRAY) { \

src/schema_compile_amend.c

diff --git a/src/schema_compile_amend.c b/src/schema_compile_amend.c
index 2c7d403..b898c0b 100644
--- a/src/schema_compile_amend.c
+++ b/src/schema_compile_amend.c
@@ -32,6 +32,7 @@
 #include "schema_features.h"
 #include "set.h"
 #include "tree.h"
+#include "tree_data_internal.h"
 #include "tree_edit.h"
 #include "tree_schema.h"
 #include "tree_schema_internal.h"
@@ -269,15 +270,46 @@
 }
 
 static LY_ERR
+lysp_ext_children_dup(const struct ly_ctx *ctx, struct lysp_stmt **child, const struct lysp_stmt *orig_child)
+{
+    LY_LIST_FOR(orig_child, orig_child) {
+        /* new child */
+        if (!*child) {
+            *child = calloc(1, sizeof **child);
+            LY_CHECK_ERR_RET(!*child, LOGMEM(ctx), LY_EMEM);
+        } else {
+            (*child)->next = calloc(1, sizeof **child);
+            LY_CHECK_ERR_RET(!(*child)->next, LOGMEM(ctx), LY_EMEM);
+            *child = (*child)->next;
+        }
+
+        /* fill */
+        DUP_STRING_RET(ctx, orig_child->stmt, (*child)->stmt);
+        (*child)->flags = orig_child->flags;
+        DUP_STRING_RET(ctx, orig_child->arg, (*child)->arg);
+        (*child)->format = orig_child->format;
+        LY_CHECK_RET(ly_dup_prefix_data(ctx, orig_child->format, orig_child->prefix_data, &((*child)->prefix_data)));
+        (*child)->kw = orig_child->kw;
+
+        /* recursive children */
+        LY_CHECK_RET(lysp_ext_children_dup(ctx, &(*child)->child, orig_child->child));
+    }
+
+    return LY_SUCCESS;
+}
+
+static LY_ERR
 lysp_ext_dup(const struct ly_ctx *ctx, struct lysp_ext_instance *ext, const struct lysp_ext_instance *orig_ext)
 {
-    LY_ERR ret = LY_SUCCESS;
-
     *ext = *orig_ext;
-    DUP_STRING(ctx, orig_ext->name, ext->name, ret);
-    DUP_STRING(ctx, orig_ext->argument, ext->argument, ret);
+    DUP_STRING_RET(ctx, orig_ext->name, ext->name);
+    DUP_STRING_RET(ctx, orig_ext->argument, ext->argument);
+    ext->parsed = NULL;
 
-    return ret;
+    ext->child = NULL;
+    LY_CHECK_RET(lysp_ext_children_dup(ctx, &ext->child, orig_ext->child));
+
+    return LY_SUCCESS;
 }
 
 static LY_ERR