commit 7c3134db21e82dfde44fd60605a7c3cff9b89327
author Michal Vasko <mvasko@cesnet.cz> Thu Jul 14 10:57:59 2022 +0200
committer Michal Vasko <mvasko@cesnet.cz> Thu Jul 14 10:57:59 2022 +0200
tree 8d3fea61d689d7a34e4152196e9d6e001d299eff
parent 3afafba45d0f85e311a6e00c3d09903bfebc1398

schema compile UPDATE lower status xpath warning from error

In some specific cases (such as using "*[..]")
there could be false-positives that must not
cause the module to fail to load.

Fixes #1876

src/schema_compile.c

diff --git a/src/schema_compile.c b/src/schema_compile.c
index 2c15bb4..d925df2 100644
--- a/src/schema_compile.c
+++ b/src/schema_compile.c
@@ -900,9 +900,11 @@
                 struct lysc_node *schema = tmp_set.val.scnodes[i].scnode;
 
                 /* XPath expression cannot reference "lower" status than the node that has the definition */
-                ret = lysc_check_status(ctx, whens[u]->flags, node->module, node->name, schema->flags, schema->module,
-                        schema->name);
-                LY_CHECK_GOTO(ret, cleanup);
+                if (lysc_check_status(NULL, whens[u]->flags, node->module, node->name, schema->flags, schema->module,
+                        schema->name)) {
+                    LOGWRN(ctx->ctx, "When condition \"%s\" may be referencing %s node \"%s\".", whens[u]->cond->expr,
+                            (schema->flags == LYS_STATUS_OBSLT) ? "obsolete" : "deprecated", schema->name);
+                }
 
                 /* check dummy node children/value accessing */
                 if (lysc_data_parent(schema) == node) {
@@ -975,7 +977,7 @@
         ret = lyxp_atomize(ctx->ctx, musts[u].cond, node->module, LY_VALUE_SCHEMA_RESOLVED, musts[u].prefixes, node,
                 &tmp_set, opts);
         if (ret) {
-            LOGVAL(ctx->ctx, LYVE_SEMANTICS, "Invalid must restriction \"%s\".", musts[u].cond->expr);
+            LOGVAL(ctx->ctx, LYVE_SEMANTICS, "Invalid must condition \"%s\".", musts[u].cond->expr);
             goto cleanup;
         }
 
@@ -984,6 +986,8 @@
         for (i = 0; i < tmp_set.used; ++i) {
             /* skip roots'n'stuff */
             if (tmp_set.val.scnodes[i].type == LYXP_NODE_ELEM) {
+                struct lysc_node *schema = tmp_set.val.scnodes[i].scnode;
+
                 /* XPath expression cannot reference "lower" status than the node that has the definition */
                 if (local_mods[u]->mod == node->module) {
                     /* use flags of the context node since the definition is local */
@@ -992,9 +996,12 @@
                     /* definition is foreign (deviation, refine), always current */
                     flg = LYS_STATUS_CURR;
                 }
-                ret = lysc_check_status(ctx, flg, local_mods[u]->mod, node->name, tmp_set.val.scnodes[i].scnode->flags,
-                        tmp_set.val.scnodes[i].scnode->module, tmp_set.val.scnodes[i].scnode->name);
-                LY_CHECK_GOTO(ret, cleanup);
+                if (lysc_check_status(NULL, flg, local_mods[u]->mod, node->name, schema->flags, schema->module,
+                        schema->name)) {
+                    LOGWRN(ctx->ctx, "Must condition \"%s\" may be referencing %s node \"%s\".", musts[u].cond->expr,
+                            (schema->flags == LYS_STATUS_OBSLT) ? "obsolete" : "deprecated", schema->name);
+                    break;
+                }
             }
         }