tree 899c14845d12938007c5575b81afaa395bcd477e
parent 08fda68c0e0dfe9f5948b96b4c32e8c88a14cae0
author Jan Kundrát <jan.kundrat@cesnet.cz> 1639264209 +0100
committer Michal Vasko <mvasko@cesnet.cz> 1647340602 +0100

MSVC: tests: fix linking with yangobj

This fixes the LNK4217 linker warning. This project for some reasons
creates an object library (`yangobjs` target in CMake) and proceeds to
link tests against that instead of the usual way of linking against
`libyang` the library properly. This is a problem on MSVC because the
tests would normally process the API symbols as `__declspec(dllimport)`,
while at the same time linking the object library with an implementation
of these symbols into the same image. At the same time we cannot simply
set `-DLIBYANG_BUILD` globally because we're *also* building tools such
as `yanglint` which does *not* embed these object files, but links
against `-lyang` normally, and that one needs `__declspec(dllimport)`.

The alternative would be to get rid of the `yangobj` altogether, which
would make the code more straightforward IMHO. That would also make the
previous commit (`MSVC: tests: link with all the compat libraries`)
superfluous because the usual rules of CMake transitive linking of
libraries would take over. However, Michal indicated that the reason of
`yangobj` is that some of these tests are for internal, unexported
functions, which means that `yangobj` will have to stay for now.

See-also: https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4217