commit 29adfbe533cf5f1563e39ee4afb6e8fbf5a5505f
author Michal Vasko <mvasko@cesnet.cz> Tue Dec 08 17:12:03 2020 +0100
committer Radek Krejci <rkrejci@cesnet.cz> Wed Dec 09 11:42:25 2020 +0100
tree 7a69fbfee0a136988420b28ed1c5f55602c74ff1
parent 630d98952f1b35d0a7734f9a691b492ca580bbbf

validation BUGFIX when validating reply, add only output implicit nodes

src/validation.c

diff --git a/src/validation.c b/src/validation.c
index bdfa571..4129446 100644
--- a/src/validation.c
+++ b/src/validation.c
@@ -1251,13 +1251,13 @@
  * @param[in,out] node_types Set for unres node types.
  * @param[in,out] meta_types Set for unres metadata types.
  * @param[in,out] node_when Set for nodes with when conditions.
- * @param[in] val_opts Validation options, see @ref datavalidationoptions.
+ * @param[in] impl_opts Implicit options, see @ref implicitoptions.
  * @param[in,out] diff Validation diff.
  * @return LY_ERR value.
  */
 static LY_ERR
 lyd_validate_subtree(struct lyd_node *root, struct ly_set *node_types, struct ly_set *meta_types,
-        struct ly_set *node_when, uint32_t val_opts, struct lyd_node **diff)
+        struct ly_set *node_when, uint32_t impl_opts, struct lyd_node **diff)
 {
     const struct lyd_meta *meta;
     struct lyd_node *node;
@@ -1279,7 +1279,7 @@
 
             /* add nested defaults */
             LY_CHECK_RET(lyd_new_implicit_r(node, lyd_node_children_p((struct lyd_node *)node), NULL, NULL, NULL,
-                    NULL, val_opts & LYD_VALIDATE_NO_STATE ? LYD_IMPLICIT_NO_STATE : 0, diff));
+                    NULL, impl_opts, diff));
         }
 
         if (!(node->schema->nodetype & (LYS_RPC | LYS_ACTION | LYS_NOTIF)) && node->schema->when) {
@@ -1352,7 +1352,8 @@
 
         /* process nested nodes */
         LY_LIST_FOR(*first2, iter) {
-            ret = lyd_validate_subtree(iter, &node_types, &meta_types, &node_when, val_opts, diff);
+            ret = lyd_validate_subtree(iter, &node_types, &meta_types, &node_when, val_opts & LYD_VALIDATE_NO_STATE
+                    ? LYD_IMPLICIT_NO_STATE : 0, diff);
             LY_CHECK_GOTO(ret, cleanup);
         }
 
@@ -1484,7 +1485,8 @@
     }
 
     /* prevalidate whole operation subtree */
-    LY_CHECK_GOTO(ret = lyd_validate_subtree(op_node, &type_check, &type_meta_check, &when_check, 0, diff), cleanup);
+    LY_CHECK_GOTO(ret = lyd_validate_subtree(op_node, &type_check, &type_meta_check, &when_check,
+            op == LYD_VALIDATE_OP_REPLY ? LYD_IMPLICIT_OUTPUT : 0, diff), cleanup);
 
     /* finish incompletely validated terminal values/attributes and when conditions on the full tree */
     LY_CHECK_GOTO(ret = lyd_validate_unres((struct lyd_node **)&tree, NULL, &when_check, &type_check, &type_meta_check,