commit 28e101a2a45e2fee27708b0958612bb16e7bc980
author aPiecek <piecek@cesnet.cz> Thu Jun 10 09:09:31 2021 +0200
committer Michal Vasko <mvasko@cesnet.cz> Thu Jun 10 13:55:29 2021 +0200
tree c44024d9d6eff24e1c19b8bf0a1248e07ce9a9b2
parent 438b5292dfd85c1111f81d98d4a62436587beb74

json BUGFIX in ::lyjson_number_is_zero()

src/json.c

diff --git a/src/json.c b/src/json.c
index 6ae4484..3e36b0f 100644
--- a/src/json.c
+++ b/src/json.c
@@ -355,8 +355,6 @@
 /**
  * @brief Check if the number can be shortened to zero.
  *
- * The input number must be syntactically valid.
- *
  * @param[in] in Start of input string;
  * @param[in] end End of input string;
  * @return 1 if number is zero, otherwise 0.
@@ -364,13 +362,17 @@
 static ly_bool
 lyjson_number_is_zero(const char *in, const char *end)
 {
-    assert(end >= in);
+    assert(in < end);
 
     if ((in[0] == '-') || (in[0] == '+')) {
         in++;
+        assert(in < end);
     }
     if ((in[0] == '0') && (in[1] == '.')) {
         in += 2;
+        if (!(in < end)) {
+            return 1;
+        }
     }
 
     return lyjson_count_in_row(in, end, '0', 0) == end - in;

tests/utests/basic/test_json.c

diff --git a/tests/utests/basic/test_json.c b/tests/utests/basic/test_json.c
index cabafaa..b2cfafd 100644
--- a/tests/utests/basic/test_json.c
+++ b/tests/utests/basic/test_json.c
@@ -505,6 +505,11 @@
     assert_int_equal(LY_EVALID, lyjson_ctx_new(UTEST_LYCTX, in, &jsonctx));
     CHECK_LOG_CTX("Exponent out-of-bounds in a JSON Number value (1e9999999999999999999).", "Line number 1.");
 
+    str = "-2.1e0.";
+    assert_non_null(ly_in_memory(in, str));
+    assert_int_equal(LY_EVALID, lyjson_ctx_new(UTEST_LYCTX, in, &jsonctx));
+    CHECK_LOG_CTX("Unexpected character \".\" after JSON number.", "Line number 1.");
+
     ly_in_free(in, 0);
 }