instanceid BUGFIX redunant check causing wrong comparison (#2173)
* removed unnecessary check, that s1->predicates not equals to NULL.
It's possible due LY_ARRAY_COUNT can handles NULL pointer by itself.
* before this fix comparison old value without predicate and a new one
with predicate returned LY_SUCCES instead of LY_ENOT
diff --git a/src/plugins_types/instanceid.c b/src/plugins_types/instanceid.c
index c15ff64..e2d01e3 100644
--- a/src/plugins_types/instanceid.c
+++ b/src/plugins_types/instanceid.c
@@ -267,7 +267,7 @@
struct ly_path *s1 = &val1->target[u];
struct ly_path *s2 = &val2->target[u];
- if ((s1->node != s2->node) || (s1->predicates && (LY_ARRAY_COUNT(s1->predicates) != LY_ARRAY_COUNT(s2->predicates)))) {
+ if ((s1->node != s2->node) || (LY_ARRAY_COUNT(s1->predicates) != LY_ARRAY_COUNT(s2->predicates))) {
return LY_ENOT;
}
LY_ARRAY_FOR(s1->predicates, v) {