commit c31b16e5a9fb1cdbc9c0d1e303e37dccf23d8db0
author roman <xjanot04@fit.vutbr.cz> Thu Nov 09 13:42:25 2023 +0100
committer roman <xjanot04@fit.vutbr.cz> Thu Nov 09 13:59:56 2023 +0100
tree 390f2aed5ff13e91b56b90b32f924cdd867f1be2
parent 6dfdc0d104dd2a7ed7737626d2d45ee818205b08

messages client BUGFIX excluded_change null deref

src/messages_client.c

diff --git a/src/messages_client.c b/src/messages_client.c
index bc58b86..f8cc0fb 100644
--- a/src/messages_client.c
+++ b/src/messages_client.c
@@ -698,6 +698,7 @@
 {
     struct nc_rpc_establishpush *rpc;
     uint32_t i;
+    void *tmp;
 
     NC_CHECK_ARG_RET(NULL, datastore, NULL);
 
@@ -737,7 +738,15 @@
     if (excluded_change && (paramtype == NC_PARAMTYPE_DUP_AND_FREE)) {
         rpc->excluded_change = NULL;
         for (i = 0; excluded_change[i]; ++i) {
-            rpc->excluded_change = realloc(rpc->excluded_change, (i + 2) * sizeof *rpc->excluded_change);
+            tmp = realloc(rpc->excluded_change, (i + 2) * sizeof *rpc->excluded_change);
+            if (!tmp) {
+                /* in case we fail to alloc, just free all the excluded changes, but return the rpc anyways */
+                ERRMEM;
+                free(rpc->excluded_change);
+                rpc->excluded_change = NULL;
+                break;
+            }
+            rpc->excluded_change = tmp;
             rpc->excluded_change[i] = strdup(excluded_change[i]);
             rpc->excluded_change[i + 1] = NULL;
         }