commit faacd0226c0dd3f44fd40e3baf77eb3ba840f0f2
author Václav Kubernát <kubernat@cesnet.cz> Wed Jul 08 16:44:38 2020 +0200
committer Václav Kubernát <kubernat@cesnet.cz> Fri Jul 10 11:49:03 2020 +0200
tree b7b936b4583921affec6602c3a6fd312330849d2
parent b94e155b060e461006c616ad7383c1f685b20edb

Get rid of push_back in favor of emplace_back

Change-Id: I4a0096441ed725eb21e42eb9cc17a173929e3788

tests/keyvalue_completion.cpp

diff --git a/tests/keyvalue_completion.cpp b/tests/keyvalue_completion.cpp
index dd826f4..7b28ea8 100644
--- a/tests/keyvalue_completion.cpp
+++ b/tests/keyvalue_completion.cpp
@@ -56,8 +56,7 @@
             "9",
             "42"
         };
-        queryExpectations.push_back(NAMED_REQUIRE_CALL(*mockDatastore, listInstances("/example:list"))
-            .RETURN(queryReturn));
+        queryExpectations.emplace_back(NAMED_REQUIRE_CALL(*mockDatastore, listInstances("/example:list")).RETURN(queryReturn));
     }
 
     SECTION("get example:twoKeyList[number=")
@@ -82,8 +81,7 @@
                 input += "name=";
                 expected = { "'Petr'", "'Honza'"};
             }
-            queryExpectations.push_back(NAMED_REQUIRE_CALL(*mockDatastore, listInstances("/example:twoKeyList"))
-                    .RETURN(queryReturn));
+            queryExpectations.emplace_back(NAMED_REQUIRE_CALL(*mockDatastore, listInstances("/example:twoKeyList")).RETURN(queryReturn));
         }
 
         SECTION("name is set")
@@ -100,7 +98,7 @@
                 expected = { "10", "100" };
             }
             input += "][number=";
-            queryExpectations.push_back(NAMED_REQUIRE_CALL(*mockDatastore, listInstances("/example:twoKeyList"))
+            queryExpectations.emplace_back(NAMED_REQUIRE_CALL(*mockDatastore, listInstances("/example:twoKeyList"))
                     .TIMES(2)
                     .RETURN(queryReturn));
         }
@@ -129,7 +127,7 @@
                 expected = { "'Honza'" };
             }
             input += "][name=";
-            queryExpectations.push_back(NAMED_REQUIRE_CALL(*mockDatastore, listInstances("/example:twoKeyList"))
+            queryExpectations.emplace_back(NAMED_REQUIRE_CALL(*mockDatastore, listInstances("/example:twoKeyList"))
                     .TIMES(2)
                     .RETURN(queryReturn));
         }
@@ -151,7 +149,7 @@
                 input = "get example:twoKeyList[number=123][name='Petr'][";
             }
             // I use ALLOW_CALL here, all this stuff calls it different number of times
-            queryExpectations.push_back(NAMED_ALLOW_CALL(*mockDatastore, listInstances("/example:twoKeyList"))
+            queryExpectations.emplace_back(NAMED_ALLOW_CALL(*mockDatastore, listInstances("/example:twoKeyList"))
                     .RETURN(queryReturn));
         }