commit 59e4ee409e9aff87d1d70dcd0dca3cfd6ff67c02
author Václav Kubernát <kubernat@cesnet.cz> Wed Jul 08 17:32:45 2020 +0200
committer Václav Kubernát <kubernat@cesnet.cz> Fri Jul 10 11:49:03 2020 +0200
tree aa29e2f04f956a77e21c7301df92802851f0d708
parent 1db04ca68a8e199ddd05055270093d63d6d59bcf

Add [[nodiscard]] attribute where meaningful

Mainly functions with zero side effects.

Change-Id: Ie812f9ad67bfd54f13aaae35932a6d00ca80cbd6

src/datastore_access.hpp

diff --git a/src/datastore_access.hpp b/src/datastore_access.hpp
index 5a9cdd1..8ff7658 100644
--- a/src/datastore_access.hpp
+++ b/src/datastore_access.hpp
@@ -30,7 +30,7 @@
 public:
     DatastoreException(const std::vector<DatastoreError>& errors);
     ~DatastoreException() override = default;
-    const char* what() const noexcept override;
+    [[nodiscard]] const char* what() const noexcept override;
 
 private:
     std::string m_what;
@@ -44,7 +44,7 @@
 public:
     using Tree = std::vector<std::pair<std::string, leaf_data_>>;
     virtual ~DatastoreAccess() = 0;
-    virtual Tree getItems(const std::string& path) const = 0;
+    [[nodiscard]] virtual Tree getItems(const std::string& path) const = 0;
     virtual void setLeaf(const std::string& path, leaf_data_ value) = 0;
     virtual void createItem(const std::string& path) = 0;
     virtual void deleteItem(const std::string& path) = 0;
@@ -56,7 +56,7 @@
     virtual void commitChanges() = 0;
     virtual void discardChanges() = 0;
     virtual void copyConfig(const Datastore source, const Datastore destination) = 0;
-    virtual std::string dump(const DataFormat format) const = 0;
+    [[nodiscard]] virtual std::string dump(const DataFormat format) const = 0;
 
 private:
     friend class DataQuery;