commit 117f7b559de23bd13d8c9a2bc92cf01f82a226dd
author Václav Kubernát <kubernat@cesnet.cz> Thu Jan 23 16:10:55 2020 +0100
committer Václav Kubernát <kubernat@cesnet.cz> Mon Jan 27 10:58:41 2020 +0100
tree c5d4a2673e15d75e049289973327b398754da543
parent 395d92c50e2db2bd95ef7e36e4ae4f24d7cb9474

Fix leaf_data completion

Completion for enums and identities was setting m_completionIterator
even though it supplied no new completions.

Issue: https://tree.taiga.io/project/jktjkt-netconf-cli/issue/150
Change-Id: I0f8252bc011b0a6418c1a616521027c784080b9b

src/ast_handlers.hpp

diff --git a/src/ast_handlers.hpp b/src/ast_handlers.hpp
index d99e020..e59fc36 100644
--- a/src/ast_handlers.hpp
+++ b/src/ast_handlers.hpp
@@ -650,12 +650,12 @@
         auto& parserContext = x3::get<parser_context_tag>(context);
         const Schema& schema = parserContext.m_schema;
 
-        parserContext.m_completionIterator = begin;
-
         // Only generate completions if the type is enum so that we don't
         // overwrite some other completions.
-        if (schema.leafType(parserContext.m_tmpListKeyLeafPath.m_location, parserContext.m_tmpListKeyLeafPath.m_node) == yang::LeafDataTypes::Enum)
+        if (schema.leafType(parserContext.m_tmpListKeyLeafPath.m_location, parserContext.m_tmpListKeyLeafPath.m_node) == yang::LeafDataTypes::Enum) {
+            parserContext.m_completionIterator = begin;
             parserContext.m_suggestions = schema.enumValues(parserContext.m_tmpListKeyLeafPath.m_location, parserContext.m_tmpListKeyLeafPath.m_node);
+        }
     }
 };
 
@@ -667,11 +667,11 @@
         auto& parserContext = x3::get<parser_context_tag>(context);
         const Schema& schema = parserContext.m_schema;
 
-        parserContext.m_completionIterator = begin;
-
         // Only generate completions if the type is identityref so that we
         // don't overwrite some other completions.
-        if (schema.leafType(parserContext.m_tmpListKeyLeafPath.m_location, parserContext.m_tmpListKeyLeafPath.m_node) == yang::LeafDataTypes::IdentityRef)
+        if (schema.leafType(parserContext.m_tmpListKeyLeafPath.m_location, parserContext.m_tmpListKeyLeafPath.m_node) == yang::LeafDataTypes::IdentityRef) {
+            parserContext.m_completionIterator = begin;
             parserContext.m_suggestions = schema.validIdentities(parserContext.m_tmpListKeyLeafPath.m_location, parserContext.m_tmpListKeyLeafPath.m_node, Prefixes::WhenNeeded);
+        }
     }
 };

tests/path_completion.cpp

diff --git a/tests/path_completion.cpp b/tests/path_completion.cpp
index f84ae4f..832110d 100644
--- a/tests/path_completion.cpp
+++ b/tests/path_completion.cpp
@@ -185,6 +185,13 @@
             expectedContextLength = 6;
         }
 
+        SECTION("cd example:list[number=")
+        {
+            input = "cd example:list[number=";
+            expectedCompletions = {"number="};
+            expectedContextLength = 7;
+        }
+
         SECTION("cd example:list[number=12")
         {
             input = "cd example:list[number=12";